Timeline



Mar 21, 2011:

11:58 PM Writing Reftests edited by hayato@chromium.org
(diff)
11:29 PM LayoutTestDashboards created by ojan@chromium.org
11:27 PM Changeset in webkit [81648] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Anonymous blocks need isRenderBlock cast check. Also, need
to allow display BOX for flexible boxes.
​https://bugs.webkit.org/show_bug.cgi?id=56709

Test: accessibility/anchor-linked-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): remove specific fix in r81088 which is no longer needed.
  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast check.

2011-03-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when searching up the render tree
for an anchor element in accessibility code.
​https://bugs.webkit.org/show_bug.cgi?id=56709

  • accessibility/anchor-linked-anonymous-block-crash-expected.txt: Added.
  • accessibility/anchor-linked-anonymous-block-crash.html: Added.
11:25 PM WikiStart edited by ojan@chromium.org
(diff)
10:39 PM Changeset in webkit [81647] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
​https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptCore.gyp:
    • Also, remove jsc.cpp from the excluded list because it's not part of the jsc_files variable instead of the javascriptcore_files variable.

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
​https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptGlue.gyp:
10:24 PM Changeset in webkit [81646] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: updating Chromium test expectataions.

  • platform/chromium/test_expectations.txt:
10:21 PM Changeset in webkit [81645] by pfeldman@chromium.org
  • 4 edits in trunk/Tools

2011-03-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81597.
​http://trac.webkit.org/changeset/81597
​https://bugs.webkit.org/show_bug.cgi?id=56801

Change results in lots of unexpected flaky on the dashboard.
(Requested by pfeldman on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:59 PM Changeset in webkit [81644] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-21 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

Add the first reftest so that we can make sure that reftests won't cause
any issues on all buildbots.
This patch will also act as a sample reftest which a Wiki page will refer.

​https://bugs.webkit.org/show_bug.cgi?id=56450

  • fast/harness/font-weight-bold-expected.html: Added.
  • fast/harness/font-weight-bold.html: Added.
9:32 PM Changeset in webkit [81643] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when adjusting position for inline boxes.
​https://bugs.webkit.org/show_bug.cgi?id=56300

  • fast/inline/inline-box-adjust-position-crash-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash.html: Added.
  • fast/inline/inline-box-adjust-position-crash2-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash2.html: Added.

2011-03-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Revert small change made in r78846 of replacing move with positionLineBox
in the adjusting position function for inline box.
​https://bugs.webkit.org/show_bug.cgi?id=56300

The change in r78846 caused positioning line boxes during the step of adjusting
position for inline box, thereby causing line boxes to be nuked. This happens as
part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
Later on, we do the positioning of line boxes again later in that function. This
causes use of removed inline box leading to crash. Also, it is unnecessary to do
this twice.

Tests: fast/inline/inline-box-adjust-position-crash.html

fast/inline/inline-box-adjust-position-crash2.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition):
9:18 PM Changeset in webkit [81642] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.4.0

Merging r81641

9:14 PM Changeset in webkit [81641] by alex
  • 4 edits in trunk

2011-03-21 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
​https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • configure.ac:

2011-03-21 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
​https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • NEWS:
8:35 PM Changeset in webkit [81640] by commit-queue@webkit.org
  • 14 edits
    10 adds in trunk

2011-03-21 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=55644

Note that these tests do not run as part of new-run-webkit-tests,
but rather in Chromium's ui_test. I've run them locally and confirmed
they pass; a subsequent Chromium change will be submitted to run them
on the Chromium build bots.

  • http/tests/filesystem/resources/fs-worker-common.js: Added.
  • http/tests/filesystem/resources/fs-worker-test-util.js: Added. Copied from fast/filesystem/resources for use by HTTP tests.
  • http/tests/filesystem/script-tests/resolve-uri.js: Updated to be used either in window or worker context.
  • http/tests/filesystem/workers/resolve-url-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync.html: Added.
  • http/tests/filesystem/workers/resolve-url.html: Added.
  • http/tests/filesystem/workers/script-tests/TEMPLATE.html: Added.
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added.

2011-03-21 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=55644

Tests: http/tests/filesystem/workers/resolve-url-sync.html

http/tests/filesystem/workers/resolve-url.html

  • fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::readFileSystem): Add support for workers.
  • fileapi/LocalFileSystem.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::resolveLocalFileSystemURL): (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

2011-03-21 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=55644

Pass "create" bool through to allow opening
a filesystem without allowing creation.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker):
  • src/WebWorkerBase.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
  • src/WorkerFileSystemCallbacksBridge.h:
8:28 PM Changeset in webkit [81639] by levin@chromium.org
  • 11 edits in trunk

2011-03-21 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24683

  • http/tests/xmlhttprequest/workers/referer-expected.txt: Fixed expectations now that this works correctly.
  • http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Ditto.

2011-03-21 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24683

Tests: http/tests/xmlhttprequest/workers/referer.html

http/tests/xmlhttprequest/workers/shared-worker-referer.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer. (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto. (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
  • loader/DocumentThreadableLoader.h: Ditto.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
  • loader/ResourceLoadScheduler.h: Ditto.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
  • loader/WorkerThreadableLoader.h:
8:15 PM Changeset in webkit [81638] by commit-queue@webkit.org
  • 2 edits in trunk

2011-03-21 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Add exception handling when PORT was missing.
​https://bugs.webkit.org/show_bug.cgi?id=56728

  • Source/CMakeLists.txt:
8:06 PM Changeset in webkit [81637] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-21 Ilya Sherman <​isherman@chromium.org>

Reviewed by James Robinson.

Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Clients should instead call into WebFormControlElement::isEnabled().
​https://bugs.webkit.org/show_bug.cgi?id=56364

  • public/WebInputElement.h: Removed isEnabledFormControl().
  • src/WebInputElement.cpp: Removed isEnabledFormControl().
7:35 PM Changeset in webkit [81636] by simonjam@chromium.org
  • 6 edits
    1 copy in trunk/LayoutTests

2011-03-21 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline win/linux after r81625.

  • platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/percentage-non-integer-expected.txt.
  • platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.txt:
7:32 PM Changeset in webkit [81635] by Nate Chapin
  • 10 edits
    5 adds in trunk

2011-03-21 Nate Chapin <Nate Chapin>

Reviewed by Brady Eidson.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=38690.

  • http/tests/cache/post-redirect-get-expected.txt: Added.
  • http/tests/cache/post-redirect-get.php: Added.
  • http/tests/cache/post-with-cached-subresources-expected.txt: Added.
  • http/tests/cache/post-with-cached-subresources.php: Added.
  • http/tests/cache/resources/post-image-to-verify.php: Added.

2011-03-21 Nate Chapin <Nate Chapin>

Reviewed by Brady Eidson.

Do not check the DocumentLoader's request cache policy
in determining whether we should force revalidation of a cached
subresource. If the main resource received headers telling it not
to cache, that policy will be propagated to subresources.

The previous behavior is left in behind a flag in Settings, since
QuickLook depends on it.

​https://bugs.webkit.org/show_bug.cgi?id=38690

Tests: http/tests/cache/post-redirect-get.php

http/tests/cache/post-with-cached-subresources.php

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): (WebCore::FrameLoader::loadPostRequest):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseQuickLookResourceCachingQuirks): (WebCore::Settings::useQuickLookResourceCachingQuirks):

2011-03-21 Nate Chapin <Nate Chapin>

Reviewed by Brady Eidson.

Expose a preference to use caching quirks for QuickLook,
and use it if the QuickLook framework is loaded.

​https://bugs.webkit.org/show_bug.cgi?id=38690

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (useQuickLookQuirks): (+[WebPreferences initialize]): (-[WebPreferences useQuickLookResourceCachingQuirks]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
6:17 PM Changeset in webkit [81634] by Martin Robinson
  • 5 edits
    6 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81611

6:15 PM Changeset in webkit [81633] by Martin Robinson
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81536

6:15 PM Changeset in webkit [81632] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-21 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Remove dependency on default font from data-transfer-items.html
​https://bugs.webkit.org/show_bug.cgi?id=56791

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
5:58 PM Changeset in webkit [81631] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Mac release builds after ​https://bugs.webkit.org/show_bug.cgi?id=56783

  • Platform/mac/Logging.mac.mm:
5:50 PM Changeset in webkit [81630] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebCore

Merging r81589

5:49 PM Changeset in webkit [81629] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.4.0/Source

Merging r81587

5:47 PM Changeset in webkit [81628] by beidson@apple.com
  • 3 edits
    3 adds in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.

Reviewed by Brian Weinstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannel):

  • Platform/Logging.h:
  • Platform/mac/Logging.mac.mm: Added.

(WebKit::initializeLogChannel):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize logging if necessary.

  • WebKit2.xcodeproj/project.pbxproj:
5:33 PM Changeset in webkit [81627] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.4.0/Source

Merging 81575

5:29 PM Changeset in webkit [81626] by Martin Robinson
  • 6 edits in releases/WebKitGTK/webkit-1.4.0/Source/JavaScriptCore

Merging 81525

5:24 PM Changeset in webkit [81625] by commit-queue@webkit.org
  • 14 edits in trunk

2011-03-21 Rik Cabanier <​cabanier@gmail.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-21 Rik Cabanier <​cabanier@adobe.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
5:16 PM Changeset in webkit [81624] by abarth@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
​https://bugs.webkit.org/show_bug.cgi?id=56780

The reason we couldn't resolve this warning in the GYP build was that
the normal build disables this warning specifically for this file.
This patch takes the same approach as the previous patch to
WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
(rather than a build system configuration).

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Remove the special-case for this file.
  • gyp/JavaScriptCore.gyp:
    • Remove the work-around for this issue.
  • wtf/Assertions.cpp:
    • Add a pragma disabling this warning for this file.
5:14 PM Changeset in webkit [81623] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add WebCoreExportFileGenerator to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56778

This target mirrors the eponymous target from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • generate-webcore-export-file-generator.sh: Added.
5:11 PM Changeset in webkit [81622] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
​https://bugs.webkit.org/show_bug.cgi?id=56782
<rdar://problem/9151993>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Factored out code for resending an event and moved it to WKView.
  • UIProcess/API/mac/WKView.mm: (-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier to just do that in _resendKeyDownEvent:. (-[WKView keyDown:]): Ditto. (-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we are not already resending an event - it would be too confusing if we ever had to do that, but looks like this never happens.
  • UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.
5:11 PM Changeset in webkit [81621] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn't crash on startup
​https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/JavaScriptCore.gyp:

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn&apos;t crash on startup
​https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/WebCore.gyp:
5:03 PM Changeset in webkit [81620] by dcheng@chromium.org
  • 10 edits in trunk

2011-03-21 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=56330

Update the layout test to take into account that the actual contents of the clipboard
are exposed in a paste via DataTransferItems now.
Also fix the flakiness in the layout test.

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
  • platform/chromium/test_expectations.txt:

2011-03-21 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=56330

Support retrieving clipboard data in a paste through DataTransferItems.

Test: editing/pasteboard/data-transfer-items.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::createFromPasteboard): (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString):
  • platform/chromium/DataTransferItemChromium.h:
  • platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::addPasteboardItem):
  • platform/chromium/DataTransferItemsChromium.h:
4:34 PM Changeset in webkit [81619] by Chris Fleizach
  • 5 edits in trunk/Source

AX: showContextMenu not working in WK2
​https://bugs.webkit.org/show_bug.cgi?id=56734

Reviewed by Darin Adler.

../WebCore:

WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

../WebKit/mac:

Implement showContextMenu() so accessibility related code can call this
independent of whether WK1 or WK2 is running.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::showContextMenu):

4:19 PM Changeset in webkit [81618] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable/disable a GestureReocognizer framework

​https://bugs.webkit.org/show_bug.cgi?id=49345

  • wtf/Platform.h:

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Add Support to WebCore to optionally call a platform-specific gesture recognizer
​https://bugs.webkit.org/show_bug.cgi?id=49345

Added an ability for the EventHandler to invoke an optional platform
specific gesture recognizer.

No tests added because the change should be functionally invisible.

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
  • platform/PlatformGestureRecognizer.cpp: Added. (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::create):
  • platform/PlatformGestureRecognizer.h: Added.

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable a platform specific GestureReocognizer framework in Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=49345

  • features.gypi:
4:11 PM Changeset in webkit [81617] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in fails to load contextual menu
​https://bugs.webkit.org/show_bug.cgi?id=56777
<rdar://problem/8979033>

Open a Carbon resource map and make it the current map when calling NP_Initialize.

  • Platform/Module.cpp: (WebKit::Module::Module): Initialize m_bundleResourceMap to -1.
  • Platform/Module.h: Add m_bundleResourceMap.
  • Platform/mac/ModuleMac.mm: (WebKit::Module::unload): Close the resource map.

(WebKit::Module::bundleResourceMap):
Open a resource map if necessary.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad): Get the resource map and make it current before calling NP_Initialize.
3:56 PM Changeset in webkit [81616] by Martin Robinson
  • 1 edit
    1 add in releases/WebKitGTK/webkit-1.4.0

Adding svnmerge.py metadata file to the release branch

3:56 PM Changeset in webkit [81615] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Plug-in process crashes if it fails to load a plug-in module
​https://bugs.webkit.org/show_bug.cgi?id=56775

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.
3:17 PM Changeset in webkit [81614] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-21 Tony Chang <​tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] remove devtools_html's dependency on WebKit.gypi
​https://bugs.webkit.org/show_bug.cgi?id=56661

We want to depend on the values in the gypi file, not the gypi file
itself. Actually, if someone edits a gypi file, s/he should re-run
gyp to pick up the new dependencies.

It turns out that this doesn't matter much for this target anymore
since we pull the .js dependencies from the inspector html file.

  • WebKit.gyp: cleanup dependencies
  • scripts/generate_devtools_html.py: remove unused param
3:05 PM Changeset in webkit [81613] by dino@apple.com
  • 8 edits
    2 adds in trunk

2011-03-21 Dean Jackson <​dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

AnimationBase had a custom linked-list/self-pointer for keeping
track of animations that needed to be notified of style updates
and start progress. This caused problems when AnimationBase was
destroyed, since the pointer wasn't managed in any way. I replaced
these pointers with HashSets and moved the code that removes animations
from the sets into AnimationControllerPrivate, where it belongs.
CompositeAnimation is also more careful to tell AnimationControllerPrivate
when it no longer needs to keep track of waiting animations.

This should stop the style updates being called on non-active animations
(which was the cause of the state machine error here) and should also
stop a few of the related flakey test failures and occasional crashes.

Test: animations/body-removal-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::~AnimationBase):
  • Remove the linked-list
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::styleAvailable): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::startTimeResponse): (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
  • New method to remove animations from the waiting lists
  • page/animation/AnimationControllerPrivate.h:
  • use a HashSet rather than an AnimationBase* pointer.
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • remove the animations and transitions from the lists when we know they are no longer active (rather than waiting for the AnimationBase to do it when destructing)

2011-03-21 Dean Jackson <​dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

Add a test that triggers the assertion by removing the <body>
element and re-inserting it.

While not directly related to this bug, the
transform-origin-vs-functions test would occasionally fail because it
depended on the order of events being fired. The update to the way
animations are keeping their state triggered this more often. Now the
output is sorted before finishing the test.

  • animations/3d/transform-origin-vs-functions.html:
  • animations/body-removal-crash.html: Added.
  • platform/mac/animations/body-removal-crash-expected.checksum: Added.
  • platform/mac/animations/body-removal-crash-expected.png: Added.
  • platform/mac/animations/body-removal-crash-expected.txt: Added.
2:58 PM Changeset in webkit [81612] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, add flaky and failing tests after r81597.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [81611] by jschuh@chromium.org
  • 5 edits
    6 adds in trunk

2011-03-21 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
​https://bugs.webkit.org/show_bug.cgi?id=56690

  • fast/dom/insertedIntoDocument-child-expected.txt: Added.
  • fast/dom/insertedIntoDocument-child.html: Added.
  • fast/dom/insertedIntoDocument-iframe-expected.txt: Added.
  • fast/dom/insertedIntoDocument-iframe.html: Added.
  • fast/dom/insertedIntoDocument-sibling-expected.txt: Added.
  • fast/dom/insertedIntoDocument-sibling.html: Added.

2011-03-21 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
​https://bugs.webkit.org/show_bug.cgi?id=56690

Tests: fast/dom/insertedIntoDocument-child.html

fast/dom/insertedIntoDocument-iframe.html
fast/dom/insertedIntoDocument-sibling.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument):
2:44 PM Changeset in webkit [81610] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add new files to JavaScriptCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=56766

2:41 PM Changeset in webkit [81609] by commit-queue@webkit.org
  • 10 edits
    7 deletes in trunk/Source

2011-03-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
​http://trac.webkit.org/changeset/81377
​https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • wtf/Vector.h:

2011-03-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
​http://trac.webkit.org/changeset/81377
​https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h:
  • public/WebVector.h: (WebKit::WebVector::operator[]):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp:
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Removed.
  • tests/data/pageserialization/awesome.png: Removed.
  • tests/data/pageserialization/embed_iframe.html: Removed.
  • tests/data/pageserialization/object_iframe.html: Removed.
  • tests/data/pageserialization/simple_iframe.html: Removed.
  • tests/data/pageserialization/simple_page.html: Removed.
  • tests/data/pageserialization/top_frame.html: Removed.
2:39 PM Changeset in webkit [81608] by tony@chromium.org
  • 4 edits
    11 deletes in trunk/LayoutTests

2011-03-21 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Convert fake-drag into a dumpAsText test and remove 1s timeout
​https://bugs.webkit.org/show_bug.cgi?id=56674

This test was added with eventSender, so there was no leapForward
at the time. Also convert to dumpAsText while I'm here.

  • editing/selection/fake-drag.html:
  • platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.png: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.txt:
2:19 PM Changeset in webkit [81607] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: skipping new inspector test on GTK unless harness is fixed.

  • platform/gtk/Skipped:
1:54 PM Changeset in webkit [81606] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix failing tests on the WebKit2 bots.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

1:05 PM Changeset in webkit [81605] by levin@chromium.org
  • 3 edits in trunk/Source/WebCore

SubresourceLoader should expose a way to set the outgoing referer/origin
​https://bugs.webkit.org/show_bug.cgi?id=55903

Reviewed by Adam Barth.

No new tests as no new functionality is exposed.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/SubresourceLoader.h:
1:03 PM Changeset in webkit [81604] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in loads controller at top of movie not bottom
​https://bugs.webkit.org/show_bug.cgi?id=56764
<rdar://problem/8979037>

Create a layer with geometryFlipped set and add the plug-in layer as a sublayer,
matching WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
1:01 PM Changeset in webkit [81603] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-21 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-21 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-21 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
12:57 PM Changeset in webkit [81602] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-21 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs preferences to change security knobs
​https://bugs.webkit.org/show_bug.cgi?id=56762

Add preferences for WebSecurityEnabled, UniversalAccessFromFileURLsAllowed
and FileAccessFromFileURLsAllowed.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebSecurityEnabled): (WKPreferencesGetWebSecurityEnabled): (WKPreferencesSetUniversalAccessFromFileURLsAllowed): (WKPreferencesGetUniversalAccessFromFileURLsAllowed): (WKPreferencesSetFileAccessFromFileURLsAllowed): (WKPreferencesGetFileAccessFromFileURLsAllowed):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:49 PM Changeset in webkit [81601] by commit-queue@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-03-21 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks
​https://bugs.webkit.org/show_bug.cgi?id=56578

Fixed and re-enabled http/tests/inspector/network tests

  • http/tests/inspector/network/network-size.html: Renamed from LayoutTests/http/tests/inspector/network/network-size.html-disabled.
  • http/tests/inspector/network/network-timing.html: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html-disabled.
12:47 PM Changeset in webkit [81600] by commit-queue@webkit.org
  • 18 edits in trunk

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

Restore the expected result before r79953. r79953 changed behavior slightly in function
finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
or after this patch.

  • platform/mac/editing/selection/designmode-no-caret-expected.txt:

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebCore.exp.in:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
  • dom/Node.cpp: (WebCore::Node::isContentEditable):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
  • page/DragController.cpp: (WebCore::DragController::operationForLoad):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::setEditable): (WebCore::Page::isEditable):

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_editable): (webkit_web_view_set_editable):

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]):

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • Api/qwebpage.cpp: (QWebPage::setContentEditable): (QWebPage::isContentEditable):

2011-03-21 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
​https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebFrame.cpp: (wxWebFrame::MakeEditable): (wxWebFrame::IsEditable):
12:37 PM Changeset in webkit [81599] by ericu@chromium.org
  • 8 edits in trunk/Source

2011-03-21 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
​https://bugs.webkit.org/show_bug.cgi?id=56704

  • fileapi/DOMFileSystemSync.cpp (DOMFileSystemSync::createFile) (class GetPathHelper): Added, to look up path before creating File.
  • fileapi/DOMFileSystem.cpp (DOMFileSystem::createFile) (GetPathCallback): Added, to look up path before creating File.
  • platform/FileMetadata.h (struct FileMetadata): Added new field platformPath.

2011-03-21 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
​https://bugs.webkit.org/show_bug.cgi?id=56704

  • src/WebFileSystemCallbacksImpl.cpp: (WebFileSystemCallbacksImpl::didReadMetadata) Pass new platformPath member through.
  • src/WorkerFileSystemCallbacksBridge.cpp: (CrossThreadCopierBase) Copy new platformPath member.
  • public/WebFileInfo.h: (struct WebFileInfo) Add new platformPath member.
12:28 PM Changeset in webkit [81598] by Adam Roben
  • 2 edits in trunk/Tools

Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file

Fixes <​http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
to the master.
(RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
since we're running on the build master, not the slave. Instead, turn the raw source of
actual.html which the build slave uploaded into an HTML log.

12:10 PM Changeset in webkit [81597] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-03-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: run tests in ascending alphabetical order per dir
​https://bugs.webkit.org/show_bug.cgi?id=56760

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
12:08 PM Changeset in webkit [81596] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-21 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
​https://bugs.webkit.org/show_bug.cgi?id=56458

Enabling the feature by default for chromium builds.

  • features.gypi:

2011-03-21 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
​https://bugs.webkit.org/show_bug.cgi?id=56458

Adding options to enable the media stream API feature in Chromium.

  • Scripts/build-webkit:
12:05 PM Changeset in webkit [81595] by jamesr@google.com
  • 2 edits in branches/chromium/696/LayoutTests

Merge 81538 - 2011-03-18 James Robinson <​jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:

TBR=​jamesr@google.com

11:41 AM Changeset in webkit [81594] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove old DrawingArea and LayerHostingView code from WKView.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):
(-[WKView hitTest:]):
(-[WKView WebKit::]):

11:33 AM Changeset in webkit [81593] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-21 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Need WebKit2 API for creating a page with a specific main frame name
​https://bugs.webkit.org/show_bug.cgi?id=56759

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h: Add mainFrameName to creation parameters.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:]): (-[WKView initWithFrame:contextRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:mainFrameName:]): Add new initializer which takes a main frame name.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMainFrameName): (WebKit::WebPageProxy::creationParameters):
  • UIProcess/WebPageProxy.h: Store the main frame name for initialization/re-initialization.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::createMainFrame):
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Pass the name to main frame creation.
11:20 AM Changeset in webkit [81592] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-21 Dominic Cooney <​dominicc@google.com>

Reviewed by Jeremy Orlow.

Adds a regression test for MediaQueryList listener callbacks in V8.
​https://bugs.webkit.org/show_bug.cgi?id=56166

  • fast/media/media-query-list-callback-expected.txt: Added.
  • fast/media/media-query-list-callback.html: Added.
  • fast/media/resources/media-query-list-callback-frame.html: Added.

2011-03-21 Dominic Cooney <​dominicc@google.com>

Reviewed by Jeremy Orlow.

Establishes a V8 context before executing MediaQueryList callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=56166

MediaQueryList listener callbacks didn't establish a V8 context
before running script, causing crashes on C++-only
callstacks (such as user resizing, printing, etc.) I believe this
could also be contrived to execute media query list listener
callbacks across domain.

Test: fast/media/media-query-list-callback.html

  • css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged):
10:25 AM Changeset in webkit [81591] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Add QNetworkReplyHandler::wasAborted()

Instead of checking if the ResourceHandle is null everywhere,
use a wasAborted() method to make the code readable.

  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyHandler::wasAborted):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::uploadProgress):
10:11 AM Changeset in webkit [81590] by Chris Fleizach
  • 2 edits
    1 delete in trunk/LayoutTests

platform/mac/accessibility/aria-table-with-colspan-cells.html is failing on the Leopard Release tester
​https://bugs.webkit.org/show_bug.cgi?id=56523

Reviewed by Darin Adler.

List and table functionality is not present on Leopard and should be skipped.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/platform/mac/accessibility: Removed.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Removed.
10:11 AM Changeset in webkit [81589] by christian@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
​https://bugs.webkit.org/show_bug.cgi?id=56201

Reviewed by Martin Robinson.

  • platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf

if there is no image.

9:40 AM Changeset in webkit [81588] by qi.2.zhang@nokia.com
  • 4 edits in trunk/Tools

2011-03-21 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=56323

Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
"--stdout" or "--stderr" option.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::processArgsLine): (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setRedirectOutputFileName): (WebCore::DumpRenderTree::setRedirectErrorFileName):
  • DumpRenderTree/qt/main.cpp: (isOption): (takeOptionValue): (printUsage): (main):
9:32 AM Changeset in webkit [81587] by mario@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
​https://bugs.webkit.org/show_bug.cgi?id=56737

Only consider parent objects not ignoring accessibility.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: (webkitAccessibleHyperlinkGetStartIndex): Look for the parent object not ignoring accessibility for the current hyperlink. (webkitAccessibleHyperlinkGetEndIndex): Ditto.

2011-03-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
​https://bugs.webkit.org/show_bug.cgi?id=56737

  • tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also check offsets for hyperlinks inside <span> nodes.
9:18 AM WebKitGTK edited by Martin Robinson
(diff)
9:14 AM Changeset in webkit [81586] by Adam Roben
  • 2 edits in trunk/Tools

Fix exceptions on the buildbot due to my last change

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.

9:00 AM Changeset in webkit [81585] by Adam Roben
  • 2 edits in trunk/Tools

Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file

Fixes <​http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
logs.
(RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
the build master. This will correctly treat it as HTML.

8:49 AM Changeset in webkit [81584] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove handling of QNetworkAccessManager::UnknownOperation

Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
Custom verb requests are using CustomOperation already, so this was dead code.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::start):
8:41 AM Changeset in webkit [81583] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Fix multiple-definition linker warnings on Windows

  • WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is

already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
file.

8:28 AM Changeset in webkit [81582] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Clean up QNetworkReplyHandler::release()

Since QNetworkReplyHandler no longer uses queued connections to
the QNetworkReply, it's not necessary to mess with the event
queue when releasing a reply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
8:19 AM Changeset in webkit [81581] by Adam Roben
  • 3 edits in trunk/LayoutTests

Skip another asserting animations test

<​http://webkit.org/b/56488> tracks the failure

  • platform/mac/Skipped:
  • platform/win/Skipped:
8:06 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
7:40 AM Changeset in webkit [81580] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk

2011-03-21 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
​https://bugs.webkit.org/show_bug.cgi?id=56691

Added a test for transfer size for chunked encoding type.

  • http/tests/inspector/network/network-size-chunked.html: Added.
  • http/tests/inspector/network/network-size-expected-chunked.txt: Added.
  • http/tests/inspector/network/resources/resource.php:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-21 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
​https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

Test: http/tests/inspector/network/network-size-chunked.html

  • inspector/Inspector.idl:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.increaseTransferSize):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::forwardData):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer):

2011-03-21 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
​https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
7:36 AM Changeset in webkit [81579] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

2011-03-21 Hao Zheng <​zhenghao@google.com>

Reviewed by Darin Adler.

Bug 15713: Rollout r72533 completely.
​https://bugs.webkit.org/show_bug.cgi?id=15713

r72599 only rolled out the checksum files, which caused mismatch
between checksum and png. Some png files had been
rolled out by some other changes, so rollout the remaining png.

  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-linux/fast/doctypes/002-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-expected.png:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/lists/007-vertical-expected.png:
  • platform/chromium-linux/fast/lists/008-vertical-expected.png:
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/doctypes/002-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-expected.png:
  • platform/chromium-win/fast/lists/003-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
7:21 AM Changeset in webkit [81578] by krit@webkit.org
  • 5 edits
    36 adds in trunk

2011-03-21 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
​https://bugs.webkit.org/show_bug.cgi?id=54538

SVG spec: ​http://www.w3.org/TR/SVG/struct.html#UseElement
Quotation for referenced <symbol>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these attributes will be transferred to the generated 'svg'."
Quotation for referenced <svg>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these values will override the corresponding attributes
on the 'svg' in the generated tree."
For above quotations, we should treat 'use' element as referencing
'use' element, just like Firefox 3.6 and Opera 11, instead of
corrensponding 'use' element.

Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg

svg/custom/use-transfer-width-height-properties-to-svg1.svg
svg/custom/use-transfer-width-height-properties-to-svg2.svg
svg/custom/use-transfer-width-height-properties-to-symbol.svg
svg/custom/use-transfer-width-height-properties-to-symbol1.svg
svg/custom/use-transfer-width-height-properties-to-symbol2.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::SVGElementInstance):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::create): (WebCore::SVGElementInstance::correspondingUseElement): (WebCore::SVGElementInstance::directUseElement): (WebCore::SVGElementInstance::clearUseElements):
  • svg/SVGUseElement.cpp: (WebCore::updateContainerSize): (WebCore::SVGUseElement::updateContainerSizes): (WebCore::dumpInstanceTree): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::buildInstanceTree):

2011-03-21 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
​https://bugs.webkit.org/show_bug.cgi?id=54538

Test cases for transfering width/height properties from
'use' element to 'svg' and 'symbol' elements.
See: ​http://www.w3.org/TR/SVG/struct.html#UseElement

  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2.svg: Added.
6:54 AM Changeset in webkit [81577] by loki@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Extend constant pool to be able to store 16 bit instructions with a constant
​https://bugs.webkit.org/show_bug.cgi?id=46796

Reviewed by Csaba Osztrogonác.

The putShortWithConstantInt function inserts a 16 bit instruction which
refers a 32 bits constant or literal. This is a vital function for those
target which loads a PC relative value with a 16 bit instruction (like
Thumb-2 instruction set and SH4 architecture).

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):

  • assembler/AssemblerBufferWithConstantPool.h:
3:53 AM Changeset in webkit [81576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-21 Jaehun Lim <​ljaehun.lim@samsung.com>

Reviewed by Pavel Feldman.

Fix build break when inspector is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=56735

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).
2:33 AM Changeset in webkit [81575] by Philippe Normand
  • 4 edits in trunk/Source

2011-03-21 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK distcheck build fix.

  • GNUmakefile.am:
1:20 AM Changeset in webkit [81574] by jchaffraix@webkit.org
  • 3 edits in trunk

2011-03-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

  • fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
  • fast/css/webkit-empty-transform-preserve3d-crash.html: Added.

2011-03-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

Test: fast/css/webkit-empty-transform-preserve3d-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the rest of the code and check that the RenderBox has a layer to avoid crashing on the layer() call.
12:56 AM Changeset in webkit [81573] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move cookie processing and appcache from DOMAgent.js
​https://bugs.webkit.org/show_bug.cgi?id=56713

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  • inspector/front-end/CookieItemsView.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.buildCookiesFromString): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.eventListeners):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update):
12:54 AM Changeset in webkit [81572] by pfeldman@chromium.org
  • 29 edits in trunk/Source/WebCore

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector.json to valid JSON types.
​https://bugs.webkit.org/show_bug.cgi?id=56651

This change migrates inspector from long to int as
dom, storage, database and other id types.

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightDOMNode):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::addRule): (WebCore::InspectorCSSAgent::elementForId):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::bind): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::loadEventFired): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::characterDataModified): (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults): (WebCore::InspectorDOMAgent::copyNode): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h: (WebCore::InspectorDOMStorageResource::id):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseId): (WebCore::InspectorDatabaseAgent::databaseForId):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::id):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::setInitialContent): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket):
  • inspector/generate-inspector-idl:
12:44 AM Changeset in webkit [81571] by pfeldman@chromium.org
  • 9 edits in trunk

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
​https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/report-protocol-errors-expected.txt:

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
​https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightFrame):
  • inspector/InspectorAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::pointerAsId): (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrame): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::frameForId): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
12:42 AM Changeset in webkit [81570] by pfeldman@chromium.org
  • 27 edits in trunk

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=56681

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpCallArguments):
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=56681

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::inspect):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::releaseObject):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::releaseObjectGroup):
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.inspect):
12:24 AM Changeset in webkit [81569] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-21 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaselined Chromium expectations.

  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt: Added.

Mar 20, 2011:

10:59 PM Changeset in webkit [81568] by pfeldman@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-03-20 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: removing stale Chromium expectations.

  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Removed.
4:30 PM Changeset in webkit [81567] by levin@chromium.org
  • 60 edits
    4 moves in trunk

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • API/JSClassRef.h:
  • API/OpaqueJSString.h:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Atomics.h:
  • wtf/CMakeLists.txt:
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::crossThreadCopy):
  • wtf/ThreadSafeRefCounted.h: Copied from wtf/ThreadSafeShared.h. (WTF::ThreadSafeRefCountedBase::ThreadSafeRefCountedBase): (WTF::ThreadSafeRefCountedBase::ref): (WTF::ThreadSafeRefCountedBase::refCount): (WTF::ThreadSafeRefCountedBase::derefBase): (WTF::ThreadSafeRefCounted::ThreadSafeRefCounted):
  • wtf/ThreadSafeShared.h: Removed.
  • wtf/Threading.h:

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • gyp/JavaScriptGlue.gypi:

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • bindings/v8/SerializedScriptValue.h:
  • dom/Document.cpp:
  • dom/default/PlatformMessagePortChannel.h:
  • fileapi/FileThread.h:
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::create): (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didSendData): (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse): (WebCore::ThreadableLoaderClientWrapper::didReceiveData): (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  • page/SecurityOrigin.h:
  • platform/CrossThreadCopier.h:
  • platform/network/BlobData.h:
  • platform/network/cf/SocketStreamHandle.h:
  • storage/AbstractDatabase.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseCallback.h:
  • storage/DatabaseThread.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/SQLError.h:
  • storage/SQLResultSet.h:
  • storage/SQLStatement.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • workers/DefaultSharedWorkerRepository.cpp:

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • Platform/CoreIPC/Connection.h:
  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/ThreadLauncher.h:

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • src/PlatformMessagePortChannel.h:
  • src/WebWorkerBase.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.h:

2011-03-20 Bill Budge <​bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
​https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • Scripts/do-webcore-rename:
3:25 PM Changeset in webkit [81566] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add http/tests/appcache/origin-delete.html to the Skipped list for WebKit2,
since layoutTestController.clearAllApplicationCaches is not yet implemented
by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
1:07 PM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:40 PM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:32 PM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:31 PM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
3:25 AM Changeset in webkit [81565] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-20 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean up redirection logic in QNetworkReplyHandler
​https://bugs.webkit.org/show_bug.cgi?id=56717

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Use resetState() when constructing QNRH as well.

(WebCore::QNetworkReplyHandler::resetState):
Delete (deferred) the m_reply if one exists (only when redirecting.)

(WebCore::QNetworkReplyHandler::finish):
Return early when redirecting.

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
Move the redirection logic from sendResponseIfNeeded() into a
separate redirect() method.

Mar 19, 2011:

8:39 PM Changeset in webkit [81564] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Dan Bernstein.

Add stub to LayoutTestControllerGtk.cpp to fix GTK build
​https://bugs.webkit.org/show_bug.cgi?id=56719

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
5:57 PM Changeset in webkit [81563] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove StringImpl::computeHash()
​https://bugs.webkit.org/show_bug.cgi?id=49894

Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.

  • wtf/text/AtomicString.cpp: (WTF::CStringTranslator::hash): (WTF::UCharBufferTranslator::hash): (WTF::HashAndCharactersTranslator::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::setHash): (WTF::StringImpl::hash):
3:36 PM Changeset in webkit [81562] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()

The function doesn't ignore anything, thus it shouldn't have an imperative name.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::shouldIgnoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3:18 PM Changeset in webkit [81561] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Kill layer violation FIXME in ResourceHandleQt.

We were including qwebframe_p.h from WebKit/qt for no reason.

  • platform/network/qt/ResourceHandleQt.cpp:
3:15 PM Changeset in webkit [81560] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Refactor handling of deferred loads
​https://bugs.webkit.org/show_bug.cgi?id=56715

Split QNetworkReplyHandler's "load mode" into two parameters
instead of trying to fit the deferral mechanism into it.

Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadingDeferred): (WebCore::QNetworkReplyHandler::resumeDeferredLoad): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::resetState):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::platformSetDefersLoading):
3:08 PM Changeset in webkit [81559] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

3:07 PM Changeset in webkit [81558] by mrowe@apple.com
  • 1 copy in tags/Safari-533.21.1

New tag.

2:28 PM Changeset in webkit [81557] by commit-queue@webkit.org
  • 26 edits
    4 adds in trunk

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

This test creates an Application Cache for the DRT origin, deletes it for the origin,
and verifies that the Application Cache has obsolete status.

  • http/tests/appcache/origin-delete-expected.txt: Added.
  • http/tests/appcache/origin-delete.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

To delete all Application Cache for an origin, we must obsolete all
in-memory cache groups for that origin. If a cache group isn't in memory,
then it must be deleted from disk. The previous implementation correctly
removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
when the DocumentLoader was destroyed.

Test: http/tests/appcache/origin-delete.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::clearStorageID): (WebCore::ApplicationCache::deleteCacheForOrigin):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

Use new ApplicationCache API to delete all cache for an origin.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteOrigin:]):

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin instead of ApplicationCacheStorage::deleteEntriesForOrigin. (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):

2011-03-19 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
​https://bugs.webkit.org/show_bug.cgi?id=56415

  • DumpRenderTree/LayoutTestController.cpp: (clearApplicationCacheForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs. (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
1:11 PM Changeset in webkit [81556] by gyuyoung.kim@samsung.com
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-03-19 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy GeolocationServiceEfl. cpp | h
​https://bugs.webkit.org/show_bug.cgi?id=56710

Add dummy GeolocationServiceEfl.cpp | h to platform/efl.

  • CMakeListsEfl.txt:
  • platform/efl/GeolocationServiceEfl.cpp: Added. (WebCore::GeolocationServiceEfl::create): (WebCore::GeolocationServiceEfl::GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::startUpdating): (WebCore::GeolocationServiceEfl::stopUpdating): (WebCore::GeolocationServiceEfl::suspend): (WebCore::GeolocationServiceEfl::resume): (WebCore::GeolocationServiceEfl::lastPosition): (WebCore::GeolocationServiceEfl::lastError):
  • platform/efl/GeolocationServiceEfl.h: Added.
1:09 PM Changeset in webkit [81555] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Unreviewed, rolling out r81551.
​http://trac.webkit.org/changeset/81551
​https://bugs.webkit.org/show_bug.cgi?id=55336

Broke some storage tests on Win32.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
12:22 PM Changeset in webkit [81554] by simonjam@chromium.org
  • 3 edits
    6 deletes in trunk/LayoutTests

2011-03-19 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81528.

  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
12:07 PM Changeset in webkit [81553] by andreas.kling@nokia.com
  • 18 edits in trunk/Source

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
​https://bugs.webkit.org/show_bug.cgi?id=56712

  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::positionUpdated):

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
​https://bugs.webkit.org/show_bug.cgi?id=56712

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::selectionRectForSimpleText):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::paint):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::DnsPrefetchHelper): (WebCore::DnsPrefetchHelper::lookup):
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaSliderTrack):
11:35 AM Changeset in webkit [81552] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-19 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
​https://bugs.webkit.org/show_bug.cgi?id=56711

Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
ownership of the reply is transferred to the receiving slot.

  • Api/qwebpage.cpp:
10:55 AM Changeset in webkit [81551] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use Win32 API to get file information
​https://bugs.webkit.org/show_bug.cgi?id=55336

Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
and GetFileAttributesEx() so we can share the code with WinCE.

  • platform/win/FileSystemWin.cpp: (WebCore::createFileHandle): (WebCore::getFileInformation): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
7:25 AM Changeset in webkit [81550] by xan@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-19 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify GObjectEventListener
​https://bugs.webkit.org/show_bug.cgi?id=56698

Get rid of special case for DOMWindow, since it's also an
EventTarget.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): remove DOMWindow special casing. (WebCore::GObjectEventListener::~GObjectEventListener): ditto. (WebCore::GObjectEventListener::gobjectDestroyed):
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): ditto. (WebCore::GObjectEventListener::removeEventListener): ditto.
6:08 AM Changeset in webkit [81549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-19 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=56195
Fix conditional which had an int for one case and a pointer for another.
Similar fix as ​https://bugs.webkit.org/show_bug.cgi?id=56198

No new tests. Fix compilation on Solaris 10 with Sun Studio C++

  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
4:42 AM Changeset in webkit [81548] by Patrick Gansterer
  • 26 edits in trunk/Source

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
​https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
  • wtf/StringHasher.h: (WTF::StringHasher::computeHash): (WTF::StringHasher::hashMemory):
  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):

2011-03-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
​https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents):
  • dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):

Mar 18, 2011:

9:52 PM Changeset in webkit [81547] by mitz@apple.com
  • 3 edits in trunk/Tools

Revised build fix for r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
8:58 PM Changeset in webkit [81546] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/56688> Fix clang static analyzer warning in WebCoreViewFactory.m

Reviewed by Anders Carlsson.

Fixes the following static analyzer warning:

Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]'

return self;

  • page/mac/WebCoreViewFactory.m:

(-[WebCoreViewFactory init]): Assign the result of [super init]
to self.

7:18 PM Changeset in webkit [81545] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the WinCairo build.

  • win/WebKit2.vcproj:
7:17 PM Changeset in webkit [81544] by jamesr@google.com
  • 206 edits
    2 adds in trunk/LayoutTests

2011-03-18 James Robinson <​jamesr@chromium.org>

Update chromium win pixel baselines for tests with justified text for r81528

  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-win/css1/text_properties/text_align-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.checksum:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.checksum:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.checksum:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.checksum:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.checksum:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.checksum:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.checksum:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.checksum:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum:
  • platform/chromium-win/svg/text/bidi-tspans-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [81543] by cevans@google.com
  • 7 edits in branches/chromium/696

Merge 81399
BUG=74653

6:04 PM Changeset in webkit [81542] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/696

Merge 81088
BUG=75347

6:02 PM Changeset in webkit [81541] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/696

Merge 80773
BUG=75347

5:51 PM Changeset in webkit [81540] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build
​https://bugs.webkit.org/show_bug.cgi?id=56696

After this patch, the WebCore GYP build successfully compiles and
links. I haven't trying executing it yet.

  • WebCore.gypi:
    • DOMMouseEvent should be included as part of the Objective-C bindings.
  • WebCore.xcodeproj/project.pbxproj:
    • RenderSVGPath.cpp was mistakenly included directly in the project instead of being built by RenderSVGAllInOne.
  • gyp/WebCore.gyp:
    • Exclude some more files from the build. These files are absent in the normal build. I didn't see them earlier because the dead code stripping was hiding them. (They're probably unreferenced.)
    • Switch to using RenderSVGAllInOne. I'm not entirely sure if this part of the patch is necessary, but it matches the normal build more closely.
  • platform/mac/WebCoreObjCExtras.mm:
    • The normal build passes the -Wdeprecated-declarations flag when compiling this file. The GYP folks explicitly do not want to add that feature to GYP, and there does not appear to be a way to remove the deprecated call from this file.
  • rendering/svg/RenderSVGAllInOne.cpp:
    • Add RenderSVGPath.cpp, which was missing previously.
5:48 PM Changeset in webkit [81539] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should (almost!) link
​https://bugs.webkit.org/show_bug.cgi?id=56689

This patch is a grab-bag of small changes to bring the WebCore GYP
build down to two link errors or one compile error (take your pick).
We might need a GYP change to get this last file to compile, however.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
5:31 PM Changeset in webkit [81538] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-03-18 James Robinson <​jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [81537] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
​https://bugs.webkit.org/show_bug.cgi?id=56505

Added a test to edit contents of hr and datagrid and object's fallback content.

  • editing/editability/ignored-content-expected.txt: Added.
  • editing/editability/ignored-content.html: Added.

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
​https://bugs.webkit.org/show_bug.cgi?id=56505

The bug was caused by canHaveChildrenForEditing's always returning false even when
object element used fallback content. Fixed the bug by adding a check.

Test: editing/editability/ignored-content.html

  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
5:05 PM Changeset in webkit [81536] by aestes@apple.com
  • 5 edits
    2 adds in trunk

2011-03-18 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
​https://bugs.webkit.org/show_bug.cgi?id=56380

  • fast/parser/fragment-foreign-content-context-expected.txt: Added.
  • fast/parser/fragment-foreign-content-context.html: Added.

2011-03-18 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
​https://bugs.webkit.org/show_bug.cgi?id=56380


Fix two issues with parsing a fragment that has a foreign content
element as its context element. The first issue is that the parser will
initially be in the InForeignContentMode insertion mode when processing
the first tag in the fragment in this case so one call site needs to
change from currentElement() to currentNode(). The second issue is that
when we changed fragments from using a fake HTML root element to a
DocumentFragment we broke checks that assumed the root element was in
the HTML namespace. Fix this by claiming that the DocumentFragment is
also in the HTML namespace.

Test: fast/parser/fragment-foreign-content-context.html

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
  • html/parser/HTMLElementStack.h: (WebCore::isInHTMLNamespace):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag):
4:36 PM Changeset in webkit [81535] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Empty gray page after going back from a PDF
​https://bugs.webkit.org/show_bug.cgi?id=56694
<rdar://problem/8811854>

Update m_frameHasCustomRepresentation when loading a page that's in the page cache.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
4:36 PM Changeset in webkit [81534] by mrowe@apple.com
  • 2 edits in branches/safari-533.21-branch/WebCore

Merge r80787.

4:36 PM Changeset in webkit [81533] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.21-branch

Merge r79689.

4:30 PM Changeset in webkit [81532] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-18 Martin Robinson <​mrobinson@igalia.com>

[GTK] JSC crashes in 32bit Release bots after r80743
​https://bugs.webkit.org/show_bug.cgi?id=56180

  • platform/gtk/Skipped: Unskip tests which should now be passing since this bug is fixed.
4:24 PM Changeset in webkit [81531] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Windows Release Tests] media tests crashing in QuickTime on apple-windows-8.
​https://bugs.webkit.org/show_bug.cgi?id=56653

Unreviewed, skipping media/video-load-readyState.html since that has been crashing
on the last 3 runs.

  • platform/win-wk2/Skipped:
4:19 PM Changeset in webkit [81530] by jamesr@google.com
  • 4 edits in branches/chromium/696

Merge 81528 - 2011-03-18 James Robinson <​jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
​https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):

TBR=​jamesr@google.com
BUG=75169

4:15 PM Changeset in webkit [81529] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

4:14 PM Changeset in webkit [81528] by jamesr@google.com
  • 4 edits in trunk

2011-03-18 James Robinson <​jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
​https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
4:11 PM Changeset in webkit [81527] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:08 PM Changeset in webkit [81526] by Lucas Forschler
  • 1 copy in tags/Safari-534.26

New tag.

4:07 PM Changeset in webkit [81525] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-03-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

[GTK] JSC crashes in 32bit Release bots after r80743
​https://bugs.webkit.org/show_bug.cgi?id=56180


The crash was caused by referencing GC memory from a GC destructor. This
is not safe because destruction time / order is not guaranteed.

  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::create): (JSC::ProfileGenerator::ProfileGenerator): (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
  • profiler/ProfileGenerator.h: (JSC::ProfileGenerator::origin): Made ExecState* the first argument, to match the rest of this class and JSC.


Use a JSGlobalObject* instead of an ExecState* with an indirect reference
to a JSGlobalObject* to track our origin. This is simpler and more
efficient, and it removes the destruction order dependency that was causing
our crash.

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): Updated for change to JSGlobalObject*. (JSC::Profiler::stopProfiling): New function for stopping all profiles for a given global object. This is more straight-forward than multiplexing through the old function.

(JSC::dispatchFunctionToProfiles): Updated for change to JSGlobalObject*.

  • profiler/Profiler.h: Ditto.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): Ditto.
4:06 PM Changeset in webkit [81524] by mrowe@apple.com
  • 1 copy in branches/safari-533.21-branch

New branch.

4:06 PM Changeset in webkit [81523] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80668
BUG=75374

4:02 PM Changeset in webkit [81522] by dcheng@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Fix incorrect test onpaste-text-html-types.html
​https://bugs.webkit.org/show_bug.cgi?id=56621

The test was checking for the presence of "Text" in event.clipboardData.types,
but per ​http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/024956.html,
this should not be the case.

  • editing/pasteboard/onpaste-text-html-types.html:
3:53 PM Changeset in webkit [81521] by cevans@google.com
  • 3 edits in branches/chromium/696/Source/WebCore

Merge 80798
BUG=73899

3:41 PM Changeset in webkit [81520] by simonjam@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-18 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81489.

  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
3:32 PM Changeset in webkit [81519] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash when sending a sync message ends up invalidating the connection
​https://bugs.webkit.org/show_bug.cgi?id=56686
<rdar://problem/9048781>

Guard against a null client.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
3:20 PM Changeset in webkit [81518] by rniwa@webkit.org
  • 8 edits in trunk

2011-03-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=56599

Re-enabled the test on non-Mac platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=56599

Debug build fix.

  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node, then we can't necessarily instantiate a position inside the node.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e could be null. Exit early in those cases as well.
3:14 PM Changeset in webkit [81517] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC bindings to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56671

It turns out we generate a bunch of ObjC bindings files that we don't
actually build. I've manually synced the list of ObjC derived source
files to match the existing list. This brings us down to 19 link
errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
3:05 PM Changeset in webkit [81516] by cevans@google.com
  • 2 edits
    12 copies in branches/chromium/696

Merge 80682
BUG=61502

2:55 PM Changeset in webkit [81515] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-18 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=56624

No new tests, just splitting jsc related configuration.

  • CMakeLists.txt:
  • UseJSC.cmake: Added.
2:50 PM Changeset in webkit [81514] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=56685
webarchive/test-link-rel-icon.html is now flaky

Rubberstamped by Adam Roben.

  • platform/mac/Skipped:
2:48 PM Changeset in webkit [81513] by enne@google.com
  • 3 edits in branches/chromium/696/Source/WebKit/chromium

Merge 81395 - 2011-03-17 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
​https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:

TBR=​enne@google.com

2:44 PM Changeset in webkit [81512] by senorblanco@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

One last attempt at rebaselining these tests (now that I know how
the --gpu flag works).

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
2:17 PM Changeset in webkit [81511] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; more test baselines.

Update the checksums I forgot to update in r81504.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
2:15 PM Changeset in webkit [81510] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-18 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] make devtool concatenation targets conditional based on debug_devtools
​https://bugs.webkit.org/show_bug.cgi?id=56667

We don't want to run these targets when debug_devtools=1 because it
will overwrite the devtools.js and devtools.css files copied by
inspector_resources. On Linux, this triggers a warning because
there are two commands that target the same output file when
debug_devtools=1.

I also removed the 'sources' lines since I don't think they do
anything for actions.

  • WebKit.gyp:
2:03 PM Changeset in webkit [81509] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
​https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
​https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
1:59 PM Changeset in webkit [81508] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 James Simonsen <​simonjam@chromium.org>

[Chromium] Unreviewed, re-enable some stable tests and add a flaky one.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [81507] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Benjamin Poulain.

[Qt][WK2] Need a way to debug the web process after the UI process dies
​https://bugs.webkit.org/show_bug.cgi?id=56116

Allow the web process to outlive it's parent process
in debug builds if the QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS
environment variable is set.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess): Used getenv since the prctl call is already in a Linux-only block and the implementation in this file is a candidate for sharing across ports in the future.
1:29 PM Changeset in webkit [81506] by cevans@google.com
  • 1 edit in branches/chromium/696/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595

1:28 PM Changeset in webkit [81505] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595
Review URL: ​http://codereview.chromium.org/6713045

1:18 PM Changeset in webkit [81504] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

New GPU baselines for shadow quality improved by ​http://trac.webkit.org/changeset/81489.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
1:04 PM Changeset in webkit [81503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Remove unused method FontFallbackList::fontDataForCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=56657

  • platform/graphics/Font.h:
  • platform/graphics/FontFallbackList.cpp:
  • platform/graphics/FontFallbackList.h:
1:04 PM Changeset in webkit [81502] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4.0

Branching for the 1.4.0 GTK+ stable release.

1:03 PM Changeset in webkit [81501] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <​kling@webkit.org>

Reverting accidental changes in r81498.

12:58 PM Changeset in webkit [81500] by Adam Roben
  • 2 edits in trunk/Tools

Windows build fix

  • WebKitTestRunner/config.h: Add a missing #endif.
12:49 PM Changeset in webkit [81499] by loislo@chromium.org
  • 7 edits in trunk

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename console agent events.
​https://bugs.webkit.org/show_bug.cgi?id=56646

addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate

WebCore:

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
12:46 PM Changeset in webkit [81498] by andreas.kling@nokia.com
  • 5 edits in trunk

2011-03-18 Andreas Kling <​kling@webkit.org>

Unbreak Qt build after r81494.

  • WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
12:38 PM Changeset in webkit [81497] by senorblanco@chromium.org
  • 166 edits
    14 adds in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines.

New baselines for shadow quality improved by ​http://trac.webkit.org/changeset/81489.

  • platform/chromium-linux/compositing/geometry: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-linux/compositing/iframes: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-linux/svg/css/shadow-changes-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-win/compositing/geometry: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/chromium-win/compositing/iframes: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.checksum:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.checksum:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium/test_expectations.txt:
12:36 PM Changeset in webkit [81496] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build. This was really Adam Roben's fault. I swear!

  • WebKitTestRunner/config.h:
12:28 PM Changeset in webkit [81495] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

2011-03-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
​http://trac.webkit.org/changeset/81487
​https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
  • inspector/styles/get-set-stylesheet-text.html: Removed.
  • inspector/styles/resources/get-set-stylesheet-text.css: Removed.
  • inspector/styles/styles-new-API.html:

2011-03-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
​http://trac.webkit.org/changeset/81487
​https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):
12:24 PM Changeset in webkit [81494] by weinig@apple.com
  • 9 edits
    1 move
    2 adds in trunk/Tools

2011-03-18 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Pixel tests don't work in WebKitTestRunner on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56630

Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
built-in snapshotting instead of using the window server on the Mac.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::setPixelResult): (WTR::InjectedBundle::shouldDumpPixels):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Take the snapshot in the bundle and send it to the UIProcess for dumping.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cg: Added.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm. (WTR::createCGContextFromImage): (WTR::computeMD5HashStringForContext): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/mac/TestInvocationMac.mm: Removed. Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
  • WebKitTestRunner/win/TestInvocationWin.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Keep stub for Cairo build.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added. Add CG configuration.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files.
12:15 PM Changeset in webkit [81493] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Command-period does not stop load when page has focus in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56601

  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): If called outside interpretKeyEvents, call through to super. (-[WKView insertText:]): Assert that we are inside interpretKeyEvents. (-[WKView unmarkText]): Ditto. (-[WKView setMarkedText:selectedRange:]): Ditto. (-[WKView _interceptKeyEvent:]): Set a flag to indicate we are inside interpretKeyEvents for use by the above.
12:10 PM Changeset in webkit [81492] by Adam Roben
  • 2 edits in trunk/Tools

Don't allow Leaks Viewer's vertical scrollbar to cover up long function names

Rubber-stamped by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
overflow-y:overlay so that the scrollbar doesn't overlay the content.

12:03 PM Changeset in webkit [81491] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

[chromium] Add some test expectations missing from r81489.

  • platform/chromium/test_expectations.txt:
12:00 PM Changeset in webkit [81490] by Adam Roben
  • 2 edits in trunk/Tools

Don't ellipsize long or indented function names in Leaks Viewer

Fixes <​http://webkit.org/b/56037> Leaks viewer needs horizontal
scrollbar

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container):
(.data-grid td > div, .data-grid th > div):
Allow the contents to extend to the right.

11:14 AM Changeset in webkit [81489] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/chromium/test_expectations.txt:

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
11:11 AM Changeset in webkit [81488] by jberlin@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

Web Inspector: inspector/elements/mutate-unknown-node.html is flakey.
​https://bugs.webkit.org/show_bug.cgi?id=56457

Unreviewed, disable the test and remove it from the Qt Skipped list because this test is
also being flakey on Windows.

  • inspector/elements/mutate-unknown-node.html: Removed.
  • inspector/elements/mutate-unknown-node.html-disabled: Copied from inspector/elements/mutate-unknown-node.html.
  • platform/qt/Skipped:
10:55 AM Changeset in webkit [81487] by apavlov@chromium.org
  • 10 edits
    3 adds in trunk

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
​https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt: Added.
  • inspector/styles/get-set-stylesheet-text.html: Added.
  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles/styles-new-API.html:
10:25 AM Changeset in webkit [81486] by xan@webkit.org
  • 8 edits in trunk/Source

Source/WebCore:

2011-03-18 David Keijser <​keijser@gmail.com> and Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
​https://bugs.webkit.org/show_bug.cgi?id=49649

Add explicit EventTarget API to add/remove event listeners instead
of using GSignal, which due to internal limitations in glib makes
us preemptively add listeners for all event types.

  • bindings/gobject/GObjectEventListener.cpp: add new addEventListener/removeEventListener methods, and small refactoring to store an EventTarget internally instead of a DOM node, which is more generic and can be reused in more cases.
  • bindings/gobject/GObjectEventListener.h: ditto.
  • bindings/gobject/WebKitDOMEventTarget.cpp: (webkit_dom_event_target_add_event_listener): new iface method to add an event listener. (webkit_dom_event_target_remove_event_listener): new iface method to remove an event listener.
  • bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
  • bindings/scripts/CodeGeneratorGObject.pm: change code generation accordingly.

Source/WebKit/gtk:

2011-03-18 David Keijser <​keijser@gmail.com> and Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
​https://bugs.webkit.org/show_bug.cgi?id=49649

  • tests/testdomdomwindow.c: update unit tests for new APIs. (load_event_callback): ditto. (test_dom_domview_signals): ditto. (load_status_callback): ditto.
10:07 AM Changeset in webkit [81485] by kerz@chromium.org
  • 2 edits in branches/chromium/648/Source/WebKit/chromium

Merge 76889 - 2011-01-27 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

This addresses a regression introduced by r75784, as described in:
​https://bugs.webkit.org/show_bug.cgi?id=53176

The problem is that originalEndContainer and originalEndOffset was
meant to capture the end of the document, but was being assigned after
a call to searchRange->setStart() (when scoping is restarted), which can
result in the Range being collapsed to start (thereby assigning the
wrong value to the Container/Offset pair).

This code is never triggered by layout tests, but I'm adding a regressiono
test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6708026

10:07 AM Changeset in webkit [81484] by beidson@apple.com
  • 28 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase

Reviewed by Sam Weinig.

../WebCore:

-Update the synchronous method names to be prefixed with "synchronous."
-Call asynchronous versions of the appropriate methods if the IconDatabase supports them.

Update icon database calls to be prefixed with "synchronous":

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabaseBase::synchronousIconForPageURL):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::synchronousIconURLForPageURL):

Add nascent support for an asynchronous icon database mode:

  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::create):
(WebCore::EnumCallback::~EnumCallback):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::create):
(WebCore::ObjectCallback::~ObjectCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
(WebCore::IconDatabaseBase::supportsAsynchronousMode):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::iconDataForIconURL):

Add interfaces to use the asynchronous versions of certain IconDatabase calls:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::iconLoadDecisionAvailable):
(WebCore::iconLoadDecisionCallback):
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
(WebCore::DocumentLoader::continueIconLoadWithDecision):
(WebCore::iconDataCallback):
(WebCore::DocumentLoader::getIconDataForIconURL):

  • loader/DocumentLoader.h:

Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
icon database modes:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::iconLoadDecisionReceived):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::continueIconLoadWithDecision):

  • loader/FrameLoader.h:
  • WebCore.exp.in:

../WebKit/efl:

Update already-used function names:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

../WebKit/gtk:

Update already-used function names:

  • webkit/webkiticondatabase.cpp:

(webkit_icon_database_get_icon_uri):
(webkit_icon_database_get_icon_pixbuf):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_icon_uri):

../WebKit/mac:

Update already-used function names:

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):

  • WebView/WebView.mm:

(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

../WebKit/qt:

Update already-used function names:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):

../WebKit/win:

Update already-used function names:

  • WebIconDatabase.cpp:

(WebIconDatabase::iconForURL):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::hasIconForURL):

../WebKit2:

-Update the synchronous method names to be prefixed with "synchronous."
-Add empty implementations for the asynchronous accessors.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::supportsAsynchronousMode):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
9:56 AM Changeset in webkit [81483] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::NativeExecutable::NativeExecutable): (JSC::VPtrHackExecutable::VPtrHackExecutable): (JSC::ScriptExecutable::ScriptExecutable): Use a raw pointer instead of PassRefPtr, like JSString does, since JSGlobalData owns the singleton exectuable structure.
9:50 AM Changeset in webkit [81482] by Adam Roben
  • 2 edits
    1 add in trunk/Tools

Fix some leaks in DRT seen on the leaks bot

Fixes <​http://webkit.org/b/56638> addURLToRedirectCallback and
setWillSendRequestClearHeaderCallback in DRT are leaky

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:

(addURLToRedirectCallback):
(setWillSendRequestClearHeaderCallback):
Use OwnArrayPtr to cause the strings to be deleted.

9:49 AM Changeset in webkit [81481] by Adam Roben
  • 2 edits in trunk/Tools

Fix a NSURLCredential leak seen on the leaks bot

Fixes <​http://webkit.org/b/56637> -[SynchronousLoader
connection:didReceiveAuthenticationChallenge:] is leaky

Reviewed by John Sullivan.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
cause the NSURLCredential to be released.

9:48 AM Changeset in webkit [81480] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: add missing brace to the generated Inspector.idl.

  • inspector/generate-inspector-idl:
9:42 AM Changeset in webkit [81479] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/Source/WebCore

2011-03-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
​https://bugs.webkit.org/show_bug.cgi?id=56294

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • inspector/Inspector.idl: Removed.
  • inspector/Inspector.json: Added.
  • inspector/generate-inspector-idl: Added.
9:40 AM Changeset in webkit [81478] by alex
  • 2 edits
    4 adds in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Fixed compilation after r80925.

  • GNUmakefile.am:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Added. (WebKit::WebFullScreenManagerProxy::enterFullScreen): (WebKit::WebFullScreenManagerProxy::exitFullScreen): (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::getFullScreenRect):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Added. (WebKit::WebFullScreenManagerGtk::WebFullScreenManagerGtk): (WebKit::WebFullScreenManager::create): (WebKit::WebFullScreenManagerGtk::setRootFullScreenLayer): (WebKit::WebFullScreenManagerGtk::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerGtk::beginExitFullScreenAnimation):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Added.
9:36 AM Changeset in webkit [81477] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

inspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2 Tests).
​https://bugs.webkit.org/show_bug.cgi?id=56633

Unreviewed, skip command-line-api-inspect.html instead of command-line-api.html, since the
former appears to be causing the latter (and probably console-clear.html as well) to time
out.

  • platform/win-wk2/Skipped:
  • platform/win-wk2/inspector: Removed.
  • platform/win-wk2/inspector/console: Removed.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Removed.
9:36 AM Changeset in webkit [81476] by alex
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed compilation after r81208.

  • GNUmakefile.am:
9:09 AM Changeset in webkit [81475] by sergio@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-18 Sergio Villar Senin <​svillar@igalia.com>

Added new GTK+ test expectations.

  • platform/gtk/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt: Added.
8:51 AM Changeset in webkit [81474] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-03-18 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

Remove unnecessary brackets around my email address.

  • Scripts/webkitpy/common/config/committers.py:
8:42 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
8:41 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
8:31 AM Changeset in webkit [81473] by jberlin@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Two inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release (WebKit2
Tests).
​https://bugs.webkit.org/show_bug.cgi?id=56632

Unreviewed, landing expected failing results in order to get the Windows 7 Release
WebKit2 bots green.

  • platform/win-wk2/http: Added.
  • platform/win-wk2/http/tests: Added.
  • platform/win-wk2/http/tests/inspector-enabled: Added.
  • platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Added.
  • platform/win-wk2/inspector: Added.
  • platform/win-wk2/inspector/console: Added.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Added.
8:29 AM Changeset in webkit [81472] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)

8:27 AM Changeset in webkit [81471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-18 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] console.log not being exposed to QmlViewer
​https://bugs.webkit.org/show_bug.cgi?id=56536

The documentation is bogus the feature does not exist.

  • declarative/qdeclarativewebview.cpp:
8:21 AM Changeset in webkit [81470] by podivilov@chromium.org
  • 12 edits in trunk/Source

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

We would like to enable debugger/profiler from frontend side only.
However, when user clicks "Start Debugging JavaScript" in Safari, we
need to enable debugger when frontend is opened or re-opened for the
same page. The idea is to store debugger-enabled setting in session
storage and check it on frontend load.

  • inspector/InspectorFrontendClient.h: (WebCore::InspectorFrontendClient::saveSessionSetting): (WebCore::InspectorFrontendClient::loadSessionSetting):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::saveSessionSetting): (WebCore::InspectorFrontendHost::loadSessionSetting):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting): (-[WebInspectorWindowController inspectorClient]):

2011-03-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
​https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting):
  • WebCoreSupport/WebInspectorClient.h:
7:31 AM Changeset in webkit [81469] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, suppress editing/deleting/5206311-1.html crashes on Mac Debug

  • platform/chromium/test_expectations.txt:
7:28 AM Changeset in webkit [81468] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable GraphicsContext3D only when the window surface support OpenGL
​https://bugs.webkit.org/show_bug.cgi?id=56555

Allow creation of WebGLRenderingContext in the HTMLCanvasElement
only if accelerated compositing is enabled. In GraphicsContext3D,
while blitting the surface check that viewport hasn't changed from
creation and painter is associated to the viewport.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getViewportGLWidget): (WebCore::GraphicsContext3DInternal::paint):
7:11 AM Changeset in webkit [81467] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
6:48 AM Changeset in webkit [81466] by apavlov@chromium.org
  • 51 edits
    2 adds in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, rebaseline GPU tests after r81414

  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
5:08 AM Changeset in webkit [81465] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only

Rubber-stamped by Jon Honeycutt.

Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.

  • Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what

each target-specific .xcconfig file should import.

4:18 AM Changeset in webkit [81464] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, fix custom expectation after r81438

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
3:26 AM Changeset in webkit [81463] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn&apos;t scroll when multiline expression is being evaluated
​https://bugs.webkit.org/show_bug.cgi?id=56639

Always scoll in the console when command result is received.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage):
3:09 AM Changeset in webkit [81462] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed fix for chromium test_expectations.txt.

There was a duplicate for inspector/mutate-unknown-node.html

  • platform/chromium/test_expectations.txt:
2:36 AM Changeset in webkit [81461] by caseq@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-18 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

http/tests/inspector/resource-parameters.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=55867

Fixed test flakiness by not finishing test before proper resource arrives.

  • http/tests/inspector/resource-parameters.html: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html-disabled.
2:14 AM Changeset in webkit [81460] by Adam Roben
  • 1 edit
    2 deletes in trunk/Tools

Remove some files I accidentally added in r81454

  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2:12 AM Changeset in webkit [81459] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: cleanup Web Inspector expectations.
​https://bugs.webkit.org/show_bug.cgi?id=56635

Many Inspector tests are passing now but they still have expectations.
I've removed unnecessary expectations and grouped the remainings.

  • platform/chromium/test_expectations.txt:
2:08 AM Changeset in webkit [81458] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows WebKit2 expected failure results for a media test

The failure is tracked by <​http://webkit.org/b/56636>.

  • platform/win-wk2/media/controls-without-preload-expected.txt: Added.
2:07 AM Changeset in webkit [81457] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some timing out tests in WebKit2 on Windows

Tracked by <​http://webkit.org/b/56633> and <​http://webkit.org/b/56634>.

  • platform/win-wk2/Skipped: Added inspector/console/command-line-api.html and

http/tests/xmlhttprequest/cross-origin-authorization.html.

2:05 AM Changeset in webkit [81456] by Adam Roben
  • 1 edit
    12 adds in trunk/LayoutTests

Add expected failure results for WebKit2 tests failing on Windows due to font differences

<​http://webkit.org/b/56617> tracks the failures.

  • platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/text/bidi-text-query-expected.txt: Added.
2:03 AM Changeset in webkit [81455] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test in that is probably causing the next test to crash in WebKit2

<​http://webkit.org/b/55780> tracks the failure.

  • platform/win-wk2/Skipped: Skip platform/win/plugins/draws-gradient.html instead of

platform/win/plugins/get-value-netscape-window.html. The former was probably causing the
latter to crash.

2:01 AM Changeset in webkit [81454] by Adam Roben
  • 1 edit
    1 move
    3 adds in trunk

Disable a flakey inspector test

<​http://webkit.org/b/56565> tracks the failure.

  • inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Renamed from LayoutTests/inspector/elements/elements-panel-xhtml-structure.xhtml.
12:39 AM Changeset in webkit [81453] by Adam Roben
  • 2 edits in trunk/Tools

Ignore an NSNumberFormatter leak on SnowLeopard

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
getObjectValue:forString:errorDescription:].

12:37 AM Changeset in webkit [81452] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Fix a CFNumber leak seen on the leaks bot

Reviewed by Gavin Barraclough.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.

12:34 AM Changeset in webkit [81451] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/648

Merge 80797
BUG=73595
Review URL: ​http://codereview.chromium.org/6709024

12:26 AM Changeset in webkit [81450] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/696

Merge 80797
BUG=73595

12:19 AM Changeset in webkit [81449] by Adam Roben
  • 2 edits in trunk/Tools

Fix a leak beneath LayoutTestController::authenticateSession seen on the bots

Rubber-stamped by Mark Rowe.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
released.

12:09 AM Changeset in webkit [81448] by Adam Roben
  • 2 edits in trunk/Tools

Address a review comment I missed in r81445

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
leaked bytes to speed up searching on long lines.

12:01 AM Changeset in webkit [81447] by Adam Roben
  • 2 edits in trunk/Tools

Mark leaky builds orange, even if all regression tests passed

Fixes <​http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
build.webkit.org when all tests pass even though there are still leaks

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
be marked orange if this build step generates warnings.

Mar 17, 2011:

11:59 PM Changeset in webkit [81446] by Adam Roben
  • 3 edits in trunk/Tools

Allow values in Leaks Viewer to be shown as percentages

Double-clicking on a column will toggle between showing percentages and showing real values.

Fixes <​http://webkit.org/b/56628> Would like to view values as percentages of the total
number of leaked bytes in Leaks Viewer

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
node's totalTime, which is used in calculating percentages.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
showing them as percentages.

11:58 PM Changeset in webkit [81445] by Adam Roben
  • 3 edits in trunk/Tools

Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer

The Self and Total columns now report the number of leaked bytes. The new Calls column shows
the number of leaked allocations. And the new Average column shows the average number of
leaked bytes per call.

Fixes <​http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
just how many allocations

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
line and store it with the leak stack.
(LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
properties.
(LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
.numberOfCalls now holds the number of leaked allocations.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
appear.
(monkeyPatchInspectorObjects): Format the values as bytes.

10:39 PM Changeset in webkit [81444] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that is likely causing later tests to assert

<​http://webkit.org/b/56599> tracks the failure.

  • platform/win/Skipped: Replaced editing/deleting/5206311-1.html with

editing/deleting/5168598.html, which is likely causing the former to assert.

10:19 PM Changeset in webkit [81443] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows XP results for test added in r81404

The differences from Windows 7 seem to be due to different fonts being used.

  • platform/win-xp/fast/text/emphasis-combined-text-expected.txt: Added.
10:18 PM Changeset in webkit [81442] by Adam Roben
  • 2 edits in trunk/Tools

Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests

Fixes <​http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
regression tests

Reviewed by James Robinson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
is always populated, even when all regression tests pass.

10:09 PM Changeset in webkit [81441] by hayato@chromium.org
  • 3 edits in trunk/Tools

2011-03-10 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

Add a check logic for reftests in case that a reftest is marked AS REBASELINE.

​https://bugs.webkit.org/show_bug.cgi?id=56076

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
9:10 PM Changeset in webkit [81440] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QML WebView emits iconChanged() when the page title changes
​https://bugs.webkit.org/show_bug.cgi?id=56570

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged signal to the view's iconChanged signal.
9:03 PM Changeset in webkit [81439] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add some of the remaining platform/mac files to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56616

These files used to be hard, but are now magically easy. 76 link errors.

  • gyp/WebCore.gyp:
8:53 PM Changeset in webkit [81438] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

Leaving the file names as-is for now to avoid svn-apply's
handling of move-and-modify.

  • fast/filesystem/directory-entry-to-uri-expected.txt:
  • fast/filesystem/file-entry-to-uri-expected.txt:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
  • http/tests/filesystem/resolve-uri-expected.txt:
  • http/tests/filesystem/script-tests/resolve-uri.js:

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

  • fileapi/Entry.idl:
  • fileapi/EntryBase.cpp: (WebCore::EntryBase::toURL):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURL):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
8:40 PM Changeset in webkit [81437] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80672
BUG=75311

8:39 PM Changeset in webkit [81436] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80672
BUG=75311
Review URL: ​http://codereview.chromium.org/6711031

8:25 PM Changeset in webkit [81435] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/648

Merge 80487
BUG=74991
Review URL: ​http://codereview.chromium.org/6685081

8:20 PM Changeset in webkit [81434] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80144
BUG=74562
Review URL: ​http://codereview.chromium.org/6711030

8:10 PM Changeset in webkit [81433] by cevans@google.com
  • 2 edits in branches/chromium/648

Merge 80043
BUG=74720
Review URL: ​http://codereview.chromium.org/6711029

8:06 PM Changeset in webkit [81432] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80579
BUG=75155

8:05 PM Changeset in webkit [81431] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80579
BUG=75155
Review URL: ​http://codereview.chromium.org/6712027

7:57 PM Changeset in webkit [81430] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/648

Merge 80520
BUG=75170
Review URL: ​http://codereview.chromium.org/6714006

7:49 PM Changeset in webkit [81429] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/plugins/PluginView.cpp

Merge 79897
BUG=73216
Review URL: ​http://codereview.chromium.org/6711028

7:46 PM Changeset in webkit [81428] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 79808
BUG=73216
Review URL: ​http://codereview.chromium.org/6709019

7:43 PM Changeset in webkit [81427] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • WebKit2.xcodeproj/project.pbxproj:
7:14 PM Changeset in webkit [81426] by simonjam@chromium.org
  • 19 edits
    11 adds in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, rebaseline a bunch of chromium tests.

  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
6:58 PM Changeset in webkit [81425] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Test some error-handling cases.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing.html: Added.

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Brandon updated the CSP spec. I've updated our implementation to
match. In the process, I found a couple bugs in the spec, which I've
sent to the working group. This patch assumes that the bugs will be
fixed in the way I suggested. If they get fixed a different way, we
might need to update the parser again.

Test: http/tests/security/contentSecurityPolicy/directive-parsing.html

  • page/ContentSecurityPolicy.cpp: (WebCore::isDirectiveNameCharacter): (WebCore::isDirectiveValueCharacter): (WebCore::advanceUntil): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::parseDirective):
  • page/ContentSecurityPolicy.h:
6:36 PM Changeset in webkit [81424] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should have PrivateHeaders
​https://bugs.webkit.org/show_bug.cgi?id=56604

I've manually verified that this produces the correct set of
PrivateHeaders (modulo the ForwardingHeaders and icu issue).
Unforunately, this patch breakes compile slightly, but I'll fix that
in a followup patch.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • gyp/WebCore.gyp:
6:31 PM Changeset in webkit [81423] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
6:17 PM Changeset in webkit [81422] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

chromium: uninitialized field in WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=56620

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
6:11 PM Changeset in webkit [81421] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setFullscreenWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56618

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_fullscreenWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
if m_fullscreenWindowIsShowing is true, call exitFullscreen.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::getPluginProcessSerialNumber): Add helper function for getting a PSN for the plug-in process.

(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
Make the plug-in process the front process.

(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
Make the current process (the UI process) the front process.

(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Call enterFullscreen or exitFullscreen.

(WebKit::PluginProcessProxy::enterFullscreen):
Make the plug-in process the front process and hide the menu bar.

(WebKit::PluginProcessProxy::exitFullscreen):
Show the menu bar and if necessary make the UI process the front process.

(WebKit::PluginProcessProxy::endModal):
call makeUIProcessTheFrontProcess.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Call makePluginProcessTheFrontProcess.

6:11 PM Changeset in webkit [81420] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.

Fixed some string leaks seen on the buildbot
​https://bugs.webkit.org/show_bug.cgi?id=56619

  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::~PropertyTable): DEref!
5:52 PM Changeset in webkit [81419] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make bidi text in <select> menus in WebKit2 on Windows match WebKit1

Fixes <​http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.

5:45 PM Changeset in webkit [81418] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setModalWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56615

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_modalWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
If m_modalWindowIsShowing is true, we must call endModal.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (-[WKPlaceholderModalWindow _wantsUserAttention]): Add a WKPlaceholderModalWindow.

(WebKit::PluginProcessProxy::setModalWindowIsShowing):
Call beginModal or endModal depending on whether we're showing a modal window or not.

(WebKit::PluginProcessProxy::beginModal):
Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.

(WebKit::PluginProcessProxy::endModal):
Tear down the window and the run loop.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Make sure that the plug-in process is frontmost.

5:18 PM Changeset in webkit [81417] by levin@chromium.org
  • 10 edits in trunk/LayoutTests

Misc clean-up (see files for details).

  • platform/chromium-mac-leopard/media/controls-after-reload-expected.checksum: Due to r81300.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Due to r81285.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Ditto.
  • platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-win-xp/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Replace BUG_LEVIN with a bug number.
5:11 PM Changeset in webkit [81416] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-17 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Web page shouldn't swallow alt-key combinations on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56612


Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
sure any alt-key combinations bubble up to the client.

  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.
5:11 PM Changeset in webkit [81415] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added platform-specific expected results for fast/text/emphasis-combined-text.html

  • platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Added.
  • platform/win/fast/text/emphasis-combined-text-expected.txt: Added.
5:10 PM Changeset in webkit [81414] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-17 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Video colors have wrong brightness/contrast
​https://bugs.webkit.org/show_bug.cgi?id=56598

This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.

  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderYUVVideo::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h: (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h:
5:08 PM Changeset in webkit [81413] by Adam Roben
  • 3 edits
    1 delete in trunk

Skip a compositing-sensitive test when accelerated compositing is disabled

Reviewed by Sam Weinig.

Tools:

  • Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when

accelerated compositing is disabled.

LayoutTests:

Remove some non-compositing results for a test that is now skipped in non-compositing builds

  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Removed.
5:08 PM Changeset in webkit [81412] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=56610

  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::FullscreenWindowTracker::FullscreenWindowTracker): Add fullscreen window tracker class.

(WebKit::rectCoversAnyScreen):
Return whether the given rect covers any screen.

(WebKit::windowCoversAnyScreen):
Return whether the given window covers any screen.

(WebKit::FullscreenWindowTracker::windowShown):
If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::FullscreenWindowTracker::windowHidden):
If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
Call the window tracking functions.

(WebKit::setModal):
Call PluginProcess::setModalWindowIsShowing.

(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Send CoreIPC messages.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in: Add new messages.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::setModalWindowIsShowing): (WebKit::PluginProcessProxy::setFullscreenWindowIsShowing): Add stubs.
4:57 PM Changeset in webkit [81411] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in JSC::MarkStack::drain Under Stress
​https://bugs.webkit.org/show_bug.cgi?id=56470

We perform a number of gc allocations while when
we are setting up new globals in a piece of global
code. We do this by adding new properties to the
symbol table, and then expanding the storage to fit
at the end.

If a GC happens during this time we will report an
incorrect size for the global object's symbol table
storage.

This patch corrects this by growing the storage size
before we starting adding entries to the symbol table.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resizeRegisters):
4:46 PM Changeset in webkit [81410] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure we're using, since the Executable is not designed to own the Structure.
4:43 PM Changeset in webkit [81409] by zmo@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 81407 - 2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.

TBR=​zmo@google.com

4:27 PM Changeset in webkit [81408] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rubber Stamped by Sam Weinig.

Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::testb_rr):

4:26 PM Changeset in webkit [81407] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.
4:22 PM Changeset in webkit [81406] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/8953779>

Reviewed by Darin Adler.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

4:16 PM Changeset in webkit [81405] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:11 PM Changeset in webkit [81404] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
​https://bugs.webkit.org/show_bug.cgi?id=56480

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/text/emphasis-combined-text.html

  • rendering/InlineTextBox.cpp:

(WebCore::rotation): Added this helper.
(WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
centered vertically.

LayoutTests:

  • fast/text/emphasis-combined-text.html: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.txt: Added.
4:11 PM Changeset in webkit [81403] by barraclough@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Bug 56603 - DFG JIT related cleanup
Move node generation out to separate function, move binarySearch algorithm out
to StdLibExtras, fix Graph::dump() to print comma between non-node children,
even if there are no node children.

Reviewed by Sam Weinig.

  • bytecode/CodeBlock.h:

(JSC::getCallReturnOffset):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::bytecodeOffset):

  • Move binaryChop to binarySearch in StdLibExtras
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • Make m_noArithmetic a member, initialize m_currentIndex in the constructor.
  • dfg/DFGByteCodeParser.h:
    • Change parse() to not take a start index (always 0).
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • Fix Graph::dump() to print comma between non-node children, even if there are no node children.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • Initialize m_compileIndex in constructor.
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationConvertThis):

  • dfg/DFGOperations.h:
    • Cleanup parameter name.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):

  • Change parse() to not take a start index (always 0).
  • wtf/StdLibExtras.h:

(WTF::binarySearch):

  • Move binaryChop to binarySearch in StdLibExtras
4:10 PM Changeset in webkit [81402] by Lucas Forschler
  • 1 copy in tags/Safari-534.25

New tag.

4:07 PM Changeset in webkit [81401] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a leak seen on the buildbot.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
4:07 PM Changeset in webkit [81400] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Allow passing a certificate chain as a user message
<rdar://problem/8951709>
​https://bugs.webkit.org/show_bug.cgi?id=56605

Reviewed by Brady Eidson.

  • Shared/API/c/mac/WKCertificateInfoMac.h:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.

4:06 PM Changeset in webkit [81399] by jianli@chromium.org
  • 9 edits
    3 adds in trunk

Blob URL should not be allow to get created from the code running from data URI
​https://bugs.webkit.org/show_bug.cgi?id=56600

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/fileapi/create-blob-url-from-data-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::createBlobURL):

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURI):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

LayoutTests:

  • http/tests/fileapi/create-blob-url-from-data-url-expected.txt: Added.
  • http/tests/fileapi/create-blob-url-from-data-url.html: Added.
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:29 PM Changeset in webkit [81398] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix clang build.

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

3:21 PM Changeset in webkit [81397] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Skip an editing test that hits assertion on non-Mac platforms.
The bug is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56599.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:18 PM Changeset in webkit [81396] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80064.
​http://trac.webkit.org/changeset/80064
​https://bugs.webkit.org/show_bug.cgi?id=56588

the original test was correct (Requested by rniwa on #webkit).

  • platform/mac/editing/input/selection-change-closes-typing.html:
3:17 PM Changeset in webkit [81395] by enne@google.com
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-17 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
​https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:
3:15 PM Changeset in webkit [81394] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need to explicitly run its destructor.
3:14 PM Changeset in webkit [81393] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-03-17 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Videos look ugly when using QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=56580

We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
in addition of what could be set on the painter. In order to not break the rendering of all the items in the
scene we set back the painter to its original state when QGraphicsWebView is rendered.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::paint): (QGraphicsWebView::renderHints): (QGraphicsWebView::setRenderHints): (QGraphicsWebView::setRenderHint):
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::renderHints):
3:04 PM Changeset in webkit [81392] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginProcessShim hooks for when windows are shown and hidden
​https://bugs.webkit.org/show_bug.cgi?id=56597

  • Configurations/PluginProcessShim.xcconfig: Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::cocoaWindowShown): (WebKit::cocoaWindowHidden): (WebKit::carbonWindowShown): (WebKit::carbonWindowHidden): (WebKit::setModal): (WebKit::PluginProcess::initializeShim): Add empty stubs.
  • PluginProcess/mac/PluginProcessShim.h:
  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::beginModal): (WebKit::endModal): Keep a modal count and call setModal accordingly.

(WebKit::shim_NSApplication_RunModalForWindow):
(WebKit::shimModalDialog):
(WebKit::shimAlert):
Call beginModal/endModal.

(WebKit::shimShowWindow):
(WebKit::shimHideWindow):
Call the shim functions.


(WebKit::WebKitPluginProcessShimInitialize):
Listen for notifications and call the necessary shim functions.

  • WebKit2.xcodeproj/project.pbxproj: Link the plug-in process shim with AppKit and QuartzCore and WKSI.
3:02 PM Changeset in webkit [81391] by Adam Roben
  • 2 edits
    2 moves in trunk/LayoutTests

Disable http/tests/inspector/network tests

They are known to be flaky. <​http://webkit.org/b/56578> tracks the issue.

  • http/tests/inspector/network/network-size.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-size.html.
  • http/tests/inspector/network/network-timing.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html.
  • platform/mac/Skipped: Removed a now-disabled test.
3:00 PM Changeset in webkit [81390] by Adam Roben
  • 4 edits in trunk/Tools

Start using PlatformSpecificScheduler for the Mac builders

The current set of file/directory patterns should work for Mac builders. We may discover
that there are more files and directories we can exclude from the Mac builds, but they can
be added later.

Fixes <​http://webkit.org/b/56593> Mac builders do lots of unnecessary builds

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two

PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
cleaned up patterns a little bit.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Fixed some expected results.
(ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
platforms.

2:51 PM Changeset in webkit [81389] by jeffm@apple.com
  • 25 edits in trunk

Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:

*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2:45 PM Changeset in webkit [81388] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac build.

  • WebCore.exp.in:

Add missing symbol.

2:25 PM Changeset in webkit [81387] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
​https://bugs.webkit.org/show_bug.cgi?id=56592

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.h:

Special case encoding/decoding of ResourceErrors for the mac.

  • Shared/mac/PlatformCertificateInfo.h:
  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.

2:21 PM Changeset in webkit [81386] by Adam Roben
  • 2 edits in trunk/Tools

Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows

Fixes <​http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
mac-wk2

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
we're running in WebKit2 mode.

2:03 PM Changeset in webkit [81385] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKWindowWillOrderOffScreenNotification.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
1:49 PM Changeset in webkit [81384] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adele Peterson and Enrica Casucci.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Debug build fix.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate a position inside the node. Call firstPositionInOrBeforeNode instead.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead of just when the node is br.
  • editing/htmlediting.cpp: (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.
1:44 PM Changeset in webkit [81383] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test_expectations.txt

Mark some tests as SLOW in DEBUG since they are on a borderline of shorter timeout.

  • platform/chromium/test_expectations.txt:
1:43 PM Changeset in webkit [81382] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky test on Mac

<​http://webkit.org/b/56578> tracks the failure.

  • platform/mac/Skipped: Added http/tests/inspector/network/network-size.html.
1:30 PM Changeset in webkit [81381] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some flaky tests on the SnowLeopard WebKit2 bot

Tracked by <​http://webkit.org/b/56530> and <​http://webkit.org/b/56584>.

  • platform/mac-wk2/Skipped: Added http/tests/inspector/resource-har-conversion.html and

inspector/debugger/debug-inlined-scripts.html.

1:22 PM Changeset in webkit [81380] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Reverting r81197, breaks JIT + INTERPRETER build.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):

  • bytecode/Opcode.h:
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

1:07 PM Changeset in webkit [81379] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

Add a COMPILER(SUNCC) define for Sun Studio 12.
​https://bugs.webkit.org/show_bug.cgi?56444
derived from patch 1 of 16 originally from ​https://bugs.webkit.org/show_bug.cgi?id=24932

  • wtf/Platform.h:
12:50 PM Changeset in webkit [81378] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [81377] by jcivelli@chromium.org
  • 10 edits
    8 adds in trunk/Source

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::::operator): (WTF::::contains):

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:14 PM Changeset in webkit [81376] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [81375] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceForURL): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
12:02 PM Changeset in webkit [81374] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added a test to ensure WebKit lets users edit contents inside a button element properly.

  • editing/execCommand/button-expected.txt: Added.
  • editing/execCommand/button.html: Added.

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
places where we instantiate positions inside a node on which editingIgnoresContent returns true.

Test: editing/execCommand/button.html

  • dom/Position.cpp: (WebCore::Position::Position): Added an assertion. (WebCore::Position::moveToPosition): Ditto.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below a node whose content is ignored by editing. While this does not avoid creation of positions inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve the underlying problem. Without this change, the assertion hits in existing layout tests. cannot be tested directly.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode instead of firstPositionInNode because startNode may as well be a br element. Without this change, the assertion hits in existing layout tests.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test for this.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Added a FIXME. (WebCore::startPositionForLine): Because br can also have an inline text box, checking that startBox is an inline text box isn't an adequate to instantiate a position inside startNode. Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout tests.
11:45 AM Changeset in webkit [81373] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip three tests that fail on one Windows WebKit2 slave but not the other

The failures are tracked by <​http://webkit.org/b/56550>.

  • platform/win-wk2/Skipped: Added fast/events/tabindex-focus-blur-all.html,

fast/forms/button-align.html, and media/audio-mpeg4-supported.html.

11:41 AM Changeset in webkit [81372] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.

11:39 AM Changeset in webkit [81371] by andersca@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Rename PluginProcessShim.cpp to PluginProcessShim.mm.

Rubber-stamped by John Sullivan.

  • PluginProcess/mac/PluginProcessShim.cpp: Removed.
  • PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
  • WebKit2.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [81370] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Invalidate all NPObjects for a plug-in when that plug-in is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=56511
<rdar://problem/8993491>

Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
tried to invoke it on a already deallocated NPObject.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.

(WebKit::PluginControllerProxy::destroy):
Pass the plug-in to removePluginControllerProxy.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

(WebKit::WebProcessConnection::createPlugin):
Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
takes care of doing this.

  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
  • Shared/Plugins/NPObjectMessageReceiver.h: Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated by the time the NPObjectMessageReceiver is destroyed.

(WebKit::NPObjectMessageReceiver::plugin):
Add getter.


  • Shared/Plugins/NPObjectProxy.h: (WebKit::NPObjectProxy::plugin): Add getter.


  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::NPRemoteObjectMap): Remove m_isInvalidating.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Simplify code.

(WebKit::NPRemoteObjectMap::pluginDestroyed):
Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.

  • Shared/Plugins/NPRemoteObjectMap.h: Remove m_isInvalidating.


  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::removePluginProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.
11:14 AM Changeset in webkit [81369] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
11:10 AM Changeset in webkit [81368] by pfeldman@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-03-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add types markup to the IDL, remove Value types from the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=56562

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::makeCall): (WebCore::InjectedScript::makeObjectCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::addRule):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/ScriptCallStack.cpp: (WebCore::ScriptCallStack::buildInspectorArray):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._createResource):
11:07 AM Changeset in webkit [81367] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

changelog

11:07 AM Changeset in webkit [81366] by simonjam@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

first changes

10:53 AM Changeset in webkit [81365] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] don't concatenate devtools files when debug_devtools=1
​https://bugs.webkit.org/show_bug.cgi?id=56572

  • WebKit.gyp:
10:41 AM Changeset in webkit [81364] by jorlow@chromium.org
  • 4 edits
    2 copies in branches/chromium/696/Source/WebCore

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

Patch by David Grogan <​dgrogan@chromium.org> on 2011-03-15
Reviewed by Jeremy Orlow.

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove

its reference to IDBDatabase, which it has as type
IDBDatabaseCallbacks.

  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes

a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::open):

  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h:

(WebCore::IDBDatabaseCallbacks::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
Merge 81181 - 2011-03-15 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):

TBR=​commit-queue@webkit.org

10:35 AM Changeset in webkit [81363] by Adam Roben
  • 2 edits
    1 move in trunk/LayoutTests

Disable http/tests/inspector/resource-parameters.html

It is flaky. The flakiness is tracked by <​http://webkit.org/b/55867>.

  • http/tests/inspector/resource-parameters.html-disabled: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html.
  • platform/qt/Skipped: Removed the test from this Skipped file since it has been disabled.
10:03 AM Changeset in webkit [81362] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-17 Oleg Romashin <​oleg.romashin@nokia.com>

Reviewed by Anders Carlsson.

Teach WebKit2 messages.py generator to ifdef headers include
which are related to ifdef-ed methods/types
​https://bugs.webkit.org/show_bug.cgi?id=55658

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
9:47 AM Changeset in webkit [81361] by commit-queue@webkit.org
  • 12 edits
    4 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround):
  • platform/chromium/test_expectations.txt:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillPath): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::clipPath): (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::drawQuad):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Removed.
  • platform/graphics/gpu/BicubicShader.h: Removed.
  • platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  • platform/graphics/gpu/ConvolutionShader.h: Removed.
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate):
9:44 AM Changeset in webkit [81360] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector tests timing out on Windows after r81222
​https://bugs.webkit.org/show_bug.cgi?id=56454

Remove custom expectations for Chromium tests that consistently pass locally.

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [81359] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some tests that only fail on apple-macpro-6

<​http://webkit.org/b/56564> tracks the failures.

  • platform/mac-leopard/Skipped:
9:39 AM Changeset in webkit [81358] by mnaganov@chromium.org
  • 4 edits in trunk

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

  • English.lproj/localizedStrings.js:

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

Modify the script to deal correctly with "\xNN" escapes, and to
check strings in Chromium's DevTools.js.

  • Scripts/check-inspector-strings:
9:38 AM Changeset in webkit [81357] by Adam Roben
  • 3 edits in trunk/LayoutTests

Skip a test that is only failing on some Leopard slaves

svg/text/font-size-below-point-five.svg generates different results on apple-macpro-5 from
the other Leopard slaves. <​http://webkit.org/b/56544> tracks this issue.

  • platform/mac-leopard/Skipped: Skip svg/text/font-size-below-point-five.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt: Reverted these

results to the results that all slaves except apple-macpro-5 generate.

9:26 AM Changeset in webkit [81356] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed, bad expected results were added. This fixes
the expected results and unskips the test on GTK.

[GTK] fast/viewport/viewport-131.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56556

  • fast/viewport/viewport-131-expected.txt:
  • platform/gtk/Skipped:
8:46 AM Changeset in webkit [81355] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:42 AM Changeset in webkit [81354] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: timeline-paint.html is flaky on GTK 64-bit Debug.
​https://bugs.webkit.org/show_bug.cgi?id=56554

It is not guaranteed that we receive exactly one paint event.

  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.stopTimeline):
8:35 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:32 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:18 AM Changeset in webkit [81353] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/reflections/abs-position-in-reflection.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
8:11 AM Changeset in webkit [81352] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky svg test on GTK.

  • platform/gtk/Skipped:
7:00 AM Changeset in webkit [81351] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for fast/dynamic/text-combine.html added
in r81251.

  • platform/gtk/fast/dynamic/text-combine-expected.txt: Added.
6:57 AM Changeset in webkit [81350] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
​https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
​https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
6:32 AM Changeset in webkit [81349] by apavlov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-03-17 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations

  • platform/chromium-mac/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81348] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-17 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Benjamin Poulain.

Update autoinstall to install mechanize 0.2.4
​https://bugs.webkit.org/show_bug.cgi?id=56499

Newer versions of mechanize support HTTPS proxies, which is necessary
for people using webkit-patch behind firewalls.

  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/thirdparty/init.py:
5:00 AM Changeset in webkit [81347] by kov@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

Tiled backing store should only request repaint for updated areas
​https://bugs.webkit.org/show_bug.cgi?id=56464

Reuse updateBackBuffer's dirty rectangle calculations to only
invalidate the necessary parts of the window.

  • platform/graphics/Tile.h:
  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers):
  • platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):
4:58 AM Changeset in webkit [81346] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/profiler/window-dot-eval.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
4:39 AM Changeset in webkit [81345] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] minor cleanup of devtools_files variable in WebKit.gyp
​https://bugs.webkit.org/show_bug.cgi?id=56503

  • WebKit.gyp: Moving duplicate variables out of a condition.
4:02 AM Changeset in webkit [81344] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing viewport test on GTK.

  • platform/gtk/Skipped:
3:32 AM Changeset in webkit [81343] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
​https://bugs.webkit.org/show_bug.cgi?id=56395

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotRetainerEdge): Added (WebInspector.HeapSnapshotRetainerEdgeIterator): Added (WebInspector.HeapSnapshotNode.prototype.get retainers): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.hasId): (WebInspector.HeapSnapshot.prototype.retainers): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildIdsList): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshot.prototype._findNodePositionInIndex): (WebInspector.HeapSnapshot.prototype._findNearestNodeIndex): (WebInspector.HeapSnapshot.prototype._getRetainerIndex): (WebInspector.HeapSnapshot.prototype._markInvisibleEdges): (WebInspector.HeapSnapshot.prototype._numbersComparator): (WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge): (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter): (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath): (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
2:49 AM Changeset in webkit [81342] by podivilov@chromium.org
  • 16 edits
    2 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • inspector/debugger/event-listener-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setFrontend): (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.prototype._enable): (WebInspector.EventListenerBreakpoint.prototype._disable): (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON): (WebInspector.EventListenerBreakpointView): (WebInspector.EventListenerBreakpointView.eventNameForUI): (WebInspector.EventListenerBreakpointView.prototype.get eventName): (WebInspector.EventListenerBreakpointView.prototype.compareTo): (WebInspector.EventListenerBreakpointView.prototype.populateLabelElement): (WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpointView.prototype._uiEventName):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
2:17 AM Changeset in webkit [81341] by Joseph Pecoraro
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport test for user-scalable=yes
​https://bugs.webkit.org/show_bug.cgi?id=56527

Provide tests for user-scalable no, yes, and default values.

  • fast/viewport/viewport-130-expected.txt: Added.
  • fast/viewport/viewport-130.html: Added.
  • fast/viewport/viewport-131-expected.txt: Added.
  • fast/viewport/viewport-131.html: Added.
  • fast/viewport/viewport-132-expected.txt: Copied from LayoutTests/fast/viewport/viewport-1-expected.txt.
  • fast/viewport/viewport-132.html: Added.
1:49 AM Changeset in webkit [81340] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Patrick Gansterer <Patrick Gansterer>

Fix the interpreter build.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Added globalData to inheritorID().
1:35 AM Changeset in webkit [81339] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add more ObjC++ files to the build
​https://bugs.webkit.org/show_bug.cgi?id=56548

96 link errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
1:14 AM Changeset in webkit [81338] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add transitions/default-timing-function.html to the SnowLeopard WebKit2 Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56531

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
1:10 AM Changeset in webkit [81337] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a few Objective-C++ files to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56547

464 link errors.

  • gyp/WebCore.gyp:
1:04 AM Changeset in webkit [81336] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add java/lc3/JavaObject/JavaObjectToDouble-001.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56545

Reviewed by Adam Roben.

  • This test was getting different results on different slaves.
  • platform/mac-leopard/Skipped:
12:51 AM Changeset in webkit [81335] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Yuta Kitamura <​yutak@chromium.org>

Unreviewed build fix.

Non-ASCII characters in XMLTreeViewer.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=56549

  • xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
  • xml/XMLTreeViewer.h: Ditto.
12:42 AM Changeset in webkit [81334] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add plugins and bridge to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56546

506 link errors.

  • gyp/WebCore.gyp:
12:14 AM Changeset in webkit [81333] by weinig@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

Disable fast/workers/storage/interrupt-database-sync.html due to flakiness on
multiple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=49906

Reviewed by Adam Roben.

  • fast/workers/storage/interrupt-database-sync.html: Removed.
  • fast/workers/storage/interrupt-database-sync.html-disabled: Copied from fast/workers/storage/interrupt-database-sync.html.
  • platform/qt/Skipped: Remove from qt Skipped list since it is now disabled.
12:04 AM Changeset in webkit [81332] by weinig@apple.com
  • 2 edits
    4 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Debug/Leopard Release Tester.

Reviewed by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56544
​https://bugs.webkit.org/show_bug.cgi?id=56545

  • platform/mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
Note: See TracTimeline for information about the timeline view.