Timeline



Mar 30, 2011:

11:04 PM Changeset in webkit [82549] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build correction after r82496. (Part 3)

Revise DragImageCairoWin to address new PlatformGraphicsContext
and object lifecycle.

  • platform/win/DragImageCairoWin.cpp:

(WebCore::deallocContext):
(WebCore::allocImage):
(WebCore::scaleDragImage):
(WebCore::createDragImageFromImage):

10:50 PM Changeset in webkit [82548] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build correction after r82496. (Part 2)

Revise DragImageCairoWin to address new PlatformGraphicsContext.

  • platform/win/DragImageCairoWin.cpp:

(WebCore::deallocContext):
(WebCore::allocImage):

10:48 PM Changeset in webkit [82547] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Adding fast/dom/HTMLKeygenElement/keygen.html to mac-wk2 Skipped list
since it requires layoutTestController.shadowRoot, which is unimplemented.

  • platform/mac-wk2/Skipped:
10:21 PM Changeset in webkit [82546] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-03-30 Dominic Cooney <dominicc@google.com>

Reviewed by Alexey Proskuryakov.

Remove actual test output from test tree.
https://bugs.webkit.org/show_bug.cgi?id=57503

  • platform/chromium-linux/websocket/tests/bad-sub-protocol-actual.txt: Removed.
  • platform/chromium-linux/websocket/tests/url-parsing-actual.txt: Removed.
10:17 PM Changeset in webkit [82545] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-30 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

REGRESSION (r82400): Leaks seen beneath CSSParser::createFloatingVectorSelector when parsing UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=57478

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::sinkFloatingSelectorVector):
  • css/CSSParser.h:
10:02 PM Changeset in webkit [82544] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build correction after r82496.

  • WebCore.vcproj/WebCore.vcproj: Add new PlatformContextCairo

files to WinCairo build. Exclude from standard Apple build.

8:57 PM Changeset in webkit [82543] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/9005982> Flash of white when a WKView with composited content moves on-screen
https://bugs.webkit.org/show_bug.cgi?id=57522

Reviewed by Maciej Stachowiak.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Invalidate the current
backing store state, so that we get an update as soon as the page enters compositing mode
next.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Added a call to
LayerTreeHost::forceRepaint() in order to flush and synchronize the layers
before sending the update message to the UI process.

8:48 PM Changeset in webkit [82542] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Typo fix, remove an accidentally added line.

  • Source/WebKit.pri:
8:46 PM Changeset in webkit [82541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Fix leaked pointer in FontGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=57307

Fix a memory leak.

No new functionality, so no new tests.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation. (WebCore::convertUniCharToUTF8):
8:24 PM Changeset in webkit [82540] by levin@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-30 David Levin <levin@chromium.org>

Reviewed by Dmitry Titov.

UnlockNonLocked condition reached in WorkerFileSystemsCallbackBridge::mayPostTaskToWorker
https://bugs.webkit.org/show_bug.cgi?id=57382

There were two issues to address:

  1. The use of a non-thread safe class (RefPtr) in a ThreadSafeRefCounted class. The problem was that this RefPtr could be changed on either thread.
  2. Keeping WorkerFileSystemCallbacksBridge alive for while it was being used including while its mutex was in use.
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::runTaskOnMainThread): Changed to take a PassRefPtr and leak the ref count as opposed to relying on dispatchTaskToMainThread to store the pointer in m_selfRef. (WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread): Remove the m_selfRef and hand off a PassRefPtr instead. (WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker): Balance out the leaked ref and ensure that WorkerFileSystemCallbacksBridge stays alive while the mutex is held.
  • src/WorkerFileSystemCallbacksBridge.h: Removed m_selfRef and derefIfWorkerIsStopped which was simply due to m_selfRef.
8:21 PM Changeset in webkit [82539] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Rollout r82240 and r82232, because they broke 2 plugin tests.

  • Source/WebKit.pri:
8:19 PM Changeset in webkit [82538] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, remove Chromium test expectations for two bugs that are known to be fixed.

  • platform/chromium/test_expectations.txt:
7:42 PM Changeset in webkit [82537] by Csaba Osztrogonác
  • 1 edit
    36 deletes in trunk/LayoutTests

Remove unnecessary Qt specific fast/canvas expected files after r82521.

  • platform/qt/fast/canvas/arc360-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-before-css-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-composite-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-resize-reset-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-text-baseline-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-identity-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-infinity-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-multiply-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-nan-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transform-skewed-expected.txt: Removed.
  • platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt: Removed.
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.txt: Removed.
  • platform/qt/fast/canvas/drawImage-expected.txt: Removed.
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Removed.
  • platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Removed.
  • platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Removed.
  • platform/qt/fast/canvas/fillrect_gradient-expected.txt: Removed.
  • platform/qt/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Removed.
  • platform/qt/fast/canvas/image-object-in-canvas-expected.txt: Removed.
  • platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Removed.
  • platform/qt/fast/canvas/patternfill-repeat-expected.txt: Removed.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Removed.
  • platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-1-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-2-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-3-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-4-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-5-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-6-expected.txt: Removed.
  • platform/qt/fast/canvas/shadow-offset-7-expected.txt: Removed.
  • platform/qt/fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.txt: Removed.
7:33 PM Changeset in webkit [82536] by commit-queue@webkit.org
  • 18 edits in trunk

2011-03-30 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Adds layoutTestController.shadowRoot accessor to Mac DRT.
https://bugs.webkit.org/show_bug.cgi?id=57415

Updates the keygen test to exercise new DRT functionality; skips
on other ports for now.

  • fast/dom/HTMLKeygenElement/keygen-expected.txt:
  • fast/dom/HTMLKeygenElement/keygen.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-30 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Adds layoutTestController.shadowRoot accessor to Mac DRT.
https://bugs.webkit.org/show_bug.cgi?id=57415

  • WebCore.exp.in: DRT needs to link WebCore::Element::shadowRoot

2011-03-30 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Adds layoutTestController.shadowRoot accessor to Mac DRT.
https://bugs.webkit.org/show_bug.cgi?id=57415

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowRoot:]):
  • DOM/WebDOMOperationsPrivate.h:

2011-03-30 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Adds layoutTestController.shadowRoot accessor to Mac DRT.
https://bugs.webkit.org/show_bug.cgi?id=57415

  • DumpRenderTree/LayoutTestController.cpp: (shadowRootCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowRoot):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowRoot):
7:25 PM Changeset in webkit [82535] by tkent@chromium.org
  • 8 edits
    2 deletes in trunk

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
https://bugs.webkit.org/show_bug.cgi?id=57424

Remove interactive-validation-lost-focusable.html because it has no
sense since r75555.

  • fast/forms/interactive-validation-lost-focusable-expected.txt: Removed.
  • fast/forms/interactive-validation-lost-focusable.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
https://bugs.webkit.org/show_bug.cgi?id=57424

r75555 made 'scroll' event asynchronous. So we don't need to worry about
deleting or moving a target node in scrollIntoViewIfNeeded().

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::validateInteractively): Remove unnecessary code.
7:21 PM Changeset in webkit [82534] by tkent@chromium.org
  • 5 edits in trunk

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r74895): Crash if input.type = 'file' twice
https://bugs.webkit.org/show_bug.cgi?id=57343

  • fast/forms/input-type-change3-expected.txt:
  • fast/forms/script-tests/input-type-change3.js: Add a new test.

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r74895): Crash if input.type = 'file' twice
https://bugs.webkit.org/show_bug.cgi?id=57343

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Don't call setAttribute() if the type is not changed.
7:08 PM Changeset in webkit [82533] by commit-queue@webkit.org
  • 10 edits in trunk

2011-03-30 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
https://bugs.webkit.org/show_bug.cgi?id=57353
<rdar://problem/9163983>

Updated following test in response to recent change in AppKit spell checker.

  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
  • platform/mac/editing/spelling/delete-autocorrected-word-1.html:

2011-03-30 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
https://bugs.webkit.org/show_bug.cgi?id=57353
<rdar://problem/9163983>

We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
panel. The latter function compensates for zooming, which we don't need in this case. We also
dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().

  • WebCore.exp.in:
  • dom/Range.cpp: (WebCore::Range::textQuads):
  • dom/Range.h:
  • editing/Editor.cpp: (WebCore::Editor::windowRectForRange):
  • editing/Editor.h:
  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors):
6:53 PM Changeset in webkit [82532] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-30 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Render fonts using skia when requested by platform context.
https://bugs.webkit.org/show_bug.cgi?id=56441

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::setupPaintForFont): (WebCore::paintSkiaText):
6:48 PM Changeset in webkit [82531] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Sandbox violations if you navigate a file URL via something other than a click
<rdar://problem/9016086>
https://bugs.webkit.org/show_bug.cgi?id=57519

  • WebProcess/WebPage/WebPage.cpp: (WebKit::shouldReuseCommittedSandboxExtension): Remove unnecessary restriction on extension reuse. Any type of file to file navigation should be allowed.
6:45 PM Changeset in webkit [82530] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up the sandbox parameter code
https://bugs.webkit.org/show_bug.cgi?id=57518

  • Shared/WebProcessCreationParameters.h: Make nsURLCachePath and uiProcessBundleResourcePath Strings to match the other paths we send over.
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): nsURLCachePath and uiProcessBundleResourcePath are now Strings.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::appendSandboxParameterPathInternal): (WebKit::appendReadwriteConfDirectory): (WebKit::appendReadonlySandboxDirectory): (WebKit::appendReadwriteSandboxDirectory): (WebKit::initializeSandbox): Make it more clear whether the directories we're adding are readonly or readwrite. No functionality change.


(WebKit::WebProcess::platformInitializeWebProcess):
nsURLCachePath is now a string.

6:32 PM Changeset in webkit [82529] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/9199518> Crash when focusing a styled editable element

Reviewed by Darin Adler.

Source/WebCore:

Test: editing/deleting/delete-button-background-image-none.html

  • editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement): Check all background layers for background images.

  • rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,

in the above function.

LayoutTests:

  • editing/deleting/delete-button-background-image-none-expected.txt: Added.
  • editing/deleting/delete-button-background-image-none.html: Added.
6:14 PM Changeset in webkit [82528] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Try once more to fix the EFL build.

  • platform/efl/RenderThemeEfl.cpp:
6:11 PM Changeset in webkit [82527] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Downloading a file fails due to a sandbox violation if the destination path is a symlink
https://bugs.webkit.org/show_bug.cgi?id=57517
<rdar://problem/8943865>

Make sure to resolve any symlinks in the given path when creating a sandbox extension handle.
Note that we can't use realpath or -[NSString stringByResolvingSymlinksInPath], because those calls
will fail if the pointed to file doesn't exist.

  • Shared/mac/SandboxExtensionMac.mm: (WebKit::resolveSymlinksInPath): New function that resolves all the symlinks in the given path.

(WebKit::SandboxExtension::createHandle):
Call resolveSymlinksInPath on the resulting path.

6:06 PM Changeset in webkit [82526] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ WebKit2 build.

  • Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: (WebKit::WebPage::platformCanHandleRequest):
5:44 PM Changeset in webkit [82525] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Regression: VO cursor doesn't follow KB focus back into HTML view
https://bugs.webkit.org/show_bug.cgi?id=57509

Reviewed by Darin Adler.

In WK2, because the web area never believes focus leave the area, sending the initial
focus change when moving back into the web area, does not trigger a notification.

That behavior needs to be overridden by explicitly posting a focused UI element change
at the appropriate time. This is only used in WK2, hence the absence of a layout test for now.

  • page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

5:11 PM Changeset in webkit [82524] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

WebHTMLView shouldn't resend noop: commands
https://bugs.webkit.org/show_bug.cgi?id=57504
<rdar://problem/9209390>

  • WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs, which we get e.g. when handling Cmd-key combos.
5:11 PM Changeset in webkit [82523] by mihaip@chromium.org
  • 36 edits
    28 copies
    98 adds in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix expected svg/ failures for Chromium Snow Leopard.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png.
  • platform/chromium-mac-leopard/svg/custom/dynamic-svg-document-creation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/grayscale-gradient-mask-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-creation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/non-scaling-stroke-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-skew-transformed-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/shapes-supporting-markers-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/shapes-supporting-markers-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/viewbox-syntax-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/viewbox-syntax-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png.
  • platform/chromium-mac-leopard/svg/filters/feDisplacementMap-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum.
  • platform/chromium-mac-leopard/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
  • platform/chromium-mac-leopard/svg/hixie/mixed/006-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/006-expected.checksum.
  • platform/chromium-mac-leopard/svg/hixie/mixed/006-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/006-expected.png.
  • platform/chromium-mac-leopard/svg/hixie/mixed/008-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/008-expected.checksum.
  • platform/chromium-mac-leopard/svg/hixie/mixed/008-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/008-expected.png.
  • platform/chromium-mac-leopard/svg/hixie/mixed/011-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/011-expected.checksum.
  • platform/chromium-mac-leopard/svg/hixie/mixed/011-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/mixed/011-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-intro-05-t-expected.png.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/dynamic-svg-document-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png: Added.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-mac/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png: Added.
  • platform/chromium-mac/svg/custom/grayscale-gradient-mask-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/grayscale-gradient-mask-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
  • platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-detach-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/use-detach-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/filters/feDisplacementMap-expected.png.
  • platform/chromium-mac/svg/custom/viewbox-syntax-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/viewbox-syntax-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.checksum:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/006-expected.checksum:
  • platform/chromium-mac/svg/hixie/mixed/006-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/008-expected.checksum:
  • platform/chromium-mac/svg/hixie/mixed/008-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/011-expected.checksum:
  • platform/chromium-mac/svg/hixie/mixed/011-expected.png:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:01 PM Changeset in webkit [82522] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Clean build fix

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Serialized project dependencies so projects

don't try to build in parallel (which doesn't mesh with our buildfailed mechanism).

5:00 PM Changeset in webkit [82521] by mdelaney@apple.com
  • 49 edits
    30 adds
    30 deletes in trunk

2011-03-30 Matthew Delaney <mdelaney@apple.com>

Reviewed by Chris Marrin.

Update fast/canvas tests to avoid dumping the render tree when possible
https://bugs.webkit.org/show_bug.cgi?id=57493

  • DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for accelerated drawing and accelerated drawing for canvas

2011-03-30 Matthew Delaney <mdelaney@apple.com>

Reviewed by Chris Marrin.

Update fast/canvas tests to avoid dumping the render tree when possible
https://bugs.webkit.org/show_bug.cgi?id=57493

  • fast/canvas/<various tests>: Added new expectations.
  • platform/mac/fast/canvas/<various tests>: Removed old expectations with Render Tree printouts.
5:00 PM Writing Layout Tests for DumpRenderTree edited by arv@chromium.org
Change the section about "Writing JavaScript-based DOM-only Test … (diff)
4:56 PM Changeset in webkit [82520] by morrita@google.com
  • 6 edits
    6 adds
    2 deletes in trunk

2011-03-30 MORITA Hajime <morrita@google.com>

box-shadow radii stays the same regardless of any spread set
https://bugs.webkit.org/show_bug.cgi?id=49726

  • Added test for multiple inset shadows.
  • Updated wrong expectations which are fixed by this change.
  • Moved some expectation file location to platform/mac because they don't match against non-mac platform results due to the difference between graphics backends.
  • fast/box-shadow/spread-multiple-inset-expected.txt: Added.
  • fast/box-shadow/spread-multiple-inset.html: Added.
  • fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
  • fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • fast/box-shadow/spread-multiple-normal.html: Changed to avoid overlapping boxes.
  • platform/mac/fast/box-shadow/spread-expected.checksum:
  • platform/mac/fast/box-shadow/spread-expected.png:
  • platform/mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/mac/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.

2011-03-30 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

box-shadow radii stays the same regardless of any spread set
https://bugs.webkit.org/show_bug.cgi?id=49726

  • Removed special shadowSpread handling path
  • Fixed broken multple inset shadow border computation.

Test: fast/box-shadow/spread-multiple-inset.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
4:53 PM Changeset in webkit [82519] by oliver@apple.com
  • 24 edits in trunk/Source/JavaScriptCore

Rollout r82500

4:33 PM Changeset in webkit [82518] by mdelaney@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed changelong entry typpos.

4:19 PM Changeset in webkit [82517] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-30 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
https://bugs.webkit.org/show_bug.cgi?id=57020

Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
4:15 PM Changeset in webkit [82516] by mdelaney@apple.com
  • 9 edits
    2 adds in trunk

2011-03-29 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG

https://bugs.webkit.org/show_bug.cgi?id=53134

  • wtf/Platform.h: Added in WTF flag for using the Accelerate framework

2011-03-29 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG

https://bugs.webkit.org/show_bug.cgi?id=53134

Test: fast/canvas/getPutImageDataPairTest.html

  • platform/graphics/cg/ImageBufferCG.cpp:

2011-03-25 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Use Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

  • fast/canvas/canvas-getImageData-expected.txt: Resetting expected results for this test due to test change.
  • fast/canvas/canvas-getImageData.html: Removed the section of this test that incorrectly assumes the rounding behavior of initial inputed data.
  • fast/canvas/getPutImageDataPairTest-expected.txt: Added.
  • fast/canvas/getPutImageDataPairTest.html: A new test to make sure that a batch of paired putImageData(getImageData) calls doesn't accumulate any error per the spec.
  • fast/canvas/rgba-parsing-expected.txt: Reset the results for this test since the initial rgba rounding values are now different. Note: the spec does not define how they *should* be rounded, so having them there is basically just for bookkeeping to know when our rounding behavior changes since it could be early warning of related real issues.
4:04 PM Changeset in webkit [82515] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Should turn off frame pointer omission (FPO) for Release (not Production) builds
https://bugs.webkit.org/show_bug.cgi?id=54403

Reviewed by Adam Roben.

Leave it enabled for Windows Production builds.
Disabling this optimization improves stack traces for memory and performance tools like umdh and xperf.

We use both /Oy- and OmitFramePointers="false" since OmitFramePointers="false" isnt' enough
to override /O2.

  • win/tools/vsprops/release.vsprops:
3:58 PM Changeset in webkit [82514] by Adam Roben
  • 2 edits in trunk/Tools

Stop ignoring leaks in CGGradientCreateWithColorStops

Fixes <rdar://problem/7888547>.

Rubber-stamped by John Sullivan.

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks): Removed some code to ignore those leaks.

3:48 PM Changeset in webkit [82513] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Try to fix the WinCairo build.

  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::platformInit): Fix misspelling of GraphicsContextPlatformPrivateToplevel.
3:43 PM Changeset in webkit [82512] by sfalken@apple.com
  • 41 edits in trunk/Source

Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508

Reviewed by Adam Roben.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/QTMovieWinProduction.vsprops:
  • WebCore.vcproj/QTMovieWinRelease.vsprops:
  • WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
  • WebCore.vcproj/WebCoreProduction.vsprops:
  • WebCore.vcproj/WebCoreRelease.vsprops:
  • WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:

Source/WebKit/win:

  • WebKit.vcproj/InterfacesProduction.vsprops:
  • WebKit.vcproj/InterfacesRelease.vsprops:
  • WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
  • WebKit.vcproj/WebKitGUIDProduction.vsprops:
  • WebKit.vcproj/WebKitGUIDRelease.vsprops:
  • WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
  • WebKit.vcproj/WebKitLibProduction.vsprops:
  • WebKit.vcproj/WebKitLibRelease.vsprops:
  • WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:

Source/WebKit2:

  • win/WebKit2Production.vsprops:
  • win/WebKit2Release.vsprops:
  • win/WebKit2ReleaseCairoCFLite.vsprops:
  • win/WebKit2WebProcessProduction.vsprops:
  • win/WebKit2WebProcessRelease.vsprops:
  • win/WebKit2WebProcessReleaseCairoCFLite.vsprops:
3:42 PM Changeset in webkit [82511] by sfalken@apple.com
  • 37 edits in trunk/Tools

Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747

Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
Reviewed by Alexey Proskuryakov.

By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".

These files don't add new functionality, so don't need extra tests.

  • DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3:41 PM Changeset in webkit [82510] by sfalken@apple.com
  • 2 edits
    1 copy in trunk/WebKitLibraries

Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508

Reviewed by Adam Roben.

  • win/tools/vsprops/release.vsprops:
  • win/tools/vsprops/releaseproduction.vsprops: Copied from WebKitLibraries/win/tools/vsprops/release.vsprops.
3:39 PM Changeset in webkit [82509] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Explicitly prevent testapi and minidom from being installed rather than relying
on Xcode's current behavior of not installing if INSTALL_PATH is not explicitly
set at the target level.

Reviewed by Adam Roben.

<rdar://problem/9206357>

3:31 PM Changeset in webkit [82508] by levin@chromium.org
  • 11 edits
    5 adds in trunk

Add some dynamic annotations to JavaScriptCore/wtf
https://bugs.webkit.org/show_bug.cgi?id=53747

Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
Reviewed by Alexey Proskuryakov.

By using these annotations we can improve the precision of finding
WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".

These files don't add new functionality, so don't need extra tests.

Source/JavaScriptCore:

(WTFAnnotateBenignRaceSized):
(WTFAnnotateHappensBefore):
(WTFAnnotateHappensAfter):

  • wtf/DynamicAnnotations.h: Added.
  • wtf/ThreadSafeRefCounted.h:

(WTF::ThreadSafeRefCountedBase::derefBase):

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/DynamicAnnotations.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3:27 PM Changeset in webkit [82507] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

Ensure consistent, readable working directory for WebProcess before entering sandbox
<rdar://problem/8951176>

Patch by Ivan Krstić <ike@apple.com> on 2011-03-30
Reviewed by Oliver Hunt.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:13 PM Changeset in webkit [82506] by jberlin@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

http/tests/uri/username-with-no-hostname.html is flaky due to preload scanner
https://bugs.webkit.org/show_bug.cgi?id=57496

Unreviewed, this test has been flakey on a bunch of platforms, so disable it to keep the
bots green.

  • http/tests/uri/username-with-no-hostname.html: Removed.
  • http/tests/uri/username-with-no-hostname.html-disabled: Copied from http/tests/uri/username-with-no-hostname.html.
3:09 PM Changeset in webkit [82505] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Skip a test which requires missing resource load callback dumps on GTK+.
Better clump another failing test.

  • platform/gtk/Skipped: Update the skipped list.
3:04 PM Changeset in webkit [82504] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Try to fix the EFL build.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): Use the new cairo_t accessor on the platform context.
3:00 PM Changeset in webkit [82503] by inferno@chromium.org
  • 8 edits
    2 adds in trunk

2011-03-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash when removing inline style
from a node that is not a html element.
https://bugs.webkit.org/show_bug.cgi?id=57348

  • editing/execCommand/remove-format-non-html-element-crash-expected.txt: Added.
  • editing/execCommand/remove-format-non-html-element-crash.html: Added.

2011-03-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Fix wrong type assumptions in editing code. Move code
from ASSERTs to hard checks.
https://bugs.webkit.org/show_bug.cgi?id=57348

Test: editing/execCommand/remove-format-non-html-element-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • editing/ApplyStyleCommand.cpp: (WebCore::getRGBAFontColor): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): (WebCore::EditingStyle::prepareToApplyAt):
  • editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
2:48 PM Changeset in webkit [82502] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-30 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Speed up clipping in accelerated 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=57464

Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::PathAndTransform::PathAndTransform): New structure to keep track of the CTM at the time the clipping path was added. (WebCore::GLES2Canvas::State::State): Replace m_clippingEnabled with a count of total clipping paths. (WebCore::GLES2Canvas::clearRect): Check the total clipping path count, instead of m_clippingEnabled. (WebCore::GLES2Canvas::fillPath): (WebCore::GLES2Canvas::fillRect): Perform state application after doing shadows. This is necessary since restore() may now leave clipping enabled. (WebCore::GLES2Canvas::clipPath): Explicitly specify the stencil operation as INCR. Store the current transformation when saving clipping paths. (WebCore::GLES2Canvas::restore): Don't clear the stencil buffer and re-draw active paths on each restore. Erase the old paths with DECR. (WebCore::GLES2Canvas::drawTexturedRect): Check m_numClippingPaths instead of m_clippingEnabled. (WebCore::GLES2Canvas::beginShadowDraw): Perform state application when drawing hard shadows. (WebCore::GLES2Canvas::endShadowDraw): Check m_numClippingPaths instead of m_clippingEnabled. (WebCore::GLES2Canvas::beginStencilDraw): Make the stencil op a parameter to beginShadowDraw(). (WebCore::GLES2Canvas::applyClipping): Compare against the total number of stencil paths, not just the ones in the current state.
  • platform/graphics/chromium/GLES2Canvas.h: Make the stencil op a parameter to beginShadowDraw().
2:44 PM Changeset in webkit [82501] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
https://bugs.webkit.org/show_bug.cgi?id=57419

Refactoring, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
  • dom/MouseEvent.h: Added decl.
2:39 PM Changeset in webkit [82500] by oliver@apple.com
  • 24 edits in trunk/Source/JavaScriptCore

2011-03-30 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695

Make StructureChain GC allocated, and make the various owners
mark it correctly.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures): (JSC::PolymorphicAccessStructureList::markAggregate): (JSC::Instruction::Instruction):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::markAggregate):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initPutByIdTransition):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITStubs.cpp: (JSC::getPolymorphicAccessStructureListSlot): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeChain):
  • runtime/JSObject.h: (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::get): (JSC::JSPropertyNameIterator::markChildren):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
  • runtime/MarkStack.h: (JSC::MarkStack::append):
  • runtime/Structure.h: (JSC::Structure::cachedPrototypeChainSlot):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):
  • runtime/StructureChain.h: (JSC::StructureChain::create): (JSC::StructureChain::createStructure):
2:06 PM Changeset in webkit [82499] by arv@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-30 Erik Arvidsson <arv@chromium.org>

Reviewed by Alexey Proskuryakov.

Missing DOM bindings for a ping
https://bugs.webkit.org/show_bug.cgi?id=51955

  • fast/dom/ping-attribute-dom-binding-expected.txt: Added.
  • fast/dom/ping-attribute-dom-binding.html: Added.

2011-03-30 Erik Arvidsson <arv@chromium.org>

Reviewed by Alexey Proskuryakov.

Missing DOM bindings for a ping
https://bugs.webkit.org/show_bug.cgi?id=51955

Test: fast/dom/ping-attribute-dom-binding.html

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
2:00 PM Changeset in webkit [82498] by mihaip@chromium.org
  • 21 edits
    20 copies
    1 move
    1 add
    1 delete in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix remaining unexpected Chromium Snow Leopard image failures.

Current Leopard baselines in chromium-mac/ are moved to
chromium-mac-leopard/.

  • platform/chromium-mac-leopard/fast/forms/input-align-image-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.checksum.
  • platform/chromium-mac-leopard/fast/forms/input-align-image-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.png.
  • platform/chromium-mac-leopard/fast/forms/input-type-change-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.checksum.
  • platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.png.
  • platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum.
  • platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png.
  • platform/chromium-mac-leopard/fast/text/drawBidiText-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.checksum.
  • platform/chromium-mac-leopard/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.png.
  • platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.checksum.
  • platform/chromium-mac-leopard/media/video-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum.
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png.
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum.
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png.
  • platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/input-align-image-expected.checksum:
  • platform/chromium-mac/fast/forms/input-align-image-expected.png:
  • platform/chromium-mac/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-mac/fast/forms/input-type-change-expected.png:
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum:
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-mac/fast/text/drawBidiText-expected.checksum:
  • platform/chromium-mac/fast/text/drawBidiText-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum:
  • platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
1:57 PM Changeset in webkit [82497] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

REGRESSION (r82320): Spacebar no longer pages down
https://bugs.webkit.org/show_bug.cgi?id=57423
<rdar://problem/9207702>

Also includes some unrelated cleanup that I had in my tree.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is being dispatched to the right frame. (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL. (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=". Even if this specific command hasn't been handled, that doesn't nullify side effects from previous commands. (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for another WebHTMLView NSTextInput method to be called from within insertText:, so no one is going to look at it.
1:56 PM Changeset in webkit [82496] by Martin Robinson
  • 24 edits
    2 copies in trunk/Source

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

No new tests. This patch is only a code cleanup.

  • GNUmakefile.am:
  • platform/graphics/GraphicsContext.h: The platform context is no longer a cairo_t, but our new class the PlatformContextCairo.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
  • platform/graphics/cairo/FontCairo.cpp: Ditto.
  • platform/graphics/cairo/GradientCairo.cpp: Ditto.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical changes which now reference platformContext()->cr() to get the cairo_t.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the PlatformContextCairo instead of the cairo_t.
  • platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/PathCairo.cpp: Ditto.
  • platform/graphics/cairo/PlatformContextCairo.cpp: Added.
  • platform/graphics/cairo/PlatformContextCairo.h: Added.
  • platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
  • platform/graphics/gtk/IconGtk.cpp: Ditto.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out m_data with a private section containing the platform context instead of just a cairo_t.
  • platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: Ditto.

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

  • webkit/webkitwebframe.cpp: (draw_page_callback):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw):

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

  • WebFrame.cpp: (hdcFromContext): Modify this method to take PlatformContextCairo instead of a cairo_t. (WebFrame::spoolPage): Update to reflect new platform context. (WebFrame::spoolPages): Ditto.
  • WebFrame.h: Ditto.
1:44 PM Changeset in webkit [82495] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Remove unnecessary NDEBUG define.

Rubber stamped by Adam Roben.

  • win/tools/vsprops/production.vsprops:
1:43 PM Changeset in webkit [82494] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-30 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r82465.

  • CMakeListsWinCE.txt:
1:38 PM Changeset in webkit [82493] by sfalken@apple.com
  • 38 edits
    1 add in trunk

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

  • win/tools/vsprops/common.vsprops:
  • win/tools/vsprops/production.vsprops: Added.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

  • WebKit.vcproj/InterfacesProduction.vsprops:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKitGUIDProduction.vsprops:
  • WebKit.vcproj/WebKitLibProduction.vsprops:

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

  • WebCore.vcproj/QTMovieWinProduction.vsprops:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCoreProduction.vsprops:

2011-03-30 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson.

WebKit2: Attempting to view css file from url causes it to download
<rdar://problem/9102611>
https://bugs.webkit.org/show_bug.cgi?id=57501

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType): Match WebKit1 by allowing any MIME type that starts with "text/" except the ones we explicitly blacklist.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
  • DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
  • DumpRenderTree/win/ImageDiffProduction.vsprops:
  • FindSafari/FindSafariProduction.vsprops:
  • FindSafari/FindSafariReleasePGO.vsprops:
  • MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
  • WebKitAPITest/WebKitAPITestProduction.vsprops:
  • WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
  • WebKitTestRunner/win/InjectedBundleProduction.vsprops:
  • WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
  • WinLauncher/WinLauncherProduction.vsprops:
  • record-memory-win/record-memory-winProduction.vsprops:
1:30 PM Changeset in webkit [82492] by weinig@apple.com
  • 10 edits in trunk/Source

WebKit2: Attempting to view css file from url causes it to download
<rdar://problem/9102611>
https://bugs.webkit.org/show_bug.cgi?id=57501

Reviewed by Brady Eidson.

Source/WebCore:

  • WebCore.exp.in:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeUnsupportedTextMIMETypes):
(WebCore::initializeMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):

  • platform/MIMETypeRegistry.h:

Add set of unsupported text MIME types, taken from WebKit/mac.

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.h:
  • WebView/WebHTMLRepresentation.mm:

(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLView unsupportedTextMIMETypes]):
Re-factor unsupportedTextMIMETypes to pull from WebCore's
MIMETypeRegistry, so that the list can be shared with WebKit2.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):
Match WebKit1 by allowing any MIME type that starts with "text/"
except the ones we explicitly blacklist.

1:29 PM Changeset in webkit [82491] by mihaip@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Put expected PNG for fast/multicol/max-height-columns-block.html in the
right directory (fix after r82480).

  • platform/chromium-mac-leopard/fast/multicol/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png.
1:15 PM Changeset in webkit [82490] by mihaip@chromium.org
  • 19 edits
    9 copies
    15 moves
    15 deletes in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix more tests for Chromium Snow Leopard.

Most are due to mismatched checksum files (like r82480), some also
needed updated chromium-mac baselines.

  • platform/chromium-mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Renamed from LayoutTests/platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png.
  • platform/chromium-mac-leopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png.
  • platform/chromium-mac-leopard/editing/inserting/4875189-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/4875189-2-expected.png.
  • platform/chromium-mac-leopard/editing/pasteboard/5387578-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/5387578-expected.png.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png.
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png.
  • platform/chromium-mac-leopard/fast/block/float/014-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/float/014-expected.png.
  • platform/chromium-mac-leopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png.
  • platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png.
  • platform/chromium-mac-leopard/fast/canvas/canvas-zoom-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/canvas/canvas-zoom-expected.png.
  • platform/chromium-mac-leopard/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png.
  • platform/chromium-mac-leopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png.
  • platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png.
  • platform/chromium-mac-leopard/fast/inline/inline-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/inline-focus-ring-expected.png.
  • platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png.
  • platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-onload-expected.png.
  • platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-sizing-expected.png.
  • platform/chromium-mac-leopard/fast/text/basic/002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/basic/002-expected.png.
  • platform/chromium-mac-leopard/fast/text/word-break-soft-hyphen-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png.
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/focus-ring-expected.png.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.png.
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.checksum:
  • platform/chromium-mac/fast/block/float/014-expected.png:
  • platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Removed.
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum:
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Removed.
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Removed.
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
  • platform/chromium-mac/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac/fast/text/basic/002-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.checksum: Removed.
1:14 PM Changeset in webkit [82489] by robert@webkit.org
  • 18 edits in trunk

2011-03-30 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966

Unskip http/tests/navigation/go-back-to-error-page.html

https://bugs.webkit.org/show_bug.cgi?id=52614

  • platform/qt/Skipped:

2011-03-30 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966

Add DRT support for loading an alternate HTML string
for error pages. This allows Qt to unskip
http/tests/navigation/go-back-to-error-page.html.

https://bugs.webkit.org/show_bug.cgi?id=52614

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAlternateHtml):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-03-30 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
Unskip http/tests/navigation/go-back-to-error-page.html

Also add the location of DumpRenderTreeSupportQt.h
to DRT's include paths.

https://bugs.webkit.org/show_bug.cgi?id=52614

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/GCControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::queueLoadHTMLString):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp:
  • DumpRenderTree/qt/TextInputControllerQt.cpp:
  • DumpRenderTree/qt/WorkQueueItemQt.cpp: (LoadAlternateHTMLStringItem::invoke):
  • DumpRenderTree/qt/WorkQueueItemQt.h: (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/launcherwindow.h:
1:02 PM Changeset in webkit [82488] by mihaip@chromium.org
  • 1 edit
    3 moves
    3 deletes in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix editing/deleting for Chromium Snow Leopard.

Same mismatched checksum story as r82480.

  • platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/4845371-expected.png.
  • platform/chromium-mac-leopard/editing/deleting/5126166-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5126166-expected.png.
  • platform/chromium-mac-leopard/editing/deleting/5483370-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5483370-expected.png.
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Removed.
12:58 PM Changeset in webkit [82487] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when closing "Add Bookmark" dialog using the Enter Key
https://bugs.webkit.org/show_bug.cgi?id=57294
<rdar://problem/9044756>

Reviewed by Darin Adler.

Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
functions that could destroy the frame.

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):

12:49 PM Changeset in webkit [82486] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/696

Merge 81970 - 2011-03-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
https://bugs.webkit.org/show_bug.cgi?id=56958

  • printing/page-count-layout-overflow-expected.txt: Added.
  • printing/page-count-layout-overflow.html: Added.

2011-03-25 Dave Hyatt <hyatt@apple.com>

Reviewed by Adele Peterson.

REGRESSION(r77257): Only first page of a document is printed
https://bugs.webkit.org/show_bug.cgi?id=56958

Test: printing/page-count-layout-overflow.html

  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination): Moved clearing of overflow

to the right place.

TBR=Dimitri Glazkov

12:45 PM Changeset in webkit [82485] by mihaip@chromium.org
  • 21 edits
    10 copies in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix svg/dynamic-updates/SVGFEConvolveMatrixElement* for Chromium Snow Leopard.

There were lone .checksum files in chromium-mac-leopard/ (similar to
r82480), now they should have corresponding .pngs too.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
12:43 PM Changeset in webkit [82484] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-03-30 Adam Barth <abarth@webkit.org>

Reviewed by Adam Roben.

SheriffBot rollouts take too long
https://bugs.webkit.org/show_bug.cgi?id=57498

We used to build before landing rollouts via the commit-queue to
prevent further breakage, but now that our individual commit-queue
machines are slower, building takes too long. I can't remember the
last time a rollout broke compile. It seems like just landing the
patch is the better trade-off.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
12:41 PM Changeset in webkit [82483] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Update some GTK+ results after r82411.

  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.checksum:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt:
12:31 PM Changeset in webkit [82482] by abarth@webkit.org
  • 7 edits
    2 deletes in trunk

2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82463.
http://trac.webkit.org/changeset/82463
https://bugs.webkit.org/show_bug.cgi?id=57482

Assertion failure in Node::rendererIsEditable on multiple
editing tests (Requested by aroben|meeting on #webkit).

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82463.
http://trac.webkit.org/changeset/82463
https://bugs.webkit.org/show_bug.cgi?id=57482

Assertion failure in Node::rendererIsEditable on multiple
editing tests (Requested by aroben|meeting on #webkit).

  • css3/unicode-bidi-plaintext-parse-expected.txt: Removed.
  • css3/unicode-bidi-plaintext-parse.html: Removed.
12:21 PM Changeset in webkit [82481] by jam@chromium.org
  • 15 edits in trunk

2011-03-29 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium]: Remove the code that called WebViewClient for spelling now that chromium is updated
https://bugs.webkit.org/show_bug.cgi?id=57396

  • DEPS:
  • public/WebFrame.h:
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::handleCurrentKeyboardEvent):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::requestCheckingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing):
  • src/WebViewImpl.cpp: (WebKit::WebView::create):
  • src/WebViewImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
  • tests/PopupMenuTest.cpp: (WebKit::SelectPopupMenuTest::SetUp):
  • tests/WebFrameTest.cpp: (WebKit::TEST_F):
  • tests/WebPageSerializerTest.cpp: (WebKit::WebPageSerializerTest::SetUp):
11:50 AM Changeset in webkit [82480] by mihaip@chromium.org
  • 1 edit
    6 moves
    6 deletes in trunk/LayoutTests

2011-03-30 Mihai Parparita <mihaip@chromium.org>

Fix fast/multicol for Chromium Snow Leopard.

We somehow ended up with only .checksum files in chromium-mac-leopard/
(due to r67681 and then moved by r73376). The checksums in chromium-mac/
were identical, so I deleted those and moved the corresponding .png
to chromium-mac-leopard/, to live alongside its checksum.

The mac/ baselines are correct for Snow Leopard, so we don't actually
need any updates to get the tests to pass.

  • platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png.
  • platform/chromium-mac-leopard/fast/multicol/margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/margin-collapse-expected.png.
  • platform/chromium-mac-leopard/fast/multicol/positioned-split-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/positioned-split-expected.png.
  • platform/chromium-mac-leopard/fast/multicol/single-line-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/single-line-expected.png.
  • platform/chromium-mac-leopard/fast/multicol/table-margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png.
  • platform/chromium-mac-leopard/fast/multicol/unsplittable-inline-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png.
  • platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/single-line-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.
11:47 AM Changeset in webkit [82479] by abarth@webkit.org
  • 3 edits
    1 delete in trunk

Remove platform/chromium-mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=57486

Tools:

This directory no longer exists, so we can remove it from the fallback
chain.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

LayoutTests:

Remove empty directories.

  • platform/chromium-mac-snowleopard: Removed.
11:46 AM Changeset in webkit [82478] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: signal sequence.
https://bugs.webkit.org/show_bug.cgi?id=57049

Reviewed by Kenneth Rohde Christiansen.

This is the first step in QNetworkReplyHandler. The main objective here is to create simple invariants:

1 - that the signals metadatachanged, readyRead and finished will come in this order.
2 - that signals metadatachanged and finished will be called exactly once.

Having these invariants further simplifications will be possible and will come in future patches.

Class QNetworkReplyWrapper was created to handle QNetworkReply object. To connect to the signals of it
instead of connecting to the signals of QNetworkReply is what guarantees the sequence of the signals.
QNetworkReplyWrapper will be used in future to perform mime type sniffing before sending
metadatachanged signal.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::resetConnections):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyWrapper::reply):
(WebCore::QNetworkReplyWrapper::redirectionTargetUrl):
(WebCore::QNetworkReplyWrapper::encoding):
(WebCore::QNetworkReplyWrapper::advertisedMimeType):
(WebCore::QNetworkReplyHandler::reply):

11:35 AM Changeset in webkit [82477] by sfalken@apple.com
  • 45 edits
    22 moves in trunk

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465

  • JavaScriptCore.vcproj/JavaScriptCore.sln:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Removed.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Removed.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.vcproj/jsc/jscProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops.
  • JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Removed.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj:
  • JavaScriptCore.vcproj/testapi/testapiProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops.
  • JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Removed.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
  • WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
  • WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
  • WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
  • WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops.
  • WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Removed.
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.submit.sln:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:
  • WebCore.vcproj/WebCoreProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/WebCoreReleaseLTCG.vsprops.
  • WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Removed.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465

  • win/WebKit2.submit.sln:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:
  • win/WebKit2Production.vsprops: Copied from Source/WebKit2/win/WebKit2ReleaseLTCG.vsprops.
  • win/WebKit2ReleaseLTCG.vsprops: Removed.
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessProduction.vsprops: Copied from Source/WebKit2/win/WebKit2WebProcessReleaseLTCG.vsprops.
  • win/WebKit2WebProcessReleaseLTCG.vsprops: Removed.

2011-03-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465

  • DumpRenderTree/DumpRenderTree.sln:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
  • DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
  • DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
  • FindSafari/FindSafari.vcproj:
  • FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
  • FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
  • MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
  • MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
  • MiniBrowser/MiniBrowser.vcproj:
  • Scripts/webkitdirs.pm:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
  • WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
  • WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
  • WebKitTestRunner/WebKitTestRunner.sln:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  • WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
  • WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
  • WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
  • WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
  • record-memory-win/record-memory-win.vcproj:
  • record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
  • record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
11:23 AM Changeset in webkit [82476] by Csaba Osztrogonác
  • 28 edits
    2 adds in trunk/LayoutTests

[Qt] Add 3 failing tests to the Skipped list because of different bugs.
Additionally update Qt specific results after r82280 and unskip them.

  • platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Added.
  • platform/qt/editing/pasteboard/paste-text-011-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/fast/css-generated-content/014-expected.checksum:
  • platform/qt/fast/css-generated-content/014-expected.png:
  • platform/qt/fast/css-generated-content/014-expected.txt:
  • platform/qt/fast/css/word-space-extra-expected.checksum:
  • platform/qt/fast/css/word-space-extra-expected.png:
  • platform/qt/fast/css/word-space-extra-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.checksum:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
11:21 AM Changeset in webkit [82475] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

WebKit2: WebProcess is using 89%, while viewing a PDF
https://bugs.webkit.org/show_bug.cgi?id=57471

Break a never ending display/update cycle between the UIProcess and the WebProcess
by clearing the dirty region when a page has a custom representation (like a PDF).
Also, avoid the issue where possible by not setting the dirty region in the same case.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): Bail early if mainFrameHasCustomRepresentation(). (WebKit::DrawingAreaImpl::scroll): Ditto. (WebKit::DrawingAreaImpl::display): Both bail early and clear m_dirtyRegion if

mainFrameHasCustomRepresentation().

11:20 AM Changeset in webkit [82474] by abarth@webkit.org
  • 1 edit
    51 moves in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Move results from chromium-mac-snowleopard to chromium-mac. We
shouldn't have any results in chromium-mac-snowleopard until we start
worrying about Lion.

This patch overwrites fast/transforms/shadows in chromium-mac, which
doesn't seem to be visible to any platform, as I understand things.

  • platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.txt: Removed.
  • platform/chromium-mac/css1/box_properties/clear-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum.
  • platform/chromium-mac/css1/box_properties/clear-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png.
  • platform/chromium-mac/css1/box_properties/float-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum.
  • platform/chromium-mac/css1/box_properties/float-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-mac/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png.
  • platform/chromium-mac/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum.
  • platform/chromium-mac/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png.
  • platform/chromium-mac/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png.
  • platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum.
  • platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png.
  • platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum.
  • platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png.
  • platform/chromium-mac/fast/block/positioning/047-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum.
  • platform/chromium-mac/fast/block/positioning/047-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png.
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum.
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png.
  • platform/chromium-mac/fast/gradients/background-clipped-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum.
  • platform/chromium-mac/fast/gradients/background-clipped-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png.
  • platform/chromium-mac/fast/replaced/selection-rect-transform-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum.
  • platform/chromium-mac/fast/replaced/selection-rect-transform-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png.
  • platform/chromium-mac/fast/text/whitespace/tab-character-basics-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum.
  • platform/chromium-mac/fast/text/whitespace/tab-character-basics-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png.
  • platform/chromium-mac/fast/transforms/diamond-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum.
  • platform/chromium-mac/fast/transforms/diamond-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum: Replaced with LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Replaced with LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png.
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum.
  • platform/chromium-mac/fast/transforms/transformed-caret-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png.
  • platform/chromium-mac/svg/text/bidi-embedded-direction-expected.checksum: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.checksum.
  • platform/chromium-mac/svg/text/bidi-embedded-direction-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.png.
  • platform/chromium-mac/svg/text/bidi-embedded-direction-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.txt.
11:12 AM Changeset in webkit [82473] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
https://bugs.webkit.org/show_bug.cgi?id=57477
<rdar://problem/9178751>

Reviewed by Anders Carlsson.

If someone has called startObservingCookieChanges, and the WebProcess crashes and restarts, the UIProcess
will call stopObservingCookieChanges when cookieStorageAdapter is nil.

The assert is wrong when the web process crashes, and there is no harm in dispatching a message to nil,
so remove the assert.

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::stopObservingCookieChanges):

11:11 AM Changeset in webkit [82472] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Snow Leopard build.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

10:52 AM Changeset in webkit [82471] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 contextual menu looks different than the rest of the OS
<rdar://problem/9172935>
https://bugs.webkit.org/show_bug.cgi?id=57475

Reviewed by Anders Carlsson.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):
Use correct SPI for showing a context menu. The dummy view is also
not necessary, so remove it.

10:50 AM Changeset in webkit [82470] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Leopard build.

  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):

10:50 AM Changeset in webkit [82469] by morrita@google.com
  • 8 edits in trunk

2011-03-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
https://bugs.webkit.org/show_bug.cgi?id=56573

Added:

  • WebBindins::makeNode() to convert WebNode to a JS object, and
  • WebElement::shadowRoot().
  • public/WebBindings.h:
  • public/WebElement.h:
  • src/WebBindings.cpp: (WebKit::makeNodeImpl): (WebKit::WebBindings::makeNode):
  • src/WebElement.cpp: (WebKit::WebElement::shadowRoot):

2011-03-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
https://bugs.webkit.org/show_bug.cgi?id=56573

Added LayoutTestController.shadowRoot() to Chromium DRT.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowRoot):
  • DumpRenderTree/chromium/LayoutTestController.h:
10:43 AM Changeset in webkit [82468] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Note that this test is flaky.

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [82467] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when NPN_Evaluate removes the plug-in frame
https://bugs.webkit.org/show_bug.cgi?id=57474
<rdar://problem/9191396>

Get a reference to the frame since it can be nulled out if running the JavaScript code
causes the plug-in's containing frame to be removed from the frame tree.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::evaluate):
10:35 AM Changeset in webkit [82466] by abarth@webkit.org
  • 1 edit
    23 deletes in trunk/LayoutTests

Remove empty directories in platform/mac-snowleopard, as requested by
Mark Rowe.

  • platform/mac-snowleopard/css2.1: Removed.
  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/deleting: Removed.
  • platform/mac-snowleopard/editing/inserting: Removed.
  • platform/mac-snowleopard/editing/pasteboard: Removed.
  • platform/mac-snowleopard/fast/backgrounds: Removed.
  • platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
  • platform/mac-snowleopard/fast/block: Removed.
  • platform/mac-snowleopard/fast/block/float: Removed.
  • platform/mac-snowleopard/fast/borders: Removed.
  • platform/mac-snowleopard/fast/canvas: Removed.
  • platform/mac-snowleopard/fast/css: Removed.
  • platform/mac-snowleopard/fast/dom: Removed.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement: Removed.
  • platform/mac-snowleopard/fast/images: Removed.
  • platform/mac-snowleopard/fast/inline: Removed.
  • platform/mac-snowleopard/fast/inline-block: Removed.
  • platform/mac-snowleopard/fast/multicol: Removed.
  • platform/mac-snowleopard/fast/replaced: Removed.
  • platform/mac-snowleopard/fast/text/basic: Removed.
  • platform/mac-snowleopard/media: Removed.
  • platform/mac-snowleopard/plugins: Removed.
  • platform/mac-snowleopard/scrollbars: Removed.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
  • platform/mac-snowleopard/svg/custom: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates: Removed.
  • platform/mac-snowleopard/svg/filters: Removed.
  • platform/mac-snowleopard/svg/text: Removed.
  • platform/mac-snowleopard/tables: Removed.
  • platform/mac-snowleopard/tables/mozilla: Removed.
  • platform/mac-snowleopard/tables/mozilla/core: Removed.
  • platform/mac-snowleopard/tables/mozilla_expected_failures: Removed.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs: Removed.
10:28 AM Changeset in webkit [82465] by weinig@apple.com
  • 25 edits
    3 copies
    1 delete in trunk/Source

Add default localization strategy that can be shared by WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57406

Reviewed by Anders Carlsson.

Source/WebCore:

Currently, only WebKit2 uses this default strategy, but WebKit1 should be able
to adopt it soon.

  • platform/DefaultLocalizationStrategy.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp.

(WebCore::DefaultLocalizationStrategy::DefaultLocalizationStrategy):

  • platform/DefaultLocalizationStrategy.h: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h.

Copy the implementation of the Localization strategy from WebKit2 into a shared default strategy.

  • platform/LocalizedStrings.cpp:

(WebCore::localizedString):
Add default implementation of localization bottleneck function.

  • platform/LocalizedStrings.h:

Add localization macros here, instead of defining them in the above layer.

  • platform/PlatformStrategies.cpp:

(WebCore::PlatformStrategies::createLocalizationStrategy):

  • platform/PlatformStrategies.h:

Add default implementation of strategy creation function which creates the default strategy.

  • platform/win/LocalizedStringsWin.cpp: Copied from Source/WebCore/platform/mac/LocalizedStringsMac.mm.

(WebCore::localizedString):
Add stub for windows, this will be update to pull from the bundle in a follow up patch.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

Source/WebKit2:

  • Shared/WebLocalizableStrings.h: Removed.

Removed in favor of using WebCore/LocalizedStrings.h directly.

  • PluginProcess/mac/PluginProcessMac.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
  • WebProcess/mac/WebProcessMac.mm:

Use WebCore/LocalizedStrings.h directly.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Remove localization strategy override in favor of using new default implementation.

  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Remove WebLocalizableStrings.h

10:22 AM Changeset in webkit [82464] by abecsi@webkit.org
  • 5 edits in trunk

2011-03-30 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708

Implement fast-path parsing for percentage color values.

Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html

Relanding with rounding fix after it was rolled out in r82315.

  • fast/canvas/rgba-parsing-expected.txt: Add new test cases.
  • fast/canvas/script-tests/rgba-parsing.js: Ditto.

2011-03-30 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708

Implement fast-path parsing for percentage color values.

Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html

Relanding with rounding fix after it was rolled out in r82315.

  • css/CSSParser.cpp: (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double. (WebCore::parseDouble): Function for parsing double values if they are valid. (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values. (WebCore::parseAlphaValue): Use the new functions. (WebCore::CSSParser::parseColor): Ditto.
10:20 AM Changeset in webkit [82463] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-03-30 Ofri Wolfus <ofri@dhcp-172-28-40-178.tlv.corp.google.com>

Reviewed by Eric Seidel.

Add support for parsing unicode-bidi: -webkit-plaintext.
https://bugs.webkit.org/show_bug.cgi?id=57457

  • css3/unicode-bidi-plaintext-parse-expected.txt: Added.
  • css3/unicode-bidi-plaintext-parse.html: Added.

2011-03-30 Ofri Wolfus <ofri@dhcp-172-28-40-178.tlv.corp.google.com>

Reviewed by Eric Seidel.

Add support for parsing unicode-bidi: -webkit-plaintext.
https://bugs.webkit.org/show_bug.cgi?id=57457

Test: css3/unicode-bidi-plaintext-parse.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
10:18 AM Changeset in webkit [82462] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-30 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove unused variables in GraphicsContext::fillRect()

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
10:10 AM Changeset in webkit [82461] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
https://bugs.webkit.org/show_bug.cgi?id=57442

When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.

No new tests as existing test covers this case.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::reachedEndOfTextRenderer):
10:01 AM Changeset in webkit [82460] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Assertion failure in plug-in process when calling WKPluginSiteDataManagerGetSitesWithData
https://bugs.webkit.org/show_bug.cgi?id=57468
<rdar://problem/9199089>

Call decrementLoadCount from removeWebProcessConnection instead of startShutdownTimerIfNecessary,
otherwise we'll get a load count underflow when a connection is never created.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::removeWebProcessConnection): (WebKit::PluginProcess::createWebProcessConnection): (WebKit::PluginProcess::startShutdownTimerIfNecessary):
9:51 AM Changeset in webkit [82459] by mario@webkit.org
  • 10 edits
    2 adds in trunk

2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Added new layout test to check that roles are correct in GTK.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Added.
  • platform/gtk/accessibility/aria-roles-unignored.html: Added.

2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Define new roles in WebCore and map them to ATK accordingly.

Test: platform/gtk/accessibility/aria-roles-unignored.html

  • accessibility/AccessibilityObject.h: Added new roles to represent paragraphs, labels, forms and div sections.
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Return ParagraphRole, LabelRole, FormRole and DivRole when needed for the GTK platform only.
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): Consider the new roles now that those kind of nodes won't return true to isGroup().
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole): Map new WebCore roles to ATK Roles. (webkit_accessible_get_role): Remove code to define roles for paragraphs, labels, forms and divs based on node's tag name.

Update mappings for the Mac platform.

  • accessibility/mac/AccessibilityObjectWrapper.mm: (createAccessibilityRoleMap): Add explicit mappings from the new roles introduced to NSAccessibilityGroupRole.

2011-03-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Duplicate new internal WebCore roles in the Chromium port.

  • public/WebAccessibilityRole.h: Update enumeration WebAccessibilityRole to reflect newly added roles in WebCore.
  • src/AssertMatchingEnums.cpp: Added new assertions.
9:48 AM Changeset in webkit [82458] by jberlin@webkit.org
  • 20 edits in trunk/Source/WebKit2

WebKit2: Make sure to try to terminate the Web Process when any work that might require the
Web Process to be relaunched is done
https://bugs.webkit.org/show_bug.cgi?id=57462

Reviewed by Anders Carlsson.

For the ManagerProxies in the UIProcess, only return true from shouldTerminate if there are
no more callbacks waiting to be invoked.

For the the Managers in the WebProcess, call WebProcess::shared().terminateIfPossible() when
any work called for by a ManagerProxy function that called relaunchProcessIfNecessary is
finished.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::shouldTerminate):
Check with each of the ManagerProxies.

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::shouldTerminate):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::shouldTerminate):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::shouldTerminate):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::shouldTerminate):

  • UIProcess/WebKeyValueStorageManagerProxy.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::shouldTerminate):

  • UIProcess/WebMediaCacheManagerProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::shouldTerminate):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):

9:14 AM Changeset in webkit [82457] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Leopard Intel Release Tests] fast/text/justify-ideograph-leading-expansion.html failing
since r82026.
https://bugs.webkit.org/show_bug.cgi?id=57461

The Leopard results match the other Mac results, but when it started inheriting from the
Snow Leopard specific results it started failing.

Copy the mac results to the mac-leopard results to get the bots green.

  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
9:13 AM Changeset in webkit [82456] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix for Efl and Qt Win.

  • inspector/PageDebuggerAgent.cpp: removed ENABLE(WORKERS) guard from code that has nothing to do with workers.
9:07 AM Changeset in webkit [82455] by sergio@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-30 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, rebaseline GTK+ test expectations.

  • platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
  • platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/gtk/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
9:04 AM Changeset in webkit [82454] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Adding editing/selection/click-below-rtl-text.html to mac-wk2 since it requires eventSender.

  • platform/mac-wk2/Skipped:
9:02 AM Changeset in webkit [82453] by caseq@chromium.org
  • 4 edits in trunk

2011-03-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: audit run never completes, fails in DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=57349

  • assure document is present before calling DOMAgent.querySelectAll()
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

2011-03-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: audit run never completes, fails in DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=57349

  • inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349
8:53 AM Changeset in webkit [82452] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Leopard Intel Release Tests] editing/spelling/grammar.html failing since introduction in
r82159.
https://bugs.webkit.org/show_bug.cgi?id=57460

Unreviewed, commit the failing expected results in order to get the bots green.

  • platform/mac-leopard/editing/spelling/grammar-expected.txt: Added.
8:42 AM Changeset in webkit [82451] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Leopard Intel Release Tests] svg/text/bidi-embedded-direction.svg failing since
introduction in r82411.
https://bugs.webkit.org/show_bug.cgi?id=57458

Unreviewed, add the platform-specific failing results to get the bots green.

NOTE: The platform-specific failing pixel test results still need to be added.

  • platform/mac-leopard/svg/text/bidi-embedded-direction-expected.txt: Added.
8:36 AM Changeset in webkit [82450] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix.

  • UseJSC.cmake: fix typo PageDebugServer -> PageScriptDebugServer
8:26 AM Changeset in webkit [82449] by yurys@chromium.org
  • 23 edits
    12 adds in trunk/Source

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345

ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/js/PageScriptDebugServer.cpp: Added. (WebCore::toPage): (WebCore::PageScriptDebugServer::shared): (WebCore::PageScriptDebugServer::PageScriptDebugServer): (WebCore::PageScriptDebugServer::~PageScriptDebugServer): (WebCore::PageScriptDebugServer::addListener): (WebCore::PageScriptDebugServer::removeListener): (WebCore::PageScriptDebugServer::recompileAllJSFunctions): (WebCore::PageScriptDebugServer::getListenersForGlobalObject): (WebCore::PageScriptDebugServer::didPause): (WebCore::PageScriptDebugServer::didContinue): (WebCore::PageScriptDebugServer::didRemoveLastListener): (WebCore::PageScriptDebugServer::setJavaScriptPaused):
  • bindings/js/PageScriptDebugServer.h: Added.
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::pauseIfNeeded):
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp: Added. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener):
  • bindings/js/WorkerScriptDebugServer.h: Added. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions): (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject): (WebCore::WorkerScriptDebugServer::didPause): (WebCore::WorkerScriptDebugServer::didContinue):
  • bindings/v8/PageScriptDebugServer.cpp: Added. (WebCore::retrieveFrame): (WebCore::PageScriptDebugServer::shared): (WebCore::PageScriptDebugServer::PageScriptDebugServer): (WebCore::PageScriptDebugServer::addListener): (WebCore::PageScriptDebugServer::removeListener): (WebCore::PageScriptDebugServer::setClientMessageLoop): (WebCore::PageScriptDebugServer::getDebugListenerForContext): (WebCore::PageScriptDebugServer::runMessageLoopOnPause): (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/PageScriptDebugServer.h: Added. (WebCore::PageScriptDebugServer::setEnabled): (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop): (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setPauseOnNextStatement): (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::editScriptSource): (WebCore::toScriptDebugServer): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::v8DebugEventCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent): (WebCore::ScriptDebugServer::isPaused):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/WorkerScriptDebugServer.cpp: Added. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener):
  • bindings/v8/WorkerScriptDebugServer.h: Added. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::getDebugListenerForContext): (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::debuggerAgent):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::setBreakpointsActive): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::resume): (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::disable): (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/PageDebuggerAgent.cpp: Added. (WebCore::PageDebuggerAgent::create): (WebCore::PageDebuggerAgent::PageDebuggerAgent): (WebCore::PageDebuggerAgent::~PageDebuggerAgent): (WebCore::PageDebuggerAgent::startListeningScriptDebugServer): (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer): (WebCore::PageDebuggerAgent::scriptDebugServer):
  • inspector/PageDebuggerAgent.h: Added.
  • inspector/WorkerDebuggerAgent.cpp: Added. (WebCore::WorkerDebuggerAgent::create): (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent): (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent): (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::scriptDebugServer):
  • inspector/WorkerDebuggerAgent.h: Added.

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345

ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
8:24 AM Changeset in webkit [82448] by Csaba Osztrogonác
  • 14 edits
    2 adds in trunk/LayoutTests

[Qt] Update expected files.

  • platform/qt/css1/box_properties/padding_right_inline-expected.checksum: Added.
  • platform/qt/css1/box_properties/padding_right_inline-expected.png: Added.
  • platform/qt/css1/box_properties/padding_right_inline-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.checksum:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.checksum:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.txt:
8:21 AM Changeset in webkit [82447] by leviw@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Clicking below last line of right-to-left editable text that puts caret in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=38087

Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
instead of lastLeafChild, which wasn't correct in the RTL case.

Test: editing/selection/click-below-rtl-text.html

  • editing/visible_units.cpp: (WebCore::logicalStartPositionForLine): Moved to RootInlineBox. (WebCore::logicalEndPositionForLine): Ditto.
  • editing/visible_units.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead of lastLeafChild.
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored. (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
  • rendering/RootInlineBox.h:

2011-03-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Clicking below last line of right-to-left editable text that puts caret in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=38087

Doing the right thing when clicking below the last line box in RTL editable content.

  • editing/selection/click-below-rtl-text-expected.txt: Added.
  • editing/selection/click-below-rtl-text.html: Added.
8:09 AM Changeset in webkit [82446] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, update Chromium test expectation for fast/text/emphasis-combined-text.html.

  • platform/chromium/test_expectations.txt:
8:06 AM Changeset in webkit [82445] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix after r82442

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange): Added a missing argument.

8:04 AM Changeset in webkit [82444] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a new test to the mac-wk2 Skipped file

<http://webkit.org/b/57455> tracks the failure.

  • platform/mac-wk2/Skipped: Added fast/forms/validation-message-appearance.html.
8:03 AM Changeset in webkit [82443] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add mac-wk2 expected failure results for plugins/embed-prefers-plugins-for-images.html

The failure is tracked by <http://webkit.org/b/57456>.

  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
  • platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added. (Since

win-wk2 falls back to mac-wk2, but the test passes on Windows, I had to copy passing results
here to override the mac-wk2 results.)

7:42 AM Changeset in webkit [82442] by Adam Roben
  • 12 edits in trunk/Source/WebKit2

Add a way to specify that a ShareableBitmap has no alpha channel

Before this patch, all ShareableBitmaps had an alpha channel. With this patch, all
ShareableBitmaps *still* have an alpha channel. But now there's a way to specify you don't
want one (which will be used in the future)!

Fixes <http://webkit.org/b/57388> Need a way to specify that a ShareableBitmap has no alpha
channel

Reviewed by Anders Carlsson.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::Handle): Moved here from the header file, and added
initialization of m_flags.

(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Encode/decode m_flags.

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
Pass along the new Flags argument.

(WebKit::ShareableBitmap::createHandle): Store our Flags on the Handle.
(WebKit::ShareableBitmap::ShareableBitmap): Store the Flags in m_flags.

  • Shared/ShareableBitmap.h: Added Flag, Flags, and m_flags, and added a Flags argument to

some create functions.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::encodeImage):

  • Shared/WebImage.cpp:

(WebKit::WebImage::create):
Specify that we want a bitmap that supports alpha to maintain current behavior.

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::bitmapInfo): New helper function. Includes an alpha channel only if specified in
the flags.

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImage):
Use the new helper function.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Specify that we want a bitmap that supports alpha to maintain current behavior.

7:40 AM Changeset in webkit [82441] by Adam Roben
  • 25 edits in trunk/Source/WebKit2

Add ShareableBitmap::Handle

This object is used for encoding/decoding a ShareableBitmap via CoreIPC. It currently just
encapsulates a SharedMemory::Handle (which is what we were using previously) and the image's
size (which means callers no longer need to deal with the size explicitly), but in the
future could be used to store more information about the bitmap.

This should cause no behavior changes.

Fixes <http://webkit.org/b/57397> ShareableBitmap needs its own Handle type

Reviewed by Anders Carlsson.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::geometryDidChange): No longer need to pass a size to create,
since the Handle records the size.
(WebKit::PluginControllerProxy::snapshot): No longer need the bufferSize argument, since the
Handle records the size.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:

Updated Handle types and removed unnecessary size argument to Snapshot.

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

Changed to use ShareableBitmap::Handle and removed m_backingStoreSize, which is now stored
in the Handles.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::encode):
(WebKit::ShareableBitmap::Handle::decode):
Simple encode/decode functions.

(WebKit::ShareableBitmap::create): Get the size from the Handle instead of as a separate
argument.
(WebKit::ShareableBitmap::createHandle): Store our size in the Handle.

  • Shared/ShareableBitmap.h: Added ShareableBitmap::Handle and made some functions use it.
  • Shared/UpdateInfo.h: Changed to use ShareableBitmap::Handle.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::encodeImage):
(CoreIPC::decodeImage):
Use the size stored in the Handle instead of encoding/decoding one separately.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setDragImage):
Removed the unnecessary imageSize argument. We can get it from the image itself.

  • UIProcess/BackingStore.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::create):
No longer need to pass a size when creating a ShareableBitmap from a Handle.

  • UIProcess/FindIndicator.h: Changed to use ShareableBitmap::Handle.
  • UIProcess/PageClient.h: Removed unnecessary imageSize argument from setDragImage.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setDragImage):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::snapshot):
(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):
Changed to use ShareableBitmap::Handle and removed now-unnecessary size arguments (since we
can get the size from the Handle).

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData): Don't need to store the backing store size in the
data anymore; the Handles will make sure it reaches the other process.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
Changed to use ShareableBitmap::Handle.

7:19 AM Changeset in webkit [82440] by yurys@chromium.org
  • 23 edits
    12 deletes in trunk/Source

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r82438 and r82436.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/js/PageScriptDebugServer.cpp: Removed.
  • bindings/js/PageScriptDebugServer.h: Removed.
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::hasListenersInterestedInPage): (WebCore::toPage): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::setJavaScriptPaused): (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener):
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp: Removed.
  • bindings/js/WorkerScriptDebugServer.h: Removed.
  • bindings/v8/PageScriptDebugServer.cpp: Removed.
  • bindings/v8/PageScriptDebugServer.h: Removed.
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::retrieveFrame): (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setPauseOnNextStatement): (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::editScriptSource): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::v8DebugEventCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::ClientMessageLoop::~ClientMessageLoop): (WebCore::ScriptDebugServer::setClientMessageLoop):
  • bindings/v8/WorkerScriptDebugServer.cpp: Removed.
  • bindings/v8/WorkerScriptDebugServer.h: Removed.
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::setBreakpointsActive): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::resume): (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::disable): (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/PageDebuggerAgent.cpp: Removed.
  • inspector/PageDebuggerAgent.h: Removed.
  • inspector/WorkerDebuggerAgent.cpp: Removed.
  • inspector/WorkerDebuggerAgent.h: Removed.
7:18 AM Changeset in webkit [82439] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update the mac-wk2 Skipped file for recently-added tests

See the file itself for the relevant bugs.

  • platform/mac-wk2/Skipped:
7:11 AM Changeset in webkit [82438] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix compilation on Windows and EFL.

  • CMakeLists.txt:
  • bindings/js/JSBindingsAllInOne.cpp:
7:03 AM Changeset in webkit [82437] by Adam Roben
  • 3 edits
    3 deletes in trunk/LayoutTests

Fix two svg/text tests that have been failing on Windows since r82411

Fixes <http://webkit.org/b/57448> REGRESSION (r82411): Two svg/text tests failing on Windows

Reviewed by Eric Seidel.

  • svg/text/bidi-reorder-value-lists.svg: Pull in Mac-compatible-font-fallback.css so that

this test will give the same results on Mac and Windows.

  • platform/win/svg/text/bidi-reorder-value-lists-expected.checksum: Removed.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.png: Removed.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.txt: Removed.

We now match Mac!

  • platform/win/svg/text/font-size-below-point-five-expected.txt: Make the same change here

that was made to the Mac results in r82411. (The remaining differences between Windows and
Mac are just due to different rounding.)

6:59 AM Changeset in webkit [82436] by yurys@chromium.org
  • 21 edits
    12 adds in trunk/Source

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345

ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.

  • GNUmakefile.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/js/PageScriptDebugServer.cpp: Added. (WebCore::toPage): (WebCore::PageScriptDebugServer::shared): (WebCore::PageScriptDebugServer::PageScriptDebugServer): (WebCore::PageScriptDebugServer::~PageScriptDebugServer): (WebCore::PageScriptDebugServer::addListener): (WebCore::PageScriptDebugServer::removeListener): (WebCore::PageScriptDebugServer::recompileAllJSFunctions): (WebCore::PageScriptDebugServer::getListenersForGlobalObject): (WebCore::PageScriptDebugServer::didPause): (WebCore::PageScriptDebugServer::didContinue): (WebCore::PageScriptDebugServer::didRemoveLastListener): (WebCore::PageScriptDebugServer::setJavaScriptPaused):
  • bindings/js/PageScriptDebugServer.h: Added.
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::pauseIfNeeded):
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp: Added. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener):
  • bindings/js/WorkerScriptDebugServer.h: Added. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions): (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject): (WebCore::WorkerScriptDebugServer::didPause): (WebCore::WorkerScriptDebugServer::didContinue):
  • bindings/v8/PageScriptDebugServer.cpp: Added. (WebCore::retrieveFrame): (WebCore::PageScriptDebugServer::shared): (WebCore::PageScriptDebugServer::PageScriptDebugServer): (WebCore::PageScriptDebugServer::addListener): (WebCore::PageScriptDebugServer::removeListener): (WebCore::PageScriptDebugServer::setClientMessageLoop): (WebCore::PageScriptDebugServer::getDebugListenerForContext): (WebCore::PageScriptDebugServer::runMessageLoopOnPause): (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/PageScriptDebugServer.h: Added. (WebCore::PageScriptDebugServer::setEnabled): (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop): (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setPauseOnNextStatement): (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::editScriptSource): (WebCore::toScriptDebugServer): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::v8DebugEventCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent): (WebCore::ScriptDebugServer::isPaused):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/WorkerScriptDebugServer.cpp: Added. (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener):
  • bindings/v8/WorkerScriptDebugServer.h: Added. (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::getDebugListenerForContext): (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::debuggerAgent):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::setBreakpointsActive): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::resume): (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::disable): (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/PageDebuggerAgent.cpp: Added. (WebCore::PageDebuggerAgent::create): (WebCore::PageDebuggerAgent::PageDebuggerAgent): (WebCore::PageDebuggerAgent::~PageDebuggerAgent): (WebCore::PageDebuggerAgent::startListeningScriptDebugServer): (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer): (WebCore::PageDebuggerAgent::scriptDebugServer):
  • inspector/PageDebuggerAgent.h: Added.
  • inspector/WorkerDebuggerAgent.cpp: Added. (WebCore::WorkerDebuggerAgent::create): (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent): (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent): (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::scriptDebugServer):
  • inspector/WorkerDebuggerAgent.h: Added.

2011-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split debugger agent into Page and Worker-specific ones
https://bugs.webkit.org/show_bug.cgi?id=57345

ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
and Page/WorkerDebuggerAgent.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
6:53 AM Changeset in webkit [82435] by podivilov@chromium.org
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-03-25 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for bug 56747 (scripts panel is broken when frontend is reopened).
https://bugs.webkit.org/show_bug.cgi?id=56841

  • http/tests/inspector-enabled/open-close-open-expected.txt: Removed.
  • http/tests/inspector-enabled/open-close-open.html: Removed.
  • inspector/debugger/open-close-open-expected.txt: Added.
  • inspector/debugger/open-close-open.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
6:52 AM Changeset in webkit [82434] by yutak@chromium.org
  • 12 edits
    37 adds in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add and update Chromium test results.

  • platform/chromium-linux/css2.1/t090501-c414-flt-ln-00-d-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-ln-00-d-expected.png:
  • platform/chromium-linux/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png: Added.
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png: Added.
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png: Added.
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/rtl-border-04-expected.png: Added.
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/rtl-border-05-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t090501-c414-flt-ln-02-d-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-01-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-01-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-02-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-02-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-03-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-03-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-04-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-04-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-05-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/borders/rtl-border-05-expected.png: Added.
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-00-d-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-00-d-expected.png:
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/chromium-win/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.checksum: Added.
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png: Added.
  • platform/chromium-win/fast/borders/rtl-border-01-expected.txt: Added.
  • platform/chromium-win/fast/borders/rtl-border-02-expected.checksum: Added.
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png: Added.
  • platform/chromium-win/fast/borders/rtl-border-02-expected.txt: Added.
  • platform/chromium-win/fast/borders/rtl-border-03-expected.checksum: Added.
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png: Added.
  • platform/chromium-win/fast/borders/rtl-border-03-expected.txt: Added.
  • platform/chromium-win/fast/borders/rtl-border-04-expected.checksum: Added.
  • platform/chromium-win/fast/borders/rtl-border-04-expected.png: Added.
  • platform/chromium-win/fast/borders/rtl-border-04-expected.txt: Added.
  • platform/chromium-win/fast/borders/rtl-border-05-expected.checksum: Added.
  • platform/chromium-win/fast/borders/rtl-border-05-expected.png: Added.
  • platform/chromium-win/fast/borders/rtl-border-05-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:42 AM Styling Form Controls edited by tkent@chromium.org
(diff)
6:40 AM Styling Form Controls edited by tkent@chromium.org
(diff)
6:38 AM Changeset in webkit [82433] by apavlov@chromium.org
  • 6 edits in trunk

2011-03-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Make the getStylesForNode result "styleAttributes" value an array rather than a map
https://bugs.webkit.org/show_bug.cgi?id=57440

WebCore:

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):

LayoutTests:

  • inspector/styles/styles-new-API.html:
6:36 AM Styling Form Controls edited by tkent@chromium.org
(diff)
6:18 AM Changeset in webkit [82432] by Adam Roben
  • 3 edits in trunk/LayoutTests

Make font fallback on Windows in new Hebrew-containing tests added in r82419 match Mac

Fixes <http://webkit.org/b/57445> fast/borders/rtl-border-0{4,5}.html failing on Windows
since they were added

Reviewed by Eric Seidel.

  • fast/borders/rtl-border-04.html:
  • fast/borders/rtl-border-05.html:

Pull in the magic Mac-compatible-font-fallback.css file, which will cause the Hebrew text in
these tests to be rendered using Lucida Grande on Windows, just like on Mac.

6:15 AM Changeset in webkit [82431] by yutak@chromium.org
  • 1 edit
    108 deletes in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82396.
http://trac.webkit.org/changeset/82396

Revert Adam's rebaselines (part 6). They broke Chromium
Leopard bots.

  • platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/4845371-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/basic/002-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/basic/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Removed.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
6:12 AM Changeset in webkit [82430] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82397.
http://trac.webkit.org/changeset/82397

Revert Adam's rebaselines (part 5). They broke Chromium
Leopard bots.

  • platform/chromium/test_expectations.txt:
6:11 AM Changeset in webkit [82429] by yutak@chromium.org
  • 1 edit
    72 deletes in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82404.
http://trac.webkit.org/changeset/82404

Revert Adam's rebaselines (part 4). They broke Chromium
Leopard bots.

  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/state-at-end-event-transform-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-6-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/drawImage-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/slider-padding-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fonts/monospace-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Removed.
6:09 AM Changeset in webkit [82428] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82405.
http://trac.webkit.org/changeset/82405

Revert Adam's rebaselines (part 3). They broke Chromium
Leopard bots.

  • platform/chromium/test_expectations.txt:
6:08 AM Changeset in webkit [82427] by yutak@chromium.org
  • 1 edit
    90 deletes in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82413.
http://trac.webkit.org/changeset/82413

Revert Adam's rebaselines (part 2). They broke Chromium
Leopard bots.

  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-5-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-transformation-with-hkern-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-transformation-with-hkern-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/non-scaling-stroke-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/non-scaling-stroke-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-skew-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/text-rotated-gradient-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/text-rotated-gradient-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/viewbox-syntax-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/viewbox-syntax-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/006-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/008-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/008-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/011-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/011-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
6:06 AM Changeset in webkit [82426] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82414.
http://trac.webkit.org/changeset/82414

Revert Adam's rebaselines (part 1). They broke Chromium
Leopard bots.

  • platform/chromium/test_expectations.txt:
5:55 AM Changeset in webkit [82425] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Evan Martin <evan@chromium.org>

Reviewed by Ryosuke Niwa.

Fix a last-second ASSERT in previous change that was wrong.

  • dom/Document.cpp: (WebCore::Document::setTitle):
5:48 AM Changeset in webkit [82424] by leviw@chromium.org
  • 7 edits in trunk

2011-03-29 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

RTL: Directionality always reset on hard line break
https://bugs.webkit.org/show_bug.cgi?id=23124

Testing that hard line breaks are being treated as paragraph separators but only
clearing directional state from Unicode control characters, not DOM nodes.
Also adding expected pixel results for bidi-override-in-anonymous-block as we're
passing more of the test with this patch.

  • fast/text/international/bidi-br-as-paragraph-separator.html: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/mac/fast/text/international/bidi-br-as-paragraph-separator-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-br-as-paragraph-separator-expected.png: Added.
  • platform/mac/fast/text/international/bidi-br-as-paragraph-separator-expected.txt: Added.

2011-03-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

RTL: Directionality always reset on hard line break
https://bugs.webkit.org/show_bug.cgi?id=23124

No longer clearing all BidiContexts when we hit a hard line break.
Instead, directionality applied by DOM elements is preserved by
reconstructing the context stack ignoring those that didn't come
from the DOM.

Test: fast/text/international/bidi-br-as-paragraph-separator.html

  • platform/text/BidiContext.cpp: (WebCore::BidiContext::createUncached): (WebCore::BidiContext::create): (WebCore::copyContextAndRebaselineLevel): Helper to make a copy of a context and recalculate its bidi level. (WebCore::BidiContext::copyStackRemovingUnicodeEmbeddingContexts): Returns the top of a BidiContext stack that's equivalent but without contexts from Unicode directional characters. (WebCore::operator==): Now takes into account embedding source.
  • platform/text/BidiContext.h: (WebCore::BidiContext::source): Enum to specify whether an embedded bidirectional control came from the DOM/Style or Unicode characters (WebCore::BidiContext::BidiContext):
  • platform/text/BidiResolver.h: (WebCore::BidiEmbedding::BidiEmbedding): An embedding is now a direction and a hint about where it came from so we can differentiate DOM directions from unicode direction control characters. (WebCore::BidiEmbedding::direction): (WebCore::BidiEmbedding::source): (WebCore::::embed): Now takes a source as well as a direction. (WebCore::::commitExplicitEmbedding): (WebCore::::createBidiRunsForLine):
  • rendering/InlineIterator.h: (WebCore::bidiNext): (WebCore::bidiFirst):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::determineStartPosition):
5:28 AM Changeset in webkit [82423] by steveblock@google.com
  • 11 edits
    1 copy
    1 move in trunk/Source/WebCore

2011-03-30 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaMethod should not expose JavaString in its API
https://bugs.webkit.org/show_bug.cgi?id=55765

  • Factors out a JavaMethod interface which does not use JNI types. This will allow the Java bridge to be used with objects that don't use JNI directly. The existing jobject-backed implementation is moved to a new JavaMethodJobject class which implements the interface.
  • Use WTF::String in place of JavaString in the API, as JavaString exposes JNI types in its interface.
  • Remove the method ID as it uses JNI types.

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaMethod.h:
  • bridge/jni/JavaMethodJobject.cpp: (JavaMethodJobject::JavaMethodJobject): (JavaMethodJobject::~JavaMethodJobject): (appendClassName): (JavaMethodJobject::signature):
  • bridge/jni/JavaMethodJobject.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h. (JSC::Bindings::JavaMethodJobject::name): (JSC::Bindings::JavaMethodJobject::returnTypeClassName): (JSC::Bindings::JavaMethodJobject::parameterAt): (JSC::Bindings::JavaMethodJobject::returnType): (JSC::Bindings::JavaMethodJobject::isStatic): (JSC::Bindings::JavaMethodJobject::numParameters):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/v8/JavaClassV8.cpp: (JavaClass::JavaClass):
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
4:21 AM Changeset in webkit [82422] by evan@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-30 Evan Martin <evan@chromium.org>

Reviewed by Ryosuke Niwa.

clean up Document's handling of title changes
https://bugs.webkit.org/show_bug.cgi?id=57433

Document::setTitle has two entry points:
1) from DOM bindings, like document.title="foo"
2) from title tags, like <title>foo</title> in HTML

Split these two code paths to make the code easier to follow.
Also, replace the repeated pattern of

m_rawTitle = "foo"; updateTitle();

with

updateTitle("foo");

  • dom/Document.cpp: (WebCore::Document::updateTitle): (WebCore::Document::setTitle): (WebCore::Document::setTitleElement): (WebCore::Document::removeTitle):
  • dom/Document.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::insertedIntoDocument): (WebCore::HTMLTitleElement::childrenChanged):
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::insertedIntoDocument): (WebCore::SVGTitleElement::childrenChanged):
3:46 AM Changeset in webkit [82421] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

BreakBlockQuoteCommand assumes all li tags have list item renderers
https://bugs.webkit.org/show_bug.cgi?id=57253

Checking that the renderers of li nodes are actually RenderListItems
before treating them as such.

  • editing/execCommand/crash-breaking-blockquote-with-list.html: Added.
  • editing/execCommand/crash-breaking-blockquote-with-list-expected.txt: Added.

2011-03-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

BreakBlockQuoteCommand assumes all li tags have list item renderers
https://bugs.webkit.org/show_bug.cgi?id=57253

Checking that the renderers of li nodes are actually RenderListItems
before treating them as such.

Test: editing/execCommand/crash-breaking-blockquote-with-list.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockQuoteCommand::doApply):
3:13 AM Changeset in webkit [82420] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing typo in the inspector front-end.

Web Inspector: REGRESSION: Broken live edit errors handling
https://bugs.webkit.org/show_bug.cgi?id=57436

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._didEditScriptSource):
3:09 AM Changeset in webkit [82419] by yael.aharon@nokia.com
  • 9 edits
    20 adds in trunk

2011-03-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements
https://bugs.webkit.org/show_bug.cgi?id=9272

  • fast/borders/rtl-border-01.html: Added.
  • fast/borders/rtl-border-02.html: Added.
  • fast/borders/rtl-border-03.html: Added.
  • fast/borders/rtl-border-04.html: Added.
  • fast/borders/rtl-border-05.html: Added.
  • platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
  • platform/mac/fast/borders/rtl-border-01-expected.checksum: Added.
  • platform/mac/fast/borders/rtl-border-01-expected.png: Added.
  • platform/mac/fast/borders/rtl-border-01-expected.txt: Added.
  • platform/mac/fast/borders/rtl-border-02-expected.checksum: Added.
  • platform/mac/fast/borders/rtl-border-02-expected.png: Added.
  • platform/mac/fast/borders/rtl-border-02-expected.txt: Added.
  • platform/mac/fast/borders/rtl-border-03-expected.checksum: Added.
  • platform/mac/fast/borders/rtl-border-03-expected.png: Added.
  • platform/mac/fast/borders/rtl-border-03-expected.txt: Added.
  • platform/mac/fast/borders/rtl-border-04-expected.checksum: Added.
  • platform/mac/fast/borders/rtl-border-04-expected.png: Added.
  • platform/mac/fast/borders/rtl-border-04-expected.txt: Added.
  • platform/mac/fast/borders/rtl-border-05-expected.checksum: Added.
  • platform/mac/fast/borders/rtl-border-05-expected.png: Added.
  • platform/mac/fast/borders/rtl-border-05-expected.txt: Added.

2011-03-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements
https://bugs.webkit.org/show_bug.cgi?id=9272

Also fixes https://bugs.webkit.org/show_bug.cgi?id=47210 and https://bugs.webkit.org/show_bug.cgi?id=8392.

Change how we decide if an InlineFlowBox is the last one for its renderer. Use the position of resolver's logicallyLastRun
to decide if there is more text in the next line.

Tests: fast/borders/rtl-border-01.html

fast/borders/rtl-border-02.html
fast/borders/rtl-border-03.html
fast/borders/rtl-border-04.html
fast/borders/rtl-border-05.html

  • rendering/InlineFlowBox.cpp: (WebCore::isAnsectorAndWithinBlock): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::layoutInlineChildren):
3:04 AM Changeset in webkit [82418] by yutak@chromium.org
  • 8 edits
    11 adds in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add/update new Chromium test results.

  • platform/chromium-linux/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.checksum:
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/chromium-mac-leopard/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.checksum:
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/chromium-win/svg/text/font-size-below-point-five-expected.txt:
  • platform/chromium/test_expectations.txt:
2:34 AM Changeset in webkit [82417] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:16 AM Changeset in webkit [82416] by yutak@chromium.org
  • 5 edits in trunk

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

[Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
https://bugs.webkit.org/show_bug.cgi?id=57430

  • platform/chromium/test_expectations.txt: Revert the expectation changes caused by r82399.

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

[Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
https://bugs.webkit.org/show_bug.cgi?id=57430

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/chromium/LayoutTestController.h:
2:14 AM Changeset in webkit [82415] by alex
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Alejandro G. Castro <alex@igalia.com>

Fix GTK build after r81980.

  • GNUmakefile.am:
2:13 AM Changeset in webkit [82414] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Add failing Snow Leopard test back to the list of failing tests.

  • platform/chromium/test_expectations.txt:
2:09 AM Changeset in webkit [82413] by abarth@webkit.org
  • 1 edit
    90 adds in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Moar Chromium Snow Leopard baselines!

  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/non-scaling-stroke-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-skew-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/text-rotated-gradient-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/text-rotated-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/viewbox-syntax-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/viewbox-syntax-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/006-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/006-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/008-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/008-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/011-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/011-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
2:00 AM Changeset in webkit [82412] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2011-03-30 Kent Tamura <tkent@chromium.org>

[Chromium] Add Chromium expectations for h1-in-section-elements.html

  • platform/chromium-linux/fast/css/h1-in-section-elements-expected.checksum: Added.
  • platform/chromium-linux/fast/css/h1-in-section-elements-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/h1-in-section-elements-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/h1-in-section-elements-expected.png: Added.
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.checksum: Added.
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png: Added.
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:36 AM Changeset in webkit [82411] by Nikolas Zimmermann
  • 20 edits
    4 adds in trunk

2011-03-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

Deconvolute SVGTextLayoutEngine code, which was confusing due to the simultaneous processing of the rendered text
in visual and logical order. Added several helper methods to make the code more readable.

Fix Unicode directional formatting characters support, now works as expected.

Test: svg/text/bidi-embedded-direction.svg

  • editing/visible_units.cpp: Refactor getLeafBoxesInLogicalOrder(), move to InlineFlowBox. (WebCore::getLogicalStartBoxAndNode): Use new collectLeafBoxesInLogicalOrder() method in InlineFlowBox. (WebCore::getLogicalEndBoxAndNode): Ditto.
  • rendering/InlineFlowBox.cpp: Add new helper function, that returns a list of all leaf boxes in logical order. (WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):
  • rendering/InlineFlowBox.h:
  • rendering/svg/RenderSVGText.cpp: Actually trigger reordering the x/y/dx/dy/rotate value lists, if needed. (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::layout):
  • rendering/svg/RenderSVGText.h: Ditto. (WebCore::RenderSVGText::layoutAttributes): (WebCore::RenderSVGText::needsReordering):
  • rendering/svg/SVGRootInlineBox.cpp: Use new InlineFlowBox::collectLeafBoxesINLogicalOrder(), with a custom "inline box reverse" implementation,

which not only reverses the order of InlineBoxes, but also the order of the x/y/dx/dy/rotate value lists, if needed.

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::swapItems):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
(WebCore::SVGRootInlineBox::reorderValueLists):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextLayoutAttributes.cpp: Store RenderSVGInlineText* pointer, where we belong to. (WebCore::SVGTextLayoutAttributes::SVGTextLayoutAttributes): (WebCore::SVGTextLayoutAttributes::dump):
  • rendering/svg/SVGTextLayoutAttributes.h: (WebCore::SVGTextLayoutAttributes::context):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Pass RenderSVGInlineText* object when creating SVGTextLayoutAttributes. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
  • rendering/svg/SVGTextLayoutEngine.cpp: Rewrite & cleanup the main layout algorithm, to be less confusing. (WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine): (WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded): (WebCore::SVGTextLayoutEngine::recordTextFragment): (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics): (WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics): (WebCore::SVGTextLayoutEngine::advanceToNextLogicalCharacter): (WebCore::SVGTextLayoutEngine::advanceToNextVisualCharacter): (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  • rendering/svg/SVGTextLayoutEngine.h:

2011-03-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

Add testcase from bug 53980, assuring that BiDi works as well, when using the Unicode directional formatting characters.

  • platform/mac/svg/text/bidi-embedded-direction-expected.checksum: Added.
  • platform/mac/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/mac/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.checksum:
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/mac/svg/text/font-size-below-point-five-expected.txt: Update result, as text runs aren't created anymore for empty text.
  • svg/text/bidi-embedded-direction.svg: Added.
  • svg/text/bidi-reorder-value-lists.svg: Extend testcase, to cover more reordering cases.
1:23 AM Changeset in webkit [82410] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, remove duplicate Chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [82409] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test expectation for fast/images/move-image-to-new-document.html.

  • platform/chromium/test_expectations.txt:
12:56 AM Changeset in webkit [82408] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Kent Tamura <tkent@chromium.org>

[Chromium] Mark h1-in-section-elements.html FAIL until Chromium bots get results.

  • platform/chromium/test_expectations.txt:
12:56 AM Changeset in webkit [82407] by mjs@apple.com
  • 3 edits in trunk/Tools

2011-03-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

make webkit-patch upload respect -d
https://bugs.webkit.org/show_bug.cgi?id=57425

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/steps/commit.py:
12:50 AM Changeset in webkit [82406] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-30 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

Add the NEXT_OPCODE() macro to the DFG-JIT parser
https://bugs.webkit.org/show_bug.cgi?id=57322

In JavaScriptCore we use macros to jump to the next opcode
(both in interpreter and JIT). This macro is added to the
DFG-JIT parser as well.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
12:47 AM Changeset in webkit [82405] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Remove a bunch of IMAGE only Snow Leopard Chromium failures from the
expectations file. This will trigger our rebaselining machinery to
make it possible to rebaseline these tests efficiently and accurately,
which I intend to do shortly.

  • platform/chromium/test_expectations.txt:
12:43 AM Changeset in webkit [82404] by abarth@webkit.org
  • 1 edit
    80 adds in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Moar chromium-mac-snowleopard results. These all appear to be correct.

  • platform/chromium-mac-snowleopard/animations: Added.
  • platform/chromium-mac-snowleopard/animations/3d: Added.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/3d/state-at-end-event-transform-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/animations/3d/state-at-end-event-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-background-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/drawImage-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/drawImage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/slider-padding-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-mac-snowleopard/fonts/monospace-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
  • platform/chromium-mac-snowleopard/http: Added.
  • platform/chromium-mac-snowleopard/http/tests: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms: Added.
  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac-snowleopard/transitions: Added.
  • platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
12:39 AM Changeset in webkit [82403] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-30 Ilya Tikhonovsky <loislo@chromium.org>

Not reviewed trivial change.

Web Inspector: Remove unnecessary function arguments after r82281.
https://bugs.webkit.org/show_bug.cgi?id=57327

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl):
12:36 AM Changeset in webkit [82402] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-03-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
https://bugs.webkit.org/show_bug.cgi?id=57429

  • Scripts/webkitpy/common/checkout/scm.py:
12:16 AM Changeset in webkit [82401] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-30 Adam Barth <abarth@webkit.org>

Reviewed by Dan Bernstein.

Update Mac Leopard baselines after r82056
https://bugs.webkit.org/show_bug.cgi?id=57428

These expected results differ from old ones just by a pixel or two.
I suspect they're caused by text metrics differences, but I haven't
confirmed visually.

  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt:
  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
12:00 AM Changeset in webkit [82400] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

H1 element should have different default style if it is in HTML5 sectioning elements.
https://bugs.webkit.org/show_bug.cgi?id=52693

  • fast/css/h1-in-section-elements.html: Added.
  • platform/mac/fast/css/h1-in-section-elements-expected.checksum: Added.
  • platform/mac/fast/css/h1-in-section-elements-expected.png: Added.
  • platform/mac/fast/css/h1-in-section-elements-expected.txt: Added.

2011-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

H1 element should have different default style if it is in HTML5 sectioning elements.
https://bugs.webkit.org/show_bug.cgi?id=52693

Test: fast/css/h1-in-section-elements.html

  • css/html.css: Add font-size and margin declarations to follow HTML5 specification. (:-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):

Mar 29, 2011:

11:51 PM Changeset in webkit [82399] by aestes@apple.com
  • 3 edits in trunk/LayoutTests

2011-03-29 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

[Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html timing out since r82087
https://bugs.webkit.org/show_bug.cgi?id=57347

  • fast/images/script-tests/move-image-to-new-document.js: Disable plug-ins so that the embed portion of the test gets the expected image loading behavior on bots with QuickTime installed.
  • platform/mac-wk2/Skipped: Skip the test in WebKit2 since it doesn't implement setPluginsEnabled().
11:42 PM Changeset in webkit [82398] by Beth Dakin
  • 19 edits in trunk/Source

Source/WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/8665411>

Reviewed by Maciej Stachowiak.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::windowScaleFactor):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):

Source/WebKit/mac: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/8665411>

Reviewed by Maciej Stachowiak.

  • Misc/WebNSControlExtras.m:

(-[NSControl sizeToFitAndAdjustWindowHeight]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scaleFactor):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):

Source/WebKit2: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/8665411>

Reviewed by Maciej Stachowiak.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::userSpaceScaleFactor):

  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::userSpaceScaleFactor):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/gtk/WebView.h:

(WebKit::WebView::userSpaceScaleFactor):

  • UIProcess/win/WebView.h:

(WebKit::WebView::userSpaceScaleFactor):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scaleFactor):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userSpaceScaleFactor):

11:39 PM Changeset in webkit [82397] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Remove a bunch of IMAGE only Snow Leopard Chromium failures from the
expectations file. This will trigger our rebaselining machinery to
make it possible to rebaseline these tests efficiently and accurately,
which I intend to do shortly.

  • platform/chromium/test_expectations.txt:
11:27 PM Changeset in webkit [82396] by abarth@webkit.org
  • 1 edit
    122 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Re-land these expected results in the correct directory.

  • platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/4845371-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images: Added.
  • platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline-block: Added.
  • platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/basic: Added.
  • platform/chromium-mac-snowleopard/fast/text/basic/002-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/basic/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/scrollbars: Added.
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text: Added.
  • platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
11:24 PM Changeset in webkit [82395] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57369

I considered renaming these to m_endOfRun and m_startOfRun but decided
that was too verbose for now (given how often they're used). I suspect
with a bit more refactoring we'll find they're not used very often and can be renamed
if so desired.

  • platform/text/BidiResolver.h: (WebCore::::appendRun): (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):
  • rendering/InlineIterator.h: (WebCore::InlineBidiResolver::appendRun):
11:20 PM Changeset in webkit [82394] by abarth@webkit.org
  • 1 edit
    108 deletes in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Revert previous change. These should have gone into the Chromium Snow
Leopard folder. (Thanks to mrowe for pointing out my error.)

  • platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
  • platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
  • platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Removed.
  • platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Removed.
  • platform/mac-snowleopard/editing/deleting/4845371-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/deleting/4845371-expected.png: Removed.
  • platform/mac-snowleopard/editing/deleting/5126166-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/deleting/5126166-expected.png: Removed.
  • platform/mac-snowleopard/editing/deleting/5483370-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/deleting/5483370-expected.png: Removed.
  • platform/mac-snowleopard/editing/deleting/table-cells-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/deleting/table-cells-expected.png: Removed.
  • platform/mac-snowleopard/editing/inserting/4875189-2-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/inserting/4875189-2-expected.png: Removed.
  • platform/mac-snowleopard/editing/pasteboard/5387578-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/pasteboard/5387578-expected.png: Removed.
  • platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
  • platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
  • platform/mac-snowleopard/fast/block/float/014-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/block/float/014-expected.png: Removed.
  • platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Removed.
  • platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Removed.
  • platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Removed.
  • platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/input-align-image-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/forms/input-align-image-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/input-type-change-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Removed.
  • platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
  • platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/margin-collapse-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/positioned-split-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/single-line-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/single-line-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Removed.
  • platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Removed.
  • platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Removed.
  • platform/mac-snowleopard/fast/replaced/image-onload-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/replaced/image-onload-expected.png: Removed.
  • platform/mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/replaced/image-sizing-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/basic/002-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/text/basic/002-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/drawBidiText-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/text/drawBidiText-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
  • platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Removed.
  • platform/mac-snowleopard/media/video-transformed-expected.checksum: Removed.
  • platform/mac-snowleopard/media/video-transformed-expected.png: Removed.
  • platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Removed.
  • platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
  • platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Removed.
  • platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
  • platform/mac-snowleopard/svg/filters/filterRes-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
  • platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Removed.
  • platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Removed.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Removed.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
11:19 PM Changeset in webkit [82393] by mnaganov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57351

  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptHeapSnapshot.cpp:
  • bindings/v8/ScriptHeapSnapshot.h:
  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
10:59 PM Changeset in webkit [82392] by abarth@webkit.org
  • 1 edit
    139 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Update Snow Leopard baselines.

  • platform/mac-snowleopard/css2.1: Added.
  • platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
  • platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
  • platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
  • platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
  • platform/mac-snowleopard/editing: Added.
  • platform/mac-snowleopard/editing/deleting: Added.
  • platform/mac-snowleopard/editing/deleting/4845371-expected.checksum: Added.
  • platform/mac-snowleopard/editing/deleting/4845371-expected.png: Added.
  • platform/mac-snowleopard/editing/deleting/5126166-expected.checksum: Added.
  • platform/mac-snowleopard/editing/deleting/5126166-expected.png: Added.
  • platform/mac-snowleopard/editing/deleting/5483370-expected.checksum: Added.
  • platform/mac-snowleopard/editing/deleting/5483370-expected.png: Added.
  • platform/mac-snowleopard/editing/deleting/table-cells-expected.checksum: Added.
  • platform/mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
  • platform/mac-snowleopard/editing/inserting: Added.
  • platform/mac-snowleopard/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/mac-snowleopard/editing/inserting/4875189-2-expected.png: Added.
  • platform/mac-snowleopard/editing/pasteboard: Added.
  • platform/mac-snowleopard/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/mac-snowleopard/editing/pasteboard/5387578-expected.png: Added.
  • platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/mac-snowleopard/fast/block: Added.
  • platform/mac-snowleopard/fast/block/float: Added.
  • platform/mac-snowleopard/fast/block/float/014-expected.checksum: Added.
  • platform/mac-snowleopard/fast/block/float/014-expected.png: Added.
  • platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/mac-snowleopard/fast/borders: Added.
  • platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/mac-snowleopard/fast/canvas: Added.
  • platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Added.
  • platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/mac-snowleopard/fast/dom: Added.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement: Added.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/input-align-image-expected.checksum: Added.
  • platform/mac-snowleopard/fast/forms/input-align-image-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/input-type-change-expected.checksum: Added.
  • platform/mac-snowleopard/fast/forms/input-type-change-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/mac-snowleopard/fast/images: Added.
  • platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/mac-snowleopard/fast/inline: Added.
  • platform/mac-snowleopard/fast/inline-block: Added.
  • platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
  • platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol: Added.
  • platform/mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/margin-collapse-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/positioned-split-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/single-line-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/single-line-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/mac-snowleopard/fast/replaced: Added.
  • platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
  • platform/mac-snowleopard/fast/replaced/image-onload-expected.checksum: Added.
  • platform/mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
  • platform/mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Added.
  • platform/mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
  • platform/mac-snowleopard/fast/text/basic: Added.
  • platform/mac-snowleopard/fast/text/basic/002-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/basic/002-expected.png: Added.
  • platform/mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/drawBidiText-expected.png: Added.
  • platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Added.
  • platform/mac-snowleopard/media: Added.
  • platform/mac-snowleopard/media/video-transformed-expected.checksum: Added.
  • platform/mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/mac-snowleopard/scrollbars: Added.
  • platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
  • platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
  • platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/custom: Added.
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.checksum: Added.
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/filters: Added.
  • platform/mac-snowleopard/svg/filters/filterRes-expected.checksum: Added.
  • platform/mac-snowleopard/svg/filters/filterRes-expected.png: Added.
  • platform/mac-snowleopard/svg/text: Added.
  • platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
  • platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/mac-snowleopard/tables: Added.
  • platform/mac-snowleopard/tables/mozilla: Added.
  • platform/mac-snowleopard/tables/mozilla/core: Added.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla_expected_failures: Added.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs: Added.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
  • platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
10:39 PM Changeset in webkit [82391] by tkent@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-29 Kent Tamura <tkent@chromium.org>

[Chromium] Add expectations for a test added in r82386.

  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.checksum: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt: Added.
10:14 PM Changeset in webkit [82390] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed build change to activate MathML for WinCairo.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Enable MathML.
9:55 PM Changeset in webkit [82389] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split more logic out from createBidiRunsForLine for readability
https://bugs.webkit.org/show_bug.cgi?id=57341

I marked reorderRunsFromLevels inline, but it probably doesn't actually need to (or want to) be.
This lops another large hunk off of reorderRunsFromLevels further reducing the size and complexity.

  • platform/text/BidiResolver.h: (WebCore::::reorderRunsFromLevels): (WebCore::::createBidiRunsForLine):
9:38 PM Changeset in webkit [82388] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build fix.

Bring DownloadCurl implementation stubs in line with current
CFNetwork API.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):

9:17 PM Changeset in webkit [82387] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82383.
http://trac.webkit.org/changeset/82383
https://bugs.webkit.org/show_bug.cgi?id=57417

"nrwt isn't shutting down cleanly" (Requested by dpranke on
#webkit).

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:14 PM Changeset in webkit [82386] by tkent@chromium.org
  • 16 edits
    4 adds in trunk

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290

Add a new test for validation message bubble, and skip it on non-Mac platforms.

  • fast/forms/validation-message-appearance.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/validation-message-appearance-expected.checksum: Added.
  • platform/mac/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/mac/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290

Introduce a setting for validation message timer so that we can configure
how long we show a validation message bubble.

Test: fast/forms/validation-message-appearance.html

  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::setMessageDOMAndStartTimer): Don't set a timer if the timer magnification value is 0 or negative. Otherwise, hides the bubble length * magnification / 1000 seconds.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize the timer magnification value.
  • page/Settings.h: (WebCore::Settings::setValidationMessageTimerMagnification): Added. (WebCore::Settings::validationMessageTimerMaginification): Added.

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Copy the private value of the timer magnification to WebCore::Settings. (-[WebView validationMessageTimerMagnification]): Added. (-[WebView setValidationMessageTimerMagnification:]): Added.
  • WebView/WebViewData.h: Declare a member for the timer magnification.
  • WebView/WebViewData.mm: (-[WebViewPrivate init]): Initialize the timer magnification.
  • WebView/WebViewPrivate.h: Declare a setter and a getter for the timer magnification.

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Change a setting so that validation bubbles isn't hidden automatically.
8:10 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
Add notes about Python module installation errors with NAT networking. (diff)
8:09 PM BuildingOnWindows edited by bfulgham@webkit.org
Add notes about NAT/Bridged network effects on Python installs (diff)
7:52 PM Changeset in webkit [82385] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-29 Dimitri Glazkov <Dimitri Glazkov>

Remove the extraneous declaration I accidentally added in r82376.

  • dom/MouseEvent.h: Removed createSimulated decl.
7:22 PM Changeset in webkit [82384] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Document that we're now passing these tests.

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [82383] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: use 'threads' on win instead of 'old-threads'

It's a bit unclear whether multiple threads or multiple
processes will be a better model on windows. This change will
test threads for now while we're still working out the bugs in
multiple-processes.

https://bugs.webkit.org/show_bug.cgi?id=57410

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
7:00 PM Changeset in webkit [82382] by levin@chromium.org
  • 6 edits in trunk/Tools

2011-03-29 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style confused by two ChangeLog entries in a row from same user
https://bugs.webkit.org/show_bug.cgi?id=57250

  • Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
  • Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
  • Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked. It basically assumes only one ChangeLog entry is being processed because that is the standard case and checking more than that would be very messey.
  • Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
  • Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
7:00 PM Changeset in webkit [82381] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor crash with show-layer-borders flag
https://bugs.webkit.org/show_bug.cgi?id=57292

Synchronize the debug border color/width with other properties to ensure the appropriate
CCLayerImpl exists. Code is only exercised with a debugging command line flag so no layout
test.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::pushPropertiesTo): (WebCore::LayerChromium::setBorderColor): (WebCore::LayerChromium::setBorderWidth):
  • platform/graphics/chromium/LayerChromium.h:
6:48 PM Changeset in webkit [82380] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Add missing PNGs. These PNGs match the checksums.

  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png: Added.
6:35 PM Changeset in webkit [82379] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Teach the preload scanner about &lt;input type=image&gt;
https://bugs.webkit.org/show_bug.cgi?id=57404

  • fast/preloader/input-expected.txt: Added.
  • fast/preloader/input.html: Added.

2011-03-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Teach the preload scanner about &lt;input type=image&gt;
https://bugs.webkit.org/show_bug.cgi?id=57404

I did a very rough sample of the top 50 web pages to see how many of each
HTML resource type they include:
img src: 1,359
script src: 276
link href: 256
iframe src: 104
input src: 50
embed src: 37
@import: 13
object data: 11

Based on this, it seems worthwhile to preload inputs and iframes (possibly embed).
This patch only does inputs.

Test: fast/preloader/input.html

  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::PreloadTask): (WebCore::HTMLNames::PreloadTask::processAttributes): (WebCore::HTMLNames::PreloadTask::inputTypeAttributeIsImage): (WebCore::HTMLNames::PreloadTask::preload):
6:26 PM Changeset in webkit [82378] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Luke Macpherson <macpherson@chromium.org>

Reviewed by David Levin.

Improve the massive switch statement in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=56288

No new tests are needed because no new functionality exposed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Asserted that cases implemented in the CSSStyleApplyProperty lookup table are unreachable. Updated comment.
6:22 PM Changeset in webkit [82377] by tkent@chromium.org
  • 11 edits in trunk

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308

  • fast/forms/interactive-validation-prevented-expected.txt: Fix a wrong expectation.
  • platform/chromium/test_expectations.txt: Update expectation of interactive-validation-prevented.html.
  • platform/mac/Skipped: Unskip interactive-validation except interactive-validation-lost-focusable.html, which doesn't pass for now.

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Convey a WebView flag for interactive validation to WebCore::Settings. (-[WebView interactiveFormValidationEnabled]): Added. (-[WebView setInteractiveFormValidationEnabled:]): Added.
  • WebView/WebViewData.h: Add interactiveFormValidationEnabled.
  • WebView/WebViewData.mm: (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
  • WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.

2011-03-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
6:07 PM Changeset in webkit [82376] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-03-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Introduce SimulatedMouseEvent and teach EventDispatcher how to use it.
https://bugs.webkit.org/show_bug.cgi?id=57402

No functional changes, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Changed to use SimulatedMouseEvent. (WebCore::EventDispatcher::dispatchMouseEvent): Combined two dispatchMouseEvent methods

into one, now that simulated-click events don't need one.

  • dom/EventDispatcher.h: Updated decls.
  • dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::create): Added. (WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Added. (WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Added.
  • dom/MouseEvent.h: Made constructor protected.
6:02 PM Changeset in webkit [82375] by Patrick Gansterer
  • 1 edit
    2 deletes in trunk/Source/WebKit/win

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Remove unused GEN_DOMObject files
https://bugs.webkit.org/show_bug.cgi?id=57370

  • GEN_DOMObject.cpp: Removed.
  • GEN_DOMObject.h: Removed.
6:02 PM Changeset in webkit [82374] by Martin Robinson
  • 16 edits
    20 adds in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update the last set of GTK+ results after r82343.

  • platform/gtk: Update the last set of GTK+ results.
5:55 PM Changeset in webkit [82373] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Revert previous change now that the roll is in.

  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [82372] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WK2: When creating the window remote token, use what's returned from accessibility
https://bugs.webkit.org/show_bug.cgi?id=57398

Reviewed by Darin Adler.

This will allow a specific WKView to override what's used for the window attribute of the
HTML elements.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):

5:51 PM Changeset in webkit [82371] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

These tests are actually fine, I just can't figure out how to make the
bot happy. I'm going to try rolling and then continue beating my head
against the bot.

  • platform/chromium/test_expectations.txt:
5:40 PM Changeset in webkit [82370] by jeffm@apple.com
  • 9 edits
    3 adds in trunk/Source/WebKit2

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Sam Weinig.

Make Windows-only InjectedBundle functions platform-specific
https://bugs.webkit.org/show_bug.cgi?id=57385


Added files for Windows-specific WKBundle functions.
Removed stub wrappers for InjectedBundle::setHostAllowsAnyHTTPSCertificate() and InjectedBundle::setClientCertificate() from non-Windows platforms.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.cpp.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.h.
  • WebProcess/InjectedBundle/API/c/win: Added.
  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: Added. (WKBundleSetHostAllowsAnyHTTPSCertificate): Moved from WKBundle.cpp. (WKBundleSetClientCertificate): Moved from WKBundle.cpp.
  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Added.
  • WebProcess/InjectedBundle/InjectedBundle.h: setHostAllowsAnyHTTPSCertificate() and setClientCertificate() are Windows-only.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
  • win/WebKit2.vcproj: Added WKBundlePrivateWin.cpp and WKBundlePrivateWin.h.
  • win/WebKit2Generated.make: Copy WKBundlePrivateWin.h.
5:29 PM Changeset in webkit [82369] by abarth@webkit.org
  • 1 edit
    1 add
    8 deletes in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Attempt to fix Chromium Mac Canary. It's unclear whether removing
these files will help, but it's worth a try.

  • platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Removed.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Removed.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
5:24 PM Changeset in webkit [82368] by cevans@google.com
  • 6 edits in branches/chromium/696/Source/WebCore/rendering

Merge 81724
BUG=75835

5:14 PM Changeset in webkit [82367] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):

5:13 PM Changeset in webkit [82366] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • WebCore.exp.in:
5:06 PM Changeset in webkit [82365] by Martin Robinson
  • 408 edits in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update the GTK+ results in the tables directory after r82343.

  • platform/gtk/tables: Update the results in this directory.
5:02 PM Changeset in webkit [82364] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit2

2011-03-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Downloads: Authentication support
https://bugs.webkit.org/show_bug.cgi?id=57403
<rdar://problem/8691166>

  • UIProcess/API/C/WKContext.h: Add didReceiveAuthenticationChallenge callback.
  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Call the download client.
  • UIProcess/Downloads/DownloadProxy.messages.in: Add DidReceiveAuthenticationChallenge message.
  • UIProcess/WebDownloadClient.cpp: (WebKit::WebDownloadClient::didReceiveAuthenticationChallenge): Call the client callback function.
  • UIProcess/WebDownloadClient.h:
  • WebProcess/Authentication/AuthenticationManager.cpp: (WebKit::AuthenticationManager::didReceiveAuthenticationChallenge): Send the DidReceiveAuthenticationChallenge message to the download proxy.

(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
If the authentication client is null, call the static download member functions.

  • WebProcess/Authentication/AuthenticationManager.h:
  • WebProcess/Downloads/Download.cpp: (WebKit::Download::didReceiveAuthenticationChallenge): Call the authentication manager.
  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm: (WebKit::Download::receivedCredential): (WebKit::Download::receivedRequestToContinueWithoutCredential): (WebKit::Download::receivedCancellation): Call the right sender methods.

(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate downloadShouldUseCredentialStorage:]):
Call the right Download member functions.

  • WebProcess/Downloads/qt/DownloadQt.cpp: (WebKit::Download::receivedCredential): (WebKit::Download::receivedRequestToContinueWithoutCredential): (WebKit::Download::receivedCancellation):
  • WebProcess/Downloads/soup/DownloadSoup.cpp: (WebKit::Download::receivedCredential): (WebKit::Download::receivedRequestToContinueWithoutCredential): (WebKit::Download::receivedCancellation): Add stubs.
4:55 PM Changeset in webkit [82363] by Martin Robinson
  • 154 edits
    4 adds in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update CSS and editing GTK+ results after r82343.

  • platform/gtk/css1:
  • platform/gtk/css2.1:
  • platform/gtk/editing:
4:54 PM Changeset in webkit [82362] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 82351
BUG=77181

4:46 PM Changeset in webkit [82361] by steveblock@google.com
  • 5 edits in trunk/Source/WebCore

2011-03-29 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaInstance should not use jvalue in its API
https://bugs.webkit.org/show_bug.cgi?id=57019

This change updates JavaInstance for V8 to use JavaValue, rather than
jvalue, in its API. This will allow us to create an API for
JavaInstance that is independent of JNI, to allow it to be
implemented on platforms that do not use JNI directly.

Refactoring only, no new tests.

  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod): (JavaInstance::getField):
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaValueV8.h:
4:46 PM Changeset in webkit [82360] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 81889
BUG=77053

4:43 PM Changeset in webkit [82359] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

AuthenticationChallengeProxy objects should be associated with processes, not pages
https://bugs.webkit.org/show_bug.cgi?id=57401

  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp: (WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy): (WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy): (WebKit::AuthenticationChallengeProxy::useCredential): (WebKit::AuthenticationChallengeProxy::cancel):
  • UIProcess/Authentication/AuthenticationChallengeProxy.h: (WebKit::AuthenticationChallengeProxy::create):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
4:42 PM Changeset in webkit [82358] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Use LocalizedStrings.h as a bottleneck for localized strings instead of
using UI_STRING.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
Call existing localization functions instead of using UI_STRING.

(-[WKView _getTextInputState:selectionEnd:underlines:]):
Remove unnecessary WebCore:: prefix.

4:41 PM Changeset in webkit [82357] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Remove more-specific instances of a general rule.

  • platform/chromium/test_expectations.txt:
4:37 PM Changeset in webkit [82356] by commit-queue@webkit.org
  • 11 edits in trunk

2011-03-29 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=42692

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode): (WebKit::WebPreferencesStore::overrideAllowUniversalAccessFromFileURLsForTestRunner):
  • Shared/WebPreferencesStore.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleOverrideAllowUniversalAccessFromFileURLsForTestRunner):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::overrideAllowUniversalAccessFromFileURLsForTestRunner):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-03-29 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=42692

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4:36 PM Changeset in webkit [82355] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/696

Merge 82088
BUG=77346

4:33 PM Changeset in webkit [82354] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Rename BidiResolver::last to m_last to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57367

  • platform/text/BidiResolver.h: (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):
4:30 PM Changeset in webkit [82353] by Martin Robinson
  • 126 edits in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update the GTK+ results in the svg directory after r82343.

  • platform/gtk/svg: Update the results in this directory.
4:30 PM Changeset in webkit [82352] by timothy@apple.com
  • 5 edits in trunk/Source/WebKit

Fix the Qt, WinCE and Chromium builds.

4:20 PM Changeset in webkit [82351] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Maciej Stachowiak.

SVGComponentTransferFunctionElement should validate type
https://bugs.webkit.org/show_bug.cgi?id=56960

  • svg/filters/feComponentTransfer-style-crash-expected.txt: Added.
  • svg/filters/feComponentTransfer-style-crash.xhtml: Added.

2011-03-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Maciej Stachowiak.

SVGComponentTransferFunctionElement should validate type
https://bugs.webkit.org/show_bug.cgi?id=56960

Test: svg/filters/feComponentTransfer-style-crash.xhtml

  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
  • svg/SVGComponentTransferFunctionElement.h:
4:16 PM Changeset in webkit [82350] by Martin Robinson
  • 255 edits in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update the last set of fast GTK+ results after r82343.

  • platform/gtk/fast: Update the last set of results in this directory.
4:12 PM Changeset in webkit [82349] by Martin Robinson
  • 202 edits in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update more GTK+ results after r82343.

  • platform/gtk/fast: Update many more results in this directory.
4:06 PM Changeset in webkit [82348] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

More build fix.

  • WebCoreSupport/WebPlatformStrategies.h:
4:05 PM Changeset in webkit [82347] by Martin Robinson
  • 201 edits in trunk/LayoutTests

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Update GTK+ results after r82343.

  • platform/gtk/fast: Update many results in this directory.
3:59 PM Changeset in webkit [82346] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add new failing tests to the Skipped list until tomorrow.

  • platform/qt/Skipped:
3:57 PM Changeset in webkit [82345] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Build fix.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):

3:56 PM Changeset in webkit [82344] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Thomas Klausner <tk@giga.or.at>

Reviewed by David Levin.

png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406

Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).

Compilation fixes, so no new tests.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
3:55 PM Changeset in webkit [82343] by Martin Robinson
  • 2 edits in trunk/Tools

2011-03-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067

Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
update DRT and pixel results as hundreds of results will need to be updated.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow by overriding the theme RC/CSS files.
3:53 PM Changeset in webkit [82342] by commit-queue@webkit.org
  • 9 edits
    6 adds in trunk

2011-03-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Tony Gentilcore.

Add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424

Unfortunately, there's lots of skipped tests, and a chrome failure
expectation here, in a strange disjoint set. On the chromium
port, favicon loads don't occur in DRT, so the favicon changes are
expected to fail. On the ports without prefetching, we expect the
prefetching test to fail.

  • fast/dom/HTMLLinkElement/prefetch-beforeload-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-beforeload.html: Added.
  • http/tests/misc/link-rel-icon-beforeload-expected.txt: Added.
  • http/tests/misc/link-rel-icon-beforeload.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • webarchive/test-link-rel-icon-beforeload-expected.webarchive: Added.
  • webarchive/test-link-rel-icon-beforeload.html: Added.

2011-03-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Tony Gentilcore.

Add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424

Over in https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html , a webkit-dev
thread, I've discussed my hopes for the link element, and adding the link header. This
change helps improve the link header by making it participate in the beforeload event in
two more important cases.

Tests: fast/dom/HTMLLinkElement/prefetch-beforeload.html

http/tests/misc/link-rel-icon-beforeload.html
webarchive/test-link-rel-icon-beforeload.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::checkBeforeLoadEvent): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h:
3:50 PM Changeset in webkit [82341] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Rename BidiResolver::current to BidiResolver::m_current to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57363

I was very confused by current until I realized it was a member variable.
I also did m_reachedEndOfLine since that was small.

  • platform/text/BidiResolver.h: (WebCore::BidiResolver::position): (WebCore::BidiResolver::setPosition): (WebCore::BidiResolver::increment): (WebCore::::createBidiRunsForLine):
3:46 PM Changeset in webkit [82340] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Geoff Pike <gpike@chromium.org>

Reviewed by Dimitri Glazkov.

In HitTestResult objects, initialize the ListHashSet<RefPtr<Node> >
lazily. In my informal testing it seems to be used hardly at all, so
it's wasteful to create it eagerly. Initializing a ListHashSet
is expensive because a ListHashSet initially has space for 256
elements, and that space is memset to 0.

This change should improve performance but have no impact on
correctness. On x86-64, for example, the change cuts the
cost of HitTestResult(IntPoint()) in EventHandler::mouseMoved()
from ~1700 cycles to ~300 cycles.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0 (WebCore::HitTestResult::operator=): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0 (WebCore::HitTestResult::addNodeToRectBasedTestResult): use mutableRectBasedTestResult() rather than m_rectBasedTestResult (WebCore::HitTestResult::append): append *(other.m_rectBasedTestResult) if other.m_rectBasedTestResult isn't 0
  • rendering/HitTestResult.h: (WebCore::HitTestResult::rectBasedTestResult): Add a typedef for ListHashSet<RefPtr<Node> > to ease readability. Change m_rectBasedTestResult from ListHashSet<RefPtr<Node> > to an OwnPtr of same. Modify rectBasedTestResult() and add mutableRectBasedTestResult().
3:45 PM Changeset in webkit [82339] by sfalken@apple.com
  • 12 edits
    67 adds in trunk/Tools

2011-03-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57394

Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
  • DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
  • DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
  • DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
  • FindSafari/FindSafari.vcproj:
  • FindSafari/FindSafariDebug.vsprops: Added.
  • FindSafari/FindSafariDebugAll.vsprops: Added.
  • FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
  • FindSafari/FindSafariRelease.vsprops: Added.
  • FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
  • FindSafari/FindSafariReleaseLTCG.vsprops: Added.
  • FindSafari/FindSafariReleasePGO.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
  • MiniBrowser/MiniBrowser.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
  • WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
  • WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
  • WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
  • WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
  • WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
  • WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherDebug.vsprops: Added.
  • WinLauncher/WinLauncherDebugAll.vsprops: Added.
  • WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
  • WinLauncher/WinLauncherRelease.vsprops: Added.
  • WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
  • WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
  • record-memory-win/record-memory-win.vcproj:
  • record-memory-win/record-memory-winDebug.vsprops: Added.
  • record-memory-win/record-memory-winDebugAll.vsprops: Added.
  • record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
  • record-memory-win/record-memory-winRelease.vsprops: Added.
  • record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
  • record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
3:44 PM Changeset in webkit [82338] by abarth@webkit.org
  • 12 edits
    35 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Moar pixel expectations.

  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/4845371-expected.png: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.png: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.png: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.checksum:
  • platform/chromium-mac/fast/block/float/014-expected.png:
  • platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/background-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Added.
  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum:
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-align-image-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-type-change-expected.png: Added.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-mac/fast/images/icon-decoding-expected.png: Added.
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
  • platform/chromium-mac/fast/inline-block: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [82337] by timothy@apple.com
  • 19 edits in trunk/Source

Update the order of the context menu to better match AppKit on Mac.

<rdar://problem/9054893>

Reviewed by John Sullivan.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate): Update the order of items on Mac.

  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Added argument for selected string.

  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

  • platform/brew/LocalizedStringsBrew.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

  • platform/haiku/LocalizedStringsHaiku.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

  • platform/wx/LocalizedStringsWx.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
3:30 PM Changeset in webkit [82336] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix formatting of WebKit2.vcproj after r82283.

  • win/WebKit2.vcproj:
3:23 PM Changeset in webkit [82335] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-29 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin and Ken Russell.

https://bugs.webkit.org/show_bug.cgi?id=57248
Occlusion issues with WebGL in Safari

The depth buffer on Safari ports was being set up with a
maximum of 16 bits. Now we use a combined 24/8 depth/stencil
buffer on Mac ports.

No new tests as this is the setting for a particular port. Other
ports may use different defaults.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::validateAttributes):
  • use Extensions3D to test for depth and multisample extensions rather than querying OpenGL directly. (WebCore::GraphicsContext3D::reshape):
  • use a 24bit depth buffer when the extension is enabled.
3:15 PM Changeset in webkit [82334] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-29 Dimitri Glazkov <Dimitri Glazkov>

Sorted XCode project. It's gotten quite out of sorts.

  • WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
3:12 PM Changeset in webkit [82333] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Previously, I forgot to update the rendertree expectations.

  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt:
3:10 PM Changeset in webkit [82332] by eae@chromium.org
  • 5 edits in trunk

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

DatasetDOMStringMap::item and ::contains copies attribute name string
https://bugs.webkit.org/show_bug.cgi?id=55645

  • fast/dom/script-tests/dataset-expected.txt:
  • fast/dom/script-tests/dataset.js:

Added extra test cases for getting fields by property name.

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

DatasetDOMStringMap::item and ::contains copies attribute name string
https://bugs.webkit.org/show_bug.cgi?id=55645

Change propertyNameMatchesAttributeName to match without creating a copy
of the string.

  • dom/DatasetDOMStringMap.cpp: (WebCore::propertyNameMatchesAttributeName):
3:02 PM Changeset in webkit [82331] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Update expected results now that we don't have a scrollbar to worry about.

  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum:
  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.png:
3:00 PM Changeset in webkit [82330] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/win

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Try to fix Windows build.

  • DOMEventsClasses.cpp: Added initguid.h again.
3:00 PM Changeset in webkit [82329] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-03-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

test_runner2.py can crash due to undefined variable
https://bugs.webkit.org/show_bug.cgi?id=57356

Replace reference to undefined variable with a variable that's actually
defined. AFAICT, there's no way to test this code.

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2:57 PM Changeset in webkit [82328] by abarth@webkit.org
  • 30 edits
    38 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Update expectations.

  • platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
  • platform/chromium-mac/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac/fast/text/basic/002-expected.checksum: Added.
  • platform/chromium-mac/fast/text/basic/002-expected.png: Added.
  • platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png: Added.
  • platform/chromium-mac/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac/media/video-transformed-expected.png: Added.
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
  • platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac/svg/filters/filteredImage-expected.png: Added.
  • platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [82327] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

~25% regression on v8-splay in the SunSpider harness
https://bugs.webkit.org/show_bug.cgi?id=56128


I'm not sure if this is the root cause of the regression Stephanie
measured, but it seems to get us back to previous v8-splay times.


SunSpider reports no change. v8-splay says 41% faster.

  • runtime/Heap.cpp: (JSC::Heap::reset): Make marking proportional to 1X the size of the heap, not .5X the size of the heap. When the heap is large, this makes a big difference. (Our old heap growth policy matched this. You can see by looking at resizeBlocks in revisions prior to r77699.)
2:46 PM Changeset in webkit [82326] by Patrick Gansterer
  • 22 edits in trunk/Source/WebKit/win

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Cleanup includes in WebKit files
https://bugs.webkit.org/show_bug.cgi?id=57381

Add missing includes to fix build without precompiled header.
Also fix paths in #include statements (e.g. WTF -> wtf).

  • AccessibleBase.h:
  • AccessibleDocument.h: Replace using statement with a qualified name.
  • CFDictionaryPropertyBag.h:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.h:
  • DefaultDownloadDelegate.cpp:
  • DefaultDownloadDelegate.h:
  • DefaultPolicyDelegate.cpp:
  • DefaultPolicyDelegate.h:
  • WebCoreSupport/EmbeddedWidget.h:
  • WebCoreSupport/WebInspectorDelegate.h:
  • WebDataSource.h:
  • WebDatabaseManager.h:
  • WebElementPropertyBag.h:
  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.h:
  • WebHistory.h:
  • WebKitClassFactory.h:
  • WebScriptWorld.h:
  • WebSerializedJSValue.h:
  • WebUserContentURLPattern.h:
2:33 PM Changeset in webkit [82325] by abarth@webkit.org
  • 4 edits
    4 deletes in trunk/Source/WebKit/chromium

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82293.
http://trac.webkit.org/changeset/82293
https://bugs.webkit.org/show_bug.cgi?id=57390

Breaks RetrieveCSSResources (Requested by abarth|gardener on
#webkit).

  • WebKit.gyp:
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebPageSerializerTest.cpp:
  • tests/data/pageserialization/css_test_page.html: Removed.
  • tests/data/pageserialization/import_style_from_link.css: Removed.
  • tests/data/pageserialization/import_styles.css: Removed.
  • tests/data/pageserialization/link_styles.css: Removed.
2:29 PM Changeset in webkit [82324] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Green means pass, AFAICT.

  • platform/chromium-mac/fast/media/media-query-invalid-value-expected.png: Added.
  • platform/chromium-win/fast/media/media-query-invalid-value-expected.png: Added.
2:24 PM Changeset in webkit [82323] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Update image result due to different text metrics.

  • platform/chromium-win/printing/return-from-printing-mode-expected.png: Added.
2:21 PM Changeset in webkit [82322] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-03-29 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

cleanup rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=57375

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Split _extract_and_add_new_baselines into 3 functions
    • Reduce the amount of line wrapping (the file already has lines over 80 col, so may as well try to make the file consistent)
    • Remove unnecessary ()s
2:17 PM Changeset in webkit [82321] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82317.
http://trac.webkit.org/changeset/82317
https://bugs.webkit.org/show_bug.cgi?id=57387

We do not need these baselines anymore (Requested by
abarth|gardener on #webkit).

  • platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Removed.
2:12 PM Changeset in webkit [82320] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=57379
Clean up WK1 key event handling logic

No bugs knowingly fixed, but this makes the code more consistent.

  • WebView/WebHTMLView.mm: (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to eventInterpretationHadSideEffects, because "handled" doesn't really mean much. (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use from other functions. We need to execute saved commands when an input method asks for current state, because providing stale state could confuse it. (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other changes. (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise, the answer would be stale. (-[WebHTMLView firstRectForCharacterRange:]): Ditto. (-[WebHTMLView selectedRange]): Ditto. (-[WebHTMLView markedRange]): Ditto. (-[WebHTMLView attributedSubstringFromRange:]): Ditto. (-[WebHTMLView hasMarkedText]): Ditto. (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be operating on stale data. Also, updated for eventWasHandled renaming. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also fragile, because there is no guarantee about when noop: is sent (also, a custom key binding could have a noop: as one of its commands, although that's hardly practical). Added the same "from input method" logic that we have in insertText: - I don't know of any IMs that call this method, but we clearly need to execute it as part of IM processing when there is marked text. (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times if current selection isn't editable. This is different from doCommandBySelector:, where we need to give super class a chance to handle the event if our processing fails. Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the return value of _interpretKeyEvent is computed differently.
2:10 PM Changeset in webkit [82319] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Set overflow: hidden so we don't need to have scrollbars in the
results. I've tested that this still shows what looks like the
intended behavior difference before and after the test.

  • fast/block/float/float-forced-below-other-floats.html:
2:05 PM Changeset in webkit [82318] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-03-29 Martin Robinson <mrobinson@igalia.com>

[GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=55314

Build fix for older versions of GTK+. Use the deprecated names for GDK key
defines and include GtkVersioning.h to allow building on newer versions
of GTK+.

  • Shared/gtk/WebEventFactory.cpp: (WebKit::isGdkKeyCodeFromKeyPad): Update key defines.
2:04 PM Changeset in webkit [82317] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Scrollbars are different on different platforms. Including scrollbars
in tests that don't need them is sadness.

  • platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
  • platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Added.
1:55 PM Changeset in webkit [82316] by sfalken@apple.com
  • 7 edits
    30 adds in trunk/Source

Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57383

Reviewed by Darin Adler.

Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

Source/WebKit/win:

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesDebug.vsprops: Added.
  • WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
  • WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
  • WebKit.vcproj/InterfacesRelease.vsprops: Added.
  • WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
  • WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
  • WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
  • WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
  • WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
  • WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
  • WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
  • WebKit.vcproj/WebKitLibDebug.vsprops: Added.
  • WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
  • WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
  • WebKit.vcproj/WebKitLibRelease.vsprops: Added.
  • WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
  • WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.

Source/WebKit2:

  • win/WebKit2.vcproj:
  • win/WebKit2Debug.vsprops: Added.
  • win/WebKit2DebugAll.vsprops: Added.
  • win/WebKit2DebugCairoCFLite.vsprops: Added.
  • win/WebKit2Release.vsprops: Added.
  • win/WebKit2ReleaseCairoCFLite.vsprops: Added.
  • win/WebKit2ReleaseLTCG.vsprops: Added.
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessDebug.vsprops: Added.
  • win/WebKit2WebProcessDebugAll.vsprops: Added.
  • win/WebKit2WebProcessDebugCairoCFLite.vsprops: Added.
  • win/WebKit2WebProcessRelease.vsprops: Added.
  • win/WebKit2WebProcessReleaseCairoCFLite.vsprops: Added.
  • win/WebKit2WebProcessReleaseLTCG.vsprops: Added.
1:55 PM Changeset in webkit [82315] by Csaba Osztrogonác
  • 5 edits
    2 deletes in trunk

Unreviewed rollout r82282, part of r82288, r82298.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::parseColorInt):
(WebCore::isValidDouble):
(WebCore::parseAlphaValue):
(WebCore::CSSParser::parseColor):

LayoutTests:

  • fast/canvas/rgba-parsing-expected.txt:
  • fast/canvas/script-tests/rgba-parsing.js:
  • platform/chromium-mac/fast/canvas/rgba-parsing-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/rgba-parsing-expected.txt: Removed.
1:54 PM Changeset in webkit [82314] by bfulgham@webkit.org
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=55981
Second round of clean-ups, aimed at supporting GTK with the
same unified FontPlatformData header. This version removes
some unneeded WinCairo code, and aligns the WinCairo and
GTK ports to reduce code duplication.

Reviewed by Dave Hyatt.

  • WebCore.vcproj/WebCore.vcproj: Get rid of a dangling reference to an old WinCairo file.
  • platform/graphics/FontPlatformData.h: Remove unneeded member for m_fontFace, which is a member of m_scaledFont. Switch to standard Cairo hashing.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):

  • platform/graphics/win/FontCacheWin.cpp: Update to no longer use the unnecessary fontFace() accessor.

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

1:53 PM Changeset in webkit [82313] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

Make WinCairo a core builder.
https://bugs.webkit.org/show_bug.cgi?id=57373

Reviewed by Adam Roben.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1:45 PM Changeset in webkit [82312] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

WebKit2: The WebProcess should be relaunched if necessary when WebKit2 is asked for
information about Cookies, Databases, Local Storage, etc.
https://bugs.webkit.org/show_bug.cgi?id=57374

Reviewed by Anders Carlsson.

Instead of bailing when the WebProcess is not valid, call relaunchProcessIfNecessary().

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

1:37 PM Changeset in webkit [82311] by jianli@chromium.org
  • 5 edits
    2 adds in trunk

Inline worker powered by blob URL does not work with files URL even if
allowFileAccessFromFileURLs is enabled
https://bugs.webkit.org/show_bug.cgi?id=56063

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/workers/inline-worker-via-blob-url.html

  • fileapi/BlobURL.cpp: Removed unneeded getOrigin() method.
  • fileapi/BlobURL.h: Removed unneeded getOrigin() method.
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin): Extended the logic to handle
filesystem URL also to blob URL. Also fixed the problem that m_isUnique
is incorrectly set for blob and filesystem URLs.
(WebCore::SecurityOrigin::create): Removed the special logic for blob URL
since we use the same logic in SecurityOrigin constructor as filesystem
URL.
(WebCore::SecurityOrigin::canRequest): Removed the special logic for blob
URL since it is not needed with the fix in SecurityOrigin constructor.

LayoutTests:

  • fast/files/workers/inline-worker-via-blob-url-expected.txt: Added.
  • fast/files/workers/inline-worker-via-blob-url.html: Added.
1:27 PM Changeset in webkit [82310] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-29 Tony Chang <tony@chromium.org>

Roll chromium version to r79710 to pick up libpng changes.

  • DEPS:
1:25 PM Changeset in webkit [82309] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

WebKit2: Support setting the client certificate on Windows
https://bugs.webkit.org/show_bug.cgi?id=57368


Allow setting the client certificate for a host via the injected bundle.
This requires the ability for Webkit2 Windows clients to create a WKCertificateInfo from a PCCERT_CONTEXT so they can send it to the web process.

  • Shared/API/c/win/WKCertificateInfoWin.cpp: (WKCertificateInfoCreateWithCertificate): Added.
  • Shared/API/c/win/WKCertificateInfoWin.h: Added WKCertificateInfoCreateWithCertificate().
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetClientCertificate): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetClientCertificate().
  • WebProcess/InjectedBundle/InjectedBundle.h: Added setClientCertificate().
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: (WebKit::InjectedBundle::setClientCertificate): Added.
1:24 PM Changeset in webkit [82308] by timothy@apple.com
  • 19 edits
    1 copy
    1 delete in trunk

Make WebCore and WebKit2 work with update-webkit-localizable-strings.

Source/WebCore: Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
  • platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so

extract-localizable-strings does not complain about unbalanced single quotes.

Source/WebKit: Update WebKit Localizable.strings to only contain WebKit/win strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

  • English.lproj/Localizable.strings: Updated.

Source/WebKit2: Make WebKit2 work with update-webkit-localizable-strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginProcessMac.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
  • Shared/WebLocalizableStrings.h: Added.
  • UIProcess/API/mac/WKView.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Use UI_STRING. Remove FIXME.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Remove UI_STRING macros.

Use WebLocalizableStrings.h.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(registerErrors): Remove UI_STRING macro. Use WebLocalizableStrings.h.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Use UI_STRING. Remove FIXME.

  • GNUmakefile.am: Added Shared/WebLocalizableStrings.h.
  • WebKit2.pro: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.

Tools: Update update-webkit-localizable-strings to understand that WebKit and
WebKit2 strings go in WebCore.

Also make extract-localizable-strings optionally use an exclude file. No individual
warnings are produced about unlocalized strings when there is no exclude file. This
is needed for WebCore, since there are too many bare strings.

https://webkit.org/b/57354

Reviewed by Sam Weinig.

  • Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
  • Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1:18 PM Changeset in webkit [82307] by abarth@webkit.org
  • 9 edits
    2 deletes in trunk

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380

This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Removed.
  • platform/gtk/accessibility/aria-roles-unignored.html: Removed.

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380

This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380

This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole): (webkit_accessible_get_role):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
1:10 PM Changeset in webkit [82306] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

CoreIPC::decodeResourceError() leaks a CFDataRef
https://bugs.webkit.org/show_bug.cgi?id=57366

  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceError): Don't leak the result of WebCore::copyCertificateToData(), since the ResourceError will retain it.
1:10 PM Changeset in webkit [82305] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

  • platform/text/BidiResolver.h:

(WebCore::::createBidiRunsForLine):

1:07 PM Changeset in webkit [82304] by sfalken@apple.com
  • 3 edits
    12 adds in trunk/Source/WebCore

Use per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57378

Reviewed by Adam Roben.

Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinDebug.vsprops: Added.
  • WebCore.vcproj/QTMovieWinDebugAll.vsprops: Added.
  • WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops: Added.
  • WebCore.vcproj/QTMovieWinRelease.vsprops: Added.
  • WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops: Added.
  • WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Added.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreDebug.vsprops: Added.
  • WebCore.vcproj/WebCoreDebugAll.vsprops: Added.
  • WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Added.
  • WebCore.vcproj/WebCoreRelease.vsprops: Added.
  • WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops: Added.
  • WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Added.
12:47 PM Changeset in webkit [82303] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9194927> REGRESSION (r81691): Page at www.mondaynote.com lays out incorrectly

Reviewed by Simon Fraser.

Back out the optimization that stopped when it hit the first float. This was an incorrect optimization
and can't be done without more work.

Source/WebCore:

Added fast/block/float/float-forced-below-other-floats.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

LayoutTests:

Added fast/block/float/float-below-other-floats.html

  • fast/block/float/float-forced-below-other-floats.html: Added.
  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.png: Added.
  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt: Added.
12:43 PM Changeset in webkit [82302] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

WebKit2 bundle page needs to offer generated file hooks
https://bugs.webkit.org/show_bug.cgi?id=57279

Patch by Darin Adler <Darin Adler> on 2011-03-29
Reviewed by Adam Roben.

(Land missing part of the original patch after r82289.)

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.

12:43 PM Changeset in webkit [82301] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add passing results for a test that passes in WebKit2 but not WebKit1

The WebKit1 failure is tracked by <http://webkit.org/b/57334>.

  • platform/win-wk2/http/tests/uri/username-with-no-hostname-expected.txt: Added.
12:38 PM Changeset in webkit [82300] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Adam Barth.

REGRESSION(r82295): This patch does not compile on Chromium (Requested by abarth|gardener on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57377

Fix build errors on Chromium bots.

  • public/WebAccessibilityRole.h: Update to reflect newly added roles in WebCore.
  • src/AssertMatchingEnums.cpp: Ditto.
12:09 PM Changeset in webkit [82299] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-29 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=57361

  • DEPS:
12:03 PM Changeset in webkit [82298] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Looks like a rounding issue.

  • platform/chromium-mac/fast/canvas/rgba-parsing-expected.txt: Added.
  • platform/chromium-win/fast/canvas/rgba-parsing-expected.txt: Added.
12:00 PM Changeset in webkit [82297] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it
https://bugs.webkit.org/show_bug.cgi?id=57338

I'm attempting to break createBidiRunsForLine into understandable pieces
so that we can tell what it's actually doing. Our implementation of the
unicode bidi algorithm is slightly different from the spec in that we
run it per-line (instead of over the entire paragraph at once). This is
great for performance (our implementation is resumable), but it makes
things a bit tricky to understand. Splitting createBidiRunsForLine into
pieces should help make our UBA implementation more readable.

  • platform/text/BidiResolver.h: (WebCore::::updateStatusLastFromCurrentDirection): (WebCore::::createBidiRunsForLine):
11:50 AM Changeset in webkit [82296] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Consistent crash from Google/ARIA combobox click
https://bugs.webkit.org/show_bug.cgi?id=55883

Added new layout test to check this doesn't crash anymore in GTK.

  • platform/gtk/accessibility/aria-options-and-menuitems-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-options-and-menuitems-crash.html: Added.

2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Consistent crash from Google/ARIA combobox click
https://bugs.webkit.org/show_bug.cgi?id=55883

Do not call to firstChild() to avoid entering into infinite loops.

This would happen when current item is a WebCore Group and some of
its children have either role 'option' or 'menuitem'. Other than
that the logic behind that call to firstChild() seems to be no
longer needed so it's safe to remove it.

Test: platform/gtk/accessibility/aria-options-and-menuitems-crash.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Remove call to firsChild, which was leading to crashes sometimes.
11:43 AM Changeset in webkit [82295] by mario@webkit.org
  • 6 edits
    2 adds in trunk

2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Added new layout test to check that roles are correct in GTK.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Added.
  • platform/gtk/accessibility/aria-roles-unignored.html: Added.

2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Define new roles in WebCore and map them to ATK accordingly.

Test: platform/gtk/accessibility/aria-roles-unignored.html

  • accessibility/AccessibilityObject.h: Added new roles to represent paragraphs, labels, forms and div sections.
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Return ParagraphRole, LabelRole, FormRole and DivRole when needed.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole): Map new WebCore roles to ATK Roles. (webkit_accessible_get_role): Remove code to define roles for paragraphs, labels, forms and divs based on node's tag name.

Update mappings for the Mac platform.

  • accessibility/mac/AccessibilityObjectWrapper.mm: (createAccessibilityRoleMap): Add explicit mappings from the new roles introduced to NSAccessibilityGroupRole.
11:40 AM Changeset in webkit [82294] by Patrick Gansterer
  • 57 edits in trunk/Source/WebKit/win

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Remove #pragma warning push and pop statements
https://bugs.webkit.org/show_bug.cgi?id=57198

We do not need to disable warnings via #pragma since we started
compiling WebCore with the same compiler warnings flags as WebKit.

  • DOMCSSClasses.cpp:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • DefaultDownloadDelegate.cpp:
  • DefaultPolicyDelegate.cpp:
  • MarshallingHelpers.cpp:
  • WebActionPropertyBag.cpp:
  • WebActionPropertyBag.h:
  • WebCache.cpp:
  • WebCoreSupport/WebDragClient.cpp:
  • WebCoreSupport/WebEditorClient.cpp:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebInspectorClient.cpp:
  • WebDocumentLoader.h:
  • WebDownload.cpp:
  • WebDownloadCFNet.cpp:
  • WebDownloadCurl.cpp:
  • WebElementPropertyBag.cpp:
  • WebError.cpp:
  • WebError.h:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebFramePolicyListener.cpp:
  • WebFramePolicyListener.h:
  • WebHistory.cpp:
  • WebHistoryItem.cpp:
  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
  • WebInspector.cpp:
  • WebJavaScriptCollector.cpp:
  • WebKitGraphics.cpp:
  • WebKitSystemBits.cpp:
  • WebLocalizableStrings.cpp:
  • WebMutableURLRequest.cpp:
  • WebMutableURLRequest.h:
  • WebNodeHighlight.cpp:
  • WebNodeHighlight.h:
  • WebNotificationCenter.cpp:
  • WebResource.cpp:
  • WebResource.h:
  • WebScrollBar.cpp:
  • WebScrollBar.h:
  • WebURLAuthenticationChallenge.cpp:
  • WebURLAuthenticationChallenge.h:
  • WebURLAuthenticationChallengeSender.cpp:
  • WebURLAuthenticationChallengeSenderCFNet.cpp:
  • WebURLAuthenticationChallengeSenderCurl.cpp:
  • WebURLCredential.cpp:
  • WebURLCredential.h:
  • WebURLProtectionSpace.cpp:
  • WebURLProtectionSpace.h:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
11:40 AM Changeset in webkit [82293] by jcivelli@chromium.org
  • 4 edits
    4 adds in trunk/Source/WebKit/chromium

2011-03-29 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding retrieval off CSS resources to WebPageSerializer::retrieveAllResources.
https://bugs.webkit.org/show_bug.cgi?id=56650

  • WebKit.gyp:
  • src/WebPageSerializer.cpp: (WebCore::getResourceAttributeForElement): (WebCore::retrieveStyleSheetForElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebCore::retrieveResourcesForCSSRule): (WebCore::retrieveResourcesForCSSStyleDeclaration): (WebCore::retrieveResourcesForCSSStyleSheet): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebPageSerializerTest.cpp: (WebKit::TestWebFrameClient::TestWebFrameClient): (WebKit::TestWebFrameClient::allowScript): (WebKit::WebPageSerializerTest::enableJS): (WebKit::WebPageSerializerTest::runOnLoad): (WebKit::TEST_F):
  • tests/data/pageserialization/css_test_page.html: Added.
  • tests/data/pageserialization/import_style_from_link.css: Added. (#divOrange):
  • tests/data/pageserialization/import_styles.css: Added. (#divYellow):
  • tests/data/pageserialization/link_styles.css: Added. (#divRed):
11:27 AM Changeset in webkit [82292] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html timing out
since r82087.
https://bugs.webkit.org/show_bug.cgi?id=57347

Unreviewed, add fast/images/move-image-to-new-document.html to the skipped list in order to
get the bots green.

  • platform/mac-wk2/Skipped:
11:26 AM Changeset in webkit [82291] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed build fix. Remove ASSERT hitting consitently on GTK.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::moveToStartOf):
11:25 AM Changeset in webkit [82290] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Allow the AppleConnect plug-in to use the QuickDraw drawing model
https://bugs.webkit.org/show_bug.cgi?id=57365
<rdar://problem/8712320>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks):
  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
11:20 AM Changeset in webkit [82289] by Darin Adler
  • 5 edits in trunk/Source/WebKit2

2011-03-28 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

WebKit2 bundle page needs to offer generated file hooks
https://bugs.webkit.org/show_bug.cgi?id=57279

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added shouldGenerateFileForUpload and generateFileForUpload callback pointers.
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload): Added. (WebKit::InjectedBundlePageUIClient::generateFileForUpload): Added.
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Added functions above.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Implemented by calling the functions above. (WebKit::WebChromeClient::generateReplacementFile): Ditto.
11:20 AM Changeset in webkit [82288] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Fix some just-introduced build failures.

  • WebCore.pro: Correct spelling of filename.
  • css/CSSParser.cpp:

(WebCore::parseColorIntOrPercentage): Fix double/int conversion that fails to compile
on Leopard. Also renamed one local variabel.

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad): Removed unused argument names to avoid warning.
(WebCore::InspectorAgent::domContentLoadedEventFired): Ditto.

11:13 AM Changeset in webkit [82287] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix after r82247.

  • WebMutableURLRequest.cpp: The new CertificateCFWin routines

are not CFNetwork-specific. All CF-based ports can use them.

11:12 AM Changeset in webkit [82286] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline of fast/forms/listbox-bidi-align.html.

  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
11:10 AM Changeset in webkit [82285] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-29 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion failure in plug-in process with clang-built 32/64-bit WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57359

Don't use alignof when encoding and decoding scalar types.


Darwin 32-bit, double and unsigned long long are 4-byte aligned but on 64-bit they're
8-byte aligned which causes problems when doing IPC between 32-bit and 64-bit processes.
GCC is buggy and returns 8, but clang is correct and returns 4. Use sizeof instead which we know
is equal to or greater than the alignment.

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::decodeBool): (CoreIPC::ArgumentDecoder::decodeUInt32): (CoreIPC::ArgumentDecoder::decodeUInt64): (CoreIPC::ArgumentDecoder::decodeInt32): (CoreIPC::ArgumentDecoder::decodeInt64): (CoreIPC::ArgumentDecoder::decodeFloat): (CoreIPC::ArgumentDecoder::decodeDouble):
  • Platform/CoreIPC/ArgumentEncoder.cpp: (CoreIPC::ArgumentEncoder::encodeBool): (CoreIPC::ArgumentEncoder::encodeUInt32): (CoreIPC::ArgumentEncoder::encodeUInt64): (CoreIPC::ArgumentEncoder::encodeInt32): (CoreIPC::ArgumentEncoder::encodeInt64): (CoreIPC::ArgumentEncoder::encodeFloat): (CoreIPC::ArgumentEncoder::encodeDouble):
11:07 AM Changeset in webkit [82284] by Patrick Gansterer
  • 10 edits in trunk/Source/WebKit/win

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=57191

We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.

  • DefaultDownloadDelegate.cpp:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebCoreSupport/WebInspectorClient.cpp:
  • WebKitDLL.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebURLResponse.cpp:
  • WebView.cpp:
11:07 AM Changeset in webkit [82283] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r81928.

  • win/WebKit2.vcproj: Don't build CG-specific icon routines

for WinCairo port.

11:03 AM Changeset in webkit [82282] by abecsi@webkit.org
  • 5 edits in trunk

2011-03-29 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708

Implement fast-path parsing for percentage color values.

Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.

  • fast/canvas/script-tests/rgba-parsing.js: Add cases to test the consistency.

2011-03-29 Andras Becsi <abecsi@webkit.org>

Reviewed by Darin Adler.

CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708

Implement fast-path parsing for percentage color values.

Gain ~30% speedup on http://canvex.lazyilluminati.com/misc/3d.html.

  • css/CSSParser.cpp: (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double. (WebCore::parseDouble): Function for parsing double values if they are valid. (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values. (WebCore::parseAlphaValue): Use the new functions. (WebCore::CSSParser::parseColor): Ditto.
11:01 AM Changeset in webkit [82281] by loislo@chromium.org
  • 24 edits
    2 adds in trunk

2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract InspectorPageAgent from InspectorAgent.
https://bugs.webkit.org/show_bug.cgi?id=57327

There are page related methods and inspector related methods in InspectorAgent.
It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

  • GNUmakefile.am:
  • WebCore.gypi:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::pageAgent):
  • inspector/InspectorPageAgent.cpp: Added. (WebCore::InspectorPageAgent::create): (WebCore::InspectorPageAgent::InspectorPageAgent): (WebCore::InspectorPageAgent::setFrontend): (WebCore::InspectorPageAgent::clearFrontend): (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad): (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad): (WebCore::InspectorPageAgent::reloadPage): (WebCore::InspectorPageAgent::openInInspectedWindow): (WebCore::InspectorPageAgent::setUserAgentOverride): (WebCore::buildObjectForCookie): (WebCore::buildArrayForCookies): (WebCore::InspectorPageAgent::getCookies): (WebCore::InspectorPageAgent::deleteCookie): (WebCore::InspectorPageAgent::inspectedURLChanged): (WebCore::InspectorPageAgent::restore): (WebCore::InspectorPageAgent::didCommitLoad): (WebCore::InspectorPageAgent::domContentEventFired): (WebCore::InspectorPageAgent::loadEventFired): (WebCore::InspectorPageAgent::didClearWindowObjectInWorld): (WebCore::InspectorPageAgent::applyUserAgentOverride):
  • inspector/InspectorPageAgent.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::retrievePageAgent):
  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorPageAgent): (WebCore::InstrumentingAgents::setInspectorPageAgent):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookie): (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
  • inspector/front-end/inspector.js: (WebInspector.openResource): (WebInspector.documentKeyDown):

2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract InspectorPageAgent from InspectorAgent.
https://bugs.webkit.org/show_bug.cgi?id=57327

There are page related methods and inspector related methods in InspectorAgent.
It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage):
10:56 AM Changeset in webkit [82280] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57276

Reviewed by Darin Adler.

Add optimizations to make the vertical placement of boxes much faster. Whenever a box is added
to a line, compare it with the parent box. If we can determine that the child box has the exact
same height and baseline position as the parent box, then we keep a boolean flag set called
descendantsHaveSameLineHeightAndBaseline(). If the box is different for any reason then we clear the
flag up the line box parent chain.

When it comes time to do computeLogicalboxHeights, we can avoid recurring into the children of
a box whose descendants all have the same position. When we do placeBoxesInBlockDirection, we
can do a simplified recursion that just calls adjustBlockDirectionPosition to offset the boxes
without doing anything else.

Because of the quirks mode rule of only shrinking boxes with no immediate text children, we need
to track whether a box has text descendants now as well. When we avoid doing the recursion
this flag tells us whether the collection of boxes should have an effect on the ascent and descent
of the line in quirks mode.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasTextDescendants):
(WebCore::InlineFlowBox::descendantsHaveSameLineHeightAndBaseline):
(WebCore::InlineFlowBox::clearDescendantsHaveSameLineHeightAndBaseline):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

10:54 AM Changeset in webkit [82279] by tony@chromium.org
  • 6 edits
    3 adds in trunk/Tools

2011-03-29 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] NRWT should be able to read checksums from png comments
https://bugs.webkit.org/show_bug.cgi?id=57280

  • Scripts/read-checksum-from-png: Added. Utility script to read the checksum

from a file.

  • Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,

if the -checksum.txt file doesn't exist, try looking in the png.

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first

2k for a png comment with the checksum

  • Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
10:50 AM Changeset in webkit [82278] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

  • platform/gtk/Skipped: Skip fast/loader/onload-willSendRequest-null-for-frame.html.
10:44 AM Changeset in webkit [82277] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Remove a bunch of duplicate code by adding some InlineIterator helper methods
https://bugs.webkit.org/show_bug.cgi?id=57326

Once I started adding these it became clear how much crazy duplicated code
we had due to treating InlineIterator as a struct and accessing its
members directly. We can't quite make the members private yet since
findNextLineBreak still splits out the members. But this change
makes the code much cleaner.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::clear): (WebCore::InlineIterator::moveToStartOf):i (WebCore::InlineIterator::moveTo): (WebCore::InlineIterator::increment):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::tryHyphenating): (WebCore::RenderBlock::findNextLineBreak):
10:35 AM Changeset in webkit [82276] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-29 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Reproducible crash running under libgmalloc, in -[WKView(Internal) removeTrackingRect:] --&gt; objc_assign_ivar_non_gc
<rdar://problem/9193352>
https://bugs.webkit.org/show_bug.cgi?id=57358

-[WKView removeTrackingRect] can be called from below -[WKView dealloc] after we have
destroyed _data. So, nil out _data after releasing it and nil check it appropriately.


  • UIProcess/API/mac/WKView.mm: (-[WKView dealloc]): Nil out _data after releasing it.

(-[WKView removeTrackingRect:]):
Add early return for nil _data.

10:33 AM Changeset in webkit [82275] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Clean up bidiNext by abstracting repeated code
https://bugs.webkit.org/show_bug.cgi?id=57335

I also added a comment to explain what bidiNext is actually doing.
This whole area of code is confusing but need not be.

  • rendering/InlineIterator.h: (WebCore::embedCharFromDirection): (WebCore::notifyResolverEnteredObject): (WebCore::notifyResolverWillExitObject): (WebCore::bidiNext): (WebCore::bidiFirst):
10:31 AM Changeset in webkit [82274] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Support external CSS stylesheet freeflow text editing
https://bugs.webkit.org/show_bug.cgi?id=54397

In this implementation, Ctrl/Cmd-S commits the current changes into the model.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.CSSSourceFrameDelegateForResourcesPanel): (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.canEditScriptSource): (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource): (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource.handleInfos): (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype._saveStyleSheet):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer):
10:22 AM Changeset in webkit [82273] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for fast/forms/listbox-bidi-align.html,
added in r82200.

  • platform/gtk/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/gtk/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/gtk/fast/forms/listbox-bidi-align-expected.txt: Added.
10:12 AM Changeset in webkit [82272] by eric.carlson@apple.com
  • 4 edits
    3 adds in trunk

2011-03-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

playbackRate should not be set to defaultPlaybackRate in play()
https://bugs.webkit.org/show_bug.cgi?id=55943

Test: media/video-playbackrate.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playbackRate): No need to ask the media engine for the current

rate, we already have the current value cached.

(WebCore::HTMLMediaElement::playInternal): Don't reset the engine's playback rate to

the default rate.

(WebCore::HTMLMediaElement::togglePlayState): Do reset the engine's playback rate to

the default rate before triggering playback.

  • manual-tests/media-default-playback-rate.html: Added.

2011-03-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

playbackRate should not be set to defaultPlaybackRate in play()
https://bugs.webkit.org/show_bug.cgi?id=55943

  • media/event-attributes-expected.txt:
  • media/video-playbackrate-expected.txt: Added.
  • media/video-playbackrate.html: Added.
10:12 AM Changeset in webkit [82271] by Philippe Normand
  • 2 edits in trunk/Tools

2011-03-29 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] http/tests/uri/username-with-no-hostname.html fails
https://bugs.webkit.org/show_bug.cgi?id=57325

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): URI host value check done case-insensitively.
10:06 AM Changeset in webkit [82270] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

I need to spend some more quality time with the rebaselining tool to
figure out how to make it update these (or I can update them manually
when I catch up).

  • platform/chromium/test_expectations.txt:
9:53 AM Changeset in webkit [82269] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

The text renders slightly differently on Snow Leopard.

  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Added.
9:42 AM Changeset in webkit [82268] by sfalken@apple.com
  • 5 edits
    28 adds in trunk/Source/JavaScriptCore

2011-03-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Use per-configuration vsprops in JavaScriptCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57350


Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.

9:38 AM Changeset in webkit [82267] by Philippe Normand
  • 4 edits in trunk

2011-03-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] http/tests/uri/username-with-no-hostname.html fails
https://bugs.webkit.org/show_bug.cgi?id=57325

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): Check URI before submitting the request to WebCore.

Reviewed by Martin Robinson.

[GTK] http/tests/uri/username-with-no-hostname.html fails
https://bugs.webkit.org/show_bug.cgi?id=57325

  • platform/gtk/Skipped: Unskip fixed test.
9:31 AM Changeset in webkit [82266] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

This test is flaky on Mac too.

  • platform/chromium/test_expectations.txt:
9:30 AM BuildingGtk edited by dominicc@google.com
(diff)
9:30 AM BuildingGtk edited by dominicc@google.com
Added additional packages required when running layout tests. (diff)
9:23 AM Changeset in webkit [82265] by jberlin@webkit.org
  • 3 edits in trunk/WebKitLibraries

Update the WebKitSystemInterface libraries for changes in the implementation.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
9:21 AM Changeset in webkit [82264] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-03-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Remove specialization of EventDispatcher with inversion of control.
https://bugs.webkit.org/show_bug.cgi?id=57285

Since some events have extra logic around their dispatch, allow them
to dispatch themselves and specialize the logic. This change only
converts KeyboardEvent to this model.

No functional change, covered by existing tests.

  • dom/Event.cpp: (WebCore::Event::dispatch): Added.
  • dom/Event.h: Updated decls.
  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Changed to ask event to dispatch

itself.

  • dom/EventDispatcher.h: Updated decls.
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::dispatch): Added, moving code from EventDispatcher.
  • dom/KeyboardEvent.h: Updated decls.
  • dom/Node.cpp: (WebCore::Node::dispatchKeyEvent): Changed to use the new ways.
9:12 AM Changeset in webkit [82263] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
https://bugs.webkit.org/show_bug.cgi?id=57329

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspect):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): (WebCore::InspectorDOMAgent::handleMousePress): (WebCore::InspectorDOMAgent::inspect): (WebCore::InspectorDOMAgent::focusNode): (WebCore::InspectorDOMAgent::highlight): (WebCore::InspectorDOMAgent::hideHighlight):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
9:04 AM Changeset in webkit [82262] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Add missing expectation (looks like a pass).

  • platform/chromium/svg: Added.
  • platform/chromium/svg/custom: Added.
  • platform/chromium/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
  • platform/chromium/svg/custom/use-in-symbol-with-offset-expected.png: Added.
9:02 AM Changeset in webkit [82261] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-29 Oliver Hunt <oliver@apple.com>

Reviewed by Eric Seidel.

REGRESSION(r82173): Causes assertion and test failures in run-javascriptcore-tests on Windows (Requested by aroben on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57333

constructDate now takes the global object explicitly as it may be called
by functions other than the constructor itself.

  • API/JSObjectRef.cpp: (JSObjectMakeDate):
  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::constructWithDateConstructor):
  • runtime/DateConstructor.h:
9:01 AM Changeset in webkit [82260] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, skipping a test failing on GTK+ bots.

[GTK] fast/text/justify-ideograph-leading-expansion.html fails on bots
https://bugs.webkit.org/show_bug.cgi?id=57346

  • platform/gtk/Skipped:
8:46 AM Changeset in webkit [82259] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

webkit2 does not pass tests that require the window to be focused.
https://bugs.webkit.org/show_bug.cgi?id=56988

Unreviewed, update the WK2 expected results for pseudo-any.html after r82183.

  • platform/mac-wk2/fast/css/pseudo-any-expected.txt:
  • platform/win-wk2/fast/css/pseudo-any-expected.txt:
8:40 AM Changeset in webkit [82258] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Add another test that depends on EventSender to the mac-wk2 Skipped file.

  • platform/mac-wk2/Skipped:

Add fast/events/mouse-relative-position.html.

8:33 AM Changeset in webkit [82257] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
https://bugs.webkit.org/show_bug.cgi?id=56602

Added new methods to interface while keeping the old ones to keep
chromium working until it is also patched.

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData2):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didReceiveData2):
8:30 AM Changeset in webkit [82256] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

Rename InlineIterator::pos to m_pos to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57342

Somehow I failed to upload this one earlier, no wonder later patches didn't apply.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::operator==): (WebCore::operator!=): (WebCore::InlineIterator::increment): (WebCore::InlineIterator::current): (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::checkMidpoints): (WebCore::RenderBlock::appendRunsForObject): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine): (WebCore::tryHyphenating): (WebCore::RenderBlock::findNextLineBreak):
8:26 AM Changeset in webkit [82255] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows expected semi-failure results after r82189

The test is passing, but we're failing to print out an error message so we don't match the
expected results. Printing the error message is tracked by <http://webkit.org/b/57334>.

  • platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Added.
8:25 AM Changeset in webkit [82254] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Benjamin Poulain.

https://bugs.webkit.org/show_bug.cgi?id=41953

Fix compile error on Solaris 10/Sun Studio 12 CC emanating from MathExtras.h

  • wtf/MathExtras.h:
8:22 AM Changeset in webkit [82253] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document BrowserDebugger agent.
https://bugs.webkit.org/show_bug.cgi?id=57331

  • inspector/Inspector.json:
8:09 AM Changeset in webkit [82252] by apavlov@chromium.org
  • 11 edits
    3 adds in trunk

2011-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt: Added.
  • inspector/styles/get-set-stylesheet-text.html: Added.
  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles/styles-add-blank-property.html: Tentatively fix flakiness by waiting for pending dispatches to finish
  • inspector/styles/styles-new-API.html:
8:07 AM Changeset in webkit [82251] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] DevTools shows two resources for each plugin resource loaded
https://bugs.webkit.org/show_bug.cgi?id=57101

Remove DevToolsAgent network callbacks as this information is now available through ResourceLoader

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
7:41 AM Changeset in webkit [82250] by jeremy@chromium.org
  • 5 edits
    4 adds in trunk

2011-03-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Implement text-align:match-parent as -webkit-match-parent.
https://bugs.webkit.org/show_bug.cgi?id=50951

Add tests to verify that the implementation works as expected.

  • fast/css/text-align-webkit-match-parent-expected.txt: Added.
  • fast/css/text-align-webkit-match-parent-parse-expected.txt: Added.
  • fast/css/text-align-webkit-match-parent-parse.html: Added.
  • fast/css/text-align-webkit-match-parent.html: Added.

2011-03-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Implement text-align:match-parent as -webkit-match-parent.
https://bugs.webkit.org/show_bug.cgi?id=50951

Add support to the CSS parser.

Tests: fast/css/text-align-webkit-match-parent-parse.html

fast/css/text-align-webkit-match-parent.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
7:35 AM Changeset in webkit [82249] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57323

All of these m_nextBreakablePosition = -1 could probably be replaced with
some new methods. But I'll do that in a separate change. Clearly
m_nextBreakablePosition is just a cached value which should be cleared
at the right times. I suspect we may even fail to clear it sometimes when
we should due to the current used of direct access instead of smarter functions.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::increment):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::tryHyphenating): (WebCore::RenderBlock::findNextLineBreak):
7:30 AM Changeset in webkit [82248] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for new test added in r82200

Windows differs from Mac due to a different scrollbar width within the listbox.

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.
7:14 AM Changeset in webkit [82247] by jeffm@apple.com
  • 7 edits
    3 adds in trunk/Source

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Jon Honeycutt.

Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296

Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.

  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Jon Honeycutt.

Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296

Create a new win directory in platform/cf and add CertificateCFWin.cpp and CertificateCFWin.h to it.

  • WebCore.vcproj/WebCore.vcproj: Added CertificateCFWin.cpp and CertificateCFWin.h.
  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy all header files in \platform\cf\win\.
  • platform/cf/win: Added.
  • platform/cf/win/CertificateCFWin.cpp: Added. (WebCore::deallocCertContext): Added. (WebCore::createCertContextDeallocator): Added. (WebCore::copyCertificateToData): Added.
  • platform/cf/win/CertificateCFWin.h: Added.

2011-03-29 Jeff Miller <jeffm@apple.com>

Reviewed by Jon Honeycutt.

Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296


Remove duplicate code that implemented this functionality in WebCoreArgumentCodersWin.cpp and use WebCore::copyCertificateToData() instead.

  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceError): Use WebCore::copyCertificateToData().
7:09 AM Changeset in webkit [82246] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-29 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
https://bugs.webkit.org/show_bug.cgi?id=57303

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::doDragDrop): (EventSender::beginDragWithFiles):
7:06 AM Changeset in webkit [82245] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Rename InlineIterator::block to m_block to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57321

I could have made m_block private, since it's only accessed in
one place outside of InlineIterator (for an ASSERT). But I chose
not to do so in this change.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
6:36 AM Changeset in webkit [82244] by zoltan@webkit.org
  • 8 edits in trunk/Tools

[Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=57314

Reviewed by Andreas Kling.

Provide possibility to print loaded urls to the standard output.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::printURL):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::printURL):
(LauncherWindow::cloneWindow):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

6:33 AM Changeset in webkit [82243] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-29 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix for build-webkit -minimal.

Breakage introduced by http://trac.webkit.org/changeset/82238.
The minimal option has no support for shortcuts.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
6:28 AM Changeset in webkit [82242] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Incorrect offset of svg <use> element which is in <symbol> element
https://bugs.webkit.org/show_bug.cgi?id=57318

Test case to verify offset of svg <use> element in <symbol> element
is set correctly.

  • platform/qt/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
  • platform/qt/svg/custom/use-in-symbol-with-offset-expected.png: Added.
  • svg/custom/use-in-symbol-with-offset-expected.txt: Added.
  • svg/custom/use-in-symbol-with-offset.svg: Added.

2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Incorrect offset of svg <use> element which is in <symbol> element
https://bugs.webkit.org/show_bug.cgi?id=57318

When webkit expanded a svg <symbol> element in the shadow tree it
would clone the children of the <symbol>. The children may contain
SVGShadowTreeContainerElement which was expanded from svg <use>
element. But the clone operation would clone a
SVGShadowTreeContainerElement as a svg <g> element. This resulted
that updateContainerOffset wouldn't update offset for those elements
which were expand from <use> elements.

This patch implements cloneElementWithoutAttributesAndChildren for
SVGShadowTreeContainerElement to make the container clone itself
correctly.

Test: svg/custom/use-in-symbol-with-offset.svg

  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
  • rendering/svg/SVGShadowTreeElements.h:
6:18 AM Changeset in webkit [82241] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Rename InlineIterator::obj to m_obj to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57319

I started this rename after confusion in InlineBidiResolver::appendRun.
(Which uses an "obj" local in InlineIterator.h. It's not actually
masking m_obj because it's a separate class, but I didn't realize
that at the time because it's in InlineIterator.h which is itself confusing!)

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::operator==): (WebCore::operator!=): (WebCore::InlineIterator::increment): (WebCore::InlineIterator::atEnd): (WebCore::InlineIterator::current): (WebCore::InlineIterator::direction): (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::checkMidpoints): (WebCore::RenderBlock::appendRunsForObject): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::requiresLineBox): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::tryHyphenating): (WebCore::RenderBlock::findNextLineBreak):
6:18 AM Changeset in webkit [82240] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018

Rubber-stamped by Andreas Kling.

Symbian buildfix after r82232.

  • Source/WebKit.pri: Readd uitools option.
6:05 AM Changeset in webkit [82239] by pfeldman@chromium.org
  • 23 edits in trunk

2011-03-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document Timeline domain, make timeline event types of type string.
https://bugs.webkit.org/show_bug.cgi?id=57299

  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch-expected.txt:
  • inspector/timeline/timeline-layout-expected.txt:
  • inspector/timeline/timeline-mark-timeline-expected.txt:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-paint-expected.txt:
  • inspector/timeline/timeline-parse-html-expected.txt:
  • inspector/timeline/timeline-recalculate-styles-expected.txt:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
  • inspector/timeline/timeline-script-tag-2-expected.txt:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline):
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
  • platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-paint-expected.txt:
  • platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:

2011-03-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document Timeline domain, make timeline event types of type string.
https://bugs.webkit.org/show_bug.cgi?id=57299

  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::start): (WebCore::InspectorTimelineAgent::stop): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::didDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::didReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._createEventDivider): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelineDispatcher.prototype.started): (WebInspector.TimelineDispatcher.prototype.stopped): (WebInspector.TimelineDispatcher.prototype.eventRecorded): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
6:04 AM Changeset in webkit [82238] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179

Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
5:58 AM Changeset in webkit [82237] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-29 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixing live edits tests on chromium.
https://bugs.webkit.org/show_bug.cgi?id=57316

  • inspector/debugger/live-edit.html:

2011-03-29 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixing live edits tests on chromium.
https://bugs.webkit.org/show_bug.cgi?id=57316

  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
5:55 AM Changeset in webkit [82236] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip crashing svg test on GTK.

  • platform/gtk/Skipped: Skip svg/text/text-deco-01-b.svg
5:29 AM Changeset in webkit [82235] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-29 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Fix documentation for QWebPage::repaintRequested()

This signal is always emitted when the page is dirtied, so remove
reference to old behavior where we would only emit the signal for
headless QWebPages.

  • Api/qwebpage.cpp:
5:28 AM Changeset in webkit [82234] by podivilov@chromium.org
  • 9 edits in trunk

2011-03-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix call frames positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=57036

  • inspector/debugger/debugger-eval-while-paused.html:

2011-03-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix call frames positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=57036

Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype._contextMenu): (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype.get debuggerPausedDetails): (WebInspector.DebuggerModel.prototype._pausedScript):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresenationCallFrame): Call frame wrapper for UI.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.get content):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
5:17 AM WebKit Team edited by alexis.menard@openbossa.org
(diff)
5:10 AM Changeset in webkit [82233] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Fix for execCommand("Delete") with an empty selection.
https://bugs.webkit.org/show_bug.cgi?id=56652

Add test for deleting an empty selection from an empty container.

  • editing/execCommand/delete-empty-container-expected.txt: Added.
  • editing/execCommand/delete-empty-container.html: Added.

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Fix for execCommand("Delete") with an empty selection.
https://bugs.webkit.org/show_bug.cgi?id=56652

Test: editing/execCommand/delete-empty-container.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.
5:01 AM Changeset in webkit [82232] by commit-queue@webkit.org
  • 2 edits in trunk

2011-03-29 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Removed modular references after support for the flag was removed.

Support was removed because the Qt Modularization project decided we
don't need it. It's better to base decisions on the available
information, as demonstrated in the patch by checking
QT.phonon.includes.

In addition, remove the reference to uitools. It has been moved to
QtKernel now, and therefore is always available.

[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018

  • Source/WebKit.pri:
5:00 AM Changeset in webkit [82231] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Patch by Gabor Loki <loki@webkit.org> on 2011-03-29
Rubber-stamped by Csaba Osztrogonác.

  • Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
4:44 AM Changeset in webkit [82230] by mnaganov@chromium.org
  • 6 edits in trunk

2011-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
make sure we don't return big amounts of data to forms.
https://bugs.webkit.org/show_bug.cgi?id=57227

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get dominatorIndex): (WebInspector.HeapSnapshotNode.prototype.get retainers): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype.get _allNodes): (WebInspector.HeapSnapshot.prototype.get nodeCount): (WebInspector.HeapSnapshot.prototype.get rootNodeIndex): (WebInspector.HeapSnapshot.prototype.hasId): (WebInspector.HeapSnapshot.prototype.get nodeIds): (WebInspector.HeapSnapshot.prototype._retainersForNode): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes): (WebInspector.HeapSnapshot.prototype._buildIdsList): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider):

2011-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
make sure we don't return big amounts of data to forms.
https://bugs.webkit.org/show_bug.cgi?id=57227

  • inspector/profiler/heap-snapshot.html:
4:34 AM Writing Reftests edited by hayato@chromium.org
(diff)
4:34 AM Changeset in webkit [82229] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix detailed heap snapshots UI.
https://bugs.webkit.org/show_bug.cgi?id=57235

Fix two problems:

  1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
  2. Long strings need to be truncated in grid, their contents can be shown on hover.
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/heapProfiler.css: (.detailed-heapshot-view .console-formatted-string): (.detailed-heapshot-view .data-grid tr.selected *): (.detailed-heapshot-view .data-grid:focus tr.selected *):
4:24 AM Changeset in webkit [82228] by loki@webkit.org
  • 3 edits in trunk/Tools

[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Reviewed by Csaba Osztrogonác.

  • Scripts/build-jsc:
  • Scripts/webkitdirs.pm:
4:20 AM Changeset in webkit [82227] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-29 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Highlight visible lines first
https://bugs.webkit.org/show_bug.cgi?id=57013

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleChunkNumber): (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks): (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops): (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber): (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLineChunks): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainChunk.prototype.set expanded):
4:13 AM Changeset in webkit [82226] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Yuta Kitamura <yutak@chromium.org>

Unreviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:02 AM Changeset in webkit [82225] by eae@chromium.org
  • 10 edits
    4 adds in trunk

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Relative mouse coordinates recalculated for target
https://bugs.webkit.org/show_bug.cgi?id=57130

Add mouse event performance test.

  • fast/events/mouse-relative-position-expected.txt: Added.
  • fast/events/mouse-relative-position.html: Added.
  • perf/mouse-event-expected.txt: Added.
  • perf/mouse-event.html: Added.

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Relative mouse coordinates recalculated for each target
https://bugs.webkit.org/show_bug.cgi?id=57130

Calculate relative coordinates lazily for mouse events instead of doing
it for each target. Speeds up dispatching of mouse events in deep dom
structures significantly, O(n2) to O(n).

Also fixes https://bugs.webkit.org/show_bug.cgi?id=34973

Tests: fast/events/mouse-relative-position.html

perf/mouse-event.html

  • dom/Event.cpp: (WebCore::Event::setTarget):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates): (WebCore::pageZoomFactor): (WebCore::MouseRelatedEvent::receivedTarget): (WebCore::MouseRelatedEvent::computeRelativePosition): (WebCore::MouseRelatedEvent::layerX): (WebCore::MouseRelatedEvent::layerY): (WebCore::MouseRelatedEvent::offsetX): (WebCore::MouseRelatedEvent::offsetY):
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp: (WebCore::UIEvent::layerX): (WebCore::UIEvent::layerY):
  • dom/UIEvent.h:

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Relative mouse coordinates recalculated for each target
https://bugs.webkit.org/show_bug.cgi?id=57130

  • public/WebDOMMouseEvent.h:
  • src/WebDOMMouseEvent.cpp: (WebKit::WebDOMMouseEvent::layerX): (WebKit::WebDOMMouseEvent::layerY): (WebKit::WebDOMMouseEvent::offsetX): (WebKit::WebDOMMouseEvent::offsetY):
3:43 AM Changeset in webkit [82224] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing http/tests/uri test on GTK.

  • platform/gtk/Skipped:
3:38 AM Changeset in webkit [82223] by yutak@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-03-29 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r82195.
http://trac.webkit.org/changeset/82195
https://bugs.webkit.org/show_bug.cgi?id=56602

Broke Chromium Clang builds.

  • public/WebDevToolsAgent.h:
  • public/WebURLLoaderClient.h:
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
  • src/WebDevToolsAgentImpl.h:
3:31 AM Changeset in webkit [82222] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=57266

Add test for getComputedStyle(...).counterIncrement without a counter.

  • fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt: Added.
  • fast/css/getComputedStyle/counterIncrement-without-counter.html: Added.

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=57266

Add null check to counterToCSSValue.

Test: fast/css/getComputedStyle/counterIncrement-without-counter.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::counterToCSSValue):
2:34 AM Changeset in webkit [82221] by yutak@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-29 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Another build fix. The last fix was incorrect.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullscreenForNode): (WebKit::ChromeClientImpl::supportsFullScreenForElement):
  • src/ChromeClientImpl.h:
2:24 AM Changeset in webkit [82220] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-29 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed build fix (64 bit gcc).

GCC does not accept uint64_t formatted as %lli.

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): Add explicit cast to long long.
2:18 AM Changeset in webkit [82219] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, disable an assert in testwebview due to
https://bugs.webkit.org/show_bug.cgi?id=57315

  • tests/testwebview.c:
2:08 AM Changeset in webkit [82218] by yutak@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-29 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Build fix for Chromium Clang bot.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullscreenForNode):
  • src/ChromeClientImpl.h:
2:06 AM Changeset in webkit [82217] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

2011-03-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Tony Gentilcore.

Implement onerror events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=57182

  • fast/dom/HTMLLinkElement/prefetch-onerror-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-onerror.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Tony Gentilcore.

Implement onerror events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=57182

These events are equired on link elements, see
http://dev.w3.org/html5/spec/Overview.html#the-link-element

After a discussion in WebKit-dev about the direction of prefetch in the loader, and about a path
to adding the Link header, we decided to look at making onerror, onload and onbeforeload events
more uniformly supported. See the thread at
https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html .

It turned out that part of adding onerror for link prefetch was to make the top CachedResource less
abstract. It was pure virtual until prefetch became the first consumer to use an unspecialised
implementation, and this CL continues that by adding a default checkNotify method to it. As it
happens there were already two subclasses using what amounted to the generic checkNotify, so I
also removed those, buying us some code cleanup with the change.

Test: fast/dom/HTMLLinkElement/prefetch-onerror.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::onloadTimerFired): (WebCore::HTMLLinkElement::notifyFinished):
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::checkNotify): (WebCore::CachedResource::data): (WebCore::CachedResource::error):
  • loader/cache/CachedResource.h:
  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
1:58 AM Changeset in webkit [82216] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

http/tests/uri/username-with-no-hostname.html fails after r82151
https://bugs.webkit.org/show_bug.cgi?id=57306

  • platform/qt/Skipped: Add http/tests/uri/username-with-no-hostname.html until fix.
1:55 AM Changeset in webkit [82215] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add support for parsing unicode-bidi: -webkit-isolate
https://bugs.webkit.org/show_bug.cgi?id=57181

  • css3/unicode-bidi-insolate-parse-expected.txt: Added.
  • css3/unicode-bidi-insolate-parse.html: Added.

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add support for parsing unicode-bidi: -webkit-isolate
https://bugs.webkit.org/show_bug.cgi?id=57181

Test: css3/unicode-bidi-insolate-parse.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:
1:42 AM Changeset in webkit [82214] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r82193.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::openTemporaryFile):
1:40 AM Changeset in webkit [82213] by Philippe Normand
  • 7 edits in trunk/LayoutTests

2011-03-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline for r82144.

  • platform/gtk/fast/block/positioning/052-expected.checksum:
  • platform/gtk/fast/block/positioning/052-expected.png:
  • platform/gtk/fast/block/positioning/052-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
1:37 AM Changeset in webkit [82212] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=57231
Add conditional for SUNCC supporting alignment macros

Compile fix for Solaris 10/Sun Studio 12 CC

  • wtf/Vector.h:
1:35 AM Writing Reftests edited by hayato@chromium.org
(diff)
1:35 AM Writing Reftests edited by hayato@chromium.org
(diff)
1:32 AM Changeset in webkit [82211] by abarth@webkit.org
  • 23 edits in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Add GPU expectations for compositing tests (these appear to all be passes).

  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
1:21 AM Changeset in webkit [82210] by abarth@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Update IMAGE results to show test progression (yay!).

  • platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
  • platform/chromium-linux/fast/text/drawBidiText-expected.png:
  • platform/chromium-mac/fast/text/drawBidiText-expected.checksum: Added.
  • platform/chromium-mac/fast/text/drawBidiText-expected.png: Added.
  • platform/chromium-win-xp/fast/text/drawBidiText-expected.checksum: Added.
  • platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Added.
  • platform/chromium-win/fast/text/drawBidiText-expected.checksum:
  • platform/chromium-win/fast/text/drawBidiText-expected.png:
1:14 AM Changeset in webkit [82209] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Add Windows baselines.

  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.txt: Added.
1:10 AM Changeset in webkit [82208] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-29 Adam Barth <abarth@webkit.org>

Add platform-specific baselines for listbox-bidi-align.

  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt: Added.
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Added.
12:59 AM Changeset in webkit [82207] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=57256

Fix crash on misaligned reads on Solaris 10/Sparc

  • wtf/text/AtomicString.cpp: (WTF::equal):
12:37 AM Changeset in webkit [82206] by mjs@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WKPageGetSourceForFrame and WKPageGetContentsAsString should throw an error in case of a race with page loading
https://bugs.webkit.org/show_bug.cgi?id=57305
<rdar://problem/8738060>, <rdar://problem/8780168>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Clear m_loadDependentStringCallbackIDs (WebKit::WebPageProxy::getSourceForFrame): track the callback as load dependent (WebKit::WebPageProxy::getContentsAsString): ditto (WebKit::WebPageProxy::clearLoadDependentCallbacks): Invalidate all load dependent callbacks (WebKit::WebPageProxy::didCommitLoadForFrame): Call clearLoadDependentCallbacks (WebKit::WebPageProxy::didFailLoadForFrame): ditto (WebKit::WebPageProxy::stringCallback): Remove callback from load dependent set if appropriate (WebKit::WebPageProxy::processDidCrash): Clear m_loadDependentStringCallbackIDs
  • UIProcess/WebPageProxy.h: Add m_loadDependentStringCallbackIDs hash set.
12:30 AM Changeset in webkit [82205] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation
https://bugs.webkit.org/show_bug.cgi?id=57222

WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments().
Thus, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data
anymore.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
12:20 AM Changeset in webkit [82204] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-29 Adam Klein <adamk@chromium.org>

Reviewed by Darin Adler.

removeAllInDirectory() layout test helper method can call successCallback twice
https://bugs.webkit.org/show_bug.cgi?id=57136

Fixed to only call successCallback once, thereby avoiding
flakiness in tests which use this function
(see http://crbug.com/77442).

  • fast/filesystem/resources/fs-test-util.js: (removeAllInDirectory):
  • http/tests/filesystem/resources/fs-test-util.js: (removeAllInDirectory):
12:14 AM Changeset in webkit [82203] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-29 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test expectation for http/tests/uri/username-with-no-hostname.html.

  • platform/chromium/test_expectations.txt:

Mar 28, 2011:

11:59 PM Changeset in webkit [82202] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82198.
http://trac.webkit.org/changeset/82198
https://bugs.webkit.org/show_bug.cgi?id=57304

Broke Chromium Win build. (Requested by dave_levin on
#webkit).

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:45 PM Changeset in webkit [82201] by yutak@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, fix Chromium test results and expectations.

  • platform/chromium-mac-leopard/fast/block/positioning/047-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/047-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:42 PM Changeset in webkit [82200] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2011-03-28 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

  • fast/forms/listbox-bidi-align.html: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
  • platform/mac/fast/text/drawBidiText-expected.checksum: Updated.
  • platform/mac/fast/text/drawBidiText-expected.png: Updated.

2011-03-28 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

Test: fast/forms/listbox-bidi-align.html

  • rendering/RenderListBox.cpp: (WebCore::itemOffsetForAlignment): (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
11:32 PM Changeset in webkit [82199] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-28 Kwang Yul Seo <skyul@company100.net>

Reviewed by Benjamin Poulain.

[Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
https://bugs.webkit.org/show_bug.cgi?id=57142

TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
Remove ENABLE(VIDEO) guard.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
  • platform/graphics/texmap/TextureMapperNode.h:
  • platform/graphics/texmap/TextureMapperPlatformLayer.h: (WebCore::TextureMapperMediaLayer::layerType):
11:20 PM Changeset in webkit [82198] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Thomas Klausner <tk@giga.or.at>

Reviewed by David Levin.

png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406

Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).

Compilation fixes, so no new tests.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:18 PM Changeset in webkit [82197] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Kwang Yul Seo <skyul@company100.net>

Reviewed by Adam Barth.

Replace fprintf(stderr, ...) with LOG_ERROR
https://bugs.webkit.org/show_bug.cgi?id=57216

LOG_ERROR is a better choice here.

  • bridge/jni/v8/JavaClassV8.cpp: (JavaClass::JavaClass):
10:56 PM Changeset in webkit [82196] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

2011-03-28 Andrew Foster <andrewf@chromium.org>

Reviewed by Ojan Vafai.

webkit-patch should be more intelligent about whether a bug applies to a patch
Create a new function, parse_bug_id_from_changelog() which determines
that a bug is related to a patch by parsing the output generated from
prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
the description of a patch.
https://bugs.webkit.org/show_bug.cgi?id=56989

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/net/bugzilla/init.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py:
  • Scripts/webkitpy/tool/commands/upload.py:
10:53 PM Changeset in webkit [82195] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-03-28 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
https://bugs.webkit.org/show_bug.cgi?id=56602

Added new methods to interface while keeping the old ones to keep
chromium working until it is also patched.

  • public/WebDevToolsAgent.h:
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
  • src/WebDevToolsAgentImpl.h:
10:41 PM Changeset in webkit [82194] by steveblock@google.com
  • 7 edits
    1 add in trunk/Source/WebCore

2011-03-28 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add a new JavaValue to type to represent a Java value in the Java bridge
https://bugs.webkit.org/show_bug.cgi?id=57022

This change introduces a new JavaValue type and uses it in place of jvalue
in the conversions to and from JavaNPObject used in the V8 Java bridge.

Refactoring only, no new tests.

  • WebCore.gypi:
  • bridge/jni/JNIUtility.cpp: (JSC::Bindings::javaTypeFromClassName): (JSC::Bindings::signatureFromJavaType): (JSC::Bindings::getJNIField): (JSC::Bindings::callJNIMethod):
  • bridge/jni/JavaType.h:
  • bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJavaValue): (JSC::Bindings::convertJavaValueToNPVariant): (JSC::Bindings::jvalueToJavaValue): (JSC::Bindings::javaValueToJvalue):
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaValueV8.h: Added. (JSC::Bindings::JavaValue::JavaValue):
10:29 PM Changeset in webkit [82193] by Patrick Gansterer
  • 19 edits in trunk/Source

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use String instead of CString as return value of openTemporaryFile
https://bugs.webkit.org/show_bug.cgi?id=55332

We usually store all paths as UTF-16. Do this for temporary files too.

  • WebCore.exp.in
  • platform/FileSystem.h:
  • platform/android/FileSystemAndroid.cpp:
  • platform/brew/FileSystemBrew.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/haiku/FileSystemHaiku.cpp:
  • platform/mac/FileSystemMac.mm:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wince/FileSystemWinCE.cpp:
  • platform/wx/FileSystemWx.cpp:
  • plugins/PluginStream.cpp: (WebCore::PluginStream::destroyStream):
  • plugins/PluginStream.h:

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use String instead of CString as return value of openTemporaryFile
https://bugs.webkit.org/show_bug.cgi?id=55332

  • Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::initializeTempLogFile):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
10:28 PM Changeset in webkit [82192] by Patrick Gansterer
  • 1 edit
    2 deletes in trunk/Source/WebKit/win

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Remove unused DOMCreateInstance files
https://bugs.webkit.org/show_bug.cgi?id=57193

  • DOMCreateInstance.cpp: Removed.
  • DOMCreateInstance.h: Removed.
10:08 PM Changeset in webkit [82191] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>

Reviewed by Pavel Feldman.

Web Inspector: empty, non-functional window
https://bugs.webkit.org/show_bug.cgi?id=56354

Check whether DOM local storage is enabled
before attempting to access window.localStorage.

No new tests.

9:57 PM Changeset in webkit [82190] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Clean up Chromium test expectations for plugins/embed-prefers-plugins-for-images.html.

  • platform/chromium/test_expectations.txt:
9:47 PM Changeset in webkit [82189] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Fix test results that were accidentally committed with a wrong
result due to a temporary wrong code change.

  • http/tests/uri/username-with-no-hostname-expected.txt:
9:36 PM Changeset in webkit [82188] by aestes@apple.com
  • 4 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/chromium/test_expectations.txt: Skip the test.
  • platform/gtk/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
8:47 PM Changeset in webkit [82187] by aestes@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

Make embed-prefers-plugins-for-images.html pass on all Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/win/Skipped:
  • plugins/embed-prefers-plugins-for-images-expected.txt:
  • plugins/embed-prefers-plugins-for-images.html:
8:04 PM Changeset in webkit [82186] by mjs@apple.com
  • 2 edits in trunk/Tools

Revert accidentally commited change.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

7:39 PM Changeset in webkit [82185] by Beth Dakin
  • 5 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>

Reviewed by Darin Adler.

This patch rolls out revision 79053 and fixes the same bug in a better way.

New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

Roll-out of 79053.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):

  • page/FrameView.h:
7:36 PM Changeset in webkit [82184] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

fix style sharing with :any and sibling selectors
https://bugs.webkit.org/show_bug.cgi?id=57211

Also tests sibling selector style sharing in general since
no existing tests seem to cover that codepath.

  • fast/css/sibling-selectors-expected.txt: Added.
  • fast/css/sibling-selectors.html: Added.

2011-03-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

fix style sharing with :any and sibling selectors
https://bugs.webkit.org/show_bug.cgi?id=57211

Test: fast/css/sibling-selectors.html

  • css/CSSStyleSelector.cpp: (WebCore::collectFeaturesFromList):
7:30 PM Changeset in webkit [82183] by ojan@chromium.org
  • 6 edits in trunk

2011-03-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

fix :-webkit-any(:last-child)
https://bugs.webkit.org/show_bug.cgi?id=57207

  • fast/css/pseudo-any.html:

2011-03-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

fix :-webkit-any(:last-child)
https://bugs.webkit.org/show_bug.cgi?id=57207

We were passing the wrong arguments to checkSelector. Also, we were not
passing through the encounteredLink bool.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSStyleSelector.h:
7:15 PM Styling Form Controls edited by tkent@chromium.org
(diff)
6:45 PM Changeset in webkit [82182] by aestes@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-wk2/plugins: Added.
  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
6:42 PM Styling Form Controls edited by tkent@chromium.org
(diff)
6:26 PM Changeset in webkit [82181] by mjs@apple.com
  • 5 edits in trunk

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
https://bugs.webkit.org/show_bug.cgi?id=57291

  • platform/KURL.cpp: (WebCore::KURL::parse): Instead of considering URLs with credentials but no host invalid, consider them to have a host ending in @ (which fails down the line)/

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION(r82152): fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
https://bugs.webkit.org/show_bug.cgi?id=57291

  • http/tests/uri/username-with-no-hostname.html: Adjusted test to be more tolerant of exactly how the image load fails.
6:10 PM Changeset in webkit [82180] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix some problems of the appearance of form validation message bubble.
https://bugs.webkit.org/show_bug.cgi?id=57208

No new tests. Validation message bubble appearance is not testable
because it depends on a timer.

  • css/html.css: (::-webkit-validation-bubble): (::-webkit-validation-bubble-message): (::-webkit-validation-bubble-arrow): (::-webkit-validation-bubble-arrow-clipper):
    • Explicitly set margin, padding, and color.
    • Make the shadow darker.
    • Make the background color darker.
    • Make opacity larger.
    • Make the border color lighter.
    • Add inset shadows
    • Change the implementation of an arrow. Stop making a right triangle by the border trick. Use -webkit-transform instead.
    • Make min-width workable by changing display property of -webkit-validation-bubble to "inline-block".
  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Change the node structure. Before this change, -webkit-validation-bubble had three DIVs inside. After this change, it has two DIVs; -webkit-validation-bubble-arrow-clipper and -webkit-validation-bubble-message, and -webkit-validation-bubble-arrow-clipper contains -webkit-validation-bubble-arrow.
6:06 PM Changeset in webkit [82179] by mdelaney@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

2011-03-28 Matthew Delaney <mdelaney@apple.com>

Reviewed by Adele Peterson.

Updating small batch of gradient expected results files
https://bugs.webkit.org/show_bug.cgi?id=57117

  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
5:41 PM Changeset in webkit [82178] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

REGRESSION: http/tests/inspector/console-resource-errors.html failing on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=56539

Unreviewed, remove the platform-specific failing results to get the bots green.
The test appears to be working in WebKit after r82106 and r82017.

  • platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Removed.
5:33 PM Changeset in webkit [82177] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Vincent Scheib <scheib@chromium.org>

Chromium test expectation for r82159

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [82176] by enrica@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: Can't enter pasted with context or Edit menu text in search or address field in the browser.
https://bugs.webkit.org/show_bug.cgi?id=57275
<rdar://problem/8246691>

Reviewed by Sam Weinig.

We need to classify cut and paste actions as user typing actions even when
the action is triggered by a context menu selection to
allow the propagation of the textDidChangeInTextField event.

  • editing/EditorCommand.cpp:

The following methods have been modified to properly set up
the UserTypingGestureAction when the command source is the
menu or a key binding sequence.
(WebCore::executeCut):
(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeDelete):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Changed to
call execute command instead of referring to the specific method in
the editor class.

4:53 PM Changeset in webkit [82175] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Add another test that depends on EventSender to the mac-wk2 Skipped file.

  • platform/mac-wk2/Skipped:

Add fast/events/onchange-text-form-field.html.

4:49 PM Changeset in webkit [82174] by tony@chromium.org
  • 4 edits in trunk

2011-03-28 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] have DRT write the png checksum into a png comment
https://bugs.webkit.org/show_bug.cgi?id=57255

  • DEPS: Pull in version of chromium with comment writing

2011-03-28 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] have DRT write the png checksum into a png comment
https://bugs.webkit.org/show_bug.cgi?id=57255

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
4:39 PM Changeset in webkit [82173] by oliver@apple.com
  • 39 edits
    3 adds in trunk

2011-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250

Add test cases for correct behaviour

  • fast/js/js-constructors-use-correct-global-expected.txt: Added.
  • fast/js/js-constructors-use-correct-global.html: Added.
  • fast/js/resources/js-constructors-use-correct-global.js: Added.

2011-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250

This is a problem with all built in constructors, the use of
lexicalGlobalObject rather than the constructors own
global object reference means that a builtin will always use
the prototype from the lexical global object rather than that
of the constructors origin.

  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeRegExp):
  • JavaScriptCore.exp:
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h:
  • runtime/DateConstructor.cpp: (JSC::constructDate):
  • runtime/DateInstance.cpp:
  • runtime/DateInstance.h:
  • runtime/ErrorConstructor.cpp: (JSC::constructWithErrorConstructor): (JSC::callErrorConstructor):
  • runtime/FunctionConstructor.cpp: (JSC::constructWithFunctionConstructor): (JSC::callFunctionConstructor): (JSC::constructFunction):
  • runtime/FunctionConstructor.h:
  • runtime/JSCell.cpp: (JSC::JSCell::getOwnPropertySlot): (JSC::JSCell::put): (JSC::JSCell::deleteProperty): (JSC::JSCell::toThisObject): (JSC::JSCell::toObject):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toObject):
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toObject):
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::toObject):
  • runtime/JSObject.h:
  • runtime/JSString.cpp: (JSC::StringObject::create): (JSC::JSString::toObject): (JSC::JSString::toThisObject):
  • runtime/JSString.h:
  • runtime/JSValue.cpp: (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::toThisObjectSlowCase): (JSC::JSValue::synthesizeObject):
  • runtime/JSValue.h:
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/ObjectConstructor.cpp: (JSC::constructObject): (JSC::constructWithObjectConstructor): (JSC::callObjectConstructor):
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp): (JSC::constructWithRegExpConstructor): (JSC::callRegExpConstructor):
  • runtime/RegExpConstructor.h:
  • runtime/StringConstructor.cpp: (JSC::constructWithStringConstructor):
  • runtime/StringObject.h:

2011-03-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250

Up date for new toObject api

  • UserObjectImp.cpp: (UserObjectImp::toPrimitive): (UserObjectImp::toBoolean): (UserObjectImp::toNumber): (UserObjectImp::toString):

2011-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

instanceof Array test fails when using iframes
https://bugs.webkit.org/show_bug.cgi?id=17250

Update for new function and date apis

Test: fast/js/js-constructors-use-correct-global.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
4:24 PM Changeset in webkit [82172] by adele@apple.com
  • 2 edits in trunk/Tools

Removing Qt stub, since it doesn't use the same header as the others.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4:15 PM Changeset in webkit [82171] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=57124 When the scroller style is
changed via delegate method, the page needs a full relayout and repaint
-and corresponding-
<rdar://problem/9059129>

Reviewed by Darin Adler.

Call into WebKitSystemInterface to associate the new painter with the existing
painter controller. Reset the scrollbar frame rects to the new thickness -- normally
this only happens when a scrollbar is created, so we have to reset the thickness
here to pick up the new theme thickness. Finally, force a full relayout and style
recall with setNeedsRecalcStyleInAllFrames()

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):

setNeedsRecalcStyleInAllFrames() used to be a static method in Settings.cpp. This
patch moves it to be a member function on Page so that it can be called from
FrameView when the scrollbar style changes.

  • page/FrameView.cpp:

(WebCore::FrameView::setNeedsRecalcStyleInAllFrames):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setNeedsRecalcStyleInAllFrames):

  • page/Page.h:
  • page/Settings.cpp:

(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::setMinimumFontSize):
(WebCore::Settings::setMinimumLogicalFontSize):
(WebCore::Settings::setDefaultFontSize):
(WebCore::Settings::setDefaultFixedFontSize):
(WebCore::Settings::setTextAreasAreResizable):
(WebCore::Settings::setAuthorAndUserStylesEnabled):
(WebCore::Settings::setFontRenderingMode):
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setShowDebugBorders):
(WebCore::Settings::setShowRepaintCounter):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setNeedsRecalcStyleInAllFrames):

4:11 PM Changeset in webkit [82170] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Dirk Pranke <dpranke@chromium.org>

RS=Tony Chang.

r81977 moved FontPlatformData.h from
WebCore/platform/graphics/cocoa to platform/graphics. This
change updates the chromium build accordingly.

https://bugs.webkit.org/show_bug.cgi?id=57281

  • platform/graphics/chromium/CrossProcessFontLoading.mm:
3:56 PM Changeset in webkit [82169] by scheib@chromium.org
  • 7 edits in trunk/LayoutTests

2011-03-28 Vincent Scheib <scheib@chromium.org>

Chromium rebaseline for r82144.

  • platform/chromium-linux/fast/block/positioning/058-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/052-expected.txt:
  • platform/chromium-win/fast/block/positioning/058-expected.checksum:
  • platform/chromium-win/fast/block/positioning/058-expected.png:
  • platform/chromium-win/fast/block/positioning/058-expected.txt:
  • platform/chromium/test_expectations.txt:
3:43 PM Changeset in webkit [82168] by adele@apple.com
  • 4 edits in trunk/Tools

Added a few more stubs.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::hasGrammarMarker):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::hasGrammarMarker):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::hasGrammarMarker):

3:31 PM Changeset in webkit [82167] by jer.noble@apple.com
  • 9 edits in trunk

MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=57249

Reviewed by Darin Adler.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
3:22 PM Changeset in webkit [82166] by adele@apple.com
  • 4 edits in trunk

Build fix.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):

Tools:

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::hasGrammarMarker):

3:07 PM Changeset in webkit [82165] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-03-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

http streams don't always display video with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=57203

No new tests, we don't currently have tests for http live streams. Changes verified manually.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_shouldPrepareToRender. (WebCore::MediaPlayer::loadWithNextMediaEngine): Call prepareForRendering on new engine

if m_shouldPrepareToRender is set.

(WebCore::MediaPlayer::prepareForRendering): Set m_shouldPrepareToRender.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup): Don't return true until

m_isAllowedToRender has been set.

(WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Always call setUpVideoRendering,

it has logic to figure out when setup is required.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Call setUpVideoRendering when we aren't

using the preferred rendering mode because if we get a file's metadata between the
time supportsAcceleratedRendering() and paint() are called, we will allocate a software
renderer even when we prefer a layer backed renderer.

(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Return "unknown" until we have metadata.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use itemKVOProperties() instead of

an explicit list of key path names.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): metadataKeyNames renamed

to assetMetadataKeyNames, return an NSArray instead of a CFArrayRef since that is what the
callers need.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Return the duration of the

player item, not the asset, because AVAsset.duration always returns an indefinite time
for all streaming files.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): metadataKeyNames renamed

to assetMetadataKeyNames.

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): Do nothing until

metadata is available.

(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Split size calculation logic off

into sizeChanged().

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): New. Use AVPlayerItem.presentationSize

until tracks is non-NULL so we have a size as early as possible.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetMetadataKeyNames): Renamed from metadataKeyNames.
(WebCore::MediaPlayerPrivateAVFoundationObjC::itemKVOProperties): New, return an array of

KVO observable properties.

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Respond to

presentationSize change.

3:04 PM Changeset in webkit [82164] by adele@apple.com
  • 4 edits in trunk/Source/WebKit

../WebKit/chromium: Build fix.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):

Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

../WebKit/win: Build fix.

  • WebFrame.cpp: (WebFrame::hasSpellingMarker):

Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.

3:01 PM Changeset in webkit [82163] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Search field focus ring is missing
https://bugs.webkit.org/show_bug.cgi?id=57270
<rdar://problem/8765555>

Add an _automaticFocusRingDisabled method which returns YES.

  • platform/mac/ThemeMac.mm: (-[WebCoreFlippedView _automaticFocusRingDisabled]):
3:00 PM Changeset in webkit [82162] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESSION [r78794-r79249] Allocation of memory is slow when number of active objects is large
https://bugs.webkit.org/show_bug.cgi?id=56823


Partial fix for most of the problem. (TOT still shows a regression, though.)

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Use highWaterMark(), instead of capacity(), since capacity() is O(n) relative to the size of the heap.

In limited circumstances, capacity() is also worse than highWaterMark()
for measuring extra cost relative to heap size, since capacity() only
measures the *current* capacity of the heap, but the heap will grow if
necessary to attain highWaterMark().

2:53 PM Changeset in webkit [82161] by aestes@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in failing results for embed-prefers-plugins-for-images.html on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Added.
2:49 PM Changeset in webkit [82160] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move more events to EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=57247

No functional changes, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::eventTargetRespectingSVGTargetRules): Made a static function,

since it's not used anywhere outside of the EventDispatcher.

(WebCore::EventDispatcher::dispatchScopedEvent): Moved from Node.cpp.
(WebCore::EventDispatcher::dispatchKeyEvent): Ditto.
(WebCore::EventDispatcher::dispatchWheelEvent): Ditto.
(WebCore::EventDispatcher::dispatchEvent): Changed to use eventTargetRespectingSVGTargetRules

as a static function.

  • dom/EventDispatcher.h: Updated decls.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Replaced with calling EventDispatcher. (WebCore::Node::dispatchKeyEvent): Ditto. (WebCore::Node::dispatchWheelEvent): Ditto.
2:48 PM Changeset in webkit [82159] by adele@apple.com
  • 17 edits
    2 adds in trunk

Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

Test: editing/spelling/grammar.html

  • WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar,

so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph. In the case of this bug,
when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used
in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph
is the only one operated on when this information is used.
(WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.

  • editing/Editor.h:

Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • WebView/WebFrame.mm:

(-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
(-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.

  • WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.

Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • DumpRenderTree/LayoutTestController.cpp:

(hasGrammarMarkerCallback): Added.
(LayoutTestController::staticFunctions): Added case for hasGrammarMarker.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.

LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
https://bugs.webkit.org/show_bug.cgi?id=57173

Reviewed by Eric Seidel.

  • editing/spelling/grammar-expected.txt: Added.
  • editing/spelling/grammar.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:32 PM Changeset in webkit [82158] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8895977> REGRESSION: multicol crashes with positioned elements
https://bugs.webkit.org/show_bug.cgi?id=48983

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/paginated-layer-crash.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintPaginatedChildLayer): Bring the logic for finding pagintating layers
into sync with updatePagination() after r68069.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Ditto.

LayoutTests:

  • fast/multicol/paginated-layer-crash-expected.txt: Added.
  • fast/multicol/paginated-layer-crash.html: Added.
2:32 PM Changeset in webkit [82157] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Downloads started with DownloadCFNet::start never start
https://bugs.webkit.org/show_bug.cgi?id=57268

Reviewed by Jon Honeycutt.

  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::start): Call CFURLDownloadStart on the download we create.

2:28 PM Changeset in webkit [82156] by scheib@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-28 Vincent Scheib <scheib@chromium.org>

Chromium rebaseline for r82123.

  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
2:23 PM Changeset in webkit [82155] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Reviewed by Benjamin Poulain.

Trivial typo fix after r82082.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

2:00 PM Changeset in webkit [82154] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • Shared/ShareableBitmap.h:
1:58 PM Changeset in webkit [82153] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Beep when pressing a menu key equivalent when a plug-in has focus
https://bugs.webkit.org/show_bug.cgi?id=57264
<rdar://problem/8935597>

We don't want the WKTextInputWindowController inputContext to be involved in interpretKeyEvents.

  • UIProcess/API/mac/WKView.mm: (-[WKView inputContext]):
1:53 PM Changeset in webkit [82152] by mjs@apple.com
  • 3 edits
    2 adds in trunk

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler' .

URLSs with non-empty username but empty hostname treat first path segment as hostname, potentially enabling XSS
https://bugs.webkit.org/show_bug.cgi?id=57220

Test: http/tests/uri/username-with-no-hostname.html

  • platform/KURL.cpp: (WebCore::hostPortIsEmptyButUserPassIsNot): (WebCore::KURL::parse):

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler' .

URLSs with non-empty username but empty hostname are allowed to load
https://bugs.webkit.org/show_bug.cgi?id=57220

  • http/tests/uri/username-with-no-hostname-expected.txt: Added.
  • http/tests/uri/username-with-no-hostname.html: Added.
1:45 PM Changeset in webkit [82151] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-03-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

CGImageRefs must hold a strong reference to underlying data
https://bugs.webkit.org/show_bug.cgi?id=57263
<rdar://problem/9146179>

Make paintBitmapContext use CGBitmapContextCreateImage, which creates a copy-on-write copy
of the bitmap data. Also, add ShareableBitmap::makeCGImageCopy which does the same thing, and
ShareableBitmap::makeCGImage in the cases where we know that the ShareableBitmap data will never change.

  • Platform/cg/CGUtilities.cpp: (WebKit::paintImage): Factor image painting code out into a separate function.

(WebKit::paintBitmapContext):
Call paintImage.

  • Shared/API/c/cg/WKImageCG.cpp: (WKImagemakeCGImage): Use ShareableBitmap::makeCGImageCopy.
  • Shared/ShareableBitmap.h:
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint): (WebKit::ShareableBitmap::makeCGImageCopy): (WebKit::ShareableBitmap::makeCGImage): (WebKit::ShareableBitmap::releaseBitmapContextData): (WebKit::ShareableBitmap::releaseDataProviderData): Add makeCGImage and makeCGImageCopy.
  • Shared/cg/WebCoreArgumentCodersCG.cpp: (CoreIPC::createImage): Use ShareableBitmap::makeCGImage.


  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setDragImage): Use ShareableBitmap::makeCGImage and plug a CGImageRef leak.
1:34 PM Changeset in webkit [82150] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): It's not "event" in this function, it's "theEvent".
1:32 PM Changeset in webkit [82149] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests

Update progressing layout tests on SL.

1:19 PM Changeset in webkit [82148] by ap@apple.com
  • 7 edits in trunk/Source

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=57260
Clean up text input code a little

WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyboardEvent): (WebEditorClient::handleInputMethodKeydown):
  • WebView/WebHTMLViewInternal.h: Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept anything. It's just a version it interpretKeyEvents: that tells us whether it was handled, and also possibly saves resulting commands for later execution.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event handling state, like the other booleans there. Don't call interpretKeyEvents: again simply because the first call resulted in no saved commands, becasue it's confusing and apparently useless (I couldn't find any broken behavior). (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView doCommandBySelector:]): Ditto. (-[WebHTMLView insertText:]): Ditto.
  • WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand: method on WebView.

WebKit2:

  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): This NSTextInput protocol method lacked a LOG() call. (-[WKView keyDown:]): Added (possibly useless) event protection to match performKeyEquivalent: and also WebKit1.
  • WebProcess/WebPage/mac/WebPageMac.mm: Removed an obsolete comment.
1:16 PM Changeset in webkit [82147] by abarth@webkit.org
  • 6 edits
    3 adds in trunk

2011-03-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline event handlers
https://bugs.webkit.org/show_bug.cgi?id=57212

I considered wrapping this into the canExecute check, but that approach
would require passing that function a bunch of context information to
behave correctly once we add support for the "options" directive that
re-enables these features.

Test: http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html

  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
    • This function was a mess. I couldn't resist cleaning it up a bunch. Notice that we ASSERT at the beginning of the function that scriptExecutionContext is a document and that both ways of getting the global object are the same when document->frame() is non-zero because the document must be active and there is a one-to-one relation between Frames and active Documents.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
  • page/ContentSecurityPolicy.h:

2011-03-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

script-src should block inline event handlers
https://bugs.webkit.org/show_bug.cgi?id=57212

  • http/tests/security/contentSecurityPolicy/resources/event-handler.pl: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html: Added.
1:09 PM Changeset in webkit [82146] by jeffm@apple.com
  • 6 edits in trunk/Source

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

ResourceError::certificate() should return a PCCERT_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=57262

  • platform/network/cf/ResourceError.h: certificate() now returns a PCCERT_CONTEXT.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::certificate): Added.

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

ResourceError::certificate() should return a PCCERT_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=57262

  • Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Don't assert if no PCCERT_CONTEXT is specified.
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Removed unneeded code now that ResourceError::certificate() returns a PCCERT_CONTEXT.
1:03 PM Changeset in webkit [82145] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

2011-03-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
12:44 PM Changeset in webkit [82144] by hyatt@apple.com
  • 4 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=57221, memory corruption/crashes when positioned objects
occur at the end of a line.

Reviewed by Simon Fraser and Darin Adler.

The old code and new code for dealing with a trailing space object midpoint manipulated a raw
array instead of the Vector. Otherwise this corruption would have been caught prior to check-in.

I have patched the code to only go through the Vector and to make it handle the case that led to
the corruption. Trailing positioned objects can occur both prior to and following the trailing space
object's midpoint, so we have to be prepared to deal with both cases.

This is already tested by fast/block/positioning/052.html, and that test now properly progresses
like the other positioning tests did.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

  • platform/mac/fast/block/positioning/052-expected.txt:
12:41 PM Changeset in webkit [82143] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-28 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
12:32 PM Changeset in webkit [82142] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-03-28 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
https://bugs.webkit.org/show_bug.cgi?id=52629

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of QWebPage::repaintRequested() use a Qt::QueuedConnection.
  • tests/qwebpage/tst_qwebpage.cpp: (RepaintRequestedRenderer::RepaintRequestedRenderer): (RepaintRequestedRenderer::onRepaintRequested): (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling QWebFrame::render() in a slot connected to to QWebPage::repaintRequested() doesn't cause recursive signal emissions.
12:10 PM Changeset in webkit [82141] by Simon Fraser
  • 2 edits in trunk/Tools

2011-03-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
to link against WebKit.framework for now.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [82140] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unused CFErrorRef.

Rubber-stamped by Adam Roben.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceError): Remove unused CFErrorRef.

11:25 AM Changeset in webkit [82139] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57251

Build fix, had remnant of another patch in r82130

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompileGetByIdChainList):

11:17 AM Changeset in webkit [82138] by andreip@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-28 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
https://bugs.webkit.org/show_bug.cgi?id=57100

Close the ENABLE guard and the namespace in the right order.

No new tests, just cleanup.

  • bindings/v8/custom/V8IDBAnyCustom.cpp:
  • bindings/v8/custom/V8IDBKeyCustom.cpp:
11:16 AM Changeset in webkit [82137] by jeffm@apple.com
  • 13 edits in trunk

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195

Rename wkGetSSLPeerCertificateData() to wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*, and
implement wkGetSSLPeerCertificateData() to return a CFDataRef. Add wkSetSSLPeerCertificateData() so
WebCore::ResourceError can set the certificate in the user info dictionary.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195


Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.

  • WebError.cpp: (WebError::sslPeerCertificate):
  • WebURLResponse.cpp: (WebURLResponse::sslPeerCertificate):

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195

Add support for tracking the certificate in WebCore::ResourceError.

  • platform/network/ResourceErrorBase.cpp: (WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
  • platform/network/ResourceErrorBase.h: (WebCore::ResourceErrorBase::platformCopy): Added.
  • platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate. (WebCore::ResourceError::certificate): Added.
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Added constructor that takes certificate data. (WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary. (WebCore::ResourceError::platformCopy): Copy m_certificate. (WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.

2011-03-28 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195


Add support for sending the certificate with the WebCore::ResourceError.

  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceError): Encode certificate data. (CoreIPC::deallocCertContext): Added. (CoreIPC::createCertContextDeallocator): Added. (CoreIPC::copyCert): Added. (CoreIPC::decodeResourceError): Decode certificate data.
10:57 AM Changeset in webkit [82136] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Add an extra newline to the end of the generated Inspector.idl file so that it does not
trigger the Windows "no newline at at end of file" warning.

Rubber-stamped by Adam Roben.

  • inspector/generate-inspector-idl:
10:49 AM Changeset in webkit [82135] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, added new GTK+ test expectations.

  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.png: Added.
  • platform/gtk/fast/block/positioning/trailing-space-test-expected.txt: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/gtk/fast/blockflow/fallback-orientation-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.png: Added.
  • platform/gtk/svg/text/text-path-middle-align-expected.txt: Added.
10:46 AM Changeset in webkit [82134] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.

(WebCore::MediaPlayerPrivateQt::getSupportedTypes):
(WebCore::MediaPlayerPrivateQt::commitLoad):

10:29 AM Changeset in webkit [82133] by pfeldman@chromium.org
  • 3 edits in trunk/Source

2011-03-28 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixed chromium build.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
10:19 AM Changeset in webkit [82132] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82099.
http://trac.webkit.org/changeset/82099
https://bugs.webkit.org/show_bug.cgi?id=57245

Breaks live edits tests on chromium. (Requested by pfeldman on
#webkit).

  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
10:16 AM Changeset in webkit [82131] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up and rename debugger domain functions.
https://bugs.webkit.org/show_bug.cgi?id=57240

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointsActive): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerDispatcher.prototype.paused): (WebInspector.DebuggerDispatcher.prototype.resumed): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  • inspector/front-end/inspector.js: (WebInspector.didCreateWorker): (WebInspector.didDestroyWorker):
10:14 AM Changeset in webkit [82130] by oliver@apple.com
  • 30 edits in trunk/Source/JavaScriptCore

2011-03-27 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add additional immediate types to allow us to distinguish the source of a JIT immediate
https://bugs.webkit.org/show_bug.cgi?id=57190

Allow us to distinguish whether a JIT immediate is a value that we
control (TrustedImm32 and TrustedImmPtr) vs. ones that can be controlled
or influenced by code we are compiling. Currently we do nothing with this
information -- this change is large and mechanical but would obscure any
logic changes that we would have made.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr): (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr): (JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32): (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::pop): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::setPtr): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchTest8):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::urshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch8): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest8): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::set32Compare32): (JSC::MacroAssemblerARM::set8Compare32): (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::add32): (JSC::MacroAssemblerARMv7::and32): (JSC::MacroAssemblerARMv7::lshift32): (JSC::MacroAssemblerARMv7::mul32): (JSC::MacroAssemblerARMv7::or32): (JSC::MacroAssemblerARMv7::rshift32): (JSC::MacroAssemblerARMv7::urshift32): (JSC::MacroAssemblerARMv7::sub32): (JSC::MacroAssemblerARMv7::xor32): (JSC::MacroAssemblerARMv7::load32): (JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARMv7::load16): (JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARMv7::store32): (JSC::MacroAssemblerARMv7::loadDouble): (JSC::MacroAssemblerARMv7::storeDouble): (JSC::MacroAssemblerARMv7::push): (JSC::MacroAssemblerARMv7::move): (JSC::MacroAssemblerARMv7::compare32): (JSC::MacroAssemblerARMv7::test32): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch16): (JSC::MacroAssemblerARMv7::branch8): (JSC::MacroAssemblerARMv7::branchTest32): (JSC::MacroAssemblerARMv7::branchTest8): (JSC::MacroAssemblerARMv7::branchAdd32): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::branchSub32): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::set32Compare32): (JSC::MacroAssemblerARMv7::set8Compare32): (JSC::MacroAssemblerARMv7::set32Test32): (JSC::MacroAssemblerARMv7::set32Test8): (JSC::MacroAssemblerARMv7::moveWithPatch): (JSC::MacroAssemblerARMv7::branchPtrWithPatch): (JSC::MacroAssemblerARMv7::storePtrWithPatch): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch): (JSC::MacroAssemblerARMv7::setupArmAddress): (JSC::MacroAssemblerARMv7::makeBaseIndexBase): (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::urshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::set8Compare32): (JSC::MacroAssemblerMIPS::set32Compare32): (JSC::MacroAssemblerMIPS::set32Test8): (JSC::MacroAssemblerMIPS::set32Test32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::add32): (JSC::MacroAssemblerX86::addWithCarry32): (JSC::MacroAssemblerX86::and32): (JSC::MacroAssemblerX86::or32): (JSC::MacroAssemblerX86::sub32): (JSC::MacroAssemblerX86::store32): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::moveWithPatch): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::storePtrWithPatch):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::lshift32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::rshift32): (JSC::MacroAssemblerX86Common::urshift32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::store32): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::push): (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::branch8): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchTest8): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set8Compare32): (JSC::MacroAssemblerX86Common::set32Compare32): (JSC::MacroAssemblerX86Common::set32Test8): (JSC::MacroAssemblerX86Common::set32Test32):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::loadDouble): (JSC::MacroAssemblerX86_64::addDouble): (JSC::MacroAssemblerX86_64::convertInt32ToDouble): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): (JSC::MacroAssemblerX86_64::addPtr): (JSC::MacroAssemblerX86_64::andPtr): (JSC::MacroAssemblerX86_64::orPtr): (JSC::MacroAssemblerX86_64::subPtr): (JSC::MacroAssemblerX86_64::xorPtr): (JSC::MacroAssemblerX86_64::storePtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::moveWithPatch): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86_64::branchTest8):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::callOperation):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::jitAssertIsInt32): (JSC::DFG::JITCompiler::emitCount):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::compile):
  • jit/JIT.cpp: (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_mod):
  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emitRightShift): (JSC::JIT::emitRightShiftSlowCase): (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitLoadCharacterString): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::checkStructure): (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag): (JSC::JIT::emitCount): (JSC::JIT::sampleInstruction): (JSC::JIT::sampleCodeBlock): (JSC::JIT::emitStoreInt32): (JSC::JIT::emitStoreCell): (JSC::JIT::emitStoreBool): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitInitRegister): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_check_has_instance): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_init_lazy_reg): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_resolve_global_dynamic): (JSC::JIT::emit_op_new_regexp): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs): (JSC::JIT::emit_op_new_func):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_check_has_instance): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_tear_off_arguments): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_create_activation): (JSC::JIT::emit_op_create_arguments): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::softModulo):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument):
  • jit/JITStubs.cpp: (JSC::getPolymorphicAccessStructureListSlot): (JSC::DEFINE_STUB_FUNCTION):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::emitLoadDouble):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::SpecializedThunkJIT): (JSC::SpecializedThunkJIT::loadJSStringArgument): (JSC::SpecializedThunkJIT::tagReturnAsInt32): (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
  • jit/ThunkGenerators.cpp: (JSC::charToString): (JSC::powThunkGenerator):
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::matchCharacterClass): (JSC::Yarr::YarrGenerator::storeToFrame): (JSC::Yarr::YarrGenerator::storeToFrameWithPatch): (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode): (JSC::Yarr::YarrGenerator::generatePatternCharacterSingle): (JSC::Yarr::YarrGenerator::generatePatternCharacterFixed): (JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy): (JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::YarrGenerator::generateCharacterClassFixed): (JSC::Yarr::YarrGenerator::generateCharacterClassGreedy): (JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): (JSC::Yarr::YarrGenerator::generateDisjunction):
10:10 AM Changeset in webkit [82129] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html fails.
https://bugs.webkit.org/show_bug.cgi?id=57243

Rubber-stamped by Adam Roben.

  • platform/win/Skipped:

Remove the two tests that were removed in r71392.
Also, remove spelling-backspace-between-lines.html because it is not flakey and the
layoutTestController method is implemented on Windows, it just fails with this test.

  • platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
10:07 AM Changeset in webkit [82128] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/57239> Use forward class declaration instead of including header

Reviewed by Dan Bernstein.

Adding a "using namespace WebCore;" statement in a header may
cause issues when <WebCore/Length.h> is included before
<CoreText/CoreText.h>.

Length.h defines the LengthType enum with a 'Fixed' value.
CoreText.h includes MacTypes.h, which has a
"typedef SInt32 Fixed;" statement, and then CoreText.h includes
other headers that also use 'Fixed', but expect the typedef to
be defined, not the enum. If another header includes
"using namespace WebCore;" before CoreText.h, the
following compiler errors result (paths abbreviated):

CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
Length.h:37: error: WebCore::LengthType WebCore::Fixed
SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type

  • platform/mac/HTMLConverter.h: Use forward declaration of

DocumentLoader class instead of including header. Remove the
unused "using namespace WebCore;" statement.

10:01 AM Changeset in webkit [82127] by Dimitri Glazkov
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-03-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Introduce EventDispatcher, the new common way to fire events.
https://bugs.webkit.org/show_bug.cgi?id=57168

The goal here is two-fold:
1) reduce the need to randomly sprinkle guards around the dispatch code
by creating a well-scoped abstraction for dispatching events.
2) create a place where fiddly event-related things like creating event
contexts for ancestors can be done lazily.

Additionally, with all the free-standing static functions, this code was
just begging to come out of Node.cpp.

The first step is a near-mechanical extraction of mouse-related events
from Node.cpp to EventDispatcher. For now, the call sites are just
replaced with invoking EventDispatcher. Later, we can remove these methods
from Node.

Refactoring, no functional changes.

  • Android.mk: Added EventDispatcher to build system.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/EventDispatcher.cpp: Added.
  • dom/EventDispatcher.h: Added.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher. (WebCore::Node::dispatchEvent): Ditto. (WebCore::Node::dispatchMouseEvent): Ditto. (WebCore::Node::dispatchSimulatedClick): Ditto.
  • dom/Node.h: Updated decls.
9:37 AM Changeset in webkit [82126] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
introduction in r82056.
https://bugs.webkit.org/show_bug.cgi?id=57238

Unreviewed, add expected failing results, since vertical text is not yet implemented on
Windows, to get the bots green.

  • platform/win/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/win/fast/blockflow/fallback-orientation-expected.txt: Added.
9:29 AM Changeset in webkit [82125] by benjamin.poulain@nokia.com
  • 12 edits in trunk

2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Enable QT_ASCII_CAST_WARNINGS by default in webkit.pri to catch the errors early on.

  • Source/WebKit.pri:

2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

  • QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
  • tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests since they are applications, not libraries.

2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Disable QT_ASCII_CAST_WARNINGS for applications.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • MiniBrowser/qt/MiniBrowser.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
9:24 AM Changeset in webkit [82124] by sergio@webkit.org
  • 5 edits in trunk

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fullscreen tests failing after r82084
https://bugs.webkit.org/show_bug.cgi?id=57219

Unskipped some fullscreen tests passing now.

  • platform/gtk/Skipped:

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fullscreen tests failing after r82084
https://bugs.webkit.org/show_bug.cgi?id=57219

Added the withKeyboard parameter to supportsFullScreenForElement
method in ChromeClient. Fullscreen will be disabled for keyboard
access by default.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullScreenForElement):
  • WebCoreSupport/ChromeClientGtk.h:
9:17 AM Changeset in webkit [82123] by mitz@apple.com
  • 4 edits
    8 adds in trunk

<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
https://bugs.webkit.org/show_bug.cgi?id=57197

Reviewed by Maciej Stachowiak.

Source/WebCore:

Tests: fast/repaint/overflow-flipped-writing-mode-block.html

fast/repaint/overflow-flipped-writing-mode-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
with the damage rect.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint): Made the intersection check more like the one in
RenderBlock::paint().

LayoutTests:

  • fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-expected.txt: Added.
  • fast/repaint/overflow-flipped-writing-mode-block.html: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
  • fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
  • fast/repaint/overflow-flipped-writing-mode-table.html: Added.
8:58 AM Changeset in webkit [82122] by sergio@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, rebaseline GTK+ test results.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
8:56 AM Changeset in webkit [82121] by xji@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

move directionOfEnclosingBlock() to be global so that it could be reused.
https://bugs.webkit.org/show_bug.cgi?id=57233.

Provide global function directionOfEnclosingBlock(Node*) so that it could be
reused in SelectionController and other functionalities that need enclosing
block's direcionality, such as moving caret by word in visual order.


No new functionality, so no new tests.

  • editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
  • editing/htmlediting.cpp: (WebCore::directionOfEnclosingBlock):
  • editing/htmlediting.h:
8:48 AM Changeset in webkit [82120] by Darin Adler
  • 21 edits in trunk/Source/WebKit/win

Set eol-style to native on more files. I noticed the last check-in had an entire file
changing because of an EOL style change, and setting this property prevents that from
happening in future. We may want to do this systematically for more of WebKit later.

  • AccessibleBase.cpp: Added property svn:eol-style.
  • AccessibleBase.h: Added property svn:eol-style.
  • AccessibleDocument.cpp: Added property svn:eol-style.
  • AccessibleDocument.h: Added property svn:eol-style.
  • AccessibleImage.cpp: Added property svn:eol-style.
  • AccessibleImage.h: Added property svn:eol-style.
  • COMVariantSetter.h: Added property svn:eol-style.
  • FullscreenVideoController.cpp: Added property svn:eol-style.
  • FullscreenVideoController.h: Added property svn:eol-style.
  • WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
  • WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
  • WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
  • WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
  • WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
  • WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
8:47 AM Changeset in webkit [82119] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=57236

Unreviewed, skip the flakey test in order to get the bots green.

  • platform/mac-snowleopard/Skipped:
7:43 AM Changeset in webkit [82118] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, update pixel test expectations after r82105.

  • platform/gtk/fast/css/text-align-expected.checksum:
  • platform/gtk/fast/css/text-align-expected.png:
7:39 AM Changeset in webkit [82117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
https://bugs.webkit.org/show_bug.cgi?id=56825

Fixes for context attribute handling:

  • Initialize depth and stencil buffer depending on whether they are enabled in context attributes.
  • Always enable depth buffer when stencil buffer is enabled.
  • Disable stencil buffer on OpenGL ES 2.0
  • Cleaned up clutter code from initialization. Made code paths more sane.
  • Clear mask is now set correctly in reshape().

Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::isValid): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3DInternal::getProcAddress): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::bindFramebuffer):
7:34 AM Changeset in webkit [82116] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-28 Ryosuke Niwa <rniwa@webkit.org>

[Chromium] [Mac Leopard] Update test expectations after r82105.

  • platform/chromium-linux/fast/css/text-align-expected.checksum:
  • platform/chromium-linux/fast/css/text-align-expected.png:
  • platform/chromium-win/fast/css/text-align-expected.checksum:
  • platform/chromium-win/fast/css/text-align-expected.png:
  • platform/chromium-win/fast/css/text-align-expected.txt:
  • platform/mac-leopard/fast/css/text-align-expected.checksum:
  • platform/mac-leopard/fast/css/text-align-expected.png:
7:33 AM Changeset in webkit [82115] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] QtWebKit does not link with --3d-canvas using MinGW
https://bugs.webkit.org/show_bug.cgi?id=57225

  • QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
7:21 AM Changeset in webkit [82114] by jeffm@apple.com
  • 1 edit
    1 delete in trunk/WebKitLibraries

Remove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.

Rubber-stamped by Adam Roben.

  • win/lib/WebKitSystemInterface_debug.lib: Removed.
7:12 AM Changeset in webkit [82113] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183

Reviewed by Andreas Kling.

Windows buildfix after r82065.

  • Api/DerivedSources.pro: Readding escaping on Windows platforms.
7:10 AM Changeset in webkit [82112] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Ryosuke Niwa <rniwa@webkit.org>

[GTK] Update text expectations after r82105.

  • platform/gtk/fast/css/text-align-expected.txt:
6:44 AM Changeset in webkit [82111] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
https://bugs.webkit.org/show_bug.cgi?id=57226

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setInitialContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.requestWillBeSent): (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached): (WebInspector.NetworkDispatcher.prototype.responseReceived): (WebInspector.NetworkDispatcher.prototype.dataReceived): (WebInspector.NetworkDispatcher.prototype.loadingFinished): (WebInspector.NetworkDispatcher.prototype.loadingFailed): (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetached): (WebInspector.NetworkDispatcher.prototype.initialContentSet): (WebInspector.NetworkDispatcher.prototype.frameNavigated): (WebInspector.NetworkDispatcher.prototype.webSocketCreated): (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest): (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived): (WebInspector.NetworkDispatcher.prototype.webSocketClosed):
6:05 AM Changeset in webkit [82110] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Update expectations after r82105.

  • platform/qt/fast/css/text-align-expected.checksum:
  • platform/qt/fast/css/text-align-expected.png:
  • platform/qt/fast/css/text-align-expected.txt:
5:41 AM Changeset in webkit [82109] by andreas.kling@nokia.com
  • 3 edits in trunk/Tools

2011-03-28 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser doesn't reset its window title when opening about:blank
https://bugs.webkit.org/show_bug.cgi?id=57224

  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::onTitleChanged):
  • QtTestBrowser/mainwindow.h:
5:24 AM Changeset in webkit [82108] by mnaganov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
https://bugs.webkit.org/show_bug.cgi?id=57099

  • bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
  • bindings/v8/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::~ScriptProfile):
  • bindings/v8/ScriptProfile.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
5:23 AM Changeset in webkit [82107] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix console messages positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=57010

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping): (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage): (WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages): (WebInspector.DebuggerPresentationModel.prototype._reset):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addConsoleMessage): (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): (WebInspector.ScriptsPanel.prototype._consoleMessageAdded): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame.prototype.addMessageToSource):
5:18 AM Changeset in webkit [82106] by pfeldman@chromium.org
  • 16 edits
    1 add in trunk

2011-03-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
https://bugs.webkit.org/show_bug.cgi?id=57186

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/resources/console-resource-errors-iframe.html: Added.
  • inspector/report-protocol-errors.html:
  • inspector/storage-panel-dom-storage.html:

2011-03-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
https://bugs.webkit.org/show_bug.cgi?id=57186

  • ResourceTreeModel is now event target (Object)
  • There is no ResourceTreeModel -> UI dependencies
  • NetworkManager -> ResourceTreeModel dependencies has been removed
  • NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
  • ResourceTreeModel requests tree structure from the backend separately
  • Cached resources tree payload is now limited to url and type (no headers involved)
  • Resources tree is being rendered lazily upon request from the panel.
  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::getCachedResources): (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): (.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.frontendReused): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.frontendReused): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.frames): (WebInspector.ResourceTreeModel.prototype.subframes): (WebInspector.ResourceTreeModel.prototype.resources): (WebInspector.ResourceTreeModel.prototype._onCommitLoad): (WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._onResourceUpdated): (WebInspector.ResourceTreeModel.prototype._addResourceToFrame): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype._createResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame): (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype._frameAdded): (WebInspector.ResourcesPanel.prototype._frameDetached): (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.ResourcesPanel.prototype._frameNavigated): (WebInspector.FrameTreeElement.prototype.setTitles):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
5:04 AM Changeset in webkit [82105] by rniwa@webkit.org
  • 13 edits in trunk

2011-03-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

WebKit's behavior for text-align inherit differs from other browsers
https://bugs.webkit.org/show_bug.cgi?id=56377

The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
the alignment of the text in those nodes should be determined based on the directionality of the text,
not by the directionality of the ancestor node from which text-align property is inherited.

Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
align text to the left in a LTR context and to the right in a RTL context respectively.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND. (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Ditto.
  • rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
  • rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.

2011-03-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

WebKit's behavior for text-align inherit differs from other browsers
https://bugs.webkit.org/show_bug.cgi?id=56377

Added test more cases to text-align, which already has some tests for text-align: start and text-align: end.

  • fast/css/text-align-expected.txt:
  • fast/css/text-align.html:
  • platform/mac/fast/css/text-align-expected.checksum:
  • platform/mac/fast/css/text-align-expected.png:
5:02 AM Changeset in webkit [82104] by abecsi@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the linking of jsc with MinGW after r81963.

  • jsc.pro: add -l and remove the lib suffix.
4:57 AM Changeset in webkit [82103] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix breakpoints positions in formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=56931

Add async requestMapping method to SourceFile interface as required for populating
breakpoints sidebar pane when in "format all scripts" mode.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI. (WebInspector.PresentationBreakpoint.prototype.get sourceFileId): (WebInspector.PresentationBreakpoint.prototype.get lineNumber): (WebInspector.PresentationBreakpoint.prototype.get condition): (WebInspector.PresentationBreakpoint.prototype.get enabled): (WebInspector.PresentationBreakpoint.prototype.get url): (WebInspector.PresentationBreakpoint.prototype.get resolved): (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.requestSourceMapping): (WebInspector.FormattedSourceFile.prototype.requestSourceMapping): (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation): (WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation): (WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
4:49 AM Changeset in webkit [82102] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

This patch fixes linking errors on Qt Webkit Windows MinGW builds.
This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
QWEBKIT_EXPORT is defined as follows:

Patch by Nancy Piedra <nancy.piedra@nokia.com> on 2011-03-28
Reviewed by Csaba Osztrogonác.

No new tests needed since only changing .pro file.

  • WebCore.pro:
4:46 AM Changeset in webkit [82101] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit/win

2011-03-28 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix.

  • COMPropertyBag.h: Added missing include.
  • WebKitCOMAPI.h: Ditto.
  • WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
4:36 AM Changeset in webkit [82100] by yutak@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Yet another test result fix for fast/blockflow/fallback-orientation-expected.html.

  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt.
4:31 AM Changeset in webkit [82099] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: source frame should show the error to user when live edit is failed
https://bugs.webkit.org/show_bug.cgi?id=57002

  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
4:30 AM Changeset in webkit [82098] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test expectation for inspector/debugger/debugger-activation-crash.html.

  • platform/chromium/test_expectations.txt:
4:06 AM Changeset in webkit [82097] by yutak@chromium.org
  • 1 edit
    3 moves
    1 add in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, move Chromium test results into the right directory (move WinXP
baseline into chromium-win-xp).

  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum.
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.png.
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt.
3:45 AM Changeset in webkit [82096] by yutak@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add new Chromium test results and expectation.

  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:16 AM Changeset in webkit [82095] by mario@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Expose the AtkValue interface for WAI-ARIA sliders
https://bugs.webkit.org/show_bug.cgi?id=56655

New test to check WAI-ARIA sliders required attributes.

  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Added.
  • platform/gtk/accessibility/aria-slider-required-attributes.html: Added.

2011-03-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Expose the AtkValue interface for WAI-ARIA sliders
https://bugs.webkit.org/show_bug.cgi?id=56655

Implement AtkValue interface for WAI-ARIA sliders.

Test: platform/gtk/accessibility/aria-slider-required-attributes.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the 'property-change::accessible-value' signal when needed.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (core): New, returns a core object from an AtkValue. (webkitAccessibleValueGetCurrentValue): New, implements AtkValue. (webkitAccessibleValueGetMaximumValue): Ditto. (webkitAccessibleValueGetMinimumValue): Ditto. (webkitAccessibleValueSetCurrentValue): Ditto. (webkitAccessibleValueGetMinimumIncrement): Ditto. (atkValueInterfaceInit): Ditto. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE. (getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.
2:49 AM Changeset in webkit [82094] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Sergio Villar Senin <svillar@igalia.com>

[GTK] Fullscreen tests failing after r82084
https://bugs.webkit.org/show_bug.cgi?id=57219

Skipping some fullscreen tests failing since r82084

  • platform/gtk/Skipped:
2:33 AM Changeset in webkit [82093] by mjs@apple.com
  • 3 edits
    5 adds in trunk

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Assigning location.path to something that doesn't start with / mangles the authority
https://bugs.webkit.org/show_bug.cgi?id=57209
<rdar://problem/9195132>


Tests: http/tests/uri/assign-path-with-leading-slash.html

http/tests/uri/assign-path-without-leading-slash.html

  • platform/KURL.cpp: (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.

2011-03-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Assigning location.path to something that doesn't start with / mangles the authority
https://bugs.webkit.org/show_bug.cgi?id=57209
<rdar://problem/9195132>

  • http/tests/uri/assign-path-with-leading-slash-expected.txt: Added.
  • http/tests/uri/assign-path-with-leading-slash.html: Added.
  • http/tests/uri/assign-path-without-leading-slash-expected.txt: Added.
  • http/tests/uri/assign-path-without-leading-slash.html: Added.
  • http/tests/uri/resources/assign-path-landing.html: Added.
2:28 AM Changeset in webkit [82092] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test expectation for fast/text/justify-ideograph-leading-expansion.html.

  • platform/chromium/test_expectations.txt:
2:19 AM Changeset in webkit [82091] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Extract functions to update logical width from computeInlineDirectionPositionsForLine
https://bugs.webkit.org/show_bug.cgi?id=57213

Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.

They are used to update logical widths, logical left, and total logical width for left,
right, and center aligned blocks.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::updateLogicalWidthForLeftAlignedBlock): (WebCore::updateLogicalWidthForRightAlignedBlock): (WebCore::updateLogicalWidthForCenterAlignedBlock): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1:57 AM Changeset in webkit [82090] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-28 Evan Martin <evan@chromium.org>

Reviewed by Ryosuke Niwa.

Refactor duplicate code in HTMLTextElement
https://bugs.webkit.org/show_bug.cgi?id=57215

  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged): This method did an equivalent loop to the text() method on the same object.
1:26 AM Changeset in webkit [82089] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-28 Yuta Kitamura <yutak@chromium.org>

Unreviewed, update Chromium test results for plugins/plugin-javascript-access.html.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/chromium-win/plugins/plugin-javascript-access-expected.txt:
  • platform/chromium/test_expectations.txt:

Mar 27, 2011:

11:46 PM Changeset in webkit [82088] by ukai@chromium.org
  • 3 edits
    3 adds in trunk

2011-03-27 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
  • http/tests/websocket/tests/close-unref-websocket.html: Added.
  • http/tests/websocket/tests/hanging-handshake_wsh.py: Added.

2011-03-27 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't call WebSocket::didClose() more than once.
https://bugs.webkit.org/show_bug.cgi?id=57081

If WebSocket close() is called, and connection is established, then
it will call didClose() that resets m_channel to 0.
After that, when connection is closed, WebSocketChannel will call
didClose for the WebSocket instance.

Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
WebSocketChannel suppress the second didClose().

Test: http/tests/websocket/tests/close-unref-websocket.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::didClose):
11:41 PM Changeset in webkit [82087] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-27 Andy Estes <aestes@apple.com>

Reviewed by Maciej Stachowiak.

Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
https://bugs.webkit.org/show_bug.cgi?id=57205


If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
plug-in MIME types, WebKit has to check for a property list file in
~/Library/Preferences for the MIME type dictionary.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary has the key WebPluginMIMETypesFilename, open the property list specified by that key's value and return the MIME type dictionary from there. Otherwise, return the MIME type dictionary specified by the key WebPluginMIMETypes. (WebKit::getPluginInfoFromPropertyLists): Call getMIMETypesFromPluginBundle().
11:09 PM Changeset in webkit [82086] by yutak@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.

  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.
10:15 PM Changeset in webkit [82085] by abarth@webkit.org
  • 11 edits in trunk

2011-03-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
https://bugs.webkit.org/show_bug.cgi?id=57196

Test both allow => disallow and disallow => allow redirect cases.
Previously, we had incorrect expectations for one of the redirect
cases. Also, I've updated the policy syntax to match the default-src
syntax.

  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:

2011-03-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix script-src redirect handling
https://bugs.webkit.org/show_bug.cgi?id=57196

Resource-loading requirements in CSP apply to each hop in the redirect
chain. To make that work properly, we need to move enforcement into
the loader. Fortunately, we already have a choke-point in the loader
for enforcing this kind of policy.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunnerHost.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowScriptFromSource):
  • page/ContentSecurityPolicy.h:
9:27 PM Changeset in webkit [82084] by jer.noble@apple.com
  • 18 edits in trunk

2011-03-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684

Pass whether keyboard access was requested up to ChromeClient when asking
if fullscreen mode is supported.

  • dom/Document.cpp: (WebCore::Document::webkitRequestFullScreenForElement):
  • page/ChromeClient.h: (WebCore::ChromeClient::supportsFullscreenForElement):

2011-03-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullScreenForElement):
  • WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
  • WebView/WebViewInternal.h:

2011-03-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684

Take into account whether keyboard access was requested when deciding whether full
screen mode is supported.

  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::supportsFullScreen):
  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::supportsFullScreenForElement):
  • WebProcess/WebCoreSupport/WebChromeClient.h:

2011-03-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Full Screen: disable keyboard access by default
https://bugs.webkit.org/show_bug.cgi?id=56684

Accept the withKeyboard parameter to supportsFullScreenForElement.

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
7:33 PM Changeset in webkit [82083] by Patrick Gansterer
  • 3 edits
    2 adds in trunk/Tools

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Levin.

check-webkit-style should check ChangeLog for a valid bug number
https://bugs.webkit.org/show_bug.cgi?id=57184

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py: Added.
  • Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3:54 PM Changeset in webkit [82082] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts):
2:22 PM Changeset in webkit [82081] by mrowe@apple.com
  • 5 edits in branches/safari-534.26-branch/Source

Versioning.

2:21 PM Changeset in webkit [82080] by mrowe@apple.com
  • 1 copy in tags/Safari-534.26.4

New tag.

2:21 PM Changeset in webkit [82079] by mrowe@apple.com
  • 3 edits in branches/safari-534.26-branch/Source/WebKit2

Merge r82078.

12:56 PM Changeset in webkit [82078] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Dock doesn't come back after leaving fullscreen on Hulu
https://bugs.webkit.org/show_bug.cgi?id=57189
<rdar://problem/9192413>

Port some code over from the old WebKit1 plug-in host.

  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::shimShowMenuBar): (WebKit::shimHideMenuBar): (WebKit::shimIsMenuBarVisible):
12:26 PM Changeset in webkit [82077] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Keep a strong reference to the connection to avoid crashes.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:
12:15 PM Changeset in webkit [82076] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <kling@webkit.org>

Fix build warning about IconDatabaseClient.h (wrong path.)

12:12 PM Changeset in webkit [82075] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support for CSS color and background-color properties on select element's dropdown list
https://bugs.webkit.org/show_bug.cgi?id=51627

Extend the QWebSelectData interface with background and foreground colors
for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
getters in RenderMenuList.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/PopupMenuQt.cpp: (SelectData::backgroundColor): (SelectData::foregroundColor): (SelectData::itemBackgroundColor): (SelectData::itemForegroundColor):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
11:26 AM Changeset in webkit [82074] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-03-27 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] Fix Api test failure -- microFocusCoordinates
https://bugs.webkit.org/show_bug.cgi?id=57108

Since the canvas is not self-closing tag, we need to add '</canvas>'.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
10:52 AM Changeset in webkit [82073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
https://bugs.webkit.org/show_bug.cgi?id=57143

Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
define WTF_USE_TEXTURE_MAPPER=1.

10:42 AM Changeset in webkit [82072] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Fix agentOS() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=57177

Replace old PLATFORM macro with OS and CPU.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
10:38 AM Changeset in webkit [82071] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[EFL] Use an appropriate user agent string
https://bugs.webkit.org/show_bug.cgi?id=57176

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
10:28 AM Changeset in webkit [82070] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Use a appropriate user agent string
https://bugs.webkit.org/show_bug.cgi?id=57175

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::userAgent):
10:24 AM Changeset in webkit [82069] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Generate WebKitVersion.h
https://bugs.webkit.org/show_bug.cgi?id=57128

This file will be used for the user agent string by the CMake based ports.

  • CMakeLists.txt:
10:20 AM BuildingQtOnLinux edited by srikumar.b@gmail.com
(diff)
9:36 AM Changeset in webkit [82068] by yutak@chromium.org
  • 7 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add new Chromium test result and expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/chromium/test_expectations.txt:
9:36 AM Changeset in webkit [82067] by commit-queue@webkit.org
  • 14 edits in trunk/Source

2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • wtf/MessageQueue.h:

2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=57170 Fix last elements
in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

Compile fix only, no actual code change.

  • dom/ExceptionCode.h:
  • editing/EditorInsertAction.h:
  • loader/FrameLoaderTypes.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/ScrollTypes.h:
  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/text/TextCodec.h:
7:50 AM Changeset in webkit [82066] by rwlbuis@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-27 Rob Buis <rwlbuis@gmail.com>

Unreviewed, update improve test result.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
7:23 AM Changeset in webkit [82065] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183

The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
which was due to the outputting code previously being wrapped in eval().

  • Api/DerivedSources.pro:
6:26 AM Changeset in webkit [82064] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <yutak@chromium.org>

Unreviewed, update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:38 AM Changeset in webkit [82063] by yutak@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-03-27 Yuta Kitamura <yutak@chromium.org>

Unreviewed, add new Chromium test results.

  • platform/chromium-linux/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png: Added.
  • platform/chromium-win/svg/text/text-path-middle-align-expected.txt: Added.
5:25 AM Changeset in webkit [82062] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-27 Yuta Kitamura <yutak@chromium.org>

Unreviewed, fix Chromium text expectation.

  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [82061] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-27 Rob Buis <rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Text on path positioning at zero startOffset
https://bugs.webkit.org/show_bug.cgi?id=56245

Since for length 0 no previous point is set, choose epsilon
length to get normal at starting point of the path.

Test: svg/text/text-path-middle-align.svg

  • platform/graphics/Path.cpp: (WebCore::Path::normalAngleAtLength):
2:53 AM Changeset in webkit [82060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
created by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932

Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions

  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::thisObject):
12:18 AM Changeset in webkit [82059] by benjamin.poulain@nokia.com
  • 8 edits in trunk/Source/WebKit/qt

2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

Use explicit conversion for string to avoid depending on the default codec
installed by the user code.

  • Api/qwebkitversion.cpp: (qWebKitVersion):
  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::javaScriptConsoleMessage):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::setEditingBehavior): (DumpRenderTreeSupportQt::plainText):
  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
  • WebCoreSupport/InspectorServerQt.cpp: (WebCore::parseWebSocketChallengeNumber): (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

Mar 26, 2011:

10:19 PM Changeset in webkit [82058] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Jeff Miller <jeffm@apple.com>

Reviewed by Sam Weinig.

WKErrorCopyCFError() doesn&apos;t actually return a copy of the CFErrorRef
https://bugs.webkit.org/show_bug.cgi?id=57172

  • Shared/API/c/cf/WKErrorCF.cpp: (WKErrorCopyCFError): Use RetainPtr<> and leakRef() to return a real copy.
8:12 PM Changeset in webkit [82057] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix a bug which was causing the "skip back" button to be missing, causing
the media layout tests to fail.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

6:38 PM Changeset in webkit [82056] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
https://bugs.webkit.org/show_bug.cgi?id=57169

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/blockflow/fallback-orientation.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.

LayoutTests:

  • fast/blockflow/fallback-orientation.html: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
  • platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.
6:10 PM Changeset in webkit [82055] by mjs@apple.com
  • 5 edits in trunk

Source/WebKit2: Revert inadvertantly commited changes.

  • WebProcess/com.apple.WebProcess.sb:

Tools: Revert inadvertantly committed changes.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:58 PM Changeset in webkit [82054] by mjs@apple.com
  • 6 edits
    2 adds in trunk

2011-03-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
https://bugs.webkit.org/show_bug.cgi?id=56150

Test: fast/css/giant-stylesheet-crash.html

  • dom/StyleElement.cpp: (WebCore::StyleElement::process):

2011-03-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
https://bugs.webkit.org/show_bug.cgi?id=56150

  • fast/css/giant-stylesheet-crash-expected.txt: Added.
  • fast/css/giant-stylesheet-crash.html: Added.
5:15 PM Changeset in webkit [82053] by jer.noble@apple.com
  • 14 edits
    1 add in trunk/Source/WebCore

2011-03-22 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Media controls must use full screen style when in new full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=56851

Add new full screen styles for the full screen media elements.

  • DerivedSources.make: Add fullScreenQuickTime.css.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded(). (WebCore::CSSStyleSelector::CSSStyleSelector): Ditto. (WebCore::CSSStyleSelector::styleForElement): Load full screen rules

if needed.

  • css/fullscreenQuickTime.css: Added.
  • css/mediaControls.css:
  • html/shadow/MediaControls.cpp: (WebCore::isFullScreen): Added. (WebCore::MediaControls::create): Add new full screen volume controls. (WebCore::MediaControls::updateStyle): Ditto. (WebCore::MediaControls::update): Ditto. (WebCore::MediaControls::updateVolumeSliderContainer): Ditto. (WebCore::MediaControls::forwardEvent): Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::create): Added. (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet (WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
  • rendering/MediaControlElements.h:

Added m_overridePosition.

(WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added. (WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward

buttons.

5:03 PM Changeset in webkit [82052] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-03-26 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56956

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.

2011-03-26 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Enable the Full Screen API by default in WebKit/mac and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56956

  • Shared/WebPreferencesStore.h: Default the fullScreenEnabled preference to true.
4:46 PM Changeset in webkit [82051] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-26 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

RenderMedia should obey the view's flattening bit.
https://bugs.webkit.org/show_bug.cgi?id=57156

Paint the current frame in software when the associated FrameView
has its flattening bit set.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
4:05 PM Changeset in webkit [82050] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for !ENABLE(DOM_STORAGE).

  • storage/StorageTracker.cpp:

Added #if ENABLE(DOM_STORAGE) like in the other storage files.

3:53 PM Changeset in webkit [82049] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows
https://bugs.webkit.org/show_bug.cgi?id=57152

Reviewed by Steve Falkenburg.

We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.
Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor. Use return value from CertDuplicateCertificateContext().
(WebKit::PlatformCertificateInfo::operator=): Use return value from CertDuplicateCertificateContext().

  • Shared/win/PlatformCertificateInfo.h: Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor.
2:36 PM Changeset in webkit [82048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Graphic corruption appeared with Silverlight contents while resizing window
https://bugs.webkit.org/show_bug.cgi?id=57167
<rdar://problem/9094052>

Pass DispatchMessageEvenWhenWaitingForSyncReply when sending GeometryDidChange messages since that will guarantee
that those messages will be handled before PaintEntirePlugin messages which prevents the PaintEntirePlugin handler from
painting into the wrong backing store.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
2:18 PM Changeset in webkit [82047] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Web process considered unresponsive (SPOD shown) when displaying a JavaScript alert() as a result of a click
<rdar://problem/9067557>
https://bugs.webkit.org/show_bug.cgi?id=57166

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): Invalidate the responsiveness timer before calling out to the client.
2:17 PM Changeset in webkit [82046] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

2011-03-26 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Show page icons (favicons) in QtTestBrowser location bar.
https://bugs.webkit.org/show_bug.cgi?id=57162

  • QtTestBrowser/QtTestBrowser.qrc:
  • QtTestBrowser/favicon.png: Added.
  • QtTestBrowser/locationedit.cpp: (defaultPageIcon): (LocationEdit::LocationEdit): (LocationEdit::setPageIcon): (LocationEdit::resizeEvent): (LocationEdit::updateInternalGeometry):
  • QtTestBrowser/locationedit.h:
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::onIconChanged): (MainWindow::onLoadStarted):
  • QtTestBrowser/mainwindow.h:
2:15 PM Changeset in webkit [82045] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

ASSERTION FAILED: m_operationInProgress == NoOperation loading nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=57165
<rdar://problem/9024311>

The assertion fired because during GC, the web process sends a synchronous NPObjectMessageReceiver::Deallocate
message to the plug-in process. Since this is a synchronous message, the web process needs to process incoming synchronous
messages. While waiting, we get an incoming PluginProxy::Evaluate message from the plug-in. This causes JavaScript to run
during GC which is very bad.

The fix for this is to add a flag on the connection that will cause synchronous messages sent by the connection (in this case the
plug-in process) to not be processed while the other side (the web process) is waiting for a synchronous reply _unless_ the connection
is actually processing a synchronous message. (The last part is to avoid deadlocks).

Since the call to NPN_Evaluate by the plug-in (that ends up sending the PluginProxy::Evaluate message) comes from a run loop timer firing,
it's OK to wait for it to be processed by the web process when it returns to the run loop.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage and m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount.

(CoreIPC::Connection::setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage):
Set m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage.

(CoreIPC::Connection::sendMessage):
Don't add the MessageID::DispatchMessageWhenWaitingForSyncReply flag when the right flags has been set on the connection, and it's not processing a synchronous message.

(CoreIPC::Connection::dispatchMessage):
Increment and decrement m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount accordingly.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::WebProcessConnection): Call setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the connection.
1:50 PM Changeset in webkit [82044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Benjamin Poulain.

[Qt] Remove GraphicsLayerTextureMapper::nativeLayer
https://bugs.webkit.org/show_bug.cgi?id=57141

GraphicsLayer::nativeLayer was removed in r73380.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
1:48 PM Changeset in webkit [82043] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Rollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations))

-[NSString stringByResolvingSymlinksInPath] does not do what we needed for paths within /private.
This caused all SSL sites to stop working.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):

1:32 PM Changeset in webkit [82042] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
<rdar://problem/9127411>
https://bugs.webkit.org/show_bug.cgi?id=57164

  • WebProcess/mac/WebProcessMac.mm: (WebKit::appendSandboxParameterPath): (WebKit::initializeSandbox): Use -[NSString stringByResolvingSymlinksInPath] instead of realpath to ensure we can resolve symlinks even if the file/directory doesn't exist yet.
1:20 PM Changeset in webkit [82041] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Factor processing of incoming sync replies out into processIncomingSyncReply
https://bugs.webkit.org/show_bug.cgi?id=57161

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): Pass DispatchMessageEvenWhenWaitingForSyncReply to sendMessage.

(CoreIPC::Connection::processIncomingSyncReply):
Move code from processIncomingMessage to here.

(CoreIPC::Connection::processIncomingMessage):
Call processIncomingSyncReply.

1:14 PM Changeset in webkit [82040] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <mrobinson@igalia.com>

[GTK] layoutTestController.overridePreference("WebKitDefaultFontSize"...) does not take into account screen DPI
https://bugs.webkit.org/show_bug.cgi?id=57160

Skip failing test. This bug was uncovered by r82033.

  • platform/gtk/Skipped:
1:07 PM Changeset in webkit [82039] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <mrobinson@igalia.com>

Remove a test from the GTK+ skipped list that no longer exists.

  • platform/gtk/Skipped: Update the skipped list.
1:04 PM Changeset in webkit [82038] by Martin Robinson
  • 10 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <mrobinson@igalia.com>

Rebaseline a few more GTK+ tests after r82033.

  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
12:55 PM Changeset in webkit [82037] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Source/JavaScriptGlue

2011-03-26 Adam Barth <abarth@webkit.org>

Remove the JavaScriptGlue GYP build. We're not going to use GYP for
JavaScriptGlue because JavaScriptGlue is used only by one port.

  • gyp: Removed.
  • gyp/JavaScriptGlue.gyp: Removed.
  • gyp/JavaScriptGlue.gypi: Removed.
  • gyp/remove-headers-if-needed.sh: Removed.
  • gyp/run-if-exists.sh: Removed.
  • gyp/update-info-plist.sh: Removed.
12:37 PM Changeset in webkit [82036] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-26 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate
<rdar://problem/9188041>
https://bugs.webkit.org/show_bug.cgi?id=57159

  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::typeFromCFTypeRef): (CoreIPC::encode): (CoreIPC::decode):
  • Shared/cf/ArgumentCodersCF.h: Add encoding/decoding for SecCertificateRef type.
  • Shared/mac/PlatformCertificateInfo.mm: (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): Use ArgumentCodersCF now that it knows how to encode/decode SecCertificateRefs.
12:34 PM Changeset in webkit [82035] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Handle synchronous replies coming in out of order
https://bugs.webkit.org/show_bug.cgi?id=57158

When processing an incoming reply, don't assume that it belongs to the last sent synchronous request.
Instead, iterate over the m_pendingSyncReplies vector backwards looking for the corresponding request.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage):
12:28 PM Changeset in webkit [82034] by andreas.kling@nokia.com
  • 5 edits
    2 adds in trunk/Source/WebKit/qt

2011-03-26 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
https://bugs.webkit.org/show_bug.cgi?id=57157

Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
is always emitted when appropriate.

  • WebCoreSupport/IconDatabaseClientQt.h: Added.
  • WebCoreSupport/IconDatabaseClientQt.cpp: Added. (WebCore::IconDatabaseClientQt::instance): (WebCore::IconDatabaseClientQt::IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt): (WebCore::IconDatabaseClientQt::performImport): (WebCore::IconDatabaseClientQt::didRemoveAllIcons): (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL): (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL): (WebCore::IconDatabaseClientQt::didChangeIconForPageURL): (WebCore::IconDatabaseClientQt::didFinishURLImport):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::registerForIconNotification): (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the QWebFrame::iconChanged() signal when the IconDatabases finishes loading a cached favicon for the frame's URL.
  • Api/qwebsettings.cpp: (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is instantiated. An IconDatabaseClient has to be registered before the IconDatabase spawns its reader thread.
11:52 AM Changeset in webkit [82033] by Martin Robinson
  • 196 edits in trunk

2011-03-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
https://bugs.webkit.org/show_bug.cgi?id=56866

Update GTK+ test results which now have differ.

  • platform/gtk/editing/pasteboard/4641033-expected.checksum:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.checksum:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.checksum:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.checksum:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.checksum:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.checksum:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/forms/001-expected.checksum:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.checksum:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.checksum:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.checksum:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.checksum:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.checksum:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/select-align-expected.checksum:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.checksum:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.checksum:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.checksum:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.checksum:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.checksum:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/html/keygen-expected.checksum:
  • platform/gtk/fast/html/keygen-expected.png:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/invalid/014-expected.checksum:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.checksum:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.checksum:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.checksum:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.checksum:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.checksum:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:

2011-03-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Force DumpRenderTree to use 96 DPI
https://bugs.webkit.org/show_bug.cgi?id=56866

Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
broader compatibility with WebKit2 and makes setting font sizes more straightforward.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI. (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution. (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
11:23 AM Changeset in webkit [82032] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix a possible deadlock when two synchronous messages are sent at the same time
https://bugs.webkit.org/show_bug.cgi?id=57155

Simplify code and fix a possible (although highly improbable) dead lock.

  • Platform/CoreIPC/Connection.cpp: Make SyncMessageState atomically ref counted since it can be ref()'ed from the connection queue. Get rid of m_waitForSyncReplyCount and add m_didScheduleDispatchMessagesWork.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_didScheduleDispatchMessagesWork to false.

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
if m_didScheduleDispatchMessagesWork is false, schedule a call to dispatchMessageAndResetDidScheduleDispatchMessagesWork
on the client run loop.

(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesWork):
Dispatch messages and set m_didScheduleDispatchMessagesWork back to false.

(CoreIPC::Connection::sendSyncMessage):
Remove calls to beginWaitForSyncReply and endWaitForSyncReply.

11:15 AM Changeset in webkit [82031] by Martin Robinson
  • 45 edits in trunk/LayoutTests

2011-03-26 Martin Robinson <mrobinson@igalia.com>

Rebaseline many GTK+ tests after r81994.

  • platform/gtk/fast/block/positioning/056-expected.txt:
  • platform/gtk/fast/block/positioning/auto/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.checksum:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/gtk/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/gtk/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/gtk/fast/clip/001-expected.txt:
  • platform/gtk/fast/clip/004-expected.txt:
  • platform/gtk/fast/clip/006-expected.txt:
  • platform/gtk/fast/clip/007-expected.txt:
  • platform/gtk/fast/clip/008-expected.txt:
  • platform/gtk/fast/clip/009-expected.txt:
  • platform/gtk/fast/clip/010-expected.txt:
  • platform/gtk/fast/clip/011-expected.txt:
  • platform/gtk/fast/clip/012-expected.txt:
  • platform/gtk/fast/clip/013-expected.txt:
  • platform/gtk/fast/clip/014-expected.txt:
  • platform/gtk/fast/clip/nestedTransparencyClip-expected.txt:
  • platform/gtk/fast/clip/outline-overflowClip-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/layers/layer-visibility-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
7:38 AM Changeset in webkit [82030] by abarth@webkit.org
  • 2 edits in trunk

2011-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

We shouldn't bother running GYP if the generated files are newer than the GYP files
https://bugs.webkit.org/show_bug.cgi?id=57146

In the common case, this check will avoid any overhead from processing
the GYP files. Another approach to doing this is to add the feature to
GYP directly, but GYP's approach to this problem is to compute the
output in its entirety and compare it byte-for-byte against the output
file. In the future, it might make sense to add this approach as an
alternative approach for GYP itself.

I also removed JavaScriptGlue from the script because we're not really
going to change JavaScriptGlue over to GYP. We were using
JavaScriptGlue as a learning experience.

  • Source/gyp/configure:
7:25 AM Changeset in webkit [82029] by Csaba Osztrogonác
  • 11 edits in trunk/LayoutTests

Update Qt specific expected results after r81992.

  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.checksum:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
4:59 AM Changeset in webkit [82028] by abarth@webkit.org
  • 10 edits
    2 adds in trunk

2011-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
https://bugs.webkit.org/show_bug.cgi?id=54799

Test a variety of source-list parsing cases. There's a bunch more
cases we could be testing. We'll add more over time.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing.html: Added.

2011-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach Content Security Policy how to parse source-list
https://bugs.webkit.org/show_bug.cgi?id=54799

This patch is larger than I would like, but I wasn't sure how to make
it any smaller while still being reasonably testable. I've left out
some features (such as host wildcarding and 'self') so I can add them
in later patches with tests.

Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html

  • bindings/ScriptControllerBase.cpp:
  • dom/ScriptElement.cpp:
  • html/parser/HTMLDocumentParser.cpp:
  • loader/FrameLoader.cpp:
    • Add include explicitly now that we're not spamming the include everywhere