Timeline
Apr 18, 2011:
- 10:44 PM Changeset in webkit [84225] by
-
- 8 edits in trunk/Source/WebCore
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Makes SVG shadow roots and DOM shadow roots distinct.
https://bugs.webkit.org/show_bug.cgi?id=52788
Not a functional change. Covered by existing SVG tests.
- dom/EventDispatcher.cpp: (WebCore::findElementInstance): (WebCore::EventDispatcher::adjustToShadowBoundaries): (WebCore::EventDispatcher::adjustRelatedTarget): (WebCore::EventDispatcher::ensureEventAncestors):
- dom/Node.cpp: (WebCore::Node::setShadowHost): (WebCore::Node::svgShadowHost): (WebCore::Node::shadowTreeRootNode):
- dom/Node.h: (WebCore::Node::isSVGShadowRoot): (WebCore::Node::parentNode): (WebCore::Node::parentNodeGuaranteedHostFree):
- rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer): (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
- rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): (WebCore::SVGShadowTreeRootElement::create): (WebCore::SVGShadowTreeRootElement::attachElement): (WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
- rendering/svg/SVGShadowTreeElements.h: (WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
- 10:36 PM Changeset in webkit [84224] by
-
- 55 edits2 moves in trunk
2011-04-18 Taiju TSUIKI <develop@tzik.jp>
Reviewed by Darin Fisher.
Vendor-prefix requestFileSystem in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=58517
Prefix from:
- window.requestFileSystem to window.webkitRequestFileSystem
- window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
- window.Flags to window.WebKitFlags
- WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
- WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
- WorkerContext.Flags to WorkerContext.WebKitFlags
- fast/dom/script-tests/prototype-inheritance.js:
- fast/filesystem/flags-passing-expected.txt:
- fast/filesystem/resources/async-operations.js:
- fast/filesystem/resources/directory-entry-to-uri.js:
- fast/filesystem/resources/file-entry-to-uri-sync.js:
- fast/filesystem/resources/file-entry-to-uri.js:
- fast/filesystem/resources/file-from-file-entry-sync.js:
- fast/filesystem/resources/file-from-file-entry.js:
- fast/filesystem/resources/file-writer-sync-truncate-extend.js:
- fast/filesystem/resources/file-writer-sync-write-overlapped.js:
- fast/filesystem/resources/file-writer-utils.js:
- fast/filesystem/resources/fs-worker-common.js:
- fast/filesystem/resources/op-tests-helper.js:
- fast/filesystem/resources/simple-persistent-sync.js:
- fast/filesystem/resources/simple-persistent.js:
- fast/filesystem/resources/simple-temporary-sync.js:
- fast/filesystem/resources/simple-temporary.js:
- fast/filesystem/resources/sync-operations.js:
- fast/filesystem/script-tests/filesystem-reference.js:
- fast/filesystem/script-tests/flags-passing.js:
- fast/filesystem/script-tests/read-directory.js:
- http/tests/filesystem/resolve-uri-expected.txt:
- http/tests/filesystem/script-tests/resolve-uri.js:
- http/tests/filesystem/workers/resolve-url-expected.txt:
- http/tests/filesystem/workers/script-tests/resolve-url-sync.js:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
2011-04-18 Taiju TSUIKI <develop@tzik.jp>
Reviewed by Darin Fisher.
Vendor-prefix requestFileSystem in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=58517
Prefix from:
- window.requestFileSystem to window.webkitRequestFileSystem
- window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
- window.Flags to window.WebKitFlags
- WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
- WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
- WorkerContext.Flags to WorkerContext.WebKitFlags
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags): (WebCore::JSDirectoryEntrySync::getFile): (WebCore::JSDirectoryEntrySync::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): (WebCore::V8DirectoryEntrySync::getDirectoryCallback): (WebCore::V8DirectoryEntrySync::getFileCallback):
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):
- fileapi/DOMFileSystemBase.h:
- fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): (WebCore::DirectoryEntry::getDirectory):
- fileapi/DirectoryEntry.h:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::getFile): (WebCore::DirectoryEntrySync::getDirectory):
- fileapi/DirectoryEntrySync.h:
- fileapi/DirectoryEntrySync.idl:
- fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h. (WebCore::WebKitFlags::create): (WebCore::WebKitFlags::isCreate): (WebCore::WebKitFlags::setCreate): (WebCore::WebKitFlags::isExclusive): (WebCore::WebKitFlags::setExclusive): (WebCore::WebKitFlags::WebKitFlags):
- fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestFileSystem): (WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::webkitRequestFileSystem): (WebCore::WorkerContext::webkitRequestFileSystemSync): (WebCore::WorkerContext::webkitResolveLocalFileSystemURL): (WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- 9:32 PM Changeset in webkit [84223] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Daniel Bates <dbates@rim.com>
Skip fast/events/fire-mousedown-while-pressing-mouse-button.html which is failing on
Qt Linux for now. See bug for more details.
This test was added in changeset 84217 <http://trac.webkit.org/changeset/84217>
(https://bugs.webkit.org/show_bug.cgi?id=58700).
- platform/qt/Skipped:
- 9:28 PM Changeset in webkit [84222] by
-
- 14 edits2 adds in trunk/Source/WebCore
2011-04-18 Steve Lacey <sjl@chromium.org>
Reviewed by Dimitri Glazkov.
Decouple media controls usage from implementation.
This allows each port to implement thier own controls in a different
manner to the default webkit implementation.
Convert media controls hooks to a client interface
https://bugs.webkit.org/show_bug.cgi?id=58346
No new tests as there is no functional change.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): (WebCore::HTMLMediaElement::ensureMediaControls): (WebCore::HTMLMediaElement::preDispatchEventHandler):
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): (WebCore::MediaControlPanelMuteButtonElement::create): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): (WebCore::MediaControlFullscreenButtonElement::create):
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::MediaControlRootElement): (WebCore::MediaControls::create):
- html/shadow/MediaControlRootElement.h:
- html/shadow/MediaControls.cpp: Added. (WebCore::MediaControls::MediaControls):
- html/shadow/MediaControls.h: Added. (WebCore::MediaControls::~MediaControls):
- 8:49 PM Changeset in webkit [84221] by
-
- 78 edits in trunk
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
Update pixel results for tests that draw the selection rectangle.
- platform/gtk/editing/selection/4402375-expected.checksum:
- platform/gtk/editing/selection/4402375-expected.png:
- platform/gtk/editing/selection/image-before-linebreak-expected.checksum:
- platform/gtk/editing/selection/image-before-linebreak-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-1-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-1-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-2-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-2-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
- platform/gtk/editing/selection/transformed-selection-rects-expected.checksum:
- platform/gtk/editing/selection/transformed-selection-rects-expected.png:
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.checksum:
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
- platform/gtk/svg/text/selection-doubleclick-expected.checksum:
- platform/gtk/svg/text/selection-doubleclick-expected.png:
- platform/gtk/svg/text/selection-tripleclick-expected.checksum:
- platform/gtk/svg/text/selection-tripleclick-expected.png:
- platform/gtk/svg/text/text-align-01-b-expected.checksum:
- platform/gtk/svg/text/text-align-01-b-expected.png:
- platform/gtk/svg/text/text-align-02-b-expected.checksum:
- platform/gtk/svg/text/text-align-02-b-expected.png:
- platform/gtk/svg/text/text-align-03-b-expected.checksum:
- platform/gtk/svg/text/text-align-03-b-expected.png:
- platform/gtk/svg/text/text-align-04-b-expected.checksum:
- platform/gtk/svg/text/text-align-04-b-expected.png:
- platform/gtk/svg/text/text-align-05-b-expected.checksum:
- platform/gtk/svg/text/text-align-05-b-expected.png:
- platform/gtk/svg/text/text-align-06-b-expected.checksum:
- platform/gtk/svg/text/text-align-06-b-expected.png:
- platform/gtk/svg/text/text-altglyph-01-b-expected.checksum:
- platform/gtk/svg/text/text-altglyph-01-b-expected.png:
- platform/gtk/svg/text/text-deco-01-b-expected.checksum:
- platform/gtk/svg/text/text-deco-01-b-expected.png:
- platform/gtk/svg/text/text-fonts-01-t-expected.checksum:
- platform/gtk/svg/text/text-fonts-01-t-expected.png:
- platform/gtk/svg/text/text-fonts-02-t-expected.checksum:
- platform/gtk/svg/text/text-fonts-02-t-expected.png:
- platform/gtk/svg/text/text-intro-05-t-expected.checksum:
- platform/gtk/svg/text/text-intro-05-t-expected.png:
- platform/gtk/svg/text/text-path-01-b-expected.checksum:
- platform/gtk/svg/text/text-path-01-b-expected.png:
- platform/gtk/svg/text/text-spacing-01-b-expected.checksum:
- platform/gtk/svg/text/text-spacing-01-b-expected.png:
- platform/gtk/svg/text/text-text-01-b-expected.checksum:
- platform/gtk/svg/text/text-text-01-b-expected.png:
- platform/gtk/svg/text/text-text-03-b-expected.checksum:
- platform/gtk/svg/text/text-text-03-b-expected.png:
- platform/gtk/svg/text/text-text-04-t-expected.checksum:
- platform/gtk/svg/text/text-text-04-t-expected.png:
- platform/gtk/svg/text/text-text-05-t-expected.checksum:
- platform/gtk/svg/text/text-text-05-t-expected.png:
- platform/gtk/svg/text/text-text-06-t-expected.checksum:
- platform/gtk/svg/text/text-text-06-t-expected.png:
- platform/gtk/svg/text/text-text-07-t-expected.checksum:
- platform/gtk/svg/text/text-text-07-t-expected.png:
- platform/gtk/svg/text/text-text-08-b-expected.checksum:
- platform/gtk/svg/text/text-text-08-b-expected.png:
- platform/gtk/svg/text/text-tref-01-b-expected.checksum:
- platform/gtk/svg/text/text-tref-01-b-expected.png:
- platform/gtk/svg/text/text-tselect-01-b-expected.checksum:
- platform/gtk/svg/text/text-tselect-01-b-expected.png:
- platform/gtk/svg/text/text-tselect-02-f-expected.checksum:
- platform/gtk/svg/text/text-tselect-02-f-expected.png:
- platform/gtk/svg/text/text-tspan-01-b-expected.checksum:
- platform/gtk/svg/text/text-tspan-01-b-expected.png:
- platform/gtk/svg/text/text-ws-01-t-expected.checksum:
- platform/gtk/svg/text/text-ws-01-t-expected.png:
- platform/gtk/svg/text/text-ws-02-t-expected.checksum:
- platform/gtk/svg/text/text-ws-02-t-expected.png:
- platform/gtk/svg/text/textPathBoundsBug-expected.checksum:
- platform/gtk/svg/text/textPathBoundsBug-expected.png:
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[GTK] Need support for dumping focus rectangles in pixel results
https://bugs.webkit.org/show_bug.cgi?id=53647
Add a support function that returns the rectangle of the current
selection in frame.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::rectangleForSelection):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[GTK] Need support for dumping focus rectangles in pixel results
https://bugs.webkit.org/show_bug.cgi?id=53647
Dump the selection rect if it has been requested.
- DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView):
- 8:47 PM Changeset in webkit [84220] by
-
- 10 edits in trunk/Source
2011-04-18 Jia Pu <jpu@apple.com>
Reviewed by Mark Rowe.
WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798
<rdar://problem/9294938>
Use public header <AppKit/NSSpellChecker.h> instead.
- WebCoreSupport/CorrectionPanel.h:
- WebCoreSupport/CorrectionPanel.mm: (correctionIndicatorType): (CorrectionPanel::show): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebView.mm:
2011-04-18 Jia Pu <jpu@apple.com>
Reviewed by Mark Rowe.
WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798
<rdar://problem/9294938>
Use public header <AppKit/NSSpellChecker.h> instead.
- UIProcess/mac/CorrectionPanel.h:
- UIProcess/mac/CorrectionPanel.mm: (correctionIndicatorType): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
- UIProcess/mac/TextCheckerMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- 8:43 PM Changeset in webkit [84219] by
-
- 3 edits in trunk/Source/WebCore
2011-04-18 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add incremental decoding to WebP decoder
https://bugs.webkit.org/show_bug.cgi?id=58851
No new tests, as it's not possible for the layout test framework to
force the decoders to decode incrementally.
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::decode):
- platform/image-decoders/webp/WEBPImageDecoder.h:
- 8:39 PM Changeset in webkit [84218] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
remove tests from test_expectations.txt, as they now pass
https://bugs.webkit.org/show_bug.cgi?id=58813
- platform/chromium/test_expectations.txt:
- 8:21 PM Changeset in webkit [84217] by
-
- 3 edits2 adds in trunk
2011-04-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
pressing-and-holding another mouse button
https://bugs.webkit.org/show_bug.cgi?id=58700
Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
while pressing and holding a mouse button B, where A != B. This issue only affects builds
that enable PAN_SCROLLING.
On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
should only stop the autoscroll timer.
Test: fast/events/fire-mousedown-while-pressing-mouse-button.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
2011-04-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
pressing-and-holding another mouse button
https://bugs.webkit.org/show_bug.cgi?id=58700
Test to ensure that a mousedown event is fired when pressing a mouse button A
while pressing and holding a mouse button B, where A != B.
- fast/events/fire-mousedown-while-pressing-mouse-button-expected.txt: Added.
- fast/events/fire-mousedown-while-pressing-mouse-button.html: Added.
- 8:11 PM Changeset in webkit [84216] by
-
- 4 edits1 move in trunk/Tools
2011-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy should run the ActiveWorkItems tests
https://bugs.webkit.org/show_bug.cgi?id=58859
Also make the unit tests pass. :)
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/queue.py:
- QueueStatusServer/model/workitems.py:
- 7:21 PM Changeset in webkit [84215] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
https://bugs.webkit.org/show_bug.cgi?id=58617
<rdar://problem/9048012>
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders
- 6:40 PM Changeset in webkit [84214] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
https://bugs.webkit.org/show_bug.cgi?id=58824
<rdar://problem/9292680>
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
- 6:35 PM Changeset in webkit [84213] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Don't cast BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=58821
BitmapImageSingleFrameSkia has isBitmap return true, but
can't be cast to a BitmapImage. Instead of using BitmapImage,
use isOpaque from SkBitmap to determine if the image has alpha.
No new tests.
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- 5:34 PM Changeset in webkit [84212] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove unneeded deprecated methods from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=58853
Remove deprecated methods
- heap/MarkStack.h:
- 5:00 PM Changeset in webkit [84211] by
-
- 4 edits in trunk/Tools
2011-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org should show trailing-days pass counts for queues
https://bugs.webkit.org/show_bug.cgi?id=58812
This lets us see if each bot is pulling its own weight or not.
Before I wrote this patch our suspicious was that one of the
cq bots was doing most of the work. Turns out they're actually
pretty even in their recent pass counts.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/index.yaml:
- QueueStatusServer/templates/queuestatus.html:
- 4:43 PM Changeset in webkit [84210] by
-
- 4 edits3 deletes in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: obsolete old threading code, part 1
https://bugs.webkit.org/show_bug.cgi?id=58752
This patch removes support for the 'old-inline' and
'old-threads' worker models, and deletes the corresponding code.
Now that the new code is stable, this stuff is no longer
necessary.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:43 PM Changeset in webkit [84209] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194
Skip fullscreen/full-screen-cancel.html (which uses eventSender.keyDown) in the WK2 tests.
- platform/mac-wk2/Skipped:
- 4:34 PM Changeset in webkit [84208] by
-
- 3 edits in trunk/Source/WebCore
If deleting the StorageTracker.db file fails, local storage is left in a strange state.
https://bugs.webkit.org/show_bug.cgi?id=58805
Reviewed by Steve Falkenburg.
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
depends on and to prevent clashes between a theoretical web page editing local storage
at the same time this method is called.
(WebCore::StorageTracker::syncDeleteAllOrigins):
If it is not possible to delete the StorageTracker.db file, empty it.
(WebCore::StorageTracker::deleteOriginOnMainThread):
Wrapper for deleteOrigin.
- storage/StorageTracker.h:
- 4:31 PM Changeset in webkit [84207] by
-
- 7 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add an --additional-drt-flag option
https://bugs.webkit.org/show_bug.cgi?id=58680
NRWT has a bunch of command line flags that exist to pass
custom flags to DRT, especially on chromium. It would be nice
if there was a generic mechanism to pass through flags so we
didn't have all the custom ones.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 4:28 PM Changeset in webkit [84206] by
-
- 14 edits2 adds in trunk
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
WKTR does not support the eventSender.keyDown() method, so use mouseDown()
in those cases that keyDown() does not exist.
- fullscreen/full-screen-test.js: (runWithKeyDown.document.addEventListener): (runWithKeyDown):
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
Add a new WKBundlePage API for Full Screen events, and move some of the implementation
of WebFullScreenManager into the new InjectedBundlePageFullScreenClient class, so that
the default behavior can be overridden by a WKBundlePageFullScreenClient.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::supportsFullScreen): Moved contents into InjectedBundlePageFullScreenClient. (WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto. (WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetFullScreenClient): Added. (WKBundlePageWillEnterFullScreenForElement): Added. (WKBundlePageDidEnterFullScreenForElement): Added. (WKBundlePageWillExitFullScreenForElement): Added. (WKBundlePageDidExitFullScreenForElement): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: Added. (WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen): Added. (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): Added. (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Added.
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Added.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleFullScreenClient): Added.
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleFullScreenClient): Added.
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
WKTR to test the LayoutTest/fullscreen/ tests.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient. (WTR::InjectedBundlePage::supportsFullScreen): Added. (WTR::InjectedBundlePage::enterFullScreenForElement): Added. (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
- 4:20 PM Changeset in webkit [84205] by
-
- 2 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=58388
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 4:11 PM Changeset in webkit [84204] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
Added back missing #include.
- bindings/js/DOMWrapperWorld.cpp:
- 4:09 PM Changeset in webkit [84203] by
-
- 2 edits in trunk/Source/WebCore
Dropping a file in a WKView (WebKit2) doesn't load the file.
https://bugs.webkit.org/show_bug.cgi?id=58842
<rdar://problem/8514409>
Reviewed by Maciej Stachowiak.
The URL string for the file contains an extra %00 at the end
that causes the network framework to fail to load the file.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):
- 4:07 PM Changeset in webkit [84202] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Maciej Stachowiak.
Re-add a null check lost in r83081
https://bugs.webkit.org/show_bug.cgi?id=58846
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getSelectedRange):
- 4:06 PM Changeset in webkit [84201] by
-
- 7 edits in trunk/Source/WebKit2
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Clean up tool-tip/status-bar confusion.
https://bugs.webkit.org/show_bug.cgi?id=58844
Tool-tips were incorrectly hooked up to the status bar text.
Chrome::setStatusbarText() now correctly causes the QWKPage::statusBarMessage() signal.
New API:
- QWKPage::toolTipChanged(const QString& toolTip) [signal]
QGraphicsWKView will automatically listen for this and set its own toolTip().
- UIProcess/API/qt/ClientImpl.cpp: (qt_wk_setStatusText):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKViewPrivate::onToolTipChanged):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::toolTipChanged): (QWKPage::QWKPage):
- UIProcess/API/qt/qwkpage.h:
- 4:02 PM Changeset in webkit [84200] by
-
- 3 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Unreviewed.
Re-land r84112. It was rolled out in r84127 but it didn't need
to be. Only r84111 actually broke things.
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:58 PM Changeset in webkit [84199] by
-
- 14 edits2 adds in trunk
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- Tools/DumpRenderTree/chromium/LayoutTestController.cpp:
- Tools/DumpRenderTree/chromium/LayoutTestController.h: Adapt to new API. Expose title direction to JS so it can be tested.
- Tools/DumpRenderTree/chromium/WebViewHost.cpp:
- Tools/DumpRenderTree/chromium/WebViewHost.h: Provide new API.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
New test that checks the directionality of the title for some
simple pages.
- fast/dom/title-directionality-expected.txt: Added.
- fast/dom/title-directionality.html: Added.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- public/WebFrameClient.h: (WebKit::WebFrameClient::didReceiveTitle): Add new param to API.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle): Pass new param in API.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setTitleTextDirection): Add member and setter to let us stash the title direction at load time.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.h: Adapt to new API; push the title into layoutTestController when we receive it.
- 3:53 PM Changeset in webkit [84198] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Discovered and rubber-stamped by Stephanie Lewis.
Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>
- bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::~DOMWrapperWorld): (WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our window shells when clearing / destroying ourselves. r83990 removed this behavior for documents since there are no per-document maps anymore, but removing this behavior for window shells too was a typo.
- 3:53 PM Changeset in webkit [84197] by
-
- 4 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: don't run more processes than necessary
https://bugs.webkit.org/show_bug.cgi?id=58751
Previously NRWT would start up 1 process for each processor on
the machine by default, which was a waste if we were only
running a few shards of tests.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:44 PM Changeset in webkit [84196] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK2] Unreviewed buildfix after r84174.
- QtWebKit.pro: Missing includepath added.
- 3:44 PM Changeset in webkit [84195] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
include links to actual.png files for new pixel tests
https://bugs.webkit.org/show_bug.cgi?id=58831
Load image elements to confirm whether the files exist.
Image elements will load without being appended to the DOM.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 3:41 PM Changeset in webkit [84194] by
-
- 24 edits in trunk/Source/WebCore
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
https://bugs.webkit.org/show_bug.cgi?id=58828
- WebCore.exp.in: Blah.
- bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership to JSNodeCustom, where other custom JSNode-related code goes.
(WebCore::JSDOMWrapperOwner::finalize):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
- bindings/js/DOMWrapperWorld.h: (WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner): (WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner to JSDOMWrapperOwner, to match the name of JSDOMWrapper.
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper- related functions, since there is no meaningful distinction between the two anymore -- they both use the same extensible interface.
- bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.
- bindings/js/JSDOMBinding.h: (WebCore::getInlineCachedWrapper): (WebCore::setInlineCachedWrapper): (WebCore::clearInlineCachedWrapper): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::getCachedWrapper): (WebCore::cacheWrapper): (WebCore::uncacheWrapper): (WebCore::createWrapper): (WebCore::wrap): Created a generic, extensible mechanism for creating, caching, retrieving, marking, and destroying DOM wrappers. This eliminates the difference between DOM object wrappers and DOM node wrappers, and lays the groundwork for getting rid of MarkStack::deprecatedAppend usage for marking the remainder of our DOM objects.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
- bindings/js/JSDataViewCustom.cpp: (WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): Updated for renames mentioned above.
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots): (WebCore::JSNamedNodeMapOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSNamedNodeMap::markChildren): (WebCore::toJS): Updated to use our new interface for customizing wrapper lifetime management through function overloading without using MarkStack::deprecatedAppend.
- bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): (WebCore::JSNodeOwner::finalize): (WebCore::createWrapperInline): Moved node-related code from JSDOMBinding to here. Removed special case marking code for JSNamedNodeMap because JSNamedNodeMap now knows how to maintain its own lifetime invariants.
- bindings/js/JSNodeCustom.h: (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::getInlineCachedWrapper): (WebCore::setInlineCachedWrapper): (WebCore::clearInlineCachedWrapper): (WebCore::toJS): Updated to use our new interface for customizing wrapper lifetime management through function overloading without using MarkStack::deprecatedAppend or special-case code for nodes.
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Updated for renames mentioned above.
- bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for renames mentioned above.
- dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now because it needs to provide a custom WeakHandleOwner at wrapper creation time.
- 3:32 PM Changeset in webkit [84193] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
sandbox violation for ~/Library/Dictionaries
https://bugs.webkit.org/show_bug.cgi?id=58841
<rdar://problem/9294770>
- WebProcess/com.apple.WebProcess.sb: Add to sandbox profile. No obvious harm from allowing this, though it's not 100% clear why it's needed.
- 3:28 PM Changeset in webkit [84192] by
-
- 4 edits1 move in trunk/Source/WebCore
REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58747
Rubber-stamped by Sam Weinig.
Copy the WebCore Localizable.strings file into the output directory.
- WebCore.vcproj/WebCoreGenerated.vcproj:
- WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
- WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
- WebCore.vcproj/copyInspectorFiles.cmd: Removed.
- WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.
- 3:20 PM Changeset in webkit [84191] by
-
- 2 edits in trunk/Source/WebKit/mac
Reviewed by Timothy Hatcher.
Stop using -[NSString initWithContentsOfFile:]
https://bugs.webkit.org/show_bug.cgi?id=58763
-[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
- WebView/WebView.mm:
(leakMailQuirksUserScriptContents):
(leakOutlookQuirksUserScriptContents):
- 3:16 PM Changeset in webkit [84190] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
Off by one initialising repeat callframe
https://bugs.webkit.org/show_bug.cgi?id=58838
<rdar://problem/8756810>
If the end of a callframe made for a repeat call landed on
a page boundary the following page may not have been committed
which means that the off by one could lead to a crash. However
it could only happen in this case and only on windows which is
why it was so hard to repro. Alas given the steps needed to
reproduce are such that it's not really possible to make a
testcase.
This fix makes the code a little less squirrely by not trying
to avoid the unnecessary initialisation of |this|.
- interpreter/Interpreter.cpp: (JSC::Interpreter::prepareForRepeatCall):
- 2:56 PM Changeset in webkit [84189] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
https://bugs.webkit.org/show_bug.cgi?id=57546
Disable the fullscreen VKB when testing inputFieldFocus().
- tests/qwebframe/tst_qwebframe.cpp:
- 2:51 PM Changeset in webkit [84188] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add a zoomed view for pixel results to the new results html file
https://bugs.webkit.org/show_bug.cgi?id=58827
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 2:48 PM Changeset in webkit [84187] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint
When scheduling a repaint for the plugin's widget, PluginViewQt
needs to make sure the widget's geometry is up to date. Otherwise
the paint event happens on the widget's old location.
Added a manual test.
- manual-tests/qt/plugin-painting.html: Added.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::invalidateRect):
- 2:47 PM QtWebKitFeatures21 edited by
- (diff)
- 2:44 PM Changeset in webkit [84186] by
-
- 4 edits in trunk/Source/WebCore
Fix Qt build
- 2:31 PM Changeset in webkit [84185] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 58829 - DFG JIT - Optimize add/sub immediate, multiply.
Reviewed by Geoff Garen.
Add code generation for add/subtract instruction with immediate operands
(where a child is a constant), and don't bail to non-speculative if an
integer multiple results in a +0 result (only if it should be generating -0).
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDoubleConstantWithInt32Value):
- 2:21 PM Changeset in webkit [84184] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Windows build.
- Scripts/webkit2/messages.py:
- 2:20 PM Changeset in webkit [84183] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Chang Shu <cshu@webkit.org>
Unreviewed.
Skip failed test due to r84160.
- platform/win-wk2/Skipped:
- 2:08 PM Changeset in webkit [84182] by
-
- 10 edits in trunk/Source/JavaScriptCore
Bug 58817 - DFG JIT - if speculative compilation fails, throw away code.
Reviewed by Geoff Garen.
If we detect a logical conflict, throw away generated code,
and only compile through the NonSpeculativeJIT.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::rewindToLabel):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::rewindToOffset):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchSub32):
- assembler/X86Assembler.h:
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkSpeculationChecks):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
- 2:04 PM Changeset in webkit [84181] by
-
- 10 edits1 delete in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Get rid of WebProcessProxyLegacyMessage
https://bugs.webkit.org/show_bug.cgi?id=58825
- GNUmakefile.am:
- Platform/CoreIPC/MessageID.h:
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Removed.
- UIProcess/WebProcessProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
- win/WebKit2.vcproj:
- 1:59 PM Changeset in webkit [84180] by
-
- 1 edit12 adds in trunk/LayoutTests
2011-04-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add some new tests that exercise border-drawing on split inlines.
- fast/blockflow/border-styles-vertical-lr.html: Added.
- fast/blockflow/border-styles-vertical-rl.html: Added.
- fast/borders/border-styles-split.html: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
- platform/mac/fast/borders/border-styles-split-expected.checksum: Added.
- platform/mac/fast/borders/border-styles-split-expected.png: Added.
- platform/mac/fast/borders/border-styles-split-expected.txt: Added.
- 1:46 PM Changeset in webkit [84179] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Andreas Kling <kling@webkit.org>
[Qt] DRT: Unreviewed test fix after r84168.
Dump the original request KURL for blocked access attempts.
Turns out converting it to a QUrl lower-cases the hostname.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
- 1:43 PM Changeset in webkit [84178] by
-
- 1 edit in trunk/Source/JavaScriptCore/heap/MarkStack.h
Land all of the last patch
- 1:40 PM Changeset in webkit [84177] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/Plugins/PluginInfoStore.h:
- 1:34 PM Changeset in webkit [84176] by
-
- 7 edits in trunk/Source
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
As simple as it sounds.
- runtime/JSValue.h:
- runtime/WriteBarrier.h:
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
Replace use of DeprecatedPtr<> with Global<> as ownership rules
aren't obvious, have filed bug #58820 on seeing if this is safe.
- bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
- bridge/qt/qt_instance.h:
- 1:34 PM Styling Form Controls edited by
- (diff)
- 1:29 PM Changeset in webkit [84175] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Alejandro G. Castro <alex@igalia.com>
Skipping overhanging-tall-block.html, it is crashing in the GTK+ bots.
- platform/gtk/Skipped:
- 1:24 PM Changeset in webkit [84174] by
-
- 11 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Use the message generator for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=58815
- Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): (CoreIPC::handleMessageDelayed): Add helper functions.
- UIProcess/Plugins/PluginInfoStore.h: Mark class noncopyable.
- UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): This now takes a delayed reply.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getPluginProcessConnection): This now takes a delayed reply.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Call DelayedReply::send.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginProcessConnection): This now takes a delayed reply.
(WebKit::WebProcessProxy::didReceiveSyncMessage):
No need to handle this message here.
- UIProcess/WebProcessProxy.messages.in: Add GetPluginProcessConnection message.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Don't use deprecatedSendSync.
- 1:16 PM QtWebKitFeatures21 edited by
- (diff)
- 1:07 PM QtWebKitFeatures21 edited by
- (diff)
- 1:04 PM Changeset in webkit [84173] by
-
- 3 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Finish implementing delayed sync replies in the CoreIPC message generator
https://bugs.webkit.org/show_bug.cgi?id=58814
Put the DelayedReply function definitions in the .cpp file and fix bugs found by
actually trying to compile the generated files.
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
- 12:58 PM Changeset in webkit [84172] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=58088
- platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::convertScanline): un/premultiplies and converts a scanline of image data from/to BGRA to/from RGBA (WebCore::unpremultitplyScanline): (WebCore::premultitplyScanline): (WebCore::ImageBufferData::getData): (WebCore::ImageBufferData::putData):
- 12:49 PM Changeset in webkit [84171] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix Api tests for QWebPage on Symbian
https://bugs.webkit.org/show_bug.cgi?id=56924
Ignores the style attribute that selectedHtml() returns.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::findText):
- 12:42 PM Changeset in webkit [84170] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
Allow all log channels to be initialized from WebCoreLogLevel Windows environment variable
https://bugs.webkit.org/show_bug.cgi?id=58811
- platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): Support initializing LogResourceLoading, LogProgress, and LogFileAPI from WebCoreLogLevel Windows environment variable.
- 12:27 PM Changeset in webkit [84169] by
-
- 4 edits2 adds in trunk
2011-04-18 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
- fullscreen/full-screen-cancel-expected.txt: Added.
- fullscreen/full-screen-cancel.html: Added.
2011-04-18 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
Test: fullscreen/full-screen-cancel.html
- dom/Document.cpp: (WebCore::Document::Document): Remove m_isFullscreen. (WebCore::Document::webkitWillEnterFullScreenForElement): (WebCore::Document::webkitWillExitFullScreenForElement): Remove duplicate call to setAnimating(). (WebCore::Document::webkitDidExitFullScreenForElement): Reset m_fullScreenElement reference.
- dom/Document.h: (WebCore::Document::webkitIsFullScreen): Use m_fullScreenElement instead of m_isFullscreen. (WebCore::Document::webkitFullScreenKeyboardInputAllowed): Ditto.
- 12:23 PM Changeset in webkit [84168] by
-
- 4 edits in trunk
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Adam Barth.
[Qt] DRT: Unbreak redirection of http:/ URLs.
https://bugs.webkit.org/show_bug.cgi?id=58779
- platform/qt/Skipped: Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Adam Barth.
REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
https://bugs.webkit.org/show_bug.cgi?id=58779
KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
QUrl instead to match the behavior of other ports.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
- 12:20 PM Changeset in webkit [84167] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Chris Rogers <crogers@google.com>
Unreviewed.
Update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=58810
- platform/chromium/test_expectations.txt:
- 12:18 PM Changeset in webkit [84166] by
-
- 3 edits4 adds in trunk
<rdar://problem/9282486> REGRESSION (r81992): Facebook photo tags can get cut off when moving the mouse.
https://bugs.webkit.org/show_bug.cgi?id=58500
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/repaint/text-in-relative-positioned-inline.html
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the container’s repaint rect, not
the containing block’s. This matters when the containing block is outside the RenderText’s
enclosing layer, as is the case here.
LayoutTests:
- fast/repaint/text-in-relative-positioned-inline-expected.checksum: Added.
- fast/repaint/text-in-relative-positioned-inline-expected.png: Added.
- fast/repaint/text-in-relative-positioned-inline-expected.txt: Added.
- fast/repaint/text-in-relative-positioned-inline.html: Added.
- 12:04 PM Changeset in webkit [84165] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add labels to results html page
https://bugs.webkit.org/show_bug.cgi?id=58803
-fix iframe size to be the size of the png results
-fix a bunch of aesthetic nits
-fix some incorrectly styled code
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 11:45 AM Changeset in webkit [84164] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84155.
http://trac.webkit.org/changeset/84155
https://bugs.webkit.org/show_bug.cgi?id=58802
"paintEntireContents flag is used for painting outside of the
screen. It's not the right way to fix EFL tiled backing
store." (Requested by demarchi on #webkit).
- ewk/ewk_view_tiled.c: (_ewk_view_tiled_smart_add):
- 11:16 AM Changeset in webkit [84163] by
-
- 3 edits in trunk/Source/WebCore
2011-04-15 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Speed up DrawingBuffer::reset().
https://bugs.webkit.org/show_bug.cgi?id=58706
When DrawingBuffer::reset() is called, it should not reallocate
the FBOs if the size has not changed. It should just do a glClear().
Covered by tests in fast/canvas and canvas/philip.
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): Initialize the size to -1, -1, so the size change check will work on first reset.
- platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset): If the size hasn't changed, don't resize the FBOs. Just clear the relevant buffers.
- 11:00 AM Changeset in webkit [84162] by
-
- 4 edits in branches/chromium/696/Source/WebCore
Merge 83551 - 2011-04-11 Alexey Marinichev <amarinichev@chromium.org> Reviewed by James Robinson. LayerChromium/CCLayerImpl ownership fix https://bugs.webkit.org/show_bug.cgi?id=58283 CCLayerImpl's m_owner field lifetime should match the lifetime of the corresponding LayerChromium. This change moves resetting of m_owner into LayerChromium's destructor. Tested similarly to bug 57577. * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::~LayerChromium): * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::cleanupResources): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::resetOwner):
TBR=commit-queue@webkit.org
BUG=cros 14249
- 10:56 AM QtWebKitFeatures21 edited by
- (diff)
- 10:51 AM Changeset in webkit [84161] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group resources by type in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=58796
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._frameAdded): (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.setTitles): (WebInspector.FrameTreeElement.prototype.set hovered): (WebInspector.FrameTreeElement.prototype.appendResource): (WebInspector.FrameTreeElement.prototype.appendChild): (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder): (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder.compare):
- 10:50 AM QtWebKitFeatures21 edited by
- (diff)
- 10:50 AM QtWebKitRelease21 edited by
- (diff)
- 10:41 AM Changeset in webkit [84160] by
-
- 9 edits in trunk
2011-04-18 Chang Shu <cshu@webkit.org>
Reviewed by Eric Seidel.
WebKitTestRunner needs layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=42541
Unskip passed tests.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-18 Chang Shu <cshu@webkit.org>
Reviewed by Eric Seidel.
WebKitTestRunner needs layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=42541
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: (WTR::LayoutTestController::pathToLocalResource):
- WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::pathToLocalResource):
- WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: (WTR::LayoutTestController::pathToLocalResource):
- 10:34 AM Changeset in webkit [84159] by
-
- 2 edits in trunk/Source/WebKit/win
Remove the two commands that make en.lproj and copy Localizable.strings.
Rubber-stamped by Adam Roben.
- WebKit.vcproj/WebKitLibPostBuild.cmd:
- 10:29 AM Changeset in webkit [84158] by
-
- 5 edits1 delete in trunk
Make update-webkit-localizable-strings put WebKit/win strings in WebCore
now that all localized strings in WebKit/win use WEB_UI_STRING.
Reviewed by Dan Bernstein.
Source/WebCore:
- English.lproj/Localizable.strings: Updated with strings from WebKit/win.
Source/WebKit:
- English.lproj/Localizable.strings: Removed.
Tools:
- Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
- 10:18 AM Changeset in webkit [84157] by
-
- 1 edit11 adds in trunk/LayoutTests
2011-04-18 Hao Zheng <zhenghao@chromium.org>
Reviewed by Eric Seidel.
Rebaseline 3 tests under chromium-gpu-linux port.
https://bugs.webkit.org/show_bug.cgi?id=58627
- platform/chromium-gpu-linux/fast/media: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Added.
- platform/chromium-gpu-linux/fast/repaint: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
- 10:14 AM Changeset in webkit [84156] by
-
- 4 edits in trunk/Source/WebCore
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Adam Barth.
REGRESSION: <progress> doesn't animate if it doesn't have value
https://bugs.webkit.org/show_bug.cgi?id=58693
The initial value of RenderProgress::m_position is accidentally same as
the indeterminate value, that makes update code on updateFromElement() skipped.
This change set unique invalid value for the initial value of m_position.
No new tests. Testing animated bar is not possible with DRT.
- html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position):
- html/HTMLProgressElement.h:
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::isDeterminate):
- 10:13 AM Changeset in webkit [84155] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-04-18 Eunsol Park <eunsol47.park@samsung.com>
Reviewed by Eric Seidel.
[EFL] Scroll doesn't work on tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=55021
Scroll doesn't work on tiled backing store, but it works on single.
If ewk_frame_paint_full_set() set True, view size return content size and scroll can't be made.
so, ewk_frame_paint_full_set() is removed from ewk_tiled_smart_add().
- ewk/ewk_view_tiled.c: (_ewk_view_tiled_smart_add):
- 10:08 AM Changeset in webkit [84154] by
-
- 3 edits in trunk/Tools
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=58755
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
- WinLauncher/PrintWebUIDelegate.cpp: Also fix various style issues (including indentation and removal of ugly C-casts).
- WinLauncher/WinLauncher.cpp:
- 9:55 AM Changeset in webkit [84153] by
-
- 3 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Reproducible crash in Find on Page, on pages that use accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=58793
<rdar://problem/9295870>
Move the call to PageOverlay::setNeedsDisplay() back to WebPage::installPageOverlay;
it needs to be called after we've told the drawing area that a page overlay has been installed.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setPage):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay):
- 9:48 AM Changeset in webkit [84152] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
https://bugs.webkit.org/show_bug.cgi?id=58791
On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
We should guard it again RefPtr.
- html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary):
- 9:37 AM Changeset in webkit [84151] by
-
- 2 edits in trunk/Source/WebCore
CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=56124
<rdar://problem/9119036>
Reviewed by Simon Fraser.
In all stacks this is occuring when the document is kept alive by the guard ref only
and the node holding it is deleted.
As a speculative fix, clear the document stylesheets when it turns into a guard ref zombie.
This has a pretty good chance of fixing the actual bug. At minimum it will move the
crash to an earlier, more easily traceble point.
No tests, crash stacks only, no idea how to reproduce.
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
- 9:23 AM Changeset in webkit [84150] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Backspace in the Console is broken
https://bugs.webkit.org/show_bug.cgi?id=58764
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 9:13 AM Changeset in webkit [84149] by
-
- 14 edits7 adds in trunk
2011-04-18 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
LevelDB backend for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=57372
Add LevelDB wrappers to Android.mk.
- Source/Android.mk:
2011-04-18 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
LevelDB backend for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=57372
Only available behind a run-time flag. Covered by existing layout
tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/leveldb/LevelDBComparator.h: Added. (WebCore::LevelDBComparator::~LevelDBComparator):
- platform/leveldb/LevelDBDatabase.cpp: Added. (WebCore::makeSlice): (WebCore::makeLevelDBSlice): (WebCore::makeVector): (WebCore::LevelDBDatabase::LevelDBDatabase): (WebCore::LevelDBDatabase::~LevelDBDatabase): (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::newIterator):
- platform/leveldb/LevelDBDatabase.h: Added.
- platform/leveldb/LevelDBIterator.cpp: Added. (WebCore::LevelDBIterator::~LevelDBIterator): (WebCore::LevelDBIterator::LevelDBIterator): (WebCore::makeSlice): (WebCore::makeLevelDBSlice): (WebCore::LevelDBIterator::isValid): (WebCore::LevelDBIterator::seekToLast): (WebCore::LevelDBIterator::seek): (WebCore::LevelDBIterator::next): (WebCore::LevelDBIterator::prev): (WebCore::LevelDBIterator::key): (WebCore::LevelDBIterator::value):
- platform/leveldb/LevelDBIterator.h: Added.
- platform/leveldb/LevelDBSlice.h: Added. (WebCore::LevelDBSlice::LevelDBSlice): (WebCore::LevelDBSlice::~LevelDBSlice): (WebCore::LevelDBSlice::begin): (WebCore::LevelDBSlice::end):
- storage/IDBLevelDBBackingStore.cpp: (WebCore::encodeByte): (WebCore::maxIDBKey): (WebCore::minIDBKey): (WebCore::encodeInt): (WebCore::decodeInt): (WebCore::encodeVarInt): (WebCore::decodeVarInt): (WebCore::encodeString): (WebCore::decodeString): (WebCore::encodeStringWithLength): (WebCore::decodeStringWithLength): (WebCore::encodeDouble): (WebCore::decodeDouble): (WebCore::encodeIDBKey): (WebCore::decodeIDBKey): (WebCore::extractEncodedIDBKey): (WebCore::compareEncodedIDBKeys): (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::KeyPrefix::SchemaVersionKey::encode): (WebCore::KeyPrefix::MaxDatabaseIdKey::encode): (WebCore::KeyPrefix::DatabaseFreeListKey::DatabaseFreeListKey): (WebCore::KeyPrefix::DatabaseFreeListKey::decode): (WebCore::KeyPrefix::DatabaseFreeListKey::encode): (WebCore::KeyPrefix::DatabaseFreeListKey::databaseId): (WebCore::KeyPrefix::DatabaseFreeListKey::compare): (WebCore::KeyPrefix::DatabaseNameKey::decode): (WebCore::KeyPrefix::DatabaseNameKey::encode): (WebCore::KeyPrefix::DatabaseNameKey::origin): (WebCore::KeyPrefix::DatabaseNameKey::databaseName): (WebCore::KeyPrefix::DatabaseNameKey::compare): (WebCore::KeyPrefix::DatabaseMetaDataKey::encode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::decode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::encode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::objectStoreId): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::metaDataType): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::compare): (WebCore::KeyPrefix::IndexMetaDataKey::IndexMetaDataKey): (WebCore::KeyPrefix::IndexMetaDataKey::decode): (WebCore::KeyPrefix::IndexMetaDataKey::encode): (WebCore::KeyPrefix::IndexMetaDataKey::compare): (WebCore::KeyPrefix::IndexMetaDataKey::indexId): (WebCore::KeyPrefix::IndexMetaDataKey::metaDataType): (WebCore::KeyPrefix::ObjectStoreFreeListKey::ObjectStoreFreeListKey): (WebCore::KeyPrefix::ObjectStoreFreeListKey::decode): (WebCore::KeyPrefix::ObjectStoreFreeListKey::encode): (WebCore::KeyPrefix::ObjectStoreFreeListKey::objectStoreId): (WebCore::KeyPrefix::ObjectStoreFreeListKey::compare): (WebCore::KeyPrefix::IndexFreeListKey::IndexFreeListKey): (WebCore::KeyPrefix::IndexFreeListKey::decode): (WebCore::KeyPrefix::IndexFreeListKey::encode): (WebCore::KeyPrefix::IndexFreeListKey::compare): (WebCore::KeyPrefix::IndexFreeListKey::objectStoreId): (WebCore::KeyPrefix::IndexFreeListKey::indexId): (WebCore::KeyPrefix::ObjectStoreNamesKey::decode): (WebCore::KeyPrefix::ObjectStoreNamesKey::encode): (WebCore::KeyPrefix::ObjectStoreNamesKey::compare): (WebCore::KeyPrefix::ObjectStoreNamesKey::objectStoreName): (WebCore::KeyPrefix::IndexNamesKey::IndexNamesKey): (WebCore::KeyPrefix::IndexNamesKey::decode): (WebCore::KeyPrefix::IndexNamesKey::encode): (WebCore::KeyPrefix::IndexNamesKey::compare): (WebCore::KeyPrefix::IndexNamesKey::indexName): (WebCore::KeyPrefix::ObjectStoreDataKey::decode): (WebCore::KeyPrefix::ObjectStoreDataKey::encode): (WebCore::KeyPrefix::ObjectStoreDataKey::compare): (WebCore::KeyPrefix::ObjectStoreDataKey::userKey): (WebCore::KeyPrefix::ExistsEntryKey::decode): (WebCore::KeyPrefix::ExistsEntryKey::encode): (WebCore::KeyPrefix::ExistsEntryKey::compare): (WebCore::KeyPrefix::ExistsEntryKey::userKey): (WebCore::KeyPrefix::IndexDataKey::IndexDataKey): (WebCore::KeyPrefix::IndexDataKey::decode): (WebCore::KeyPrefix::IndexDataKey::encode): (WebCore::KeyPrefix::IndexDataKey::encodeMaxKey): (WebCore::KeyPrefix::IndexDataKey::compare): (WebCore::KeyPrefix::IndexDataKey::databaseId): (WebCore::KeyPrefix::IndexDataKey::objectStoreId): (WebCore::KeyPrefix::IndexDataKey::indexId): (WebCore::KeyPrefix::IndexDataKey::userKey): (WebCore::KeyPrefix::realCompare): (WebCore::KeyPrefix::compareKeys): (WebCore::KeyPrefix::compareIndexKeys): (WebCore::KeyPrefix::Comparator::compare): (WebCore::KeyPrefix::Comparator::name): (WebCore::setUpMetadata): (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore): (WebCore::IDBLevelDBBackingStore::open): (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::deleteIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::findGreatestKeyLessThan): (WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord): (WebCore::IDBLevelDBBackingStore::getObjectViaIndex): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor): (WebCore::IDBLevelDBBackingStore::createTransaction):
- storage/IDBLevelDBBackingStore.h:
- 8:59 AM Changeset in webkit [84148] by
-
- 7 edits3 adds in trunk
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for CSS-resource binding.
https://bugs.webkit.org/show_bug.cgi?id=58786
- inspector/styles/resources/styles-history.css: Added. (body):
- inspector/styles/styles-history-expecte.txt: Added.
- inspector/styles/styles-history.html: Added.
- inspector/styles/styles-source-offsets.html:
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for CSS-resource binding.
https://bugs.webkit.org/show_bug.cgi?id=58786
Test: inspector/styles/styles-history.html
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyleSheet::setPropertyText): (WebCore::InspectorStyleSheet::toggleProperty):
- inspector/InspectorStyleSheet.h:
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.if): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.mycallback): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged): (WebInspector.CSSStyleModel.prototype.setStyleSheetText): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText):
- 8:56 AM Changeset in webkit [84147] by
-
- 5 edits in trunk
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83996.
http://trac.webkit.org/changeset/83996
https://bugs.webkit.org/show_bug.cgi?id=58790
layout test editing/selection/move-by-word-visually.html is
failing (Requested by jknotten on #webkit).
- editing/selection/move-by-word-visually-expected.txt:
- editing/selection/move-by-word-visually.html:
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83996.
http://trac.webkit.org/changeset/83996
https://bugs.webkit.org/show_bug.cgi?id=58790
layout test editing/selection/move-by-word-visually.html is
failing (Requested by jknotten on #webkit).
- editing/visible_units.cpp: (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality): (WebCore::previousWordBreakInBox): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):
- 8:32 AM Changeset in webkit [84146] by
-
- 19 edits in trunk/Source/WebKit/win
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Include <WebCore/COMPtr.h> instead of "COMPtr.h"
https://bugs.webkit.org/show_bug.cgi?id=58744
- DOMCoreClasses.cpp:
- DOMHTMLClasses.cpp:
- WebActionPropertyBag.cpp:
- WebBackForwardList.cpp:
- WebCoreSupport/WebGeolocationClient.h:
- WebDownload.h:
- WebDropSource.h:
- WebFrame.cpp:
- WebHistoryItem.cpp:
- WebIconDatabase.cpp:
- WebNavigationData.h:
- WebPreferences.cpp:
- WebResource.h:
- WebURLAuthenticationChallenge.cpp:
- WebURLAuthenticationChallengeSender.cpp:
- WebURLAuthenticationChallengeSenderCFNet.cpp:
- WebURLAuthenticationChallengeSenderCurl.cpp:
- WebView.h:
- 8:13 AM Changeset in webkit [84145] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Daniel Bates.
Modify make_names.pl to not include conditional includes unconditionally
https://bugs.webkit.org/show_bug.cgi?id=53672
Fixed conditional includes being unconditionally included.
No new tests (no change in functionality)
- dom/make_names.pl:
- Modified printJSElementIncludes() to only print unconditional element includes.
- Modified printElementIncludes() to only print unconditional element includes.
- Added printConditionalElementIncludes() which takes care of printing conditional element includes.
- 7:55 AM Changeset in webkit [84144] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
WKFrameLoadState should be a uint32_t to match our API conventions
https://bugs.webkit.org/show_bug.cgi?id=58785
- UIProcess/API/C/WKFrame.h: typedef WKFrameLoadState as a uint32_t and define its values as an anonymous enum.
- 7:44 AM Changeset in webkit [84143] by
-
- 3 edits4 deletes in trunk
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83803.
http://trac.webkit.org/changeset/83803
https://bugs.webkit.org/show_bug.cgi?id=58782
Caused focus rings to appear in youtube videos (Requested by
inferno-sec on #webkit).
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83803.
http://trac.webkit.org/changeset/83803
https://bugs.webkit.org/show_bug.cgi?id=58782
Caused focus rings to appear in youtube videos (Requested by
inferno-sec on #webkit).
- fast/frames/iframe-outline.html: Removed.
- platform/mac/fast/frames/iframe-outline-expected.checksum: Removed.
- platform/mac/fast/frames/iframe-outline-expected.png: Removed.
- platform/mac/fast/frames/iframe-outline-expected.txt: Removed.
- 7:25 AM Changeset in webkit [84142] by
-
- 2 edits in trunk/LayoutTests
Skip a flaky test on Windows
<http://webkit.org/b/58367> tracks the failure.
- platform/win/Skipped: Added http/tests/inspector/resource-tree-model.html.
- 7:19 AM Changeset in webkit [84141] by
-
- 3 edits in trunk/Source/WebCore
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Need a workaround for bug 58422
https://bugs.webkit.org/show_bug.cgi?id=58780
Instead of the A:before content, the link text is displayed as the A tag content.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.linkifyUncopyable): (WebInspector.StylePropertiesSection):
- inspector/front-end/inspector.css:
- 7:15 AM Changeset in webkit [84140] by
-
- 5 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline for fast/html/details-add-summary-1
https://bugs.webkit.org/show_bug.cgi?id=58783
Following changes to after changes to RenderDetailsMarker (r84039).
- platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
- 6:56 AM Changeset in webkit [84139] by
-
- 8 edits in trunk
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- platform/qt/Skipped: unskip fast/dom/HTMLKeygenElement now
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowRoot): Added.
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowRoot): Added.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 6:54 AM Changeset in webkit [84138] by
-
- 4 edits1 copy in trunk/Source/WebKit2
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 84017.
- GNUmakefile.am:
- Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
- Shared/gtk/NativeWebMouseEventGtk.cpp: Copied from Source/WebKit2/Shared/NativeWebMouseEvent.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::handleMouseEvent):
- 6:49 AM Changeset in webkit [84137] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 82465.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedString):
- 6:36 AM Changeset in webkit [84136] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: TAB should not move focus from the text editor while live editing
https://bugs.webkit.org/show_bug.cgi?id=58537
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._registerShortcuts): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo): (WebInspector.TextEditorMainPanel.prototype.handleTabKeyPress): (WebInspector.TextEditorMainPanel.prototype._setCaretLocation): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._setText):
- 6:32 AM Changeset in webkit [84135] by
-
- 3 edits2 adds in trunk
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=58551
- inspector/styles/metrics-box-sizing-expected.txt: Added.
- inspector/styles/metrics-box-sizing.html: Added.
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=58551
Test: inspector/styles/metrics-box-sizing.html
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._getPropertyValueAsPx): (WebInspector.MetricsSidebarPane.prototype._getBox): (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaWidthPx): (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaHeightPx): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.startEditing): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- 5:25 AM Changeset in webkit [84134] by
-
- 4 edits in trunk/Source/WebCore
2011-04-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Database agent stops to propagate it's events after navigation.
https://bugs.webkit.org/show_bug.cgi?id=58776
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::restore):
- inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
- 5:15 AM Changeset in webkit [84133] by
-
- 2 edits12 adds2 deletes in trunk/LayoutTests
011-04-18 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium baselines for new tests.
- platform/chromium-linux/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/select-background-none-expected.png: Removed.
- platform/chromium-win/fast/forms/select-background-none-expected.png: Added.
- platform/chromium-win/fast/forms/select-background-none-expected.txt: Added.
- platform/chromium-win/fast/frames/iframe-outline-expected.png: Added.
- platform/chromium-win/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-win/fast/text/zero-font-size-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:54 AM Changeset in webkit [84132] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added suppressions for shadow texts broken by r83936.
- platform/chromium/test_expectations.txt:
- 4:51 AM Changeset in webkit [84131] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Update test expectations for canvas/philip/tests/2d.gradient.interpolate.outside.html
https://bugs.webkit.org/show_bug.cgi?id=58777
Regression caused by Skia roll: Chromium r81836.
- platform/chromium/test_expectations.txt:
- 4:29 AM Changeset in webkit [84130] by
-
- 2 edits in trunk
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Pavel Feldman.
REGRESSION (r81479): generate-inspector-idl fails on native win32
https://bugs.webkit.org/show_bug.cgi?id=58315
Disable git autocrlf for Inspector.json.
- .gitattributes:
- 4:16 AM Changeset in webkit [84129] by
-
- 89 edits1 copy1 add in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline after changes to RenderDetailsMarker (Linux, Mac) (r84039)
https://bugs.webkit.org/show_bug.cgi?id=58775
- platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
- platform/chromium-linux/fast/html/details-no-summary1-expected.png:
- platform/chromium-linux/fast/html/details-no-summary2-expected.png:
- platform/chromium-linux/fast/html/details-no-summary3-expected.png:
- platform/chromium-linux/fast/html/details-no-summary4-expected.png:
- platform/chromium-linux/fast/html/details-open-javascript-expected.png:
- platform/chromium-linux/fast/html/details-open1-expected.png:
- platform/chromium-linux/fast/html/details-open2-expected.png:
- platform/chromium-linux/fast/html/details-open3-expected.png:
- platform/chromium-linux/fast/html/details-open4-expected.png:
- platform/chromium-linux/fast/html/details-open5-expected.png:
- platform/chromium-linux/fast/html/details-open6-expected.png:
- platform/chromium-linux/fast/html/details-position-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-linux/fast/html/details-writing-mode-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-position-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png:
- platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png.
- platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
- 2:47 AM Changeset in webkit [84128] by
-
- 4 edits in trunk/Tools
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84111.
http://trac.webkit.org/changeset/84111
https://bugs.webkit.org/show_bug.cgi?id=58771
Chromium linux layout tests are broken. (Requested by loislo2
on #webkit).
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- 2:45 AM Changeset in webkit [84127] by
-
- 3 edits in trunk/Tools
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84112.
http://trac.webkit.org/changeset/84112
https://bugs.webkit.org/show_bug.cgi?id=58770
Chromium linux layout tests are broken. (Requested by loislo2
on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 2:34 AM Changeset in webkit [84126] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83968.
http://trac.webkit.org/changeset/83968
https://bugs.webkit.org/show_bug.cgi?id=58769
Breaks Backspace in Web Inspector console (Requested by
apavlov on #webkit).
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 2:27 AM Changeset in webkit [84125] by
-
- 14 edits1 copy1 add in trunk/Source/WebCore
2011-04-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce WorkerInspectorController
https://bugs.webkit.org/show_bug.cgi?id=58668
WorkerInspectorController will be owned by WorkerContext and will hold all inspector
agents and will also manage connection to the inspector frontend.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptState.cpp: (WebCore::scriptStateFromWorkerContext):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromWorkerContext):
- bindings/v8/ScriptState.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::updateCookie):
- inspector/WorkerInspectorController.cpp: Added. (WebCore::WorkerInspectorController::WorkerInspectorController): (WebCore::WorkerInspectorController::~WorkerInspectorController): (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend): (WebCore::WorkerInspectorController::dispatchMessageFromFrontend):
- inspector/WorkerInspectorController.h: Copied from Source/WebCore/bindings/js/ScriptState.h.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- workers/WorkerContext.h: (WebCore::WorkerContext::workerInspectorController):
- 2:15 AM Changeset in webkit [84124] by
-
- 90 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline after changes to RenderDetailsMarker (r84039)
https://bugs.webkit.org/show_bug.cgi?id=58767
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-expected.png:
- platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-expected.png:
- platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-expected.png:
- platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-expected.png:
- platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-expected.png:
- platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-expected.png:
- platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-expected.png:
- platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-expected.png:
- platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-expected.png:
- platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
- platform/chromium-win/fast/html/details-no-summary1-expected.png:
- platform/chromium-win/fast/html/details-no-summary1-expected.txt:
- platform/chromium-win/fast/html/details-no-summary2-expected.png:
- platform/chromium-win/fast/html/details-no-summary2-expected.txt:
- platform/chromium-win/fast/html/details-no-summary3-expected.png:
- platform/chromium-win/fast/html/details-no-summary3-expected.txt:
- platform/chromium-win/fast/html/details-no-summary4-expected.png:
- platform/chromium-win/fast/html/details-no-summary4-expected.txt:
- platform/chromium-win/fast/html/details-open-javascript-expected.png:
- platform/chromium-win/fast/html/details-open-javascript-expected.txt:
- platform/chromium-win/fast/html/details-open1-expected.png:
- platform/chromium-win/fast/html/details-open1-expected.txt:
- platform/chromium-win/fast/html/details-open2-expected.png:
- platform/chromium-win/fast/html/details-open2-expected.txt:
- platform/chromium-win/fast/html/details-open3-expected.png:
- platform/chromium-win/fast/html/details-open3-expected.txt:
- platform/chromium-win/fast/html/details-open4-expected.png:
- platform/chromium-win/fast/html/details-open4-expected.txt:
- platform/chromium-win/fast/html/details-open5-expected.png:
- platform/chromium-win/fast/html/details-open5-expected.txt:
- platform/chromium-win/fast/html/details-open6-expected.png:
- platform/chromium-win/fast/html/details-open6-expected.txt:
- platform/chromium-win/fast/html/details-position-expected.png:
- platform/chromium-win/fast/html/details-position-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-writing-mode-expected.png:
- platform/chromium-win/fast/html/details-writing-mode-expected.txt:
- platform/chromium/test_expectations.txt:
Apr 17, 2011:
- 11:53 PM Changeset in webkit [84123] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Thierry Reding <thierry.reding@avionic-design.de>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
- dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor
on something that is not C code, and will be sent to a program
which might be confused by the linemarkers.
The linemarkers are not problematic, however, because the script
properly handles them by ignoring all lines starting with a #.
- 10:36 PM Changeset in webkit [84122] by
-
- 46 edits90 adds in trunk/LayoutTests
Update Qt specific expected files after r84039.
- platform/qt/fast/html/details-[...] : Updated.
- 10:15 PM Changeset in webkit [84121] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reviewed by Dan Bernstein.
JSC no longer builds with Clang due to -Woverloaded-virtual warning
https://bugs.webkit.org/show_bug.cgi?id=58760
Rename Structure's specificValue overload of put to putSpecificValue to avoid
Clang's warning for overloading a virtual function.
- runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::putSpecificValue):
- runtime/Structure.h:
- 9:06 PM Changeset in webkit [84120] by
-
- 14 edits in trunk/Source
<http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
<rdar://problem/9268729>
Reviewed by Dan Bernstein.
This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::ResourceRequest class in
WebCore, the WebView class in WebKit1, and the WebContext class
in WebKit2. It also removes support for the
WebKitForceHTTPPipeliningPriorityHigh user default which was not
needed.
Source/WebCore:
Run these commands if you set the user defaults previously,
replacing "BUNDLE.ID" with your application's bundle ID:
defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh
- WebCore.exp.in: Export ResourceRequest::httpPipeliningEnabled()
and ResourceRequest::setHTTPPipeliningEnabled().
- platform/network/ResourceRequestBase.h:
(WebCore::isHTTPPipeliningEnabled): Removed declaration.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::httpPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added declaration.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
to use ResourceRequest::httpPipeliningEnabled().
(WebCore::readBooleanPreference): Removed.
(WebCore::isHTTPPipeliningEnabled): Removed.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use ResourceRequest::httpPipeliningEnabled(). Removed check for
shouldForceHTTPPipeliningPriorityHigh().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
- WebView/WebViewPrivate.h:
(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
Source/WebKit2:
- UIProcess/API/C/WKContext.cpp:
(_WKContextSetHTTPPipeliningEnabled): Added.
- UIProcess/API/C/WKContextPrivate.h:
(_WKContextSetHTTPPipeliningEnabled): Added declaration.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added.
(WebKit::WebContext::httpPipeliningEnabled): Added.
- UIProcess/WebContext.h:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added declaration.
(WebKit::WebContext::httpPipeliningEnabled): Added declaration.
- 7:10 PM Changeset in webkit [84119] by
-
- 7 edits in trunk
REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html
https://bugs.webkit.org/show_bug.cgi?id=58736
Reviewed by Maciej Stachowiak.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): It is enough to extend the float so
that it touches the bottom of the previous line, since RenderBlock::markLinesDirtyInBlockRange()
always dirties the line after the last one in the range.
LayoutTests:
Revert to the correct results.
- platform/chromium-win/fast/block/float/032-expected.txt:
- platform/gtk/fast/block/float/032-expected.txt:
- platform/mac/fast/block/float/032-expected.txt:
- platform/qt/fast/block/float/032-expected.txt:
- 5:10 PM Changeset in webkit [84118] by
-
- 5 edits in trunk/Source/WebKit2
2011-04-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Make more strings in WebKit2 localizable
https://bugs.webkit.org/show_bug.cgi?id=58757
- UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView menuForEvent:]):
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand):
- UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::nameForEditAction):
- UIProcess/WebEditCommandProxy.h: Use WebCore's localization macro to make more strings localizable.
- 4:58 PM Changeset in webkit [84117] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Add missing include to fix build without precompiled header.
- rendering/RenderMediaControls.cpp:
- 4:50 PM Changeset in webkit [84116] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Daniel Bates <dbates@webkit.org>
Attempt to fix the Chromium build after changeset 84110 <http://trac.webkit.org/changeset/84110>
(https://bugs.webkit.org/show_bug.cgi?id=57842).
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Rename CachedResource::LinkPrefetch to CachedResource::LinkResource.
- 4:33 PM Changeset in webkit [84115] by
-
- 1 edit in trunk/Tools/ChangeLog
2011-04-17 Daniel Bates <dbates@webkit.org>
Acknowledge Adam Barth for reviewing the patch committed in changeset
84114 <http://trac.webkit.org/changeset/84114>. And fix my email address.
- 4:27 PM Changeset in webkit [84114] by
-
- 6 edits in trunk/Tools
2011-04-17 Daniel Bates <dbates@webkit.com>
Reviewed by Eric Seidel.
webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500
Prompt for username and password when using git-svn and there aren't cached SVN credentials.
- Scripts/webkitpy/common/checkout/scm.py:
- Added mixin class SVNRepository and made both class SVN and Git inherit from it.
- Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value for argument realm; modified call sites as needed.
- Modified AuthenticationError constructor to take optional prompt_for_password argument.
- Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
- Modified Git._commit_on_branch() to take optional username and password argument.
- Modified Git.push_local_commits_to_server() to take optional username and password argument and to call has_authorization_for_realm().
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
- Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to SVN.has_authorization_for_realm().
- Scripts/webkitpy/common/net/credentials.py:
- Modified Credentials.read_credentials() to call User.prompt_password() instead of using getpass.getpass() directly.
- Scripts/webkitpy/common/system/user.py:
- Added User.prompt_password().
- Scripts/webkitpy/tool/steps/commit.py:
- Modified Commit.run() to prompt for a password if needed.
- 4:08 PM Changeset in webkit [84113] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Remove pthread dependency of GCController
https://bugs.webkit.org/show_bug.cgi?id=54833
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
- 2:49 PM Changeset in webkit [84112] by
-
- 3 edits in trunk/Tools
2011-04-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: save stderr into the layout-test-results dir
https://bugs.webkit.org/show_bug.cgi?id=58690
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 2:48 PM Changeset in webkit [84111] by
-
- 4 edits in trunk/Tools
2011-04-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: read stderr from chromium DRT separately
https://bugs.webkit.org/show_bug.cgi?id=58708
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- 2:30 PM Changeset in webkit [84110] by
-
- 13 edits4 adds in trunk
2011-04-17 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add support for link rel type "subresource"
https://bugs.webkit.org/show_bug.cgi?id=57842
Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.
During testing, I was dissapointed to see the results for the http
test below don't give the subresource priority ordering. This is
another instance of https://bugs.webkit.org/show_bug.cgi?id=49238
which I'll be working on next, and thus fix the test.
- fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
- fast/dom/HTMLLinkElement/subresource.html: Added.
- http/tests/misc/link-rel-prefetch-and-subresource-expected.txt: Added.
- http/tests/misc/link-rel-prefetch-and-subresource.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-04-17 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add support for link rel type "subresource"
https://bugs.webkit.org/show_bug.cgi?id=57842
Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.
Particularly after https://bugs.webkit.org/show_bug.cgi?id=51940
is implemented, a rel type that launches requests at an higher
priority is going to be very useful. This rel type is in the
HTML5 spec at http://wiki.whatwg.org/wiki/RelExtensions . An
expected use case will be for servers to provide subresource hints
in link headers, which will allow servers to help make the web
faster.
This feature continues my implementation of the Link header, which
we've talked about in WebKit-dev in
https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html.
Tests: fast/dom/HTMLLinkElement/subresource.html
http/tests/misc/link-rel-prefetch-and-subresource.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::onloadTimerFired): (WebCore::HTMLLinkElement::notifyFinished):
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
- loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
- loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
- loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::incrementRequestCount): (WebCore::CachedResourceLoader::decrementRequestCount):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
- 2:09 PM Changeset in webkit [84109] by
-
- 2 edits in trunk/Source/WebKit/mac
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dan Bernstein.
Assign to self in WebInspectorWindowController constructors
https://bugs.webkit.org/show_bug.cgi?id=58749
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:]):
- 1:41 PM Changeset in webkit [84108] by
-
- 4 edits2 adds in trunk/Source/WebKit
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Move WebNodeHighlighter into its own file
https://bugs.webkit.org/show_bug.cgi?id=58746
- WebKit.xcodeproj/project.pbxproj: Add WebNodeHighlighter.{h,mm}.
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Move WebNodeHighlighter into its own file
https://bugs.webkit.org/show_bug.cgi?id=58746
Extract this class into its own file alongside the
other WebNodeHighlight files. In doing so do some
cleanup on WebInspectorClient removing some methods
that were never called.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): style fix.
- WebInspector/WebNodeHighlighter.h: Added.
- WebInspector/WebNodeHighlighter.mm: Added. (-[WebNodeHighlighter initWithInspectedWebView:]): call super init. (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
- 1:23 PM Changeset in webkit [84107] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=58745
Reviewed by Joseph Pecoraro.
This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
which was fixed in r83514.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
variable so named, not the top layout overflow.
- 12:42 PM April 2011 Meeting edited by
- Adding myself to shadow DOM talk (diff)
- 12:06 PM Changeset in webkit [84106] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Remove WTF_PLATFORM_SGL
https://bugs.webkit.org/show_bug.cgi?id=58743
WTF_PLATFORM_SGL and PLATFORM(SGL) are not used in the code anywhere.
- wtf/Platform.h:
- 12:03 PM Changeset in webkit [84105] by
-
- 19 edits in trunk/Source/WebCore
2011-04-17 Geoffrey Garen <ggaren@apple.com>
Strongly suggested, but not necessarily reviewed, by
Sam Weinig and Maciej Stachowiak.
Renamed DOMObject* => JSDOMWrapper*.
- bindings/js/DOMWrapperWorld.cpp: (WebCore::isObservable): (WebCore::DOMObjectHandleOwner::finalize):
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSDOMBinding.h: (WebCore::JSDOMWrapperWithGlobalPointer::globalObject): (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper):
- bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMWrapper::~JSDOMWrapper):
- bindings/js/JSDOMWrapper.h: (WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 11:59 AM Changeset in webkit [84104] by
-
- 15 edits in trunk
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- wtf/Platform.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- config.h:
- platform/graphics/ca/TransformationMatrixCA.cpp:
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/mac/WebCoreSystemInterface.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/win/LayerTreeHostWin.cpp: (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 7:29 AM Changeset in webkit [84103] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Young Han Lee <joybro@company100.net>
Reviewed by Benjamin Poulain.
[Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
https://bugs.webkit.org/show_bug.cgi?id=58739
gInVertexAttributeIndex is a constant variable to point the location of
"InVertex" attribute of the vertex shaders.
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::drawTexture): (WebCore::TextureMapperGL::paintToTarget):
- 4:04 AM Changeset in webkit [84102] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Kinuko Yasuda <kinuko@chromium.org>
Not reviewed: Fix copyright (I had submitted the file with wrong
copyright line).
- storage/StorageInfo.idl:
- 3:04 AM Changeset in webkit [84101] by
-
- 102 edits in trunk
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- wtf/Platform.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- config.h:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- loader/cache/CachedFont.cpp:
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::createImage):
- platform/FloatConversion.h:
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/BitmapImage.h:
- platform/graphics/Color.h:
- platform/graphics/DashArray.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow):
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/Image.cpp:
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.cpp:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cg/ColorCG.cpp:
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/ImageCG.cpp:
- platform/graphics/cg/ImageSourceCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/cg/PDFDocumentImage.cpp:
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/TransformationMatrixCG.cpp:
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::Painter::Painter):
- platform/graphics/chromium/PlatformCanvas.h:
- platform/graphics/chromium/PlatformImage.cpp: (WebCore::PlatformImage::updateFromImage):
- platform/graphics/opentype/OpenTypeUtilities.cpp:
- platform/graphics/transforms/AffineTransform.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/DIBPixelData.h:
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::platformInit): (WebCore::createGDIFont): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/GraphicsContextWin.cpp:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp:
- platform/image-decoders/ImageDecoder.cpp:
- platform/image-decoders/ImageDecoder.h:
- rendering/RenderObject.h:
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::applyResource):
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::reshape):
- src/GraphicsContext3DInternal.h:
- src/PlatformBridge.cpp:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- WebFrame.cpp: (WebFrame::spoolPages):
- WebFrame.h:
- WebPreferences.cpp: (WebPreferences::setFontSmoothing): (WebPreferences::setFontSmoothingContrast):
- WebView.cpp: (systemParameterChanged):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- Shared/ShareableBitmap.h:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
- Shared/WebGraphicsContext.h:
- Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
- UIProcess/win/WebView.cpp: (WebKit::WebView::setFindIndicator):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): (WebKit::WebPage::drawPagesToPDF):
- WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::platformPreferencesDidChange):
- config.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect):
- DumpRenderTree/config.h:
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
- TestWebKitAPI/PlatformWebView.h:
- WebKitTestRunner/config.h:
- WebKitTestRunner/win/TestInvocationWin.cpp:
