Timeline
Apr 18, 2011:
- 10:44 PM Changeset in webkit [84225] by
-
- 8 edits in trunk/Source/WebCore
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Makes SVG shadow roots and DOM shadow roots distinct.
https://bugs.webkit.org/show_bug.cgi?id=52788
Not a functional change. Covered by existing SVG tests.
- dom/EventDispatcher.cpp: (WebCore::findElementInstance): (WebCore::EventDispatcher::adjustToShadowBoundaries): (WebCore::EventDispatcher::adjustRelatedTarget): (WebCore::EventDispatcher::ensureEventAncestors):
- dom/Node.cpp: (WebCore::Node::setShadowHost): (WebCore::Node::svgShadowHost): (WebCore::Node::shadowTreeRootNode):
- dom/Node.h: (WebCore::Node::isSVGShadowRoot): (WebCore::Node::parentNode): (WebCore::Node::parentNodeGuaranteedHostFree):
- rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer): (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
- rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): (WebCore::SVGShadowTreeRootElement::create): (WebCore::SVGShadowTreeRootElement::attachElement): (WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
- rendering/svg/SVGShadowTreeElements.h: (WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
- 10:36 PM Changeset in webkit [84224] by
-
- 55 edits2 moves in trunk
2011-04-18 Taiju TSUIKI <develop@tzik.jp>
Reviewed by Darin Fisher.
Vendor-prefix requestFileSystem in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=58517
Prefix from:
- window.requestFileSystem to window.webkitRequestFileSystem
- window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
- window.Flags to window.WebKitFlags
- WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
- WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
- WorkerContext.Flags to WorkerContext.WebKitFlags
- fast/dom/script-tests/prototype-inheritance.js:
- fast/filesystem/flags-passing-expected.txt:
- fast/filesystem/resources/async-operations.js:
- fast/filesystem/resources/directory-entry-to-uri.js:
- fast/filesystem/resources/file-entry-to-uri-sync.js:
- fast/filesystem/resources/file-entry-to-uri.js:
- fast/filesystem/resources/file-from-file-entry-sync.js:
- fast/filesystem/resources/file-from-file-entry.js:
- fast/filesystem/resources/file-writer-sync-truncate-extend.js:
- fast/filesystem/resources/file-writer-sync-write-overlapped.js:
- fast/filesystem/resources/file-writer-utils.js:
- fast/filesystem/resources/fs-worker-common.js:
- fast/filesystem/resources/op-tests-helper.js:
- fast/filesystem/resources/simple-persistent-sync.js:
- fast/filesystem/resources/simple-persistent.js:
- fast/filesystem/resources/simple-temporary-sync.js:
- fast/filesystem/resources/simple-temporary.js:
- fast/filesystem/resources/sync-operations.js:
- fast/filesystem/script-tests/filesystem-reference.js:
- fast/filesystem/script-tests/flags-passing.js:
- fast/filesystem/script-tests/read-directory.js:
- http/tests/filesystem/resolve-uri-expected.txt:
- http/tests/filesystem/script-tests/resolve-uri.js:
- http/tests/filesystem/workers/resolve-url-expected.txt:
- http/tests/filesystem/workers/script-tests/resolve-url-sync.js:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
2011-04-18 Taiju TSUIKI <develop@tzik.jp>
Reviewed by Darin Fisher.
Vendor-prefix requestFileSystem in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=58517
Prefix from:
- window.requestFileSystem to window.webkitRequestFileSystem
- window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
- window.Flags to window.WebKitFlags
- WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
- WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
- WorkerContext.Flags to WorkerContext.WebKitFlags
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags): (WebCore::JSDirectoryEntrySync::getFile): (WebCore::JSDirectoryEntrySync::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): (WebCore::V8DirectoryEntrySync::getDirectoryCallback): (WebCore::V8DirectoryEntrySync::getFileCallback):
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):
- fileapi/DOMFileSystemBase.h:
- fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::getFile): (WebCore::DirectoryEntry::getDirectory):
- fileapi/DirectoryEntry.h:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::getFile): (WebCore::DirectoryEntrySync::getDirectory):
- fileapi/DirectoryEntrySync.h:
- fileapi/DirectoryEntrySync.idl:
- fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h. (WebCore::WebKitFlags::create): (WebCore::WebKitFlags::isCreate): (WebCore::WebKitFlags::setCreate): (WebCore::WebKitFlags::isExclusive): (WebCore::WebKitFlags::setExclusive): (WebCore::WebKitFlags::WebKitFlags):
- fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestFileSystem): (WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::webkitRequestFileSystem): (WebCore::WorkerContext::webkitRequestFileSystemSync): (WebCore::WorkerContext::webkitResolveLocalFileSystemURL): (WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- 9:32 PM Changeset in webkit [84223] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Daniel Bates <dbates@rim.com>
Skip fast/events/fire-mousedown-while-pressing-mouse-button.html which is failing on
Qt Linux for now. See bug for more details.
This test was added in changeset 84217 <http://trac.webkit.org/changeset/84217>
(https://bugs.webkit.org/show_bug.cgi?id=58700).
- platform/qt/Skipped:
- 9:28 PM Changeset in webkit [84222] by
-
- 14 edits2 adds in trunk/Source/WebCore
2011-04-18 Steve Lacey <sjl@chromium.org>
Reviewed by Dimitri Glazkov.
Decouple media controls usage from implementation.
This allows each port to implement thier own controls in a different
manner to the default webkit implementation.
Convert media controls hooks to a client interface
https://bugs.webkit.org/show_bug.cgi?id=58346
No new tests as there is no functional change.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): (WebCore::HTMLMediaElement::ensureMediaControls): (WebCore::HTMLMediaElement::preDispatchEventHandler):
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): (WebCore::MediaControlPanelMuteButtonElement::create): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): (WebCore::MediaControlFullscreenButtonElement::create):
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::MediaControlRootElement): (WebCore::MediaControls::create):
- html/shadow/MediaControlRootElement.h:
- html/shadow/MediaControls.cpp: Added. (WebCore::MediaControls::MediaControls):
- html/shadow/MediaControls.h: Added. (WebCore::MediaControls::~MediaControls):
- 8:49 PM Changeset in webkit [84221] by
-
- 78 edits in trunk
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
Update pixel results for tests that draw the selection rectangle.
- platform/gtk/editing/selection/4402375-expected.checksum:
- platform/gtk/editing/selection/4402375-expected.png:
- platform/gtk/editing/selection/image-before-linebreak-expected.checksum:
- platform/gtk/editing/selection/image-before-linebreak-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-1-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-1-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-2-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-2-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
- platform/gtk/editing/selection/transformed-selection-rects-expected.checksum:
- platform/gtk/editing/selection/transformed-selection-rects-expected.png:
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.checksum:
- platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
- platform/gtk/svg/text/selection-doubleclick-expected.checksum:
- platform/gtk/svg/text/selection-doubleclick-expected.png:
- platform/gtk/svg/text/selection-tripleclick-expected.checksum:
- platform/gtk/svg/text/selection-tripleclick-expected.png:
- platform/gtk/svg/text/text-align-01-b-expected.checksum:
- platform/gtk/svg/text/text-align-01-b-expected.png:
- platform/gtk/svg/text/text-align-02-b-expected.checksum:
- platform/gtk/svg/text/text-align-02-b-expected.png:
- platform/gtk/svg/text/text-align-03-b-expected.checksum:
- platform/gtk/svg/text/text-align-03-b-expected.png:
- platform/gtk/svg/text/text-align-04-b-expected.checksum:
- platform/gtk/svg/text/text-align-04-b-expected.png:
- platform/gtk/svg/text/text-align-05-b-expected.checksum:
- platform/gtk/svg/text/text-align-05-b-expected.png:
- platform/gtk/svg/text/text-align-06-b-expected.checksum:
- platform/gtk/svg/text/text-align-06-b-expected.png:
- platform/gtk/svg/text/text-altglyph-01-b-expected.checksum:
- platform/gtk/svg/text/text-altglyph-01-b-expected.png:
- platform/gtk/svg/text/text-deco-01-b-expected.checksum:
- platform/gtk/svg/text/text-deco-01-b-expected.png:
- platform/gtk/svg/text/text-fonts-01-t-expected.checksum:
- platform/gtk/svg/text/text-fonts-01-t-expected.png:
- platform/gtk/svg/text/text-fonts-02-t-expected.checksum:
- platform/gtk/svg/text/text-fonts-02-t-expected.png:
- platform/gtk/svg/text/text-intro-05-t-expected.checksum:
- platform/gtk/svg/text/text-intro-05-t-expected.png:
- platform/gtk/svg/text/text-path-01-b-expected.checksum:
- platform/gtk/svg/text/text-path-01-b-expected.png:
- platform/gtk/svg/text/text-spacing-01-b-expected.checksum:
- platform/gtk/svg/text/text-spacing-01-b-expected.png:
- platform/gtk/svg/text/text-text-01-b-expected.checksum:
- platform/gtk/svg/text/text-text-01-b-expected.png:
- platform/gtk/svg/text/text-text-03-b-expected.checksum:
- platform/gtk/svg/text/text-text-03-b-expected.png:
- platform/gtk/svg/text/text-text-04-t-expected.checksum:
- platform/gtk/svg/text/text-text-04-t-expected.png:
- platform/gtk/svg/text/text-text-05-t-expected.checksum:
- platform/gtk/svg/text/text-text-05-t-expected.png:
- platform/gtk/svg/text/text-text-06-t-expected.checksum:
- platform/gtk/svg/text/text-text-06-t-expected.png:
- platform/gtk/svg/text/text-text-07-t-expected.checksum:
- platform/gtk/svg/text/text-text-07-t-expected.png:
- platform/gtk/svg/text/text-text-08-b-expected.checksum:
- platform/gtk/svg/text/text-text-08-b-expected.png:
- platform/gtk/svg/text/text-tref-01-b-expected.checksum:
- platform/gtk/svg/text/text-tref-01-b-expected.png:
- platform/gtk/svg/text/text-tselect-01-b-expected.checksum:
- platform/gtk/svg/text/text-tselect-01-b-expected.png:
- platform/gtk/svg/text/text-tselect-02-f-expected.checksum:
- platform/gtk/svg/text/text-tselect-02-f-expected.png:
- platform/gtk/svg/text/text-tspan-01-b-expected.checksum:
- platform/gtk/svg/text/text-tspan-01-b-expected.png:
- platform/gtk/svg/text/text-ws-01-t-expected.checksum:
- platform/gtk/svg/text/text-ws-01-t-expected.png:
- platform/gtk/svg/text/text-ws-02-t-expected.checksum:
- platform/gtk/svg/text/text-ws-02-t-expected.png:
- platform/gtk/svg/text/textPathBoundsBug-expected.checksum:
- platform/gtk/svg/text/textPathBoundsBug-expected.png:
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[GTK] Need support for dumping focus rectangles in pixel results
https://bugs.webkit.org/show_bug.cgi?id=53647
Add a support function that returns the rectangle of the current
selection in frame.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::rectangleForSelection):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Martin Robinson.
[GTK] Need support for dumping focus rectangles in pixel results
https://bugs.webkit.org/show_bug.cgi?id=53647
Dump the selection rect if it has been requested.
- DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView):
- 8:47 PM Changeset in webkit [84220] by
-
- 10 edits in trunk/Source
2011-04-18 Jia Pu <jpu@apple.com>
Reviewed by Mark Rowe.
WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798
<rdar://problem/9294938>
Use public header <AppKit/NSSpellChecker.h> instead.
- WebCoreSupport/CorrectionPanel.h:
- WebCoreSupport/CorrectionPanel.mm: (correctionIndicatorType): (CorrectionPanel::show): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebView.mm:
2011-04-18 Jia Pu <jpu@apple.com>
Reviewed by Mark Rowe.
WebKit needs to stop importing <AppKit/NSTextChecker.h>
https://bugs.webkit.org/show_bug.cgi?id=58798
<rdar://problem/9294938>
Use public header <AppKit/NSSpellChecker.h> instead.
- UIProcess/mac/CorrectionPanel.h:
- UIProcess/mac/CorrectionPanel.mm: (correctionIndicatorType): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
- UIProcess/mac/TextCheckerMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- 8:43 PM Changeset in webkit [84219] by
-
- 3 edits in trunk/Source/WebCore
2011-04-18 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add incremental decoding to WebP decoder
https://bugs.webkit.org/show_bug.cgi?id=58851
No new tests, as it's not possible for the layout test framework to
force the decoders to decode incrementally.
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::decode):
- platform/image-decoders/webp/WEBPImageDecoder.h:
- 8:39 PM Changeset in webkit [84218] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
remove tests from test_expectations.txt, as they now pass
https://bugs.webkit.org/show_bug.cgi?id=58813
- platform/chromium/test_expectations.txt:
- 8:21 PM Changeset in webkit [84217] by
-
- 3 edits2 adds in trunk
2011-04-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
pressing-and-holding another mouse button
https://bugs.webkit.org/show_bug.cgi?id=58700
Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
while pressing and holding a mouse button B, where A != B. This issue only affects builds
that enable PAN_SCROLLING.
On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
should only stop the autoscroll timer.
Test: fast/events/fire-mousedown-while-pressing-mouse-button.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
2011-04-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
pressing-and-holding another mouse button
https://bugs.webkit.org/show_bug.cgi?id=58700
Test to ensure that a mousedown event is fired when pressing a mouse button A
while pressing and holding a mouse button B, where A != B.
- fast/events/fire-mousedown-while-pressing-mouse-button-expected.txt: Added.
- fast/events/fire-mousedown-while-pressing-mouse-button.html: Added.
- 8:11 PM Changeset in webkit [84216] by
-
- 4 edits1 move in trunk/Tools
2011-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy should run the ActiveWorkItems tests
https://bugs.webkit.org/show_bug.cgi?id=58859
Also make the unit tests pass. :)
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/queue.py:
- QueueStatusServer/model/workitems.py:
- 7:21 PM Changeset in webkit [84215] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
https://bugs.webkit.org/show_bug.cgi?id=58617
<rdar://problem/9048012>
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders
- 6:40 PM Changeset in webkit [84214] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
https://bugs.webkit.org/show_bug.cgi?id=58824
<rdar://problem/9292680>
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
- 6:35 PM Changeset in webkit [84213] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
Don't cast BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=58821
BitmapImageSingleFrameSkia has isBitmap return true, but
can't be cast to a BitmapImage. Instead of using BitmapImage,
use isOpaque from SkBitmap to determine if the image has alpha.
No new tests.
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- 5:34 PM Changeset in webkit [84212] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove unneeded deprecated methods from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=58853
Remove deprecated methods
- heap/MarkStack.h:
- 5:00 PM Changeset in webkit [84211] by
-
- 4 edits in trunk/Tools
2011-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org should show trailing-days pass counts for queues
https://bugs.webkit.org/show_bug.cgi?id=58812
This lets us see if each bot is pulling its own weight or not.
Before I wrote this patch our suspicious was that one of the
cq bots was doing most of the work. Turns out they're actually
pretty even in their recent pass counts.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/index.yaml:
- QueueStatusServer/templates/queuestatus.html:
- 4:43 PM Changeset in webkit [84210] by
-
- 4 edits3 deletes in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: obsolete old threading code, part 1
https://bugs.webkit.org/show_bug.cgi?id=58752
This patch removes support for the 'old-inline' and
'old-threads' worker models, and deletes the corresponding code.
Now that the new code is stable, this stuff is no longer
necessary.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:43 PM Changeset in webkit [84209] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194
Skip fullscreen/full-screen-cancel.html (which uses eventSender.keyDown) in the WK2 tests.
- platform/mac-wk2/Skipped:
- 4:34 PM Changeset in webkit [84208] by
-
- 3 edits in trunk/Source/WebCore
If deleting the StorageTracker.db file fails, local storage is left in a strange state.
https://bugs.webkit.org/show_bug.cgi?id=58805
Reviewed by Steve Falkenburg.
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
depends on and to prevent clashes between a theoretical web page editing local storage
at the same time this method is called.
(WebCore::StorageTracker::syncDeleteAllOrigins):
If it is not possible to delete the StorageTracker.db file, empty it.
(WebCore::StorageTracker::deleteOriginOnMainThread):
Wrapper for deleteOrigin.
- storage/StorageTracker.h:
- 4:31 PM Changeset in webkit [84207] by
-
- 7 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add an --additional-drt-flag option
https://bugs.webkit.org/show_bug.cgi?id=58680
NRWT has a bunch of command line flags that exist to pass
custom flags to DRT, especially on chromium. It would be nice
if there was a generic mechanism to pass through flags so we
didn't have all the custom ones.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 4:28 PM Changeset in webkit [84206] by
-
- 14 edits2 adds in trunk
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
WKTR does not support the eventSender.keyDown() method, so use mouseDown()
in those cases that keyDown() does not exist.
- fullscreen/full-screen-test.js: (runWithKeyDown.document.addEventListener): (runWithKeyDown):
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
Add a new WKBundlePage API for Full Screen events, and move some of the implementation
of WebFullScreenManager into the new InjectedBundlePageFullScreenClient class, so that
the default behavior can be overridden by a WKBundlePageFullScreenClient.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::supportsFullScreen): Moved contents into InjectedBundlePageFullScreenClient. (WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto. (WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetFullScreenClient): Added. (WKBundlePageWillEnterFullScreenForElement): Added. (WKBundlePageDidEnterFullScreenForElement): Added. (WKBundlePageWillExitFullScreenForElement): Added. (WKBundlePageDidExitFullScreenForElement): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: Added. (WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen): Added. (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): Added. (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Added.
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Added.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleFullScreenClient): Added.
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleFullScreenClient): Added.
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: WKTR should support WebKit2 full screen APIs
https://bugs.webkit.org/show_bug.cgi?id=56318
Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
WKTR to test the LayoutTest/fullscreen/ tests.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient. (WTR::InjectedBundlePage::supportsFullScreen): Added. (WTR::InjectedBundlePage::enterFullScreenForElement): Added. (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
- 4:20 PM Changeset in webkit [84205] by
-
- 2 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=58388
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 4:11 PM Changeset in webkit [84204] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
Added back missing #include.
- bindings/js/DOMWrapperWorld.cpp:
- 4:09 PM Changeset in webkit [84203] by
-
- 2 edits in trunk/Source/WebCore
Dropping a file in a WKView (WebKit2) doesn't load the file.
https://bugs.webkit.org/show_bug.cgi?id=58842
<rdar://problem/8514409>
Reviewed by Maciej Stachowiak.
The URL string for the file contains an extra %00 at the end
that causes the network framework to fail to load the file.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):
- 4:07 PM Changeset in webkit [84202] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Maciej Stachowiak.
Re-add a null check lost in r83081
https://bugs.webkit.org/show_bug.cgi?id=58846
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getSelectedRange):
- 4:06 PM Changeset in webkit [84201] by
-
- 7 edits in trunk/Source/WebKit2
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Clean up tool-tip/status-bar confusion.
https://bugs.webkit.org/show_bug.cgi?id=58844
Tool-tips were incorrectly hooked up to the status bar text.
Chrome::setStatusbarText() now correctly causes the QWKPage::statusBarMessage() signal.
New API:
- QWKPage::toolTipChanged(const QString& toolTip) [signal]
QGraphicsWKView will automatically listen for this and set its own toolTip().
- UIProcess/API/qt/ClientImpl.cpp: (qt_wk_setStatusText):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKViewPrivate::onToolTipChanged):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::toolTipChanged): (QWKPage::QWKPage):
- UIProcess/API/qt/qwkpage.h:
- 4:02 PM Changeset in webkit [84200] by
-
- 3 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Unreviewed.
Re-land r84112. It was rolled out in r84127 but it didn't need
to be. Only r84111 actually broke things.
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:58 PM Changeset in webkit [84199] by
-
- 14 edits2 adds in trunk
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- Tools/DumpRenderTree/chromium/LayoutTestController.cpp:
- Tools/DumpRenderTree/chromium/LayoutTestController.h: Adapt to new API. Expose title direction to JS so it can be tested.
- Tools/DumpRenderTree/chromium/WebViewHost.cpp:
- Tools/DumpRenderTree/chromium/WebViewHost.h: Provide new API.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
New test that checks the directionality of the title for some
simple pages.
- fast/dom/title-directionality-expected.txt: Added.
- fast/dom/title-directionality.html: Added.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- public/WebFrameClient.h: (WebKit::WebFrameClient::didReceiveTitle): Add new param to API.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle): Pass new param in API.
2011-04-18 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] expose title direction to webkit client
https://bugs.webkit.org/show_bug.cgi?id=58823
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setTitleTextDirection): Add member and setter to let us stash the title direction at load time.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.h: Adapt to new API; push the title into layoutTestController when we receive it.
- 3:53 PM Changeset in webkit [84198] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Discovered and rubber-stamped by Stephanie Lewis.
Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>
- bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::~DOMWrapperWorld): (WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our window shells when clearing / destroying ourselves. r83990 removed this behavior for documents since there are no per-document maps anymore, but removing this behavior for window shells too was a typo.
- 3:53 PM Changeset in webkit [84197] by
-
- 4 edits in trunk/Tools
2011-04-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: don't run more processes than necessary
https://bugs.webkit.org/show_bug.cgi?id=58751
Previously NRWT would start up 1 process for each processor on
the machine by default, which was a waste if we were only
running a few shards of tests.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:44 PM Changeset in webkit [84196] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK2] Unreviewed buildfix after r84174.
- QtWebKit.pro: Missing includepath added.
- 3:44 PM Changeset in webkit [84195] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
include links to actual.png files for new pixel tests
https://bugs.webkit.org/show_bug.cgi?id=58831
Load image elements to confirm whether the files exist.
Image elements will load without being appended to the DOM.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 3:41 PM Changeset in webkit [84194] by
-
- 24 edits in trunk/Source/WebCore
2011-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
https://bugs.webkit.org/show_bug.cgi?id=58828
- WebCore.exp.in: Blah.
- bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership to JSNodeCustom, where other custom JSNode-related code goes.
(WebCore::JSDOMWrapperOwner::finalize):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
- bindings/js/DOMWrapperWorld.h: (WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner): (WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner to JSDOMWrapperOwner, to match the name of JSDOMWrapper.
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper- related functions, since there is no meaningful distinction between the two anymore -- they both use the same extensible interface.
- bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.
- bindings/js/JSDOMBinding.h: (WebCore::getInlineCachedWrapper): (WebCore::setInlineCachedWrapper): (WebCore::clearInlineCachedWrapper): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::getCachedWrapper): (WebCore::cacheWrapper): (WebCore::uncacheWrapper): (WebCore::createWrapper): (WebCore::wrap): Created a generic, extensible mechanism for creating, caching, retrieving, marking, and destroying DOM wrappers. This eliminates the difference between DOM object wrappers and DOM node wrappers, and lays the groundwork for getting rid of MarkStack::deprecatedAppend usage for marking the remainder of our DOM objects.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
- bindings/js/JSDataViewCustom.cpp: (WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): Updated for renames mentioned above.
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots): (WebCore::JSNamedNodeMapOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSNamedNodeMap::markChildren): (WebCore::toJS): Updated to use our new interface for customizing wrapper lifetime management through function overloading without using MarkStack::deprecatedAppend.
- bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): (WebCore::JSNodeOwner::finalize): (WebCore::createWrapperInline): Moved node-related code from JSDOMBinding to here. Removed special case marking code for JSNamedNodeMap because JSNamedNodeMap now knows how to maintain its own lifetime invariants.
- bindings/js/JSNodeCustom.h: (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::getInlineCachedWrapper): (WebCore::setInlineCachedWrapper): (WebCore::clearInlineCachedWrapper): (WebCore::toJS): Updated to use our new interface for customizing wrapper lifetime management through function overloading without using MarkStack::deprecatedAppend or special-case code for nodes.
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Updated for renames mentioned above.
- bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for renames mentioned above.
- dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now because it needs to provide a custom WeakHandleOwner at wrapper creation time.
- 3:32 PM Changeset in webkit [84193] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
sandbox violation for ~/Library/Dictionaries
https://bugs.webkit.org/show_bug.cgi?id=58841
<rdar://problem/9294770>
- WebProcess/com.apple.WebProcess.sb: Add to sandbox profile. No obvious harm from allowing this, though it's not 100% clear why it's needed.
- 3:28 PM Changeset in webkit [84192] by
-
- 4 edits1 move in trunk/Source/WebCore
REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58747
Rubber-stamped by Sam Weinig.
Copy the WebCore Localizable.strings file into the output directory.
- WebCore.vcproj/WebCoreGenerated.vcproj:
- WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
- WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
- WebCore.vcproj/copyInspectorFiles.cmd: Removed.
- WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.
- 3:20 PM Changeset in webkit [84191] by
-
- 2 edits in trunk/Source/WebKit/mac
Reviewed by Timothy Hatcher.
Stop using -[NSString initWithContentsOfFile:]
https://bugs.webkit.org/show_bug.cgi?id=58763
-[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
- WebView/WebView.mm:
(leakMailQuirksUserScriptContents):
(leakOutlookQuirksUserScriptContents):
- 3:16 PM Changeset in webkit [84190] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
Off by one initialising repeat callframe
https://bugs.webkit.org/show_bug.cgi?id=58838
<rdar://problem/8756810>
If the end of a callframe made for a repeat call landed on
a page boundary the following page may not have been committed
which means that the off by one could lead to a crash. However
it could only happen in this case and only on windows which is
why it was so hard to repro. Alas given the steps needed to
reproduce are such that it's not really possible to make a
testcase.
This fix makes the code a little less squirrely by not trying
to avoid the unnecessary initialisation of |this|.
- interpreter/Interpreter.cpp: (JSC::Interpreter::prepareForRepeatCall):
- 2:56 PM Changeset in webkit [84189] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
https://bugs.webkit.org/show_bug.cgi?id=57546
Disable the fullscreen VKB when testing inputFieldFocus().
- tests/qwebframe/tst_qwebframe.cpp:
- 2:51 PM Changeset in webkit [84188] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add a zoomed view for pixel results to the new results html file
https://bugs.webkit.org/show_bug.cgi?id=58827
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 2:48 PM Changeset in webkit [84187] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint
When scheduling a repaint for the plugin's widget, PluginViewQt
needs to make sure the widget's geometry is up to date. Otherwise
the paint event happens on the widget's old location.
Added a manual test.
- manual-tests/qt/plugin-painting.html: Added.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::invalidateRect):
- 2:47 PM QtWebKitFeatures21 edited by
- (diff)
- 2:44 PM Changeset in webkit [84186] by
-
- 4 edits in trunk/Source/WebCore
Fix Qt build
- 2:31 PM Changeset in webkit [84185] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 58829 - DFG JIT - Optimize add/sub immediate, multiply.
Reviewed by Geoff Garen.
Add code generation for add/subtract instruction with immediate operands
(where a child is a constant), and don't bail to non-speculative if an
integer multiple results in a +0 result (only if it should be generating -0).
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDoubleConstantWithInt32Value):
- 2:21 PM Changeset in webkit [84184] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Windows build.
- Scripts/webkit2/messages.py:
- 2:20 PM Changeset in webkit [84183] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Chang Shu <cshu@webkit.org>
Unreviewed.
Skip failed test due to r84160.
- platform/win-wk2/Skipped:
- 2:08 PM Changeset in webkit [84182] by
-
- 10 edits in trunk/Source/JavaScriptCore
Bug 58817 - DFG JIT - if speculative compilation fails, throw away code.
Reviewed by Geoff Garen.
If we detect a logical conflict, throw away generated code,
and only compile through the NonSpeculativeJIT.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::rewindToLabel):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::rewindToOffset):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchSub32):
- assembler/X86Assembler.h:
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkSpeculationChecks):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
- 2:04 PM Changeset in webkit [84181] by
-
- 10 edits1 delete in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Get rid of WebProcessProxyLegacyMessage
https://bugs.webkit.org/show_bug.cgi?id=58825
- GNUmakefile.am:
- Platform/CoreIPC/MessageID.h:
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Removed.
- UIProcess/WebProcessProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
- win/WebKit2.vcproj:
- 1:59 PM Changeset in webkit [84180] by
-
- 1 edit12 adds in trunk/LayoutTests
2011-04-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add some new tests that exercise border-drawing on split inlines.
- fast/blockflow/border-styles-vertical-lr.html: Added.
- fast/blockflow/border-styles-vertical-rl.html: Added.
- fast/borders/border-styles-split.html: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
- platform/mac/fast/borders/border-styles-split-expected.checksum: Added.
- platform/mac/fast/borders/border-styles-split-expected.png: Added.
- platform/mac/fast/borders/border-styles-split-expected.txt: Added.
- 1:46 PM Changeset in webkit [84179] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Andreas Kling <kling@webkit.org>
[Qt] DRT: Unreviewed test fix after r84168.
Dump the original request KURL for blocked access attempts.
Turns out converting it to a QUrl lower-cases the hostname.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
- 1:43 PM Changeset in webkit [84178] by
-
- 1 edit in trunk/Source/JavaScriptCore/heap/MarkStack.h
Land all of the last patch
- 1:40 PM Changeset in webkit [84177] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/Plugins/PluginInfoStore.h:
- 1:34 PM Changeset in webkit [84176] by
-
- 7 edits in trunk/Source
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
As simple as it sounds.
- runtime/JSValue.h:
- runtime/WriteBarrier.h:
2011-04-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
Replace use of DeprecatedPtr<> with Global<> as ownership rules
aren't obvious, have filed bug #58820 on seeing if this is safe.
- bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
- bridge/qt/qt_instance.h:
- 1:34 PM Styling Form Controls edited by
- (diff)
- 1:29 PM Changeset in webkit [84175] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Alejandro G. Castro <alex@igalia.com>
Skipping overhanging-tall-block.html, it is crashing in the GTK+ bots.
- platform/gtk/Skipped:
- 1:24 PM Changeset in webkit [84174] by
-
- 11 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Use the message generator for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=58815
- Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): (CoreIPC::handleMessageDelayed): Add helper functions.
- UIProcess/Plugins/PluginInfoStore.h: Mark class noncopyable.
- UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): This now takes a delayed reply.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getPluginProcessConnection): This now takes a delayed reply.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Call DelayedReply::send.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginProcessConnection): This now takes a delayed reply.
(WebKit::WebProcessProxy::didReceiveSyncMessage):
No need to handle this message here.
- UIProcess/WebProcessProxy.messages.in: Add GetPluginProcessConnection message.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Don't use deprecatedSendSync.
- 1:16 PM QtWebKitFeatures21 edited by
- (diff)
- 1:07 PM QtWebKitFeatures21 edited by
- (diff)
- 1:04 PM Changeset in webkit [84173] by
-
- 3 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Finish implementing delayed sync replies in the CoreIPC message generator
https://bugs.webkit.org/show_bug.cgi?id=58814
Put the DelayedReply function definitions in the .cpp file and fix bugs found by
actually trying to compile the generated files.
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
- 12:58 PM Changeset in webkit [84172] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=58088
- platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::convertScanline): un/premultiplies and converts a scanline of image data from/to BGRA to/from RGBA (WebCore::unpremultitplyScanline): (WebCore::premultitplyScanline): (WebCore::ImageBufferData::getData): (WebCore::ImageBufferData::putData):
- 12:49 PM Changeset in webkit [84171] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix Api tests for QWebPage on Symbian
https://bugs.webkit.org/show_bug.cgi?id=56924
Ignores the style attribute that selectedHtml() returns.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::findText):
- 12:42 PM Changeset in webkit [84170] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
Allow all log channels to be initialized from WebCoreLogLevel Windows environment variable
https://bugs.webkit.org/show_bug.cgi?id=58811
- platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): Support initializing LogResourceLoading, LogProgress, and LogFileAPI from WebCoreLogLevel Windows environment variable.
- 12:27 PM Changeset in webkit [84169] by
-
- 4 edits2 adds in trunk
2011-04-18 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
- fullscreen/full-screen-cancel-expected.txt: Added.
- fullscreen/full-screen-cancel.html: Added.
2011-04-18 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Reset fullscreen element reference when leaving fullscreen mode and some other cleanup.
Test: fullscreen/full-screen-cancel.html
- dom/Document.cpp: (WebCore::Document::Document): Remove m_isFullscreen. (WebCore::Document::webkitWillEnterFullScreenForElement): (WebCore::Document::webkitWillExitFullScreenForElement): Remove duplicate call to setAnimating(). (WebCore::Document::webkitDidExitFullScreenForElement): Reset m_fullScreenElement reference.
- dom/Document.h: (WebCore::Document::webkitIsFullScreen): Use m_fullScreenElement instead of m_isFullscreen. (WebCore::Document::webkitFullScreenKeyboardInputAllowed): Ditto.
- 12:23 PM Changeset in webkit [84168] by
-
- 4 edits in trunk
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Adam Barth.
[Qt] DRT: Unbreak redirection of http:/ URLs.
https://bugs.webkit.org/show_bug.cgi?id=58779
- platform/qt/Skipped: Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html
2011-04-18 Andreas Kling <kling@webkit.org>
Reviewed by Adam Barth.
REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
https://bugs.webkit.org/show_bug.cgi?id=58779
KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
QUrl instead to match the behavior of other ports.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
- 12:20 PM Changeset in webkit [84167] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Chris Rogers <crogers@google.com>
Unreviewed.
Update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=58810
- platform/chromium/test_expectations.txt:
- 12:18 PM Changeset in webkit [84166] by
-
- 3 edits4 adds in trunk
<rdar://problem/9282486> REGRESSION (r81992): Facebook photo tags can get cut off when moving the mouse.
https://bugs.webkit.org/show_bug.cgi?id=58500
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/repaint/text-in-relative-positioned-inline.html
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the container’s repaint rect, not
the containing block’s. This matters when the containing block is outside the RenderText’s
enclosing layer, as is the case here.
LayoutTests:
- fast/repaint/text-in-relative-positioned-inline-expected.checksum: Added.
- fast/repaint/text-in-relative-positioned-inline-expected.png: Added.
- fast/repaint/text-in-relative-positioned-inline-expected.txt: Added.
- fast/repaint/text-in-relative-positioned-inline.html: Added.
- 12:04 PM Changeset in webkit [84165] by
-
- 2 edits in trunk/Tools
2011-04-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add labels to results html page
https://bugs.webkit.org/show_bug.cgi?id=58803
-fix iframe size to be the size of the png results
-fix a bunch of aesthetic nits
-fix some incorrectly styled code
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 11:45 AM Changeset in webkit [84164] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84155.
http://trac.webkit.org/changeset/84155
https://bugs.webkit.org/show_bug.cgi?id=58802
"paintEntireContents flag is used for painting outside of the
screen. It's not the right way to fix EFL tiled backing
store." (Requested by demarchi on #webkit).
- ewk/ewk_view_tiled.c: (_ewk_view_tiled_smart_add):
- 11:16 AM Changeset in webkit [84163] by
-
- 3 edits in trunk/Source/WebCore
2011-04-15 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Speed up DrawingBuffer::reset().
https://bugs.webkit.org/show_bug.cgi?id=58706
When DrawingBuffer::reset() is called, it should not reallocate
the FBOs if the size has not changed. It should just do a glClear().
Covered by tests in fast/canvas and canvas/philip.
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): Initialize the size to -1, -1, so the size change check will work on first reset.
- platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset): If the size hasn't changed, don't resize the FBOs. Just clear the relevant buffers.
- 11:00 AM Changeset in webkit [84162] by
-
- 4 edits in branches/chromium/696/Source/WebCore
Merge 83551 - 2011-04-11 Alexey Marinichev <amarinichev@chromium.org> Reviewed by James Robinson. LayerChromium/CCLayerImpl ownership fix https://bugs.webkit.org/show_bug.cgi?id=58283 CCLayerImpl's m_owner field lifetime should match the lifetime of the corresponding LayerChromium. This change moves resetting of m_owner into LayerChromium's destructor. Tested similarly to bug 57577. * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::~LayerChromium): * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::cleanupResources): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::resetOwner):
TBR=commit-queue@webkit.org
BUG=cros 14249
- 10:56 AM QtWebKitFeatures21 edited by
- (diff)
- 10:51 AM Changeset in webkit [84161] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group resources by type in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=58796
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._frameAdded): (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.setTitles): (WebInspector.FrameTreeElement.prototype.set hovered): (WebInspector.FrameTreeElement.prototype.appendResource): (WebInspector.FrameTreeElement.prototype.appendChild): (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder): (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder.compare):
- 10:50 AM QtWebKitFeatures21 edited by
- (diff)
- 10:50 AM QtWebKitRelease21 edited by
- (diff)
- 10:41 AM Changeset in webkit [84160] by
-
- 9 edits in trunk
2011-04-18 Chang Shu <cshu@webkit.org>
Reviewed by Eric Seidel.
WebKitTestRunner needs layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=42541
Unskip passed tests.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-18 Chang Shu <cshu@webkit.org>
Reviewed by Eric Seidel.
WebKitTestRunner needs layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=42541
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: (WTR::LayoutTestController::pathToLocalResource):
- WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::pathToLocalResource):
- WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: (WTR::LayoutTestController::pathToLocalResource):
- 10:34 AM Changeset in webkit [84159] by
-
- 2 edits in trunk/Source/WebKit/win
Remove the two commands that make en.lproj and copy Localizable.strings.
Rubber-stamped by Adam Roben.
- WebKit.vcproj/WebKitLibPostBuild.cmd:
- 10:29 AM Changeset in webkit [84158] by
-
- 5 edits1 delete in trunk
Make update-webkit-localizable-strings put WebKit/win strings in WebCore
now that all localized strings in WebKit/win use WEB_UI_STRING.
Reviewed by Dan Bernstein.
Source/WebCore:
- English.lproj/Localizable.strings: Updated with strings from WebKit/win.
Source/WebKit:
- English.lproj/Localizable.strings: Removed.
Tools:
- Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
- 10:18 AM Changeset in webkit [84157] by
-
- 1 edit11 adds in trunk/LayoutTests
2011-04-18 Hao Zheng <zhenghao@chromium.org>
Reviewed by Eric Seidel.
Rebaseline 3 tests under chromium-gpu-linux port.
https://bugs.webkit.org/show_bug.cgi?id=58627
- platform/chromium-gpu-linux/fast/media: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Added.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Added.
- platform/chromium-gpu-linux/fast/repaint: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.checksum: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
- 10:14 AM Changeset in webkit [84156] by
-
- 4 edits in trunk/Source/WebCore
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Adam Barth.
REGRESSION: <progress> doesn't animate if it doesn't have value
https://bugs.webkit.org/show_bug.cgi?id=58693
The initial value of RenderProgress::m_position is accidentally same as
the indeterminate value, that makes update code on updateFromElement() skipped.
This change set unique invalid value for the initial value of m_position.
No new tests. Testing animated bar is not possible with DRT.
- html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position):
- html/HTMLProgressElement.h:
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::isDeterminate):
- 10:13 AM Changeset in webkit [84155] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-04-18 Eunsol Park <eunsol47.park@samsung.com>
Reviewed by Eric Seidel.
[EFL] Scroll doesn't work on tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=55021
Scroll doesn't work on tiled backing store, but it works on single.
If ewk_frame_paint_full_set() set True, view size return content size and scroll can't be made.
so, ewk_frame_paint_full_set() is removed from ewk_tiled_smart_add().
- ewk/ewk_view_tiled.c: (_ewk_view_tiled_smart_add):
- 10:08 AM Changeset in webkit [84154] by
-
- 3 edits in trunk/Tools
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=58755
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
- WinLauncher/PrintWebUIDelegate.cpp: Also fix various style issues (including indentation and removal of ugly C-casts).
- WinLauncher/WinLauncher.cpp:
- 9:55 AM Changeset in webkit [84153] by
-
- 3 edits in trunk/Source/WebKit2
2011-04-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Reproducible crash in Find on Page, on pages that use accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=58793
<rdar://problem/9295870>
Move the call to PageOverlay::setNeedsDisplay() back to WebPage::installPageOverlay;
it needs to be called after we've told the drawing area that a page overlay has been installed.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setPage):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay):
- 9:48 AM Changeset in webkit [84152] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
https://bugs.webkit.org/show_bug.cgi?id=58791
On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
We should guard it again RefPtr.
- html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary):
- 9:37 AM Changeset in webkit [84151] by
-
- 2 edits in trunk/Source/WebCore
CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=56124
<rdar://problem/9119036>
Reviewed by Simon Fraser.
In all stacks this is occuring when the document is kept alive by the guard ref only
and the node holding it is deleted.
As a speculative fix, clear the document stylesheets when it turns into a guard ref zombie.
This has a pretty good chance of fixing the actual bug. At minimum it will move the
crash to an earlier, more easily traceble point.
No tests, crash stacks only, no idea how to reproduce.
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
- 9:23 AM Changeset in webkit [84150] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Backspace in the Console is broken
https://bugs.webkit.org/show_bug.cgi?id=58764
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 9:13 AM Changeset in webkit [84149] by
-
- 14 edits7 adds in trunk
2011-04-18 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
LevelDB backend for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=57372
Add LevelDB wrappers to Android.mk.
- Source/Android.mk:
2011-04-18 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
LevelDB backend for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=57372
Only available behind a run-time flag. Covered by existing layout
tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/leveldb/LevelDBComparator.h: Added. (WebCore::LevelDBComparator::~LevelDBComparator):
- platform/leveldb/LevelDBDatabase.cpp: Added. (WebCore::makeSlice): (WebCore::makeLevelDBSlice): (WebCore::makeVector): (WebCore::LevelDBDatabase::LevelDBDatabase): (WebCore::LevelDBDatabase::~LevelDBDatabase): (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::newIterator):
- platform/leveldb/LevelDBDatabase.h: Added.
- platform/leveldb/LevelDBIterator.cpp: Added. (WebCore::LevelDBIterator::~LevelDBIterator): (WebCore::LevelDBIterator::LevelDBIterator): (WebCore::makeSlice): (WebCore::makeLevelDBSlice): (WebCore::LevelDBIterator::isValid): (WebCore::LevelDBIterator::seekToLast): (WebCore::LevelDBIterator::seek): (WebCore::LevelDBIterator::next): (WebCore::LevelDBIterator::prev): (WebCore::LevelDBIterator::key): (WebCore::LevelDBIterator::value):
- platform/leveldb/LevelDBIterator.h: Added.
- platform/leveldb/LevelDBSlice.h: Added. (WebCore::LevelDBSlice::LevelDBSlice): (WebCore::LevelDBSlice::~LevelDBSlice): (WebCore::LevelDBSlice::begin): (WebCore::LevelDBSlice::end):
- storage/IDBLevelDBBackingStore.cpp: (WebCore::encodeByte): (WebCore::maxIDBKey): (WebCore::minIDBKey): (WebCore::encodeInt): (WebCore::decodeInt): (WebCore::encodeVarInt): (WebCore::decodeVarInt): (WebCore::encodeString): (WebCore::decodeString): (WebCore::encodeStringWithLength): (WebCore::decodeStringWithLength): (WebCore::encodeDouble): (WebCore::decodeDouble): (WebCore::encodeIDBKey): (WebCore::decodeIDBKey): (WebCore::extractEncodedIDBKey): (WebCore::compareEncodedIDBKeys): (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::KeyPrefix::SchemaVersionKey::encode): (WebCore::KeyPrefix::MaxDatabaseIdKey::encode): (WebCore::KeyPrefix::DatabaseFreeListKey::DatabaseFreeListKey): (WebCore::KeyPrefix::DatabaseFreeListKey::decode): (WebCore::KeyPrefix::DatabaseFreeListKey::encode): (WebCore::KeyPrefix::DatabaseFreeListKey::databaseId): (WebCore::KeyPrefix::DatabaseFreeListKey::compare): (WebCore::KeyPrefix::DatabaseNameKey::decode): (WebCore::KeyPrefix::DatabaseNameKey::encode): (WebCore::KeyPrefix::DatabaseNameKey::origin): (WebCore::KeyPrefix::DatabaseNameKey::databaseName): (WebCore::KeyPrefix::DatabaseNameKey::compare): (WebCore::KeyPrefix::DatabaseMetaDataKey::encode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::decode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::encode): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::objectStoreId): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::metaDataType): (WebCore::KeyPrefix::ObjectStoreMetaDataKey::compare): (WebCore::KeyPrefix::IndexMetaDataKey::IndexMetaDataKey): (WebCore::KeyPrefix::IndexMetaDataKey::decode): (WebCore::KeyPrefix::IndexMetaDataKey::encode): (WebCore::KeyPrefix::IndexMetaDataKey::compare): (WebCore::KeyPrefix::IndexMetaDataKey::indexId): (WebCore::KeyPrefix::IndexMetaDataKey::metaDataType): (WebCore::KeyPrefix::ObjectStoreFreeListKey::ObjectStoreFreeListKey): (WebCore::KeyPrefix::ObjectStoreFreeListKey::decode): (WebCore::KeyPrefix::ObjectStoreFreeListKey::encode): (WebCore::KeyPrefix::ObjectStoreFreeListKey::objectStoreId): (WebCore::KeyPrefix::ObjectStoreFreeListKey::compare): (WebCore::KeyPrefix::IndexFreeListKey::IndexFreeListKey): (WebCore::KeyPrefix::IndexFreeListKey::decode): (WebCore::KeyPrefix::IndexFreeListKey::encode): (WebCore::KeyPrefix::IndexFreeListKey::compare): (WebCore::KeyPrefix::IndexFreeListKey::objectStoreId): (WebCore::KeyPrefix::IndexFreeListKey::indexId): (WebCore::KeyPrefix::ObjectStoreNamesKey::decode): (WebCore::KeyPrefix::ObjectStoreNamesKey::encode): (WebCore::KeyPrefix::ObjectStoreNamesKey::compare): (WebCore::KeyPrefix::ObjectStoreNamesKey::objectStoreName): (WebCore::KeyPrefix::IndexNamesKey::IndexNamesKey): (WebCore::KeyPrefix::IndexNamesKey::decode): (WebCore::KeyPrefix::IndexNamesKey::encode): (WebCore::KeyPrefix::IndexNamesKey::compare): (WebCore::KeyPrefix::IndexNamesKey::indexName): (WebCore::KeyPrefix::ObjectStoreDataKey::decode): (WebCore::KeyPrefix::ObjectStoreDataKey::encode): (WebCore::KeyPrefix::ObjectStoreDataKey::compare): (WebCore::KeyPrefix::ObjectStoreDataKey::userKey): (WebCore::KeyPrefix::ExistsEntryKey::decode): (WebCore::KeyPrefix::ExistsEntryKey::encode): (WebCore::KeyPrefix::ExistsEntryKey::compare): (WebCore::KeyPrefix::ExistsEntryKey::userKey): (WebCore::KeyPrefix::IndexDataKey::IndexDataKey): (WebCore::KeyPrefix::IndexDataKey::decode): (WebCore::KeyPrefix::IndexDataKey::encode): (WebCore::KeyPrefix::IndexDataKey::encodeMaxKey): (WebCore::KeyPrefix::IndexDataKey::compare): (WebCore::KeyPrefix::IndexDataKey::databaseId): (WebCore::KeyPrefix::IndexDataKey::objectStoreId): (WebCore::KeyPrefix::IndexDataKey::indexId): (WebCore::KeyPrefix::IndexDataKey::userKey): (WebCore::KeyPrefix::realCompare): (WebCore::KeyPrefix::compareKeys): (WebCore::KeyPrefix::compareIndexKeys): (WebCore::KeyPrefix::Comparator::compare): (WebCore::KeyPrefix::Comparator::name): (WebCore::setUpMetadata): (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore): (WebCore::IDBLevelDBBackingStore::open): (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::deleteIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::findGreatestKeyLessThan): (WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord): (WebCore::IDBLevelDBBackingStore::getObjectViaIndex): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor): (WebCore::IDBLevelDBBackingStore::createTransaction):
- storage/IDBLevelDBBackingStore.h:
- 8:59 AM Changeset in webkit [84148] by
-
- 7 edits3 adds in trunk
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for CSS-resource binding.
https://bugs.webkit.org/show_bug.cgi?id=58786
- inspector/styles/resources/styles-history.css: Added. (body):
- inspector/styles/styles-history-expecte.txt: Added.
- inspector/styles/styles-history.html: Added.
- inspector/styles/styles-source-offsets.html:
2011-04-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for CSS-resource binding.
https://bugs.webkit.org/show_bug.cgi?id=58786
Test: inspector/styles/styles-history.html
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyleSheet::setPropertyText): (WebCore::InspectorStyleSheet::toggleProperty):
- inspector/InspectorStyleSheet.h:
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.if): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.mycallback): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged): (WebInspector.CSSStyleModel.prototype.setStyleSheetText): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText):
- 8:56 AM Changeset in webkit [84147] by
-
- 5 edits in trunk
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83996.
http://trac.webkit.org/changeset/83996
https://bugs.webkit.org/show_bug.cgi?id=58790
layout test editing/selection/move-by-word-visually.html is
failing (Requested by jknotten on #webkit).
- editing/selection/move-by-word-visually-expected.txt:
- editing/selection/move-by-word-visually.html:
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83996.
http://trac.webkit.org/changeset/83996
https://bugs.webkit.org/show_bug.cgi?id=58790
layout test editing/selection/move-by-word-visually.html is
failing (Requested by jknotten on #webkit).
- editing/visible_units.cpp: (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality): (WebCore::previousWordBreakInBox): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):
- 8:32 AM Changeset in webkit [84146] by
-
- 19 edits in trunk/Source/WebKit/win
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Include <WebCore/COMPtr.h> instead of "COMPtr.h"
https://bugs.webkit.org/show_bug.cgi?id=58744
- DOMCoreClasses.cpp:
- DOMHTMLClasses.cpp:
- WebActionPropertyBag.cpp:
- WebBackForwardList.cpp:
- WebCoreSupport/WebGeolocationClient.h:
- WebDownload.h:
- WebDropSource.h:
- WebFrame.cpp:
- WebHistoryItem.cpp:
- WebIconDatabase.cpp:
- WebNavigationData.h:
- WebPreferences.cpp:
- WebResource.h:
- WebURLAuthenticationChallenge.cpp:
- WebURLAuthenticationChallengeSender.cpp:
- WebURLAuthenticationChallengeSenderCFNet.cpp:
- WebURLAuthenticationChallengeSenderCurl.cpp:
- WebView.h:
- 8:13 AM Changeset in webkit [84145] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Daniel Bates.
Modify make_names.pl to not include conditional includes unconditionally
https://bugs.webkit.org/show_bug.cgi?id=53672
Fixed conditional includes being unconditionally included.
No new tests (no change in functionality)
- dom/make_names.pl:
- Modified printJSElementIncludes() to only print unconditional element includes.
- Modified printElementIncludes() to only print unconditional element includes.
- Added printConditionalElementIncludes() which takes care of printing conditional element includes.
- 7:55 AM Changeset in webkit [84144] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-18 Jeff Miller <jeffm@apple.com>
Reviewed by Timothy Hatcher.
WKFrameLoadState should be a uint32_t to match our API conventions
https://bugs.webkit.org/show_bug.cgi?id=58785
- UIProcess/API/C/WKFrame.h: typedef WKFrameLoadState as a uint32_t and define its values as an anonymous enum.
- 7:44 AM Changeset in webkit [84143] by
-
- 3 edits4 deletes in trunk
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83803.
http://trac.webkit.org/changeset/83803
https://bugs.webkit.org/show_bug.cgi?id=58782
Caused focus rings to appear in youtube videos (Requested by
inferno-sec on #webkit).
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83803.
http://trac.webkit.org/changeset/83803
https://bugs.webkit.org/show_bug.cgi?id=58782
Caused focus rings to appear in youtube videos (Requested by
inferno-sec on #webkit).
- fast/frames/iframe-outline.html: Removed.
- platform/mac/fast/frames/iframe-outline-expected.checksum: Removed.
- platform/mac/fast/frames/iframe-outline-expected.png: Removed.
- platform/mac/fast/frames/iframe-outline-expected.txt: Removed.
- 7:25 AM Changeset in webkit [84142] by
-
- 2 edits in trunk/LayoutTests
Skip a flaky test on Windows
<http://webkit.org/b/58367> tracks the failure.
- platform/win/Skipped: Added http/tests/inspector/resource-tree-model.html.
- 7:19 AM Changeset in webkit [84141] by
-
- 3 edits in trunk/Source/WebCore
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Need a workaround for bug 58422
https://bugs.webkit.org/show_bug.cgi?id=58780
Instead of the A:before content, the link text is displayed as the A tag content.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.linkifyUncopyable): (WebInspector.StylePropertiesSection):
- inspector/front-end/inspector.css:
- 7:15 AM Changeset in webkit [84140] by
-
- 5 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline for fast/html/details-add-summary-1
https://bugs.webkit.org/show_bug.cgi?id=58783
Following changes to after changes to RenderDetailsMarker (r84039).
- platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
- 6:56 AM Changeset in webkit [84139] by
-
- 8 edits in trunk
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- platform/qt/Skipped: unskip fast/dom/HTMLKeygenElement now
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowRoot): Added.
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-18 Dominic Cooney <dominicc@chromium.org>
Reviewed by Andreas Kling.
Add layoutTestController.shadowRoot to Qt DRT.
https://bugs.webkit.org/show_bug.cgi?id=58759
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowRoot): Added.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 6:54 AM Changeset in webkit [84138] by
-
- 4 edits1 copy in trunk/Source/WebKit2
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 84017.
- GNUmakefile.am:
- Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
- Shared/gtk/NativeWebMouseEventGtk.cpp: Copied from Source/WebKit2/Shared/NativeWebMouseEvent.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::handleMouseEvent):
- 6:49 AM Changeset in webkit [84137] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after 82465.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedString):
- 6:36 AM Changeset in webkit [84136] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: TAB should not move focus from the text editor while live editing
https://bugs.webkit.org/show_bug.cgi?id=58537
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._registerShortcuts): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo): (WebInspector.TextEditorMainPanel.prototype.handleTabKeyPress): (WebInspector.TextEditorMainPanel.prototype._setCaretLocation): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._setText):
- 6:32 AM Changeset in webkit [84135] by
-
- 3 edits2 adds in trunk
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=58551
- inspector/styles/metrics-box-sizing-expected.txt: Added.
- inspector/styles/metrics-box-sizing.html: Added.
2011-04-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect content area dimensions in Metrics pane for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=58551
Test: inspector/styles/metrics-box-sizing.html
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._getPropertyValueAsPx): (WebInspector.MetricsSidebarPane.prototype._getBox): (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaWidthPx): (WebInspector.MetricsSidebarPane.prototype._update.getContentAreaHeightPx): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.startEditing): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- 5:25 AM Changeset in webkit [84134] by
-
- 4 edits in trunk/Source/WebCore
2011-04-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Database agent stops to propagate it's events after navigation.
https://bugs.webkit.org/show_bug.cgi?id=58776
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::restore):
- inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
- 5:15 AM Changeset in webkit [84133] by
-
- 2 edits12 adds2 deletes in trunk/LayoutTests
011-04-18 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium baselines for new tests.
- platform/chromium-linux/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/select-background-none-expected.png: Removed.
- platform/chromium-win/fast/forms/select-background-none-expected.png: Added.
- platform/chromium-win/fast/forms/select-background-none-expected.txt: Added.
- platform/chromium-win/fast/frames/iframe-outline-expected.png: Added.
- platform/chromium-win/fast/text/zero-font-size-expected.png: Added.
- platform/chromium-win/fast/text/zero-font-size-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:54 AM Changeset in webkit [84132] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added suppressions for shadow texts broken by r83936.
- platform/chromium/test_expectations.txt:
- 4:51 AM Changeset in webkit [84131] by
-
- 2 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Update test expectations for canvas/philip/tests/2d.gradient.interpolate.outside.html
https://bugs.webkit.org/show_bug.cgi?id=58777
Regression caused by Skia roll: Chromium r81836.
- platform/chromium/test_expectations.txt:
- 4:29 AM Changeset in webkit [84130] by
-
- 2 edits in trunk
2011-04-18 Patrick Gansterer <Patrick Gansterer>
Reviewed by Pavel Feldman.
REGRESSION (r81479): generate-inspector-idl fails on native win32
https://bugs.webkit.org/show_bug.cgi?id=58315
Disable git autocrlf for Inspector.json.
- .gitattributes:
- 4:16 AM Changeset in webkit [84129] by
-
- 89 edits1 copy1 add in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline after changes to RenderDetailsMarker (Linux, Mac) (r84039)
https://bugs.webkit.org/show_bug.cgi?id=58775
- platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
- platform/chromium-linux/fast/html/details-no-summary1-expected.png:
- platform/chromium-linux/fast/html/details-no-summary2-expected.png:
- platform/chromium-linux/fast/html/details-no-summary3-expected.png:
- platform/chromium-linux/fast/html/details-no-summary4-expected.png:
- platform/chromium-linux/fast/html/details-open-javascript-expected.png:
- platform/chromium-linux/fast/html/details-open1-expected.png:
- platform/chromium-linux/fast/html/details-open2-expected.png:
- platform/chromium-linux/fast/html/details-open3-expected.png:
- platform/chromium-linux/fast/html/details-open4-expected.png:
- platform/chromium-linux/fast/html/details-open5-expected.png:
- platform/chromium-linux/fast/html/details-open6-expected.png:
- platform/chromium-linux/fast/html/details-position-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-linux/fast/html/details-writing-mode-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-position-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png:
- platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png.
- platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
- 2:47 AM Changeset in webkit [84128] by
-
- 4 edits in trunk/Tools
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84111.
http://trac.webkit.org/changeset/84111
https://bugs.webkit.org/show_bug.cgi?id=58771
Chromium linux layout tests are broken. (Requested by loislo2
on #webkit).
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- 2:45 AM Changeset in webkit [84127] by
-
- 3 edits in trunk/Tools
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84112.
http://trac.webkit.org/changeset/84112
https://bugs.webkit.org/show_bug.cgi?id=58770
Chromium linux layout tests are broken. (Requested by loislo2
on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 2:34 AM Changeset in webkit [84126] by
-
- 2 edits in trunk/Source/WebCore
2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83968.
http://trac.webkit.org/changeset/83968
https://bugs.webkit.org/show_bug.cgi?id=58769
Breaks Backspace in Web Inspector console (Requested by
apavlov on #webkit).
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 2:27 AM Changeset in webkit [84125] by
-
- 14 edits1 copy1 add in trunk/Source/WebCore
2011-04-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce WorkerInspectorController
https://bugs.webkit.org/show_bug.cgi?id=58668
WorkerInspectorController will be owned by WorkerContext and will hold all inspector
agents and will also manage connection to the inspector frontend.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptState.cpp: (WebCore::scriptStateFromWorkerContext):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromWorkerContext):
- bindings/v8/ScriptState.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::updateCookie):
- inspector/WorkerInspectorController.cpp: Added. (WebCore::WorkerInspectorController::WorkerInspectorController): (WebCore::WorkerInspectorController::~WorkerInspectorController): (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend): (WebCore::WorkerInspectorController::dispatchMessageFromFrontend):
- inspector/WorkerInspectorController.h: Copied from Source/WebCore/bindings/js/ScriptState.h.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- workers/WorkerContext.h: (WebCore::WorkerContext::workerInspectorController):
- 2:15 AM Changeset in webkit [84124] by
-
- 90 edits in trunk/LayoutTests
2011-04-18 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline after changes to RenderDetailsMarker (r84039)
https://bugs.webkit.org/show_bug.cgi?id=58767
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-expected.png:
- platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-expected.png:
- platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-expected.png:
- platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-expected.png:
- platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-expected.png:
- platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-expected.png:
- platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-expected.png:
- platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-expected.png:
- platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-expected.png:
- platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
- platform/chromium-win/fast/html/details-no-summary1-expected.png:
- platform/chromium-win/fast/html/details-no-summary1-expected.txt:
- platform/chromium-win/fast/html/details-no-summary2-expected.png:
- platform/chromium-win/fast/html/details-no-summary2-expected.txt:
- platform/chromium-win/fast/html/details-no-summary3-expected.png:
- platform/chromium-win/fast/html/details-no-summary3-expected.txt:
- platform/chromium-win/fast/html/details-no-summary4-expected.png:
- platform/chromium-win/fast/html/details-no-summary4-expected.txt:
- platform/chromium-win/fast/html/details-open-javascript-expected.png:
- platform/chromium-win/fast/html/details-open-javascript-expected.txt:
- platform/chromium-win/fast/html/details-open1-expected.png:
- platform/chromium-win/fast/html/details-open1-expected.txt:
- platform/chromium-win/fast/html/details-open2-expected.png:
- platform/chromium-win/fast/html/details-open2-expected.txt:
- platform/chromium-win/fast/html/details-open3-expected.png:
- platform/chromium-win/fast/html/details-open3-expected.txt:
- platform/chromium-win/fast/html/details-open4-expected.png:
- platform/chromium-win/fast/html/details-open4-expected.txt:
- platform/chromium-win/fast/html/details-open5-expected.png:
- platform/chromium-win/fast/html/details-open5-expected.txt:
- platform/chromium-win/fast/html/details-open6-expected.png:
- platform/chromium-win/fast/html/details-open6-expected.txt:
- platform/chromium-win/fast/html/details-position-expected.png:
- platform/chromium-win/fast/html/details-position-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-writing-mode-expected.png:
- platform/chromium-win/fast/html/details-writing-mode-expected.txt:
- platform/chromium/test_expectations.txt:
Apr 17, 2011:
- 11:53 PM Changeset in webkit [84123] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Thierry Reding <thierry.reding@avionic-design.de>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
- dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor
on something that is not C code, and will be sent to a program
which might be confused by the linemarkers.
The linemarkers are not problematic, however, because the script
properly handles them by ignoring all lines starting with a #.
- 10:36 PM Changeset in webkit [84122] by
-
- 46 edits90 adds in trunk/LayoutTests
Update Qt specific expected files after r84039.
- platform/qt/fast/html/details-[...] : Updated.
- 10:15 PM Changeset in webkit [84121] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reviewed by Dan Bernstein.
JSC no longer builds with Clang due to -Woverloaded-virtual warning
https://bugs.webkit.org/show_bug.cgi?id=58760
Rename Structure's specificValue overload of put to putSpecificValue to avoid
Clang's warning for overloading a virtual function.
- runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::putSpecificValue):
- runtime/Structure.h:
- 9:06 PM Changeset in webkit [84120] by
-
- 14 edits in trunk/Source
<http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
<rdar://problem/9268729>
Reviewed by Dan Bernstein.
This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::ResourceRequest class in
WebCore, the WebView class in WebKit1, and the WebContext class
in WebKit2. It also removes support for the
WebKitForceHTTPPipeliningPriorityHigh user default which was not
needed.
Source/WebCore:
Run these commands if you set the user defaults previously,
replacing "BUNDLE.ID" with your application's bundle ID:
defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh
- WebCore.exp.in: Export ResourceRequest::httpPipeliningEnabled()
and ResourceRequest::setHTTPPipeliningEnabled().
- platform/network/ResourceRequestBase.h:
(WebCore::isHTTPPipeliningEnabled): Removed declaration.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::httpPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added declaration.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
to use ResourceRequest::httpPipeliningEnabled().
(WebCore::readBooleanPreference): Removed.
(WebCore::isHTTPPipeliningEnabled): Removed.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use ResourceRequest::httpPipeliningEnabled(). Removed check for
shouldForceHTTPPipeliningPriorityHigh().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
- WebView/WebViewPrivate.h:
(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
Source/WebKit2:
- UIProcess/API/C/WKContext.cpp:
(_WKContextSetHTTPPipeliningEnabled): Added.
- UIProcess/API/C/WKContextPrivate.h:
(_WKContextSetHTTPPipeliningEnabled): Added declaration.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added.
(WebKit::WebContext::httpPipeliningEnabled): Added.
- UIProcess/WebContext.h:
(WebKit::WebContext::setHTTPPipeliningEnabled): Added declaration.
(WebKit::WebContext::httpPipeliningEnabled): Added declaration.
- 7:10 PM Changeset in webkit [84119] by
-
- 7 edits in trunk
REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html
https://bugs.webkit.org/show_bug.cgi?id=58736
Reviewed by Maciej Stachowiak.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): It is enough to extend the float so
that it touches the bottom of the previous line, since RenderBlock::markLinesDirtyInBlockRange()
always dirties the line after the last one in the range.
LayoutTests:
Revert to the correct results.
- platform/chromium-win/fast/block/float/032-expected.txt:
- platform/gtk/fast/block/float/032-expected.txt:
- platform/mac/fast/block/float/032-expected.txt:
- platform/qt/fast/block/float/032-expected.txt:
- 5:10 PM Changeset in webkit [84118] by
-
- 5 edits in trunk/Source/WebKit2
2011-04-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Make more strings in WebKit2 localizable
https://bugs.webkit.org/show_bug.cgi?id=58757
- UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView menuForEvent:]):
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand):
- UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::nameForEditAction):
- UIProcess/WebEditCommandProxy.h: Use WebCore's localization macro to make more strings localizable.
- 4:58 PM Changeset in webkit [84117] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Add missing include to fix build without precompiled header.
- rendering/RenderMediaControls.cpp:
- 4:50 PM Changeset in webkit [84116] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Daniel Bates <dbates@webkit.org>
Attempt to fix the Chromium build after changeset 84110 <http://trac.webkit.org/changeset/84110>
(https://bugs.webkit.org/show_bug.cgi?id=57842).
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Rename CachedResource::LinkPrefetch to CachedResource::LinkResource.
- 4:33 PM Changeset in webkit [84115] by
-
- 1 edit in trunk/Tools/ChangeLog
2011-04-17 Daniel Bates <dbates@webkit.org>
Acknowledge Adam Barth for reviewing the patch committed in changeset
84114 <http://trac.webkit.org/changeset/84114>. And fix my email address.
- 4:27 PM Changeset in webkit [84114] by
-
- 6 edits in trunk/Tools
2011-04-17 Daniel Bates <dbates@webkit.com>
Reviewed by Eric Seidel.
webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500
Prompt for username and password when using git-svn and there aren't cached SVN credentials.
- Scripts/webkitpy/common/checkout/scm.py:
- Added mixin class SVNRepository and made both class SVN and Git inherit from it.
- Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value for argument realm; modified call sites as needed.
- Modified AuthenticationError constructor to take optional prompt_for_password argument.
- Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
- Modified Git._commit_on_branch() to take optional username and password argument.
- Modified Git.push_local_commits_to_server() to take optional username and password argument and to call has_authorization_for_realm().
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
- Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to SVN.has_authorization_for_realm().
- Scripts/webkitpy/common/net/credentials.py:
- Modified Credentials.read_credentials() to call User.prompt_password() instead of using getpass.getpass() directly.
- Scripts/webkitpy/common/system/user.py:
- Added User.prompt_password().
- Scripts/webkitpy/tool/steps/commit.py:
- Modified Commit.run() to prompt for a password if needed.
- 4:08 PM Changeset in webkit [84113] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Remove pthread dependency of GCController
https://bugs.webkit.org/show_bug.cgi?id=54833
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
- 2:49 PM Changeset in webkit [84112] by
-
- 3 edits in trunk/Tools
2011-04-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: save stderr into the layout-test-results dir
https://bugs.webkit.org/show_bug.cgi?id=58690
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 2:48 PM Changeset in webkit [84111] by
-
- 4 edits in trunk/Tools
2011-04-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: read stderr from chromium DRT separately
https://bugs.webkit.org/show_bug.cgi?id=58708
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- 2:30 PM Changeset in webkit [84110] by
-
- 13 edits4 adds in trunk
2011-04-17 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add support for link rel type "subresource"
https://bugs.webkit.org/show_bug.cgi?id=57842
Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.
During testing, I was dissapointed to see the results for the http
test below don't give the subresource priority ordering. This is
another instance of https://bugs.webkit.org/show_bug.cgi?id=49238
which I'll be working on next, and thus fix the test.
- fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
- fast/dom/HTMLLinkElement/subresource.html: Added.
- http/tests/misc/link-rel-prefetch-and-subresource-expected.txt: Added.
- http/tests/misc/link-rel-prefetch-and-subresource.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-04-17 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add support for link rel type "subresource"
https://bugs.webkit.org/show_bug.cgi?id=57842
Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.
Particularly after https://bugs.webkit.org/show_bug.cgi?id=51940
is implemented, a rel type that launches requests at an higher
priority is going to be very useful. This rel type is in the
HTML5 spec at http://wiki.whatwg.org/wiki/RelExtensions . An
expected use case will be for servers to provide subresource hints
in link headers, which will allow servers to help make the web
faster.
This feature continues my implementation of the Link header, which
we've talked about in WebKit-dev in
https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html.
Tests: fast/dom/HTMLLinkElement/subresource.html
http/tests/misc/link-rel-prefetch-and-subresource.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::onloadTimerFired): (WebCore::HTMLLinkElement::notifyFinished):
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
- loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
- loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
- loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::incrementRequestCount): (WebCore::CachedResourceLoader::decrementRequestCount):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
- 2:09 PM Changeset in webkit [84109] by
-
- 2 edits in trunk/Source/WebKit/mac
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dan Bernstein.
Assign to self in WebInspectorWindowController constructors
https://bugs.webkit.org/show_bug.cgi?id=58749
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:]):
- 1:41 PM Changeset in webkit [84108] by
-
- 4 edits2 adds in trunk/Source/WebKit
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Move WebNodeHighlighter into its own file
https://bugs.webkit.org/show_bug.cgi?id=58746
- WebKit.xcodeproj/project.pbxproj: Add WebNodeHighlighter.{h,mm}.
2011-04-17 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Move WebNodeHighlighter into its own file
https://bugs.webkit.org/show_bug.cgi?id=58746
Extract this class into its own file alongside the
other WebNodeHighlight files. In doing so do some
cleanup on WebInspectorClient removing some methods
that were never called.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): style fix.
- WebInspector/WebNodeHighlighter.h: Added.
- WebInspector/WebNodeHighlighter.mm: Added. (-[WebNodeHighlighter initWithInspectedWebView:]): call super init. (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
- 1:23 PM Changeset in webkit [84107] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=58745
Reviewed by Joseph Pecoraro.
This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
which was fixed in r83514.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
variable so named, not the top layout overflow.
- 12:42 PM April 2011 Meeting edited by
- Adding myself to shadow DOM talk (diff)
- 12:06 PM Changeset in webkit [84106] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Remove WTF_PLATFORM_SGL
https://bugs.webkit.org/show_bug.cgi?id=58743
WTF_PLATFORM_SGL and PLATFORM(SGL) are not used in the code anywhere.
- wtf/Platform.h:
- 12:03 PM Changeset in webkit [84105] by
-
- 19 edits in trunk/Source/WebCore
2011-04-17 Geoffrey Garen <ggaren@apple.com>
Strongly suggested, but not necessarily reviewed, by
Sam Weinig and Maciej Stachowiak.
Renamed DOMObject* => JSDOMWrapper*.
- bindings/js/DOMWrapperWorld.cpp: (WebCore::isObservable): (WebCore::DOMObjectHandleOwner::finalize):
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSDOMBinding.h: (WebCore::JSDOMWrapperWithGlobalPointer::globalObject): (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper):
- bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMWrapper::~JSDOMWrapper):
- bindings/js/JSDOMWrapper.h: (WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- 11:59 AM Changeset in webkit [84104] by
-
- 15 edits in trunk
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- wtf/Platform.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- config.h:
- platform/graphics/ca/TransformationMatrixCA.cpp:
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/mac/WebCoreSystemInterface.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/win/LayerTreeHostWin.cpp: (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CA) to USE(CA)
https://bugs.webkit.org/show_bug.cgi?id=58742
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 7:29 AM Changeset in webkit [84103] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Young Han Lee <joybro@company100.net>
Reviewed by Benjamin Poulain.
[Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
https://bugs.webkit.org/show_bug.cgi?id=58739
gInVertexAttributeIndex is a constant variable to point the location of
"InVertex" attribute of the vertex shaders.
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::drawTexture): (WebCore::TextureMapperGL::paintToTarget):
- 4:04 AM Changeset in webkit [84102] by
-
- 2 edits in trunk/Source/WebCore
2011-04-17 Kinuko Yasuda <kinuko@chromium.org>
Not reviewed: Fix copyright (I had submitted the file with wrong
copyright line).
- storage/StorageInfo.idl:
- 3:04 AM Changeset in webkit [84101] by
-
- 102 edits in trunk
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- wtf/Platform.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- config.h:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- loader/cache/CachedFont.cpp:
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::createImage):
- platform/FloatConversion.h:
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/BitmapImage.h:
- platform/graphics/Color.h:
- platform/graphics/DashArray.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow):
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/Image.cpp:
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.cpp:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cg/ColorCG.cpp:
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/ImageCG.cpp:
- platform/graphics/cg/ImageSourceCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/cg/PDFDocumentImage.cpp:
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/TransformationMatrixCG.cpp:
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::Painter::Painter):
- platform/graphics/chromium/PlatformCanvas.h:
- platform/graphics/chromium/PlatformImage.cpp: (WebCore::PlatformImage::updateFromImage):
- platform/graphics/opentype/OpenTypeUtilities.cpp:
- platform/graphics/transforms/AffineTransform.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/DIBPixelData.h:
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::platformInit): (WebCore::createGDIFont): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/GraphicsContextWin.cpp:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp:
- platform/image-decoders/ImageDecoder.cpp:
- platform/image-decoders/ImageDecoder.h:
- rendering/RenderObject.h:
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
- rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::applyResource):
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::reshape):
- src/GraphicsContext3DInternal.h:
- src/PlatformBridge.cpp:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- WebFrame.cpp: (WebFrame::spoolPages):
- WebFrame.h:
- WebPreferences.cpp: (WebPreferences::setFontSmoothing): (WebPreferences::setFontSmoothingContrast):
- WebView.cpp: (systemParameterChanged):
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- Shared/ShareableBitmap.h:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
- Shared/WebGraphicsContext.h:
- Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
- UIProcess/win/WebView.cpp: (WebKit::WebView::setFindIndicator):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): (WebKit::WebPage::drawPagesToPDF):
- WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::platformPreferencesDidChange):
- config.h:
2011-04-17 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect):
- DumpRenderTree/config.h:
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
- TestWebKitAPI/PlatformWebView.h:
- WebKitTestRunner/config.h:
- WebKitTestRunner/win/TestInvocationWin.cpp:
Apr 16, 2011:
- 11:29 PM Changeset in webkit [84100] by
-
- 3 edits14 adds in trunk/Source/WebKit/qt
2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Autotest got missed in the handover of the QML WebView element
https://bugs.webkit.org/show_bug.cgi?id=41449
Importing WebView QML element test cases from Qt repository. I did some
style modifications and simplifications in the original code but hopefully
without changing the behavior.
Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
issues currently are:
- pixelCache() test checked the usage of pixel cache by using a subclass of QDeclarativeWebView. We can't do that right now because this class is not exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want this kind of test.
- elementAtArea() test uses a function that is not exported. But in this case I think we should test it's user, the public method "heuristicZoom".
- tests/qdeclarativewebview/resources/basic.html: Added.
- tests/qdeclarativewebview/resources/basic.png: Added.
- tests/qdeclarativewebview/resources/basic.qml: Added.
- tests/qdeclarativewebview/resources/elements.html: Added.
- tests/qdeclarativewebview/resources/elements.qml: Added.
- tests/qdeclarativewebview/resources/forward.html: Added.
- tests/qdeclarativewebview/resources/forward.png: Added.
- tests/qdeclarativewebview/resources/javaScript.html: Added.
- tests/qdeclarativewebview/resources/javaScript.qml: Added.
- tests/qdeclarativewebview/resources/loadError.qml: Added.
- tests/qdeclarativewebview/resources/newwindows.html: Added.
- tests/qdeclarativewebview/resources/newwindows.qml: Added.
- tests/qdeclarativewebview/resources/propertychanges.qml: Added.
- tests/qdeclarativewebview/resources/sethtml.qml: Added.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: (tst_QDeclarativeWebView::tmpDir): (strippedHtml): (fileContents): (removeRecursive): (tst_QDeclarativeWebView::cleanupTestCase): (tst_QDeclarativeWebView::basicProperties): (tst_QDeclarativeWebView::elementAreaAt): (tst_QDeclarativeWebView::historyNav): (callEvaluateJavaScript): (tst_QDeclarativeWebView::javaScript): (tst_QDeclarativeWebView::loadError): (tst_QDeclarativeWebView::multipleWindows): (tst_QDeclarativeWebView::newWindowComponent): (tst_QDeclarativeWebView::newWindowParent): (tst_QDeclarativeWebView::pressGrabTime): (tst_QDeclarativeWebView::renderingEnabled): (tst_QDeclarativeWebView::setHtml): (tst_QDeclarativeWebView::settings): (tst_QDeclarativeWebView::checkNoErrors):
- tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
- 7:25 PM Changeset in webkit [84099] by
-
- 3 edits1 add in trunk/Source/WebCore
2011-04-16 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
about:blank documents in new tabs can XHR anywhere
https://bugs.webkit.org/show_bug.cgi?id=58712
Empty security origins have supposed to be low-privilege, we should
mark them as having a unique origin.
- manual-tests/about-blank-xhr.html: Added.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
- page/SecurityOrigin.h:
- 5:20 PM Changeset in webkit [84098] by
-
- 5 edits in trunk/LayoutTests
Updated results for fast/block/float/032.html after r84096. Filed http://webkit.org/b/58736 to
track this change.
- platform/chromium-win/fast/block/float/032-expected.txt:
- platform/gtk/fast/block/float/032-expected.txt:
- platform/mac/fast/block/float/032-expected.txt:
- platform/qt/fast/block/float/032-expected.txt:
- 3:51 PM Changeset in webkit [84097] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt][WK2] Unskip fast/loader/null-request-after-willSendRequest.html since
it is passing for a long time.
- platform/qt-wk2/Skipped:
- 2:59 PM Changeset in webkit [84096] by
-
- 6 edits4 adds in trunk
<rdar://problem/9190108> Crash when hiding a float
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/block/float/overhanging-tall-block.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats): Moved the call to childLogicalTop() out of the loop.
Capped the logical bottom so that we get the correct maximum.
- rendering/RenderBlock.h: Decleared appendFloatingObjectToLastLine().
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): Added. Ensures correct bookkeeping by
extending the float if needed so that it touches the line.
(WebCore::RenderBlock::layoutInlineChildren): Changed to call appendFloatingObjectToLastLine().
(WebCore::RenderBlock::checkFloatsInCleanLine): Capped the float height so the we mark the right
range of lines as dirty.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::appendFloat): Replaced the floats() accessor with this function, which
allows the creation of the vector to be combined with appending the first float.
LayoutTests:
- fast/block/float/overhanging-tall-block.html: Added.
- platform/mac/fast/block/float/overhanging-tall-block-expected.checksum: Added.
- platform/mac/fast/block/float/overhanging-tall-block-expected.png: Added.
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt: Added.
- 2:22 PM Changeset in webkit [84095] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when NPP_Write returns -1 when writing the manual stream
https://bugs.webkit.org/show_bug.cgi?id=58735
<rdar://problem/9124993>
If NPP_Write returns -1 we must cancel the stream.
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverDataToPlugin):
- 2:19 PM Changeset in webkit [84094] by
-
- 6 edits in trunk/Source/WebKit/win
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Windows should use WebCore localized strings
<rdar://problem/9119405>
https://bugs.webkit.org/show_bug.cgi?id=58733
- WebCoreSupport/WebEditorClient.cpp: (undoNameForEditAction): (WebEditorClient::registerCommandForUndo):
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
- WebURLResponse.cpp: (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): (WebURLResponse::localizedStringForStatusCode): Change to use WEB_UI_STRING.
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebPlatformStrategies.h: Remove the localization strategy in favor of using the default one.
- 2:15 PM Changeset in webkit [84093] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-16 Simon Fraser <Simon Fraser>
Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
https://bugs.webkit.org/show_bug.cgi?id=58734
Add result for new test.
- platform/mac/fast/borders/webkit-border-radius-expected.checksum: Added.
- platform/mac/fast/borders/webkit-border-radius-expected.png: Added.
- platform/mac/fast/borders/webkit-border-radius-expected.txt: Added.
- 2:13 PM Changeset in webkit [84092] by
-
- 34 edits1 add in trunk/LayoutTests
2011-04-16 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
https://bugs.webkit.org/show_bug.cgi?id=58734
Drop the -webkit prefix on border-radius in the tests, and remove -moz-border-radius,
since Firefox supports the unprefixed property now. This avoids the problem where
-moz-border-radius and -webkit-border-radius had different behaviors when given two values.
Also unprefix box-sizing for WebKit, and add a -moz prefixed version for Firefox.
Add a test that compares the behavior of -webkit-border-radius and border-radius with
two values.
- fast/borders/border-radius-circle.html:
- fast/borders/border-radius-constraints.html:
- fast/borders/border-radius-groove-01.html:
- fast/borders/border-radius-groove-02.html:
- fast/borders/border-radius-groove-03.html:
- fast/borders/border-radius-wide-border-01.html:
- fast/borders/border-radius-wide-border-02.html:
- fast/borders/border-radius-wide-border-03.html:
- fast/borders/border-radius-wide-border-04.html:
- fast/borders/borderRadiusAllStylesAllCorners.html:
- fast/borders/borderRadiusArcs01.html:
- fast/borders/borderRadiusDashed01.html:
- fast/borders/borderRadiusDashed02.html:
- fast/borders/borderRadiusDashed03.html:
- fast/borders/borderRadiusDashed04.html:
- fast/borders/borderRadiusDashed05.html:
- fast/borders/borderRadiusDashed06.html:
- fast/borders/borderRadiusDotted01.html:
- fast/borders/borderRadiusDotted02.html:
- fast/borders/borderRadiusDotted03.html:
- fast/borders/borderRadiusDotted04.html:
- fast/borders/borderRadiusDotted05.html:
- fast/borders/borderRadiusDotted06.html:
- fast/borders/borderRadiusDouble02.html:
- fast/borders/borderRadiusDouble03.html:
- fast/borders/borderRadiusDouble04.html:
- fast/borders/borderRadiusDouble05.html:
- fast/borders/borderRadiusDouble06.html:
- fast/borders/borderRadiusDouble07.html:
- fast/borders/borderRadiusDouble08.html:
- fast/borders/borderRadiusDouble09.html:
- fast/borders/borderRadiusGroove01.html:
- fast/borders/borderRadiusGroove02.html:
- fast/borders/webkit-border-radius.html: Added.
- platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-01-expected.png:
- platform/mac/fast/borders/border-radius-groove-02-expected.png:
- platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-03-expected.png:
- platform/mac/fast/borders/border-radius-inline-flow-expected.png:
- platform/mac/fast/borders/border-radius-split-inline-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-01-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
- platform/mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed02-expected.png:
- platform/mac/fast/borders/borderRadiusDashed03-expected.png:
- platform/mac/fast/borders/borderRadiusDashed04-expected.png:
- platform/mac/fast/borders/borderRadiusDashed05-expected.png:
- platform/mac/fast/borders/borderRadiusDashed06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed06-expected.png:
- platform/mac/fast/borders/borderRadiusDotted01-expected.png:
- platform/mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/mac/fast/borders/borderRadiusDotted04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted05-expected.png:
- platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/mac/fast/borders/borderRadiusDouble03-expected.png:
- platform/mac/fast/borders/borderRadiusDouble04-expected.png:
- platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble05-expected.png:
- platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble07-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble07-expected.png:
- platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble08-expected.png:
- platform/mac/fast/borders/borderRadiusDouble09-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble09-expected.png:
- platform/mac/fast/borders/borderRadiusGroove01-expected.png:
- platform/mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/mac/fast/borders/borderRadiusInset01-expected.png:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/mac/fast/borders/borderRadiusOutset01-expected.png:
- platform/mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid02-expected.png:
- platform/mac/fast/borders/borderRadiusSolid03-expected.png:
- 12:31 PM Changeset in webkit [84091] by
-
- 9 edits in trunk/Source
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Pages in the PageCache don't have the correct visited link coloring after being restored
https://bugs.webkit.org/show_bug.cgi?id=58721
- WebCore.exp.in: Add export of markPagesForVistedLinkStyleRecalc for use by WebKit2.
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
- history/CachedPage.h: (WebCore::CachedPage::markForVistedLinkStyleRecalc): Add bit, set by calling markForVistedLinkStyleRecalc, which forces a visited link style recalc when being restored.
- history/PageCache.h:
- history/PageCache.cpp: (WebCore::PageCache::markPagesForVistedLinkStyleRecalc): Mark all pages in the page cache as requiring visited link style recalc.
- page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLink): (WebCore::PageGroup::removeVisitedLinks): (WebCore::PageGroup::removeAllVisitedLinks): Set dirty bit when changing any visited link information.
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Pages in the PageCache don't have the correct visited link coloring after being restored
https://bugs.webkit.org/show_bug.cgi?id=58721
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::visitedLinkStateChanged): (WebKit::WebProcess::allVisitedLinkStateChanged): Mark all pages in the page cache as needing visited link style recalc whenever visited link information changes.
- 11:37 AM Changeset in webkit [84090] by
-
- 3 edits2 adds in trunk
2011-04-16 Leo Yang <leoyang.webkit@gmail.com>
Reviewed by Nikolas Zimmermann.
ASSERT failure when svg <use> element changes href
https://bugs.webkit.org/show_bug.cgi?id=58726
Test case to verify assertion at line 509 of SVGUseElement.cpp.
Test passes if no crash occurs in debug mode.
- svg/custom/use-crash-when-href-change-expected.txt: Added.
- svg/custom/use-crash-when-href-change.svg: Added.
2011-04-16 Leo Yang <leoyang.webkit@gmail.com>
Reviewed by Nikolas Zimmermann.
ASSERT failure when svg <use> element changes href
https://bugs.webkit.org/show_bug.cgi?id=58726
m_resourceId was not empty after the pending resource
becomes available. This will trigger the assertion at
line 509 of SVGUseElement.cpp when the <use> element's
href becomes empty or invalid.
This patch makes m_resourceId be empty after the pending
resource becomes available to avoid assertion failure.
Test: svg/custom/use-crash-when-href-change.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource):
- 3:55 AM Changeset in webkit [84089] by
-
- 2 edits in trunk
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
- Source/cmake/OptionsEfl.cmake:
- 3:37 AM Changeset in webkit [84088] by
-
- 41 edits in trunk
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
- wtf/Platform.h:
- wtf/gobject/GTypedefs.h:
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
- CMakeListsEfl.txt:
- config.h:
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/ContextShadow.h:
- platform/graphics/DashArray.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::add):
- platform/graphics/Gradient.cpp:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/ImageSource.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/cairo/DrawErrorUnderline.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cairo/ImageCairo.cpp:
- platform/graphics/gstreamer/ImageGStreamer.h:
- platform/graphics/transforms/AffineTransform.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/GraphicsContextWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintWindowedPluginIntoContext):
- rendering/RenderObject.h:
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
- WebFrame.cpp: (WebFrame::spoolPages):
- WebFrame.h:
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/config.h:
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
- WebKitTestRunner/config.h:
- 3:12 AM Changeset in webkit [84087] by
-
- 2 edits in trunk/Source/WebCore
2011-04-16 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r84033.
- platform/win/LocalizedStringsWin.cpp: (WebCore::localizedString):
- 2:33 AM Changeset in webkit [84086] by
-
- 2 edits in trunk/Tools
2011-04-16 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
show diffs+test inline in the results page
https://bugs.webkit.org/show_bug.cgi?id=58723
Put each row in it's own tbody and sort based on tbodies. That way
we can append the results to the tbody inline as another table row.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 2:02 AM Changeset in webkit [84085] by
-
- 4 edits2 adds in trunk
2011-04-16 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Tests that we do not crash when adding a list item block child
as a before child to svg text.
https://bugs.webkit.org/show_bug.cgi?id=58678
- svg/text/text-block-child-crash-expected.txt: Added.
- svg/text/text-block-child-crash.xhtml: Added.
2011-04-16 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Only allow inline child for SVG text since we cannot
handle block childs.
https://bugs.webkit.org/show_bug.cgi?id=58678
Test: svg/text/text-block-child-crash.xhtml
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::isChildAllowed):
- rendering/svg/RenderSVGText.h:
- 1:47 AM Changeset in webkit [84084] by
-
- 46 edits in trunk/LayoutTests
2011-04-16 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, new GTK+ test expectations after r84039.
- platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-1-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-expected.txt:
- platform/gtk/fast/html/details-no-summary1-expected.txt:
- platform/gtk/fast/html/details-no-summary2-expected.txt:
- platform/gtk/fast/html/details-no-summary3-expected.txt:
- platform/gtk/fast/html/details-no-summary4-expected.txt:
- platform/gtk/fast/html/details-open-javascript-expected.txt:
- platform/gtk/fast/html/details-open1-expected.txt:
- platform/gtk/fast/html/details-open2-expected.txt:
- platform/gtk/fast/html/details-open3-expected.txt:
- platform/gtk/fast/html/details-open4-expected.txt:
- platform/gtk/fast/html/details-open5-expected.txt:
- platform/gtk/fast/html/details-open6-expected.txt:
- platform/gtk/fast/html/details-position-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-expected.txt:
- platform/gtk/fast/html/details-writing-mode-expected.txt:
- 12:28 AM Changeset in webkit [84083] by
-
- 2 edits in trunk/Tools
2011-04-16 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
handle new tests in the new results html file
https://bugs.webkit.org/show_bug.cgi?id=58715
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
Apr 15, 2011:
- 11:22 PM Changeset in webkit [84082] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-15 Daniel Bates <dbates@webkit.org>
Attempt to fix the Qt Linux Release build after changeset 84064 <http://trac.webkit.org/changeset/84064>
(https://bugs.webkit.org/show_bug.cgi?id=58686).
- UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().
- 10:41 PM Changeset in webkit [84081] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84067.
http://trac.webkit.org/changeset/84067
https://bugs.webkit.org/show_bug.cgi?id=58724
qt build are failing. (Requested by loislo2 on #webkit).
- heap/MarkStack.h: (JSC::MarkStack::append):
- runtime/JSValue.h:
- runtime/WriteBarrier.h: (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::operator==):
- 10:32 PM Changeset in webkit [84080] by
-
- 7 edits in trunk
2011-04-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
- http/tests/inspector-enabled/database-open.html:
2011-04-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
- inspector/Inspector.json:
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
- inspector/InspectorDatabaseAgent.h:
- inspector/front-end/inspector.js:
- 9:40 PM Changeset in webkit [84079] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-15 John Bates <jbates@google.com>
Reviewed by Kenneth Russell.
Change WebGraphicsContext3D virtuals to pure virtuals as intended
https://bugs.webkit.org/show_bug.cgi?id=58479
- public/WebGraphicsContext3D.h:
- 9:35 PM Changeset in webkit [84078] by
-
- 2 edits in trunk/Source/WebKit/mac
2011-04-15 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
[Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
https://bugs.webkit.org/show_bug.cgi?id=58717
Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
- WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::show):
- 9:23 PM Changeset in webkit [84077] by
-
- 5 edits6 adds in trunk
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP media-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58642
These tests are adapted from the other media loading tests.
- http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/media-src-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/media-src-blocked.html: Added.
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP media-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58642
Yay HTMLMediaElement for having the exact hook we need!
Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html
http/tests/security/contentSecurityPolicy/media-src-blocked.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- Although it's tempting to add this branch to the previous if-block, that results in the wrong error message being logged to the console (covered by the "blocked" test).
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- These changes are routine.
- 8:59 PM Changeset in webkit [84076] by
-
- 2 edits in trunk/Tools
2011-04-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
old-run-webkit-tests: save the list of tests actually run to a file
https://bugs.webkit.org/show_bug.cgi?id=58692
- Scripts/old-run-webkit-tests:
- 8:40 PM Changeset in webkit [84075] by
-
- 2 edits in trunk/Tools
2011-04-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
fix MockFileSystem.abspath() on windows
https://bugs.webkit.org/show_bug.cgi?id=58713
The existing code was borked on Windows if a path was passed
in using a drive letter (e.g., "d:\foo.txt"), and would go
into an infinite recursive loop. While win paths shouldn't
normally be passed into the mock filesystem, this just
bulletproofs things a bit (note that "/foo.txt" is considered
an absolute path on windows python as well.
- Scripts/webkitpy/common/system/filesystem_mock.py:
- 8:02 PM Changeset in webkit [84074] by
-
- 3 edits in trunk/Tools
2011-04-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
show stderr files and httpd log files
https://bugs.webkit.org/show_bug.cgi?id=58714
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- 7:33 PM Changeset in webkit [84073] by
-
- 9 edits8 adds in trunk
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
Herein lies a four-way testing matrix.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.
Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
- bindings/js/ScheduledAction.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowEval):
- page/ContentSecurityPolicy.h:
- 7:26 PM Changeset in webkit [84072] by
-
- 16 edits in trunk
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
Initial draft at:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0175.html
- configure.ac:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- features.gypi:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- Scripts/build-webkit:
2011-04-15 Shishir Agrawal <shishir@chromium.org>
Reviewed by James Robinson.
Add a flag to guard Page Visibility API changes.
https://bugs.webkit.org/show_bug.cgi?id=58464
- win/tools/vsprops/FeatureDefines.vsprops:
- 7:06 PM Changeset in webkit [84071] by
-
- 4 edits in trunk/Source/WebCore
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Make plugins compile during WebKit GTK Windows build.
Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58580
- plugins/PluginView.cpp: (WebCore::PluginView::stop):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformGetValue): (WebCore::PluginView::platformStart):
- 6:53 PM Changeset in webkit [84070] by
-
- 5 edits in trunk
2011-04-15 Chang Shu <cshu@webkit.org>
Reviewed by Alexey Proskuryakov.
When a message with url embedded is added to console, the "file:" scheme
and path should be stripped.
https://bugs.webkit.org/show_bug.cgi?id=58665
Unskip passed tests.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-15 Chang Shu <cshu@webkit.org>
Reviewed by Alexey Proskuryakov.
When a message with url embedded is added to console, the "file:" scheme
and path should be stripped.
https://bugs.webkit.org/show_bug.cgi?id=58665
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent): (WTR::InjectedBundlePage::willAddMessageToConsole):
- 6:19 PM Changeset in webkit [84069] by
-
- 2 edits in trunk/Source/JavaScriptCore
Errrk! - build fix from !x86-64.
- dfg/DFGNode.h:
- 6:16 PM Changeset in webkit [84068] by
-
- 2 edits2 deletes in trunk/Source/JavaScriptCore
Revert of r83974.
JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=58716
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/tests/RunAllWtfTests.cpp: Removed.
- wtf/tests/StringTests.cpp: Removed.
- 6:11 PM Changeset in webkit [84067] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-15 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove DeprecatedPtr
https://bugs.webkit.org/show_bug.cgi?id=58718
As simple as it sounds.
- heap/MarkStack.h: (JSC::MarkStack::append):
- runtime/JSValue.h:
- runtime/WriteBarrier.h:
- 5:49 PM Changeset in webkit [84066] by
-
- 6 edits in trunk/Source/WebCore
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
https://bugs.webkit.org/show_bug.cgi?id=58512
Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
This change keeps an small refactoring on
FrameView::shouldUpdate(), which doesn't affect on the behavior.
- dom/Document.cpp:
- dom/Document.h:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::shouldUpdate):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 5:42 PM Changeset in webkit [84065] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Reduce default kernel size of SincResampler to favor better speed over quality
https://bugs.webkit.org/show_bug.cgi?id=58710
No new tests since audio API is not yet implemented.
- platform/audio/SincResampler.h:
- 5:38 PM Changeset in webkit [84064] by
-
- 22 edits in trunk
2011-04-15 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
Add takeFocus callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=58686
On Windows, we need to handle moving focus out of the web view in the client, so add a takeFocus callback to WKPageUIClient
and stop handling taking focus in the framework in WKView.mm on the Mac.
- UIProcess/API/C/WKPage.h: Added WKFocusDirection enum and takeFocus to WKPageUIClient.
- UIProcess/API/mac/PageClientImpl.h: Removed takeFocus().
- UIProcess/API/mac/PageClientImpl.mm: Removed takeFocus().
- UIProcess/API/mac/WKView.mm: Removed _takeFocus().
- UIProcess/API/mac/WKViewInternal.h: Removed _takeFocus().
- UIProcess/API/qt/ClientImpl.cpp: (qt_wk_takeFocus): Added.
- UIProcess/API/qt/ClientImpl.h: Added qt_wk_takeFocus.
- UIProcess/API/qt/qwkpage.cpp: Remove takeFocus(). (QWKPage::QWKPage): Added takeFocus() callback.
- UIProcess/PageClient.h: Removed takeFocus().
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::takeFocus): Call m_uiClient to take focus.
- UIProcess/WebPageProxy.h: Pass FocusDirection as a uint32_t to takeFocus().
- UIProcess/WebPageProxy.messages.in: Pass FocusDirection as a uint32_t in TakeFocus message.
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::takeFocus): Added.
- UIProcess/WebUIClient.h: Added takeFocus().
- UIProcess/win/WebView.cpp: Removed takeFocus(), which was never implemented on Windows.
- UIProcess/win/WebView.h: Removed takeFocus().
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::takeFocus): Pass FocusDirection as a uint32_t in TakeFocus message.
2011-04-15 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
Add takeFocus callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=58686
Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Added empty takeFocus entry.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Added empty takeFocus entry. (WTR::TestController::initialize): Added empty takeFocus entry.
- 5:37 PM Changeset in webkit [84063] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add a simple tool to gather statistics on whether functions
are completed through the new or old JIT.
Reviewed by Oliver Hunt.
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 5:33 PM Changeset in webkit [84062] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Sam Weinig.
WebKit2: Stop using deprecated NSInputManager
https://bugs.webkit.org/show_bug.cgi?id=58709
Changed all mouse related functions to give NSInputContext a chance to handle the event,
added logging. Removed -rightMouseMoved: method, which was added by accident.
- UIProcess/API/mac/WKView.mm: (-[WKView mouseMoved:]): (-[WKView mouseDown:]): (-[WKView mouseUp:]): (-[WKView mouseDragged:]):
- 5:26 PM Changeset in webkit [84061] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
These have to be defined for Windows in general, since win32 API
does not provide them.
https://bugs.webkit.org/show_bug.cgi?id=58582
- platform/graphics/WOFFFileFormat.cpp:
- 5:21 PM Changeset in webkit [84060] by
-
- 6 edits in trunk
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Adam Barth.
Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087
Added console message when X-Frame-Options headers block resource loading
- http/tests/inspector/network/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Adam Barth.
Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087
Added console message when X-Frame-Options headers block resource loading
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- 5:17 PM Changeset in webkit [84059] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Martin Robinson.
Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
test. This allows Windows build of WebKit GTK to chose the right
path.
https://bugs.webkit.org/show_bug.cgi?id=58576
- platform/FileSystem.h:
- 5:14 PM Changeset in webkit [84058] by
-
- 2 edits in trunk/Source/WebKit2
Potential crash getting a JS wrapper.
<rdar://problem/8988741>
Reviewed by Brian Weinstein.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
Ensure that we have a valid m_coreFrame, because it can be cleared by
invalidate().
- 5:05 PM Changeset in webkit [84057] by
-
- 15 edits2 copies27 adds in trunk
[Qt] QWebPage MIME type handling inconsistency with other web browsers
https://bugs.webkit.org/show_bug.cgi?id=46968
Source/WebCore:
Reviewed by Kenneth Rohde Christiansen.
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
- WebCore.pro:
- platform/network/MIMESniffing.cpp: Added.
(MagicNumbers::dataSizeNeededForImageSniffing):
(MagicNumbers::maskedCompare):
(MagicNumbers::checkSpaceOrBracket):
(MagicNumbers::compare):
(MagicNumbers::findMIMEType):
(MagicNumbers::findSimpleMIMEType):
(MagicNumbers::textOrBinaryTypeSniffingProcedure):
(MagicNumbers::unknownTypeSniffingProcedure):
(MagicNumbers::imageTypeSniffingProcedure):
(MagicNumbers::checkText):
(MagicNumbers::checkRDF):
(MagicNumbers::skipTag):
(MagicNumbers::feedTypeSniffingProcedure):
(MIMESniffer::MIMESniffer):
- platform/network/MIMESniffing.h: Added.
(MIMESniffer::dataSize):
(MIMESniffer::sniff):
(MIMESniffer::isValid):
- platform/network/NetworkingContext.h:
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::advertisedMIMEType):
(WebCore::QNetworkReplyWrapper::mimeType):
- platform/network/qt/QtMIMETypeSniffer.cpp: Added.
(QtMIMETypeSniffer::QtMIMETypeSniffer):
(QtMIMETypeSniffer::sniff):
(QtMIMETypeSniffer::trySniffing):
- platform/network/qt/QtMIMETypeSniffer.h: Added.
(QtMIMETypeSniffer::mimeType):
(QtMIMETypeSniffer::isFinished):
Source/WebKit/qt:
Reviewed by Kenneth Rohde Christiansen.
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createNetworkingContext):
- WebCoreSupport/FrameNetworkingContextQt.cpp:
(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
- WebCoreSupport/FrameNetworkingContextQt.h:
- tests/MIMESniffing/MIMESniffing.pro: Added.
- tests/MIMESniffing/TestData.h: Added.
- tests/MIMESniffing/resources.qrc: Added.
- tests/MIMESniffing/resources/application_atom+xml: Added.
- tests/MIMESniffing/resources/application_ogg: Added.
- tests/MIMESniffing/resources/application_pdf: Added.
- tests/MIMESniffing/resources/application_postscript: Added.
- tests/MIMESniffing/resources/application_rdf+xml: Added.
- tests/MIMESniffing/resources/application_rss+xml: Added.
- tests/MIMESniffing/resources/application_x-gzip: Added.
- tests/MIMESniffing/resources/application_x-rar-compressed: Added.
- tests/MIMESniffing/resources/application_zip: Added.
- tests/MIMESniffing/resources/audio_x-wave: Added.
- tests/MIMESniffing/resources/image_bmp: Added.
- tests/MIMESniffing/resources/image_gif: Added.
- tests/MIMESniffing/resources/image_jpeg: Added.
- tests/MIMESniffing/resources/image_png: Added.
- tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
- tests/MIMESniffing/resources/image_webp: Added.
- tests/MIMESniffing/resources/text_html: Added.
- tests/MIMESniffing/resources/text_xml: Added.
- tests/MIMESniffing/resources/video_webm: Added.
- tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
(tst_MIMESniffing::tst_MIMESniffing):
(errorText):
(tst_MIMESniffing::testCase1):
- tests/tests.pro:
Source/WebKit2:
Reviewed by Kenneth Rohde Christiansen.
Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::MIMESniffingEnabled):
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
LayoutTests:
Rubberstamped by Andreas Kling.
Unskipping http/tests/loading/text-content-type-with-binary-extension.html.
- platform/qt/Skipped:
- 5:03 PM Changeset in webkit [84056] by
-
- 3 edits2 adds in trunk
2011-04-15 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
input field with focus makes appendChild operation ~42x slower
https://bugs.webkit.org/show_bug.cgi?id=57059
Add performance test for cloneNode when an input field has focus.
- perf/clone-with-focus-expected.txt: Added.
- perf/clone-with-focus.html: Added.
2011-04-15 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
input field with focus makes appendChild operation ~42x slower
https://bugs.webkit.org/show_bug.cgi?id=57059
Change ContainerNode::cloneChildNodes to only disable the
deleteButtonController if the container itself (or any of its children)
is being edited. Thus avoiding a reflow in cases where it's not.
Test: perf/clone-with-focus.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
- 5:01 PM Changeset in webkit [84055] by
-
- 4 edits in trunk
2011-04-15 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
[Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
https://bugs.webkit.org/show_bug.cgi?id=44079
Remove an assert whose invariant doesn't hold.
- platform/chromium/test_expectations.txt: Re-enable test.
2011-04-15 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
[Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
https://bugs.webkit.org/show_bug.cgi?id=44079
Remove an assert whose invariant doesn't hold.
- src/FrameLoaderClientImpl.cpp:
- 4:59 PM Changeset in webkit [84054] by
-
- 4 edits in trunk/Tools
2011-04-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
only show pretty-diff/wdiff if they were generated
https://bugs.webkit.org/show_bug.cgi?id=58682
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- 4:58 PM Changeset in webkit [84053] by
-
- 23 edits8 adds in trunk
2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose unified Quota API if QUOTA build flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=58648
- src/AssertMatchingEnums.cpp: Added enum assertions.
- src/StorageInfoChromium.cpp: Made a build fix.
2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose unified Quota API if QUOTA build flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=58648
Test: storage/storageinfo-query-usage.html
- CMakeLists.txt: Added new file entries.
- DerivedSources.cpp: Added new file entries.
- DerivedSources.make: Added new file entries.
- GNUmakefile.am: Added new file entries.
- WebCore.gypi: Added new file entries.
- WebCore.vcproj/WebCore.vcproj: Added new file entries.
- WebCore.xcodeproj/project.pbxproj: Added new file entries.
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitStorageInfo): Added.
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/StorageInfo.h: Added storage type enum.
- storage/StorageInfo.idl: Added.
- storage/StorageInfoErrorCallback.idl: Added.
- storage/StorageInfoUsageCallback.idl: Added.
2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose unified Quota API if QUOTA build flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=58648
Added a layout test, also added skipped entries on platforms
where the QUOTA flag is not enabled.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- storage/script-tests/TEMPLATE.html: Added.
- storage/script-tests/storageinfo-query-usage.js: Added.
- storage/storageinfo-query-usage-expected.txt: Added.
- storage/storageinfo-query-usage.html: Added.
- 4:55 PM Changeset in webkit [84052] by
-
- 191 edits in trunk
2011-04-15 Oliver Hunt <oliver@apple.com>
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Rolling r83894 r83827 r83810 r83809 r83808 back in with
a workaround for the gcc bug seen by the gtk bots
- 4:51 PM Changeset in webkit [84051] by
-
- 2 edits in trunk/Source/WebCore
Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
http://www.webkit.org/demos/calendar.
https://bugs.webkit.org/show_bug.cgi?id=58698
Reviewed by Brian Weinstein.
- platform/win/FileSystemWin.cpp:
(WebCore::openFile):
Add breaks to the case statement.
(WebCore::directoryName):
Remove any trailing slash in directoryName. After closer inspection of all callers, it
appears the that callers do not need the trailing slash, and those that use the length do
so only to change the direction of the slashes throughout the length of the path.
- 4:47 PM Changeset in webkit [84050] by
-
- 11 edits in trunk/Source/WebCore
2011-04-15 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=52963
.) Change base class of ShadowRoot from DocumentFragment to TreeScope.
.) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
.) Merged setTreeScope() with setTreeScopeRecursively()
.) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
No new tests. (refactoring)
- dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::ContainerNode::removeBetween): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::parserAddChild):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::setDocType):
- dom/Element.h:
- dom/Node.cpp: (WebCore::Node::treeScope): (WebCore::Node::setTreeScopeRecursively):
- dom/Node.h: (WebCore::Node::document):
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::~ShadowRoot): (WebCore::ShadowRoot::nodeType): (WebCore::ShadowRoot::cloneNode): (WebCore::ShadowRoot::childTypeAllowed):
- dom/ShadowRoot.h: (WebCore::toShadowRoot):
- dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
- dom/TreeScope.h:
- rendering/RenderSlider.cpp:
- 4:38 PM Changeset in webkit [84049] by
-
- 6 edits in trunk/Source/WebCore
2011-04-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
DOM object handles are never removed from cache
https://bugs.webkit.org/show_bug.cgi?id=58707
We were trying to remove hash table items by value instead of by key.
- bindings/js/DOMWrapperWorld.cpp: (WebCore::JSNodeHandleOwner::finalize): Changed to work more like DOMObjectHandleOwner::finalize because I'm going to merge them.
(WebCore::DOMObjectHandleOwner::finalize): Remove hash table items
by key, not value. (Oops!) Use a helper function to make sure we get
this right.
- bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMObjectWrapper): Store the hash table key as our weak handle context, so we can use it at destruction time.
- bindings/js/JSDOMBinding.h: Removed unnecessary include.
- bindings/js/JSNodeCustom.h: (WebCore::cacheDOMNodeWrapper): Store the hash table key as our weak handle context, so we can use it at destruction time.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::setWrapper): Forward context parameter, to support the above.
- 4:35 PM Changeset in webkit [84048] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gavin Barraclough.
Correctly prefix symbols. Since gcc 4.5.0, Windows x64 symbols
are not prefixed by underscore anymore. This is consistent with
what MSVC does.
https://bugs.webkit.org/show_bug.cgi?id=58573
- jit/JITStubs.cpp:
- 4:33 PM WebKit Team edited by
- (diff)
- 4:10 PM Changeset in webkit [84047] by
-
- 2 edits in trunk
2011-04-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- configure.ac: bump to 1.5.0, 1.4.0 will be released from a branch and was already cut off.
- 4:03 PM Changeset in webkit [84046] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Kenneth Russell <kbr@google.com>
Unreviewed. Chromium Linux Release build fix due to unused variables.
- platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup):
- 4:02 PM Changeset in webkit [84045] by
-
- 10 edits in trunk/Source/JavaScriptCore
Bug 58705 - DFG JIT Add support for flow control (branch, jump).
Reviewed by Geoff Garen.
Add support for control flow by breaking the CodeBlock up into multiple
basic blocks, generating code for each basic block in turn through the
speculative JIT & then the non-speculative JIT.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeOffset):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
(JSC::DFG::JITCodeGenerator::addBranch):
(JSC::DFG::JITCodeGenerator::linkBranches):
(JSC::DFG::JITCodeGenerator::BranchRecord::BranchRecord):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::takenBytecodeOffset):
(JSC::DFG::Node::notTakenBytecodeOffset):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGNonSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
- 3:56 PM Changeset in webkit [84044] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build change after r83945.
New 'PlatformPathCairo.cpp' was not added to the WinCairo build.
- WebCore.vcproj/WebCore.vcproj: Add missing file to WinCairo build. Exclude for standard Apple build.
- 3:54 PM Changeset in webkit [84043] by
-
- 3 edits in trunk/Source/WebKit2
Add API to get the bundle page overlay fade in fraction.
Reviewed by Sam Weinig.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlayFractionFadedIn):
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
- 3:44 PM April 2011 Meeting edited by
- (diff)
- 3:31 PM Changeset in webkit [84042] by
-
- 5 edits in trunk/Source
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fade the find page overlay
https://bugs.webkit.org/show_bug.cgi?id=58697
Add a symbol that WebKit2 needs.
- WebCore.exp.in:
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fade the find page overlay
https://bugs.webkit.org/show_bug.cgi?id=58697
- WebProcess/WebPage/FindController.cpp: Make the color components floats.
(WebKit::overlayBackgroundColor):
(WebKit::holeShadowColor):
(WebKit::holeFillColor):
Add helper functions for returning the colors given the fraction faded in.
(WebKit::FindController::drawRect):
Use the new helper functions.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Start the fade animation unless we're replacing an already existing page overlay with another.
- 3:30 PM Changeset in webkit [84041] by
-
- 7 edits in trunk/Source/JavaScriptCore
Bug 58701 - DFG JIT - add GetLocal/SetLocal nodes
Reviewed by Geoff Garen.
Use these for both access to arguments & local variables, adds ability
to set locals, such that values will persist between basic blocks.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::VariableRecord::VariableRecord):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::derefChildren):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::local):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:17 PM Changeset in webkit [84040] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-04-15 Andreas Kling <kling@webkit.org>
Unreviewed, remove a Qt-specific expectation that's no longer needed.
- platform/qt/Skipped:
- platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Removed.
- 2:56 PM Changeset in webkit [84039] by
-
- 154 edits2 adds4 deletes in trunk
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
RenderDetailsMarker should belong to shadow element.
https://bugs.webkit.org/show_bug.cgi?id=58591
- Render tree structure has changed.
- Changed style rule on details-writing-mode.html to avoid to hit shadow CSS leak bug.
- fast/html/details-writing-mode.html:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.checksum:
- platform/mac/fast/html/details-add-summary-1-expected.png:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.checksum:
- platform/mac/fast/html/details-add-summary-10-expected.png:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.checksum:
- platform/mac/fast/html/details-add-summary-2-expected.png:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.checksum:
- platform/mac/fast/html/details-add-summary-3-expected.png:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.checksum:
- platform/mac/fast/html/details-add-summary-4-expected.png:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.checksum:
- platform/mac/fast/html/details-add-summary-5-expected.png:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.checksum:
- platform/mac/fast/html/details-add-summary-6-expected.png:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.checksum:
- platform/mac/fast/html/details-add-summary-7-expected.png:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.checksum:
- platform/mac/fast/html/details-add-summary-8-expected.png:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.checksum:
- platform/mac/fast/html/details-add-summary-9-expected.png:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.checksum:
- platform/mac/fast/html/details-no-summary1-expected.png:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.checksum:
- platform/mac/fast/html/details-no-summary2-expected.png:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.checksum:
- platform/mac/fast/html/details-no-summary3-expected.png:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.checksum:
- platform/mac/fast/html/details-no-summary4-expected.png:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.checksum:
- platform/mac/fast/html/details-open-javascript-expected.png:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.checksum:
- platform/mac/fast/html/details-open1-expected.png:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.checksum:
- platform/mac/fast/html/details-open2-expected.png:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.checksum:
- platform/mac/fast/html/details-open3-expected.png:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.checksum:
- platform/mac/fast/html/details-open4-expected.png:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.checksum:
- platform/mac/fast/html/details-open5-expected.png:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.checksum:
- platform/mac/fast/html/details-open6-expected.png:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.checksum:
- platform/mac/fast/html/details-position-expected.png:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.checksum:
- platform/mac/fast/html/details-remove-summary-1-expected.png:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.checksum:
- platform/mac/fast/html/details-remove-summary-2-expected.png:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.checksum:
- platform/mac/fast/html/details-remove-summary-3-expected.png:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.checksum:
- platform/mac/fast/html/details-remove-summary-4-expected.png:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.checksum:
- platform/mac/fast/html/details-remove-summary-5-expected.png:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.checksum:
- platform/mac/fast/html/details-remove-summary-6-expected.png:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.checksum:
- platform/mac/fast/html/details-writing-mode-expected.png:
- platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-15 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
RenderDetailsMarker should belong to shadow element.
https://bugs.webkit.org/show_bug.cgi?id=58591
- Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker.
- Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout. Note that marker size is given via style for -webkit-details-marker pseudo class.
- Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement. Now RenderDetails knows nothing about default summary.
- Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of <summary>, and the clickable area is now <summary> itself.
- Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/html.css: (summary::-webkit-details-marker):
- dom/Element.cpp: (WebCore::Element::attach):
- dom/Node.cpp: (WebCore::shouldCreateRendererFor):
- dom/Node.h: (WebCore::Node::canHaveLightChildRendererWithShadow):
- html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::findSummaryFor): (WebCore::HTMLDetailsElement::findMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree): (WebCore::HTMLDetailsElement::childrenChanged): (WebCore::HTMLDetailsElement::finishParsingChildren): (WebCore::HTMLDetailsElement::toggleOpen):
- html/HTMLDetailsElement.h: (WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow):
- html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree): (WebCore::HTMLSummaryElement::detailsElement): (WebCore::HTMLSummaryElement::isMainSummary): (WebCore::HTMLSummaryElement::defaultEventHandler):
- html/HTMLSummaryElement.h: (WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow):
- html/shadow/DetailsMarkerControl.cpp: Added. (WebCore::DetailsMarkerControl::DetailsMarkerControl): (WebCore::DetailsMarkerControl::createRenderer): (WebCore::DetailsMarkerControl::rendererIsNeeded): (WebCore::DetailsMarkerControl::shadowPseudoId): (WebCore::DetailsMarkerControl::summaryElement):
- html/shadow/DetailsMarkerControl.h: Added. (WebCore::DetailsMarkerControl::create):
- rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::styleDidChange): (WebCore::RenderDetails::moveSummaryToContents): (WebCore::RenderDetails::checkMainSummary): (WebCore::RenderDetails::layout):
- rendering/RenderDetails.h:
- rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): (WebCore::RenderDetailsMarker::isOpen): (WebCore::RenderDetailsMarker::getPath): (WebCore::RenderDetailsMarker::paint): (WebCore::RenderDetailsMarker::details):
- rendering/RenderDetailsMarker.h:
- 2:52 PM Changeset in webkit [84038] by
-
- 1 edit2 copies in branches/chromium/696
Merge 83862 - 2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
- fast/speech/input-readonly-and-disabled-expected.txt: Added.
- fast/speech/input-readonly-and-disabled.html: Added.
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
Test: fast/speech/input-readonly-and-disabled.html
- html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
- 2:45 PM Changeset in webkit [84037] by
-
- 4 edits in trunk/Source/JavaScriptCore
Bug 58696 - DFG JIT split handling of vars/temporaries
Reviewed by Sam Weinig.
Presently all callee registers are treated as having single block scope,
since the DFG JIT can only compile single block functions. In order to
expand the JIT to support control flow we will need to change to retaining
locals (but not temporaries) across basic block boundaries.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getTemporary):
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::getInt32Constant):
(JSC::DFG::ByteCodeParser::getDoubleConstant):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
- dfg/DFGNode.h:
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
- 2:44 PM Changeset in webkit [84036] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build.
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::fadeAnimationTimerFired):
- 2:44 PM Changeset in webkit [84035] by
-
- 19 edits4 adds in trunk/LayoutTests
2011-04-15 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, update baselines for compositing changes.
https://bugs.webkit.org/show_bug.cgi?id=57113
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.png: Added.
- platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.png: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium/test_expectations.txt:
- 2:36 PM Changeset in webkit [84034] by
-
- 7 edits in trunk/Source/WebKit2
2011-04-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add the ability for PageOverlays to fade in and out
https://bugs.webkit.org/show_bug.cgi?id=58694
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageUninstallPageOverlay): WebPage::uninstallPageOverlay now takes a boolean. Default to false for now.
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::findString): Pass false to uninstallPageOverlay.
(WebKit::FindController::hideFindUI):
Pass true to uninstallPageOverlay.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::PageOverlay): Initialize new member variables.
(WebKit::PageOverlay::bounds):
Get rid of an unnecessary webPage() getter.
(WebKit::PageOverlay::setPage):
Stop the animation timer.
(WebKit::PageOverlay::startFadeInAnimation):
Update m_fractionFadedIn and call startFadeAnimation.
(WebKit::PageOverlay::startFadeOutAnimation):
Ditto.
(WebKit::PageOverlay::startFadeAnimation):
Initialize m_fadeAnimationStartTime and start the fade animation timer.
(WebKit::PageOverlay::fadeAnimationTimerFired):
Update m_fractionFadedIn and call setNeedsDisplay().
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::uninstallPageOverlay): If fadeOut is true, tell the page overlay to start the fade out animation. When the fade animation is complete, the page overlay will uninstall itself.
- 2:18 PM Changeset in webkit [84033] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Implement localize strings for windows WebKit2
https://bugs.webkit.org/show_bug.cgi?id=58688
- platform/win/LocalizedStringsWin.cpp: (WebCore::createWebKitBundle): (WebCore::webKitBundle): (WebCore::localizedString): Add implementation of localizedString for Windows.
- 2:13 PM Changeset in webkit [84032] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixing build.
Inadvertantly checked in
Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
instead of Source/JavaScriptCore/JavaScriptCore.exp
- 1:56 PM Changeset in webkit [84031] by
-
- 2 edits in trunk/LayoutTests
2011-04-15 Andreas Kling <kling@webkit.org>
- platform/qt/Skipped:
- 1:51 PM Changeset in webkit [84030] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-15 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
https://bugs.webkit.org/show_bug.cgi?id=58677
Moved JSObjectWithGlobalObject::globalObject() to
runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
it for a performance benefit. An equivalent instance had been in
a header file before r60057.
- JavaScriptCore.exp:
- runtime/JSObjectWithGlobalObject.cpp:
- runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::globalObject):
- 1:47 PM Changeset in webkit [84029] by
-
- 19 edits in trunk/Source/WebCore
2011-04-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Some mechanical DOM wrapper cleanup
https://bugs.webkit.org/show_bug.cgi?id=58689
- WebCore.exp.in: Export!
- bindings/js/DOMWrapperWorld.cpp: (WebCore::isReachableFromDOM): Inverted the inDocument test to make the relationship of the special cases to the normal case clearer.
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper):
- bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper): (WebCore::createDOMNodeWrapper): (WebCore::getDOMNodeWrapper): Changed DOM wrapper functions to operate in terms of DOMWrapperWorlds instead of ExecStates. This is clearer, and ever-so-slightly faster.
Removed hasCachedXXX functions, now that they're unused.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
- bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::toJS):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Updated for changes above.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Removed use of hasCachedDOMObjectWrapper because XHR is almost always created and used by JavaScript, so it's simpler to just always report extra cost.
- 1:45 PM Changeset in webkit [84028] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r81262): plugins/refcount-leaks.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=56478
Unskip plugins/refcount-leaks.html on Windows because it is now
passing on release and debug.
- platform/win/Skipped:
- 1:33 PM Changeset in webkit [84027] by
-
- 4 edits in trunk/LayoutTests
2011-04-15 James Robinson <jamesr@chromium.org>
Add chromium linux expectations for direct-image-compositing.html
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium/test_expectations.txt:
- 1:25 PM Changeset in webkit [84026] by
-
- 2 edits in trunk/LayoutTests
2011-04-15 Chris Rogers <crogers@google.com>
Unreviewed.
Update test_expectations.txt with more failing fast/borders tests
https://bugs.webkit.org/show_bug.cgi?id=58685
- platform/chromium/test_expectations.txt:
- 1:11 PM Changeset in webkit [84025] by
-
- 3 edits1 delete in trunk
2011-04-15 Andreas Kling <kling@webkit.org>
Rolling out accidental part of r84010.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding):
2011-04-15 Andreas Kling <kling@webkit.org>
Rolling out accidental part of r84010.
- fast/forms/button-line-break.html: Removed.
- 1:07 PM Changeset in webkit [84024] by
-
- 2 edits in trunk/Source/WebCore
Forgot windows build fix.
- 1:01 PM Changeset in webkit [84023] by
-
- 3 edits in trunk/Source/WebCore
2011-04-15 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Yury Semikhatsky.
Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
https://bugs.webkit.org/show_bug.cgi?id=51364
The front end should not use a transparent background when
loaded as a web page (remote debugging) but should when loaded
regularly in a custom window. This adds a "remote" style class
onto the document body when the page is loaded remotely.
- inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
- inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.
- 1:01 PM Changeset in webkit [84022] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
JSLock ASSERT seen often when using the inspector for long
periods of time. We should take the JSLock whenever we
might allocate memory in the JavaScript Heap.
JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
https://bugs.webkit.org/show_bug.cgi?id=58674
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::nodeAsScriptValue): take the JSLock.
- 12:55 PM Changeset in webkit [84021] by
-
- 11 edits in trunk/Source
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make JSNodeFilterCondition handle its lifetime correctly
https://bugs.webkit.org/show_bug.cgi?id=58622
Add export
- JavaScriptCore.exp:
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make JSNodeFilterCondition handle its lifetime correctly
https://bugs.webkit.org/show_bug.cgi?id=58622
Switch over to a WeakHandle and external roots to keep the
condition value live.
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode): (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
- bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
- bindings/scripts/CodeGeneratorJS.pm:
- 12:48 PM Changeset in webkit [84020] by
-
- 1 edit2 copies in branches/chromium/696
Merge 83611
BUG=79025
- 12:46 PM Changeset in webkit [84019] by
-
- 3 edits in trunk/Source/WebKit2
Views should be made visible before painting in WM_PRINTCLIENT messages
https://bugs.webkit.org/show_bug.cgi?id=58676
<rdar://problem/9279211>
Reviewed by Adam Roben.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::onPrintClientEvent): If our view isn't currently visible set it to visible
before painting, then reset it back to not visible after painting.
(WebKit::WebView::onShowWindowEvent): Call setIsVisible instead of duplicating logic.
(WebKit::WebView::setIsVisible): Set the m_isVisible flag and call viewStateDidChange.
- UIProcess/win/WebView.h:
- 12:42 PM Changeset in webkit [84018] by
-
- 3 edits in trunk/Source/WebCore
[Qt] QNetworkReplyHandler refactoring: some adjustments
https://bugs.webkit.org/show_bug.cgi?id=57092
Reviewed by Andreas Kling.
- Removing flag m_redirected from QNetworkReplyHandler and using m_redirectionTargetUrl.isValid() instead.
- Moving flag m_responseContainsData from QNetworkReplyHandler to the reply wrapper and removing the connection of
signal metaDataChanged for m_responseContainsData to be consistent.
- Using an OwnPtr to keep the reference to the QNetworkReplyWrapper.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveReadyRead):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::release):
(WebCore::shouldIgnoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
- platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::responseContainsData):
(WebCore::QNetworkReplyWrapper::redirected):
- 12:37 PM Changeset in webkit [84017] by
-
- 13 edits4 adds in trunk/Source/WebKit2
2011-04-15 Jon Lee <jonlee@apple.com>
Reviewed by Anders Carlsson.
onClick does not function with <select> elements in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57904
<rdar://problem/9217757>
Reviewed by Anders Carlsson.
- Shared/NativeWebMouseEvent.h: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::nativeEvent):
- Shared/mac/NativeWebMouseEventMac.mm: Added. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- Shared/qt/NativeWebMouseEventQt.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- Shared/win/NativeWebMouseEventWin.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- UIProcess/API/mac/WKView.mm: (-[WKView mouseMoved:]): (-[WKView _mouseHandler:]): Pre-compiler mouse handler calls need to use the new NativeWebMouseEvent class
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mouseMoveEvent): (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseReleaseEvent): (QWKPagePrivate::mouseDoubleClickEvent):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleMouseEvent): keep track of mouse down event in order to be able to send a fake mouse up event on the select element (WebKit::WebPageProxy::currentMouseDownEvent): for access by the popup menu proxy to dispatch the fake mouse up event (WebKit::WebPageProxy::didReceiveEvent): clear out the cached mouse down event (WebKit::WebPageProxy::processDidCrash): clear out the cached events since we assume that didReceiveEvent did not called prior to the crash
- UIProcess/WebPageProxy.h:
- UIProcess/WebPopupMenuProxy.h:
- UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
- UIProcess/win/WebPopupMenuProxyWin.cpp: (WebKit::WebPopupMenuProxyWin::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
- UIProcess/win/WebView.cpp: (WebKit::WebView::onMouseEvent):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 12:34 PM Changeset in webkit [84016] by
-
- 2 edits in trunk/Source/WebCore
Chromium build fix.
- platform/SecureTextInput.h: CARBON_SECURE_INPUT_MODE no longer exists.
- 12:31 PM Changeset in webkit [84015] by
-
- 1 edit2 copies in branches/chromium/696
Merge 83699
BUG=79199
- 12:30 PM Changeset in webkit [84014] by
-
- 2 edits in trunk/Source/WebKit2
Qt build fix.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::selectionStateChanged): Wrap the variable in PLATFORM(MAC), too, as it's unused on other platforms.
- 12:25 PM Changeset in webkit [84013] by
-
- 4 edits in trunk
2011-04-15 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] DRT: Default custom policy delegate decision should be Ignore.
If layoutTestController.setCustomPolicyDelegate() is called with only
one argument, the second ("permissive") should default to false.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-04-15 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] DRT: Default custom policy delegate decision should be Ignore.
- platform/qt/Skipped: Unskip now passing tests.
- 12:25 PM Changeset in webkit [84012] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Get the right reviewer up in here.
- 12:24 PM Changeset in webkit [84011] by
-
- 8 edits in trunk/Source/WebKit2
<rdar://problem/9287880> and https://bugs.webkit.org/show_bug.cgi?id=58596
WK2: Past searches not remembered for <input type=search results="5" autosave="foo">
Reviewed by Sam Weinig.
Add SaveRecentSearches and LoadRecentSearches messages:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPageProxy.h:
Message up to the UIProcess for the save/load operations:
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
- WebProcess/WebCoreSupport/WebPopupMenu.h:
(WebKit::WebPopupMenu::page):
Save the values to disk CFPreference-style:
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
Stubbed out for non-CF platforms:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
- 12:22 PM Changeset in webkit [84010] by
-
- 5 edits1 add in trunk
2011-04-15 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] DRT: Block access to external URLs.
- platform/qt/Skipped: Unskip now passing tests.
2011-04-15 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] DRT: Block access to external URLs.
Implement the "Blocked access to external URL" behavior for Qt's DRT,
based on what other ports are doing.
Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
- 12:16 PM Changeset in webkit [84009] by
-
- 3 edits8 copies in branches/chromium/696
Merge 83787
BUG=75186
- 12:16 PM Changeset in webkit [84008] by
-
- 36 edits3 copies3 deletes in branches/chromium/696
Merge 83884 - BlobBuilder should be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=58518
Reviewed by Darin Fisher.
Source/WebCore:
Renamed BlobBuilder to WebKitBlobBuilder.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.
(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):
- fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.
(WebCore::WebKitBlobBuilder::create):
- fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
LayoutTests:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
- fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
- fast/dom/script-tests/prototype-inheritance.js:
- fast/dom/window-domurl-crash.html:
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test.html:
- fast/files/resources/read-blob-test-cases.js:
(testReadingTripleSlicedHybridBlob):
- fast/files/resources/read-common.js:
(buildBlob):
- fast/files/workers/inline-worker-via-blob-url.html:
- fast/filesystem/resources/file-writer-events.js:
(tenXBlob):
(startWrite):
- fast/filesystem/resources/file-writer-gc-blob.js:
(tenXBlob):
(startWrite):
- fast/filesystem/resources/file-writer-sync-truncate-extend.js:
- fast/filesystem/resources/file-writer-sync-write-overlapped.js:
- fast/filesystem/resources/file-writer-utils.js:
- fast/js/global-constructors-expected.txt:
- fast/js/script-tests/global-constructors.js:
- http/tests/fileapi/create-blob-url-from-data-url.html:
- http/tests/local/blob/resources/hybrid-blob-util.js:
(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):
- http/tests/security/resources/create-filesystem-file.html:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/window-domurl-crash-expected.txt:
- 12:13 PM Changeset in webkit [84007] by
-
- 3 edits8 deletes in branches/chromium/696
Revert 84004 - Merge 83787
BUG=75186
- 12:10 PM Changeset in webkit [84006] by
-
- 1 edit in branches/chromium/696/LayoutTests/fast/filesystem/resources/file-writer-utils.js
Merge 83878 - Unreviewed, fixed tests caused by r83873.
- fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
- 12:07 PM Changeset in webkit [84005] by
-
- 13 edits2 copies in branches/chromium/696
Merge 83873 - Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
https://bugs.webkit.org/show_bug.cgi?id=58496
Reviewed by Darin Fisher.
Source/WebCore:
Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.
Test: fast/files/blob-slice-test.html
- fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice):
- fileapi/Blob.h:
- fileapi/Blob.idl:
LayoutTests:
Added a new test to test the new behavior and also update all existing
tests to use the new name.
- fast/dom/Window/window-properties.html:
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test-expected.txt: Added.
- fast/files/blob-slice-test.html: Added.
- fast/files/resources/read-blob-test-cases.js:
(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):
- fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
- http/tests/local/blob/script-tests/send-hybrid-blob.js:
():
- http/tests/local/blob/script-tests/send-sliced-data-blob.js:
(runSliceTest):
- http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:
(onStableFileDrop):
(onUnstableFileDrop):
- http/tests/local/formdata/resources/send-form-data-common.js:
(testSendingFormData):
- 12:00 PM Changeset in webkit [84004] by
-
- 3 edits8 copies in branches/chromium/696
Merge 83787
BUG=75186
- 11:57 AM Changeset in webkit [84003] by
-
- 3 edits8 deletes in branches/chromium/696
Revert 84002 - Merge 83787
BUG=75186
- 11:50 AM Changeset in webkit [84002] by
-
- 3 edits8 copies in branches/chromium/696
Merge 83787
BUG=75186
- 11:47 AM Changeset in webkit [84001] by
-
- 3 edits8 deletes in branches/chromium/696
Revert 83995 - Merge 83787
BUG=75186
- 11:45 AM Changeset in webkit [84000] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Mike Reed <reed@google.com>
Reviewed by Darin Fisher.
hide unused static function when SKIA_GPU is enabled
https://bugs.webkit.org/show_bug.cgi?id=58670
No new tests. Just fixes a warning (treated as an error) when SKIA_GPU is enabled
- platform/graphics/skia/ImageSkia.cpp:
- 11:43 AM Changeset in webkit [83999] by
-
- 2 edits in trunk/LayoutTests
2011-04-15 James Robinson <jamesr@chromium.org>
Fix duplicate expectation for compositing/tiling/huge-layer-img.html on chromium mac.
- platform/chromium/test_expectations.txt:
- 11:39 AM Changeset in webkit [83998] by
-
- 9 edits12 adds in trunk
2011-04-15 Simon Fraser <Simon Fraser>
Reviewed by Beth Dakin.
Some borders with border-radius do not have rounded inner edges
https://bugs.webkit.org/show_bug.cgi?id=58457
Improve the logic used to compute the inner radii on curved
borders, to maintain borders of even thickness around the curve.
Tests: fast/borders/mixed-border-styles-radius.html
fast/borders/mixed-border-styles.html
- rendering/RenderBoxModelObject.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::computeBorderOuterRect): (WebCore::RenderBoxModelObject::computeBorderInnerRect): Two new utility functions to share some code that was in both paintBorder() and paintBoxShaadow(). getRoundedInnerBorderWithBorderWidths() now takes the outer border box as well as the inner box.
(WebCore::RenderBoxModelObject::paintBorder): Call new methods.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath): getRoundedInnerBorderWithBorderWidths() now takes the outer border box as well as the inner box.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
- rendering/style/RenderStyle.h: Compute the inner radii by starting with teh radii used for the outer box, and then shrinking them down based on the border thickness.
- 11:38 AM Changeset in webkit [83997] by
-
- 13 edits in trunk/Source
Reviewed by Dan Bernstein.
WebKit2: Password field input does not switch to ASCII-compatible source
https://bugs.webkit.org/show_bug.cgi?id=58583
<rdar://problem/9059651>
The implementation is more modern than what we have in WK1. Instead of returning a null
input context (as in non-editable content), we now set page context's properties.
- 11:31 AM Changeset in webkit [83996] by
-
- 5 edits in trunk
2011-04-13 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Continue (3rd) experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=58294
- editing/selection/move-by-word-visually-expected.txt:
- editing/selection/move-by-word-visually.html:
2011-04-13 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Continue (3rd) experiment with moving caret by word in visual order.
https://bugs.webkit.org/show_bug.cgi?id=58294
This patch along with r82588 and r83483 implements moving caret by
word in visual order.
The overall algorithm is:
- First get the InlineBox and offset of the pass-in VisiblePosition.
- Based on the position (left boundary, middle, right boundary) of the offset and the direction of the movement, look for visually adjacent word breaks. 2.1 If the offset is the minimum offset of the box,
return the rightmost word boundary in previous boxes if moving left.
return the leftmost word boundary in box and next boxes if moving right.
2.2 Similar for the case when offset is at the maximum offset of the box.
2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
or nextWordPosition based on the directionality of the box. If this word break position
is also inside the same box, return it. Otherwise (the nextWordPosition or
previousWordPosition is not in the same box or is at the box boundary), collect all the
word breaks in the box and search for the one closest to the input "offset" based on
box directionality, block directionality, and movement direction. Continue search in
adjacent boxes if needed.
Notes:
- Word boundaries are collected one box at a time. Only when a boundary that is closest to the input position (in the moving direction) is not available in current box, word boundaries in adjacent box will be collected. So, there is no need to save InlineBox in word boundaries. Instead, the word boundaries are saved as a pair (VisiblePosition, offset) to avoid recomputing VisiblePosition.
- We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block and right boundary of a word in RTL block). And word boundaries are collected using previousWordPosition() and nextWordPosition(). So when box directionality is the same as block directionality, word boundaries are collected from right to left visually in a LTR box, and word boundaries are collected from left to right visually in a RTL box. It is the other way around when box directionality is different from block directionality.
- To find the right kinds of word boundaries, we must move back and forth between words in some situations. For example, if we're moving to the right in a LTR box in LTR block, we cannot simply return nextWordPosition() because it would return the right boundary of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
- When collecting word breaks inside a box, it first computes a start position, then collect the right kind of word breaks until it reaches the end of (or beyond) the box. In the meanwhile, it might need special handling on the rightmost or leftmost position based on the directionality of the box and block. These computations do not consider the box's bidi level.
- editing/visible_units.cpp: (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBox): (WebCore::previousWordBoundaryInBox): (WebCore::nextWordBoundaryInBox): (WebCore::visuallyLastWordBoundaryInBox): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):
- 11:23 AM Changeset in webkit [83995] by
-
- 3 edits8 copies in branches/chromium/696
Merge 83787
BUG=75186
- 11:07 AM Changeset in webkit [83994] by
-
- 7 edits in trunk/Source/WebKit2
2011-04-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Rendering in <video> element appears to render quickly to catch up if it has been playing in a background tab
https://bugs.webkit.org/show_bug.cgi?id=58637
Notify AVFoundation that no one will be rendering when the view or window moves off screen.
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isViewVisible): Return false if the view's window is not visible.
- UIProcess/API/mac/WKView.mm: (-[WKView addWindowObserversForWindow:]): Observe orderOut and orderIn events. (-[WKView removeWindowObservers]): Ditto. (-[WKView _windowDidOrderOffScreen:]): Added. (-[WKView _windowDidOrderOnScreen:]): Added.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::suspendPainting): Call LayerTreeHost::pauseRendering. (WebKit::DrawingAreaImpl::resumePainting): Call LayerTreeHost::resumeRendering.
- WebProcess/WebPage/LayerTreeHost.h: (WebKit::LayerTreeHost::pauseRendering): Added stub. (WebKit::LayerTreeHost::resumeRendering): Added stub.
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: (WebKit::LayerTreeHostCAMac::pauseRendering): Added. Post a notification with our
intention to stop rendering.
(WebKit::LayerTreeHostCAMac::resumeRendering): Added. Post a notification with our
intention to start rendering.
- 11:05 AM Changeset in webkit [83993] by
-
- 161 edits4 adds in trunk/LayoutTests
2011-04-15 Simon Fraser <Simon Fraser>
Rebaseline Mac pixel results in fast/ on SnowLeopard.
- platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
- platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
- platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
- platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
- platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
- platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
- platform/mac/fast/block/basic/011-expected.checksum:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/float/float-avoidance-expected.checksum:
- platform/mac/fast/block/float/float-avoidance-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.checksum:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/positioning/auto/005-expected.checksum:
- platform/mac/fast/block/positioning/auto/005-expected.png:
- platform/mac/fast/block/positioning/auto/006-expected.checksum:
- platform/mac/fast/block/positioning/auto/006-expected.png:
- platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.checksum:
- platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.png:
- platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.checksum:
- platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.png:
- platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.checksum:
- platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.png:
- platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.checksum:
- platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.png:
- platform/mac/fast/borders/border-radius-circle-expected.checksum:
- platform/mac/fast/borders/border-radius-circle-expected.png:
- platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
- platform/mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
- platform/mac/fast/borders/svg-as-border-image-2-expected.png:
- platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
- platform/mac/fast/box-shadow/border-radius-big-expected.png:
- platform/mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
- platform/mac/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum:
- platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/mac/fast/box-shadow/spread-expected.checksum:
- platform/mac/fast/box-shadow/spread-expected.png:
- platform/mac/fast/box-shadow/spread-multiple-inset-expected.checksum:
- platform/mac/fast/box-shadow/spread-multiple-inset-expected.png:
- platform/mac/fast/box-shadow/spread-multiple-normal-expected.checksum:
- platform/mac/fast/box-shadow/spread-multiple-normal-expected.png:
- platform/mac/fast/canvas/canvas-incremental-repaint-expected.checksum:
- platform/mac/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.checksum:
- platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png:
- platform/mac/fast/canvas/drawImage-expected.checksum:
- platform/mac/fast/canvas/drawImage-expected.png:
- platform/mac/fast/canvas/webgl/css-webkit-canvas-expected.checksum:
- platform/mac/fast/canvas/webgl/css-webkit-canvas-expected.png:
- platform/mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.checksum:
- platform/mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png:
- platform/mac/fast/css/font-face-default-font-expected.checksum:
- platform/mac/fast/css/font-face-default-font-expected.png:
- platform/mac/fast/css/font_property_normal-expected.checksum:
- platform/mac/fast/css/font_property_normal-expected.png:
- platform/mac/fast/css/line-height-font-order-expected.checksum:
- platform/mac/fast/css/line-height-font-order-expected.png:
- platform/mac/fast/forms/001-expected.checksum:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.checksum:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.checksum:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/checkbox-radio-onchange-expected.checksum:
- platform/mac/fast/forms/checkbox-radio-onchange-expected.png:
- platform/mac/fast/forms/file-input-disabled-expected.checksum:
- platform/mac/fast/forms/file-input-disabled-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/formmove-expected.checksum:
- platform/mac/fast/forms/formmove-expected.png:
- platform/mac/fast/forms/formmove2-expected.checksum:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/indeterminate-expected.checksum:
- platform/mac/fast/forms/indeterminate-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.checksum:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-value-expected.checksum:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/minWidthPercent-expected.checksum:
- platform/mac/fast/forms/minWidthPercent-expected.png:
- platform/mac/fast/forms/radio-attr-order-expected.checksum:
- platform/mac/fast/forms/radio-attr-order-expected.png:
- platform/mac/fast/forms/radio-nested-labels-expected.checksum:
- platform/mac/fast/forms/radio-nested-labels-expected.png:
- platform/mac/fast/forms/radio_checked-expected.checksum:
- platform/mac/fast/forms/radio_checked-expected.png:
- platform/mac/fast/forms/radio_checked_dynamic-expected.checksum:
- platform/mac/fast/forms/radio_checked_dynamic-expected.png:
- platform/mac/fast/images/animated-svg-as-image-expected.checksum:
- platform/mac/fast/images/animated-svg-as-image-expected.png:
- platform/mac/fast/images/imagemap-case-expected.checksum:
- platform/mac/fast/images/imagemap-case-expected.png:
- platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum:
- platform/mac/fast/images/imagemap-circle-focus-ring-expected.png:
- platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum:
- platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png:
- platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum:
- platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png:
- platform/mac/fast/inline/positionedLifetime-expected.checksum:
- platform/mac/fast/inline/positionedLifetime-expected.png:
- platform/mac/fast/invalid/019-expected.checksum:
- platform/mac/fast/invalid/019-expected.png:
- platform/mac/fast/invalid/missing-address-end-tag-expected.checksum:
- platform/mac/fast/invalid/missing-address-end-tag-expected.png:
- platform/mac/fast/invalid/table-inside-stray-table-content-expected.checksum:
- platform/mac/fast/invalid/table-inside-stray-table-content-expected.png:
- platform/mac/fast/lists/003-vertical-expected.checksum:
- platform/mac/fast/lists/003-vertical-expected.png:
- platform/mac/fast/media/media-query-invalid-value-expected.checksum:
- platform/mac/fast/media/media-query-invalid-value-expected.png:
- platform/mac/fast/overflow/003-expected.checksum:
- platform/mac/fast/overflow/003-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/parser/bad-xml-slash-expected.checksum:
- platform/mac/fast/parser/bad-xml-slash-expected.png:
- platform/mac/fast/repaint/box-shadow-h-expected.checksum:
- platform/mac/fast/repaint/box-shadow-h-expected.png:
- platform/mac/fast/repaint/control-clip-expected.checksum:
- platform/mac/fast/repaint/control-clip-expected.png:
- platform/mac/fast/repaint/list-marker-expected.checksum:
- platform/mac/fast/repaint/list-marker-expected.png:
- platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum:
- platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
- platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
- platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.checksum:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/text/emphasis-vertical-expected.checksum:
- platform/mac/fast/text/emphasis-vertical-expected.png:
- platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum:
- platform/mac/fast/text/hyphenate-limit-before-after-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
- platform/mac/fast/text/international/text-combine-image-test-expected.png:
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum:
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/mac/fast/text/justify-ideograph-leading-expansion-expected.checksum:
- platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
- platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
- platform/mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
- platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/mac/fast/transforms/shadows-expected.checksum:
- platform/mac/fast/transforms/shadows-expected.png:
- 11:01 AM Changeset in webkit [83992] by
-
- 3 edits in trunk/Source/WebCore
2011-04-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash
https://bugs.webkit.org/show_bug.cgi?id=58501
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Call validateHTMLImageElement(). (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::validateHTMLImageElement): Make sure image is ready.
- html/canvas/WebGLRenderingContext.h:
- 10:57 AM Changeset in webkit [83991] by
-
- 5 edits in trunk/Source/WebCore
2011-04-07 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
DocumentMaker::AllMarkers should not be a part of DocumentMarker::MarkerType
https://bugs.webkit.org/show_bug.cgi?id=58112
- Converted DocumentMarker::MarkerTypes from unsigned int to a class.
- Converted DocumentMarker::AllMarkers from an enum entry to a subclass of MarkerTypes.
- Changed type of some MarkerType argument on DocumentMarkerController API to MarkerTypes which should allow a combination of MarkerType constansts.
- Removed some MarkerType arguments on DocumentMarkerController API which only received AllMarkers.
No new tests, no behavior change.
- WebCore.exp.in:
- dom/DocumentMarker.h: (WebCore::DocumentMarker::MarkerTypes::MarkerTypes): (WebCore::DocumentMarker::MarkerTypes::contains): (WebCore::DocumentMarker::MarkerTypes::intersects): (WebCore::DocumentMarker::MarkerTypes::operator==): (WebCore::DocumentMarker::MarkerTypes::add): (WebCore::DocumentMarker::MarkerTypes::remove): (WebCore::DocumentMarker::AllMarkers::AllMarkers):
- dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::possiblyHasMarkers): (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
- dom/DocumentMarkerController.h:
- 10:44 AM Changeset in webkit [83990] by
-
- 15 edits in trunk/Source/WebCore
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Complicated hash table is complicated
https://bugs.webkit.org/show_bug.cgi?id=58631
Now that we use the opaque roots system to track node wrapper lifetime,
we can remove a lot of complicated hash-tablery that used to do the same.
Now normal world node wrappers are just set as direct properties of
ScriptWrappable, while isolated world node wrappers and other DOM object
wrappers are stored in a shared, per-world hash table.
In addition to reducing complexity, this makes DOM wrapper allocation
1.6X faster (tested with scratch-gc-dom3.html), and it reduces the memory
footprint of normal world wrappers by ~2/3, and isolated world wrappers
by ~1/3.
- WebCore.exp.in: Paying the patch tithe.
- bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::~DOMWrapperWorld): (WebCore::DOMWrapperWorld::clearWrappers): No more per-document hash tables.
(WebCore::JSNodeHandleOwner::finalize): Changed to call a helper function,
so the code to destroy a wrapper can live next to the code to create one.
- bindings/js/DOMWrapperWorld.h: No more per-document hash tables.
- bindings/js/JSDOMBinding.cpp: (WebCore::uncacheDOMObjectWrapper):
- bindings/js/JSDOMBinding.h: (WebCore::createDOMNodeWrapper): (WebCore::getDOMNodeWrapper): No more per-document hash tables. Added uncacheDOMObjectWrapper to be symmetrical with cacheDOMObjectWrapper.
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Ditto.
- bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::uncacheDOMNodeWrapper): (WebCore::toJS): Implemented the scheme described above.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper): ScriptWrappable needs a handle owner now, since we don't have an extra handle living in a hash table to maintain ownership for us.
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
- dom/Document.h:
- dom/Node.cpp: (WebCore::Node::setDocument): No more per-document hash tables.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Removed call to hasCachedDOMNodeWrapperUnchecked because that was the old way of doing things, and I was in the mood for getting rid of the old way. It's debatable whether the check was ever a good idea. Even when a <canvas> doesn't have a direct JS wrapper, other JS references can still keep the <canvas> alive. So, it's probably best always to report extra cost.
- 10:42 AM Changeset in webkit [83989] by
-
- 1 edit5 adds in trunk/LayoutTests
DRT on Windows doesn't block access to external URLs (https://bugs.webkit.org/show_bug.cgi?id=57334),
but WKTR does, so add the expected passing results to the win-wk2 directory to override the expected
failing results in the win directory in order to get the bots green.
- platform/win-wk2/fast/ruby: Added.
- platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
- platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
- platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
- platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
- 10:41 AM Changeset in webkit [83988] by
-
- 5 edits in trunk/Source/WebKit2
WebKit2: Need a way to keep the WebProcess alive for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=58592
Reviewed by Sam Weinig.
- UIProcess/API/C/WKContext.cpp:
(WKContextDisableProcessTermination):
(WKContextEnableProcessTermination):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Initialize m_processTerminationEnabled to true.
(WebKit::WebContext::enableProcessTermination):
Set m_processTerminationEnabled to true, and try to terminate the web process.
(WebKit::WebContext::shouldTerminate):
If !m_processTerminationEnabled, return false.
- UIProcess/WebContext.h:
(WebKit::WebContext::disableProcessTermination):
Set m_processTerminationEnabled to false;
- 10:32 AM Changeset in webkit [83987] by
-
- 11 edits in trunk/Source
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
https://bugs.webkit.org/show_bug.cgi?id=58650
- inspector/Inspector.json:
- inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
- inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): (WebInspector.ResourceHeadersView.prototype._refreshHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRequestHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleResponseHeadersText): (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
- inspector/front-end/networkPanel.css: (.resource-headers-view .outline-disclosure li.headers-text):
- platform/network/ResourceLoadInfo.h:
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
https://bugs.webkit.org/show_bug.cgi?id=58650
- public/WebHTTPLoadInfo.h:
- src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::requestHeadersText): (WebKit::WebHTTPLoadInfo::setRequestHeadersText): (WebKit::WebHTTPLoadInfo::responseHeadersText): (WebKit::WebHTTPLoadInfo::setResponseHeadersText):
- 10:28 AM Changeset in webkit [83986] by
-
- 3 edits in trunk/Source/WebCore
2011-04-15 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement css overflow properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58633
No new tests required as no functionality changes.
- css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Add initializers for CSSPropertyOverflowX, CSSPropertyOverflowY and CSSPropertyOverflow.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Delete existing implementations.
- 9:57 AM Changeset in webkit [83985] by
-
- 6 edits in trunk/Source
2011-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Make mac WebKit1 use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=58628
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm: Remove the localization strategy code. The equivalent is now in WebCore/platform/DefaultLocalizationStrategy.cpp.
2011-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Make mac WebKit1 use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=58628
- English.lproj/Localizable.strings: Update by running update-webkit-localizable-strings.
- platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary): (WebCore::DefaultLocalizationStrategy::keygenKeychainItemName): (WebCore::DefaultLocalizationStrategy::imageTitle): Match the WebKit1 versions of these functions by special casing CF platforms.
- 9:42 AM Changeset in webkit [83984] by
-
- 5 edits3 adds in trunk
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
https://bugs.webkit.org/show_bug.cgi?id=58136
Passed response info to inspector when X-Frame-Options header blocks resource loading.
- http/tests/inspector/network/resources/x-frame-options-deny.cgi: Added.
- http/tests/inspector/network/x-frame-options-deny-expected.txt: Added.
- http/tests/inspector/network/x-frame-options-deny.html: Added.
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
https://bugs.webkit.org/show_bug.cgi?id=58136
Passed response info to inspector when X-Frame-Options header blocks resource loading.
Test: http/tests/inspector/network/x-frame-options-deny.html
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDeniedImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- 9:29 AM Changeset in webkit [83983] by
-
- 3 edits2 adds in trunk
2011-04-15 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
https://bugs.webkit.org/show_bug.cgi?id=58449
- inspector/editor/text-editor-model-expected.txt: Added.
- inspector/editor/text-editor-model.html: Added.
2011-04-15 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
https://bugs.webkit.org/show_bug.cgi?id=58449
Test: inspector/editor/text-editor-model.html
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel): (WebInspector.TextEditorModel.prototype.get text): (WebInspector.TextEditorModel.prototype.setText): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype.copyRange):
- 9:20 AM Changeset in webkit [83982] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-15 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Need to export ViewportAttributes class
https://bugs.webkit.org/show_bug.cgi?id=58651
On Symbian, if the ViewportAttributes class is not exported we get
linking errors.
Since this is a compilation issue, no new tests added.
- UIProcess/API/qt/qwkpage.h:
- 9:11 AM Changeset in webkit [83981] by
-
- 2 edits in trunk/LayoutTests
2011-04-15 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
Flaky Test: media/invalid-media-url-crash.html
https://bugs.webkit.org/show_bug.cgi?id=51138
Skipping this test on Snow Leopard since it's hitting
a known MediaToolbox crasher on Snow Leopard.
If Apple happens to software update SL users we can
unskip this, until then no need to run this flaky test.
- platform/mac-snowleopard/Skipped:
- 9:00 AM Changeset in webkit [83980] by
-
- 3 edits in trunk/Tools
2011-04-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
fix path to layout test in new results file
https://bugs.webkit.org/show_bug.cgi?id=58618
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- 8:45 AM Changeset in webkit [83979] by
-
- 2 edits in trunk/LayoutTests
2011-04-15 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, skipping a test.
[GTK] editing/selection/select-out-of-editable.html failing after r83967
https://bugs.webkit.org/show_bug.cgi?id=58667
- platform/gtk/Skipped: skipping editing/selection/select-out-of-editable.html
- 8:42 AM Changeset in webkit [83978] by
-
- 2 edits in trunk/Tools
2011-04-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
fix sorting in new results file
https://bugs.webkit.org/show_bug.cgi?id=58616
-Fix the custom sort to return -1, 0, 1 instead of true/false.
-Secondary sort by test name when sort values are equal.
-Sort by test name by default.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 8:39 AM Changeset in webkit [83977] by
-
- 3 edits in trunk/Tools
2011-04-15 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
check-webkit-style shouldn't complain about not including a primary header file
if none exists
https://bugs.webkit.org/show_bug.cgi?id=39514
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 8:38 AM Changeset in webkit [83976] by
-
- 1 edit6 adds in trunk/LayoutTests
[Windows Tests] fast/forms/input-text-drag-down.html and
editing/selection/select-from-textfield-outwards.html failing since r83967.
https://bugs.webkit.org/show_bug.cgi?id=58664
Adding Windows-specific expected failing results to get the bots green.
- platform/win/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
- platform/win/editing/selection/select-from-textfield-outwards-expected.png: Added.
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt: Added.
- platform/win/fast/forms/input-text-drag-down-expected.checksum: Added.
- platform/win/fast/forms/input-text-drag-down-expected.png: Added.
- platform/win/fast/forms/input-text-drag-down-expected.txt: Added.
- 8:15 AM Changeset in webkit [83975] by
-
- 14 edits4 adds in trunk/Source/WebCore
2011-04-15 Sergey Vorobyev <sergeyvorobyev@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Network events don't preserves,
when inspector frontend closed and open again
https://bugs.webkit.org/show_bug.cgi?id=58064
Added InspectorFrontendProxy and EventsCollector.
They allow captured messages from InspectorResourceAgent
to frontend (or mockFrontend if frontend disabled) and
push collected data when frontend reconnect.
This functionality is disabled by default.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/EventsCollector.cpp: Added. (WebCore::EventsCollector::EventsCollector): (WebCore::EventsCollector::addEvent): (WebCore::EventsCollector::sendCollectedEvents):
- inspector/EventsCollector.h: Added. (WebCore::EventsCollector::~EventsCollector):
- inspector/Inspector.json:
- inspector/InspectorFrontendProxy.cpp: Added. (WebCore::InspectorFrontendProxy::InspectorFrontendProxy): (WebCore::InspectorFrontendProxy::setInspectorFrontendChannel): (WebCore::InspectorFrontendProxy::setEventsCollector): (WebCore::InspectorFrontendProxy::sendMessageToFrontend):
- inspector/InspectorFrontendProxy.h: Added. (WebCore::InspectorFrontendProxy::~InspectorFrontendProxy):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::domContentEventFired): (WebCore::InspectorResourceAgent::loadEventFired): (WebCore::InspectorResourceAgent::enabledBackgoundEventsCoollection): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.domContentEventFired): (WebInspector.NetworkDispatcher.prototype.loadEventFired):
- inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired):
- 7:55 AM Changeset in webkit [83974] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
2011-04-15 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
Add a sample test case for GTest framework
https://bugs.webkit.org/show_bug.cgi?id=58509
Add an example of GTest testcase, complete with a runner, to JavaScriptCore.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/tests/RunAllWtfTests.cpp: Added. (main):
- wtf/tests/StringTests.cpp: Added.
- 7:38 AM Changeset in webkit [83973] by
-
- 3 edits in trunk/Source/WebCore
2011-04-15 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r83397) [Qt] When clicking on the media elements they grow 2 pixels.
https://bugs.webkit.org/show_bug.cgi?id=58477
Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size. Therefore
ports which are not using the borders must explicitly disable them in their custom
stylesheet.
- css/mediaControlsQt.css: (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (video::-webkit-media-controls-fullscreen-button):
- css/mediaControlsQuickTime.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- 7:35 AM Changeset in webkit [83972] by
-
- 15 edits in trunk/Source
2011-04-15 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Fisher.
Added enums for external file system type.
https://bugs.webkit.org/show_bug.cgi?id=58456
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::crackFileSystemURL):
- fileapi/DOMFileSystemBase.h:
- fileapi/EntryBase.cpp: (WebCore::EntryBase::toURL):
- page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
- page/DOMWindow.h:
- platform/AsyncFileSystem.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): (WebCore::WorkerContext::requestFileSystemSync):
- workers/WorkerContext.h:
2011-04-15 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Fisher.
Added enums for external file system type and exposed factory function
for creating File- and DirectoryEntry objects from Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=58456
- public/WebFileSystem.h:
- public/WebFrame.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFileSystem): (WebKit::WebFrameImpl::createFileEntry):
- src/WebFrameImpl.h:
- 7:30 AM Changeset in webkit [83971] by
-
- 1 edit6 adds in trunk/LayoutTests
2011-04-15 Sergio Villar Senin <svillar@igalia.com>
Unreviewed, added new GTK+ test expectations.
- platform/gtk/fast/forms/select-background-none-expected.checksum: Added.
- platform/gtk/fast/forms/select-background-none-expected.png: Added.
- platform/gtk/fast/forms/select-background-none-expected.txt: Added.
- platform/gtk/fast/text/zero-font-size-expected.checksum: Added.
- platform/gtk/fast/text/zero-font-size-expected.png: Added.
- platform/gtk/fast/text/zero-font-size-expected.txt: Added.
- 7:25 AM Changeset in webkit [83970] by
-
- 2 edits in trunk/LayoutTests
Add new eventSender-dependent tests from r83967 to the mac-wks Skipped file
- platform/mac-wk2/Skipped: Added some new editing/selection tests.
- 7:08 AM Changeset in webkit [83969] by
-
- 6 edits in trunk/Source/WebCore
2011-04-15 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: make resource revisions use dedicated type (not Resource clone).
https://bugs.webkit.org/show_bug.cgi?id=58659
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.addRevision): (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent): (WebInspector.ResourceRevision): (WebInspector.ResourceRevision.prototype.get resource): (WebInspector.ResourceRevision.prototype.get timestamp): (WebInspector.ResourceRevision.prototype.get content): (WebInspector.ResourceRevision.prototype.revertToThis): (WebInspector.ResourceRevision.prototype.requestContent.mycallback): (WebInspector.ResourceRevision.prototype.requestContent):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource): (WebInspector.RevisionSourceFrame): (WebInspector.RevisionSourceFrame.prototype.get resource): (WebInspector.RevisionSourceFrame.prototype.isContentEditable): (WebInspector.RevisionSourceFrame.prototype.requestContent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._showRevisionView): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step1): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step2): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype.get itemURL): (WebInspector.ResourceRevisionTreeElement.prototype.onselect): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._ensureContentLoaded): (WebInspector.SourceFrame.prototype.requestContent): (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing):
- 6:57 AM Changeset in webkit [83968] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Prevent Backspace keypresses from routing into the inspected page
https://bugs.webkit.org/show_bug.cgi?id=58653
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 6:44 AM Changeset in webkit [83967] by
-
- 3 edits9 adds in trunk
2011-04-15 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552
Tests that dragging outside of a contenteditable, input or textarea selects to the end of the
element, rather than jumping back to the beginning.
- editing/selection/resources/select-out-of-floated-editable.js: Added. (log): (else.window.onmouseup): (getSelectionStart): (getSelectionEnd): (checkSelection):
- editing/selection/select-out-of-editable-expected.txt: Added.
- editing/selection/select-out-of-editable.html: Added.
- editing/selection/select-out-of-floated-contenteditable-expected.txt: Added.
- editing/selection/select-out-of-floated-contenteditable.html: Added.
- editing/selection/select-out-of-floated-input-expected.txt: Added.
- editing/selection/select-out-of-floated-input.html: Added.
- editing/selection/select-out-of-floated-textarea-expected.txt: Added.
- editing/selection/select-out-of-floated-textarea.html: Added.
2011-04-15 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Text selection changes unexpectedly when dragging out of the <input>
https://bugs.webkit.org/show_bug.cgi?id=55552
Tests: editing/selection/select-out-of-editable.html
editing/selection/select-out-of-floated-contenteditable.html
editing/selection/select-out-of-floated-input.html
editing/selection/select-out-of-floated-textarea.html
- page/EventHandler.cpp: (WebCore::selectionExtentRespectingEditingBoundary): When dragging from an editable element, check that the endpoint is not outside the element. If it is, translate the point into a local point within the editable element. (WebCore::EventHandler::updateSelectionForMouseDrag): Call targetPositionForSelectionEndpoint() to calculate the selection endpoint.
- 6:41 AM Changeset in webkit [83966] by
-
- 2 edits in trunk/LayoutTests
Update Windows results after r83939
- platform/win/media/media-document-audio-repaint-expected.txt:
- 6:34 AM Changeset in webkit [83965] by
-
- 2 edits in trunk/LayoutTests
Skip a sometimes-failing test on Windows
<http://webkit.org/b/58441> tracks the failure.
- platform/win/Skipped: Added fast/events/pageshow-pagehide-on-back-cached-with-frames.html.
- 6:28 AM Changeset in webkit [83964] by
-
- 2 edits in trunk/LayoutTests
Skip a timing-out test on Windows
<http://webkit.org/b/58654> tracks the failure.
- platform/win/Skipped: Added media/video-controls-in-media-document.html.
- 6:12 AM Changeset in webkit [83963] by
-
- 9 edits8 deletes in trunk
Roll out r83954
It was causing fast/dom/Window/timer-null-script-execution-context.html to crash on multiple
bots.
See <http://webkit.org/b/58610>.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScheduledAction.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- page/ContentSecurityPolicy.cpp:
- page/ContentSecurityPolicy.h:
LayoutTests:
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Removed.
- 5:39 AM Changeset in webkit [83962] by
-
- 13 edits in trunk
2011-04-15 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor resource setContent / revisions infrastructure to get
rid of onRevert callback.
https://bugs.webkit.org/show_bug.cgi?id=58649
Instead, we will have DomainModel/Resource binding responsible for changing
underlying model upon resource changes and vice versa.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::getStyleSheetText): (WebCore::InspectorCSSAgent::setStyleSheetText): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::assertStyleSheetForId):
- inspector/InspectorCSSAgent.h:
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged): (WebInspector.CSSStyleModel.prototype.setStyleSheetText): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.prototype.setText): (WebInspector.CSSStyleModelResourceBinding): (WebInspector.CSSStyleModelResourceBinding.prototype.setContent): (WebInspector.CSSStyleModelResourceBinding.prototype._frameNavigated): (WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent): (WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders): (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent): (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModelResourceBinding): (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent): (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
- inspector/front-end/Object.js: (WebInspector.Object.prototype.hasEventListeners):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.registerDomainModelBinding): (WebInspector.Resource.prototype.isEditable): (WebInspector.Resource.prototype.setContent): (WebInspector.Resource.prototype.addRevision): (WebInspector.Resource.prototype.revertToThis.callback): (WebInspector.Resource.prototype.revertToThis): (WebInspector.ResourceDomainModelBinding): (WebInspector.ResourceDomainModelBinding.prototype.canSetContent): (WebInspector.ResourceDomainModelBinding.prototype.setContent):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceSourceFrame.prototype.isContentEditable): (WebInspector.ResourceSourceFrame.prototype.editContent): (WebInspector.ResourceSourceFrame.prototype.endEditing): (WebInspector.ResourceSourceFrame.prototype._clearIncrementalUpdateTimer): (WebInspector.ResourceSourceFrame.prototype._requestContent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype._populateRevisions): (WebInspector.FrameResourceTreeElement.prototype._revisionAdded): (WebInspector.FrameResourceTreeElement.prototype._appendRevision):
- inspector/front-end/inspector.html:
- 3:05 AM Changeset in webkit [83961] by
-
- 2 edits1 copy in trunk/LayoutTests
2011-04-15 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK platform results for
fast/css/font-face-repeated-url.html
- fast/css/font-face-repeated-url-expected.txt:
- platform/gtk/fast/css/font-face-repeated-url-expected.txt: Copied from LayoutTests/fast/css/font-face-repeated-url-expected.txt.
- 2:28 AM Changeset in webkit [83960] by
-
- 8 edits in trunk
2011-04-15 Andrey Kosyakov <caseq@chromium.org>
Unreviewed, rolling out r83949.
http://trac.webkit.org/changeset/83949
https://bugs.webkit.org/show_bug.cgi?id=57960
broke 31 tests in chromium win & linux
- platform/chromium/test_expectations.txt:
2011-04-15 Andrey Kosyakov <caseq@chromium.org>
Unreviewed, rolling out r83949.
http://trac.webkit.org/changeset/83949
https://bugs.webkit.org/show_bug.cgi?id=57960
broke 31 tests in chromium win & linux
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect):
- platform/graphics/chromium/GLES2Canvas.h:
- platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::updateSubRect):
- platform/graphics/gpu/Texture.h:
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- 1:50 AM Changeset in webkit [83959] by
-
- 3 edits in trunk/LayoutTests
2011-04-15 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline of two tests.
- fast/css/font-face-repeated-url-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- 1:10 AM Changeset in webkit [83958] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Create tests for network panel timing, size and raw headers text
https://bugs.webkit.org/show_bug.cgi?id=58566
Added network timing, size and raw headers tests for Inspector
Since chromium used different version of network stack for layout
tests, these are interactive ui tests (DevToolsSanityTest.TestNetwork*)
- src/js/Tests.js: (.TestSuite.prototype.testNetworkSize.finishResource): (.TestSuite.prototype.testNetworkSyncSize.finishResource): (.TestSuite.prototype.testNetworkRawHeadersText.finishResource): (.TestSuite.prototype.testNetworkTiming.finishResource):
- 12:55 AM Changeset in webkit [83957] by
-
- 2 edits in trunk/Source/WebCore
2011-04-15 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
Fix building with Sun Studio 12: function pointers for extern "C" are treated differently
https://bugs.webkit.org/show_bug.cgi?id=58508
Since extern "C" makes a different type (although most compilers ignore that),
we should be more careful when passing NPAPI callback functions.
- plugins/npapi.cpp: (NPN_PluginThreadAsyncCall):
- 12:54 AM Changeset in webkit [83956] by
-
- 3 edits in trunk/Tools
2011-04-15 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
queues.webkit.org should display when a bot last rebooted
https://bugs.webkit.org/show_bug.cgi?id=58562
There is more repeated code here than I would like. I fear
my django-fu isn't quite up to snuff.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/templates/queuestatus.html:
- 12:43 AM Changeset in webkit [83955] by
-
- 191 edits in trunk
2011-04-15 Philippe Normand <pnormand@igalia.com>
Unreviewed, rollout r83894 r83827 r83810 r83809 r83808.
r83808 and its follow-up commits broke GTK Release builds.
https://bugs.webkit.org/show_bug.cgi?id=58483
- 12:39 AM Changeset in webkit [83954] by
-
- 9 edits8 adds in trunk
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.
Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
- bindings/js/ScheduledAction.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowEval):
- page/ContentSecurityPolicy.h:
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP should block string arguments to setTimeout and setInterval unless options eval-script
https://bugs.webkit.org/show_bug.cgi?id=58610
Herein lies a four-way testing matrix.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.
- 12:37 AM Changeset in webkit [83953] by
-
- 3 edits2 adds in trunk
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for CSP's 'self' source
https://bugs.webkit.org/show_bug.cgi?id=58604
- http/tests/security/contentSecurityPolicy/script-src-self-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-self.html: Added.
2011-04-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add support for CSP's 'self' source
https://bugs.webkit.org/show_bug.cgi?id=58604
This change is now trivially easy.
Test: http/tests/security/contentSecurityPolicy/script-src-self.html
- page/ContentSecurityPolicy.cpp: (WebCore::CSPSourceList::addSourceSelf):
- 12:13 AM Changeset in webkit [83952] by
-
- 18 edits in trunk
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
- configure.ac:
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
No new tests. No new functionality.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- features.pri:
- html/HTMLTagNames.in:
- html/HTMLTrackElement.cpp:
- html/HTMLTrackElement.h:
- html/HTMLTrackElement.idl:
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
- Configurations/FeatureDefines.xcconfig:
2011-04-15 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Renaming TRACK feature define to VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=53556
- Configurations/FeatureDefines.xcconfig:
Apr 14, 2011:
- 11:29 PM Changeset in webkit [83951] by
-
- 4 edits in trunk/Source/WebCore
2011-04-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Ctrl+Left/Right switch panels during live editing
https://bugs.webkit.org/show_bug.cgi?id=58521
Disable Ctrl+Left/Right keyboard shortcuts while in live edit.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.readOnlyStateChanged):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextViewer.prototype.get readOnly): (WebInspector.TextViewer.prototype._doubleClick): (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing): (WebInspector.TextViewer.prototype._commitEditing): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewerDelegate.prototype.readOnlyStateChanged): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
- inspector/front-end/inspector.js: (WebInspector.markBeingEdited): (WebInspector.isEditingAnyField): (WebInspector.startEditing.cleanUpAfterEditing):
- 10:55 PM Changeset in webkit [83950] by
-
- 12 edits in trunk/Source
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Enable raw HTTP headers support
https://bugs.webkit.org/show_bug.cgi?id=58259
Added raw headers text support to inspector.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get rawRequestHeadersText): (WebInspector.Resource.prototype.set rawRequestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get rawResponseHeadersText): (WebInspector.Resource.prototype.set rawResponseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
- inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): (WebInspector.ResourceHeadersView.prototype._refreshHeaders): (WebInspector.ResourceHeadersView.prototype._refreshRawHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRawRequestHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRawResponseHeadersText): (WebInspector.ResourceHeadersView.prototype._createToggleButton): (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
- inspector/front-end/networkPanel.css: (.resource-headers-view .outline-disclosure li .header-toggle): (.resource-headers-view .outline-disclosure li.expanded .header-toggle): (.resource-headers-view .outline-disclosure li .header-toggle:hover): (.resource-headers-view .outline-disclosure li.raw-headers-text):
- platform/network/ResourceLoadInfo.h:
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Enable raw HTTP headers support
https://bugs.webkit.org/show_bug.cgi?id=58259
Added raw headers text support to inspector.
- public/WebHTTPLoadInfo.h:
- src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::rawRequestHeadersText): (WebKit::WebHTTPLoadInfo::setRawRequestHeadersText): (WebKit::WebHTTPLoadInfo::rawResponseHeadersText): (WebKit::WebHTTPLoadInfo::setRawResponseHeadersText):
- 10:43 PM Changeset in webkit [83949] by
-
- 8 edits in trunk
2011-04-14 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Accelerated 2D Canvas is slow to execute putImageData
https://bugs.webkit.org/show_bug.cgi?id=57960
- platform/chromium/test_expectations.txt: added expected failure for test canvas/philip/tests/2d.gradient.interpolate.colouralpha.html Logged as chromium issue: http://code.google.com/p/chromium/issues/detail?id=79477
2011-04-14 Justin Novosad <junov@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Accelerated 2D Canvas is slow to execute putImageData
https://bugs.webkit.org/show_bug.cgi?id=57960
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): Added an option for using the blend ops for alpha multiplication instead of compositing. (WebCore::GLES2Canvas::applyClipping): (WebCore::GLES2Canvas::putImageData): New method for drawing raw pixel data from memory to the canvas (WebCore::GLES2Canvas::putUnmultipliedImageData): Wrapper for putImageData (WebCore::GLES2Canvas::putPremultipliedImageData): Wrapper for putImageData
- platform/graphics/chromium/GLES2Canvas.h:
- platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::updateSubRect): Added an overload of the updateSubRect method that can receive a pixel of a size that is different from texture size. Improved the performance of updateSubrect by avoiding the allocation of a temporary buffer when not required.
- platform/graphics/gpu/Texture.h:
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): In the unmultiplied path, division by alpha now performs proper rounding in order to avoid generational degradation with putImageData (WebCore::putImageData): Alpha multiplication now performs proper rounding in order to be consistent with the hardware rendering path: OpenGL always rounds when converting to fixed point representation. (WebCore::ImageBuffer::putUnmultipliedImageData): Now supports a hardware rendering path, which eliminates the need for a readback from the GPU (WebCore::ImageBuffer::putPremultipliedImageData): Now supports a hardware rendering path, which eliminates the need for a readback from the GPU
- 10:24 PM Changeset in webkit [83948] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, test expectations for more bug 57113 fallout.
- platform/chromium/test_expectations.txt:
- 10:22 PM Changeset in webkit [83947] by
-
- 5 edits1 add9 deletes in trunk/LayoutTests
2011-04-14 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Rewrote video-controls-in-media-document layouttest to use the shadow
DOM (possible as of r83397) and avoid the need for pixel-test status.
https://bugs.webkit.org/show_bug.cgi?id=54634
- media/video-controls-in-media-document-expected.txt: Added.
- media/video-controls-in-media-document.html:
- platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.checksum: Removed.
- platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.png: Removed.
- platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.txt: Removed.
- platform/chromium-win-xp/media/video-controls-in-media-document-expected.checksum: Removed.
- platform/chromium-win-xp/media/video-controls-in-media-document-expected.png: Removed.
- platform/chromium/media/video-controls-in-media-document-expected.checksum: Removed.
- platform/chromium/media/video-controls-in-media-document-expected.png: Removed.
- platform/chromium/media/video-controls-in-media-document-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/media/video-controls-in-media-document-expected.txt: Removed.
- platform/mac/Skipped:
- platform/win/Skipped:
- 10:19 PM Changeset in webkit [83946] by
-
- 2 edits in trunk/Tools
2011-04-14 Alok Priyadarshi <alokp@chromium.org>
Reviewed by Adam Barth.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
Fixed compile error on Mac when using Core Graphics.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect):
- 10:18 PM Changeset in webkit [83945] by
-
- 6 edits2 adds1 delete in trunk/Source/WebCore
2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
Creating a CairoPath instance is not thread safe
https://bugs.webkit.org/show_bug.cgi?id=58514
This patch allows a cairo surface to be created just one time in order to
guarantee thread safety.
In addition, CairoPath.{h,cpp} is renamed to PlatformPathCairo.{h,cpp} to
prevent confusing them with PathCairo.cpp
- CMakeListsEfl.txt: Added PlatformPathCairo.cpp
- GNUmakefile.list.am: Added PlatformPathCairo.{h,cpp} instead of CairoPath.h.
- platform/graphics/cairo/CairoPath.h: Removed.
- platform/graphics/cairo/CairoUtilities.cpp: Include PlatformPathCairo.h instead of CairoPath.h.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
- platform/graphics/cairo/PathCairo.cpp: Ditto.
- platform/graphics/cairo/PlatformPathCairo.cpp: Added. (WebCore::getPathSurface): Getting a static cairo surface. (WebCore::CairoPath::CairoPath): Moved the implementation of the constructor into the CPP file.
- platform/graphics/cairo/PlatformPathCairo.h: Renamed CairoPath.h to this. (WebCore::CairoPath::~CairoPath): (WebCore::CairoPath::context):
- 10:13 PM Changeset in webkit [83944] by
-
- 3 edits in trunk/Source/WebCore
2011-04-14 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add lowpass filter and graph to fps indicator
https://bugs.webkit.org/show_bug.cgi?id=58186
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::drawHudContents): (WebCore::CCHeadsUpDisplay::drawFPSCounter): (WebCore::CCHeadsUpDisplay::drawPlatformLayerTree): (WebCore::CCHeadsUpDisplay::onPresent):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
- 10:05 PM Changeset in webkit [83943] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=58612
Crash switching overlay/non-overlay scrollbar preference
(WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
-and corresponding-
<rdar://problem/9241920>
Reviewed by Adele Peterson.
Speculative fix: Page could definitely be null here.
- page/FrameView.cpp:
(WebCore::FrameView::scrollbarStyleChanged):
- 9:29 PM Changeset in webkit [83942] by
-
- 6 edits in trunk/Source
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
https://bugs.webkit.org/show_bug.cgi?id=58447
FrameLoader now takes encoded data length for synchronous requests from the field with the same name.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
- platform/network/ResourceLoadInfo.h: (WebCore::ResourceLoadInfo::ResourceLoadInfo):
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
https://bugs.webkit.org/show_bug.cgi?id=58447
FrameLoader now takes encoded data length for synchronous requests from the field with the same name.
- public/WebHTTPLoadInfo.h:
- src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::encodedDataLength): (WebKit::WebHTTPLoadInfo::setEncodedDataLength):
- 8:52 PM Changeset in webkit [83941] by
-
- 23 edits in trunk
2011-04-14 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas. The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium. We will eventually define an API that every port using skia will define.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::Font::drawComplexText):
- platform/graphics/chromium/ImageBufferDataSkia.h:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
- platform/graphics/chromium/PlatformCanvas.h:
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::setCanvas): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
- platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::canvas): (WebCore::PlatformContextSkia::printing): (WebCore::PlatformContextSkia::setPrinting):
2011-04-14 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
- public/WebCanvas.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage):
- tests/TransparencyWinTest.cpp: (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::TEST):
2011-04-14 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
- DumpRenderTree/chromium/TestShell.cpp: (makeCanvasOpaque): (TestShell::dumpImage):
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::WebThemeControlDRTWin): (WebThemeControlDRTWin::draw): (WebThemeControlDRTWin::drawTextField): (WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas):
- DumpRenderTree/chromium/WebViewHost.h:
- 8:48 PM Changeset in webkit [83940] by
-
- 3 edits in trunk/Source/WebCore
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
PumpSession should not call currentTime() in the constructor
https://bugs.webkit.org/show_bug.cgi?id=55211
currentTime() is expensive. So we avoid calling it in the constructor
and instead set startTime on the first check for a yield
(which in the synchronous case never happens, and in the yielding
case will happen immediately after the first token due to
processedTokens being set to INT_MAX).
This ended up being a large win on (my local copy of)
peacekeeper's domDynamicCreationCreateElement:
Before:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377
After:
avg 345.96666666666664
median 346
stdev 1.6829207415152454
min 343
max 349
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession): (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
- 8:43 PM Changeset in webkit [83939] by
-
- 6 edits in trunk
2011-04-14 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Update expectation to reflect removal of the -25px bottom margin.
https://bugs.webkit.org/show_bug.cgi?id=58442
- media/media-document-audio-repaint-expected.txt:
2011-04-14 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Remove unnecessary bottom margin of controls in video elements on media documents.
This makes the cases of media documents and non-media documents consistent,
and makes it possible to reason about the height of a rendered media document
(needed e.g. for sizing iframes).
This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
media/video-controls-in-media-document.html layouttest (see bug 54634 for
the un-Skipping).
- css/mediaControls.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
- css/mediaControlsEfl.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
- css/mediaControlsQuickTime.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
- 8:39 PM Changeset in webkit [83938] by
-
- 11 edits in trunk/Source/WebCore
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Use opaque roots instead of direct marking for nodes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=58624
A node treats the root of its tree (usually the document) as its opaque
root during GC.
This is needed for correctness in a generational GC world, but it also
happens to be a 3.5X speedup in a DOM-heavy GC test (scratch-gc-dom2.html).
- bindings/js/DOMWrapperWorld.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): Moved a helper function from JSDOMBinding. We use this function to determine whether a node is observable.
(WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): Start using
our weak handle callback to determine reachability, instead of direct
marking traversal through the DOM.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::markChildren): Updated to use the opaque roots mechanism instead of direct marking.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h: Moved code mentioned above. Removed markDOMNodeWrapper because it is now unused. This is a good thing because markDOMNodeWrapper used deprecatedAppend, which is not compatible with generational GC.
- bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementation::markChildren): Updated to use opaque roots.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren): No need to mark our child nodes directly, since they will take care of themselves through the opaque roots mechanism.
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::markChildren): Updated to use opaque roots.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): No need to mark our tree or our document directly, since they will take care of themselves through the opaque roots mechanism.
- bindings/js/JSNodeCustom.h: (WebCore::root): Helper function for accessing the root of a node tree. This is O(1) while you're in the document, O(log(N)) when you're in a reasonably balanced disconnected tree, and O(N) in the pathological case of a disconnected tree that's shaped like a linked list. If average case O(long(N)) turns out to be too slow, we can optimize through use of rare data or an external hash table, but it is so uncommon that I have ignored it for now.
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::markChildren): Updated to use opaque roots.
- 8:30 PM Changeset in webkit [83937] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Guess what? ChickenW chromium test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 8:18 PM Changeset in webkit [83936] by
-
- 3 edits in trunk/Source
2011-04-14 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
fix shadows with gradients
https://bugs.webkit.org/show_bug.cgi?id=58376
No new tests. Existing tests exercise this
LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 8:08 PM Changeset in webkit [83935] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-14 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
In skia platform call SkBitmap::notifyPixelsChanged on WebGL readback
https://bugs.webkit.org/show_bug.cgi?id=58543
No new tests. Tested by fast/canvas/webgl/canvas-test.html
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
- 7:54 PM Changeset in webkit [83934] by
-
- 2 edits in trunk/LayoutTests
Skip a test in WK2 that requires
layoutTestController.overridePreference().
- platform/mac-wk2/Skipped:
- 7:40 PM Changeset in webkit [83933] by
-
- 5 edits3 adds in trunk
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No headers information in network panel for downloads.
https://bugs.webkit.org/show_bug.cgi?id=58139
Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.
- http/tests/inspector/network/download-expected.txt: Added.
- http/tests/inspector/network/download.html: Added.
- http/tests/inspector/network/resources/download.zzz: Added.
2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: No headers information in network panel for downloads.
https://bugs.webkit.org/show_bug.cgi?id=58139
Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.
Test: http/tests/inspector/network/download.html
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl): (WebCore::InspectorInstrumentation::continueWithPolicyDownloadImpl): (WebCore::InspectorInstrumentation::continueWithPolicyIgnoreImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueWithPolicyDownload): (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- 7:12 PM Changeset in webkit [83932] by
-
- 3 edits in trunk/Source/WebCore
2011-04-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
Convert use of raw pointers to RefPtr in using Cairo
https://bugs.webkit.org/show_bug.cgi?id=57717
No new tests added becaue of just replacing raw pointers with smart pointers.
- platform/graphics/cairo/ContextShadowCairo.cpp: Use a RefPtr<cairo_surface_t> instead of raw pointer. (WebCore::purgeScratchBuffer): (WebCore::getScratchBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp: Use a RefPtr<cairo_t> instead of raw pointer. (copySurface):
- 7:12 PM Changeset in webkit [83931] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-04-14 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Antonio Gomes.
Memory cache API
https://bugs.webkit.org/show_bug.cgi?id=58016
- ewk/ewk_settings.cpp: (ewk_settings_cache_enable_get): (ewk_settings_cache_enable_set): (ewk_settings_cache_capacity_set):
- ewk/ewk_settings.h:
- 7:09 PM Changeset in webkit [83930] by
-
- 3 edits8 adds in trunk
2011-04-14 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
https://bugs.webkit.org/show_bug.cgi?id=57818
- fast/forms/select-background-none.html: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.png: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.txt: Added.
- platform/chromium-linux/fast/forms/select-background-none-expected.checksum: Added.
- platform/chromium-linux/fast/forms/select-background-none-expected.png: Added.
- platform/chromium-linux/fast/forms/select-background-none-expected.txt: Added.
- platform/mac/fast/forms/select-background-none-expected.txt: Added.
2011-04-14 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
https://bugs.webkit.org/show_bug.cgi?id=57818
Test: fast/forms/select-background-none.html
This fix is only for Chromium on Linux. Chromium on Mac already works fine.
But Windows has the same problem. This change doesn't include Windows part.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
- 6:54 PM Changeset in webkit [83929] by
-
- 2 edits in trunk/Source/JavaScriptCore
Hide DFG_JIT_RESTRICTIONS behind ARITHMETIC_OP() macro, and rename
m_regressionGuard to m_parseFailed, such that it can be reused for
other failure cases.
Rubber stamped by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
- 6:44 PM Changeset in webkit [83928] by
-
- 7 edits in trunk/Tools
2011-04-14 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=58007
Adds flag to start the test browsers maximized.
Symbian started maximized on QtTestBrowser - made MiniBrowser follow
suit.
Also fixes some ToggleFullScreen issues so that prior window state is
restored.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::toggleFullScreenMode):
- MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
- MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::toggleFullScreenMode):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 6:35 PM Changeset in webkit [83927] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, update test expectations for huge-layer-img.
- platform/chromium/test_expectations.txt:
- 6:32 PM Changeset in webkit [83926] by
-
- 3 edits in trunk/Source/WebCore
2011-04-14 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement border style css properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58506
No new functionality added.
- css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added new property initializers.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Removed old property handlers.
- 6:28 PM Changeset in webkit [83925] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
[Chromium] Two new tests added by r83287 fail in chromium
https://bugs.webkit.org/show_bug.cgi?id=58147
Solved by enabling the Media Stream API in the chromium feature override file.
- platform/chromium/test_expectations.txt:
- 6:28 PM Changeset in webkit [83924] by
-
- 9 edits in trunk/Source/JavaScriptCore
Bug 58620 - DFG JIT - loading of arguments should not be lazy
Reviewed by Geoffrey Garen.
This optimization is overly simplistic. It only works because we never
write out definitions to arguments (since we currently only compile
single block functions). Revert this for now, we may want to reintroduce
something like this again in the future, but it will need to be aware
how to schedule definitions to arguments versus lazy loads that have not
yet been performed.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::needsSpill):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::initConstantInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- 6:24 PM Changeset in webkit [83923] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=58619
- platform/chromium/test_expectations.txt:
- 6:05 PM Changeset in webkit [83922] by
-
- 3 edits3 adds in trunk
2011-04-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
Presence of shadow DOM should suppress rendering of ordinary child nodes
https://bugs.webkit.org/show_bug.cgi?id=58073
- fast/dom/shadow/no-renderers-for-light-children-expected.txt: Added.
- fast/dom/shadow/no-renderers-for-light-children.html: Added.
2011-04-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
Presence of shadow DOM should suppress rendering of ordinary child nodes
https://bugs.webkit.org/show_bug.cgi?id=58073
Test: fast/dom/shadow/no-renderers-for-light-children.html
- dom/Node.cpp: (WebCore::shadowRoot): Added a helper function. (WebCore::Node::setDocumentRecursively): Changed to use the helper. (WebCore::shouldCreateRendererFor): Expanded a long condition check into a helper function,
added a check for children of an element with a shadow DOM.
(WebCore::Node::createRendererAndStyle): Changed to use the helper.
- 6:02 PM Changeset in webkit [83921] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Add correct chromium expectation for compositing/layer-creation/overflow-scroll-overlap
- platform/chromium-gpu/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:58 PM Changeset in webkit [83920] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Update chromium test expectations.
- platform/chromium-gpu/compositing/layer-creation: Removed.
- platform/chromium/test_expectations.txt:
- 5:51 PM Changeset in webkit [83919] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Select All context menu item doesn't work in Flash
https://bugs.webkit.org/show_bug.cgi?id=58615
<rdar://problem/9225761>
In some cases, -[NSWindow isKeyWindow] will return false even if
a window is the key window, so we have to compare our window
against -[NSApplication keyWindow].
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isViewWindowActive):
- 5:47 PM Changeset in webkit [83918] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add CFPreference based backend for WebKit2 preferences
https://bugs.webkit.org/show_bug.cgi?id=58605
- UIProcess/cf/WebPreferencesCF.cpp: (WebKit::cfStringFromWebCoreString): (WebKit::makeKey): (WebKit::setStringValueIfInUserDefaults): (WebKit::setBoolValueIfInUserDefaults): (WebKit::setUInt32ValueIfInUserDefaults): (WebKit::setDoubleValueIfInUserDefaults): (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Implement platform functions using CFPreferences API.
- 5:44 PM Changeset in webkit [83917] by
-
- 2 edits in trunk/Tools
2011-04-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add checkbox to only show unexpected results to new results file
https://bugs.webkit.org/show_bug.cgi?id=58606
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 5:25 PM Changeset in webkit [83916] by
-
- 21 edits in trunk
Bug 58600 - DFG JIT bugs in ValueToInt, PutByVal
Reviewed by Geoffrey Garen.
The bug in PutByVal is that an operand is in JSValueOperand - when this
locks an integer into a register it will always retag the value without
checking if the register is already locked. This is a problem where the
value being stored by a PutByVal is the same as the subscript.
The subscript is locked into a register first, as a strict integer.
Locking the value results in the subscript being modified.
The bug in ValueToInt related to the function of sillentFillAllRegisters.
The problem is that this method will restore all register values from
prior to the call, overwriting the result of the call out. Allow a
register to be passed to specifically be excluded from being preserved.
Source/JavaScriptCore:
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::debugOffset):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::debugOffset):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::debugOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugAddress):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::debugOffset):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::orPtr):
- assembler/X86Assembler.h:
(JSC::X86Assembler::debugOffset):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGenerationInfo.h:
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isConstant):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isConstant):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- fast/js/array-index-immediate-types-expected.txt:
- fast/js/script-tests/array-index-immediate-types.js:
(putSelf):
- 5:16 PM Changeset in webkit [83915] by
-
- 46 edits in trunk
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Tile content and image layers
https://bugs.webkit.org/show_bug.cgi?id=57113
Rebaseline a number of image tests where slight filtering differences
from using tiles caused test failures with exact pixel matching.
None of these results are perceptually different.
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum:
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum:
- platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum:
- platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum:
- platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png:
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum:
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum:
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium/test_expectations.txt:
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Tile content and image layers
https://bugs.webkit.org/show_bug.cgi?id=57113
Layers tile by default if any dimension is larger than 512. Smaller
layers are contained within a single texture but still use the tiler
infrastructure so that there's only one code path.
Remove large layer support from content layers. Content layers no
longer own a platform canvas--they own a tiler. Refactor tiler to
allow for better separation of update/upload/paint. Add rect
parameter to update and draw functions on layers for the layer-space
rect of interest. This is necessary to know which tiles need to be
drawn.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerPainter::ContentLayerPainter): (WebCore::ContentLayerPainter::paint): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::tilingTransform): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::layerBounds): (WebCore::ContentLayerChromium::updateLayerSize): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources): (WebCore::ContentLayerChromium::setTilingOption): (WebCore::ContentLayerChromium::bindContentsTexture): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::setIsMask): (WebCore::ContentLayerChromium::dumpLayerProperties):
- platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent):
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::layerBounds): (WebCore::ImageLayerChromium::tilingTransform):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::invalidateRect): (WebCore::LayerChromium::paintContentsIfDirty): (WebCore::LayerChromium::setIsMask): (WebCore::LayerChromium::draw):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::paintContentsRecursive): (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::getSingleTexture): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::unreserveTextures):
- platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer): (WebCore::LayerTilerChromium::skipsDraw):
- platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::Painter::Painter):
- platform/graphics/chromium/PlatformCanvas.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::draw):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- 4:54 PM Changeset in webkit [83914] by
-
- 4 edits in trunk
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
https://bugs.webkit.org/show_bug.cgi?id=58575
Remove expected failure lines for pixel tests that now should pass.
- platform/chromium/test_expectations.txt:
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
https://bugs.webkit.org/show_bug.cgi?id=58575
Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
is called, not contentsResized() so that we always update layers when adding or removing scrollbars.
Covered by several chromium pixel tests.
- page/FrameView.cpp: (WebCore::FrameView::contentsResized): (WebCore::FrameView::visibleContentsResized):
- 4:52 PM Changeset in webkit [83913] by
-
- 2 edits in trunk/Source/WebCore
Fix some threading issues in IconDatabase.
https://bugs.webkit.org/show_bug.cgi?id=57985
Reviewed by Brady Eidson.
No functionality change so no new tests. It would be very hard to test this, but
I am working on a change for bug 31639 to detect these (which makes layout tests
fail for at least one of these issues).
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::readFromDatabase): Release imageData so that it won't get deref'ed outside of locks.
(WebCore::IconDatabase::writeToDatabase): Acquire m_urlAndIconLock because the SharedBuffer<> data
is used, and this lock seems to be the one which consistently guards it.
- 4:31 PM Changeset in webkit [83912] by
-
- 5 edits2 adds in trunk/Tools
2011-04-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
[WinCairo] Implement ImageDiff Logic.
http://bugs.webkit.org/show_bug.cgi?id=58486
- DumpRenderTree/win/ImageDiffCairo.cpp: Added. (strtof): (readFromData): (createImageFromStdin): (releaseMallocBuffer): (createDifferenceImage): (imageHasAlpha): (writeToData): (main):
- DumpRenderTree/win/ImageDiff.vcproj: Updated for new ImageDiffCairo.cpp (excluding from Apple builds).
- DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use new ImageDiffWinCairoCommon.vsprops file.
- DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use new ImageDiffWinCairoCommon.vsprops file.
- DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
- Scripts/old-run-webkit-tests: Make sure proper executable is built and executed for WinCairo port.
- 4:25 PM Changeset in webkit [83911] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Chris Rogers <crogers@google.com>
Unreviewed.
Update preload-slow-loading.php in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=58597
- platform/chromium/test_expectations.txt:
- 4:20 PM Changeset in webkit [83910] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Drain the mark stack while marking weak handles, not after.
https://bugs.webkit.org/show_bug.cgi?id=58574
Otherwise, items that would have caused more weak handle marking are
processed after all weak handle marking has finished, and referenced
weak handles get recycled.
- heap/HandleHeap.cpp: (JSC::HandleHeap::markWeakHandles): Removed looping from here, since we want Heap::markRoots to be responsible for draining the mark stack.
- heap/Heap.cpp: (JSC::Heap::markRoots): Moved looping to here, as explained above.
For efficiency's sake, drain the mark stack before starting to mark weak
handles. Otherwise, items drained while marking weak handles may force
an extra trip through the weak handle list.
For correctness's sake, drain the mark stack each time through the weak
handle list. Otherwise, opaque roots that would make weak handles reachable
are not discovered until after weak handle marking is over.
- 4:13 PM Changeset in webkit [83909] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/8665102> and https://bugs.webkit.org/show_bug.cgi?id=58595
Menu is not displayed for <input type=search results="5">
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::enabled): Return true, like all good search popup menus should.
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData): Remember the shouldPopOver-ness.
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode): Remember the shouldPopOver-ness.
(WebKit::PlatformPopupMenuData::decode): Remember the shouldPopOver-ness.
- Shared/PlatformPopupMenuData.h:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Use the shouldPopOver-ness to adjust display position.
- 4:12 PM Changeset in webkit [83908] by
-
- 3 edits in trunk/Tools
2011-04-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
only show expected failure type for ports that use an expectations file
https://bugs.webkit.org/show_bug.cgi?id=58588
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- 4:08 PM Changeset in webkit [83907] by
-
- 2 edits in trunk/LayoutTests
Add a comment with the bugzilla URL that tracks implementing
layoutTestController.setPluginsEnabled() in WebKitTestRunner.
- platform/mac-wk2/Skipped:
- 3:55 PM Changeset in webkit [83906] by
-
- 3 edits in trunk/Tools
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue fails to catch IOError when results.html is missing
https://bugs.webkit.org/show_bug.cgi?id=58589
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:48 PM Changeset in webkit [83905] by
-
- 3 edits1 delete in trunk/LayoutTests
2011-04-14 Chris Rogers <crogers@google.com>
Unreviewed.
Rebaseline fast/box-shadow/box-shadow-transformed.html
and other test_expectations.txt fixup
https://bugs.webkit.org/show_bug.cgi?id=58585
- platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Removed.
- platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [83904] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Mark several tests as only failing in Linux debug, add a bug
number.
- platform/chromium/test_expectations.txt:
- 3:32 PM Changeset in webkit [83903] by
-
- 2 edits in trunk/Tools
[wx] Unreviewed build fix for Mac installation script.
- 3:22 PM Changeset in webkit [83902] by
-
- 2 edits in trunk/Tools
2011-04-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
sort columns in the new json_results.html file
https://bugs.webkit.org/show_bug.cgi?id=58581
Also fix padding on TDs and the path to layout tests.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 3:16 PM Changeset in webkit [83901] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Crash in NetscapePluginModule::tryGetSitesWithData when NPP_GetSitesWithData returns null
https://bugs.webkit.org/show_bug.cgi?id=58578
<rdar://problem/9275201>
It's OK for NPP_GetSitesWithData to return null.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryGetSitesWithData):
- 3:14 PM Changeset in webkit [83900] by
-
- 16 edits in trunk
Simplifying Worker termination sequence (removing unnecessary mutex)
https://bugs.webkit.org/show_bug.cgi?id=57090
Reviewed by David Levin.
Source/WebCore:
No new tests. Existing Worker tests should pass.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
Check for Terminator-caused exception (or Terminator::shouldTerminate since sometimes
JS might not run significant enough chunk to be terminated by Terminator) and set
the flag to forbid future reentry into JS.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
- bindings/js/WorkerScriptController.h:
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
- bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::proxy):
Symmetrical changes to JSC and V8 WorkerScriptControllers:
- remove Mutex around operations with executionForbidden flag.
- set/check that flag only on Worker thread.
- some renaming in attempt to better reflect what the methods do.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
Check for v8::TryCatch::CanContinue() and set forbidExecution flag.
This result indicates that TerminateExecution() was in effect - we should
not reenter V8 anymore after that.
- dom/Document.h:
(WebCore::Document::isJSExecutionForbidden):
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
Stop dispatching messages once the worker context started to close.
Per Workers spec, once WorkerGlobalScope.Close() is called, the next
JS execution does not happen, including onmessage events. Before this
change, Close() was setting the forbidExecution flag, indirectly stopping
events from dispatching.
- dom/ScriptExecutionContext.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::close):
(WebCore::WorkerContext::isJSExecutionForbidden):
- workers/WorkerContext.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
LayoutTests:
- fast/workers/resources/shared-worker-lifecycle.js:
(createWorkerFrame): Fixing flaky worker test - removing document.write().
When document.write() is called directly from inline script as in this test, it appends to the document.
However, if worker threads from previously run test are still exiting,
the test defers itself using setTimeout() and in this case document.write() overwrites the whole document
and makes the test fail.
- 3:09 PM Changeset in webkit [83899] by
-
- 5 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=56493
Drag-scrolling overlay scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688>
Reviewed by Simon Fraser.
There was an original change to fix this in the normal hit-testing case, but hit
testing of transformed and/or positioned objects was still broken. The transformed
case is fixed by sending an OverlayScrollbarSizeRelevancy parameter to
calculateRects(). Getting positioned objects right is a little trickier. Those need
to opt into using temporary clip rects during hit testing. To avoid doing that when
it is not necessary, I added a new bit to ScrollView to track whether there are
currently overlay scrollbars painted in the view.
- platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(WebCore::ScrollView::containsScrollableAreaWithOverlayScrollbars):
(WebCore::ScrollView::setContainsScrollableAreaWithOverlayScrollbars):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
- rendering/RenderLayer.h:
- 2:59 PM Changeset in webkit [83898] by
-
- 5 edits in trunk/Source
Versioning.
- 2:55 PM Changeset in webkit [83897] by
-
- 1 copy in tags/Safari-534.29
New tag.
- 2:46 PM Changeset in webkit [83896] by
-
- 8 edits2 adds in trunk
REGRESSION(r74107): Including svg format in @font-face rules makes Web Fonts fail to load
https://bugs.webkit.org/show_bug.cgi?id=57766
<rdar://problem/9232183>
Reviewed by Oliver Hunt.
Source/WebCore:
Move the knowledge of whether to interpret a font as SVG from CachedFont to CSSFontFaceSource. This way
we can try to interpret the same cached resource in multiple ways.
Test: fast/css/font-face-repeated-url.html
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
(WebCore::CSSFontFaceSource::setHasExternalSVGFont):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::ensureSVGFontData):
Use TextResourceDecoder correctly.
(WebCore::CachedFont::getSVGFontById):
- loader/cache/CachedFont.h:
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
LayoutTests:
- fast/css/font-face-repeated-url-expected.txt: Added.
- fast/css/font-face-repeated-url.html: Added.
- 2:39 PM Changeset in webkit [83895] by
-
- 3 edits in trunk/Source/WebKit2
Make creating WebPreferences lazy
https://bugs.webkit.org/show_bug.cgi?id=58570
Reviewed by Anders Carlsson.
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
- UIProcess/WebPageGroup.h:
Don't create the WebPreference object until it is requested.
- 2:36 PM ThreadCommunication edited by
- (diff)
- 2:09 PM Changeset in webkit [83894] by
-
- 2 edits in trunk/Source/JavaScriptCore
Temporarily remove assertion that's firing all the time.
RS=Anders
- 2:01 PM Changeset in webkit [83893] by
-
- 4 edits in trunk/Source/WebCore
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Enable building Web Audio with MKL in Chrome-branded builds
https://bugs.webkit.org/show_bug.cgi?id=58561
Factored out MKL support into a separate GYP file that is
incorporated in Chrome-branded builds. Changed how the FFTFrame
implementations are pulled in and chosen so that all files can be
unconditionally compiled.
Tested with both Chrome-branded build (incorporating MKL) and
Chromium build (building just FFTFrameStub.cpp) on Linux.
- WebCore.gyp/WebCore.gyp:
- platform/audio/fftw/FFTFrameFFTW.cpp:
- platform/audio/mkl/FFTFrameMKL.cpp:
- 1:53 PM Changeset in webkit [83892] by
-
- 7 edits in trunk/Source
2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
Adjust Web inspector to highlight elements on the page when the mouse
hovers the element on DOM inspector.
- Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::highlight): (WebCore::InspectorClientQt::hideHighlight):
2011-04-14 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
We should call drawNodeHighlight() just if a highlighted node exists
to avoid do save()/restore() on the Graphics Context unnecessarily.
Added highlightedNode() method to check if we need to call drawNodeHighlight()
and only on this case do save()/restore() on the Graphics Context.
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::highlightedNode):
- 1:50 PM Changeset in webkit [83891] by
-
- 4 edits in trunk/Source
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData should return 1 tile when tile size is texture size.
https://bugs.webkit.org/show_bug.cgi?id=58364
- platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles):
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData should return 1 tile if tile size is texture size.
https://bugs.webkit.org/show_bug.cgi?id=58364
Update test to properly handle this case.
- tests/TilingDataTest.cpp: (WebCore::TEST):
- 1:39 PM Changeset in webkit [83890] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Update chromium expectations for tests that have subtle 32vs64 bit rendering differences on linux in the GPU path.
- platform/chromium/test_expectations.txt:
- 1:34 PM Changeset in webkit [83889] by
-
- 3 edits4 adds in trunk
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r72141): Acid3 rendering is not pixel perfect.
https://bugs.webkit.org/show_bug.cgi?id=55734
- fast/text/zero-font-size.html: Added.
- platform/mac/fast/text/zero-font-size-expected.checksum: Added.
- platform/mac/fast/text/zero-font-size-expected.png: Added.
- platform/mac/fast/text/zero-font-size-expected.txt: Added.
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r72141): Acid3 rendering is not pixel perfect.
https://bugs.webkit.org/show_bug.cgi?id=55734
WebCore should render text with a 0px font size at 0px regardless of
minimum font size settings. This is compatible with other browsers that
have a minimum font size preference and ensures pixel-perfect rendering
on Acid3.
Test: fast/text/zero-font-size.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If specifiedSize is 0, return specified size regardless of zoom factor or minimum font size.
- 1:31 PM Changeset in webkit [83888] by
-
- 4 edits2 adds in trunk
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
Test: fast/canvas/drawImageFromRect_withToDataURLAsSource.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
- html/canvas/CanvasRenderingContext2D.h:
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
- fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt: Added.
- fast/canvas/drawImageFromRect_withToDataURLAsSource.html: Added.
- 1:26 PM Changeset in webkit [83887] by
-
- 4 edits17 deletes in trunk
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535
Remove unnecessary baselines - the behavior on these tests should
match the mac port now.
- platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
- platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
- platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
- platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
- platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
- platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535
Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::shouldCompositeOverflowControls):
- 1:24 PM Changeset in webkit [83886] by
-
- 2 edits in trunk/LayoutTests
[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52810
https://bugs.webkit.org/show_bug.cgi?id=52812
- platform/qt/Skipped: Add svg/text/text-align-05-b.svg
- 1:17 PM Changeset in webkit [83885] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make protected object list in caches window reflect reality
https://bugs.webkit.org/show_bug.cgi?id=58565
Make sure the heap includes objects protected by Strong handles
in its list of protected objects.
- heap/HandleHeap.h:
- heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
- 1:13 PM Changeset in webkit [83884] by
-
- 44 edits3 moves in trunk
BlobBuilder should be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=58518
Reviewed by Darin Fisher.
Source/WebCore:
Renamed BlobBuilder to WebKitBlobBuilder.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.
(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):
- fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.
(WebCore::WebKitBlobBuilder::create):
- fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
LayoutTests:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
- fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
- fast/dom/script-tests/prototype-inheritance.js:
- fast/dom/window-domurl-crash.html:
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test.html:
- fast/files/resources/read-blob-test-cases.js:
(testReadingTripleSlicedHybridBlob):
- fast/files/resources/read-common.js:
(buildBlob):
- fast/files/workers/inline-worker-via-blob-url.html:
- fast/filesystem/resources/file-writer-events.js:
(tenXBlob):
(startWrite):
- fast/filesystem/resources/file-writer-gc-blob.js:
(tenXBlob):
(startWrite):
- fast/filesystem/resources/file-writer-sync-truncate-extend.js:
- fast/filesystem/resources/file-writer-sync-write-overlapped.js:
- fast/filesystem/resources/file-writer-utils.js:
- fast/js/global-constructors-expected.txt:
- fast/js/script-tests/global-constructors.js:
- http/tests/fileapi/create-blob-url-from-data-url.html:
- http/tests/local/blob/resources/hybrid-blob-util.js:
(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):
- http/tests/security/resources/create-filesystem-file.html:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/fast/dom/window-domurl-crash-expected.txt:
- 12:54 PM Changeset in webkit [83883] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Adam Barth <abarth@webkit.org>
Remove some trailing whitespace. I'm making this change to initialize
the SVN credentials on a new commit-queue machine. I'm sure there's a
better way to do this, but I don't know it.
- dom/Document.cpp: (WebCore::Document::Document):
- 12:50 PM Changeset in webkit [83882] by
-
- 13 edits in trunk
Set minimum priority for fast lane connections
https://bugs.webkit.org/show_bug.cgi?id=58353
Reviewed by David Kilzer.
Source/WebCore:
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMinimumFastLanePriority to allow javascript resources to use the fast
lane connections.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
WebKitLibraries:
Add WKSetHTTPPipeliningMinimumFastLanePriority.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 11:55 AM Changeset in webkit [83881] by
-
- 4 edits in trunk/Tools
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
queues.webkit.org should display when a bot last passed a patch
https://bugs.webkit.org/show_bug.cgi?id=58546
I am suspicious that some of our commit-queue instances are never
actually passing anything.
This will let us know if those bots are never passing patches.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/index.yaml:
- QueueStatusServer/templates/queuestatus.html:
- 11:53 AM Changeset in webkit [83880] by
-
- 3 edits in trunk/Tools
2011-04-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Roben.
REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
https://bugs.webkit.org/show_bug.cgi?id=58545
Remove platform-specific overrides; the default behavior should
be working everywhere now, I think.
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- 11:52 AM Changeset in webkit [83879] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4.0
2011-04-14 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Martin Robinson.
Bump version to 1.4.0.
- configure.ac:
- 11:46 AM Changeset in webkit [83878] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixed tests caused by r83873.
- fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
- 11:33 AM Changeset in webkit [83877] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/transforms/scrollIntoView-transformed.html fails
https://bugs.webkit.org/show_bug.cgi?id=58559
- platform/qt/Skipped: Add fast/transforms/scrollIntoView-transformed.html until fix.
- 11:23 AM Changeset in webkit [83876] by
-
- 5 edits in trunk/Tools
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queues are hitting an exception trying to land when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=58558
Just an un-tested (and thus broken) code path from yesterday's changes.
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 11:19 AM Changeset in webkit [83875] by
-
- 5 edits in trunk/Source/WebCore
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Fix Web Audio build on Linux Debug and with stub FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=58555
Built Chromium/Linux in Debug mode to test.
- platform/audio/FFTFrame.cpp:
- platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::initialize):
- webaudio/AudioContext.cpp:
- webaudio/DefaultAudioDestinationNode.cpp:
- 11:13 AM Changeset in webkit [83874] by
-
- 6 edits in trunk/Source/WebCore
2011-04-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: add initial implementation of WorkerScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=58552
- bindings/v8/DebuggerScript.js:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): each worker context now have a debug id (similar to frame contexts).
- bindings/v8/WorkerScriptDebugServer.cpp: (WebCore::retrieveWorkerContext): (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener): (WebCore::WorkerScriptDebugServer::getDebugListenerForContext): (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): run message loop until debugger command is received and execution is resumed. (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
- bindings/v8/WorkerScriptDebugServer.h:
- inspector/WorkerDebuggerAgent.cpp: (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
- 11:10 AM Changeset in webkit [83873] by
-
- 13 edits2 adds in trunk
Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
https://bugs.webkit.org/show_bug.cgi?id=58496
Reviewed by Darin Fisher.
Source/WebCore:
Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.
Test: fast/files/blob-slice-test.html
- fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice):
- fileapi/Blob.h:
- fileapi/Blob.idl:
LayoutTests:
Added a new test to test the new behavior and also update all existing
tests to use the new name.
- fast/dom/Window/window-properties.html:
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test-expected.txt: Added.
- fast/files/blob-slice-test.html: Added.
- fast/files/resources/read-blob-test-cases.js:
(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):
- fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
- http/tests/local/blob/script-tests/send-hybrid-blob.js:
():
- http/tests/local/blob/script-tests/send-sliced-data-blob.js:
(runSliceTest):
- http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:
(onStableFileDrop):
(onUnstableFileDrop):
- http/tests/local/formdata/resources/send-form-data-common.js:
(testSendingFormData):
- 11:10 AM Changeset in webkit [83872] by
-
- 4 edits in trunk/Source/WebKit2
Clang warning fixes.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/mac/TextCheckerMac.mm:
- WebProcess/Downloads/mac/DownloadMac.mm:
- 10:53 AM Changeset in webkit [83871] by
-
- 3168 edits2 adds in trunk
[Qt] Height of "Ahem" font differs from all other ports.
https://bugs.webkit.org/show_bug.cgi?id=57954
Source/WebCore:
Patch by Andreas Kling <kling@webkit.org> on 2011-04-14
Reviewed by Benjamin Poulain.
QFontMetricsF::descent() returns the actual descent minus 1,
to account for the baseline. Add it back to get correct metrics
for WebKit.
QFontMetricsF::leading() may return negative values on some
platforms (those using FreeType), this breaks WebKit's assumption
that lineSpacing >= (ascent + descent), so we work around this in
the same fashion as SimpleFontDataFreeType and SimpleFontDataPango.
This is covered by thousands of layout tests.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
- platform/qt/ [...]: Update expected files.
- 10:47 AM Changeset in webkit [83870] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-04-14 Tony Chang <tony@chromium.org>
Reviewed by Adam Roben.
make PrettyPatch.rb aware of checksums in png files
https://bugs.webkit.org/show_bug.cgi?id=58387
Patch v2 with nil checks in the case of file adds and deletes.
- PrettyPatch/PrettyPatch.rb:
- 10:26 AM Changeset in webkit [83869] by
-
- 8 edits in trunk
[wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
- 10:21 AM Changeset in webkit [83868] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
RuntimeApplicationChecks.h needs to be a private header so WebKit can find it.
- WebCore.xcodeproj/project.pbxproj:
- 10:20 AM ThreadCommunication edited by
- (diff)
- 10:10 AM Changeset in webkit [83867] by
-
- 8 edits in trunk/Source/WebKit2
WebKit2: Add an option for a PageGroup to be invisible to the History Client.
https://bugs.webkit.org/show_bug.cgi?id=58547
Reviewed by Timothy Hatcher.
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorPageGroup):
The Web Inspector should not be visible to the History Client, because its HTML-based nature
should not be exposed through the API.
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):
- UIProcess/WebPageGroup.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
Do not send the message to the WebContent for the history client.
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
Ditto.
(WebKit::WebFrameLoaderClient::setTitle):
Ditto.
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):
- 9:57 AM Changeset in webkit [83866] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r83864.
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._childNodeRemoved):
- 9:48 AM April 2011 Meeting edited by
- (diff)
- 9:47 AM Changeset in webkit [83865] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Content area highlight does not cover scrollbars
https://bugs.webkit.org/show_bug.cgi?id=58528
- inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
- 9:18 AM Changeset in webkit [83864] by
-
- 16 edits1 add1 delete in trunk
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038
- inspector/debugger/dom-breakpoints.html:
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Removed.
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.NativeBreakpointsSidebarPane.prototype._reset): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMAgent.prototype._childNodeRemoved):
- inspector/front-end/DOMBreakpointsSidebarPane.js: Added. (WebInspector.DOMBreakpointsSidebarPane): (WebInspector.DOMBreakpointsSidebarPane.prototype.setInspectedURL): (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu.toggleBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu): (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend): (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.formatters.s): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.append): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage): (WebInspector.DOMBreakpointsSidebarPane.prototype.nodeRemoved): (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpointsForNode): (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.DOMBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.DOMBreakpointsSidebarPane.prototype._createBreakpointId): (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.DOMBreakpointsSidebarPane.prototype.restoreBreakpoints):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.coalesceCollapsedCrumbs):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage): (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
- inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype._set):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.inspectedURLChanged):
- inspector/front-end/utilities.js: ():
- 9:00 AM Changeset in webkit [83863] by
-
- 4 edits in releases/WebKitGTK/webkit-1.4.0
Merging r83728.
- 9:00 AM April 2011 Meeting edited by
- (diff)
- 8:51 AM Changeset in webkit [83862] by
-
- 3 edits2 adds in trunk
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
- fast/speech/input-readonly-and-disabled-expected.txt: Added.
- fast/speech/input-readonly-and-disabled.html: Added.
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
Test: fast/speech/input-readonly-and-disabled.html
- html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
- 8:49 AM Changeset in webkit [83861] by
-
- 7 edits in trunk
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
- inspector/Inspector.json:
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
- inspector/InspectorDatabaseAgent.h:
- inspector/front-end/inspector.js:
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
- http/tests/inspector-enabled/database-open.html:
- 8:47 AM Changeset in webkit [83860] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Anders Carlsson.
Don't emit RegExp tables for chromium where they are not used
https://bugs.webkit.org/show_bug.cgi?id=58544
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- create_regex_tables: Added the "--notables" command line argument.
- 8:25 AM Changeset in webkit [83859] by
-
- 76 edits12 adds23 deletes in trunk/LayoutTests
2011-04-14 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r83855.
http://trac.webkit.org/changeset/83855
After r83847 has been rolled out, these expectations no longer
apply.
- platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
- platform/chromium-gpu-linux/media/video-no-audio-expected.png:
- platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
- platform/chromium-gpu-mac/media/video-no-audio-expected.png:
- platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-win/media/video-display-toggle-expected.png:
- platform/chromium-gpu-win/media/video-no-audio-expected.png:
- platform/chromium-gpu-win/media/video-volume-slider-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-linux/fast/layers/video-layer-expected.png:
- platform/chromium-linux/media/audio-controls-rendering-expected.png:
- platform/chromium-linux/media/controls-after-reload-expected.png:
- platform/chromium-linux/media/controls-strict-expected.png:
- platform/chromium-linux/media/controls-styling-expected.png:
- platform/chromium-linux/media/controls-without-preload-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/video-controls-rendering-expected.png:
- platform/chromium-linux/media/video-display-toggle-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.png:
- platform/chromium-linux/media/video-no-audio-expected.png:
- platform/chromium-linux/media/video-volume-slider-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
- platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.png:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Added.
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.checksum: Added.
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.checksum: Added.
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.checksum: Added.
- platform/chromium-mac/media/controls-styling-expected.png:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
- platform/chromium-mac/media/controls-without-preload-expected.png:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum: Added.
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.checksum: Added.
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.checksum: Added.
- platform/chromium-mac/media/video-empty-source-expected.png:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.checksum: Added.
- platform/chromium-mac/media/video-volume-slider-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win/fast/layers/video-layer-expected.png:
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.png:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.png:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.png:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.png:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- 8:23 AM Changeset in webkit [83858] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r83847.
http://trac.webkit.org/changeset/83847
https://bugs.webkit.org/show_bug.cgi?id=58477
Chromium media controls do use button borders, so this change
is incorrect.
- css/mediaControls.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- 8:15 AM Changeset in webkit [83857] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed test fix for r83849.
It was flaky.
- http/tests/inspector-enabled/database-open.html:
- 7:42 AM Changeset in webkit [83856] by
-
- 1 edit20 adds in trunk/LayoutTests
Add new Windows expected results after r83820
Windows differs from Mac on these tests due to extra scrollbar layers. Presumably this is
because Mac uses native scrollbars for frames, and thus can't put them into layers.
<http://webkit.org/b/58535> tracks the difference, but will probably just be closed as
"works correctly".
- platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
- platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
- platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
- platform/win/compositing/overflow/resize-painting-expected.txt: Added.
- 7:36 AM Changeset in webkit [83855] by
-
- 76 edits23 adds12 deletes in trunk/LayoutTests
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Updated/added chromium test expectation for media controls tests following CSS change in r83847.
- platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Added.
- platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
- platform/chromium-gpu-linux/media/video-no-audio-expected.png:
- platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
- platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
- platform/chromium-gpu-mac/media/video-no-audio-expected.png:
- platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/controls-after-reload-expected.png: Added.
- platform/chromium-gpu-win/media/controls-strict-expected.png: Added.
- platform/chromium-gpu-win/media/controls-styling-expected.png: Added.
- platform/chromium-gpu-win/media/controls-without-preload-expected.png: Added.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
- platform/chromium-gpu-win/media/video-display-toggle-expected.png:
- platform/chromium-gpu-win/media/video-no-audio-expected.png:
- platform/chromium-gpu-win/media/video-volume-slider-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Added.
- platform/chromium-linux/fast/layers/video-layer-expected.png:
- platform/chromium-linux/media/audio-controls-rendering-expected.png:
- platform/chromium-linux/media/controls-after-reload-expected.png:
- platform/chromium-linux/media/controls-strict-expected.png:
- platform/chromium-linux/media/controls-styling-expected.png:
- platform/chromium-linux/media/controls-without-preload-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/video-controls-rendering-expected.png:
- platform/chromium-linux/media/video-display-toggle-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.png:
- platform/chromium-linux/media/video-no-audio-expected.png:
- platform/chromium-linux/media/video-volume-slider-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.checksum: Removed.
- platform/chromium-mac/fast/layers/video-layer-expected.png:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Removed.
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.checksum: Removed.
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.checksum: Removed.
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.checksum: Removed.
- platform/chromium-mac/media/controls-styling-expected.png:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.checksum: Removed.
- platform/chromium-mac/media/controls-without-preload-expected.png:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Removed.
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum: Removed.
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.checksum: Removed.
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.checksum: Removed.
- platform/chromium-mac/media/video-empty-source-expected.png:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.checksum: Removed.
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.checksum: Removed.
- platform/chromium-mac/media/video-volume-slider-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win/fast/layers/video-layer-expected.png:
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.png:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.png:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.png:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.png:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- 7:01 AM Changeset in webkit [83854] by
-
- 1 edit4 adds in trunk/LayoutTests
Add Windows results for new tests added in r83787
Windows differs from the cross-platfom results due to <http://webkit.org/b/57334>.
- platform/win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
- platform/win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
- platform/win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
- platform/win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
- 6:59 AM Changeset in webkit [83853] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Andreas Kling.
Fix GraphicsContext3DQt.cpp compilation warnings treated as errors
https://bugs.webkit.org/show_bug.cgi?id=58478
No new tests.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::getProcAddress): Do not use deprecated QString constructor to avoid warning. (WebCore::GraphicsContext3D::reshape): Use parenthesis to avoid warning.
- 6:59 AM Changeset in webkit [83852] by
-
- 2 edits in trunk/Source/WebKit/win
Replace some known-to-fail assertions with FIXMEs
These assertions get hit during various layout tests. They indicate that we're sometimes
doing some extra work when a page goes into accelerated compositing mode, but otherwise
there's no bad effect.
See <http://webkit.org/b/58539> for more details.
Rubber-stamped by John Sullivan.
- WebView.cpp:
(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Replaced assertions with FIXMEs.
- 6:48 AM Changeset in webkit [83851] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Removed ScrollableArea::paintScrollCorner() added in r83820,
as it breaks chromium clang build (shadowed by RenderLayer::paintScrollCorner()
with a different signature)
- platform/ScrollableArea.h:
- 6:42 AM Changeset in webkit [83850] by
-
- 8 edits in trunk
2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58534
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode.prototype.get data):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshot.prototype._numbersComparator): (WebInspector.HeapSnapshot.prototype.baseSnapshotHasNode): (WebInspector.HeapSnapshot.prototype.updateBaseNodeIds): (WebInspector.HeapSnapshotsDiff): (WebInspector.HeapSnapshotsDiff.prototype.set baseIds): (WebInspector.HeapSnapshotsDiff.prototype.set baseSelfSizes): (WebInspector.HeapSnapshotsDiff.prototype.calculate):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy): (WebInspector.HeapSnapshotProxy.prototype.createDiff): (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.dispose): (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy): (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58534
- inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest):
- inspector/profiler/heap-snapshot-test.js: (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock): (initialize_HeapSnapshotTest):
- 6:35 AM Changeset in webkit [83849] by
-
- 5 edits in trunk/Source/WebCore
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
- inspector/Inspector.json:
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
- inspector/InspectorDatabaseAgent.h:
- inspector/front-end/inspector.js:
- 6:31 AM Changeset in webkit [83848] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] "Remove Breakpoint" menu item is absent in the DOM breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=58530
- inspector/front-end/ElementsPanel.js:
- 6:22 AM Changeset in webkit [83847] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r83397) [Qt] When clicking on the media elements they
grow 2 pixels.
https://bugs.webkit.org/show_bug.cgi?id=58477
Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size.
- css/mediaControls.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- 6:17 AM Changeset in webkit [83846] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Diego Gonzalez <diegohcg@webkit.org>
[Qt] Improve disable style for input elements in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58480
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/QtMobileWebStyle.cpp:
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawComplexControl):
- 5:54 AM Changeset in webkit [83845] by
-
- 4 edits in trunk/Source/WebCore
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: restore previous selection in Resources panel upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=58533
- inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
- inspector/front-end/inspector.css: (#close-button-left, #close-button-right):
- 5:52 AM Changeset in webkit [83844] by
-
- 1 edit8 adds in trunk/LayoutTests
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium baselines for SVG tests added in r83821.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- 5:46 AM Changeset in webkit [83843] by
-
- 7 edits in trunk
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS free flow editing.
https://bugs.webkit.org/show_bug.cgi?id=58529
- inspector/styles/get-set-stylesheet-text.html:
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS free flow editing.
https://bugs.webkit.org/show_bug.cgi?id=58529
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleSheet.prototype.setText):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isResourceRevision): (WebInspector.Resource.prototype.setContent):
- inspector/front-end/ResourceView.js: (WebInspector.CSSSourceFrame.prototype.isContentEditable): (WebInspector.CSSSourceFrame.prototype.editContent): (WebInspector.CSSSourceFrame.prototype.endEditing.commitIncrementalEdit): (WebInspector.CSSSourceFrame.prototype.endEditing):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.editContent):
- 5:38 AM Changeset in webkit [83842] by
-
- 13 edits in trunk/Source/WebKit2
2011-04-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719
Guard functionality related to complex text and implementations
that rely on MachPort with PLATFORM(MAC).
Based on Oleg Romashin's patch.
- PluginProcess/PluginControllerProxy.cpp:
- PluginProcess/PluginControllerProxy.messages.in:
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection):
- PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin):
- Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::decode): Fix bad C++ that does not compile with gcc-linux.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch): (WebKit::PluginProcessProxy::didCreateWebProcessConnection):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- WebKit2.pro: Move implementation that does not need external visibility from WebKit2API.pri. Adding the headers as well.
- WebKit2API.pri:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/WebPage/WebPage.cpp:
- 5:32 AM Changeset in webkit [83841] by
-
- 4 edits in trunk/Source/WebCore
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector:Duplicated display of storage db when running Web SQL from an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57830
There was created a new InspectorDatabaseResource entry for every didOpenDatabase event.
Moreover there is new WebCore::Database for each didOpenDatabase event.
I decided to change the old instance of the Database to a new one if they both use the same file.
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::findByFileName):
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::setDatabase):
- 5:26 AM Changeset in webkit [83840] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
https://bugs.webkit.org/show_bug.cgi?id=58525
Unskip svgdom-over-01-f.svg, since it is now passing.
- platform/gtk/Skipped:
- 5:16 AM Changeset in webkit [83839] by
-
- 3 edits in trunk/Source/WebCore
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
https://bugs.webkit.org/show_bug.cgi?id=58525
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-04-14
Reviewed by Dirk Schulze.
A renderer is created even for those filter primitives
which parent is not a filter. A rendererIsNeeded() is
added to SVGFilterPrimitiveStandardAttributes.
Test: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- 5:12 AM Changeset in webkit [83838] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
REGRESSION(r83397) [Qt] When the video is loading and the poster is shown
all the controls are not visible except the play button.
https://bugs.webkit.org/show_bug.cgi?id=58484
r83397 introduces a new API hasOwnDisabledStateHandlingFor to handle when
the controls should be disabled. Qt port paints its own controls, we don't want
the default implementation to handle the hidden/disable state for us.
Existing tests covers the visibility of the controls.
- platform/qt/RenderThemeQt.h: (WebCore::RenderThemeQt::hasOwnDisabledStateHandlingFor):
- 4:59 AM Changeset in webkit [83837] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disabled form controls don't actually look disabled.
https://bugs.webkit.org/show_bug.cgi?id=58490
Unsetting QStyle::State_Enabled is not enough to get the "disabled" appearance
when painting controls. We must also set the QStyleOption's palette's current
color group.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
- 4:41 AM Changeset in webkit [83836] by
-
- 5 edits in trunk
2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
Added additional test for parsing codecs parameter.
https://bugs.webkit.org/show_bug.cgi?id=58188
- media/video-can-play-type-expected.txt:
- media/video-can-play-type.html:
2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter
https://bugs.webkit.org/show_bug.cgi?id=58188
The codec parameter in MediaPlayerPrivateQt::supportsType was not parsed into
a QStringList. This change parses and trims the list.
An additional test was added to video-can-play-type.html to test parsing of codec parameter.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::supportsType):
- 4:20 AM Changeset in webkit [83835] by
-
- 6 edits3 adds in trunk/Source
Optimizing lightning filter to ARM-NEON SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=54456
Reviewed by Nikolas Zimmermann.
NEON is the SIMD instruction set for ARM. This instruction set
allows to speed-up the lighting filter by 4 times on ARM
(on WebCore/manual-tests/svg-filter-animation.svg).
- WebCore.pri:
- WebCore.pro:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::drawLighting):
(WebCore::getPowerCoefficients):
(WebCore::FELighting::drawInteriorPixels):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/arm/FELightingNEON.cpp: Added.
(attribute):
- platform/graphics/filters/arm/FELightingNEON.h: Added.
- 4:01 AM Changeset in webkit [83834] by
-
- 2 edits in trunk/Source/WebCore
2011-04-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Benjamin Poulain.
[Qt] GraphicsContext3D internal buffers are not freed
https://bugs.webkit.org/show_bug.cgi?id=57530
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
- 3:53 AM Changeset in webkit [83833] by
-
- 2 edits in trunk/LayoutTests
2011-04-14 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 2 failing tests.
- platform/gtk/Skipped: Skip http/tests/loading/onload-vs-immediate-refresh.pl and svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
- 3:46 AM Changeset in webkit [83832] by
-
- 13 edits1 move1 add1 delete in trunk/Source/WebCore
REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling
https://bugs.webkit.org/show_bug.cgi?id=52988
Reviewed by Maciej Stachowiak.
Safari RSS relies on synchronous dispatch of ScrollEvent to update the
position of its sidebar during scrolling without producing a jiggling
effect. Due to r75555, this event is no longer dispatched synchronously
which results in stale repaints before the onscroll handler gets a
chance to update the position of the sidebar.
Since it is impractical to resolve this issue in Safari RSS itself, add
a quirk that restores synchronous ScrollEvent dispatch for Safari RSS.
No tests. This is an app-specific change that doesn't affect web
content.
- Android.mk: Add platform/RuntimeApplicationChecks.[cpp|h]
- CMakeLists.txt: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/EventQueue.cpp:
(WebCore::shouldDispatchScrollEventSynchronously): Send ScrollEvent
synchronously if the embedding application is Safari and the document's
URL scheme is "feed" or "feeds".
(WebCore::EventQueue::enqueueOrDispatchScrollEvent): Dispatch
ScrollEvent synchronously if shouldDispatchScrollEventSynchronously()
returns true.
- dom/EventQueue.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent): Call enqueueOrDispatchScrollEvent().
- platform/RuntimeApplicationChecks.cpp: Added.
(WebCore::mainBundleIsEqualTo): Add a helper routine for CF platforms
that checks if the main bundle's identifier is equal to a given string.
This function returns false for non-CF platforms.
(WebCore::applicationIsSafari): Call mainBundleIsEqualTo().
(WebCore::applicationIsAppleMail): Ditto.
(WebCore::applicationIsMicrosoftMessenger): Ditto.
(WebCore::applicationIsAdobeInstaller): Ditto.
(WebCore::applicationIsAOLInstantMessenger): Ditto.
(WebCore::applicationIsMicrosoftMyDay): Ditto.
(WebCore::applicationIsMicrosoftOutlook): Ditto.
- platform/mac/RuntimeApplicationChecks.mm: Removed. Functions moved to
RuntimeApplicationChecks.cpp.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo): Call enqueueOrDispatchScrollEvent().
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollTo): Call enqueueOrDispatchScrollEvent().
- 2:56 AM Changeset in webkit [83831] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/ruby tests fail
https://bugs.webkit.org/show_bug.cgi?id=58523
- platform/qt/Skipped: Add failing tests.
- 2:44 AM Changeset in webkit [83830] by
-
- 3 edits1 move1 add2 deletes in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Chromium expectation update.
- platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt.
- platform/chromium/test_expectations.txt:
- 2:39 AM Changeset in webkit [83829] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-04-14 Bill Budge <bbudge@chromium.org>
Reviewed by Darin Fisher.
Make WebURLLoaderOptions disallow cross origin requests by default.
https://bugs.webkit.org/show_bug.cgi?id=58475
No new tests. Exposes no new functionality.
- public/WebURLLoaderOptions.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
- 2:27 AM Changeset in webkit [83828] by
-
- 5 edits in trunk/Source/WebCore
2011-04-14 John Bates <jbates@google.com>
Reviewed by Kenneth Russell.
Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop.
https://bugs.webkit.org/show_bug.cgi?id=58383
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::addChildContext): (WebCore::LayerRendererChromium::removeChildContext):
- platform/graphics/chromium/LayerRendererChromium.h:
- 2:27 AM Changeset in webkit [83827] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-14 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r83808.
It seams that the MSVC compiler for WinCE does not handle the friend scope correct.
Add an addtional inline function to StructureTransitionTable to work around this.
- runtime/Structure.h: (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
- 2:18 AM Changeset in webkit [83826] by
-
- 2 edits1 move in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Few more updates for r83820.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt.
- platform/chromium-gpu/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Renamed from LayoutTests/platform/chromium-gpu/compositing/layer-creation.
- platform/chromium/test_expectations.txt:
- 1:47 AM Changeset in webkit [83825] by
-
- 1 edit18 adds in trunk/LayoutTests
2011-04-14 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for new tests.
- platform/gtk/fast/borders/bidi-002-expected.checksum: Added.
- platform/gtk/fast/borders/bidi-002-expected.png: Added.
- platform/gtk/fast/borders/bidi-002-expected.txt: Added.
- platform/gtk/fast/borders/bidi-004-expected.checksum: Added.
- platform/gtk/fast/borders/bidi-004-expected.png: Added.
- platform/gtk/fast/borders/bidi-004-expected.txt: Added.
- platform/gtk/fast/borders/bidi-009a-expected.checksum: Added.
- platform/gtk/fast/borders/bidi-009a-expected.png: Added.
- platform/gtk/fast/borders/bidi-009a-expected.txt: Added.
- platform/gtk/fast/frames/iframe-outline-expected.checksum: Added.
- platform/gtk/fast/frames/iframe-outline-expected.png: Added.
- platform/gtk/fast/frames/iframe-outline-expected.txt: Added.
- platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
- platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
- platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- 1:45 AM Changeset in webkit [83824] by
-
- 13 edits9 deletes in trunk
2011-04-14 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Failing GPU video tests
https://bugs.webkit.org/show_bug.cgi?id=57926
Rebaseline images.
- platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Removed.
- platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
- platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Removed.
- platform/chromium-gpu-linux/media/video-no-audio-expected.png:
- platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Removed.
- platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
- platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Removed.
- platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
- platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Removed.
- platform/chromium-gpu-mac/media/video-no-audio-expected.png:
- platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Removed.
- platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
- platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Removed.
- platform/chromium-gpu-win/media/video-display-toggle-expected.png:
- platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Removed.
- platform/chromium-gpu-win/media/video-no-audio-expected.png:
- platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Removed.
- platform/chromium-gpu-win/media/video-volume-slider-expected.png:
- platform/chromium/test_expectations.txt:
2011-04-14 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Failing GPU video tests
https://bugs.webkit.org/show_bug.cgi?id=57926
Added/updated GPU directory names for rebaseline tool.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 1:27 AM Changeset in webkit [83823] by
-
- 4 edits in trunk/LayoutTests
2011-04-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Kent Tamura.
[chromium] http/tests/loading/preload-append-scan.php fails
https://bugs.webkit.org/show_bug.cgi?id=58352
On chromium, onload-vs-immediate-refresh always caused the subsequent test to fail
with an additional didFinishLoadForFrame message. This was because the test
navigates via a refresh, but did not actually wait for the navigation to complete.
This patch fixes that by adding a waitUntilDone() and calling notifyDone() after the
redirect target page loads. Now the log for this test shows both navigations and no
part of the navigation leaks into the next test.
Also, since dumpAsText() shows alerts, there was no reason to write vs. alert the
SUCCESS message.
- http/tests/loading/onload-vs-immediate-refresh-expected.txt:
- http/tests/loading/onload-vs-immediate-refresh.pl:
- platform/chromium/test_expectations.txt:
- 1:20 AM Changeset in webkit [83822] by
-
- 20 edits2 copies11 moves1 add18 deletes in trunk/LayoutTests
2011-04-14 James Robinson <jamesr@chromium.org>
Update expectations and baselines for r83820.
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
- platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Removed.
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
- platform/chromium-gpu-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
- platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt.
- platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt.
- platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt.
- platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
- platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt.
- platform/chromium-gpu/compositing/layer-creation: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
- platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt.
- platform/chromium/test_expectations.txt:
- 12:40 AM WikiStart edited by
- Added a link to "April 2011 Meeting" (diff)
- 12:14 AM Changeset in webkit [83821] by
-
- 13 edits20 adds in trunk
2011-04-14 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
Testing inherited CSS related SVG property changes by FEFlood, FESpecularLighting and FEDiffuseLighing filters.
Adding a missing test to check the dynamic update of lighting-color property of FESpecularLighting.
All the other modifications are covered by the existing dyanmic-update tests.
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Added.
- svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
- svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Added. (executeTest):
2011-04-14 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
The changes of some CSS related SVGFilter properties e.g. lighting_color, flood_color, flood_opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
- platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::setFloodColor): (WebCore::FEFlood::setFloodOpacity):
- platform/graphics/filters/FEFlood.h:
- platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setLightingColor):
- platform/graphics/filters/FESpecularLighting.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::setFilterEffectAttribute):
- svg/SVGFEFloodElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
