Timeline



May 10, 2011:

11:41 PM Changeset in webkit [86221] by yurys@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that browser doesn't crash if alert() arguments conversion throws to an exception
​https://bugs.webkit.org/show_bug.cgi?id=60541

  • inspector/console/alert-toString-exception-expected.txt: Added.
  • inspector/console/alert-toString-exception.html: Added.
  • platform/chromium/inspector/console/alert-toString-exception-expected.txt: Added.
11:41 PM Changeset in webkit [86220] by Stephanie Lewis
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

Revert accidental JavaScriptCore change in ​http://trac.webkit.org/changeset/86130

  • Configurations/JavaScriptCore.xcconfig:
11:12 PM Changeset in webkit [86219] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
​https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().
11:07 PM Changeset in webkit [86218] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr patch.

  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData):
11:03 PM Changeset in webkit [86217] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-10 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBufferFromRange): (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
  • platform/audio/HRTFElevation.cpp: (WebCore::HRTFElevation::createForSubject): (WebCore::HRTFElevation::createByInterpolatingSlices):
  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Reverb.cpp: (WebCore::Reverb::initialize):
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource): (WebCore::createBusFromInMemoryAudioFile):
10:56 PM Changeset in webkit [86216] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <​abarth@webkit.org>

Build fix for font data madness. I've had to whitelist this on several
ports. They need to all be fixed at once.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
10:35 PM Changeset in webkit [86215] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium rebaselines.

  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
10:34 PM Changeset in webkit [86214] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX for !ENABLE(TEXT_CARET) after r86039

  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::paintDragCaret): Added
UNUSED_PARAM(frame) for !ENABLE(TEXT_CARET).

10:32 PM Changeset in webkit [86213] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

EWS bots should be robust against test-webkitpy hangs
​https://bugs.webkit.org/show_bug.cgi?id=60579

Added a killAfterTimeout subroutine, which takes a child_pid
and timeout, and will setup a watchdog process to kill that child
after the timeout. killAfterTimeout will waitpid on the child.

  • EWSTools/start-queue.sh:
10:25 PM Changeset in webkit [86212] by morrita@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/editing

Merge 86132 - 2011-05-10 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
​https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

TBR=​levin@chromium.org
BUG=82238
Review URL: ​http://codereview.chromium.org/7005023

10:21 PM Changeset in webkit [86211] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-10 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=60502

Other platforms to follow.

  • wtf/PassOwnPtr.h:
9:59 PM Changeset in webkit [86210] by morrita@google.com
  • 2 edits in trunk/Tools

2011-05-10 MORITA Hajime <​morrita@google.com>

Unreviewed, moved myself to the reviewers list.

  • Scripts/webkitpy/common/config/committers.py:
9:50 PM WebKit Team edited by morrita@google.com
(diff)
7:29 PM Changeset in webkit [86209] by ggaren@apple.com
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

2011-05-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier
​https://bugs.webkit.org/show_bug.cgi?id=60532

  • heap/Handle.h: Moved HandleTypes to its own header because that's the WebKit style, and it was necessary to resolve a circular dependency between Handle.h and WriteBarrier.h.
  • heap/Heap.h: (JSC::Heap::writeBarrier): Added an inline no-op writeBarrier(), to verify that all the code is in the right place.
  • heap/MarkStack.h: Moved WriteBarrier operations to WriteBarrier.h to resolve a circular dependency.
  • runtime/ArgList.h:
  • runtime/JSCell.h: #include WriteBarrier.h since we don't get it for free anymore.
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): Call the real writeBarrier() function, now that it exists.
  • runtime/SmallStrings.h: Removed a stray #include to resolve a circular dependency.
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::set): (JSC::MarkStack::append): (JSC::MarkStack::appendValues): Updated to match the changes above.
7:28 PM Changeset in webkit [86208] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clean up setLayerRenderer() calls in LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=60524

This refactors the way LayerRendererChromium calls setLayerRenderer on its layers in a few ways to clean things
up:

*) Move the pre-paint call to setLayerRenderer from updatePropertiesAndRenderSurfaces() to paintLayerContents().

updatePropertiesAndRenderSurfaces() does too much and the layer renderer pointer only has to be up to date to do
the actual paint. Longer term we won't need to call this at all in order to call paint and this call will just
go away.

*) Tweaks updateCompositorResourcesRecursive() to be slightly shorter and less error-prone.
*) Explicitly set the LayerRendererChromium for each layer in the tree when transfering the root layer (used

during lost context). LayerChromium::setLayerRenderer checks if the new LayerRendererChromium is different
by comparing the pointer value to the old one. This check will be incorrect if there are multiple lost
contexts between a setLayerRenderer() call and a new LayerRendererChromium happens to be allocated at the
same address as the old one. An explicit call to setLayerRenderer() for every layer in the tree fixes this
since when this function is called the new and old LayerRendererChromium are still live and so they cannot
live at the same address.

The first two changes are purely refactors and do not change behavior. The third issue can't be tested via a
layout test directly as we don't have a way to induce a lost context on the compositor in a layout test.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::clearLayerRendererRecursive): (WebCore::LayerRendererChromium::transferRootLayer): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
7:18 PM Changeset in webkit [86207] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

7:11 PM Changeset in webkit [86206] by oliver@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Assertion failure in JSC::Structure::typeInfo when reloading weather.com video page
​https://bugs.webkit.org/show_bug.cgi?id=60580

The plugin object map was incorrect trying to implement a weak map itself using
destructors. Switch to a WeakGCMap and the problem is fixed.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::~JSNPObject):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateJSObject): (WebKit::NPRuntimeObjectMap::invalidate):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
6:53 PM Changeset in webkit [86205] by commit-queue@webkit.org
  • 18 edits
    4 adds in trunk

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
​https://bugs.webkit.org/show_bug.cgi?id=60558

  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Added.

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
​https://bugs.webkit.org/show_bug.cgi?id=60558

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html

storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html

Use SQLiteFileSystem::getDatabaseFileSize to get actual usage by
an origin's local storage db. Factored out code that retrieves
path of local storage db.

  • WebCore.exp.in: Sorted alphabetically StorageTracker's mangled function names.
  • storage/StorageTracker.cpp: (WebCore::StorageTracker::syncDeleteOrigin): Uses helper function to get path of origin's db (WebCore::StorageTracker::databasePathForOrigin): New helper function. that gets the path of an origin's local storage db from StorageTracker. (WebCore::StorageTracker::diskUsageForOrigin): New API.
  • storage/StorageTracker.h:

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by David Levin.

Add ApplicationCache API to get disk usage per origin
​https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
​https://bugs.webkit.org/show_bug.cgi?id=60558

  • DumpRenderTree/LayoutTestController.cpp: (localStorageDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
6:47 PM Changeset in webkit [86204] by commit-queue@webkit.org
  • 22 edits
    6 adds in trunk

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
​https://bugs.webkit.org/show_bug.cgi?id=57127

  • http/tests/appcache/origin-usage-expected.txt: Added.
  • http/tests/appcache/origin-usage.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.manifest: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
​https://bugs.webkit.org/show_bug.cgi?id=57127

ApplicationCacheStorage already provides an API to get per-origin
disk usage. This should be exposed through WebCore::ApplicationCache
to not be dependent on storage implementation.

Test: http/tests/appcache/origin-usage.html

  • WebCore.exp.in:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::diskUsageForOrigin):
  • loader/appcache/ApplicationCache.h:

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
​https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <​adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
​https://bugs.webkit.org/show_bug.cgi?id=57127

Added test that loads two frames with ~15Kb image, checks usage,
deletes app cache, verifies usage is 0.

  • DumpRenderTree/LayoutTestController.cpp: (applicationCacheDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::LayoutTestController): (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
6:44 PM Changeset in webkit [86203] by demarchi@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed, adding Rafael Antognolli as a committer.

  • Scripts/webkitpy/common/config/committers.py:
6:34 PM Changeset in webkit [86202] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Add some aggressive GC validation to debug builds.
​https://bugs.webkit.org/show_bug.cgi?id=60601

When assertions are enabled we now do some validity checking
of objects being added to the mark stack.

  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo): (JSC::PolymorphicAccessStructureList::visitAggregate):
  • heap/MarkStack.cpp: (JSC::MarkStack::validateSet): (JSC::MarkStack::validateValue):
  • heap/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
6:24 PM Changeset in webkit [86201] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-05-10 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
​https://bugs.webkit.org/show_bug.cgi?id=58378

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h: Add plumbing for new settings to Chromium DRT.
5:46 PM Changeset in webkit [86200] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Protect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
​https://bugs.webkit.org/show_bug.cgi?id=60594
<rdar://problem/9203259>

Reviewed by Alexey Proskuryakov.

No tests since we don't have any bots testing CFNETWORK_DATA_ARRAY_CALLBACK.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): The didReceiveData()
callback on client can result in the load being cancelled. This results in the delegate
(self) being freed. Protect self during the loop so we can check for m_handle and safely
return without crashing.

5:33 PM Changeset in webkit [86199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Chris Guillory <​chris.guillory@google.com>

Reviewed by James Robinson.

[ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint.
​https://bugs.webkit.org/show_bug.cgi?id=59848

To test this I plan to make the non-printing device (BitmapPlatformDevice) fail
when EndPlatformPaint doesn't matchup with BeginPlatformPaint.
​http://codereview.chromium.org/6949012/

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
5:19 PM Changeset in webkit [86198] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Yet more quarantine related sandbox denial when downloading files
<rdar://problem/9397494>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb:
5:10 PM Changeset in webkit [86197] by commit-queue@webkit.org
  • 23 edits
    1 delete in trunk/Source/WebCore

2011-05-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86195.
​http://trac.webkit.org/changeset/86195
​https://bugs.webkit.org/show_bug.cgi?id=60597

LayerOffset is a really bad name (Requested by smfr on
#webkit).

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Removed.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
5:06 PM Changeset in webkit [86196] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Convert x,y and width,height pairs to IntPoint and IntSize for RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=60409

Convert RenderLayer to use IntPoint for x,y pairs and IntSize for offsets and sizes.

Refactoring, covered by existing tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollTo): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::scrollWidth): (WebCore::RenderLayer::scrollHeight): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::x): (WebCore::RenderLayer::y): (WebCore::RenderLayer::setLocation): (WebCore::RenderLayer::width): (WebCore::RenderLayer::height): (WebCore::RenderLayer::size): (WebCore::RenderLayer::setWidth): (WebCore::RenderLayer::setHeight): (WebCore::RenderLayer::scrolledContentOffset): (WebCore::RenderLayer::scrollXOffset): (WebCore::RenderLayer::scrollYOffset): (WebCore::RenderLayer::scrollOffset): (WebCore::RenderLayer::scrollToXOffset): (WebCore::RenderLayer::scrollToYOffset): (WebCore::RenderLayer::relativePositionOffset):
4:45 PM Changeset in webkit [86195] by leviw@chromium.org
  • 23 edits
    1 add in trunk/Source/WebCore

2011-05-10 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Create LayerOffset class
​https://bugs.webkit.org/show_bug.cgi?id=60490

Adding a LayerOffset class that will replace existing usage of tx/ty.
LayerOffset is necessary since these values are commonly used as both
a size and a point. Updating paintIntoRect to use this new class.

No new tests since this doesn't change any behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Added. (WebCore::LayerOffset::LayerOffset): (WebCore::LayerOffset::x): (WebCore::LayerOffset::y): (WebCore::LayerOffset::setX): (WebCore::LayerOffset::setY): (WebCore::LayerOffset::toSize): (WebCore::LayerOffset::toPoint): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-): (WebCore::operator==): (WebCore::operator!=):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
4:37 PM Changeset in webkit [86194] by jam@chromium.org
  • 2 edits in branches/chromium/742/Source/WebKit/chromium

Revert 79703 - 2011-02-15 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
​https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

TBR=​brettw@chromium.org
BUG=81878
Review URL: ​http://codereview.chromium.org/7005016

4:32 PM Changeset in webkit [86193] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Make member variables of CaretBase private
​https://bugs.webkit.org/show_bug.cgi?id=60454

Moved m_absCaretBounds, m_absoluteCaretRepaintBounds, m_absCaretBoundsDirty, and m_caretPaint back
from CaretBase to FrameSelection because they are only used in FrameSelection, and made the rest
of member variables in CaretBase private.

  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Takes CaretVisibility as an argument. (WebCore::DragCaretController::DragCaretController): (WebCore::FrameSelection::FrameSelection): Initializes m_absCaretBoundsDirty and m_caretPaint now that they are part of FrameSelection again. (WebCore::DragCaretController::setCaretPosition): (WebCore::FrameSelection::setSelection): (WebCore::CaretBase::clearCaretRect): Extracted from updateCaretRect. (WebCore::CaretBase::updateCaretRect): No longer clears caret; all call sites (namely setCaretPosition and localCaretRect) that used to call updateCaretRect now need to call clearCaretRect or updateCaretRect based on some conditions. (WebCore::FrameSelection::localCaretRect): (WebCore::CaretBase::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::paintCaret): Only calls CaretBase::paintCaret if m_caretPaint is true. (WebCore::CaretBase::paintCaret): Removed an early exit for when m_caretPaint is false since m_caretPaint has been moved from CaretBase to FrameSelection. (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisibility): Takes CaretVisibility instead of bool. (WebCore::FrameSelection::caretBlinkTimerFired):
  • editing/FrameSelection.h: (WebCore::CaretBase::fastLocalCaretRect): Added; replaces localCaretRectForPainting. (WebCore::CaretBase::shouldUpdateCaretRect): Added. (WebCore::CaretBase::setCaretRectNeedsUpdate): Added. (WebCore::CaretBase::setCaretVisibility): Added. (WebCore::CaretBase::caretIsVisible): Added. (WebCore::FrameSelection::setCaretRectNeedsUpdate): Added.
4:28 PM Changeset in webkit [86192] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-10 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=58854

Regression test for ​http://crbug.com/79539.

  • http/tests/filesystem/no-cache-filesystem-url-expected.txt: Added.
  • http/tests/filesystem/no-cache-filesystem-url.html: Added.
4:24 PM Changeset in webkit [86191] by enrica@apple.com
  • 2 edits in trunk/Tools

Added my name to the reviewers list and removed my name from
to committer-only list.

Reviewed by Beth Dakin.

  • Scripts/webkitpy/common/config/committers.py:
4:14 PM WebKit Team edited by enrica@apple.com
(diff)
4:01 PM Changeset in webkit [86190] by jpu@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself as commiter.

3:57 PM Changeset in webkit [86189] by jamesr@google.com
  • 8 edits in trunk/Source/WebCore

2011-05-10 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

[chromium] Use parent/child terms for compositor tree structures consistently instead of superlayer/sublayer
​https://bugs.webkit.org/show_bug.cgi?id=60588

GraphicsLayer uses parent/child terminology for tree structure, as does CCLayerImpl. LayerChromium was using
superlayer/sublayer terms, inherited from this code's branching from the platform/graphics/win/CACF code. The
mixed terminology is confusing and parent/child is more common, so this unifies everything to use parent/child.

No new tests, refactor only.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToCanvas): (WebCore::GraphicsLayerChromium::setContentsToMedia): (WebCore::GraphicsLayerChromium::hostLayerForChildren): (WebCore::GraphicsLayerChromium::layerForParent): (WebCore::GraphicsLayerChromium::updateChildList): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::setupContentsLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::addChild): (WebCore::LayerChromium::insertChild): (WebCore::LayerChromium::removeFromParent): (WebCore::LayerChromium::removeChild): (WebCore::LayerChromium::replaceChild): (WebCore::LayerChromium::indexOfChild): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllChildren): (WebCore::LayerChromium::setChildren): (WebCore::LayerChromium::parent): (WebCore::LayerChromium::dumpLayer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::children): (WebCore::LayerChromium::setParent): (WebCore::LayerChromium::numChildren):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive): (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::descendantsDrawsContent):
  • platform/graphics/chromium/cc/CCLayerImpl.h:
3:45 PM Changeset in webkit [86188] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Switch RenderBoxModelObject::paintNinePieceImage to use IntRect instead of four ints
​https://bugs.webkit.org/show_bug.cgi?id=60586

Switch paintNinePieceImage to take an IntRect instead of four ints representing an IntRect!

No new tests as this is simply refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage): (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
3:44 PM Changeset in webkit [86187] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-10 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Coalesced wheel events should be saved to hand back to the client on unhandled return
​https://bugs.webkit.org/show_bug.cgi?id=60584

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): (WebKit::canCoalesce): (WebKit::coalesce): (WebKit::coalescedWheelEvent): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::processDidCrash): Reworks coalescing/merging code to happen on didReceiveEvent rather than in handleWheelEvent. This means we now store the pending events in a queue, and pull them out when we can.
  • UIProcess/WebPageProxy.h: Change single event containers to contain all pending/merged/coalesced events and remove unused flag.
3:43 PM Changeset in webkit [86186] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-09 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
​https://bugs.webkit.org/show_bug.cgi?id=60531

Remove the (unused) _isAnimating ivar and replace it with two ivars: _isEnteringFullScreen and
_isExitingFullScreen. These will ensure each is only called once per full screen request, and
that if one exit/enter request interrupts another, that the required functions are called in
order.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Removed _isAnimating. (-[WKFullScreenWindowController exitFullScreen]): Ditto. (-[WKFullScreenWindowController beganEnterFullScreenAnimation]): Gate on _isEnteringFullScreen. Check _isExitingFullScreen

and call [self finishedExitFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Gate on _isEnteringFullScreen.
(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Gate on _isExitingFullScreen. Check _isEnteringFullScreen

and call [self finishedEnterFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Gate on _isExitingFullScreen.

3:38 PM Changeset in webkit [86185] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

2011-05-05 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
​https://bugs.webkit.org/show_bug.cgi?id=60278

  • fullscreen/full-screen-remove-children-expected.txt: Added.
  • fullscreen/full-screen-remove-children.html: Added.
  • fullscreen/full-screen-test.js: Fixed an exception when running in Safari.

2011-05-05 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
​https://bugs.webkit.org/show_bug.cgi?id=60278

Handle the removal of a full screen element from within Node::willRemove() instead
of Document::nodeWillBeRemoved(). The new function Document::fullScreenElementWillBeRemoved() will
be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().

Test: fullscreen/full-screen-remove-children.html

  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element. (WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::willRemove): Check to see if this is the current full screen element.
3:37 PM Changeset in webkit [86184] by Beth Dakin
  • 15 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=60582
Crash switching overlay/non-overlay scrollbar preference still possible
-and corresponding-
<rdar://problem/9323983>

Reviewed by Darin Adler.

Source/WebCore:

This patch prevents any work from being done on pages that are in the page cache
when the preference is switched.

When the Document is going into or coming out of the page cache, have the
FrameView inactivate or activate the Page's ScrollAnimators as appropriate.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

Iterate through the Page's ScrollableAreas setting the active state of the
ScrollAnimators.

  • page/FrameView.cpp:

(WebCore::FrameView::setAnimatorsAreActive):

  • page/FrameView.h:

ScrollAnimator has a new bit -- m_isActive. Right now m_isActive is always true
unless the ScrollAnimator belongs to a ScrollableArea that is in the page cache.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::setIsActive):
(WebCore::ScrollAnimator::isActive):

ScrollAnimatorMac has a new bit -- m_needsScrollerStyleUpdate. This is set to true
when a ScrollAnimator is inactive and has received the
updateScrollerStyleForNewRecommendedScrollerStyle delegate notification. It
prevents any work from being done for this delegate until the ScrollAnimator
becomes active again.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorMac::needsScrollerStyleUpdate):

This delegate method has been re-factored into ScrollAnimatorMac::
updateScrollerStyle(). This way the meat of the function can be called by both the
delegate and ScrollAnimatorMac::setIsActive()

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

This override of ScrollAnimator::setIsActive() calls the base class, and then calls updateScrollerStyle() if needsScrollerStyleUpdate() is set to true.
(WebCore::ScrollAnimatorMac::setIsActive):

This is mostly the same as the old delegate method. Key differences are that if
the ScrollAnimator is inactive, we now setNeedsScrollerStyleUpdate(true) and
return early. We also only call scrollableArea()->scrollbarStyleChanged() if
needsScrollerStyleUpdate() is false since in the true case when we are restoring
from the page cache, this would be duplicated work.
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

New WKSystemInterface function is needed to retrieve the scrollbar style.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:15 PM Changeset in webkit [86183] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-05-10 Jeff Miller <​jeffm@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Windows clients need to know if the page overlay is installed
​https://bugs.webkit.org/show_bug.cgi?id=60562
<rdar://problem/8940164>


Until we move all the UI for find on page into WebKit on Windows (specifically, drawing the find bouncy),
WebKit clients need to know whether WebKit is drawing the page overlay or not. Keep track of this in
the WebPageProxy in the UI process and provide a WebKit2 API to retrieve this information.

  • UIProcess/API/C/win/WKView.cpp: (WKViewIsPageOverlayInstalled): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewIsPageOverlayInstalled().


  • UIProcess/PageClient.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.messages.in: Added DidInstallOrUninstallPageOverlay.
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::didInstallOrUninstallPageOverlay): Added.


  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): Initialize m_pageOverlayInstalled. (WebKit::WebView::didInstallOrUninstallPageOverlay): Added.
  • UIProcess/win/WebView.h: Added didInstallOrUninstallPageOverlay() and m_pageOverlayInstalled. (WebKit::WebView::pageOverlayInstalled): Added.


  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Send message to UI process to tell it the page overlay is installed. (WebKit::WebPage::uninstallPageOverlay): Send message to UI process to tell it the page overlay is uninstalled.
3:11 PM WebKit Team edited by senorblanco@chromium.org
(diff)
2:53 PM Changeset in webkit [86182] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=60502

Technically there are a few bits in here that weren't reviewed by Dave,
but close enough for government work. This patch all fixes the
remaining strict PassOwnPtr violations on Chromium Linux.

  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2:43 PM Changeset in webkit [86181] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 84611 - <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
​https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

  • media/audio-controls-do-not-fade-out-expected.txt: Added.
  • media/audio-controls-do-not-fade-out.html: Added.

TBR=​mitz@apple.com
Review URL: ​http://codereview.chromium.org/7005009

2:19 PM Changeset in webkit [86180] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

In my patch to fix ​https://bugs.webkit.org/show_bug.cgi?id=60572 I committed without having saved ChangeLog and code comments that are critical to explain the bug and the code change.

Whoops! Here they are.

1:26 PM Changeset in webkit [86179] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9343191> and ​https://bugs.webkit.org/show_bug.cgi?id=60572

Reviewed by Alice Liu.

No new tests - There's no way to reproduce the truly bizarre things Canon does in their app
that would reasonably fit in to our testing infrastructure.

Add a timer to Settings and instead of calling setLoadsImagesAutomaticallyInAllFrames right
away when this pref changes, call it on a 0-delay:

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):

  • page/Settings.h:
12:37 PM Changeset in webkit [86178] by Martin Robinson
  • 4 edits in trunk/Source/WebCore

2011-05-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
​https://bugs.webkit.org/show_bug.cgi?id=59990

No new tests. This is covered by existing pixel tests.

  • platform/gtk/GtkVersioning.c: (getGdkDrawableSize): Added this helper method.
  • platform/gtk/GtkVersioning.h: Added helper method declaration.
  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Call into the helper if there is actually a GdkDrawable. If not, disable the sanity check.
12:33 PM Changeset in webkit [86177] by Martin Robinson
  • 2 edits
    1 add in trunk/Source/WebCore

2011-05-10 Martin Robinson <​mrobinson@igalia.com>

Fix the GTK+ WebKit2 build. Add a CredentialsStorage stub for libsoup.

  • GNUmakefile.list.am: Add stub to source list.
  • platform/network/soup/CredentialStorageSoup.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Added stub. (WebCore::CredentialStorage::get):
12:24 PM Changeset in webkit [86176] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Dan Bernstein.

Second attempts at a fix for this bug. Instead of removing the dirtying (which turned out to be needed in a few cases),
make dirtyLinesFromChangedChild mark a child as needing layout when it has to recur to the parent. Because the method already
aborts the recursion if selfNeedsLayout() is set on the parent, this has the effect of stopping the O(n2) pathological
behavior, since you can use the selfNeedsLayout() bit to understand that you've dirtied the lines already.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

12:23 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:57 AM Changeset in webkit [86175] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
​https://bugs.webkit.org/show_bug.cgi?id=60567
<rdar://problem/9377845>

It is possible to receive an incoming sync reply that is for a request we don't know about.
This could happen if the sync message send timed out for example.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingSyncReply):
11:57 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:32 AM Changeset in webkit [86174] by Martin Robinson
  • 11 edits in trunk/Source

2011-05-05 Brent Fulgham <​bfulgham@webkit.org> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
​https://bugs.webkit.org/show_bug.cgi?id=60293

No new tests. This is covered by current pixel tests.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyCairoImageSurface): Abstract the code from WebCore::ImageBuffer::copyImage into this helper which creates a deep copy of a Cairo image surface.
  • platform/graphics/cairo/CairoUtilities.h: Added declaration.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::copyImage): Use the new helper.
  • platform/graphics/cairo/ImageCairo.cpp: Abstract some of this logic into the new drawSurfaceToContext method on PlatformContextCairo. (WebCore::BitmapImage::draw):
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::drawPatternToCairoContext): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext): Added.
  • platform/graphics/cairo/PlatformContextCairo.h: Added declarations.

2011-05-05 Brent Fulgham <​bfulgham@webkit.org> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
​https://bugs.webkit.org/show_bug.cgi?id=60293

  • GNUmakefile.am: Remove ShareableBitmapGtk in favor of ShareableBitmapCairo.
  • Shared/ShareableBitmap.h: Added a couple Cairo-specific declarations.
  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): Added. (WebKit::ShareableBitmap::paint): Added. (WebKit::ShareableBitmap::createCairoSurface): Added. (WebKit::ShareableBitmap::releaseSurfaceData): Added.
11:30 AM Changeset in webkit [86173] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/JavaScriptCore/wtf/FastMalloc.cpp

Merge 86106
BUG=82152
Review URL: ​http://codereview.chromium.org/7000002

11:28 AM Changeset in webkit [86172] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • platform/network/qt/CredentialStorageQt.cpp:

(WebCore::CredentialStorage::get):
Add stub.

11:12 AM Changeset in webkit [86171] by tony@chromium.org
  • 8 edits
    1 add
    1 delete in trunk

2011-05-10 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=60079

Update the expected results.

  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
  • platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-05-10 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=60079

Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
value pair.

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
11:04 AM Changeset in webkit [86170] by imasaki@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-05-10 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaselines for video-layer-crash.
​https://bugs.webkit.org/show_bug.cgi?id=60548

Chromium bug is ​http://crbug.com/60744. Expected images need to be
updated because they are incorrect. The cause of this image change
cannot be easily determined at present because the test has been
broken for so long.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Added.
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
11:04 AM Changeset in webkit [86169] by andersca@apple.com
  • 14 edits in trunk/Source

2011-05-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
​https://bugs.webkit.org/show_bug.cgi?id=60560
<rdar://problem/9338693>

Add symbols required by WebKit2.

  • WebCore.exp.in:

2011-05-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
​https://bugs.webkit.org/show_bug.cgi?id=60560

Implement NPN_GetAuthenticationInfo.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::getAuthenticationInfo): Send a GetAuthenticationInfo message to the web process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::initializeProtectionSpace): Initialize a WebCore::ProtectionSpace object from NPAPI parameters.

(WebKit::NPN_GetAuthenticationInfo):
Make a ProtectionSpace object and then call NetscapePlugin::getAuthenticationInfo.
Finally, copy the username/password and pass them back to the plug-in.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::getAuthenticationInfo): Call the plug-in controller.
  • WebProcess/Plugins/PluginController.h: Add getAuthenticationInfo pure virtual member function.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::getAuthenticationInfo): Call the real plug-in controller's getAuthenticationInfo member function.
  • WebProcess/Plugins/PluginProxy.messages.in: Add GetAuthenticationInfo message.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::getAuthenticationInfo): Try to get the authentication info from the credential storage. Failing that, get it from the persistent credential storage.
10:46 AM Changeset in webkit [86168] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Styles sidebar is not updated upon changes in the Resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=60320

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
10:37 AM Changeset in webkit [86167] by jamesr@google.com
  • 25 edits
    16 deletes in branches/chromium/742

Revert 79985 - 2011-03-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
​https://bugs.webkit.org/show_bug.cgi?id=54800

Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
mutations take affect, but don't affect other renderers which shared the SVGPaint object before.

  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
  • svg/animations/animate-color-fill-currentColor-expected.txt: Added.
  • svg/animations/animate-color-fill-currentColor.html: Added.
  • svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
  • svg/custom/SVGPaint-mutate-attribute.svg: Added.
  • svg/custom/SVGPaint-mutate-inline-style.svg: Added.
  • svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
  • svg/dom/SVGPaint-expected.txt: Same for SVGPaint.

2011-03-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
​https://bugs.webkit.org/show_bug.cgi?id=54800

Wrong handling of currentColor on inherit
​https://bugs.webkit.org/show_bug.cgi?id=38102

Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).

<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.

In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.

A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)

Add several new tests covering the patch.

Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg

svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg

  • GNUMakefile.am: Add CSSMutableValue.h
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
  • css/CSSMutableStyleDeclaration.h: Add destructor.
  • css/CSSMutableValue.h: Added. (WebCore::CSSMutableValue::CSSMutableValue): (WebCore::CSSMutableValue::~CSSMutableValue): (WebCore::CSSMutableValue::isMutableValue): (WebCore::CSSMutableValue::node): (WebCore::CSSMutableValue::setNode): (WebCore::CSSMutableValue::setNeedsStyleRecalc):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
  • css/CSSValue.h: (WebCore::CSSValue::isMutableValue): Return false, default.
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
  • rendering/style/SVGRenderStyle.h: Ditto. (WebCore::SVGRenderStyle::initialFillOpacity): (WebCore::SVGRenderStyle::initialFillPaintType): (WebCore::SVGRenderStyle::initialFillPaintColor): (WebCore::SVGRenderStyle::initialFillPaintUri): (WebCore::SVGRenderStyle::initialStrokeOpacity): (WebCore::SVGRenderStyle::initialStrokePaintType): (WebCore::SVGRenderStyle::initialStrokePaintColor): (WebCore::SVGRenderStyle::initialStrokePaintUri): (WebCore::SVGRenderStyle::initialStrokeMiterLimit): (WebCore::SVGRenderStyle::initialStopOpacity): (WebCore::SVGRenderStyle::initialFloodOpacity): (WebCore::SVGRenderStyle::setFillPaint): (WebCore::SVGRenderStyle::setStrokePaint): (WebCore::SVGRenderStyle::fillPaintType): (WebCore::SVGRenderStyle::fillPaintColor): (WebCore::SVGRenderStyle::fillPaintUri): (WebCore::SVGRenderStyle::strokePaintType): (WebCore::SVGRenderStyle::strokePaintColor): (WebCore::SVGRenderStyle::strokePaintUri): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
  • rendering/style/SVGRenderStyleDefs.cpp: Ditto. (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto. (WebCore::requestPaintingResource):
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
  • rendering/svg/SVGResources.cpp: Ditto. (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources):
  • svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object. (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor):
  • svg/SVGColor.h:
  • svg/SVGPaint.cpp: Ditto. (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
  • svg/SVGPaint.h:

TBR=​kerz@chromium.org
BUG=80880
Review URL: ​http://codereview.chromium.org/7002001

10:36 AM Changeset in webkit [86166] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-10 Chang Shu <​cshu@webkit.org>

Reviewed by Darin Adler.

Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=60554

  • editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms.html:
  • platform/chromium-linux/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
10:28 AM Changeset in webkit [86165] by levin@chromium.org
  • 9 edits in trunk/Tools

2011-05-10 David Levin <​levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
​https://bugs.webkit.org/show_bug.cgi?id=60466

  • Scripts/webkitpy/style/checker.py: (unrelated) style fix.
  • Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since that property was removed.
  • Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line filtering for errors.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to verify that the line filtering is turned off.
  • Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors and remove the unused file_path parameter.
  • Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the line filtering is turned off (and fix test_no_error).
  • Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering of errors based on the lines changed in the patch.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off the filtering.
10:26 AM Changeset in webkit [86164] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
​https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
10:08 AM Changeset in webkit [86163] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Files that load quickly sometimes won't play.
​https://bugs.webkit.org/show_bug.cgi?id=60556
<rdar://problem/9330567>

No new tests, this failure is very difficult to reproduce on some machines. The fix was
verified manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates

to dispatchNotification so it is more obvious which state changes call it.

(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to

dispatchNotification.

(WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after

processing "size changed" notification so we detect all state changes. Consolidate
calls to updateStates here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in

a debug build.

9:57 AM Changeset in webkit [86162] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/742

Merge 86160 - Fix null ptr crash from r85876

BUG=72832
Review URL: ​http://codereview.chromium.org/6999012

9:46 AM Changeset in webkit [86161] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Use FontSmoothingLevelWindows by default on Windows

Fixes <​http://webkit.org/b/60557> REGRESSION (r86077): Web Inspector uses CG font rendering
in WebKit2 on Windows

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Added and deployed a new DEFAULT_WEBKIT_FONT_SMOOTHING_LEVEL

macro to let Windows have a different default font smoothing level from other platforms.

  • UIProcess/API/C/WKPreferencesPrivate.h: Updated the comment about the default font

smoothing level.

9:40 AM Changeset in webkit [86160] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Add containsFloats call to hasOverhangingFloats.
​https://bugs.webkit.org/show_bug.cgi?id=60537

Test: fast/block/float/no-overhanging-float-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats):

2011-05-10 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash due to wrong result from
hasOverhangingFloats.
​https://bugs.webkit.org/show_bug.cgi?id=60537

  • fast/block/float/no-overhanging-float-crash-expected.txt: Added.
  • fast/block/float/no-overhanging-float-crash.html: Added.
9:22 AM Changeset in webkit [86159] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Drop obsolete test code for the Profiles panel.
​https://bugs.webkit.org/show_bug.cgi?id=60471

  • src/js/Tests.js:
9:22 AM Changeset in webkit [86158] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] Increment QtWebKit trunk version to 4.10.0
​https://bugs.webkit.org/show_bug.cgi?id=60549

QtWebKit-2.2 (branched) will be 4.9.0, so we need to
increase the trunk version by 1.

  • qt_webkit_version.pri:
8:50 AM Changeset in webkit [86157] by Adam Roben
  • 9 edits
    2 deletes in trunk

Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows

Fixes <​http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:

(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
WindowedPluginTest::testHarnessWindow function.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:

(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
turns out only the size mattered for <​http://webkit.org/b/46716>, which this test was
created for.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
WindowedPluginTest, and initialized new members.
(WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
(WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
then clean up and tell the test harness we're done.
(WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
(WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
window becomes visible.
(WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
if it was hidden at the start of the test.
(WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
This should cause our window to become visible and our window region to get set. When we get
a WM_WINDOWPOSCHANGED message, we can finally finish the test.
(WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
(WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
"startTest".
(WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:

(WindowedPluginTest::testHarnessWindow):

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:

Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.

LayoutTests:

  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Updated

for new test output that doesn't claim anything about the window's position.

  • platform/win/plugins/window-region-is-set-to-clip-rect.html: Hide the plugin initially,

and tell the plugin when the load event has fired.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
8:48 AM Changeset in webkit [86156] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/workers/wrapper-map-gc.html, because it crashes intermittently.
8:43 AM Changeset in webkit [86155] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/dom/Geolocation/window-close-crash.html.
8:32 AM Changeset in webkit [86154] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] tst_QWebPage creates temporary files in the current working dir
​https://bugs.webkit.org/show_bug.cgi?id=60497

tst_QWebPage was using QDir::currentPath when creating temporary dirs
and leaving them after the test was run. I basically borrowed the fix
from tst_QDeclarativeWebView.

  • tests/qwebpage/tst_qwebpage.cpp: (removeRecursive): (tst_QWebPage::tmpDirPath): (tst_QWebPage::cleanupFiles): (tst_QWebPage::database): (tst_QWebPage::multiplePageGroupsAndLocalStorage):
8:25 AM Changeset in webkit [86153] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Antonio Gomes.

Warning fix on PluginPackage.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=60371

Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
Let's use a struct rather than an array so we can pass everything to StringHasher.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
7:56 AM Changeset in webkit [86152] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Andreas Kling <​andreas.kling@nokia.com>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
​https://bugs.webkit.org/show_bug.cgi?id=60551

  • WebCore.pro: Disable the line that enables HAVE_QRAWFONT if the feature is found. Added a comment about why.
7:39 AM Changeset in webkit [86151] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Fix video-play-stall-before-metadata.

A stalled event won't be sent until no progress has happened for 3
seconds. Make sure that the connection is still open for at least that long.
​https://bugs.webkit.org/show_bug.cgi?id=60306

  • http/tests/media/video-load-and-stall.cgi:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • platform/chromium/test_expectations.txt:
6:56 AM Changeset in webkit [86150] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

One more unreviewed typo fix after r86148. :(

  • platform/qt-4.8/Skipped:
6:54 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
6:51 AM Changeset in webkit [86149] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86148.

  • platform/qt-4.8/Skipped:
6:48 AM Changeset in webkit [86148] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
​http://trac.webkit.org/changeset/86143

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped:
    • Add http/tests/security/xss-DENIED-xsl-document.xml
    • Add http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html
6:43 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
6:22 AM Changeset in webkit [86147] by caseq@chromium.org
  • 4 edits in trunk

2011-05-10 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
​https://bugs.webkit.org/show_bug.cgi?id=60266

  • bindings/objc/DOM.mm: (kitClass): return DOMNode class for shadow root node

2011-05-10 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
​https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped: removed suppression of console-shadow-dom-access.html
5:55 AM Changeset in webkit [86146] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[WK2] eventSender.keyDown is unimplemented

Move fast/forms/radio-group-keyboard-change-event.html from qt-wk2/Skipped to
mac-wk2/Skipped, because it isn't Qt specific bug, but general WK2 specific one.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
5:42 AM Changeset in webkit [86145] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt][Mac] Add platform specific expected result for plugins/plugin-javascript-access.html,
which is same as the platform independent one, but differs from the general Qt specific.

  • platform/qt-mac/plugins: Added.
  • platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Added.
5:33 AM Changeset in webkit [86144] by benm@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Ben Murdoch <​benm@google.com>

Reviewed by Steve Block.

Fix build in WebCore/xml/XSLTProcessorLibxslt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60478

No new tests), build fix only.

  • xml/XSLTProcessorLibxslt.cpp: Add CString.h include.
5:30 AM Changeset in webkit [86143] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=60311

It is a general Qt related bug, so we should add it to qt/Skipped instead of all Skipped list.

  • platform/qt-arm/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-linux/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-mac/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt/Skipped: Add fast/events/backspace-navigates-back.html.
5:14 AM Changeset in webkit [86142] by Csaba Osztrogonác
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed.

Move plugins/plugin-javascript-access-expected.txt from qt-linux platform
to qt, because it should be used by qt-4.8, qt-arm Linux platforms too.

  • platform/qt-linux/plugins: Removed.
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/qt/plugins/plugin-javascript-access-expected.txt: Copied from LayoutTests/platform/qt-linux/plugins/plugin-javascript-access-expected.txt.
4:56 AM Changeset in webkit [86141] by Csaba Osztrogonác
  • 4 edits
    2 adds in trunk

[Qt] Add new qt-4.8 platform for layout testing
​https://bugs.webkit.org/show_bug.cgi?id=60544

Reviewed by Kenneth Rohde Christiansen.

Tools:

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

LayoutTests:

  • platform/qt-4.8/Skipped: Added.
4:24 AM Changeset in webkit [86140] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtRawFont support should check based on feature, not version
​https://bugs.webkit.org/show_bug.cgi?id=60513

Build fix - no tests added.

  • WebCore.pro:
1:59 AM Changeset in webkit [86139] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] eventSender.keyDown is unimplemented

  • platform/qt-wk2/Skipped: Add fast/forms/radio-group-keyboard-change-event.html.
1:49 AM Styling Form Controls edited by tkent@chromium.org
How to remove spin buttons (diff)
1:46 AM Changeset in webkit [86138] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/qt-mac/Skipped: Add plugins/embed-prefers-plugins-for-images.html.
1:34 AM Changeset in webkit [86137] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed fix.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
​https://bugs.webkit.org/show_bug.cgi?id=60499

r86124 implemented unmarkText() and it fixed a test,
which doesn't need Qt specific expected failure anymore.

  • platform/qt/fast/events/ime-composition-events-001-expected.txt: Removed.
1:27 AM Changeset in webkit [86136] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Tony Gentilcore <​tonyg@chromium.org>

Build fix: include ExceptionCode
​https://bugs.webkit.org/show_bug.cgi?id=60538

  • bindings/js/JSDOMBinding.cpp:
1:19 AM Changeset in webkit [86135] by tonyg@chromium.org
  • 64 edits in trunk/Source

2011-05-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
​https://bugs.webkit.org/show_bug.cgi?id=60388

These were all found using the include-what-you-use clang plugin.

  • css/CSSFontFaceSrcValue.h:
  • css/CSSImageGeneratorValue.h:
  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.cpp:
  • css/CSSPrimitiveValueCache.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/RGBColor.cpp:
  • css/RGBColor.h:
  • dom/EventTarget.h:
  • dom/ExceptionBase.cpp:
  • dom/ExceptionBase.h:
  • dom/MessagePort.cpp:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/SelectElement.cpp:
  • dom/SelectElement.h:
  • dom/TextEvent.cpp:
  • dom/TextEvent.h:
  • dom/Touch.cpp:
  • dom/Touch.h:
  • dom/TouchEvent.cpp:
  • dom/TouchEvent.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyBlockElementCommand.h:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/EditCommand.h:
  • editing/Editor.h:
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.h:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • html/HTMLSelectElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • loader/appcache/DOMApplicationCache.cpp:
  • page/EventSource.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/svg/RenderSVGInlineText.cpp:
  • svg/SVGMatrix.h:
  • websockets/WebSocket.cpp:
  • workers/AbstractWorker.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XPathExpression.cpp:

2011-05-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
​https://bugs.webkit.org/show_bug.cgi?id=60388

  • WebProcess/FullScreen/WebFullScreenManager.cpp:
1:13 AM Changeset in webkit [86134] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-10 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking (video-controls-rendering.html)

  • platform/chromium/test_expectations.txt:
12:52 AM Changeset in webkit [86133] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Adam Barth <​abarth@webkit.org>

Attempt to fix the clang build.

  • src/WebDevToolsAgentImpl.cpp:
12:46 AM Changeset in webkit [86132] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-10 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
​https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

May 9, 2011:

10:41 PM Changeset in webkit [86131] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the LLVM Compiler build.

  • page/EventHandler.h:
10:23 PM Changeset in webkit [86130] by weinig@apple.com
  • 15 edits in trunk

Unreviewed, rolling out r86108.
​http://trac.webkit.org/changeset/86108
​https://bugs.webkit.org/show_bug.cgi?id=60533

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-05-09
Broke makefile based builds and Cairo (Requested by weinig on
#webkit).

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:

(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

9:48 PM Changeset in webkit [86129] by dcheng@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-05-09 Daniel Cheng <​dcheng@chromium.org>

Fix the build.

Really add the file this time.

  • page/DragState.h: Added. (WebCore::DragState::DragState):
9:33 PM Changeset in webkit [86128] by dcheng@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-05-09 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Refactor RenderObject::draggableNode.
​https://bugs.webkit.org/show_bug.cgi?id=60503

This patch lays the ground for refactoring the drag start logic. It moves draggableNode to
DragController to avoid the awkward plumbing of calling DragController from RenderObject and
also moves EventHandlerDragState out from EventHandler so it can be shared between
EventHandler and DragController where appropriate.

No new tests since there should be no behavior change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::mayStartDragAtEventLocation):
  • page/DragController.h:
  • page/DragState.h: Added. (WebCore::DragState::DragState):
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
8:58 PM Writing Reftests edited by hayato@chromium.org
(diff)
8:24 PM Changeset in webkit [86127] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/page/animation/CompositeAnimation.cpp

Merge 85693
BUG=82096
Review URL: ​http://codereview.chromium.org/6994006

7:40 PM Changeset in webkit [86126] by hayato@chromium.org
  • 5 edits in trunk/Tools

2011-05-09 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

Skip reftests if pixel tests are disabled.

​https://bugs.webkit.org/show_bug.cgi?id=59078

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
7:23 PM Changeset in webkit [86125] by Martin Robinson
  • 4 edits in trunk

2011-05-09 Martin Robinson <​mrobinson@igalia.com>

Update the results for a test after r86102. This test was susceptible to
scrollbar race conditions and r86102 changed timing slightly.

  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:

2011-05-09 Martin Robinson <​mrobinson@igalia.com>

Fix a test after r86102. Scrollbars update asynchronously, so we
must check the adjustments after a short delay.

  • tests/testwebview.c: (quit_after_short_delay_cb): Add a short delay before checking adjustments. (test_webkit_web_view_grab_focus): Ditto.
7:11 PM Changeset in webkit [86124] by commit-queue@webkit.org
  • 8 edits in trunk

2011-05-09 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
​https://bugs.webkit.org/show_bug.cgi?id=60499

Unskipped passed test.

  • platform/qt/Skipped:

2011-05-09 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
​https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::confirmComposition):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-09 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
​https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::unmarkText):
  • DumpRenderTree/qt/TextInputControllerQt.h:
7:05 PM Changeset in webkit [86123] by Lucas Forschler
  • 5 edits in tags/Safari-534.34.4/Source

Versioning to match updated WebBrowser.

7:01 PM Changeset in webkit [86122] by Lucas Forschler
  • 1 copy in tags/Safari-534.34.4

New tag.

6:55 PM Changeset in webkit [86121] by imasaki@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-09 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline images for video-controls-rendering.
​https://bugs.webkit.org/show_bug.cgi?id=60517

Chromium bug is ​http://crbug.com/82033. These rebaselines are necessary
due to unrelated bug (​http://crbug.com/74102). We are checking in bad
baselines for the time being so that we ensure no other problems occur.
This test will fail when above bug (​http://crbug.com/74102) is fixed.
At that time, we will checkin correct baselines.

  • platform/chromium-gpu-linux/media/video-controls-rendering -expected.png: Added.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:52 PM Changeset in webkit [86120] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Darin Adler.

Enable casting between CSSPrimitiveValue and FontWeight enum
​https://bugs.webkit.org/show_bug.cgi?id=60516

No new tests added as no functionality changed.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Implement cast from FontWeight to CSSPrimitiveValue. (WebCore::CSSPrimitiveValue::operator FontWeight): Implement cast from CSSPrimitiveValue to FontWeight
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use new cast to reduce code size. Flatten switch inside if.
6:50 PM Changeset in webkit [86119] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

[chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
​https://bugs.webkit.org/show_bug.cgi?id=60520

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
6:38 PM Changeset in webkit [86118] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

Fix build, for real.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment):
6:30 PM Changeset in webkit [86117] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r85984

6:28 PM Changeset in webkit [86116] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix..

Fix GTK+3.x build.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment): the adjustment is in adjustmentWatcher() now. (getVerticalAdjustment): ditto.
6:09 PM Changeset in webkit [86115] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-09 Simon Fraser <Simon Fraser>

Move IconURL.* into the dom grouping.

  • WebCore.xcodeproj/project.pbxproj:
6:01 PM Changeset in webkit [86114] by Martin Robinson
  • 4 edits
    1 add in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84979

5:59 PM Changeset in webkit [86113] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84123

5:58 PM Changeset in webkit [86112] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85221

5:57 PM Changeset in webkit [86111] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4

Merging r85219

5:56 PM Changeset in webkit [86110] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85390

5:25 PM Changeset in webkit [86109] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

2011-05-08 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
​https://bugs.webkit.org/show_bug.cgi?id=60449

  • fullscreen/full-screen-remove-sibling-expected.txt: Added.
  • fullscreen/full-screen-remove-sibling.html: Added.

2011-05-08 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
​https://bugs.webkit.org/show_bug.cgi?id=60449

Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
coalesce anonymous children.

Test: fullscreen/full-screen-remove-sibling.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
5:17 PM Changeset in webkit [86108] by levin@chromium.org
  • 15 edits in trunk

Switch TestWebKitAPI to GTest
​https://bugs.webkit.org/show_bug.cgi?id=59561

Patch by Dmitry Lomov <​dslomov@google.com> on 2011-05-09
Reviewed by Sam Weinig.

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

4:50 PM Changeset in webkit [86107] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-05-09 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
​https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): (-[WebFullScreenController exitFullscreen]):

2011-05-09 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
​https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The beganExitFullScreenAnimation method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
4:45 PM Changeset in webkit [86106] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-09 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

​http://bugs.webkit.org/show_bug.cgi?id=60509
Wrong type used for return value from strlen

  • wtf/FastMalloc.cpp: (WTF::fastStrDup): Use size_t. Also don't bother checking for failure since fastMalloc won't return if it fails.
4:41 PM Changeset in webkit [86105] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r84706): Crazy rendering of vimeo.com after exiting fullscreen video
​https://bugs.webkit.org/show_bug.cgi?id=60512

Initialize m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
4:37 PM Changeset in webkit [86104] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r86039): DragCaretController doesn't draw caret
​https://bugs.webkit.org/show_bug.cgi?id=60505

Removed an early exit in setCaretPosition introduced by r86039.
Also replaced calls to containerNode by deprecatedNode since rendering code doesn't
support container node for rendering caret.

  • editing/FrameSelection.cpp: (WebCore::DragCaretController::setCaretPosition):
4:31 PM Changeset in webkit [86103] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

A WKView with plug-ins paints white when first moved into a window
​https://bugs.webkit.org/show_bug.cgi?id=60511

Reviewed by Darin Adler.

The UI process’s wait for DidUpdateBackingStoreState would always time out because the Web process
was blocked on a synchronous message the UI process trying to get the connections for plug-ins in
the view. This is avoided by deferring the call to Page::setCanStartMedia().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize the new m_setCanStartMediaTimer.
(WebKit::WebPage::setCanStartMediaTimerFired): Added. Calls setCanStartMedia(true) when the timer
fires.
(WebKit::WebPage::setIsInWindow): When going out of a window, stop the timer. When going into a
window, start it.

  • WebProcess/WebPage/WebPage.h:
4:24 PM Changeset in webkit [86102] by Martin Robinson
  • 14 edits
    2 adds in trunk/Source

2011-04-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=59821

Completely remove the ability for WebKit to set GtkAdjustments on ScrollViews
and, consequently, Scrollbars. Handling adjustment updates can now be managed
in WebKit.

No new tests. This is covered by existing Scrollbar tests.

  • platform/ScrollView.cpp: platformInit and platformDestroy can now be shared between ScrollView.cpp and ScrollViewGtk.cpp.
  • platform/ScrollView.h: Remove unused methods.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::create): No longer need to pass in the adjustment. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): Update the comments here.
  • platform/gtk/MainFrameScrollbarGtk.h: Lots of code removal.
  • platform/gtk/ScrollViewGtk.cpp: Ditto. (WebCore::ScrollView::createScrollbar): Ditto. (WebCore::ScrollView::setScrollbarModes): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: This file needs the GRefPtrGtk.h include now that it doesn't receive it transitively.

2011-04-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=59821

Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
them to WebCore to manage. This simplifies the code quite a bit and should be less
crash prone in the future.

  • GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
  • WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member. (WebKit::ChromeClient::ChromeClient) Initialize the new member. (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments. (WebKit::ChromeClient::contentsSizeChanged): Ditto. (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there is no main frame, so do an early return in that case.
  • WebCoreSupport/ChromeClientGtk.h: Add the new member. (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into WebCore. (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::postCommitFrameViewSetup):
  • WebCoreSupport/GtkAdjustmentWatcher.cpp: Added. (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher): (WebKit::updateAdjustmentFromScrollbar): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars): (WebKit::updateAdjustmentCallback): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): (WebKit::adjustmentValueChangedCallback): (WebKit::setAdjustment): (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment): (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment): (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
  • WebCoreSupport/GtkAdjustmentWatcher.h: Added. (WebKit::GtkAdjustmentWatcher::horizontalAdjustment): (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
  • webkit/webkitwebview.cpp: (setHorizontalAdjustment): (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher. (getHorizontalAdjustment): Ditto. (getVerticalAdjustment): Ditto. (webkit_web_view_size_allocate): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Ditto. (webkit_web_view_init): Ditto.
  • webkit/webkitwebviewprivate.h: Ditto.
4:08 PM Changeset in webkit [86101] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when sending a sync message to a crashed web process
​https://bugs.webkit.org/show_bug.cgi?id=60514
<rdar://problem/9281270>

Change WebProcessProxy::sendSync to return false if there's no connection.

Audit all WebProcessProxy::sendSync call sites to initialize reply parameters.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): (WebKit::WebPageProxy::getSelectedText): (WebKit::WebPageProxy::gestureWillBegin):
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::sendSync):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::insertText): (WebKit::WebPageProxy::getMarkedRange): (WebKit::WebPageProxy::getSelectedRange): (WebKit::WebPageProxy::characterIndexForPoint): (WebKit::WebPageProxy::executeKeypressCommands): (WebKit::WebPageProxy::writeSelectionToPasteboard): (WebKit::WebPageProxy::readSelectionFromPasteboard):
4:05 PM Changeset in webkit [86100] by abarth@webkit.org
  • 9 edits
    5 adds in trunk

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
​https://bugs.webkit.org/show_bug.cgi?id=60240

Test that the function constructor is properly blocked.

  • http/tests/security/contentSecurityPolicy/function-constructor-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked.html: Added.
  • platform/chromium/test_expectations.txt:

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
​https://bugs.webkit.org/show_bug.cgi?id=60240

When eval is disabled, we need to block the use of the function
constructor. However, the WebCore JSC bindings call the function
constructor directly to create inline event listeners. To support that
use, this patch adds an entrypoint that bypasses the check for whether
eval is enabled.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h:

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
​https://bugs.webkit.org/show_bug.cgi?id=60240

Tests: http/tests/security/contentSecurityPolicy/function-constructor-allowed.html

http/tests/security/contentSecurityPolicy/function-constructor-blocked.html

  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
    • Update call site to the new entrypoint.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject):
    • Add some comments about the rediculousness of this implementation.
4:02 PM Changeset in webkit [86099] by crogers@google.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-05-09 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
​https://bugs.webkit.org/show_bug.cgi?id=60396

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DenormalDisabler.h: Added. (WebCore::DenormalDisabler::DenormalDisabler): (WebCore::DenormalDisabler::~DenormalDisabler): (WebCore::DenormalDisabler::getCSR): (WebCore::DenormalDisabler::setCSR):
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::provideInput):
3:53 PM Changeset in webkit [86098] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Style cleanups in RenderFlexibleBox.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60504

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): Use m_ for member variables, and

use class initializer list.

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::marginWidthForChild): Pull out common code used in calc*PrefWidths
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo): Rewrite uses of FlexBoxIterator into for statements

rather than while loops.

(WebCore::RenderFlexibleBox::layoutHorizontalBox): ditto
(WebCore::RenderFlexibleBox::layoutVerticalBox): ditto
(WebCore::RenderFlexibleBox::applyLineClamp):
(WebCore::RenderFlexibleBox::allowedChildFlex): Rename variables w/h to width/height.

3:49 PM Changeset in webkit [86097] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Create a plug-in's MIME types preferences plist if it doesn't exist.
​https://bugs.webkit.org/show_bug.cgi?id=57204
<rdar://problem/9195048>

Spawn a plug-in process and let it create the plist. For now, we'll do this on the
main thread since it's a rare one-time computation and we have an API function,
WKFrameCanShowMIMEType, which would have to block anyway.

  • PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain): If -createPluginMIMETypesPreferences is one of the command line argument keys, the plug-in path will be the argument value. Call NetscapePluginModule::createPluginMIMETypesPreferences to create the preferences file and then exit.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::contentsOfPropertyListAtURL): Move code to read a property list out into a helper function.

(WebKit::getMIMETypesFromPluginBundle):
If there's no property list file, try to create one.

(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):
Load the plug-in, find the BP_CreatePluginMIMETypesPreferences and call it.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::createPropertyListFile): Spawn a plug-in process and pass the -createPluginMIMETypesPreferences flag to it and then wait for it to exit.
3:47 PM Changeset in webkit [86096] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-09 Robert Hogan <​robert@webkit.org>

Unreviewed, update test expectations.

Update platform-specific results after r86086

The unix test NPAPI plugin now supports the png mime type.

​https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt:
3:36 PM Changeset in webkit [86095] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove unflaky media-related tests from test expectation.
​https://bugs.webkit.org/show_bug.cgi?id=60500

Chromium bug is ​http://crbug.com/81660.

  • platform/chromium/test_expectations.txt:
3:29 PM Changeset in webkit [86094] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebKit/chromium

2011-05-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86091.
​http://trac.webkit.org/changeset/86091
​https://bugs.webkit.org/show_bug.cgi?id=60510

Broke Chromium win release build. (Requested by dave_levin on
#webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
3:27 PM Changeset in webkit [86093] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Abstract line deletion code into a function
​https://bugs.webkit.org/show_bug.cgi?id=60501

No change in behavior, thus no testing.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine):
3:14 PM Changeset in webkit [86092] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Cleared some stray executable bits on source files.

  • bindings/js/WorkerScriptDebugServer.cpp: Removed property svn:executable.
  • bindings/js/WorkerScriptDebugServer.h: Removed property svn:executable.
3:04 PM Changeset in webkit [86091] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-09 Tao Bai <​michaelbai@chromium.org>

Reviewed by David Levin.

Handle the touch icon.
​https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added a parameter to favIconURL() to specify the type of icon need to
return.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
2:56 PM Changeset in webkit [86090] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] DRT eventSender.addTouchPoint method is not setting the start position
​https://bugs.webkit.org/show_bug.cgi?id=60487

When adding a new touch point, the start position of this point needs to be set.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint):
2:47 PM Changeset in webkit [86089] by andersca@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move EnvironmentVariables out into its own .cpp file
​https://bugs.webkit.org/show_bug.cgi?id=60507

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp: Added. (WebKit::EnvironmentVariables::EnvironmentVariables): (WebKit::EnvironmentVariables::~EnvironmentVariables): (WebKit::EnvironmentVariables::set): (WebKit::EnvironmentVariables::get): (WebKit::EnvironmentVariables::appendValue): (WebKit::EnvironmentVariables::valueIfVariableHasName): (WebKit::EnvironmentVariables::createStringForVariable): (WebKit::EnvironmentVariables::copyEnvironmentVariables):
  • UIProcess/Launcher/mac/EnvironmentVariables.h: Added. (WebKit::EnvironmentVariables::environmentPointer):
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
2:42 PM Changeset in webkit [86088] by arv@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
​https://bugs.webkit.org/show_bug.cgi?id=32013

  • fast/forms/radio-group-keyboard-change-event-expected.txt: Added.
  • fast/forms/radio-group-keyboard-change-event.html: Added.

2011-05-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
​https://bugs.webkit.org/show_bug.cgi?id=32013

Test: fast/forms/radio-group-keyboard-change-event.html

  • html/RadioInputType.cpp: (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click

event. The simulated click event will check it for us but more importantly it will fire the "change" event as
expected.

2:20 PM Changeset in webkit [86087] by abarth@webkit.org
  • 2 edits
    2 adds in trunk

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
​https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

2:09 PM Changeset in webkit [86086] by robert@webkit.org
  • 5 edits in trunk

2011-05-09 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-09 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
1:22 PM Changeset in webkit [86085] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove canvas usage of roundToDevicePixels
​https://bugs.webkit.org/show_bug.cgi?id=60331

No new tests. This could only affect canvases at non-integral scale factors. Our tests only run in 1.0x.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
1:20 PM Changeset in webkit [86084] by xan@webkit.org
  • 2 edits in trunk

2011-05-09 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix logic in GCC version detection, it was reversed.

  • configure.ac:
12:57 PM Changeset in webkit [86083] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-09 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
​https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • Source/WebKit.pri:

2011-05-09 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
​https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • WebCore.pri:
12:49 PM Changeset in webkit [86082] by chang.shu@nokia.com
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <​cshu@webkit.org>

Unreviewed.

Expected result for editing/inserting/insert-bg-font.html can be shared
​https://bugs.webkit.org/show_bug.cgi?id=60498

  • editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
  • platform/gtk/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/qt/Skipped:
12:40 PM Changeset in webkit [86081] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Simple small-caps text is displayed in uniform size.
​https://bugs.webkit.org/show_bug.cgi?id=60492

Covered by existing tests.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): In the FontPlatformData constructor used by SimpleFontData::scaledFontData(), pass the pixel size to both QFont and QRawFont to make small caps and emphasis marks have the correct size when rendered through the fast font path.
12:32 PM Changeset in webkit [86080] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-09 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make DumpRenderTree build in components for linux
​https://bugs.webkit.org/show_bug.cgi?id=60491

  • WebKit.gyp: move some code that was in a Windows-only block to be used on all platforms.
12:32 PM Changeset in webkit [86079] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86075.
​http://trac.webkit.org/changeset/86075
​https://bugs.webkit.org/show_bug.cgi?id=60495

broke windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
12:22 PM Changeset in webkit [86078] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Remove unused FontPlatformData functions.
​https://bugs.webkit.org/show_bug.cgi?id=60485

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::bold): Removed. (WebCore::FontPlatformData::family): Removed. (WebCore::FontPlatformData::italic): Removed. (WebCore::FontPlatformData::smallCaps): Removed.
12:20 PM Changeset in webkit [86077] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Always set the font rendering mode based on preference values

WebPage::platformInitialize and WebPage::platformPreferencesDidChange were fighting over the
font rendering mode. The platformInitialize code predates preference-based font rendering
mode support, and is now redundant and incorrect.

Fixes <​http://webkit.org/b/60494> WebKit2 uses GDI text instead of CG text when
FontSmoothing preference is set to kWKFontSmoothingLevelNoSubpixelAntiAliasing in a .plist
on disk

Reviewed by Sam Weinig.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Removed code to set the font rendering mode.
platformPreferencesDidChange will take care of this for us.

12:07 PM Changeset in webkit [86076] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

Clean up NetscapePluginModule::getPluginInfo
​https://bugs.webkit.org/show_bug.cgi?id=60486

Make all 'get' functions take a PluginInfoStore::Plugin reference, since getPluginInfoFromPropertyLists
is going to need it to know the path and plug-in architecture.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::getPluginInfoFromCarbonResources): (WebKit::NetscapePluginModule::getPluginInfo):
12:04 PM Changeset in webkit [86075] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Take 2 on updating the WKSI libraries.

  • win/lib/WebKitSystemInterface.lib:
11:58 AM Changeset in webkit [86074] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9005982> REGRESSION (r85780): Flash of white when a WKView with composited content moves on-screen
​https://bugs.webkit.org/show_bug.cgi?id=60488

Reviewed by Darin Adler.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Update m_compositingAccordingToProxyMessages,
since the DidUpdateBackingStoreState message also changes the compositing state in the proxy.

11:54 AM Changeset in webkit [86073] by inferno@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

2011-05-09 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Rebaselines for r86065.

  • platform/chromium-linux/platform/gtk: Added.
  • platform/chromium-linux/platform/gtk/fonts: Added.
  • platform/chromium-linux/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac-leopard/platform: Added.
  • platform/chromium-mac-leopard/platform/gtk: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk: Added.
  • platform/chromium-mac/platform/gtk/fonts: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium-win/platform/gtk: Added.
  • platform/chromium-win/platform/gtk/fonts: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [86072] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Add invalid file handle check.

​https://bugs.webkit.org/show_bug.cgi?id=60483

11:23 AM Changeset in webkit [86071] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Update the popup menu code to grab the native control and initialize the
event handler properly.

​https://bugs.webkit.org/show_bug.cgi?id=60482

11:20 AM Changeset in webkit [86070] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Make sure other controls adjust the rect to handle transforms, and turn off the
adjustment in 2.9.2+ where it is handled internally by wx.

Also add a couple drawing and focus handling fixes for text fields and menulist controls.

​https://bugs.webkit.org/show_bug.cgi?id=60481

11:18 AM Changeset in webkit [86069] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Style fix: Function names must begin with lowercase letter and should not use "get".
​https://bugs.webkit.org/show_bug.cgi?id=60475

  • dom/Document.cpp: (WebCore::Document::webkitVisibilityState):
  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString): Renamed.
  • page/PageVisibilityState.h:
11:14 AM Changeset in webkit [86068] by kevino@webkit.org
  • 3 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Create empty event handler to avoid new mouse capture assert added in wx 2.9 on wxMSW.

​https://bugs.webkit.org/show_bug.cgi?id=60480

11:13 AM Changeset in webkit [86067] by abarth@webkit.org
  • 40 edits in trunk/Source

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60461

Fix many, many PassOwnPtr nits.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::detach):
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacks::didOpenFileSystem): (WebCore::ResolveURICallbacks::didOpenFileSystem):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayer::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::createRenderSurface):
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create):
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::TrackerRemoveOpenDatabaseTask::create):
  • storage/chromium/SQLTransactionClientChromium.cpp: (WebCore::NotifyDatabaseChangedTask::create):

2011-05-09 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60461

Fixed many, many PassOwnPtr nits.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::transaction):
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index):
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::create): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::connect):
  • src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::create):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::DebuggerTask::DebuggerTask): (WebKit::DebuggerTask::~DebuggerTask): (WebKit::DebuggerTask::run): (WebKit::WebDevToolsAgent::interruptAndDispatch):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::deleteFunction):
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::open):
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::deleteFunction): (WebKit::WebIDBObjectStoreImpl::clear): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::setCallbacks):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDevToolsAgentClient):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContext):
  • src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
11:04 AM Changeset in webkit [86066] by chang.shu@nokia.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <​cshu@webkit.org>

Unreviewed.

[Qt] editing/inserting/5803706-1.html has the incorrect expected result
​https://bugs.webkit.org/show_bug.cgi?id=60479

  • platform/qt/editing/inserting/5803706-1-expected.txt: Removed.
10:52 AM WikiStart edited by Ademar Reis
(diff)
10:52 AM Changeset in webkit [86065] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-09 Martin Robinson <​mrobinson@igalia.com>

Add a pixel result for platform/gtk/fonts/fontconfig-synthetic-bold.html.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
10:51 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:47 AM Changeset in webkit [86064] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Soup] Clean up error handling in ResourceHandleSoup
​https://bugs.webkit.org/show_bug.cgi?id=60436

Instead of repeating the ResourceError creation twice, abstract
it into a helper method.

No new tests. This is a code cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::soupErrorShouldCauseLoadFailure): Added. (WebCore::convertSoupErrorToResourceError): Added. (WebCore::sendRequestCallback): Use the new helpers. (WebCore::readCallback): Ditto.
10:32 AM Changeset in webkit [86063] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Pull jsonresults_unittest test cases out into separate test methods.
​https://bugs.webkit.org/show_bug.cgi?id=60418

  • TestResultServer/model/jsonresults_unittest.py:
10:29 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:19 AM Changeset in webkit [86062] by eric@webkit.org
  • 2 edits
    1 add in trunk/Websites/webkit.org

2011-05-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add guidelines for feature addition to webkit.org (per disccusion at contributor meeting)
​https://bugs.webkit.org/show_bug.cgi?id=59672

  • coding/adding-features.html: Added.
  • nav.inc:
10:13 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
9:32 AM Changeset in webkit [86061] by inferno@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Add a crash test for r85964.
​https://bugs.webkit.org/show_bug.cgi?id=59473

  • fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
  • fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.
9:29 AM Changeset in webkit [86060] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r85869): Restore dirty line logic in RenderInline::destroy.
​https://bugs.webkit.org/show_bug.cgi?id=60448

Test: fast/inline/inline-destroy-dirty-lines-crash.html

  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):

2011-05-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not when failing to dirty lines while removing
a inline.
​https://bugs.webkit.org/show_bug.cgi?id=60448

  • fast/inline/inline-destroy-dirty-lines-crash-expected.txt: Added.
  • fast/inline/inline-destroy-dirty-lines-crash.html: Added.
9:15 AM Changeset in webkit [86059] by alex
  • 2 edits in trunk/LayoutTests

2011-05-09 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip 2 more flaky svg tests failing by one pixel in
32-bits Debug, see bug 39022.

  • platform/gtk/Skipped:
8:38 AM Changeset in webkit [86058] by alex
  • 2 edits in trunk/Source/WebCore

2011-05-09 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] WidgetGtk setFocus can not access directly the widget in WK2
​https://bugs.webkit.org/show_bug.cgi?id=60016

Added code to check the situation where we do not have direct
access to the widget. We use the page to grab the focus which
would send a request to the UIProcess in WK2.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
8:27 AM BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
8:23 AM Changeset in webkit [86057] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed. Re-skip two failing inspector tests on Qt.

They still fail in the bot's environment for whatever reason.

  • platform/qt/Skipped:
8:00 AM Changeset in webkit [86056] by Adam Roben
  • 3 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Automatically touch WebKit.idl whenever any other WebKit1 IDL file changes

Fixes <​http://webkit.org/b/60468> WebKit.idl needs to be manually touched whenever any other
WebKit1 IDL file changes to avoid build errors

Reviewed by Tim Hatcher.

Updated for script rename.

  • JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Renamed

from react-to-vsprops-changes.py.
(top level): Moved a constant here from main.
(main): Moved most code from here to react_to_vsprops_changes. Added a call to the new
react_to_webkit1_interface_changes function.
(react_to_vsprops_changes): Moved code here from main. Updated to use the
TOP_LEVEL_DIRECTORY global. Moved some code from here to mtime_of_newest_file_matching_globa
and touch_if_older_than.
(react_to_webkit1_interface_changes): Added. Touches WebKit.idl if any other WebKit1 IDL
file has changed.
(mtime_of_newest_file_matching_glob): Added. Code came from main.
(touch_if_older_than): Added. Code came from main.

7:58 AM Changeset in webkit [86055] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-09 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
​https://bugs.webkit.org/show_bug.cgi?id=60387

Update the expected results for the argument types after the lastest updates
in the getUserMedia specification. The test has been disabled temporarily
and will be re-enabled by 60177 since some exceptions are risen after parsing
the provided options.

  • fast/dom/MediaStream/argument-types-expected.txt:
  • fast/dom/MediaStream/script-tests/argument-types.js: (ObjectThrowingException.prototype.toString):
  • platform/chromium/test_expectations.txt:

2011-05-09 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
​https://bugs.webkit.org/show_bug.cgi?id=60387

Perform the required changes to support rising exceptions in the
navigator.getUserMedia method. This is required by the latest changes in the spec:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::V8Navigator::webkitGetUserMediaCallback):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/Navigator.h:
  • page/Navigator.idl:
7:13 AM Changeset in webkit [86054] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed Qt 4.8 fix.

  • WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
7:06 AM Changeset in webkit [86053] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Minor skiplist cleanup.

Unskip two inspector tests that aren't failing.
Added explanation for why http/tests/misc/redirect-to-external-url.html is skipped.

  • platform/qt/Skipped:
7:06 AM Changeset in webkit [86052] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows project file fix after r86047

  • WebCore.vcproj/WebCore.vcproj: Added missing closing tags.
6:51 AM Changeset in webkit [86051] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
​https://bugs.webkit.org/show_bug.cgi?id=60417

Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
instead of the PlatformCALayer everywhere.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
6:41 AM Changeset in webkit [86050] by rwlbuis@webkit.org
  • 78 edits in trunk/Source/WebCore

2011-05-09 Rob Buis <​rbuis@rim.com>

Reviewed by Dirk Schulze.

Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
​https://bugs.webkit.org/show_bug.cgi?id=22576

Add tag name ASSERTs in SVG Element constructors.

No new tests, since no change in behaviour.

4:22 AM Changeset in webkit [86049] by mahesh.kulkarni@nokia.com
  • 4 edits in trunk

2011-05-09 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60458

Update all pages with Mock position/error/permission.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition):

2011-05-09 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60458

Unskipping fast/dom/Geolocation/window-close-crash.html.

  • platform/qt/Skipped:
4:17 AM Changeset in webkit [86048] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Srinivasulu Chereddy <​srinivasulu.chereddy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] one skipped 2d-transforms layout test passes on Qt Linux - skip list to be updated
​https://bugs.webkit.org/show_bug.cgi?id=60399

  • platform/qt/Skipped:
4:00 AM Changeset in webkit [86047] by commit-queue@webkit.org
  • 33 edits
    13 adds in trunk

2011-05-09 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=54181

  • fast/events/page-visibility-iframe-delete-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-delete-test.html: Added.
  • fast/events/page-visibility-iframe-move-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-move-test.html: Added.
  • fast/events/page-visibility-iframe-propagation-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-propagation-test.html: Added.
  • fast/events/page-visibility-transition-test-expected.txt: Added.
  • fast/events/page-visibility-transition-test.html: Added.
  • fast/events/resources/page-visibility-iframe-delete-test-frame.html: Added.
  • fast/events/resources/page-visibility-iframe-move-new-page.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-09 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=54181

Tests: fast/events/page-visibility-iframe-delete-test.html

fast/events/page-visibility-iframe-move-test.html
fast/events/page-visibility-iframe-propagation-test.html
fast/events/page-visibility-transition-test.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::visibilityState): (WebCore::Document::webkitVisibilityState): (WebCore::Document::webkitIsVisible): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:
  • page/Frame.cpp: (WebCore::Frame::dispatchVisibilityStateChangeEvent):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setVisibilityState): (WebCore::Page::visibilityState):
  • page/Page.h:
  • page/PageVisibilityState.cpp: Added. (WebCore::GetPageVisibilityStateString):
  • page/PageVisibilityState.h: Added.

2011-05-09 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=54181

  • WebKit.gyp:
  • public/WebPageVisibilityState.h: Added.
  • public/WebView.h: (WebKit::WebView::setVisibilityState):
  • public/WebViewClient.h: (WebKit::WebViewClient::visibilityState):
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setVisibilityState):
  • src/WebViewImpl.h:

2011-05-09 Shishir Agrawal <​shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=54181

  • DumpRenderTree/LayoutTestController.cpp: (setPageVisibilityCallback): (resetPageVisibilityCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::setPageVisibility): (LayoutTestController::resetPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::resetPageVisibility): (LayoutTestController::setPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.h:
3:55 AM Changeset in webkit [86046] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Venkat Penukonda <​venkat.2.penukonda@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt]6 of the skipped canvas layout tests pass on Qt Linux
​https://bugs.webkit.org/show_bug.cgi?id=60382

  • platform/qt/Skipped: Removed passing canvas tests
3:48 AM Changeset in webkit [86045] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

Build fix for WebKit 2 on Qt

Reviewed by Andreas Kling.

Qt treats warnings as errors so it does not build with unused variables. This patch removed two unused variable in WebKit 2.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::createTiles):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

2:19 AM Changeset in webkit [86044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement expanding CSS border properties in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=60456

No new tests added as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Create CSS border expanding property handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property handlers that are no longer needed.

May 8, 2011:

9:37 PM Changeset in webkit [86043] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r86042.
​http://trac.webkit.org/changeset/86042

The change contains an incorrect specification.

  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [86042] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <​morrita@google.com>

Unreviewed marking flaky test (insecure-plugin-in-iframe.html)

  • platform/chromium/test_expectations.txt:
8:29 PM Changeset in webkit [86041] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk

2011-05-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
​https://bugs.webkit.org/show_bug.cgi?id=60376

Added tests to ensure selectstart event is fired when a user selects all contents
and script can prevent such selection change in selectstart's event handler.

  • fast/events/selectstart-on-selectall-expected.txt: Added.
  • fast/events/selectstart-on-selectall.html: Added.
  • fast/events/selectstart-prevent-selectall-expected.txt: Added.
  • fast/events/selectstart-prevent-selectall.html: Added.

2011-05-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
​https://bugs.webkit.org/show_bug.cgi?id=60376

Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
document, editable region, or text control.

Tests: editing/selection/selectstart-on-selectall.html

editing/selection/selectstart-prevent-selectall.html

  • dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is input element or textarea element when the current selection is inside a shadow DOM, and the root editable element if it's inside a non-shadow editable region, and the body element otherwise.
  • html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer declared in Node.
7:16 PM Changeset in webkit [86040] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-08 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
​https://bugs.webkit.org/show_bug.cgi?id=60249

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setColumnBreakInside): Assert that supported values are used.
5:40 PM Changeset in webkit [86039] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a DragCaretController from FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=60273

Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
DragCaretController and FrameSelection and provides functions to paint caret.

Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.

  • WebCore.exp.in:
  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Added. (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true. (WebCore::DragCaretController::isContentRichlyEditable): Added. (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase. (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection. (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController. (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification. (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved and respondToNodeModification. Note that the position DragCaretController holds is equivalent to FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position, we used to execute the first if clause and cleared render tree selection and DOM tree selection. This is exactly what new DragCaretController::nodeWillBeRemoved does. (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions. (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection. (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned. Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if FrameSelection's start was not null. (WebCore::caretRendersInsideNode): Moved; Made static local. (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer. (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer. (WebCore::DragCaretController::caretRenderer): Ditto. (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments. (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*. (WebCore::CaretBase::caretRepaintRect): Ditto. (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect, and shouldRepaintCaret with extra arguments. (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable. (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect. (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect. (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret. (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret. (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for DragCaretController. (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
  • editing/FrameSelection.h: (WebCore::CaretBase::localCaretRectForPainting): Added. (WebCore::DragCaretController::isContentEditable): Added. (WebCore::DragCaretController::hasCaret): Added. (WebCore::DragCaretController::caretPosition): Added. (WebCore::DragCaretController::clear): Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): Uses DragCaretController. (WebCore::DragController::dispatchTextInputEventFor): Ditto. (WebCore::DragController::concludeEditDrag): Ditto. (WebCore::DragController::placeDragCaret): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
  • page/Page.h: (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
2:49 PM Changeset in webkit [86038] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86037.
​http://trac.webkit.org/changeset/86037
​https://bugs.webkit.org/show_bug.cgi?id=60453

broke Windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
2:30 PM Changeset in webkit [86037] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Update the WKSI libraries.

Rubber-stamped by Alice Liu.

  • win/lib/WebKitSystemInterface.lib:
1:56 PM Changeset in webkit [86036] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Make JSRetainPtr work with JSGlobalContextRefs.
​https://bugs.webkit.org/show_bug.cgi?id=60452

Reviewed by Dan Bernstein.

Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.

  • API/JSRetainPtr.h:

(JSRetain):
(JSRelease):

1:24 PM Changeset in webkit [86035] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-08 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

More rebaselines for r86028.

  • platform/chromium-linux/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.txt:
1:13 PM Changeset in webkit [86034] by imasaki@chromium.org
  • 5 edits in trunk/LayoutTests

2011-05-08 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Eric Seidel.

[Chromium] add rebaseline for video-volume-slider for GPU.
​https://bugs.webkit.org/show_bug.cgi?id=60427

These tests are failing due to text.
​http://code.google.com/p/chromium/issues/detail?id=81482

  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:
12:47 PM Changeset in webkit [86033] by inferno@chromium.org
  • 15 edits
    6 adds
    2 deletes in trunk/LayoutTests

2011-05-08 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

More chromium rebaseline for r86028.

  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-expected.png:
  • platform/chromium-linux/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-linux/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-linux/fast/text/trailing-white-space-expected.png:
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.txt:
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.txt:
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [86032] by inferno@chromium.org
  • 108 edits
    4 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r86028.

  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/chromium/test_expectations.txt:
11:53 AM Changeset in webkit [86031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-08 Kamil Blank <​k.blank@samsung.com>

Reviewed by Antonio Gomes.

Added new commands to be called by ewk_view_editor_command.
Due to this change ewk_view_select_* functions have been removed.
​https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_view.cpp: (ewk_view_execute_editor_command):
  • ewk/ewk_view.h:
10:36 AM Changeset in webkit [86030] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated a platform-specific expected result again after r86028.

  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
10:13 AM Changeset in webkit [86029] by mitz@apple.com
  • 48 edits in trunk/LayoutTests

Updated some platform-specific expected results after r86028.

  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/text/justified-selection-at-edge-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.txt:
  • platform/qt/fast/text/justify-nbsp-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
9:27 AM Changeset in webkit [86028] by mitz@apple.com
  • 63 edits in trunk

<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
​https://bugs.webkit.org/show_bug.cgi?id=60432

Reviewed by Darin Adler.

Source/WebCore:

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
variable is a (truncated) int anyway.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
so that the right amount is added to the total width. Also changed to use an early return.

LayoutTests:

  • fast/text/justify-nbsp-expected.png:
  • fast/text/justify-nbsp-expected.txt:
  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.png:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
9:09 AM Changeset in webkit [86027] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:
5:18 AM Changeset in webkit [86026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
​https://bugs.webkit.org/show_bug.cgi?id=58556

Tests: fast/canvas/webgl/gl-teximage.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):

May 7, 2011:

11:47 PM Changeset in webkit [86025] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Reverted unintended changes in r86024

11:42 PM Changeset in webkit [86024] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
​https://bugs.webkit.org/show_bug.cgi?id=60443

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/replaced/table-percent-height-positioned.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
doesn’t affect the table cell’s height).

LayoutTests:

  • fast/replaced/table-percent-height-positioned-expected.png: Added.
  • fast/replaced/table-percent-height-positioned-expected.txt: Added.
  • fast/replaced/table-percent-height-positioned.html: Added.
10:20 PM Changeset in webkit [86023] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-07 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Cleanup unexpected test passes in the gpu webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=60393

  • platform/chromium/test_expectations.txt:
9:42 PM Changeset in webkit [86022] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overlay fades out instead of disappearing immediately

Reviewed by Timothy Hatcher.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::hideFindUI): Do not fade out the overlay.

9:42 PM Changeset in webkit [86021] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Avoid copying a header file into the WebKit2 framework wrapper.

  • WebKit2.xcodeproj/project.pbxproj: Corrected the target membership of HTTPCookieAcceptPolicy.h.
7:50 PM Changeset in webkit [86020] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Testing EWS spins on patches with a large number of failures
​https://bugs.webkit.org/show_bug.cgi?id=60441

In cases where the tree has a small number of persistent failures but a
patch has a large number of failures, we weren't believing any results.
That lead to us retrying the patch forever while we waited for
trustworthy results that would never come.

This patch loosens the semantics of unexpected_failures to return a
subset (rather than the exact set) of unexpected failures. In the case
where the tree has a bounded number of failures and the patch has an
unbounded number of failures, we can accurately compute such a subset
and reject the patch.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
6:25 PM Changeset in webkit [86019] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows WebKit2 Release Tests]
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing since r85795.
​https://bugs.webkit.org/show_bug.cgi?id=60442

Add win-wk2 failing expected results to get the bots green.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
6:09 PM Changeset in webkit [86018] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
​http://trac.webkit.org/changeset/86016
​https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
5:58 PM Changeset in webkit [86017] by inferno@chromium.org
  • 5 edits in trunk/Source

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
​http://trac.webkit.org/changeset/85974
​https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):

2011-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
​http://trac.webkit.org/changeset/85974
​https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
5:49 PM Changeset in webkit [86016] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
4:46 PM Changeset in webkit [86015] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled

Add another test (fast/events/popup-blocked-from-mousemove.html) to the mac-wk2 Skipped list
to get the bots green.

  • platform/mac-wk2/Skipped:
4:39 PM Changeset in webkit [86014] by dbates@webkit.org
  • 1 edit in trunk/Source/WebKit/efl/ChangeLog

2011-05-07 Daniel Bates <​dbates@webkit.org>

Update title of bug in change log entry for changeset <​http://trac.webkit.org/changeset/86012>
so as to be consistent with the name of the bug in <​https://bugs.webkit.org/show_bug.cgi?id=60151>.

4:37 PM Changeset in webkit [86013] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Add willPerformClientRedirect to the user-gesture tests.

  • fast/frames/location-redirect-user-gesture-expected.txt:
  • fast/frames/meta-refresh-user-gesture-expected.txt:

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Create a UserGestureIndicator when calling the clientRedirected callback.

  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer):

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):

2011-05-07 Joe Mason <​jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
​https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
(For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willPerformClientRedirect): (WebViewHost::didStartProvisionalLoad):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
4:34 PM Changeset in webkit [86012] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-07 Tomasz Morawski <​t.morawski@samsung.com>

Reviewed by Daniel Bates.

[EFL] Remove ewk_tile_unused_cache_free function form public api
​https://bugs.webkit.org/show_bug.cgi?id=60151

The ewk_tile_unused_cache_free function should be only called by
ewk_tile_unused_cache_unref function. Calling this function without
considering reference counting may lead to fatal results.

  • ewk/ewk_tiled_model.c: (_ewk_tile_unused_cache_free): (ewk_tile_unused_cache_unref):
  • ewk/ewk_tiled_model.h:
4:34 PM Changeset in webkit [86011] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
introduction in r85669.
​https://bugs.webkit.org/show_bug.cgi?id=60272

Add expected failing text results to get the bots green.

Note: these tests still need pixel results to be generated both for mac-wk2 and win-wk2.

  • platform/mac-wk2/editing/selection: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt: Added.
4:15 PM Changeset in webkit [86010] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

2011-05-07 Daniel Bates <​dbates@webkit.org>

Update change log entry for changeset <​http://trac.webkit.org/changeset/86009> to
explain that this was an attempt to fix the build after changeset 86007
<​http://trac.webkit.org/changeset/86007> (bug #60438).

4:08 PM Changeset in webkit [86009] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-05-07 Daniel Bates <​dbates@webkit.org>

Remove some more references to isTiger(), which was removed in changeset 86007
<​http://trac.webkit.org/changeset/86007> (bug #60438).

  • Scripts/old-run-webkit-tests:
    • Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and file local variable.
3:59 PM Changeset in webkit [86008] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-07 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Daniel Bates.

Fix compile with GCC 4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=60380

Remove unused local variable from code.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch):
12:56 PM Changeset in webkit [86007] by psolanki@apple.com
  • 5 edits in trunk/Tools

Remove references to Tiger in scripts
​https://bugs.webkit.org/show_bug.cgi?id=60438

Reviewed by Darin Adler.

Remove isTiger() and all of the code that depends on it.

  • Scripts/build-webkit:
  • Scripts/ensure-valid-python:
  • Scripts/gdb-safari:
  • Scripts/webkitdirs.pm:
7:36 AM Changeset in webkit [86006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-07 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Adam Roben.

[Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961
​https://bugs.webkit.org/show_bug.cgi?id=60420

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: (WebKit::NetscapePlugin::platformVisibilityDidChange):
12:52 AM Changeset in webkit [86005] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 85586
BUG=81348
Review URL: ​http://codereview.chromium.org/6953015

12:32 AM Changeset in webkit [86004] by cevans@google.com
  • 2 edits
    14 copies in branches/chromium/742

Merge 85876
BUG=72832
Review URL: ​http://codereview.chromium.org/6952018

12:17 AM Changeset in webkit [86003] by cevans@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/rendering

Merge 85705
BUG=79746
Review URL: ​http://codereview.chromium.org/6948015

12:08 AM Changeset in webkit [86002] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when sending a wheel event to a node with no shadow ancestor node
​https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>

Reviewed by Alice Liu.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.

May 6, 2011:

11:12 PM Changeset in webkit [86001] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/742

Merge 85964
BUG=72832
Review URL: ​http://codereview.chromium.org/6949014

10:49 PM Changeset in webkit [86000] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Forgot it since my last svg rebaseline r85981.

  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
10:02 PM Changeset in webkit [85999] by inferno@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium rebaselines for r85990

  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
9:24 PM Changeset in webkit [85998] by tkent@chromium.org
  • 32 edits
    2 deletes in trunk/Source

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement and TextFieldInputType.
  • Change the return type of Node::toInputElement(): InputElement* -> HTMLInputElement*

No new tests. This change should not change the existing behaviour.

  • CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
  • GNUmakefile.list.am: ditto.
  • WebCore.exp.in: Add symbols of functions exposed to WebKit.
  • WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): Follow the return type change of Node::toInputElement().
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): ditto. (WebCore::AccessibilityRenderObject::isIndeterminate): ditto. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto. (WebCore::AccessibilityRenderObject::isChecked): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  • dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton): ditto.
  • dom/DOMAllInOne.cpp: Remove InputElement.h.
  • dom/InputElement.cpp: Removed.
  • dom/InputElement.h: Removed.
  • dom/Node.cpp: (WebCore::Node::toInputElement): Change the return type from InputElement* to HTMLInputElement*.
  • dom/Node.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::formControlName): (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::size): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): (WebCore::HTMLInputElement::setDefaultName): (WebCore::HTMLInputElement::maxLength): (WebCore::HTMLInputElement::cacheSelection): (WebCore::formatCodes): Moved from InputElement. (WebCore::cursorPositionToMaskIndex): ditto. (WebCore::HTMLInputElement::isConformToInputMask): ditto. (WebCore::HTMLInputElement::validateInputMask): ditto. (WebCore::HTMLInputElement::setWapInputFormat): ditto. (WebCore::HTMLInputElement::notifyFormStateChanged): ditto. (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto. (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
  • html/HTMLInputElement.h:
    • Add data members which were defined in InputElementData.
    • Make some functions public because the public interface InputElement is removed.
    • Make some functions non-virtual because they don't override corresponding virtual functions of InputElement anymore.

(WebCore::HTMLInputElement::toInputElement):

Follow the return type change of Node::toInputElement().

(WebCore::HTMLInputElement::isIndeterminate):
(WebCore::HTMLInputElement::isAutofilled):
(WebCore::HTMLInputElement::supportsMaxLength):
(WebCore::HTMLInputElement::cachedSelectionStart):
(WebCore::HTMLInputElement::cachedSelectionEnd):

  • html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
  • html/InputType.cpp: (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
  • html/InputType.h: Update for the above.
  • html/TextFieldInputType.cpp: (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp. (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength(). (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Move the code from InputElement::handleBeforeTextInsertedEvent().
  • html/TextFieldInputType.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp:
    • Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
    • Follow the return type change of inputElement().

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):

Make sure node() is an HTMLInputElement instance.

(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
(WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
(WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::startSearchEventTimer):
(WebCore::RenderTextControlSingleLine::searchEventTimerFired):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTextControlSingleLine.h: Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): Follow the return type change of Node::toInputElement(). (WebCore::RenderTheme::isIndeterminate): ditto. (WebCore::RenderTheme::shouldHaveSpinButton): Change the parameter type: InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.h: ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength. (WebKit::toWebInputElement): Follow the return type change of Node::toInputElement().

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Follow the return type change of Node::toInputElement(). (DumpRenderTreeSupportGtk::setValueForUser): ditto.

2011-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=60262

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAutofilled): Follow the return type change of Node::toInputElement().
8:51 PM Changeset in webkit [85997] by cevans@google.com
  • 14 edits
    2 copies in branches/chromium/742

Merge 85823
BUG=64046
Review URL: ​http://codereview.chromium.org/6955016

8:45 PM Changeset in webkit [85996] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/742

Merge 85926
BUG=80608
Review URL: ​http://codereview.chromium.org/6949013

8:26 PM Changeset in webkit [85995] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/696

Merge 85926
BUG=80608

8:19 PM Changeset in webkit [85994] by cevans@google.com
  • 12 edits
    2 copies in branches/chromium/696

Merge 85823
BUG=64046

7:13 PM Changeset in webkit [85993] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

  • http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
​https://bugs.webkit.org/show_bug.cgi?id=60402

This mode lets web sites try out CSP by getting violation reports (and
console spam) without actually changing the behavior of their web sites.

Test: http/tests/security/contentSecurityPolicy/report-only.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h:
6:18 PM Changeset in webkit [85992] by imasaki@chromium.org
  • 8 edits in trunk/LayoutTests

2011-05-06 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline to chromium for video-layer.
​https://bugs.webkit.org/show_bug.cgi?id=60423

These expected files are produced by the rebaseline tool.
​http://code.google.com/p/chromium/issues/detail?id=81833

  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [85991] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by David Levin.

[chromium] Rebaseline needed for media/audio-repaint
​https://bugs.webkit.org/show_bug.cgi?id=60416

  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [85990] by Beth Dakin
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60421
Custom scrollbars nested inside an overlay scrollbar overflow region end up
painting twice
-and corresponding-
<rdar://problem/9389072>

Reviewed by Darin Adler.

Source/WebCore:

Be sure not to paint custom css scrollbars during the special overlay-scrollbar
painting pass.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):

LayoutTests:

  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • scrollbars/scrollbars-on-positioned-content.html: Added.
5:50 PM WebKit Team edited by rniwa@webkit.org
Adding "Core DOM" and "Event Handling" to my area of knowledge (diff)
5:47 PM Changeset in webkit [85989] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-05-06 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Add utility for converting SkCanvas to CGContext
​https://bugs.webkit.org/show_bug.cgi?id=59808

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The BitLockerSkia utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

Each time the CGContext is retrieved, it is rebuilt.
This permits the caller to modify the same canvas
between calls.

This change adds utilities but does not modify any
existing code. For now, there are no callers to these
utilities, so there is no functional change.

No new tests.

  • platform/graphics/skia/BitLockerSkia.cpp: Added. (WebCore::SkMatrixToCGAffineTransform): Conversion utility. (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas. (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up. (WebCore::BitLockerSkia::release): Internal private helper. (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
  • platform/graphics/skia/BitLockerSkia.h: Added.
5:11 PM Changeset in webkit [85988] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-06 David Grogan <​dgrogan@chromium.org>

Reviewed by Eric Seidel.

update link to message about mac 64bit git binaries
​https://bugs.webkit.org/show_bug.cgi?id=60411

The original message implied (correctly, at-the-time) that
​http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
binaries. The new message notes that they do. This might prevent someone
else from spending a few minutes confused.

  • Scripts/webkitpy/common/checkout/scm/git.py:
4:29 PM Changeset in webkit [85987] by Martin Robinson
  • 6 edits
    2 adds in trunk/Source

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract coordinate system translation code from WebKit into WebCore.
This will allow the code to be shared between WebKit and WebKit2. The code
now lives in a new GtkUtilities.cpp helper file.

  • GNUmakefile.list.am: Added GtkUtilities to the source list.
  • platform/gtk/GtkUtilities.cpp: Added. (WebCore::convertWidgetRectToScreenRect):
  • platform/gtk/GtkUtilities.h: Added.

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract the code to translate from widget space to screen space into
a helper method in WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities. (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
​https://bugs.webkit.org/show_bug.cgi?id=55960

Add an implementation of PageClient::windowToScreen for GTK+ WebKit2 using
the newly abstracted widget to screen coordinate translation code in WebCore.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::windowToScreen): Added implementation.
4:12 PM Changeset in webkit [85986] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Disable platform/win/plugins/visibility-hidden.html.

  • platform/chromium/test_expectations.txt:
4:07 PM Changeset in webkit [85985] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove some unnecessary static methods in ResourceHandleSoup.

No new tests. This is only a small cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly. (WebCore::gotHeadersCallback):Ditto. (WebCore::contentSniffedCallback):Ditto. (WebCore::sendRequestCallback):Ditto. (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
4:06 PM Changeset in webkit [85984] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] ResourceHandles are leaked on 304 responses
​https://bugs.webkit.org/show_bug.cgi?id=60413

Always call cleanupSoupRequestOperation, even when the request was not
canceled. Before the code would call didFinishLoading and then never clean up
the request.

No new tests. This simply fixes a memory leak.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
3:50 PM Changeset in webkit [85983] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Simplify the PluginInfoStore interface
​https://bugs.webkit.org/show_bug.cgi?id=60406

Just expose a single API for getting a list of plug-ins from the info store,
PluginInfoStore::plugins and remove PluginInfoStore::getPlugins and PluginInfoStore::getPluginPaths.

Also, change the WebContext::pluginInfoStore() getter to return a reference.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): (WebKit::WebContext::getPluginPath):
  • UIProcess/WebContext.h: (WebKit::WebContext::pluginInfoStore):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType):
3:38 PM Changeset in webkit [85982] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-05-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: crashes in race with crashing DRT
​https://bugs.webkit.org/show_bug.cgi?id=60238

This fixes a race where if we wrote the URL to DRT and
DRT crashed immediately, we could get a broken pipe
error back during the write() and not handle it correctly,
causing NRWT to also crash.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:16 PM Changeset in webkit [85981] by inferno@chromium.org
  • 61 edits
    28 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Rebaselines for r85926.
​https://bugs.webkit.org/show_bug.cgi?id=60356

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
  • platform/chromium-mac/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
3:08 PM Changeset in webkit [85980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:52 PM Changeset in webkit [85979] by inferno@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r85964, r85971 and r85967.

  • platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [85978] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make more PluginInfoStore member functions static
​https://bugs.webkit.org/show_bug.cgi?id=60401

This is a first step towards making PluginInfoStore thread safe.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
2:12 PM Changeset in webkit [85977] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • fast/events/popup-blocked-from-mousemove-expected.txt: Added.
  • fast/events/popup-blocked-from-mousemove.html: Added.

2011-05-06 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
​https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
2:06 PM Changeset in webkit [85976] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Fix error due to duplicate entry.

  • platform/chromium/test_expectations.txt:
2:03 PM Changeset in webkit [85975] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60301

This CSP directive is not in the CSP spec. This patch is somewhat of
an experiment to see whether this feature is useful. Based on our
implementation experience, we will coordinate with folks via the W3C to
see if this makes sense to add to the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:52 PM Changeset in webkit [85974] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
​https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
1:29 PM Changeset in webkit [85973] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Fix two warnings of unused variables.
​https://bugs.webkit.org/show_bug.cgi?id=60370

Remove two unused local variable from the code.

No new tests, the existing ones should cover.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateNextProgressTime):
1:13 PM Changeset in webkit [85972] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
    • Boo different error messages.
  • platform/chromium/test_expectations.txt:
    • Test progression.

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
​https://bugs.webkit.org/show_bug.cgi?id=60384

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
1:07 PM Changeset in webkit [85971] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.
12:22 PM Changeset in webkit [85970] by enne@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline changes after r85959
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [85969] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a --skip-integrationtests mode to test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=60354

These two test suites account for 2/3 of test-webkitpy's running time
because they're not actually unit tests. They're integration tests.
This patch adds the ability to skip integration tests by passing a
command line argument to test-webkitpy. The buildbots will continue to
run these integration tests to make sure they don't regress. This
option is for use by developers when working on parts of the code that
are well-covered by unit tests.

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
  • Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
12:14 PM Changeset in webkit [85968] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[results.html] label the zoomed pixel containers (expected, actual, diff)
​https://bugs.webkit.org/show_bug.cgi?id=60383

  • fast/harness/results.html:
12:10 PM Changeset in webkit [85967] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Add pixel results for mac.

  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.
12:09 PM Changeset in webkit [85966] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 John Abd-El-Malek <​jam@chromium.org>

Reviewed by James Robinson.

[chromium]: Reland using WebPermissionClient for checking indexed db usage
​https://bugs.webkit.org/show_bug.cgi?id=60386

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
12:05 PM Changeset in webkit [85965] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-06 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Add baselines to chromium for video-source-error that reflect the fact that
chromium does not support mp4.

[chromium] Rebaseline needed for video-source-error
​https://bugs.webkit.org/show_bug.cgi?id=60292

  • platform/chromium/media/video-source-error-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [85964] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank

Reviewed by Dan Bernstein.

Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.

Source/WebCore:

Added fast/block/positioning/hiding-inside-relpositioned-inline.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

  • fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
11:49 AM Changeset in webkit [85963] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: move selection test into the text area branch.

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
11:48 AM Changeset in webkit [85962] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Mac build fix

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a

missing #import.

11:41 AM Changeset in webkit [85961] by Adam Roben
  • 18 edits
    3 adds in trunk

Show/hide windowed plugins according to the plugin element's visibility CSS property

Fixes <​http://webkit.org/b/60285> <rdar://problem/9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed

Reviewed by Anders Carlsson.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::isPluginVisible):

  • PluginProcess/PluginControllerProxy.h:

Stubbed out.

  • Shared/win/WindowGeometry.cpp:

(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):

  • Shared/win/WindowGeometry.h:

Added visible member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::visibilityDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Added. Calls through to platform-specific code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformVisibilityDidChange):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.

  • WebProcess/Plugins/Plugin.h: Added visibilityDidChange.
  • WebProcess/Plugins/PluginController.h: Added isPluginVisible.
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::visibilityDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Stubbed out.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.

(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.

  • WebProcess/Plugins/PluginView.h: Updated for PluginController changes.

LayoutTests:

Add a test that shows that windowed plugins with visibility:hidden do not appear on screen

I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <​http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.

  • platform/win/plugins/visibility-hidden-expected.png: Added.
  • platform/win/plugins/visibility-hidden-expected.txt: Added.
  • platform/win/plugins/visibility-hidden.html: Added.
11:35 AM Changeset in webkit [85960] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The results.zip generated by the Chromium EWS are too big
​https://bugs.webkit.org/show_bug.cgi?id=60352

Currently results.zip created by the Chromium EWS bot contain roughly
1000 tests that we expect to fail. These test results are not helpful
to contributors.

There are several approaches to solving this problem:

1) We could be more selective about which files to include in the zip.
2) We could ask new-run-webkit-tests not to generate results for

expected failures.

3) We could ask new-run-webkit-tests not to run tests that we expect to

fail.

This patch takes approach (3). Currently, we're ignoring the outcome
of failing tests anyway, so there's not much point in actually running
them. As a side benefit, this will speed up the test run by about 6%.
In the future, we might revisit this decision and choose another
approach.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
10:41 AM Changeset in webkit [85959] by enne@google.com
  • 4 edits
    4 adds in trunk

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Added.
  • compositing/flat-with-transformed-child.html: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
​https://bugs.webkit.org/show_bug.cgi?id=59020

Allow for empty scissor rects, which implies scissoring to the render
surface. The previous code and previous patch on this bug both didn't
take into account that the scissor rect should be the render surface
and not the projection of the layer itself, because child layers
aren't necessarily contained within the bounds of their superlayer.

Test: compositing/flat-with-transformed-child.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
10:30 AM Changeset in webkit [85958] by Adam Roben
  • 15 edits
    2 adds in trunk/Source/WebKit2

Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message

This will make it easier to add more info to this message in the future (like whether the
window is visible).

Fixes <​http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious

Reviewed by Anders Carlsson.

  • Scripts/webkit2/messages.py:

(struct_or_class): Added WindowGeometry to the list of structs.

  • Shared/win/WindowGeometry.cpp: Added.
  • Shared/win/WindowGeometry.h: Added.
  • win/WebKit2.vcproj: Added new files.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.

10:22 AM Changeset in webkit [85957] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Mihai Parparita.

[results.html] zoomed pixel results should not be antialiased
​https://bugs.webkit.org/show_bug.cgi?id=60330

-Use canvas instead of CSS zoom.
-Only zoom the part of the image we need to show.
-Make pixel zooming mostly work in Firefox.
-Increase the zoom from 3x to 6x.

  • fast/harness/results.html:
10:22 AM Changeset in webkit [85956] by ddkilzer@apple.com
  • 4 edits in trunk/Source

Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings

Reviewed by Jon Honeycutt.

This fixes an Xcode 4 warning about using obsolete settings.

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

10:12 AM Changeset in webkit [85955] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-05-06 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Lazily allocate ScrollAnimator in ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=60327

Avoid allocating the ScrollAnimator up-front, because we
create lots of ScrollableAreas via RenderLayer, and we should
only need the animator when scrolling.

  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::ScrollableArea): (WebCore::ScrollableArea::scrollAnimator): (WebCore::ScrollableArea::scroll): (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation): (WebCore::ScrollableArea::handleWheelEvent): (WebCore::ScrollableArea::handleGestureEvent):
  • platform/ScrollableArea.h:
10:04 AM Changeset in webkit [85954] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85919.
​http://trac.webkit.org/changeset/85919
​https://bugs.webkit.org/show_bug.cgi?id=60378

broke chromium database tests (Requested by inferno-sec on
#webkit).

  • public/WebPermissionClient.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
9:55 AM Changeset in webkit [85953] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement NetscapePlugin::platformPaint for GTK platform
​https://bugs.webkit.org/show_bug.cgi?id=60368

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformPaint):
9:37 AM Changeset in webkit [85952] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4

Create the 1.4 stable branch

9:03 AM Changeset in webkit [85951] by Carlos Garcia Campos
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

Share PluginInfoStore implementation between Qt and GTK ports
​https://bugs.webkit.org/show_bug.cgi?id=60366

  • GNUmakefile.am:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Removed.
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.pro:
8:51 AM Changeset in webkit [85950] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, fix parse errors in test_expectations.

I will annotate bug 60356 so that this case gets looked at.

  • platform/chromium/test_expectations.txt:
8:23 AM Changeset in webkit [85949] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
​https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/9392609>

Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.

Tested manually because we don't have any live streams to test in DRT.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay. (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay. (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::reset): Ditto. (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:
8:06 AM Changeset in webkit [85948] by Adam Roben
  • 3 deletes in trunk/LayoutTests/platform/win/plugins

Roll out r85946

I didn't mean to commit it!

8:04 AM Changeset in webkit [85947] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Touch WebKit.idl to fix the build

I needed this on my own machine. Maybe others will need it, too.

  • Interfaces/WebKit.idl:
8:02 AM Changeset in webkit [85946] by Adam Roben
  • 3 adds in trunk/LayoutTests/platform/win/plugins

Add a test for visibility:hidden for plugins

7:46 AM Changeset in webkit [85945] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.

std::tr1::has_trivial_constructor is in <tr1/memory>.

  • wtf/TypeTraits.h:
7:35 AM Changeset in webkit [85944] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed Qt 4.8 build fix.

  • WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can enable it after the 4.8 bots are updated with the full QRawFont APIs.
6:48 AM Changeset in webkit [85943] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
​https://bugs.webkit.org/show_bug.cgi?id=60319

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
6:24 AM Changeset in webkit [85942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use qt-arm platform instead of qt-linux on ARM platform.

Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
3:51 AM Changeset in webkit [85941] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

[Qt]fast/events/backspace-navigates-back.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60349

  • platform/mac-wk2/Skipped: Add fast/events/backspace-navigates-back.html because of missing layoutTestController.setEditingBehavior().
  • platform/qt-arm/Skipped: Add fast/events/backspace-navigates-back.html.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-mac/Skipped: Add fast/events/backspace-navigates-back.html.
2:17 AM Changeset in webkit [85940] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <​pnormand@igalia.com>

Windows DRT needs an implementation of shadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=59081

Skip media/video-controls-visible-audio-only.html that now
requires shadowRoot support.

  • platform/win/Skipped:
1:58 AM Changeset in webkit [85939] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8. Relative urls should not be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=57138

  • http/tests/websocket/tests/url-with-nonascii-query-expected.txt: Added.
  • http/tests/websocket/tests/url-with-nonascii-query.html: Added.
  • http/tests/websocket/tests/url-parsing-expected.txt: Failure message for relative url has changed since it is no longer expanded.

2011-05-06 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8.
​https://bugs.webkit.org/show_bug.cgi?id=57138

Change WebSocket::connect to take the raw URL string and parse it
internally using the simple KURL constructor, which expects an absolute
UTF-8 encoded URL. This ensures that all code that creates a WebSocket
goes through this method instead of completeURL.

Test: http/tests/websocket/tests/url-with-nonascii-query.html

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
  • websockets/WebSocket.h:
1:42 AM Changeset in webkit [85938] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
​https://bugs.webkit.org/show_bug.cgi?id=60339

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialColorSpace): Add initialColorSpace() static method.
1:33 AM Changeset in webkit [85937] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed, marking tests whose expectations became obsolete since r85926.

  • platform/chromium/test_expectations.txt:
1:27 AM Changeset in webkit [85936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setPageBreakInside() reject unsupported enum values.
​https://bugs.webkit.org/show_bug.cgi?id=60235

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setPageBreakInside): Assert that only supported values are used.
1:17 AM Changeset in webkit [85935] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Move burden of checking for BJustify box alignment into RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=60246

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case logic checking for BJUSTIFY and use existing macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBoxAlign): Assert valid values are used.
1:00 AM Changeset in webkit [85934] by Philippe Normand
  • 7 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Layout tests shouldn't have to hard code media controller element locations
​https://bugs.webkit.org/show_bug.cgi?id=28220

New mediaControlsButtonCoordinates() function to get the middle
coordinates of a media controls button. This avoids hardcoding
positions in the tests.

Also unskipped the affected GTK media tests now passing.

  • media/audio-delete-while-step-button-clicked.html:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (mediaControlsButtonCoordinates):
  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [85933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
​https://bugs.webkit.org/show_bug.cgi?id=60338

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
12:47 AM Changeset in webkit [85932] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (send-form-data-with-sliced-file.html)

  • platform/chromium/test_expectations.txt:
12:45 AM Changeset in webkit [85931] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85860.

  • UIProcess/API/gtk/PageClientImpl.h: Fix typo.
12:43 AM Changeset in webkit [85930] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (resource-tree-frame-navigate.html)

  • platform/chromium/test_expectations.txt:
12:39 AM Changeset in webkit [85929] by Csaba Osztrogonác
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/mac-wk2/Skipped:
    • Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
  • platform/qt-arm/Skipped:
    • Add fast/css/hover-update.html, because it fails intermittently.
    • Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-wk2/Skipped:
    • Add new but failing test: editing/pasteboard/paste-placeholder-input.html
12:35 AM Changeset in webkit [85928] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix with gcc 4.6 and c++0x support.
​https://bugs.webkit.org/show_bug.cgi?id=60284

When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.

No new tests, build fix.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::create):
12:33 AM Changeset in webkit [85927] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

Add an option to NRWT to skip failing tests
​https://bugs.webkit.org/show_bug.cgi?id=60295

This option is similar to the way old-run-webkit-tests works. We're
planning to use this option on the testing EWS bots because they don't
use information from failing tests yet.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:33 AM Changeset in webkit [85926] by cdn@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Change maxEffectRect to a FloatRect.
​https://bugs.webkit.org/show_bug.cgi?id=59551

  • svg/filters/filter-after-transform-crash-expected.txt: Added.
  • svg/filters/filter-after-transform-crash.svg: Added.

2011-05-06 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Tests for crash when a transform is applied to certain filters.
​https://bugs.webkit.org/show_bug.cgi?id=59551

Test: svg/filters/filter-after-transform-crash.svg

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::determineAbsolutePaintRect):
  • platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  • platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  • platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
  • platform/graphics/filters/FELighting.h: (WebCore::FELighting::determineAbsolutePaintRect):
  • platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
  • platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::isFilterSizeValid): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::maxEffectRect): (WebCore::FilterEffect::setMaxEffectRect):
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
12:27 AM Changeset in webkit [85925] by Philippe Normand
  • 38 edits in trunk

Tools:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

shadowPseudoId support in the various LayoutTestController
implementations.

  • DumpRenderTree/LayoutTestController.cpp: (shadowPseudoIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

WebKit2:

2011-05-05 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleShadowPseudoId):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot): (WebKit::InjectedBundleNodeHandle::elementShadowPseudoId):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

WebKit/win:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOMCoreClasses.cpp: (DOMElement::shadowPseudoId):
  • DOMCoreClasses.h:

WebKit/qt:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKit/mac:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowPseudoId]):
  • DOM/WebDOMOperationsPrivate.h:

WebKit/gtk:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

WebKit/chromium:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::shadowPseudoId):

LayoutTests:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
​https://bugs.webkit.org/show_bug.cgi?id=60034

  • media/video-controls-transformed.html: Refactored to use the pseudoShadowId() LayoutTestController method.
12:19 AM Changeset in webkit [85924] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <​morrita@google.com>

Unreviewed flakiness marking. (test_boolean_expr.html)

  • platform/chromium/test_expectations.txt:
12:11 AM Changeset in webkit [85923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Use cast to convert primitive value to FontSmoothingMode.
​https://bugs.webkit.org/show_bug.cgi?id=60242

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to convert primitive value to FontSmoothingMode.
12:06 AM Changeset in webkit [85922] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <​abarth@webkit.org>

EWS can't reject patches
​https://bugs.webkit.org/show_bug.cgi?id=60345

We're supposed to use patch.id() for the attachment ID, silly.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Note: See TracTimeline for information about the timeline view.