Timeline



May 17, 2011:

11:16 PM Changeset in webkit [86738] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
​https://bugs.webkit.org/show_bug.cgi?id=60982

The GraphicsLayer tree has unparented m_fullScreenRootLayer behind our backs, replacing the
tiled layer with a normal one. Instead of holding on to a specific layer, assume that the
w_rootLayer will only have 0 or 1 children, and if a child is present, then that is our full-
screen layer.

Additionally, check to see if the animating layer's presentationLayer is nil
before calling it; asking a nil object for a CATransform3D will give back a struct full of
garbage.

In WKFullScreenWindowController, when the exit animation completes, ignore the "completed"
parameter. This eliminates the possibility that the full screen window will end up left
on top of the screen if the animation is cancelled and a enter full screen animation isn't
forthcoming.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
11:12 PM Changeset in webkit [86737] by jer.noble@apple.com
  • 9 edits in trunk

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60997

Updated the following tests with the new expectation that removing an element from the DOM will trigger
full screen mode to exit.

  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-ancestor.html:
  • fullscreen/full-screen-remove-children-expected.txt:
  • fullscreen/full-screen-remove-children.html:
  • fullscreen/full-screen-remove-expected.txt:
  • fullscreen/full-screen-remove.html:

2011-05-17 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60997

Tests: fullscreen/full-screen-remove-ancestor.html

fullscreen/full-screen-remove-children.html
fullscreen/full-screen-remove.html

  • dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document

make sure to message the documentElement() as well.

(WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.

10:50 PM Changeset in webkit [86736] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Skip failing tests on minor Qt platforms.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
10:22 PM Changeset in webkit [86735] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests now pass:
fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html

  • platform/chromium/test_expectations.txt:
9:43 PM Changeset in webkit [86734] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=61022

Reviewed by Alice Liu.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.

8:56 PM Changeset in webkit [86733] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.

  • platform/chromium/test_expectations.txt:
8:50 PM Changeset in webkit [86732] by yutak@chromium.org
  • 16 edits in trunk

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
​https://bugs.webkit.org/show_bug.cgi?id=60878

The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
expected results of tests that dump WebSocket.readyState.

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/handshake-error-expected.txt:
  • http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js: (ws.onclose):
  • http/tests/websocket/tests/script-tests/handshake-error.js: (ws.onclose):
  • http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/simple-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
​https://bugs.webkit.org/show_bug.cgi?id=60878

No new tests are added because there is no change in functionality.

  • platform/network/SocketStreamHandleBase.h:
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
8:47 PM Changeset in webkit [86731] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/invalidate_rect.html now passes on Linux.

  • platform/chromium/test_expectations.txt:
8:23 PM Changeset in webkit [86730] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.

  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
8:07 PM Changeset in webkit [86729] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

More attempts to work around the EFL build system being borken.

  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
8:03 PM Changeset in webkit [86728] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the EFL build.

  • runtime/BooleanPrototype.cpp:
7:39 PM Changeset in webkit [86727] by ggaren@apple.com
  • 47 edits in trunk

Source/JavaScriptCore: Rolling back in r86653 with build fixed.

Reviewed by Gavin Barraclough and Oliver Hunt.

Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933

Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.

This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

  • create_hash_table: Added a special case for fromCharCode, since it uses

a custom "thunk generator".

  • heap/Heap.cpp:

(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.

  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h: Added new tables.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a

static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.

Even more global object properties can be made lazy, but that requires
more in-depth changes.

  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.

LayoutTests: Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933

Reviewed by Gavin Barraclough.

Added a few more expected failures, now that more code uses static hash
tables.

The fact that built-ins are not deletable, but should be, is covered by
​https://bugs.webkit.org/show_bug.cgi?id=61014

  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
6:48 PM Changeset in webkit [86726] by morrita@google.com
  • 12 edits
    3 copies
    1 move in trunk/Source/WebCore

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] ShadowContentElement should be part of dom/
​https://bugs.webkit.org/show_bug.cgi?id=59117

  • Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
  • Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
  • Added ShadowContentElement.cpp
  • Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
  • dom/Node.h: (WebCore::Node::forceReattach): Moved from static local function to share between classes.
  • dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::attach):
  • dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::isShadowBoundary): (WebCore::ShadowContentElement::rendererIsNeeded): (WebCore::ShadowContentElement::createRenderer):
  • dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor):
  • dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::recalcStyle):
  • html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsSummaryElement::DetailsSummaryElement):
  • html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement):
5:53 PM Changeset in webkit [86725] by cdn@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-17 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
​https://bugs.webkit.org/show_bug.cgi?id=61005

Test: http/tests/loading/nested_bad_objects.php

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2011-05-17 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when two nested image objects with invalid data are loaded.
​https://bugs.webkit.org/show_bug.cgi?id=61005

  • http/tests/loading/nested_bad_objects-expected.txt: Added.
  • http/tests/loading/nested_bad_objects.php: Added.
5:29 PM Changeset in webkit [86724] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.

Rubberstamped by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put

SnowLeopard build guards around the shim install path.

5:21 PM Changeset in webkit [86723] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-05-17 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Simon Fraser.

Remove empty directory.

  • fast/inspector: Removed.
5:12 PM Changeset in webkit [86722] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-17 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
​https://bugs.webkit.org/show_bug.cgi?id=60995

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: (WebCore::AudioNode::ref):
5:08 PM Changeset in webkit [86721] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-17 Tao Bai <​michaelbai@chromium.org>

Reviewed by Darin Fisher.

Clear deprecated icon APIs from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=60989

  • public/WebFrame.h: Removed faviconURL()
  • public/WebFrameClient.h: Removed didChangeIcons()
  • src/FrameLoaderClientImpl.cpp:

Removed the code to support deprecated API

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

  • src/WebFrameImpl.cpp: Removed faviconURL()
  • src/WebFrameImpl.h: Removed faviconURL()
4:42 PM Changeset in webkit [86720] by beidson@apple.com
  • 9 edits in trunk/Source/WebCore

2011-05-17 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/9366728> and ​https://webkit.org/b/60796
Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]

Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
This change has the following benefits:

  • Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect themselves, check these variables as often, or ASSERT them.
  • ResourceLoader subclasses no longer have to call the base class ::didCancel
  • ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the cancellation is completed inside the last call.

No new tests - No change in behavior for previous tests, and new test would require API usage outside
the scope of DumpRenderTree.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
  • loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().

Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willCancel): (WebCore::MainResourceLoader::didCancel):
  • loader/MainResourceLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel() (WebCore::NetscapePlugInStreamLoader::willCancel): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/NetscapePlugInStreamLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willCancel): (WebCore::SubresourceLoader::didCancel):
  • loader/SubresourceLoader.h:
4:39 PM Changeset in webkit [86719] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86668.
​http://trac.webkit.org/changeset/86668
​https://bugs.webkit.org/show_bug.cgi?id=61001

It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
#webkit).

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
4:21 PM Changeset in webkit [86718] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix after r86717.

  • UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget
4:15 PM Changeset in webkit [86717] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2: Needs API to set a custom drop target
​https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/9090868>

Reviewed by Adam Roben.

Add API to set a custom drop target on a WKView.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the

custom one.

  • UIProcess/win/WebView.h:
4:10 PM Changeset in webkit [86716] by rniwa@webkit.org
  • 3 edits
    2 adds
    19 deletes in trunk/LayoutTests

2011-05-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=60998

Converted the tests.

  • editing/pasteboard/paste-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-2.html:
  • editing/pasteboard/paste-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-3.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
4:03 PM Changeset in webkit [86715] by rniwa@webkit.org
  • 3 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-text-012.html should be a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=60996

Converted the test.

  • editing/pasteboard/paste-text-012-expected.txt: Added.
  • editing/pasteboard/paste-text-012.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.
3:49 PM Changeset in webkit [86714] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-17 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Add API to determine if a frame has any form elements without going to javascript
​https://bugs.webkit.org/show_bug.cgi?id=60999

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameContainsAnyFormElements):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::containsAnyFormElements):
  • WebProcess/WebPage/WebFrame.h: Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine if there are any form elements.
3:34 PM Changeset in webkit [86713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Always set layerRenderer, even on non-drawn-layers
​https://bugs.webkit.org/show_bug.cgi?id=60977

This is a defensive fixe for crbug.com/82799, in which
a RenderLayer could not prepare itself because its owning layerImpl
had no associated layerRenderer. The underlying issue is that we
sometimes put renderSurfaces onto the list that won't actually render.
For now, the priority is to reduce fragility so that invisible layers
dont lead to crashers. We do this by being more agressive about
binding CCLayerImpls to the LayerRenderer, doing it all the time rather
than only when we think it will get rendered.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents):
3:32 PM Changeset in webkit [86712] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-17 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

JSGlobalContextRelease should not trigger a synchronous garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=60990

  • API/JSContextRef.cpp: Change synchronous call to collectAllGarbage to a call to trigger the activityCallback.
3:31 PM Changeset in webkit [86711] by cdn@chromium.org
  • 1 edit in branches/chromium/742/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 86219 - 2011-05-10 Kent Tamura <​tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
​https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().

BUG=82154
Review URL: ​http://codereview.chromium.org/7039019

3:07 PM Changeset in webkit [86710] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Clipboard policy callbacks from EditorClientImpl are reversed
​https://bugs.webkit.org/show_bug.cgi?id=60994

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
3:00 PM Changeset in webkit [86709] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-17 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

Skip on qt-mac

​http://bugs.webkit.org/show_bug.cgi?id=60838

  • platform/qt-mac/Skipped:
2:45 PM Changeset in webkit [86708] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the clang build.

  • rendering/RenderText.h:

(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.

2:33 PM Changeset in webkit [86707] by arv@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-17 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
​https://bugs.webkit.org/show_bug.cgi?id=49509

This tests that an iframe is the activeElement when focus is inside that frame.

  • fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
  • fast/dom/HTMLDocument/active-element-frames.html: Added.

2011-05-17 Erik Arvidsson <​arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
​https://bugs.webkit.org/show_bug.cgi?id=49509

This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.

Test: fast/dom/HTMLDocument/active-element-frames.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.
1:57 PM Changeset in webkit [86706] by robert@webkit.org
  • 11 edits in trunk

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

​https://bugs.webkit.org/show_bug.cgi?id=54051

  • platform/qt/Skipped: Unskip plugins/invalidate_rect.html
  • platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

Add ChromeClientQt::allowsAcceleratedCompositing().

​https://bugs.webkit.org/show_bug.cgi?id=54051

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
  • WebCoreSupport/ChromeClientQt.h:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

  • Make the unix test netscape plugin recognize the onPaintEvent and windowedPlugin parameters.

​https://bugs.webkit.org/show_bug.cgi?id=54051

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::displayInvalidatedRegion):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event):
1:57 PM Changeset in webkit [86705] by eae@chromium.org
  • 48 edits in trunk/Source/WebCore

2011-05-17 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Change nodeAtPoint to take IntPoint instead of int x, int y
​https://bugs.webkit.org/show_bug.cgi?id=60663

Change nodeAtPoint to take a single const IntPoint& instead of a pair of
ints for the location.

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::flooredIntPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): (WebCore::RenderObject::nodeAtPoint):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
1:39 PM Changeset in webkit [86704] by atwilson@chromium.org
  • 14 edits in trunk/Source

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86647.
​http://trac.webkit.org/changeset/86647
​https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86647.
​http://trac.webkit.org/changeset/86647
​https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
1:38 PM Changeset in webkit [86703] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86656.
​http://trac.webkit.org/changeset/86656

Broke tests downstream in Chromium

  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
1:30 PM Changeset in webkit [86702] by tony@chromium.org
  • 2 edits
    25 adds in trunk/LayoutTests

2011-05-17 Tony Chang <​tony@chromium.org>

Land linux 32 bit results.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:26 PM Changeset in webkit [86701] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
1:20 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
1:04 PM Changeset in webkit [86700] by commit-queue@webkit.org
  • 15 edits in trunk

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

  • fast/events/touch/document-create-touch-expected.txt:
  • fast/events/touch/script-tests/document-create-touch.js:

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

  • dom/Document.cpp: (WebCore::Document::createTouch):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Touch.cpp: (WebCore::Touch::Touch):
  • dom/Touch.h: (WebCore::Touch::create): (WebCore::Touch::webkitRadiusX): (WebCore::Touch::webkitRadiusY): (WebCore::Touch::webkitRotationAngle):
  • dom/Touch.idl:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::radiusX): (WebCore::PlatformTouchPoint::radiusY): (WebCore::PlatformTouchPoint::rotationAngle):

2011-05-17 Yufeng Shen <​miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
​https://bugs.webkit.org/show_bug.cgi?id=59030

  • public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
  • src/WebInputEventConversion.cpp: (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
1:02 PM Changeset in webkit [86699] by oliver@apple.com
  • 21 edits
    2 adds in trunk/Source

2011-05-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Reduce code size for inline cache
​https://bugs.webkit.org/show_bug.cgi?id=60942

This patch introduces the concept of a "compact" address that
allows individual architectures to control the maximum offset
used for the inline path of get_by_id. This reduces the code
size of get_by_id by 3 bytes on x86 and x86_64 and slightly
improves performance on v8 tests.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::repatchCompact):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::repatchCompact):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::AbstractMacroAssembler::repatchCompact):
  • assembler/CodeLocation.h: (JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact): (JSC::CodeLocationCommon::dataLabelCompactAtOffset):
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::locationOf):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::repatchCompact):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::repatchCompact):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::repatch):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::repatchCompact):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_mr_disp8): (JSC::X86Assembler::movq_mr_disp8): (JSC::X86Assembler::repatchCompact): (JSC::X86Assembler::setInt8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID):
12:45 PM Changeset in webkit [86698] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add a LineLayoutState object to hold global state during line layout
​https://bugs.webkit.org/show_bug.cgi?id=60113

Like LayoutState for layout(), LineLayoutState keeps track of global information
during an entire linebox tree layout pass (aka layoutInlineChildren).

For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
It's possible we should hold the useRepaintBounds bool as well as
the startLine and endLine RootInlineBox pointers.

No change in behavior, thus no tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineLayoutState::LineLayoutState): (WebCore::LineLayoutState::markForFullLayout): (WebCore::LineLayoutState::isFullLayout): (WebCore::LineLayoutState::setRepaintRange): (WebCore::LineLayoutState::updateRepaintRangeFromBox): (WebCore::LineLayoutState::startLine): (WebCore::LineLayoutState::endLine): (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkFloatsInCleanLine): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine):
12:35 PM Changeset in webkit [86697] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-17 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
​https://bugs.webkit.org/show_bug.cgi?id=60978

Backslash to escape newlines was confusing both prepare-ChangeLog and the
QtCreator highlight system.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::evalJSV): Remove usage of backslash to escape newlines in string literal.
12:29 PM Changeset in webkit [86696] by tony@chromium.org
  • 10 edits in trunk/Tools

2011-05-17 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=60895

Update the tools to handle the move. Lucid 32 results now go in
chromium-linux-x86 and the default platform on Linux is now x86_64.

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
  • Scripts/webkitpy/layout_tests/port/base.py: ditto
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
12:26 PM Changeset in webkit [86695] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
​https://bugs.webkit.org/show_bug.cgi?id=54636

  • fast/images/imagemap-dynamic-area-updates-expected.txt: Added.
  • fast/images/imagemap-dynamic-area-updates.html: Added.
  • fast/images/script-tests/imagemap-dynamic-area-updates.js: Added. (setArea): (checkForArea):

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
​https://bugs.webkit.org/show_bug.cgi?id=54636

Recompute the clickable region after the "shape" or "coords" attribute
of an area element is changed.

Test: fast/images/imagemap-dynamic-area-updates.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): (WebCore::HTMLAreaElement::invalidateCachedRegion):
  • html/HTMLAreaElement.h:
12:00 PM Changeset in webkit [86694] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebKit2

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Initial support for favicons.
​https://bugs.webkit.org/show_bug.cgi?id=58937

Add the following API to QWKContext:

  • void setIconDatabasePath(QString)
  • void iconChangedForPageURL(QUrl) [signal]
  • QIcon iconForPageURL(QUrl)

This is mostly analogous to the QWebSettings/QWebFrame icon API we had in WebKit1.

  • UIProcess/API/qt/ClientImpl.h: Added WKIconDatabaseClient methods.
  • UIProcess/API/qt/ClientImpl.cpp: (toQWKContext): Helper to cast from "void* clientInfo" to a QWKContext*. (qt_wk_didChangeIconForPageURL): Emits QWKContext::iconChangedForPageURL(QUrl). (qt_wk_didRemoveAllIcons): Stub.
  • UIProcess/API/qt/qwkcontext.h:
  • UIProcess/API/qt/qwkcontext_p.h:
  • UIProcess/API/qt/qwkcontext.cpp: (QWKContextPrivate::QWKContextPrivate): Set up and register a WKIconDatabaseClient. (QWKContext::QWKContext): Minor refactor to avoid code duplication in constructors. (QWKContext::setIconDatabasePath): Exactly what it sounds like. (QWKContext::iconForPageURL): Retrieves the favicon for a given page URL as a QIcon.
  • WebKit2API.pri: Add WKIconDatabase.cpp and WKIconDatabase.h to build.
12:00 PM Changeset in webkit [86693] by luiz@webkit.org
  • 3 edits
    10 adds in trunk

[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
​https://bugs.webkit.org/show_bug.cgi?id=60440

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.

Tests: http/tests/navigation/post-301-response.html

http/tests/navigation/post-302-response.html
http/tests/navigation/post-303-response.html
http/tests/navigation/post-307-response.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendNetworkRequest):

LayoutTests:

These new tests check that no POST content is sent to the new URL after receiving http
status codes 301, 302 and 303, and checks that the POST content is sent to the new URL
after receiving a 307 http status code.

  • http/tests/navigation/post-301-response-expected.txt: Added.
  • http/tests/navigation/post-301-response.html: Added.
  • http/tests/navigation/post-302-response-expected.txt: Added.
  • http/tests/navigation/post-302-response.html: Added.
  • http/tests/navigation/post-303-response-expected.txt: Added.
  • http/tests/navigation/post-303-response.html: Added.
  • http/tests/navigation/post-307-response-expected.txt: Added.
  • http/tests/navigation/post-307-response.html: Added.
  • http/tests/navigation/resources/redirected-post-request-contents.php: Added.
  • http/tests/navigation/resources/redirection-response.php: Added.
11:57 AM Changeset in webkit [86692] by beidson@apple.com
  • 8 edits
    1 add in trunk/Source/WebKit2

Part 4 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

This patch actually hooks up the shim to the WebProcess shim callbacks, which messages these
4 calls up to the UIProcess and returns the result.

Note that this patch uncovered the fact that CoreIPC can't sync message out from a secondary thread,
so I filed ​https://bugs.webkit.org/show_bug.cgi?id=60975 as a followup to allow that.

  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::SecItemResponseData): Reorder the constructor arguments to be

a little cleaner.

  • Shared/mac/SecItemResponseData.h:

Call the shim callbacks for each method:

  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):

Implement the shim callbacks, which each marshall to the main thread, which then calls out to CoreIPC:

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatchingMainThread):
(WebKit::WebSecItemCopyMatching):
(WebKit::WebSecItemAddOnMainThread):
(WebKit::WebSecItemAdd):
(WebKit::WebSecItemUpdateOnMainThread):
(WebKit::WebSecItemUpdate):
(WebKit::WebSecItemDeleteOnMainThread):
(WebKit::WebSecItemDelete):

Add the 4 messages and their implementations in the UIProcess:

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebProcessProxyMac.mm: Added.

(WebKit::WebProcessProxy::secItemCopyMatching):
(WebKit::WebProcessProxy::secItemAdd):
(WebKit::WebProcessProxy::secItemUpdate):
(WebKit::WebProcessProxy::secItemDelete):

  • WebKit2.xcodeproj/project.pbxproj:
11:37 AM Changeset in webkit [86691] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] GraphicsLayerQtImpl: Remove an unused variable.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::paint):
11:16 AM Changeset in webkit [86690] by kerz@chromium.org
  • 9 edits in branches/chromium/742/Source

Merge 86290 - 2011-05-11 Antoine Labour <​piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
​https://bugs.webkit.org/show_bug.cgi?id=60656

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
  • loader/ResourceLoadScheduler.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <​piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
​https://bugs.webkit.org/show_bug.cgi?id=60656

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7019016

11:08 AM Changeset in webkit [86689] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Incomplete page painting at dropbox.com
​https://bugs.webkit.org/show_bug.cgi?id=60974
<rdar://problem/9448213>

When we're exiting compositing mode and haven't sent an EnterAcceleratedCompositingMode
message to the UI process, we still need to send the updated bits to the ui process.


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
11:06 AM Changeset in webkit [86688] by beidson@apple.com
  • 4 edits
    4 adds in trunk/Source/WebKit2

Part 3 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add CoreIPC stuff we'll need to marshall the SecItem calls to the UIProcess and back.

Teach ArgumentCodersCF about CFDateRef, SecKeychainItemRef, and generic CFTypeRefs:

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):

  • Shared/cf/ArgumentCodersCF.h:

Serializable object that contains the query CFDictionaryRef and optionally the
"attributesToMatch" CFDictionaryRef:

  • Shared/mac/SecItemRequestData.cpp: Added.

(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h: Added.

(WebKit::SecItemRequestData::query):
(WebKit::SecItemRequestData::attributesToMatch):

Serializable object that returns an OSStatus and optionally a "result object" CFTypeRef:

  • Shared/mac/SecItemResponseData.cpp: Added.

(WebKit::SecItemResponseData::SecItemResponseData):
(WebKit::SecItemResponseData::encode):
(WebKit::SecItemResponseData::decode):

  • Shared/mac/SecItemResponseData.h: Added.

(WebKit::SecItemResponseData::resultObject):
(WebKit::SecItemResponseData::resultCode):

  • WebKit2.xcodeproj/project.pbxproj:
10:49 AM Changeset in webkit [86687] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/TextViewer.js

Merge 86683 - 2011-05-17 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
​https://bugs.webkit.org/show_bug.cgi?id=60970

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7037012

10:39 AM Changeset in webkit [86686] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

Part 2 of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Hookup some of the methods we plan to shim in the patch, but just have them call through
to the actual implementations for now.

Also stub-out the future shimmed versions of the methods.

  • WebProcess/mac/WebProcessShim.h: Add the methods to the shim callbacks.
  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching): Call through to the actual function for now.
(WebKit::shimSecItemAdd): Ditto.
(WebKit::shimSecItemUpdate): Ditto.
(WebKit::shimSecItemDelete): Ditto.
(WebKit::WebKitWebProcessShimInitialize): Copy over the shim callbacks.

  • WebKit2.xcodeproj/project.pbxproj: Link the shim to required frameworks.


  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatching): Add placeholders for the future to-be-shimmed functions.
(WebKit::WebSecItemAdd): Ditto.
(WebKit::WebSecItemUpdate): Ditto.
(WebKit::WebSecItemDelete): Ditto.
(WebKit::WebProcess::initializeShim): Pass along those placeholders to the shim initializer.

10:38 AM Changeset in webkit [86685] by kerz@chromium.org
  • 5 edits
    2 deletes in branches/chromium/742

Revert 84311 - REGRESSION(r55762): Highlight color can't be copied in gmail.
​https://bugs.webkit.org/show_bug.cgi?id=58925
<rdar://problem/9253057>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/pasteboard/copy-text-with-backgroundcolor.html

The changes of r55762 uncovered the underlying issue here. The markup fragment
placed in the pasteboard does not contain the background color style.
This occurs only if the selection is limited to a single text node, whereas if the
selection spans across multiple nodes, the style is preserved correctly.
The fix consists in changing the logic that decides whether we should include the wrapping
node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
on isElementPresentational to choose candidates to be the wrapping node.
I've extended it to accept nodes that have non fully transparent background colors.

  • editing/Editor.cpp:

(WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.

  • editing/Editor.h:
  • editing/markup.cpp:

(WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.

LayoutTests:

The following test checks that when we copy a text node surrounded by an element that
has non transparent background color we preserve the background color as well.

  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Added.
  • editing/pasteboard/copy-text-with-backgroundcolor.html: Added.

TBR=​enrica@apple.com
Review URL: ​http://codereview.chromium.org/7031026

10:36 AM Changeset in webkit [86684] by kerz@chromium.org
  • 3 edits
    2 deletes in branches/chromium/742

Revert 85494 - MERGE 85090 - 2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

​http://crbug.com/80498

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/6975019

10:27 AM Changeset in webkit [86683] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
​https://bugs.webkit.org/show_bug.cgi?id=60970

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
10:25 AM Changeset in webkit [86682] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-17 Sakamuri Ramakrishna <​ramakrishna.sakamuri@nokia.com>

Reviewed by Andreas Kling.

[Qt] 4 of the skipped storage layout tests pass on Qt Linux- skip list to be modified
​https://bugs.webkit.org/show_bug.cgi?id=60715

  • platform/qt/Skipped:
10:23 AM Changeset in webkit [86681] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-17 Anton Muhin <​antonm@chromium.org>

Unreviewed.

Improving test expectations.

  • platform/chromium/test_expectations.txt:
10:16 AM Changeset in webkit [86680] by andreas.kling@nokia.com
  • 3 edits
    4 adds in trunk

2011-05-17 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
​https://bugs.webkit.org/show_bug.cgi?id=40841

Test: compositing/animation/busy-indicator.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::TransformAnimationQt::getAnimatedProperty): (WebCore::OpacityAnimationQt::getAnimatedProperty): (WebCore::GraphicsLayerQt::addAnimation):

2011-05-17 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
​https://bugs.webkit.org/show_bug.cgi?id=40841

  • compositing/animation/busy-indicator-no.png: Added.
  • compositing/animation/busy-indicator.html: Added.
  • compositing/animation/busy-indicator.png: Added.
  • compositing/animation/busy-indicator-expected.txt: Added.
10:13 AM Changeset in webkit [86679] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Grace Kloba <​klobag@chromium.org>

Reviewed by Kenneth Russell.

GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
​https://bugs.webkit.org/show_bug.cgi?id=60965

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
10:12 AM Changeset in webkit [86678] by beidson@apple.com
  • 6 edits
    1 move
    2 adds in trunk/Source/WebKit2

Part one of <rdar://problem/8814289> and ​https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add am empty shim for a new WebProcess shim and install it at launch.

Use the same Shim.xcconfig for both the web and plugin processes:

  • Configurations/PluginProcessShim.xcconfig: Removed.
  • Configurations/Shim.xcconfig: Copied from Configurations/PluginProcessShim.xcconfig.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.h: Add initializeShim() for Mac-only
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim): Initialize the (empty) shim callbacks.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Call initializeShim()

  • WebProcess/mac/WebProcessShim.h: Added.
  • WebProcess/mac/WebProcessShim.mm: Added.

(WebKit::WebKitWebProcessShimInitialize): Empty for now.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Install the Plugin Process shim for plugin processes

and the WebProcess shim for the web content process.

10:05 AM Changeset in webkit [86677] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Andreas Kling <​kling@webkit.org>

Bot-matching rebaseline after r86675.

  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
9:57 AM Changeset in webkit [86676] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

Loose end from fix for ​https://bugs.webkit.org/show_bug.cgi?id=60938

Reviewed by Adam Roben.

  • WebKit2.xcodeproj/project.pbxproj:

Made new header file "private" instead of "project" so clients can access it.

9:34 AM Changeset in webkit [86675] by commit-queue@webkit.org
  • 18 edits in trunk/LayoutTests

2011-05-17 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] rebaseline skipped tests after r83871
​https://bugs.webkit.org/show_bug.cgi?id=60961

Rebaseline tests after r83871 and remove them from Qt Skipped file.

  • platform/qt/Skipped:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/qt/http/tests/misc/error404-expected.txt:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
  • platform/qt/http/tests/misc/iframe404-expected.txt:
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/qt/http/tests/uri/css-href-expected.txt:
  • platform/qt/tables/layering/paint-test-layering-1-expected.txt:
  • platform/qt/tables/layering/paint-test-layering-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/qt/tables/mozilla/other/slashlogo-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
  • platform/qt/transitions/svg-text-shadow-transition-expected.txt:
9:24 AM Changeset in webkit [86674] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
​https://bugs.webkit.org/show_bug.cgi?id=60962

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
9:03 AM Changeset in webkit [86673] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference.
​https://bugs.webkit.org/show_bug.cgi?id=42197

Add fast/images/animated-gif-restored-from-bfcache.html to the mac-wk2 Skipped list to get
the bots green.

  • platform/mac-wk2/Skipped:
7:39 AM Changeset in webkit [86672] by podivilov@chromium.org
  • 27 edits in trunk

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
​http://trac.webkit.org/changeset/86660
​https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
​http://trac.webkit.org/changeset/86660
​https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
6:29 AM Changeset in webkit [86671] by Adam Roben
  • 2 edits in trunk/Tools

Make run-api-tests work on Windows when there are spaces in the path

Fixes <​http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe

Reviewed by David Levin.

  • Scripts/run-api-tests:

(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.

6:06 AM Changeset in webkit [86670] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-17 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed warning fix introduced by r86377.

  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
4:51 AM Changeset in webkit [86669] by yutak@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

2011-05-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
​https://bugs.webkit.org/show_bug.cgi?id=60945

Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
move these definitions into .cpp in order to allow further modifications in this class.

No new tests, as this is just refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::create): (WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::sent): (WebCore::ThreadableWebSocketChannelClientWrapper::setSent): (WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::clearClient): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
4:39 AM Changeset in webkit [86668] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
​https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
4:36 AM Changeset in webkit [86667] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support shadowed text in fast font path.
​https://bugs.webkit.org/show_bug.cgi?id=60462

  • platform/graphics/Font.cpp: (WebCore::Font::drawText): Remove complex path shortcut for shadowed text.
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawGlyphs): Paint shadows for simple text.
4:34 AM Changeset in webkit [86666] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Construct GraphicsLayerQtImpl::State with correct values.
​https://bugs.webkit.org/show_bug.cgi?id=60902

The GraphicsLayerQtImpl initial state should match the initial values
of the corresponding GraphicsLayer flags.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::State::State):
3:12 AM Changeset in webkit [86665] by hans@chromium.org
  • 5 edits in trunk

2011-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
​https://bugs.webkit.org/show_bug.cgi?id=60697

Test that we can create a new index for which not all current records
have a key.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:

2011-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
​https://bugs.webkit.org/show_bug.cgi?id=60697

When populating a new index, records which do not have a key on the
index's key path should be ignored.

  • storage/IDBObjectStoreBackendImpl.cpp:
2:46 AM Changeset in webkit [86664] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-05-17 Young Han Lee <​joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
​https://bugs.webkit.org/show_bug.cgi?id=60947

No new tests. Build fix.

  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapper::create):
  • platform/graphics/qt/TextureMapperQt.h: (WebCore::TextureMapperQt::create):
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):

2011-05-17 Young Han Lee <​joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
​https://bugs.webkit.org/show_bug.cgi?id=60947

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQWidget::setRootGraphicsLayer):
2:34 AM Changeset in webkit [86663] by apavlov@chromium.org
  • 6 edits in trunk

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
​https://bugs.webkit.org/show_bug.cgi?id=60890

  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:

2011-05-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
​https://bugs.webkit.org/show_bug.cgi?id=60890

  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.alteredFloatNumber): (WebInspector.StylePropertyTreeElement.prototype):
2:31 AM Changeset in webkit [86662] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests are flaky on Linux.
fast/speech/input-appearance-numberandspeech.html
fast/speech/input-appearance-searchandspeech.html
fast/speech/input-appearance-speechbutton.html

  • platform/chromium/test_expectations.txt:
2:11 AM Changeset in webkit [86661] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-17 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/js/mozilla/strict/eval-variable-environment.html now passes.

  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [86660] by podivilov@chromium.org
  • 27 edits in trunk

2011-05-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
12:37 AM Changeset in webkit [86659] by yutak@chromium.org
  • 4 edits in trunk

2011-05-16 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
​https://bugs.webkit.org/show_bug.cgi?id=60880

  • http/tests/websocket/tests/handshake-error-expected.txt: Remove a carriage return in the first line.

2011-05-16 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
​https://bugs.webkit.org/show_bug.cgi?id=60880

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine): WebSocketHandshake should not print a carriage return to console. To fix this, we first check whether the status line ends with CRLF. After that, we can print the first (lineLength - 2) characters of the status line which do not contain a carriage return.

May 16, 2011:

11:59 PM Changeset in webkit [86658] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

http/tests/appcache/interrupted-update.html is flaky on win, mac, and linux.

  • platform/chromium/test_expectations.txt:
11:12 PM Changeset in webkit [86657] by commit-queue@webkit.org
  • 37 edits in trunk/Source/JavaScriptCore

2011-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86653.
​http://trac.webkit.org/changeset/86653
​https://bugs.webkit.org/show_bug.cgi?id=60944

"Caused regressions on Windows, OSX and EFL" (Requested by
yutak on #webkit).

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • create_hash_table:
  • heap/Heap.cpp: (JSC::TypeCounter::operator()):
  • interpreter/CallFrame.h: (JSC::ExecState::arrayTable): (JSC::ExecState::numberTable):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncJSCPrint):
  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot):
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
10:55 PM Changeset in webkit [86656] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 MORITA Hajime <​morrita@google.com>

Unreviewed build fix for r86647, which broke SUPPORT_AUTOCORRECTION_PANEL.

  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
10:11 PM Changeset in webkit [86655] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/hixie/perf/00{1,2}.xml now pass on Linux.

  • platform/chromium/test_expectations.txt:
9:26 PM Changeset in webkit [86654] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Kent Tamura <​tkent@chromium.org>

Fix Leopard build.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Use double instead of int.
9:08 PM Changeset in webkit [86653] by ggaren@apple.com
  • 37 edits in trunk/Source/JavaScriptCore

2011-05-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Geoffrey Garen.

Global object initialization is expensive
​https://bugs.webkit.org/show_bug.cgi?id=60933


Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.


This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

  • create_hash_table: Added a special case for fromCharCode, since it uses a custom "thunk generator".
  • heap/Heap.cpp: (JSC::TypeCounter::operator()): Fixed a bug where the type counter would overcount objects that were owned through more than one mechanism because it was getting in the way of counting the results for this patch.
  • interpreter/CallFrame.h: (JSC::ExecState::arrayConstructorTable): (JSC::ExecState::arrayPrototypeTable): (JSC::ExecState::booleanPrototypeTable): (JSC::ExecState::dateConstructorTable): (JSC::ExecState::errorPrototypeTable): (JSC::ExecState::globalObjectTable): (JSC::ExecState::numberConstructorTable): (JSC::ExecState::numberPrototypeTable): (JSC::ExecState::objectPrototypeTable): (JSC::ExecState::regExpPrototypeTable): (JSC::ExecState::stringConstructorTable): Added new tables.
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::ArrayConstructor::getOwnPropertySlot): (JSC::ArrayConstructor::getOwnPropertyDescriptor):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::createStructure):
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype): (JSC::BooleanPrototype::getOwnPropertySlot): (JSC::BooleanPrototype::getOwnPropertyDescriptor):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::createStructure):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): (JSC::DateConstructor::getOwnPropertySlot): (JSC::DateConstructor::getOwnPropertyDescriptor):
  • runtime/DateConstructor.h: (JSC::DateConstructor::createStructure):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype): (JSC::ErrorPrototype::getOwnPropertySlot): (JSC::ErrorPrototype::getOwnPropertyDescriptor):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::createStructure): Standardized these objects to use static tables for function properties.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h: Added new tables.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a static table for its global functions. This required uninlining some things to avoid a circular header dependency. However, those things probably shouldn't have been inlined in the first place.


Even more global object properties can be made lazy, but that requires
more in-depth changes.

  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype): (JSC::NumberPrototype::getOwnPropertySlot): (JSC::NumberPrototype::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::createStructure):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot): (JSC::ObjectPrototype::getOwnPropertyDescriptor):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::createStructure):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::RegExpPrototype::getOwnPropertySlot): (JSC::RegExpPrototype::getOwnPropertyDescriptor):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::createStructure):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): (JSC::StringConstructor::getOwnPropertySlot): (JSC::StringConstructor::getOwnPropertyDescriptor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::createStructure): Standardized these objects to use static tables for function properties.
7:51 PM Changeset in webkit [86652] by jamesr@google.com
  • 20 edits
    1 copy
    2 adds in trunk/Source

2011-05-16 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Decouple LayerChromium/CCLayerImpl trees
​https://bugs.webkit.org/show_bug.cgi?id=58830

Makes the CCLayerImpl tree self-hosting and provides an explicit step
to synchronize the LayerChromium tree to the CCLayerImpl tree.
Tested by compositing/ layout tests and by unit tests in WebKit/chromium.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::dumpLayerProperties): (WebCore::LayerChromium::createCCLayerImpl): (WebCore::LayerChromium::ccLayerImpl):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::id): (WebCore::LayerChromium::setCCLayerImpl):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/TreeSynchronizer.cpp: Added. (WebCore::TreeSynchronizer::addCCLayerImplsToMapRecursive): (WebCore::TreeSynchronizer::synchronizeTreeRecursive): (WebCore::TreeSynchronizer::synchronizeTrees):
  • platform/graphics/chromium/TreeSynchronizer.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::addChild): (WebCore::CCLayerImpl::removeFromParent): (WebCore::CCLayerImpl::removeAllChildren): (WebCore::CCLayerImpl::clearChildList): (WebCore::CCLayerImpl::descendantsDrawsContent): (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::updateCompositorResources):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::create): (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::children): (WebCore::CCLayerImpl::setMaskLayer): (WebCore::CCLayerImpl::maskLayer): (WebCore::CCLayerImpl::setReplicaLayer): (WebCore::CCLayerImpl::replicaLayer): (WebCore::CCLayerImpl::id): (WebCore::CCLayerImpl::owner): (WebCore::CCLayerImpl::setParent):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h: (WebCore::CCPluginLayerImpl::create):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h: (WebCore::CCVideoLayerImpl::create):

2011-05-16 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.
​https://bugs.webkit.org/show_bug.cgi?id=58830

Add unit tests for the compositor's TreeSynchronizer.

  • WebKit.gypi:
  • tests/TreeSynchronizerTest.cpp: Added. (WebCore::MockCCLayerImpl::create): (WebCore::MockCCLayerImpl::~MockCCLayerImpl): (WebCore::MockCCLayerImpl::setCCLayerDestructionList): (WebCore::MockCCLayerImpl::MockCCLayerImpl): (WebCore::MockLayerChromium::create): (WebCore::MockLayerChromium::~MockLayerChromium): (WebCore::MockLayerChromium::createCCLayerImpl): (WebCore::MockLayerChromium::pushPropertiesTo): (WebCore::MockLayerChromium::MockLayerChromium): (WebCore::expectTreesAreIdentical): (WebCore::TEST):
7:49 PM Changeset in webkit [86651] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86648.
​http://trac.webkit.org/changeset/86648
​https://bugs.webkit.org/show_bug.cgi?id=60941

media/controls-css-overload.html still failing on non-GPU
tests (Requested by scherkus on #webkit).

  • platform/chromium/test_expectations.txt:
7:34 PM Changeset in webkit [86650] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
​https://bugs.webkit.org/show_bug.cgi?id=60871

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added expected results.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added test patterns when initial values are empty.

2011-05-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
​https://bugs.webkit.org/show_bug.cgi?id=60871

Test: fast/forms/input-stepup-stepdown-from-renderer.html

In number input type, if the value is not a number, including empty, the currect valued is assumed 0.
But we have to handle it separately from the case when the value is actuall "0".

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Added cliping for default value.
6:42 PM Changeset in webkit [86649] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

This test case triggers the ASSERT.

  • fast/parser/append-child-followed-by-document-write-expected.txt: Added.
  • fast/parser/append-child-followed-by-document-write.html: Added.

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
​https://bugs.webkit.org/show_bug.cgi?id=60935

The ASSERT is invalid when the parser is in the initial state and the
document is non-empty, which is strange but not impossible.

Test: fast/parser/append-child-followed-by-document-write.html

  • dom/Document.cpp: (WebCore::Document::setCompatibilityMode):
6:14 PM Changeset in webkit [86648] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, updating expectation for media/controls-css-overload.html.

  • platform/chromium/test_expectations.txt:
6:11 PM Changeset in webkit [86647] by morrita@google.com
  • 14 edits in trunk/Source

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

  • Moved DocumentMarker's member variables to private and added getters for them.
  • Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
  • Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController because it accesses DocumentMarker internals.
  • Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-16 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
6:01 PM Changeset in webkit [86646] by Martin Robinson
  • 4 edits in trunk/Source

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Fix the Cairo build for older versions of GTK+.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Include GtkVersioning.h to satisfy older versions of GTK+ 2.x.

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Take another shot at fixing the WinCairo build.

  • Shared/cairo/LayerTreeContextCairo.cpp: Include NotImplemented.h using a framework include.
5:53 PM Changeset in webkit [86645] by weinig@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by Jon Honeycutt.

Add access to process pid in WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=60938

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp: Added. (WKPageGetProcessIdentifier):
  • UIProcess/API/C/mac/WKPagePrivateMac.h: Added.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processIdentifier):
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Add WKPageGetProcessIdentifier as SPI for the mac.
5:50 PM Changeset in webkit [86644] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

  • loader/navigation-while-deferring-loads-expected.txt: Added.
  • loader/navigation-while-deferring-loads.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

If goToItem is called while loading is deferred, save the arguments
and try again later instead of doing nothing.

Test: loader/navigation-while-deferring-loads.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Pipe the "defersLoading" state into HistoryController.
  • loader/HistoryController.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::goToItem): Save the HistoryItem and FrameLoadType if loading is deferred. (WebCore::HistoryController::setDefersLoading): If we have a saved HistoryItem after resuming, try going to it.
  • loader/HistoryController.h:
  • page/Page.cpp: (WebCore::Page::goToItem): No longer bail early if loading is deferred, since HistoryController now handles this case.

2011-05-16 Ian Henderson <​ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
​https://bugs.webkit.org/show_bug.cgi?id=60412

Add setDefersLoading and goBack methods to LayoutTestController. We
need to use goBack() instead of history.back() because the latter goes
through NavigationScheduler, hence doesn't exhibit the bug.

  • DumpRenderTree/LayoutTestController.cpp: (goBackCallback): (setDefersLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
5:31 PM Changeset in webkit [86643] by scherkus@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, checking in new baselines for media/video-canvas-alpha.html for chromium-gpu-{linux,win}.

  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [86642] by Martin Robinson
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Add file missing from my previous commit.

  • Shared/cairo/LayerTreeContextCairo.cpp: Added.
5:22 PM Changeset in webkit [86641] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, un-skipping a few Chromium layout test expectations.

  • platform/chromium/test_expectations.txt:
5:21 PM Changeset in webkit [86640] by atwilson@chromium.org
  • 14 edits
    6 deletes in trunk/Source

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86625.
​http://trac.webkit.org/changeset/86625
​https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Removed.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
  • platform/graphics/chromium/LayerTextureSubImage.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setLayerRenderer): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86625.
​http://trac.webkit.org/changeset/86625
​https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • src/WebViewImpl.cpp:
4:50 PM Changeset in webkit [86639] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

No need to compile .js files, that is what the JIT is for.

  • WebKit.xcodeproj/project.pbxproj:
4:48 PM Changeset in webkit [86638] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, marking media/video-transformed.html as passing on all platforms.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [86637] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move
    3 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix baselines for xss-DENIED-set-opener.html. This is too hard.

  • platform/chromium-linux/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-win-vista/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
4:40 PM Changeset in webkit [86636] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix baselines for set-href-attribute-hash.html. This is too hard.

  • platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
  • platform/chromium-win-vista/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
4:39 PM Changeset in webkit [86635] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=60927
fastCheckSelector() does not inline correctly in all cases

Reviewed by Dave Kilzer.

Use anonymous namespace instead of static qualifier to get internal linkage.
Use functions as template arguments instead of classes.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

4:36 PM Changeset in webkit [86634] by Martin Robinson
  • 3 edits
    1 delete in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​martin.james.robinson@gmail.com>

Try to fix the WinCairo build after r86612.

Move the LayerTreeContextGtk.cpp stub to LayerTreeContextCairo.cpp and add
it to the WinCairo build.

  • GNUmakefile.am: Update the source list.
  • Shared/cairo/LayerTreeContextCairo.cpp: Renamed from Source/WebKit2/Shared/gtk/LayerTreeContextGtk.cpp.
  • win/WebKit2.vcproj: Update the source list.
4:36 PM Changeset in webkit [86633] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Just return "nullptr" to fix compile errors
​https://bugs.webkit.org/show_bug.cgi?id=60932

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
4:33 PM Changeset in webkit [86632] by eae@chromium.org
  • 10 edits in trunk/Source

2011-05-16 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
​https://bugs.webkit.org/show_bug.cgi?id=60743

Change RenderView::documentRect to compute rect once rather than four times.
Replace all uses of docTop/Right/Bottom/Left/Width/Height with documentRect to
simplify the code and reduce complexity.

Covered by existing tests.

  • WebCore.exp.in:
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::forceLayoutForPagination):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  • rendering/RenderView.cpp: (WebCore::RenderView::documentRect):
  • rendering/RenderView.h:

2011-05-16 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
​https://bugs.webkit.org/show_bug.cgi?id=60743

Replace uses of docWidth/Height with documentRect.

  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
4:32 PM Changeset in webkit [86631] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-16 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] shard V8DerivedSources into 19 files
​https://bugs.webkit.org/show_bug.cgi?id=60926

This reduces the clobber build time by 4s on my machine. It helps
by making the slowest to compile V8DerivedSources faster (and thus
more parallelizable). With 8 files, the 3 slowest are 23s, 18s and
10s. With 19 files, the 3 slowest are 16s, 10s, and 10s.

  • WebCore.gyp/WebCore.gyp:
  • storage/IDBObjectStore.h: Fix a missing include that was working because a different .cpp file before it was including the header.
4:13 PM Changeset in webkit [86630] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Fix web audio enabled mac port compile errors
​https://bugs.webkit.org/show_bug.cgi?id=60930

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
4:12 PM Changeset in webkit [86629] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations changes to disable crashing tests.

​https://bugs.webkit.org/show_bug.cgi?id=60931

  • platform/chromium/test_expectations.txt:
4:10 PM Changeset in webkit [86628] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
​https://bugs.webkit.org/show_bug.cgi?id=60925

I suspect this difference is really just papering over other bugs
but now that I finally understand the difference, I should at least
document it for others.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::determineStartPosition):
4:02 PM Changeset in webkit [86627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Scrolling in Twitter is broken after r86102
​https://bugs.webkit.org/show_bug.cgi?id=60922

Fix adjustment handling for pages that trigger the slow scrolling path.
The slow scrolling path is triggered by WebCore when it determines that
doing a simple invalidation is quicker than doing a normal scroll. This
typically happens when there are large elements with fixed positions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment watcher to update its adjustments when a page triggers the slow scrolling path.
4:02 PM Changeset in webkit [86626] by scherkus@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, rebaselining media/video-aspect-ratio.html for chromium-gpu-{linux,mac,win}.

  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:58 PM Changeset in webkit [86625] by alokp@chromium.org
  • 14 edits
    2 copies
    4 adds in trunk/Source

2011-05-16 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Added.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h: Added.
  • platform/graphics/chromium/LayerTextureUpdater.h: Added. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
​https://bugs.webkit.org/show_bug.cgi?id=60719

  • src/WebViewImpl.cpp:
3:57 PM Changeset in webkit [86624] by weinig@apple.com
  • 5 edits in trunk/Tools

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

TestWebKitAPI should build with clang if it can
​https://bugs.webkit.org/show_bug.cgi?id=60918

  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Update CompilerVersion.xcconfig to match others.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add CompilerVersion.xcconfig to the project.
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: (TestWebKitAPI::didSameDocumentNavigationForFrame): Add some casts to quiet warnings from clang.
3:56 PM Changeset in webkit [86623] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed prospective build fix/workaround for chromium ARM compiler error.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::animationNameForTransition):

3:53 PM Changeset in webkit [86622] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Layout test file-URL-with-port-number.html fails on Mac and Linux
​http://code.google.com/p/chromium/issues/detail?id=10342

The consensus is to not support this behavior unless there is a
compelling compatibility reason.

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [86621] by scherkus@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, rebaselining media/video-zoom.html for chromium-gpu-{linux,mac}.

  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
3:48 PM Changeset in webkit [86620] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
​https://bugs.webkit.org/show_bug.cgi?id=60912

No new tests. This will be covered by WebKit2 pixel tests.

  • GNUmakefile.list.am: Added new GtkWidgetBackingStore source and header files.
  • platform/gtk/GtkWidgetBackingStore.h: Added.
  • platform/gtk/GtkWidgetBackingStoreCairo.cpp: Added this implementation of the backing store that uses Cairo and has the same performance characteristics as the WebKit2 implementaiton.
  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Added this implementation of the backing store that uses X11 directly and has better performance than the Cairo version.

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
​https://bugs.webkit.org/show_bug.cgi?id=60912

Instead of allocating the backing store surface directly in WebKit2,
instantiate the GtkWidgetBackingStore class which abstracts away the
platform-specific details of maintaining the backing store.

  • UIProcess/BackingStore.h:
  • UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::paint): Call into GtkWidgetBackingStore to get the Cairo surface now. (WebKit::BackingStore::incorporateUpdate): Ditto. (WebKit::BackingStore::scroll): Call into GtkWidgetBackingStore to do the actual backing store scroll.
3:46 PM Changeset in webkit [86619] by rniwa@webkit.org
  • 3 edits
    2 moves
    2 adds
    17 deletes in trunk/LayoutTests

2011-05-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and converted to dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=60923

Renamed pasteboard/5075944-2.html to pasteboard/preserve-underline-color.html and pasteboard/5075944-3.html to
deleting/deleting-line-break-preserves-underline-color.html. Also converted them to dump-as-markup tests.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: Added.
  • editing/deleting/deleting-line-break-preserves-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-3.html.
  • editing/pasteboard/5075944-2.html: Removed.
  • editing/pasteboard/5075944-3.html: Removed.
  • editing/pasteboard/preserve-underline-color-expected.txt: Added.
  • editing/pasteboard/preserve-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-2.html.
  • platform/chromium-linux/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5075944-3-expected.txt: Removed.
3:45 PM Changeset in webkit [86618] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

Layout Test fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing
​http://code.google.com/p/chromium/issues/detail?id=72428

This test is passing, not failing.

  • platform/chromium/fast/dom/HTMLAnchorElement: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [86617] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-05-16 Adam Barth <​abarth@webkit.org>

cross-frame-access-call.html fails after WebKit r74449
​http://code.google.com/p/chromium/issues/detail?id=67767

These tests aren't really failing. They just have different results
because of interactions with the popup blocker.

  • platform/chromium/http/tests/security/aboutBlank: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
3:39 PM Changeset in webkit [86616] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-16 Dirk Pranke <​dpranke@chromium.org>

Reviewed by David Levin.

add dpranke as a reviewer
​https://bugs.webkit.org/show_bug.cgi?id=60919

  • Scripts/webkitpy/common/config/committers.py:
3:32 PM Changeset in webkit [86615] by cmarrin@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-16 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Plug-in hit testing is broken after zooming
​https://bugs.webkit.org/show_bug.cgi?id=60916

Construct a WebMouseEvent to send to plugin, adjusting values to take pageScaleFactor
into account. Also adjusted bounds sent to viewGeometryDidChange to take pageScaleFactor
into account. Both are needed or the plugin will think the mouse positions are outside
its bounds.

  • Shared/WebEvent.h:
  • Shared/WebMouseEvent.cpp:Add ctor to clone a WebMouseEvent and add a scaleFactor to values (WebKit::WebMouseEvent::WebMouseEvent):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::handleEvent):Adjust mouse coords to take pageScaleFactor into account (WebKit::PluginView::viewGeometryDidChange):Adjust bounds to take pageScaleFactor into account
3:25 PM Changeset in webkit [86614] by scherkus@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, removing baselines for media/media-document-audio-repaint.html as they're incorrect.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [86613] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Csaba Osztrogonác.

​https://bugs.webkit.org/show_bug.cgi?id=59930

Add plugins/object-embed-plugin-scripting.html to qt-mac Skipped list

Note that nearly all plugin tests are currently skipped by qt-mac,
so something may be missng from the buildbot.

  • platform/qt-mac/Skipped:
3:07 PM Changeset in webkit [86612] by Martin Robinson
  • 16 edits
    1 copy
    1 add in trunk/Source/WebKit2

2011-05-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Anders Carlsson.

GTK port of WebKit2 should switch to new DrawingAreaImpl model
​https://bugs.webkit.org/show_bug.cgi?id=59655

  • GNUmakefile.am: Add the files necessary to use the DrawingAreaProxyImpl to the source list. The source list also needs the LayerContextTree stubs.
  • Shared/LayerTreeContext.h: This file should not be guarded by USE(ACCELERATED_COMPOSITING) as it's needed for the DrawingAreaProxyImpl IPC messaging.
  • Shared/gtk/LayerTreeContextGtk.cpp: Added this stub.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createDrawingAreaProxy): Instead of creating the deprecated chunked drawing area, create a DrawingAreaProxyImpl. (WebKit::PageClientImpl::setViewNeedsDisplay): Here we must now queue a redraw. Previously the chunked drawing area was doing this manually. This is the appropriate place though. (WebKit::PageClientImpl::scrollView): Add an implementation that just calls into setViewNeedsDisplay.
  • UIProcess/API/gtk/PageClientImpl.h: Added a getter for m_viewWidget. (WebKit::PageClientImpl::viewWidget):
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): Added this helper which reduces code duplication between GTK+ 2.x and 3.x (webkitWebViewBaseExpose): Call the new helper now. (webkitWebViewBaseDraw): Ditto.
  • UIProcess/BackingStore.h: Updated to include GTK+ specific types.
  • UIProcess/DrawingAreaProxy.h: Ditto.
  • UIProcess/DrawingAreaProxy.messages.in: Do not the DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING).
  • UIProcess/WebPageProxy.cpp: Removed these guards, as DrawingAreProxyImpl is used on all platforms now. (WebKit::WebPageProxy::didReceiveMessage): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/gtk/BackingStoreGtk.cpp: Added. This implementation heavily uses Cairo, but depends on GTK+/GDK in a few places. (WebKit::BackingStore::paint): (WebKit::BackingStore::incorporateUpdate): (WebKit::BackingStore::scroll):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added a getting for the viewWidget, which is required by BackingStoreGtk. A similar getter exists for Windows and Mac. (WebKit::WebPageProxy::viewWidget): Ditto.
  • WebProcess/WebPage/DrawingArea.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::DrawingArea::create): Ditto.
  • WebProcess/WebPage/DrawingArea.h: Ditto.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Do not guard this DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING)
  • WebProcess/WebPage/WebPage.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::WebPage::didReceiveMessage): Ditto.
3:05 PM Changeset in webkit [86611] by robert@webkit.org
  • 5 edits in trunk

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

​https://bugs.webkit.org/show_bug.cgi?id=60838

The unix test plugin needs to call the test's NPP_URLNotify
rather than the browsers.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_url_notify):
2:46 PM WebKit Team edited by bfulgham@webkit.org
(diff)
2:44 PM Changeset in webkit [86610] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, correcting bug number for a test expectation.

  • platform/chromium/test_expectations.txt:
2:42 PM Changeset in webkit [86609] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:

Rubber-stamped by Adam Roben.

2:37 PM Changeset in webkit [86608] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Sandbox denies Kerberos authentication
​https://bugs.webkit.org/show_bug.cgi?id=60921
<rdar://problem/9133872>


  • WebProcess/com.apple.WebProcess.sb:
2:34 PM Changeset in webkit [86607] by crogers@google.com
  • 8 edits
    9 adds in trunk/Source/WebCore

2011-05-16 Chris Rogers <​crogers@google.com>

Reviewed by ​senorblanco@chromium.org.

Add DynamicsCompressorNode implementation
​https://bugs.webkit.org/show_bug.cgi?id=60682

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DynamicsCompressor.cpp: Added. (WebCore::DynamicsCompressor::DynamicsCompressor): (WebCore::DynamicsCompressor::initializeParameters): (WebCore::DynamicsCompressor::parameterValue): (WebCore::DynamicsCompressor::setEmphasisStageParameters): (WebCore::DynamicsCompressor::setEmphasisParameters): (WebCore::DynamicsCompressor::process): (WebCore::DynamicsCompressor::reset):
  • platform/audio/DynamicsCompressor.h: Added. (WebCore::DynamicsCompressor::isStereo): (WebCore::DynamicsCompressor::sampleRate): (WebCore::DynamicsCompressor::nyquist):
  • platform/audio/DynamicsCompressorKernel.cpp: Added. (WebCore::saturate): (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel): (WebCore::DynamicsCompressorKernel::setPreDelayTime): (WebCore::DynamicsCompressorKernel::process): (WebCore::DynamicsCompressorKernel::reset):
  • platform/audio/DynamicsCompressorKernel.h: Added. (WebCore::DynamicsCompressorKernel::latencyFrames): (WebCore::DynamicsCompressorKernel::sampleRate):
  • platform/audio/ZeroPole.cpp: Added. (WebCore::ZeroPole::process):
  • platform/audio/ZeroPole.h: Added. (WebCore::ZeroPole::ZeroPole): (WebCore::ZeroPole::reset): (WebCore::ZeroPole::setZero): (WebCore::ZeroPole::setPole): (WebCore::ZeroPole::zero): (WebCore::ZeroPole::pole):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createDynamicsCompressor):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/DynamicsCompressorNode.cpp: Added. (WebCore::DynamicsCompressorNode::DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::~DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::process): (WebCore::DynamicsCompressorNode::reset): (WebCore::DynamicsCompressorNode::initialize): (WebCore::DynamicsCompressorNode::uninitialize):
  • webaudio/DynamicsCompressorNode.h: Added. (WebCore::DynamicsCompressorNode::create):
  • webaudio/DynamicsCompressorNode.idl: Added.
2:26 PM Changeset in webkit [86606] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Re-added platform-specific result after r86599.

  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from platform/mac-leopard/editing/text-iterator/findString-expected.txt.
2:17 PM Nice Bugzilla queries edited by ddkilzer@webkit.org
Updated 5-year-old links to work with current Bugzilla. (diff)
2:17 PM Changeset in webkit [86605] by rniwa@webkit.org
  • 3 edits
    1 move
    1 add
    11 deletes in trunk/LayoutTests

2011-05-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=60920

Renamed 5091898.html to delete-line-break-before-underlined-content.html and converted it
to a dump-as-markup test.

  • editing/deleting/5091898.html: Removed.
  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: Added.
  • editing/deleting/delete-line-break-before-underlined-content.html: Copied from LayoutTests/editing/deleting/5091898.html.
  • platform/chromium-linux/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.txt: Removed.
  • platform/gtk/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac/editing/style/5091898-expected.png: Removed.
  • platform/mac/editing/style/5091898-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/deleting/5091898-expected.png: Removed.
  • platform/qt/editing/deleting/5091898-expected.txt: Removed.
1:45 PM Changeset in webkit [86604] by tony@chromium.org
  • 57 edits
    1 delete in trunk/LayoutTests

2011-05-16 Tony Chang <​tony@chromium.org>

Move chromium-linux-x86_64 results into chromium-linux. We're making
x86_64 the default configuration for chromium-linux because that's
what the devs build and use.

1:35 PM Changeset in webkit [86603] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix typo pointed out by Dave Levin.

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::assertWKStringEqual):
Strig -> String.

1:28 PM Changeset in webkit [86602] by weinig@apple.com
  • 30 edits in trunk/Tools

2011-05-16 Sam Weinig <​sam@webkit.org>

Reviewed by David Levin.

Convert api tester over to using gtest expectations directly
​https://bugs.webkit.org/show_bug.cgi?id=60862

  • TestWebKitAPI/PlatformUtilities.cpp: (TestWebKitAPI::Util::toSTD):
  • TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::assertWKStrigEqual): Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make the implementation of the macro simpler.
  • TestWebKitAPI/Test.h: Remove TEST_ASSERT forwarder.

[Test changes elided]

1:24 PM Changeset in webkit [86601] by yuzo@google.com
  • 7 edits in trunk/Source

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
​https://bugs.webkit.org/show_bug.cgi?id=43704

In setting printing, we should not validate resources already cached
for the document. If we do, web fonts used for screen are revalidated
and possiby reloaded. Then the fonts can be shown as blank on print.
This patch won't save the case where screen and print use different web
fonts. Nonetheless, this is an improvement.

No new tests because there seems to be no good way to test print images.

  • editing/Editor.cpp: (WebCore::Editor::paste): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • loader/cache/CachedResourceLoader.h: (WebCore::ResourceCacheValidationSuppressor::ResourceCacheValidationSuppressor): RAII class for allowing/disallowing stale resources. (WebCore::ResourceCacheValidationSuppressor::~ResourceCacheValidationSuppressor):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • page/Frame.cpp: (WebCore::Frame::setPrinting): Use ResourceCacheValidationSuppressor to allow stale resources in printing.

2011-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
​https://bugs.webkit.org/show_bug.cgi?id=43704

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
1:18 PM Changeset in webkit [86600] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, de-duplicating media/video-zoom-controls.html expectations.

  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [86599] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe mid-word
​https://bugs.webkit.org/show_bug.cgi?id=60915

Reviewed by Darin Adler.

Source/WebCore:

CFStringTokenizer’s kCFStringTokenizerUnitWord considers “Here’s” as two separate tokens.
Switching to CFStringTokenizer in r84750 was an attempt to address an issue with Japanese word
boundaries for searches with WebFindOptionsAtWordStarts, but it turned out to be insufficient,
and in r86387 the Japanese word issue was addressed independently of text boundaries, so just
revert r84750.

  • platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

LayoutTests:

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
12:59 PM Changeset in webkit [86598] by ddkilzer@apple.com
  • 16 edits in trunk

<​http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
<rdar://problem/9446430>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig: Fixed typo.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit/mac:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit2:

  • Configurations/Base.xcconfig: Fixed typo.

Tools:

  • MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
  • TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  • WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
12:25 PM Changeset in webkit [86597] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for broken regression tests. Adding null pointer check

  • page/FrameView.cpp:

(WebCore::FrameView::didAddHorizontalScrollbar):
(WebCore::FrameView::willRemoveHorizontalScrollbar):

12:04 PM Changeset in webkit [86596] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Remove unused member variables from LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=60899

These should have been removed when tiling was enabled for root
layers.

  • platform/graphics/chromium/LayerRendererChromium.h:
11:58 AM Changeset in webkit [86595] by atwilson@chromium.org
  • 19 edits in trunk

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86589.
​http://trac.webkit.org/changeset/86589
​https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r86589.
​http://trac.webkit.org/changeset/86589
​https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
11:54 AM Changeset in webkit [86594] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

JSWeakObjectMap finalisation may occur while gc is in inconsistent state
​https://bugs.webkit.org/show_bug.cgi?id=60908
<rdar://problem/9409491>

We need to ensure that we have called all the weak map finalizers while
the global object (and hence global context) is still in a consistent
state. The best way to achieve this is to simply use a weak handle and
finalizer on the global object.

  • JavaScriptCore.exp:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::WeakMapFinalizer::finalize):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap):
11:08 AM Changeset in webkit [86593] by bweinstein@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix a revision number in the ChangeLog

11:07 AM Changeset in webkit [86592] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r86555): Dropping URL onto Desktop creates broken Internet Shortcut file.

Reviewed by Enrica Casucci.

r86477 fixed this bug by using latin1 as the CString's encoding instead of ascii, but r86555
undid this change.

Change it back to latin1 to fix the bug.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeURL):

11:03 AM Changeset in webkit [86591] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; build fix for non-SnowLeopard builds.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition

of layerIsDescendentOf in a #if check.

10:55 AM Changeset in webkit [86590] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

If the root compositing layer changes while we're about to exit compositing mode, make sure to enter compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=60905
<rdar://problem/9365574>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): If we have a layer tree host, but haven't yet sent a EnterAcceleratedCompositingMode message (this can happen when quickly going in and out of compositing mode), make sure to schedule a notification when the layer tree host does it next flush. This will end up sending the EnterAcceleratedCompositingMode message.
10:54 AM Changeset in webkit [86589] by podivilov@chromium.org
  • 19 edits in trunk

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
​https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
10:50 AM Changeset in webkit [86588] by jer.noble@apple.com
  • 7 edits in trunk/Source

2011-05-13 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
​https://bugs.webkit.org/show_bug.cgi?id=60826

Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
next time setVisible(true) is called.

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Call setFullScreenRootLayer(0)

before disabling animation on the full screen renderer.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new

WebKitLayerHostChanged notification.

(WebCore::layerIsDescendentOf): Added.
(WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added. If the changed

layer is an ancestor of the movie layer, tear down rendering and re-
create the next time setVisible(true) is called.

(-[WebCoreMovieObserver layerHostChanged:]): Added ObjC listener wrapper.

2011-05-13 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
​https://bugs.webkit.org/show_bug.cgi?id=60826

Emit a notification when moving a CALayer from the WebProcess's main
layer host to a new context. This allows listeners to invalidate their
layers which may not support moving between different CAContexts (as is
the case with QTMovieLayer). In order to allow listeners to determine if they
are affected, the notification will pass the root CALayer in a userInfo
dictionary.

In WebFullScreenManagerMac, move from storing a pointer to a non-refcounted
class (GraphicsLayer) to a retainable class (PlatformLayer).

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): No need to initialize

m_fullScreenRootLayer now that it is a RetainPtr<>.

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Emit a notification

after either creating or destroying the full screen layer host.

(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

10:48 AM Changeset in webkit [86587] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[WK2] Remove some passing tests from the mac-wk2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=60889

  • platform/mac-wk2/Skipped:
10:32 AM Changeset in webkit [86586] by abarth@webkit.org
  • 4 edits
    2 deletes in trunk

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60874

No need to test a feature that doesn't exist.

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Removed.

2011-05-16 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
​https://bugs.webkit.org/show_bug.cgi?id=60874

After talking this out with various folks in the CSP working group, we
decided that this syntax isn't the right way to approach this issue.
If we want to address the use case of enabling JavaScript URLs
separately from inline script, we'll probably just make

script-src javascript:

work that way.

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
10:27 AM Changeset in webkit [86585] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebKit2

[Qt][Wk2][Symbian] Fix build after r86560
​https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <​siddharth.mathur@nokia.com> on 2011-05-16
Rubber-stamped by Csaba Osztrogonác.

Temporarily fix Symbian build by re-enabling compilation
of Qt/Gtk common code (as was the case for Symbian before r55875).
This is a stop gap until the pure Symbian Core IPC and process launching bits land in Bug 55875
As of this revision, only the native SharedMemory implementation is in trunk.

  • Platform/CoreIPC/Attachment.h: Compile Qt/Gtk common code for Qt-Symbian too
  • Platform/CoreIPC/Connection.h: ditto
  • Platform/SharedMemory.h: ditto
  • Platform/qt/SharedMemorySymbian.cpp: stub implementations of attachment handling

(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):

10:25 AM Changeset in webkit [86584] by jonlee@apple.com
  • 47 edits in trunk

Source/WebCore: Reviewed by Simon Fraser.

Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

  • dom/Document.cpp: (WebCore::Document::Document): Initialize wheel event handler count (WebCore::Document::didAddWheelEventHandler): Increment count, and tell the main frame to recalculate the total number of wheel event handlers in all of its frames' documents (WebCore::Document::didRemoveWheelEventHandler): Reverse of previous method
  • dom/Document.h: (WebCore::Document::wheelEventHandlerCount): Access the count
  • dom/Node.cpp: (WebCore::tryAddEventListener): If the event listener is a mouse wheel event, then tell the document to increment its count (WebCore::tryRemoveEventListener): Reverse of previous method
  • page/ChromeClient.h: Two new methods:

numWheelEventHandlersChanged: WebProcess tells UIProcess to update its cached

count of total wheel event handlers, which in this case only include horizontal
scrollbars and mouse wheel JS handlers

shouldRubberBandInDirection: allow the UIProcess to provide some control over

whether rubber banding is allowed when scrolling in a particular direction

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::numWheelEventHandlersChanged): Default empty impl (WebCore::EmptyChromeClient::shouldRubberBandInDirection): Default empty impl
  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Remove a redundant pointer check
  • page/Frame.cpp: (WebCore::Frame::setDocument): When the frame's document changes, calculate that document's total wheel event handlers, and notify the UIProcess (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged): Performs a crawl of the frame tree to aggregate the count
  • page/Frame.h:
  • platform/ScrollableArea.h: Virtualize didAddHorizontalScrollbar and willRemoveHorizontalScrollbar for overriding in RenderLayer and FrameView (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition): Returns true if there is no scrollbar or the scroller position is in the minimum scroll position. (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition): Converse of the above. (WebCore::ScrollableArea::shouldRubberBandInDirection): Default impl
  • page/FrameView.cpp: (WebCore::FrameView::didAddHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::willRemoveHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::shouldRubberBandInDirection): Connective glue
  • page/FrameView.h: Adding overriding methods from ScrollableArea
  • rendering/RenderLayer.cpp: Similar functionality to FrameView (WebCore::RenderLayer::didAddHorizontalScrollbar): (WebCore::RenderLayer::willRemoveHorizontalScrollbar):
  • rendering/RenderLayer.h:
  • platform/mac/ScrollAnimatorMac.h: Fix typo of "momentum"
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Fix typo of "momentum" (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::beginScrollGesture): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::snapRubberBand): Fix typo of "momentum"

(WebCore::ScrollAnimatorMac::handleWheelEvent): New logic for determining whether
to allow rubber-banding based on the area's scroll position and the wheel event.
Could prevent accepting the wheel event. Also, fix typo of "momentum"
(WebCore::isScrollingLeftAndShouldNotRubberBand): Inline helper function for logic
(WebCore::isScrollingRightAndShouldNotRubberBand): Inline helper function for logic

Source/WebKit/chromium: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/efl: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientEfl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/gtk: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/haiku: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientHaiku.h:

(WebCore::ChromeClientHaiku::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientHaiku::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/mac: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method

Source/WebKit/qt: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/win: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wince: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientWinCE.h:

(WebKit::ChromeClientWinCE::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientWinCE::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wx: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientWx::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit2: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

We keep track of the number of horizontal scrollbars and mouse wheel event handlers in the
UI process as a means of determining whether horizontal scroll events will be handled
by the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willHandleHorizontalScrollEvents): Return true if there is at least
one wheel event handler

  • UIProcess/WebPageProxy.h: Add new variable to cache the count

(WebKit::WebPageProxy::numWheelEventHandlersChanged): Sets the count

The rest just provides all the connections.

  • UIProcess/API/C/WKPage.cpp:

(WKPageWillHandleHorizontalScrollEvents):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldRubberBandInDirection): Forward to injected bundle UI client
(WebKit::WebChromeClient::updateCountWheelEventHandlers): Updates the web page proxy

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools: Can't horizontally scroll iframes and overflow because wheel events are always accepted
​https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.

10:16 AM Changeset in webkit [86583] by commit-queue@webkit.org
  • 15 edits
    1 copy in trunk

2011-05-16 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
​https://bugs.webkit.org/show_bug.cgi?id=60177

Re-enable the argument-types test as the navigator.getUserMedia options
are now being parsed and raise the appropriate exceptions.

  • platform/chromium/test_expectations.txt:

2011-05-16 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
​https://bugs.webkit.org/show_bug.cgi?id=60177

Add the code and messages for requesting the generation of local streams and getting the reply back.

Tests for the Media Stream API will be provided by the bug 56587.
One test is re-enabled with this patch.

Test: fast/dom/MediaStream/argument-types.html

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/CallbackTask.h: Added. (WebCore::CallbackTask1::create): (WebCore::CallbackTask1::performTask): (WebCore::CallbackTask1::Scheduler::scheduleCallback): (WebCore::CallbackTask1::CallbackTask1):
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::isClientAvailable): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest): (WebCore::MediaStreamController::registerStream): (WebCore::MediaStreamController::generateStream): (WebCore::MediaStreamController::streamGenerated): (WebCore::MediaStreamController::streamGenerationFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback): (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback): (WebCore::::unregisterAll): (WebCore::::detachEmbedder): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::isClientAvailable): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::parseGenerateStreamOptions): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::ClientBase): (WebCore::MediaStreamFrameController::ClientBase::~ClientBase): (WebCore::MediaStreamFrameController::ClientBase::mediaStreamFrameController): (WebCore::MediaStreamFrameController::ClientBase::clientId): (WebCore::MediaStreamFrameController::ClientBase::isStream): (WebCore::MediaStreamFrameController::ClientBase::isGeneratedStream): (WebCore::MediaStreamFrameController::ClientBase::detachEmbedder): (WebCore::MediaStreamFrameController::ClientBase::associateFrameController): (WebCore::MediaStreamFrameController::ClientBase::unregisterClient): (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::~StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isStream): (WebCore::MediaStreamFrameController::StreamClient::unregister): (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator): (WebCore::MediaStreamFrameController::IdGenerator::getNextId): (WebCore::MediaStreamFrameController::ClientMapBase::ClientMapBase):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/NavigatorUserMediaErrorCallback.h:
10:09 AM Changeset in webkit [86582] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=60892

Don't set the ItemClipsChildrenToShape flag for the root platform layer,
since that is now the overflow controls layer. The clip layer, which was
previously the root platform layer, already gets the flag by way of
the GraphicsLayer mask-to-bounds flag.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
9:58 AM Changeset in webkit [86581] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: debuggerWasEnabled notification should not be send to front-end on navigation.
​https://bugs.webkit.org/show_bug.cgi?id=60888

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::restore): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
9:54 AM Changeset in webkit [86580] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
​https://bugs.webkit.org/show_bug.cgi?id=60898
<rdar://problem/9309903>

Special-case Command-A and always return true, indicating that the plug-in handled the event.
This matches WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
9:52 AM Changeset in webkit [86579] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-16 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursors
​https://bugs.webkit.org/show_bug.cgi?id=60804

This test creates an object store with a few records and exercises
a variety of cursors going forward, backward, and over key ranges.
It also updates records from the cursor and checks that the update
stuck.

  • storage/indexeddb/mozilla/cursors-expected.txt: Added.
  • storage/indexeddb/mozilla/cursors.html: Added.
9:34 AM Changeset in webkit [86578] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Short-circuit NPRuntime calls made by Flash during plug-in instantiation
​https://bugs.webkit.org/show_bug.cgi?id=60894
<rdar://problem/8804681>

During plug-in instantiation, Flash makes a couple of NPRuntime calls to get the
URL of the current document as well as the URL of the toplevel document. This leads to
a bunch of IPC traffic that slows down instantiation.

Since we know what calls Flash is making and what results are expected, we can handle the
NPRuntime calls directly in the plug-in process and avoid extra IPC overhead.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): Initialize m_pluginCreationParameters.

(WebKit::PluginControllerProxy::initialize):
Set m_pluginCreationParameters to point to the creation parameters right before
calling Plugin::initialize and restore it back afterwards.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
If the plug-in calling NPN_Invoke has the CanShortCircuitSomeNPRuntimeCallsDuringInitialization
quirk, and we're being initialized, check for the flash_getWindowLocation and
flash_getTopLocation function calls and return the correct values.

(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Check if the script string has the definitions of flash_getWindowLocation or flash_getTopLocation
and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
which could in theory be a backwards compatibility problem if web pages were to assume that these
functions existed on a page with plug-ins. In practice this is probably not a problem, especially since
these functions are only used on Mac WebKit.

  • PluginProcess/PluginControllerProxy.h: (WebKit::PluginControllerProxy::inInitialize): Add helper function.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk for Flash on Mac.
  • Shared/Plugins/PluginQuirks.h: Add Mac specific CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk.
9:06 AM Changeset in webkit [86577] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add a returnValue parameter to tryToShortCircuitInvoke
​https://bugs.webkit.org/show_bug.cgi?id=60891

tryToShortCircuitInvoke needs to be able to indicate that an invoke
call failed. Add a returnValue parameter and have the real return value
indicate whether tryToShortCircuitInvoke did short-circuit the invoke or not.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke):
  • WebProcess/Plugins/PluginView.h:
9:05 AM Changeset in webkit [86576] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-16 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove EAPI macro from functions definition
​https://bugs.webkit.org/show_bug.cgi?id=60754

This macro should be used in header files only.
It's not necessary to have it in definitions.

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_window_features.cpp: (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get):
8:58 AM Changeset in webkit [86575] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the failing mac-wk2 expected results for online-fallback-layering.html, since it now
appears to be passing on the SL WK2 bots:
​http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r86545%20(11698)/http/tests/appcache/online-fallback-layering-pretty-diff.html

  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Removed.
8:23 AM Changeset in webkit [86574] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[Qt][Wk2][Symbian] Fix build after r86560
​https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <​siddharth.mathur@nokia.com> on 2011-05-16
Reviewed by Csaba Osztrogonác.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with USE(UNIX_DOMAIN_SOCKETS)

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder): ditto

8:11 AM Changeset in webkit [86573] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
​https://bugs.webkit.org/show_bug.cgi?id=60886

Make it possible for a plug-in controller to intercept calls to NPN_Invoke, which
will be useful for avoiding sync IPC messages during instantiation.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::evaluate): Call tryToShortCircuitEvaluate. If it returns true, we don't need to call back to the web process to ask it to evaluate the script string.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Always return false for now.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke): Get the plug-in and call tryToShortCircuitInvoke.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke): Call the plug-in controller.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke): Always return false here, since there's no need to short-circuit calls for plug-ins that live in the web process.
7:49 AM Changeset in webkit [86572] by Ademar Reis
  • 2 edits in trunk/Tools

2011-05-16 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] Tools.pro misses include(common.pri)
​https://bugs.webkit.org/show_bug.cgi?id=60883

It includes features.pri, which depends on common.pri (the build is
not broken today with the default options, but this is the right
thing to do).

  • Tools.pro:
7:41 AM Changeset in webkit [86571] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed, skip failing tests.

  • platform/mac-wk2/Skipped: Add fast/forms/focus-with-display-block.html because of missing eventSender.keyDown implementation
  • platform/qt-wk2/Skipped: Add fast/js/array-sort-modifying-tostring.html to make WK2 bot green to be able to catch new regressions
7:38 AM Changeset in webkit [86570] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-16 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix inspector dom action test flake.

  • inspector/elements/edit-dom-actions.html:
7:26 AM Changeset in webkit [86569] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Added fast/forms/focus-with-display-block.html.
7:23 AM Changeset in webkit [86568] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Addd

platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html.

7:23 AM Changeset in webkit [86567] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update results for a new Mac dragging test

This test has been failing since it was added in r86472. I don't know whether the old
results are wrong or the test is actually showing a bug. <​http://webkit.org/b/60882> tracks
the failure.

  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt:
6:44 AM Changeset in webkit [86566] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Windows build fix.

  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::consoleMarkTimeline):
6:36 AM Changeset in webkit [86565] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext):
6:27 AM Changeset in webkit [86564] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
​https://bugs.webkit.org/show_bug.cgi?id=60624

InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
about changes in WebCore.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed):
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::inspectedPage):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros is used for early return in common case when inspector is not opened. In this case inspector instrumentation costs one additional check of a static field. (WebCore::InspectorInstrumentation::didOpenDatabase):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl): (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willCallFunctionImpl): (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willEvaluateScriptImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::willLayoutImpl): (WebCore::InspectorInstrumentation::willLoadXHRImpl): (WebCore::InspectorInstrumentation::willPaintImpl): (WebCore::InspectorInstrumentation::willRecalculateStyleImpl): (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl): (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::willWriteHTMLImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::bindInstrumentingAgents): (WebCore::InspectorInstrumentation::unbindInstrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::didInvalidateStyleAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::applyUserAgentOverride): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::continueAfterPingLoader): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied): (WebCore::InspectorInstrumentation::continueWithPolicyDownload): (WebCore::InspectorInstrumentation::continueWithPolicyIgnore): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::instrumentingAgentsForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):
6:18 AM Changeset in webkit [86563] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-16 Pavel Feldman <​pfeldman@google.com>

Not reviewed: simplify inspector dom actions test.

  • inspector/elements/edit-dom-actions.html:
5:56 AM Changeset in webkit [86562] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-16 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Move Resources Panel search to backend
​https://bugs.webkit.org/show_bug.cgi?id=59596

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::decodeMainResource): (WebCore::InspectorPageAgent::resourceContent): (WebCore::cachedResourcesForFrame): (WebCore::InspectorPageAgent::getCookies): (WebCore::InspectorPageAgent::deleteCookie): (WebCore::createSearchRegexSource): (WebCore::countRegularExpressionMatches): (WebCore::buildObjectForSearchMatch): (WebCore::InspectorPageAgent::searchInResources): (WebCore::InspectorPageAgent::domContentEventFired): (WebCore::InspectorPageAgent::loadEventFired): (WebCore::InspectorPageAgent::frameNavigated): (WebCore::InspectorPageAgent::frameDetached): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype.performSearch.searchInEditedResource): (WebInspector.ResourcesPanel.prototype.performSearch.callback): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype._ensureViewSearchPerformed): (WebInspector.ResourcesPanel.prototype._showSearchResult.callback): (WebInspector.ResourcesPanel.prototype._showSearchResult): (WebInspector.ResourcesPanel.prototype._resetSearchResults): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult): (WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult): (WebInspector.FrameTreeElement.prototype.resourceByURL): (WebInspector.FrameResourceTreeElement.prototype._resetSearchResults): (WebInspector.FrameResourceTreeElement.prototype.get searchMatchesCount): (WebInspector.FrameResourceTreeElement.prototype.searchMatchesFound): (WebInspector.ResourcesSearchController): (WebInspector.ResourcesSearchController.prototype.nextSearchResult): (WebInspector.ResourcesSearchController.prototype.previousSearchResult): (WebInspector.ResourcesSearchController.prototype._searchResult): (WebInspector.SearchResultsTreeElementsTraverser): (WebInspector.SearchResultsTreeElementsTraverser.prototype.first): (WebInspector.SearchResultsTreeElementsTraverser.prototype.last): (WebInspector.SearchResultsTreeElementsTraverser.prototype.next): (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext): (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementHasSearchResults): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.createSearchRegex): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.hasSearchResults): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.jumpToSearchResult): (WebInspector.SourceFrame.prototype._collectRegexMatches):
  • inspector/front-end/utilities.js: ():
5:42 AM Changeset in webkit [86561] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

CSS: Fast path for 'px' lengths should be case-insensitive.
​https://bugs.webkit.org/show_bug.cgi?id=60703

No new tests, this is an optimization that avoids creating
a full CSSParser to parse the value.

  • css/CSSParser.cpp: (WebCore::parseSimpleLengthValue):
5:40 AM Changeset in webkit [86560] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

2011-05-16 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=55875

  • wtf/Platform.h: Exclude Symbian OS from USE(UNIX_DOMAIN_SOCKETS) users

2011-05-16 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=55875

Use global chunks for sharing data between processes.
This is an initial implementation. An outstanding issue
is the correct way to close() the chunk in the SharedMemory d'tor
without triggering a delete by the kernel when the ref-count
temporarily goes to zero.

  • Platform/SharedMemory.h: platform specific handle and chunk name
  • Platform/qt/SharedMemorySymbian.cpp: Added. Native Symbian OS implementation using RChunk.CreateGlobal() for named chunks. The chunk name is serialized and sent over the IPC channel and opened by the remote process using RChunk.OpenGlobal().

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
(WebKit::SharedMemory::systemPageSize):

  • Platform/unix/SharedMemoryUnix.cpp: Exclude Qt-Symbian using HAVE(UNIX_DOMAIN_SOCKETS)
  • WebKit2.pro: Add SharedMemorySymbian.cpp
5:28 AM Changeset in webkit [86559] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/inspector.css

Merge 85402 - 2011-04-30 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector toolbar titles were 2px off.

  • inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7032004

5:24 AM Changeset in webkit [86558] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/NetworkManager.js

Merge 86027 - 2011-05-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/7030014

5:05 AM Changeset in webkit [86557] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-16 Naiem Shaik <​naiem.shaik@gmail.com>

Reviewed by Adam Barth.

This is for fixing build break in webgl due to ​https://bugs.webkit.org/show_bug.cgi?id=59861
The bug raised for fixing this is ​https://bugs.webkit.org/show_bug.cgi?id=60867

No new tests. This does not change any functionality.

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.cpp: (WebCore::GraphicsContext3DInternal::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.h:
5:00 AM Changeset in webkit [86556] by pfeldman@chromium.org
  • 5 edits in trunk

2011-05-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: parse edited attributes by means of InspectorDOMAgent.
​https://bugs.webkit.org/show_bug.cgi?id=60807

This change moves attribute parsing from the front-end to the backend.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttribute):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
3:58 AM Changeset in webkit [86555] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Switch from Vector<UChar> to StringBuilder in dom/
​https://bugs.webkit.org/show_bug.cgi?id=57843

Incorporate comment from Darin/Andreas.

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i]. (WebCore::convertPropertyNameToAttributeName): Ditto.
3:51 AM Changeset in webkit [86554] by apavlov@chromium.org
  • 6 edits in trunk

2011-05-16 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
​https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:

2011-05-16 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
​https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
3:20 AM Changeset in webkit [86553] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Darin Adler.

Switch from Vector<UChar> to StringBuilder in dom/
​https://bugs.webkit.org/show_bug.cgi?id=57843

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): (WebCore::convertPropertyNameToAttributeName):
  • dom/Range.cpp: (WebCore::Range::toString):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptContent):
2:53 AM Changeset in webkit [86552] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-05 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move double click handling from TextEditor to SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=60271

It is SourceFrame's responsibility to check if content is editable and
to configure TextEditor component (e.g. set editable range) when user
tries to initiate editing.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.doubleClick): (WebInspector.RevisionSourceFrame.prototype.doubleClick):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.beforeTextChanged): (WebInspector.SourceFrame.prototype.afterTextChanged): (WebInspector.SourceFrame.prototype.doubleClick): (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.cancelEditing): (WebInspector.SourceFrame.prototype._setReadOnly):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._doubleClick): (WebInspector.TextViewer.prototype._commitEditing): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewerDelegate.prototype.doubleClick): (WebInspector.TextViewerDelegate.prototype.beforeTextChanged): (WebInspector.TextViewerDelegate.prototype.afterTextChanged):
2:50 AM Changeset in webkit [86551] by loislo@chromium.org
  • 4 edits in trunk

2011-05-15 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:
2:30 AM Changeset in webkit [86550] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Partial revert of r86537. FullScreenVideoQt.h can't depend on OwnPtr.h
because moc_FullScreenVideoQt.cpp fails to include config.h.
Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
is hard, so we're going back to manual new and delete for this class.
Bad times.

  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
2:27 AM Changeset in webkit [86549] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r86489.

  • GNUmakefile.am: Add PluginProcess/PluginCreationParameters.cpp and PluginProcess/PluginCreationParameters.h to compilation.
2:17 AM Changeset in webkit [86548] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-16 Huzaifa Sidhpurwala <​huzaifas@redhat.com>

Reviewed by Adam Barth.

Add Huzaifa Sidhpurwala to the WebKit Security Group site.
​https://bugs.webkit.org/show_bug.cgi?id=60686

  • security/security-group-members.html:
2:08 AM Changeset in webkit [86547] by barraclough@apple.com
  • 7 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60866
Evaluation order broken for empty alternatives in subpatterns

Rubber stamped by Geoff Garen.

Source/JavaScriptCore:

Reverting ​https://bugs.webkit.org/show_bug.cgi?id=51395

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

LayoutTests:

Reverted ​https://bugs.webkit.org/show_bug.cgi?id=51395, and added
test cases for /(|a)/ and /(a|)/, to test the evaluation order of
subpattern matches with empty alternatives.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
  • fast/regex/script-tests/slow.js:
  • fast/regex/slow-expected.txt:
1:25 AM Changeset in webkit [86546] by alex
  • 2 edits in trunk/LayoutTests

2011-05-16 Alejandro G. Castro <​alex@igalia.com>

Skipped failing test, the fail already has a bug:

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60834

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [86545] by Carlos Garcia Campos
  • 4 edits
    5 adds in trunk

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
​https://bugs.webkit.org/show_bug.cgi?id=58223

  • configure.ac: Add configure option to enable/disable plugin process.

2011-05-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
​https://bugs.webkit.org/show_bug.cgi?id=58223

  • GNUmakefile.am: Add new files to compilation.
  • PluginProcess/gtk/PluginControllerProxyGtk.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/gtk/PluginProcessGtk.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebProcess/Plugins/Netscape/gtk/PluginProxyGtk.cpp: Added. (WebKit::PluginProxy::needsBackingStore):
1:02 AM Changeset in webkit [86544] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createGraphicsContext):
12:59 AM Changeset in webkit [86543] by Nikolas Zimmermann
  • 1 edit in trunk/Source/WebCore/plugins/PluginStream.cpp

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
​https://bugs.webkit.org/show_bug.cgi?id=60700

Oops, forgot to include plugins/ in my previous commit.

Remove makeString() usage everywhere, instead directly use operator+.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
12:56 AM Changeset in webkit [86542] by Nikolas Zimmermann
  • 52 edits in trunk/Source/WebCore

2011-05-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
​https://bugs.webkit.org/show_bug.cgi?id=60700

Remove makeString() usage everywhere, instead directly use operator+.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::borderSpacingValue):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
  • html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::didReceiveResponse):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::crossDomainAccessErrorMessage):
  • page/PageSerializer.cpp: (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator): (WebCore::SerializerMarkupAccumulator::appendElement): (WebCore::PageSerializer::urlForBlankFrame):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
  • platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationIdentifier):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL):
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL):
  • platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::reportErrorToClient):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeURL):
  • platform/win/FileSystemWin.cpp: (WebCore::listDirectory):
  • platform/win/LanguageWin.cpp: (WebCore::platformDefaultLanguage):
  • platform/win/PathWalker.cpp: (WebCore::PathWalker::PathWalker):
  • platform/win/SystemInfo.cpp: (WebCore::osVersionForUAString): (WebCore::windowsVersionForUAString):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::valueAsString):
  • svg/SVGLength.cpp: (WebCore::SVGLength::valueAsString):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::cssText):
  • svg/SVGPointList.cpp: (WebCore::SVGPointList::valueAsString):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::valueAsString):
  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString):
  • svg/SVGTransformList.cpp:
  • svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
12:51 AM Changeset in webkit [86541] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Sigh. This code is somewhat crazy.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
12:43 AM Changeset in webkit [86540] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

This patch requires some slightly fancy footwork.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
12:30 AM Changeset in webkit [86539] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-05-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector console should be searchable
​https://bugs.webkit.org/show_bug.cgi?id=60711

Search now works for Console panel. It shows number of matching console entries
and allows to jump to the next matching console entry. Also the matches count
is dynamically updated when new messages are added to the console.

ResourceTreeModel and DebuggerPresentationModel now listen to console events instead
of being called directly from ConsoleView.

  • inspector/front-end/ConsolePanel.js: (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.searchCanceled): (WebInspector.ConsolePanel.prototype.performSearch): (WebInspector.ConsolePanel.prototype.jumpToNextSearchResult): (WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult): (WebInspector.ConsolePanel.prototype._clearCurrentSearchResultHighlight): (WebInspector.ConsolePanel.prototype._jumpToSearchResult): (WebInspector.ConsolePanel.prototype._consoleMessageAdded): (WebInspector.ConsolePanel.prototype._consoleCleared):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage.prototype.clearHighlight): (WebInspector.ConsoleMessage.prototype.highlightSearchResults): (WebInspector.ConsoleMessage.prototype.matchesRegex): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype.clearHighlight): (WebInspector.ConsoleCommand.prototype.highlightSearchResults): (WebInspector.ConsoleCommand.prototype.matchesRegex): (WebInspector.ConsoleCommand.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype._formatCommand):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded): (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
  • inspector/front-end/utilities.js: ():
12:27 AM Changeset in webkit [86538] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-16 Adam Barth <​abarth@webkit.org>

Missing include.

  • WebCoreSupport/PopupMenuQt.h:
12:24 AM Changeset in webkit [86537] by abarth@webkit.org
  • 13 edits in trunk/Source

2011-05-16 Adam Barth <​abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60873

This change is slightly more than a build fix because the patch kind of
spidered a bit while I was trying to fix the build the "right way."
Hopefully nothing here is controversial.

  • Api/qwebpage.cpp: (QWebPagePrivate::adjustPointForClicking):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationWrapper::NotificationWrapper): (WebCore::NotificationPresenterClientQt::displayNotification):
  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::show):
  • WebCoreSupport/PopupMenuQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createSelectInputMethod): (WebCore::QtPlatformPlugin::createNotificationPresenter): (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer): (WebCore::QtPlatformPlugin::createTouchModifier): (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h: (WebCore::QtPlatformPlugin::QtPlatformPlugin):

2011-05-16 Adam Barth <​abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=60873

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
12:21 AM Changeset in webkit [86536] by barraclough@apple.com
  • 5 edits in trunk

Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=60860
Simplify backtracking in YARR JIT

Reviewed by Geoff Garen & Michael Saboff.

YARR JIT currently performs a single pass of code generation over the pattern,
with special handling to allow the code generation for some backtracking code
out of line. We can simplify things by moving to a common mechanism whereby all
forwards matching code is generated in one pass, and all backtracking code is
generated in another. Backtracking code can be generated in reverse order, to
optimized the common fall-through case.

To make it easier to walk over the pattern, we can first convert to a more
byte-code like format before JIT generating. In time we should unify this with
the YARR interpreter to more closely unify the two.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):
(JSC::Yarr::YarrGenerator::BacktrackingState::BacktrackingState):
(JSC::Yarr::YarrGenerator::BacktrackingState::append):
(JSC::Yarr::YarrGenerator::BacktrackingState::fallthrough):
(JSC::Yarr::YarrGenerator::BacktrackingState::link):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkTo):
(JSC::Yarr::YarrGenerator::BacktrackingState::takeBacktracksToJumpList):
(JSC::Yarr::YarrGenerator::BacktrackingState::isEmpty):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkDataLabels):
(JSC::Yarr::YarrGenerator::BacktrackingState::ReturnAddressRecord::ReturnAddressRecord):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::backtrackAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileAlternative):
(JSC::Yarr::YarrGenerator::opCompileBody):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=60860
Add layout tests for some regular expressions that used to crash the compiler.

Reviewed by Geoff Garen & Michael Saboff.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
12:07 AM Changeset in webkit [86535] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

media/video-volume-slider.html causes GTK 64 bit debug bot to time out
​https://bugs.webkit.org/show_bug.cgi?id=60055

  • media/video-volume-slider.html: Use the shadow DOM tree to locate the mute button and get its coordinates. This test is now more port-agnostic.
12:01 AM Changeset in webkit [86534] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

2011-05-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Darin Adler.

Move mediaControlsButtonCoordinates() out of video-test.js
​https://bugs.webkit.org/show_bug.cgi?id=60693

Moved the function to a new js file called media-controls.js. Also
made the function throw an exception if the button is not found
and handle the exception in the various tests using the function.

  • media/audio-delete-while-step-button-clicked.html:
  • media/media-controls.js: Added. (mediaControlsButtonCoordinates):
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (isInTimeRanges):

May 15, 2011:

11:52 PM Changeset in webkit [86533] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachCurrentPage): (QGraphicsWebView::setPage):
  • Api/qwebpage.cpp: (QWebPage::setView):
11:46 PM Changeset in webkit [86532] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::GraphicsLayerQt): (WebCore::GraphicsLayer::create):
11:41 PM Changeset in webkit [86531] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/text/qt/TextCodecQt.cpp: (WebCore::newTextCodecQt):
11:36 PM Changeset in webkit [86530] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::release): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::start):
11:30 PM Changeset in webkit [86529] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doEnd):
11:21 PM Changeset in webkit [86528] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-15 Adam Barth <​abarth@webkit.org>

Enable strict PassOwnPtr on Qt. (Build fixes to follow.)

  • wtf/PassOwnPtr.h:
11:15 PM Changeset in webkit [86527] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-15 MORITA Hajime <​morrita@google.com>

Unreviewed an expectation update.

  • platform/gtk/fast/html/details-add-child-2-expected.txt:
10:59 PM Changeset in webkit [86526] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

2011-05-15 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
​https://bugs.webkit.org/show_bug.cgi?id=60602

Add a test that ensures <output>, <meter> and <progress> are not focused.
Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

  • fast/forms/focus-with-display-block-expected.txt: Added.
  • fast/forms/focus-with-display-block.html: Added.
  • platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.

2011-05-15 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
​https://bugs.webkit.org/show_bug.cgi?id=60602

HTMLFormControlElement::isFocusable() returns true when the element is
visible as a block element. However, for output, meter, and progress
elements, the function should not return true unless they have
tabindex attributes. Override supportsFocus() of these elements to
apply the result of Node::supportsFocus() because it takes care of
whether the element has tabindex or not.

Test: fast/forms/focus-with-display-block.html

  • html/HTMLFormControlElement.h: Made supportsFocus() protected.
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::supportsFocus): Added.
  • html/HTMLMeterElement.h:
  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::supportsFocus): Added.
  • html/HTMLOutputElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::supportsFocus): Added.
  • html/HTMLProgressElement.h:
10:44 PM Changeset in webkit [86525] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

10:31 PM Changeset in webkit [86524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-15 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
​https://bugs.webkit.org/show_bug.cgi?id=60864

Implemented reuse of BackingStore's in
DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
matches the size of the existing BackingStore.
Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
These changes reduces memory usage up to 10MB on memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
10:10 PM Changeset in webkit [86523] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.

​https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason


(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))


I'm basically rolling out ​http://trac.webkit.org/changeset/49786 because

(a) it created this performance problem


and


(b) a more complete fix, which obsoletes ​http://trac.webkit.org/changeset/49786,
was committed in ​http://trac.webkit.org/changeset/53439.


Tested with the file attached to ​https://bugs.webkit.org/show_bug.cgi?id=29832.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't create a new window every time we destroy a frame.
8:29 PM Changeset in webkit [86522] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Pass the window NPObject identifier in the plug-in creation parameters
​https://bugs.webkit.org/show_bug.cgi?id=60865

This avoids a synchronous call when the plug-in wants to get the NPObject that
corresponds to the window.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): Change this to take the PluginCreationParameters. Initialize the window NPObject.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Just return the window NPObject; it's already been initialized.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Add the window NPObject ID.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin): Pass the creation parameters to PluginControllerProxy::initialize.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Initialize the window NPObject ID.
  • WebProcess/Plugins/PluginProxy.messages.in: Remove the GetWindowScriptNPObject message.
7:55 PM Changeset in webkit [86521] by morrita@google.com
  • 15 edits
    2 copies
    12 adds in trunk

2011-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should affect the order of renderer children
​https://bugs.webkit.org/show_bug.cgi?id=59157

  • fast/html/details-add-details-child-1.html: Added.
  • fast/html/details-add-details-child-2.html: Added.
  • fast/html/details-nested-1.html: Added.
  • fast/html/details-nested-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.txt: Added.
  • platform/mac/fast/html/details-nested-2-expected.png: Added.
  • platform/mac/fast/html/details-nested-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:

2011-05-12 MORITA Hajime <​morrita@google.com>

ShadowContentElement should affect the order of renderer children
​https://bugs.webkit.org/show_bug.cgi?id=59157

Introduced ShadowContentSelector to collect and forward content
children for each ShadowContentElement. ShadowRoot collects child
nodes of its host (we call these children "content children"), and
the descendant ShadowContentElement pulls that these content
children and put it under its child during
ShadowContentElement::attach().

Content children no longer create its renderer during its normal
attach() phase (called "light" phase). And they create it during
attach() as a content children instead (called "forwarded phase").
These phases are detected by NodeRendererFactory and represented
as NodeRendererFactory::AttachPhase value AttachContentLight and
AttachContentForwarded.

Tests: fast/html/details-add-details-child-1.html

fast/html/details-add-details-child-2.html
fast/html/details-nested-1.html
fast/html/details-nested-2.html

  • dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/ShadowRoot.cpp: (WebCore::forceReattach): (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance): (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor): (WebCore::ShadowContentElement::attach): (WebCore::ShadowRoot::recalcStyle): (WebCore::ShadowRoot::activeContentContainer): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::attach):
  • dom/ShadowRoot.h:
  • html/shadow/ShadowContentElement.h: (WebCore::ShadowContentElement::rendererIsNeeded):
  • rendering/RenderDetails.cpp:
  • rendering/RenderDetails.h:
7:46 PM Changeset in webkit [86520] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-13 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
​https://bugs.webkit.org/show_bug.cgi?id=57088

Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::resolveTextCheckingTypeMask):
  • editing/Editor.h:
  • platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel
6:44 PM Changeset in webkit [86519] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-15 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.
6:35 PM Changeset in webkit [86518] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Dominic Cooney <​dominicc@chromium.org>

Unreviewed. Remove expectation of gc-shadow.html flakiness.

  • platform/chromium/test_expectations.txt:
6:21 PM Changeset in webkit [86517] by dominicc@chromium.org
  • 2 edits in trunk/Tools

2011-05-15 Dominic Cooney <​dominicc@chromium.org>

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
5:53 PM Changeset in webkit [86516] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen.

Pass the document URL and toplevel document URL when creating a plug-in
​https://bugs.webkit.org/show_bug.cgi?id=60863

This is the first of a series of patches intended to reduce the IPC traffic
during plug-in instantiation.

  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Parameters::encode): Encode the URLs.

(WebKit::Plugin::Parameters::decode):
Decode the URLs.

  • WebProcess/Plugins/Plugin.h: Add the document and toplevel document URLs.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Initialize the document and toplevel document URLs.
4:54 PM Changeset in webkit [86515] by dbates@webkit.org
  • 6 edits in trunk/Tools

2011-05-15 Daniel Bates <​dbates@webkit.org>

Reviewed by Chris Jerdonek.

svn-apply can't handle Git diff that only changes executable bit
​https://bugs.webkit.org/show_bug.cgi?id=60848

Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
that only has an executable bit change.

  • Scripts/VCSUtils.pm:
    • Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().

(parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
fixing <​https://bugs.webkit.org/show_bug.cgi?id=29684>.

  • Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
  • Scripts/svn-unapply: (patch): Ditto.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated expected results for test cases to account for numTextChunks.
    • Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
    • Added test case "Git: file that only has an executable bit change".
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
    • Updated expected results for test cases to account for numTextChunks.
4:20 PM Changeset in webkit [86514] by rwlbuis@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-15 Rob Buis <​rbuis@rim.com>

Reviewed by Eric Seidel.

REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
​https://bugs.webkit.org/show_bug.cgi?id=16614

Include testcase from the bug to prevent future regression (right now we pass both full testcase
and this reduction).

  • platform/mac/svg/custom/small-rect-scale-expected.png: Added.
  • platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
  • svg/custom/small-rect-scale.svg: Added.
4:02 PM Changeset in webkit [86513] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build.

  • TestWebKitAPI/win/main.cpp:

(main):

3:49 PM Changeset in webkit [86512] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86509.

  • platform/qt/Skipped:
3:41 PM Changeset in webkit [86511] by weinig@apple.com
  • 6 edits in trunk/Tools

2011-05-15 Sam Weinig <​sam@webkit.org>

Reviewed by David Levin.

Make API tester more gtest friendly
​https://bugs.webkit.org/show_bug.cgi?id=60859

  • Scripts/run-api-tests: Numerous changes:
  • Remove logic to run tests one at a time.
  • Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us.
  • Forward stdout from the test tool to stdout, even in non-verbose runs.
  • Run test tool from the current working directory instead of the root webkit directory.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources.
  • TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run):
  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point.
3:31 PM Changeset in webkit [86510] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/JSFunction.cpp: Made the host function stub cache weak --

otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

11:43 AM Changeset in webkit [86509] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Just skipping a test.

  • platform/qt/Skipped: inspector/console/console-long-eval-crash.html
10:34 AM Changeset in webkit [86508] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, just skipping a test.

New test fails on some of the SnowLeopard bots.

  • platform/mac-snowleopard/Skipped:
9:57 AM Changeset in webkit [86507] by loislo@chromium.org
  • 10 edits
    2 adds in trunk

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

​https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
9:18 AM Changeset in webkit [86506] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
​https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Test: http/tests/media/video-cross-site.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction

to prevent cross-domain references from being followed.

2011-05-15 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
​https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Add test for cross-domain QuickTime reference movie and test.

  • http/tests/media/resources/cross-site-reference.mov: Added.
  • http/tests/media/video-cross-site-expected.txt: Added.
  • http/tests/media/video-cross-site.html: Added.
  • platform/chromium/test_expectations.txt: Skipped, QuickTime reference movies not supported.
  • platform/gtk/Skipped: Ditto.
7:07 AM Changeset in webkit [86505] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
​http://trac.webkit.org/changeset/86504
​https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
6:49 AM Changeset in webkit [86504] by robert@webkit.org
  • 9 edits
    1 add in trunk

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
​https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
4:40 AM Changeset in webkit [86503] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Arno Renevier <​arno@renevier.net>

Reviewed by Darin Adler.

remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60775

No new tests. This change only impacts compilation.

  • html/HTMLFrameElementBase.cpp:

May 14, 2011:

11:41 PM Changeset in webkit [86502] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Fix strokeArc and fillRoundedRect drawing, and add clipPath support.

​https://bugs.webkit.org/show_bug.cgi?id=60847

10:39 PM Changeset in webkit [86501] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

2011-05-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTTP video-on-demand streams frequently have live stream UI
​https://bugs.webkit.org/show_bug.cgi?id=60849
<rdar://problem/9440502>

No new tests, we don't currently have tests for http live streams. Changes verified manually.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Reset the media controls so

a duration change which identifies a format will be picked up.

(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): New, reset media controls

so they can be reconfigured for the media file characteristics.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::characteristicChanged): New, pass through to the element.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerCharacteristicChanged):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setHasVideo): Call characteristicChanged when

setting changes.

(WebCore::MediaPlayerPrivateAVFoundation::setHasAudio): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::setHasClosedCaptions): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Move the duration

change notification logic to invalidateCachedDuration.

(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration): New, invalidate

the cached duration and notify the element when it changes.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call invalidateCachedDuration

for the DurationChanged notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Define DurationChanged.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't check asset or

item duration until they have been loaded.

(WebCore::itemKVOProperties): Listen for duration change.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with

duration change notification.

6:51 PM Changeset in webkit [86500] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when trying to parse an invalid font family
value of 'inherit' or 'initial' in a font face rule.
​https://bugs.webkit.org/show_bug.cgi?id=60837

  • fast/css/invalid-font-family-in-font-face-crash-expected.txt: Added.
  • fast/css/invalid-font-family-in-font-face-crash.html: Added.

2011-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

As per spec, only allow one font family name in a font face rule.
Other things like initial value, inherited value or multiple names
are discarded.
​https://bugs.webkit.org/show_bug.cgi?id=60837

Test: fast/css/invalid-font-family-in-font-face-crash.html

  • css/CSSParser.cpp: (WebCore::CSSParser::createFontFaceRule):
3:10 PM Changeset in webkit [86499] by oliver@apple.com
  • 66 edits in trunk/Source

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSCell.cpp: (JSC::slowValidateCell):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
  • runtime/Structure.h: (JSC::JSCell::classInfo):
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
  • wtf/Assertions.h:

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):
2:44 PM Changeset in webkit [86498] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders Carlsson.

Make Qt bindings GC safe
​https://bugs.webkit.org/show_bug.cgi?id=60841

Trying to do cache management by using "this" as a key from a GC
object's destructor leads to a violation of GC semantics. Make
the qt bindings use a Weak<> handle for finalization.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
  • bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethodData::finalize):
2:23 PM Changeset in webkit [86497] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

WebKit2: Smart cut&paste is broken
​https://bugs.webkit.org/show_bug.cgi?id=60840
<rdar://problem/9439927>

  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): Match WK1 - this default defaults to YES if not present.
1:48 PM Changeset in webkit [86496] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [86495] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

WKView does not draw after forced repaint before the first update
​https://bugs.webkit.org/show_bug.cgi?id=60845

Reviewed by Alice Liu.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint): Added.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint): Set m_hasReceivedFirstUpdate
to true, ensuring that paint() will wait for an update if needed.

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint): Call DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint().

1:00 PM Changeset in webkit [86494] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Document the WantsMozillaUserAgent quirk and make it Windows specific
​https://bugs.webkit.org/show_bug.cgi?id=60843

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::userAgent):
11:40 AM Changeset in webkit [86493] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-14 Arno Renevier <​arno@renevier.net>

Reviewed by Martin Robinson.

make run-gtk-tests executable
​https://bugs.webkit.org/show_bug.cgi?id=59278

  • Scripts/run-gtk-tests:
11:15 AM Changeset in webkit [86492] by dcheng@chromium.org
  • 1 edit
    3 copies in branches/chromium/742

Merge 85971 - ​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/7018002

11:10 AM Changeset in webkit [86491] by rniwa@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-05-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Make canHaveChildrenForEditing more efficient
​https://bugs.webkit.org/show_bug.cgi?id=53564

Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.

As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:

HTML: applet, br, embed, frame, frameset, hr (unless has children), img, input, keygen,

meter, object (unless uses fallback content), output, progress, select, and textarea.

No new tests are added since this change cannot be tested directly.

  • dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
  • dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
  • dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
  • dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
  • dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
  • editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
  • editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
  • html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
  • html/HTMLButtonElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
  • html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
  • html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
  • html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
  • html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
  • html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Added; returns true iff it has children.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::canContainRangeEndPoint): Added; returns true iff it uses fallback content.
11:10 AM Changeset in webkit [86490] by andersca@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/qt/Skipped:

Add plugins/get-url-notify-with-url-that-fails-to-load.html to the skipped list.

11:06 AM Changeset in webkit [86489] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Consolidate plug-in creation parameters to a single struct
​https://bugs.webkit.org/show_bug.cgi?id=60839

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::create): (WebKit::PluginControllerProxy::PluginControllerProxy):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: Added. (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Added.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin):
  • PluginProcess/WebProcessConnection.h:
  • PluginProcess/WebProcessConnection.messages.in:
  • Scripts/webkit2/messages.py:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):
10:29 AM Changeset in webkit [86488] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

2011-05-14 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
​https://bugs.webkit.org/show_bug.cgi?id=60142

  • fullscreen/video-controls-override-expected.txt: Added.
  • fullscreen/video-controls-override.html: Added.

2011-05-14 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
​https://bugs.webkit.org/show_bug.cgi?id=60142

Create a queue of elements who must be targeted with webkitfullscreenchange events. Instead of dispatching
a single event with whatever the current value of m_fullScreenElement is (which may have been cleared, or
changed since the timer was asked to fire), dispatch one event for each entry in the queue.

Test: fullscreen/video-controls-override.html

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Push current full screen element onto the

webkitfullscreenchange event delay queue.

(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::fullScreenElementRemoved): Ditto.
(WebCore::Document::fullScreenChangeDelayTimerFired): Empty the queue, dispatching a

webkitfullscreenchange event for each entry.

  • dom/Document.h:
9:31 AM Changeset in webkit [86487] by andersca@apple.com
  • 10 edits
    3 adds in trunk

2011-05-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

2011-05-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

  • platform/gtk/Skipped: Add test to Skipped list since it apparently crashes.
  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

9:17 AM Changeset in webkit [86486] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-14 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

Flashing window frame and graphical glitches after exiting full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=60825

A layer-backed WebView throws an exception when moved from a layer-backed parent view
to a non-layer-backed one, so make the WebView a child of the content view, instead of
the animation view. There is an unrelated fix in beganExitFullScreen, which was calling
finishedExitFullScreenAnimation: instead of finishedEnterFullScreenAnimation: when
notifications come out of order.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Add the _webView

to the full screen window's content view, instead of the _animationView.

(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Call

finishedEnterFullScreenAnimation: instead of finishedExitFullScreenAnimation:.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): Add the

_layerHostingView to the contentView, instead of the animationView.

7:56 AM Changeset in webkit [86485] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Buildfix for SharedTimerWx.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60829

  • platform/wx/SharedTimerWx.cpp: (WebCore::WebKitTimer::WebKitTimer): We can't call the constructor of a base class in the body of the constructor.
2:39 AM Changeset in webkit [86484] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r86477.

Remove the global namespace prefix from GlobalLock/GlobalUnlock.

  • platform/win/ClipboardUtilitiesWin.cpp:
1:48 AM Changeset in webkit [86483] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]fast/events/remove-target-in-mouseup* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=60833

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60834

  • platform/qt/Skipped: Add failing tests.
1:02 AM Changeset in webkit [86482] by Csaba Osztrogonác
  • 66 edits in trunk/Source

Unreviewed, rolling out r86469 and r86471, because they made hundreds tests crash on Qt.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

Source/JavaScriptCore:

(JSC::DebuggerActivation::visitChildren):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

  • runtime/Executable.h:

(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

  • runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):

  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC::Structure::createStructure):
(JSC::JSCell::classInfo):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrier::WriteBarrier):

  • wtf/Assertions.h:

Source/WebCore:

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildren):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::invalidate):
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

12:24 AM Changeset in webkit [86481] by Csaba Osztrogonác
  • 9 edits
    3 deletes in trunk

Unreviewed, rolling out r86476.
​http://trac.webkit.org/changeset/86476
​https://bugs.webkit.org/show_bug.cgi?id=60832

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-05-14
It made plugins/get-url-notify-with-url-that-fails-to-
load.html crash on GTK (Requested by Ossy on #webkit).

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::stop):
(WebKit::NetscapePluginStream::notifyAndDestroyStream):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Removed.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Removed.

May 13, 2011:

10:22 PM Changeset in webkit [86480] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • ewk/ewk_history.cpp:
9:42 PM Changeset in webkit [86479] by dcheng@chromium.org
  • 1 edit
    3 deletes in branches/chromium/742

Revert 86470 - Merge 85971 - ​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/6973064

TBR=​dcheng@chromium.org
Review URL: ​http://codereview.chromium.org/6973070

9:20 PM Changeset in webkit [86478] by ap@apple.com
  • 5 edits
    3 adds in trunk

2011-05-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
​https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

  • http/tests/appcache/interrupted-update-expected.txt: Added.
  • http/tests/appcache/interrupted-update.html: Added.
  • http/tests/appcache/resources/interrupted-update.manifest: Added.
  • http/tests/appcache/main-resource-redirect.html:
  • http/tests/appcache/non-html.xhtml: Now that we dispatch an error even when aborting a load due to navigation, error event handler was getting called after notifyDone().

2011-05-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
​https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

Test: http/tests/appcache/interrupted-update.html

The reason was two-fold:
1) Cache group state wasn't fully reset after a failed cache update (or an initial load).
2) The cache group is not deleted until after after the navigation (from autorelease pool),
so the failed and sorry old version was picked up by cache selection algorithm.

The latter is more of a surprising behavior than a problem in itself. Keeping an appcache in
memory for reload is generally a good thing for performance.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Added a FIXME about half-baked state resetting code that sent me looking for a wrong fix originally. (WebCore::ApplicationCacheGroup::stopLoadingInFrame): Stopped load is an update failure like any other, so we should call cacheUpdateFailed(), which knows how to reset state.
6:18 PM Changeset in webkit [86477] by enrica@apple.com
  • 13 edits in trunk/Source

REGRESSION (WK2): Can't drag and drop a link or image from Safari to Desktop
​https://bugs.webkit.org/show_bug.cgi?id=60819
<rdar://problem/9370689>

Reviewed by Darin Adler and Brian Weinstein.

Source/WebCore:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.
It also fixes a regression introduced by r70914, that was causing the content of the
shortcut files to be corrupted. Using ascii() to convert from String to CString was
causing '\n' and '\r' to be replaced with '?'.

  • platform/DragData.h:
  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fileDescriptorFormat): Moved from ClipboardWin.cpp.
(WebCore::fileContentFormatZero): Moved from ClipboardWin.cpp.
(WebCore::getFileDescriptorData): Serialize FileDescriptor type.
(WebCore::getFileContentData): Serialize FileContent type.
(WebCore::setFileDescriptorData): Deserialize FileDescriptor type.
(WebCore::setFileContentData): Deserialize FileContent type.
(WebCore::setCFData): Added missing initialization of the tymed field
that was causing the cfHDrop format not to be deserialized correctly.

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::createGlobalHDropContent): Changed ascii() to latin1().
(WebCore::ClipboardWin::writeURL):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::getDragFileDescriptorData):
(WebCore::DragData::getDragFileContentData):

Source/WebKit2:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.

  • Platform/CoreIPC/Arguments.h: Added support for messages with 10 arguments.

(CoreIPC::Arguments10::Arguments10):
(CoreIPC::Arguments10::encode):
(CoreIPC::Arguments10::decode):
(CoreIPC::In):
(CoreIPC::Out):

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added support for memebers with 10 arguments.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startDragDrop):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp:

(WebKit::WebDragClient::startDrag):

6:05 PM Changeset in webkit [86476] by andersca@apple.com
  • 9 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
​https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

5:55 PM Changeset in webkit [86475] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Daniel Cheng <​dcheng@chromium.org>

Fix the build.

Add includes that the builders are suddenly complaining about...

  • page/DragState.h:
5:24 PM Changeset in webkit [86474] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Disable failing test on chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
5:03 PM Changeset in webkit [86473] by msaboff@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-13 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Backing store may not get discarded due to stopped timer
​https://bugs.webkit.org/show_bug.cgi?id=60816

Changed the backing store timer to restart if it has been stopped.
The evaluation is done when the view's state is changed.
This change appears to be worth ~3MB (one backing store worth)
during memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
4:31 PM Changeset in webkit [86472] by dcheng@chromium.org
  • 9 edits
    2 adds in trunk

2011-05-13 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
​https://bugs.webkit.org/show_bug.cgi?id=59409

Add a new test to test drag start edge cases on Mac (because of a non-zero text drag delay)
as well as rebase an existing test.

  • fast/css/user-drag-none.html: Text nodes are no longer draggable.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt: Added.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html: Added.

2011-05-13 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
​https://bugs.webkit.org/show_bug.cgi?id=59409

Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
defined in the spec. Among other things:

  • draggableNode() no longer returns text nodes when dragging anchors.
  • When starting a drag over an image in a selection, prefer to drag the selection.
  • Several redundant hit tests have been removed.
  • Minor refactoring to make the logic easier to follow.

Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html

  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::startDrag):
  • page/DragController.h:
  • page/DragState.h: (WebCore::DragState::shouldDispatchEvents):
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateDragSourceActionsAllowed): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::ExactlyOneBitSet): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
4:16 PM Changeset in webkit [86471] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

4:09 PM Changeset in webkit [86470] by dcheng@chromium.org
  • 1 edit
    3 copies in branches/chromium/742

Merge 85971 - ​https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/6973064

4:07 PM Changeset in webkit [86469] by oliver@apple.com
  • 66 edits in trunk/Source

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSCell.cpp: (JSC::slowValidateCell):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
  • runtime/Structure.h: (JSC::JSCell::classInfo):
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
  • wtf/Assertions.h:

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
​https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):
3:56 PM Changeset in webkit [86468] by andersca@apple.com
  • 2 edits in trunk/Tools

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
3:37 PM Changeset in webkit [86467] by andersca@apple.com
  • 22 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
​https://bugs.webkit.org/show_bug.cgi?id=60810

In NetscapePluginStream::sendJavaScriptStream, we were incorrectly passing the result URL
to the stream, instead of the result. Also, store the request URL in the NetscapePluginStream object
to avoid sending it over the wire.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::didEvaluateJavaScript):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::loadURL): (WebKit::NetscapePlugin::didEvaluateJavaScript): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::NetscapePluginStream): (WebKit::NetscapePluginStream::sendJavaScriptStream):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h: (WebKit::NetscapePluginStream::create):
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::didEvaluateJavaScript):
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest):

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
​https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • plugins/get-url-with-javascript-url-expected.txt: Added.
  • plugins/get-url-with-javascript-url.html: Added.

2011-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
​https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am: Add files.
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added. (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL): (GetURLWithJavaScriptURL::NPP_New): (GetURLWithJavaScriptURL::NPP_NewStream): (GetURLWithJavaScriptURL::NPP_DestroyStream): (GetURLWithJavaScriptURL::NPP_WriteReady): (GetURLWithJavaScriptURL::NPP_Write):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_URLNotify): call the PluginTest NPP wrappers.
3:32 PM Changeset in webkit [86466] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: remove objectstore
​https://bugs.webkit.org/show_bug.cgi?id=60768

This test creates an objectstore, populates it with 100 records,
deletes the objectstore, and checks that the objectStoreNames array
is updated properly at each step.

  • storage/indexeddb/mozilla/remove-objectstore-expected.txt: Added.
  • storage/indexeddb/mozilla/remove-objectstore.html: Added.
3:30 PM Changeset in webkit [86465] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Removed chromium border-fit-lines.html suppression as it seems to pass now. Unreviewed.

  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [86464] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
​http://trac.webkit.org/changeset/86447
​https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
​http://trac.webkit.org/changeset/86447
​https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
​http://trac.webkit.org/changeset/86447
​https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
3:00 PM Changeset in webkit [86463] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Mikhail Naganov <​mnaganov@chromium.org>

Web Inspector: Unreviewed image glyph position fix in CSS after r85588.

  • inspector/front-end/heapProfiler.css: (.heapshot-help-status-bar-item .glyph):
2:48 PM HighLevelOverview edited by levin@chromium.org
(diff)
2:44 PM Changeset in webkit [86462] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
​https://bugs.webkit.org/show_bug.cgi?id=60784

Test that we block popup windows from inside sandbox.

  • http/tests/security/no-popup-from-sandbox-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top.html: Added.
  • http/tests/security/no-popup-from-sandbox.html: Added.

2011-05-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
​https://bugs.webkit.org/show_bug.cgi?id=60784

Previously, we weren't implementing this requirement from the spec:

"This flag also prevents content from creating new auxiliary browsing
contexts, e.g. using the target attribute or the window.open() method."

Tests: http/tests/security/no-popup-from-sandbox-top.html

http/tests/security/no-popup-from-sandbox.html

  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::checkNewWindowPolicy):
2:35 PM Changeset in webkit [86461] by rniwa@webkit.org
  • 5 edits
    8 adds in trunk

2011-05-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
​https://bugs.webkit.org/show_bug.cgi?id=60600

Added tests to ensure WebKit does not fire click event when the target node
is removed in mouseup event.

  • fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-deep.html: Added.
  • fast/events/remove-target-in-mouseup-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback.html: Added.
  • fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-twice.html: Added.
  • fast/events/remove-target-in-mouseup.html: Added.

2011-05-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
​https://bugs.webkit.org/show_bug.cgi?id=60600

Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
from the document. New behavior matches Internet Explorer and Firefox.

Tests: fast/events/remove-target-in-mouseup-deep.html

fast/events/remove-target-in-mouseup-insertback.html
fast/events/remove-target-in-mouseup-twice.html
fast/events/remove-target-in-mouseup.html

  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved. (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
  • page/EventHandler.cpp: (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode or one of its ancestor is removed from the document.
  • page/EventHandler.h:
1:59 PM Changeset in webkit [86460] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Joseph Pecoraro.

Hide appcache status bar items
​https://bugs.webkit.org/show_bug.cgi?id=60799

We have a number of non-trivial bugs that make these more misleading than helpful to developers.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): Just hide the items for now. Removing all support code would be complicated, and not helpful.
1:46 PM Changeset in webkit [86459] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-05-13 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Make some page() member functions const
​https://bugs.webkit.org/show_bug.cgi?id=60794

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Make page() const.
  • UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::page): Make page() const.
  • UIProcess/WebInspectorProxy.h: (WebKit::WebInspectorProxy::page): Make page() const.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
1:40 PM Changeset in webkit [86458] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
​https://bugs.webkit.org/show_bug.cgi?id=60785

  • http/tests/security/no-indexeddb-from-sandbox-expected.txt: Added.
  • http/tests/security/no-indexeddb-from-sandbox.html: Added.

2011-05-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
​https://bugs.webkit.org/show_bug.cgi?id=60785

We're supposed to return a null indexedDB factory when inside an iframe
sandbox.

Test: http/tests/security/no-indexeddb-from-sandbox.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
1:22 PM Changeset in webkit [86457] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: indexes with keys and key ranges
​https://bugs.webkit.org/show_bug.cgi?id=60733

This megatest creates an object store with several rows of data,
creates indexes on each key, then iterates each index in a variety
of ways (keys, key ranges, etc).

  • storage/indexeddb/mozilla/indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/indexes.html: Added.
12:54 PM Changeset in webkit [86456] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Load plugins in the order they're found

Fixes <​http://webkit.org/b/60788> <rdar://problem/9435787> REGRESSION (r69790): WebKit2
doesn't prefer plugins in the additional plugins directory

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::addFromVector):
Changed to use a ListHashSet instead of a HashSet to store the plugin paths.

12:54 PM Changeset in webkit [86455] by Adam Roben
  • 4 edits in trunk/Source/WebCore

Fix manual tests that got broken by the move of WebCore into Source

  • manual-tests/plugins/object-clipping.html:
  • manual-tests/pointer-events.html:
  • manual-tests/video-waiting-seeking.html:

Updated some paths.

12:48 PM Changeset in webkit [86454] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-13 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=60738

Remove supression for previously failing compositor tests.

  • platform/chromium/test_expectations.txt:

2011-05-13 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=60738

Bind texture before setting its filtering state.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateFromPixels):
12:40 PM Changeset in webkit [86453] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=60787
Add some assertions to ApplicationCacheGroup

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto. (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before resetting it. (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or resource hanging around. (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
12:28 PM Changeset in webkit [86452] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-13 Tao Bai <​michaelbai@chromium.org>

Reviewed by Darin Fisher.

Handle the touch icon.
​https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added method iconURLs() to specify the type of icon need to return.
The favIconURL() is deprecated and will be removed later.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL): (WebKit::WebIconURL::iconType): (WebKit::WebIconURL::iconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
12:09 PM Changeset in webkit [86451] by weinig@apple.com
  • 64 edits
    1 add in trunk/Source

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • src/AutoFillPopupMenuClient.cpp:
  • src/PlatformBridge.cpp:
  • src/WebPopupMenuImpl.cpp:

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • Api/qgraphicswebview.cpp:
  • WebCoreSupport/ChromeClientQt.cpp:

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/GtkAdjustmentWatcher.cpp:

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebDragClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebFrame.cpp: (WebFrame::setPrinting):
  • WebView.cpp:

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebView/WebClipView.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Replace #includes in FrameView.h of Frame.h and Page.h with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityScrollView.cpp:
  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • css/MediaQueryMatcher.cpp:
  • dom/Range.cpp:
  • editing/SpellingCorrectionController.cpp:
  • history/CachedFrame.cpp:
  • html/HTMLBodyElement.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/parser/HTMLParserScheduler.cpp:
  • page/AdjustViewSizeOrNot.h: Added.
  • page/EditorClient.h:
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
  • page/FrameView.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
  • page/chromium/FrameChromium.cpp:
  • page/win/FrameCGWin.cpp:
  • page/win/FrameWin.cpp:
  • platform/efl/PopupMenuEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/gtk/WidgetGtk.cpp:
  • plugins/IFrameShimSupport.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderFrameBase.cpp:
  • rendering/RenderIFrame.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderWidget.cpp:
  • svg/SVGSVGElement.cpp:

2011-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
11:21 AM Changeset in webkit [86450] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress crasher in chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
11:21 AM Changeset in webkit [86449] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-13 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCollapsedBorder to use IntRect
​https://bugs.webkit.org/show_bug.cgi?id=60739

Updating the last offending paint function that takes four ints
instead of an IntRect.

No new tests as this is simple refactoring.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
11:17 AM Changeset in webkit [86448] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r75823): Revert initialization back to the first RenderBlock
in the parent chain.
​https://bugs.webkit.org/show_bug.cgi?id=60780

Test: fast/block/float/float-not-removed-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): In r75823, I forgot to initialize parentBlock, when the original code did and Hyatt did mention in c#5. Now, initializing parentBlock to the first RenderBlock in the parent chain.

2011-05-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to access a deleted float.
​https://bugs.webkit.org/show_bug.cgi?id=60780

  • fast/block/float/float-not-removed-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-crash.html: Added.
11:11 AM Changeset in webkit [86447] by robert@webkit.org
  • 9 edits
    2 adds in trunk

2011-05-13 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-13 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
​https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Robert Hogan <​robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

​https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
11:00 AM Changeset in webkit [86446] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-05 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TextEditor should support editing a range.
​https://bugs.webkit.org/show_bug.cgi?id=59688

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype.setEditableRange): (WebInspector.TextEditorMainPanel.prototype.clearEditableRange): (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.set readOnly): (WebInspector.TextEditorMainChunk.prototype.get readOnly): (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
  • inspector/front-end/textViewer.css: (.text-editor-read-only):
10:36 AM Changeset in webkit [86445] by Adam Roben
  • 3 edits in trunk/Tools

Exclude the Leopard NRWT bot from the core builder set

Fixes <​http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
in the core builder set.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
regexps.

10:36 AM Changeset in webkit [86444] by Adam Roben
  • 2 edits in trunk/Tools

Group all the NRWT bots together

This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
bots are experimental, it seems best not to clutter up the non-experimental bots with
experimental ones.

Fixes <​http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
on build.webkit.org

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the

Chromium testers, which also use new-run-webkit-tests.

10:25 AM Changeset in webkit [86443] by podivilov@chromium.org
  • 7 edits in trunk

2011-05-05 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
​https://bugs.webkit.org/show_bug.cgi?id=60263

  • inspector/debugger/resources/obfuscated.js: (formatted1): (formatted2):
  • inspector/debugger/script-formatter.html:

2011-05-05 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
​https://bugs.webkit.org/show_bug.cgi?id=60263

Source mapping is broken for script chunks that are already formatted at the beginning
and at the end of the script (see script-formatter.html).

  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype._didFormatContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.originalToFormatted): (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage): (HTMLScriptFormatter.prototype.format):
  • inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.SourceMappingForFormattedSourceFile): (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine): (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
10:24 AM Changeset in webkit [86442] by Adam Roben
  • 5 edits
    5 adds in trunk

Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect changes

r79167 moved some code from setFrameRect to setBoundsSize, including a call to
frameRectsChanged. This was done because positionScrollbarLayers, which is called by
frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
frame rect changes.

This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
to be called at different times from frameRectsChanged. Then it restores the
frameRectsChanged call to setFrameRect, which fixes the bug.

Test: platform/win/plugins/iframe-inside-overflow.html

Fixes <​http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
plugins in Google Reader don't move when the article list is scrolled

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
call frameRectsChanged here when our frame rect hasn't changed.
(WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
in r79167.
(WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
positionScrollbarLayers to be called.
(WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.

Tools:

Add a plugin test that dumps the plugin window's rect

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.

(DumpWindowRect::DumpWindowRect): Just call up to the base class.
(DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
harness window and log it.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.

LayoutTests:

Add a test for windowed plugins inside iframes inside scrolled overflow areas

  • platform/win/plugins/iframe-inside-overflow-expected.txt: Added.
  • platform/win/plugins/iframe-inside-overflow.html: Added.

(loaded): Scrolls the div and tells the plugin to start its test (which will cause its
window rect to be logged).

  • platform/win/plugins/resources/dump-window-rect-iframe.html: Added.
10:24 AM Changeset in webkit [86441] by Adam Roben
  • 3 edits
    2 adds in trunk/Tools

Move code required for most tests of plugin window geometry into a base class

WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
having all the trickiness in a shared base class, writing new window geometry tests will be
much easier.

Fixes <​http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
WindowGeometryTest base class. Most of the code from this class was moved to the new base
class.
(WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
This is called by the base class when it is safe to check the window's geometry. Note that
the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
just vestigial code from an earlier version of this test.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new

WindowGeometryTest class.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from

WindowRegionIsSetToClipRect.
(WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
Subclasses can implement that function to perform their own tests.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
9:58 AM Changeset in webkit [86440] by robert@webkit.org
  • 3 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

2011-05-02 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

Make fast/dom/object-embed-plugin-scripting.html compatible with non-Mac ports

​https://bugs.webkit.org/show_bug.cgi?id=59930

  • fast/dom/resources/articles.m4a: Removed.
  • platform/chromium/test_expectations.txt: Unskip object-embed-plugin-scripting.html on Linux
  • platform/qt/Skipped: Unskip object-embed-plugin-scripting.html
  • plugins/object-embed-plugin-scripting-expected.txt: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting-expected.txt.
  • plugins/object-embed-plugin-scripting.html: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting.html.
  • plugins/resources/apple.gif: Added.
9:56 AM Changeset in webkit [86439] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-13 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth.

Don't destroy a null FcPattern when failing to do a FontConfig match.
This crashes, and there's nothing FcDestroy could do with a null
pointer even if it didn't crash.
​https://bugs.webkit.org/show_bug.cgi?id=60777

  • src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
9:55 AM Changeset in webkit [86438] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC.

Reviewed by nobody, build fix.

qobject_cast<> requires the class to be exported on MSVC,
removing it since the code that needs it is commented out for
the same reason.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::elementAreaAt):

9:54 AM Changeset in webkit [86437] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.

Reviewed by nobody, build fix.

  • tests/tests.pro:
9:40 AM HighLevelOverview edited by levin@chromium.org
(diff)
9:22 AM SourceDirectory created by levin@chromium.org
9:00 AM Changeset in webkit [86436] by Martin Robinson
  • 8 edits
    2 adds in trunk/Source

2011-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59765

Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
almost directly moved from the WebKit layer.

No new tests. This is covered by the editing tests.

  • GNUmakefile.list.am:
  • platform/gtk/KeyBindingTranslator.cpp: Added. (WebCore::backspaceCallback):Added. (WebCore::selectAllCallback):Added. (WebCore::cutClipboardCallback):Added. (WebCore::copyClipboardCallback):Added. (WebCore::pasteClipboardCallback):Added. (WebCore::toggleOverwriteCallback):Added. (WebCore::popupMenuCallback):Added. (WebCore::showHelpCallback):Added. (WebCore::deleteFromCursorCallback):Added. (WebCore::moveCursorCallback):Added. (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added. (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
  • platform/gtk/KeyBindingTranslator.h: Added. (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.

2011-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that the command vector now contains WTF::string. (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class. (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.

2011-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code. (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
  • UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
9:00 AM Changeset in webkit [86435] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-13 Steve VanDeBogart <​vandebo@chromium.org>

Unreviewed.

Update expectations for GPU tests that use shadows after fix (Skia rev 1297).
​https://bugs.webkit.org/show_bug.cgi?id=60742

  • platform/chromium/test_expectations.txt:
8:26 AM Changeset in webkit [86434] by zherczeg@webkit.org
  • 3 edits in trunk/Tools

2011-05-13 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Csaba Osztrogonác.

Missing 2nd #EOF if WebProcess is killed.
​https://bugs.webkit.org/show_bug.cgi?id=60761

If the WebProcess is killed, only one #EOF is yielded
by WebKitTestRunner. However, run-webkit-test wait for
a second #EOF, which signals the finishing of pixel dump.
Since this never happens, run-webkit-test waits forever.

  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
8:09 AM Changeset in webkit [86433] by zecke@webkit.org
  • 3 edits in trunk/Source/WebCore

[android] Forward declare types for PlatformWidget and DragImage

​https://bugs.webkit.org/show_bug.cgi?id=59890

This is fixing the compilation of files that include Widget.h or
DragImage.h.

8:09 AM Changeset in webkit [86432] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[android] OS(ANDROID) does not imply PLATFORM(ANDROID)

​https://bugs.webkit.org/show_bug.cgi?id=59888

It is possible to build QtWebKit and others for OS(ANDROID). Let
the buildsystem decide which platform is to be build.

7:59 AM Changeset in webkit [86431] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped: Add 4 failing tests.
7:56 AM Changeset in webkit [86430] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-06 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix incremental html highlight.
​https://bugs.webkit.org/show_bug.cgi?id=60163

SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
initialCondition object via condition link). This all worked because of another bug in tokenizers registry
that always returned new tokenizer object.
For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
state from string. That's why we need tokenizers to be truly stateless.

  • inspector/front-end/DOMSyntaxHighlighter.js: (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._highlightLines):
7:48 AM Changeset in webkit [86429] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[NRWT] chromium-linux tests shouldn't run on other platforms
​https://bugs.webkit.org/show_bug.cgi?id=60162

Patch by Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-13
Reviewed by Csaba Osztrogonác.

Remove _tests_for_other_platforms defs because r82753
implemented it properly in the baseclass in webkit.py.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
7:38 AM Changeset in webkit [86428] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Build fix after r86418

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Made the destructor public so that this class can be used with
[Pass]OwnPtr.

7:32 AM Changeset in webkit [86427] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped:
7:00 AM Changeset in webkit [86426] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
6:29 AM Changeset in webkit [86425] by hans@chromium.org
  • 4 edits in trunk/Source

2011-05-11 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
​https://bugs.webkit.org/show_bug.cgi?id=60623

Fix the code for comparing two int64_t variables.
Also remove faulty line in ObjectStoreNamesKey::encode which was
uncovered by the unit test in this patch.

Very hard to cover with layout tests; covered by unit test.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::compareInts): (WebCore::IDBLevelDBCoding::KeyPrefix::compare): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): (WebCore::IDBLevelDBCoding::IndexDataKey::compare):

2011-05-11 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
​https://bugs.webkit.org/show_bug.cgi?id=60623

Unit test for comparison of encoded keys.

  • tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
5:08 AM Changeset in webkit [86424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Darin Adler.

GraphicsContext3DQt.cpp fails to compile
​https://bugs.webkit.org/show_bug.cgi?id=60740

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Change order of initializers.
3:34 AM Changeset in webkit [86423] by antonm@chromium.org
  • 1 edit
    23 adds in trunk/LayoutTests

2011-02-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
​https://bugs.webkit.org/show_bug.cgi?id=53611

This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.

Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
  • dom/Document.h:
3:21 AM Changeset in webkit [86422] by hans@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-05 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
​https://bugs.webkit.org/show_bug.cgi?id=60032

Add test for veryfing that transaction roll-back works, even with a
previously opened cursor still around.

  • storage/indexeddb/transaction-rollback-expected.txt: Added.
  • storage/indexeddb/transaction-rollback.html: Added.

2011-05-05 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
​https://bugs.webkit.org/show_bug.cgi?id=60032

Let the IDBTransactionbackendImpl keep track of all open cursors, and
"close" them (i.e. finalizing the underlying SQLiteStatement) before
committing or rolling back the transaction. This fixes the problem
with opened cursors preventing transaction rollback.

Test: storage/indexeddb/transaction-rollback.html

  • storage/IDBBackingStore.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::close):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBSQLiteBackingStore.cpp:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::registerOpenCursor): (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h: (WebCore::IDBTransactionBackendInterface::registerOpenCursor): (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):

2011-05-05 Hans Wennborg <​hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
​https://bugs.webkit.org/show_bug.cgi?id=60032

Implement two new methods in IDBTransactionBackendInterface.

  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::registerOpenCursor): (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
  • src/IDBTransactionBackendProxy.h:
2:56 AM Changeset in webkit [86421] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move ewk_view_dpi_get() to ewk_util.cpp
​https://bugs.webkit.org/show_bug.cgi?id=60753

Move ewk_view_dpi_get() to ewk_util.cpp

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp: (ewk_util_dpi_get):
  • ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute):
1:39 AM Changeset in webkit [86420] by sergio@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r86352.

  • platform/gtk/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/gtk/svg/custom/stroke-opacity-update-expected.txt: Added.
1:29 AM Changeset in webkit [86419] by sergio@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, new GTK+ test expectations.

  • platform/gtk/fast/borders/outline-alpha-block-expected.png:
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.png:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-update-expected.png:
  • platform/gtk/svg/custom/fill-opacity-update-expected.txt:
12:37 AM Changeset in webkit [86418] by Patrick Gansterer
  • 21 edits in trunk/Source

2011-05-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::loadWithNextMediaEngine):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::create):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

2011-05-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h:
12:20 AM Changeset in webkit [86417] by ap@apple.com
  • 11 edits in trunk

2011-05-13 Alexey Proskuryakov <​ap@apple.com>

Unreviewed test changes.

Web Inspector: Show Error Messages for Application Cache Errors
​https://bugs.webkit.org/show_bug.cgi?id=41642

  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:

2011-05-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Pavel Feldman.

Web Inspector: Show Error Messages for Application Cache Errors
​https://bugs.webkit.org/show_bug.cgi?id=41642

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota): Added console error logging.
Note: See TracTimeline for information about the timeline view.