Context Navigation

← Previous Period
Next Period →

Timeline

Jul 31, 2011:

11:05 PM Changeset in webkit [92101] by abarth@webkit.org

4 edits
1 delete in trunk/LayoutTests

These results appear to differ only in text rendering.

platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:

10:36 PM Changeset in webkit [92100] by abarth@webkit.org

1 edit
10 adds in trunk/LayoutTests

Adding expected results. These results appear to differ only in the scrollbar.

platform/chromium-linux/svg/custom/external-paintserver-reference-expected.png: Added.
platform/chromium-linux/svg/custom/linking-base-external-reference-expected.png: Added.
platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
platform/chromium-mac/svg/custom/external-paintserver-reference-expected.txt: Added.
platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
platform/chromium-mac/svg/custom/linking-base-external-reference-expected.txt: Added.
platform/chromium-win/svg/custom/external-paintserver-reference-expected.png: Added.
platform/chromium-win/svg/custom/external-paintserver-reference-expected.txt: Added.
platform/chromium-win/svg/custom/linking-base-external-reference-expected.png: Added.
platform/chromium-win/svg/custom/linking-base-external-reference-expected.txt: Added.

10:33 PM Changeset in webkit [92099] by abarth@webkit.org

2 edits in trunk/LayoutTests

Update baseline. This patch might cause Linux to start failing, but in
that case, we can add a more specific Linux result. This approach is
somewhat of an exploration of this automated rebaselining algorithm.

platform/chromium-win/svg/batik/text/textLength-expected.txt:

9:25 PM Changeset in webkit [92098] by commit-queue@webkit.org

3 edits
2 deletes in trunk

Unreviewed, rolling out r92094.
http://trac.webkit.org/changeset/92094
https://bugs.webkit.org/show_bug.cgi?id=65443

Triggered many asserts (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-31

Source/WebCore:

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

LayoutTests:

fast/events/event-target-reset-expected.txt: Removed.
fast/events/event-target-reset.html: Removed.

9:17 PM Changeset in webkit [92097] by andersca@apple.com

2 edits in trunk/Tools

DownloadDecideDestinationCrash WebKit2 API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=65442

Reviewed by Sam Weinig.

Copy the 18-characters.html file to the destination directory so we won't
crash trying to make an URL for it.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

9:10 PM Changeset in webkit [92096] by andersca@apple.com

2 adds in trunk/Tools/TestWebKitAPI

Add forgotten files.

8:32 PM Changeset in webkit [92095] by andersca@apple.com

8 edits in trunk/Tools

Fix SpacebarScrolling WebKit2 API test
https://bugs.webkit.org/show_bug.cgi?id=65431

Reviewed by Sam Weinig.

Add a way to do platform-specific bundle initialization, and use it to disable smooth
scrolling. Also make it possible for a test to load the injected bundle without actually running
a test from it.

TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

TestWebKitAPI/InjectedBundleController.h:
TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):

TestWebKitAPI/PlatformUtilities.h:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.

(TestWebKitAPI::InjectedBundleController::platformInitialize):

TestWebKitAPI/win/TestWebKitAPI.vcproj:

7:53 PM Changeset in webkit [92094] by dominicc@chromium.org

3 edits
2 adds in trunk

Event target set to null post event dispatch
https://bugs.webkit.org/show_bug.cgi?id=63934

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/event-target-reset.html

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Reset target to outermost
shadow host.

LayoutTests:

fast/events/event-target-reset-expected.txt: Added.
fast/events/event-target-reset.html: Added.

6:50 PM Changeset in webkit [92093] by barraclough@apple.com

6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.

Unreviewed - rolling out r91290.

Source/JavaScriptCore:

Looks like the wild wild web isn't ready for this yet.

This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling Array.prototype.slice as a part
of its bind implementation.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Checking in failing results - we can't fix this bug just yet
for web compatibility reasons.

fast/js/array-prototype-properties-expected.txt:
ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:

4:48 PM Changeset in webkit [92092] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437

Reviewed by Oliver Hunt.

Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words. This is a 1% win on SunSpider.

heap/MarkedBlock.h:

4:17 PM Changeset in webkit [92091] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix fast/dom/Range/getBoundingClientRect.html after r92089.

fast/dom/Range/getBoundingClientRect.html:

2:14 PM Changeset in webkit [92090] by rniwa@webkit.org

2 edits in trunk/LayoutTests

[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty-list-item.html are slow/timeout
https://bugs.webkit.org/show_bug.cgi?id=65019

This bug was invalid; neither test is slow nor timing out.

platform/chromium/test_expectations.txt:

2:05 PM Changeset in webkit [92089] by weinig@apple.com

7 edits in trunk

REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update to more closely match the spec.

dom/Range.cpp:

(WebCore::Range::getClientRects):
Return an empty ClientRectList instead of null when the range is empty.

(WebCore::Range::getBoundingClientRect):
Always return a ClientRect, even for an empty bounding rect.

LayoutTests:

fast/dom/Range/getBoundingClientRect-expected.txt:
fast/dom/Range/getBoundingClientRect.html:
fast/dom/Range/getClientRects-expected.txt:
fast/dom/Range/getClientRects.html:

Add test cases for empty and collapsed ranges.

1:44 PM Changeset in webkit [92088] by rniwa@webkit.org

10 edits
2 copies
4 adds in trunk

[HTML5] Implement the selectionDirection property on input and textarea
https://bugs.webkit.org/show_bug.cgi?id=60403

Reviewed by Darin Adler.

Source/WebCore:

Implements selectionDirection property as specified in HTML5 section 4.10.20:
http://www.whatwg.org/specs/web-apps/current-work/#textFieldSelection

selectionDirection is a property on input and textarea elements, which, on getting returns either "none",
"forward", or "backward" corresponding to the current selection direction, and on setting, modifies
the direction of the current selection. When selection doesn't exist or direction is unknown, "none"
is returned on getting. Setting the property value to neither of above values will result in setting "none".

This patch also adds the optional third argument, direction, to setSelectionRange.

Test: fast/forms/selection-direction.html

fast/forms/selection-wrongtype.html

bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::selectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionRange): Processes the third argument.

bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter): Added.
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter): Added.
(WebCore::V8HTMLInputElement::setSelectionRangeCallback): Processes the third argument.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance): Calls hasCachedSelection.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
(WebCore::HTMLInputElement::setValue): Calls cacheSelection with SelectionHasNoDirection.

html/HTMLTextAreaElement.idl: Added selectionDirection and the third argument to setSelectionRange.
html/HTMLInputElement.idl: Ditto.
html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initializes
m_cachedSelectionDirection.
(WebCore::HTMLTextFormControlElement::setSelectionStart): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
(WebCore::HTMLTextFormControlElement::setSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::select): Calls setSelectionRange with SelectionHasNoDirection.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Added the version that takes direction
string as the third argument, which calls the version that takes two ints and TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::directionString): Added.
(WebCore::HTMLTextFormControlElement::selectionDirection): Added.
(WebCore::HTMLTextFormControlElement::computeSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::selection): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls cacheSelection.

html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Takes TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::hasCachedSelection): Extracted from hasCachedSelectionStart;
cacheSelection is the only function that modifies m_cacheSelectionStart and m_cacheSelectionEnd
and none of its callers ever set one of them be -1 so they are always both -1 or both non-negative.
Thus, having two separate functions for m_cacheSelectionStart and m_cacheSelectionEnd was redundant.

LayoutTests:

Added a test to ensure WebKit sets and gets selectionDirection property.

Also added a test to ensure WebKit throws exceptions when retrieving or assigning values to selectionStart,
selectionEnd, and selectionDirection property of the input element when the element isn't a text field.

fast/forms/selection-direction-expected.txt: Added.
fast/forms/selection-direction.html: Added.
fast/forms/selection-wrongtype-expected.txt: Added.
fast/forms/selection-wrongtype.html: Added.
platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt; editing delegate change.

platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt since Windows port fallbacks to Mac.

1:40 PM Changeset in webkit [92087] by Dimitri Glazkov

3 edits in trunk/Tools

Use set comparison to find duplicate or overlapping specifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65430

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length

of a set is wrong.

Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch

regressions.

1:32 PM Changeset in webkit [92086] by mitz@apple.com

1 edit
2 adds in trunk/LayoutTests

Add expected results for Snow Leopard and earlier for fast/css/font-family-pictograph.html

Fixes REGRESSION (r91777): fast/css/font-family-pictograph.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65433

platform/mac-snowleopard/fast/css: Added.
platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Added.

1:13 PM Changeset in webkit [92085] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424

Reviewed by Gavin Barraclough.

Added code to emit PutByVal inline fast path.

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

12:03 PM Changeset in webkit [92084] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382

Reviewed by Oliver Hunt.

This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire. New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):

heap/Heap.h:
heap/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):

heap/MarkedBlock.h:
wtf/Platform.h:

9:30 AM Changeset in webkit [92083] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/chromium

[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
overload, and change the overload that takes WebURLLoaderOptions to
use a default value. This is equivalent to the original parameterless
overload.
https://bugs.webkit.org/show_bug.cgi?id=65280

Patch by Bill Budge <bbudge@chromium.org> on 2011-07-31
Reviewed by Darin Fisher.

public/WebFrame.h:
src/AssociatedURLLoader.cpp:
src/AssociatedURLLoader.h:
src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

1:48 AM Changeset in webkit [92082] by dbates@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
https://bugs.webkit.org/show_bug.cgi?id=65427

This variable was unused when it was initially added in <http://trac.webkit.org/changeset/89660> (bug #62718)
and it is unused today. We should remove it. This will also resolve a compiler warning.

Reviewed by Xan Lopez.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(getChildForTable):

1:34 AM Changeset in webkit [92081] by dbates@webkit.org

2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Add missing semicolons to build fix attempt in <http://trac.webkit.org/changeset/92080>.

Source/autotools/symbols.filter:

1:18 AM Changeset in webkit [92080] by dbates@webkit.org

2 edits in trunk

2011-07-31 Daniel Bates <dbates@webkit.org>

Some more fixes to the GTK build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

Source/autotools/symbols.filter: Export symbols needed by Internals.

1:06 AM Changeset in webkit [92079] by dbates@webkit.org

2 edits in trunk/Source/WebKit2

2011-07-31 Daniel Bates <dbates@webkit.org>

Try again to fix the WinCairo Debug build after r92059 ( https://bugs.webkit.org/show_bug.cgi?id=65419).

win/WebKit2CFLite.def: Export symbols needed by Internals.

12:37 AM Changeset in webkit [92078] by dbates@webkit.org

3 edits in trunk/Source/WebKit/win

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).

WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.

12:16 AM Changeset in webkit [92077] by xan@webkit.org

2 edits in trunk/Tools

2011-07-31 Xan Lopez <xlopez@igalia.com>

Group dependencies CFLAGS together.

GNUmakefile.am: ditto.

12:04 AM Changeset in webkit [92076] by dbates@webkit.org

2 edits in trunk/Tools

2011-07-31 Daniel Bates <dbates@webkit.org>

Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
(https://bugs.webkit.org/show_bug.cgi?id=65419).

GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.

Jul 30, 2011:

11:47 PM Changeset in webkit [92075] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30

DEPS:

11:44 PM Changeset in webkit [92074] by dbates@webkit.org

2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
(https://bugs.webkit.org/show_bug.cgi?id=64744)

WebCore.vcproj/WebCore.vcproj: Remove ContextShadowCairo.cpp from the build since this file was deleted in <http://trac.webkit.org/changeset/91914>.

11:36 PM Changeset in webkit [92073] by dbates@webkit.org

1 edit in trunk/Source/WebCore/ChangeLog

2011-07-30 Daniel Bates <dbates@webkit.org>

Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.

11:29 PM Changeset in webkit [92072] by dbates@webkit.org

2 edits in trunk/Source/WebCore

2011-07-30 Daniel Bates <dbates@webkit.com>

Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
(https://bugs.webkit.org/show_bug.cgi?id=65342)

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock() to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.

11:14 PM Changeset in webkit [92071] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421

Reviewed by Oliver Hunt.

Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

10:56 PM Changeset in webkit [92070] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the Windows build after r92059.

win/WebKit2.def: Export symbols needed by Internals.

9:46 PM Changeset in webkit [92069] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068

bindings/scripts/test/JS/JSTestCallback.cpp:

7:23 PM Changeset in webkit [92068] by Patrick Gansterer

112 edits in trunk/Source

Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add missing and remove unneeded include statements for MainThread.

wtf/CryptographicallyRandomNumber.cpp:
wtf/Threading.h:
wtf/ThreadingPthreads.cpp:
wtf/text/StringStatics.cpp:

Source/WebCore: