⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 17, 2011:

11:58 PM Changeset in webkit [93285] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r93268.

  • dom/Document.cpp:

(WebCore::disableRangeMutation):

11:37 PM Changeset in webkit [93284] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch RenderBox to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66156

Reviewed by Eric Seidel.

Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.

No new tests as no new functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):

11:34 PM Changeset in webkit [93283] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening

Patch by Balazs Kelemen <​kbalazs@webkit.org> on 2011-08-17

  • platform/qt/Skipped: Skip new failures.
9:47 PM Changeset in webkit [93282] by dslomov@google.com
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=66400
Fix TestWebKitAPI build on Mac OS.

Reviewed by David Levin.

  • TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
9:22 PM Changeset in webkit [93281] by sullivan@chromium.org
  • 6 edits in trunk/Source/WebCore

Reduce usages of String::createUninitialized
​https://bugs.webkit.org/show_bug.cgi?id=66399

Constructs Strings with StringBuilder instead of calling createUninitialized.

Reviewed by Adam Barth.

No new tests; no functional change.

  • dom/StyleElement.cpp:

(WebCore::StyleElement::process):

  • dom/Text.cpp:

(WebCore::Text::wholeText):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

  • platform/graphics/Font.cpp:

(WebCore::Font::normalizeSpaces):

  • platform/text/TextCodecUserDefined.cpp:

(WebCore::TextCodecUserDefined::decode):

9:06 PM Changeset in webkit [93280] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

Switch FrameView to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66147

Reviewed by Eric Seidel.

Convert Frame & FrameView to new layout abstraction as a part of the
ongoing conversion work.

No new tests, no new functionality.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::scalePage):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::reset):
(WebCore::FrameView::init):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setMarginWidth):
(WebCore::FrameView::setMarginHeight):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::scrollOffsetForFixedPosition):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

  • page/FrameView.h:

(WebCore::FrameView::marginWidth):
(WebCore::FrameView::marginHeight):

  • page/mac/FrameMac.mm:

(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):

8:38 PM Changeset in webkit [93279] by eae@chromium.org
  • 15 edits in trunk/Source/WebCore

Switch html/* to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66347

Reviewed by Eric Seidel.

Convert HTML* and shadow element to new layout abstraction as a part of
the ongoing conversion work.

No new tests, no new functionality.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::invalidateCachedRegion):
(WebCore::HTMLAreaElement::mapMouseEvent):
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::getRegion):

  • html/HTMLAreaElement.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/HTMLCanvasElement.h:
  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

  • html/HTMLMapElement.h:
  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::continueDrag):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::defaultEventHandler):

  • html/shadow/MediaControlElements.h:
  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::dragFrom):
(WebCore::SliderThumbElement::setPositionFromPoint):

  • html/shadow/SliderThumbElement.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

8:24 PM Changeset in webkit [93278] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Change references to leveldb.gyp to leveldatabase.gyp as part of the
leveldb refactoring going on in chromium: crbug.com/89378
​https://bugs.webkit.org/show_bug.cgi?id=66332

Patch by David Grogan <​dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Gentilcore.

Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb

  • WebCore.gyp/WebCore.gyp:
7:56 PM Changeset in webkit [93277] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=66379
implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.

Patch by Thouraya ANDOLSI <​thouraya.andolsi@st.com> on 2011-08-17
Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):

  • jit/JIT.h:
7:41 PM Changeset in webkit [93276] by hayato@chromium.org
  • 16 edits in trunk

Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=61421

Reviewed by Dimitri Glazkov.

Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
that focus/blue events are stopped at the lowest common shadow boundary.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Event.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):

  • dom/Event.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

  • dom/Node.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchBlurEvent):

  • html/HTMLFormControlElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):

  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):

  • html/HTMLTextFormControlElement.h:
  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events.html:
7:14 PM Changeset in webkit [93275] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
​https://bugs.webkit.org/show_bug.cgi?id=66036

Source/WebCore:

These modes cannot be passed straight through to the underlying graphics context as the graphics context
and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
the entire canvas.

The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
area being filled.

Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
transformed path being filled contained anti-aliasing at its edges artifacts were introduced.

With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
appropriate mode, with any areas outside the draw area being cleared.

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

Test: fast/canvas/canvas-composite-transformclip.html

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

LayoutTests:

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

  • fast/canvas/canvas-composite-alpha.html:
  • fast/canvas/canvas-composite-transformclip-expected.txt: Added.
  • fast/canvas/canvas-composite-transformclip.html: Added.
  • platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/canvas/canvas-composite-expected.png:
  • platform/mac/fast/canvas/canvas-composite-transformclip-expected.png: Added.
7:00 PM Changeset in webkit [93274] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

Switch inspector to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66358

Reviewed by Eric Seidel.

Convert inspector code to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawNodeHighlight):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willPaint):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createPaintData):

  • inspector/TimelineRecordFactory.h:
6:31 PM Changeset in webkit [93273] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Switch Editing code to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66355

Reviewed by Eric Seidel.

Converting remaining editing code to the LayoutUnit abstraction.

No new tests, no change in functionality.

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::insideVisibleArea):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:
  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

6:18 PM Changeset in webkit [93272] by leviw@chromium.org
  • 25 edits in trunk/Source/WebCore

Switch Accessibility code to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66348

Reviewed by Eric Seidel.

Converting remaining Accessibility code to the LayoutUnit abstraction.

No new tests, no change in functionality

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::elementRect):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::elementAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::elementRect):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::elementRect):

  • accessibility/AccessibilityMenuListOption.h:

(WebCore::AccessibilityMenuListOption::size):

  • accessibility/AccessibilityMenuListPopup.h:

(WebCore::AccessibilityMenuListPopup::elementRect):
(WebCore::AccessibilityMenuListPopup::size):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clickPoint):
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::boundingBoxRect):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::elementRect):
(WebCore::AccessibilityRenderObject::size):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::elementRect):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::elementRect):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):
(WebCore::AccessibilitySliderThumb::size):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):

  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

6:02 PM Changeset in webkit [93271] by jonlee@apple.com
  • 2 edits in trunk/Websites/webkit.org

Updating the forms survey to include various element sizes.

  • projects/forms/survey.html:
5:49 PM Changeset in webkit [93270] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Switch focus handling to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66331

Reviewed by Eric Seidel.

Convert FocusController and SpatialNavigation to new layout abstraction
as a part of the ongoing conversion work.

No new tests, no new functionality.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/FocusController.h:
  • page/SpatialNavigation.cpp:

(WebCore::alignmentForRects):
(WebCore::start):
(WebCore::middle):
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::deflateIfOverlapped):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::distanceDataForNode):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):

  • page/SpatialNavigation.h:
5:36 PM Changeset in webkit [93269] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

Switch Document, DocumentMarker, Clipboard, and Range to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=66330

Reviewed by Eric Seidel.

Converting the remaining DOM classes to use the LayoutUnit abstraction.

No new tests, no new behavior.

  • dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):
(WebCore::nodeFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::prepareMouseEvent):

  • dom/Document.h:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):

  • dom/DocumentMarkerController.h:
  • dom/Range.cpp:

(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):

  • dom/RenderedDocumentMarker.h:

(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setRenderedRect):
(WebCore::RenderedDocumentMarker::renderedRect):
(WebCore::RenderedDocumentMarker::invalidMarkerRect):
(WebCore::RenderedDocumentMarker::invalidate):

5:17 PM Changeset in webkit [93268] by mitz@apple.com
  • 8 edits in trunk/Source

Source/WebCore: Removed an unused setting.

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • page/Settings.cpp:

(WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.

  • page/Settings.h: Removed accessors.

Source/WebKit/mac: Removed some code that is not needed when building for Leopard or later.

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusToSendToOldClients): Removed check for Tiger Mail.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::objectContentType):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

5:11 PM Changeset in webkit [93267] by mrowe@apple.com
  • 5 edits in tags/Safari-535.1.2

Merge r93070.

5:11 PM Changeset in webkit [93266] by mrowe@apple.com
  • 5 edits in tags/Safari-535.1.2/Source

Versioning.

5:09 PM Changeset in webkit [93265] by mrowe@apple.com
  • 1 copy in tags/Safari-535.1.2

New tag.

5:08 PM Changeset in webkit [93264] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Move towards supporting user controlled prototypes on CanvasPixelArray
​https://bugs.webkit.org/show_bug.cgi?id=66429

Reviewed by Gavin Barraclough.

Start using a per-global object structure for canvas pixel array.

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

5:06 PM Changeset in webkit [93263] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
​https://bugs.webkit.org/show_bug.cgi?id=66281

Reviewed by Eric Seidel.

No new tests - refactoring only.

The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from unsigned to CSSPrimitiveValue
(WebCore::CSSPrimitiveValue::operator unsigned):
Support cast from CSSPrimitiveValue to unsigned

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.

4:55 PM Changeset in webkit [93262] by commit-queue@webkit.org
  • 5 edits in trunk/Source

ScrollAnimatorNone: Remove unused field
​https://bugs.webkit.org/show_bug.cgi?id=66312

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-08-17
Reviewed by Adam Barth.

Source/WebCore:

No functional change; no test needed.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):

4:37 PM Changeset in webkit [93261] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Eliminate the WebCGFloat compatibility definition that was needed for Tiger.

Rubber-stamped by Anders Carlsson.

  • WebView/WebHTMLViewPrivate.h:
4:32 PM Changeset in webkit [93260] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Work-in-progress on Soft link against AVFoundationCF and CoreMedia
​https://bugs.webkit.org/show_bug.cgi?id=65725

Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
is enabled.

Reviewed by Anders Carlsson.

No new tests; no functional change.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).

(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.

4:28 PM Changeset in webkit [93259] by Dimitri Glazkov
  • 7 edits
    53 moves
    1 add in trunk/Tools

garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
​https://bugs.webkit.org/show_bug.cgi?id=66427

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.

():

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
4:16 PM Changeset in webkit [93258] by mitz@apple.com
  • 12 edits in trunk/Source/WebKit/mac

Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
needed for Tiger.

Reviewed by Darin Adler.

  • History/WebBackForwardList.h:
  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLRepresentation.h:
  • WebView/WebPreferences.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebResourceLoadDelegatePrivate.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebTextIterator.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebViewPrivate.h:
4:14 PM Changeset in webkit [93257] by jochen@chromium.org
  • 2 edits in trunk/Tools

Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
​https://bugs.webkit.org/show_bug.cgi?id=65877

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4:08 PM Changeset in webkit [93256] by Dimitri Glazkov
  • 4 edits in trunk/Tools

Remove base.keys and replace it with Object.keys.
​https://bugs.webkit.org/show_bug.cgi?id=66422

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
4:04 PM Changeset in webkit [93255] by jamesr@google.com
  • 24 edits
    2 copies in branches/chromium/835/Source

Merge 92520 - [chromium] Accelerated canvas breaks when moving canvases or resources between Pages
​https://bugs.webkit.org/show_bug.cgi?id=65402

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.

Source/WebCore:

Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.

  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Source/WebKit/chromium:

Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

TBR=​apatrick@chromium.org
BUG=80703
Review URL: ​http://codereview.chromium.org/7671031

3:51 PM Changeset in webkit [93254] by Dimitri Glazkov
  • 4 edits in trunk/Tools

garden-o-matic Summary view should have items in descending chronological order.
​https://bugs.webkit.org/show_bug.cgi?id=66403

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
3:41 PM Changeset in webkit [93253] by jamesr@google.com
  • 3 edits in branches/chromium/835/Source/WebCore

Merge 92430 - [chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
​https://bugs.webkit.org/show_bug.cgi?id=65655

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:

TBR=​commit-queue@webkit.org
BUG=80703
Review URL: ​http://codereview.chromium.org/7670046

3:41 PM Changeset in webkit [93252] by Dimitri Glazkov
  • 4 edits in trunk/Tools

Fix a few errors in garden-o-matic frontend unit tests.
​https://bugs.webkit.org/show_bug.cgi?id=66421

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
3:31 PM Changeset in webkit [93251] by tony@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] remove stale result and mark 3 new authentication tests as
failing because chromium drt is missing a function. Also mark
midword-break-before-surrogate-pair-2.html as failing on mac.

  • platform/chromium-cg-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:17 PM Changeset in webkit [93250] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/text/midword-break-before-surrogate-pair-2.html is failing
on win and linux due to missing glyph.

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [93249] by mrowe@apple.com
  • 10 edits in trunk

Use the LLVM Compiler for optimized builds when recent enough versions of it are available.

Rubber-stamped by Sam Weinig.

2:57 PM Changeset in webkit [93248] by mrowe@apple.com
  • 15 edits in trunk

Bring some consistency to the CompilerVersion.xcconfig files. They all now include REAL_PLATFORM_NAME in the relevant setting names.

Rubber-stamped by Sam Weinig.

2:43 PM Changeset in webkit [93247] by beidson@apple.com
  • 4 edits
    4 copies
    4 moves
    11 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
Regression: On Lion, redirects lose HTTP authentication headers

Source/WebCore:

Reviewed by Alexey Proskuryakov and Darin Adler.

This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
assuming the redirected URL did not contain credentials directly.

Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html

http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

LayoutTests:

These have to be in different paths to prevent credentials from leaking over from test to test.
Sad sad sad...

Reviewed by Alexey Proskuryakov.

  • http/tests/misc/authentication-redirect-1: Added.
  • http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect-expected.txt.
  • http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect.html.
  • http/tests/misc/authentication-redirect-1/resources: Added.
  • http/tests/misc/authentication-redirect-1/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-redirect-2: Added.
  • http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
  • http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html: Added.
  • http/tests/misc/authentication-redirect-2/resources: Added.
  • http/tests/misc/authentication-redirect-2/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-redirect-3: Added.
  • http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
  • http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html: Added.
  • http/tests/misc/authentication-redirect-3/resources: Added.
  • http/tests/misc/authentication-redirect-3/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php: Added.
  • http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
  • http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
  • http/tests/misc/authentication-sent-to-redirect.html: Removed.
  • http/tests/misc/resources/auth-echo.php: Removed.
  • http/tests/misc/resources/auth-then-redirect.php: Removed.
2:34 PM Changeset in webkit [93246] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Accessibility stack exhaustion using role attribute
​https://bugs.webkit.org/show_bug.cgi?id=65174

Reviewed by Darin Adler.

Forgot to commit review comments.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):

2:29 PM Changeset in webkit [93245] by rniwa@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

Dump-as-markup conversion: editing/inserting/insert-3786362-fix.html
​https://bugs.webkit.org/show_bug.cgi?id=66396

Reviewed by Chang Shu.

Converted the test.

  • editing/inserting/insert-3786362-fix-expected.txt: Added.
  • editing/inserting/insert-3786362-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/gtk/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/mac-leopard/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3786362-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3786362-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3786362-fix-expected.txt: Removed.
2:26 PM Changeset in webkit [93244] by jamesr@google.com
  • 11 edits in branches/chromium/835/Source

Merge 91736 - Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=65043

BUG=80703

Patch by Al Patrick <​apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
​https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <​apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7631029

2:24 PM Changeset in webkit [93243] by Chris Fleizach
  • 5 edits
    2 adds in trunk

Accessibility stack exhaustion using role attribute
​https://bugs.webkit.org/show_bug.cgi?id=65174

Source/WebCore:

Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
creation flow. That can lead to loops.

Reviewed by Darin Adler.

Tests: accessibility/crash-determining-aria-role-when-label-present.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/crash-determining-aria-role-when-label-present-expected.txt: Added.
  • accessibility/crash-determining-aria-role-when-label-present.html: Added.
2:16 PM Changeset in webkit [93242] by abarth@webkit.org
  • 8 edits in trunk/Tools

Update Tools to account for (CG) being added to Chromium builder names
​https://bugs.webkit.org/show_bug.cgi?id=66410

Reviewed by Adam Barth.

Some of these names will change back once we turn on Skia bots.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2:13 PM Changeset in webkit [93241] by Dimitri Glazkov
  • 6 edits in trunk/Tools

Wire up relative time to garden-o-matic summary view.
​https://bugs.webkit.org/show_bug.cgi?id=66343

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2:08 PM Changeset in webkit [93240] by Adam Roben
  • 2 edits in trunk/Tools

Make run-api-tests run tests in alphabetical order

Fixes <​http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order

Reviewed by David Kilzer.

  • Scripts/run-api-tests:

(runAllTests):
(runAllTestsInSuite):
Sort the lists of tests and suites before iterating over them.

1:58 PM Changeset in webkit [93239] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Crash if compositing is disabled during updateLayers()
​https://bugs.webkit.org/show_bug.cgi?id=66353

Reviewed by Kenneth Russell.

If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
drawLayers() has to return without doing anything if the root layer is null.

Crash fixed based on crash reports. No known reliably repro case, unfortunately.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

1:54 PM Changeset in webkit [93238] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

JSC verbose debugging output sometimes doesn't work as expected.
​https://bugs.webkit.org/show_bug.cgi?id=66107

Reviewed by Gavin Barraclough.

Hardened the CodeBlock::dump() code so that it no longer crashes. Improved
the DFG verbose code so that it prints slightly more useful information.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::debugSize):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfRegExps):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

1:52 PM Changeset in webkit [93237] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
​https://bugs.webkit.org/show_bug.cgi?id=66402

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/midword-break-before-surrogate-pair-2.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
break before a trailing surrogate.

LayoutTests:

  • fast/text/midword-break-before-surrogate-pair-2.html: Added.
1:15 PM Changeset in webkit [93236] by abarth@webkit.org
  • 8 edits
    5 adds in trunk/Tools

garden-o-matic should be able to rebaseline expected failures
​https://bugs.webkit.org/show_bug.cgi?id=66204

Reviewed by Dimitri Glazkov.

This patch introduces a new view for displaying expect, actual, and
differences between results. The new view also has a fledgling
controller that handles some basic operations. The new view is
exercised by rebaseline.html, which lets you rebaselines expected
failures, but the new view is not fully integrated into
garden-o-matic.html

More patches will be required to make this stuff fully working, but
this patch was already somewhat spiraling out of control. Hopefully
this patch will serve as a good starting point for further development.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
12:59 PM Changeset in webkit [93235] by chang.shu@nokia.com
  • 17 edits in trunk

2011-08-16 Chang Shu <​cshu@webkit.org>

Support reset in WebCore::Internals
​https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

New tests will be added when function reset is implemented.

Added framework code in WebCoreTestSupport. The real implementation of
Internals::reset() depends on the need from the settings that require a reset.

  • testing/Internals.cpp: (WebCore::Internals::reset):
  • testing/Internals.h:
  • testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
  • testing/js/WebCoreTestSupport.h:
  • testing/v8/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
  • testing/v8/WebCoreTestSupport.h:

2011-08-16 Chang Shu <​cshu@webkit.org>

Support reset in WebCore::Internals
​https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added framework code in WebKit.

  • public/WebTestingSupport.h:
  • src/WebTestingSupport.cpp: (WebKit::WebTestingSupport::resetInternalsObject):

2011-08-16 Chang Shu <​cshu@webkit.org>

Support reset in WebCore::Internals
​https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added framework code in WebKit.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::resetInternalsObject):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-08-16 Chang Shu <​cshu@webkit.org>

Support reset in WebCore::Internals
​https://bugs.webkit.org/show_bug.cgi?id=66307

Reviewed by Dimitri Glazkov.

Added call to resetInternalsObject in DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
12:44 PM Changeset in webkit [93234] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline for Windows, Chromium Windows, and Chromium Linux after r93221.

  • platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
12:11 PM Changeset in webkit [93233] by andersca@apple.com
  • 2 edits
    4 deletes in trunk/Source/WebKit2

Remove unused Core Animation related classes
​https://bugs.webkit.org/show_bug.cgi?id=66393

Reviewed by Darin Adler.

  • Shared/mac/CoreAnimationRenderer.h: Removed.
  • Shared/mac/CoreAnimationRenderer.mm: Removed.
  • Shared/mac/ShareableSurface.cpp: Removed.
  • Shared/mac/ShareableSurface.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
12:10 PM Changeset in webkit [93232] by Adam Roben
  • 4 edits
    1 copy in trunk/LayoutTests

Update Windows Results for svg/W3C-SVG-1.1-SE/text-intro-05-t.svg

  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.

These results were checked in to platform/win but were really XP-specific.

  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:

Updated these results for Windows 7.

11:56 AM Changeset in webkit [93231] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

Add a new build slave for the Qt port on Mac OS SnowLeopard.
​https://bugs.webkit.org/show_bug.cgi?id=66392

Modify the config file to include the new build slave.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:53 AM Changeset in webkit [93230] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/canvas/webgl/data-view-crash.html as flaky
on linux debug.

  • platform/chromium/test_expectations.txt:
11:44 AM Changeset in webkit [93229] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved
and the WebCore.gypi file wasn't updated.

  • WebCore.gypi:
11:39 AM Changeset in webkit [93228] by aa@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium/ChangeLog

Remove support for old didCreateIsolatedContext() signature
​https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

11:29 AM Changeset in webkit [93227] by inferno@chromium.org
  • 8 edits
    3 adds in trunk

Source/WebCore: Crash in Document::recalcStyleSelector
​https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.

Test: svg/dom/stylesheet-candidate-node-crash-main.html

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::~HTMLStyleElement):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::~SVGStyleElement):

LayoutTests: Tests that we do not crash when iterating through stylesheet
candidate list hashset.
​https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

  • svg/dom/resources/stylesheet-candidate-node-crash.svg: Added.
  • svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added.
  • svg/dom/stylesheet-candidate-node-crash-main.html: Added.
11:28 AM Changeset in webkit [93226] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Source/WebCore: AccessibilityObject levels are inconsistent
​https://bugs.webkit.org/show_bug.cgi?id=66180

Updated accessibilityTable to return level values consistent with other accessibilityObjects that
return level values. This means a value of 0 is now only returned when tableLevel() is called on a
non-table element.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/element-level.html

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableLevel):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools: AccessibilityObject levels are inconsistent
​https://bugs.webkit.org/show_bug.cgi?id=66180

Added the ability to get numeric attribute values using numberAttributeValue. This
function complements the existing stringAttributeValue and boolAttributeValue functions.
The addition of numberAttributeValue was necessary because the stringAttributeValue
function does a type check and will only return strings. This limitation made it
impossible to get values for attributes that returned an NSNumber.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(numberAttributeValueCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::numberAttributeValue):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::numberAttributeValue):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::numberAttributeValue):

LayoutTests: AccessibilityObject levels are inconsistent
​https://bugs.webkit.org/show_bug.cgi?id=66180

This test ensures that all AccessibilityObjects that return a level value return consistent results.
For example, a level of 0 should only be returned by a level function when it is called on an
AccessibilityObject of the wrong type. It's especially important that we enforce this consistency
using layout tests because these level values are not defined by the W3C but are still used by
popular screen readers such as VoiceOver.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/element-level-expected.txt: Added.
  • platform/mac/accessibility/element-level.html: Added.
11:21 AM Changeset in webkit [93225] by aa@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Remove support for old didCreateIsolatedContext() signature
​https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

11:17 AM Changeset in webkit [93224] by Adam Roben
  • 4 edits in trunk/Tools

Tell Trac logs always to display all specified revisions in a single page

Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.

Fixes <​http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:

Updated tests for the above.

11:13 AM Changeset in webkit [93223] by Adam Roben
  • 2 edits in trunk/Tools

Fix TestFailures's link to file a bug about TestFailures itself

Fixes <​http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
bug about itself is broken

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
the host from the path.

11:13 AM Changeset in webkit [93222] by Adam Roben
  • 4 edits in trunk/Tools

Teach TestFailures to ignore unbelievably short test runs

Fixes <​http://webkit.org/b/66385> TestFailures page thinks all tests passed in
​http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
that caused it not to run any tests at all (as happened for a while due to
<​http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Test for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.

11:07 AM Changeset in webkit [93221] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

An arrow key collapses directionless selection range in the wrong direction in BiDi
​https://bugs.webkit.org/show_bug.cgi?id=64626

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.

Test: editing/selection/collapse-selection-in-bidi.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.

  • editing/FrameSelection.h:

LayoutTests:

Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.

  • editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • editing/selection/collapse-selection-in-bidi.html: Added.
11:04 AM Changeset in webkit [93220] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove onTimeout from WebIDBTransactionCallbacks.h
​https://bugs.webkit.org/show_bug.cgi?id=66326

Patch by David Grogan <​dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.

  • public/WebIDBTransactionCallbacks.h:
10:57 AM Changeset in webkit [93219] by jeffm@apple.com
  • 4 edits
    4 moves
    2 adds in trunk/Source/WebCore

Some AVFoundation source files should be in platform-specific directories
​https://bugs.webkit.org/show_bug.cgi?id=66352

Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.

Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.

Reviewed by Eric Carlson.

No new tests; no functional change.

  • WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.
  • WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.
  • platform/graphics/avfoundation/cf: Added.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.
  • platform/graphics/avfoundation/objc: Added.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.
10:45 AM Changeset in webkit [93218] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Only set m_fontDirty if TextSizeAdjust is actually changed.
​https://bugs.webkit.org/show_bug.cgi?id=66022

Reviewed by Darin Adler.

No new tests. Refactoring only.

Reduces instances where the font information is dirtied to save recalculation where it is not necessary.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.

10:45 AM Changeset in webkit [93217] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r93204.
​http://trac.webkit.org/changeset/93204
​https://bugs.webkit.org/show_bug.cgi?id=66375

Test no longer crashing since r93171

  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [93216] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
​https://bugs.webkit.org/show_bug.cgi?id=66211

Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.

Reviewed by Tony Chang.

No new tests; no functional change.

  • platform/graphics/chromium/HarfbuzzSkia.cpp:

(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.

  • platform/graphics/chromium/HarfbuzzSkia.h:
10:16 AM Changeset in webkit [93215] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
10:16 AM Changeset in webkit [93214] by tony@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Add chromium baselines for tests added in r93144.

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:59 AM Changeset in webkit [93213] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark svg/custom/repaint-shadow.svg and
media/media-blocked-by-beforeload.html as flaky.

  • platform/chromium/test_expectations.txt:
9:25 AM Changeset in webkit [93212] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
9:02 AM Changeset in webkit [93211] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another <progress> test on Windows

  • platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.
8:49 AM Changeset in webkit [93210] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Web Inspector: http/tests/inspector/network/disabled-cache-crash.html flaky
​https://bugs.webkit.org/show_bug.cgi?id=65558

Add TIMEOUT expectation.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
8:22 AM Changeset in webkit [93209] by Adam Roben
  • 3 edits in trunk/LayoutTests

Add Windows expected failure results for text-combine-image-test.html

Failure is tracked by <​http://webkit.org/b/66376>.

  • platform/win/fast/text/international/text-combine-image-test-expected.png:
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:
8:21 AM Changeset in webkit [93208] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for new test added in r93068

Failure is tracked by <​http://webkit.org/b/66374>.

  • platform/win/editing/deleting/regional-indicators-expected.txt: Added.
8:21 AM Changeset in webkit [93207] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows results for new test added in r91777

  • platform/win/fast/css/font-family-pictograph-expected.png: Added.
  • platform/win/fast/css/font-family-pictograph-expected.txt: Added.
7:05 AM Changeset in webkit [93206] by Adam Roben
  • 1 edit
    9 adds in trunk/LayoutTests

Add Windows results for tests that differ from Lion due to font differences

These tests started failing in r93107 when I made Windows fall back to Lion results instead
of SnowLeopard results. This is good in general, but these particular tests happen to give
SnowLeopard-ish results due to some fonts that changed in Lion.

  • platform/win/css1/font_properties/font-expected.png: Added.
  • platform/win/css1/font_properties/font-expected.txt: Copied from platform/mac-snowleopard/css1/font_properties/font-expected.txt.
  • platform/win/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/win/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Added.
  • platform/win/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/win/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt.
  • platform/win/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/win/fast/text/capitalize-boundaries-expected.txt: Copied from platform/win/fast/text/capitalize-boundaries-expected.txt.
7:04 AM Changeset in webkit [93205] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows expected failures results for new test added in r93144

Failure is tracked by <​http://webkit.org/b/56101>.

  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
6:50 AM Changeset in webkit [93204] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

http/tests/misc/font-face-in-multiple-segmented-faces.html assertion failure on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=66375

Sets a CRASH expectation for Windows debug.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
6:05 AM Changeset in webkit [93203] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Set failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin-in-iframe.html for all build flavors
​http://crbug.com/26042

The test already has a failing TEXT expectation for DEBUG and for
LINUX RELEASE, but we're now seeing failures on Mac10.6. It looks like
it's generally flaky.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:45 AM Changeset in webkit [93202] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
​https://bugs.webkit.org/show_bug.cgi?id=66311

Patch by Sailesh Agrawal <​sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarMinimumTotalLengthNeededForThumb):

4:42 AM Changeset in webkit [93201] by steveblock@google.com
  • 5 edits
    3 deletes in trunk

Unreviewed, rolling out r93186.
​http://trac.webkit.org/changeset/93186
​https://bugs.webkit.org/show_bug.cgi?id=66114

Breaks LayoutTests on Chromium canary bots

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

LayoutTests:

  • compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Removed.
  • compositing/backface-visibility-hierarchical-transform.html: Removed.
3:54 AM Changeset in webkit [93200] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] REGRESSION after r93011
​https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
    • Unskip fast/css/font-face-opentype.html.
    • Unskip http/tests/security/cross-frame-access-put.html, because it passes now.
  • platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Update Qt 4.8 specific expected result.
3:52 AM Changeset in webkit [93199] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Get rid of calls to deprecatedNode and deprecatedEditingOffset in
AccessibilityRenderObject.cpp and InsertTextCommand.cpp
​https://bugs.webkit.org/show_bug.cgi?id=66014

Reviewed by Hajime Morita.

Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
and deprecatedEditingOffset.
(WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.

  • dom/Position.h:

(WebCore::Position::rootEditableElement): Added.

  • dom/Range.cpp:

(WebCore::Range::setStart): Added.
(WebCore::Range::setEnd): Added.

  • dom/Range.h:
  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/RenderedPosition.cpp:

(WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.

  • editing/RenderedPosition.h:
3:49 AM Changeset in webkit [93198] by Csaba Osztrogonác
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
    • Unskip tests removed by r93095.
    • Skip fast/repaint/japanese-rl-selection-repaint-in-regions.html introduced in r93144.
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added. (test introduced in r93144)
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added. (test introduced in r93144)
1:28 AM Changeset in webkit [93197] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
​https://bugs.webkit.org/show_bug.cgi?id=66238

Patch by Sailesh Agrawal <​sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:

  1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
  2. animation is delayed because shouldSuspendScrollAnimations() is true
  3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
  4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.

It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.

Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts ​http://trac.webkit.org/changeset/92316.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterForceFlashScrollers):

1:26 AM Changeset in webkit [93196] by caseq@chromium.org
  • 30 edits
    2 adds in trunk

2011-08-16 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
​https://bugs.webkit.org/show_bug.cgi?id=66131

Reviewed by Pavel Feldman.

Test: inspector/view-events.html

  • added a notion of an optional parent to a View
  • maintain a list of View children
  • dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
  • promoted Panel's logic of (re)storing scroll positions to view
  • demoted inheritScrollPositionFromView to a couple of views that need it.
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype.onResize):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.populateStatusBar): (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.onResize): (WebInspector.SimpleCookiesTable.prototype.onResize):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.onResize):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.onResize):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.onResize): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.onResize):
  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.onResize):
  • inspector/front-end/IFrameView.js: (WebInspector.IFrameView):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView.prototype._installHighlightSupport):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView): (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkLogView.prototype.onResize): (WebInspector.NetworkLogView.prototype.wasShown): (WebInspector.NetworkLogView.prototype.willHide): (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.performSearch.processChunk): (WebInspector.Panel.prototype.performSearch): (WebInspector.Panel.prototype.updateSidebarWidth):
  • inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView.prototype.show): (WebInspector.PanelEnablerView.prototype.onResize):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.onResize):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.onResize):
  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
  • inspector/front-end/ResourceResponseView.js: (WebInspector.ResourceResponseView.prototype.contentLoaded):
  • inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.prototype.show):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.ResourcesPanel.prototype.closeVisibleView): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.willHide): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.inheritScrollPositions):
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TextViewer.prototype.inheritScrollPositions): (WebInspector.TextViewer.prototype.onResize):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.onResize): (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TimelinePanel.prototype.show):
  • inspector/front-end/View.js: (WebInspector.View): (WebInspector.View.prototype.wasShown): (WebInspector.View.prototype.willHide): (WebInspector.View.prototype._innerShow): (WebInspector.View.prototype.show): (WebInspector.View.prototype._innerHide): (WebInspector.View.prototype.hide): (WebInspector.View.prototype._detach): (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.View.prototype.storeScrollPositions): (WebInspector.View.prototype.restoreScrollPositions): (WebInspector.View.prototype.addChildView): (WebInspector.View.prototype.removeChildView): (WebInspector.View.prototype.onResize): (WebInspector.View.prototype.doResize): (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren): (WebInspector.View.prototype.dispatchToVisibleChildren):
  • inspector/front-end/inspector.js: (WebInspector.windowResize):

2011-08-16 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
​https://bugs.webkit.org/show_bug.cgi?id=66131

Reviewed by Pavel Feldman.

  • inspector/view-events-expected.txt: Added.
  • inspector/view-events.html: Added.

Aug 16, 2011:

9:51 PM Changeset in webkit [93195] by macpherson@chromium.org
  • 6 edits in trunk/Source/WebCore

Represent RenderStyle::textOverflow property using an enum instead of a bool.
​https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.

  • rendering/style/RenderStyleConstants.h:

Define TextOverflow enum.

  • rendering/style/StyleRareNonInheritedData.h:

Change representation of text overflow from bool to one-bit unsigned.

9:49 PM Changeset in webkit [93194] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Apple's Windows production build should fail to compile if AVFoundation is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
6:54 PM Changeset in webkit [93193] by levin@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
​https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/7669011

6:41 PM Changeset in webkit [93192] by levin@chromium.org
  • 1 edit in branches/chromium/782/Source/WebCore/loader/CrossOriginAccessControl.cpp

Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
​https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

TBR=​levin@chromium.org
Review URL: ​http://codereview.chromium.org/7669010

6:41 PM Changeset in webkit [93191] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add new chromium-mac-leopard directory to match the chromium-mac that
tonywork added. This directory will house Skia results for Chromium Mac.

  • platform/chromium-mac-leopard: Added.
6:38 PM Changeset in webkit [93190] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add a CG qualifier similar to the GPU qualifier
​https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
6:34 PM Changeset in webkit [93189] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively. In some cases,
we may get to this generated code with one or both of these
registers trash. One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress(). This patch uses the
values on the stack. A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

6:32 PM Changeset in webkit [93188] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r89086): All worker xhr requests trigger preflight requests.
​https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

6:29 PM Changeset in webkit [93187] by hayato@chromium.org
  • 6 edits
    4 adds in trunk/LayoutTests

Add two sample mismatch reftests to make sure that reftests work correctly.
​https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

  • fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-fail-mismatch-reftest.html: Added.
  • fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
  • fast/harness/sample-mismatch-reftest.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
6:24 PM Changeset in webkit [93186] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Computing screen-space transform for LayerChromium and CCLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl). This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the screen space transform.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

  • compositing/backface-visibility-hierarchical-transform-expected.png: Added.
  • compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
  • compositing/backface-visibility-hierarchical-transform.html: Added.
6:11 PM Changeset in webkit [93185] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

More rebaselines for Windows WebKit2 port.

  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
5:57 PM Changeset in webkit [93184] by hayato@chromium.org
  • 3 edits
    2 adds
    2 deletes in trunk

Implement proper handling of events which happen in children of shadow hosts.
​https://bugs.webkit.org/show_bug.cgi?id=66285

Reviewed by Dimitri Glazkov.

Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.

Source/WebCore:

Test: fast/dom/shadow/shadow-contents-event.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

  • fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
  • fast/dom/shadow/details-summary-mouseover.html: Removed.
  • fast/dom/shadow/shadow-contents-event-expected.txt: Added.
  • fast/dom/shadow/shadow-contents-event.html: Added.
5:55 PM Changeset in webkit [93183] by eric@webkit.org
  • 3 edits in trunk/Tools

REGRESSION(92717): WinPort needs to parse version information from port_name
​https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed. Fixing an exception/typo seen on the bots (and testing to make sure it works).

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5:16 PM Changeset in webkit [93182] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
​https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):

  • loader/ThreadableLoader.h:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):

  • notifications/Notification.cpp:

(WebCore::Notification::startLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::loadAsynchronously):

5:07 PM Changeset in webkit [93181] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

5:06 PM Changeset in webkit [93180] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.16

New tag.

5:05 PM Changeset in webkit [93179] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

4:51 PM Changeset in webkit [93178] by abarth@webkit.org
  • 2 edits in trunk/Tools

Change webkit-patch analyze-baselines to print in a more unix-friendly way
​https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
4:30 PM Changeset in webkit [93177] by rniwa@webkit.org
  • 1 edit
    4 copies
    1 add in trunk/LayoutTests

win-wk2 needs updated baselines for some editing tests
​https://bugs.webkit.org/show_bug.cgi?id=66344

win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win

Patch by Wyatt Carss <​wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.

  • platform/win-wk2/editing/deleting: Added.
  • platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
  • platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
  • platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
4:30 PM Changeset in webkit [93176] by eric@webkit.org
  • 6 edits
    3 adds in trunk/Tools

REGRESSION(92717): WinPort needs to parse version information from port_name
​https://bugs.webkit.org/show_bug.cgi?id=66325

Reviewed by Adam Barth.

WinPort didn't have any port_name parsing logic.
Seemed it was best to just share the logic from MacPort.
Sharing the logic from MacPort seemed easiest with a shared superclass.
Once I created ApplePort (the superclass) there was a bunch of logic to share.
I found LeakDetector was just in the way when switching back and forth
between win.py and mac.py so I moved it into its own file.

The only logic change here is that WinPort should now be
able to parse port_name values like MacPort (and other ports)
can. The fact that ports do this in their constructors is
wrong and a source of many bugs. But at least now WinPort
matches the status-quo.

  • Scripts/webkitpy/layout_tests/port/apple.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
4:26 PM Changeset in webkit [93175] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add webkit-patch analyze-baselines, as requested by jamesr.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
4:16 PM Changeset in webkit [93174] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Fix spelling error.
​https://bugs.webkit.org/show_bug.cgi?id=66261

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-08-16
Reviewed by Adam Barth.

No functional change, no tests needed.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::notifyPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):

4:12 PM Changeset in webkit [93173] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fold bulk-optimize-baselines into optimize-baselines
​https://bugs.webkit.org/show_bug.cgi?id=66345

Reviewed by James Robinson.

bulk-optimize-baselines is now a superset of optimize-baselines, so
they can be combined.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
4:12 PM Changeset in webkit [93172] by tony@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Add placeholder directories so the chromium canary bots can update.

  • platform/chromium-mac: Added.
  • platform/chromium-mac/fast: Added.
  • platform/chromium-mac/fast/events: Added.
  • platform/chromium-mac/http: Added.
  • platform/chromium-mac/http/tests: Added.
  • platform/chromium-mac/http/tests/workers: Added.
  • platform/chromium-mac/storage: Added.
  • platform/chromium-mac/storage/domstorage: Added.
3:58 PM Changeset in webkit [93171] by Joseph Pecoraro
  • 4 edits in trunk

<​http://webkit.org/b/66328> ASSERT in fast/css/custom-font-xheight.html

Reviewed by Dan Bernstein.

In r93140 the temporary font created for a remote CSS font face
was created without being retained. We need to protect the
font from being purged while we hold onto it, so add a font cache
purge preventer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/chromium/test_expectations.txt:

Unskipped.

3:35 PM Changeset in webkit [93170] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
which WebKitTestRunner does not support yet.

  • platform/wk2/Skipped:
3:25 PM Changeset in webkit [93169] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] cleanup after previous webkit change rolled into chrome
​https://bugs.webkit.org/show_bug.cgi?id=66177

Reviewed by James Robinson.

  • DEPS:
  • WebKit.gyp:
  • public/WebScrollbar.h:
3:21 PM Changeset in webkit [93168] by abarth@webkit.org
  • 1 move in trunk/LayoutTests/platform/chromium-cg-mac-leopard

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

3:20 PM Changeset in webkit [93167] by abarth@webkit.org
  • 1 move in trunk/LayoutTests/platform/chromium-cg-mac

This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

3:20 PM Changeset in webkit [93166] by abarth@webkit.org
  • 19 edits in trunk/Tools

Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
​https://bugs.webkit.org/show_bug.cgi?id=66334

Reviewed by Tony Chang.

This patch moves us closer to switching the Chromium port from
CoreGraphics to Skia. This patch teaches our tools that the current
Chromium Mac configuration is actually chromium-cg-mac, which makes
room for a future chromium-mac configuration that uses Skia.

Shortly after this patch lands, I'll do a server-side move of the
chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
and chromium-cg-mac-leopard.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:15 PM Changeset in webkit [93165] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/custom-font-xheight.html is asserting on all
chromium builds.

Also mark 2 repaint tests as failing on mac.

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [93164] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/repaint/canvas-putImageData.html is now passing
because of the win baselines added in r93139.

  • platform/chromium/test_expectations.txt:
3:07 PM Changeset in webkit [93163] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic frontend needs a friendly relative time description method.
​https://bugs.webkit.org/show_bug.cgi?id=66324

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
3:01 PM Changeset in webkit [93162] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows results for scripts-panel.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
2:55 PM Changeset in webkit [93161] by Dimitri Glazkov
  • 4 edits in trunk/Tools

Summary view should not add multiple entries for the same test failure.
​https://bugs.webkit.org/show_bug.cgi?id=66318

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for

equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2:39 PM Changeset in webkit [93160] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium Windows build fix after r93140. Take 4.

Namespace the now public enum as FontCache::ShouldRetain.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):

2:35 PM Changeset in webkit [93159] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows results for overlapped-iframe-iframe.html

The Windows results match the cross-platform results, not the Mac results.

  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
2:32 PM Changeset in webkit [93158] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that relies on eventSender.scalePageBy on Windows

  • platform/win/Skipped: Added fast/repaint/background-scaling.html.
2:32 PM Changeset in webkit [93157] by senorblanco@chromium.org
  • 15 edits in trunk/Source/WebCore

Canvas resizing can be slow
​https://bugs.webkit.org/show_bug.cgi?id=66251

Canvas resizing was slow due to re-allocation of the ImageBuffer on
each size change (width or height). This was introduced inadvertently
by calls to isAccelerated() during canvas reset(). Since we won't
know if we have successfully accelerated until ImageBuffer creation,
move the compositor invalidation to createImageBuffer() as well.
This patch also attempts to unify the Skia and CG accelerated canvas
paths. The DrawingBuffer used by the Skia path is now owned by
ImageBuffer[Skia], similar to how the IOSurface is owned by
ImageBuffer[CG]. Some of the logic for when to accelerate was moved
into HTMLCanvasElement and unified with the CG path. Acceleration is
also now enabled by the same "Accelerated" ImageBuffer create flag
used by the CG path. DrawingBuffer is now re-created even for a
same-size change (same as the memory buffer), but we speed it up
by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
clear it, since it's done with a glClear anyway).

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
Don't call isAccelerated() from reset(), since we don't want to
inadvertently create the ImageBuffer. Also, since we won't know if
we have successfully accelerated until createImageBuffer() is
called, defer the compositor invalidation to createImageBuffer() as
well.
(WebCore::HTMLCanvasElement::shouldAccelerate):
Unify the CG and Skia ports' logic for when to accelerate (Skia
logic moved in from CanvasRenderingContext2D).
(WebCore::HTMLCanvasElement::createImageBuffer):
Use the unified shouldAccelerate() logic, and pass it as a flag
to ImageBuffer. Do compositor invalidation as well.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
Expose hasCreatedImageBuffer() publically, so
CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
it.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Remove all acceleration setting and resetting, since it's now done
during ImageBuffer creation.
(WebCore::CanvasRenderingContext2D::isAccelerated):
Check if the image buffer was created, so we don't inadvertently
create it here.
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
WebViewImpl may be null. Ask the render tree instead.
(WebCore::CanvasRenderingContext2D::reset):
Don't reset acceleration here, since we don't own it anymore.
(WebCore::CanvasRenderingContext2D::platformLayer):
Call into the ImageBuffer to get our PlatformLayer.

  • html/canvas/CanvasRenderingContext2D.h:

Remove m_drawingBuffer, and all acceleration-related calls.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

Remove setGraphicsContext3D(), and paintsIntoImageBuffer().

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::platformLayer):
Implement a dummy platformLayer() call for non-skia ports.

  • platform/graphics/ImageBuffer.h:

Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).

  • platform/graphics/chromium/ImageBufferDataSkia.h:

Add a DrawingBuffer data member.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::reset):
Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
Since we immediately clear the framebuffer via glClear(), this whole
resource safe business is overkill.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This
functionality is handled by ImageBuffer now.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
Give the ImageBufferData ownership of the DrawingBuffer.
(WebCore::ImageBuffer::platformLayer):
Implement an accessor for the DrawingBuffer's PlatformLayer.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setGraphicsContext3D):

  • platform/graphics/skia/PlatformContextSkia.h:

Remove isPathSkiaSafe() extern (unused).
Remove paintsIntoImageBuffer() (now unused). Remove IntSize param
from setGraphicsContext3D() (unused).

2:19 PM Changeset in webkit [93156] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium Windows build fix after r93140. Take 3.

Include the proper includes!

  • platform/graphics/FontCache.h:
2:12 PM Changeset in webkit [93155] by Adam Roben
  • 3 edits in trunk/Tools

Teach TestFailures that tests that have failed or passed many times in a row are not flaky

The basic strategy here is that once a test has failed or passed many times in a row we
never again consider it as a possibly flaky test. It's a simple strategy but seems to result
in many fewer false positives than our current behavior.

Fixes <​http://webkit.org/b/66327> TestFailures page considers far too many tests to be
flaky, including tests that failed for a while but then were fixed

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
number of non-too-many-failure builds we've seen.
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
tests, keep track of how many times they have passed or failed in a row. If they pass or
fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
considered flaky it doesn't matter how many times it passes or fails.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:

Added tests for the above.

2:12 PM Changeset in webkit [93154] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/custom-font-xheight.html is hitting an assert
in debug on Linux.

  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [93153] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark new tests as failing. Will pull results from the
bots when they cycle.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [93152] by Dimitri Glazkov
  • 2 edits
    8 adds in trunk/Tools

garden-o-matic needs a summary view with actions for each problem.
​https://bugs.webkit.org/show_bug.cgi?id=66144

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
1:47 PM Changeset in webkit [93151] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium Windows build fix after r93140. Take 2.

This just makes the troublesome enum public. If this
fixes the build I will file a follow-up bug to clean-up
these build issues and either keep the enum public and
cleanup other functions or restore the enum to private.
There is no harm in making the enum public right now.

  • platform/graphics/FontCache.h:
1:44 PM Changeset in webkit [93150] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Unmatrix algorithm implementation is wrong
​https://bugs.webkit.org/show_bug.cgi?id=66080

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-08-16
Reviewed by Dean Jackson.

Source/WebCore:

Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.

Test: animations/animation-matrix-negative-scale-unmatrix.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose):

LayoutTests:

  • animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
  • animations/animation-matrix-negative-scale-unmatrix.html: Added.
1:28 PM Changeset in webkit [93149] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
1:13 PM Changeset in webkit [93148] by eric.carlson@apple.com
  • 3 edits
    1 delete in trunk/LayoutTests

Make video-controls-no-scripting.html results platform independent.

  • media/video-controls-no-scripting-expected.txt:
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
1:10 PM Changeset in webkit [93147] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebCore

Unreviewed Windows and Chromium Windows build fix after r93140.

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

12:50 PM Changeset in webkit [93146] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Make placeholder text remain visible until a character is typed on Windows

Fixes <​http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields

Covered by existing tests (which are currently failing on the bots until this patch lands).

Reviewed by Dave Hyatt.

  • rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):

  • rendering/RenderThemeWin.h:

(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.

12:48 PM Changeset in webkit [93145] by dino@apple.com
  • 2 edits in trunk/Tools

Adding Ted "hober" O'Connor as a non-committing contributor.

  • Scripts/webkitpy/common/config/committers.py:
12:43 PM Changeset in webkit [93144] by hyatt@apple.com
  • 8 edits
    9 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66254

Source/WebCore:

Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
content.

Reviewed by Simon Fraser.

Added new tests in fast/repaint.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:

(WebCore::RenderView::hasRenderFlowThreads):

LayoutTests:

Make regions repaint properly. Added new repaint tests.

Reviewed by Simon Fraser.

  • fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
  • fast/repaint/line-flow-with-floats-in-regions.html: Added.
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
12:42 PM Changeset in webkit [93143] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch

Merge r93070.

12:40 PM Changeset in webkit [93142] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch

Merge r93048.

12:34 PM Changeset in webkit [93141] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r93047.

12:18 PM Changeset in webkit [93140] by Joseph Pecoraro
  • 14 edits in trunk/Source/WebCore

Abandoned Memory: Temporary CSS Fonts May Never Be Purged
​https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

While a remote CSS font face is loading we fallback to a
temporary font. We don't want to retain the fallback font
because noone takes ownership of the temporary font. This
patch adds a way to get an uncached fallback font, which
plumbs the ShouldRetain enum through the different platform
implementations of getLastResortFallbackFont.

No new tests, no functional change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getNonRetainedLastResortFallbackFont):

  • platform/graphics/FontCache.h:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/haiku/FontCacheHaiku.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/pango/FontCachePango.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

12:12 PM Changeset in webkit [93139] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows expected results for some <canvas> tests

<canvas> doesn't use accelerated compositing on Windows like it does on Lion.

  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
11:56 AM Changeset in webkit [93138] by dbates@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-08-16 Daniel Bates <​dbates@webkit.org>

Add myself to the list of individual members in the WebKit Security Group.

Rubber-stamped by Eric Seidel.

  • security/security-group-members.html:
11:49 AM Changeset in webkit [93137] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92977.

11:45 AM Changeset in webkit [93136] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Chromium Mac: Rubber banding gutter drawing
​https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

11:44 AM Changeset in webkit [93135] by Lucas Forschler
  • 3 edits in branches/safari-534.51-branch/Source

Merge r88444.

11:39 AM Changeset in webkit [93134] by rniwa@webkit.org
  • 72 edits
    2 adds in trunk

Programmatically set selection should not have direction on Mac
​https://bugs.webkit.org/show_bug.cgi?id=60529

Patch by Wyatt Carss <​wcarss@chromium.org> on 2011-08-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified default value of VisibleSelection->m_isDirectional from 'true'
to 'false' by adding a defaulted argument to several VisibleSelection
constructors to make programmatic selection be directionless by default
on Mac. Also modified several calls to VisibleSelection's constructors
to correctly preserve directionality.

Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
a call to setExtent triggers an editing delegate that uses the
FrameSelection. The direction here should have been preserved from before,
but setIsDirectional was not called until after FrameSelection.cpp:869. It
has been moved up to make things behave.

  • WebCore.exp.in:
  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):

  • editing/FrameSelection.cpp:

(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):

  • editing/FrameSelection.h:
  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::doApply):

  • editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection):

  • editing/VisibleSelection.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Added editing/selection/programmatic-selection-on-mac-is-directionless
to test selection direction in programmatically set selections on
windows, unix, and mac, in plain text, editable divs, text-input
fields, and textareas. Modified text baselines for many editing tests,
which had a delegate change as a result of the cpp patch.

  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/selection/after-line-break-expected.txt:
  • platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/mac/editing/deleting/delete-and-undo-expected.txt:
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-01-expected.txt:
  • platform/mac/editing/inserting/insert-at-end-02-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/4076267-expected.txt:
  • platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-015-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/anchor-focus2-expected.txt:
  • platform/mac/editing/selection/anchor-focus3-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/fake-drag-expected.txt:
  • platform/mac/editing/selection/move-by-word-001-expected.txt:
  • platform/mac/editing/selection/transformed-selection-rects-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
11:36 AM Changeset in webkit [93133] by jpfau@apple.com
  • 7 edits in trunk/Source/WebCore

New XML parser: Add document fragment parser
​https://bugs.webkit.org/show_bug.cgi?id=66317

Reviewed by Adam Barth.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::parseXML):

  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::parseDocumentFragment):

  • xml/parser/NewXMLDocumentParser.h:

(WebCore::NewXMLDocumentParser::create):

  • xml/parser/XMLTokenizer.h:
  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::pushCurrentNode):

  • xml/parser/XMLTreeBuilder.h:

(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::node):

11:36 AM Changeset in webkit [93132] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.

  • platform/chromium/test_expectations.txt:
11:23 AM Changeset in webkit [93131] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

GraphicsContext3D should allow its hostWindow to be NULL
​https://bugs.webkit.org/show_bug.cgi?id=66305

Allow the hostWindow param (and m_webViewImpl) to be NULL. This
makes it much easier to enable GPU acceleration at a lower level
in WebKit's platform/graphics layer, without needing access to the
Page* or HostWindow*. Also bump the chromium DEPS to chrome r96940,
which includes a similar change for the in-process GraphicsContext3D
implementations.

Reviewed by James Robinson.

  • DEPS:
  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initialize):
(WebCore::GraphicsContext3DInternal::platformTexture):
(WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):

11:07 AM Changeset in webkit [93130] by jpfau@apple.com
  • 3 edits in trunk/Source/WebCore

New XML parser: Replace assertions regarding character data in the prolog with proper checks
​https://bugs.webkit.org/show_bug.cgi?id=66269

Reviewed by Adam Barth.

This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):

  • xml/parser/XMLTreeBuilder.h:
11:04 AM Changeset in webkit [93129] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).

  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [93128] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected results for resource-har-conversion.html

While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
extra fields in the request objects.

  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:58 AM Changeset in webkit [93127] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: word wrap long edits
​https://bugs.webkit.org/show_bug.cgi?id=65512

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.styles-section .properties li.child-editing):

10:31 AM Changeset in webkit [93126] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
​https://bugs.webkit.org/show_bug.cgi?id=66316

Reviewed by NOBODY (OOPS!).

  • WebKit.gyp:
10:27 AM Changeset in webkit [93125] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: convert DOM breakpoint types to strings.
​https://bugs.webkit.org/show_bug.cgi?id=66304

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane):

10:23 AM Changeset in webkit [93124] by tony@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir. The mac result (r93112) was getting
picked up by the chromium port.

  • platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
10:16 AM Changeset in webkit [93123] by tony@chromium.org
  • 2 edits
    1 move
    1 add in trunk/LayoutTests

Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.

Also add chromium baseline (the top of the video control is in a
different place).

  • media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
  • media/video-controls-no-scripting.html:
  • platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
10:15 AM Changeset in webkit [93122] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: force pseudo element state when checking it in the styles sidebar.
​https://bugs.webkit.org/show_bug.cgi?id=66292

This reverts ​http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.

Reviewed by David Hyatt.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • css/CSSStyleSelector.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::forcePseudoStateImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::forcePseudoState):

9:59 AM Changeset in webkit [93121] by Lucas Forschler
  • 1 edit in branches/safari-534.51-branch/LayoutTests/ChangeLog

rollout incorrect submit of 93118.

9:57 AM Changeset in webkit [93120] by tony@chromium.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r93114.
​http://trac.webkit.org/changeset/93114
​https://bugs.webkit.org/show_bug.cgi?id=66226

broke the chromium mac compile

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:
  • platform/ScrollbarThemeComposite.cpp:
  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):

  • platform/mac/ScrollbarThemeMac.h:
9:56 AM Changeset in webkit [93119] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results for a fast/text test for Safari 5.1's AAS

The results are now more like Mac's. Dan Bernstein says this is probably a progression.

  • platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
9:55 AM Changeset in webkit [93118] by Lucas Forschler
  • 1 edit in branches/safari-534.51-branch/LayoutTests/ChangeLog

Merge r36608.

9:46 AM Changeset in webkit [93117] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark media/video-source-error.html as flaky in Debug.

  • platform/chromium/test_expectations.txt:
9:44 AM Changeset in webkit [93116] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update Windows results after r92890

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
9:39 AM Changeset in webkit [93115] by Adam Roben
  • 1 edit
    3 deletes in trunk/LayoutTests

Remove Windows-specific hyphenation test results now that hyphenation works on Windows

  • platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
9:34 AM Changeset in webkit [93114] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Chromium Mac: Rubber banding gutter drawing
​https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

  • platform/ScrollbarThemeComposite.h:
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

9:31 AM Changeset in webkit [93113] by tony@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir. The mac failing results (r93105) were
getting picked up by the chromium port.

  • platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
9:28 AM Changeset in webkit [93112] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Lion/Windows expected results for an Inspector test

The only difference from the cross-platform results is that the .js resources are now given
a MIME type of "text/plain".

This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.

  • platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
9:27 AM Changeset in webkit [93111] by Adam Roben
  • 4 edits in trunk/Tools

Teach TestFailures how to interpret unfinished test runs

Fixes <​http://webkit.org/b/66309> TestFailures thinks all tests passed in
​http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
rather than "isStarted" so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.

9:19 AM Changeset in webkit [93110] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
​https://bugs.webkit.org/show_bug.cgi?id=66273

Reviewed by Simon Fraser.

No new tests - no functionality changed - refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Define cast from CSSPrimitiveValue to ETransformStyle3D.
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
Define cast from ETransformStyle3D to CSSPrimitiveValue.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to handle CSSPropertyWebkitTransformStyle.

9:18 AM Changeset in webkit [93109] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
​https://bugs.webkit.org/show_bug.cgi?id=66279

Reviewed by Simon Fraser.

No new tests - no functionality changed - simple refactoring only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.

9:13 AM Changeset in webkit [93108] by eric.carlson@apple.com
  • 4 edits
    3 adds in trunk

2011-08-16 Eric Carlson <​eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
​https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

Tests: media/video-controls-no-scripting-iframe.html

media/video-controls-no-scripting.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code

to configureMediaControls.

(WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
(WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in

attributeChanged and preDispatchEventHandler here.

(WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code

to configureMediaControls.

  • html/HTMLMediaElement.h:

2011-08-16 Eric Carlson <​eric.carlson@apple.com>

[REGRESSION] Media controls should always be enabled when scripting is disabled
​https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

  • media/video-controls-no-scripting-expected.txt: Added.
  • media/video-controls-no-scripting-iframe.html: Added.
  • media/video-controls-no-scripting.html: Added.
9:03 AM Changeset in webkit [93107] by Adam Roben
  • 6 edits in trunk/Tools

Make Apple's Windows port fall back to Lion results instead of SnowLeopard

Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
should match Lion's behavior.

Fixes <​http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
but doesn't use Lion results

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):
Replaced mac-snowleopard with mac-lion.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
directory, which all Apple Mac platforms and Apple Win platforms could potentially use
results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
will no longer look there for results.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest.test_should_build): Tests for the above changes.

9:00 AM Changeset in webkit [93106] by Adam Roben
  • 2 edits in trunk/LayoutTests

Stop skipping the web-apps tests I just landed results for on Lion

  • platform/mac-lion/Skipped:
8:57 AM Changeset in webkit [93105] by Adam Roben
  • 1 edit
    7 adds in trunk/LayoutTests

Check in expected failure results for some web-apps tests on Lion and Windows

Since these failures are likely due to bugs in non-WebKit components, they are tracked by
<rdar://problem/9313271>.

  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
  • platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
  • platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
8:51 AM Changeset in webkit [93104] by Adam Roben
  • 2 edits
    4 copies
    10 adds
    1 delete in trunk/LayoutTests

Share Sputnik Unicode results between Lion and Windows

Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.

  • platform/mac-lion/Skipped: Removed these tests.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
8:41 AM WebKit Team edited by hayato@chromium.org
(diff)
8:33 AM Changeset in webkit [93103] by Adam Roben
  • 5 edits in trunk/LayoutTests

Update Windows Sputnik results for ICU 4.6

Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.

  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
  • platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
8:16 AM Changeset in webkit [93102] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)

Since these failures are likely to be due to bugs in non-WebKit components, they are tracked
by Radars.

  • platform/win/Skipped: Added http/tests/multipart/invalid-image-data-standalone.html,

http/tests/cookies/simple-cookies-expired.html, and
http/tests/cookies/simple-cookies-max-age.html.

7:53 AM Changeset in webkit [93101] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: hide non-conservative methods from the protocol documentation.
​https://bugs.webkit.org/show_bug.cgi?id=66301

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
7:50 AM Changeset in webkit [93100] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg

See ​http://code.google.com/p/chromium/issues/detail?id=93044

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:42 AM Changeset in webkit [93099] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Add TIMEOUT expectation for editing/deleting/regional-indicators.html
​https://bugs.webkit.org/show_bug.cgi?id=66268

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:39 AM Changeset in webkit [93098] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: nuke background events collection (dead feature)
​https://bugs.webkit.org/show_bug.cgi?id=66296

Fix the GTK build after r93095.

Unreviewed build fix.

No new tests neede.

  • GNUmakefile.list.am: Remove nonexistent sources.
7:26 AM Changeset in webkit [93097] by abecsi@webkit.org
  • 20 edits
    1 add in trunk

Reviewed by Csaba Osztrogonác.

Need AtomicStrings for the various font family names
​https://bugs.webkit.org/show_bug.cgi?id=28024

.:

  • Source/cmake/WebKitMacros.cmake: Add new macro.

Source/WebCore:

Unify the usage of '-webkit' prefixed font family names by using
global AtomicStrings.
Use a .in file to generate the needed sources through make_names.pl.

No new tests needed.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::fontDataForGenericFamily):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/WebKitFontFamilyNames.in: Added.
  • dom/make_names.pl:
  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getFontData):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::useFixedDefaultSize):

7:15 AM Changeset in webkit [93096] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
​https://bugs.webkit.org/show_bug.cgi?id=66300

Reviewed by Pavel Feldman.

  • WebKit.gyp:
6:41 AM Changeset in webkit [93095] by pfeldman@chromium.org
  • 12 edits
    10 deletes in trunk

Web Inspector: nuke background events collection (dead feature)
​https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/EventsCollector.cpp: Removed.
  • inspector/EventsCollector.h: Removed.
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: Removed.
  • inspector/InspectorFrontendProxy.h: Removed.
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

LayoutTests:

  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
  • http/tests/inspector/network/network-clear-after-disabled.html: Removed.
  • http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
  • http/tests/inspector/network/network-close-load-open.html: Removed.
  • http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
  • http/tests/inspector/network/network-open-load-reopen.html: Removed.
6:38 AM Changeset in webkit [93094] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

fix

6:11 AM Changeset in webkit [93093] by benjamin.poulain@nokia.com
  • 9 edits
    2 adds in trunk/Source

[Qt] Missing spell check support
​https://bugs.webkit.org/show_bug.cgi?id=44114

Patch by Lindsay Mathieson <​lindsay.mathieson@gmail.com> on 2011-08-16
Reviewed by Benjamin Poulain.

Source/WebCore:

Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):

Source/WebKit/qt:

Added a platform plugin to allow spell and grammar check in QtWebKit.

  • Api/qwebkitplatformplugin.h:
  • QtWebKit.pro:
  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::textChecker):

  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createSpellChecker):

  • WebCoreSupport/QtPlatformPlugin.h:
  • WebCoreSupport/TextCheckerClientQt.cpp: Added.

(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):

  • WebCoreSupport/TextCheckerClientQt.h: Added.

(WebCore::TextCheckerClientQt::requestCheckingOfString):

6:01 AM Changeset in webkit [93092] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Add javascriptcoregtk to the introspection build, to fix it.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> in 2011-08-16
Reviewed by Xan Lopez.

  • GNUmakefile.am:
5:46 AM Changeset in webkit [93091] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs a more-complete implementation of eventSender
​https://bugs.webkit.org/show_bug.cgi?id=42194

Unreviewed gardening.

  • platform/wk2/Skipped: skip editing/input/style-change-during-input.html
4:35 AM Changeset in webkit [93090] by dino@apple.com
  • 2 edits in trunk/Tools

Move me from contributor to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:04 AM Changeset in webkit [93089] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: resource-tree-errors-reload.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Pavel Feldman.

  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
1:57 AM Changeset in webkit [93088] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
​https://bugs.webkit.org/show_bug.cgi?id=66268

  • platform/qt/Skipped:
12:00 AM Changeset in webkit [93087] by morrita@google.com
  • 3 edits
    2 adds in trunk

REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
​https://bugs.webkit.org/show_bug.cgi?id=66216

Reviewed by Ryosuke Niwa.

Source/WebCore:

Element::spellcheckAttributeState() uses Element::hasAttribute(),
which calls updateStyleAttribute(), which potentially makes style
dirty. But that is problematic since Editor calls spellcheckAttributeState()
during the spell-checking phase and make the style dirty,
which can trigger re-layout, which wipes the shadow tree of a textarea
out by pre-committed "value" text.

This change removes the hasAttribute() call from
spellcheckAttributeState().

Test: editing/input/style-change-during-input.html

  • dom/Element.cpp:

(WebCore::Element::spellcheckAttributeState):

LayoutTests:

  • editing/input/style-change-during-input-expected.txt: Added.
  • editing/input/style-change-during-input.html: Added.
Note: See TracTimeline for information about the timeline view.