Context Navigation

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

inspector/debugger/raw-source-code-expected.txt: Removed.
inspector/debugger/raw-source-code.html: Removed.
inspector/debugger/script-formatter.html:
inspector/debugger/source-file.html:

6:38 PM Changeset in webkit [94741] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

offsetFromRoot optimization is disabled after r93837
https://bugs.webkit.org/show_bug.cgi?id=67677

Reviewed by Simon Fraser.

Unfortunately not covered by any test as it does not change updateLayerPosition complexity (it is still O(n^{2)

because of clippedOverflowRectForRepaint). However it is a noticeable slowdown on some use cases but we don't

have a good test harness to cover such slowdown.}

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Pass offsetFromRoot as not doing so means that we miss
the optimization altogether.

(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

rendering/RenderLayer.h:

Renamed |cachedOffset| to |offsetFromRoot| to be consistent with our latest renaming.

6:31 PM Changeset in webkit [94740] by rniwa@webkit.org

1 edit in trunk/Source/WebCore/rendering/RenderBlock.cpp

Fix my commit per darin's suggestion.

6:27 PM Changeset in webkit [94739] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Windows build fix after r94737.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):

5:55 PM Changeset in webkit [94738] by mitz@apple.com

2 edits in trunk/Source/WebCore

Removed hyphenation function implementations for an usupported build configuration.

Reviewed by Sam Weinig.

platform/text/cf/HyphenationCF.cpp:

5:50 PM Changeset in webkit [94737] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67739

adjustRectForColumns is O(# of columns) when it can be O(1). Fix the slow performance of this
function by removing the loop and just computing the start and end column for a repaint rect
and uniting everything in between.

Reviewed by Dan Bernstein.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):

5:26 PM Changeset in webkit [94736] by abarth@webkit.org

8 edits
8 adds
4 deletes in trunk/LayoutTests

Update baselines for svg/as-background-image. These results all appear
correct and test_expectations indicates that they just need new
baselines.

platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-win-vista/svg/as-background-image: Added.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Added.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Added.
platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium/test_expectations.txt:
platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
svg/as-background-image/animated-svg-as-background-expected.txt: Added.
svg/as-background-image/svg-as-background-1-expected.txt: Added.
svg/as-background-image/svg-as-background-3-expected.txt: Added.
svg/as-background-image/svg-as-background-5-expected.txt: Added.

5:18 PM Changeset in webkit [94735] by abarth@webkit.org

2 edits
4 adds in trunk/LayoutTests

These tests just differ in how JSC and V8 report error messages.

platform/chromium-cg-mac-leopard/http/tests/security: Added.
platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:13 PM Changeset in webkit [94734] by abarth@webkit.org

2 edits
2 adds in trunk/LayoutTests

Our results here reflect an intentional difference between GURL and
KURL. KURL doesn't handle non-ASCII characters in the fragment in the
same was as IE whereas GURL does.

platform/chromium/http/tests/uri: Added.
platform/chromium/http/tests/uri/resolve-encoding-relative-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:01 PM Changeset in webkit [94733] by abarth@webkit.org

2 edits
2 adds in trunk/LayoutTests

Our behavior is correct with respect to the new cookie RFC. I'm told
that CFNetwork is going to change this behavior to match every other
browser.

platform/chromium/http/tests/cookies: Added.
platform/chromium/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:51 PM Changeset in webkit [94732] by commit-queue@webkit.org

22 edits
6 deletes in trunk

Unreviewed, rolling out r94714 and r94723.
http://trac.webkit.org/changeset/94714
http://trac.webkit.org/changeset/94723
https://bugs.webkit.org/show_bug.cgi?id=67746

breaks gtk-linux tests with assertion failure (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::inTransparencyLayer):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::getWindowsContext):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):

rendering/RenderThemeWin.cpp:

(WebCore::drawControl):

LayoutTests:

platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Removed.
platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Removed.
platform/chromium-win/svg/custom/simple-text-double-shadow.png: Removed.
platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
svg/custom/simple-text-double-shadow.svg: Removed.

4:48 PM Changeset in webkit [94731] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PPC build fix.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

4:48 PM Changeset in webkit [94730] by abarth@webkit.org

2 edits
1 add
3 deletes in trunk/LayoutTests

Update results. The actual results are only off by a fraction of a
pixel around the curve in the zero.

platform/chromium-cg-mac/media/audio-repaint-expected.txt: Removed.
platform/chromium-mac/media/audio-repaint-expected.txt: Removed.
platform/chromium-win-xp/media: Removed.
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium/media/audio-repaint-expected.txt: Added.

4:43 PM Changeset in webkit [94729] by abarth@webkit.org

8 edits in trunk/LayoutTests

These results are also off by just factional pixels.

platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

4:38 PM Changeset in webkit [94728] by abarth@webkit.org

11 edits
1 add in trunk/LayoutTests

These results all differ only in less than one pixel border or text rendering.

platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
platform/chromium-cg-mac/tables/mozilla/bugs/bug82946-2-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2886-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug6674-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2886-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug6674-expected.png:

4:35 PM Changeset in webkit [94727] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Mac baseline for the test added by r94331.

platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

4:26 PM Changeset in webkit [94726] by rniwa@webkit.org

4 edits in trunk/LayoutTests

Rebaseline for r94710.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

4:25 PM Changeset in webkit [94725] by Nate Chapin

25 edits
9 adds
3 deletes in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium svg/ rebaselines.

platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-cg-mac-leopard/svg/batik/filters/feTile-expected.png:
platform/chromium-cg-mac-leopard/svg/batik/text/textFeatures-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-cg-mac-leopard/svg/filters/filterRes-expected.png:
platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-cg-mac/svg/batik/filters/feTile-expected.png:
platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png:
platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Linear-expected.png:
platform/chromium-cg-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-cg-mac/svg/filters/filterRes-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Removed.
platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-win-vista/svg/filters: Removed.
platform/chromium-win-xp/svg/css: Removed.
platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-win/svg/filters/filterRes-expected.png:
platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [94724] by rniwa@webkit.org

5 edits
2 moves in trunk/LayoutTests

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.

Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

css2.1/t090204-display-change-01-b-ao.html:
fast/css/line-after-floating-div-expected.png: Removed.
fast/css/line-after-floating-div-expected.txt: Removed.
fast/css/line-after-floating-div.html:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
platform/mac/fast/css/line-after-floating-div-expected.png: Copied from

LayoutTests/fast/css/line-after-floating-div-expected.png.

platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from

LayoutTests/fast/css/line-after-floating-div-expected.txt.

4:10 PM Changeset in webkit [94723] by timothy_horton@apple.com

1 edit
3 adds in trunk/LayoutTests

Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Added.
platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Added.
platform/chromium-win/svg/custom/simple-text-double-shadow.png: Added.

4:08 PM Changeset in webkit [94722] by abarth@webkit.org

6 edits in trunk/Tools

rebaseline button in garden-o-matic details view should work
https://bugs.webkit.org/show_bug.cgi?id=67738

Reviewed by Dimitri Glazkov.

This patch wires up the rebaseline button in garden-o-matic results
details view. The button is current per-test, so there isn't a way to
rebaseline individual bots. This is a place to start. If we decide we
want per-bot rebaselining, we'll need to think of some better UI.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

3:54 PM Changeset in webkit [94721] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21. This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6. I would really much
rather include a test with this patch, but my attempts to write a test
have failed. :(

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

3:49 PM Changeset in webkit [94720] by Nate Chapin

3 edits
7 adds
3 deletes in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium fast/css/ rebaslines.

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Added.
platform/chromium-linux/fast/css/getComputedStyle: Removed.
platform/chromium-linux/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-win/fast/css/line-after-floating-div-expected.txt: Added.

3:23 PM Changeset in webkit [94719] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, patch up some chromium gpu expectations
that are failing on the cg mac builds.

platform/chromium/test_expectations.txt:

3:19 PM Changeset in webkit [94718] by eric@webkit.org

5 edits in trunk/Tools

Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
https://bugs.webkit.org/show_bug.cgi?id=67737

Reviewed by Adam Barth.

I got a little over-eager when deprecating host.port_factory in the previous commit.
Turns out that Host.port_factory was already the "modern" port/factory.py
it was just the Module object. I un-deprecated the variable, and changed it from
being the module to being an actual PortFactory, passing it a host object.
I also taught PortFactory how to set user/executive/filesystem in the kwargs
when instantiating a new Port object.
This magically fixed the test_rebaseline test, since its now no longer talking
to the real filesystem.

Scripts/webkitpy/common/host.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/mocktool.py:

2:44 PM Changeset in webkit [94717] by eric@webkit.org

5 edits in trunk/Tools

Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
https://bugs.webkit.org/show_bug.cgi?id=67734

Reviewed by Adam Barth.

Right now every place that creates a Port object has to be very careful
to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
The correct fix is for port/factory.py (which creates most port objects)
to know how to pass these in automatically. However, currently all port/factory.py
functions are free functions instead of being on an object. This patch
adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.

In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
pass along the proper scm/user/filesystem to the Port object.

Scripts/webkitpy/common/host.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/mocktool.py:

2:42 PM Changeset in webkit [94716] by Chris Fleizach

4 edits
2 adds in trunk

Changes to aria-hidden don't change VO navigation
https://bugs.webkit.org/show_bug.cgi?id=67722

Reviewed by Darin Adler.

Source/WebCore:

When altering aria-hidden, WebCore needs to update the children caches of
affected elements. However, for elements that were children, but ignored, their
caches did not get updated, and stale information would be propagated.

The fix is to always clearChildren() when a parent is asking for children. This
ensures information is always up to date when the parent itself is asking for new data.

Test: accessibility/aria-hidden-updates-alldescendants.html

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

accessibility/aria-hidden-updates-alldescendants-expected.txt: Added.
accessibility/aria-hidden-updates-alldescendants.html: Added.

2:39 PM Changeset in webkit [94715] by Nate Chapin

2 edits
2 adds in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, upstream some chromium expected failure after skia roll,
and rebaseline 2 tests for leopard cg.

platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
platform/chromium/test_expectations.txt:

2:35 PM Changeset in webkit [94714] by timothy_horton@apple.com

22 edits
3 adds in trunk

Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Simon Fraser.

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::isInTransparencyLayer):

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::isInTransparencyLayer):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::getWindowsContext):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/win/ScrollbarThemeWin.cpp:
plugins/win/PluginViewWin.cpp:
rendering/RenderThemeWin.cpp:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
svg/custom/simple-text-double-shadow.svg: Added.

2:10 PM Changeset in webkit [94713] by abarth@webkit.org

3 edits in branches/chromium/835/Source/WebKit/chromium/src

Merge 94102 - [Chromium] Add null checks for document()->loader()
https://bugs.webkit.org/show_bug.cgi?id=67077

Reviewed by Nate Chapin.

Document::loader can return 0 for a number of reasons. Call sites need
to null check the result, like we do for Document::frame. I suspect
some of these are real crashes, along the lines of
http://trac.webkit.org/changeset/93692, but null checking this function
is just good practice.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageEncoding):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7782040

2:04 PM Changeset in webkit [94712] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.
Make the WONTFIX WIN LINUX for platform/chromium/rubberbanding/
FAIL instead of IMAGE, so it's less likely to flake out.

platform/chromium/test_expectations.txt:

2:01 PM Changeset in webkit [94711] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add the forgotten expected results for r94696.

fast/css/line-after-floating-div-expected.png: Added.
fast/css/line-after-floating-div-expected.txt: Added.

1:59 PM Changeset in webkit [94710] by mitz@apple.com

14 edits
5 adds in trunk

<rdar://problem/8881922> Support the hyphenate-limit-lines property
https://bugs.webkit.org/show_bug.cgi?id=67730

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit-lines.html

fast/text/hyphenate-limit-lines.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added hyphenate-limit-lines.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto. Valid values are non-negative integers and the keyword
"no-limit".

css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-lines.
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Added hyphenate-limit-lines.

css/CSSValueKeywords.in: Added the "no-limit" value keyword.
rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats): Count the number of consecutive hyphenated lines
before the start line and pass it to layoutRunsAndFloatsInRange().
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Keep track of the number of consecutive
hyphenated lines before the current line and pass it to LineBreaker::nextLineBreak().
(WebCore::tryHyphenating): Added parameters for the number of consecutive hyphenated lines before
the current line and the limit on consecutive hyphenated lines, and an early return if the limit
has been reached.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Added a parameter for the number of consecutive
hyphenated lines before the current line, which is passed through to tryHyphenating, along with
the value of hyphenate-limit-lines.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::isHyphenated): Added. Returns true if the line was hyphenated.

rendering/RootInlineBox.h:
rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitLines): Added this getter.
(WebCore::InheritedFlags::setHyphenationLimitLines): Added this setter.
(WebCore::InheritedFlags::initialHyphenationLimitLines): Added. The initial value is -1,
corresponding to "no-limit".

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize new member variable.
(WebCore::StyleRareInheritedData::operator==): Compare new member variable.

rendering/style/StyleRareInheritedData.h:

LayoutTests:

fast/css/parsing-hyphenate-limit-lines-expected.txt: Added.
fast/css/parsing-hyphenate-limit-lines.html: Added.
fast/text/hyphenate-limit-lines.html: Added.
platform/mac/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/mac/fast/text/hyphenate-limit-lines-expected.txt: Added.

1:58 PM Changeset in webkit [94709] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r94697.

platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

1:56 PM Changeset in webkit [94708] by Nate Chapin

5 edits
1 delete in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-win-xp/svg/transforms: Removed.
platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium/test_expectations.txt:

1:56 PM Changeset in webkit [94707] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r94441.
http://trac.webkit.org/changeset/94441
https://bugs.webkit.org/show_bug.cgi?id=67731

"MacEWSes are backed up due to new machines not able to reach
git.webkit.org. Disabling tests for now" (Requested by
eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

1:18 PM Changeset in webkit [94706] by ojan@chromium.org

10 edits in trunk/Source/WebCore

split overrideSize into overrideHeight and overrideWidth
https://bugs.webkit.org/show_bug.cgi?id=67550

Reviewed by Sam Weinig.

All uses of overrideSize only set one of the width or the height.
This change removes a bool from RenderObject and removes some
flexbox specific logic from RenderBox.

The only downside is that we have two global maps where we used
to have one.

No functional changes so existing tests are sufficient.

rendering/RenderBox.cpp:

(WebCore::RenderBox::hasOverrideHeight):
(WebCore::RenderBox::hasOverrideWidth):
(WebCore::RenderBox::setOverrideHeight):
(WebCore::RenderBox::setOverrideWidth):
(WebCore::RenderBox::clearOverrideSize):
(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):

rendering/RenderBox.h:
rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):

rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

rendering/RenderObject.h:
rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

rendering/RenderTableCell.h:
rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

1:13 PM Changeset in webkit [94705] by commit-queue@webkit.org

14 edits
25 adds in trunk

Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
https://bugs.webkit.org/show_bug.cgi?id=67511

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore:

Tests: platform/chromium-mac/rubberbanding/overhang-e.html

platform/chromium-mac/rubberbanding/overhang-n.html
platform/chromium-mac/rubberbanding/overhang-ne.html
platform/chromium-mac/rubberbanding/overhang-nw.html
platform/chromium-mac/rubberbanding/overhang-s.html
platform/chromium-mac/rubberbanding/overhang-se.html
platform/chromium-mac/rubberbanding/overhang-sw.html
platform/chromium-mac/rubberbanding/overhang-w.html

WebCore.exp.in:
platform/ScrollableArea.h:
testing/Internals.cpp:

(WebCore::Internals::setScrollViewPosition):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

platform/chromium-mac/rubberbanding: Added.
platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-e.html: Added.
platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-n.html: Added.
platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-s.html: Added.
platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-se.html: Added.
platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-w.html: Added.

1:06 PM Changeset in webkit [94704] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Release mode build fix.

1:00 PM Changeset in webkit [94703] by commit-queue@webkit.org

30 edits
2 adds in trunk

[Chromium] Render surface anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=66437

Patch by David Reveman <reveman@chromium.org> on 2011-09-07
Reviewed by James Robinson.

Source/WebCore:

Add CCLayerQuad class and CCLayerQuad::Edge subclass to allow
edge computations to be shared between tiled layers and render
surfaces. Move isCCW utility function to FloatQuad class and
add to2dTransform method to TransformationMatrix class. Add
necessary anti-aliasing shaders for render surfaces and use them
to avoid aliased edges.

Tests: compositing/reflections/nested-reflection-transformed.html (existing)

WebCore.gypi:
platform/graphics/FloatQuad.cpp:

(WebCore::FloatQuad::isCounterclockwise):

platform/graphics/FloatQuad.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::drawTexturedQuad):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::sharedGeometryQuad):

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaAA::FragmentShaderRGBATexAlphaAA):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentTexClampAlphaAABinding::FragmentTexClampAlphaAABinding):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::pointLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::edgeLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskSamplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::edgeLocation):

platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

platform/graphics/chromium/cc/CCLayerQuad.cpp: Added.

(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::floatQuad):
(WebCore::CCLayerQuad::toFloatArray):

platform/graphics/chromium/cc/CCLayerQuad.h: Added.

(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::Edge::x):
(WebCore::CCLayerQuad::Edge::y):
(WebCore::CCLayerQuad::Edge::z):
(WebCore::CCLayerQuad::Edge::setX):
(WebCore::CCLayerQuad::Edge::setY):
(WebCore::CCLayerQuad::Edge::setZ):
(WebCore::CCLayerQuad::Edge::set):
(WebCore::CCLayerQuad::Edge::moveX):
(WebCore::CCLayerQuad::Edge::moveY):
(WebCore::CCLayerQuad::Edge::moveZ):
(WebCore::CCLayerQuad::Edge::move):
(WebCore::CCLayerQuad::Edge::scaleX):
(WebCore::CCLayerQuad::Edge::scaleY):
(WebCore::CCLayerQuad::Edge::scaleZ):
(WebCore::CCLayerQuad::Edge::scale):
(WebCore::CCLayerQuad::Edge::intersect):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::left):
(WebCore::CCLayerQuad::top):
(WebCore::CCLayerQuad::right):
(WebCore::CCLayerQuad::bottom):
(WebCore::CCLayerQuad::inflateX):
(WebCore::CCLayerQuad::inflateY):
(WebCore::CCLayerQuad::inflate):
(WebCore::CCLayerQuad::inflateAntiAliasingDistance):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

platform/graphics/chromium/cc/CCRenderSurface.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:
platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::to2dTransform):

platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png:
platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
platform/chromium-gpu-linux/media/video-transformed-expected.png:
platform/chromium/test_expectations.txt:

12:51 PM Changeset in webkit [94702] by xji@chromium.org

2 edits in trunk/LayoutTests

Rebaseline after r93935.

platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

12:40 PM Changeset in webkit [94701] by oliver@apple.com

55 edits
2 deletes in trunk/Source

Remove JSObjectWithGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=67689

Reviewed by Geoff Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Remove JSObjectWithGlobalObject, and update code to stop using anonymous
storage to access the global object that a JSObject comes from. Largely
mechanical change to remove the use of anonymous storage and JSObjectWithGlobalObject.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):

API/JSCallbackConstructor.h:
API/JSCallbackObject.cpp:
API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::staticFunctionGetter):

API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

API/JSValueRef.cpp:

(JSValueIsObjectOfClass):

API/JSWeakObjectMapRefPrivate.cpp:
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:
dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):

jit/JIT.h:
jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFunction):

jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/DatePrototype.cpp:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):

runtime/InternalFunction.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):

runtime/JSFunction.h:

(JSC::JSFunction::create):
(JSC::JSFunction::createStructure):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):

runtime/JSONObject.h:
runtime/JSObject.h:

(JSC::JSObject::globalObject):

runtime/JSObjectWithGlobalObject.cpp: Removed.
runtime/JSObjectWithGlobalObject.h: Removed.
runtime/JSValue.cpp:

(JSC::JSValue::isValidCallee):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/Lookup.h:
runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):

runtime/MathObject.h:
runtime/NumberPrototype.cpp:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):

runtime/RegExpObject.h:
runtime/Structure.cpp:

(JSC::Structure::Structure):

runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::globalObject):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Remove use of anonymous storage and JSObjectWithGlobalObject for
accessing a JSObject's global object now that they're available
on the object's structure.

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):

bridge/runtime_object.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebKit2:

Remove JSObjectWithGlobalObject usage.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):

WebProcess/Plugins/Netscape/JSNPObject.h:

12:31 PM Changeset in webkit [94700] by commit-queue@webkit.org

8 edits in trunk

Tools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
Scripts/webkitpy/layout_tests/port/factory_unittest.py:

LayoutTests: now that layout tests distinguish between Core Graphics and Skia
expectations, update test_expectations accordingly.
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

platform/chromium/test_expectations.txt:

12:30 PM UsingGitWithWebKit edited by dpranke@chromium.org

(diff)

12:29 PM Changeset in webkit [94699] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Mac build fix after r94694.

WebCore.xcodeproj/project.pbxproj:

12:27 PM Changeset in webkit [94698] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

FELighting is using width instead of height to determine skip for parallel(n>2) case
https://bugs.webkit.org/show_bug.cgi?id=67719
<rdar://problem/10086178>

Reviewed by Dirk Schulze.

No new tests, because the bug only exhibits under conditions which are currently
impossible by default (using more than 2 cores) on some platforms.

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

12:20 PM Changeset in webkit [94697] by wjmaclean@chromium.org

9 edits
5 adds in trunk

Eliminate motion jitter in animated, blurred SVG image
https://bugs.webkit.org/show_bug.cgi?id=67503

Fixes filter shear-free transform applied to SVG images.

Source/WebCore:

In applyResource() the shearFreeAbsoluteTransform is applied to the drawing region,
which is based on the object bounding box (which doesn't move). For a rotation
around the centre of the box, this should really just be the identity matrix,
since the BB should neither change size nor location. So really, we're just interested
in the scale change of the BB here, and not in moving it.

This impacts how slices are extracted, and affects the {x|y}Mid and {x|y}Max extractions
for vertical and horizontal slices, so the test verifies these.

Reviewed by Dirk Schulze.

Test: svg/W3C-SVG-1.1-SE/filters-image-05-f.svg

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

Reviewed by Dirk Schulze.

platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-linux/svg/filters/filterRes-expected.png:
platform/chromium-linux/svg/filters/filterRes-expected.txt: Added.
platform/chromium/test_expectations.txt:
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg: Added.

12:14 PM Changeset in webkit [94696] by rniwa@webkit.org

4 edits
1 copy in trunk/LayoutTests

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by David Hyatt.

Fixed the test to properly attach load event listener on window instead of document.

Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.

css2.1/t090204-display-change-01-b-ao.html:
fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:

11:59 AM Changeset in webkit [94695] by robert@webkit.org

3 edits
6 adds in trunk

Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html

fast/block/positioning/positioned-float-layout-after-image-load.html

In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check. Do the same
for positioned floats in RenderBlock::positionedFloatsNeedRelayout(), although currently layoutPositionedObjects()
takes care of it this at least ensures no regression in future.

Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when

deciding whether to mark children for layout

(WebCore::RenderBlock::positionedFloatsNeedRelayout): ditto

LayoutTests:

fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
fast/block/positioning/absolute-layout-after-image-load.html: Added.
fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Added.
fast/block/positioning/positioned-float-layout-after-image-load.html: Added.
fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Added.

11:50 AM Changeset in webkit [94694] by commit-queue@webkit.org

8 edits
8 moves
1 add in trunk/Source/WebCore

Moving platform/track to html/track to avoid layering violation.
https://bugs.webkit.org/show_bug.cgi?id=67680

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-07
Reviewed by Adam Barth.

No new tests. No new functionality.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
html/track/CueParser.cpp: Renamed from Source/WebCore/platform/track/CueParser.cpp.
html/track/CueParser.h: Renamed from Source/WebCore/platform/track/CueParser.h.
html/track/CueParserPrivate.h: Renamed from Source/WebCore/platform/track/CueParserPrivate.h.
html/track/WebVTTParser.cpp: Renamed from Source/WebCore/platform/track/WebVTTParser.cpp.
html/track/WebVTTParser.h: Renamed from Source/WebCore/platform/track/WebVTTParser.h.
html/track/WebVTTToken.h: Renamed from Source/WebCore/platform/track/WebVTTToken.h.
html/track/WebVTTTokenizer.cpp: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.cpp.
html/track/WebVTTTokenizer.h: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.h.

11:48 AM Changeset in webkit [94693] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67286

REGRESSION: css2.1/t090204-display-change-01-b-ao.html fails after r94084.

Make sure that the trailing floats line box explicitly sets the line top with leading and line bottom with
leading to just be the block height.

Reviewed by Dan Bernstein.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::linkToEndLineIfNeeded):

11:32 AM Changeset in webkit [94692] by abarth@webkit.org

7 edits in trunk

[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-07
Reviewed by Darin Fisher.

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):

src/WebInputEventConversion.h:

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

11:16 AM Changeset in webkit [94691] by inferno@chromium.org

1 edit in branches/chromium/835/Source/WebCore/rendering/RenderScrollbar.cpp

Merge 94690 - Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
BUG=95552
Review URL: http://codereview.chromium.org/7782035

11:15 AM Changeset in webkit [94690] by inferno@chromium.org

2 edits in trunk/Source/WebCore

Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
https://bugs.webkit.org/show_bug.cgi?id=67669

Reviewed by James Robinson.

Owning renderer can be cleared for custom scrollbars in clearOwningRenderer()
call. We need a null check in updateScrollbarParts, so that we do not crash.

No tests since issue seen in crash reports only and I donot know a way to
reproduce.

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarParts):

11:14 AM Changeset in webkit [94689] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2011-09-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix after r94674.

inspector/debugger/script-formatter.html:

10:55 AM Changeset in webkit [94688] by barraclough@apple.com

9 edits in trunk/Source/JavaScriptCore

Refactor JIT checks for ObjectType into helper functions.

Rubber stamped by Sam Weinig.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchIfNotObject):

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JIT.h:
jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret_object_or_this):

jit/JITInlineMethods.h:

(JSC::JIT::emitJumpIfNotObject):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

10:55 AM Changeset in webkit [94687] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip media/media-controls-invalid-url.html on Mac for now because it has been failing.
The failure is tracked by the bug 67716.

platform/mac/Skipped:

10:41 AM Changeset in webkit [94686] by rniwa@webkit.org

1 edit
1 copy in trunk/LayoutTests

Finally, Mac rebaseline for r93237.

platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Copied from

LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt.

10:35 AM Changeset in webkit [94685] by jocelyn.turcotte@nokia.com

19 edits in trunk/Source

[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to.
https://bugs.webkit.org/show_bug.cgi?id=67606

Source/WebCore:

Reviewed by Noam Rosenthal.

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setKeepAndCoverAreaMultipliers):
(WebCore::TiledBackingStore::setCoverAreaFocusVector):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::calculateKeepRect):
(WebCore::TiledBackingStore::calculateCoverRect):

platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::getKeepAndCoverAreaMultipliers):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

Source/WebKit2:

UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportMotionVectorChanged):

UIProcess/API/qt/qtouchwebview.h:
UIProcess/API/qt/qtouchwebview_p.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::setVisibleContentRectMotionVector):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):

UIProcess/qt/ViewportInteractionEngine.h:
UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRectMotionVector):

UIProcess/qt/qtouchwebpageproxy.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRectMotionVector):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectMotionVector):

WebProcess/WebPage/TiledDrawingArea.h:

10:34 AM Changeset in webkit [94684] by rniwa@webkit.org

1 edit
1 copy in trunk/LayoutTests

Fix my accidental svn mv (instead of cp) in r94680.

fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from

LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt.

10:34 AM Changeset in webkit [94683] by Dimitri Glazkov

1 add in branches/chromium/874/codereview.settings

Added codereview.settings to 874 branch.

10:30 AM Changeset in webkit [94682] by Dimitri Glazkov

1 copy in branches/chromium/874

Branched for Chromium 874.

10:19 AM Changeset in webkit [94681] by jocelyn.turcotte@nokia.com

9 edits in trunk/Source

[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
https://bugs.webkit.org/show_bug.cgi?id=67416

Reviewed by Kenneth Rohde Christiansen.

Original code by Antti Koivisto.
With the current code, when the page is layouted during load, edge tiles will
get removed instead of continuing to show their front buffer while the tile
is being rendered for the new size.

Source/WebCore:

platform/graphics/Tile.h:
platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):

platform/graphics/TiledBackingStore.h:
platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::resize):

platform/graphics/qt/TileQt.h:

Source/WebKit2:

WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::resize):

WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

10:17 AM Changeset in webkit [94680] by rniwa@webkit.org

1 edit
1 move in trunk/LayoutTests

GTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.

fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from

LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt.

10:17 AM Changeset in webkit [94679] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Don't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTransform2DRotation
https://bugs.webkit.org/show_bug.cgi?id=67242
<rdar://problem/10069770>

Reviewed by Dirk Schulze.

No new tests, minor performance improvement.

platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::blend):
(WebCore::AffineTransform::decompose):
(WebCore::AffineTransform::recompose):

platform/graphics/transforms/AffineTransform.h:
rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clear2DRotation):

10:07 AM Changeset in webkit [94678] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

TiledDrawingArea: Fix issues where the tiles of the previous scale would be removed too early.
https://bugs.webkit.org/show_bug.cgi?id=67390

Reviewed by Tor Arne Vestbø.

The two issues addresssed are:

The previous instance of the tile backing store would be destroyed in createTile which would send removeTile messages for all its tiles before the DidRenderFrame message is sent for the new tiles.
When quickly changing the scale a second time after a scale change, the previous tile set would be replaced by the current incomplete tile set which may contain no tiles at all.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::createTile):

10:05 AM Changeset in webkit [94677] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has been failing.
The failure is tracked by the bug 67713.

platform/gtk/Skipped:

10:04 AM Changeset in webkit [94676] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::pathToLocalResource):
(LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource

9:43 AM Changeset in webkit [94675] by jocelyn.turcotte@nokia.com

3 edits in trunk/Source/WebKit2

[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
https://bugs.webkit.org/show_bug.cgi?id=67195

Reviewed by Tor Arne Vestbø.

Since tiledBackingStorePaintEnd is called even when no tile is dirty, the TiledDrawingArea
and its proxy are looping over DidRenderFrame and RenderNextFrame messages.
This causes QSGItem::update() to be called and consumes a lot of useless CPU cycles on the UI process.

Introduce a bool to send DidRenderFrame only when dirty content was rendered.

WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):

WebProcess/WebPage/TiledDrawingArea.h:

9:42 AM Changeset in webkit [94674] by podivilov@chromium.org

7 edits
2 adds in trunk

Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

inspector/debugger/raw-source-code-expected.txt: Added.
inspector/debugger/raw-source-code.html: Added.
inspector/debugger/script-formatter.html:
inspector/debugger/source-file.html:

9:40 AM Changeset in webkit [94673] by jocelyn.turcotte@nokia.com

17 edits in trunk/Source/WebKit2

[Qt][WK2] Make sure that the visible content rect and the content scale get to the web process in one single message.
https://bugs.webkit.org/show_bug.cgi?id=67189

Reviewed by Kenneth Rohde Christiansen.

The TiledBackingStore needs to know the screen size of the viewport to know how many tiles to
create, and since the visible content rect is given in page coordinates, the contents scale is
necessary to calculate the viewport size.
Both the rect and the scale then need to arrive to the web process at the same time to prevent
picking the new visible rect with the old scale or vice-versa which can produce a huge viewport size
and create/render an insane amount of tiles.

Things this patch does:

Merge the visible contents rect and content scale handling together.
Make QTouchWebView responsible for telling those viewport values to the web process instead of QTouchWebPage.
Prevent updating the viewport in ViewportInteractionEngine while a pinch is in progress and update the viewport at the end.

UIProcess/API/qt/qtouchwebpage.cpp:
UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/qtouchwebpage_p.h:
UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebView::geometryChanged):

UIProcess/API/qt/qtouchwebview.h:
UIProcess/API/qt/qtouchwebview_p.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::setVisibleContentRectAndScale):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::~ViewportInteractionEngine): Allows OwnPtr with the forward declaration of ViewportUpdateGuard.
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentViewportChanged):

UIProcess/qt/ViewportInteractionEngine.h:
UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRectAndScale):

UIProcess/qt/qtouchwebpageproxy.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRectAndScale):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):

WebProcess/WebPage/TiledDrawingArea.h:

9:35 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update on 3 more bots (diff)

9:18 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt to 4.7.4 and Mobility to 1.2.0 on 3 bots (diff)

8:54 AM Changeset in webkit [94672] by jocelyn.turcotte@nokia.com

7 edits
2 moves in trunk/Source/WebKit2

[Qt][WK2] Rename SGAgent to SGUpdateQueue to sharpen it's responsability.
https://bugs.webkit.org/show_bug.cgi?id=67122

Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

UIProcess/API/qt/qtouchwebpage_p.h:
UIProcess/qt/SGUpdateQueue.cpp: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.cpp.

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGUpdateQueue::SGUpdateQueue):
(WebKit::SGUpdateQueue::createTileNode):
(WebKit::SGUpdateQueue::removeTileNode):
(WebKit::SGUpdateQueue::setNodeBackBuffer):
(WebKit::SGUpdateQueue::swapTileBuffers):
(WebKit::SGUpdateQueue::applyUpdates):
(WebKit::SGUpdateQueue::getScaleNode):

UIProcess/qt/SGUpdateQueue.h: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.h.

(WebKit::SGUpdateQueue::isSwapPending):
(WebKit::NodeUpdate::NodeUpdate):
(WebKit::NodeUpdate::~NodeUpdate):

UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::updateWebView):
(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):

UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::sceneGraphUpdateQueue):

UIProcess/qt/TouchViewInterface.h:
WebKit2.pro:

8:15 AM Changeset in webkit [94671] by apavlov@chromium.org

5 edits in trunk

Web Inspector: Implement circular tabbing through the Styles sidebar pane contents
https://bugs.webkit.org/show_bug.cgi?id=67127

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/Section.js:

(WebInspector.Section.prototype.get firstSibling):
(WebInspector.Section.prototype.get lastSibling):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
(WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):

LayoutTests:

inspector/styles/styles-commit-editing.html:

8:09 AM Changeset in webkit [94670] by caseq@chromium.org

3 edits in trunk/LayoutTests

2011-09-07 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix (removed a call to console.trace() to avoid having platform-specific expectations).

inspector/extensions/extensions-console-expected.txt:
inspector/extensions/extensions-console.html:

7:12 AM Changeset in webkit [94669] by caryclark@google.com

16 edits
19 adds
181 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

platform/chromium-mac/media/media/video-defaultmuted-expected.txt: Removed.

(remaining files omitted for brevity)

6:33 AM Changeset in webkit [94668] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit2

[Qt] Unreviewed suppression of an unnecessary debug output.

UIProcess/API/qt/tests/qmltests/qmltests.pro:

6:30 AM Changeset in webkit [94667] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Symbian
https://bugs.webkit.org/show_bug.cgi?id=67706

Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.

(buildQMakeProject):

6:12 AM Changeset in webkit [94666] by caseq@chromium.org

8 edits
2 adds in trunk

2011-09-02 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506

Reviewed by Pavel Feldman.

Test: inspector/extensions/extensions-console.html

inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessage.prototype.get text): (WebInspector.ConsoleMessage.prototype.get parameters):
inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Console.prototype.getMessages): (WebInspector.injectedExtensionAPI.Console.prototype.addMessage): (WebInspector.injectedExtensionAPI.Console.prototype.get MessageLevel): (WebInspector.injectedExtensionAPI.Network.dispatchRequestEvent): (WebInspector.injectedExtensionAPI.Network): (WebInspector.injectedExtensionAPI.AuditCategoryImpl.dispatchAuditEvent): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceEvent): (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceContentEvent): (WebInspector.injectedExtensionAPI.InspectedWindow):
inspector/front-end/ExtensionCommon.js: (WebInspector.commonExtensionSymbols):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyConsoleMessageAdded): (WebInspector.ExtensionServer.prototype._onGetConsoleMessages): (WebInspector.ExtensionServer.prototype._onAddConsoleMessage): (WebInspector.ExtensionServer.prototype._makeConsoleMessage): (WebInspector.ExtensionServer.prototype._makeConsoleMessage.convertParameter): (WebInspector.ExtensionServer.prototype._dispatchCallback): (WebInspector.ExtensionServer.prototype.initExtensions):

2011-09-02 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506

Reviewed by Pavel Feldman.

http/tests/inspector/resources/extension-main.js:
inspector/extensions/extensions-api-expected.txt:
inspector/extensions/extensions-console-expected.txt: Added.
inspector/extensions/extensions-console.html: Added.

5:31 AM Changeset in webkit [94665] by caseq@chromium.org

3 edits in trunk/Source/WebCore

2011-09-05 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: disable popover when a mouse button is pressed
https://bugs.webkit.org/show_bug.cgi?id=67610

Reviewed by Pavel Feldman.

disable popover when a mouse button is pressed
disable popover in a SourceFrame when the source is being edited

inspector/front-end/Popover.js: (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype._mouseUp): (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._handleMouseAction):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._onHidePopover): (WebInspector.SourceFrame.prototype.doubleClick):

5:31 AM Changeset in webkit [94664] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

Update LayoutTests/platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-07

platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:

5:26 AM Changeset in webkit [94663] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Roll back r94655 with a small fix.

Scripts/webkitdirs.pm:

(buildQMakeProject):

4:10 AM Changeset in webkit [94662] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[WK2] evetSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening, skip dependent new test.

platform/wk2/Skipped: Skip fast/forms/number-input-changeevent.html.

3:36 AM Changeset in webkit [94661] by loislo@chromium.org

7 edits in trunk

Unreviewed, rolling out r94635.
http://trac.webkit.org/changeset/94635
https://bugs.webkit.org/show_bug.cgi?id=67704

Linux Touch build is failing to compile this change.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

src/WebInputEventConversion.h:

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

3:28 AM Changeset in webkit [94660] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed, rolling out r94655.
http://trac.webkit.org/changeset/94655
https://bugs.webkit.org/show_bug.cgi?id=67703

It broke Leopard debug bot (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Scripts/webkitdirs.pm:

3:16 AM Changeset in webkit [94659] by Antti Koivisto

17 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67634
De-virtualize styleForRenderer()

Reviewed by Sam Weinig.

This has performance and code clarity benefits.

move styleForRenderer from Node to Element
get rid of the now unnecessary NodeRenderingContext parameter
de-virtualize, add virtual customStyleForRenderer()

dom/Element.cpp:

(WebCore::Element::customStyleForRenderer):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):

dom/Element.h:
dom/Node.cpp:
dom/Node.h:

(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):
(WebCore::Node::hasCustomStyleForRenderer):
(WebCore::Node::setHasCustomStyleForRenderer):

Move styleForRenderer, add customStyleForRenderer, add a bit.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererAndStyle):

Handle non-element case separately since styleForRenderer was moved from Node to Element.

html/HTMLNoScriptElement.cpp:

(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::customStyleForRenderer):

html/HTMLNoScriptElement.h:

Move a strange XHTMLMP special case to where it belongs.

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::attach):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::attach):

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::textWithDirection):

html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):

html/shadow/TextControlInnerElements.h:
rendering/svg/SVGShadowTreeElements.cpp:

(WebCore::SVGShadowTreeContainerElement::customStyleForRenderer):

rendering/svg/SVGShadowTreeElements.h:
svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):

svg/SVGElement.h:

Adopt customStyleForRenderer().

3:07 AM Changeset in webkit [94658] by rniwa@webkit.org

12 edits
2 adds in trunk

Change event is not fired for input[type=number] when the user reverts a change made by script
https://bugs.webkit.org/show_bug.cgi?id=67697

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue not calling setTextAsOfLastFormControlChangeEvent
for text fields other than type=text.

Also fixed a that stepUpFromRenderer does not call setTextAsOfLastFormControlChangeEvent at appropriate
timing due to setValueAsNumber always passing sendChangeEvent=false to setValue by propagating values
through setValueAsNumber and applyStep. This refactoring allows us to remove calls to dispatch* in
stepUpFromRenderer because they're now called in setValueAsNumber or applyStep.

Test: fast/forms/number-input-changeevent.html

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsNumber):

html/BaseDateAndTimeInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::setValueAsNumber):

html/InputType.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsNumber):

html/NumberInputType.h:
html/RangeInputType.cpp:

(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):

html/RangeInputType.h:

LayoutTests:

Add a regression test to ensure WebKit fires change event when the user reverts a change made by script.

fast/forms/number-input-changeevent-expected.txt: Added.
fast/forms/number-input-changeevent.html: Added.

2:52 AM Changeset in webkit [94657] by Antti Koivisto

3 edits in trunk/Source/WebCore

Try to fix Qt build by moving the Qt specific include (which is not really allowed here!).

Not reviewed.

css/CSSStyleSelector.cpp:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkStateSlowCase):

2:36 AM Changeset in webkit [94656] by Antti Koivisto

12 edits
2 adds in trunk/Source/WebCore

Move SelectorChecker out from CSSStyleSelector scope
https://bugs.webkit.org/show_bug.cgi?id=67648

Reviewed by Sam Weinig.

Move SelectorChecker to SelectorChecker.h/cpp
Make private functions private
Make members private, add accessors
Move m_sameOriginOnly to CSSStyleSelector as it is not used by SelectorChecker

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::style):
(WebCore::CSSStyleSelector::parentStyle):
(WebCore::CSSStyleSelector::rootElementStyle):
(WebCore::CSSStyleSelector::element):
(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):
(WebCore::CSSStyleSelector::setZoom):
(WebCore::CSSStyleSelector::setEffectiveZoom):
(WebCore::CSSStyleSelector::setTextSizeAdjust):
(WebCore::CSSStyleSelector::setStyle):
(WebCore::CSSStyleSelector::fontSelector):
(WebCore::CSSStyleSelector::allVisitedStateChanged):
(WebCore::CSSStyleSelector::visitedStateChanged):
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::isRightPage):
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
(WebCore::CSSStyleSelector::styleNotYetAvailable):

css/SelectorChecker.cpp: Added.

(WebCore::SelectorChecker::SelectorChecker):
(WebCore::linkAttribute):
(WebCore::SelectorChecker::determineLinkStateSlowCase):
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::addLocalNameToSet):
(WebCore::createHtmlCaseInsensitiveAttributesSet):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::attributeQualifiedNameMatches):
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::allVisitedStateChanged):
(WebCore::SelectorChecker::visitedStateChanged):

css/SelectorChecker.h: Added.

(WebCore::SelectorChecker::document):
(WebCore::SelectorChecker::strictParsing):
(WebCore::SelectorChecker::isCollectingRulesOnly):
(WebCore::SelectorChecker::setCollectingRulesOnly):
(WebCore::SelectorChecker::isMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::setMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::pseudoStyle):
(WebCore::SelectorChecker::setPseudoStyle):
(WebCore::SelectorChecker::hasUnknownPseudoElements):
(WebCore::SelectorChecker::clearHasUnknownPseudoElements):
(WebCore::SelectorChecker::determineLinkState):

dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):

dom/SelectorQuery.h:

2:28 AM Changeset in webkit [94655] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Scripts/webkitdirs.pm:

2:24 AM Changeset in webkit [94654] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening after r94646.

platform/qt-mac/Skipped: Paint the Qt-Mac bot green.

2:23 AM Changeset in webkit [94653] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Revert expectation that was wrongly generated for textStyles.svg.

platform/chromium-linux/svg/batik/text/textStyles-expected.png:

2:21 AM Changeset in webkit [94652] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Unreviewed Windows rebaselines.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

2:17 AM Changeset in webkit [94651] by rniwa@webkit.org

2 edits in trunk/LayoutTests

One last GTK+ rebaseline for r94614.

platform/gtk/fast/js/global-constructors-expected.txt:

2:11 AM Changeset in webkit [94650] by rniwa@webkit.org

4 edits in trunk/LayoutTests

GTK+ rebaselines after r94614.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

2:06 AM Changeset in webkit [94649] by loislo@chromium.org

2 edits
3 deletes in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Rebaseline expectations after r94593

platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

12:55 AM Changeset in webkit [94648] by commit-queue@webkit.org

3 edits
1 add
11 deletes in trunk/LayoutTests

fast/dom/replaceChild.html may not test what it's supposed to test and may sometimes be flaky
https://bugs.webkit.org/show_bug.cgi?id=67629

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-07
Reviewed by Darin Adler.

The test is supposed to test Node.replaceChild() called from a frame.
However, in most cases, it's not executed because the test finishes before
the iframe's onload event handler. For now, the expected result is just
the original render tree before replaceChild(). In chance that iframe's
onload is executed earlier, the actual result might be different from
expected (that is, replaceChild() is executed and the DOM is actually changed.)

Use waitUntilDone() and notifyDone() to ensure the frame's onload handler
is called.

BTW changed it to a pure text test to avoid platform branches.

fast/dom/replaceChild.html:
fast/dom/replaceChild-expected.txt: Added.
fast/dom/resources/replaceChildHelper.html:
platform/chromium-linux/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-mac/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-win/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-win/fast/dom/replaceChild-expected.txt: Removed.
platform/gtk/fast/dom/replaceChild-expected.png: Removed.
platform/gtk/fast/dom/replaceChild-expected.txt: Removed.
platform/mac-leopard/fast/dom/replaceChild-expected.png: Removed.
platform/mac/fast/dom/replaceChild-expected.png: Removed.
platform/mac/fast/dom/replaceChild-expected.txt: Removed.
platform/qt/fast/dom/replaceChild-expected.png: Removed.
platform/qt/fast/dom/replaceChild-expected.txt: Removed.

12:50 AM Changeset in webkit [94647] by dslomov@google.com

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67413
[Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh.
This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController.

Reviewed by Yury Semikhatsky.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::clearInspector):

workers/WorkerContext.h:
workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):

12:45 AM Changeset in webkit [94646] by Csaba Osztrogonác

1 edit
6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results for new passing tests.

platform/qt/fast/borders/border-image-longhand-expected.png: Added.
platform/qt/fast/borders/border-image-longhand-expected.txt: Added.
platform/qt/fast/borders/border-image-scaled-expected.png: Added.
platform/qt/fast/borders/border-image-scaled-expected.txt: Added.
platform/qt/fast/borders/border-image-side-reduction-expected.png: Added.
platform/qt/fast/borders/border-image-side-reduction-expected.txt: Added.

12:12 AM Changeset in webkit [94645] by loislo@chromium.org

3 edits in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Rebaseline expectations for svg/batik/text/textStyles.svg after r94624.

platform/chromium-linux/svg/batik/text/textStyles-expected.png:
platform/chromium-win/svg/batik/text/textStyles-expected.txt:

12:01 AM Changeset in webkit [94644] by Csaba Osztrogonác

112 edits in trunk/Source

Unreviewed, rolling out r94627 and r94632.
http://trac.webkit.org/changeset/94627
http://trac.webkit.org/changeset/94632
https://bugs.webkit.org/show_bug.cgi?id=67698

It broke tests on GTK and Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/JavaScriptCore:

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):

API/JSCallbackFunction.h:
JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::create):

debugger/DebuggerActivation.h:
jsc.cpp:

(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

runtime/BooleanObject.h:

(JSC::BooleanObject::create):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

runtime/DateConstructor.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h:

(JSC::DateInstance::create):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

runtime/DatePrototype.h:
runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

runtime/ErrorConstructor.h:

(JSC::ErrorConstructor::create):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

runtime/FunctionPrototype.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

runtime/InternalFunction.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):

runtime/JSONObject.h:

(JSC::JSONObject::create):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSString.cpp:

(JSC::StringObject::create):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

runtime/MathObject.h:

(JSC::MathObject::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::constructorBody):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

runtime/NumberConstructor.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

runtime/NumberObject.h:

(JSC::NumberObject::create):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

runtime/RegExpObject.h:

(JSC::RegExpObject::create):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

runtime/StringObject.h:

(JSC::StringObject::create):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::create):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

bridge/c/CRuntimeObject.h:
bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

bridge/jni/jsc/JavaRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

bridge/runtime_array.h:

(JSC::RuntimeArray::create):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

Plugins/Hosted/ProxyRuntimeObject.h:
Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPMethod.h:
WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

WebProcess/Plugins/Netscape/JSNPObject.h:

Sep 6, 2011:

11:53 PM Changeset in webkit [94643] by yurys@chromium.org

8 edits
7 adds in trunk

fast/workers/worker-script-error.html fails on Chromium after r94061
https://bugs.webkit.org/show_bug.cgi?id=67206

Source/WebCore:

Default action should be prevented if window.onerror returned true and stay
not prevented otherwise.

Reviewed by Dmitry Titov.

Tests: fast/events/window-onerror14.html

fast/events/window-onerror15.html
fast/events/window-onerror16.html

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):
(WebCore::V8AbstractEventListener::shouldPreventDefault): allow specific
event listeners to decide when to prevent default action based on the handler
return value.

bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):
(WebCore::V8WindowErrorHandler::shouldPreventDefault):

bindings/v8/V8WindowErrorHandler.h:
bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
(WebCore::V8WorkerContextErrorHandler::shouldPreventDefault):

bindings/v8/V8WorkerContextErrorHandler.h:

LayoutTests:

Add a couple more tests for window.onerror handler that check whether
error message is printed to the console pending on the handler return
value.

Reviewed by Dmitry Titov.

fast/events/window-onerror14-expected.txt: Added.
fast/events/window-onerror14.html: Added.
fast/events/window-onerror15-expected.txt: Added.
fast/events/window-onerror15.html: Added.
fast/events/window-onerror16-expected.txt: Added.
fast/events/window-onerror16.html: Added.
platform/chromium/fast/events/window-onerror16-expected.txt: Added.

11:49 PM Changeset in webkit [94642] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: repair console sniffing for interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=67608

Reviewed by Pavel Feldman.

src/js/Tests.js:

(.TestSuite.prototype.evaluateInConsole_):

11:41 PM Changeset in webkit [94641] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit/qt

Unreviewed buildfix after r94620.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createFrame):

10:43 PM Changeset in webkit [94640] by commit-queue@webkit.org

54 edits in trunk/Source

Replace usages of Vector<UChar> with existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67079

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-06
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

This is part of work to support 8-bit string buffers.
Adds StringBuilder::characters() because the original Vector<UChar>::data()
is widely used.
Sets the minimum size of buffer to 16 to prevent possible performance
regression. Further performance investigation should be done in
https://bugs.webkit.org/show_bug.cgi?id=67084.

wtf/Forward.h:
wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendUninitialized): Sets minimum buffer size to 16 bytes.

wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters): Added.

Source/WebCore:

No new tests. All existing unit tests and layout tests should run
as before.

css/CSSOMUtils.cpp:

(WebCore::appendCharacter):
(WebCore::serializeCharacter):
(WebCore::serializeCharacterAsCodePoint):
(WebCore::serializeIdentifier):
(WebCore::serializeString):

css/CSSOMUtils.h:
css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase):

css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapeRect::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
(WebCore::CSSWrapShapePolygon::cssText):

editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat):

editing/MarkupAccumulator.cpp:

(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendAttributeValue):
(WebCore::MarkupAccumulator::appendCustomAttributes):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::MarkupAccumulator::appendEndMarkup):

editing/MarkupAccumulator.h:
editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::takeResults):
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::urlToMarkup):

html/DOMTokenList.cpp:

(WebCore::DOMTokenList::removeToken):

html/HTMLFontElement.cpp:

(WebCore::parseFontSize):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):

html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

html/parser/CSSPreloadScanner.h:
html/parser/HTMLEntityParser.cpp:

(WebCore::consumeHTMLEntity):

html/parser/HTMLEntityParser.h:
html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):
(WebCore::parseHTMLNonNegativeInteger):

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processEntity):
(WebCore::HTMLTokenizer::nextToken):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo):
(WebCore::HTMLTreeBuilder::defaultForInTableText):

html/parser/HTMLTreeBuilder.h:
inspector/InspectorValues.cpp:

(WebCore::InspectorValue::toJSONString):
(WebCore::InspectorValue::writeJSON):
(WebCore::InspectorBasicValue::writeJSON):
(WebCore::InspectorString::writeJSON):
(WebCore::InspectorObject::writeJSON):
(WebCore::InspectorArray::writeJSON):

inspector/InspectorValues.h:
loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendText):
(WebCore::SerializerMarkupAccumulator::appendElement):
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString):

platform/KURL.cpp:

(WebCore::KURL::deprecatedString):
(WebCore::decodeURLEscapeSequences):

platform/LinkHash.cpp:

(WebCore::squeezeOutNullCharacters):
(WebCore::cleanSlashDotDotSlashes):
(WebCore::mergeDoubleSlashes):
(WebCore::cleanSlashDotSlashes):
(WebCore::cleanPath):
(WebCore::visitedURLInline):
(WebCore::visitedURL):
(WebCore::visitedLinkHash):

platform/LinkHash.h:
platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURL):

platform/network/HTTPParsers.cpp:

(WebCore::extractMIMETypeFromMediaType):

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode):

platform/text/TextStream.cpp:

(WebCore::TextStream::operator<<):
(WebCore::TextStream::release):

platform/text/TextStream.h:
plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen):

rendering/InlineTextBox.h:

(WebCore::BufferForAppendingHyphen::BufferForAppendingHyphen):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::markerTextWithSuffix):

rendering/RenderListMarker.cpp:

(WebCore::toSymbolic):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::suffix):

rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables):

rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::decodeString):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders):

xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):
(WebCore::XPath::FunConcat::evaluate):

xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):
(WebCore::saveResultToString):

xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::unconsumeCharacters):
(WebCore::consumeCharacterReference):

xml/parser/XMLCharacterReferenceParser.cpp:

(WebCore::consumeXMLCharacterReference):

xml/parser/XMLCharacterReferenceParser.h:
xml/parser/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::nextToken):

10:33 PM Changeset in webkit [94639] by tkent@chromium.org

16 edits
2 adds in trunk

REGRESSION (Safari 5.1 - ToT): File input retains its file icon when the value is reset
https://bugs.webkit.org/show_bug.cgi?id=67567

Reviewed by Dimitri Glazkov.

Source/WebCore:

Introduce InputType::setValue(), which is called by HTMLInputElement::setValue().
Clear m_icon in FileInputType::setValue().

Tests: fast/forms/file/file-reset-in-change-expected.html

fast/forms/file/file-reset-in-change.html

html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):
Implemenation for the "default" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default

html/BaseButtonInputType.h:
html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):
Implemenation for the "default/on" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default-on

html/BaseCheckableInputType.h:
html/FileInputType.cpp:

(WebCore::FileInputType::setValue):
Implemenation for the "filename" mode, and clearing m_icon.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-filename

html/FileInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Move some code to InputType::setValue().
(WebCore::HTMLInputElement::setValueInternal): A helper for InputType::setValue().

html/HTMLInputElement.h:
html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):
Implementation for the "default" mode.

html/HiddenInputType.h:
html/InputType.cpp:

(WebCore::InputType::setValue):
Implementation for the "value" mode.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-value

html/InputType.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):
In addition to the "value" mode processing, updates placeholder visibililty.

html/TextFieldInputType.h:

LayoutTests:

fast/forms/file/file-reset-in-change-expected.html: Added.
fast/forms/file/file-reset-in-change.html: Added.

10:06 PM Changeset in webkit [94638] by rniwa@webkit.org

5 edits in trunk/LayoutTests

Qt rebaseline after r94614.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

9:43 PM Changeset in webkit [94637] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
https://bugs.webkit.org/show_bug.cgi?id=67681

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.

Test: fast/forms/suggested-value-after-setvalue.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

LayoutTests:

Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.

fast/forms/suggested-value-after-setvalue-expected.txt: Added.
fast/forms/suggested-value-after-setvalue.html: Added.

9:35 PM Changeset in webkit [94636] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix GTK build.

bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

9:35 PM Changeset in webkit [94635] by commit-queue@webkit.org

7 edits in trunk

[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-06
Reviewed by Darin Fisher.

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):

src/WebInputEventConversion.h:

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

9:34 PM Changeset in webkit [94634] by ap@apple.com

3 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67653

Reviewed by James Robinson.

fast/dom/HTMLMeterElement/meter-element-crash.html: Added waitUntilDone/notifyDone,

and changed "1" that's displayed after testing to "PASS".

9:25 PM Changeset in webkit [94633] by rniwa@webkit.org

5 edits in trunk/Source

fast/forms/suggested-value-crash.html crashes on Windows
https://bugs.webkit.org/show_bug.cgi?id=67688

Reviewed by Adam Barth.

Source/WebCore:

The crash was caused because functions in internals were accessing uninitialized QualifiedNames.
Fixed the bug by avoiding to link to inputTag and textareaTag. Instead, we resort to toInputElement
and string comparison.

testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):

Source/WebKit2:

Removed sybmols for inputTag and textareaTag. Added the symbol for StringImpl::equal.

win/WebKit2.def:
win/WebKit2CFLite.def:

9:22 PM Changeset in webkit [94632] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix broken snow leopard build
https://bugs.webkit.org/show_bug.cgi?id=67693

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Daniel Bates.

Removed unnecessary symbol export.

JavaScriptCore.exp:

8:41 PM Changeset in webkit [94631] by abarth@webkit.org

5 edits in trunk/Tools

garden-o-matic details view should having working rebaseline and next/previous buttons
https://bugs.webkit.org/show_bug.cgi?id=67659

Reviewed by Dimitri Glazkov.

This patch wires up basic back/forward buttons that let you traverse
through the results we're examining in the details view. This ended up
being more code than I expected, but I wanted to keep all the state
information in the DOM itself.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

8:00 PM Changeset in webkit [94630] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Fix WebFrameClient receiving isRedirect when reloading
https://bugs.webkit.org/show_bug.cgi?id=63591

Patch by Ben Smith <binji@chromium.org> on 2011-09-06
Reviewed by Adam Barth.

Fix bug when quickly reloading a WebFrame where the
WebFrameClient would get called with decidePolicyForNavigation
isRedirect=true.

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

src/WebDataSourceImpl.h:

(WebKit::WebDataSourceImpl::isRedirect):

tests/WebFrameTest.cpp:

(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):
(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
(WebKit::TEST_F):

7:47 PM Changeset in webkit [94629] by fpizlo@apple.com

18 edits
1 add in trunk/Source/JavaScriptCore

DFG JIT does not optimize booleans
https://bugs.webkit.org/show_bug.cgi?id=67670

Reviewed by Gavin Barraclough.

This adds boolean value profiling, boolean prediction in the DFG,
boolean forward flow propagation in the DFGPropagator, boolean
data format in DFG generation info, and comprehensive optimizations
based on both boolean prediction and boolean generation info.
This is brings the speed-up on v8-richards to 12%, and gives slight
speed-ups elsewhere as well.

Making this work right required navigating some subtleties in
value profiling. Some functions get compiled with insufficient
information because some important path of the function never
executed. In these cases, we wish to fall back on static
speculation. But to do so, we need to ensure that predictions that
are inherent in the code (like that GetById almost certainly takes
a cell operand) are reflected in predictions that we make in
DFGPropagator. Thus, DFGPropagator now does both backward and
forward flow, using a both forward and backward fixpoint.

The backward flow in DFGPropagator is a separate static analysis,
and needs to keep a set of backward flow abstract values for
variables, arguments, and globals. To make this easy, this patch
factors out DFGGraph's prediction tracking capability into
DFGPredictionTracker, which now gets used by both DFGGraph (for
forward flow predictions) and DFGPropagator (for backward flow
predictions). Backward flow predictions eventually get merged
into forward flow ones, but the two are not equivalent: a forward
flow prediction is a superset of the backward flow prediction.

Debugging these prediction issues required a better understanding
of where we fail speculation, and what our value predictions look
like. This patch also adds optional verbose speculation failure
(so an informative printf fires whenever speculation failure occurs)
and slight improvements to the verbosity in other places.

bytecode/ValueProfile.h:

(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::probabilityOfBoolean):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGenerationInfo.h:

(JSC::DFG::dataFormatToString):
(JSC::DFG::needDataFormatConversion):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predictions):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::GPRTemporary::GPRTemporary):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isBooleanConstant):
(JSC::DFG::JITCodeGenerator::valueOfBooleanConstant):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::isBooleanConstant):
(JSC::DFG::JITCompiler::valueOfBooleanConstant):

dfg/DFGNode.h:

(JSC::DFG::isBooleanPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePredictions):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::valueOfBooleanConstant):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::hasNumericResult):
(JSC::DFG::Node::predict):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionTracker.h: Added.

(JSC::DFG::operandIsArgument):
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::PredictionTracker::PredictionTracker):
(JSC::DFG::PredictionTracker::initializeSimilarTo):
(JSC::DFG::PredictionTracker::numberOfArguments):
(JSC::DFG::PredictionTracker::numberOfVariables):
(JSC::DFG::PredictionTracker::argumentIndexForOperand):
(JSC::DFG::PredictionTracker::predictArgument):
(JSC::DFG::PredictionTracker::predict):
(JSC::DFG::PredictionTracker::predictGlobalVar):
(JSC::DFG::PredictionTracker::getArgumentPrediction):
(JSC::DFG::PredictionTracker::getPrediction):
(JSC::DFG::PredictionTracker::getGlobalVarPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::~SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::index):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):

runtime/JSGlobalData.h:
runtime/JSValue.cpp:

(JSC::JSValue::description):

7:35 PM Changeset in webkit [94628] by commit-queue@webkit.org

41 edits
1 copy
6 moves
4 adds
12 deletes in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia)
https://bugs.webkit.org/show_bug.cgi?id=67596

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Kenneth Russell.

fast/backgrounds/gradient-background-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt.
fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt.
fast/box-shadow/spread-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/spread-expected.txt.
fast/css/box-shadow-and-border-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt.
fast/css/color-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/color-leakage-expected.txt.
fast/css/nested-rounded-corners-expected.txt:
platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
platform/chromium-linux/fast/: 17 changes
platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png: Added.
platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
platform/chromium-win/fast/: 19 changes
platform/chromium/test_expectations.txt:
platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Renamed from LayoutTests/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png.
platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
platform/mac/fast/: 5 files removed
platform/mac/fast/css/nested-rounded-corners-expected.txt: Copied from LayoutTests/fast/css/nested-rounded-corners-expected.txt.
platform/qt/: 6 files removed

7:13 PM Changeset in webkit [94627] by commit-queue@webkit.org

112 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::finishCreation):

API/JSCallbackFunction.h:
JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:
debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::finishCreation):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):
(JSC::BooleanConstructor::finishCreation):

runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

runtime/BooleanObject.h:

(JSC::BooleanObject::create):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::finishCreation):

runtime/DateConstructor.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h:

(JSC::DateInstance::create):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):
(JSC::DatePrototype::finishCreation):

runtime/DatePrototype.h:
runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):
(JSC::ErrorConstructor::finishCreation):

runtime/ErrorConstructor.h:
runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):
(JSC::FunctionConstructor::finishCreation):

runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::finishCreation):

runtime/FunctionPrototype.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

runtime/InternalFunction.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):

runtime/JSONObject.h:

(JSC::JSONObject::create):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSString.cpp:

(JSC::StringObject::create):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

runtime/MathObject.h:

(JSC::MathObject::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):
(JSC::NumberConstructor::finishCreation):

runtime/NumberConstructor.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

runtime/NumberObject.h:

(JSC::NumberObject::create):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::finishCreation):

runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpMatchesArray::RegExpMatchesArray):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

runtime/RegExpObject.h:

(JSC::RegExpObject::create):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::finishCreation):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

runtime/StringObject.h:

(JSC::StringObject::create):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

No new tests.

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::create):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):

bridge/c/CRuntimeObject.h:
bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
(JSC::Bindings::JavaRuntimeObject::finishCreation):

bridge/jni/jsc/JavaRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

bridge/runtime_array.h:

(JSC::RuntimeArray::create):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):
(JSC::RuntimeMethod::finishCreation):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

Plugins/Hosted/ProxyRuntimeObject.h:
Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):

Source/WebKit2:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::finishCreation):

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

7:09 PM Changeset in webkit [94626] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Update chromium gpu baseline due to skia roll

platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:

7:07 PM Changeset in webkit [94625] by macpherson@chromium.org

3 edits in trunk/Source/WebCore

Implement list style properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67103

Reviewed by Eric Seidel.

No new tests / no behavioral changes.

css/CSSStyleApplyProperty.cpp:

Add class to wrap call to CSSStyleSelector::styleImage().
(WebCore::ApplyPropertyStyleImage::ApplyPropertyStyleImage):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handlers for list style properties.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing property implementations.

7:05 PM Changeset in webkit [94624] by jamesr@google.com

7 edits
2 copies in trunk/LayoutTests

[chromium] Update various chromium baselines.

platform/chromium-cg-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png:
platform/chromium-cg-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt.
platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/wrapper-classes-expected.txt.
platform/chromium-win/svg/batik/text/textStyles-expected.png:
platform/chromium-win/svg/batik/text/textStyles-expected.txt:
platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/chromium/fast/dom/wrapper-classes-expected.txt:

7:05 PM Changeset in webkit [94623] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Accessibility tests crashing in BasicRawSentinelNode code
https://bugs.webkit.org/show_bug.cgi?id=67682

Reviewed by Geoffrey Garen.

A CodeBlock should ensure that no other CodeBlocks have references to it after
it is destroyed.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

7:00 PM Changeset in webkit [94622] by commit-queue@webkit.org

4 edits
2 adds in trunk

Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=67486
This reverts r65993 which gives wrong results for rshift
in some corner cases (see the test).

Patch by Yong Li <yoli@rim.com> on 2011-09-06
Reviewed by Gavin Barraclough.

New test: fast/js/floating-point-truncate-rshift.html

assembler/ARMAssembler.h:
assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=67486
Add a test case for branchTruncateDoubleToInt32() which is
used in right shift optimization when the assembler
"supportsFloatingPointTruncate".

Patch by Yong Li <yoli@rim.com> on 2011-09-06
Reviewed by Gavin Barraclough.

fast/js/floating-point-truncate-rshift-expected.txt: Added.
fast/js/floating-point-truncate-rshift.html: Added.

6:58 PM Changeset in webkit [94621] by mrowe@apple.com

5 edits in trunk/Source

Versioning.

6:55 PM Changeset in webkit [94620] by alexis.menard@openbossa.org

16 edits in trunk/Source

[Qt] Move away from QPointer as it is slow and it has a replacement QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=67673

Reviewed by Ariya Hidayat.

Source/WebCore:

Move away from QPointer to QWeakPointer, it is faster.

No new tests, the existing ones should cover.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::getClass):
(JSC::Bindings::QtField::name):
(JSC::Bindings::QtField::valueFromInstance):

bridge/qt/qt_instance.h:

(JSC::Bindings::QtInstance::getObject):

bridge/qt/qt_runtime.h:
platform/qt/SharedTimerQt.cpp:

(WebCore::SharedTimerQt::inst):

Source/WebKit/qt:

Move away from QPointer as Qt provides a better and faster solution : QWeakPointer.

Api/qwebframe.cpp:

(QWebHitTestResult::linkTargetFrame):
(QWebHitTestResult::frame):

Api/qwebframe_p.h:
Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::acceptNavigationRequest):
(QWebPagePrivate::createMainFrame):
(QWebPagePrivate::updateAction):
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPage::createStandardContextMenu):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::focusInEvent):
(QWebPage::setPalette):
(QWebPagePrivate::touchEvent):
(QWebPage::~QWebPage):
(QWebPage::mainFrame):
(QWebPage::viewportSize):
(QWebPage::preferredContentsSize):
(QWebPage::setContentEditable):
(QWebPage::updatePositionDependentActions):

Api/qwebpage_p.h:
Api/qwebview.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::contextMenu):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createFrame):

tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::ownership):

tests/qwebpage/tst_qwebpage.cpp:

(PluginCounterPage::PluginCounterPage):
(PluginTracerPage::createPlugin):
(tst_QWebPage::createViewlessPlugin):

tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):

6:54 PM Changeset in webkit [94619] by mrowe@apple.com

1 copy in tags/Safari-535.2

New tag.

6:43 PM Changeset in webkit [94618] by dpranke@chromium.org

3 edits
1 add in trunk/Tools

fix MockFileSystem.glob(), refactor filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=67462

Reviewed by Eric Seidel.

In debugging why my proposed change for MockFileSystem.glob()
in bug 66228 didn't work, I stumbled across two real bugs
that cancelled each other out for the unit tests. I fixed those
(glob shouldn't recurse into subdirs, and we weren't populating
self.dirs from self.files properly).

I have also created a "mixin" class for tests that can be shared
between the real filesystem and the mock filesystem - MockFileSystem
is being used enough it needs its own tests.

Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
Scripts/webkitpy/common/system/filesystem_unittest.py:

6:25 PM Changeset in webkit [94617] by oliver@apple.com

9 edits in trunk/Source/WebCore

Update expected results of bindings tests.

4:36 PM Changeset in webkit [94616] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for r94559.

Marked the relevant parameters as unused if !ENABLE(JIT), and surrounded
new out-of-line JIT-specific method definitions with !ENABLE(JIT).

bytecode/CodeBlock.cpp:
runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

4:30 PM Changeset in webkit [94615] by abarth@webkit.org

4 edits
1 delete in trunk/LayoutTests

editing/selection/mixed-editability-10.html is failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=67683

Update editing/selection/mixed-editability-10.html baselines after
HTMLSpanElement introduction.

editing/selection/mixed-editability-10-expected.txt:
platform/qt/editing/selection/mixed-editability-10-expected.png: Removed.
- This test is no longer an image test.
platform/qt/editing/selection/mixed-editability-10-expected.txt:
platform/win/editing/selection/mixed-editability-10-expected.txt:

4:26 PM Changeset in webkit [94614] by eric@webkit.org

26 edits
3 deletes in trunk

Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1)
https://bugs.webkit.org/show_bug.cgi?id=67678

Reviewed by Darin Adler.

This is why we can't have nice things.

There was some confusion in the original DOM HTML 1 spec about
the existence of HTMlBlockquoteElement which was clarified by
a later errata, removing HTMLBlockquoteElement:
http://www.w3.org/DOM/updates/REC-DOM-Level-1-19981001-errata.html
"This interface is an error and must be ignored. The Interface HTMLQuoteElement is used for both the Q and BLOCKQUOTE elements"

Le sigh. Personally I think having a separate HTMLBlockquoteElement
is clearer, but thats not how the web works. Removed it and updated test results.

CMakeLists.txt:
CodeGenerators.pri:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/gobject/GNUmakefile.am:
editing/IndentOutdentCommand.cpp:
html/HTMLBlockquoteElement.cpp: Removed.
html/HTMLBlockquoteElement.h: Removed.
html/HTMLBlockquoteElement.idl: Removed.
html/HTMLElementsAllInOne.cpp:
html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::HTMLQuoteElement):
(WebCore::HTMLQuoteElement::insertedIntoDocument):

html/HTMLTagNames.in:
page/DOMWindow.idl:

4:06 PM Changeset in webkit [94613] by rniwa@webkit.org

19 edits in trunk/Source

Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
https://bugs.webkit.org/show_bug.cgi?id=67569

Reviewed by Antonio Gomes.

Source/WebCore:

Renamed Editor::confirmCompositionWithoutDisturbingSelection to Editor::cancelComposition.
Also renamed the shared function from confirmComposition to setComposition.

WebCore.exp.in:
editing/Editor.cpp:

(WebCore::Editor::confirmComposition):
(WebCore::Editor::cancelComposition):
(WebCore::Editor::setComposition):

editing/Editor.h:

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::unmarkText):

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection):

Source/WebKit/mac:

WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

WebView.cpp:

(WebView::resetIME):

Source/WebKit2:

UIProcess/API/mac/WKView.mm:

(-[WKView resignFirstResponder]):
(-[WKView _updateTextInputStateIncludingSecureInputState:]):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::cancelComposition):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::cancelComposition):

3:57 PM Changeset in webkit [94612] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Update expectations for a few tests that render oddly on xp due to r94589

platform/chromium/test_expectations.txt:

3:56 PM Changeset in webkit [94611] by mrowe@apple.com

5 edits in branches/safari-534.51-branch/Source

Versioning.

3:56 PM Changeset in webkit [94610] by mrowe@apple.com

1 copy in tags/Safari-534.51.21

New tag.

3:52 PM Changeset in webkit [94609] by weinig@apple.com

2 edits in trunk/Source/WebCore

WebVTTTokenizer files in the wrong place in the Xcode project.

WebCore.xcodeproj/project.pbxproj:

Move WebVTTTokenizer files so they are in the right place in the project.

3:51 PM Changeset in webkit [94608] by crogers@google.com

5 edits
2 adds in trunk

MediaElementAudioSourceNode destruction triggers ASSERTS
https://bugs.webkit.org/show_bug.cgi?id=67665

Reviewed by Nate Chapin.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode-gc.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setAudioSourceNode):

webaudio/AudioContext.cpp:

(WebCore::AudioContext::uninitializeDispatch):
(WebCore::AudioContext::stop):

webaudio/AudioContext.h:

LayoutTests:

webaudio/mediaelementaudiosourcenode-gc-expected.txt: Added.
webaudio/mediaelementaudiosourcenode-gc.html: Added.

3:45 PM Changeset in webkit [94607] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix broken PPC build due to new dtoa library
https://bugs.webkit.org/show_bug.cgi?id=67654

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
Reviewed by Dan Bernstein.

Added condition for PPC in the new dtoa compatibility check so that
building won't fail.

wtf/dtoa/utils.h:

3:36 PM Changeset in webkit [94606] by kbr@google.com

2 edits in branches/chromium/835/Source

Merge http://trac.webkit.org/changeset/93131 : GraphicsContext3D should allow its hostWindow to be NULL .

Pass 0 to SharedGraphicsContext3D::create.

Merge definition of CanvasRenderingContext2D::paintsIntoCanvasBuffer from http://trac.webkit.org/changeset/93157 .

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=94163

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7839014

3:29 PM Changeset in webkit [94605] by jamesr@google.com

9 edits
3 copies
11 adds in trunk/LayoutTests

[chromium] Update pixel baselines for r94597

platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png: Added.
platform/chromium-cg-mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
platform/chromium-cg-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/chromium-linux/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png:
platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
platform/chromium-win/fast/borders/border-image-longhand-expected.png: Added.
platform/chromium-win/fast/borders/border-image-longhand-expected.txt: Added.
platform/chromium-win/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-win/fast/borders/border-image-scaled-expected.txt: Added.
platform/chromium-win/fast/borders/border-image-side-reduction-expected.png: Added.
platform/chromium-win/fast/borders/border-image-side-reduction-expected.txt: Added.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

3:19 PM Changeset in webkit [94604] by abarth@webkit.org

3 edits
2 copies in trunk/Source/WebKit/chromium

[Chromium] Add WebFloatQuad.h for Android
https://bugs.webkit.org/show_bug.cgi?id=67573

Reviewed by Darin Fisher.

Android uses this wrapper of WebCore::FloatQuad in some API methods
(which will appear in subsequent patches).

WebKit.gyp:
public/WebFloatQuad.h: Added.
src/WebFloatQuad.cpp: Added.

3:19 PM Changeset in webkit [94603] by mrowe@apple.com

4 edits in branches/safari-534.51-branch/Source

Merge r94251.

3:17 PM WebKit Team edited by davidbarr@chromium.org

(diff)

3:17 PM Changeset in webkit [94602] by mrowe@apple.com

2 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r94478.

3:15 PM Changeset in webkit [94601] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit/qt

[Qt] Fix API test failure after r92823 and r93001.
https://bugs.webkit.org/show_bug.cgi?id=67676

Reviewed by Kenneth Rohde Christiansen.

r92823 and r93001 make WebKit no longer produce wrapping style
spans on copy and paste and class="Apple-style-span" anymore.
Our expectations need to be updated.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::cursorMovements):
(tst_QWebPage::textSelection):
(tst_QWebPage::findText):

2:51 PM Changeset in webkit [94600] by abarth@webkit.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Add didAcceptIndices to ExternalPopupMenuClient for Android
https://bugs.webkit.org/show_bug.cgi?id=67574

Reviewed by Darin Fisher.

In Android, external popup menus can admit multiple selection (e.g.,
for listboxes presented using external UI).

public/WebExternalPopupMenuClient.h:
src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::didAcceptIndices):

src/ExternalPopupMenu.h:

2:51 PM Changeset in webkit [94599] by oliver@apple.com

100 edits in trunk/Source

An object's structure should reference the global object responsible for its creation
https://bugs.webkit.org/show_bug.cgi?id=67624

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add a reference to a GlobalObject to Structure, and update all calls to
Structure::create() to pass the global object that is the origin for that
structure. For objects where the appropriate global object isn't available
at construction time (global object prototypes, etc), or objects that
logically don't have a global object (strings, etc) we just pass null.

This change is largely mechanical (passing a new globalObject parameter
around).

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::createStructure):

API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::createStructure):

API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):

API/JSContextRef.cpp:
JavaScriptCore.exp:
debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::createStructure):

runtime/Arguments.h:

(JSC::Arguments::createStructure):

runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::createStructure):

runtime/BooleanObject.h:

(JSC::BooleanObject::createStructure):

runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

runtime/DateInstance.h:

(JSC::DateInstance::createStructure):

runtime/DatePrototype.h:

(JSC::DatePrototype::createStructure):

runtime/ErrorInstance.h:

(JSC::ErrorInstance::createStructure):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure):

runtime/Executable.h:

(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::createStructure):

runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

runtime/InternalFunction.h:

(JSC::InternalFunction::createStructure):

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

runtime/JSActivation.h:

(JSC::JSActivation::createStructure):

runtime/JSArray.h:

(JSC::JSArray::createStructure):

runtime/JSByteArray.cpp:

(JSC::JSByteArray::createStructure):

runtime/JSByteArray.h:
runtime/JSFunction.h:

(JSC::JSFunction::createStructure):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):

runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::createStructure):

runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):

runtime/JSObject.h:

(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):
(JSC::createEmptyObjectStructure):

runtime/JSObjectWithGlobalObject.h:

(JSC::JSObjectWithGlobalObject::createStructure):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::createStructure):

runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::createStructure):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::createStructure):

runtime/MathObject.h:

(JSC::MathObject::createStructure):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::createStructure):
(JSC::NativeErrorConstructor::constructorBody):

runtime/NumberConstructor.h:

(JSC::NumberConstructor::createStructure):

runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

runtime/RegExp.h:

(JSC::RegExp::createStructure):

runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::createStructure):

runtime/RegExpObject.h:

(JSC::RegExpObject::createStructure):

runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::createStructure):

runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure):

runtime/StringObject.h:

(JSC::StringObject::createStructure):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):

runtime/StringPrototype.h:

(JSC::StringPrototype::createStructure):

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::visitChildren):

runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::globalObject):
(JSC::Structure::setGlobalObject):

runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

Source/JavaScriptGlue:

Update for Structure::create() requiring a global object.

JSRun.h:

(JSGlueGlobalObject::create):

UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

Update calls to Structure::create() to pass the globalObject in,
and update the CodeGenerator to generate appropriate createStructure
methods.

bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::createStructure):

bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::createStructure):
(WebCore::getDOMStructure):

bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::createStructure):
(WebCore::getDOMConstructor):

bindings/js/JSDOMWindowBase.h:

(WebCore::JSDOMWindowBase::createStructure):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::createStructure):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::createStructure):

bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::createStructure):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::createStructure):

bindings/js/JSWorkerContextBase.h:

(WebCore::JSWorkerContextBase::createStructure):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):

bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::createStructure):

bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::createStructure):

bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::createStructure):

bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::createStructure):

bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::createStructure):

bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::createStructure):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::createStructure):

bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):

bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::createStructure):

Source/WebKit/mac:

Update for new Structure::create() globalObject parameter.

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::createStructure):

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

Source/WebKit2:

Update for new Structure::create globalObject parameter.

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::create):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

2:50 PM Changeset in webkit [94598] by andersca@apple.com

8 edits
3 moves in trunk

Move NPAPI headers in bridge to plugins
https://bugs.webkit.org/show_bug.cgi?id=67661

Source/WebCore:

Reviewed by Darin Adler.

WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Update build systems.

bridge/npapi.h: Removed.
bridge/npruntime.h: Removed.
bridge/nptypes.h: Removed.
plugins/npapi.h: Copied from Source/WebCore/bridge/npapi.h.
plugins/npruntime.h: Copied from Source/WebCore/bridge/npruntime.h.
plugins/nptypes.h: Copied from Source/WebCore/bridge/nptypes.h.

Tools:

Update forwarding headers.

DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:

2:45 PM Changeset in webkit [94597] by hyatt@apple.com

14 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=67672

Improve background-size parsing. Make it actually dump auto values properly, and also make it omit
auto if it is the second value. Fix the parsing to not create a value list when only a singleton value
is specified.

Reviewed by Beth Dakin.

Covered well by existing tests.

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillSizeToCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapFillSize):

LayoutTests:

fast/backgrounds/size/parsing-background-size-values-expected.txt:
fast/backgrounds/size/parsing-inherit-expected.txt:
fast/backgrounds/size/resources/parsing-background-size-values.js:
fast/backgrounds/size/resources/parsing-inherit.js:
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt:
fast/css/value-list-out-of-bounds-crash.html:
svg/css/getComputedStyle-basic-expected.txt:

2:18 PM Changeset in webkit [94596] by hyatt@apple.com

1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

Fix build bustage from accidental project file addition.

1:41 PM Changeset in webkit [94595] by hyatt@apple.com

5 edits in trunk/LayoutTests

Update some layout test results following the improved Pair parsing code that landed in r94593.

fast/backgrounds/size/parsing-background-size-values-expected.txt:
fast/backgrounds/size/resources/parsing-background-size-values.js:
fast/reflections/reflection-computed-style-expected.txt:
inspector/elements/elements-panel-styles-expected.txt:

1:37 PM Changeset in webkit [94594] by fpizlo@apple.com

1 edit
3 adds in trunk/LayoutTests

LayoutTests does not include a test for DFG speculation recovery of additions
https://bugs.webkit.org/show_bug.cgi?id=67667

Reviewed by Geoffrey Garen.

fast/js/add-recovery-expected.txt: Added.
fast/js/add-recovery.html: Added.
fast/js/script-tests/add-recovery.js: Added.

(destructiveAddForBoxedInteger):

1:32 PM Changeset in webkit [94593] by hyatt@apple.com

27 edits
9 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=67657

Implement border-image-width. This patch stops short of converting -webkit-border-image to a shorthand.
I'll do that in the next patch.

Note that unlike the -webkit-border-image syntax, border-image-width does not actually set the border
width values. It simply makes cuts into the border image drawing area (which for now is just the border
box, but that will change once border-image-outset is implemented).

This means we need additional storage for the slices, since they are now separate from the border widths.

For backwards compatibility, -webkit-border-image will continue to set the border widths when
border-image-width is specified in the -webkit-border-image shorthand.

Reviewed by Beth Dakin.

Source/WebCore:

Added new tests in fast/borders.

css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
(WebCore::CSSBorderImageSliceValue::cssText):

css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::create):
(WebCore::CSSBorderImageSliceValue::slices):
Rename slices() to imageSlices() and add borderSlices() and m_borderSlices to hold the desired cuts
for the border image drawing area. Converted the slices over to the new Quad primitive value (a RectBase
subclass that is identical to Rect but dumps as a quad instead of a rect primitive).

css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Make CSSBorderImageValue take the border slices during construction now.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageWidth):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for computed style via valueForNinePieceImageWidth. Patch all of the border image properties
to dump the most compact form possible for the property values, e.g., "stretch stretch" becomes "stretch."

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageWidthParseContext::BorderImageWidthParseContext):
(WebCore::BorderImageWidthParseContext::allowNumber):
(WebCore::BorderImageWidthParseContext::allowFinalCommit):
(WebCore::BorderImageWidthParseContext::top):
(WebCore::BorderImageWidthParseContext::commitNumber):
(WebCore::BorderImageWidthParseContext::setAllowFinalCommit):
(WebCore::BorderImageWidthParseContext::setTop):
(WebCore::BorderImageWidthParseContext::commitBorderImageWidth):
(WebCore::CSSParser::parseBorderImageWidth):

css/CSSParser.h:

Modify the border-image code to pass off border-image-width parsing to parseBorderImageWidth.

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::cssText):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getQuadValue):
Add the new Quad value to CSSPrimitiveValue.

css/CSSPropertyNames.in:

Add the new properties for border-image-width and -webkit-mask-box-image-width.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageSlice):
(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
(WebCore::CSSStyleSelector::loadPendingImages):

css/CSSStyleSelector.h:

Add the code to map the image width into border slices.

css/Rect.h:

(WebCore::RectBase::top):
(WebCore::RectBase::right):
(WebCore::RectBase::bottom):
(WebCore::RectBase::left):
(WebCore::RectBase::setTop):
(WebCore::RectBase::setRight):
(WebCore::RectBase::setBottom):
(WebCore::RectBase::setLeft):
(WebCore::RectBase::RectBase):
(WebCore::RectBase::~RectBase):
(WebCore::Rect::create):
(WebCore::Rect::Rect):
(WebCore::Quad::create):
(WebCore::Quad::Quad):
Adding the new Quad value.

rendering/RenderBoxModelObject.cpp:

(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Modify painting to treat the border slices as separate from the border widths.

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::operator==):

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):

rendering/style/StyleRareNonInheritedData.cpp:

Add the border slices.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

rendering/style/StyleReflection.h:

(WebCore::StyleReflection::StyleReflection):
Make sure masks and reflections default border-image-width to auto instead of 1, since that matches
old behavior.

LayoutTests:

fast/borders/border-image-longhand.html: Added.
fast/borders/border-image-scaled.html: Added.
fast/borders/border-image-side-reduction.html: Added.
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
fast/css/large-value-csstext-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

1:32 PM Changeset in webkit [94592] by tony@chromium.org

3 edits in trunk/Tools

[chromium] Check in 'build' for compiled binaries first
https://bugs.webkit.org/show_bug.cgi?id=67549

Reviewed by Dirk Pranke.

I'm working on moving the windows build output to a common location
rather than relative to the sln file. Because of that, we need to
check those build locations first for DumpRenderTree.exe.

Scripts/webkitpy/layout_tests/port/chromium_win.py:

12:50 PM Changeset in webkit [94591] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Kenneth Russell.

Change the row converter function signatures to be the same. Call them via a function
pointer during the encoding loop. Minor webkit style cleanup, remove unused include.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

platform/image-encoders/skia/JPEGImageEncoder.cpp: Remove SkUnPreMultiply.h (not used).

(WebCore::preMultipliedBGRAtoRGB): Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB): pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels): Move constants out of the encoding loop: use a function pointer
to call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures), define
and use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode):

12:37 PM Changeset in webkit [94590] by commit-queue@webkit.org

7 edits in trunk/Source

Allow MediaSource API to be enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=67306

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-09-06
Reviewed by Eric Carlson.

Source/WebCore:

bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitMediaSourceEnabled):

html/HTMLMediaElement.idl:

Source/WebKit/chromium:

public/WebRuntimeFeatures.h:
src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

12:21 PM Changeset in webkit [94589] by reed@google.com

9 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

platform/graphics/skia/PlatformContextSkia.cpp:
platform/graphics/skia/PlatformContextSkia.h:
platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):

platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

platform/chromium/test_expectations.txt:

12:18 PM Changeset in webkit [94588] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit/qt

[Qt][Symbian] REGRESSION[94105] DumpRenderTree.exe doesn't build on Symbian
https://bugs.webkit.org/show_bug.cgi?id=67644

Patch by Ademar de Souza Reis Jr. <Ademar Reis> on 2011-09-06
Reviewed by Csaba Osztrogonác.

symbian/eabi/QtWebKitu.def: add missing entry for

FrameLoaderClientQt::dumpProgressFinishedCallback(bool)

12:03 PM Changeset in webkit [94587] by nduca@chromium.org

2 edits in trunk/Source/WebCore

[chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621

CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.

Reviewed by James Robinson.

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

12:00 PM Changeset in webkit [94586] by rniwa@webkit.org

14 edits
2 adds in trunk

REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium
https://bugs.webkit.org/show_bug.cgi?id=67453

Reviewed by Kent Tamura.

Add symbols for internals.

Source/autotools/symbols.filter:

Source/WebCore:

Fixed the bug by updating inner text value in setSuggestedValue.

Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.

Test: fast/forms/suggested-value.html

WebCore.exp.in:
testing/Internals.cpp:

(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium:

Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.

src/WebNode.cpp:

(WebKit::WebNode::isFocusable):

Source/WebKit2:

Add symbols for internals.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.

fast/forms/suggested-value-expected.txt: Added.
fast/forms/suggested-value.html: Added.

11:56 AM Changeset in webkit [94585] by Laszlo Gombos

3 edits in trunk/LayoutTests

2011-09-06 Laszlo Gombos <Laszlo Gombos>

Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460

Unreviewed, renaming tests in WK2 skiplists after r93312.

platform/win-wk2/Skipped:
platform/wk2/Skipped:

11:49 AM Changeset in webkit [94584] by eric.carlson@apple.com

3 edits
2 adds in trunk

load() does not reset the resource selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=64917

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-source-load.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource): Reset m_nextChildNodeToConsider, update

comments and rearrange logic to more closely match logic in spec.

(WebCore::HTMLMediaElement::noneSupported): Update comments.

LayoutTests:

media/video-source-load-expected.txt: Added.
media/video-source-load.html: Added.

11:26 AM Changeset in webkit [94583] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Use soup_session_add_feature_by_type uniformly in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=67593

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-06
Reviewed by Martin Robinson.

Using soup_session_add_feature_by_type for adding all soup features
instead of adding using GRefPtr.

WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

11:19 AM Changeset in webkit [94582] by inferno@chromium.org

14 edits in trunk

Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Source/WebCore:

Reviewed by James Robinson.

Share propagateStyleToAnonymousChildren with RenderBlock::styleDidChange.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):

rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

rendering/RenderObject.h:

LayoutTests:

Add comments explaining what the test does.

Reviewed by James Robinson.

fast/ruby/ruby-block-style-not-updated-with-before-after-content.html:
fast/ruby/ruby-block-style-not-updated.html:
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html:
fast/ruby/ruby-inline-style-not-updated.html:
fast/table/table-before-child-style-update.html:
fast/table/table-row-before-child-style-update.html:
fast/table/table-row-style-not-updated-with-after-content.html:
fast/table/table-row-style-not-updated-with-before-content.html:
fast/table/table-style-not-updated.html:

11:13 AM Changeset in webkit [94581] by commit-queue@webkit.org

4 edits
3 adds in trunk

[skia] States of GraphicsContext may never be restored after clipToImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=67358

Source/WebCore:

beginLayerClippedToImage/applyClipFromImage are mismatched when clipping to
an empty ImageBuffer, which will make states of GraphicsContext incorrect.

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

Test: fast/repaint/background-clip-text.html

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

LayoutTests:

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

fast/repaint/background-clip-text-expected.png: Added.
fast/repaint/background-clip-text-expected.txt: Added.
fast/repaint/background-clip-text.html: Added.
platform/qt/Skipped: Missing layoutController.testRepaint().

11:02 AM Changeset in webkit [94580] by abarth@webkit.org

6 edits in trunk/Tools

Use a hierarchial structure for the garden-o-matic results view
https://bugs.webkit.org/show_bug.cgi?id=67620

Reviewed by Dimitri Glazkov.

This patch re-organizes the results view to use a hierachial structure
for selection. At the top-level are sections for each test. Expanding
the test section shows a tab selector for builders.

This structure prepares us for wiring up various actions to this view.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:

(.):

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

():

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

(.results-view>.toolbar):
(.results-view>.toolbar ul.actions):
(.results-view>.toolbar ul.actions li):
(.results-grid table):
(.results-grid table td, .results-view table th):
(.results-grid table th):
(.results-grid .text-result):
(.results-grid .image-result):

11:00 AM Changeset in webkit [94579] by abarth@webkit.org

2 edits in trunk/Tools

garden-o-matic's base.probe generates spam in the JavaScript console
https://bugs.webkit.org/show_bug.cgi?id=67622

Reviewed by Dimitri Glazkov.

Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
instead of HTMLScriptElement to test whether results exist. This
reduces the console.log spam and saves bandwidth because we can use a
HEAD request instead of a GET request.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:

10:49 AM Changeset in webkit [94578] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[EFL] Do not allocate memory for extremely large surfaces.
https://bugs.webkit.org/show_bug.cgi?id=65192

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-06
Reviewed by Martin Robinson.

So far, RenderThemeEfl tried to allocate a buffer and a cairo surface
the size of the whole form element passed to it.

In the case of
fast/overflow/overflow-height-float-not-removed-crash.html and others,
this meant extremely large widgets, which crashed the code.

We now only render the widgets if they are smaller than some hardcoded
and sufficiently large values which should work in most cases.

No new tests, as this was uncovered by existing ones.

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::isFormElementTooLargeToDisplay):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):

platform/efl/RenderThemeEfl.h:

10:36 AM Changeset in webkit [94577] by podivilov@chromium.org

6 edits
3 adds in trunk

Web Inspector: implement source map v3 consumer.
https://bugs.webkit.org/show_bug.cgi?id=67205

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/compiler-source-mapping.html

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/CompilerSourceMapping.js: Added.

(WebInspector.CompilerSourceMapping):
(WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.CompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._findMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parsePayload):
(WebInspector.ClosureCompilerSourceMapping.prototype._isSeparator):
(WebInspector.ClosureCompilerSourceMapping.prototype._decodeVLQ):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.next):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.peek):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.hasNext):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

LayoutTests:

inspector/debugger/compiler-source-mapping-expected.txt: Added.
inspector/debugger/compiler-source-mapping.html: Added.

10:12 AM UsingGitWithWebKit edited by davidbarr@chromium.org

Add details about tuning aggressive gc (diff)

9:41 AM Changeset in webkit [94576] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, unskip tests now passing because bug 61523 was fixed.

platform/gtk/Skipped:

9:19 AM Changeset in webkit [94575] by msaboff@apple.com

3 edits
13 adds in trunk/Source/JavaScriptCore

Add windows changes for JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67521

Windows build changes for regular expression functional test.

Rubber-stamped by Gavin Barraclough.

JavaScriptCore.vcproj/JavaScriptCore.sln:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/testRegExp: Added.
JavaScriptCore.vcproj/testRegExp/testRegExp.vcproj: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpDebug.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpDebugAll.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpDebugCairoCFLite.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpPostBuild.cmd: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpPreBuild.cmd: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpPreLink.cmd: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpProduction.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpRelease.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpReleaseCairoCFLite.vsprops: Added.
JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops: Added.

9:01 AM Changeset in webkit [94574] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

platform/qt-mac/Skipped: Skip one more failing test.

8:53 AM Changeset in webkit [94573] by apavlov@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectation for inspector/elements/elements-panel-styles.html,
which no longer looks flaky.
https://bugs.webkit.org/show_bug.cgi?id=63056

platform/chromium/test_expectations.txt:

8:37 AM Changeset in webkit [94572] by Csaba Osztrogonác

1 edit
2 moves in trunk/LayoutTests

[Qt] Unreviewed gardening after r94331.

platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png.
platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.

8:25 AM Changeset in webkit [94571] by podivilov@chromium.org

11 edits in trunk

Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

RawSourceCode content and source mapping loading logic is too complex, re-implement it using simpler semantics:
1) Initially, RawSourceCode doesn't have any content or mapping because content loading and
formatting operations are asynchronous, it only has scripts metadata. We don't update UI right
after RawSourceCode creation until full RawSourceCode representation is ready (content + mapping).
2) When RawSourceCode representation is ready (e.g. resource is finished, or content is formatted
if in pretty-print mode) we dispatch SourceMappingUpdated event to notify the listeners that
source code should be shown to user and raw locations should be converted to ui locations
(to show breakpoins, messages, call frames etc in UI). At this moment, all source file's content
is ready for loading and source mapping is available.
3) Later, RawSourceCode representation may change again, e.g. if pretty-print mode is toggled, or
blocked resource is finished etc., in that case SourceMappingUpdated is dispatched again to update
source code, links and decorations in UI.

Reviewed by Yury Semikhatsky.

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.sourceMappingUpdated):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

LayoutTests:

Reviewed by Yury Semikhatsky.

inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:
inspector/debugger/scripts-panel.html:
inspector/debugger/source-frame-count.html:

8:23 AM Changeset in webkit [94570] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.

7:30 AM Changeset in webkit [94569] by Laszlo Gombos

2 edits in trunk/LayoutTests

2011-09-06 Laszlo Gombos <Laszlo Gombos>

Regression: On Lion, redirects lose HTTP authentication headers
https://bugs.webkit.org/show_bug.cgi?id=66354

Unreviewed, renaming tests in WK2 skiplist after r93247.

platform/wk2/Skipped:

7:11 AM Changeset in webkit [94568] by Csaba Osztrogonác

3 edits
2 deletes in trunk

Unreviewed, rolling out r94564.
http://trac.webkit.org/changeset/94564
https://bugs.webkit.org/show_bug.cgi?id=67555

It broke many tests

Source/WebCore:

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):

LayoutTests:

svg/custom/tref-clone-crash-expected.txt: Removed.
svg/custom/tref-clone-crash.html: Removed.

7:07 AM Changeset in webkit [94567] by Laszlo Gombos

2 edits in trunk/LayoutTests

2011-09-06 Laszlo Gombos <Laszlo Gombos>

Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

platform/wk2/Skipped: Remove non-existent tests from the Skipped list as well.

6:56 AM Changeset in webkit [94566] by andreas.kling@nokia.com

2 edits in trunk/LayoutTests

Unreviewed, removing non-existent test from Qt skiplist.

platform/qt/Skipped:

6:38 AM Changeset in webkit [94565] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][ARM] http/tests/loading/empty-urls.html fails
https://bugs.webkit.org/show_bug.cgi?id=67638

[Qt][ARM]fast/dom/call-a-constructor-as-a-function.html fails
https://bugs.webkit.org/show_bug.cgi?id=67639

platform/qt-arm/Skipped: Skip failing tests.

5:57 AM Changeset in webkit [94564] by rwlbuis@webkit.org

3 edits
2 adds in trunk

2011-09-06 Rob Buis <rbuis@rim.com>

use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555

Reviewed by Nikolas Zimmermann.

Do not install event listener if tref is not part of any document.

Test: svg/custom/tref-clone-crash.html

svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):

5:48 AM Changeset in webkit [94563] by Csaba Osztrogonác

1 edit
3 adds in trunk/LayoutTests

[Qt][ARM] Missing WebGLContextEvent window property
https://bugs.webkit.org/show_bug.cgi?id=67637

platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Added.

4:58 AM Changeset in webkit [94562] by yurys@chromium.org

10 edits in trunk

Unreviewed, rolling out r94560.
http://trac.webkit.org/changeset/94560
https://bugs.webkit.org/show_bug.cgi?id=67636

It made inspector/debugger/script-formatter.html flakey
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

Source/WebCore:

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.set reset):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.PresenationCallFrame.prototype.select):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._requestContent):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._hasPendingResource):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:
inspector/debugger/scripts-panel.html:
inspector/debugger/source-frame-count.html:

4:15 AM Changeset in webkit [94561] by Antti Koivisto

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67480
[Chromium] [REGRESSION] Layout Test svg/batik/text/textStyles.svg is failing

Reviewed by Dimitri Glazkov.

The text node needs willRecalcStyle mechanism too.

dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

dom/Text.h:

(WebCore::Text::willRecalcTextStyle):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::SVGShadowText):
(WebCore::SVGShadowText::willRecalcTextStyle):

2:34 AM Changeset in webkit [94560] by podivilov@chromium.org

10 edits in trunk

Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

Reviewed by Yury Semikhatsky.

inspector/front-end/DebuggerPresentationModel.js:

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

inspector/front-end/SourceFile.js:

LayoutTests:

Reviewed by Yury Semikhatsky.

inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:
inspector/debugger/scripts-panel.html:
inspector/debugger/source-frame-count.html:

2:23 AM Changeset in webkit [94559] by fpizlo@apple.com

34 edits
4 adds in trunk/Source/JavaScriptCore

JavaScriptCore does not have tiered compilation
https://bugs.webkit.org/show_bug.cgi?id=67176

Reviewed by Gavin Barraclough.

This adds the ability to have multiple CodeBlocks associated with
a particular role in an Executable. These are stored in
descending order of compiler tier. CodeBlocks are optimized when
a counter (m_executeCounter) that is incremented in loops and
epilogues becomes positive. Optimizing means that all calls to
the old CodeBlock are unlinked.

The DFG can now pull in predictions from ValueProfiles, and
propagate them along the graph. To support the new phase while
maintaing some level of abstraction, a DFGDriver was introduced
that encapsulates how to run the DFG compiler.

This is turned off by default because it's not yet a performance
win on all benchmarks. It speeds up crypto and richards by
10% and 6% respectively, but still does not do as good of a job
as it could. Notably, the DFG backend has not changed, and
is largely oblivious to the new information being made available
to it.

When turned off (the default), this patch is performance neutral.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branchAdd32):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchAdd32):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CallLinkInfo::unlink):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::clearEvalCache):
(JSC::replaceExistingEntries):
(JSC::CodeBlock::copyDataFromAlternative):
(JSC::ProgramCodeBlock::replacement):
(JSC::EvalCodeBlock::replacement):
(JSC::FunctionCodeBlock::replacement):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):

bytecode/CodeBlock.h:

(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

bytecode/ValueProfile.h:

(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::dynamicallyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::parse):

dfg/DFGDriver.cpp: Added.

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

dfg/DFGDriver.h: Added.

(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfDoubleConstant):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isConstant):
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):

dfg/DFGNode.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::valueOfInt32Constant):
(JSC::DFG::Node::valueOfDoubleConstant):
(JSC::DFG::Node::predict):

dfg/DFGPropagation.cpp: Added.

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):

dfg/DFGPropagation.h: Added.

(JSC::DFG::propagate):

dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

heap/HandleHeap.h:

(JSC::HandleHeap::Node::Node):

jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):

jit/JIT.h:

(JSC::JIT::emitOptimizationCheck):

jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

jit/JITCode.h:

(JSC::JITCode::JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jit/JITStubs.h:
runtime/Executable.cpp:

(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileOptimizedFor):

wtf/Platform.h:
wtf/SentinelLinkedList.h:

(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::setPrev):
(WTF::BasicRawSentinelNode::setNext):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::BasicRawSentinelNode::isOnList):
(WTF::::remove):
(WTF::::SentinelLinkedList):
(WTF::::begin):
(WTF::::end):
(WTF::::push):

1:18 AM Changeset in webkit [94558] by krit@webkit.org

10 edits in trunk

Return to transform multiplication: motion transform * other transforms
https://bugs.webkit.org/show_bug.cgi?id=67601

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Right now we take the current transform of a transformable SVG element, post multiply the animation transform
and post multiply the motion transform to the other both:

transform * animation transform * motion transform

We switched to this behavior with the clean up of AffineTransform.
While the specification of SVG demands us to do so, no other SVG viewer is doing it that way. Now switching back to:

motion transform * transform * animation transform

This is done by other SVG viewers as well. While their is no consense about how to multiply the different transforms
on the SVG WG, their is a consense that the current specified behavior is unwanted. See
http://lists.w3.org/Archives/Public/www-svg/2011Jan/0055.html for more details.

We pass the following tests of the official W3C SVG test suite again now:

animate-elem-24-t.svg
animate-elem-30-t.svg

svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Change the expected results of nested transformations to match new behavior
on matrices multiplications.

svg/animations/animate-path-nested-transforms-expected.txt:
svg/animations/animate-text-nested-transforms-expected.txt:
svg/animations/script-tests/animate-path-nested-transforms.js:

(startSample):
(endSample):

svg/animations/script-tests/animate-text-nested-transforms.js:

(startSample):
(endSample):

svg/animations/svgtransform-animation-discrete-expected.txt:
svg/animations/svgtransform-animation-discrete.html:

12:55 AM Changeset in webkit [94557] by abecsi@webkit.org

2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=49321

Rubber-stamped by Csaba Osztrogonác.

platform/qt-wk2/Skipped:

The issue is not reproducible any more, so the bug can be closed and the test unskipped.

12:50 AM Changeset in webkit [94556] by fpizlo@apple.com

2 edits in trunk/LayoutTests

Updated expectations on Mac for fast/js/global-constructors.html.

Rubber-stampted by Gavin Barraclough.

platform/mac/fast/js/global-constructors-expected.txt:

12:49 AM Changeset in webkit [94555] by commit-queue@webkit.org

3 edits in trunk/Websites/bugs.webkit.org

Unreviewed, rolling out r94554.
http://trac.webkit.org/changeset/94554
https://bugs.webkit.org/show_bug.cgi?id=67631

This patch did not quite fix the problem (Requested by
benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

PrettyPatch/PrettyPatch.rb:
PrettyPatch/PrettyPatch_test.rb:

12:26 AM Changeset in webkit [94554] by commit-queue@webkit.org

3 edits in trunk/Websites/bugs.webkit.org

PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
See this email from the git mailing list archive for info
http://marc.info/?l=git&m=114682417113315&w=2

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Shinichiro Hamaji.

PrettyPatch/PrettyPatch.rb:
PrettyPatch/PrettyPatch_test.rb:

12:13 AM Changeset in webkit [94553] by Philippe Normand

6 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r94545.

platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

12:05 AM Changeset in webkit [94552] by Philippe Normand

7 edits in trunk/LayoutTests

Unreviewed, fullscreen tests rebaseline after r94545.

fullscreen/full-screen-cancel-expected.txt:
fullscreen/full-screen-css-expected.txt:
fullscreen/full-screen-remove-ancestor-expected.txt:
fullscreen/full-screen-remove-children-expected.txt:
fullscreen/full-screen-remove-expected.txt:
fullscreen/full-screen-twice-expected.txt:

Sep 5, 2011:

11:58 PM Changeset in webkit [94551] by reni@webkit.org

8 edits in trunk/LayoutTests

[Qt] Update expecteds after r94545.

Unreviewed gardening.

platform/qt/fast/dom/Window/window-properties-expected.png:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/js/global-constructors-expected.png:
platform/qt/fast/js/global-constructors-expected.txt:

9:52 PM Changeset in webkit [94550] by inferno@chromium.org

13 edits
8 adds in trunk/LayoutTests

Unreviewed. GTK rebaselines for r94541, r94543.

platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
platform/gtk/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
platform/gtk/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
platform/gtk/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
platform/gtk/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
platform/gtk/fast/table/table-after-child-in-table-expected.txt:
platform/gtk/fast/table/table-before-child-in-table-expected.txt:
platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt:
platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
platform/gtk/fast/table/table-row-style-not-updated-expected.txt: Added.
platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
platform/gtk/fast/table/table-style-not-updated-expected.txt: Added.

8:45 PM Changeset in webkit [94549] by jamesr@google.com

1 edit
1 delete in trunk/LayoutTests

[chromium] Remove unnecessary expectation, results match the fallback path.

platform/chromium-cg-mac/fast/dom/wrapper-classes-expected.txt: Removed.

8:06 PM Changeset in webkit [94548] by inferno@chromium.org

22 edits
16 adds
1 delete in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r94541, r94543.

platform/chromium-cg-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/chromium-cg-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/chromium-cg-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
platform/chromium-linux/fast/table/table-row-style-not-updated-expected.png: Added.
platform/chromium-linux/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
platform/chromium-linux/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
platform/chromium-linux/fast/table/table-style-not-updated-expected.png: Added.
platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt:
platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
platform/chromium-win/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
platform/chromium-win/fast/table/table-row-style-not-updated-expected.png: Added.
platform/chromium-win/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
platform/chromium-win/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
platform/chromium-win/fast/table/table-style-not-updated-expected.png: Added.
platform/chromium/test_expectations.txt:

7:38 PM Changeset in webkit [94547] by inferno@chromium.org

11 edits
8 adds in trunk/LayoutTests

Unreviewed. Qt rebaselines for r94543.

platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt:
platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
platform/qt/fast/table/table-after-child-in-table-expected.txt:
platform/qt/fast/table/table-before-child-in-table-expected.txt:
platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
platform/qt/fast/table/table-row-style-not-updated-expected.txt: Added.
platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
platform/qt/fast/table/table-style-not-updated-expected.txt: Added.

7:13 PM Changeset in webkit [94546] by inferno@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Rebaselines for r94541.

platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

6:52 PM Changeset in webkit [94545] by abarth@webkit.org

23 edits
1 move
4 adds
11 deletes in trunk

window.HTMLSpanElement does not exist
https://bugs.webkit.org/show_bug.cgi?id=67571

Reviewed by Sam Weinig.

Source/WebCore:

We have these objects for most other elements and HTMLSpanElement
exists in Firefox and in the HTML5 spec. This patch adds it.

Test: fast/dom/wrapper-classes.html

CMakeLists.txt:
CodeGenerators.pri:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/HTMLElementsAllInOne.cpp:
html/HTMLSpanElement.cpp: Added.

(WebCore::HTMLSpanElement::HTMLSpanElement):
(WebCore::HTMLSpanElement::create):

html/HTMLSpanElement.h: Added.
html/HTMLSpanElement.idl: Added.
html/HTMLTagNames.in:
page/DOMWindow.idl:

LayoutTests:

Update tests to account for HTMLSpanElement existing. I also took the
liberty of changing fast/tokenizer/external-script-document-write.html
into a text test and cleaning up the platform-specific results.

editing/selection/extend-after-mouse-selection-expected.txt:
fast/dom/gc-6-expected.txt:
fast/dom/gc-7-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html:
fast/events/mouseclick-target-and-positioning-expected.txt:
fast/js/toString-and-valueOf-override-expected.txt:
fast/tokenizer/external-script-document-write-expected.txt: Added.
fast/tokenizer/resources/external-script-document-write.js:
platform/chromium-linux/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/chromium-win/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/chromium-win/fast/tokenizer/external-script-document-write-expected.txt: Removed.
platform/gtk/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/gtk/fast/tokenizer/external-script-document-write-expected.txt: Removed.
platform/mac-leopard/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/mac/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/mac/fast/tokenizer/external-script-document-write-expected.txt: Removed.
platform/qt/fast/tokenizer/external-script-document-write-expected.png: Removed.
platform/qt/fast/tokenizer/external-script-document-write-expected.txt: Removed.

6:49 PM Changeset in webkit [94544] by inferno@chromium.org

12 edits
24 copies in branches/chromium/835

Merge 94543 - Style not propagated to anonymous boxes and anonymous
inline-blocks.

BUG=92651
Review URL: http://codereview.chromium.org/7833032

6:45 PM Changeset in webkit [94543] by inferno@chromium.org

20 edits
24 adds in trunk

Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html

fast/ruby/ruby-block-style-not-updated.html
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
fast/ruby/ruby-inline-style-not-updated.html
fast/table/table-row-style-not-updated-with-after-content.html
fast/table/table-row-style-not-updated-with-before-content.html
fast/table/table-row-style-not-updated.html
fast/table/table-style-not-updated.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

rendering/RenderObject.h:

(WebCore::RenderObject::isBeforeAfterContent):

rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):

rendering/RenderRuby.h:
rendering/RenderTable.cpp:

(WebCore::RenderTable::styleDidChange):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):

rendering/RenderTableSection.h:

LayoutTests:

None of the different color boxes should overlap. If they overlap, test fails.

fast/ruby/ruby-block-style-not-updated-expected.png: Added.
fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
fast/ruby/ruby-block-style-not-updated-with-before-after-content.html: Added.
fast/ruby/ruby-block-style-not-updated.html: Added.
fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html: Added.
fast/ruby/ruby-inline-style-not-updated.html: Added.
fast/table/table-row-style-not-updated-expected.png: Added.
fast/table/table-row-style-not-updated-expected.txt: Added.
fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
fast/table/table-row-style-not-updated-with-after-content.html: Added.
fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
fast/table/table-row-style-not-updated-with-before-content.html: Added.
fast/table/table-row-style-not-updated.html: Added.
fast/table/table-style-not-updated-expected.png: Added.
fast/table/table-style-not-updated-expected.txt: Added.
fast/table/table-style-not-updated.html: Added.
platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
platform/mac/fast/table/table-after-child-in-table-expected.txt:
platform/mac/fast/table/table-before-child-in-table-expected.txt:
platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
platform/mac/fast/table/table-row-before-child-in-table-expected.txt:

6:21 PM Changeset in webkit [94542] by inferno@chromium.org

5 edits
2 copies in branches/chromium/835

Merge 94541 - Crash in RenderObjectChildList::destroyLeftOverChildren()

BUG=89580
Review URL: http://codereview.chromium.org/7737033

6:16 PM Changeset in webkit [94541] by inferno@chromium.org

7 edits
2 adds in trunk

Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
fast/multicol/column-span-parent-continuation-crash.html: Added.
platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

4:18 PM Changeset in webkit [94540] by abarth@webkit.org

8 edits in trunk/Tools

Add a tab to garden-o-matic for viewing expected failures
https://bugs.webkit.org/show_bug.cgi?id=67619

Reviewed by Dimitri Glazkov.

This patch adds a basic tab to garden-o-matic that shows all the tests
failing on the bots, including the expected failures. This patch
mostly involves refactoring existing classes to allow new subclasses.

This view is useful for when gardeners mark tests as expected to fail
and then rebaseline them later.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

3:58 PM Changeset in webkit [94539] by abarth@webkit.org

2 edits in trunk/Tools

Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617

Reviewed by Dimitri Glazkov.

Caught by running the unit tests with noglobals turned on.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

2:07 PM Changeset in webkit [94538] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r94537.
http://trac.webkit.org/changeset/94537
https://bugs.webkit.org/show_bug.cgi?id=67618

Does not compile on Chromium Mac (Requested by abarth_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):

12:56 PM Changeset in webkit [94537] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Adam Barth.

Change the row converter function signatures to be the same. Call them via a function
pointer during the encoding loop. Minor webkit stlye cleanup, remove unused include.

No new tests. Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

platform/image-encoders/skia/JPEGImageEncoder.cpp: Remove SkUnPreMultiply.h (not used).

(WebCore::preMultipliedBGRAtoRGB): Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB): pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels): Move contants out of the encoding loop: use a function pointer to
call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures) during the
image row encoding loop. Add/use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode): webkit style: no need to split lines.

9:55 AM Changeset in webkit [94536] by jknotten@chromium.org

3 edits
3 adds in trunk

Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

fast/events/page-scaled-mouse-click-expected.txt: Added.
fast/events/page-scaled-mouse-click.html: Added.
fast/events/script-tests/page-scaled-mouse-click.js: Added.

9:51 AM Changeset in webkit [94535] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

D'oh! Missed the name of the test in the previous gardening.
Unreviewed regardening.

platform/qt-wk2/Skipped:

9:47 AM Changeset in webkit [94534] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67607

Unreviewed gardening.

platform/qt-wk2/Skipped:

8:42 AM Changeset in webkit [94533] by kbalazs@webkit.org

1 edit
1 move in trunk/LayoutTests

[Qt] Unreviewed gardening - move expectation to the correct place.

platform/qt/fast/borders/border-image-repeat-expected.txt: Renamed from LayoutTests/platform/qt/border-image-repeat-expected.txt.

8:35 AM Changeset in webkit [94532] by podivilov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: rename RawSourceCode.reload to contentEdited.
https://bugs.webkit.org/show_bug.cgi?id=67504

Make RawSourceCode.reload private and remove RawSourceCode.content getter and setter
(RawSourceCode isn't supposed to have any content).

Reviewed by Yury Semikhatsky.

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._didRequestContent):

8:01 AM Changeset in webkit [94531] by leandrogracia@chromium.org

2 edits in trunk/Source/WebCore

Fix the regression of bug 65333 introduced by 60170.
This caused the speech input bubble to appear in the wrong side for RTL text inputs.
https://bugs.webkit.org/show_bug.cgi?id=67597

Reviewed by Tony Gentilcore.

No new tests. Fixing regression.

html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

7:46 AM Changeset in webkit [94530] by podivilov@chromium.org

2 edits in trunk/LayoutTests

Web Inspector: cleanup scripts-panel.html test.
https://bugs.webkit.org/show_bug.cgi?id=67497

ScriptsPanel test should not depend on presentation model internals.

Reviewed by Yury Semikhatsky.

inspector/debugger/scripts-panel.html:

7:40 AM Changeset in webkit [94529] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: F5 results in a Web Inspector frontend reload on non-Macs
https://bugs.webkit.org/show_bug.cgi?id=67602

Reviewed by Yury Semikhatsky.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

7:20 AM Changeset in webkit [94528] by kbalazs@webkit.org

1 edit
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-05

platform/qt/border-image-repeat-expected.txt: Added.

7:11 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt to 4.7.4 and Mobility to 1.2.0 on Qt Linux Release bot (diff)

5:57 AM Changeset in webkit [94527] by loislo@chromium.org

5 edits in trunk/Source/WebCore

Unreviewed, rolling out r94525.
http://trac.webkit.org/changeset/94525
https://bugs.webkit.org/show_bug.cgi?id=67599

WinCE compilation failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

platform/text/TextBoundaries.cpp:
platform/text/TextBreakIteratorICU.cpp:
platform/text/qt/TextBoundariesQt.cpp:
platform/text/qt/TextBreakIteratorQt.cpp:

5:55 AM Changeset in webkit [94526] by kbalazs@webkit.org

6 edits
6 adds in trunk/LayoutTests/platform/qt/fast

2011-09-05 Balazs Kelemen <kbalazs@webkit.org>

[Qt] Update expectations.

Unreviewed gardening.

platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
platform/qt/fast/dom/Window/window-properties-expected.png:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/qt/fast/js/global-constructors-expected.png:
platform/qt/fast/js/global-constructors-expected.txt:

5:08 AM Changeset in webkit [94525] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
https://bugs.webkit.org/show_bug.cgi?id=67391

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-09-05
Reviewed by Kenneth Rohde Christiansen.

platform/text/TextBoundaries.cpp:
platform/text/TextBreakIteratorICU.cpp:
platform/text/qt/TextBoundariesQt.cpp:
platform/text/qt/TextBreakIteratorQt.cpp:

3:53 AM Changeset in webkit [94524] by kbalazs@webkit.org

5 edits
3 adds in trunk

[Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Reviewed by Andreas Kling.

Source/WebKit2:

Shared/API/c/qt/WKImageQt.cpp: Added.

(WKImageCreateQImage): C style (private) API to get the contents of the backing
store as an image.

Shared/API/c/qt/WKImageQt.h: Added.
Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage): Typo. Remove useless ifdef.

WebKit2API.pri:

Tools:

Implemented pixel result generation by reusing the logic
that we have in DumpRenderTree.

WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::dumpImage):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

3:50 AM Changeset in webkit [94523] by zoltan@webkit.org

3 edits in trunk/LayoutTests

[Qt] Update expected result after r94425
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Kristof Kosztyo <kkristof@inf.u-szeged.hu> on 2011-09-05

platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:

3:43 AM Changeset in webkit [94522] by commit-queue@webkit.org

10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595

It broke everything (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
heap/Heap.cpp:

(JSC::Heap::collect):

heap/Heap.h:
heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

heap/NewSpace.h:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

runtime/JSObject.h:

(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

3:22 AM Changeset in webkit [94521] by loislo@chromium.org

3 edits in trunk/LayoutTests

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium MAC.
The test was introduced at r94492.

platform/chromium-cg-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-cg-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:

2:41 AM Changeset in webkit [94520] by Patrick Gansterer

10 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for r94452.

Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.

wtf/dtoa/bignum-dtoa.cc:
wtf/dtoa/bignum.cc:
wtf/dtoa/cached-powers.cc:
wtf/dtoa/diy-fp.cc:
wtf/dtoa/double-conversion.cc:
wtf/dtoa/fast-dtoa.cc:
wtf/dtoa/fixed-dtoa.cc:
wtf/dtoa/strtod.cc:
wtf/dtoa/utils.h:

1:49 AM Changeset in webkit [94519] by abecsi@webkit.org

4 edits in trunk/Source

[Qt][WK2] Fix the build

Rubber-stamped by Csaba Osztrogonác.

Source/JavaScriptCore:

wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.

The variable fractional_part is only set but never used.

Source/WebKit2:

DerivedSources.pro: Add missing PluginProcessConnection.messages.in after r94456.

1:36 AM Changeset in webkit [94518] by loislo@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update expected image for chromium Linux.
The test was introduced at r94492.

platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.

12:52 AM Changeset in webkit [94517] by loislo@chromium.org

4 edits
1 delete in trunk/LayoutTests

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for chromium: fast/repaint/block-layout-inline-children-float-positioned.html

platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

12:46 AM Changeset in webkit [94516] by commit-queue@webkit.org

10 edits in trunk/Source

Logic from HTMLElement::deprecatedCreateContextualFragment moved into
Range::createContextualFragment function.
https://bugs.webkit.org/show_bug.cgi?id=67056

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-09-05
Reviewed by Ryosuke Niwa.

Code Refactoring for deprecatedCreateContextualFragment.

Source/WebCore:

No new tests. Code Re-factoring.

dom/Element.cpp:
dom/Element.h:
dom/Range.cpp:

(WebCore::insertIntoFragment):
(WebCore::Range::createDocumentFragmentForElement):
(WebCore::Range::createContextualFragment):

dom/Range.h:
editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

html/HTMLElement.cpp:
html/HTMLElement.h:

Source/WebKit/qt:

Api/qwebelement.cpp:

(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

12:38 AM Changeset in webkit [94515] by loislo@chromium.org

1 edit
12 adds in trunk/LayoutTests

2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for fast/inline/absolute-positioned-inline-in-centred-block

platform/chromium-cg-mac-leopard/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.

Sep 4, 2011:

11:48 PM Changeset in webkit [94514] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-04
Reviewed by Darin Adler.

Fixing the build (again which was broken by the dtoa patch. Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

wtf/dtoa/cached-powers.cc:
wtf/dtoa/utils.h:

11:43 PM Changeset in webkit [94513] by koz@chromium.org

6 edits
2 deletes in trunk

Unreviewed, rolling out r94510.
http://trac.webkit.org/changeset/94510
https://bugs.webkit.org/show_bug.cgi?id=66531

Causes layout test crashes.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

dom/NodeRenderingContext.cpp:

(WebCore::wrapWithRenderFullScreen):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

rendering/RenderFullScreen.cpp:

(RenderFullScreen::createFullScreenStyle):

rendering/RenderFullScreen.h:

LayoutTests:

plugins/fullscreen-plugins-dont-reload-expected.txt: Removed.
plugins/fullscreen-plugins-dont-reload.html: Removed.

10:59 PM Changeset in webkit [94512] by inferno@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Compile fix for r94511.

dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

10:22 PM Changeset in webkit [94511] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556

Reviewed by Ryosuke Niwa.

Source/WebCore:

Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.

Test: fast/dom/Range/range-delete-contents-event-fire-crash.html

dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

LayoutTests:

Tests that we do not crash when removing contents of
a range from the document.

fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt: Added.
fast/dom/Range/range-delete-contents-event-fire-crash.html: Added.

9:46 PM Changeset in webkit [94510] by commit-queue@webkit.org

6 edits
2 adds in trunk

Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

Test: plugins/fullscreen-plugins-dont-reload.html

dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererIfNeeded):

rendering/RenderFullScreen.cpp:

(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):

rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
plugins/fullscreen-plugins-dont-reload.html: Added.

9:18 PM Changeset in webkit [94509] by ryuan.choi@samsung.com

2 edits
2 moves in trunk/Source/WebKit/efl

[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
https://bugs.webkit.org/show_bug.cgi?id=66542

Use a C++ compiler for these files, so that they can include the C++-using
ewk_private.h.

Reviewed by Daniel Bates.

CMakeListsEfl.txt:
ewk/ewk_view_single.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_single.c.

(_ewk_view_single_on_del):
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_backing_store_add):
(_ewk_view_single_smart_resize):
(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
(_ewk_view_single_smart_repaints_process):
(_ewk_view_single_smart_zoom_weak_set):
(_ewk_view_single_smart_zoom_weak_smooth_scale_set):
(_ewk_view_single_smart_bg_color_set):
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):

ewk/ewk_view_tiled.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_tiled.c.

(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_add):
(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):
(_ewk_view_tiled_smart_contents_resize):
(_ewk_view_tiled_smart_zoom_set):
(_ewk_view_tiled_smart_zoom_weak_set):
(_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
(_ewk_view_tiled_smart_flush):
(_ewk_view_tiled_smart_pre_render_region):
(_ewk_view_tiled_smart_pre_render_relative_radius):
(_ewk_view_tiled_smart_pre_render_cancel):
(_ewk_view_tiled_smart_disable_render):
(_ewk_view_tiled_smart_enable_render):
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):
(ewk_view_tiled_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

5:01 PM Changeset in webkit [94508] by mitz@apple.com

10 edits
2 adds in trunk

<rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.

css/CSSFontFace.h:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.

css/CSSFontSelector.h:
css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.

dom/Document.cpp:

(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.

dom/Document.h:

(WebCore::Document::retireCustomFont): Added.

LayoutTests:

fast/css/font-face-used-after-retired-expected.txt: Added.
fast/css/font-face-used-after-retired.html: Added.

2:24 PM Changeset in webkit [94507] by abarth@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Reviewed by Darin Fisher.

This flag requests that the embedder allow multiple selection for the
popup menu. (See also https://bugs.webkit.org/show_bug.cgi?id=67574.)

public/WebPopupMenuInfo.h:
src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::getPopupMenuInfo):

2:19 PM Changeset in webkit [94506] by weinig@apple.com

2 edits in trunk/LayoutTests

Forgot to check in new results for fast/events/event-creation.html

fast/events/event-creation-expected.txt:

2:04 PM Changeset in webkit [94505] by weinig@apple.com

12 edits
3 deletes in trunk

Document.createEvent should support all the interfaces of Event we got
https://bugs.webkit.org/show_bug.cgi?id=67568

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/events/event-creation.html

dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
Added empty create.

dom/Document.cpp:

(WebCore::Document::createEvent):
Add missing interfaces.

dom/HashChangeEvent.h:

(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
Added empty create.

page/SpeechInputEvent.cpp:

(WebCore::SpeechInputEvent::create):
(WebCore::SpeechInputEvent::SpeechInputEvent):
(WebCore::SpeechInputEvent::~SpeechInputEvent):

page/SpeechInputEvent.h:

Added empty create.

LayoutTests:

fast/events/event-creation.html:

Converted to shouldBe style test, changed prototype check to us instanceof and constructor check,
added enumeration based catchall.

fast/events/event-instanceof-expected.txt: Removed.
fast/events/event-instanceof.html: Removed.
fast/events/script-tests/event-instanceof.js: Removed.

Moved contents to fast/events/event-creation.html.

11:10 AM Changeset in webkit [94504] by abarth@webkit.org

7 edits in trunk/Source

[Chromium] Add memory threshold values to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=67575

Reviewed by Darin Fisher.

Source/WebCore:

Grab these memory thresholds from PlatformSupport rather than hard-coding them.

bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

platform/chromium/PlatformSupport.h:
platform/qt/PlatformSupport.h:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

Source/WebKit/chromium:

Instead of hard-coding these values, we now grab them from
WebKitPlatformSupport because Android wishes to configure them on a
per-device basis.

One could view grabing these values from PlatformSupport as a bit of a
layering violation (because they feel like policy), but another view is
that the alternative implementation is to query the OS for various
memory parameters. In either case, getting these values via
PlatformSupport is much easier and consistent with the other memory
related queries in PlatformSupport already.

public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::lowMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highUsageDeltaMB):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

11:04 AM Changeset in webkit [94503] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-09-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium expectations.
The expectations for http/tests/security/xssAuditor/dom-write-innerHTML.html
were in conflict. The first was for LINUX the second was for DEBUG. I just added RELEASE flag for LINUX one.

platform/chromium/test_expectations.txt:

10:51 AM Changeset in webkit [94502] by kevino@webkit.org

1 edit
5 adds in trunk/Source/WebCore

[wx] Unreviewed build fix. Add new / moved files missing from last commit.

9:49 AM Changeset in webkit [94501] by kevino@webkit.org

19 edits in trunk

[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
https://bugs.webkit.org/show_bug.cgi?id=67577

Reviewed by Kevin Ollivier.

Sep 3, 2011:

10:43 PM Changeset in webkit [94500] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

7:58 PM Changeset in webkit [94499] by Laszlo Gombos

8 edits in trunk/Source

REGRESSION (r86268): Fix for qt_networkAccessAllowed()
https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has been removed a while back.

WebCore.pri:
WebCore.pro:
features.pri:
platform/network/NetworkStateNotifier.h:
platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

4:31 PM Changeset in webkit [94498] by rniwa@webkit.org

1 edit in trunk/LayoutTests/platform/mac/Skipped

Remove the corresponding entry from the skipped list.

4:30 PM Changeset in webkit [94497] by rniwa@webkit.org

3 edits
2 copies in trunk

REGRESSION(r94274): selection-change-closes-typing.html fails
https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

editing/Editor.cpp:

(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.

platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from

LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

3:43 PM Changeset in webkit [94496] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Test that document.all.tags() matches IE behavior with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

fast/dom/document-all-tags-expected.txt: Added.
fast/dom/document-all-tags.html: Added.

2:00 PM Changeset in webkit [94495] by robert@webkit.org

4 edits
4 adds in trunk/LayoutTests

Add platform-specific results for r94492

Unreviewed.

platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

1:08 PM Changeset in webkit [94494] by kevino@webkit.org

4 edits in trunk

[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

12:26 PM Changeset in webkit [94493] by weinig@apple.com

8 edits in trunk

Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

page/DOMWindow.idl:

LayoutTests:

platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
platform/mac/fast/dom/prototype-inheritance-expected.txt:
platform/mac/fast/js/global-constructors-expected.txt:

Update results for new constructors.

11:28 AM Changeset in webkit [94492] by robert@webkit.org

8 edits
12 adds in trunk

div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html

Ensure positioned block elements inherit alignment. fast/css/bug4860-absolute-inline-child-inherits-alignment.html
Ensure positioned inline elements inherit alignment. fast/inline/absolute-positioned-inline-in-centred-block.html
Ensure positioned inline element that's the sole or first child of a rendered block obeys parents alignment. fast/inline/absolute-positioned-block-in-centred-block.html
As above, but a positioned block should not inherit alignment.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
fast/inline/absolute-positioned-block-in-centred-block.html: Added.
fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified by the container of an element absolute position when there was no text preceding the element. The updated results agree with Firefox and IE.
fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.

11:18 AM Changeset in webkit [94491] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

dom/Element.cpp:
dom/Element.h:

10:13 AM Changeset in webkit [94490] by mitz@apple.com

2 edits in trunk/Tools

32-bit build fix.

TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):

9:13 AM Changeset in webkit [94489] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Enable support for WebGL OES_standard_derivatives for Qt
https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

8:57 AM Changeset in webkit [94488] by mitz@apple.com

5 edits
1 add in trunk/Tools

Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.

TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.

(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.

TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD): Added.

1:29 AM Changeset in webkit [94487] by abarth@webkit.org

6 edits in trunk/Tools

garden-o-matic results view should have a better results selector
https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view. Currently, this grid just shows how the tests fail on the
various bots. A future patch will let you select which failure to view
and to mark the failures for rebaselining.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
- Add some more basic functions for manipulating dictionaries.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:

1:27 AM Changeset in webkit [94486] by abarth@webkit.org

5 edits in trunk/Tools

garden-o-matic results view should show Actual and Expected results for text failures
https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid. Now that we do, we can move show these results.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
- Fixed some typos that were preventing these unit tests from running.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

(.):

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- Report -actual.txt and -expected.txt as possible results URLs.

1:25 AM Changeset in webkit [94485] by abarth@webkit.org

4 edits in trunk/Tools

garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

12:49 AM Changeset in webkit [94484] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG variable predictions only work for local variables, not temporaries
https://bugs.webkit.org/show_bug.cgi?id=67554

Reviewed by Gavin Barraclough.

This appears to be a slight speed-up in Kraken (0.3% but significant)
and neutral elsewhere.

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

12:45 AM Changeset in webkit [94483] by rniwa@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r94458.
http://trac.webkit.org/changeset/94458
https://bugs.webkit.org/show_bug.cgi?id=67558

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

12:45 AM Changeset in webkit [94482] by yutak@chromium.org

18 edits
1 copy
2 moves
4 adds in trunk

WebSocket: Send ArrayBuffer as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67477

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/send-arraybuffer.html

http/tests/websocket/tests/hybi/workers/send-arraybuffer.html
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

websockets/ThreadableWebSocketChannel.h:
websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):

websockets/ThreadableWebSocketChannelClientWrapper.h:

Rename "sent" to "sendRequestResult" to clarify the meaning. Messages from the script may not
be sent immediately, thus the return value of WebSocketChannel::send() indicates whether the
message has been queued successfully, rather than whether the message has been sent or not.

websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
Case of sending "[object ArrayBuffer]" is covered by an existing test
http/tests/websocket/tests/{hybi,hixie76}/send-object.html.

websockets/WebSocket.h:
websockets/WebSocket.idl:
websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

websockets/WebSocketChannel.h:
websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
Construct an ArrayBuffer from the data on Vector<char>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Copy the content into temporary buffer of Vector<char>, and send it to the main thread.

websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:

Add tests to send ArrayBuffers.

http/tests/websocket/tests/hybi/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/send-blob_wsh.py, because this handler
is used from send-blob.html and send-arraybuffer.html.

http/tests/websocket/tests/hybi/send-arraybuffer-expected.txt: Added.
http/tests/websocket/tests/hybi/send-arraybuffer.html:

Added. Send three small binary messages as ArrayBuffers.

http/tests/websocket/tests/hybi/send-blob.html:
http/tests/websocket/tests/hybi/workers/resources/check-binary-messages_wsh.py:

Renamed from LayoutTests/http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py.

http/tests/websocket/tests/hybi/workers/resources/send-arraybuffer.js:

Added. Same as send-arraybuffer.html, except that this test is run on the worker.

http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

Removed the definition of unnecessary function startsWith().

http/tests/websocket/tests/hybi/workers/send-arraybuffer-expected.txt: Added.
http/tests/websocket/tests/hybi/workers/send-arraybuffer.html: Added

12:29 AM Changeset in webkit [94481] by rniwa@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r94453.
http://trac.webkit.org/changeset/94453
https://bugs.webkit.org/show_bug.cgi?id=67557

Caused appcache test to fail on various bots (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-03

Scripts/webkitpy/layout_tests/port/webkit.py:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed