Timeline



Oct 5, 2011:

11:34 PM Changeset in webkit [96790] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=69498

Patch by James Robinson <​jamesr@chromium.org> on 2011-10-05
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setThreadedCompositingEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11:04 PM Changeset in webkit [96789] by arv@chromium.org
  • 2 edits in trunk/Tools

[QT] Fix DRT after r96779

unreviewed.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::dumpHistoryItem):

11:00 PM Changeset in webkit [96788] by haraken@chromium.org
  • 34 edits in trunk/Source/WebCore

Refactor IDL attributes about constructor
​https://bugs.webkit.org/show_bug.cgi?id=69074

Reviewed by Adam Barth.

Currently, IDL attributes about constructor are confusing:

  • [CustomConstructFunction] means that there is a custom constructor for JSC.
  • [V8CustomConstructor] means that there is a custom constructor for V8.
  • [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
  • For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
  • ObjC, CPP and GObject bindings do not support custom constructors.

This patch makes the following changes:

  • Rename [CustomConstructFunction] to [JSCustomConstructor].
  • [JSCustomConstructor] means that there is a custom constructor for JSC.
  • [V8CustomConstructor] means that there is a custom constructor for V8.
  • [CustomConstructor] means that there is a custom constructor for both JSC and V8.

No new tests. No change in behavior. Confirm that build succeeds.

  • bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]

(GenerateHeader):
(GenerateAttributesHashTable):
(GenerateImplementation):
(GenerateConstructorDefinition):

  • css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/Event.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageChannel.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • html/DOMFormData.idl: Ditto.
  • html/canvas/ArrayBuffer.idl: Ditto.
  • html/canvas/DataView.idl: Ditto.
  • html/canvas/Float32Array.idl: Ditto.
  • html/canvas/Float64Array.idl: Ditto.
  • html/canvas/Int16Array.idl: Ditto.
  • html/canvas/Int32Array.idl: Ditto.
  • html/canvas/Int8Array.idl: Ditto.
  • html/canvas/Uint16Array.idl: Ditto.
  • html/canvas/Uint32Array.idl: Ditto.
  • html/canvas/Uint8Array.idl: Ditto.
  • p2p/PeerConnection.idl: Ditto.
  • page/EventSource.idl: Ditto.
  • page/WebKitPoint.idl: Ditto.
  • webaudio/AudioContext.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
  • websockets/WebSocket.idl: Ditto.
  • workers/SharedWorker.idl: Ditto.
  • workers/Worker.idl: Ditto.
  • xml/XMLHttpRequest.idl: Ditto.
  • xml/XSLTProcessor.idl: Ditto.
10:37 PM Changeset in webkit [96787] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed build fix.

  • platform/wincairo/Skipped: Skip css3 folder (for now).
9:18 PM Changeset in webkit [96786] by aestes@apple.com
  • 17 edits in trunk/Source

Source/WebCore: Add the option to suppress rendering until the document's load event fires.
​https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a WebCore setting that suppresses painting and compositing layer
updates until the document's load event fires. This masks the effects
of incremental rendering (for clients that opt in) by ensuring that all
sub-resources have loaded and a full layout has taken place before
painting the document for the first time.

No tests currently possible. Testing this would require the ability for
DRT to dump state while resources are loading, which it doesn't
currently do.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): If rendering was previously
suppressed, force a repaint and compositing layer update.
(WebCore::Document::visualUpdatesAllowed): Add a helper method to
determine if the document is in a state where rendering is allowed.

  • dom/Document.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setSuppressIncrementalRendering):
(WebCore::Settings::suppressIncrementalRendering):

  • rendering/RenderLayer.cpp:

(WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
painting suppression checks into a single helper function for
readability's sake.
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
suppress compositing layer updates and the load event has yet to fire,
return early.

Source/WebKit/mac: Add an option to suppress rendering until the document's load event fires.
​https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new private WebPreference.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
(-[WebPreferences suppressRenderingWhileInitiallyLoading]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2: Add an option to suppress rendering until the document's load event fires.
​https://bugs.webkit.org/show_bug.cgi?id=69298

Reviewed by Simon Fraser.

Add a new WKPreference.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSuppressRenderingWhileInitiallyLoading):
(WKPreferencesGetSuppressRenderingWhileInitiallyLoading):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

8:37 PM Changeset in webkit [96785] by yutak@chromium.org
  • 7 edits
    2 adds in trunk

WebSocket: Add extensions attribute
​https://bugs.webkit.org/show_bug.cgi?id=69408

Reviewed by Kent Tamura.

Source/WebCore:

Add WebSocket's "extensions" attribute as specified in the WebSocket API
<​http://dev.w3.org/html5/websockets/#the-websocket-interface>.

WebSocket protocol extension is not implemented at all, thus this attribute
always returns an empty string.

Test: http/tests/websocket/tests/hybi/extensions.html

http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::extensions):
If the hixie-76 protocol is chosen, we need to return "undefined" in order to
keep behavior of the ports which have not used the newer hybi protocol yet.

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

LayoutTests:

  • http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
  • http/tests/websocket/tests/hixie76/undefined-attributes.html:

Added "extensions" attribute to the list because it shouldn't be defined
when hixie-76 protocol is used.

  • http/tests/websocket/tests/hybi/extensions-expected.txt: Added.
  • http/tests/websocket/tests/hybi/extensions.html:

Added. Test whether .extensions attribute always returns an empty string.

8:04 PM Changeset in webkit [96784] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

r96770 broke binary compatibility with Safari
​https://bugs.webkit.org/show_bug.cgi?id=69496

Reviewed by Dan Bernstein.

Fix binary compatibility issue by declaring the deprecated methods inside a extern "C" block.

  • UIProcess/API/C/WKContext.cpp:
7:38 PM Changeset in webkit [96783] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix attempt after r96760.

7:27 PM Changeset in webkit [96782] by dominicc@chromium.org
  • 6 edits in trunk/Source/WebCore

IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
​https://bugs.webkit.org/show_bug.cgi?id=69406

Reviewed by Hajime Morita.

No change in behavior => No new tests.

  • dom/Node.cpp:

(WebCore::Node::setShadowHost): Don't twiddle the flag.

  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.

  • dom/TreeScope.h:
7:15 PM Changeset in webkit [96781] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations for Web Audio on Windows.

Unreviewed.

  • platform/chromium/test_expectations.txt:
7:04 PM Changeset in webkit [96780] by crogers@google.com
  • 4 edits in trunk/Source

Define a log2f() function for Windows in wtf/MathExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=69491

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • wtf/MathExtras.h:

(log2f):

Source/WebCore:

No new tests. This change is tested in existing layout tests.

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

6:40 PM Changeset in webkit [96779] by arv@chromium.org
  • 46 edits
    1 delete in trunk

window.location.href and others needlessly decodes URI-encoded characters
​https://bugs.webkit.org/show_bug.cgi?id=30225

Reviewed by Darin Adler.

Source/WebCore:

Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.

This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
not encode so aggressively.

  • fileapi/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultObjectContentType): Manually decode path()

  • page/Location.cpp:

(WebCore::Location::href): Use string() instead of deprecatedString()

  • page/Location.h:

(WebCore::Location::toString): Inline call to href()

  • platform/KURL.cpp:

(WebCore::KURL::path): Don't decode.
(WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart

since this is now used for more than just fragments.

(WebCore::KURL::parse): Don't decode

  • platform/KURLGoogle.cpp:

(WebCore::KURL::path): Remove out of date comment

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath): Manually decode path()

  • platform/win/ClipboardWin.cpp:

(WebCore::createGlobalHDropContent): Manually decode path()

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::href): Use string() instead of deprecatedString()

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::toString): Inline call to href()

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(normalizeLayoutTestURLInternal): Remove extra encode.

LayoutTests:

The path part of location.href and location.pathname are now not decoded and we keep percent escape sequences.

data and javascript URLs only encodes non ascii characters.

  • fast/dom/anchor-origin-expected.txt:
  • fast/dom/anchor-origin.html: Change to not use document.write since we don't want to output HTML.
  • fast/history/history-back-initial-vs-final-url-expected.txt:
  • fast/loader/subframe-navigate-during-main-frame-load-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/mailto-expected.txt:
  • fast/url/script-tests/file-http-base.js:
  • fast/url/script-tests/segments.js:
  • fast/url/script-tests/standard-url.js:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/segments.html: Use UTF-8
  • fast/url/standard-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium-cg-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-linux/fast/url/standard-url-expected.txt:
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/standard-url-expected.txt:
  • platform/chromium/fast/dom/anchor-origin-expected.txt: Removed.
6:14 PM Changeset in webkit [96778] by Darin Adler
  • 2 edits in trunk/Tools

Fix build.

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:

(TestWebKitAPI::TEST): Remove underscore prefix from call to
WKContextRegisterURLSchemeAsEmptyDocument.

5:56 PM Changeset in webkit [96777] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Use four more named cursors if present
​https://bugs.webkit.org/show_bug.cgi?id=69488

Reviewed by Dan Bernstein.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
"ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
falls back if the cursors are not present.

5:51 PM Changeset in webkit [96776] by tony@chromium.org
  • 7 edits in trunk

force margin:auto to 0 in flex items
​https://bugs.webkit.org/show_bug.cgi?id=69475

Reviewed by Ojan Vafai.

Source/WebCore:

The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

  • css3/flexbox/002.html:
  • css3/flexbox/003.html:
  • css3/flexbox/004.html:
  • css3/flexbox/writing-modes.html:
5:44 PM Changeset in webkit [96775] by dino@apple.com
  • 3 edits
    3 adds in trunk

Computed style for filter property
​https://bugs.webkit.org/show_bug.cgi?id=68477

Reviewed by Simon Fraser.

Reports the computed style for the new -webkit-filter
property value.

Test: css3/filters/filter-property-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedFilter):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

New test to exercise computed style for -webkit-filter. Note
that drop-shadow is not yet supported.

  • css3/filters/filter-property-computed-style-expected.txt: Added.
  • css3/filters/filter-property-computed-style.html: Added.
  • css3/filters/script-tests/filter-property-computed-style.js: Added.

(testComputedFilterRule):

5:40 PM Changeset in webkit [96774] by jer.noble@apple.com
  • 14 edits in trunk

Enable WEB_AUDIO by default in the WebKit/mac port.
​https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to

the WebCore.framework bundle.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
5:35 PM Changeset in webkit [96773] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Switch to building Release target, and activate tests.
​https://bugs.webkit.org/show_bug.cgi?id=69272

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

Change from debug to release target. Switch from "Build" to
"BuildAndTest"

5:34 PM Changeset in webkit [96772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Make destructor of WebURLLoaderClient virtual.
​https://bugs.webkit.org/show_bug.cgi?id=69457

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-10-05
Reviewed by Darin Fisher.

  • public/WebURLLoaderClient.h:

(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

5:29 PM Changeset in webkit [96771] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

[WinCairo] unreviewed build correction.

  • platform/wincairo/Skipped: Update to get build green.
5:08 PM Changeset in webkit [96770] by Simon Fraser
  • 12 edits in trunk

In WebKitTestRunner, text has font smoothing in pixel snapshots
​https://bugs.webkit.org/show_bug.cgi?id=69396

Source/WebKit2:

Reviewed by Darin Adler.

Plumb through a method on WKContext that controls whether font smoothing
is enabled. Since this is a global setting, such a method is more appropriate
than a preference.

Remove leading underscores on some WKContext functions, but keep
exported versions of same for binary compatibility.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetAlwaysUsesComplexTextCodePath):
(WKContextSetShouldUseFontSmoothing):
(WKContextSetAdditionalPluginsDirectory):
(WKContextRegisterURLSchemeAsEmptyDocument):
(WKContextSetHTTPPipeliningEnabled):
(_WKContextSetAdditionalPluginsDirectory):
(_WKContextRegisterURLSchemeAsEmptyDocument):
(_WKContextSetAlwaysUsesComplexTextCodePath):
(_WKContextSetHTTPPipeliningEnabled):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setShouldUseFontSmoothing):
(WebKit::WebContext::httpPipeliningEnabled):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setShouldUseFontSmoothing):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Reviewed by Darin Adler.

Call the new WKContext method that disables font smoothing in
WebKitTestRunner, so that pixel snapshots don't have font smoothing
enabled. Remove leading underscore from a WKContext function call.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

5:01 PM Changeset in webkit [96769] by ojan@chromium.org
  • 7 edits in trunk

[flexbox] take marginBeforeForChild into account when positioning children
​https://bugs.webkit.org/show_bug.cgi?id=69313

Reviewed by Tony Chang.

Source/WebCore:

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

LayoutTests:

  • css3/flexbox/002.html:
  • css3/flexbox/writing-modes.html:
5:00 PM Changeset in webkit [96768] by levin@chromium.org
  • 2 edits in trunk/Tools

Improve the watchlist for threading entries.
​https://bugs.webkit.org/show_bug.cgi?id=69463

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
4:59 PM Changeset in webkit [96767] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations after Skia roll.

Unreviewed.

  • platform/chromium/test_expectations.txt: Added select-background-none.html on Linux.
4:46 PM Changeset in webkit [96766] by vangelis@chromium.org
  • 10 edits in trunk/Source

Switching threaded compositor from a compile time option to a
run time one.
​https://bugs.webkit.org/show_bug.cgi?id=69391

Reviewed by Darin Fisher.

Source/WebCore:

Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
called from anywhere,

No new tests as it doesn't add new functionality.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::compositeImmediately):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):
(WebKit::WebSettingsImpl::setUseThreadedCompositor):

  • src/WebSettingsImpl.h:

(WebKit::WebSettingsImpl::useThreadedCompositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

4:40 PM Changeset in webkit [96765] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Flash of white when unminimizing windows
​https://bugs.webkit.org/show_bug.cgi?id=69476
<rdar://problem/10202680>

Reviewed by Simon Fraser.

Whenever the UI process requests an immediate backing store update, make sure to resume
painting if it's suspended.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState):

4:27 PM Changeset in webkit [96764] by dino@apple.com
  • 27 edits
    1 copy
    11 adds in trunk

Parse '-webkit-filter' property syntax
​https://bugs.webkit.org/show_bug.cgi?id=68473

Reviewed by Nikolas Zimmermann.

Parse the new -webkit-filter property, looking for shorthand
functions then testing number, type and value of parameters.

Note that support for drop-shadow() was omitted from this
patch because parsing CSS shadow syntax was going to require some
refactoring of the box and text shadow code. The followup
bug is ​https://bugs.webkit.org/show_bug.cgi?id=69108.

Also, computed style will return null for filters at the moment.
That's ​https://bugs.webkit.org/show_bug.cgi?id=68477.

Tests: css3/filters/filter-property-parsing-invalid.html

css3/filters/filter-property-parsing.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Build files updated for new WebKitCSSFilterValue classes.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

Test if value is WebKitCSSFilterValue.

  • css/CSSParser.cpp:

(WebCore::filterInfoForName):
(WebCore::CSSParser::isValidFilterArgument):
(WebCore::CSSParser::parseFilter):

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:

Handle the new shorthand functions in -webkit-filter.

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSFilterValue):

Add virtual function that returns false here.

  • css/WebKitCSSFilterValue.cpp: Added.

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::cssText):

  • css/WebKitCSSFilterValue.h: Added.

(WebCore::WebKitCSSFilterValue::create):
(WebCore::WebKitCSSFilterValue::operationType):
(WebCore::WebKitCSSFilterValue::isWebKitCSSFilterValue):

  • css/WebKitCSSFilterValue.idl: Added.

WebKitCSSFilterValue modelled closely on WebKitCSSTransformValue,
basically identifying the type of operation in a CSSValueList.

  • page/DOMWindow.idl:

New WebKitCSSFilterValue constructor.

  • platform/graphics/filters/FilterOperation.h:

(WebCore::BlurFilterOperation::create):
(WebCore::BlurFilterOperation::stdDeviationX):
(WebCore::BlurFilterOperation::stdDeviationY):
(WebCore::BlurFilterOperation::BlurFilterOperation):
(WebCore::SharpenFilterOperation::create):
(WebCore::SharpenFilterOperation::radius):
(WebCore::SharpenFilterOperation::threshold):
(WebCore::SharpenFilterOperation::SharpenFilterOperation):

Use Length rather than double for parameters that are CSS lengths.

New tests that exercise the -webkit-filter syntax, with
(nearly) all the function shorthands. Since this patch also
added a global WebKitCSSFilterValue interface, the window
tests needed update, but only on the platforms that have
ENABLE(CSS_FILTERS).

  • css3/filters/filter-property-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt: Added.
  • css3/filters/filter-property-parsing-invalid-expected.txt: Added.
  • css3/filters/filter-property-parsing-invalid.html: Added.
  • css3/filters/filter-property-parsing.html: Added.
  • css3/filters/script-tests/filter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • css3/filters/script-tests/filter-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

  • css3/filters/script-tests/filter-property.js:

Updated old test which was missing quotes, plus new tests that
exercise the shorthand feature.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/js/global-constructors-expected.txt:

Updated isAppleWebkit() platform files for the new WebKitCSSFilterValue
API exposed on Window.

4:05 PM Changeset in webkit [96763] by crogers@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline webaudio/audiobuffersource-playbackrate.html due to ​http://trac.webkit.org/changeset/96745
​https://bugs.webkit.org/show_bug.cgi?id=69470

Unreviewed.

  • webaudio/audiobuffersource-playbackrate-expected.wav:
3:51 PM Changeset in webkit [96762] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
​https://bugs.webkit.org/show_bug.cgi?id=69346

Reviewed by Oliver Hunt.

Removed the assertion, since it was completely wrong for op_post_inc.
Short of having specialized PostInc nodes in the DFG, there is no
robust way of asserting what this assertion was trying to assert while
also supporting op_post_inc.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:49 PM Changeset in webkit [96761] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build - it doesn't have a log2f() function...
​https://bugs.webkit.org/show_bug.cgi?id=69473

Unreviewed build fix.

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

3:44 PM Changeset in webkit [96760] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Added a simpler mechanism for registering one-off finalizers
​https://bugs.webkit.org/show_bug.cgi?id=69466

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):

  • heap/Heap.h: New function for adding an arbitrary finalizer for an

arbitrary cell without declaring any special classes or Handles yourself.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::ExecutableBase::clearCodeVirtual):
(JSC::EvalExecutable::clearCodeVirtual):
(JSC::ProgramExecutable::clearCodeVirtual):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::clearCodeVirtual):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation): Use the new mechanism for eager
finalization of executables.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager
finalization of weak maps.

3:42 PM Changeset in webkit [96759] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
​https://bugs.webkit.org/show_bug.cgi?id=69467

Reviewed by Kenneth Russell.

Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
false-positive ASSERT().

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

3:39 PM Changeset in webkit [96758] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r96756.
​http://trac.webkit.org/changeset/96756
​https://bugs.webkit.org/show_bug.cgi?id=69472

Many builds broken due to WTFGetBacktrace not being exported
from JavaScriptCore (Requested by aroben on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-05

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
3:23 PM Changeset in webkit [96757] by Adam Roben
  • 5 edits
    2 adds in trunk

Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer

RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
pointed-to type confused us when we implemented hashTableDeletedValue.

Fixes <​http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
in HashMap/HashSet fails to compile

Reviewed by John Sullivan.

Source/JavaScriptCore:

  • wtf/RetainPtr.h:

(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
since T might itself be a pointer.

(WTF::PtrHash<RetainPtr<P> >): Updated this to use PtrType everywhere, even though T* didn't
seem to be causing a problem.

Tools:

Add tests for using RetainPtrs inside HashMap and HashSet

  • TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.

(TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
and value type of HashMap.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added new file.

3:03 PM Changeset in webkit [96756] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

save resource zeroing stacks in ScriptElement for debugging
​https://bugs.webkit.org/show_bug.cgi?id=69453

The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
75604). This patch will save a stack in the ScriptElement when this happens, so that if
we do later crash, we can see how we did the first zeroing.

See ​http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
this change will help track down.

Reviewed by Nate Chapin.

No new tests, this shouldn't affect output at all, and isn't particularly testable.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
2:57 PM Changeset in webkit [96755] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-10-05 Oliver Hunt <​oliver@apple.com>

Remove last vestiges of anonymous storage.

Reviewed by Gavin Barraclough.

One anonymous storage function escaped my prior purge of
this feature, this patch removes it.

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::finishCreation):
  • runtime/JSObject.h:
2:48 PM Changeset in webkit [96754] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

More build fix.

  • WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix.
2:46 PM Changeset in webkit [96753] by abarth@webkit.org
  • 2 edits in trunk/Tools

Mark as Expected in garden-o-matic is confusing
​https://bugs.webkit.org/show_bug.cgi?id=69452

Reviewed by David Levin.

krit didn't understand the difference between this button and the
Rebaseline button because both of them seem to indicate that the new
behavior is expected. This patch renames "Mark as Expected" to "Expect
Failure" to make it clear that we're just expecting the test to fail
rather than accepting the new results as passing. We might need to
iterate on these names a bit more if folks continue to find them
confusing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2:40 PM Changeset in webkit [96752] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[WinCairo] Create a Skipped file to support the new WinCairo test bot.
​https://bugs.webkit.org/show_bug.cgi?id=69280
(Fix bad check-in).

Reviewed by Adam Roben.

  • platform/wincairo: Added.
  • platform/wincairo/Skipped: Added.
2:40 PM Changeset in webkit [96751] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=69456

Reviewed by David Levin.

No new tests. No new functionality.

  • html/track/CueParser.cpp:

(WebCore::CueParser::didFinishLoading):

  • html/track/CueParser.h:
2:36 PM Changeset in webkit [96750] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG should be capable of a broader range of speculations on branch and not
​https://bugs.webkit.org/show_bug.cgi?id=69322

Reviewed by Oliver Hunt.

  • bytecode/PredictedType.h:

(JSC::isFinalObjectOrOtherPrediction):
(JSC::isArrayOrOtherPrediction):

  • dfg/DFGJITCodeGenerator.cpp:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

2:35 PM Changeset in webkit [96749] by bfulgham@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

[WinCairo] Create a Skipped file to support the new WinCairo test bot.
​https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

  • platform/wincairo: Added.
  • platform/wincairo/Skipped: Added.
2:35 PM Changeset in webkit [96748] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<​http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db

Reviewed by Alexey Proskuryakov.

  • Storage/WebStorageManager.mm:

(+[WebStorageManager _storageDirectoryPath]): Restore call to
-[NSString stringByStandardizingPath]. Also fix over-release of
sLocalStoragePath if the initial -objectForKey: call returned an
NSString object. Use pthread_once to be thread-safe.

2:31 PM WikiStart edited by ariya@webkit.org
(diff)
2:31 PM JavaScriptCore created by ariya@webkit.org
let's just call it JavaScriptCore, without ".. Overview" suffix
2:15 PM Changeset in webkit [96747] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit build fix.

  • WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors. In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure.
2:13 PM WikiStart edited by ariya@webkit.org
link to JavaScriptCore Overview (diff)
2:01 PM Changeset in webkit [96746] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add watchlist entries for abarth
​https://bugs.webkit.org/show_bug.cgi?id=69461

Reviewed by David Levin.

I might have gone a bit overboard. We'll see if this is too much spam
for me.

  • Scripts/webkitpy/common/config/watchlist:
1:53 PM Changeset in webkit [96745] by jer.noble@apple.com
  • 93 edits in trunk/Source

WEB_AUDIO does not compile on Leopard 32-bit.
​https://bugs.webkit.org/show_bug.cgi?id=69292

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by all existing audio tests.

Use of float and double within the WEB_AUDIO implementation have been harmonized, with most
calculations done using floats, with narrowPrecisionToFloat() added when necessary to
narrow double results down to floats, and with float constants initialized with float values:

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createByMixingToMono):

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::sampleRate):
(WebCore::AudioBus::setSampleRate):

  • platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::AudioDSPKernel):
(WebCore::AudioDSPKernel::sampleRate):

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/AudioDestination.h:
  • platform/audio/AudioFileReader.h:
  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::AudioProcessor):
(WebCore::AudioProcessor::sampleRate):

  • platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::decibelsToLinear):
(WebCore::AudioUtilities::linearToDecibels):
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):

  • platform/audio/AudioUtilities.h:
  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::parameterValue):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):

  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::sampleRate):
(WebCore::DynamicsCompressor::nyquist):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::saturate):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/DynamicsCompressorKernel.h:
  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::create):
(WebCore::HRTFDatabase::HRTFDatabase):

  • platform/audio/HRTFDatabase.h:

(WebCore::HRTFDatabase::sampleRate):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):

  • platform/audio/HRTFDatabaseLoader.h:

(WebCore::HRTFDatabaseLoader::databaseSampleRate):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
(WebCore::HRTFElevation::createForSubject):
(WebCore::HRTFElevation::createByInterpolatingSlices):

  • platform/audio/HRTFElevation.h:

(WebCore::HRTFElevation::sampleRate):
(WebCore::HRTFElevation::HRTFElevation):

  • platform/audio/HRTFKernel.cpp:

(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFKernel.h:

(WebCore::HRTFKernel::create):
(WebCore::HRTFKernel::frameDelay):
(WebCore::HRTFKernel::sampleRate):
(WebCore::HRTFKernel::HRTFKernel):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::fftSizeForSampleRate):

  • platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::sampleRate):

  • platform/audio/Panner.cpp:

(WebCore::Panner::create):

  • platform/audio/Panner.h:
  • platform/audio/chromium/AudioBusChromium.cpp:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):

  • platform/audio/mac/AudioDestinationMac.h:

(WebCore::AudioDestinationMac::sampleRate):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/mac/AudioFileReaderMac.h:
  • webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
(WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):

  • webaudio/AsyncAudioDecoder.h:

(WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):

  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):
(WebCore::AudioBuffer::AudioBuffer):

  • webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::sampleRate):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

  • webaudio/AudioBufferSourceNode.h:
  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::AudioChannelMerger):

  • webaudio/AudioChannelMerger.h:

(WebCore::AudioChannelMerger::create):

  • webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::AudioChannelSplitter):

  • webaudio/AudioChannelSplitter.h:

(WebCore::AudioChannelSplitter::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::createBuffer):

  • webaudio/AudioContext.h:

(WebCore::AudioContext::sampleRate):

  • webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

  • webaudio/AudioGainNode.h:

(WebCore::AudioGainNode::create):

  • webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • webaudio/AudioListener.h:

(WebCore::AudioListener::setPosition):
(WebCore::AudioListener::setOrientation):
(WebCore::AudioListener::setVelocity):

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):

  • webaudio/AudioNode.h:

(WebCore::AudioNode::sampleRate):

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::getAzimuthElevation):

  • webaudio/AudioPannerNode.h:

(WebCore::AudioPannerNode::create):

  • webaudio/AudioParam.cpp:

(WebCore::AudioParam::value):
(WebCore::AudioParam::smoothedValue):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateSampleAccurateValues):

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::timeToSampleFrame):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • webaudio/AudioSourceNode.h:

(WebCore::AudioSourceNode::AudioSourceNode):

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

  • webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::create):

  • webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • webaudio/BiquadProcessor.h:
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::create):

  • webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):

  • webaudio/DefaultAudioDestinationNode.h:

(WebCore::DefaultAudioDestinationNode::sampleRate):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):

  • webaudio/DelayDSPKernel.h:
  • webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • webaudio/DelayNode.h:

(WebCore::DelayNode::create):

  • webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • webaudio/DelayProcessor.h:
  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::create):

  • webaudio/HighPass2FilterNode.cpp:

(WebCore::HighPass2FilterNode::HighPass2FilterNode):

  • webaudio/HighPass2FilterNode.h:

(WebCore::HighPass2FilterNode::create):

  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):

  • webaudio/JavaScriptAudioNode.h:
  • webaudio/LowPass2FilterNode.cpp:

(WebCore::LowPass2FilterNode::LowPass2FilterNode):

  • webaudio/LowPass2FilterNode.h:

(WebCore::LowPass2FilterNode::create):

  • webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::sampleRate):

  • webaudio/RealtimeAnalyserNode.cpp:

(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):

  • webaudio/RealtimeAnalyserNode.h:

(WebCore::RealtimeAnalyserNode::create):

  • webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::process):

  • webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::WaveShaperProcessor):

  • webaudio/WaveShaperProcessor.h:

Source/WebKit/chromium:

Platform-independent portions of WEB_AUDIO have changed from double -> float, and
platform-specific subclasses must change as well.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::sampleRate):

1:36 PM Changeset in webkit [96744] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

[WinCairo] Teach old-run-webkit-tests about wincairo.
​https://bugs.webkit.org/show_bug.cgi?id=69280

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests: Handle wincairo case.

(buildPlatformResultHierarchy):
(readSkippedFiles): Ditto

  • Scripts/webkitdirs.pm: Deal with wincairo build case.

(determineConfiguration):

1:28 PM Changeset in webkit [96743] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
​https://bugs.webkit.org/show_bug.cgi?id=69274

Reviewed by Andreas Kling.

Use currently existing QtWidgets to provide an implementation of
window.alert(), window.confirm() and window.prompt().

  • Shared/WebString.h:

(WebKit::WebString::createNull):
(WebKit::WebString::WebString):
Add a way to create a Null WebString. RunJavaScriptPrompt will differentiate
between empty and null strings.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
Create helper functions to enable and disable mouse events. This is useful for
disabling mouse events in the WebView when we show QtWidget dialogs to avoid
unwanted interaction with the page.

(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::init):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(createNullWKString):
(qt_wk_runJavaScriptPrompt):

  • UIProcess/qt/ClientImpl.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::runJavaScriptAlert):
(WebKit::TouchViewInterface::runJavaScriptConfirm):
(WebKit::TouchViewInterface::runJavaScriptPrompt):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
1:25 PM Changeset in webkit [96742] by Michael Nordman
  • 5 edits in branches/chromium/874/Source/WebCore

Merge 96554 - A little more WebSQLDatabase thread safety.

​https://bugs.webkit.org/show_bug.cgi?id=69277

  • switch to using AtomicallyInitializedStatic where appropiate
  • avoid using some Strings across threads

Reviewed by David Levin.

Existing tests apply.

  • storage/AbstractDatabase.cpp:

(WebCore::guidMutex):

(WebCore::guidToVersionMap):

(WebCore::guidToDatabaseMap):

(WebCore::guidForOriginAndName):

(WebCore::AbstractDatabase::databaseInfoTableName):

(WebCore::AbstractDatabase::AbstractDatabase):

(WebCore::AbstractDatabase::performOpenAndVerify):

(WebCore::AbstractDatabase::getVersionFromDatabase):

(WebCore::AbstractDatabase::setVersionInDatabase):

  • storage/AbstractDatabase.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::tracker):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::instance):

TBR=Michael Nordman
Review URL: ​http://codereview.chromium.org/8152004

1:01 PM Changeset in webkit [96741] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r96733.
​http://trac.webkit.org/changeset/96733
​https://bugs.webkit.org/show_bug.cgi?id=69454

Broke GCC for some reason (Requested by andersca on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-05

  • wtf/ListHashSet.h:

(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):

12:46 PM Changeset in webkit [96740] by commit-queue@webkit.org
  • 17 edits
    3 adds in trunk

[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
​https://bugs.webkit.org/show_bug.cgi?id=68924

Source/WebKit2:

Implemented WKBundlePage private APIs to support the above functions.

Patch by Chang Shu <​cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetComposition):
(WKBundlePageHasComposition):
(WKBundlePageConfirmComposition):
(WKBundlePageConfirmCompositionWithText):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting):
(WebKit::WebPage::hasCompositionForTesting):
(WebKit::WebPage::confirmCompositionForTesting):

  • WebProcess/WebPage/WebPage.h:

Tools:

Added TextInputController files and JS interfaces for the above functions.

Patch by Chang Shu <​cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::textInputController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.

(WTR::TextInputController::create):
(WTR::TextInputController::TextInputController):
(WTR::TextInputController::~TextInputController):
(WTR::TextInputController::wrapperClass):
(WTR::TextInputController::makeWindowObject):
(WTR::TextInputController::setMarkedText):
(WTR::TextInputController::hasMarkedText):
(WTR::TextInputController::unmarkText):
(WTR::TextInputController::insertText):

  • WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <​cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

  • platform/wk2/Skipped:
12:22 PM Changeset in webkit [96739] by ap@apple.com
  • 10 edits in trunk/Source

[Mac] Make built-in PDF description localizable
​https://bugs.webkit.org/show_bug.cgi?id=69442

Reviewed by Dan Bernstein.

Source/WebCore:

Added strings for plug-in's name and for its supported MIME type.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in:
  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::builtInPDFPluginName):
(WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription):

  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::builtInPDFPluginName):
(WebCore::pdfDocumentTypeDescription):

  • platform/LocalizedStrings.h:

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Use a localized string instead of a literal one.
12:07 PM Changeset in webkit [96738] by oliver@apple.com
  • 7 edits in trunk

Add rudimentary filtering to write barriers
​https://bugs.webkit.org/show_bug.cgi?id=69392

Reviewed by Filip Pizlo.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add approximate filtering for write barriers based on the
target's mark bit. Also add some macros to support dumping
GC phase timings.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::markCellCard):

  • heap/Heap.cpp:

(JSC::GCTimer::GCTimerScope::GCTimerScope):
(JSC::GCTimer::GCTimerScope::~GCTimerScope):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

Add phase timing information.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::offsetOfMarks):
(JSC::MarkedBlock::gatherDirtyCells):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

When we're recording gc phase times Heap.o picks up
some exit time destructors, so we'll just ignore Heap.o
in this check.

  • Scripts/check-for-exit-time-destructors:
12:04 PM Changeset in webkit [96737] by levin@chromium.org
  • 5 edits in trunk/Source/WebCore

Attempt to fix the bindings test (broken by r96727).
Reviewed by Adam Barth.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

11:46 AM Changeset in webkit [96736] by jamesr@google.com
  • 16 edits
    2 adds in trunk/Source

[chromium] Hook WebCompositor interface for input events up to the compositor proper
​https://bugs.webkit.org/show_bug.cgi?id=69394

Reviewed by Darin Fisher.

Source/WebCore:

This wires up WebCompositorImpl to the compositor itself so we can handle input events as scrolls on the
compositor thread, although it doesn't actually wire up any input events to actual scrolling. The way this
works:

  • CCThreadProxy owns an adapter that implements the CCScrollController interface
  • CCThreadProxy owns a CCInputHandler, which is implemented by WebKit::WebCompositorImpl, that has a pointer to

the adapter

  • CCLayerTreeHost has an identifier (an int) for its WebKit::WebCompositorImpl that's initialized in

initializeLayerRenderer. This identifier is exposed to its owner (WebKit::WebViewImpl) so the embedder can wire
up the threading logic behind the scenes.

This is just plumbing, no change in behavior.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCInputHandler.h: Added.

(WebCore::CCInputHandler::~CCInputHandler):
(WebCore::CCInputHandler::CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::compositorIdentifier):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScrollController.h: Added.

(WebCore::CCScrollController::CCScrollController):
(WebCore::CCScrollController::~CCScrollController):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::compositorIdentifier):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxyScrollControllerAdapter::create):
(WebCore::CCThreadProxyScrollControllerAdapter::~CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxyScrollControllerAdapter::scrollRootLayer):
(WebCore::CCThreadProxyScrollControllerAdapter::CCThreadProxyScrollControllerAdapter):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::compositorIdentifier):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

This teaches WebCompositorImpl about WebCore::CCInputHandler, which WebCompositorImpl implements, and
CCScrollController, which WebCompositorImpl will use in the future to do actual scrolling. One thing that is a
bit unusual here is WebCore::CCInputHandler::create() which is defined in WebCompositorImpl.cpp. This is
because we need a WebKit object (WebKit::WebCompositorImpl) to be owned by a WebCore object (WebCore::CCThreadProxy).
The WebCore side only needs to know about the interface, CCInputHandler, but the actual implementation has to
live in WebKit in order to know about the concrete type.

  • src/WebCompositorImpl.cpp:

(WebCore::CCInputHandler::create):
(WebKit::WebCompositor::fromIdentifier):
(WebKit::WebCompositorImpl::fromIdentifier):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::identifier):

  • src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/WebCompositorImplTest.cpp:
11:36 AM Changeset in webkit [96735] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/874

Merge 96552 - REGRESSION(r94274): cloned text input loses value
​https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

  • fast/forms/clone-input-with-dirty-value-expected.txt: Added.
  • fast/forms/clone-input-with-dirty-value.html: Added.

Review URL: ​http://codereview.chromium.org/8142040

11:31 AM Changeset in webkit [96734] by rniwa@webkit.org
  • 2 edits
    1 copy in branches/chromium/874/Source/WebCore

Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event
​https://bugs.webkit.org/show_bug.cgi?id=69315

Reviewed by Kent Tamura.

Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.

Added a manual test. Unfortunately, the test always passes in DRT.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/FrameSelection.h:
  • manual-tests/mutate-unfocused-text-with-selection.html: Added.

Review URL: ​http://codereview.chromium.org/8133029

11:29 AM Changeset in webkit [96733] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use std::reverse_iterator for ListHashSet reverse iterators
​https://bugs.webkit.org/show_bug.cgi?id=69446

Reviewed by Darin Adler.

  • wtf/ListHashSet.h:

Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.

11:22 AM Changeset in webkit [96732] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink OutlineValue.
​https://bugs.webkit.org/show_bug.cgi?id=69436

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Move OutlineValue::m_isAuto up into the base class (BorderValue.)
This shrinks OutlineValue by 32 bit, which in turn shrinks
StyleBackgroundData by one CPU word.

This reduces memory consumption by 250 kB (on 64-bit) when loading
the full HTML5 spec.

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::isAuto):

11:21 AM Changeset in webkit [96731] by commit-queue@webkit.org
  • 13 edits in trunk

[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
​https://bugs.webkit.org/show_bug.cgi?id=69365

Patch by Chang Shu <​cshu@webkit.org> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Expose computeViewportAttributes for mac build.

  • WebCore.exp.in:

Source/WebKit2:

Implement retrieving viewport configuration as text in WebProcess.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageViewportConfigurationAsText):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewportConfigurationAsText):

  • WebProcess/WebPage/WebPage.h:

Tools:

Added js API in WTR LayoutTestController.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::dumpConfigurationForViewport):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip passed tests on Qt. The tests work on Mac, too. But they are skipped by
platform/mac/Skipped.

  • platform/qt-wk2/Skipped:
11:20 AM WebKitGTK edited by plaes@plaes.org
Fix links (diff)
11:18 AM Changeset in webkit [96730] by simonjam@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

[Chromium] Add baselines for new SVG tests from r96712.

  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
11:17 AM WebKitGTK/1.4.x edited by plaes@plaes.org
Fix title (diff)
11:16 AM WebKitGTK/1.4.x edited by plaes@plaes.org
Remove strikethrough so it's a bit more readable. (diff)
11:15 AM Changeset in webkit [96729] by barraclough@apple.com
  • 8 edits in trunk

Make Object.prototype getter/setter methods match ES5 behaviour
​https://bugs.webkit.org/show_bug.cgi?id=69393

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The rest of Object.prototype no longer substitute Null/Undefined with the global object,
this is old ES3 behaviour. Remove it here too.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

Update tests to conform with ES5 style handling of 'this' in host functions.

  • fast/dom/Window/Location/window-override-location-using-defineGetter.html:
  • fast/dom/Window/Location/window-override-window-using-defineGetter.html:
  • fast/js/exception-sequencing-binops.js:
  • fast/js/exception-sequencing.html:
  • fast/js/pic/delete-global-object.html:
11:15 AM WebKitGTK/1.4.x edited by plaes@plaes.org
Added changeset descriptions for 1.4.1 (diff)
11:10 AM WebKitGTK/1.6.x edited by plaes@plaes.org
Added link to 1.4.x (diff)
11:09 AM WebKitGTK/1.4.x created by plaes@plaes.org
Preliminary page for 1.4.x
11:09 AM Changeset in webkit [96728] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-05 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed. Skipping media layout tests for Mac Leopard GPU.

They're a maintenance burden and we don't run the GPU compositor on Leopard.

  • platform/chromium/test_expectations.txt:
11:08 AM Changeset in webkit [96727] by annacc@chromium.org
  • 9 edits in trunk/Source

Source/WebCore: Functions to make <track> enabled at runtime, including changes to
CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
be runtime-enabled.
​https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

No new tests. No new functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):

  • html/HTMLTrackElement.idl:

Source/WebKit/chromium: Functions to make <track> enabled at runtime.
​https://bugs.webkit.org/show_bug.cgi?id=69352

Reviewed by Adam Barth.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableVideoTrack):
(WebKit::WebRuntimeFeatures::isVideoTrackEnabled):

11:07 AM Changeset in webkit [96726] by kbr@google.com
  • 4 edits
    2 adds in trunk

Mask underlying RENDERER and VENDOR strings
​https://bugs.webkit.org/show_bug.cgi?id=69389

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/canvas/webgl/renderer-and-vendor-strings.html

  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

  • fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
  • fast/canvas/webgl/renderer-and-vendor-strings.html: Added.
11:02 AM Changeset in webkit [96725] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)

Temporarily disable Skia on Mac on Leopard and Snow Leopard.

  • LayoutTests/platform/chromium/test_expectations.txt:
11:00 AM WebKitGTK/1.6.x edited by plaes@plaes.org
Add back "Changes merged" (diff)
10:59 AM WebKitGTK/1.6.x edited by plaes@plaes.org
Added 1.6.1 for history purposes (diff)
10:56 AM Changeset in webkit [96724] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] ImageDiff: Do not clear the image before it is processed and compared
​https://bugs.webkit.org/show_bug.cgi?id=69378

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

Commit 61836 to Evas added a few cleanup calls to some
evas_object_image functions which effectively made ImageDiff consider
all images to be equal.

It turns out that now evas_object_image_colorspace_set clears any
data set, so the call to evas_object_image_data_set was not having any
effect.

  • DumpRenderTree/efl/ImageDiff.cpp:

(readImageFromStdin): Call evas_object_image_data_set after
evas_object_image_colorspace_set.

10:54 AM WebKitGTK/1.6.x created by plaes@plaes.org
Create proper page for 1.6.x releases
10:51 AM Changeset in webkit [96723] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
​https://bugs.webkit.org/show_bug.cgi?id=68449

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-05
Reviewed by Antonio Gomes.

evas_render() must be called to close up temporary files and unmap unused
resources. evas_object_image_data_set() must be called after an
evas_object_image_data_get() to balance an internal reference count.

  • DumpRenderTree/efl/ImageDiff.cpp:

(differenceImageFromDifferenceBuffer):
(calculateDifference):
(printImage):
(printImageDifferences):

10:44 AM Changeset in webkit [96722] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Get rid of posixThread in MachineStackMarker::Thread
​https://bugs.webkit.org/show_bug.cgi?id=54836

Reviewed by Oliver Hunt.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::equalThread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):

10:41 AM Changeset in webkit [96721] by commit-queue@webkit.org
  • 9 edits
    1 copy
    3 adds in trunk

Spec change - option.label should be reflected like option.value
​https://bugs.webkit.org/show_bug.cgi?id=68684

Patch by Sachin Puranik <​jcqt43@motorola.com> on 2011-10-05
Reviewed by Darin Adler.

Source/WebCore:

Incorporating the recent change in spec for label attribute of
option element. While retrieving the "Label" IDL attribute return
the "Label" content attribute if present , else return the
value of textContent attribute.

Tests: fast/forms/option-label-trim-html-spaces.html

fast/forms/option-value-and-label-changed-by-js.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):style fixes

  • dom/OptionElement.h: make collectOptionInnerText() protected.
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::label): return innerText if label attribute un-available.
(WebCore::HTMLOptionElement::setLabel):setLabel() implementation.

  • html/HTMLOptionElement.h: add setLabel declaration.
  • html/HTMLOptionElement.idl: Change reflect to ConvertNullToNullString in idl

LayoutTests:

IDL "Label" attribute of option element should return textContent IDL attribute
if conetent attribute "Label" is unavailable. Changed the tests to match
above said behaviour. Added new tests.

  • fast/forms/option-label-trim-html-spaces-expected.txt: Html space triming test.
  • fast/forms/option-label-trim-html-spaces.html: Html space triming test.
  • fast/forms/option-value-and-label-changed-by-js-expected.txt: Attribute change from JS.
  • fast/forms/option-value-and-label-changed-by-js.html: Attribute change from JS.
  • fast/forms/option-value-and-label-expected.txt: Changed test case as per new spec.
  • fast/forms/option-value-and-label.html: Changed test case as per new spec.
10:39 AM Changeset in webkit [96720] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix compilation with gtk v2.20.1
​https://bugs.webkit.org/show_bug.cgi?id=69418

Unreviewed build fix

Patch by Rémi Duraffort <​remi.duraffort@st.com> on 2011-10-05

  • platform/gtk/GtkDragAndDropHelper.cpp:
10:19 AM Changeset in webkit [96719] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Reduce test flakyness.
There was a race between Inspector's internal page reloaded message and load event.

  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
10:05 AM Changeset in webkit [96718] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68731

Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
translation offset and clip rects when overflow or outlines spill out.

Reviewed by Darin Adler.

Source/WebCore:

Added new test in fast/regions.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOverflowRect):

LayoutTests:

  • fast/regions/outline-sides-in-region.html: Added.
  • platform/mac/fast/regions/outline-sides-in-region-expected.png: Added.
  • platform/mac/fast/regions/outline-sides-in-region-expected.txt: Added.
9:52 AM Changeset in webkit [96717] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Removed JSValue::toJSNumber
​https://bugs.webkit.org/show_bug.cgi?id=69399

No perf. change.

toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:
9:51 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the WK2 bot (diff)
9:45 AM Changeset in webkit [96716] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.

  • WebCore.xcodeproj/project.pbxproj:
9:39 AM Changeset in webkit [96715] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

libsoup-CRITICAL : soup_message_io_pause: assertion `io != NULL' failed
​https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Xan Lopez.

No new tests. This is difficult to test because it relies on network
timing and to catch and parse stdout.

Instead of allowing messages to pause and unpause after receiving headers,
we wait until the completion of the sendRequestCallback. This will ensure
that the SoupSession is in the correct state to allow for pausing and unpausing.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause
until the sendRequestCallback is called. We detect this situation by
checking whether or not we have an input stream yet. Previously the code
was only pausing until after soupMessage->status_code was not equal to
SOUP_STATUS_NONE. This means that the message was pausable right after
headers are received. sendRequestCallback happens some time after that.

9:27 AM Changeset in webkit [96714] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Unskip sputnik tests, because they pass with newer Qt5.
9:27 AM Changeset in webkit [96713] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Debug builders.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

9:20 AM Changeset in webkit [96712] by krit@webkit.org
  • 4 edits
    10 adds in trunk

SVG 1.1: ineffectual transform attribute for ClipPath
​https://bugs.webkit.org/show_bug.cgi?id=55361

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Respect 'transform' attribute/property for <clip-path>.
If the masking code path is used the mask context gets transformed, otherwise the path itself.

Tests: svg/clip-path/clip-path-transform-1.svg

svg/clip-path/clip-path-transform-2.svg
svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path.
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation.

  • rendering/svg/RenderSVGResourceClipper.h:

LayoutTests:

Reviewed by Nikolas Zimmermann.

Test that the clip path gets concatenated with the current animated transformation and
that hit testing is affected correctly.

  • platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Added.
  • svg/clip-path/clip-path-transform-1.svg: Added. Test clipping to path with transform.
  • svg/clip-path/clip-path-transform-2.svg: Added. Test masking with transform.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Added.
  • svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html: Added.
  • svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js: Added.

(executeBackgroundTest):
(executeTest):

9:14 AM Changeset in webkit [96711] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline.
​https://bugs.webkit.org/show_bug.cgi?id=69431

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.hide):
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._reset):
(WebInspector.ElementsPanel.prototype._nodeRemoved):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.wireToDomAgent):
(WebInspector.ElementsTreeOutline.prototype.setVisible):
(WebInspector.ElementsTreeOutline.prototype.addEventListener):
(WebInspector.ElementsTreeOutline.prototype.removeEventListener):
(WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
(WebInspector.ElementsTreeOutline.prototype.update):
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode):
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
(WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange):
(WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
(WebInspector.ElementsTreeElement.prototype.insertChildElement):
(WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._editingCancelled):
():

  • inspector/front-end/externs.js:

(WebInspector.ElementsTreeOutline):

  • inspector/front-end/utilities.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpElementsTree):
(initialize_ElementTest.InspectorTest.expandElementsTree.onAllNodesAvailable):
(initialize_ElementTest.InspectorTest.expandElementsTree):

  • inspector/elements/edit-dom-actions.html:
  • inspector/styles/styles-update-from-js.html:
9:10 AM Changeset in webkit [96710] by yurys@chromium.org
  • 23 edits
    1 copy in trunk/Source

Web Inspector: provide a way for persisting worker inspector state
​https://bugs.webkit.org/show_bug.cgi?id=69422

Source/WebCore:

Worker inspector can persist and restore its state. InspectorStateClient is
exctracted into a separate interface and has a custom implementation in case
of worker inspector.

Reviewed by Pavel Feldman.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.h:
  • inspector/InspectorState.cpp:

(WebCore::InspectorState::InspectorState):

  • inspector/InspectorState.h:
  • inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h.

(WebCore::InspectorStateClient::~InspectorStateClient):
(WebCore::InspectorStateClient::updateInspectorStateCookie):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postMessageToPageInspector):
(WebCore::SharedWorkerProxy::updateInspectorStateCookie):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::updateInspectorStateCookie):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:

Source/WebKit/chromium:

Provided an API for saving/restoring worker inspector state.

Reviewed by Pavel Feldman.

  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):

  • public/WebSharedWorker.h:

(WebKit::WebSharedWorker::reattachDevTools):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):

  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):

  • src/WebWorkerClientImpl.h:
9:09 AM Changeset in webkit [96709] by loislo@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

Web Inspector: debugger-activation-crash2.html are flaky.
​https://bugs.webkit.org/show_bug.cgi?id=69428

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-activation-crash2-expected.txt:
  • inspector/debugger/debugger-activation-crash2.html:
  • platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
9:00 AM WebKitGTK edited by plaes@plaes.org
Link to a new page for stable version tracking (diff)
8:51 AM Changeset in webkit [96708] by gavinp@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
​https://bugs.webkit.org/show_bug.cgi?id=69424

Skip an extra frame in WTFReportBacktrace. As well, I now don't count skipped frames in maxFrames,
so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
31 reported frames.

Reviewed by Adam Roben.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
8:40 AM Changeset in webkit [96707] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

Crash in SVGTRefElement::updateReferencedText.
​https://bugs.webkit.org/show_bug.cgi?id=67555

Reviewed by Rob Buis.

Source/WebCore:

Test: svg/text/tref-event-listener-crash.svg

  • svg/SVGTRefElement.cpp:

(WebCore::SubtreeModificationEventListener::clear): This fixes the
crash. there can be cases when our target is removed, but our event
listener is alive. when our tref is going away, we need to disable
those event listeners by nulling out our tref element.
(WebCore::SubtreeModificationEventListener::handleEvent): Adding
null check for tref element, which can happen in cases where
event listener's clear is called, but we could not remove it from
the target.
(WebCore::SVGTRefElement::~SVGTRefElement): There are always
cases when removedFromDocument is not called. So, important to
clear event listener in those cases.
(WebCore::SVGTRefElement::svgAttributeChanged): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::buildPendingResource): Common function
to prevent triple duplication of same code. made it more readable.
(WebCore::SVGTRefElement::insertedIntoDocument): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::removedFromDocument): Use new helper
removeEventListener.
(WebCore::SVGTRefElement::clearEventListener): Helper to clear
event listener. Name chosen to not collide with Node::removeEventListener.

  • svg/SVGTRefElement.h: definition of new helpers.
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
logic as tref and use element. more asserts and easy bailouts.

LayoutTests:

  • svg/text/tref-event-listener-crash-expected.txt: Added.
  • svg/text/tref-event-listener-crash.svg: Added.
8:18 AM Changeset in webkit [96706] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-05 Pavel Feldman <​pfeldman@google.com>

Not reviewed: restoring : shortcut in inspector.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSidebarButtons):
8:13 AM Changeset in webkit [96705] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Shrink FontDescription.
​https://bugs.webkit.org/show_bug.cgi?id=69426

Reviewed by Nikolas Zimmermann.

Pack FontDescription's members in a bitfield, effectively shrinking
the class by two CPU-words. This reduces memory consumption by ~1 MB
on 64-bit when loading the full HTML5 spec.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::orientation):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::widthVariant):

7:51 AM Changeset in webkit [96704] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] First test always fails because of useless xcb dump
​https://bugs.webkit.org/show_bug.cgi?id=69132

Unskip the first test because the failure always affects the first test we run
so skipping makes no sense.

  • platform/qt-wk2/Skipped:
7:30 AM Changeset in webkit [96703] by vsevik@chromium.org
  • 13 edits
    5 adds in trunk

Web Inspector: Add support for search in script content.
​https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html

http/tests/inspector/search/search-in-script.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):

  • http/tests/inspector/search/resources/search-concatenated.html: Added.
  • http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-concatenated-script.html: Added.
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-script.html: Added.
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest):

  • inspector/debugger/content-providers.html:
  • platform/qt/Skipped:
7:20 AM Changeset in webkit [96702] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
​https://bugs.webkit.org/show_bug.cgi?id=69111

Reviewed by Kenneth Rohde Christiansen.

Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.

Source/WebCore:

No new tests : existing ones should cover.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::SharedCookieJarQt):

Source/WebKit2:

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDataLocation):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

7:19 AM Changeset in webkit [96701] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Try to paint the bot green.

Unreviewed gardening.

  • platform/qt-wk2/Skipped:
7:14 AM Changeset in webkit [96700] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(FILTERS) after r96203.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientUpdatedFromElement):

6:53 AM Changeset in webkit [96699] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

WTR needs an implementation for eventSender.continuousMouseScrollBy
​https://bugs.webkit.org/show_bug.cgi?id=69417

Unreviewed gardening: skip dependent test.

  • platform/wk2/Skipped:
6:08 AM Changeset in webkit [96698] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Unreviewed build fix.

Don't use WebCore directly in WTR.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

5:21 AM Changeset in webkit [96697] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for windows bots after r96679.

  • html/NumberInputType.h:
5:03 AM Changeset in webkit [96696] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline for test.

  • inspector/debugger/linkifier-expected.txt:
4:55 AM Changeset in webkit [96695] by pfeldman@chromium.org
  • 20 edits in trunk/Source/WebCore

Web Inspector: make ResourceView(s) compile
​https://bugs.webkit.org/show_bug.cgi?id=69351

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._sortCookies):

  • inspector/front-end/DataGrid.js:
  • inspector/front-end/EmptyView.js:
  • inspector/front-end/FontView.js:

(WebInspector.FontView.prototype._createContentIfNeeded):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/NetworkItemView.js:
  • inspector/front-end/ResourceCookiesView.js:
  • inspector/front-end/ResourceHTMLView.js:

(WebInspector.ResourceHTMLView.prototype.hide):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHeadersText):

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):

  • inspector/front-end/ResourcePreviewView.js:
  • inspector/front-end/ResourceResponseView.js:
  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):

  • inspector/front-end/SourceFrame.js:
  • inspector/front-end/TabbedPane.js:
  • inspector/front-end/UIUtils.js:

(Number.secondsToString):
(Number.bytesToString):

  • inspector/front-end/inspector.js:
4:41 AM Changeset in webkit [96694] by loislo@chromium.org
  • 11 edits
    2 adds in trunk

Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
​https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/linkifier.html

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/linkifier-expected.txt: Added.
  • inspector/debugger/linkifier.html: Added.
4:38 AM Changeset in webkit [96693] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
​https://bugs.webkit.org/show_bug.cgi?id=64914

Reviewed by Antti Koivisto.

Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.

Also added a compile-time assertion to guard against future bloating of
the InlineBox class.

  • rendering/InlineBox.cpp:

(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

4:24 AM Changeset in webkit [96692] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Shrink FontFallbackList.
​https://bugs.webkit.org/show_bug.cgi?id=69093

Rubber-stamped by Antti Koivisto.

Workaround MSVC quirk by making enum bitfield "unsigned".

  • platform/graphics/FontFallbackList.h:
4:19 AM Changeset in webkit [96691] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Shrink StyleRareNonInheritedData.
​https://bugs.webkit.org/show_bug.cgi?id=69331

Reviewed by Darin Adler.

Workaround MSVC quirk by making enum bitfields "unsigned".

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::transformStyle3D):
(WebCore::InheritedFlags::backfaceVisibility):
(WebCore::InheritedFlags::pageSizeType):

  • rendering/style/StyleRareNonInheritedData.h:
3:32 AM Changeset in webkit [96690] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed WinCE build fix for r96595.

  • wtf/Assertions.cpp:

RtlCaptureStackBackTrace() isn't available on WinCE.

3:12 AM Changeset in webkit [96689] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: add CSS model classes to the compilation.
​https://bugs.webkit.org/show_bug.cgi?id=69376

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-10-05
Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CSSCompletions.js:
  • inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/ResourceTreeModel.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

  • inspector/front-end/externs.js:

(Array.prototype.keySet):

2:28 AM Changeset in webkit [96688] by levin@chromium.org
  • 2 edits in trunk/Tools

watchlist: Add more rules for chromium public api and sort the file.
​https://bugs.webkit.org/show_bug.cgi?id=69323

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
2:26 AM Changeset in webkit [96687] by hans@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Rebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
for chromium-cg-mac after r96675. (By Garden-o-Matic.)

  • platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
2:25 AM Changeset in webkit [96686] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Input styles are unexpectedly shared regardless of required status difference.
​https://bugs.webkit.org/show_bug.cgi?id=69402

Reviewed by Daniel Bates.

Source/WebCore:

Tests: fast/css/pseudo-required-shared.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().

LayoutTests:

  • fast/css/pseudo-required-shared-expected.html: Added.
  • fast/css/pseudo-required-shared.html: Added.
2:21 AM Changeset in webkit [96685] by levin@chromium.org
  • 7 edits in trunk/Tools

watchlist: Don't add the same message to a bug more than once.
​https://bugs.webkit.org/show_bug.cgi?id=69303

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine

if a message is in the comments already.

  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:

Pick a bug supplied by the mock. Change the test due to different output
from the mock watch list tool.

  • Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return

another email so it will be filtered out, fix bugs to have the cc and comment fields,
and fix fetch_bug to handle bug_id's which are text (because that took me way too long
to debug).

  • Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments

and/or cc's that are already in the bug.

  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,

and remove a comment that is filtered out.

2:09 AM Changeset in webkit [96684] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Unreviewed build fix after r96643.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

2:03 AM Changeset in webkit [96683] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected file after r96509.

  • platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt:
1:21 AM Changeset in webkit [96682] by yurys@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: save inspector state into single string instead of string map
​https://bugs.webkit.org/show_bug.cgi?id=69335

Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):

  • src/WebDevToolsAgentImpl.h:
1:09 AM Changeset in webkit [96681] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests.
1:03 AM Changeset in webkit [96680] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Use WKRetainPtr for WK types in WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=69404

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextFinalize):
(createDefaultWebContext):
(webkitWebContextGetWKContext):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri):
(webkit_web_view_load_alternate_html):

Oct 4, 2011:

11:07 PM Changeset in webkit [96679] by tkent@chromium.org
  • 10 edits in trunk/Source/WebCore

Remove Node::willBlur()
​https://bugs.webkit.org/show_bug.cgi?id=69395

Reviewed by Ryosuke Niwa.

Revert the WebCore part of r87371 because
FrameSelection::textWillBeReplaced() doesn't set focus anymore.
No new tests. Covered by fast/forms/input-number-blur-twice.html.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Revert r87371.

  • dom/Node.cpp: ditto.
  • dom/Node.h: ditto.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::handleBlurEvent): ditto.

  • html/HTMLInputElement.h: ditto.
  • html/InputType.cpp:

(WebCore::InputType::handleBlurEvent): ditto.

  • html/InputType.h: ditto.
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleBlurEvent): ditto.

  • html/NumberInputType.h: ditto.
11:06 PM Changeset in webkit [96678] by tkent@chromium.org
  • 34 edits in trunk

Introduce feature flags for incomplete input types
​https://bugs.webkit.org/show_bug.cgi?id=68971

Reviewed by Hajime Morita.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
  • html/DateInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATE)
  • html/DateInputType.h: ditto.
  • html/DateTimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIME)
  • html/DateTimeInputType.h: ditto.
  • html/DateTimeLocalInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIMELOCAL)
  • html/DateTimeLocalInputType.h: ditto.
  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

Recognizes type attribute value only if it is enabled by ENABLE(INPUT_TYPE_*).

  • html/MonthInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_MONTH)
  • html/MonthInputType.h: ditto.
  • html/TimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_TIME)
  • html/TimeInputType.h: ditto.
  • html/WeekInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_WEEK)
  • html/WeekInputType.h: ditto.

Source/WebKit/chromium:

  • features.gypi: Add disabled ENABLE_INPUT_TYPE_* flags.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Tools:

  • Scripts/build-webkit:

Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
They are disabled by default.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

Add ENABLE_INPUT_TYPE_* flags. They are disabled by default.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto.

LayoutTests:

Skip fast/forms/{date,datetime,datetimelocal,month,time,week}.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:02 PM Changeset in webkit [96677] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use an explicit cast when shortening.

9:56 PM Changeset in webkit [96676] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Only set when the custom encoding is different from existing value
​https://bugs.webkit.org/show_bug.cgi?id=69061

Reviewed by Hajime Morita.

Only set the custom encoding value if it is different from the current value, to avoid
reloading the page.

  • ewk/ewk_view.cpp:

(ewk_view_setting_encoding_custom_set):

9:45 PM Changeset in webkit [96675] by hyatt@apple.com
  • 25 edits
    9 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=69398

Source/WebCore:

[CSS3 Regions] Support the region-overflow property properly.

(1) Change -webkit-break to break, since the -webkit-region-overflow property already has the
-webkit- extension.

(2) Fix clipping so that it works when overflow is set or when region break is set.

(3) Refactor all the pagination spots to check if a next page is available using the new hasNextPage
function. This prevents us from paginating if we hit the last region and further breaks are no longer
allowed.

Reviewed by Dan Bernstein.

Added new tests in fast/regions.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionOverflow):

  • css/CSSValueKeywords.in:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOverflowRect):

LayoutTests:

[CSS3 Regions] Support the region-overflow property properly.

Reviewed by Dan Bernstein.

  • fast/regions/region-overflow-auto-overflow-hidden.html: Added.
  • fast/regions/region-overflow-auto-overflow-visible.html: Added.
  • fast/regions/region-overflow-break.html: Added.
  • fast/regions/script-tests/webkit-region-overflow-parsing.js:
  • fast/regions/webkit-region-overflow-parsing-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-break-expected.png: Added.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt:
7:47 PM Changeset in webkit [96674] by mhahnenberg@apple.com
  • 13 edits in trunk/Source

Add static ClassInfo structs to classes that override JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=69311

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
Also added new createStructure methods to those classes that didn't have
them so that the new ClassInfo structs would be used when creating the Structures
in these classes.

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:

(JSC::BooleanConstructor::createStructure):

getCallData was not marked as static in StrictModeTypeErrorFunction.

  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:

(JSC::ErrorConstructor::createStructure):

  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:

(JSC::FunctionConstructor::createStructure):

  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

Source/WebCore:

No new tests.

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
Also added new createStructure methods to those classes that didn't have
them so that the new ClassInfo structs would be used when creating the Structures
in these classes.

  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
7:38 PM Changeset in webkit [96673] by ggaren@apple.com
  • 31 edits in trunk/Source

Some JSValue cleanup
​https://bugs.webkit.org/show_bug.cgi?id=69320

../JavaScriptCore:

Reviewed by Darin Adler.

No measurable performance change.

Removed some JSValue::get* functions. get* used to be an optimization
when every value operation was a virtual function call: get* would combine
two virtual calls into one. Now, with non-virtual, inlined functions, get*
isn't faster, and may be slightly slower.

Merged getBoolean(bool&) and getBoolean() into asBoolean().

Merged uncheckedGetNumber(), getJSNumber() and getNumber() into
asNumber().

  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::JSValue::asNumber):
(JSC::JSValue::asBoolean): As promised!

  • runtime/NumberPrototype.cpp:

(JSC::toThisNumber):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf): Removed a bunch of uses of getJSNumber()
by switching to toThisNumber().

  • API/JSCallbackObjectFunctions.h:

(JSC::::toNumber):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/DateInstance.h:

(JSC::DateInstance::internalNumber):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • runtime/JSArray.cpp:

(JSC::compareNumbersForQSort): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().

  • runtime/JSCell.cpp:
  • runtime/JSCell.h: Nixed getJSNumber().
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/NumberObject.cpp:
  • runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

  • runtime/Operations.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().

../WebCore:

Reviewed by Darin Adler.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::valueToDate):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSQLTransactionSyncCustom.cpp:

(WebCore::JSSQLTransactionSync::executeSql):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • bridge/jni/jsc/JNIUtilityPrivate.cpp:

(JSC::Bindings::convertValueToJValue): Updated for JSC changes.

../WebKit/mac:

Reviewed by Darin Adler.

  • WebView/WebView.mm:

(aeDescFromJSValue): Updated for JSC changes.

6:32 PM Changeset in webkit [96672] by commit-queue@webkit.org
  • 4 edits in trunk

Fix FrameView::scrollElementToRect to take already scrolled amount into consideration.
​https://bugs.webkit.org/show_bug.cgi?id=69220

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-10-04
Reviewed by Simon Fraser.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):

LayoutTests:

  • fast/dom/scroll-element-to-rect.html:
6:32 PM Changeset in webkit [96671] by tkent@chromium.org
  • 3 edits in branches/chromium/874

Merge 96290 - REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 231
​https://bugs.webkit.org/show_bug.cgi?id=68981

Reviewed by Darin Adler.

Source/WebCore:

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().

LayoutTests:

  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/forms/input-text-paste-maxlength.html:

TBR=​tkent@chromium.org
BUG=crbug.com/98117
Review URL: ​http://codereview.chromium.org/8135023

6:14 PM Changeset in webkit [96670] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Ignore the warning about using 'override'.

  • WebCore.vcproj/WebCore.vcproj:
6:12 PM Changeset in webkit [96669] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Stub out WorkerScriptController::disableEval for v8 to fix the build.

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

  • bindings/v8/WorkerScriptController.h:
6:10 PM Changeset in webkit [96668] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

OVERRIDE seems to not be working for Windows. Remove it for now.

  • dom/Document.h:
  • workers/WorkerContext.h:
5:52 PM Changeset in webkit [96667] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Wean ContentSecurityPolicy from the Document
​https://bugs.webkit.org/show_bug.cgi?id=69387

Reviewed by Adam Barth.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

  • bindings/js/WorkerScriptController.h:
  • dom/Document.cpp:

(WebCore::Document::disableEval):

  • dom/Document.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::disableEval):

  • workers/WorkerContext.h:
  • dom/ScriptExecutionContext.h:

Add pure virtual disableEval to ScriptExecutionContext, so that ContentSecurityPolicy
can call it for both Documents and WorkerContexts.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):
Call the new ScriptExecutionContext::disableEval() function.

(WebCore::ContentSecurityPolicy::reportViolation):
Use ScriptExecutionContext::addMessage() instead of going directly to the DOMWindow.

5:52 PM Changeset in webkit [96666] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic doesn't launch it's UI on Lion
​https://bugs.webkit.org/show_bug.cgi?id=69349

Reviewed by Darin Adler.

It turns out that Lion is a bit more picky about file URLs. This patch
switches us from using a path to using an actual file URL, silencing
the warning and making the tool actually launch on Lion.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
5:12 PM Changeset in webkit [96665] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update test expectations after ​http://trac.webkit.org/changeset/96449
​https://bugs.webkit.org/show_bug.cgi?id=69316

Patch by David Barr <​davidbarr@chromium.org> on 2011-10-04
Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [96664] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix Perl undefined variable warning when using run-safari after
<​http://trac.webkit.org/changeset/96448> (​https://bugs.webkit.org/show_bug.cgi?id=68662)

Rubber-stamped by Alexey Proskuryakov.

  • Scripts/webkitdirs.pm:

(runMacWebKitApp): Check that the optional function argument $useOpenCommand
is defined before using it in a comparison operation.

4:48 PM Changeset in webkit [96663] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move code into ScrollElasticityController::beginScrollGesture()
​https://bugs.webkit.org/show_bug.cgi?id=69383

Reviewed by John Sullivan.

  • platform/mac/ScrollAnimatorMac.h:

Add new ScrollElasticityControllerClient member functions.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMinimumPosition):
(WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMaximumPosition):
(WebCore::ScrollAnimatorMac::stretchAmount):
(WebCore::ScrollAnimatorMac::startSnapRubberbandTimer):
(WebCore::ScrollAnimatorMac::stopSnapRubberbandTimer):
Implement the new ScrollElasticityControllerClient member functions.

(WebCore::ScrollAnimatorMac::beginScrollGesture):
Move code into ScrollElasticityController::beginScrollGesture and call it directly.

  • platform/mac/ScrollElasticityController.h:

Add new ScrollElasticityControllerClient member functions.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::reboundDeltaForElasticDelta):
(WebCore::ScrollElasticityController::beginScrollGesture):
Set up the scroll gesture state.

(WebCore::ScrollElasticityController::stopSnapRubberbandTimer):
New helper function.

4:34 PM Changeset in webkit [96662] by commit-queue@webkit.org
  • 19 edits in trunk

Add GAMEPAD feature flag
​https://bugs.webkit.org/show_bug.cgi?id=66859

Patch by Scott Graham <​scottmg@chromium.org> on 2011-10-04
Reviewed by Darin Fisher.

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, as no new functionality yet.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
4:02 PM Changeset in webkit [96661] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

JITCodeGenerator should no longer have code that tries too hard
to be both speculative and non-speculative
​https://bugs.webkit.org/show_bug.cgi?id=69321

Reviewed by Gavin Barraclough.

Removed m_isSpeculative and speculationCheck() from JITCodeGenerator.
This required moving emitBranch() to SpeculativeJIT, since it was
the main user of that field and method. Other than trvial clean-ups
in emitBranch(), the code is unchanged (and still has some disparity
between 64 and 32_64, and still lacks some obvious optimizations).

  • dfg/DFGJITCodeGenerator.cpp:
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

4:01 PM Changeset in webkit [96660] by tony@chromium.org
  • 5 edits
    3 moves in trunk/Source

[Chromium] Moved files towards GTK removal
​https://bugs.webkit.org/show_bug.cgi?id=69229

Patch by Fady Samuel <​fsamuel@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.cpp.

(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

  • platform/chromium/PlatformThemeChromiumLinux.h: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.h.

(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):

  • src/linux/WebFontInfo.cpp: Renamed from Source/WebKit/chromium/src/gtk/WebFontInfo.cpp.

(WebKit::WebFontInfo::familyForChars):
(WebKit::WebFontInfo::renderStyleForStrike):

3:57 PM Changeset in webkit [96659] by commit-queue@webkit.org
  • 57 edits
    4 adds in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 7
​https://bugs.webkit.org/show_bug.cgi?id=69135

Patch by Ben Wells <​benwells@chromium.org> on 2011-10-04
Reviewed by James Robinson.

  • platform/chromium-linux/fast/: 26 changes.
  • platform/chromium-linux/svg/custom/no-inherited-dashed-stroke-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-win/fast/: 27 changes.
  • platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium/test_expectations.txt:
3:56 PM Changeset in webkit [96658] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
​https://bugs.webkit.org/show_bug.cgi?id=69374

Unreviewed.

Per ​https://bugs.webkit.org/show_bug.cgi?id=69374#c7
updating the chunksize to be a bit smaller now that the total
size of the html5 spec is smaller than when I wrote the test.

This should increase the prevalence of style resolution in the
sample time, which more closely matches instrument samples
taken when loading the full page in Safari.

  • Parser/html5-full-render.html:
3:48 PM Changeset in webkit [96657] by commit-queue@webkit.org
  • 4 edits in trunk

Fix position check for double tap gesture detection. A double tap
should not be detected if the two taps are far from each other.
​https://bugs.webkit.org/show_bug.cgi?id=69270

Patch by Varun Jain <​varunjain@chromium.org> on 2011-10-04
Reviewed by Darin Fisher.

Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::GestureRecognizerChromium::isSecondClickInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::click):

  • platform/chromium/GestureRecognizerChromium.h:
3:45 PM Changeset in webkit [96656] by adachan@apple.com
  • 2 edits in trunk/Source/WebKit2

toURLRef() in WKSharedAPICast.h should return null for a null string
​https://bugs.webkit.org/show_bug.cgi?id=69380

Reviewed by Jon Honeycutt.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toURLRef): Add the missing "return" for the null string case.

3:38 PM Changeset in webkit [96655] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk/Source

[chromium] Extract scheduling logic from CCThreadProxy to its own class
​https://bugs.webkit.org/show_bug.cgi?id=69049

Patch by James Robinson <​jamesr@chromium.org> on 2011-10-04
Reviewed by Kenneth Russell.

Source/WebCore:

This partially extracts the commit/draw scheduling from CCThreadProxy to a separate isolated class. This makes
the commit/draw logic easier to test, understand and extend.

There is one subtle behavior change here to the way that the function formerly known as
CCLayerTreeHost::setNeedsCommitAndRedraw works. Previously, this would trigger a begin frame message, if one
wasn't pending, and then trigger a redraw if one wasn't pending. This was subtly wrong - the intent of that call
is that a redraw should happen after the commit. It isn't useful to draw before the commit occurs. This patch
changes the name of the function to setNeedsCommitThenRedraw and only requests a redraw after a commit occurs.

Covered by new CCSchedulerTest unit tests, CCLayerTreeHostTest unit tests, and compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScheduler.cpp: Added.

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::requestCommit):
(WebCore::CCScheduler::requestCommitThenRedraw):
(WebCore::CCScheduler::requestRedraw):
(WebCore::CCScheduler::didCommit):
(WebCore::CCScheduler::didDraw):

  • platform/graphics/chromium/cc/CCScheduler.h: Added.

(WebCore::CCSchedulerClient::~CCSchedulerClient):
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
(WebCore::CCScheduler::redrawAfterCommit):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxySchedulerClient::create):
(WebCore::CCThreadProxySchedulerClient::~CCThreadProxySchedulerClient):
(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxySchedulerClient::scheduleDrawAndPresent):
(WebCore::CCThreadProxySchedulerClient::CCThreadProxySchedulerClient):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCThreadProxy::setNeedsCommitThenRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Adds some unit tests for the new CCScheduler class. Since the class is very simple today, the tests are
similarly quite simple.

  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::postSetNeedsCommitThenRedrawToMainThread):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommitThenRedraw):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):

  • tests/CCSchedulerTest.cpp: Added.
3:30 PM Changeset in webkit [96654] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

occasional crash in Chromium in dispatching keyEvent
​https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <​scottmg@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebKit/chromium:

Guard Frame while handling keyEvent, as it can lose last reference due
to actions of handler.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

LayoutTests:

  • fast/events/keyevent-iframe-removed-crash-expected.txt: Added.
  • fast/events/keyevent-iframe-removed-crash.html: Added.
3:28 PM Changeset in webkit [96653] by ap@apple.com
  • 12 edits
    3 adds in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=67774
PDF in a frameset is not displayed, always downloads

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PDF: Added. Added BuiltInPDFView class. It implements ScrollableArea and Plugin, working with iframes, objects and embeds. The implementation targets Mac port only, fixing a WebKit2 regression.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): Tell WebCore that there is a plug-in for PDF, so that it instantiates it in a regular fashion.
  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::canShowMIMEType): We can now show PDF not only in main frame.
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Added. This is largely an implementation of ScrollableArea now, which can render the first page of a PDF. Further improvements to come.
  • WebProcess/Plugins/PDF/BuiltInPDFView.h: Added.
  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::updateControlTints): Give Plugin a chance to invalidate its tintable controls - it's necessary for PDF because scrollbars are tintable.
  • WebProcess/Plugins/Plugin.h: (WebKit::Plugin::controller): Added a const version, since some ScrollableArea methods are const.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Call updateControlTints at updatingControlTints phase.
  • WebProcess/Plugins/PluginView.h: PDF plug-in needs to tinker with embedding FrameView to use Scrollbar class, so it needs to cast its PluginController up to PluginView. It's unfortunate that PluginView has so much NPAPI specific code, but that's how it is now.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): If there is no real plug-in installed for PDF, instantiate built-in one.
3:14 PM Changeset in webkit [96652] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

ScrollElasticityController should keep track of the rubberband timer state
​https://bugs.webkit.org/show_bug.cgi?id=69381

Reviewed by Sam Weinig.

Add a m_snapRubberbandTimerIsActive member variable to ScrollElasticityController
and use it instead of checking whether the m_snapRubberbandTimer is active.

Eventually, ScrollElasticityControllerClient will have two member functions for starting
and stopping the timer, and the ScrollElasticityController will call them at the appropriate times.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
It's OK to stop the timer unconditionally.

(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::ScrollElasticityController):

2:58 PM Changeset in webkit [96651] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move all rubber-banding related member variables to ScrollElasticityController
​https://bugs.webkit.org/show_bug.cgi?id=69379

Reviewed by Dan Bernstein.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::ScrollElasticityController):

2:50 PM Changeset in webkit [96650] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update XP results for the font shaping patch.

  • platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.txt: Added.
2:37 PM Changeset in webkit [96649] by abarth@webkit.org
  • 9 edits in trunk/LayoutTests

Update baselines after ​http://trac.webkit.org/changeset/96620. These
changes match the changes Dave made to other platforms.

  • platform/chromium-cg-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-cg-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
2:34 PM Changeset in webkit [96648] by hyatt@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/wtf/ListHashSet.h

Fix Leopard build bustage.

2:27 PM Changeset in webkit [96647] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
​https://bugs.webkit.org/show_bug.cgi?id=69374

Reviewed by James Robinson.

This should finally be able to provide us with a repeatable metric
for how fast we're currently able to load the HTML5 spec.
There are a variety of interesting functions which show up in this
sample, including of course style resolution.

  • Parser/html5-full-render.html:
2:25 PM Changeset in webkit [96646] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Build fixes for everyone.

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
Fix Chromium build.

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Fix GTK+ build.

2:23 PM Changeset in webkit [96645] by jonlee@apple.com
  • 29 edits
    4 adds in trunk

REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
​https://bugs.webkit.org/show_bug.cgi?id=68412
<rdar://problem/9988252>

Reviewed by Darin Adler.

Source/WebKit2:

In WK1 setInitialFocus() is called on FocusController with the key event that
caused the web view to become first responder. In WK2 no event is sent. So if
the key stroke that caused the change in first responder status contains the
option modifier key, FocusController did not know that it had to switch behavior.

Because there are multiple ways that the WKView can becomeFirstResponder, I changed
the signature to setInitialFocus to express whether the key event parameter is an
actual key event.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewSetInitialFocus):

  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]): Take the NSApp currentEvent and pass it along if
the event is a keyboard event, otherwise pass an empty event.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setInitialFocus): Change in function signature to confirm that
the event that caused the initial focus was a keyboard event, and provide the keyboard
event itself.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setInitialFocus):

  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setInitialFocus): If we know that the cause of this was a keyboard
event, we pass that event to the FocusController. Otherwise we fall back to the original
behavior, which is to pass no event at all.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

In order to create a test for the bug, I had to update DRT and WKTR to create some
widget that allows first responder status to move away from the main web view.

Three methods were added to layoutTestController: addChromeInputField,
removeChromeInputField, and focusWebView. addChromeInputField adds a text field
that is a sibling to the web view, and sets up the key event loop between the two.
removeChromeInputField removes that field. focusWebView moves first responder
status to the web view.

The test makes the call via layoutTestController and passes a callback that it
assumes will be executed once the task is completed. In DRT the callback is called
synchronously. In WKTR this is handled with message passing between the two
processes.

  • DumpRenderTree/LayoutTestController.cpp:

(addChromeInputFieldCallback):
(removeChromeInputFieldCallback):
(focusWebViewCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
make sure to remove the chrome input field.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
through JS.
(WTR::cacheLayoutTestControllerCallback):
(WTR::callLayoutTestControllerCallback):
(WTR::LayoutTestController::addChromeInputField):
(WTR::LayoutTestController::removeChromeInputField):
(WTR::LayoutTestController::focusWebView):
(WTR::LayoutTestController::callAddChromeInputFieldCallback):
(WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
(WTR::LayoutTestController::callFocusWebViewCallback):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do

with the patch-- just cleaning up style.
(LayoutTestController::addDisallowedURL):
(originsArrayToJS):
(LayoutTestController::queueLoad):
(LayoutTestController::setMockDeviceOrientation):
(LayoutTestController::setIconDatabaseEnabled):
(LayoutTestController::setEditingBehavior):

LayoutTests:

The option-key navigation is only relevant to the Mac platform.

  • platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
  • platform/mac/fast/forms/focus-option-control-on-page.html: Added.
  • platform/mac/fast/forms/script-tests/focus-option-control-on-page.js: Added.

(startTest):
(runKeyPresses):
(notifyDone):
(log):

2:18 PM Changeset in webkit [96644] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

Add a ScrollElasticityController class and move some members over from ScrollAnimatorMac
​https://bugs.webkit.org/show_bug.cgi?id=69373

Reviewed by David Hyatt.

ScrollElasticityController is a new class that will handle the rubber-banding when handling scroll events.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h: Added.

(WebCore::ScrollElasticityControllerClient::~ScrollElasticityControllerClient):

  • platform/mac/ScrollElasticityController.mm: Added.

(WebCore::ScrollElasticityController::ScrollElasticityController):

2:16 PM Changeset in webkit [96643] by hyatt@apple.com
  • 17 edits in trunk

Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Add support for reverse iteration to ListHashSet to support being able to walk them
backwards easily.

Reviewed by Anders Carlsson.

  • wtf/ListHashSet.h:

(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):
(WTF::::makeConstIterator):

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Reviewed by Anders Carlsson.

No new tests, since plenty of results changed.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOverflowRect):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Reviewed by Anders Carlsson.

  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png:
  • platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
2:10 PM Changeset in webkit [96642] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
​https://bugs.webkit.org/show_bug.cgi?id=69361

Reviewed by James Robinson.

No new tests. This changes no JavaScript API.

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::setNumberOfChannels):

1:56 PM Changeset in webkit [96641] by gavinp@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

fix gtk breakage caused by changeset 96595
​https://bugs.webkit.org/show_bug.cgi?id=69371

ews did not catch build breakage in the gtk WebKitPluginProcess target; this patch removes
the pretty printer on gtk, which should fix the build on that platform.

Reviewed by NOBODY, this is a build fix.

  • wtf/Assertions.cpp:
1:53 PM Changeset in webkit [96640] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

Update our copy of the HTML5 spec used for performance testing to match the latest version
​https://bugs.webkit.org/show_bug.cgi?id=69364

Unreviewed. The patch is too large to post, so landing this unreviewed. :(

The copy of the html5 spec we were using for testing was over a year old
and didn't have any of the subresources with it (we were only using it
as an HTML parsing benchmark). I'm about to use it for testing
the full load/render time of the benchmark, so I've updated to the latest
version of the spec (now 8mb instead of 5mb) and inlined two of the
CSS files. (Inlining the CSS was necessary to make my testing consistent
as there seems to be a race with some timer fired after CSS load.)

Increasing from 5mb to 8mb showed a similar 30% slowdown in our parser
benchmarks as expected.

  • Parser/resources/html5.html:
1:44 PM Changeset in webkit [96639] by andersca@apple.com
  • 12 edits in trunk/Source/WebCore

Use const PlatformWheelEvent references where possible
​https://bugs.webkit.org/show_bug.cgi?id=69367

Reviewed by Sam Weinig.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):

  • platform/ScrollableArea.h:
  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

1:39 PM Changeset in webkit [96638] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink HTMLTableCellElement.
​https://bugs.webkit.org/show_bug.cgi?id=69347

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Don't cache the rowspan and colspan attributes on the element.
This shrinks HTMLTableCellElement by one CPU word, reducing memory
consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::parseMappedAttribute):

  • html/HTMLTableCellElement.h:
1:37 PM Changeset in webkit [96637] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Unreviewed, rolling out r96630.
​http://trac.webkit.org/changeset/96630
​https://bugs.webkit.org/show_bug.cgi?id=69368

Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-04

Source/JavaScriptCore:

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
1:24 PM Changeset in webkit [96636] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected results.

  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
1:20 PM Changeset in webkit [96635] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Enable sub pixel text (Skia on Mac)
​https://bugs.webkit.org/show_bug.cgi?id=69354
​http://code.google.com/p/chromium/issues/detail?id=98165

Reviewed by Eric Seidel.

No new tests. Layout test pixel results have been
disabled and will be rebaselined once all Skia on Mac
changes are in.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
Enable sub pixel text. This is set by default to enabled
by CoreGraphics, but by default disabled on Skia.

1:16 PM Changeset in webkit [96634] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

Add loopsPerRun option to Parser performance test runner
​https://bugs.webkit.org/show_bug.cgi?id=69363

Reviewed by Antti Koivisto.

Add loopsPerRun option and abstract out runLoop function (to make the UI more responsive).
No change in behavior in any of the tests.

  • Parser/resources/runner.js:

(runLoop):
(run):
(start):

1:11 PM Changeset in webkit [96633] by andersca@apple.com
  • 16 edits in trunk/Source

Remove PlatformWheelEvent::m_isAccepted
​https://bugs.webkit.org/show_bug.cgi?id=69357

Reviewed by Darin Adler.

../WebCore:

Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):

  • platform/efl/PlatformWheelEventEfl.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/win/WheelEventWin.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
m_isAccepted has been removed.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::onMouseWheel):
Just return the value of handleWheelEvent.

12:47 PM Changeset in webkit [96632] by cdn@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
​https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

Test: fast/css/counters/counter-after-style-crash.html

  • rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):

LayoutTests: Add test for crash when performing rich text mutations with counter nodes.
​https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

  • fast/css/counters/counter-after-style-crash-expected.txt: Added.
  • fast/css/counters/counter-after-style-crash.html: Added.
12:35 PM Changeset in webkit [96631] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

IndexedDB add() should fail if key is NaN
​https://bugs.webkit.org/show_bug.cgi?id=62286

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/invalid-keys.html

Implement special case - numbers are valid keys, except for NaN.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

LayoutTests:

Tests for NaN and other invalid IndexedDB keys.

  • storage/indexeddb/invalid-keys-expected.txt: Added.
  • storage/indexeddb/invalid-keys.html: Added.
12:22 PM Changeset in webkit [96630] by mhahnenberg@apple.com
  • 13 edits in trunk/Source

Add static ClassInfo structs to classes that override JSCell::getCallData
​https://bugs.webkit.org/show_bug.cgi?id=69311

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:

getCallData was not marked as static is StrictModeTypeErrorFunction.

  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

Source/WebCore:

No new tests.

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
12:17 PM Changeset in webkit [96629] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Leopard build fix after r96613.

  • wtf/Platform.h:
12:12 PM QtWebKitRelease22 edited by ademar@webkit.org
(diff)
12:02 PM Changeset in webkit [96628] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

REGRESSION(r94274): setting input.value erroneously triggers focus event
​https://bugs.webkit.org/show_bug.cgi?id=69315

Reviewed by Kent Tamura.

Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.

Added a manual test. Unfortunately, the test always passes in DRT.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/FrameSelection.h:
  • manual-tests/mutate-unfocused-text-with-selection.html: Added.
12:02 PM Changeset in webkit [96627] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Implicitly add toString and valueOf to prototype when convertToType callback is provided
​https://bugs.webkit.org/show_bug.cgi?id=69156

Reviewed by Geoffrey Garen.

Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

  • API/JSCallbackFunction.h:
  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

  • API/tests/testapi.js:
11:58 AM Changeset in webkit [96626] by commit-queue@webkit.org
  • 7 edits
    6 adds in trunk

HTML canvas strokes with dash and dashOffset
​https://bugs.webkit.org/show_bug.cgi?id=63933

Patch by Young Han Lee <​joybro201@gmail.com> on 2011-10-04
Reviewed by Simon Fraser.

Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
These attributes can be used to determine the dash-style of stroke in HTML Canvas.

As this kind of attributes are not specified in the HTML Canvas specification yet,
the 'webkit' prefix is added to its names.

Mozilla already implemented these attributes, mozDash and mozDashOffset [1], and this patch
is created by referring to the implementation. This patch is basically using the specified
behavior of stroke-dasharray and stroke-dashoffset in the SVG specification [2], except
that doesn't support units or percentages, just floating point numbers.

[1] ​https://bugzilla.mozilla.org/show_bug.cgi?id=662038
[2] ​http://www.w3.org/TR/SVG/painting.html#StrokeProperties

Source/WebCore:

Tests: fast/canvas/canvas-webkitLineDash-invalid.html

fast/canvas/canvas-webkitLineDash.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::webkitLineDash):
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::webkitLineDash):
(WebCore::CanvasRenderingContext2D::setWebkitLineDash):
(WebCore::CanvasRenderingContext2D::webkitLineDashOffset):
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

  • fast/canvas/canvas-webkitLineDash-expected.txt: Added.
  • fast/canvas/canvas-webkitLineDash-invalid-expected.txt: Added.
  • fast/canvas/canvas-webkitLineDash-invalid.html: Added.
  • fast/canvas/canvas-webkitLineDash.html: Added.
  • fast/canvas/script-tests/canvas-webkitLineDash-invalid.js: Added.

(trySettingLineDash):
(trySettingLineDashOffset):

  • fast/canvas/script-tests/canvas-webkitLineDash.js: Added.
  • platform/chromium/test_expectations.txt:
11:56 AM Changeset in webkit [96625] by timothy_horton@apple.com
  • 21 edits
    23 adds in trunk/LayoutTests

Additional unreviewed Lion SVG pixel test rebaselining.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
  • platform/mac-snowleopard/svg/carto.net: Added.
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
  • platform/mac/svg/custom/external-paintserver-reference-expected.png: Added.
  • platform/mac/svg/custom/linking-base-external-reference-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
11:41 AM Changeset in webkit [96624] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

Allow canvas backing store to be lazily allocated
​https://bugs.webkit.org/show_bug.cgi?id=67054

Reviewed by Darin Adler.

No new tests; doesn't affect behavior.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer): Removed the setting of lineWidth
that caused the eager creation of ImageBuffer to use its GraphicsContext.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Added in default
line width setting along with other default context settings.

11:39 AM Changeset in webkit [96623] by Simon Fraser
  • 3 edits in trunk/Tools

Move font-fixup code in WebKitTestRunner to a better place
​https://bugs.webkit.org/show_bug.cgi?id=69356

Reviewed by Sam Weinig.

Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
already contains font-related code.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::activateFonts):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

11:35 AM Changeset in webkit [96622] by timothy_horton@apple.com
  • 73 edits
    84 adds in trunk/LayoutTests

Partial unreviewed rebaselines for Lion SVG pixel tests.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/mac-snowleopard/svg/css: Added.
  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png: Added.
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png: Added.
  • platform/mac-snowleopard/svg/custom: Added.
  • platform/mac-snowleopard/svg/custom/altglyph-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/junk-data-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/missing-xlink-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/mac-snowleopard/svg/dom: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac-snowleopard/svg/hixie: Added.
  • platform/mac-snowleopard/svg/hixie/error: Added.
  • platform/mac-snowleopard/svg/hixie/error/012-expected.png: Added.
  • platform/mac-snowleopard/svg/in-html: Added.
  • platform/mac-snowleopard/svg/in-html/circle-expected.png: Added.
  • platform/mac-snowleopard/svg/overflow: Added.
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/mac-snowleopard/svg/text/kerning-expected.png: Added.
  • platform/mac-snowleopard/svg/text/multichar-glyph-expected.png: Added.
  • platform/mac-snowleopard/svg/wicd: Added.
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom: Added.
  • platform/mac-snowleopard/svg/zoom/page: Added.
  • platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac-snowleopard/svg/zoom/text: Added.
  • platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/custom/altglyph-expected.png:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/in-html/circle-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
11:30 AM Changeset in webkit [96621] by weinig@apple.com
  • 7 edits
    12 adds in trunk

Add support for the CSP connect-src directive
​https://bugs.webkit.org/show_bug.cgi?id=69353

Reviewed by Adam Barth.

Add CSP support for XMLHttpRequest, WebSockets and EventSource.

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html

http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html
http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html
http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowConnectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

Add connect-src directive parsing and predicate.

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
Test allowConnectFromSource when establishing a connection.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html: Added.
11:17 AM Changeset in webkit [96620] by hyatt@apple.com
  • 36 edits
    21 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=69317

[CSS3 Regions] Make overflow:hidden/auto/scroll sections behave properly when split across regions. This
includes sizing and positioning independently in each region, clipping independently in each region, and
shifting to avoid floats in each region.

Reviewed by Anders Carlsson.

Source/WebCore:

Added many new tests in fast/regions.

  • editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea):
Patching a call to overflowClipRect, which now includes a region argument so that clipping can be adjusted
per-region.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Don't clear out the cached region information when the width changes. Instead make a new call to
the flow thread to check if widths changed in any region and set relayoutChildren to true if so.

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
This is a new function that has been split out from determineLogicalLeftPositionForChild so that it can
be called by region code to compute offsets independently in each region without altering the overall object's
logical left position.

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
Patched to call computeStartPositionDeltaForChildAvoidingFloats instead of doing the work of avoiding the floats
itself.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Fix the left clamping code to clamp to the left border in the correct region rather than always just clamping
to 0.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Tweaked to handle the new signature of borderBoxRectInRegion.

(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
Reworked not to return 0 on failure or when done, but to just return the current height. This is a more
fitting answer for the function to return when no more floats remain.

(WebCore::RenderBlock::getClearDelta):
Big changes to this function. It was never patched to support writing modes, so the new code is all
writing-mode-aware now. Also improved the computeLogicalWidth() call to make sure margins didn't get incorrectly changed.
The code computes transient information in each region as the object tries to find a place to fit, so that the
old widths are properly retained when layout of that child later checks to see if it needs to relayout children or not.

(WebCore::RenderBlock::nodeAtPoint):
Patched to call overflowClipRect with the region being hit tested.

(WebCore::inNormalFlow):
Tweaked to not need the initialBlock variable.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
Tweaked to use inRenderFlowThread() now that it exists. Also removing the regionsHaveUniformLogicalWidth()
optimization, since you can't rely on that when objects size differently depending on floats. In other words,
the future of pagination is variable width objects even in printing/columns.

(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
Renamed to make it more clear what logicalPageOffset() was. It's your offset from the top of the first page.

(WebCore::RenderBlock::regionAtBlockOffset):
New helper function for accessing the region at a given offset within your block.

(WebCore::RenderBlock::logicalWidthChangedInRegions):
New helper function that computes whether or not your logical width information changed in any regions. If so,
relayoutChildren gets set to true (just as it would have when computeLogicalWidth for the overall block changes
values).

(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
Tweaked because of const to take const arguments.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalLeftForChild):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::startOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Reworking these functions so versions exist that take regions and page offsets to avoid having to recalculate
where you are over and over again as you walk up a containing block chain.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitBelowFloats):
Changed to handle the better return value for nextFloatLogicalBottomBelow.

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
Removing the uniform logical width optimization.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
Changed to take a region and offset from the first page so that it doesn't have to be recomputed as you recur up
the containing block chain.

(WebCore::RenderBox::clearRenderBoxRegionInfo):
Changed to just use inRenderFlowThread().

(WebCore::RenderBox::pushContentsClip):
Changed for the new region-parameterized overflow clip function.

(WebCore::RenderBox::overflowClipRect):
Now takes a region so that a specific clip rect can be returned sized to the appropriate border box in that
region.

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Objects in flow threads no longer shrink to avoid floats when computing their overall widths. The region-specific
check now does the shrinking. It checks at the point where the region slices the object, or the top of the object if
it begins in the middle of the region.

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Push all the rest of the computeLogicalWidth code into computeLogicalWidthInRegion.

(WebCore::RenderBox::renderBoxRegionInfo):
Changed to take the region and the offset from the top of the first page to avoid recomputation.

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasVisualOverflow):
New helper used by the RenderLayer code to avoid having to check visual overflow when none exists.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the new region-specific overflow clip.

  • rendering/RenderBoxRegionInfo.h:

(WebCore::RenderBoxRegionInfo::shiftLogicalLeft):
Helper used by the region code to shift a box over when floats cause it to move.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalWidth):
Remove the optimization to avoid creating box info for uniform widths.

(WebCore::RenderFlowThread::paintIntoRegion):
Make the clip rects used when painting the flow thread's layer tree temporary in each region.

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Removing the uniform logical width optimization

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):

  • rendering/RenderFlowThread.h:

New helper called to see if a block needs to relayout its children because its width changed in some
region.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
(WebCore::RenderLayer::repaintBlockSelectionGaps):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):
Changing all the layer clipping code to pass regions through to all of the helper functions involved. This is
so overflowClipRect can ultimately take a region. Eventually when we get positioned objects moving independently
in each region, we'll patch the "clip" property as well, and it will be much easier because all the plumbing has
been put in place here for overflow.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderFlowThread):
Optimized to not walk up the render tree if we're in layout and a currentRenderFlowThread() exists.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
Removing the optimization for uniform logical width regions. Changed remove to take so that the caller
can examine it before deleting.

(WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):

  • rendering/RenderRegion.h:

Helper function that computes the region's offset from the top of the first page.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):
Changed to pass the region to overflowClipRect.

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Modified because the layer clip functions need regions now.

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):
Changed to use inRenderFlowThread over view()->hasRenderFlowThread.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paint):
Patched to use the new overflowClipRect that is region-specific.

LayoutTests:

  • fast/regions/floats-basic-in-variable-width-regions.html: Added.
  • fast/regions/overflow-in-uniform-regions-dynamic.html: Added.
  • fast/regions/overflow-in-uniform-regions.html: Added.
  • fast/regions/overflow-in-variable-width-regions.html:
  • fast/regions/overflow-moving-below-floats-in-variable-width-regions.html: Added.
  • fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html: Added.
  • fast/regions/overflow-rtl-in-variable-width-regions.html:
  • fast/regions/overflow-size-change-in-variable-width-regions.html: Added.
  • fast/regions/overflow-size-change-with-stacking-context.html: Added.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png:
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
11:15 AM Changeset in webkit [96619] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

WKPreferences should allow control of application chrome mode
​https://bugs.webkit.org/show_bug.cgi?id=69344

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Set application chrome mode setting.

11:15 AM Changeset in webkit [96618] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

[EFL] DRT: Add DumpRenderTree.cpp
​https://bugs.webkit.org/show_bug.cgi?id=62034

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-04
Reviewed by Antonio Gomes.

This is the main implementation file for EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTree.cpp: Added.

(dumpFramesAsText):
(dumpFrameScrollPosition):
(shouldLogFrameLoadDelegates):
(shouldDumpAsText):
(sendPixelResultsEOF):
(invalidateAnyPreviousWaitToDumpWatchdog):
(onEcoreEvasResize):
(onCloseWindow):
(useLongRunningServerMode):
(parseCommandLineOptions):
(getFinalTestURL):
(getExpectedPixelHash):
(createLayoutTestController):
(runTest):
(runTestingServerLoop):
(adjustOutputTypeByMimeType):
(dumpFrameContentsAsText):
(shouldDumpFrameScrollPosition):
(shouldDumpPixelsAndCompareWithExpected):
(shouldDumpBackForwardList):
(initEfl):
(shutdownEfl):
(displayWebView):
(dump):
(initEcoreEvas):
(main):

11:15 AM Changeset in webkit [96617] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

More work towards making PlatformWheelEvent immutable
​https://bugs.webkit.org/show_bug.cgi?id=69348

Reviewed by Sam Weinig.

More work on getting rid of m_isAccepted from PlatformWheelEvent. Add more asserts
that the return value of handleWheelEvent is equal to m_isAccepted.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

11:14 AM Changeset in webkit [96616] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Implement default error pages in WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=69255

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitError.cpp:

(webkit_policy_error_quark): Add quark for policy errors.
(webkit_plugin_error_quark): Add quark for plugin errors.

  • UIProcess/API/gtk/WebKitError.h: Add policy and plugin errors.
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientLoadFailed): Load a custom error page when
load failed and signal has not been handled.
(webkit_web_loader_client_class_init): Add default implementation
for provisional_load_failed and load_failed virtual methods.

11:12 AM Changeset in webkit [96615] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

Inset focus ring (Skia on Mac)
​https://bugs.webkit.org/show_bug.cgi?id=69166
​http://code.google.com/p/chromium/issues/detail?id=97956

This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.

Reviewed by Adam Barth.

No new tests. This platform is not enabled.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

11:11 AM Changeset in webkit [96614] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=69254

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_alternate_html):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/testloading.c:

(loadAlternateContentLoadFinished):
(loadAlternateContentLoadFailed):
(testLoadAlternateContent):
(main):

11:06 AM Changeset in webkit [96613] by jonlee@apple.com
  • 21 edits
    2 adds in trunk

Extend DOM WheelEvent to differentiate between physical and logical scroll directions
​https://bugs.webkit.org/show_bug.cgi?id=68959
<rdar://problem/10036688>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/Platform.h: Added HAVE_INVERTED_WHEEL_EVENTS for Lion and later.

Source/WebCore:

Test: fast/events/wheelevent-direction-inverted-from-device.html

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):

  • dom/WheelEvent.h:

(WebCore::WheelEvent::create):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):

  • dom/WheelEvent.idl: Added the webkitDirectionInvertedFromDevice idl attribute.
  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::webkitDirectionInvertedFromDevice):

  • platform/efl/PlatformWheelEventEfl.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): if building on Lion or later, use
[NSEvent isDirectionInvertedFromDevice].

  • platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

  • platform/win/WheelEventWin.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

Source/WebKit2:

  • Shared/WebEvent.h:

(WebKit::WebWheelEvent::directionInvertedFromDevice):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent): get the flag from the NSEvent.

  • UIProcess/WebPageProxy.cpp:

(WebKit::coalesce):

LayoutTests:

  • fast/events/wheelevent-direction-inverted-from-device-expected.txt: Added.
  • fast/events/wheelevent-direction-inverted-from-device.html: Added.
  • platform/mac-wk2/Skipped: WKTR does not support mouse scroll events yet.
11:04 AM Changeset in webkit [96612] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
​https://bugs.webkit.org/show_bug.cgi?id=69338

Unreviewed build fix

Patch by Rémi Duraffort <​remi.duraffort@st.com> on 2011-10-04

Source/WebCore:

  • CMakeListsEfl.txt:

Source/WebKit/efl:

  • CMakeListsEfl.txt:
11:02 AM Changeset in webkit [96611] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
​https://bugs.webkit.org/show_bug.cgi?id=69325

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-10-04
Reviewed by Gustavo Noronha Silva.

Documentation generation for WebKit2-GTK+ APIs
using gtk-doc.

.:

  • configure.ac:

Source/WebKit2:

  • GNUmakefile.am: Added doc generation files to EXTRA_DIST.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Makefile for doc generation.
  • UIProcess/API/gtk/docs/version.xml.in: Version information.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Document template.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Document sections added.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Added GObjects types.
11:00 AM Changeset in webkit [96610] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Resource loader should block HTTP redirects to local resources
​https://bugs.webkit.org/show_bug.cgi?id=68706

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-10-03
Reviewed by Adam Barth.

Source/WebCore:

Modified MainResourceLoader to add an extra security check on
HTTP redirects. Also, moved isFeedWithNestedProtocolInHTTPFamily
to SecurityOrigin.cpp.

  • loader/FrameLoader.cpp:

(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::FrameLoader::loadFrameRequest):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):

  • page/SecurityOrigin.cpp:

(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::canDisplay):

LayoutTests:

Adding a test to attempt an HTTP redirect to a file: URL.

  • http/tests/security/redirect-BLOCKED-to-localURL.html: Added.
  • http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
  • http/tests/security/resources/file-redirect-target.html: Added.
10:49 AM Changeset in webkit [96609] by caryclark@google.com
  • 3 edits in trunk/Source/WebCore

Apply color profile found to decoded bitmap (Skia on Mac)
​https://bugs.webkit.org/show_bug.cgi?id=69144
This fixes ​http://code.google.com/p/chromium/issues/detail?id=97830

Reviewed by Stephen White.

No new tests. This platform is not enabled.

  • platform/image-decoders/ImageDecoder.h:

Add color profile slot to Skia variation.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):
Adjust the bitmap in place to use the supplied color space.

(WebCore::createColorSpace):
Create a CGColorSpace from a color profile.

(WebCore::ImageFrame::setColorProfile):
Save the image's color profile until the image is complete.

(WebCore::ImageFrame::setStatus):
Apply the color profile, if any, to the image.

10:47 AM Changeset in webkit [96608] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Restore Linux baseline for this test. The Linux baseline got clobbered
when I updated the Windows baseline.

  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.txt: Added.
10:44 AM Changeset in webkit [96607] by leandro@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.

The Perl scripts in the css/ directory expect the definitions passed via
--defines to be a string of space-separated entries, however we were passing a
list of semicolon-separated strings, thus making all feature defines actually
be ignored.

Detected after r96433, which checked for some definitions in
CSSPropertyNames.in.

No new tests, this is a build fix.

  • CMakeLists.txt:
10:39 AM Changeset in webkit [96606] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
​https://bugs.webkit.org/show_bug.cgi?id=69329

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-10-04
Reviewed by Martin Robinson.

Added documentation for WebKitNetworkError enum and corrected few other
minor issues in WebKit2-GTK+ API documentation.

  • UIProcess/API/gtk/WebKitError.h: Added documentation for WebKitNetworkError.
  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkit_web_loader_client_class_init): Corrected parameter name.

  • UIProcess/API/gtk/WebKitWebView.cpp: Corrected annotation.
10:22 AM Changeset in webkit [96605] by mario@webkit.org
  • 25 edits in trunk/LayoutTests

2011-10-04 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed; rebaselines for GTK after r96509.

  • platform/gtk/fast/forms/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/invalid/017-expected.txt:
  • platform/gtk/fast/invalid/018-expected.txt:
  • platform/gtk/fast/invalid/020-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.png:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/gtk/fast/table/inline-form-assert-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug56405-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug56563-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
10:19 AM Changeset in webkit [96604] by pfeldman@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: make SourceFrame compile.
​https://bugs.webkit.org/show_bug.cgi?id=69345

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.inspectElement):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._inspectElementRequested):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrameDelegate.prototype.requestContent):
(WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.continueToLine):
(WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegate.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):

  • inspector/front-end/externs.js:

(WebInspector.log):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

  • inspector/front-end/utilities.js:

():

9:59 AM Changeset in webkit [96603] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-10-04 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed; new baselines for GTK after r96470

  • platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
9:56 AM QtWebKitRelease22 edited by ademar@webkit.org
(diff)
9:55 AM QtWebKitRelease22 edited by ademar@webkit.org
(diff)
9:53 AM Changeset in webkit [96602] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update font shaping result after ​http://trac.webkit.org/changeset/96582.
This appears to be a progression, but I'll check with the authors of
that patch to be sure.

  • platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
9:48 AM Changeset in webkit [96601] by abarth@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Update leopard results.

  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug23994-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-object: Removed.
  • platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
  • platform/chromium-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Removed.
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
9:32 AM Changeset in webkit [96600] by mario@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-10-04 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed; new baselines for GTK after r96257, r96374 and r96404.

  • platform/gtk/fast/repaint/selection-clear-expected.png: Added.
  • platform/gtk/fast/repaint/selection-clear-expected.txt: Added.
  • platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
  • platform/gtk/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/gtk/fast/text/line-initial-and-final-swashes-expected.txt: Added.
9:17 AM Changeset in webkit [96599] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: Factor out object properties popup.
​https://bugs.webkit.org/show_bug.cgi?id=69234

Also, for HTML elements, show a non-empty id value in the element name.

Reviewed by Pavel Feldman.

9:16 AM Changeset in webkit [96598] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

MinGW warning fix after r96286.

Avoid redefining STDCALL, because STDCALL is also defined in mingw32/include/windef.h:

Reviewed by Tor Arne Vestbø.

  • assembler/MacroAssemblerCodeRef.h:
9:11 AM Changeset in webkit [96597] by pfeldman@chromium.org
  • 17 edits in trunk/Source/WebCore

Web Inspector: compile text editor.
​https://bugs.webkit.org/show_bug.cgi?id=69339

Drive-by compilation for color, database and dom storage entities.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Color.js:

(WebInspector.Color.prototype._individualRGBValueToFloatValue):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.makeKey):
(WebInspector.KeyboardShortcut.makeKeyFromEvent):
(WebInspector.KeyboardShortcut.makeDescriptor):

  • inspector/front-end/SourceCSSTokenizer.js:
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js:
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceTokenizer.js:

(WebInspector.SourceTokenizer.prototype._charAt):
(WebInspector.SourceTokenizer.prototype.createInitialCondition):
(WebInspector.SourceTokenizer.prototype.nextToken):

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):

  • inspector/front-end/TextEditorModel.js:
  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewerDelegate.prototype.doubleClick):
(WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegate.prototype.afterTextChanged):
(WebInspector.TextViewerDelegate.prototype.commitEditing):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegate.prototype.suggestedFileName):
(WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._createLink):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

  • inspector/front-end/externs.js:

(WebInspector.completeURL):
(window.getComputedStyle):
(Event.prototype.initWebKitWheelEvent):

  • inspector/front-end/utilities.js:
8:49 AM Changeset in webkit [96596] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Timeline panel shortcut for filtering short records should have shorter description.
​https://bugs.webkit.org/show_bug.cgi?id=69333

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

8:39 AM Changeset in webkit [96595] by gavinp@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

add more stack dumping methods
​https://bugs.webkit.org/show_bug.cgi?id=69018

In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
WebKit programmatically retrieve the current stack. This is useful if you need to add more
reporting to field crash report uploads, if you're tracking down an irreproducable bug,
for instance.

Reviewed by Darin Adler.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
8:34 AM QtWebKitBuildBots edited by Csaba Osztrogonác
typo fix (diff)
8:30 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Add Qt SL bot (diff)
8:27 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Reorder the bots (diff)
8:26 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Remove QtWebKit 2.0 and 2.1 bots (diff)
8:25 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Remove NRWT and V8 bots (diff)
8:24 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt on 4.8.x trunk bot (diff)
8:13 AM Changeset in webkit [96594] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink StyleRareNonInheritedData.
​https://bugs.webkit.org/show_bug.cgi?id=69331

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Rearrange the members and move all small types into the bitfield.
This shrinks StyleRareNonInheritedData by two CPU words, reducing memory
consumption by 140 kB (on 64-bit) when loading the full HTML5 spec.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleRareNonInheritedData.h:
8:02 AM Changeset in webkit [96593] by vsevik@chromium.org
  • 16 edits
    2 deletes in trunk

Web Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
​https://bugs.webkit.org/show_bug.cgi?id=69332

Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • http/tests/inspector/network/disabled-cache-crash-expected.txt: Removed.
  • http/tests/inspector/network/disabled-cache-crash.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
7:45 AM Changeset in webkit [96592] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

allow failure of most Chromium-Mac-Skia tests while we clean up that port
​https://bugs.webkit.org/show_bug.cgi?id=69279

Patch by Elliot Poger <​epoger@google.com> on 2011-10-04
Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
7:23 AM Changeset in webkit [96591] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: make DataGrid compile
​https://bugs.webkit.org/show_bug.cgi?id=69334

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-10-04
Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype._startEditingConfig):
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeChildrenRecursive):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
(WebInspector.DataGridNode.prototype._attach):

  • inspector/front-end/UIUtils.js:

(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.EditingConfig):
(WebInspector.startEditing.blurEventListener):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):

  • inspector/front-end/externs.js:

(Array.prototype.remove):
(window.getComputedStyle):

  • inspector/front-end/inspector.js:
7:12 AM Changeset in webkit [96590] by yurys@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: save inspector state into single string instead of string map
​https://bugs.webkit.org/show_bug.cgi?id=69335

Added explicit methods for saving and restoring agent runtime state.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:

(WebKit::WebDevToolsAgentClient::saveAgentRuntimeState):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):

  • src/WebDevToolsAgentImpl.h:
7:09 AM Changeset in webkit [96589] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-04 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: [Extensions API] extension panel's toolbar icon is incorrect when inspector window is docked
​https://bugs.webkit.org/show_bug.cgi?id=69336

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
6:24 AM Changeset in webkit [96588] by podivilov@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: update call frame location when source mapping is changed.
​https://bugs.webkit.org/show_bug.cgi?id=68997

Currently we use fake "debugger-paused" event hack to update execution line and call stack placards when source mapping is changed.

  • add PresentationCallFrame.createPlacard method to create "live" placards that are updated on source mapping changes.
  • remove PresentationCallFrame functionName, isInternalScript, and url getters.
  • fire execution-line-changed event when selected call frame or source mapping is changed.

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.sh:
  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMappingPayload):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

  • inspector/front-end/ContentProviders.js:

(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.get rawSourceCode):
(WebInspector.PresentationCallFrame.prototype.uiLocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):

  • inspector/front-end/externs.js:

(WebInspector.displayNameForURL):

5:58 AM Changeset in webkit [96587] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
​https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip one more failing test.
5:56 AM Changeset in webkit [96586] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-10-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector tests fix.

  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel): (WebInspector.ExtensionPanel.prototype.get toolbarItemLabel):
5:32 AM Changeset in webkit [96585] by podivilov@chromium.org
  • 13 edits
    1 add in trunk

Web Inspector: add compiler source mapping support to RawSourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=68891

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):

  • inspector/front-end/CompilerSourceMappingProvider.js: Added.

(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.continueToLine):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):

  • inspector/front-end/UISourceCodeContentProviders.js:

(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
4:37 AM Changeset in webkit [96584] by pfeldman@chromium.org
  • 17 edits
    1 add in trunk/Source/WebCore

Web Inspector: start adding UI components to the compilation process.
​https://bugs.webkit.org/show_bug.cgi?id=69319

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-10-04
Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.resize):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.statusBarResized):

  • inspector/front-end/EmptyView.js:
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.set get toolbarItemLabel):
(WebInspector.Panel.prototype.get statusBarItems):
(WebInspector.Panel.prototype.updateMainViewWidth):
(WebInspector.Panel.prototype.statusBarResized):

  • inspector/front-end/PropertiesSection.js:
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onKeyDown):

  • inspector/front-end/Section.js:

(WebInspector.Section.prototype.set populated):
(WebInspector.Section.prototype.onpopulate):
(WebInspector.Section.prototype.expand):

  • inspector/front-end/SidebarPane.js:
  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown.prototype.show):

  • inspector/front-end/UIUtils.js: Added.

(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
(WebInspector.animateStyle.cancel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.extensionServer.notifyPanelShown):
(WebInspector.extensionServer.notifyPanelHidden):
(WebInspector.currentPanel):
(WebInspector.setCurrentPanel):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
4:03 AM Changeset in webkit [96583] by hans@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Update expectations for svg/W3C-SVG-1.1/pservers-grad-06-b.svg
​https://bugs.webkit.org/show_bug.cgi?id=69330

Win rebaseline.

  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:16 AM Changeset in webkit [96582] by bashi@chromium.org
  • 6 edits
    2 adds in trunk

[Chromium] Implement font shaping with font-feature-settings on Windows
​https://bugs.webkit.org/show_bug.cgi?id=65904

Reviewed by Kenneth Russell.

Source/WebCore:

Use Uniscribe's OpenType APIs to shape complex text to support -webkit-font-feature-settings property.

No new tests. css3/font-feature-settings-rendering.html should pass by this patch.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::loadOpenTypeFunctions):
(WebCore::UniscribeHelper::UniscribeHelper): Calls loadOpenTypeFunctions if needed.
(WebCore::UniscribeHelper::fillRuns): Uses ScriptItemizeOpenType() if possible.
(WebCore::UniscribeHelper::shape): Uses ScriptShapeOpenType() if possible.
(WebCore::UniscribeHelper::fillShapes): Adds OpenType script tag as an argument.
(WebCore::convertFeatureTag): Added.
(WebCore::UniscribeHelper::setRangeProperties): Added.

  • platform/graphics/chromium/UniscribeHelper.h:
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): Calls setRangeProperties().

LayoutTests:

Adds expectations of css3/font-feature-settings-rendering.html for Chromium win port. Since Uniscirbe OpenType APIs are not available on WinXP by default, the test could fail on WinXP.

  • platform/chromium-win/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-win/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt: VISTA and WIN7 should pass css3/font-feature-settings-rendering.html.
3:07 AM Changeset in webkit [96581] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

[EFL] Implement declared but missing functions.
​https://bugs.webkit.org/show_bug.cgi?id=65368

Unreviewed build fix for WebKit/Efl builds after r96566.

  • platform/efl/CursorEfl.cpp:

(WebCore::Cursor::operator=):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::localizedString):

3:05 AM Changeset in webkit [96580] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move abstract panel search logic into the only view that is using it.
​https://bugs.webkit.org/show_bug.cgi?id=69328

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.searchCanceled):
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCount):
(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCountSoon):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.performSearch.processChunk):
(WebInspector.ProfilesPanel.prototype.performSearch):
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):

2:51 AM Changeset in webkit [96579] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-10-04 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fixed poor inspector merge, drive-by front-endcompilation fix.

  • inspector/front-end/ContentProviders.js: (WebInspector.ScriptContentProvider.prototype.requestContent): (WebInspector.ScriptContentProvider.prototype.searchInContent): (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
  • inspector/front-end/DebuggerPresentationModel.js:
2:30 AM Changeset in webkit [96578] by reni@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-10-04

  • platform/qt/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/qt/svg/filters/feColorMatrix-saturate-expected.txt: Added.
2:17 AM Changeset in webkit [96577] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: remove dependency from GoToLine dialog from Panel.
​https://bugs.webkit.org/show_bug.cgi?id=69327

Reviewed by Yury Semikhatsky.

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.install):
(WebInspector.GoToLineDialog._show):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype._tabSelected):
(WebInspector.ResourceContentView.prototype.contentLoaded):
(WebInspector.ResourceContentView.prototype.canHighlightLine):
(WebInspector.ResourceContentView.prototype.highlightLine):
(set WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.viewGetter):
(WebInspector.NetworkPanel):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.registerShortcut):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.viewGetter):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.showResource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.viewGetter):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.canHighlightLine):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._hideTab):
(WebInspector.TabbedPane.prototype.canHighlightLine):
(WebInspector.TabbedPane.prototype.highlightLine):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.canHighlightLine):
(WebInspector.View.prototype.highlightLine):

2:03 AM Changeset in webkit [96576] by commit-queue@webkit.org
  • 11 edits
    5 deletes in trunk

Unreviewed, rolling out r96491.
​http://trac.webkit.org/changeset/96491
​https://bugs.webkit.org/show_bug.cgi?id=69326

Breaks Slow Leopard inspector tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-04

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.requestContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTreeTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTreeTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest):

  • http/tests/inspector/search/resources/search-concatenated.html: Removed.
  • http/tests/inspector/search/search-in-concatenated-script-expected.txt: Removed.
  • http/tests/inspector/search/search-in-concatenated-script.html: Removed.
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt: Removed.
  • http/tests/inspector/search/search-in-script.html: Removed.
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):

1:37 AM Changeset in webkit [96575] by pfeldman@chromium.org
  • 18 edits in trunk/Source/WebCore

Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
​https://bugs.webkit.org/show_bug.cgi?id=69269

Reviewed by Yury Semikhatsky.

  • inspector/compile-front-end.sh:
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._messagesClicked):

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/ContextMenu.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):

  • inspector/front-end/HelpScreen.js:
  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.displayName):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):

  • inspector/front-end/ShortcutsScreen.js:
  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/externs.js:

(WebInspector.populateHrefContextMenu):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
(WebInspector.ScriptsPanel):

  • inspector/front-end/inspector.js:
  • inspector/front-end/utilities.js:
12:21 AM Changeset in webkit [96574] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r96510.

  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt:

Oct 3, 2011:

11:42 PM Changeset in webkit [96573] by rniwa@webkit.org
  • 21 edits in trunk/LayoutTests

Mac rebaseline after r96509.

  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/invalid/017-expected.txt:
  • platform/mac/fast/invalid/018-expected.txt:
  • platform/mac/fast/invalid/020-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/mac/fast/table/inline-form-assert-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
11:22 PM Changeset in webkit [96572] by Csaba Osztrogonác
  • 24 edits
    3 copies
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.

  • platform/qt/fast/invalid/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png.
  • platform/qt/fast/invalid/017-expected.txt:
  • platform/qt/fast/invalid/018-expected.png: Added.
  • platform/qt/fast/invalid/018-expected.txt:
  • platform/qt/fast/invalid/020-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.png.
  • platform/qt/fast/invalid/020-expected.txt:
  • platform/qt/fast/invalid/table-inside-stray-table-content-expected.png: Added.
  • platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/qt/fast/table/inline-form-assert-expected.png:
  • platform/qt/fast/table/inline-form-assert-expected.txt:
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9024-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug9024-expected.txt.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
9:16 PM Changeset in webkit [96571] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Mac release build fix after r96561, and Leopard build fix after r96568.

  • editing/TextCheckingHelper.h:

(WebCore::TextCheckingParagraph::textCharAt):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):

8:52 PM Changeset in webkit [96570] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Build fix after r96568.

  • accessibility/AccessibilityObject.cpp:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:
  • editing/Editor.cpp:
8:20 PM Changeset in webkit [96569] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should inline Array.push and Array.pop
​https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Geoff Garen.

Fix 32-bit.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:10 PM Changeset in webkit [96568] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
​https://bugs.webkit.org/show_bug.cgi?id=69241

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-10-03
Reviewed by Ryosuke Niwa.

WebCore has two different code paths for spell-checking:

1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.

At the first step, this patch introduces an indirect wrapper to call
checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
other non-SL or non-Lion platform.

No new tests because this patch does not change a behavior.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling): ditto.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::checkTextOfParagraph): Added.

  • editing/TextCheckingHelper.h:
7:55 PM Changeset in webkit [96567] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG should inline Array.push and Array.pop
​https://bugs.webkit.org/show_bug.cgi?id=69314

Reviewed by Oliver Hunt.

1% speed-up in V8 due to 6% speed-up in V8-deltablue.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::storePtr):

  • create_hash_table:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGIntrinsic.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

7:26 PM Changeset in webkit [96566] by Darin Adler
  • 13 edits in trunk/Source/WebCore

Change cursor to hand over missing plug-in message
​https://bugs.webkit.org/show_bug.cgi?id=69312

Reviewed by Sam Weinig.

No tests because we currently don't have any test machinery for cursors.

  • page/EventHandler.cpp:

(WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
to represent either a cursor, or no cursor change.
(WebCore::OptionalCursor::isCursorChange): Added.
(WebCore::OptionalCursor::cursor): Added.
(WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
moved some special cases from handleMouseMoveEvent in here. Moved the logic
for plug-ins and framesets into the specific renderer classes for those.
Added a call to the new getCursor virtual function.
(WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
just be a call to selectCursor and then setCursor. Plug-in-specific code is now
in RenderWidget.

  • page/EventHandler.h: Changed return type of selectCursor.
  • page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
(WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
Yes, this has nothing to do with the rest of the patch, but it's good.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
(WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
Overloaded so it can be called with a point rather than an event.
(WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
the logic below.
(WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
Changed to use shouldMissingPluginMessageBeButton.
(WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
a hand when over the missing plug-in message.

  • rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated

for other changes above.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::selectCursor about cursors when over
resizable frame borders.

  • rendering/RenderFrameSet.h: Added getCursor.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.

  • rendering/RenderObject.h: Added getCursor.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
the cursor when the pointer is over a plug-in. This new code is much better,
because it only kicks in when there is actually a plug-in present. The old
was based on the HTML tag!

  • rendering/RenderWidget.h: Added getCursor.
7:00 PM Changeset in webkit [96565] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic should remove builders from the failure grid once they start to pass
​https://bugs.webkit.org/show_bug.cgi?id=69309

Unreviewed. dglazkov is on vacation. I need to interest someone else
in reviewing these patches.

This patch follows the update/purge model from UpdateTracker. This
patch is less awesome than it could be because it causes the UI to
flash slightly. In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing. However,
that's not such a big deal because this UI is hidden in the default
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
6:37 PM Changeset in webkit [96564] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC ASSERT Opening the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=69293

Reviewed by Oliver Hunt.

If a polymorphic access structure list has a duplicated structure, then
don't crash.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

6:16 PM Changeset in webkit [96563] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

On X86, switch bucketCount into a register, timeoutCheck into memory
​https://bugs.webkit.org/show_bug.cgi?id=69299

Reviewed by Geoff Garen.

We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):

  • Added branchSub32 with AbsoluteAddress.
  • jit/JIT.cpp:

(JSC::JIT::emitTimeoutCheck):

  • Keep timeout count in memory on X86.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • remove X86 specific code, switch bucket count back into a register.
  • jit/JITStubs.cpp:
    • Stop initializing esi (it is no longer the timeoutCheck!)
  • jit/JSInterfaceJIT.h:
    • change definition of esi to be the bucketCountRegister.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
    • Add timeoutCount as a property to global data (the counter should be per-thread).
6:05 PM Changeset in webkit [96562] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG backends don't have access to per-node predictions from the propagator
​https://bugs.webkit.org/show_bug.cgi?id=69291

Reviewed by Oliver Hunt.

Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.

This is performance neutral.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):

5:29 PM Changeset in webkit [96561] by andersca@apple.com
  • 13 edits in trunk/Source/WebCore

Work towards making PlatformWheelEvent immutable
​https://bugs.webkit.org/show_bug.cgi?id=69306

Reviewed by Sam Weinig.

Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
the event has been handled or not. For all other event types, that state is instead
tracked by the return value of the various event handlers.

As a first step, add return values to the various handleWheelEvent functions and
add an assertion in EventHandler::wheelEvent that the return value is the same as
the state of PlatformWheelEvent::isAccepted.

  • Configurations/Base.xcconfig:

Don't warn when using C++11 extensions.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):
Assert that isAccepted matches the return value.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):
Return isAccepted.

  • platform/ScrollAnimator.h:

HandleWheelEvent now returns a boolean.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Return whether the event was handled or not.

  • platform/ScrollView.h:

ScrollView::wheelEvent now returns a bool.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):

  • platform/ScrollableArea.h:

ScrollableArea::handleWheelEvent now returns a bool.

  • platform/chromium/ScrollAnimatorChromiumMac.h:
  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
Add return values, based on either the base class calls or the state of
PlatformWheelEvent::isAccepted().

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Ditto.

5:23 PM Changeset in webkit [96560] by levin@chromium.org
  • 4 edits in trunk/Tools

webkitpy: Expose cc_emails and comments from bug.py
​https://bugs.webkit.org/show_bug.cgi?id=69308

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due

to comments being exposed.

5:13 PM Changeset in webkit [96559] by eric@webkit.org
  • 2 edits
    1 copy in trunk/PerformanceTests

Add a microbenchmark for a full-page render of the HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=69285

Reviewed by Adam Barth.

This was designed to be a test for ​https://bugs.webkit.org/show_bug.cgi?id=68944
But it seems that by far our dominating cost for the HTML5 benchmark is
time spent laying out lines (which isn't actually that surprising).

I'm adding the performance test for posterity.

  • Parser/html-parser.html:
    • Removed use of "about:blank" which abarth says is a no-op. Made comment more accurate.
  • Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.
5:10 PM Changeset in webkit [96558] by mitz@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=69305

Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/custom/boundingBox.html

Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
bounding rects.

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer): Ditto.

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
(WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
box.

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.

  • rendering/svg/SVGRenderSupport.h:

LayoutTests:

  • svg/custom/boundingBox-expected.txt: Added.
  • svg/custom/boundingBox.html: Added.
4:54 PM Changeset in webkit [96557] by jamesr@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Tweak WebCompositor API for input event handling to express three possible states
​https://bugs.webkit.org/show_bug.cgi?id=69304

Reviewed by Darin Fisher.

  • public/WebCompositorClient.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):

4:22 PM Changeset in webkit [96556] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add myself to the watchlist for platform/graphics/chromium
​https://bugs.webkit.org/show_bug.cgi?id=69297

Patch by James Robinson <​jamesr@chromium.org> on 2011-10-03
Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
4:11 PM Changeset in webkit [96555] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Content area does not return to the correct position after rubberbanding
​https://bugs.webkit.org/show_bug.cgi?id=69302
<rdar://problem/10102886>

Reviewed by Sam Weinig.

Make sure to schedule a display after adding to the dirty region.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):

4:07 PM Changeset in webkit [96554] by Michael Nordman
  • 5 edits in trunk/Source/WebCore

A little more WebSQLDatabase thread safety.
​https://bugs.webkit.org/show_bug.cgi?id=69277

  • switch to using AtomicallyInitializedStatic where appropiate
  • avoid using some Strings across threads

Reviewed by David Levin.

Existing tests apply.

  • storage/AbstractDatabase.cpp:

(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):

  • storage/AbstractDatabase.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::tracker):

  • storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::instance):

4:05 PM Changeset in webkit [96553] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
​https://bugs.webkit.org/show_bug.cgi?id=68874

Reviewed by Enrica Casucci.

Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.

  • editing/CompositeEditCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
the text node referenced by destination. This is tested by an existing layout test.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
by the existing layout tests in editing/pasteboard.
(WebCore::ReplaceSelectionCommand::updateNodesInserted):

  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp:

(WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
(WebCore::highestNodeToRemoveInPruning): Ditto.

  • editing/htmlediting.h:
4:02 PM Changeset in webkit [96552] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r94274): cloned text input loses value
​https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

  • fast/forms/clone-input-with-dirty-value-expected.txt: Added.
  • fast/forms/clone-input-with-dirty-value.html: Added.
3:51 PM Changeset in webkit [96551] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r96530.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

3:35 PM Changeset in webkit [96550] by weinig@apple.com
  • 8 edits in trunk/Source/WebCore

Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
​https://bugs.webkit.org/show_bug.cgi?id=69294

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):
Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.

  • dom/Document.h:

Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setContentSecurityPolicy):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::contentSecurityPolicy):
Add ContentSecurityPolicy member and getter/setter.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::parseReportURI):
(WebCore::ContentSecurityPolicy::createCSPDirective):

  • page/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::create):
Replace Document with ScriptExecutionContext. Add temporary checked casts to document
where necessary.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
Add initialization of the ContentSecurityPolicy.

3:31 PM Changeset in webkit [96549] by andersca@apple.com
  • 22 edits in trunk

Remove custom scrollbar painting hooks
​https://bugs.webkit.org/show_bug.cgi?id=69163

Source/WebCore:

Reviewed by Alexey Proskuryakov.

The custom scrollbar and scroll corner painting hooks aren't used by anyone
so go ahead and remove them. This removes the setter/getter and ChromeClient functions.

  • page/Chrome.cpp:
  • page/ChromeClient.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):

Source/WebKit/chromium:

Reviewed by Alexey Proskuryakov.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):

Source/WebKit/win:

Reviewed by Alexey Proskuryakov.

Remove now unused WebPreferences and ChromeClient overrides.

  • Interfaces/IWebPreferences.idl:
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::unused3):
(WebPreferences::unused4):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Remove overridden ChromeClient member functions.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):
No need to enable custom scrollbar painting.

3:25 PM Changeset in webkit [96548] by abarth@webkit.org
  • 4 edits
    7 adds
    3 deletes in trunk/LayoutTests

Update results again now that Leopard has finally cycled.

  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
3:15 PM Changeset in webkit [96547] by Darin Adler
  • 22 edits in trunk/Source/WebCore

Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
​https://bugs.webkit.org/show_bug.cgi?id=68672

Reviewed by Daniel Bates.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):

  • css/CSSStyleSelector.cpp:

(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::styleForElement):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/haiku/RenderThemeHaiku.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::resolve):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::releaseConnectionForDownload):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::create):

  • platform/wx/RenderThemeWx.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderTheme::themeForPage):

  • rendering/style/RenderStyle.cpp:

(WebCore::defaultStyle):
Call leakRef instead of releaseRef. I did this only in the cases where
it was obvious to me this was the right way to do it. I'll keep revisiting
sites still calling it releaseRef until they are all gone.

3:00 PM Changeset in webkit [96546] by ojan@chromium.org
  • 9 edits in trunk/Source/WebCore

remove dead code in flipForWritingMode
​https://bugs.webkit.org/show_bug.cgi?id=68948

Reviewed by Hajime Morita.

ChildToParentFlippingAdjustment is never used, so the third argument
to flipForWritingMode always has the same value.

In addition, renamed to flipForWritingModeForChild to be more clear
that it's operating on the child and renamed flipFloatForWritingMode to match.

No new tests. This is just a code cleanup. No functional changes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::flipFloatForWritingModeForChild):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::flipForWritingModeForChild):
(WebCore::RenderBox::topLeftLocation):

  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::nodeAtPoint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::nodeAtPoint):

2:57 PM Changeset in webkit [96545] by jer.noble@apple.com
  • 10 edits in trunk/Source

Unreviewed, rolling out r96526.
​http://trac.webkit.org/changeset/96526
​https://bugs.webkit.org/show_bug.cgi?id=68587

WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
2:55 PM Changeset in webkit [96544] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Update results to account for Windows Vista.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
2:50 PM Changeset in webkit [96543] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

<​http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values

Reviewed by Pavel Feldman.

Source/WebCore:

Previously we assumed rgb values were always in byte form,
but they could include percentage values. Ex. rgb(100%,0,0).
This patch fixes this, and in the process includes clamping
for invalid percentages, byte values, and alpha values.

Test: inspector/styles/styles-invalid-color-values.html

  • inspector/front-end/Color.js:

(WebInspector.Color.prototype._clamp):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._individualRGBValueToHexValue):
(WebInspector.Color.prototype._rgbToHex):
(WebInspector.Color.prototype._rgbToHSL):
An individual rgb value can be either a decimal/float or a
percentage. Rewrite the conversion functions to handle either
input. Regardless of the type of input, always return a clamped
decimal/float value between 0 and 255.

(WebInspector.Color.prototype._rgbaToHSLA):
(WebInspector.Color.prototype._hslaToRGBA):
(WebInspector.Color.prototype._parse):
Clamp the alpha value between 0 and 1.

LayoutTests:

This test outputs all of the supported color format representations
for supplied CSS color values. We expect some of the CSS values
to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
that rgb percentages, such as rgb(100%,0,0), work correctly.

  • inspector/styles/styles-invalid-color-values-expected.txt: Added.
  • inspector/styles/styles-invalid-color-values.html: Added.
2:45 PM Changeset in webkit [96542] by abarth@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Update chromium-cg-mac results after ​http://trac.webkit.org/changeset/96530.

  • platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
2:44 PM Changeset in webkit [96541] by levin@chromium.org
  • 3 edits in trunk/Tools

watchlist: Make watchlist run on a bot.
​https://bugs.webkit.org/show_bug.cgi?id=68974

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Change to log what is run so that we can see the style command
and the watchlist command being run.

2:44 PM Changeset in webkit [96540] by levin@chromium.org
  • 5 edits in trunk/Tools

watchlist: Allow specified a bug to attach the watchlist info to.
​https://bugs.webkit.org/show_bug.cgi?id=69288

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:

Add tests and fix an existing test because the unit tests do not go through the
normal command line processing (so the -g argument remained when we determined bug ids).

  • Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to

get the assert raises regex method.

  • Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
2:42 PM Changeset in webkit [96539] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Update results now that the race condition is fixed. It seems like the
cross-platform results would need to be updated as well, but no bot has
told me that yet.

  • platform/chromium-mac-leopard/svg/as-object: Added.
  • platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
2:37 PM Changeset in webkit [96538] by abarth@webkit.org
  • 14 edits
    8 adds
    3 deletes in trunk/LayoutTests

Update baselines after ​http://trac.webkit.org/changeset/96530.

  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-cg-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
  • svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
1:57 PM Changeset in webkit [96537] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[EFL] DRT: Add JSStringUtils.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=66397

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-10-03
Reviewed by Ryosuke Niwa.

Adds helper functions to compare the equality of C-style strings and
JSStringRef objects.

  • DumpRenderTree/efl/JSStringUtils.cpp: Added.

(equals):

  • DumpRenderTree/efl/JSStringUtils.h: Added.
1:51 PM Changeset in webkit [96536] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic should work in Safari 5.1
​https://bugs.webkit.org/show_bug.cgi?id=69290

Reviewed by Sam Weinig.

My old implementation of bind was too clever by half. This one seems
to work better, at least according to this test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1:43 PM Changeset in webkit [96535] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r96532.
​http://trac.webkit.org/changeset/96532
​https://bugs.webkit.org/show_bug.cgi?id=69289

Accidentally marked failures as expected instead of creating
new baseline. (Requested by krit on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-03

  • platform/chromium/test_expectations.txt:
1:39 PM Changeset in webkit [96534] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for DFG JIT 32_64.

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:25 PM Changeset in webkit [96533] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

webkit->chromium DEPS roll 103471->103694
​https://bugs.webkit.org/show_bug.cgi?id=69271

This brings in a new tools/win/supalink directory from
​http://src.chromium.org/viewvc/chrome?view=rev&revision=103474

Patch by Elliot Poger <​epoger@google.com> on 2011-10-03
Reviewed by Adam Barth.

  • DEPS:
1:24 PM Changeset in webkit [96532] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

Uneviewed by rebaseline after SVG Pattern patch with bug 69261.

  • platform/chromium/test_expectations.txt:
1:09 PM Changeset in webkit [96531] by eric@webkit.org
  • 2 edits in trunk/PerformanceTests

PerformanceTests/Parser/html-parser is only testing parsing of the head element
​https://bugs.webkit.org/show_bug.cgi?id=69283

Reviewed by Adam Barth.

While investigating ​https://bugs.webkit.org/show_bug.cgi?id=68944
I found that the html-parser benchmark was only parsing up to the
first script tag per loop! We've fixed this by adding the sandbox
tag which will deny all external loads and allow the parser to
synchronously continue parsing the entire document to completion
(as we had expected it was doing).

This changes the profile somewhat. Line number counting is much
hotter, since we're actually accounting for the parse of the entire
document in our sample.

Total sample time only about doubles, from 1800ms to 3800ms on my machine
which is less than I would have expected.

  • Parser/html-parser.html:
12:54 PM Changeset in webkit [96530] by krit@webkit.org
  • 5 edits
    3 adds in trunk

SVG Pattern tile pixelated on patternTransform
​https://bugs.webkit.org/show_bug.cgi?id=69261

Source/WebCore:

Reviewed by Rob Buis.

Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.

Test: svg/custom/pattern-scaled-pattern-space.svg

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

LayoutTests:

Reviewed by Rob Buis.

Add a new test to check that SVG pattern tiles are not pixelated on
scaling with patternTransform.
Updated two more pixel tests. Both changes are progressions.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
  • svg/custom/pattern-scaled-pattern-space.svg: Added.
12:52 PM Changeset in webkit [96529] by jamesr@google.com
  • 10 edits
    1 copy in trunk/Source

[chromium] Add WebWidget API for accessing the current WebCompositor
​https://bugs.webkit.org/show_bug.cgi?id=69181

Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

  • public/WebWidget.h:

(WebKit::WebWidget::compositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
12:44 PM Changeset in webkit [96528] by abarth@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk/LayoutTests

Another round of updates after ​http://trac.webkit.org/changeset/96509.

  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.png:
  • platform/chromium-win/fast/invalid/018-expected.png:
  • platform/chromium-win/fast/invalid/020-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
12:25 PM Changeset in webkit [96527] by fpizlo@apple.com
  • 15 edits
    1 add in trunk/Source/JavaScriptCore

DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
​https://bugs.webkit.org/show_bug.cgi?id=69235

Reviewed by Oliver Hunt.

This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.

Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.

Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Instruction.h:

(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):

  • dfg/DFGNode.h:

(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureSet.h: Added.

(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

12:21 PM Changeset in webkit [96526] by jer.noble@apple.com
  • 10 edits in trunk/Source

Enable WEB_AUDIO by default in the WebKit/mac port.
​https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to

the WebCore.framework bundle.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:13 PM Changeset in webkit [96525] by crogers@google.com
  • 24 edits
    2 adds in trunk

BiquadFilterNode .type attribute is not handled correctly
​https://bugs.webkit.org/show_bug.cgi?id=69182

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/biquadfilternode-basic.html

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::initialize):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::AudioChannelMerger):

  • webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::AudioChannelSplitter):

  • webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::setNodeType):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):

  • webaudio/AudioNode.h:

(WebCore::AudioNode::nodeType):

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):

  • webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):
(WebCore::BiquadFilterNode::setType):

  • webaudio/BiquadFilterNode.h:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::setType):

  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • webaudio/HighPass2FilterNode.cpp:

(WebCore::HighPass2FilterNode::HighPass2FilterNode):

  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):

  • webaudio/LowPass2FilterNode.cpp:

(WebCore::LowPass2FilterNode::LowPass2FilterNode):

  • webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

  • webaudio/RealtimeAnalyserNode.cpp:

(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):

  • webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):

LayoutTests:

  • webaudio/biquadfilternode-basic-expected.txt: Added.
  • webaudio/biquadfilternode-basic.html: Added.
12:01 PM Changeset in webkit [96524] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: support role mapping for HTML5 section elements
​https://bugs.webkit.org/show_bug.cgi?id=69150

Source/WebCore:

We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:

article -> Document article
nav -> Landmark navigation
aside -> Landmark complementary
section -> Document region
address -> Landmark content info
header -> Landmark banner (unless it's in an article or section)
footer -> Landmark content info (unless it's in an article or section)

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html-section-elements.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/accessibility/html-section-elements-expected.txt: Added.
  • platform/mac/accessibility/html-section-elements.html: Added.
11:55 AM Changeset in webkit [96523] by ademar@webkit.org
  • 2 edits in trunk/Tools

Unreviewed: change my e-mail in commiters.py

(I'm leaving the company and my @openbossa.org will be no more)

  • Scripts/webkitpy/common/config/committers.py:
11:09 AM Changeset in webkit [96522] by Chris Fleizach
  • 1 edit
    2 adds in trunk/LayoutTests

AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
​https://bugs.webkit.org/show_bug.cgi?id=69262

Actually commit the files this time.

Reviewed by John Sullivan.

  • platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
  • platform/mac/accessibility/heading-clickpoint.html: Added.
11:05 AM Changeset in webkit [96521] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Results from more bots for ​http://trac.webkit.org/changeset/96498.

  • platform/chromium-cg-mac-leopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Removed.
  • platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Removed.
11:04 AM Changeset in webkit [96520] by Chris Fleizach
  • 6 edits in trunk

AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
​https://bugs.webkit.org/show_bug.cgi?id=69262

Source/WebCore:

When the contextual menu is opened for a heading, often it will open on empty space because
the heading is wider than the content inside. The click point should thus use the content
inside the heading as the click point.

To accomplish this we need to query whether we have children using children() which is a non-const
method, hence the removal of const from clickPoint().

Reviewed by John Sullivan.

Test: platform/mac/accessibility/heading-clickpoint.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clickPoint):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::clickPoint):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by John Sullivan.

  • platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
  • platform/mac/accessibility/heading-clickpoint.html: Added.
11:00 AM Changeset in webkit [96519] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r96500.
​http://trac.webkit.org/changeset/96500
​https://bugs.webkit.org/show_bug.cgi?id=69268

Breaks inspector, change landed with no test. (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-03

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/Linkifier.js: Removed.
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
10:51 AM Changeset in webkit [96518] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unbork the test_expectations file.

  • platform/chromium/test_expectations.txt:
10:40 AM Changeset in webkit [96517] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Add exact match attribute selectors to the fast path
​https://bugs.webkit.org/show_bug.cgi?id=69159

Reviewed by Sam Weinig.

Attribute selectors are increasingly common and we have them in our default style sheet too.
[foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.

  • Implement fast path checking for simple attribute selectors.
  • Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()


This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(WebCore::CSSSelector::hasTag):
(WebCore::CSSSelector::attribute):
(WebCore::CSSSelector::isAttributeSelector):

  • css/CSSSelectorList.cpp:

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkSelector):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkSelector):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::attributeNameMatches):
(WebCore::SelectorChecker::checkExactAttribute):
(WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):

10:37 AM Changeset in webkit [96516] by abarth@webkit.org
  • 10 edits
    32 adds
    5 deletes in trunk/LayoutTests

Update expectations for tables tests after ​http://trac.webkit.org/changeset/96509.

  • platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: Added.
  • platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium/fast/invalid: Added.
  • platform/chromium/fast/invalid/017-expected.txt: Added.
  • platform/chromium/fast/invalid/018-expected.txt: Added.
  • platform/chromium/fast/invalid/020-expected.txt: Added.
  • platform/chromium/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium/fast/invalid/table-inside-stray-table-content-expected.txt: Added.
  • platform/chromium/fast/table: Added.
  • platform/chromium/fast/table/inline-form-assert-expected.txt: Added.
  • platform/chromium/tables: Added.
  • platform/chromium/tables/mozilla: Added.
  • platform/chromium/tables/mozilla/bugs: Added.
  • platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Added.
  • platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug220653-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/core: Added.
  • platform/chromium/tables/mozilla_expected_failures/core/conflicts-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/empty_cells-expected.txt: Added.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
10:20 AM Changeset in webkit [96515] by reed@google.com
  • 2 edits in trunk/Source/WebCore

respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
​https://bugs.webkit.org/show_bug.cgi?id=69172

Reviewed by Stephen White.

No new tests. This is a cleanup/optimization, existing tests apply

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

9:57 AM Changeset in webkit [96514] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r95526): It made 3 inspector tests fail
​https://bugs.webkit.org/show_bug.cgi?id=69265

  • platform/qt/Skipped: Skip failing tests to make buildbot happy.
9:56 AM Changeset in webkit [96513] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete bogus expected PNG.

  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.
9:50 AM Changeset in webkit [96512] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

FontFallbackList: Glyph pages waste a lot of memory.
​https://bugs.webkit.org/show_bug.cgi?id=69260

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.

Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.

The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.

  • platform/graphics/FontFallbackList.h:
9:36 AM Changeset in webkit [96511] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
​https://bugs.webkit.org/show_bug.cgi?id=69252

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didFailProvisionalLoadWithErrorForFrame): Pass failing URL to
signal handler.
(didFailLoadWithErrorForFrame): Ditto.
(webkit_web_loader_client_class_init): Add failing URL parameter
to provisional-load-failed and load-failed signals.

  • UIProcess/API/gtk/WebKitWebLoaderClient.h:
  • UIProcess/API/gtk/tests/testloading.c:

(loadStatusProvisionalLoadFailed): Update to API changes.
(loadStatusLoadFailed): Ditto.
(loadErrorProvisionalLoadFailed): Ditto.

  • UIProcess/API/gtk/webkit2marshal.list:
9:19 AM Changeset in webkit [96510] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Fix typo causing race condition in this test.

  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
9:19 AM Changeset in webkit [96509] by commit-queue@webkit.org
  • 30 edits
    1 copy
    2 adds in trunk

Right border missing from table with colspan and collapsing border
​https://bugs.webkit.org/show_bug.cgi?id=14274

Patch by Konstantin Scheglov <​scheglov@google.com> on 2011-10-03
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/bug14274.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):

  • rendering/RenderTable.h:

(WebCore::RenderTable::colToEffCol):

LayoutTests:

  • fast/table/border-collapsing/bug14274-expected.png: Copied from LayoutTests/platform/chromium-win/fast/invalid/020-expected.png.
  • fast/table/border-collapsing/bug14274-expected.txt: Added.
  • fast/table/border-collapsing/bug14274.html: Added.
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.png:
  • platform/chromium-win/fast/invalid/017-expected.txt:
  • platform/chromium-win/fast/invalid/018-expected.png:
  • platform/chromium-win/fast/invalid/018-expected.txt:
  • platform/chromium-win/fast/invalid/020-expected.png:
  • platform/chromium-win/fast/invalid/020-expected.txt:
  • platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
9:17 AM Changeset in webkit [96508] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Fix memory leak when loading url
​https://bugs.webkit.org/show_bug.cgi?id=69247

Reviewed by Martin Robinson.

Release URL created with WKURLCreateWithUTF8CString().

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri):

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(activateUriEntryCallback):

  • MiniBrowser/gtk/main.c:

(loadURI):

9:16 AM Changeset in webkit [96507] by abarth@webkit.org
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

Update baselines after ​http://trac.webkit.org/changeset/96498.

  • platform/chromium-linux-x86/svg/filters: Removed.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Added.
  • platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: Added.
9:14 AM Changeset in webkit [96506] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfoForLoadedPlugin()
​https://bugs.webkit.org/show_bug.cgi?id=69147

Reviewed by Martin Robinson.

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):

9:11 AM Changeset in webkit [96505] by Carlos Garcia Campos
  • 5 edits in trunk/Source

[GTK] Fix make distcheck build
​https://bugs.webkit.org/show_bug.cgi?id=69243

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.am:
  • GNUmakefile.list.am:
9:03 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the WK2 bot (diff)
9:02 AM Changeset in webkit [96504] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

feColorMatrix saturation is not limited to range 0..1 anymore
​https://bugs.webkit.org/show_bug.cgi?id=69245

Unreviewed rebaseline of Win Chromium DRT results.

  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
8:58 AM Changeset in webkit [96503] by Csaba Osztrogonác
  • 8 edits
    1 add in trunk/Source

[Qt] Build fix: Qt::escape is deprecated in Qt5
​https://bugs.webkit.org/show_bug.cgi?id=69162

Use QString::toHtmlEscaped in the Qt5 case.

Source/JavaScriptCore:

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

(escapeHtml):

  • wtf/wtf.pri:

Source/WebCore:

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

No new tests needed.

  • WebCore.pro: adjust the include path accordingly

in the v8 case.

Source/WebKit/qt:

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

8:51 AM Changeset in webkit [96502] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: [chromium] clean up inspector layout test suppressions on chromium.
​https://bugs.webkit.org/show_bug.cgi?id=69263

  • platform/chromium/test_expectations.txt:
8:43 AM Changeset in webkit [96501] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening after r96404.

Patch by Zsolt Fehér <​feherzs@inf.u-szeged.hu> on 2011-10-03

  • platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
8:07 AM Changeset in webkit [96500] by loislo@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
​https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Yury Semikhatsky.

Test: inspector/performance/resources/network-append-30-requests.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.prototype._linkifyLocation):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():

  • inspector/front-end/Linkifier.js: Added.

(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateSourceAnchors):
(WebInspector.Linkifier.prototype._updateAnchor):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
7:56 AM Changeset in webkit [96499] by pfeldman@chromium.org
  • 18 edits in trunk

Source/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
​https://bugs.webkit.org/show_bug.cgi?id=69253

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessageImpl):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.get path):
(WebInspector.Cookie.prototype.get domain):
(WebInspector.Cookie.prototype.expires):

  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createResource):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.searchInContent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._createResource):

  • inspector/front-end/externs.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.extensionServer.notifyResourceContentCommitted):
(WebInspector.resourceForURL):
(WebInspector.debuggerPresentationModel.linkifyLocation):
(WebInspector.ObjectPropertiesSection):
(WebInspector.ElementsTreeOutline):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):

  • inspector/generate-protocol-externs:

Tools: Unreviewed. Add Zoltán Árvai as contributor.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2011-10-03

  • Scripts/webkitpy/common/config/committers.py:
7:27 AM Changeset in webkit [96498] by krit@webkit.org
  • 6 edits
    3 adds in trunk

feColorMatrix saturation is not limited to range 0..1 anymore
​https://bugs.webkit.org/show_bug.cgi?id=69245

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
under- or oversaturation of the filter input image.
​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement

Test: svg/filters/feColorMatrix-saturate.svg

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Added new test case to test under- or oversaturation of the filter input image if the value
is not in the range of 0..1.
feColorMatrix-values needed a change, since it relies to the old specification text.

  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • svg/filters/feColorMatrix-saturate-expected.png: Added.
  • svg/filters/feColorMatrix-saturate-expected.txt: Added.
  • svg/filters/feColorMatrix-saturate.svg: Added.
  • svg/filters/feColorMatrix-values.svg:
7:21 AM Changeset in webkit [96497] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[EFL] DRT: Add DumpHistoryItem.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=63992

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-10-03
Reviewed by Antonio Gomes.

This is the code responsible for dumping the back and forward history
list.

  • DumpRenderTree/efl/DumpHistoryItem.cpp: Added.

(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dumpBackForwardListForWebViews):

  • DumpRenderTree/efl/DumpHistoryItem.h: Added.
7:16 AM Changeset in webkit [96496] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink HTMLLIElement.
​https://bugs.webkit.org/show_bug.cgi?id=69250

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.

Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):

  • html/HTMLLIElement.h:
7:13 AM Changeset in webkit [96495] by ryuan.choi@samsung.com
  • 3 edits
    3 moves in trunk/Source/WebKit/efl

[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
​https://bugs.webkit.org/show_bug.cgi?id=68599

Use a C++ compiler for these files and fix compile issues and coding style.

Reviewed by Hajime Morita.

  • CMakeListsEfl.txt:
  • ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
  • ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.
7:04 AM Changeset in webkit [96494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
​https://bugs.webkit.org/show_bug.cgi?id=68439

We use a dispatch queue and a dispatch source in the WebProcess
to receive a notification when the UI Process dies.
The WebProcess then commits suicide.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::parentProcessDiedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):

6:58 AM Changeset in webkit [96493] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r96257.
​https://bugs.webkit.org/show_bug.cgi?id=69257

Patch by Zsolt Fehér <​feherzs@inf.u-szeged.hu> on 2011-10-03

  • platform/qt/Skipped:
6:06 AM Changeset in webkit [96492] by kbalazs@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

libdispatch based ParallelJobs is not enough parallel
​https://bugs.webkit.org/show_bug.cgi?id=66378

Reviewed by Zoltan Herczeg.

Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(​https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).

  • wtf/ParallelJobsLibdispatch.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

5:56 AM Changeset in webkit [96491] by vsevik@chromium.org
  • 11 edits
    5 adds in trunk

Web Inspector: Add support for backend search in script content.
​https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html

http/tests/inspector/search/search-in-script.html

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):

  • http/tests/inspector/search/resources/search-concatenated.html: Added.
  • http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-concatenated-script.html: Added.
  • http/tests/inspector/search/search-in-resource.html:
  • http/tests/inspector/search/search-in-script-expected.txt: Added.
  • http/tests/inspector/search/search-in-script.html: Added.
  • http/tests/inspector/search/search-test.js:

(initialize_SearchTest):

4:58 AM Changeset in webkit [96490] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r96481.
​http://trac.webkit.org/changeset/96481
​https://bugs.webkit.org/show_bug.cgi?id=69251

Breaks webkit_unit_tests on Linux(dbg) (Requested by hwennborg
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-03

  • WebKit.gypi:
  • public/WebCompositor.h:
  • public/WebWidgetClient.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebCompositorImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):

  • tests/WebCompositorImplTest.cpp: Removed.
4:37 AM Changeset in webkit [96489] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
​https://bugs.webkit.org/show_bug.cgi?id=69223

WebKitTestRunner must include Qt / qnamespace header
to get a definition of Qt::MouseButtons.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

  • WebKitTestRunner/EventSenderProxy.h:
3:55 AM Changeset in webkit [96488] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed. Add Zoltán Árvai as contributor.

  • Scripts/webkitpy/common/config/committers.py:
2:54 AM Changeset in webkit [96487] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
​https://bugs.webkit.org/show_bug.cgi?id=69244

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatParameter):
(WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessage.prototype._formatParameterAsString):
(WebInspector.ConsoleMessage.prototype._printArray):
(WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):

  • inspector/front-end/ConsoleView.js:
2:30 AM Changeset in webkit [96486] by rgabor@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed Qt gardening after r96404

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-10-03

  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
2:18 AM WebKit Team edited by yutak@chromium.org
(diff)
2:16 AM Changeset in webkit [96485] by pfeldman@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: restore partial front-end compilability
​https://bugs.webkit.org/show_bug.cgi?id=69221

Removed unused isWhitespace; introduced missing classes in Inspector.json;
generated externs for the protocol types along with the commands.

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-10-03
Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateBreadcrumb):

  • inspector/front-end/ElementsTreeOutline.js:

():

  • inspector/front-end/Object.js:
  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._mouseMove):

  • inspector/front-end/View.js:
  • inspector/front-end/externs.js:

(Array.prototype.remove):

  • inspector/generate-protocol-externs:

Oct 2, 2011:

11:59 PM Changeset in webkit [96484] by tkent@chromium.org
  • 14 edits
    4 adds in trunk

method/enctype/formMethod/formEnctype properties should be limited to known values.
​https://bugs.webkit.org/show_bug.cgi?id=68887

Reviewed by Hajime Morita.

Source/WebCore:

According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.

  • HTMLFormElement::method
  • HTMLFormElement::enctype
  • HTMLInputElement::formMethod
  • HTMLInputElement::formEnctype
  • HTMLButtonElement::formMethod
  • HTMLButtonElement::formEnctype

Tests: fast/forms/enctype-attribute.html

fast/forms/method-attribute.html

  • html/HTMLButtonElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().

  • html/HTMLFormElement.idl:

Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.

  • html/HTMLInputElement.idl: ditto.
  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.

  • loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.

LayoutTests:

  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
  • fast/forms/enctype-attribute-expected.txt: Added.
  • fast/forms/enctype-attribute.html: Added.
  • fast/forms/method-attribute-expected.txt: Added.
  • fast/forms/method-attribute.html: Added.
  • fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
  • fast/forms/submit-form-attributes-expected.txt: ditto.
11:49 PM Changeset in webkit [96483] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt]REGRESSION(r95912): It made sputnik tests flakey
​https://bugs.webkit.org/show_bug.cgi?id=68990

Reviewed by Geoffrey Garen.

Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.

  • runtime/Structure.h:

(JSC::Structure::transitionCount):

7:13 PM Changeset in webkit [96482] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG misses some obvious opportunities for common subexpression elimination
​https://bugs.webkit.org/show_bug.cgi?id=69233

Reviewed by Oliver Hunt.

0.7% speed-up on SunSpider.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

6:11 PM Changeset in webkit [96481] by commit-queue@webkit.org
  • 9 edits
    1 copy in trunk/Source/WebKit/chromium

[chromium] Add WebWidget API for accessing the current WebCompositor
​https://bugs.webkit.org/show_bug.cgi?id=69181

Patch by James Robinson <​jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

  • public/WebWidget.h:

(WebKit::WebWidget::compositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
5:40 PM Changeset in webkit [96480] by weinig@apple.com
  • 6 edits in trunk/Source

Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
​https://bugs.webkit.org/show_bug.cgi?id=69230

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

../WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):

5:22 PM Changeset in webkit [96479] by barraclough@apple.com
  • 5 edits in trunk

Bug 67455 - Different regular expression result

Reviewed by Darin Adler.

Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.

Source/JavaScriptCore:

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchParentheses):

  • Simplify some nested if else logic.

(JSC::Yarr::Interpreter::backtrackParentheses):

  • Simplify some nested if else logic.
  • Only return early from backtrackParentheses on success/error, not on failure.

LayoutTests:

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
    • Added test cases from bug.
1:02 PM Changeset in webkit [96478] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
​https://bugs.webkit.org/show_bug.cgi?id=68542

Reviewed by Mark Rowe.

  • WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
12:54 PM Changeset in webkit [96477] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
​https://bugs.webkit.org/show_bug.cgi?id=69223

Source/WebCore:

Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

No new tests, build fix.

  • WebCore.pro:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:

Source/WebKit2:

After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

  • UIProcess/API/qt/qmlplugin/qmlplugin.pro:
12:41 PM Changeset in webkit [96476] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an unused member in RenderTable::ColumnStruct
​https://bugs.webkit.org/show_bug.cgi?id=69119

Reviewed by Darin Adler.

No test as there should be no change in behavior.

The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.

  • rendering/RenderTable.h:

(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.

10:38 AM Changeset in webkit [96475] by abarth@webkit.org
  • 1 edit
    2 adds
    15 deletes in trunk/LayoutTests

Remove temporary baselines after ​http://trac.webkit.org/changeset/96470.

  • platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/css: Removed.
  • platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css: Removed.
  • platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
  • platform/chromium/svg/filters: Removed.
  • platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.txt: Added.
10:35 AM Changeset in webkit [96474] by abarth@webkit.org
  • 3 edits in trunk/Tools

Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES. Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.

We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow. We'll probably serve the UI of some web server, but
we'll need to work that out later.

  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
10:18 AM Changeset in webkit [96473] by abarth@webkit.org
  • 10 edits in trunk/Tools

Rip out half-backed garden-o-matic features in preparation for wider use
​https://bugs.webkit.org/show_bug.cgi?id=69226

This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
8:25 AM Changeset in webkit [96472] by abarth@webkit.org
  • 14 edits
    22 adds
    10 deletes in trunk/LayoutTests

Update baseline and expectations after ​http://trac.webkit.org/changeset/96470

  • platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
  • platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
  • platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-mac/svg/filters/filter-clip-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/css: Added.
  • platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-win-xp/svg/css: Added.
  • platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
  • platform/chromium/svg/filters: Added.
  • platform/chromium/svg/filters/filter-clip-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/mac/svg/filters/filter-clip-expected.txt: Removed.
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
  • platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
  • platform/qt/svg/filters/filter-clip-expected.txt: Removed.
  • svg/custom/grayscale-gradient-mask-expected.txt: Added.
  • svg/custom/mask-with-all-units-expected.txt: Added.
  • svg/filters/filter-clip-expected.txt: Added.
1:25 AM Changeset in webkit [96471] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
​https://bugs.webkit.org/show_bug.cgi?id=68760

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/invalid-lengths.html

Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.

  • css/MediaQueryEvaluator.cpp:

(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.

LayoutTests:

  • fast/media/invalid-lengths-expected.txt: Added.
  • fast/media/invalid-lengths.html: Added.
12:15 AM Changeset in webkit [96470] by krit@webkit.org
  • 5 edits
    3 adds in trunk

SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
​https://bugs.webkit.org/show_bug.cgi?id=69076

Source/WebCore:

Reviewed by Simon Fraser.

SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.

Test: svg/custom/grayscale-gradient-mask-2.svg

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceMasker.h:

LayoutTests:

Reviewed by Simon Fraser.

Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.

  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • svg/custom/grayscale-gradient-mask-2.svg: Added.

Oct 1, 2011:

11:49 PM Changeset in webkit [96469] by abarth@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Tweak expectations for leopard some more.

  • platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
9:34 PM Changeset in webkit [96468] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Correct post-build step for WinCairo test runs.
​https://bugs.webkit.org/show_bug.cgi?id=69191

Reviewed by Brian Weinstein.

  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional

shell case to handle the CFLite build.

7:21 PM Changeset in webkit [96467] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
​http://trac.webkit.org/changeset/96454

​https://bugs.webkit.org/show_bug.cgi?id=69217

Reviewed by James Robinson.

Tests: compositor test now pass

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
6:13 PM Changeset in webkit [96466] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Leopard build fix: Updated for Strong<T> changes.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:
  • WebView/WebScriptDebugger.mm:
5:54 PM Changeset in webkit [96465] by ggaren@apple.com
  • 33 edits
    2 adds in trunk/Source

Removed redundant helper functions for allocating Strong handles
​https://bugs.webkit.org/show_bug.cgi?id=69218

Reviewed by Sam Weinig.

../JavaScriptCore:

  • heap/Heap.h:

(JSC::Heap::handleHeap):

  • runtime/JSGlobalData.h: Removed these helper functions, since they

just created indirection.

  • heap/StrongInlines.h: Added. Broke out a header for inline functions

to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.

  • API/JSCallbackObjectFunctions.h:

(JSC::::init):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::setSingleTransition):

  • heap/Local.h:

(JSC::::Local):

  • heap/Strong.h:

(JSC::::Strong):
(JSC::::set):

  • heap/Weak.h:

(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.

  • bytecompiler/BytecodeGenerator.cpp:
  • runtime/JSGlobalData.cpp:
  • runtime/LiteralParser.cpp:
  • runtime/RegExpCache.cpp: Updated for header changes.

../JavaScriptGlue:

  • JSRun.cpp:
  • JSValueWrapper.cpp:

../WebCore:

  • ForwardingHeaders/heap/StrongInlines.h: Added.
  • bindings/js/JSCallbackData.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptCachedFrameData.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/runtime_root.cpp:

../WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
3:08 PM Changeset in webkit [96464] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Added myself to reviewers, because I'm now a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:03 PM Changeset in webkit [96463] by fpizlo@apple.com
  • 11 edits
    2 adds in trunk/Source/JavaScriptCore

All of JSC's heuristics should be in one place for easier tuning
​https://bugs.webkit.org/show_bug.cgi?id=69201

Reviewed by Oliver Hunt.

This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.

It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.

(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/CodeBlock.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

  • runtime/Heuristics.cpp: Added.

(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h: Added.
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

3:01 PM WebKit Team edited by fpizlo@apple.com
(diff)
2:58 PM Changeset in webkit [96462] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Bencher script makes it difficult to do automated performance testing
​https://bugs.webkit.org/show_bug.cgi?id=69207

Reviewed by Sam Weinig.

This adds two new features:

The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.

The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.

  • Scripts/bencher:
2:46 PM Changeset in webkit [96461] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Support string length in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=69215

Reviewed by Geoff Garen.

Adds a GetStringLength node to the DFG so that we can support
string.length inline.

  • dfg/DFGNode.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownString):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSString.h:

(JSC::JSString::offsetOfLength):

1:48 PM Changeset in webkit [96460] by weinig@apple.com
  • 2 edits in trunk/Tools

WTR is not successfully changing the NSUserDefaults
​https://bugs.webkit.org/show_bug.cgi?id=69204

Reviewed by Dan Bernstein.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.

12:56 PM Changeset in webkit [96459] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete bogus text expectation.

  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
12:21 PM Changeset in webkit [96458] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
​https://bugs.webkit.org/show_bug.cgi?id=69205

Patch by Yuqiang Xian <​yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.

If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):

10:32 AM Changeset in webkit [96457] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note test as timing out.

  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [96456] by abarth@webkit.org
  • 3 edits
    5 adds
    2 deletes in trunk/LayoutTests

Update Mac baselines.

  • platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/as-object: Added.
  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
  • platform/chromium-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
12:22 AM Changeset in webkit [96455] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/Source

Unreviewed, rolling out r96421.
​http://trac.webkit.org/changeset/96421
​https://bugs.webkit.org/show_bug.cgi?id=69206

It broke Qt-WK2 build (Requested by ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-01

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.pro:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

12:04 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the WK2 bot (diff)
Note: See TracTimeline for information about the timeline view.