⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 29, 2011:

10:36 PM Changeset in webkit [98824] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

8:06 PM Changeset in webkit [98823] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
5:45 PM Changeset in webkit [98822] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::markMisspellingsAfterTypingToWord):

4:27 PM Changeset in webkit [98821] by dcheng@chromium.org
  • 16 edits
    7 moves in trunk/Source/WebCore

Rename DataTransferItems to DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.h:
  • dom/Clipboard.idl:
  • dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):

  • dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.

(WebCore::DataTransferItemList::~DataTransferItemList):

  • dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):

  • platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::items):

  • platform/qt/ClipboardQt.h:
  • platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.

(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):

  • platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.
3:55 PM Changeset in webkit [98820] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Add track-text-track-destructor-crash.html to Skipped files for mac and win
​https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped:
  • platform/win/Skipped:
3:06 PM Changeset in webkit [98819] by eric@webkit.org
  • 7 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
3:04 PM Changeset in webkit [98818] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98813.

  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
2:34 PM Changeset in webkit [98817] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [98816] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK+ and Qt rebaselines after r98794.

  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.txt:
1:35 PM Changeset in webkit [98815] by robert@webkit.org
  • 2 edits
    2 moves
    1 add in trunk/LayoutTests

Second attempt to add results for tests introduced in ​http://trac.webkit.org/changeset/98812

  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
  • platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.
1:14 PM Changeset in webkit [98814] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Qt and Gtk Results for tests updated by ​http://trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
1:06 PM Changeset in webkit [98813] by robert@webkit.org
  • 1 edit
    1 move
    7 adds in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
12:15 PM Changeset in webkit [98812] by robert@webkit.org
  • 7 edits in trunk

CSS 2.1 failure: block-non-replaced-width-008.htm
​https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthUsing):

Include the margins in the calculation of logical width even when the containing block's
width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
test suite.

LayoutTests:

  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt: The pixel result is preserved, but the width of the containing block in the render tree now accurately reflects the rendered size of the cells.
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
11:58 AM Changeset in webkit [98811] by abarth@webkit.org
  • 1 edit
    20 adds
    5 deletes in trunk/LayoutTests

Add results for tests introduced in ​http://trac.webkit.org/changeset/98805.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win-vista/css2.1: Removed.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
11:29 AM Changeset in webkit [98810] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update results after ​http://trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

  • platform/chromium-win/editing/pasteboard/5134759-expected.txt:
11:26 AM Changeset in webkit [98809] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Update line number in baseline.

  • platform/chromium-linux-x86/fast/dom: Removed.
  • platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.
10:28 AM Changeset in webkit [98808] by robert@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

Platform-specific results for r98805

Unreviewed, add new results.

  • platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
9:52 AM Changeset in webkit [98807] by annacc@chromium.org
  • 4 edits
    2 adds in trunk

Make sure TextTracks are destructed if HTMLMediaElement goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

Destroy the client (this) on TextTracks.

(WebCore::HTMLMediaElement::loadTextTracks):

Move TextTrack creation to loadNextTextTrack.

(WebCore::HTMLMediaElement::loadNextTextTrack):

Keep track of new TextTrack in a list.

(WebCore::HTMLMediaElement::addTrack):

Keep track of new TextTrack in a list.

  • html/HTMLMediaElement.h:

Add m_textTracks and loadNextTextTrack().

LayoutTests:

  • media/track/track-text-track-destructor-crash-expected.txt: Added.
  • media/track/track-text-track-destructor-crash.html: Added.
9:18 AM Changeset in webkit [98806] by jochen@chromium.org
  • 23 edits
    4 adds in trunk

Implement IDBFactory.deleteDatabase
​https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html

storage/indexeddb/factory-deletedatabase.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::deleteDatabase):

  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::deleteDatabase):

  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):

  • src/WebIDBFactoryImpl.h:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt: Updated.
  • storage/indexeddb/factory-basics.html: Updated.
  • storage/indexeddb/factory-deletedatabase-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
  • storage/indexeddb/factory-deletedatabase-interactions.html: Added.
  • storage/indexeddb/factory-deletedatabase.html: Added.
  • storage/indexeddb/open-close-version-expected.txt: Updated.
  • storage/indexeddb/open-close-version.html: Updated.
7:52 AM Changeset in webkit [98805] by robert@webkit.org
  • 7 edits
    12 adds in trunk

CSS 2.1 failure: dynamic-top-change-001 to 004 fail
​https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

  • css2.1/20110323/dynamic-top-change-001.htm: Added.
  • css2.1/20110323/dynamic-top-change-002.htm: Added.
  • css2.1/20110323/dynamic-top-change-003.htm: Added.
  • css2.1/20110323/dynamic-top-change-004.htm: Added.
  • fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: See ​https://bugs.webkit.org/show_bug.cgi?id=68149#c15
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
7:45 AM Changeset in webkit [98804] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
​https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <​eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

2:36 AM Changeset in webkit [98803] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Tighten font change conditions in matched declaration cache
​https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

  • css/CSSStyleSelector.cpp:

(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
values of non-text CSS properties.

2:10 AM Changeset in webkit [98802] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

DOMURL should keep its own state rather than storing it on ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code. I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • fileapi/FileWriter.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:
1:21 AM Changeset in webkit [98801] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r98780.
​http://trac.webkit.org/changeset/98780
​https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

12:58 AM Changeset in webkit [98800] by Antti Koivisto
  • 1 edit
    2 adds in trunk/LayoutTests

REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
​https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

  • fast/css/inherited-properties-explicit-expected.txt: Added.
  • fast/css/inherited-properties-explicit.html: Added.
12:19 AM Changeset in webkit [98799] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r98795.
​http://trac.webkit.org/changeset/98795
​https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-29

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

12:04 AM Changeset in webkit [98798] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Mac rebaseline after r98617.

  • platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

Oct 28, 2011:

11:41 PM Changeset in webkit [98797] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r98775.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
11:31 PM Changeset in webkit [98796] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Potential crash in ReplaceNodeWithSpanCommand
​https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

10:51 PM Changeset in webkit [98795] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

MessagePort should be a ContextDestructionObserver
​https://bugs.webkit.org/show_bug.cgi?id=71167

Reviewed by Eric Seidel.

I couldn't quite get rid of all the uses of the
ScriptExecutionContext::m_messagePorts in this patch. I hope to get
rid of them in the future as the "extra data" design for
ScriptExecutionContext emerges.

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):

  • dom/MessagePort.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

10:27 PM Changeset in webkit [98794] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

The copy and paste result in nested scrollbars on ​http://dojotoolkit.org/widgets
​https://bugs.webkit.org/show_bug.cgi?id=70799

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit's treating a fully selected root with background property as a special common ancestor.
A variant of this bug was caused by treating any element with text-decoration property as a presentational element.

Fixed the above two bugs by not serializing the said nodes. The effective background color was already serialized
by wrappingStyleForSerialization, there was nothing to be done besides stop including it in highestAncestorToWrapMarkup.

For text-decoration property, added the logic to compute the effective value in EditingStyle::init. Also treat it
as a non-inheritable editing property so that the rest of EditingStyle just works.

Test: editing/pasteboard/avoid-copying-body-with-background.html

  • editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.

(WebCore::copyEditingProperties):
(WebCore::EditingStyle::init): Compute the effective text decoration when propertiesToInclude is
EditingPropertiesInEffect.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

  • editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgroundColorInEffect to

EditingPropertiesInEffect.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an assertion that's no longer valid.
(WebCore::isElementPresentational): Don't consider an element with text-decoration as a presentational element.
(WebCore::highestAncestorToWrapMarkup): Don't consider fully selected root as a special common ancestor ever.
Background color is computed property when we compute the wrapping style.
(WebCore::createMarkup):

LayoutTests:

Added a test to copy contents inside a body with background and text-decoration properties.

WebKit should not copy body element.

  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: an erroneous inline div

is replaced by a span.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: two style spans are

merged into one.

  • editing/pasteboard/19644-2-expected.txt: div is replaced by span. This is okay because it's the only

content in the body. Even though we now only put the gray background under text as inline style as
opposed to apply at the block level, that's what execCommand('BackColor'...) does and what user expects.

  • editing/pasteboard/avoid-copying-body-with-background-expected.txt: Added.
  • editing/pasteboard/avoid-copying-body-with-background.html: Added.
  • editing/pasteboard/preserve-underline-color-expected.txt:
  • platform/mac/editing/pasteboard/5134759-expected.txt:
6:56 PM Changeset in webkit [98793] by abarth@webkit.org
  • 9 edits
    2 moves in trunk

Rename ExceptionCodeDescription.in to DOMExceptions.in
​https://bugs.webkit.org/show_bug.cgi?id=71157

Reviewed by Eric Seidel.

.:

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

This file is now used for more than just the descriptions of the exceptions.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDescription.in.
  • dom/ExceptionCodeDescription.in: Removed.
  • dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_exception_code_description.pl.
  • dom/make_exception_code_description.pl: Removed.
6:47 PM Changeset in webkit [98792] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

SincResampler must be able to resample progressively
​https://bugs.webkit.org/show_bug.cgi?id=71131

Reviewed by Kenneth Russell.

No new tests. There is not yet an implementation using progressive resampling to test.

  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):

  • platform/audio/SincResampler.h:
6:31 PM Changeset in webkit [98791] by adamk@chromium.org
  • 7 edits in trunk

[MutationObservers] Support attributeOldValue for attribute mutations
​https://bugs.webkit.org/show_bug.cgi?id=70861

Reviewed by Ryosuke Niwa.

Source/WebCore:

Respect 'attributeOldValue' when passed to WebKitMutationObserver.observe().

If multiple observers have different attributeOldValue settings in
their registrations, two different MutationRecords are created (one is
a wrapper around the other).

If a single observer has multiple registrations that apply to a single
mutation, and those registrations have different values for
attributeOldValue, the observer is passed the oldValue.

  • dom/Element.cpp:

(WebCore::hasOldValue):
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):

  • dom/MutationRecord.cpp:

(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createWithNullOldValue):

  • dom/MutationRecord.h:

(WebCore::MutationRecord::oldValue):

LayoutTests:

Added test cases for attributeOldValue to existing tests.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
6:14 PM Changeset in webkit [98790] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Delete ExceptionCode.cpp, which is empty
​https://bugs.webkit.org/show_bug.cgi?id=71159

Reviewed by Eric Seidel.

This file has been stripped down to nothing and can be removed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ExceptionCode.cpp: Removed.
5:51 PM Changeset in webkit [98789] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r98776.
​http://trac.webkit.org/changeset/98776
​https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):

  • compositing/visibility/animation-visibility-expected.png: Removed.
  • compositing/visibility/animation-visibility-expected.txt: Removed.
  • compositing/visibility/animation-visibility.html: Removed.
5:32 PM Changeset in webkit [98788] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

Improvement to the fix for:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Dan Bernstein.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Do the frame->settings() check after the !page check, since
a null page means null settings.

5:30 PM Changeset in webkit [98787] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Make DOMURL a ContextDestructionObserver
​https://bugs.webkit.org/show_bug.cgi?id=71162

Reviewed by Eric Seidel.

This removes a bunch of hand-rolled ifdefed code.

  • dom/ActiveDOMObject.h:
    • One-argument constructors should be explicit.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):

  • html/DOMURL.h:
5:10 PM Changeset in webkit [98786] by dino@apple.com
  • 1 edit
    1 delete in trunk/Websites/webkit.org

Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

  • specs/MediaQueriesExtensions.html: Removed.
5:03 PM Changeset in webkit [98785] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkit.py gdb visualizer is broken after change to StringImpl
​https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

  • gdb/webkit.py:
4:57 PM Changeset in webkit [98784] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Factor ContextDestructionObserver out of ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp. (As an example, see DOMURL.)

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(WebCore::ContextDestructionObserver::scriptExecutionContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):

  • dom/ScriptExecutionContext.h:
4:51 PM Changeset in webkit [98783] by Joseph Pecoraro
  • 2 edits in trunk/Tools

<​http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

  • Scripts/check-for-inappropriate-objc-class-names:
4:44 PM Changeset in webkit [98782] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

Add support for sending scroll-update events from EventSender.
​https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests:

  • fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • fast/events/touch/gesture/gesture-scroll.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
  • platform/qt/Skipped:
4:35 PM Changeset in webkit [98781] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

4:31 PM Changeset in webkit [98780] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
​https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

4:31 PM Changeset in webkit [98779] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

One more unreviewed build fix due to r98775.

No new tests.

  • WebCore.vcproj/WebCore.vcproj:
4:30 PM Changeset in webkit [98778] by jamesr@google.com
  • 11 edits in trunk/Source

[chromium] Track wheel event handler registration and pass to input filter
​https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):

  • platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
4:27 PM Changeset in webkit [98777] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Unreviewed build fix due to r98775.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
4:18 PM Changeset in webkit [98776] by Simon Fraser
  • 6 edits
    3 adds in trunk

If visibility changes while an accelerated animation is running, element jumps around
​https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

  • animations/resources/animation-test-helpers.js: Add some constants for readability.

(checkExpectedValue): Add support for testing 'visibility'.

  • compositing/visibility/animation-visibility-expected.png: Added.
  • compositing/visibility/animation-visibility-expected.txt: Added.
  • compositing/visibility/animation-visibility.html: Added.
4:08 PM Changeset in webkit [98775] by timothy_horton@apple.com
  • 5 edits
    4 adds in trunk

Implement CSS3 Images cross-fade() image function
​https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCrossfadeValue.cpp: Added.

(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):

  • css/CSSCrossfadeValue.h: Added.

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):

  • css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-cross-fade.html: Added.
4:06 PM Changeset in webkit [98774] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix after r98765.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph):

3:55 PM Changeset in webkit [98773] by cmarrin@apple.com
  • 10 edits in trunk

CSS grammar doesn't support functions with no parameters
​https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:

(testFilterRule):

3:35 PM Changeset in webkit [98772] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

Fixing fast/flexbox/flex-hang. Had used an int instead of a LayoutUnit.

3:34 PM Changeset in webkit [98771] by johnnyg@google.com
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r98757.
​http://trac.webkit.org/changeset/98757
​https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

3:21 PM Changeset in webkit [98770] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

3:07 PM Changeset in webkit [98769] by sullivan@apple.com
  • 15 edits in trunk/Source

Source/WebCore: WebCore part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

  • page/Settings.h:

Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • WebView/WebFrameView.mm:

(-[WebFrameView keyDown:]):
Honor the new preference.

  • WebView/WebPreferenceKeysPrivate.h:

Added #define for WebKitBackspaceKeyNavigationEnabledKey

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

  • WebView/WebPreferencesPrivate.h:

Declared new methods.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
​https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

  • Shared/WebPreferencesStore.h:

Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

  • UIProcess/API/C/WKPreferences.h:

Declared API functions for new preference.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

2:55 PM Changeset in webkit [98768] by johnnyg@google.com
  • 5 edits
    5 adds
    9 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf: Removed.
  • platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-gpu-mac/compositing/visibility: Added.
  • platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/visibility: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom: Removed.
  • platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [98767] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Overridden clippedOverflowRectForRepaint() still uses IntRects
​https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):

  • rendering/RenderText.h:
2:46 PM Changeset in webkit [98766] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused parsers for 'exception' and 'alias' IDL keywords
​https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
2:41 PM Changeset in webkit [98765] by mitz@apple.com
  • 4 edits in trunk

<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

  • platform/mac/fast/css/font-family-pictograph-expected.txt:
2:30 PM Changeset in webkit [98764] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused default constructor
​https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

  • dom/make_exception_code_description.pl:

(generateHeader):

2:28 PM Changeset in webkit [98763] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when splitting inline flows with generated floats
​https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

  • fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
  • fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added
2:26 PM Changeset in webkit [98762] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Remove Leopard-only code from GraphicsLayerCA
​https://bugs.webkit.org/show_bug.cgi?id=71141

Reviewed by Chris Marrin.

Remove !HAVE_MODERN_QUARTZCORE code, which was only
used on Leopard. updateContentsTransform() became a no-op,
so could be removed.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:
2:17 PM Changeset in webkit [98761] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.6

New tag.

2:10 PM Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Added one more adjective to the list of good properties for a test (diff)
2:00 PM Changeset in webkit [98760] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Rollout 98610.

1:51 PM Changeset in webkit [98759] by timothy@apple.com
  • 12 edits in trunk/Source/WebKit2

Support using a different front-end for the Web Inspector in WebKit2.

rdar://problem/10318665
​https://webkit.org/b/71089

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Added webInspectorBasePath and webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetOverrideWebInspectorBaseDirectory): Added. Calls through to WebContext.
(WKContextSetOverrideWebInspectorPagePath): Ditto.
(WKContextSetOverrideWebInspectorLocalizedStringsPath): Ditto.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Set webInspectorBasePath and webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebKit::WebContext::overrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::setOverrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::overrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorLocalizedStringsPath): Added.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL): Use WebContext::overrideWebInspectorPagePath if set.
(WebKit::WebInspectorProxy::inspectorBaseURL): Use WebContext::overrideWebInspectorBaseDirectory if set.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::globalInspectorLocalizedStringsURL): Added. Static storage for the setting.
(WebKit::WebInspector::setLocalizedStringsPath): Added. Set globalInspectorLocalizedStringsURL.
(WebKit::WebInspector::localizedStringsURL): Return globalInspectorLocalizedStringsURL.

  • WebProcess/com.apple.WebProcess.sb: Added read-only subpath for WEBKIT_WEB_INSPECTOR_DIR.
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadonlySandboxDirectory): Check path for empty to prevent an exception when
calling through to fileSystemRepresentation.
(WebKit::initializeSandbox): Added WEBKIT_WEB_INSPECTOR_DIR parameter.
(WebKit::WebProcess::platformInitializeWebProcess): Call WebInspector::setLocalizedStringsPath.

1:46 PM Changeset in webkit [98758] by eric@webkit.org
  • 3 edits in trunk/Tools

NRWT crashes when parsing leaks output due to UTF-8 decoding error
​https://bugs.webkit.org/show_bug.cgi?id=71112

Reviewed by Adam Barth.

Use read_binary_file instead of read_text_file and add a test
case with some non-utf8 data to make sure we don't break this in the future.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:
  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1:44 PM Changeset in webkit [98757] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Implicitly skip render surfaces that won't be drawn
​https://bugs.webkit.org/show_bug.cgi?id=71038

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

1:27 PM Changeset in webkit [98756] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Clean up BuiltInPDFView a little
​https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):

Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

Moved to a correct location. This is not a Plugin method, but a ScrollView one.

1:20 PM Changeset in webkit [98755] by abarth@webkit.org
  • 15 edits in trunk/Source/WebCore

Autogenerate Exception-downcast code in bindings
​https://bugs.webkit.org/show_bug.cgi?id=71108

Reviewed by Eric Seidel.

This patch uses the same generated code style as we're using for Events
to generate the downcasts for the Exception types in the bindings.
This cause me to refactor more code from make_event_factory.pl into
InFilesCompiler.pm.

After this patch, some of these files and scripts are misnamed. I'll
rename them in a followup patch.

  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/InFilesCompiler.pm:

(initializeFromCommandLine):
(compile):
(interfaceForItem):
(toMacroStyle):
(generateInterfacesHeader):
(generateHeadersHeader):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCodeDescription.in:
  • dom/make_event_factory.pl:

(generateCode):
(generateImplementation):

  • dom/make_exception_code_description.pl:

(defaultItemFactory):
(generateCode):

1:10 PM Changeset in webkit [98754] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Build fixes for Chromium-Mac.

12:58 PM Changeset in webkit [98753] by levin@chromium.org
  • 4 edits in trunk/Tools

watchlist should not CC the bug reporter
​https://bugs.webkit.org/show_bug.cgi?id=71079

Reviewed by Adam Barth.

Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.

  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
  • Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
  • Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
12:42 PM Changeset in webkit [98752] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix builds which have ACCELERATED_COMPOSITING disabled.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists):

12:36 PM Changeset in webkit [98751] by johnnyg@google.com
  • 16 edits
    11 adds
    13 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-cg-mac-leopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-cg-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/002-expected.txt: Removed.
  • platform/chromium-win-vista/svg/batik/text: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium/fast/js/array-prototype-properties-expected.txt: Replaced.
  • platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:29 PM Changeset in webkit [98750] by arv@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from inspector IDLs
​https://bugs.webkit.org/show_bug.cgi?id=65748

Reviewed by Adam Barth.

Covered by existing tests.

  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
12:22 PM Changeset in webkit [98749] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

IndexedDB: Database metadata changes should be tied to transaction
​https://bugs.webkit.org/show_bug.cgi?id=70974

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

Source/WebCore:

Database metadata (that is, the version string) was rolled back
on abort by an abort task. If the abort task didn't run e.g.
due to a crash, the metadata would not be reverted. All of the
other store/index/data changes were written into the transaction
itself, so the metadata now is too. Refactored the metadata
get/create/update methods for clarity as well.

Note that the new tests don't actually verify that the code handles
this case; that will need to be done with persistence tests
that span multiple runs of the browser and induce crashes.
The new tests do verify that these changes don't cause regressions
not caught by other tests.

Tests: storage/indexeddb/open-during-transaction.html

storage/indexeddb/version-change-abort.html

  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):

  • storage/IDBLevelDBBackingStore.h:

LayoutTests:

  • storage/indexeddb/open-during-transaction-expected.txt: Added.
  • storage/indexeddb/open-during-transaction.html: Added.
  • storage/indexeddb/version-change-abort-expected.txt: Added.
  • storage/indexeddb/version-change-abort.html: Added.
12:15 PM Changeset in webkit [98748] by macpherson@chromium.org
  • 8 edits in trunk/Source/WebCore

Use enum instead of bool to represent -webkit-column-span property.
​https://bugs.webkit.org/show_bug.cgi?id=70867

Reviewed by Darin Adler.

Covered by existing tests.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleMultiColData.h:
12:08 PM Changeset in webkit [98747] by mhahnenberg@apple.com
  • 18 edits in trunk/Source

De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
​https://bugs.webkit.org/show_bug.cgi?id=70968

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their

TypeInfo. Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):

  • API/JSCallbackObject.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.

(JSC::ErrorInstance::createStructure):

  • runtime/ErrorPrototype.h: Ditto

(JSC::ErrorPrototype::createStructure):

  • runtime/JSActivation.h: Ditto

(JSC::JSActivation::createStructure):

  • runtime/JSGlobalObject.h: Ditto

(JSC::JSGlobalObject::createStructure):

  • runtime/JSObject.h: De-virtualized functions. They now check the JSType of the object for the corresponding type.

(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):

  • runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
  • runtime/JSVariableObject.cpp: Removed virtual function.
  • runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.

(JSC::JSVariableObject::createStructure):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo in createStructure since this

class inherits from JSGlobalObject.
(WebCore::JSDOMGlobalObject::createStructure):

  • bindings/js/JSDOMWindowBase.h: Ditto

(WebCore::JSDOMWindowBase::createStructure):

  • bindings/js/JSWorkerContextBase.h: Ditto

(WebCore::JSWorkerContextBase::createStructure):

  • bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure subclasses of JSGlobalObject,

namely JSDOMWindow and JSWorkerContext, get their special JSType in their createStructure function.
(GenerateHeader):

11:57 AM Changeset in webkit [98746] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

Added some missing results for compositing visibilty tests.

  • platform/mac/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/mac/compositing/visibility/visibility-image-layers-expected.txt: Added.
11:43 AM Changeset in webkit [98745] by commit-queue@webkit.org
  • 7 edits
    6 deletes in trunk

Unreviewed, rolling out r98736.
​http://trac.webkit.org/changeset/98736
​https://bugs.webkit.org/show_bug.cgi?id=71125

This patch broke perf/array-binary-search.html test (Requested
by annacc on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::addTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Removed.
  • media/track/track-load-error-readyState.html: Removed.
  • media/track/track-load-from-element-readyState-expected.txt: Removed.
  • media/track/track-load-from-element-readyState.html: Removed.
  • media/track/track-load-from-src-readyState-expected.txt: Removed.
  • media/track/track-load-from-src-readyState.html: Removed.
11:40 AM Changeset in webkit [98744] by zherczeg@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Testing allowed identifier chars which are greater than 126
​https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

  • fast/css/parsing-css-nonascii-expected.txt: Added.
  • fast/css/parsing-css-nonascii.html: Added.
11:29 AM Changeset in webkit [98743] by inferno@chromium.org
  • 6 edits
    3 copies in branches/chromium/874/LayoutTests/fast/table

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: ​http://codereview.chromium.org/8416045

11:28 AM Changeset in webkit [98742] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PluginView.cpp

Fix PluginView rect calculation

11:28 AM Changeset in webkit [98741] by inferno@chromium.org
  • 6 edits
    3 copies in branches/chromium/912/LayoutTests/fast/table

Merge 98411 - Made Table tests for Bug 70678 Platform Independent
BUG=101540
Review URL: ​http://codereview.chromium.org/8343064

11:25 AM Changeset in webkit [98740] by inferno@chromium.org
  • 3 edits
    6 copies in branches/chromium/912

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: ​http://codereview.chromium.org/8417039

11:23 AM Changeset in webkit [98739] by inferno@chromium.org
  • 3 edits
    6 copies in branches/chromium/874

Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure
BUG=101540
Review URL: ​http://codereview.chromium.org/8343063

11:06 AM WinCE edited by patricke@bsquare.com
(diff)
11:04 AM Changeset in webkit [98738] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderTableSection::recalcCells should not free its grid
​https://bugs.webkit.org/show_bug.cgi?id=71056

Reviewed by Darin Adler.

Refactoring only, no change in behavior.

r98614 had the bad side effect of clearing the row vector (m_grid) on
the RenderTableSection when doing a recalcCells. This change removes the
unneeded free and inline the |row| field into the RowStruct as it made
no sense to have it as a pointer.

  • rendering/RenderTableSection.cpp:

(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Mechanical changes now that |row| is a member of RowStruct.

(WebCore::RenderTableSection::~RenderTableSection): Clear our row vector.

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::recalcCells):
Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPosition.

(WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
Factored the code to fill the RowStruct structure with default values.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
More mechanical change after the |row| field change.

11:00 AM Changeset in webkit [98737] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Unskip tables/mozilla_expected_failures/bugs/bug14007-2.html
since the test was rebaselined in r98691.

Also enable platform/mac/editing/deleting/backward-delete.html on Chromium Mac
and skip it again on Chromium Windows and Linux.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:54 AM Changeset in webkit [98736] by annacc@chromium.org
  • 7 edits
    6 adds in trunk

Implement load notification and events for <track>.
​https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html

media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::loadNextTextTrack):
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):

  • html/HTMLMediaElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt: Added.
  • media/track/track-load-error-readyState.html: Added.
  • media/track/track-load-from-element-readyState-expected.txt: Added.
  • media/track/track-load-from-element-readyState.html: Added.
  • media/track/track-load-from-src-readyState-expected.txt: Added.
  • media/track/track-load-from-src-readyState.html: Added.
10:46 AM Changeset in webkit [98735] by Simon Fraser
  • 10 edits
    8 adds in trunk

Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
​https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html

compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.

  • platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,

added ContentsVisibilityChanged flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.

  • rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
​https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

  • compositing/visibility/visibility-composited-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms-expected.png: Added.
  • compositing/visibility/visibility-composited-transforms.html: Added.
  • compositing/visibility/visibility-composited.html: Added.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • compositing/visibility/visibility-image-layers-dynamic.html: Added.
  • compositing/visibility/visibility-image-layers-expected.png: Added.
  • compositing/visibility/visibility-image-layers.html: Added.
10:42 AM Changeset in webkit [98734] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/WebCore.gyp/WebCore.gyp

Adding Mac fixed classes to chromium gypi.

10:35 AM Changeset in webkit [98733] by arv@chromium.org
  • 190 edits
    1 delete in trunk/LayoutTests

JS Test Harness: Remove js-test-post-function.js
​https://bugs.webkit.org/show_bug.cgi?id=70959

Reviewed by Ojan Vafai.

This moves isSuccessfullyParsed to js-test-pre.js and removes js-test-post-function.js and all references to it.

  • fast/js/resources/js-test-post-function.js: Removed.
  • fast/js/resources/js-test-pre.js:

(isSuccessfullyParsed): Moved here from js-test-post-function.js

9:58 AM Changeset in webkit [98732] by Nate Chapin
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

empty-urls.html needs to stop being flaky.
Because it was in http/tests/loading, it output
frame load callbacks, and it was unpredictable whether
the callback for onload or for the load completing would
be called first. Ergo, move the test to http/tests/misc,
and remove the logic which failed to enforce a frame load
callback ordering.
​https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

  • http/tests/loading/empty-urls-expected.txt: Removed.
  • http/tests/loading/empty-urls.html: Removed.
  • http/tests/misc/empty-urls-expected.txt: Copied from LayoutTests/http/tests/loading/empty-urls-expected.txt.
  • http/tests/misc/empty-urls.html: Copied from LayoutTests/http/tests/loading/empty-urls.html.
  • platform/chromium/test_expectations.txt:
9:50 AM WebKitGTK/1.6.x edited by plaes@plaes.org
Added .xz tarball creation patch (diff)
9:47 AM Changeset in webkit [98731] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Build fixes for glib 2.31 (current master)
​https://bugs.webkit.org/show_bug.cgi?id=70679

Reviewed by Martin Robinson.

g_cond_new and g_mutex_new have been replaced by _init
functions. Same for _free, replaced by _clear.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkit_video_sink_dispose):

9:29 AM Changeset in webkit [98730] by jochen@chromium.org
  • 34 edits in trunk/Source

Rename a number of methods mentioning JavaScript to just Script instead
​https://bugs.webkit.org/show_bug.cgi?id=71105

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScript):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setScriptEnabled):

  • page/Settings.h:

(WebCore::Settings::isScriptEnabled):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScript):

  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::collectGarbage):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setJavaScriptEnabled):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_enable_scripts_set):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::WebView):

Source/WebKit/wx:

  • WebSettings.cpp:

(wxWebSettings::SetJavaScriptEnabled):
(wxWebSettings::IsJavaScriptEnabled):

  • WebView.cpp:

(wxWebView::Create):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

9:22 AM Changeset in webkit [98729] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Remove fast/replaced/table-percent-height.html that has been passing for at least
a week. Also tighten some tests that have not been passing (but occasionally timing
out) on the flakyness dashboard for some time.

8:22 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
8:17 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
7:57 AM Changeset in webkit [98728] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html.

  • platform/mac/Skipped:
7:52 AM Changeset in webkit [98727] by zoltan@webkit.org
  • 2 edits in trunk/Tools

Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
​https://bugs.webkit.org/show_bug.cgi?id=71116

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
7:42 AM Changeset in webkit [98726] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
6:59 AM Changeset in webkit [98725] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

REGRESSION: 5 editing tests fail
​https://bugs.webkit.org/show_bug.cgi?id=71117

  • platform/qt-wk2/Skipped: Skip failing tests.
6:27 AM Changeset in webkit [98724] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

Reset line numbers for scripts generated with document.write.
​https://bugs.webkit.org/show_bug.cgi?id=71099

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

  • wtf/text/TextPosition.h:

(WTF::OrdinalNumber::OrdinalNumber):

Source/WebCore:

Test: http/tests/inspector-enabled/document-write.html

  • dom/Document.h:

(WebCore::Document::isInDocumentWrite):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

LayoutTests:

  • http/tests/inspector-enabled/document-write-expected.txt: Added.
  • http/tests/inspector-enabled/document-write.html: Added.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt:
6:10 AM Changeset in webkit [98723] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-10-28 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Unsupress css3/font-feature-settings-rendering.html as it should
pass on Linux after r98716.

  • platform/chromium/test_expectations.txt:
6:06 AM Changeset in webkit [98722] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
​https://bugs.webkit.org/show_bug.cgi?id=70494

One more buildfix. (unreviewed)

  • UIProcess/API/qt/qtouchwebpage.cpp:

(computeEffectiveOpacity):
(QTouchWebPage::itemChange):

6:06 AM Changeset in webkit [98721] by Csaba Osztrogonác
  • 26 edits in trunk

[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
​https://bugs.webkit.org/show_bug.cgi?id=70494

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2011-10-28
Reviewed by Kenneth Christiansen.

Use QQuick* instead of QSG* as well as QStandardPaths
instead of QDesktopLocation.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Source/WebKit2:

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::event):
(QDesktopWebViewPrivate::engine):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
(QTouchWebView::touchEvent):

  • UIProcess/API/qt/qtouchwebview.h:
  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):
(TestWindow::resizeEvent):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::createPopupMenuProxy):

  • UIProcess/qt/QtSGUpdateQueue.cpp:

(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):

  • UIProcess/qt/QtSGUpdateQueue.h:
  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::engine):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDataLocation):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:

(WebKit::WebPopupMenuProxyQtDesktop::create):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::setDiskCache):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

5:37 AM Changeset in webkit [98720] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Mac build fix after r98711

  • WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can

find it.

5:28 AM Changeset in webkit [98719] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Tools

[Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=71106

Reviewed by Simon Hausmann.

Holding Ctrl allows multiple touch points to be held on the screen using
mouse buttons. It would previously only prevent TouchReleased to be sent
and would require another MouseButtonRelease to be sent without holding Ctrl.

This patch makes sure that all held touch points are released when Ctrl
is released if MouseButtonRelease was received.
It also removes the touch QEvent::Type logic since it's currently handled
by QtGui by observing the modified touch points.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:
5:20 AM Changeset in webkit [98718] by kenneth@webkit.org
  • 4 edits in trunk/Tools

[Qt] MiniBrowser needs a -window-size option
​https://bugs.webkit.org/show_bug.cgi?id=70999

Reviewed by Simon Hausmann.

Add an -window-size option useful for testing the viewport handling.
Also clean up the option handling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setRequestedWindowSize):
(WindowOptions::requestedWindowSize):

  • MiniBrowser/qt/utils.cpp:

(takeOptionValue):

  • MiniBrowser/qt/utils.h:
5:18 AM Changeset in webkit [98717] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make the kinetic engine use the same curve and constants as on the N9
​https://bugs.webkit.org/show_bug.cgi?id=71102

Reviewed by Simon Hausmann.

Now that we are using the QScroller for kinetic scrolling and page
interaction, we need to make sure it uses the same curve (exponential)
and the same values as the MeeGo Touch physics engine used on the N9.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):

4:47 AM Changeset in webkit [98716] by Antti Koivisto
  • 3 edits
    2 adds in trunk

[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
​https://bugs.webkit.org/show_bug.cgi?id=71019

Source/WebCore:

Reviewed by Andreas Kling.

These properties need to be marked inherited too.

Note that the new test case doesn't fail even without the patch. If I understand correctly
the image test in the title is pretty much the only way to see this. However the
new test improves code coverage and protects against future regressions.

Test: fast/css/inherited-properties-rare-text.html

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/inherited-properties-rare-text-expected.txt: Added.
  • fast/css/inherited-properties-rare-text.html: Added.
2:52 AM Changeset in webkit [98715] by abarth@webkit.org
  • 12 edits in trunk/Source

Remove getExceptionCodeDescription()
​https://bugs.webkit.org/show_bug.cgi?id=71103

Reviewed by Eric Seidel.

Source/WebCore:

This function serves no purpose.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCode.cpp:
  • dom/ExceptionCode.h:

Source/WebKit/chromium:

Migrate to new API.

  • src/StorageInfoChromium.cpp:
  • src/WebStorageQuotaCallbacksImpl.cpp:

(WebKit::WebStorageQuotaCallbacksImpl::didFail):

2:43 AM Changeset in webkit [98714] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: CSS background-image applied inline shows a warning, but still works.
​https://bugs.webkit.org/show_bug.cgi?id=70325

Reviewed by Antti Koivisto.

Source/WebCore:

This change eliminates the "non-parsed property" warning displayed next to any
"background-image" property of an element's inline style.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeclaration):

  • css/CSSParser.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
2:36 AM Changeset in webkit [98713] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fixenate Qt.

  • CodeGenerators.pri:
  • dom/make_event_factory.pl:

(toMacroStyle):

2:27 AM Changeset in webkit [98712] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Clean-up unused functions in WebIDBFactory
​https://bugs.webkit.org/show_bug.cgi?id=71011

Reviewed by Tony Chang.

This is a clean-up after r97453. Since Chromium was updated,
these functions are no longer used.

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

2:11 AM Changeset in webkit [98711] by abarth@webkit.org
  • 18 edits
    2 adds in trunk

ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
​https://bugs.webkit.org/show_bug.cgi?id=70890

Reviewed by Eric Seidel.

.:

Add a code generation step.

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Generate the feature-specific parts of ExceptionCode.cpp from a ".in"
file. This is an incremental step towards inlining
getExceptionCodeDescription into its callers and replacing the switch
statements at those locations with autogenerated code.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/DOMCoreException.cpp:

(WebCore::DOMCoreException::initializeDescription):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • dom/ExceptionCodeDescription.in: Added.
  • dom/make_exception_code_description.pl: Added.

(defaultItemFactory):
(generateCode):
(generateHeader):
(generateImplementation):

2:09 AM Changeset in webkit [98710] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: CallStackSidebarPane should remove discarded Placards from RawSourceCode listeners list
​https://bugs.webkit.org/show_bug.cgi?id=70996

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/callstack-placards-discarded.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):

  • inspector/front-end/Placard.js:

(WebInspector.Placard.prototype.toggleSelected):
(WebInspector.Placard.prototype.discard):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt: Added.
  • inspector/debugger/callstack-placards-discarded.html: Added.
1:48 AM Changeset in webkit [98709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

  • DEPS:
1:31 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
1:16 AM Changeset in webkit [98708] by jochen@chromium.org
  • 13 edits
    3 adds in trunk

Add allowScriptFromSource callback to FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=71013

Reviewed by Darin Fisher.

Source/WebCore:

Test: platform/chromium/permissionclient/script-permissions.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowScriptFromSource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Source/WebKit/chromium:

  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowScriptFromSource):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowScriptFromSource):

  • src/FrameLoaderClientImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setScriptsAllowed):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:

(WebPermissions::allowScriptFromSource):
(WebPermissions::setScriptsAllowed):
(WebPermissions::reset):

  • DumpRenderTree/chromium/WebPermissions.h:

LayoutTests:

  • platform/chromium/permissionclient/resources/script.js: Added.
  • platform/chromium/permissionclient/script-permissions-expected.txt: Added.
  • platform/chromium/permissionclient/script-permissions.html: Added.
1:12 AM Changeset in webkit [98707] by Carlos Garcia Campos
  • 12 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=70814

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didStartProvisionalLoadForFrame): Update WebView URI to make sure
it's updated to provisional URL.
(didReceiveServerRedirectForProvisionalLoadForFrame): Update
WebView URI if there's a server redirection.
(didCommitLoadForFrame): Update WebView URI to make sure it
contains the final one.
(didSameDocumentNavigationForFrame): Update WebView URI when a
navigation action within the same document is performed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didSameDocumentNavigationForFrame callback.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add URI property.
(webkitWebViewUpdateURI): Check whether current active URI has
changed to updated it and emit ::notify signal if it changes.
(webkit_web_view_load_uri): Call webkitWebViewUpdateURI() to make
sure the active URI is updated when load operation is started.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_get_uri): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Add

webkitWebViewUpdateURI().

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(provisionalLoadStartedCallback): Check provisional URL is the
requested URI.
(provisionalLoadReceivedServerRedirectCallback): Check provisional
URL after server redirection is the expected redirected URI.
(provisionalLoadFailedCallback): Check active URI.
(loadCommittedCallback): Ditto.
(loadFinishedCallback): Ditto.
(loadFailedCallback): Ditto
(LoadTrackingTest::LoadTrackingTest): Check active URI is NULL
before any loading operation has started.

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:

(LoadTrackingTest::setRedirectURI): Set the redirect URI to check
it after a server redirection.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(testBackForwardListNavigation): Use WebViewTest methods for
navigation actions instead of using WebKitWebView API directly.
(testBackForwardListLimitAndCache): Ditto.

  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadingStatus): Ditto.
(testLoadingError): Ditto.
(testLoadAlternateContent): Ditto.
(testLoadCancelled): Ditto.
(testWebViewReload): Ditto.
(testLoadProgress): Ditto.
(testWebViewActiveURI): Add a test to check that notify signal is
emitted when active URI changes and it's correctly updated when
loader client signals are emitted.
(beforeAll): Add active-uri test.

  • UIProcess/API/gtk/tests/WebViewTest.cpp: Add custom load methods

wrapping the WebKitWebView ones, to initialize the active URI to
the requested one, so that it can be checked by the loader client
test.
(WebViewTest::loadURI):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):

  • UIProcess/API/gtk/tests/WebViewTest.h:
12:59 AM Changeset in webkit [98706] by Simon Hausmann
  • 14 edits in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=69151

Patch by No'am Rosenthal <​noam.rosenthal@nokia.com> on 2011-10-21
Reviewed by Simon Hausmann.

Make QTouchWebView always render with accelerated compositing.
At first, the web content would only render after the rest of the scene has rendered. In a
future patch we'll enable rendering the web content via an FBO, which would cover all other
cases as well.

Right now this only works for QTouchWebView, and thus accelerated compositing is disabled
for desktop web-views. This required adding some settings enablers in Q
WebPreferencesPrivate. Those are not exposed to the public API, as they are an implementation
detail.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::initSceneGraphConnections):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPage):
(computeEffectiveOpacity):
(QTouchWebPagePrivate::paintToCurrentGLContext):
(QTouchWebPagePrivate::_q_onAfterSceneRender):
(QTouchWebPagePrivate::_q_onSceneGraphInitialized):
(QTouchWebPage::itemChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::get):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::renderNextFrame):

  • UIProcess/qt/QtDesktopWebPageProxy.cpp:

(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

  • UIProcess/qt/QtTouchViewInterface.cpp:

(WebKit::QtTouchViewInterface::setViewNeedsDisplay):

  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::createDrawingAreaProxy):
(QtTouchWebPageProxy::renderToCurrentGLContext):
(QtTouchWebPageProxy::setVisibleContentRectAndScale):
(QtTouchWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtTouchWebPageProxy::renderNextFrame):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHost::supportsAcceleratedCompositing):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

12:39 AM Changeset in webkit [98705] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Chromium test expectation.

  • platform/chromium/test_expectations.txt:

Mark http/tests/websocket/tests/hybi/reserved-bits.html as flaky.

12:20 AM Changeset in webkit [98704] by abarth@webkit.org
  • 7 edits
    1 add in trunk/Source

Refactor make_event_factory.pl to use InFilesCompiler.pm
​https://bugs.webkit.org/show_bug.cgi?id=71094

Reviewed by Eric Seidel.

This refactoring helps share code with
make_exception_code_descriptions.pl, which is coming in a future patch.
I have a dream of refactoring make_names.pl to use this module as well.

  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/scripts/action_makenames.py:
  • bindings/scripts/InFilesCompiler.pm: Added.

(itemHandler):
(parameterHandler):
(new):
(compile):
(license):

  • dom/make_event_factory.pl:

(defaultItemFactory):
(interfaceForEvent):
(generateCode):
(printFactoryFile):
(printMacroFile):
(printHeadersFile):

12:19 AM Changeset in webkit [98703] by apavlov@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore/inspector/front-end

Merge 98489 - Web Inspector: Need workaround for the red crossed circle in the status bar not bringing up the console when clicked
​https://bugs.webkit.org/show_bug.cgi?id=70928

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(#error-count-img):
(#error-count + #warning-count-img):
(#warning-count-img):

  • inspector/front-end/inspector.js:

(WebInspector._updateErrorAndWarningCounts):

TBR=​apavlov@chromium.org
Review URL: ​http://codereview.chromium.org/8343053

12:18 AM Changeset in webkit [98702] by Alexandru Chiculita
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:01 AM Changeset in webkit [98701] by abarth@webkit.org
  • 3 edits in trunk/Tools

Remove WinCairo from the set of core builders. WinCairo rarely builds
and is never green.

Rubber-stamped by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
Note: See TracTimeline for information about the timeline view.