Timeline
Nov 5, 2011:
- 11:10 PM Changeset in webkit [99371] by
-
- 2 edits in trunk/LayoutTests
Skip a newly failing test and reclassify some missing DRT features.
- platform/gtk/Skipped: Update skipped list.
- 10:33 PM Changeset in webkit [99370] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Remove ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=71617
Reviewed by Ariya Hidayat.
No new tests. This patch does not change behavior.
Completely remove ContextShadow. It's unused, unmaintained, and
replaced by ShadowBlur.
- WebCore.gypi: Remove references to deleted files.
- WebCore.vcproj/WebCore.vcproj: Remove references to deleted files.
- platform/graphics/ContextShadow.cpp: Removed.
- platform/graphics/ContextShadow.h: Removed.
- platform/gtk/WidgetRenderingContext.cpp: Remove now-inaccurate TODO.
- 9:27 PM Changeset in webkit [99369] by
-
- 6 edits in trunk/Source/WebCore
Dragging a file onto <input type="file"> should give distinct visual feedback
https://bugs.webkit.org/show_bug.cgi?id=13897
<rdar://problem/5232483>
Reviewed by Dan Bernstein.
When hovering over a file input element, we set the button's state to active
to differentiate dragging one file over the input element (which populates that
element) versus over the document (which would load the file into the view).
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::canReceiveDroppedFiles):
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): If set, the element
is updated, which sets the active state on the button control.
- html/HTMLInputElement.h: Add a boolean member representing whether the file
input can receive dropped files.
- page/DragController.cpp:
(WebCore::DragController::DragController): Update/set the file input that
can receive dropped files.
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
- page/DragController.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement): Sets the button active
state if the input can receive dropped files.
- 9:14 PM Changeset in webkit [99368] by
-
- 6 edits in trunk
[chromium] Use the security origin instead of the URL when checking notification permissions
https://bugs.webkit.org/show_bug.cgi?id=71590
Reviewed by Adam Barth.
Source/WebKit/chromium:
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::checkPermission):
Tools:
- DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::checkPermission):
- DumpRenderTree/chromium/NotificationPresenter.h:
- 7:26 PM Changeset in webkit [99367] by
-
- 2 edits in trunk/Source/WebCore
Improve pending resource hash table code, including fixing a memory leak
https://bugs.webkit.org/show_bug.cgi?id=71616
Reviewed by Adam Roben.
Memory leak fix and refactoring covered by existing tests.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource): Replace the combination
of contains, get, and add with just add, removing an extra unneeded hash table
lookup each time this function is called.
(WebCore::SVGDocumentExtensions::isElementInPendingResources): Added a comment
about the performance of this function. Removed unnecessary check for an empty
map; the code already efficiently exits doing nothing without the check.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): Removed
unnecessary check for an empty map; the code already efficiently does nothing
without the check. Use removePendingResource rather than calling remove to
avoid leaking the SVGPendingElements set.
(WebCore::SVGDocumentExtensions::removePendingResource): Replace the
combination of get and remove with a call to take, removing an extra
unneeded hash table lookup each time this function is called
- 6:07 PM Changeset in webkit [99366] by
-
- 2 edits in trunk/Tools
Fix a small leak in Mac version of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=71615
Reviewed by Mark Rowe.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
(LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
- 5:56 PM Changeset in webkit [99365] by
-
- 2 edits in trunk/LayoutTests
Unskip some tests on GTK+ that seem to be passing.
- platform/gtk/Skipped: Unskip tests.
- 5:50 PM Changeset in webkit [99364] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Actually use the user_data arguments to gio async functions
instead of using g_object_set_data() to basically reinvent them.
https://bugs.webkit.org/show_bug.cgi?id=71614
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startNonHTTPRequest):
- 5:39 PM Changeset in webkit [99363] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Don't unnecessarily 0-initialize read buffers.
https://bugs.webkit.org/show_bug.cgi?id=71612
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
- 5:37 PM Changeset in webkit [99362] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove a bit of dead code
https://bugs.webkit.org/show_bug.cgi?id=71613
Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.
No new tests; behavior is unchanged
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::readCallback): the caller that needed the convertToUTF16
code was removed in r77408, but the code was accidentally left
behind.
- 5:34 PM Changeset in webkit [99361] by
-
- 20 edits in trunk/LayoutTests
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576
Reviewed by Antonio Gomes.
Instead of waiting until <body onload> to toggle the frame flattening
setting. Toggle is as soon as possible. This fixes an issue where
layouts that happen before the onload event lead to flaky results.
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-simple.html:
- fast/frames/flattening/frameset-flattening-subframe-resize.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- platform/gtk/Skipped: Unskip tests which are no longer flaky.
- 4:45 PM Changeset in webkit [99360] by
-
- 2 edits in trunk/LayoutTests
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-05
Reviewed by Martin Robinson.
Skip frame flattening tests. These became flaky after backing store for
painting was introduced for the GTK port in r98827.
- platform/gtk/Skipped:
- 2:55 PM Changeset in webkit [99359] by
-
- 5 edits in trunk/Source/WebCore
Refactor sandbox flag calculation to make implementing CSP sandbox directive easier
https://bugs.webkit.org/show_bug.cgi?id=71603
Reviewed by Sam Weinig.
This patch changes the way we compute sandbox bits. Instead of caching
the result on Frame, we always compute the sandbox bits for a new
document fresh from the inputs to the process (the sandbox attribute
and the forced sandbox flags).
This patch is just refactoring. It shouldn't have an observable
effects. This patch makes it easier to implement CSP's sandbox
directive in a subsequent patch.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setSandboxFlags):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::effectiveSandboxFlags):
(WebCore::createWindow):
- loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
- 1:37 PM Changeset in webkit [99358] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:29 PM Changeset in webkit [99357] by
-
- 6 edits in trunk/Source/JavaScriptCore
Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597
Reviewed by Adam Roben.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Remove exports of removed functions.
- runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.
- runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
- runtime/JSObject.h:
Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.
- 11:16 AM Changeset in webkit [99356] by
-
- 2 edits in trunk/LayoutTests
Unskip a test on GTK+ that doesn't seem to be failing on the bots
or locally.
- platform/gtk/Skipped: Unskip a test.
- 9:28 AM Changeset in webkit [99355] by
-
- 5 edits in trunk/Source/WebCore
CSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=71609
Reviewed by Anders Carlsson.
Add a bool member to CSSStyleDeclaration that determines whether
it's a CSSMutableDeclaration.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
- css/CSSMutableStyleDeclaration.h:
- css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
- css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::isMutableStyleDeclaration):
- 9:25 AM Changeset in webkit [99354] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
https://bugs.webkit.org/show_bug.cgi?id=71608
Reviewed by Pavel Feldman.
Use CSSMutableStyleDeclaration::isInlineStyleDeclaration() instead
of doing the same checks manually.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::inlineStyleElement):
- 7:50 AM Changeset in webkit [99353] by
-
- 2 edits1 delete in trunk/Source/WebCore
Reviewed by Andreas Kling.
Removed duplicated npruntime_internal.h from bindings/v8
in favour of the one from bridge/, which has a few more
https://bugs.webkit.org/show_bug.cgi?id=45617
- bindings/v8/npruntime_internal.h: Removed.
- Target.pri: Removed strange occurence here.
- 5:15 AM Changeset in webkit [99352] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove empty and unused dom/PositionCreationFunctions.h header file
https://bugs.webkit.org/show_bug.cgi?id=71552
Reviewed by Kenneth Rohde Christiansen.
The file is empty (0 bytes) and not used anywhere. It was added in
2009 in r48234 but hasn't been touched since then.
- WebCore.gypi:
- dom/PositionCreationFunctions.h: Removed.
- 12:00 AM Changeset in webkit [99351] by
-
- 2 edits in trunk/Source/WebCore
Fix assert after running tests in dumpAsText folders. See
https://bugs.webkit.org/show_bug.cgi?id=71599 for discussion. This
patch reverts part of a slightly over-agressive refactoring in
http://trac.webkit.org/changeset/99347.
- dom/Document.cpp:
(WebCore::Document::setIsViewSource):
Nov 4, 2011:
- 10:50 PM Changeset in webkit [99350] by
-
- 2 edits in trunk/LayoutTests
Update a timing out gpu test.
- platform/chromium/test_expectations.txt:
- 6:59 PM Changeset in webkit [99349] by
-
- 5 edits3 adds in trunk
Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=71537
Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Stephen White.
Source/WebCore:
drawImage(canvas) now uses the same approach as drawImage(image) to fix these errors.
Test: fast/canvas/canvas-composite-canvas.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
- html/canvas/CanvasRenderingContext2D.h:
LayoutTests:
- fast/canvas/canvas-composite-canvas-expected.txt: Added.
- fast/canvas/canvas-composite-canvas.html: Added.
- fast/canvas/canvas-composite-image.html:
- fast/canvas/resources/canvas-composite-image-common.js: Added.
- 6:35 PM Changeset in webkit [99348] by
-
- 1 edit2 copies in branches/chromium/874
Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8478022
- 6:32 PM Changeset in webkit [99347] by
-
- 16 edits in trunk
JavaScript URLs execute in sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=71599
Reviewed by Eric Seidel.
Source/WebCore:
This patch fixes the intentional regression I introduced earlier today
by moving the sandbox bits from SecurityOrigin to Document. In the
process, I renamed SecurityOrigin::createEmpty to
SecurityOrigin::createUnique to better align with HTML5 terminology.
- WebCore.exp.in:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- dom/Document.cpp:
(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::sandboxFlags):
(WebCore::ScriptExecutionContext::enforceSandboxFlags):
(WebCore::ScriptExecutionContext::isSandboxed):
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::canEmbedJava):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
- loader/FrameLoader.cpp:
(WebCore::isDocumentSandboxed):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
- page/SecurityOrigin.h:
LayoutTests:
Update results to show progression.
- fast/frames/sandboxed-iframe-scripting-expected.txt:
- fast/frames/sandboxed-iframe-scripting.html:
- 6:30 PM Changeset in webkit [99346] by
-
- 1 edit2 copies in branches/chromium/874
Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8480023
- 6:26 PM Changeset in webkit [99345] by
-
- 5 edits5 copies in branches/chromium/874
Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8477022
- 6:26 PM Changeset in webkit [99344] by
-
- 2 edits in trunk/Source/WebCore
Potential Unused Param Build Issue
https://bugs.webkit.org/show_bug.cgi?id=71598
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-04
Reviewed by Kent Tamura.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
- 6:20 PM Changeset in webkit [99343] by
-
- 2 edits2 copies in branches/chromium/874
Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8474016
- 6:00 PM Changeset in webkit [99342] by
-
- 1 edit2 copies in branches/chromium/874
Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8479023
- 5:58 PM Changeset in webkit [99341] by
-
- 2 edits in trunk/Tools
Upgrade to the latest Mechanize
https://bugs.webkit.org/show_bug.cgi?id=71594
Reviewed by Adam Barth.
I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
Mechanize is no longer two separate libraries, so importing it is much simpler.
- Scripts/webkitpy/thirdparty/init.py:
- 5:58 PM Changeset in webkit [99340] by
-
- 1 edit in branches/chromium/874/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
Merge 98796
BUG=102242
Review URL: http://codereview.chromium.org/8479022
- 5:51 PM Changeset in webkit [99339] by
-
- 8 edits23 adds in trunk
Crash in ScrollAnimator.cpp
https://bugs.webkit.org/show_bug.cgi?id=69865
The code in ScrollAnimator assumes that horizontal per-page mouse
wheel events cannot happen, which is not true. This patch adds layout
tests for all paging wheel event situations and fixes the broken
horizontal case.
Source/WebCore:
Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson
Tests: fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html
fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-x-in-scrolling-div.html
fast/events/platform-wheelevent-paging-x-in-scrolling-page.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html
fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html
fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-scrolling-page.html
- platform/PlatformWheelEvent.h: Modify the comment to reflect the new
reality.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent): Modified the code to handle the
horizontal per-page wheel event case.
Tools:
Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::handleMouseWheel): Added the ability to specify that a
mouse wheel event should be paging.
LayoutTests:
Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson
- fast/events/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html: Added.
- fast/events/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt: Added.
- fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html: Added.
- fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-paging-x-in-scrolling-div.html: Added.
- fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
- fast/events/platform-wheelevent-paging-x-in-scrolling-page.html: Added.
- fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html: Added.
- fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
- fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html: Added.
- fast/events/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html: Added.
- fast/events/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt: Added.
- fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html: Added.
- fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-paging-y-in-scrolling-div.html: Added.
- fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
- fast/events/platform-wheelevent-paging-y-in-scrolling-page.html: Added.
- platform/chromium-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
- platform/chromium-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
- platform/chromium-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
- platform/mac/Skipped: Added skip for the new tests, as the platform
does not support it.
- platform/win/Skipped: Added skip for the new tests, as the platform
does not support it.
- 5:44 PM Changeset in webkit [99338] by
-
- 14 edits1 copy1 add in trunk/Source/WebCore
[MutationObservers] Refactor MutationObserverRegistration into its own class that is
referenced by registration points
https://bugs.webkit.org/show_bug.cgi?id=71577
Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-04
Reviewed by Ojan Vafai.
MutationObserverRegistration is now owned by the node which is observed. If transient
registrations are created, they hold a reference to this object.
The ownership relationship between Node, MutationObserverRegistration &
WebKitMutationObserver now goes like this: WebKitMutationObserver is RefCounted -
and only script and MutationObserverRegistration take references to it. Exactly
one MutationObserverRegistration can exist for any given tuple of
<Node, WebKitMutationObserver>. This represents an observer observing at a given
Node. Further observation by the same observer has the effect of *resetting*
the existing observation. The Node owns the MutationObserverRegistration.
Transient registrations are only pointers to the registration. The registration
keeps a RefPtr to its registration node and all of its transient registration nodes
as long as *any* transient registrations exist. This ensures the registration
and all registration nodes stay alive at least until the end of the microtask.
No tests required - refactor only.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/CharacterData.cpp:
(WebCore::enqueueCharacterDataMutationRecord):
- dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
- dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
- dom/MutationObserverRegistration.cpp: Added.
(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::~MutationObserverRegistration):
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::unregister):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
- dom/MutationObserverRegistration.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.
(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):
- dom/Node.cpp:
(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::addObserverToDeliverySet):
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry):
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observationStarted):
(WebCore::WebKitMutationObserver::observationEnded):
(WebCore::WebKitMutationObserver::deliver):
- dom/WebKitMutationObserver.h:
- 5:34 PM Changeset in webkit [99337] by
-
- 10 edits in trunk/Source/WebCore
Add methods to compute magnitude and phase response for biquads
https://bugs.webkit.org/show_bug.cgi?id=71055
Reviewed by Kenneth Russell.
Patch by Raymond Toy <Raymond Toy> on 2011-11-04
- platform/audio/Biquad.cpp:
(WebCore::Biquad::getFrequencyResponse):
Computes the magnitude and phase (radians) response for the given
biquad at the specified set of (normalized) frequencies.
- platform/audio/Biquad.h:
Declare getFrequencyResponse.
- webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
Factor out the code that updates filter coefficients. Allow the
caller to specify whether the smoothed values are used or not and
whether we do the update even if the coefficients are not dirty.
(WebCore::BiquadDSPKernel::process):
Use updateCoefficientsIfNecessary to update.
(WebCore::BiquadDSPKernel::getFrequencyResponse):
Implmentation of getFrequencyResponse.
- webaudio/BiquadDSPKernel.h:
Declare getFrequencyResponse.
- webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::getFrequencyResponse):
Implementation of getFrequencyResponse
- webaudio/BiquadFilterNode.h:
Declare getFrequencyResponse.
- webaudio/BiquadFilterNode.idl:
Define interface to getFrequencyResponse.
- webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::checkForDirtyCoefficients):
Factor out code for checking for dirty coefficients.
(WebCore::BiquadProcessor::process):
Use checkForDirtyCoefficients.
(WebCore::BiquadProcessor::getFrequencyResponse):
Implementation of getFrequencyResponse
- webaudio/BiquadProcessor.h:
Declare getFrequencyResponse.
- 5:29 PM Changeset in webkit [99336] by
-
- 2 edits2 moves5 adds in trunk/LayoutTests
Baselines for new test introduced in r99043
https://bugs.webkit.org/show_bug.cgi?id=71528
Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Kenneth Russell.
- platform/chromium-cg-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
- platform/chromium/test_expectations.txt:
- 5:27 PM Changeset in webkit [99335] by
-
- 2 edits in trunk/Tools
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494
Unreviewed. Fix exception when running new-run-webkit-httpd.
- Scripts/new-run-webkit-httpd:
- 5:02 PM Changeset in webkit [99334] by
-
- 3 edits in trunk/Source/WebCore
[Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=71539
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-04
Reviewed by David Kilzer.
In order to have CFURL and NSURL to be consistent when both are used on Mac,
KURL::createCFURL() is changed to support empty URL values.
- platform/cf/KURLCFNet.cpp:
(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):
- platform/mac/KURLMac.mm:
(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):
- 4:51 PM Changeset in webkit [99333] by
-
- 2 edits in trunk/Source/JavaScriptCore
sqrtDouble and andnotDouble should be declared noreturn
https://bugs.webkit.org/show_bug.cgi?id=71592
Reviewed by Sam Weinig.
- assembler/MacroAssemblerARMv7.h:
- 4:07 PM Changeset in webkit [99332] by
-
- 15 edits4 adds in trunk
CSS Aspect Ratio Property Parsing Stage
https://bugs.webkit.org/show_bug.cgi?id=70707
Reviewed by Ojan Vafai.
Source/WebCore:
Added parsing support for -webkit-aspect-ratio CSS property.
The spec can be found here: http://www.xanthir.com/blog/b4810
Test: fast/css/aspect-ratio-parsing-tests.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAspectRatioValue.cpp: Added.
(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
(WebCore::CSSAspectRatioValue::cssText):
- css/CSSAspectRatioValue.h: Added.
(WebCore::CSSAspectRatioValue::create):
(WebCore::CSSAspectRatioValue::numeratorValue):
(WebCore::CSSAspectRatioValue::denominatorValue):
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSMutableStyleDeclaration.cpp:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAspectRatio):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
LayoutTests:
- fast/css/aspect-ratio-parsing-tests-expected.txt: Added.
- fast/css/aspect-ratio-parsing-tests.html: Added.
- 3:52 PM Changeset in webkit [99331] by
-
- 2 edits in trunk/Tools
Remove Leopard-specific code from build.webkit.org
We don't have any Leopard bots anymore.
Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
and StopATSServer steps.
(unitTestsSupported): Removed check for mac-leopard.
(TestFactory.init): Removed Leopard-specific steps.
- 3:50 PM Changeset in webkit [99330] by
-
- 9 edits in trunk
Delete FrameLoader::isSandboxed
https://bugs.webkit.org/show_bug.cgi?id=71591
Reviewed by Eric Seidel.
Source/WebCore:
We should always use document->securityOrigin()->isSandboxed because
that picks up the sandbox bits that are frozen on the document rather
than the ones that could change on the Frame.
This patch starts preparing us to implement the CSP sandbox directive,
which will cause use to have document sandbox bits without any attribute.
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- This call site was the only functional site left where these two could be different. This patch causes one progression and one regression. The progression is that we now correctly freeze the allow-scripts bit when a document is created, but the regression is we now allow the execution of JavaScript URLs, as noted in fast/frames/sandboxed-iframe-scripting.html. That's even more of an edge case, so I think it's a win overall.
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
- I don't think this part of the change is testable. There's no time to execute script between when the bits get copied off the Frame and when they're checked, so there's no time to change them.
- loader/FrameLoader.cpp:
- Update FIXME comment that is now fixed.
- loader/FrameLoader.h:
- Remove wrong API.
LayoutTests:
This patch updates this test to check a few more cases and notes a bug
in our current implementation.
- fast/frames/resources/sandboxed-iframe-script-dynamic.html:
- fast/frames/sandboxed-iframe-scripting-expected.txt:
- fast/frames/sandboxed-iframe-scripting.html:
- 3:32 PM Changeset in webkit [99329] by
-
- 3 edits4 adds in trunk
When CSP blocks mixed content, we shouldn't also warn about mixed content
https://bugs.webkit.org/show_bug.cgi?id=71588
Reviewed by Eric Seidel.
Source/WebCore:
Getting both warnings confused some early adopters. They thought the
insecure loads were happening even though they blocked them with CSP.
This patch restricts the mixed content warnings to show only when the
load isn't already blocked by CSP or by the embedder.
Test: http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
LayoutTests:
These tests check what kinds of warnings we generate when blocking insecure scripts with CSP.
- http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html: Added.
- http/tests/security/contentSecurityPolicy/resources/alert-fail.js: Added.
- http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html: Added.
- 3:24 PM Changeset in webkit [99328] by
-
- 5 edits in trunk/Source/WebCore
Allow ScriptExecutionContext::addMessage to be called from background threads.
https://bugs.webkit.org/show_bug.cgi?id=71575
Patch by Michael Nordman <michaeln@google.coom> on 2011-11-04
Reviewed by Nate Chapin.
No new tests.
- dom/Document.cpp:
(WebCore::Document::addMessage):
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage):
- 3:16 PM Changeset in webkit [99327] by
-
- 16 edits in trunk/Source
[chromium] Re-named the original scissorRect to clipRect
https://bugs.webkit.org/show_bug.cgi?id=71580
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-04
Reviewed by James Robinson.
Source/WebCore:
Existing tests are updated appropriately; and no new behavior is
introduced by this patch.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUsesLayerClipping):
(WebCore::LayerChromium::usesLayerClipping):
(WebCore::LayerChromium::clipRect):
(WebCore::LayerChromium::setClipRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::clipRect):
(WebCore::RenderSurfaceChromium::setClipRect):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUsesLayerClipping):
(WebCore::CCLayerImpl::usesLayerClipping):
(WebCore::CCLayerImpl::clipRect):
(WebCore::CCLayerImpl::setClipRect):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::clipRect):
Source/WebKit/chromium:
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
- tests/LayerChromiumTest.cpp:
- 3:09 PM Changeset in webkit [99326] by
-
- 7 edits in trunk/Tools
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=71549
Reviewed by Adam Barth.
Several members of Host didn't really belong there
and were instead specific to WebKitPatch, so I've moved
them up onto that class.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 3:01 PM Changeset in webkit [99325] by
-
- 6 edits1 move in trunk/Tools
garden-o-matic: bring back party time!
https://bugs.webkit.org/show_bug.cgi?id=71582
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
- 2:43 PM Changeset in webkit [99324] by
-
- 8 edits in trunk/Source/WebCore
Add the ability to transfer ArrayBuffer and "neuter" it.
https://bugs.webkit.org/show_bug.cgi?id=71535
Reviewed by David Levin.
- html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):
- html/canvas/ArrayBuffer.h:
(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):
- html/canvas/ArrayBufferView.cpp:
(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):
- html/canvas/ArrayBufferView.h:
- html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):
- html/canvas/DataView.h:
- html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):
- 2:42 PM Changeset in webkit [99323] by
-
- 2 edits5 copies6 moves2 adds in trunk/LayoutTests
Unreviewed, rolling out r99315.
http://trac.webkit.org/changeset/99315
https://bugs.webkit.org/show_bug.cgi?id=71589
baselines still broken after running rebaseline script
(Requested by enne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-04
- platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
- platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
- platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
- platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
- platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
- platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:39 PM Changeset in webkit [99322] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r99285.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 2:32 PM Changeset in webkit [99321] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for how CSP interacts with about:blank iframes
https://bugs.webkit.org/show_bug.cgi?id=71578
Reviewed by Dimitri Glazkov.
This issue came up in the discussion on
http://code.google.com/p/chromium/issues/detail?id=103038. This patch
just adds a test to make sure we don't regress.
- http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html: Added.
- 2:27 PM Changeset in webkit [99320] by
-
- 2 edits in trunk/LayoutTests
stop running perf LayoutTests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=71513
Reviewed by Ojan Vafai.
This allows us to get rid of SLOW on some perf tests.
- platform/chromium/test_expectations.txt:
- 2:14 PM Changeset in webkit [99319] by
-
- 10 edits4 adds in trunk
[Chromium] Implement canvas.toDataURL("image/webp")
https://bugs.webkit.org/show_bug.cgi?id=70172
Reviewed by Adam Barth.
Source/WebCore:
Add a webp image encoder for the chromium skia ports, add it to the canvas
element toDataURL() flow with support for an optional quality [0.0-1.0].
Use a webp compression method (3) that provides good speed and compression
performance for this image format, and works well for various input image
types: line-art, screen-shots, and photographic images.
Test: fast/canvas/canvas-toDataURL-webp.html
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageToDataURL):
- platform/image-encoders/skia/WEBPImageEncoder.cpp: Added.
(WebCore::writeOutput):
(WebCore::importPicture):
(WebCore::importPictureBGRA):
(WebCore::importPictureRGBA):
(WebCore::encodePixels):
(WebCore::WEBPImageEncoder::encode):
- platform/image-encoders/skia/WEBPImageEncoder.h: Added.
LayoutTests:
- fast/canvas/canvas-toDataURL-webp-expected.txt: Added.
- fast/canvas/canvas-toDataURL-webp.html: Added.
- platform/chromium/test_expectations.txt: skip test on MAC CPU-CG (CoreGraphics)
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:04 PM Changeset in webkit [99318] by
-
- 5 edits in trunk
[EFL] DRT: Fix the order of the items in the dumped history list.
https://bugs.webkit.org/show_bug.cgi?id=71562
It did not make much sense to hold the history list in a map, as we do not need
the keys. And the printed items must be sorted by target, which is more easily
done with a vector.
Should make tests such as http/tests/navigation/error404-frames.html pass.
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-04
Reviewed by Antonio Gomes.
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::childHistoryItems):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
- DumpRenderTree/efl/DumpHistoryItem.cpp:
(compareHistoryItemsByTarget):
(dumpHistoryItem):
- 2:00 PM Changeset in webkit [99317] by
-
- 5 edits in trunk
[Qt] Remove ENABLE_SQLITE from qmake files
https://bugs.webkit.org/show_bug.cgi?id=71546
Reviewed by Simon Hausmann.
Source/WebCore:
ENABLE_SQLITE is required to build WebCore, so remove conditions.
- Target.pri:
Tools:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/webcore.prf:
- 1:58 PM Changeset in webkit [99316] by
-
- 3 edits in trunk/LayoutTests
Layout Test storage/indexeddb/exception-in-event-aborts.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71536
Unreviewed. Updated test and expectations.
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/indexeddb/exception-in-event-aborts.html:
- 1:55 PM Changeset in webkit [99315] by
-
- 2 edits6 moves3 adds7 deletes in trunk/LayoutTests
[chromium] Unreviewed expectation rebaseline from r99286.
- platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
- platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
- platform/chromium-gpu/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png.
- platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png.
- platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png.
- platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
- platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium/test_expectations.txt:
- 1:48 PM Changeset in webkit [99314] by
-
- 2 edits in trunk/Tools
watchlist for WebIDL shouldn't trigger on Internals.idl
https://bugs.webkit.org/show_bug.cgi?id=70657
Reviewed by David Levin.
Internals.idl isn't part of the Web-facing IDL in the project.
- Scripts/webkitpy/common/config/watchlist:
- 1:43 PM Changeset in webkit [99313] by
-
- 2 edits in trunk/LayoutTests
[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale-test2.html
https://bugs.webkit.org/show_bug.cgi?id=71587
- platform/chromium/test_expectations.txt:
- 1:37 PM Changeset in webkit [99312] by
-
- 15 edits in trunk/Source/JavaScriptCore
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Reviewed by Darin Adler.
Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
- API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
- runtime/JSBoundFunction.h:
- runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
- runtime/JSObject.h:
- 1:24 PM Changeset in webkit [99311] by
-
- 3 edits in trunk/Source/WebCore
[V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569
Reviewed by Adam Barth.
No new tests, this has only been successfully triggered
using ppapi flash.
- bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
- bindings/v8/npruntime.cpp:
- 12:53 PM Changeset in webkit [99310] by
-
- 4 edits21 adds in trunk
Send the submissions character encoding in hidden _charset_ field.
https://bugs.webkit.org/show_bug.cgi?id=19079
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.
Source/WebCore:
Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
http/tests/misc/char-encoding-in-text-charset-field-with-value.html
http/tests/misc/char-encoding-without-charset-field.html
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.
- html/HiddenInputType.h: Override appendFormData for hidden control types.
LayoutTests:
Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.
- http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
- http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
- http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
- http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
- http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
- http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
- http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.
- 12:29 PM Changeset in webkit [99309] by
-
- 3 edits in trunk/LayoutTests
2011-11-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: marked inspector/debugger/script-formatter.html
as skipped for now - sorting it out.
- platform/mac/Skipped:
- platform/win/Skipped:
- 12:12 PM Changeset in webkit [99308] by
-
- 4 edits in trunk/Source
[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
https://bugs.webkit.org/show_bug.cgi?id=71563
Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-04
Reviewed by Adam Barth.
Source/WebCore:
Use libWebKitSystemInterfaceLeopard.a that's in the Chromium port,
rather in WebKitLibraries/.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
Roll Chromium DEPS r108107:108476 to pull in
libWebKitSystemInterfaceLeopard.a.
- DEPS:
- 11:52 AM Changeset in webkit [99307] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
https://bugs.webkit.org/show_bug.cgi?id=71517
Reviewed by Simon Fraser.
Unused code removal covered by existing tests.
The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.
- 11:38 AM Changeset in webkit [99306] by
-
- 3 edits2 adds in trunk
Correct parsing of incomplete @-webkit-region rules.
https://bugs.webkit.org/show_bug.cgi?id=71514
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/regions/parse-incomplete-region-rule.html
Make sure to set the region rule to 0 on the fail branch.
- css/CSSGrammar.y:
LayoutTests:
- fast/regions/parse-incomplete-region-rule-expected.txt: Added.
- fast/regions/parse-incomplete-region-rule.html: Added.
- 11:34 AM Changeset in webkit [99305] by
-
- 4 edits in trunk/Source/WebCore
Reduce refcount churn in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=71527
Reviewed by Ryosuke Niwa.
Only the ChildListMutationAccumulator needs to hold a reference to the
target node, and the added/removed children only need be ref'd if a
ChildListMutationAccumulator exists (i.e., if there are interested
observers).
- dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):
- dom/ChildListMutationScope.h:
- dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
- 11:28 AM Changeset in webkit [99304] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Forgot to skip this test also in r99296.
- 11:27 AM Changeset in webkit [99303] by
-
- 4 edits in trunk/Source/WebCore
Correct usage of LayoutUnits in RenderImage and SVGImage
https://bugs.webkit.org/show_bug.cgi?id=71525
Reviewed by Darin Adler.
Correcting incorrect usage of LayoutUnits for image sizes that should be integers and fixing overloaded functions that
should be using LayoutUnits.
No new tests -- no change in behavior.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::nodeAtPoint):
(WebCore::RenderImage::computeReplacedLogicalWidth):
- rendering/RenderImage.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
- 11:20 AM Changeset in webkit [99302] by
-
- 2 edits in trunk/Tools
Fix WKTR crash when running NPN_ConvertPoint test.
Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
- DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):
- 11:14 AM Changeset in webkit [99301] by
-
- 9 edits in trunk
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505
Reviewed by Darin Adler.
Source/WebCore:
Enable allow-popups sandbox bit. My previous patch attempted to
forward the sandbox bits during setOpener, but that interacted poorly
with out (internal) sandboxing of the initial document. This patch
forwards the bits during createWindow, which is more targeted to the
case when a sandbox frame actually creates a new window.
- loader/FrameLoader.cpp:
(WebCore::createWindow):
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
LayoutTests:
Update test results to show that we now pass.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt:
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html:
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
- http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt:
- http/tests/security/popup-allowed-by-sandbox-when-allowed.html:
- 11:12 AM Changeset in webkit [99300] by
-
- 9 edits in trunk
NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=71570
Reviewed by Simon Fraser.
Tools:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetWindow):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Remove the NPP parameter from NPP_SetWindow.
- DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow.
- DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
- DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):
Run the test from NPP_SetWindow and call notifyDone() when done.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):
Remove unnecessary parameter.
LayoutTests:
Add a call to layoutTestController.waitUntilDone(); the plug-in will call notifyDone() when it's done.
- platform/mac/plugins/convert-point.html:
- 11:11 AM Changeset in webkit [99299] by
-
- 4 edits in trunk/Source/WebCore
Remove initMediaStreamEvent method
https://bugs.webkit.org/show_bug.cgi?id=71344
This method has been removed from the spec draft.
http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-04
Reviewed by Adam Barth.
No new tests. Removed method.
- mediastream/MediaStreamEvent.cpp:
- mediastream/MediaStreamEvent.h:
- mediastream/MediaStreamEvent.idl:
- 11:09 AM Changeset in webkit [99298] by
-
- 3 edits2 adds in trunk
Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests
https://bugs.webkit.org/show_bug.cgi?id=71053
Reviewed by Darin Adler.
Source/WebCore:
The crossorigin attribute should behave like XMLHttpRequest:
same-origin images pass without and CORS headers, but CORS checks are
performed for cross-origin loads. This patch better aligns our
behavior with Firefox, as discussed in the bug.
Test: http/tests/security/img-crossorigin-loads-same-origin.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
LayoutTests:
Test that we succeed in loading a same-origin image without the help of
CORS even if the image has the crossorigin attribute.
- http/tests/security/img-crossorigin-loads-same-origin-expected.txt: Added.
- http/tests/security/img-crossorigin-loads-same-origin.html: Added.
- 10:55 AM Changeset in webkit [99297] by
-
- 3 edits3 adds in trunk
HTMLKeygenElement: Fix "keytype" handling in appendFormData.
https://bugs.webkit.org/show_bug.cgi?id=70617
This fixes a bug introduced by http://trac.webkit.org/changeset/97658
which causes all HTML Keygen elements with a keytype optional attribute
to be considered as unsupported.
A regression test is included.
Patch by Gaurav Shah <gauravsh@chromium.org> on 2011-11-04
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/misc/submit-post-keygen.html
- html/HTMLKeygenElement.cpp:
LayoutTests:
- http/tests/misc/resources/check-keygen-post.php: Added.
- http/tests/misc/submit-post-keygen-expected.txt: Added.
- http/tests/misc/submit-post-keygen.html: Added.
- 10:51 AM Changeset in webkit [99296] by
-
- 2 edits in trunk/LayoutTests
[Qt] Temporarily skip failing tests after the build system refactoring.
Rubber-stamped by Ossy.
Bug #71571 tracks the failure so we can look into it next week.
- platform/qt/Skipped:
- 10:45 AM Changeset in webkit [99295] by
-
- 11 edits in trunk/Source
[chromium] Implement checkerboarding for missing layer tiles
https://bugs.webkit.org/show_bug.cgi?id=69585
Reviewed by James Robinson.
Source/WebCore:
For tiles that have no texture or haven't even been created yet,
draw using the background color of the layer.
The only background color set is currently the non-composited content,
and all other layers use transparent black by default.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setBackgroundColor):
- platform/graphics/chromium/NonCompositedContentHost.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundColor):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::backgroundColor):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
Source/WebKit/chromium:
To pipe the background color of the document to the non-composited
host, set it during paint. This may be more frequent than necessary,
but it'll catch all style changes.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
(WebKit::WebViewImplContentPainter::paint):
- src/WebViewImpl.h:
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- 10:41 AM Changeset in webkit [99294] by
-
- 2 edits in trunk/Tools
[Qt] Fix run-qtwebkit-tests execution on the build bot(s).
Rubber-stamped by Tor Arne Vestbø.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
changed slightly after the refactoring.
- 10:37 AM Changeset in webkit [99293] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Remove most exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=71524
Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.
Reviewed by Dimitri Glazkov.
No behavior change, so no new tests.
- platform/chromium/CursorChromium.cpp:
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
- platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::dummyHashSet):
- 10:29 AM Changeset in webkit [99292] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed expectations update.
Temporarily mark a few tests as failing from r99286 due to tiny
differences on scrollbars. Can be rebaselined once all bots cycle.
- platform/chromium/test_expectations.txt:
- 10:10 AM Changeset in webkit [99291] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614
Reviewed by Darin Fisher.
This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.
For details on how this can be accessed from CSS and javascript, please
see here:
http://developer.android.com/guide/webapps/targeting.html#DensityCSS
- public/WebView.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
- src/WebViewImpl.h:
- 10:06 AM Changeset in webkit [99290] by
-
- 2 edits in trunk/Tools
[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/default_pre.prf:
- 10:04 AM Changeset in webkit [99289] by
-
- 6 edits in trunk/Source
Add NetscapePlugin::convertFromRootView
https://bugs.webkit.org/show_bug.cgi?id=71526
Reviewed by Sam Weinig.
Source/WebCore:
Export some symbols that WebKit2 needs.
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).
- 10:00 AM Changeset in webkit [99288] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix svn properties on layout test result files I checked in.
- platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
- platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
- platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
- platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
- platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
- platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
- 9:55 AM Changeset in webkit [99287] by
-
- 2 edits in trunk/Tools
[Qt] Don't error out on wrong Qt version when qmake does recursive includes
Reviewed by Simmon Hausmann.
- 9:41 AM Changeset in webkit [99286] by
-
- 15 edits in trunk/Source
[chromium] Fix incorrect visibility/scissor rect for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70962
Reviewed by James Robinson.
Source/WebCore:
In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.
This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.
This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.
Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):
- platform/graphics/chromium/NonCompositedContentHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setRootLayer):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollLayer):
- rendering/RenderLayerCompositor.h:
Source/WebKit/chromium:
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
- 9:09 AM Changeset in webkit [99285] by
-
- 7 edits in trunk
[GTK] Disable VIDEO_TRACK for now
https://bugs.webkit.org/show_bug.cgi?id=71547
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: VIDEO_TRACK is still a moving target, it's best to
disable it for now.
LayoutTests:
Skip media/track tests and rebaseline involved fast/dom test results.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 8:48 AM Changeset in webkit [99284] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.
- 8:31 AM Changeset in webkit [99283] by
-
- 478 edits131 adds in trunk/LayoutTests
Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.
[Omitting 602 of 608 files for brevity.]
- platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
- platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
...
- platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
- platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
- platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.
- 8:29 AM Changeset in webkit [99282] by
-
- 2 edits in trunk/Tools
[Qt] Disable STDIN check before cleaning build dir
It didn't work on the bots.
Reviewed by Ossy.
- Scripts/webkitdirs.pm:
- 8:20 AM Changeset in webkit [99281] by
-
- 5 edits in trunk
[Qt] Don't build all of webkit when running build-jsc
In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.
This also means the incremental target needs to be added to all
makefiles.
Reviewed by Simon Hausmann.
- 8:20 AM Changeset in webkit [99280] by
-
- 1 edit in trunk/Tools/Scripts/webkitdirs.pm
[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir
Reviewed by Ossy.
- 7:54 AM Changeset in webkit [99279] by
-
- 2 edits in trunk/Tools
Fix run-javascriptcore-tests for Qt when it's executed by the bot.
Reviewed by Tor Arne Vestbø.
- Scripts/webkitdirs.pm:
(jscProductDir): jsc path changed.
- 7:03 AM Changeset in webkit [99278] by
-
- 2 edits in trunk/Tools
[Qt] Error out early if trying to build against Qt < 4.8
Reviewed by Simon Hausmann.
- 6:47 AM Changeset in webkit [99277] by
-
- 2 edits in trunk/Tools
Fix run-launcher for Qt and Gtk.
Rubber-stamped by Tor Arne Vestbø.
- Scripts/webkitdirs.pm:
(isWK2): Re-add isWK2(), as it's used in run-launcher.
- 6:39 AM Changeset in webkit [99276] by
-
- 2 edits in trunk/Tools
[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
Reviewed by Simon Hausmann.
- 6:37 AM Changeset in webkit [99275] by
-
- 2 edits in trunk/Tools
[GTK] Use web view title as window title in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71544
Reviewed by Philippe Normand.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.
- 6:19 AM Changeset in webkit [99274] by
-
- 50 edits4 copies9 moves31 adds16 deletes in trunk
[Qt] Refactor and clean up the qmake build system
The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.
This is a short-list of the changes:
- The rules for how to build targets are now mostly contained as prf-files in Tools/qmake/mkspecs/features. Using mkspecs also allows us to do pre- and post-processing of each project file, which helps to clean up the actual project files.
- Derived sources are no longer generated as a separate make-step but is part of each target's project file as a subdir. Makefile rules are used to ensure that we run make on the derived sources before running qmake on the actual target makefile. This makes it easier to keep a proper dependency between derived sources and the target.
- We use GNU make and the compiler to generate dependencies on UNIX-based systems running Qt 5. This allows us to lessen the need to run qmake, which should reduce compile time.
- WebKit2 is now build by default if building with Qt 5. It can be disabled by passing --no-webkit2 to build-webkit.
The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.
https://bugs.webkit.org/show_bug.cgi?id=71222
Reviewed by Simon Hausmann.
- 5:28 AM Changeset in webkit [99273] by
-
- 11 edits in trunk/Source/WebKit2
[Qt] Support programmatic scrolling with the QTouchWebView
Reviewed by Simon Hausmann.
As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.
- UIProcess/API/qt/qdesktopwebview_p.h:
(QDesktopWebViewPrivate::scrollPositionRequested):
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scrollPositionRequested):
- UIProcess/API/qt/qtouchwebview_p.h:
- UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::scrollPositionRequested):
- UIProcess/qt/QtTouchViewInterface.h:
- UIProcess/qt/QtViewInterface.h:
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
- UIProcess/qt/QtViewportInteractionEngine.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::pageDidRequestScroll):
- UIProcess/qt/QtWebPageProxy.h:
- 4:23 AM Changeset in webkit [99272] by
-
- 2 edits in trunk/Source/WebCore
[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=71548
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.
- WebCore.gypi:
- 2:20 AM Changeset in webkit [99271] by
-
- 4 edits in trunk/Tools
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494
Unreviewed. Fixing exception seen when running test-webkitpy.
Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted. But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.
- Scripts/webkitpy/style/checkers/test_expectations.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
- 2:13 AM Changeset in webkit [99270] by
-
- 3 edits in trunk/Source/WebKit/wince
[WINCE] Use default LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=71495
Reviewed by Adam Roben.
Use LocalizationStrategy from WebCore instead of using a copy of the strings in WebKit.
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
- WebCoreSupport/PlatformStrategiesWinCE.h:
- 2:04 AM Changeset in webkit [99269] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip some fast/viewport failing tests on GTK after r99195.
- platform/gtk/Skipped:
- 1:53 AM Changeset in webkit [99268] by
-
- 21 edits in trunk/Source/WebKit/efl
[EFL] Use standard booleand data type.
https://bugs.webkit.org/show_bug.cgi?id=71433
This is a fourth step in order to be more compliant with WebKit coding style.
Use standard boolean data type instead of efl boolean data type. It makes efl port
is more close to webkit coding style.
Reviewed by Zoltan Herczeg.
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- ewk/ewk_contextmenu.cpp:
- ewk/ewk_cookies.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_history.cpp:
- ewk/ewk_js.cpp:
- ewk/ewk_main.cpp:
- ewk/ewk_network.cpp:
- ewk/ewk_private.h:
- ewk/ewk_protocol_handler.cpp:
- ewk/ewk_protocol_handler_soup.cpp:
- ewk/ewk_settings.cpp:
- ewk/ewk_tiled_backing_store.cpp:
- ewk/ewk_tiled_matrix.cpp:
- ewk/ewk_tiled_model.cpp:
- ewk/ewk_util.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_single.cpp:
- ewk/ewk_view_tiled.cpp:
- 1:20 AM Changeset in webkit [99267] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed CMake build fix for !ENABLE(SQL_DATABASE).
- CMakeLists.txt: Always compile the SQLite source files, since they are required for build.
- 1:06 AM Changeset in webkit [99266] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/test_expectations.txt: Add more expectations for recent test flakinesses.
- 12:45 AM Changeset in webkit [99265] by
-
- 4 edits in trunk/Source/JavaScriptCore
More code clean-up in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71540
Remove unnecessary code duplications, and fix compilation warnings.
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-04
Reviewed by Gavin Barraclough.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
(JSC::DFG::JITCompiler::jitAssertIsCell):
- dfg/DFGJITCompiler32_64.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:35 AM Changeset in webkit [99264] by
-
- 15 edits in trunk/Source/JavaScriptCore
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Unreviewed rolling out r99238, because it made a test crash on all platform.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
- API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
- runtime/JSBoundFunction.h:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
- runtime/JSObject.h:
Nov 3, 2011:
- 9:53 PM Changeset in webkit [99263] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, forgot to skip a new test in r99261.
- platform/qt/Skipped:
- 9:52 PM Changeset in webkit [99262] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION (r99076): Pasting into password fields is broken
https://bugs.webkit.org/show_bug.cgi?id=71483
Reviewed by Darin Adler.
The bug was caused by plainText serializing secured (instead of original) text.
Fixed the bug by adding new TextIterator behavior that serializes the original text
and using it in ReplacementFragment::ReplacementFragment.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
- editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::emitText):
- editing/TextIterator.h:
- 9:18 PM Changeset in webkit [99261] by
-
- 30 edits11 adds in trunk
Add TrackEvent
https://bugs.webkit.org/show_bug.cgi?id=71178
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/events/constructors/track-event-constructor.html
- CMakeLists.txt: Add new files for TrackEvent.
- CodeGenerators.pri: Ditto.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- GNUmakefile.am: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/generic/EventConstructors.h: Ditto.
- bindings/gobject/GNUmakefile.am: Ditto.
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add method to convert to a Track.
- bindings/js/JSDictionary.h:
- bindings/js/JSEventConstructors.cpp: Add new files for TrackEvent.
- bindings/js/JSTrackCustom.cpp: Added.
(WebCore::toTrack): New, convert from a JSValue to a Track.
(WebCore::toJS): New, return a JS wrapper for a Track.
- bindings/js/JSTrackCustom.h: Added.
- bindings/js/JSTrackEventCustom.cpp: Added.
(WebCore::JSTrackEvent::track): New, returns a TextEvent's 'track' attribute.
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get): Returns RefPtr<TrackBase>.
- bindings/v8/custom/V8EventConstructors.cpp: Add Track initializing constructor.
- bindings/v8/custom/V8TrackEventCustom.cpp: Added.
(WebCore::V8TrackEvent::trackAccessorGetter): New, returns a TextEvent's 'track' attribute.
- dom/EventFactory.in: Add TrackEvent.
- dom/EventNames.h: Add 'addtrack' event.
- html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Call new base class constructor.
- html/TextTrack.h: Now derive from BaseTrack for the day we implement VideoTrack and AudioTrack.
- html/track/TrackBase.cpp: Added.
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::~TrackBase):
- html/track/TrackBase.h: Added.
(WebCore::TrackBase::type): Return the track type.
- html/track/TrackEvent.cpp: Added.
(WebCore::TrackEventInit::TrackEventInit):
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEvent::~TrackEvent):
(WebCore::TrackEvent::interfaceName):
- html/track/TrackEvent.h: Added.
(WebCore::TrackEvent::create):
(WebCore::TrackEvent::isTrackEvent):
(WebCore::TrackEvent::track):
- html/track/TrackEvent.idl: Added.
- page/DOMWindow.idl: Add TrackEvent.
LayoutTests:
- fast/events/constructors/track-event-constructor-expected.txt: Added.
- fast/events/constructors/track-event-constructor.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/Skipped:
- platform/win/Skipped:
- 8:44 PM Changeset in webkit [99260] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/test_expectations.txt: Apply recent expectation changes.
- 7:21 PM Changeset in webkit [99259] by
-
- 50 edits in branches/subpixellayout/Source
Revert platform to ints
- 7:16 PM Changeset in webkit [99258] by
-
- 786 edits in trunk/LayoutTests
JS Test Harness: Remove successfullyParsed from more tests
https://bugs.webkit.org/show_bug.cgi?id=71533
Reviewed by Ojan Vafai.
- LayoutTests/*: Remove successfullyParsed
- 6:55 PM Changeset in webkit [99257] by
-
- 3 edits in trunk/Source/WebCore
Optimize canvas fills / drawImage when covering entire canvas
https://bugs.webkit.org/show_bug.cgi?id=70789
Patch by Ben Wells <benwells@chromium.org> on 2011-11-03
Reviewed by Stephen White.
If we're filling a rect or drawing an image, and it covers the entire canvas, we don't
need to worry about clearing outside the area updated by the operation if we're in
a composite mode that requires this (such as source-in, copy, etc.). In this case we
can take the simple path through the code and save a clear (for copy) or a temporary
image buffer (for the other modes).
No new tests - optimization, behaviour is unchanged and covered by existing tests.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):
- html/canvas/CanvasRenderingContext2D.h:
- 6:32 PM Changeset in webkit [99256] by
-
- 28 edits in trunk/Source
De-virtualize JSObject::getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71306
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::getPropertyNames):
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
- runtime/JSObject.h:
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
- runtime/Structure.h:
Source/JavaScriptGlue:
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- JSUtils.cpp:
(KJSValueToCFTypeInternal):
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
Source/WebCore:
No new tests.
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getPropertyNames):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getPropertyNames):
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariantMap):
Source/WebKit/mac:
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
Source/WebKit2:
Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
- 6:18 PM Changeset in webkit [99255] by
-
- 11 edits in trunk
Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
https://bugs.webkit.org/show_bug.cgi?id=71163
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add m_visualWordMovementEnabled page setting, trigger visual word movement
function (instead of logical one) when it is set as true.
right|leftWordPosition() are tested in editing/selection/move-by-word-visually*
by using --webkit-visual-word flag.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::visualWordMovementEnabled):
- editing/FrameSelection.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setVisualWordMovementEnabled):
(WebCore::Settings::visualWordMovementEnabled):
Source/WebKit/chromium:
To minimize the risk to LTR users, we enable this feature first to chromium win
by command line flag. This and corresponding changset in chromium
(http://codereview.chromium.org/8400078/)
should be removed after this feature is enabled without command line flag.
The work flow is:
- (chromium) adds command line flag --enable-visual-word-movement, pass it to WebCore::Settings through WebPreferences.
- in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings, trigger visual word movement instead of logical one.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setVisualWordMovementEnabled):
- src/WebSettingsImpl.h:
Tools:
- DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
(WebPreferences::applyTo):
- 5:56 PM Changeset in webkit [99254] by
-
- 8 edits in trunk/Source/WebCore
Correct usage of LayoutUnits and integers in Table rendering classes
https://bugs.webkit.org/show_bug.cgi?id=71500
Reviewed by Darin Adler.
Fixing the Table layout classes to operate on integers -- sub-pixel table layout breaks
the spec. Meanwhile correcting the Table rendering classes themselves to still use
LayoutUnits.
No new tests -- no change in behavior.
- rendering/AutoTableLayout.cpp: Reverting to operating on integers.
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
- rendering/AutoTableLayout.h: Reverting to operating on integers.
- rendering/FixedTableLayout.cpp: Ditto.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):
- rendering/RenderTable.h: Switching to LayoutUnits.
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
- rendering/RenderTableCell.cpp: Switching to LayoutUnits.
(WebCore::RenderTableCell::updateLogicalWidth):
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::cellBaselinePosition):
(WebCore::RenderTableCell::scrollbarsChanged):
- rendering/RenderTableCell.h: Switching to LayoutUnits
- rendering/RenderTableSection.cpp: Ditto.
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
- 5:31 PM Changeset in webkit [99253] by
-
- 9 edits in trunk/Source
[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
https://bugs.webkit.org/show_bug.cgi?id=71381
Reviewed by Kenneth Russell.
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::didSwapBuffers):
- platform/graphics/chromium/cc/CCScheduler.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
- 5:27 PM Changeset in webkit [99252] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Added ewk_tile_memory_size_get function
https://bugs.webkit.org/show_bug.cgi?id=71213
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-03
Reviewed by Anders Carlsson.
Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
the code.
- ewk/ewk_tiled_model.cpp:
(ewk_tile_memory_size_get):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):
- ewk/ewk_tiled_model.h:
- 5:17 PM Changeset in webkit [99251] by
-
- 1 edit5 adds in trunk/Source/WTF
Add Stub.h and Stub.cpp to Source-level WTF project
https://bugs.webkit.org/show_bug.cgi?id=71497
Reviewed by Eric Seidel.
This patch adds some stub files and a skelton GYP build file as a
starting point for the new Source-level WTF project. Other build
systems and actual code will arrive in future patches.
- Stub.cpp: Added.
- Stub.h: Added.
- WTF.gyp/WTF.gyp: Added.
- WTF.gypi: Added.
- 5:13 PM Changeset in webkit [99250] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of NetscapePlugin::m_clipRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71521
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- 5:13 PM Changeset in webkit [99249] by
-
- 3 edits in trunk/Source/WebKit2
Use convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location() where possible
https://bugs.webkit.org/show_bug.cgi?id=71520
Reviewed by Dan Bernstein.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- 5:10 PM Changeset in webkit [99248] by
-
- 2 edits in trunk/LayoutTests
Remove an obsolete comment.
- platform/chromium/test_expectations.txt:
- 4:55 PM Changeset in webkit [99247] by
-
- 3 edits in trunk/Source/WebKit2
Add NetscapePlugin::convertToRootView
https://bugs.webkit.org/show_bug.cgi?id=71519
Reviewed by Darin Adler.
Yet another step towards eliminating uses of m_frameRectInWindowCoordinates.
Also, use the "root view" terminology, since that's really what we mean here.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
Use convertToRootView to get the plug-in location and clip rect in root view coordinates.
(WebKit::NetscapePlugin::convertToRootView):
Apply the m_pluginToRootViewTransform.mapPoint transform.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add convertToRootView.
- 4:42 PM Changeset in webkit [99246] by
-
- 2 edits in trunk/Source/WebCore
CMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl
Rubber-stamped by Martin Robinson
- CMakeLists.txt:
- 4:35 PM Changeset in webkit [99245] by
-
- 2 edits in trunk/Source/WebCore
CMake: Only generate from WebGL IDLs when building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=71516
Reviewed by Martin Robinson.
- CMakeLists.txt:
- 4:26 PM Changeset in webkit [99244] by
-
- 10 edits in trunk/Source/WebCore
Remove support for LegacyDefaultOptionalArguments
https://bugs.webkit.org/show_bug.cgi?id=71489
Reviewed by Darin Adler.
This removes support for LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise].
[RequiresAllArguments=Raise] is now the standard behavior so it would be a no op.
No new tests. Covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Check the "RequiresAllArguments" extended attribute and generate code
that returns undefined if there are missing arguments.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck): Ditto.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): Add generated argument count checks.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Ditto.
(WebCore::jsTestObjPrototypeFunctionIdbKey): Ditto.
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Ditto.
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): Ditto.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): Ditto.
- bindings/scripts/test/TestCallback.idl: Remove LegacyDefaultOptionalArguments.
- bindings/scripts/test/TestMediaQueryListListener.idl: Ditto.
- bindings/scripts/test/TestObj.idl: Remove LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise]
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Remove LegacyDefaultOptionalArguments.
(WebCore::TestMediaQueryListListenerInternal::methodCallback): Add generated argument count checks.
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::intMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::objMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::serializedValueCallback): Ditto.
(WebCore::TestObjInternal::idbKeyCallback): Ditto.
(WebCore::TestObjInternal::optionsObjectCallback): Ditto.
(WebCore::TestObjInternal::customArgsAndExceptionCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): Ditto.
(WebCore::TestObjInternal::methodWithCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::overloadedMethod1Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod2Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod3Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod4Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod5Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod6Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod7Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): Ditto.
- 4:17 PM Changeset in webkit [99243] by
-
- 2 edits in trunk/Source/WebKit2
Move plug-in size and backing store checks to PluginProxy::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=71508
Reviewed by Darin Adler.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...
(WebKit::PluginProxy::updateBackingStore):
...here.
- 4:17 PM Changeset in webkit [99242] by
-
- 5 edits in trunk/Source/WebKit2
Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71506
Reviewed by Darin Adler.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
This no longer needs to take the frame rect in window coordinates.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginControllerProxy.messages.in:
Remove frameRectInWindowCoordinates from the GeometryDidChange message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Don't pass frameRectInWindowCoordinates when sending GeometryDidChange.
- 4:17 PM Changeset in webkit [99241] by
-
- 10 edits in trunk/Source/WebKit2
Get rid of Plugin::wantsWindowRelativeCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=71504
Reviewed by Darin Adler.
Since all Plugin subclasses now return false for wantsWindowRelativeCoordinates,
we can go ahead and remove it.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
- 4:17 PM Changeset in webkit [99240] by
-
- 3 edits in trunk/Source/WebKit2
NetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
https://bugs.webkit.org/show_bug.cgi?id=71501
Reviewed by Darin Adler.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().
(WebKit::NetscapePlugin::platformPaint):
No need to translate back and forth between window and plug-in relative coordinates anymore.
- 4:04 PM Changeset in webkit [99239] by
-
- 76 edits in trunk/Source
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.
../WebCore:
Reviewed by Darin Fisher.
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):
- bridge/NP_jsobject.cpp:
(_NPN_CreateScriptObject):
- dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
- history/PageCache.cpp:
(WebCore::PageCache::add):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::releasePlatformDescription):
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::platformResource):
Use leakRef.
../WebKit/chromium:
- public/WebPrivatePtr.h:
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::operator=):
- src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::WebDOMEvent):
- src/WebData.cpp:
(WebKit::WebData::assign):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
- src/WebDragData.cpp:
(WebKit::WebDragData::initialize):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::ensureMutable):
- src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::WebNodeCollection):
- src/WebNodeList.cpp:
(WebKit::WebNodeList::WebNodeList):
- src/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::operator=):
- src/WebRange.cpp:
(WebKit::WebRange::WebRange):
(WebKit::WebRange::operator=):
- src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::operator=):
- src/WebThreadSafeData.cpp:
(WebKit::WebThreadSafeData::WebThreadSafeData):
Use leakRef.
../WebKit/efl:
Reviewed by Darin Fisher.
- ewk/ewk_history.cpp:
(ewk_history_item_new): Use leakRef.
../WebKit/gtk:
Reviewed by Darin Fisher.
- webkit/webkitwebdatasource.cpp:
(WebKit::kitNew):
- webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_new):
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_copy):
(WebKit::kit):
- webkit/webkitwebresource.cpp:
(webkit_web_resource_new_with_core_resource):
(webkit_web_resource_init_with_core_resource):
Use leakRef.
../WebKit/mac:
Reviewed by Darin Fisher.
- History/WebBackForwardList.mm:
(-[WebBackForwardList initWithBackForwardList:]):
- History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
- WebCoreSupport/WebOpenPanelResultListener.mm:
- WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]):
- WebView/WebResource.mm:
(-[WebResourcePrivate initWithCoreResource:]):
Use leakRef.
../WebKit/win:
Reviewed by Darin Fisher.
- WebCache.cpp:
(WebCache::statistics):
- WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
- WebHistoryItem.cpp:
(WebHistoryItem::redirectURLs):
- WebKitClassFactory.cpp:
(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):
- WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
Use leakRef.
../WebKit2:
Reviewed by Darin Fisher.
- Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
- Shared/API/c/WKArray.cpp:
(WKArrayCreate):
- Shared/API/c/WKData.cpp:
(WKDataCreate):
- Shared/API/c/WKDictionary.cpp:
(WKDictionaryCopyKeys):
- Shared/API/c/WKGeometry.cpp:
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
- Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
- Shared/API/c/WKMutableDictionary.cpp:
(WKMutableDictionaryCreate):
- Shared/API/c/WKNumber.cpp:
(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI):
(WebKit::toCopiedURLAPI):
- Shared/API/c/cf/WKErrorCF.cpp:
(WKErrorCreateWithCFError):
- Shared/API/c/cf/WKURLRequestCF.cpp:
(WKURLRequestCreateWithCFURLRequest):
- Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCreateWithCFURLResponse):
- Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCreateWithNSURLRequest):
- Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCreateWithNSURLResponse):
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
- UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListCopyBackListWithLimit):
(WKBackForwardListCopyForwardListWithLimit):
- UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
- UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
- UIProcess/API/C/WKGeolocationPosition.cpp:
(WKGeolocationPositionCreate):
- UIProcess/API/C/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateWithIdentifier):
- UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
- UIProcess/win/WebUndoClient.cpp:
(WebKit::WebUndoClient::registerEditCommand):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyChildFrames):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyTrackedRepaintRects):
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldCreateWorld):
Use leakRef.
- 3:40 PM Changeset in webkit [99238] by
-
- 15 edits in trunk/Source/JavaScriptCore
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430
Reviewed by Darin Adler.
Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
- API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
- runtime/JSBoundFunction.h:
- runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
- runtime/JSObject.h:
- 3:28 PM Changeset in webkit [99237] by
-
- 5 edits in trunk/Source
[chromium] Remove unused clipboard methods
https://bugs.webkit.org/show_bug.cgi?id=71512
Reviewed by Tony Chang.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
- public/WebClipboard.h:
(WebKit::WebClipboard::getSequenceNumber):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::writeImage):
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardGetSequenceNumber):
(WebCore::PlatformSupport::clipboardReadAvailableTypes):
- 1:49 PM Changeset in webkit [99236] by
-
- 4 edits3 deletes in branches/chromium/912/Source/WebKit/chromium
Revert 96912 - Always call setActive() in WebViewImpl::setFocus(),
not just when enabling focus.
https://bugs.webkit.org/show_bug.cgi?id=65220
Reviewed by Darin Fisher.
- WebKit.gyp:
- WebKit.gypi:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
- tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::loadFrame):
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
- tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
- tests/WebFrameTest.cpp:
- tests/WebViewTest.cpp: Added.
TBR=Nate Chapin
Review URL: http://codereview.chromium.org/8378004
- 1:37 PM Changeset in webkit [99235] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.
At some points we didn't have any guarantee that a favicon has been loaded, so now
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
making some files to not be resolved and comparing meaningless bitmaps.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):
- 1:28 PM Changeset in webkit [99234] by
-
- 7 edits2 adds in trunk
Source/WebCore: Implement TextTrackCueList.
https://bugs.webkit.org/show_bug.cgi?id=70451
Reviewed by Eric Carlson.
Test: media/track/track-text-track-cue-list.html
- html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable):
Update TextTrack's TextTrackCueList (m_cues) when new cues are discovered.
- html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
Create an empty TextTrackCueList upon TextTrack creation.
(WebCore::TextTrack::cues):
Return this TextTrack's list of cues.
Implement TextTrackCueList functionality:
- html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::TextTrackCueList):
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item):
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::add):
(WebCore::TextTrackCueList::remove):
(WebCore::TextTrackCueList::contains):
- html/TextTrackCueList.h:
(WebCore::TextTrackCueList::~TextTrackCueList):
LayoutTests: Tests for TextTrackCueList implementation.
https://bugs.webkit.org/show_bug.cgi?id=70451
Reviewed by Eric Carlson.
- media/track/track-text-track-cue-list-expected.txt: Added.
- media/track/track-text-track-cue-list.html: Added.
- 1:24 PM Changeset in webkit [99233] by
-
- 34 edits in trunk/Tools
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494
Reviewed by Adam Barth.
I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
free functions in factory.py. To remove these required fixing all callsites
to use MockHost, Host, or PortFactory where appropriate. After this change
we're only left with a handfull of places where we inappropraitely use a
real Executive, FileSystem or User object during unittesting.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
- These PortFactory overrides were from an earlier edition of my previous patch in the end, I removed MockPortFactory so all tests ended up with this same real PortFactory() with a MockHost. This was simply redundent code.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
- Use MockHost to get a mocked-out PortFactory.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
- This code has no access to a Host object, so we just use a default PortFactory for now. This will still incorrectly create real Executive/FileSystem objects durring unittesting, which is wrong. :(
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
- Use a MockHost to get a mocked PortFactory.
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
- Use a MockHost to get a mocked PortFactory.
- Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
- ditto.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
- ditto.
- Scripts/webkitpy/layout_tests/port/init.py:
- factory.get no longer exists. Yay!
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Use a MockHost to get a mocked PortFactory. To do this efficiently, I created a helper function and combined all these (mostly redundant) tests into one test with several calls to the helper function.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Pass MockUser and MockExecutive in these port testing subclasses.
- I also removed a bunch of unecessary uses of mocktool. namespacing.
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Awesome windows hacks should only happen on win32. Once we started using MockExecutives these 'svn help' commands started printing in other tests, which is how I found this bug.
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- DryRunPort has no Host, so just use a PortFactory() directly. This will do the wrong thing if we're unittesting the DryRun port but it's no worse than the existing code.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Remove the free functions.
- Fix argument overriding to be able to override None.
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Use a mocked-out PortFactory during testing.
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- Pass MockExecutive and MockUser to these manual Port instantiations.
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- No access to a Host object here, so just using PortFactory directly. This is wrong, but no more wrong than the existing code was.
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Use a MockHost to get a mocked out PortFactory.
- Scripts/webkitpy/layout_tests/port/test.py:
- Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
- Scripts/webkitpy/layout_tests/port/win.py:
- Don't run cmd /c ver from WinPort.init or it shows up in unittests which have logging MockExecutive now that we're actually passing MockExecutive to most Port instantiations during testing.
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
- Pass our new "unittesting" bool to _detect_version when actually unittesting.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Host is the future.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Use a MockHost to get a mocked out PortFactory. Once we have a mocked PortFactory we don't need to pass MockUser explicitly, it does that automatically for us.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
- Use a MockHost to get a mocked out PortFactory.
- Scripts/webkitpy/style/checkers/test_expectations.py:
- We don't have access to a Host object, so using PortFactory() directly.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
- Remove unused variable.
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- Host isn't accessible here, so using PortFactory() directly, which although unfortunate is no worse than before.
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
- Testing is much easier when you don't need to hack global state...
- Scripts/webkitpy/tool/commands/expectations.py:
- Use the port_factory on the tool.
- Scripts/webkitpy/tool/commands/rebaseline.py:
- ditto.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- This unittest was wrong. It was trying to pass the tool object, but failing to pass the arguments in the right order. Fixing that made it use a MockFileSystem (like it had been trying to), which then required us to actually populate that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
- Scripts/webkitpy/tool/commands/rebaselineserver.py:
- Get the port_factory from the tool.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- Ditto.
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- Use a MockHost to get a mocked out Port object.
- 1:21 PM Changeset in webkit [99232] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT-specific code should be able to refer to register types even on JIT-disabled builds
https://bugs.webkit.org/show_bug.cgi?id=71498
Reviewed by Gavin Barraclough.
- assembler/MacroAssembler.h:
(MacroAssembler::MacroAssembler):
- 1:20 PM Changeset in webkit [99231] by
-
- 2 edits in trunk/LayoutTests
Mark tests as slow in chromium.
fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
are already marked as timing out, but maybe they will pass in release
if we give them enough time.
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [99230] by
-
- 4 edits in trunk/Source/WebKit2
NetscapePlugin should use plug-in relative coordinates on Mac
https://bugs.webkit.org/show_bug.cgi?id=71486
Reviewed by Adam Roben.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Don't translate the graphics context when the plug-in doesn't want window relative coordinates.
This also fixed a bug I introduced in my previous commit where we'd always pass the dirty rect in
plug-in coordinates even if the plug-in wants window relative coordinates.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
Don't do the whole translate dance if the plug-in doesn't want window relative coordinates.
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false for PLATFORM_ARCHITECTURE(MAC).
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint):
Simplify code now that we know that the we're always given plug-in relative coordinates.
- 12:41 PM Changeset in webkit [99229] by
-
- 9 edits2 adds in trunk
IndexedDB result of deleting a record should be true or false
https://bugs.webkit.org/show_bug.cgi?id=60197
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by David Levin.
Source/WebCore:
IDBObjectStore.delete() was incorrectly firing an error if there
was no record to remove. Match the spec, and return true/false
as success values instead. Bring JSC binding implementation of
SerializedScriptValue more in line with V8 version for methods
called from IDB code.
Test: storage/indexeddb/mozilla/delete-result.html
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
- bindings/js/SerializedScriptValue.h:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
- bindings/v8/SerializedScriptValue.h:
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
LayoutTests:
Add tests for IDBObjectStore.delete() - should succeed if
record exists or not, and return true/false as success value.
- storage/indexeddb/mozilla/delete-result-expected.txt: Added.
- storage/indexeddb/mozilla/delete-result.html: Added.
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- 12:29 PM Changeset in webkit [99228] by
-
- 8 edits6 adds in trunk
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505
Reviewed by Eric Seidel.
Source/WebCore:
There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)
This patch lands most of the infrastructure for this feature, but it
doesn't actually enable the feature. I'll enable it in a follow-up
patch.
Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
- loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
- loader/FrameLoaderTypes.h:
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::parseSandboxPolicy):
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::sandboxFlags):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
LayoutTests:
Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.
These tests currently have expected.txt results that show failures, but
they will pass once this feature is enabled.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
- http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.
- 12:25 PM Changeset in webkit [99227] by
-
- 4 adds in trunk/Source
Add stubs for WTF and Platform
https://bugs.webkit.org/show_bug.cgi?id=71492
Reviewed by Eric Seidel.
Source/Platform:
This patch creates the Platform directory, which begins the process of
moving Platform out of WebCore.
Source/WTF:
This patch creates the WTF directory, which begins the process of
moving WTF out of JavaScriptCore.
- 12:15 PM Changeset in webkit [99226] by
-
- 4 edits in trunk/Tools
[EFL] DRT: Allow choosing which backing store to use.
https://bugs.webkit.org/show_bug.cgi?id=70532
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-03
Reviewed by Antonio Gomes.
This change makes it possible to change the backing store used by DRT
from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(shouldUseSingleBackingStore):
(chooseAndInitializeAppropriateSmartClass):
(drtViewAdd):
- DumpRenderTree/efl/DumpRenderTreeView.h:
- 11:48 AM Changeset in webkit [99225] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening after r99212.
- platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
- platform/chromium/test_expectations.txt:
Rebaselined the test on Chromium Windows.
- platform/efl/Skipped:
I forgot to check the visual baseline on EFL. The EFL port does not seem to have the
repaint result (likely due to lack of support) thus it does not need a rebaseline.
- 11:42 AM Changeset in webkit [99224] by
-
- 2 edits3 deletes in trunk/LayoutTests
Correct chromium expectations for setPrinting and single-line-must-not-be-split-into-two-pages.
https://bugs.webkit.org/show_bug.cgi?id=71080
- platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Removed.
- platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Removed.
- platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 11:20 AM Changeset in webkit [99223] by
-
- 25 edits in trunk/Source
De-virtualize JSObject::className
https://bugs.webkit.org/show_bug.cgi?id=71428
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::className):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::className):
- debugger/DebuggerActivation.h:
- jsc.cpp:
(GlobalObject::createStructure):
- profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::className):
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::className):
- runtime/JSObject.h:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- testRegExp.cpp:
(GlobalObject::createStructure):
Source/JavaScriptGlue:
Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- JSUtils.cpp:
(KJSValueToCFTypeInternal):
Source/WebCore:
No new tests.
Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::className):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::internalConstructorName):
- bridge/testqtbindings.cpp:
(Global::className):
Source/WebKit/efl:
Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- ewk/ewk_js.cpp:
(ewk_js_npobject_to_object):
- 11:05 AM Changeset in webkit [99222] by
-
- 4 edits6 adds in trunk/Source
Add Clock class and platform-specific implementations.
https://bugs.webkit.org/show_bug.cgi?id=71341
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Add WTF_USE_COREAUDIO macro for use by PlatformClockCA.
- wtf/Platform.h:
Source/WebCore:
No new tests; these classes will be used and tested by the MediaController feature.
Adds a abstract Clock class and two concrete, platform-specific subclasses.
Clock provides a basic interface for starting, stopping, and querying a generic timeline.
PlatformClockCA implements this interface using a CoreAudio CAClock object, which uses
the default audio device's hardware clock as a timing source. PlatformClockPOSIX
implements this interface using gettimeofday() as its timing source.
- WebCore.xcodeproj/project.pbxproj:
- platform/Clock.cpp: Added.
(Clock::create): Creates a platform-specific clock.
- platform/Clock.h: Added.
(WebCore::Clock::~Clock):
(WebCore::Clock::Clock):
- platform/mac/PlatformClockCA.cpp: Added.
(PlatformClockCA::PlatformClockCA):
(PlatformClockCA::~PlatformClockCA):
(PlatformClockCA::setCurrentTime):
(PlatformClockCA::currentTime):
(PlatformClockCA::setPlayRate):
(PlatformClockCA::PlatformClockCA::playRate):
(PlatformClockCA::start):
(PlatformClockCA::stop):
- platform/mac/PlatformClockCA.h: Added.
(WebCore::PlatformClockCA::isRunning):
- platform/posix/PlatformClockPOSIX.cpp: Added.
(timevalToFloat):
(timevalDelta):
(PlatformClockPOSIX::PlatformClockPOSIX):
(PlatformClockPOSIX::setCurrentTime):
(PlatformClockPOSIX::currentTime):
(PlatformClockPOSIX::setPlayRate):
(PlatformClockPOSIX::PlatformClockPOSIX::playRate):
(PlatformClockPOSIX::start):
(PlatformClockPOSIX::stop):
(PlatformClockPOSIX::now):
- platform/posix/PlatformClockPOSIX.h: Added.
(WebCore::PlatformClockPOSIX::isRunning):
- 10:57 AM Changeset in webkit [99221] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Brought back TIMEOUT for show-hide-table-rows.html
- platform/chromium/test_expectations.txt:
- 10:53 AM Changeset in webkit [99220] by
-
- 2755 edits in trunk
JS Test Harness: Remove more link tags
https://bugs.webkit.org/show_bug.cgi?id=71339
Reviewed by Ojan Vafai.
Tools:
- Scripts/make-new-script-test:
(writeTestFile): Don't output <link>
LayoutTests:
- LayoutTest/*: Remove links to js-test-style.css.
- 10:50 AM Changeset in webkit [99219] by
-
- 3 copies in branches/chromium/912/LayoutTests/svg/custom
Merge 99109 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384
Reviewed by Darin Adler.
Source/WebCore:
Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.
Test: svg/custom/resource-invalidation-crash.svg
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
- rendering/svg/RenderSVGResourceContainer.h:
LayoutTests:
Fixes a stack overflow when SVG resources reference one another and share ids.
- svg/custom/resource-invalidation-crash-expected.png: Added.
- svg/custom/resource-invalidation-crash-expected.txt: Added.
- svg/custom/resource-invalidation-crash.svg: Added.
TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8446005
- 10:46 AM Changeset in webkit [99218] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Object stores not persisting between sessions
https://bugs.webkit.org/show_bug.cgi?id=71313
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by Tony Chang.
Logic flaw introduced with r98806 skipped the loading of object stores
during subsequent sessions.
- storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
- 10:42 AM Changeset in webkit [99217] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix heap profiler rendering and resize.
https://bugs.webkit.org/show_bug.cgi?id=71484
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
- 10:41 AM Changeset in webkit [99216] by
-
- 2 edits in trunk/Tools
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-11-03
Reviewed by Martin Robinson.
[GTK] arguments passed to build-jsc are not taken into account
https://bugs.webkit.org/show_bug.cgi?id=58333
- Scripts/build-jsc:
- 10:37 AM Changeset in webkit [99215] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed evening gardening.
- platform/qt/test_expectations.txt: Remove a useless entry.
- 10:34 AM Changeset in webkit [99214] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed evening gardening. Add platform specific expected results after r98989.
- platform/qt/svg/filters/invalidate-on-child-layout-expected.png: Added.
- platform/qt/svg/filters/invalidate-on-child-layout-expected.txt: Added.
- 10:26 AM Changeset in webkit [99213] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed evening gardening. Skip failing tests.
- platform/qt-mac/Skipped:
- platform/qt/Skipped:
- 10:20 AM Changeset in webkit [99212] by
-
- 13 edits in trunk
Stop abusing RenderTableSection::needsRecalcCells logic
https://bugs.webkit.org/show_bug.cgi?id=71420
Reviewed by Darin Adler.
Source/WebCore:
Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).
Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).
The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.h:
Removed styleWillChange override as it was unneeded.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.
(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).
- rendering/RenderTableSection.h: Added the 2 previous functions.
LayoutTests:
- platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:
Update this test as this is a progression: we are not over-repainting the table
anymore.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/test_expectations.txt:
Skipped the test here as it needs a rebaseline.
- 10:16 AM Changeset in webkit [99211] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaselining. Unskipped progress-event-constructor.html in Qt-Arm
since the failure is fixed in r99161.
- platform/qt-arm/Skipped:
- 10:13 AM Changeset in webkit [99210] by
-
- 2 edits in trunk/Source/WebKit2
PluginControllerProxy's dirty rect should be in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71481
Reviewed by Sam Weinig.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect to window coordinates before passing it to the plug-in.
(WebKit::PluginControllerProxy::invalidate):
No need to convert the dirty rect to window coordinates.
(WebKit::PluginControllerProxy::paintEntirePlugin):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.isEmpty.
- 10:10 AM Changeset in webkit [99209] by
-
- 1 copy in tags/Safari-535.8
New tag.
- 10:06 AM Changeset in webkit [99208] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView
https://bugs.webkit.org/show_bug.cgi?id=70507
Reviewed by Darin Fisher.
No change in functionality except for fixed layout mode. Fixed layout mode has
not been fully upstreamed yet, so no new tests yet:
https://bugs.webkit.org/show_bug.cgi?id=70562 will address this.
This patch also fixes https://bugs.webkit.org/show_bug.cgi?id=70555
It was decided that fixed layout mode might need to be disabled for some content,
and so this change enables the embedder to decide whether to enable fixed layout on
navigation.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- 10:06 AM Changeset in webkit [99207] by
-
- 2 edits in trunk/Tools
[GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.
- 10:01 AM Changeset in webkit [99206] by
-
- 2 edits in trunk/Tools
[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71466
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowHistoryItemActivated): Go to selected back formard
list item using webkit_web_view_go_to_back_forward_list_item()
(browserWindowCreateBackForwardMenu): Create a GtkMenu for the
given GList of WebKitBackForwardListItems.
(browserWindowUpdateNavigationActions): Enable/disable back and
forward buttons depending on whether it's possible to go
back/forward. Create a menu for back and forward toolbar buttons.
(backForwadlistChanged): Call browserWindowUpdateNavigationActions().
(browserWindowConstructed): Connect to WebKitBackForwardList
changed signal.
- 9:54 AM Changeset in webkit [99205] by
-
- 2 edits in trunk/Source/WebKit2
Use the right function to determine whether NPWindow coordinates should be window relative
https://bugs.webkit.org/show_bug.cgi?id=71480
Reviewed by Adam Roben.
We want to use wantsWindowRelativeNPWindowCoordinates here, and not wantsWindowRelativeCoordinates
which is a temporary function that will be removed (and that returns the wrong value!)
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
- 9:31 AM Changeset in webkit [99204] by
-
- 4 edits in trunk/Source/WebCore
CSSRuleList: Move rule orphaning from deleteRule() out to callers.
https://bugs.webkit.org/show_bug.cgi?id=71470
Patch by Andreas Kling <kling@webkit.org> on 2011-11-03
Reviewed by Antti Koivisto.
Rule parenting is the responsibility of the owner rule (the rule containing
the rule list), so move parent clearing out of CSSRuleList::deleteRule() and
into the (two) call sites.
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::deleteRule):
- css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::deleteRule):
- 9:28 AM Changeset in webkit [99203] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):
- 9:16 AM Changeset in webkit [99202] by
-
- 24 edits2 deletes in trunk
[Qt] Remove Maemo specific code paths
https://bugs.webkit.org/show_bug.cgi?id=71476
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/WebKit.pri:
Source/WebCore:
- WebCore.pri:
- features.pri:
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
- plugins/PluginView.cpp:
(WebCore::PluginView::setValue):
- plugins/PluginView.h:
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformGetValueStatic):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
- Api/qwebview.cpp:
(QWebView::QWebView):
- QtWebKit.pro:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createSelectPopup):
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
- WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
- WebCoreSupport/QtMaemoWebPopup.h: Removed.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::focusInputTypes):
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):
Tools:
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::~LauncherWindow):
(LauncherWindow::init):
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
- QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
- QtTestBrowser/locationedit.cpp:
- QtTestBrowser/locationedit.h:
- 9:13 AM Changeset in webkit [99201] by
-
- 2 edits in trunk/Tools
[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71461
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(resetEntryProgress): Reset the entry progress after a while when
load has been completed.
(webViewLoadProgressChanged): Update location entry progress.
(browserWindowConstructed): Connect to WebView
notify::estimated-load-progress signal.
- 9:10 AM Changeset in webkit [99200] by
-
- 5 edits1 delete in trunk/Tools
[GTK] Remove WebKit2 C API from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71459
Reviewed by Martin Robinson.
Use the GTK+ API instead to add minimum functionality. The other
features will be ported to GTK+ API in following patches.
- MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback): Use webkit_web_view_load_uri().
(goBackCallback): Use webkit_web_view_go_back().
(goForwardCallback): Use webkit_web_view_go_forward().
(webViewURIChanged): Update location entry with current uri using
webkit_web_view_get_uri().
(browserWindowFinalize):
(browserWindowGetProperty):
(browserWindowSetProperty):
(browser_window_init):
(browserWindowConstructed): Connect to notify::uri signal of
WebView to be notified when the URI changes.
(browser_window_class_init):
(browser_window_new): Use WebKitWebView.
(browser_window_get_view): Use WebKitWebView
- MiniBrowser/gtk/BrowserWindow.h:
- MiniBrowser/gtk/GNUmakefile.am:
- MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
- MiniBrowser/gtk/main.c:
(loadURI): Use webkit_web_view_new().
(main):
- 9:07 AM Changeset in webkit [99199] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r99195.
The right name is restrictMinimumScaleFactorToViewportSize.
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):
- 9:04 AM Changeset in webkit [99198] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=71457
Reviewed by Martin Robinson.
- GNUmakefile.am:
- 8:40 AM Changeset in webkit [99197] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Bounce back limits are wrong in some situations
https://bugs.webkit.org/show_bug.cgi?id=71471
Reviewed by Simon Hausmann.
The valid position points were in viewport coordinates, but we were
requiring valid position points in content coordinates.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
- 8:31 AM Changeset in webkit [99196] by
-
- 2 edits2 adds in trunk/Source/WebKit/qt
Patch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtWebKit should have documentation clarifying its mobile features usage
https://bugs.webkit.org/show_bug.cgi?id=41465
Add "QtWebKit Goes Mobile" documentation
- docs/qtwebkit-goes-mobile.qdoc: Added.
- docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
- docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.
- 8:22 AM Changeset in webkit [99195] by
-
- 15 edits in trunk/Source
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Operations in computeViewportAttributes that are not a part of the spec:
http://www.w3.org/TR/2011/WD-css-device-adapt-20110915/#constraining-viewport-property-values
were moved into the functions restrictMinimumScaleFactorToViewportSize and
restrictScaleFactorToInitialScaleIfNotUserScalable.
- WebCore.exp.in:
- dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore::restrictMinimumScaleFactorToViewportSize):
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):
- dom/ViewportArguments.h:
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
- webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
Source/WebKit2:
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):
- 8:21 AM Changeset in webkit [99194] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix the signal signature of the loadFailed API test.
Rubber-stamped by Simon Hausmann.
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
- 8:05 AM Changeset in webkit [99193] by
-
- 2 edits in trunk/Tools
[Qt] Unable to start MiniBrowser after run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71469
Reviewed by Csaba Osztrogonác.
- Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
line arguments.
- 7:49 AM Changeset in webkit [99192] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix an assertion under WebPage::setViewportSize.
https://bugs.webkit.org/show_bug.cgi?id=71473
Reviewed by Simon Hausmann.
The web view can have an empty size and it causes the assert in computeViewportAttributes.
Don't notify the web page of such a size change in this case.
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):
- 7:44 AM Changeset in webkit [99191] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 7:42 AM Changeset in webkit [99190] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix, sigh.
- css/CSSFontFaceRule.h:
- css/CSSMutableStyleDeclaration.h:
- 7:39 AM Changeset in webkit [99189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping 3 new svg tests presenting pixel differences
between the 32-bits and 64-bits bots.
- platform/gtk/Skipped:
- 7:32 AM Changeset in webkit [99188] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] State variable name refactor in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71467
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Andreas Kling.
Renaming m_inDecidePolicyForMIMEType to m_inDecidePolicyForResponse after
https://bugs.webkit.org/show_bug.cgi?id=55827 .
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):
- UIProcess/WebPageProxy.h:
- 7:27 AM Changeset in webkit [99187] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix, out-of-line StyleSheet::parentStyleSheet()
again since there's a cycle in the includes between CSSRule/StyleSheet.
- css/StyleSheet.cpp:
(WebCore::StyleSheet::parentStyleSheet):
- css/StyleSheet.h:
- 7:12 AM Changeset in webkit [99186] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r99185, removing forward-declaration
of CSSRule since CSSRule.h is already included.
- css/StyleSheet.h:
- 7:01 AM Changeset in webkit [99185] by
-
- 11 edits in trunk/Source/WebCore
CSSOM: Inline some trivial methods.
https://bugs.webkit.org/show_bug.cgi?id=71468
Reviewed by Antti Koivisto.
- css/CSSFontFaceRule.cpp:
- css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::setDeclaration):
- css/CSSStyleRule.cpp:
- css/CSSStyleRule.h:
(WebCore::CSSStyleRule::setDeclaration):
- css/CSSStyleSheet.cpp:
- css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::ownerRule):
- css/StyleSheet.cpp:
- css/StyleSheet.h:
(WebCore::StyleSheet::parentStyleSheet):
- css/WebKitCSSKeyframesRule.cpp:
- css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::name):
(WebCore::WebKitCSSKeyframesRule::length):
- 6:53 AM Changeset in webkit [99184] by
-
- 2 edits in trunk/Source/WebCore
Devirtualize MediaList.
https://bugs.webkit.org/show_bug.cgi?id=71464
Reviewed by Antti Koivisto.
- css/MediaList.h: Make the destructor non-virtual.
- 6:48 AM Changeset in webkit [99183] by
-
- 8 edits2 adds in trunk/Source/WebCore
Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=65522
Reviewed by Dirk Schulze.
This patch continues the work of Felician Marton.
The arithmetic operation of feComposite SVG filter can be greatly enhanced
by the ARM-NEON instruction set since we are able to calculate the pixel data
for all four RGBA channels at the same time.
It won't affect the general behavior and existing tests will cover the changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/filters/FEComposite.cpp:
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added.
- platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added.
(WebCore::FEComposite::platformArithmeticNeon):
- 6:40 AM Changeset in webkit [99182] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Add pageScaleFactor to the serialized history item
https://bugs.webkit.org/show_bug.cgi?id=71463
Reviewed by Tor Arne Vestbø.
r75758 added the pageScaleFactor member, which we need to
serialize.
- history/qt/HistoryItemQt.cpp:
(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):
- 6:33 AM Changeset in webkit [99181] by
-
- 2 edits in trunk/Source/WebCore
Use createPrimitiveNumericValue function
https://bugs.webkit.org/show_bug.cgi?id=71432
Reviewed by Andreas Kling.
No new tests - no change in functionality.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
- 6:28 AM Changeset in webkit [99180] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip
http/tests/security/xssAuditor/script-tag-with-callbacks.html on
GTK, relying on an unimplemented feature.
- platform/gtk/Skipped:
- 6:26 AM Changeset in webkit [99179] by
-
- 7 edits in trunk/Source/WebKit2
[GTK][WEBKIT2] Add support for title property in WebKitWebView.
https://bugs.webkit.org/show_bug.cgi?id=68074
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.
Support for 'title' property is added in WebKitWebView.
Functions to get the value of this property is provided.
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didReceiveTitleForFrame): LoaderClient titleRecieve callback.
(webkitWebLoaderClientAttachLoaderClientToPage): Register didReceiveTitleForFrame callback.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): 'title' property get function.
(webkit_web_view_class_init): Register new property.
(webkitWebViewSetTitle): Notify WebKitWebView about title receive.
(webkit_web_view_get_title): API to get main frame title.
- UIProcess/API/gtk/WebKitWebView.h: webkit_web_view_get_title API expose.
- UIProcess/API/gtk/WebKitWebViewPrivate.h: Added private API.
- UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testWebViewTitle): Test webkit_web_view_get_title API.
(beforeAll): Add testWebViewTitle test.
- 6:05 AM Changeset in webkit [99178] by
-
- 32 edits1 copy7 adds in trunk/Source
[Qt][WK2] Download support and API in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=68962
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.
Source/WebKit/qt:
Registering new qml type QWebDownloadItem.
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
Source/WebKit2:
We implement our WkContextDownloadClient and the needed callbacks.
We also add APIs by exposing QWebDownloadItem. Objects from this type
have their ownership handled by QDesktopWebView and will be created or
destroyed as needed. Classes implementing ViewInterface (QDesktopWebViewPrivate
and TouchViewInterface) will receive a signal (downloadRequested) with a pointer
to the recently created QWebDownloadItem. With that they can connect the proper
signals and slots, set the download destination path and then call start().
Objects of this type will provide the progress of a download, a slot to cancel it,
and signals for getting finished or failure status.
QWebDownloadItem was also exposed in QML.
Qt needed an asynchronous way for UIProcess to return a destination path to WebProcess,
therefore the startTransfer API was added to WebKit2's Download handlers.
- Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Add encoding and decoding of suggestedFilename for ResourceResponse.
- UIProcess/API/qt/WKView.h:
- UIProcess/API/qt/qbasewebview.h: Add signal downloadRequested.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::downloadRequested):
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qwebdownloaditem.cpp: Added.
(QWebDownloadItemPrivate::QWebDownloadItemPrivate):
(QWebDownloadItem::QWebDownloadItem):
(QWebDownloadItem::~QWebDownloadItem):
(QWebDownloadItem::url):
(QWebDownloadItem::destinationPath):
(QWebDownloadItem::setDestinationPath):
(QWebDownloadItem::suggestedFilename):
(QWebDownloadItem::mimeType):
(QWebDownloadItem::expectedContentLength):
(QWebDownloadItem::totalBytesReceived):
(QWebDownloadItem::cancel):
(QWebDownloadItem::start):
- UIProcess/API/qt/qwebdownloaditem.h: Added.
- UIProcess/API/qt/qwebdownloaditem_p.h: Added.
(QWebDownloadItemPrivate::didReceiveResponse):
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/download.html: Added.
- UIProcess/API/qt/tests/qmltests/common/download.zip: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::startTransfer): Qt only function added.
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/PageClient.h: Added Qt specific function to call handleDownloadRequest from QtWebPageProxy.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Using WebPageProxy::handleDownloadRequest to bootstrap a download through PageClient.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Using handleDownloadRequest() to bootstrap a download through PageClient.
(WebKit::WebPageProxy::handleDownloadRequest): Calls PageClient::handleDownloadRequest().
- UIProcess/WebPageProxy.h:
- UIProcess/qt/QtDownloadManager.cpp: Added.
(WebKit::toQtDownloadManager):
(WebKit::qt_wk_didReceiveResponse):
(WebKit::qt_wk_didCreateDestination):
(WebKit::qt_wk_didFinishDownload):
(WebKit::qt_wk_didFailDownload):
(WebKit::qt_wk_didReceiveDataForDownload):
(QtDownloadManager::downloadReceivedResponse): Will reach QtWebPageProxy::didReceiveDownloadResponse.
(QtDownloadManager::downloadCreatedDestination):
(QtDownloadManager::downloadFinished):
(QtDownloadManager::downloadFailed):
(QtDownloadManager::downloadDataReceived):
- UIProcess/qt/QtDownloadManager.h: Added.
Bootstrap our WKContextDownloadClient and set its callbacks.
This entity will also handle all downloads and keep a map of them.
It will be kept alive together with the WebContext as a static member
of QtWebPageProxy, so we can keep it across several WebPages and, therefore,
WebViews.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::handleDownloadRequest):
(QtWebPageProxy::didReceiveDownloadResponse):
- UIProcess/qt/QtWebPageProxy.h:
From now on it will keep a static QtDownloadManager to live together
with the default WebContext. It implements PageClient::handleDownloadRequest.
QtWebPageProxy::didReceiveDownloadResponse will emit the view's signal downloadRequested.
- UIProcess/qt/QtTouchViewInterface.h:
(WebKit::QtTouchViewInterface::downloadRequested):
- UIProcess/qt/QtViewInterface.h:
- UIProcess/qt/qweberror.cpp:
(QWebError::description):
- UIProcess/qt/qweberror.h:
(QWebError::errorCodeAsDownloadError):
Add Download error handling to QWebError and a new API
to retrieve the error description from the original ResourceError.
Also, it now has QWebDownloadItem::DownloadError errorCodeAsDownloadError()
that returns the error code as a DownloadError.
- WebKit2.pro:
- WebKit2API.pri:
- WebProcess/Downloads/Download.h:
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startTransfer):
- WebProcess/Downloads/DownloadManager.h:
Adding Qt specific startTransfer function.
- WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::startTransfer):
- WebProcess/Downloads/qt/QtFileDownloader.cpp:
(WebKit::QtFileDownloader::init): start() was renamed to init().
(WebKit::QtFileDownloader::determineFilename):
Calling onReadyRead() here was unnecessary and it was triggering the overall
download process even before DownloadManager finished startDownload(). This
was leading to a DownloadManager with an empty list of downloads.
(WebKit::QtFileDownloader::startTransfer): decidedDestination() became startTransfer().
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::handleDownloadResponse):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::cancel):
- WebProcess/Downloads/qt/QtFileDownloader.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::startTransfer):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Adding Qt specific message StartTransfer and handling function.
- 6:04 AM Changeset in webkit [99177] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-11-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing win build. step2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:52 AM Changeset in webkit [99176] by
-
- 7 edits in trunk/Source/WebKit2
Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs.
https://bugs.webkit.org/show_bug.cgi?id=69249
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.
This patch adds support for 2 more load APIs, namely
webkit_web_view_load_html and webkit_web_view_load_plain_text.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_html): New API to load html string.
(webkit_web_view_load_plain_text): New API to load plain text.
- UIProcess/API/gtk/WebKitWebView.h: Public API addition.
- UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadHtml): Test webkit_web_view_load_html API.
(testLoadPlainText): Test webkit_web_view_load_plain_text API.
(beforeAll): Add new tests.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadHtml): Test webkit_web_view_load_html API.
(WebViewTest::loadPlainText): Test webkit_web_view_load_plain_text API.
- UIProcess/API/gtk/tests/WebViewTest.h:
- 5:49 AM Changeset in webkit [99175] by
-
- 2 edits in trunk/Source/WebCore
2011-11-03 Pavel Feldman <pfeldman@google.com>
Not reviewed: win build fix. Assign autoDPI at all cases (breakage introduced in r99173).
- dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
- 5:33 AM Changeset in webkit [99174] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-11-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fix windows build, step1
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:21 AM Changeset in webkit [99173] by
-
- 4 edits in trunk/Source/WebCore
Differentiate implicit viewport from that of the meta tag
https://bugs.webkit.org/show_bug.cgi?id=71453
Reviewed by Simon Hausmann.
This is needed because of DPI adjustment taking place with the meta
tag. This is to be avoided when no viewport meta tag is present.
- dom/Document.cpp:
(WebCore::Document::processViewport):
- dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):
- 5:16 AM Changeset in webkit [99172] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Another batch of expectations clean-up.
- platform/chromium/test_expectations.txt:
- 5:14 AM Changeset in webkit [99171] by
-
- 12 edits in trunk/Source/WebCore
Devirtualize CSSRule.
https://bugs.webkit.org/show_bug.cgi?id=71382
Reviewed by Antti Koivisto.
Remove the virtual destructor from CSSRule, and reimplement RefCounted's deref()
to invoke operator delete on the appropriate subclass type.
This removes the CSSRule vtable and shrinks each instance by one CPU word.
- css/CSSCharsetRule.h:
- css/CSSFontFaceRule.h:
- css/CSSMediaRule.h:
- css/CSSPageRule.h:
- css/CSSRegionStyleRule.h:
- css/CSSRule.cpp:
- css/CSSRule.h:
(WebCore::CSSRule::deref):
(WebCore::CSSRule::~CSSRule):
- css/CSSStyleRule.h:
- css/WebKitCSSKeyframeRule.h:
Devirtualize!
- css/CSSRule.cpp:
(WebCore::CSSRule::destroy):
Added, invokes operator delete on the right subclass type.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::requestStyleSheet):
- css/CSSImportRule.h:
(WebCore::CSSImportRule::ImportedStyleSheetClient::ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::~ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::setCSSStyleSheet):
Break out the inheritance from CachedStyleSheetClient into a member variable
that simply redirects the setCSSStyleSheet() callback to the CSSImportRule.
- 5:09 AM Changeset in webkit [99170] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Failing assertion with desktop webview when touch mocking in MinBrowser
https://bugs.webkit.org/show_bug.cgi?id=71452
Reviewed by Andreas Kling.
Don't re-implement touchEvent(), we don't intend to support touch events as we
receive them from the QQuickCanvas at this point.
- UIProcess/API/qt/qdesktopwebview.cpp:
- UIProcess/API/qt/qdesktopwebview.h:
- 5:03 AM Changeset in webkit [99169] by
-
- 14 edits in trunk/Source
IndexedDB: Recycle cursor objects when calling continue()
https://bugs.webkit.org/show_bug.cgi?id=71115
Reviewed by Darin Fisher.
Source/WebCore:
The IndexedDB spec says that cursors should be recycled when calling
continue(). Let the IDBRequest keep track of which cursor to return
upon success, and have the cursor use a new callback:
onSuccessWithContinuation() to signal that the continue was successful.
When we start using the new callback, the
storage/indexeddb/cursor-inconsistency.html layout test will start
passing.
- storage/IDBCallbacks.h:
- storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
- storage/IDBRequest.h:
Source/WebKit/chromium:
Add the new onSuccessWithContinuation() callback to IDB wrappers.
- public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccessWithContinuation):
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccessWithContinuation):
- src/IDBCallbacksProxy.h:
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccessWithContinuation):
- src/WebIDBCallbacksImpl.h:
- 5:03 AM Changeset in webkit [99168] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip failing tests.
- 5:02 AM Changeset in webkit [99167] by
-
- 22 edits1 copy in trunk
Web Inspector: preserve script location for inline handlers.
https://bugs.webkit.org/show_bug.cgi?id=71367
Source/JavaScriptCore:
Makes SourceCode factories receive TextPosition instead of the line number;
Stores consistent position values in SourceCode and SourceProvider;
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
- API/JSObjectRef.cpp:
(JSObjectMakeFunction):
- parser/SourceCode.h:
(JSC::makeSource):
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::startPosition):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::UStringSourceProvider):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionConstructor.h:
Source/WebCore:
Makes eventHandler report position, not line number;
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.
- bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerPosition):
- bindings/js/ScriptController.h:
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
- bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::StringSourceProvider):
(WebCore::makeSource):
LayoutTests:
Linkifier test reimplemented for simplisity.
Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.
- inspector/debugger/debugger-scripts-expected.txt:
- inspector/debugger/debugger-scripts.html:
- inspector/debugger/linkifier-expected.txt:
- inspector/debugger/linkifier.html:
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-scripts-expected.txt.
- 4:52 AM Changeset in webkit [99166] by
-
- 2 edits in trunk/LayoutTests
Unreviewed update of test expectations.
- platform/chromium/test_expectations.txt:
- 4:20 AM Changeset in webkit [99165] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build.
https://bugs.webkit.org/show_bug.cgi?id=71196
Reviewed by Kenneth Rohde Christiansen.
Ensure AC is turned off for the desktop view before we launch the process.
This avoids "accidential" enterAc/exitAc calls that cause failing assertions
because we don't really support AC in this setup.
The touch side works the same way, i.e. enable the preference before calling
init().
- UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::QtDesktopWebPageProxy):
- 4:09 AM Changeset in webkit [99164] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Styles] Do not check isEditingAnyField in StylesSidebarPane._createNewRule
https://bugs.webkit.org/show_bug.cgi?id=71217
Reviewed by Yury Semikhatsky.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
- 3:37 AM Changeset in webkit [99163] by
-
- 6 edits in trunk
[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023
Reviewed by Simon Hausmann.
Source/WebCore:
Disable X11 plugins with Qt5.
- features.pri:
Source/WebKit2:
Disable X11 plugins.
- config.h:
LayoutTests:
Disable plugin tests with Qt5.
- platform/qt-5.0/Skipped:
- 3:33 AM Changeset in webkit [99162] by
-
- 10 edits6 deletes in trunk
Unreviewed, rolling out r99138.
http://trac.webkit.org/changeset/99138
https://bugs.webkit.org/show_bug.cgi?id=71455
It made 200+ tests flakey on SL and on Qt (Requested by Ossy
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03
Source/WebCore:
- html/HTMLIFrameElement.cpp:
(WebCore::parseSandboxAttribute):
(WebCore::HTMLIFrameElement::parseMappedAttribute):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):
- loader/FrameLoader.h:
(WebCore::FrameLoader::setForcedSandboxFlags):
- loader/FrameLoaderTypes.h:
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
- page/SecurityOrigin.cpp:
- page/SecurityOrigin.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
LayoutTests:
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Removed.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Removed.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Removed.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Removed.
- http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Removed.
- http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Removed.
- 3:23 AM Changeset in webkit [99161] by
-
- 9 edits in trunk
Fixed wrong implementation of doubleValue % 2{64}.
https://bugs.webkit.org/show_bug.cgi?id=67980
Reviewed by Hajime Morita.
Source/JavaScriptCore:
fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.
- wtf/MathExtras.h:
(doubleToInteger): Implemented the spec correctly.
Source/WebCore:
fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Uses doubleToInteger().
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Ditto.
LayoutTests:
Enabled progress-event-constructor.html on Chromium-Mac.
- fast/events/constructors/progress-event-constructor-expected.txt:
- fast/events/constructors/progress-event-constructor.html: The change from "12345678901234567168" to "12345678901234567890" is not related to this patch. Just to fix typo. The reason for whether "12345678901234567168" or "12345678901234567890" does not matter is that both values are toStringed to the same value "12345678901234567000".
- platform/chromium/test_expectations.txt:
- 3:21 AM Changeset in webkit [99160] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip fast/css/webkit-mask-crash-table.html crasher on
GTK.
- platform/gtk/Skipped:
- 3:08 AM Changeset in webkit [99159] by
-
- 13 edits1 add in trunk/Source/WebCore
Web Inspector: Introduce SuggestBox for TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=71288
Reviewed by Pavel Feldman.
Drive-by fix for a regression where clicking in the Database query view did not focus the prompt.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype.afterShow):
(WebInspector.DatabaseQueryView.prototype.completions):
(WebInspector.DatabaseQueryView.prototype._selectStart.moveBackIfOutside):
(WebInspector.DatabaseQueryView.prototype._selectStart):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype._positionElement):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestForceable):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBoxConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.get hasSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype._onboxmousedown):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._applySuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestionsSoon):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):
(WebInspector.TextPrompt.SuggestBox.prototype._createItemElement):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._updateSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.spaceKeyPressed):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.search-view .search-panel):
(#search-results-pane-file-based .search-match .search-match-content):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-corner, .custom-popup-vertical-scroll ::-webkit-scrollbar-corner):
(.custom-popup-horizontal-scroll ::-webkit-resizer, .custom-popup-vertical-scroll ::-webkit-resizer):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-button, .custom-popup-vertical-scroll ::-webkit-scrollbar-button):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar:horizontal:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:hover):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:active):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:start):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:decrement):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:increment):
(.custom-popup-vertical-scroll ::-webkit-scrollbar:vertical:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:hover):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:active):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:start):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:decrement):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):
- inspector/front-end/popover.css:
(.popover.right-bottom-arrow .arrow):
- inspector/front-end/textPrompt.css: Added.
(.suggest-box):
(.suggest-box.visible):
(.suggest-box .container):
(.suggest-box-content-item):
(.suggest-box-content-item .prefix):
(.suggest-box-content-item.selected):
(.suggest-box-content-item:hover:not(.selected)):
- inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.boxInWindow):
- 3:07 AM Changeset in webkit [99158] by
-
- 3 edits in trunk/Tools
[GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71445
Reviewed by Martin Robinson.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): set directoriesDescription only when needed.
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.
- 3:00 AM Changeset in webkit [99157] by
-
- 4 edits in trunk
Source/WebCore: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277
Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.
If port is 0, SoupURI does not have an explicitly specified port. Due
to this port value is ignored in SoupURI. Hence, an extra check is
required to restore the port.
Test: LayoutTests/fast/loader/location-port.html
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):
LayoutTests: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277
Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.
Removed LayoutTests/fast/loader/location-port.html from Skipped tests
for GTK
- platform/gtk/Skipped:
- 2:59 AM Changeset in webkit [99156] by
-
- 3 edits in trunk/Tools
[GTK] Remove GtkLauncher2
https://bugs.webkit.org/show_bug.cgi?id=71449
Reviewed by Martin Robinson.
GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
made sense when we wanted to implement the exactly same wk1 API
for wk2. Now the code would require an ifdef for most the api, so
it's better to remove GtkLauncher2 and port MiniBrowser to the new
GTK+ API.
- GNUmakefile.am:
- GtkLauncher/main.c:
(notifyProgressCb):
(closeWebViewCb):
(createBrowser):
(addWebSettingsGroupToContext):
(main):
- 2:56 AM Changeset in webkit [99155] by
-
- 8 edits in trunk
[EFL] Enable the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=69127
Patch by Dongwoo Im <dw.im@samsung.com> on 2011-11-03
Reviewed by Adam Barth.
.:
Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.
- Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
- Source/cmakeconfig.h.cmake: ditto.
Source/WebKit/efl:
Implement methods to enable the Page Visibility API on EFL port.
(http://www.w3.org/TR/page-visibility)
When the visibility status of the page is changed, browser could
inform the status to WebKit using the APIs below.
- ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.
(ewk_view_visibility_state_set): Sets the page visibility status.
(ewk_view_visibility_state_get): Gets the page visibility status.
- ewk/ewk_view.h: Add public prototypes.
LayoutTests:
- platform/efl/Skipped: Unskip all of the test cases of page visibility.
- 2:27 AM Changeset in webkit [99154] by
-
- 3 edits in trunk/Source/WebKit/chromium
Web Inspector [chromium]: fix debug front-end zip generation.
https://bugs.webkit.org/show_bug.cgi?id=71376
Reviewed by Yury Semikhatsky.
- WebKit.gyp:
- scripts/generate_devtools_zip.py:
- 2:25 AM Changeset in webkit [99153] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Cleaned up obsolete suppressions.
- platform/chromium/test_expectations.txt:
- 2:10 AM Changeset in webkit [99152] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r99089.
http://trac.webkit.org/changeset/99089
https://bugs.webkit.org/show_bug.cgi?id=71448
@plt postfix for math functions cause crash on Linux 32 (the
symbol is defined but it points to NULL) (Requested by
zherczeg on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03
- dfg/DFGOperations.cpp:
- jit/JITStubs.cpp:
- jit/ThunkGenerators.cpp:
- 2:07 AM Changeset in webkit [99151] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed Qt build fix(es).
- UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::handleDragMoveEvent): Adapt to dragSession API change.
(QtDesktopWebPageProxy::handleDropEvent): Ditto.
- WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates): Implement here
also, for plugin-disabled builds.
- 2:07 AM Changeset in webkit [99150] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Allow the toolbar background to be transparent on mac platforms when remote
https://bugs.webkit.org/show_bug.cgi?id=71437
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-03
Reviewed by Yury Semikhatsky.
- inspector/front-end/inspector.css:
(body.detached.platform-mac-snowleopard #toolbar):
- 1:54 AM Changeset in webkit [99149] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Fix build-break on r99143
https://bugs.webkit.org/show_bug.cgi?id=71440
Patch by ChangSeok Oh <ChangSeok Oh> on 2011-11-03
Reviewed by Philippe Normand.
dragOperation() should be replaced with dragSession().operation since it was removed.
And didDetectXSSForFrame of WKPageLoaderClient should be relocated.
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientAttachLoaderClientToPage):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
- 1:06 AM Changeset in webkit [99148] by
-
- 15 edits3 adds in trunk
Source/JavaScriptCore: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436
Reviewed by Oliver Hunt.
This makes inlined arguments retrieval use some of the same machinery as
OSR to determine where from, and how, to retrieve a value that the DFG
might have somehow squirreled away while the old JIT would put it in its
obvious location, using an obvious format.
To that end, previously DFG-internal notions such as DataFormat,
VirtualRegister, and ValueRecovery are now in bytecode/ since they are
stored as part of InlineCallFrames.
- bytecode/CodeOrigin.h:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
- interpreter/CallFrame.h:
(JSC::ExecState::inlineCallFrame):
- interpreter/Register.h:
(JSC::Register::asInlineCallFrame):
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
- runtime/Arguments.h:
(JSC::Arguments::finishCreationAndCopyRegisters):
LayoutTests: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436
Reviewed by Oliver Hunt.
- fast/js/dfg-inline-arguments-int32-expected.txt: Added.
- fast/js/dfg-inline-arguments-int32.html: Added.
- fast/js/script-tests/dfg-inline-arguments-int32.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
- 12:37 AM Changeset in webkit [99147] by
-
- 2 edits in trunk/Tools
[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71359
Reviewed by Martin Robinson.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.
- 12:36 AM Changeset in webkit [99146] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
https://bugs.webkit.org/show_bug.cgi?id=71409
Reviewed by Simon Hausmann.
Build fix for building qtwebkit with latest qt5 which has removed Qt X11 headers.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- 12:34 AM Changeset in webkit [99145] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix after r99093...
- PluginProcess/PluginControllerProxy.h:
Nov 2, 2011:
- 11:55 PM Changeset in webkit [99144] by
-
- 6 edits3 adds in trunk/Source/JavaScriptCore
ValueRecovery should be moved out of the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=71439
Reviewed by Oliver Hunt.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/DataFormat.h: Added.
(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSFormat):
(JSC::isJSInteger):
(JSC::isJSDouble):
(JSC::isJSCell):
(JSC::isJSBoolean):
- bytecode/ValueRecovery.h: Added.
(JSC::ValueRecovery::ValueRecovery):
(JSC::ValueRecovery::alreadyInRegisterFile):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::technique):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::tagGPR):
(JSC::ValueRecovery::payloadGPR):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
- bytecode/VirtualRegister.h: Added.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isJSFormat):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGVariableAccessData.h:
- 11:46 PM Changeset in webkit [99143] by
-
- 3 edits6 adds in trunk
CSP should handle empty URLs as agreed at TPAC
https://bugs.webkit.org/show_bug.cgi?id=71426
Reviewed by Eric Seidel.
Source/WebCore:
It was somewhat unclear how CSP should treat plugins that lacked a URL
because most of the CSP rules are URL-based. At TPAC, we decided to
treat "empty" URLs as if there were the URL of the document. That
means you can use plugins with no URL if you've included 'self' in
object-src, but you can also block them by using 'none' as your
object-src.
Tests: http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::createCSPDirective):
LayoutTests:
- http/tests/security/contentSecurityPolicy/object-src-no-url-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html: Added.
- Test the allow and block cases for plugins with no URL.
- http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Added.
- Somehow these tests got deleted from the repository. This patch just re-adds them.
- 11:40 PM Changeset in webkit [99142] by
-
- 2 edits3 adds in trunk/LayoutTests
Unerviewed gardening.
- platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium/test_expectations.txt: fixed qualifiers limit-layer-bounds-transformed-overflow.html
- 11:33 PM Changeset in webkit [99141] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] [WK] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=71417
Add WKNumber.h for WKBooleanGetTypeID
Replace WKGetTypeId with WKGetTypeID
Add initialization for didDetectXSSForFrame member in WKBundlePageLoaderClient
instance.
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Noam Rosenthal.
- WebProcess/qt/QtBuiltinBundle.cpp:
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
- 11:16 PM Changeset in webkit [99140] by
-
- 38 edits9 copies5 adds in trunk/Tools
Move Mocks into _mock files near their implementations
https://bugs.webkit.org/show_bug.cgi?id=71425
Reviewed by Adam Barth.
This entire change is splitting mocktool.py into separate _mock.py files
and placing them next to their real implementations.
I also deleted MockPortFactory (since it was wrong) and was just hiding
the fact that the "skipped-ports" command was broken (and has been for a long time).
So I made MockHost use a real PortFactory (passed a MockHost) and changed
the skipped-ports implementation to use modern PortFactory methods.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
- Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
- Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
- Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py: Added.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
- Scripts/webkitpy/common/net/credentials_unittest.py:
- Scripts/webkitpy/common/net/failuremap_unittest.py:
- Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
- Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
- Scripts/webkitpy/common/net/statusserver_unittest.py:
- Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_mock.py:
- Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
- Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
- Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
- Scripts/webkitpy/common/system/workspace_unittest.py:
- Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/init.py.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/efl_unittest.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
- Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
- Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
- Scripts/webkitpy/test/main.py:
- Scripts/webkitpy/tool/bot/botinfo_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- 10:28 PM Changeset in webkit [99139] by
-
- 4 edits in trunk/Source/WebKit/mac
Move NSRange / DOMRange conversion functions to WebFramePrivate
https://bugs.webkit.org/show_bug.cgi?id=71435
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-02
Reviewed by Sam Weinig.
Move conversion functions to WebFramePrivate,
and remove the no longer used versions.
- WebView/WebFrame.mm:
(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- 9:39 PM Changeset in webkit [99138] by
-
- 10 edits6 adds in trunk
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505
Reviewed by Eric Seidel.
Source/WebCore:
There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox. Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox. Hixie says he'll add it to the spec once we implement
it, so here's our implementation. (See discussion in the W3C linked in
the bug for more details.)
Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
http/tests/security/popup-allowed-by-sandbox-when-allowed.html
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):
- loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
- loader/FrameLoaderTypes.h:
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::parseSandboxPolicy):
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::sandboxFlags):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
LayoutTests:
Test that the allow-popups directive works as expected. Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
- http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
- http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.
- 9:21 PM Changeset in webkit [99137] by
-
- 2 edits in trunk/Source/WebCore
Remove the ability to generate custom lookupGetter/lookupSetter functions,
now that they can not be overridden
Reviewed by Adam Roben.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- 9:17 PM Changeset in webkit [99136] by
-
- 4 edits in trunk
Source/JavaScriptCore: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter
https://bugs.webkit.org/show_bug.cgi?id=71333
Reviewed by Gavin Barraclough.
Tested by fast/dom/getter-on-window-object2.html
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
The attributes returned from Structure::get do not include Getter or Setter, so
instead check if the value is a GetterSetter like we do elsewhere. If it is, update
the descriptor's attributes accordingly.
LayoutTests: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter/
https://bugs.webkit.org/show_bug.cgi?id=71333
Reviewed by Gavin Barraclough.
- fast/dom/getter-on-window-object2-expected.txt:
Update for now correct results.
- 8:33 PM Changeset in webkit [99135] by
-
- 2 edits in trunk/Source/WebCore
Fix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi?id=71307)
Reviewed by Adam Roben.
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
Since we are proxying to the window, we need to pass it as the this object,
not the shell.
- 8:13 PM Changeset in webkit [99134] by
-
- 3 edits1 delete in trunk/Tools
Fixed the build and removed another copy to ColorBits.ttf.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/fonts/ColorBits.ttf: Removed.
- 8:13 PM Changeset in webkit [99133] by
-
- 2 edits in trunk/Source/JavaScriptCore
FunctionPtr should accept FASTCALL functions on X86
https://bugs.webkit.org/show_bug.cgi?id=71434
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.
On X86 we sometimes use FASTCALL convention functions, for example the
cti functions, and we may need the pointers to such functions, e.g.,
in current DFG register file check and arity check, though long term
we may avoid such usage of cti calls in DFG.
- assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- 7:58 PM Changeset in webkit [99132] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427
Reviewed by Oliver Hunt.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::globalObjectFor):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 7:19 PM Changeset in webkit [99131] by
-
- 6 edits in trunk/LayoutTests
Add new StorageInfo test to the respective skip lists.
Unreviewed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 6:56 PM Changeset in webkit [99130] by
-
- 19 edits4 adds in trunk
Remove LegacyDefaultOptionalArguments flag from storage IDL files
https://bugs.webkit.org/show_bug.cgi?id=65744
Reviewed by Adam Barth.
Source/WebCore:
Test: storage/domstorage/localstorage/missing-arguments.html
- storage/DatabaseCallback.idl:
- storage/IDBRequest.idl:
- storage/IDBTransaction.idl:
- storage/SQLResultSetRowList.idl:
- storage/SQLStatementCallback.idl:
- storage/SQLStatementErrorCallback.idl:
- storage/SQLTransaction.idl:
- storage/SQLTransactionCallback.idl:
- storage/SQLTransactionErrorCallback.idl:
- storage/SQLTransactionSync.idl:
- storage/SQLTransactionSyncCallback.idl:
- storage/Storage.idl:
- storage/StorageInfo.idl:
- storage/StorageInfoErrorCallback.idl:
- storage/StorageInfoQuotaCallback.idl:
- storage/StorageInfoUsageCallback.idl:
LayoutTests:
- storage/domstorage/localstorage/missing-arguments-expected.txt: Added.
- storage/domstorage/localstorage/missing-arguments.html: Added.
- 6:53 PM Changeset in webkit [99129] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove some unnecessary loads/stores in DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=71090
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.
In fillSpeculateCell and OSR exit, some unnecessary loads/stores can
be eliminated.
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
- 6:28 PM Changeset in webkit [99128] by
-
- 6 edits in trunk/Source
Replace usage of StringImpl with String where possible in CharacterData and Text
https://bugs.webkit.org/show_bug.cgi?id=71383
Reviewed by Darin Adler.
Source/JavaScriptCore:
- wtf/text/WTFString.h:
(WTF::String::containsOnlyWhitespace): Added new method.
Source/WebCore:
Ryosuke Niwa, in http://webkit.org/b/70862, asked me to replace usages
of String with StringImpl. I've done more than what he asked in this
patch, the biggest change being that CharacterData now holds a String
instead of a RefPtr<StringImpl>.
No new tests, as this should have no effect on behavior.
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData):
(WebCore::CharacterData::substringData):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::appendData):
(WebCore::CharacterData::insertData):
(WebCore::CharacterData::deleteData):
(WebCore::CharacterData::replaceData):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::updateRenderer):
(WebCore::CharacterData::dispatchModifiedEvent):
- dom/CharacterData.h:
(WebCore::CharacterData::length):
(WebCore::CharacterData::dataImpl):
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::setDataWithoutUpdate):
- dom/Text.cpp:
(WebCore::Text::splitText):
- 5:55 PM Changeset in webkit [99127] by
-
- 5 edits5 deletes in trunk
REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=71424
Reviewed by Sam Weinig.
Tools:
Removed the ColorBits font and the code to register it in the process
running the tests. The font was only used by the aforementioned test,
which is now being removed.
- DumpRenderTree/fonts/ColorBits-A.png: Removed.
- DumpRenderTree/fonts/ColorBits.ttf: Removed.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::inititializeFontConfigSetting):
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
LayoutTests:
Removed this test and its results, because it was relying on a feature
that is no longer present in any OS X version. The color bitmap font
rendering code is now covered by another test.
- platform/mac/fonts/color-bitmap-expected.png: Removed.
- platform/mac/fonts/color-bitmap-expected.txt: Removed.
- platform/mac/fonts/color-bitmap.html: Removed.
- 5:25 PM Changeset in webkit [99126] by
-
- 56 edits in trunk/Source
De-virtualize JSObject::getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71307
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyNames):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
- debugger/DebuggerActivation.h:
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyNames):
- runtime/Arguments.h:
- runtime/ClassInfo.h:
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertyNames):
- runtime/JSActivation.h:
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
- runtime/JSArray.h:
- runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyNames):
- runtime/JSByteArray.h:
- runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyNames):
- runtime/JSCell.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
- runtime/JSFunction.h:
- runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyNames):
- runtime/JSNotAnObject.h:
- runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
- runtime/JSObject.h:
- runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::~JSVariableObject):
(JSC::JSVariableObject::getOwnPropertyNames):
- runtime/JSVariableObject.h:
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
- runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyNames):
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- runtime/StringObject.h:
- runtime/Structure.h:
Source/JavaScriptGlue:
Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- UserObjectImp.cpp:
(UserObjectImp::getOwnPropertyNames):
- UserObjectImp.h:
Source/WebCore:
No new tests.
Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- WebCore.exp.in:
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyNames):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertyNames):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertyNames):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::getOwnPropertyNames):
- bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
- bridge/qt/qt_runtime.h:
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyNames):
- bridge/runtime_array.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):
- bridge/runtime_object.h:
Source/WebKit2:
Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyNames):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- 5:16 PM Changeset in webkit [99125] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619
Skip some failing worker tests.
- platform/mac/Skipped:
- 5:12 PM Changeset in webkit [99124] by
-
- 2 edits in trunk/Tools
Fix an intermittent hang in RenderedImageFromDOMRange.
Reviewed by Anders Carlsson.
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
immediately if there are no sources by passing a date in the distant past.
- 5:02 PM Changeset in webkit [99123] by
-
- 1 edit1 add in trunk/Tools
Add git-add-reviewer
I've been using this script for a while to add reviewers to git commits in my local
repository before pushing them to the Subversion repository. Basic usage is:
git-add-reviewer HEAD "Joe Schmoe"
or
git-add-reviewer -i trunk
Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
git commits
Reviewed by Sam Weinig.
- Scripts/git-add-reviewer: Added.
(top level): Parse options, check that the working tree is clean, then run in either
interactive or non-interactive mode as appropriate.
(interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
editor exits, we check out the commit just before the earliest one we're modifying. Then
for each commit, we check it out, update the reviewer, and amend the commit to contain the
new reviewer. Finally, we update the branch that was originally checked out to point to the
last amended commit.
(nonInteractive): Check out the commit to modify, write the current commit message to the
MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
the commit, and rebase the original branch on top of the amended commit. (usage): Print out
a usage message and exit.
(requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
and index are clean.
(fail): Print out the specified error message, if any, and return false. This function is
used as a return value in various error cases throughout the script.
(cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
(addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
to .git/MERGE_MSG, which will be used as the commit message for the next commit.
(commit): Call git-commit and use .git/MERGE_MSG as the commit message.
(addReviewerToChangeLog):
(addReviewerToCommitMessage):
These just call through to addReviewerToFile.
(addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
temp file, then move the temp file over the original file and stage it for the next commit.
(head): Returns the name of the currently-checked-out branch.
(isAncestor): Returns true if the first commit is an ancestor of the second.
(toCommit): Converts a commitish to a commit ID using git-rev-parse.
(changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
(resetToCommit): Checks out the given commit, throwing away any local changes.
(writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
the specified file.
(rebaseOntoHead): Rebases the specified branch onto HEAD.
(checkout): Checks out the given commit.
(getConfigValue): Reads the specified config variable from git-config.
- 4:57 PM Changeset in webkit [99122] by
-
- 2 edits in trunk/Source/WebKit2
Don't call NPP_SetWindow if the plug-in size or clip rect hasn't changed if the plug-in isn't using window relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71418
Reviewed by Adam Roben.
This avoids calling into the plug-in when only the plug-in position relative to the window changes.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
- 4:43 PM Changeset in webkit [99121] by
-
- 2 edits in trunk/Source/WebKit2
Fix syntax error.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- 4:30 PM Changeset in webkit [99120] by
-
- 3 edits2 adds in trunk
force inline flexitems to be wrapped in anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=71314
Reviewed by Ojan Vafai.
Source/WebCore:
If there is a mix of inline and block items, all the inline items were already getting wrapped
(see RenderBlock::addChildIgnoringAnonymousColumnBlocks). However, if there are only inline items,
we need to force them into an anonymous block.
There are still lots of bugs because we're trying to read style values from the anonymous block,
but this at least causes layout to be called on all the render objects.
Tests: css3/flexbox/anonymous-block.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox): force children into blocks
LayoutTests:
- css3/flexbox/anonymous-block-expected.html: Added.
- css3/flexbox/anonymous-block.html: Added.
- 4:22 PM Changeset in webkit [99119] by
-
- 2 edits in trunk/Source/WebKit2
Fix build error from r99108.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- 4:17 PM Changeset in webkit [99118] by
-
- 13 edits in trunk
Add ENABLE_CSS_SHADERS flag
https://bugs.webkit.org/show_bug.cgi?id=71394
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 4:14 PM Changeset in webkit [99117] by
-
- 6 edits in trunk/Source/WebKit2
Allow the various plug-in ports to decide whether NPWindow coordinates should be window-relative
https://bugs.webkit.org/show_bug.cgi?id=71415
Reviewed by Darin Adler.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
Remove the PLUGIN_ARCHITECTURE(X11) ifdef and set the NPWindow members
based on the return value of wantsWindowRelativeNPWindowCoordinates.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Add platform specific implementations.
- 4:02 PM Changeset in webkit [99116] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK] Debug build broken after r99065
https://bugs.webkit.org/show_bug.cgi?id=71397
Remove reference to panGestureActive becuase it is not defined anywhere.
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Simon Hausmann.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::panGestureStarted):
- 4:01 PM Changeset in webkit [99115] by
-
- 3 copies in branches/chromium/874/LayoutTests
Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Checking that embedded SVG is in an SVG document before negotiating size
with the host document.
Test: svg/as-object/svg-embedded-in-html-in-iframe.html
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
Fixing a bug where SVG negotiated size when embedded in html inside an iframe.
- platform/chromium/test_expectations.txt: Will update with results on other platforms.
- platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
- platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
- svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
TBR=leviw@chromium.org
Review URL: http://codereview.chromium.org/8439060
- 4:00 PM Changeset in webkit [99114] by
-
- 7 edits in trunk/LayoutTests
Remove references to non existing file; js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=71398
Reviewed by Ojan Vafai.
This js file no longer exists and the code it defined is now in js-test-pre.js.
- fast/events/touch/gesture/gesture-scroll.html:
- storage/indexeddb/factory-deletedatabase-interactions.html:
- storage/indexeddb/factory-deletedatabase.html:
- storage/indexeddb/open-during-transaction.html:
- storage/indexeddb/version-change-abort-expected.txt:
- storage/indexeddb/version-change-abort.html:
- 3:53 PM Changeset in webkit [99113] by
-
- 4 edits in trunk/Source/WebCore
Switch RenderText to new layout types
https://bugs.webkit.org/show_bug.cgi?id=71389
Reviewed by Eric Seidel.
Switch RenderText methods (and overriden methods in related classes) to
LayoutRect/LayoutUnit.
No new tests.
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):
- rendering/RenderText.h:
Change RenderText to expose its bounding box, selection and caret rects
as LayoutRects.
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
- rendering/svg/RenderSVGInlineText.h:
Change localCaretRect to return a LayoutRect.
- 3:47 PM Changeset in webkit [99112] by
-
- 2 edits in trunk/Source/WebKit2
Update dragging info on mac when user is dragging files into view
https://bugs.webkit.org/show_bug.cgi?id=71325
<rdar://problem/10379193>
Reviewed by Darin Adler.
- UIProcess/API/mac/WKView.mm:
(-[WKView draggingUpdated:]): Based on the DragSession, we update NSDraggingInfo
to update the badge and dragging formation.
- 3:44 PM Changeset in webkit [99111] by
-
- 2 edits3 moves29 adds3 deletes in trunk/LayoutTests
Land chromium baselines for tests added in r94912.
- fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt.
- fast/borders/inline-mask-overlay-image-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt.
- fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt.
- platform/chromium-cg-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-linux/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-outset-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
- platform/chromium-win/fast/borders/border-image-outset-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-outset-expected.txt: Added.
- platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
- platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
- platform/chromium/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
- platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
- platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.
- 3:42 PM Changeset in webkit [99110] by
-
- 7 edits64 deletes in trunk/LayoutTests
Remove <track>-related LayoutTests that don't actually work yet.
https://bugs.webkit.org/show_bug.cgi?id=71378
Reviewed by Eric Carlson.
- media/track/track-mutable-expected.txt: Removed.
- media/track/track-mutable.html: Removed.
- media/track/track-text-track-cue-list-expected.txt: Removed.
- media/track/track-text-track-cue-list.html: Removed.
- media/track/track-text-track-expected.txt: Removed.
- media/track/track-text-track.html: Removed.
- media/track/track-webvtt-tc000-empty-expected.txt: Removed.
- media/track/track-webvtt-tc000-empty.html: Removed.
- media/track/track-webvtt-tc001-utf8-expected.txt: Removed.
- media/track/track-webvtt-tc001-utf8.html: Removed.
- media/track/track-webvtt-tc002-bom-expected.txt: Removed.
- media/track/track-webvtt-tc002-bom.html: Removed.
- media/track/track-webvtt-tc003-newlines-expected.txt: Removed.
- media/track/track-webvtt-tc003-newlines.html: Removed.
- media/track/track-webvtt-tc004-magic-header-expected.txt: Removed.
- media/track/track-webvtt-tc004-magic-header.html: Removed.
- media/track/track-webvtt-tc005-header-comment-expected.txt: Removed.
- media/track/track-webvtt-tc005-header-comment.html: Removed.
- media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Removed.
- media/track/track-webvtt-tc006-cue-identifiers.html: Removed.
- media/track/track-webvtt-tc007-cue-no-id-expected.txt: Removed.
- media/track/track-webvtt-tc007-cue-no-id.html: Removed.
- media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Removed.
- media/track/track-webvtt-tc008-timings-no-hours.html: Removed.
- media/track/track-webvtt-tc009-timings-hour-expected.txt: Removed.
- media/track/track-webvtt-tc009-timings-hour.html: Removed.
- media/track/track-webvtt-tc010-no-timings-expected.txt: Removed.
- media/track/track-webvtt-tc010-no-timings.html: Removed.
- media/track/track-webvtt-tc011-blank-lines-expected.txt: Removed.
- media/track/track-webvtt-tc011-blank-lines.html: Removed.
- media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
- media/track/track-webvtt-tc012-out-of-order.html: Removed.
- media/track/track-webvtt-tc013-settings-expected.txt: Removed.
- media/track/track-webvtt-tc013-settings.html: Removed.
- media/track/track-webvtt-tc014-alignment-expected.txt: Removed.
- media/track/track-webvtt-tc014-alignment.html: Removed.
- media/track/track-webvtt-tc015-positioning-expected.txt: Removed.
- media/track/track-webvtt-tc015-positioning.html: Removed.
- media/track/track-webvtt-tc016-align-positioning-expected.txt: Removed.
- media/track/track-webvtt-tc016-align-positioning.html: Removed.
- media/track/track-webvtt-tc017-line-position-expected.txt: Removed.
- media/track/track-webvtt-tc017-line-position.html: Removed.
- media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Removed.
- media/track/track-webvtt-tc018-align-text-line-position.html: Removed.
- media/track/track-webvtt-tc019-cue-size-expected.txt: Removed.
- media/track/track-webvtt-tc019-cue-size.html: Removed.
- media/track/track-webvtt-tc020-cue-size-align-expected.txt: Removed.
- media/track/track-webvtt-tc020-cue-size-align.html: Removed.
- media/track/track-webvtt-tc021-valign-expected.txt: Removed.
- media/track/track-webvtt-tc021-valign.html: Removed.
- media/track/track-webvtt-tc022-entities-expected.txt: Removed.
- media/track/track-webvtt-tc022-entities.html: Removed.
- media/track/track-webvtt-tc023-markup-expected.txt: Removed.
- media/track/track-webvtt-tc023-markup.html: Removed.
- media/track/track-webvtt-tc024-timestamp-expected.txt: Removed.
- media/track/track-webvtt-tc024-timestamp.html: Removed.
- media/track/track-webvtt-tc025-class-markup-expected.txt: Removed.
- media/track/track-webvtt-tc025-class-markup.html: Removed.
- media/track/track-webvtt-tc026-voice-expected.txt: Removed.
- media/track/track-webvtt-tc026-voice.html: Removed.
- media/track/track-webvtt-tc027-empty-cue-expected.txt: Removed.
- media/track/track-webvtt-tc027-empty-cue.html: Removed.
- media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Removed.
- media/track/track-webvtt-tc028-unsupported-markup.html: Removed.
- platform/chromium/test_expectations.txt: Remove all, remaining tests currently pass.
- platform/gtk/Skipped: Remove all, remaining tests currently pass.
- platform/mac/Skipped: Make sure all are skipped, <track> not enabled.
- platform/qt/Skipped: Remove all, remaining tests currently pass.
- platform/win/Skipped: Make sure all are skipped, <track> not enabled.
- platform/wk2/Skipped: Remove all, remaining tests currently pass.
- 3:35 PM Changeset in webkit [99109] by
-
- 4 edits3 adds in trunk
Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384
Reviewed by Darin Adler.
Source/WebCore:
Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.
Test: svg/custom/resource-invalidation-crash.svg
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
- rendering/svg/RenderSVGResourceContainer.h:
LayoutTests:
Fixes a stack overflow when SVG resources reference one another and share ids.
- svg/custom/resource-invalidation-crash-expected.png: Added.
- svg/custom/resource-invalidation-crash-expected.txt: Added.
- svg/custom/resource-invalidation-crash.svg: Added.
- 3:32 PM Changeset in webkit [99108] by
-
- 35 edits1 copy in trunk
Expand DragController to provide more information about the dragging session
https://bugs.webkit.org/show_bug.cgi?id=71324
<rdar://problem/10379175>
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- page/DragController.cpp:
(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag): In addition to determining the
drag operation, DragSession is updated with data regarding whether the mouse
is over a file input, and the number of items that would be accepted based on
the mouse's location.
- page/DragController.h:
- page/DragSession.h: Added.
(WebCore::DragSession::DragSession): Keep track of current operation, whether
the mouse is over a file input element, and how many files would be accepted if
dropped.
- platform/DragData.h: Added numberOfFiles()
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::numberOfFiles):
- platform/efl/DragDataEfl.cpp:
(WebCore::DragData::numberOfFiles):
- platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::numberOfFiles):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::numberOfFiles):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::numberOfFiles):
- platform/win/DragDataWin.cpp:
(WebCore::DragData::numberOfFiles):
- platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::numberOfFiles):
- platform/wx/DragDataWx.cpp:
(WebCore::DragData::numberOfFiles):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::dragTargetDragEnterOrOver): The drag operation is contained
within the new DragSession struct. Minor refactor.
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_drag_motion): Minor refactoring.
(webkit_web_view_drag_data_received): Minor refactoring.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
(-[WebView draggingUpdated:]):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent): Minor refactoring because operation is stored in
new DragSession struct.
(QWebPagePrivate::dragMoveEvent): Ditto.
Source/WebKit/win:
- WebView.cpp:
(WebView::DragEnter): Minor refactoring because operation is stored in
new DragSession struct.
(WebView::DragOver): Ditto.
Source/WebKit2:
We now pass the DragSession struct from the Web to the UI process, instead of the
DragOperation enum.
- Scripts/webkit2/messages.py:
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView draggingUpdated:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): We now cache the last known DragSession state
(WebKit::WebPageProxy::didPerformDragControllerAction):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::dragSession):
(WebKit::WebPageProxy::resetDragOperation):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
LayoutTests:
- editing/pasteboard/script-tests/file-input-files-access.js:
(runTest): Change the expected behavior of the test-- dragging a file over a disabled
control should not load that file. Instead, the file should be ignored, and the page
remains as is.
- 3:26 PM Changeset in webkit [99107] by
-
- 9 edits in trunk/Source/WebKit2
Get rid of Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71411
Reviewed by Sam Weinig.
Now that all Plugin subclasses implement geometryDidChange and do all the work there
we can get rid of deprecatedGeometryDidChange.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
- 3:25 PM Changeset in webkit [99106] by
-
- 5 edits in trunk/Tools
BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
https://bugs.webkit.org/show_bug.cgi?id=71237
Reviewed by Adam Barth.
Calling the static version of factory.get() with proper mocking
requires passsing an explict filesystem, executive, etc.
So instead, we use a PortFactory instance and pass it a Host pointer.
I had to add a MockHost since we'd not needed a non-host tool before now.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/mocktool.py:
- 3:25 PM Changeset in webkit [99105] by
-
- 3 edits1 delete in trunk/LayoutTests
Update chromium results for printing tests.
- platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
- platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:24 PM Changeset in webkit [99104] by
-
- 2 edits in trunk/Source/WebCore
Emedded PDFs cannot be opened from Web archives
https://bugs.webkit.org/show_bug.cgi?id=70954
Reviewed by Oliver Hunt.
BuiltInPDFPlugin doesn't have access to original ResourceResponse and has to re-create it
It doesn't seem to be possible to create an NSURLResponse with a non-null HTTP status code,
and NetscapePlugInStreamLoader becomes unhappy.
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
Allow 0 status code, it's not a real error to have one in response.
- 3:13 PM Changeset in webkit [99103] by
-
- 3 edits in trunk/Tools
Update for the WebKit2 API fixage.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 3:06 PM Changeset in webkit [99102] by
-
- 2 edits in trunk/Source/WebKit2
Move back functions that were not added.
- UIProcess/API/C/WKPage.h:
- 3:01 PM Changeset in webkit [99101] by
-
- 7 edits in trunk
Source/WebKit2: Fix build and WebKit2 ABI.
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
Add page loader client sizes.
- UIProcess/API/C/WKPage.h:
Move the newly added callback functions in the loader client last and bump the
WKPageLoaderClient version.
Tools: Fix build.
Add new functions to the page loader client.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 2:57 PM Changeset in webkit [99100] by
-
- 11 edits in trunk/Source
[chromium] Slow down commit and draw rate based on visibility and draw completion
https://bugs.webkit.org/show_bug.cgi?id=71267
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::visible):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::visible):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::visible):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
- tests/CCSchedulerTest.cpp:
(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::setVisible):
(WebKitTests::FakeCCSchedulerClient::visible):
(WebKitTests::TEST):
- 2:46 PM Changeset in webkit [99099] by
-
- 9 edits1 add in trunk
<rdar://problem/10336700> Add API to get rendered text image without having to select it
https://bugs.webkit.org/show_bug.cgi?id=71407
Reviewed by Simon Fraser.
Source/WebCore:
Test: TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:]): Added.
- bindings/objc/DOMPrivate.h:
- page/Frame.h:
- page/mac/FrameMac.mm:
(WebCore::Frame::rangeImage): Added. Sets the selection in the RenderView (only) based on the
given range and gets a selection-only rendering of the view, then restores the selection.
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Skip all invalidation if the repaint behavior is RepaintNothing.
(WebCore::RenderView::getSelection): Added this getter.
- rendering/RenderView.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
(-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
- 2:43 PM Changeset in webkit [99098] by
-
- 2 edits in trunk/Tools
Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
https://bugs.webkit.org/show_bug.cgi?id=71351
Reviewed by Darin Adler.
Add the delimiter "/" at the end of the path instead of adding +1 when using
the path.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSURL _drt_descriptionSuitableForTestResult]):
- 2:36 PM Changeset in webkit [99097] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/Plugins/PluginView.h:
- 2:05 PM Changeset in webkit [99096] by
-
- 54 edits2 adds in trunk
XSSAuditor is silent
https://bugs.webkit.org/show_bug.cgi?id=70973
Patch by Tom Sepez <tsepez@chromium.org> on 2011-11-02
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/script-tag-with-callbacks.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didDetectXSS):
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didDetectXSS):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didDetectXSS):
- src/FrameLoaderClientImpl.h:
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didDetectXSS):
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didDetectXSS):
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::didRunInsecureContent):
(WebFrameLoaderClient::didDetectXSS):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebFrameLoadDelegatePrivate.h:
- WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]):
Source/WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didDetectXSS):
- WebCoreSupport/FrameLoaderClientQt.h:
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didDetectXSS):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::didDetectXSS):
- WebCoreSupport/FrameLoaderClientWinCE.h:
Source/WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didDetectXSS):
- WebKitSupport/FrameLoaderClientWx.h:
Source/WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientAttachLoaderClientToPage):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didDetectXSSForFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didDetectXSSForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didDetectXSS):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didDetectXSS):
- DumpRenderTree/chromium/WebViewHost.h:
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didDetectXSS:]):
- MiniBrowser/mac/BrowserWindowController.m:
(didDetectXSSForFrame):
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didDetectXSSForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
LayoutTests:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-callbacks.html: Added.
- 2:02 PM Changeset in webkit [99095] by
-
- 2 edits in trunk/Source/WebCore
Assertion in FontCache::getCachedFontData() when painting into composited layer
https://bugs.webkit.org/show_bug.cgi?id=71377
Reviewed by Anders Carlsson.
Add one of the mysterious FontCachePurgePreventers on the stack when painting
compositing layers, just as FrameView::paintContents does, to fix an assertion
seen on the bots with some layout tests.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
- 2:01 PM Changeset in webkit [99094] by
-
- 3 edits in trunk/Source/WebKit2
More window relative coordinate usage removal
https://bugs.webkit.org/show_bug.cgi?id=71393
Reviewed by Adam Roben.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
Just use m_clipRect instead of converting m_clipRectInWindowCoordinates to plug-in coordinates.
(WebKit::NetscapePlugin::platformPaint):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPaint):
Ditto.
- 1:57 PM Changeset in webkit [99093] by
-
- 14 edits in trunk/Source/WebKit2
Fix non-Mac builds and remove #if PLATFORM(MAC) around all contents scale factor functions.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::contentsScaleFactor):
(WebKit::PluginControllerProxy::geometryDidChange):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
- PluginProcess/PluginCreationParameters.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::contentsScaleFactor):
(WebKit::NetscapePlugin::getAuthenticationInfo):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::contentsScaleFactorChanged):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::contentsScaleFactorChanged):
(WebKit::PluginProxy::contentsScaleFactor):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::contentsScaleFactor):
- 1:28 PM Changeset in webkit [99092] by
-
- 2 edits in trunk/Source/WebKit2
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in NetscapePlugin.
https://bugs.webkit.org/show_bug.cgi?id=71390
Reviewed by Adam Roben.
m_pluginSize is always equal to m_frameRectInWindowCoordinates.size() and this moves us one
sall step further towards eliminating m_frameRectInWindowCoordinates.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::snapshot):
- 1:12 PM Changeset in webkit [99091] by
-
- 2 edits in trunk/Source/WebKit2
Fix non-Mac builds.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
- 1:05 PM Changeset in webkit [99090] by
-
- 3 edits in trunk/Source/WebKit2
Plug-in snapshots are blurry in HiDPI
https://bugs.webkit.org/show_bug.cgi?id=71387
<rdar://problem/10385393>
Reviewed by Adam Roben.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
Create the backing store in the right size and apply the contents scale factor
to the newly created graphics context.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
Pass the scale factor to ShareableBitmap::paint.
- 12:28 PM Changeset in webkit [99089] by
-
- 4 edits in trunk/Source/JavaScriptCore
TEXTREL in libjavascriptcoregtk-1.0.so.0.11.0 on x86 (or i586)
https://bugs.webkit.org/show_bug.cgi?id=70610
Patch by Alexey Shabalin <a.shabalin@gmail.com> on 2011-11-02
Reviewed by Martin Robinson.
Properly annotate ASM on BSD and Linux x86 systems.
- dfg/DFGOperations.cpp: Add annotation for X86.
- jit/JITStubs.cpp: Ditto.
- jit/ThunkGenerators.cpp: Ditto.
- 12:12 PM Changeset in webkit [99088] by
-
- 4 edits7 moves9 adds2 deletes in trunk/LayoutTests
Land chromium win/leopard baselines for printing/setPrinting.html and printing single-line-must-not-be-split-into-two-pages.html.
- platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Added.
- platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/printing/setPrinting-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/setPrinting-expected.png.
- platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png.
- platform/chromium-linux/printing/setPrinting-expected.txt: Removed.
- platform/chromium-mac-leopard/printing/setPrinting-expected.png: Added.
- platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Added.
- platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
- platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Renamed from LayoutTests/platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt.
- platform/chromium-mac-snowleopard/printing/setPrinting-expected.png: Renamed from LayoutTests/platform/chromium-mac/printing/setPrinting-expected.png.
- platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Renamed from LayoutTests/platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png.
- platform/chromium-mac/printing/setPrinting-expected.txt: Removed.
- platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png:
- platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
- platform/chromium/printing/setPrinting-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/setPrinting-expected.txt.
- platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt.
- platform/chromium/test_expectations.txt:
- 12:11 PM Changeset in webkit [99087] by
-
- 3 edits in trunk/Source/WebCore
MediaStreamRegistry should hold references to MediaStreamDescriptor rather than MediaStream
https://bugs.webkit.org/show_bug.cgi?id=70896
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-02
Reviewed by Adam Barth.
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerMediaStreamURL):
(WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamDescriptor):
- mediastream/MediaStreamRegistry.h:
- 11:53 AM Changeset in webkit [99086] by
-
- 3 edits2 adds in trunk
Match allowed CSS string characters to Firefox and Opera browsers
https://bugs.webkit.org/show_bug.cgi?id=71000
Reviewed by Darin Adler.
Source/WebCore:
Firefox and Opera accepts any character inside a string except
newline and starting quote character. This behaviour matches to
the CSS 2.1 grammar: http://www.w3.org/TR/CSS2/grammar.html
WebKit should follow them.
Test: fast/css/parsing-css-allowed-string-characters.html
- css/tokenizer.flex:
LayoutTests:
Add a new test case which contains various uncommon characters.
- fast/css/parsing-css-allowed-string-characters-expected.txt: Added.
- fast/css/parsing-css-allowed-string-characters.html: Added.
- 11:43 AM Changeset in webkit [99085] by
-
- 3 edits2 adds in trunk
Assert in MoveSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=70277
Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-11-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
A MoveSelectionCommand should be fired only if the selection type is
RangeSelection, since nothing is selected in other cases.
Test: fast/events/drag-link.html
- page/DragController.cpp:
(WebCore::DragController::dragIsMove):
LayoutTests:
Test to drag-drop anchor element on an already focused editable div
element.
- fast/events/drag-link-expected.txt: Added.
- fast/events/drag-link.html: Added.
- 11:40 AM Changeset in webkit [99084] by
-
- 2 edits in trunk/LayoutTests
Try to deflake http/tests/multipart/policy-ignore-crash.php by
flushing the output buffer. For some reason, the <script> in the
first frame isn't running.
- http/tests/multipart/policy-ignore-crash.php:
- 11:35 AM Changeset in webkit [99083] by
-
- 28 edits in trunk/Source
<input=file multiple> default text uses singular instead of plural
https://bugs.webkit.org/show_bug.cgi?id=71319
<rdar://problem/10379021>
Reviewed by Darin Adler.
Source/WebCore:
Added a new method to return the label text for a file upload control that
allows multiple files. Needed to extend the RenderTheme function to pass down
a boolean representing whether multiple files are allowed in the file list.
- English.lproj/Localizable.strings:
- html/FileInputType.cpp:
(WebCore::FileInputType::defaultToolTip):
- platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::fileButtonNoFilesSelectedLabel):
- platform/DefaultLocalizationStrategy.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp:
(WebCore::fileButtonNoFilesSelectedLabel):
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::fileButtonNoFilesSelectedLabel):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::fileButtonNoFilesSelectedLabel):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::fileListNameForWidth):
- platform/gtk/RenderThemeGtk.h:
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth):
- platform/qt/RenderThemeQt.h:
- platform/wx/LocalizedStringsWx.cpp:
(WebCore::fileButtonNoFilesSelectedLabel):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::fileTextValue):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::fileListNameForWidth):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::fileListNameForWidth):
Source/WebKit/chromium:
- src/LocalizedStrings.cpp:
(WebCore::fileButtonNoFilesSelectedLabel):
Source/WebKit/qt:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::fileButtonNoFilesSelectedLabel):
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::fileButtonNoFilesSelectedLabel):
- WebCoreSupport/PlatformStrategiesWinCE.h:
- 11:10 AM Changeset in webkit [99082] by
-
- 35 edits in trunk
[GTK] Visited links of a page group should be removed when clearing back/forward list
https://bugs.webkit.org/show_bug.cgi?id=71052
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-02
Reviewed by Martin Robinson.
Source/WebKit/gtk:
When clearing back-forward list, also remove the visited links from page's page group.
- webkit/webkitwebbackforwardlist.cpp:
(webkit_web_back_forward_list_clear):
LayoutTests:
Rebaseline Gtk-related expectations now that links to previously loaded tests do not
appear as visited after enhancing the clearing of back-forward list that is done after
each test.
- platform/gtk/fast/block/margin-collapse/010-expected.txt:
- platform/gtk/fast/block/margin-collapse/011-expected.txt:
- platform/gtk/fast/block/margin-collapse/012-expected.txt:
- platform/gtk/fast/block/margin-collapse/015-expected.txt:
- platform/gtk/fast/block/margin-collapse/016-expected.txt:
- platform/gtk/fast/block/margin-collapse/020-expected.txt:
- platform/gtk/fast/block/margin-collapse/056-expected.txt:
- platform/gtk/fast/block/margin-collapse/059-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- 11:09 AM Changeset in webkit [99081] by
-
- 4 edits in trunk
[Qt] REGRESSION: 5 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=71117
Reviewed by Andreas Kling.
Tools:
Make sure that the view is properly focused, in order to get the
didBeginEditing DRT calls.
This requires activating the window (the call will result in a FocusIn
event to the window as well as setting QGuiApplication::focusWindow())
as well as enabling the focus on the view item. The signature of
setFocus has changed to take a boolean.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
LayoutTests:
- platform/qt-5.0/Skipped: Unskip tests that now pass.
- 11:07 AM Changeset in webkit [99080] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Brought back suppressions for setPrinting.html and printing/single-line-must-not-be-split-into-two-pages.html for
Win and 10.5.
- platform/chromium/test_expectations.txt:
- 10:54 AM Changeset in webkit [99079] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix the build with NO_LISTBOX_RENDERING
Unreviewed build fix after r99035.
Patch by Michael Bruning <michael.bruning@nokia.com>
No new tests needed.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxSelectItem):
- 10:52 AM Changeset in webkit [99078] by
-
- 2 edits in trunk/LayoutTests
Cleanup chromium test_expectations.txt.
- platform/chromium/test_expectations.txt: Remove stale commented out lines.
Mark fast/frames/calculate-fixed.html as slow for mac debug (based on flakiness dashboard).
- 10:49 AM Changeset in webkit [99077] by
-
- 17 edits2 adds in trunk/Source/WebKit2
[Qt] Implement message exchange between WebView and the web page
https://bugs.webkit.org/show_bug.cgi?id=70545
Reviewed by Noam Rosenthal.
Adds a mechanism for the WebView to send messages to the JavaScript environment
of the web page. In the WebView we have a method postMessage() and a signal
messageReceived(), while in the web page we expose a navigator.qt object with a
postMessage() method and a onmessage property. The messages are objects that
follow the same structure as MessageEvents.
The feature is disabled by default, and can be enabled by setting
QWebPreferences::navigatorQtObjectEnabled property to true. Changes take effect
after the next load(). QML tests are included.
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/ClientImpl.cpp:
(setupContextInjectedBundleClient): Helper to register the injected bundle client.
(qt_wk_didReceiveMessageFromInjectedBundle): Decode and dispatch a message received
from the WebProcess to the WebPageProxy.
- UIProcess/PageClient.h:
(WebKit::PageClient::didReceiveMessageFromNavigatorQtObject):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessageFromNavigatorQtObject):
- UIProcess/WebPageProxy.h:
Handle messages received from the navigator.qt object via the injected bundle. Called
from the ClientImpl.
- UIProcess/API/qt/qbasewebview.cpp:
(QBaseWebView::postMessage):
(QBaseWebViewPrivate::setPageProxy):
- UIProcess/API/qt/qbasewebview.h:
- UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferences::navigatorQtObjectEnabled):
(QWebPreferences::setNavigatorQtObjectEnabled):
- UIProcess/API/qt/qwebpreferences.h:
The signal, slot and the setting to enable the feature.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::defaultWKContext): setup the injected bundle client for this the
default context so we can listen to messages from it.
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didReceiveMessageFromNavigatorQtObject):
(QtWebPageProxy::setNavigatorQtObjectEnabled):
(QtWebPageProxy::postMessageToNavigatorQtObject):
- UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::navigatorQtObjectEnabled):
Enabling and sending messages to the navigator.qt object are done by sending messages to
the injected bundle, identifying the page that we want to act on.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/messaging.html: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- WebProcess/qt/QtBuiltinBundle.cpp:
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didReceiveMessage):
(WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject):
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):
- WebProcess/qt/QtBuiltinBundle.h:
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::didClearWindowForFrame):
(WebKit::qt_postMessageCallback):
(WebKit::QtBuiltinBundlePage::postMessageFromNavigatorQtObject):
(WebKit::createWrappedMessage):
(WebKit::QtBuiltinBundlePage::didReceiveMessageToNavigatorQtObject):
(WebKit::QtBuiltinBundlePage::setNavigatorQtObjectEnabled):
(WebKit::QtBuiltinBundlePage::registerNavigatorQtObject):
(WebKit::QtBuiltinBundlePage::navigatorQtObjectClass):
- WebProcess/qt/QtBuiltinBundlePage.h:
(WebKit::QtBuiltinBundlePage::navigatorQtObjectEnabled):
- 10:12 AM Changeset in webkit [99076] by
-
- 3 edits2 adds in trunk
div { display: none; } makes pasting into text fields impossible
https://bugs.webkit.org/show_bug.cgi?id=27683
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by insertFragmentForTestRendering's always inserting a node for test rendering
into document's body.
Fixed the bug by inserting the node for test rendering into the root editable element. In addition,
remove the node before dispatching beforeTextInserted event to avoid event listeners, in particular
TextFieldInputType::handleBeforeTextInsertedEvent, from seeing the test node.
Test: editing/pasteboard/input-with-display-none-div.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
LayoutTests:
Add a test to insert contents into an input element inside a page
with div { display: none; }
- editing/pasteboard/input-with-display-none-div-expected.txt: Added.
- editing/pasteboard/input-with-display-none-div.html: Added.
- 9:59 AM Changeset in webkit [99075] by
-
- 2 edits1 move6 adds2 deletes in trunk/LayoutTests
Add chromium test results for fast/reflections/reflection-masks-outset.html
- fast/reflections/reflection-masks-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/reflections/reflection-masks-outset-expected.txt.
- platform/chromium-cg-mac-leopard/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/chromium-win/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/reflections/reflection-masks-outset-expected.txt: Removed.
- platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Removed.
- 9:48 AM Changeset in webkit [99074] by
-
- 1 edit in branches/chromium/912/Source/WebCore/css/CSSParser.cpp
Merge 98374
BUG=101010
Review URL: http://codereview.chromium.org/8386038
- 9:46 AM Changeset in webkit [99073] by
-
- 8 edits in trunk/Source/WebKit2
[Qt] Fix qmltest API test failures related to r98973.
https://bugs.webkit.org/show_bug.cgi?id=71280
Reviewed by Noam Rosenthal.
Most of the API was moved from TouchWebView.page to TouchWebView directly.
Fixed the qml tests to reflect this change.
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
- 9:45 AM Changeset in webkit [99072] by
-
- 2 edits in trunk/Source/JavaScriptCore
Missing Force8BitConstructor in 8-bit version of StringImpl::reallocate()
https://bugs.webkit.org/show_bug.cgi?id=71347
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-02
Reviewed by Geoffrey Garen.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
- 9:44 AM Changeset in webkit [99071] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=62108
Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-11-02
Reviewed by Simon Hausmann.
Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::committedLoad):
(WebCore::FrameLoaderClientQt::shouldFallBack):
- 9:40 AM Changeset in webkit [99070] by
-
- 5 edits in trunk/Tools
[chromium] Add per-script font preferences support in overridePreference
https://bugs.webkit.org/show_bug.cgi?id=71110
This allows a layout test to do something like:
Set standard font for Arabic to Ahem.
overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
This should make writing a layout test for per-script fonts easier.
This change only affects the Chromium DumpRenderTree, but the other
platforms should probably also have a similar change eventually.
Patch by Matt Falkenhagen <falken@chromium.org> on 2011-11-02
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
font preferences to overridePreference
(LayoutTestController::cppVariantToWebStringArray):
(setFontMap):
(LayoutTestController::overridePreference):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/WebPreferences.cpp:
(setStandardFontFamilyWrapper):
(setFixedFontFamilyWrapper):
(setSerifFontFamilyWrapper):
(setSansSerifFontFamilyWrapper):
(setCursiveFontFamilyWrapper):
(setFantasyFontFamilyWrapper):
(applyFontMap):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h: add per-script font
preference members
(WebPreferences::UScriptCodeHashTraits::emptyValue):
(WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
(WebPreferences::UScriptCodeHashTraits::isDeletedValue):
- 9:40 AM Changeset in webkit [99069] by
-
- 2 edits in trunk/LayoutTests
Fix a typo in the expected result added by r98989.
- platform/mac/svg/filters/invalidate-on-child-layout-expected.txt:
- 9:27 AM Changeset in webkit [99068] by
-
- 4 edits in trunk/Tools
until use_skia=1 by default on mac, default port should be chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71312
Patch by Elliot Poger <epoger@google.com> on 2011-11-02
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- 9:22 AM Changeset in webkit [99067] by
-
- 3 edits4 adds in trunk
REGRESSION(r96870): WebKit generates background: transparent on blogger.com
https://bugs.webkit.org/show_bug.cgi?id=71203
Reviewed by Ojan Vafai.
Source/WebCore:
Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.
Tests: editing/deleting/merge-paragraphs-with-transparent-background.html
editing/deleting/paste-with-transparent-background-color.html
- editing/EditingStyle.cpp:
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
LayoutTests:
Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.
WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.
- editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
- editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
- editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
- editing/deleting/paste-with-transparent-background-color.html: Added.
- 9:14 AM Changeset in webkit [99066] by
-
- 4 edits4 adds in trunk
printing layout test failures after r98634
https://bugs.webkit.org/show_bug.cgi?id=71080
Tools:
Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-02
Reviewed by Kent Tamura
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
matches that for Skia.
LayoutTests:
Added CG specific expected results.
Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-02
Reviewed by Kent Tamura
- platform/chromium-cg-mac/printing/setPrinting-expected.png: Added.
- platform/chromium-cg-mac/printing/setPrinting-expected.txt: Added.
- platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
- platform/chromium-cg-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
- platform/chromium/test_expectations.txt: Removed expectation of failure.
- 9:14 AM Changeset in webkit [99065] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Handle interruption of page interaction better
https://bugs.webkit.org/show_bug.cgi?id=71366
Reviewed by Simon Hausmann.
Touching the screen when a kinetic scrolling animation is running or
it is bouncing back because it was out of bounds, the animation is
immediately stopped and the content is immediately put into valid
bounds.
Touching the screen when the contents is bouncing back from a pinch
zoom which was out of bounds, we do not stop the animation, but
instead ignored the touch events while the animation lasts.
In the future we want to queue the events instead.
This also fixes some issues which was present before: As the bounce
back animation from pinch zoom centers the content using the contents
point which was in the center of the viewport, this animation could
not be used when stopping a pan animation, as it wouldn't position the
content at the place it was when the pan animation was interrupted.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::panAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::pinchAnimationActive):
- UIProcess/qt/QtViewportInteractionEngine.h:
- 9:11 AM Changeset in webkit [99064] by
-
- 2 edits in trunk/Tools
Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
https://bugs.webkit.org/show_bug.cgi?id=71346
Reviewed by Dan Bernstein.
- Scripts/webkit-tools-completion.sh:
Add "-o default" which allows for completing files in addition to the word list.
- 8:45 AM Changeset in webkit [99063] by
-
- 5 edits in trunk/Source/WebCore
CSSStyleRule: Devirtualize selectorText()
https://bugs.webkit.org/show_bug.cgi?id=71364
Patch by Andreas Kling <kling@webkit.org> on 2011-11-02
Reviewed by Antti Koivisto.
Have CSSStyleRule::selectorText() redirect to CSSPageRule::pageSelectorText()
if type() is PAGE_RULE.
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::pageSelectorText):
- css/CSSPageRule.h:
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::selectorText):
- css/CSSStyleRule.h:
- 8:11 AM Changeset in webkit [99062] by
-
- 2 edits in trunk/LayoutTests
[WK2][GTK] Skipped file cleanup
https://bugs.webkit.org/show_bug.cgi?id=71356
Added a couple of bug URLs. Moved bugs around to their proper sections.
- platform/gtk-wk2/Skipped:
- 8:07 AM Changeset in webkit [99061] by
-
- 2 edits in trunk/LayoutTests
[WK2] [GTK] WebKitWebProcess asserts in ASSERT(m_state != CLOSED)
https://bugs.webkit.org/show_bug.cgi?id=69513
Unskip passing tests.
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-02
Reviewed by Philippe Normand.
- platform/gtk-wk2/Skipped:
- 8:05 AM Changeset in webkit [99060] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Bring back some suppressions for media/media-document-audio-repaint.html.
- platform/chromium/test_expectations.txt:
- 8:02 AM Changeset in webkit [99059] by
-
- 11 edits in trunk/Source/WebCore
CSSRule: Devirtualize cssText()
https://bugs.webkit.org/show_bug.cgi?id=71292
Patch by Andreas Kling <kling@webkit.org> on 2011-11-02
Reviewed by Antti Koivisto.
Have CSSRule::cssText() redirect to the appropriate subclass based on type().
This is one of the last steps of devirtualizing CSSRule completely, which will
allow us to get rid of its vtable, and each instance's pointer thereto.
- css/CSSCharsetRule.h:
- css/CSSFontFaceRule.h:
- css/CSSImportRule.h:
- css/CSSMediaRule.h:
- css/CSSRegionStyleRule.h:
- css/CSSRule.cpp:
(WebCore::CSSRule::cssText):
- css/CSSRule.h:
- css/CSSStyleRule.h:
- css/WebKitCSSKeyframeRule.h:
- css/WebKitCSSKeyframesRule.h:
- 7:24 AM Changeset in webkit [99058] by
-
- 9 edits in trunk/Source/WebKit2
[Qt][WK2] Move content to resize (setResizesToContentsUsingLayoutSize) from UI process to Web process
https://bugs.webkit.org/show_bug.cgi?id=71107
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-02
Reviewed by Kenneth Rohde Christiansen.
Reduce the number of IPC calls to WebProcess by moving the content to resize
calls from UI process to Web process.
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::geometryChanged):
- UIProcess/API/qt/qtouchwebview_p.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setViewportSize):
(WebKit::WebPageProxy::preferencesDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/qt/QtTouchWebPageProxy.cpp:
- UIProcess/qt/QtTouchWebPageProxy.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
- WebProcess/WebPage/WebPage.messages.in:
- 7:21 AM Changeset in webkit [99057] by
-
- 217 edits408 adds in trunk/LayoutTests
Unreviewed gardening: 7th chunk of baselines for Chromium-Skia
on Leopard.
[Omitting 616 of 624 files for brevity.]
- platform/chromium-mac-leopard/animations: Added.
- platform/chromium-mac-leopard/animations/state-at-end-event-expected.png: Added.
- platform/chromium-mac-leopard/css1/basic/contextual_selectors-expected.png:
- platform/chromium-mac-leopard/css1/basic/inheritance-expected.png:
- platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png:
...
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
- 7:12 AM Changeset in webkit [99056] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for !ENABLE(FILTERS) after r98989.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
- 7:00 AM Changeset in webkit [99055] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] Clicking in a CSS property/value being edited commits the editor
https://bugs.webkit.org/show_bug.cgi?id=71360
Reviewed by Pavel Feldman.
Selecting a selected TreeElement should be an idempotent operation.
- inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):
- 5:56 AM Changeset in webkit [99054] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2]: Shouldn't send unhandled TouchCancel event to gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=70333
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.
Gesture recognizers should be reset for unhandled TouchCancel event.
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::doneWithTouchEvent):
- 4:34 AM Changeset in webkit [99053] by
-
- 3 edits3 moves2 adds1 delete in trunk/LayoutTests
Unreviewed. Another rebaseline of media/media-document-audio-repaint.html
- platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-document-audio-repaint-expected.png.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/media-document-audio-repaint-expected.png.
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-document-audio-repaint-expected.txt.
- platform/chromium/test_expectations.txt:
- 3:48 AM Changeset in webkit [99052] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed fix for build failure on chromium shared linux caused by r99020.
- WebKit.gyp:
- 2:57 AM Changeset in webkit [99051] by
-
- 19 edits in trunk
[Qt][WK2] Add support for touch event testing to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=71310
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEvent): Add support for m_shouldSendEventsSynchronously.
- UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::handleEvent): Handle plain touch events in the desktop page proxy by
forwarding them appropriately. We will receive them from WTR through ::event, but we won't
receive them from QQuickCanvas (i.e. the user) because that doesn't uses ::event but only
dedicated fooEvent() handlers, of which we don't re-implement the touch version.
(QtDesktopWebPageProxy::handleTouchEvent): Forward touch events to WebPageProxy.
- UIProcess/qt/QtDesktopWebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::touchEventSyncForTesting): Add support for synchronous touch event testing,
similar to the way it's done for mouse events.
- WebProcess/WebPage/WebPage.h: Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
Tools:
- WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
define works in EventSendingController.idl
- WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
handlers.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
required by tests.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
ui process.
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
defines.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
touch messages to the EventSenderProxy.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::sendTouchEvent):
- WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
LayoutTests:
- platform/qt-wk2/Skipped: Unskip touch tests that are passing now.
- 2:36 AM Changeset in webkit [99050] by
-
- 1 edit33 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new tests.
- platform/gtk/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/gtk/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/gtk/fast/borders/border-radius-complex-inner-expected.txt: Added.
- platform/gtk/fast/css/child-style-can-override-visited-style-expected.txt: Added.
- platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
- platform/gtk/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
- platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
- platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
- platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
- platform/gtk/svg/as-background-image/background-image-tiled-expected.txt: Added.
- platform/gtk/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/gtk/svg/as-image/same-image-two-instances-expected.txt: Added.
- platform/gtk/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
- platform/gtk/svg/as-image/svg-image-change-content-size-expected.txt: Added.
- platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
- platform/gtk/svg/filters/feColorMatrix-default-type-expected.txt: Added.
- platform/gtk/svg/filters/invalidate-on-child-layout-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
- 2:31 AM Changeset in webkit [99049] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Remove unused/duplicated modifiers member from WebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=71353
Reviewed by Kenneth Rohde Christiansen.
WebTouchEvent::m_[ctrl,alt,meta,shift]Key are redundant compared to
WebEvent::m_modifiers. The latter is fully populated and used, the former
can be safely removed.
- Shared/WebEvent.h:
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::WebTouchEvent):
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
- 2:09 AM Changeset in webkit [99048] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip the Qt mobility tests because they are working now.
- platform/qt-arm/Skipped:
- 2:00 AM Changeset in webkit [99047] by
-
- 7 edits2 adds in trunk/LayoutTests
Unreviewed, GTK rebaseline after r98852 and r99027.
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- 1:43 AM Changeset in webkit [99046] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Fix build break when DEBUG_MEM_LEAKS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=71349
Unreviewed build fix.
- ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_smart_del): remove wrong assignment
- ewk/ewk_tiled_matrix.cpp: define STDC_FORMAT_MACROS to use PRIu64
(ewk_tile_matrix_free): s/tileMatrixm/tileMatrix
(ewk_tile_matrix_dbg): s/tm/tileMatrix
- ewk/ewk_tiled_model.cpp: define STDC_FORMAT_MACROS to use PRIu64
(_ewk_tile_account_get): remove REALLOC_OR_OOM_RET
- 1:24 AM Changeset in webkit [99045] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, skip testWebKitSettingsNewWithSettings affected by bug
70127.
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsNewWithSettings):
- 12:57 AM Changeset in webkit [99044] by
-
- 2 edits28 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r98852.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
- platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
- platform/qt/Skipped: Skip failing tests because of https://bugs.webkit.org/show_bug.cgi?id=52810
- 12:54 AM Changeset in webkit [99043] by
-
- 5 edits4 adds in trunk
Canvas filling paths or rects need to be invalidate larger rects for some compositing modes.
https://bugs.webkit.org/show_bug.cgi?id=70379
Patch by Ben Wells <benwells@chromium.org> on 2011-11-02
Reviewed by James Robinson.
Source/WebCore:
Test: fast/canvas/canvas-composite-fill-repaint.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::didDrawEntireCanvas):
- html/canvas/CanvasRenderingContext2D.h:
LayoutTests:
- fast/canvas/canvas-composite-fill-repaint-expected.txt: Added.
- fast/canvas/canvas-composite-fill-repaint.html: Added.
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 12:22 AM Changeset in webkit [99042] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 12:21 AM Changeset in webkit [99041] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Dirty area is not updated with requestAnimationFrame.
https://bugs.webkit.org/show_bug.cgi?id=70170
Some additional dirty areas caused by re-layout have ignored
since updateLayoutAndSytleIfNeedeRecursive is called after gathering dirty area to repaint.
So ewk_view_layout_if_needed_recursive is relocated before getting dirty areas.
Patch by ChangSeok Oh <ChangSeok Oh> on 2011-11-02
Reviewed by Eric Seidel.
- ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
Nov 1, 2011:
- 11:26 PM Changeset in webkit [99040] by
-
- 4 edits in trunk/Source/WebCore
Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
https://bugs.webkit.org/show_bug.cgi?id=71321
Reviewed by Darin Adler.
Updating the usage of LayoutUnits in the *View classes to mirror the proper use
as derived in the subpixellayout branch.
This entails scrolling only with integers (and rounding once we've made the switch)
and using integers for window coordinates, with LayoutUnits for content coordinates.
No new tests -- no change in behavior.
- page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::zoomAnimatorTransformChanged):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::updateScrollCorner):
- page/FrameView.h:
(WebCore::FrameView::trackedRepaintRects):
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutWidth):
(WebCore::ScrollView::layoutHeight):
(WebCore::ScrollView::fixedLayoutSize):
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::scrollbarAtPoint):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::adjustScrollPositionWithinRange):
- rendering/RenderView.cpp:
(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):
- rendering/RenderView.h:
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
- 10:48 PM Changeset in webkit [99039] by
-
- 2 edits in trunk/Source/WebCore
Small fixes for WebVTTParser.
https://bugs.webkit.org/show_bug.cgi?id=71334
Reviewed by Darin Adler.
No new tests. This is needed to enable other tests, coming soon.
- html/track/WebVTTParser.cpp:
(WebCore::hasLongWebVTTIdentifier): changed to return true when header is
exactly "WEBVTT"
(WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position should
only progress once when checking the character after a timestamp.
- 8:34 PM Changeset in webkit [99038] by
-
- 2 edits1 add1 delete in trunk/LayoutTests/platform
2011-11-01 Kenji Imasaki <imasaki@chromium.org>
[Chromium] Unreviewed. Did rebaselines of media/media-document-audio-repaint.html.
- platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
- 8:20 PM Changeset in webkit [99037] by
-
- 2 edits in trunk/Tools
resolve-ChangeLogs --help should be faster.
Reviewed by Adam Roben.
- Scripts/resolve-ChangeLogs:
(usageAndExit):
Add a call to usageAndExit() before doing work to find unmerged changelogs
if --help or something illegal is provided on the command line.
- 7:52 PM Changeset in webkit [99036] by
-
- 3 edits in trunk/Source/JavaScriptCore
Cut down on malloc/free a bit in the parser arena
https://bugs.webkit.org/show_bug.cgi?id=71343
Reviewed by Oliver Hunt.
- parser/ParserArena.cpp:
(JSC::ParserArena::deallocateObjects): Call the destructors of
the deletable objects before freeing the pools. Don't call
fastFree on the deletable objects any more.
- parser/ParserArena.h:
(JSC::ParserArena::allocateDeletable): Use allocateFreeable
instead of fastMalloc here.
- 7:47 PM Changeset in webkit [99035] by
-
- 8 edits in trunk/Source
Change HTMLSelectElement::setSelectedIndex to use enums instead of bools
https://bugs.webkit.org/show_bug.cgi?id=70184
Reviewed by Kent Tamura.
Source/WebCore:
Refactoring that does not require new tests.
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
(-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]): Ditto.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex call with a
call to the new optionSelectionStateChanged function.
(WebCore::HTMLOptionElement::insertedIntoTree): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDrivenChange
was renamed to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect argument,
which was always true for all callers. Updated comment.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment.
(WebCore::HTMLSelectElement::setOption): Call the new optionSelectionStateChanged
function. The code used to explicitly ask the function it calls to deselect base
on the value of m_multiple, but that is no longer needed because the selectOption
function itself takes care of that check.
(WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed this function.
Also updated for name change to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlined function
here from the header and changed it to call the renamed selectOption function.
(WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this function.
It is used by callers that were previously using setSelectedIndex and passing
"false" for the deselect argument. It's better now that setSelectedIndex is now a
pure DOM setter function without the multiple purposes it had before. This function
now has the logic that handles the special handling when deselecting an option,
which used to be at the top of the next function.
(WebCore::HTMLSelectElement::selectOption): Renamed this from setSelectedIndex.
Replaced boolean arguments with flags. Removed code to handle the special case
when we deselect an option; that's now handled in the optionSelectionStateChanged
function. Added an assertion to replace a comment and updated for other renaming.
(WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to call the
new selectOption function and also updated for other name changes.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
- html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure setter
function for the selectedIndex DOM property. Added a optionSelectedByUser function
for the other use of setSelectedIndex, but removed the always true "deselect"
argument from it. Added a optionSelectionStateChanged function for use in the
HTMLOptionElement implementation. Renamed menuListOnChange to
dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and
SelectOptionFlags type for the arguments to the selectOption function, formerly
implemented as an overload of setSelectedIndex (and called setSelectedIndexInternal
before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChange.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
Source/WebKit/chromium:
- tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
- 7:24 PM Changeset in webkit [99034] by
-
- 13 edits in trunk
Implement lookupGetter/lookupSetter in terms of getPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71336
Reviewed by Darin Adler.
Source/JavaScriptCore:
- debugger/DebuggerActivation.cpp:
- debugger/DebuggerActivation.h:
Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.
- runtime/JSObject.cpp:
(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):
- runtime/JSObject.h:
De-virtualize lookupGetter/lookupSetter, and implement them in terms of
getPropertyDescriptor.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- page/DOMWindow.idl:
Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.
LayoutTests:
- fast/dom/getter-on-window-object2-expected.txt:
Update results now that lookupGetter/lookupSetter match getOwnPropertyDescriptor.
The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.
- 7:18 PM Changeset in webkit [99033] by
-
- 12 edits in trunk/Source
[chromium] Move resource-releasing logic into CCProxy and cleanup setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=71269
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::setVisible):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setVisible):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::composite):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
- tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestScrollSimple::beginTest):
(CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
- 7:16 PM Changeset in webkit [99032] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8386021
- 7:08 PM Changeset in webkit [99031] by
-
- 4 edits in trunk
[Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
https://bugs.webkit.org/show_bug.cgi?id=71342
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-01
Reviewed by Darin Adler.
Tools:
[NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
[NSString substringFromIndex:] with an index out of the string range.
The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
from the root of the disk.
The problem was hidden because the exception are catched when calling the delegate.
This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
in a subdirectory of the main frame.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSURL _drt_descriptionSuitableForTestResult]):
LayoutTests:
Update the test results following the fix of _drt_descriptionSuitableForTestResult.
- webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
- 7:08 PM Changeset in webkit [99030] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8423033
- 7:05 PM Changeset in webkit [99029] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8399045
- 6:53 PM Changeset in webkit [99028] by
-
- 5 edits5 copies in branches/chromium/912
Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8372052
- 6:52 PM Changeset in webkit [99027] by
-
- 18 edits2 adds in trunk
Makes [Reflect] work for constants.
This is needed to avoid platform-specific define conflicts, specifically
TextTrack::ERROR conflicts with a windows define.
https://bugs.webkit.org/show_bug.cgi?id=70951
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-constants.html
- bindings/scripts/CodeGenerator.pm:
(GenerateCompileTimeCheckForEnumsIfNeeded):
Check for [Reflect] and assign name accordingly.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file.
- bindings/scripts/test/JS/JSTestObj.cpp: Update test file.
(WebCore::jsTestObjCONST_JAVASCRIPT):
- bindings/scripts/test/JS/JSTestObj.h: Update test file.
- bindings/scripts/test/ObjC/DOMTestObj.h: Update test file.
- bindings/scripts/test/TestObj.idl: Update test file.
- bindings/scripts/test/V8/V8TestObj.cpp: Update test file.
- html/LoadableTextTrack.cpp: Use new DOM const name.
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):
- html/TextTrack.cpp: Use new DOM const name.
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):
- html/TextTrack.h: Use new DOM const name.
- html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const names.
LayoutTests:
- media/track/track-constants-expected.txt: Added.
- media/track/track-constants.html: Added.
- media/track/track-load-error-readyState.html: Updated with new const name.
- media/track/track-load-from-element-readyState.html: Updated with new const name.
- media/track/track-load-from-src-readyState.html: Updated with new const name.
VIDEO_TRACK is not enabled on these ports, so skipping this test:
- platform/mac/Skipped:
- platform/win/Skipped:
- 6:51 PM Changeset in webkit [99026] by
-
- 2 edits2 copies in branches/chromium/912
Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8437038
- 6:42 PM Changeset in webkit [99025] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98344
BUG=100863
Review URL: http://codereview.chromium.org/8440026
- 6:33 PM Changeset in webkit [99024] by
-
- 3 edits in trunk/Source/WebCore
Amend missing uses of LayoutUnit in RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=71254
Reviewed by Darin Adler.
Switching relevant uses of integers in RenderBlock to LayoutUnits.
No new tests -- no changes in behavior.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintContents):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::baselinePosition):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatWithRect::FloatWithRect):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
- 6:32 PM Changeset in webkit [99023] by
-
- 1 edit in branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145
Reviewed by Ojan Vafai.
Fix a potential crash without tests because we don't have a reduction.
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8437036
- 6:23 PM Changeset in webkit [99022] by
-
- 19 edits2 adds in trunk
WIP: Add CSS property to control printing of backgrounds for individual elements.
https://bugs.webkit.org/show_bug.cgi?id=64583
Reviewed by Eric Seidel.
Added test LayoutTests/fast/css/webkit-color-adjust.html,
Updated tests under LayoutTests/fast/css/getComputedStyle
Updated test under LayoutTests/svg/css
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialForceBackgroundsToWhite):
- 6:20 PM Changeset in webkit [99021] by
-
- 9 edits in trunk
Remove initErrorEvent method
https://bugs.webkit.org/show_bug.cgi?id=71338
Reviewed by Ojan Vafai.
Source/WebCore:
- dom/ErrorEvent.cpp: Crush.
- dom/ErrorEvent.h: Kill.
- dom/ErrorEvent.idl: Destroy.
LayoutTests:
- http/tests/workers/worker-importScriptsOnError-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 6:12 PM Changeset in webkit [99020] by
-
- 5 edits1 add in trunk/Source
Pack RenderTableCell bits
https://bugs.webkit.org/show_bug.cgi?id=71135
Reviewed by Darin Adler.
Source/WebCore:
Tested by RenderTableCellTest unit test.
(unfortunately Chromium specific...)
This saves another 8 bytes on RenderTableCell on x86-64.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
- rendering/RenderTableCell.h:
Changed the field order to use more strict packing.
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::setRow):
Added overflow checks to the 2 previous methods. We
CRASH even in release to avoid potential badness
(the limit is currently above 2 billions rows or columns
which is high enough to prevent it being hit by accident)
Source/WebKit/chromium:
- WebKit.gypi:
- tests/RenderTableCellTest.cpp: Added.
Added some tests for the column/row index limit
that was implemented in RenderTableCell.
- 5:55 PM Changeset in webkit [99019] by
-
- 3 edits in trunk/Source/WebCore
Switch background/border image back to Int
https://bugs.webkit.org/show_bug.cgi?id=71240
Reviewed by Darin Adler.
Switch background- and border-image rendering back to int to align with
device pixels.
No new tests.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::calculateAdjustedInnerBorder):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
- 5:36 PM Changeset in webkit [99018] by
-
- 20 edits in trunk/Source
De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineSetter):
- debugger/DebuggerActivation.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::defineSetter):
- runtime/JSCell.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineSetter):
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
- runtime/JSObject.h:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineSetter):
Source/WebCore:
No new tests.
Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineSetter):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineSetter):
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- 5:34 PM Changeset in webkit [99017] by
-
- 2 edits in trunk/LayoutTests
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>
Reviewed by Darin Adler.
Fix svg/filters/invalidate-on-child-layout.svg to not include nonexistent onload handler.
- svg/filters/invalidate-on-child-layout.svg:
- 5:15 PM Changeset in webkit [99016] by
-
- 9 edits in trunk/Source/WebCore
Switch PopupMenuClient to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71308
Reviewed by Darin Adler.
Switch PopupMenuClient and rendering classes implementing it to layout
type abstraction.
No new tests.
- platform/PopupMenuClient.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
Revert scroll positions and scroll offsets to ints to align with device
pixels.
- rendering/RenderListBox.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):
- rendering/RenderMenuList.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
- rendering/RenderTextControlSingleLine.h:
- 5:09 PM Changeset in webkit [99015] by
-
- 6 edits in trunk/Source
Source/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
ResourceRequest::TargetType clobbered. They set their own
type, but CachedResourceRequest (through which they now flow)
sets a TargetType without bothering to see if one has already been set.
https://bugs.webkit.org/show_bug.cgi?id=70972
Reviewed by Darin Fisher.
No new tests, this is chromium-specific and only affects
behavior seen in full builds of chromium.
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):Don't setTargetType()
if the value is something other than the default already.
- platform/network/chromium/ResourceRequest.h: Change default
TargetType to TargetIsUnspecified.
Source/WebKit/chromium: Add 2 new TargetTypes (to match ResourceRequest::TargetType)
and ensure we don't pass chromium a TargetType it doesn't
yet understand.
https://bugs.webkit.org/show_bug.cgi?id=70972
Reviewed by Darin Fisher.
- public/WebURLRequest.h:
- src/WebURLRequest.cpp:
- 5:08 PM Changeset in webkit [99014] by
-
- 8 edits in trunk/Source/WebCore
Use IntPoint for screen coordinates in MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=71327
Reviewed by Darin Adler.
Change mouse events to use int/IntPoint for screen/window coordinates and
LayoutUnit/LayoutPoint for coordinates adjusted for zooming.
No new tests.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::screenLocation):
Revert screenLocation and windowLocation back to int.
- page/DragController.cpp:
(WebCore::elementUnderMouse):
Change elementUnderMouse to use a LayoutPoint for hit testing.
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- page/EventHandler.h:
Revert m_currentMousePosition to IntPoint as it represents a
screen coordinate.
- platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):
- platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):
Revert PlatformMouseEvent to int/IntPoint as it represents a screen
coordinate.
- 4:58 PM Changeset in webkit [99013] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320
Reviewed by Ojan Vafai.
This regressed in http://trac.webkit.org/changeset/98773 .
No new tests, covered by css3/flexbox/flex-parsing.html.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):
- 4:53 PM Changeset in webkit [99012] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline getter-on-window-object2.html after r99005.
- platform/chromium/fast/dom/getter-on-window-object2-expected.txt: Added.
- 4:33 PM Changeset in webkit [99011] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: get EventQueue from ScriptExecutionContext instead of Document
https://bugs.webkit.org/show_bug.cgi?id=71147
When IDB is used from a worker thread ScriptExecutionContext will
be a WorkerContext, not a Document. This was the impetus behind
moving EventQueue into ScriptExecutionContext in r98656.
Reviewed by Nate Chapin.
No new tests. No new functionality yet.
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::enqueueEvent):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::enqueueEvent):
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::enqueueEvent):
- 4:31 PM Changeset in webkit [99010] by
-
- 5 edits in trunk/Source/WebCore
CSS: Remove unused virtual parseString() in style and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=71300
Patch by Andreas Kling <kling@webkit.org> on 2011-11-01
Reviewed by Darin Adler.
- css/CSSStyleRule.cpp:
- css/CSSStyleRule.h:
- css/WebKitCSSKeyframeRule.cpp:
- css/WebKitCSSKeyframeRule.h:
- 4:13 PM Changeset in webkit [99009] by
-
- 9 edits3 adds in trunk
DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.
I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.
- bytecode/CodeBlock.h:
(JSC::ExecState::isInlineCallFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler32_64.cpp:
- dfg/DFGNode.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
- interpreter/CallFrame.h:
- runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
LayoutTests:
Reviewed by Oliver Hunt.
Test that using bar.arguments, where bar was inlined into baz,
works correctly.
- fast/js/dfg-inline-arguments-simple-expected.txt: Added.
- fast/js/dfg-inline-arguments-simple.html: Added.
- fast/js/script-tests/dfg-inline-arguments-simple.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
- 4:02 PM Changeset in webkit [99008] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249
Switch RenderObject to LayoutRect/Size/Point abstraction.
Reviewed by Darin Adler.
No new tests.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localCaretRect):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::maximalOutlineSize):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
- rendering/RenderObject.h:
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::absoluteOutlineBounds):
(WebCore::RenderObject::outlineBoundsForRepaint):
(WebCore::adjustForAbsoluteZoom):
- 4:01 PM Changeset in webkit [99007] by
-
- 2 edits in trunk/LayoutTests
Update result to match mac repaint result. When we forced a layout on
the test (when landing the mac-sl results), it caused this result to
change slightly.
- platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
- 3:53 PM Changeset in webkit [99006] by
-
- 2 edits in trunk/Tools
[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71318
Reviewed by James Robinson.
Fixed a typo for --enable-hardware-gpu flag.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:36 PM Changeset in webkit [99005] by
-
- 3 edits in trunk/LayoutTests
Expand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor as well
https://bugs.webkit.org/show_bug.cgi?id=71332
Reviewed by Anders Carlsson.
- fast/dom/getter-on-window-object2-expected.txt:
- fast/dom/getter-on-window-object2.html:
Convert to shouldBe style tests and expand test to also test Object.getOwnPropertyDescriptor,
which currently fail for getters/setters defined over window properties.
- 3:32 PM Changeset in webkit [99004] by
-
- 5 edits2 copies in trunk/Source/WebKit/chromium
[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=71008
Expanding WebMediaStreamDescriptor and adding WebMediaStreamSource
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-01
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebMediaStreamDescriptor.h:
- public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::~WebMediaStreamSource):
(WebKit::WebMediaStreamSource::isNull):
- src/AssertMatchingEnums.cpp:
- src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::initialize):
- src/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::reset):
(WebKit::WebMediaStreamSource::operator PassRefPtr<MediaStreamSource>):
(WebKit::WebMediaStreamSource::operator MediaStreamSource*):
(WebKit::WebMediaStreamSource::initialize):
(WebKit::WebMediaStreamSource::id):
(WebKit::WebMediaStreamSource::type):
(WebKit::WebMediaStreamSource::name):
- 3:12 PM Changeset in webkit [99003] by
-
- 2 edits in trunk/LayoutTests
Suppress svg/filters/invalidate-on-child-layout.svg until the fix lands.
- platform/chromium/test_expectations.txt:
- 3:06 PM Changeset in webkit [99002] by
-
- 7 edits in trunk/Source/WebCore
Refactor: change Scrollable::m_scrollOrigin from protected to private.
https://bugs.webkit.org/show_bug.cgi?id=71236
Reviewed by Darin Adler.
Only refactor, no new tests needed.
- page/FrameView.cpp:
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
- platform/ScrollView.cpp:
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::computeScrollDimensions):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):
- 2:54 PM Changeset in webkit [99001] by
-
- 5 edits in tags/Safari-535.7.1/Source
Versioning.
- 2:50 PM Changeset in webkit [99000] by
-
- 2 edits in tags/Safari-535.7.1/Source/WebCore
Merged r98824.
- 2:45 PM Changeset in webkit [98999] by
-
- 1 copy in tags/Safari-535.7.1
New Tag.
- 2:32 PM Changeset in webkit [98998] by
-
- 3 edits in trunk/LayoutTests
Expand prototype setting test to test Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=71322
Reviewed by Anders Carlsson.
- fast/js/script-tests/prototypes.js:
Also test setting proto using Object.defineProperty.
- 1:55 PM Changeset in webkit [98997] by
-
- 3 edits2 adds in trunk
display: table-cell and box-sizing: border-box calculates content-box height
https://bugs.webkit.org/show_bug.cgi?id=69425
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/box-sizing/table-cell.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- fast/box-sizing/table-cell-expected.txt: Added.
- fast/box-sizing/table-cell.html: Added.
- 1:52 PM Changeset in webkit [98996] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.
- platform/chromium/test_expectations.txt:
- 1:40 PM Changeset in webkit [98995] by
-
- 1 copy in tags/Safari-534.52.9
New tag.
- 1:13 PM Changeset in webkit [98994] by
-
- 2 edits in trunk/Source/WebKit/chromium
CCSchedulerTests fail on Chromium Windows (dbg) after r98915
https://bugs.webkit.org/show_bug.cgi?id=71294
Reviewed by James Robinson.
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- 12:52 PM Changeset in webkit [98993] by
-
- 3 edits in trunk/Source/JavaScriptCore
StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-01
Reviewed by Geoffrey Garen.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
- wtf/text/StringImpl.h:
- 12:28 PM Changeset in webkit [98992] by
-
- 2 edits in trunk/Tools
chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71286
Patch by Elliot Poger <epoger@google.com> on 2011-11-01
Reviewed by Stephen White.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 12:24 PM Changeset in webkit [98991] by
-
- 1 edit35 adds in trunk/LayoutTests
[EFL] Unreviewed. Add remaining pixel baselines.
- platform/efl/http: Added.
- platform/efl/http/tests: Added.
- platform/efl/http/tests/local: Added.
- platform/efl/http/tests/local/file-url-sent-as-referer-expected.png: Added.
- platform/efl/http/tests/misc: Added.
- platform/efl/http/tests/misc/acid2-expected.png: Added.
- platform/efl/http/tests/misc/error404-expected.png: Added.
- platform/efl/http/tests/misc/favicon-as-image-expected.png: Added.
- platform/efl/http/tests/misc/frame-access-during-load-expected.png: Added.
- platform/efl/http/tests/misc/generated-content-inside-table-expected.png: Added.
- platform/efl/http/tests/misc/iframe404-expected.png: Added.
- platform/efl/http/tests/misc/location-replace-crossdomain-expected.png: Added.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/efl/http/tests/navigation: Added.
- platform/efl/http/tests/navigation/error404-basic-expected.png: Added.
- platform/efl/http/tests/navigation/error404-goback-expected.png: Added.
- platform/efl/http/tests/navigation/error404-subframeload-expected.png: Added.
- platform/efl/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/efl/http/tests/navigation/postredirect-basic-expected.png: Added.
- platform/efl/http/tests/navigation/postredirect-goback1-expected.png: Added.
- platform/efl/http/tests/security: Added.
- platform/efl/http/tests/security/contentSecurityPolicy: Added.
- platform/efl/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
- platform/efl/http/tests/uri: Added.
- platform/efl/http/tests/uri/css-href-expected.png: Added.
- platform/efl/scrollbars/basic-scrollbar-expected.png: Added.
- platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/efl/scrollbars/disabled-scrollbar-expected.png: Added.
- platform/efl/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
- platform/efl/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/efl/scrollbars/scrollbar-buttons-expected.png: Added.
- platform/efl/scrollbars/scrollbar-orientation-expected.png: Added.
- platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
- 12:18 PM Changeset in webkit [98990] by
-
- 8 edits4 adds in trunk
[chromium] Add testing for --enable-accelerated-drawing
https://bugs.webkit.org/show_bug.cgi?id=70822
Reviewed by James Robinson.
Source/WebCore:
Test: platform/chromium/compositing/accelerated-drawing/alpha.html
- WebCore.exp.in:
- page/Settings.cpp:
- page/Settings.h:
(WebCore::Settings::setAcceleratedDrawingEnabled):
- testing/Internals.cpp:
(WebCore::Internals::setAcceleratedDrawingEnabled):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- platform/chromium/compositing/accelerated-drawing: Added.
- platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Added.
- platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Added.
- platform/chromium/compositing/accelerated-drawing/alpha.html: Added.
- 12:13 PM Changeset in webkit [98989] by
-
- 4 edits3 adds in trunk
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>
Reviewed by Nikolas Zimmermann.
Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
invalidation was only performed if the element itself needed layout; now we also invalidate if any child
needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.
Test: svg/filters/invalidate-on-child-layout.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
Add a test that ensures that changing the layout of a child of a filtered element invalidates the filter.
- platform/mac/svg/filters/invalidate-on-child-layout-expected.png: Added.
- platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
- svg/filters/invalidate-on-child-layout.svg: Added.
- 12:05 PM Changeset in webkit [98988] by
-
- 4 edits in trunk
Four media tests failing on Lion due to incorrect cached times.
https://bugs.webkit.org/show_bug.cgi?id=69574
Reviewed by Eric Carlson.
Source/WebCore:
Do not invalidate the cached time when receiving a mediaPlayerRateChanged notification
while paused. AVFoundation in particular can return different results for currentTime()
when asked after being paused, breaking layout tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
LayoutTests:
Some media engines will cause multiple timeupdate events after pausing; so deregister
the timeupdate event listener after receiving the first one.
- media/video-pause-immediately.html:
- 11:54 AM Changeset in webkit [98987] by
-
- 2 edits in trunk/Source/WebCore
properly end requests when a bad status code return happens
https://bugs.webkit.org/show_bug.cgi?id=71122
Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.
The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.
Reviewed by Nate Chapin.
No new tests, as the problem wasn't very amenable to layout tests.
There is a chromium test going through code review at http://codereview.chromium.org/8404001/
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):
- 11:40 AM Changeset in webkit [98986] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Rebaseline after r98896.
- fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
- fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
- platform/chromium-win-vista/fast/forms: Removed.
- platform/chromium/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 11:39 AM Changeset in webkit [98985] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628
Reviewed by Adam Barth.
Covered by existing tests.
- html/canvas/CanvasRenderingContext2D.idl:
- 11:37 AM Changeset in webkit [98984] by
-
- 6 edits1 delete in trunk/LayoutTests
Rebaseline after r98979.
- fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
- fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
- platform/chromium-win-vista/fast/forms: Removed.
- platform/chromium/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 11:30 AM Changeset in webkit [98983] by
-
- 8 edits in trunk/Source/WebKit2
[Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295
Reviewed by Simon Hausmann.
Suppress superfluous debug messages of Qt5.
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
- UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
- UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
- UIProcess/API/qt/tests/util.cpp:
(messageHandler):
- UIProcess/API/qt/tests/util.h:
- 11:30 AM Changeset in webkit [98982] by
-
- 1 edit401 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/table: [...]
- platform/efl/fast/text: [...]
- platform/efl/fast/tokenizer: [...]
- platform/efl/fast/transforms: [...]
- platform/efl/fast/writing-mode: [...]
- platform/efl/fast/xsl: [...]
- 11:07 AM Changeset in webkit [98981] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html
- platform/chromium-gpu-linux/media/audio-repaint-expected.png:
- 11:02 AM Changeset in webkit [98980] by
-
- 3 edits4 adds in trunk
REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/table/crash-empty-section-calcBorder.html
fast/table/crash-empty-section-fixed-layout-calcArray.html
The refactoring in r98738 changed the way we handle the size to avoid throwing off
the memory. The new logic would end up never shrinking the grid's size (prior to that
we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
Not shrinking would mean that we would potentially read RowStruct with the default values
(for instance no |rowRenderer|).
addCell will properly grow the grid as needed to accomodate the rows and the protruding
cells with a rowspan so we introduce a variable to keep track of the size needed. At the
end, we just shrink it to this size.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::recalcCells):
Introduce a variable to keep the grid size and shrink to that size to match the old code.
LayoutTests:
Those tests checks that an empty section would not lead to reading
RowStruct without a |rowRenderer| which would crash.
- fast/table/crash-empty-section-calcBorder-expected.txt: Added.
- fast/table/crash-empty-section-calcBorder.html: Added.
- fast/table/crash-empty-section-fixed-layout-calcArray-expected.txt: Added.
- fast/table/crash-empty-section-fixed-layout-calcArray.html: Added.
- 10:59 AM Changeset in webkit [98979] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followup for the previous commit (removing another duplicate line).
- platform/chromium/test_expectations.txt:
- 10:57 AM Changeset in webkit [98978] by
-
- 4 edits in trunk
[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277
Reviewed by Simon Fraser.
Source/WebCore:
Disabled assert() in hasVisibleDescendant() until callers are fixed.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant):
LayoutTests:
- platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
- 10:35 AM Changeset in webkit [98977] by
-
- 7 edits in branches/safari-534.52-branch/Source
Merge r98936 and update Versioning.
- 10:31 AM Changeset in webkit [98976] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed. Fix ChangeLog which broke in r98733.
- 10:19 AM Changeset in webkit [98975] by
-
- 6 edits in trunk
[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
https://bugs.webkit.org/show_bug.cgi?id=71299
Reviewed by Andreas Kling.
Source/WebKit/qt:
Export an overload of QtDRT::injectInternalsObjects that is used by
the WK2 injected bundle.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::injectInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
build to enable WebCoreTestSupport::injectInternalsObject.
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
- 10:11 AM Changeset in webkit [98974] by
-
- 1 edit635 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/media: [...]
- platform/efl/fast/multicol: [...]
- platform/efl/fast/overflow: [...]
- platform/efl/fast/parser: [...]
- platform/efl/fast/reflections: [...]
- platform/efl/fast/regions: [...]
- platform/efl/fast/repaint: [...]
- platform/efl/fast/replaced: [...]
- platform/efl/fast/ruby: [...]
- platform/efl/fast/runin: [...]
- platform/efl/fast/selectors: [...]
- 10:05 AM Changeset in webkit [98973] by
-
- 19 edits2 copies1 add in trunk
[Qt] Merge common desktop and touch view APIs under a base class.
https://bugs.webkit.org/show_bug.cgi?id=71280
Reviewed by Andreas Kling.
Source/WebKit2:
- Make QDesktopWebView and QTouchWebView inherit from QBaseWebView.
- Move methods from QTouchWebPage to QTouchWebView (through the base class).
We use the same convenience macros as Qt internally by hiding QObject::d_ptr
with QBaseWebView::d_ptr instead of inheriting QBaseWebViewPrivate from
QQuickItemPrivate.
Also, QBaseWebView currently inherits from QQuickPaintedItem since QDesktopWebView
needs it, but should be changed as soon as this is not required anymore.
- UIProcess/API/qt/qbasewebview.cpp: Added.
(QBaseWebViewPrivate::QBaseWebViewPrivate):
(QBaseWebViewPrivate::setPageProxy):
(QBaseWebView::QBaseWebView):
(QBaseWebView::~QBaseWebView):
(QBaseWebView::load):
(QBaseWebView::url):
(QBaseWebView::loadProgress):
(QBaseWebView::title):
(QBaseWebView::navigationController):
(QBaseWebView::preferences):
- UIProcess/API/qt/qbasewebview.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
- UIProcess/API/qt/qbasewebview_p.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
(QBaseWebViewPrivate::~QBaseWebViewPrivate):
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
(QDesktopWebViewPrivate::webView):
(QDesktopWebViewPrivate::setViewNeedsDisplay):
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::hasFocus):
(QDesktopWebViewPrivate::isVisible):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeUrl):
(QDesktopWebViewPrivate::didChangeTitle):
(QDesktopWebViewPrivate::didChangeStatusText):
(QDesktopWebViewPrivate::loadDidBegin):
(QDesktopWebViewPrivate::loadDidSucceed):
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebViewPrivate::init):
(QDesktopWebView::~QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
(QDesktopWebView::pageRef):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
(QDesktopWebViewPrivate::engine):
(QDesktopWebViewPrivate::chooseFiles):
(QDesktopWebViewPrivate::_q_onOpenPanelFilesSelected):
(QDesktopWebViewPrivate::_q_onOpenPanelFinished):
(QDesktopWebViewPrivate::didMouseMoveOverElement):
(QDesktopWebViewPrivate::navigationPolicyForURL):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPageProxy):
(QTouchWebPagePrivate::paintToCurrentGLContext):
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebpage_p.h:
(QTouchWebPagePrivate::touchPageProxy):
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::QTouchWebView):
(QTouchWebView::~QTouchWebView):
(QTouchWebView::page):
(QTouchWebView::geometryChanged):
(QTouchWebView::onVisibleChanged):
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qtouchwebview_p.h:
(QTouchWebViewPrivate::touchPageProxy):
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::loadNonexistentFileUrl):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::load):
(WebViewAbstraction::url):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
- UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationStatusAtStartup):
- UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::createPopupMenuProxy):
- UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::didChangeViewportProperties):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):
- WebKit2API.pri:
Tools:
Remove unneded forwarding logic for TouchWebView since those properties are
now in the view just as the desktop web view.
- MiniBrowser/qt/qml/TouchView.qml:
- 9:51 AM Changeset in webkit [98972] by
-
- 3 edits in trunk/Source/WebKit2
PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261
Reviewed by Adam Roben.
Change PluginProxy::wantsWindowRelativeCoordinates to return false and remove
m_frameRectInWindowCoordinates and m_clipRectInWindowCoordinates. This is yet another step
towards eliminating window-relative coordinates wherever possible.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Since the dirty rect passed to paint is now in plug-in coordinates, there's no need to convert it
from window coordinates to plug-in coordinates before passing it to BackingStore::paint.
(WebKit::PluginProxy::deprecatedGeometryDidChange):
Assert that we're not calling this anymore.
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return false.
- 9:45 AM Changeset in webkit [98971] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS.
Unreviewed.
- DEPS:
- 9:28 AM Changeset in webkit [98970] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
https://bugs.webkit.org/show_bug.cgi?id=71289
Reviewed by Dan Bernstein.
Just adding a null check. I don't have access to an actual PDF with
this problem but crashes from the field indicate they exist.
- WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): Skip the code to add the script text
to an array when the script is null.
- 8:59 AM Changeset in webkit [98969] by
-
- 2 edits in trunk/Source/WebCore
[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284
Reviewed by Stephen White.
No new tests. This is preparing for an API change to Skia.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
- 8:56 AM Changeset in webkit [98968] by
-
- 1 edit161 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/html: [...]
- platform/efl/fast/images: [...]
- platform/efl/fast/inline-block: [...]
- platform/efl/fast/inline: [...]
- platform/efl/fast/innerHTML: [...]
- platform/efl/fast/inspector-support: [...]
- platform/efl/fast/invalid: [...]
- platform/efl/fast/layers: [...]
- platform/efl/fast/lists: [...]
- platform/efl/fast/loader: [...]
- 8:47 AM Changeset in webkit [98967] by
-
- 2 edits in trunk/Source/WebCore
CSSStyleSheet: Operate directly on the rule vector internally.
Rubber-stamped by Antti Koivisto.
There's no need to go through the public, range-checking item() method
working on m_children. Also changed length() -> m_children.size().
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- 8:44 AM Changeset in webkit [98966] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fixed conflicting entries in test expectations.
- platform/chromium/test_expectations.txt:
- 8:40 AM Changeset in webkit [98965] by
-
- 4 edits in trunk/Source/WebKit2
The QtViewportInteractionEngine should consider DPI adjustment
https://bugs.webkit.org/show_bug.cgi?id=71283
Reviewed by Simon Hausmann.
- UIProcess/API/qt/qtouchwebview.cpp:
Add some default values for now to make sure we are testing the
DPI adjustment / CSS-item space conversion.
(QTouchWebViewPrivate::updateViewportConstraints):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
Clean up the guard to be more understandable.
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
Add methods for converting between CSS and item space.
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
Make it clean which methods uses which coord space.
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemScale):
Rename calculateBoundariesForScale and change its implementation to
be correct. The new name reflects the space in which the computation
takes place and reflects similar Qt API.
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
Make sure to consider the right coord space.
- UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::Constraints::Constraints):
Add the devicePixelRatio.
- 8:32 AM Changeset in webkit [98964] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked inspector extensions tests as crash on win debug.
- platform/chromium/test_expectations.txt:
- 8:23 AM Changeset in webkit [98963] by
-
- 6 edits in trunk/Source/WebCore
CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285
Reviewed by Antti Koivisto.
Move addSubresourceStyleURLs() into the rules that actually implement it.
Add type checks and casts at the (only) call site.
- css/CSSFontFaceRule.h:
- css/CSSImportRule.h:
- css/CSSRule.h:
- css/CSSStyleRule.h:
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- 8:19 AM Changeset in webkit [98962] by
-
- 3 edits2 adds in trunk
AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743
Reviewed by Darin Adler.
Source/WebCore:
Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Added.
- platform/mac/accessibility/aria-popup-buttons-on-native-elements.html: Added.
- 8:16 AM Changeset in webkit [98961] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 8:02 AM Changeset in webkit [98960] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 7:41 AM Changeset in webkit [98959] by
-
- 2 edits in trunk/Source/WebKit2
Prospective clang build fix.
Reviewed by Andreas Kling.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Handle GestureSingleTap in the event type switch.
- 6:58 AM Changeset in webkit [98958] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix chromium interactive tests.
- src/js/Tests.js: (.TestSuite.prototype.showPanel):
- 6:34 AM Changeset in webkit [98957] by
-
- 3 edits4 adds in trunk/Source/WebKit2
[Qt] Create infrastructure for Qt's builtin bundle in web process.
https://bugs.webkit.org/show_bug.cgi?id=71279
Reviewed by Simon Hausmann.
Create a builtin bundle for Qt port: an InjectedBundle which the code is together
with the Qt's web process instead of being in a different library. This gives us
access to many hooks at web process (using WKBundle* functions of C API) without
adding any maintenance burden to cross-port code.
Since we also use a InjectedBundle in the WebKitTestRunner, we only install our
builtin bundle if there's no other installed. This is fine because WTR won't use
the extra runtime features that we plan to provide with the builtin bundle.
- WebKit2.pro:
- WebProcess/qt/QtBuiltinBundle.cpp: Added.
(WebKit::QtBuiltinBundle::~QtBuiltinBundle):
(WebKit::QtBuiltinBundle::shared):
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::bundlePageForPageRef):
- WebProcess/qt/QtBuiltinBundle.h: Added.
(WebKit::QtBuiltinBundle::toRef):
Object that holds a WKBundleRef and keeps track of the pages in the current context.
- WebProcess/qt/QtBuiltinBundlePage.cpp: Added.
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):
- WebProcess/qt/QtBuiltinBundlePage.h: Added.
(WebKit::QtBuiltinBundlePage::page):
Our representation for pages from the bundle perspective. This will be the right
place to registering page related clients.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
If there's no bundle to be loaded, initialize Qt builtin bundle, which will register the
bundle client for this context.
- 6:32 AM Changeset in webkit [98956] by
-
- 5 edits in trunk
Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
LayoutTests:
- inspector/styles/styles-source-lines-expected.txt:
- inspector/styles/styles-update-from-js-expected.txt:
- 6:09 AM Changeset in webkit [98955] by
-
- 7 edits2 adds in trunk/LayoutTests
Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334
Reviewed by Pavel Feldman.
- http/tests/inspector/extensions-headers.html:
- http/tests/inspector/resources/extension-main.js:
():
- inspector/extensions/extensions-audits.html:
- inspector/extensions/extensions-console.html:
- inspector/extensions/extensions-resources.html:
- platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
- platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:59 AM Changeset in webkit [98954] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix extensions tests.
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel):
- 5:53 AM Changeset in webkit [98953] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix inspector extensions tests.
- inspector/extensions/extensions.html:
- 5:36 AM Changeset in webkit [98952] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: do not switch panels on Cmd + -> while in console.
https://bugs.webkit.org/show_bug.cgi?id=71281
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
- 5:34 AM Changeset in webkit [98951] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt documentation fix.
This signal is Qt 4.8 material.
- Api/qwebpage.cpp:
- 4:36 AM Changeset in webkit [98950] by
-
- 3 edits in trunk/Tools
check-webkit-style: Allow names starting with "_q_".
https://bugs.webkit.org/show_bug.cgi?id=70625
Reviewed by Tor Arne Vestbø.
Used by the Qt port as the standard prefix for private slots.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 3:35 AM Changeset in webkit [98949] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 3:29 AM Changeset in webkit [98948] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 3:17 AM Changeset in webkit [98947] by
-
- 2 edits in trunk/Source/WebCore
[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951
Adjust symbols visibility for WebCore.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-01
Reviewed by Simon Hausmann.
- WebCore.pro:
- 3:14 AM Changeset in webkit [98946] by
-
- 2 edits in trunk/Source/WebCore
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: add InspectorView.js entry into WebKit.qrc
- inspector/front-end/WebKit.qrc:
- 3:05 AM Changeset in webkit [98945] by
-
- 29 edits1 add in trunk
Web Inspector: introduce PanelContainer class, start moving panel management from inspector.js to the new class.
https://bugs.webkit.org/show_bug.cgi?id=71272
Reviewed by Yury Semikhatsky.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.setVisible):
- inspector/front-end/InspectorView.js: Added.
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.currentPanel):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._canGoBackInHistory):
(WebInspector.InspectorView.prototype._goBackInHistory):
(WebInspector.InspectorView.prototype._canGoForwardInHistory):
(WebInspector.InspectorView.prototype._goForwardInHistory):
(WebInspector.InspectorView.prototype._pushToHistory):
- inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._panelSelected):
(WebInspector.addPanel):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
- inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.expandElementsTree):
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/debugger/debugger-expand-scope.html:
- inspector/debugger/debugger-proto-property.html:
- inspector/debugger/dom-breakpoints.html:
- inspector/elements/elements-img-tooltip.html:
- inspector/elements/elements-panel-limited-children.html:
- inspector/storage-panel-dom-storage.html:
- inspector/styles/styles-new-API.html:
- inspector/view-css.html:
- inspector/view-events.html:
- 3:02 AM Changeset in webkit [98944] by
-
- 1 edit392 adds in trunk/LayoutTests
[EFL] Unreviewed. Add pixel baselines for fast/ tests.
- platform/efl/fast/doctypes: [...]
- platform/efl/fast/dom: [...]
- platform/efl/fast/dynamic: [...]
- platform/efl/fast/encoding: [...]
- platform/efl/fast/events: [...]
- platform/efl/fast/fast-mobile-scrolling: [...]
- platform/efl/fast/flexbox: [...]
- platform/efl/fast/forms: [...]
- platform/efl/fast/frames: [...]
- platform/efl/fast/gradients: [...]
- 2:54 AM Changeset in webkit [98943] by
-
- 7 edits in trunk/Source
[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
https://bugs.webkit.org/show_bug.cgi?id=71274
Reviewed by Kenneth Christiansen.
Source/WebCore:
- features.pri: Enable GESTURE_EVENTS.
Source/WebKit2:
- Shared/WebEvent.h: Add GestureSingleTap as gesture type.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Support converting
WebEven::GestureSingleTap to PlatformGestureEvent::TapType.
- Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::isGestureEventType): GestureSingleTap is a valid gesture event type.
- WebKit2.pro: Add WebGestureEvent.cpp to the build.
- 2:54 AM Changeset in webkit [98942] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Fix valgrind error about uninitialized variable
https://bugs.webkit.org/show_bug.cgi?id=71273
Reviewed by Kenneth Christiansen.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Initialize isPrimary.
- 12:35 AM Changeset in webkit [98941] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)
- platform/chromium/test_expectations.txt:
- 12:24 AM Changeset in webkit [98940] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r98847.
http://trac.webkit.org/changeset/98847
https://bugs.webkit.org/show_bug.cgi?id=71268
"Debugger test failures on multiple platforms" (Requested by
yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-01
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
LayoutTests:
- inspector/debugger/bind-script-to-resource-expected.txt: Removed.
- inspector/debugger/bind-script-to-resource.html: Removed.
- inspector/debugger/linkifier-expected.txt:
- inspector/debugger/linkifier.html:
- 12:11 AM Changeset in webkit [98939] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline test started failing because syntax errors in inline handlers
are now reported to console.
window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991
- fast/js/invalid-syntax-for-function-expected.txt:
