Timeline



Nov 9, 2011:

11:59 PM Changeset in webkit [99819] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: console does not work after switching panel while editing.
​https://bugs.webkit.org/show_bug.cgi?id=71918

Reviewed by Yury Semikhatsky.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):

11:39 PM Changeset in webkit [99818] by hayato@chromium.org
  • 7 edits in trunk

[NRWT] Make results.html aware of reference filename in reftests.
​https://bugs.webkit.org/show_bug.cgi?id=71574

Reviewed by Ryosuke Niwa.

If a reference filename is different from the default one, include that in result summary
so results.html can link to the correct reference file.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

LayoutTests:

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
  • platform/chromium/fast/harness/results-expected.txt:
11:12 PM Changeset in webkit [99817] by scherkus@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-11-09 Andrew Scherkus <​scherkus@chromium.org>

Rebaselining media/video-frame-accurate-seek-expected.html now that it passes consistently.

  • platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-linux/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png: Added.
10:50 PM Changeset in webkit [99816] by commit-queue@webkit.org
  • 10 edits
    8 adds in trunk

Need support for dirname attribute
​https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html

fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html

  • html/HTMLAttributeNames.in:

Added "dirname" attribute.

  • html/HTMLInputElement.idl:

Add "dirName" property to HTMLInputElement interface.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.

  • html/HTMLTextAreaElement.idl:

Add "dirName" property to HTMLTextAreaElement interface.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.

  • html/HTMLTextFormControlElement.h:

Helper function for finding directionality of the Element.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.

  • html/TextFieldInputType.h:

Append dirname form data.

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Added.
  • fast/forms/form-dirname-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
  • fast/forms/submit-form-with-dirname-attribute.html: Added.
10:28 PM Changeset in webkit [99815] by scherkus@chromium.org
  • 12 edits in trunk/LayoutTests

2011-11-09 Andrew Scherkus <​scherkus@chromium.org>

chromium-gpu-linux media rebaselines due to r98596.

  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-empty-source-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
10:10 PM Changeset in webkit [99814] by commit-queue@webkit.org
  • 18 edits
    1 add in trunk

Internals.markerRangeForNode should be able to take markers by specifying a marker type.
​https://bugs.webkit.org/show_bug.cgi?id=71792

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-09
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

Test: editing/spelling/markers.html

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markersFor):

Takes marker types to get only necessary markers.

  • dom/DocumentMarkerController.h:
  • testing/Internals.cpp:

(WebCore::markerTypesFrom): Added.
(WebCore::Internals::markerCountForNode):

Takes marker types to get only necessary markers.

(WebCore::Internals::markerRangeForNode): ditto.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def: Exposed necessary references.
  • win/WebKit2CFLite.def: ditto.

LayoutTests:

  • editing/spelling/markers.html: Added.
  • editing/spelling/spelling-insert-html.html: Fixed function usage.
  • platform/chromium/test_expectations.txt: Skipped chromium test.
  • platform/gtk/Skipped: Skipped gtk test.
  • platform/qt/Skipped: Skipped qt test.
  • platform/win/Skipped: Skeipped win test.
9:45 PM Changeset in webkit [99813] by commit-queue@webkit.org
  • 9 edits
    6 copies
    1 move
    1 add
    1 delete in trunk/Source/WebCore

[Chromium] Add support for painting into an SkPicture and then rasterizing into tile-sized chunks.
​https://bugs.webkit.org/show_bug.cgi?id=71388

Patch by David Reveman <​reveman@chromium.org> on 2011-11-09
Reviewed by James Robinson.

Add UpdatableTexture class, which allows texture updater to
allocate tile specific resources and paint tiles separately.
Rename texture uploader classes and move them to separate files.

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Added.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::create):
(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::~BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::create):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::~FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::Texture::textureUpdater):
(WebCore::ImageLayerTextureUpdater::createTexture):
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::Texture::~Texture):
(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::Texture::Texture):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::~SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::drawPicture):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
8:49 PM Changeset in webkit [99812] by msaboff@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
​https://bugs.webkit.org/show_bug.cgi?id=71862

Changed LiteralParser to be templatized of character type.

Moved five enums out of class definition to work around a clang compiler defect.

Added lexIdentifier templated method to break out character specific versions.
Added static setParserTokenString templated method to handle setting approriately
sized string pointer.

To keep code in LiteralParser.cpp and keep LiteralParser.h small, the two
flavors of LiteralParser are explicitly instantiated at the end of
LiteralParser.cpp.

Reviewed by Oliver Hunt.

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::isJSONWhiteSpace):
(JSC::::tryJSONPParse):
(JSC::::makeIdentifier):
(JSC::::Lexer::lex):
(JSC::::Lexer::lexIdentifier):
(JSC::::Lexer::next):
(JSC::LChar):
(JSC::UChar):
(JSC::isSafeStringCharacter):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::currentToken):
(JSC::LiteralParser::Lexer::getErrorMessage):

  • runtime/UString.h:

(JSC::LChar):
(JSC::UChar):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::append):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):

8:40 PM Changeset in webkit [99811] by kevino@webkit.org
  • 5 edits in trunk

[wx] Unreviewed build fix. Update project files and add LTC stubs for new methods.

8:37 PM Changeset in webkit [99810] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Multiple CodeBlock should be able to share the same instruction
stream without copying
​https://bugs.webkit.org/show_bug.cgi?id=71978

Reviewed by Oliver Hunt.

This refactors CodeBlock::m_instructions to be a Vector boxed in a
ref-counted object, but otherwise does not take advantage of this.

This is performance neutral.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasInstructions):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):

  • jit/JIT.cpp:

(JSC::JIT::JIT):

8:35 PM Changeset in webkit [99809] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Add stub for new method.

8:33 PM Changeset in webkit [99808] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. wx should not be excluded from building ScopedFramePaintingState code.

8:28 PM Changeset in webkit [99807] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Don't run fontDataForCombiningCharacterSequence on wx as we don't support it yet.

8:21 PM Changeset in webkit [99806] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Update how we hash the font after changes to the StringHasher APIs.

8:17 PM Changeset in webkit [99805] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Support XCode 4 when building deps.

8:13 PM Changeset in webkit [99804] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have been removed from EventTarget.

7:10 PM Changeset in webkit [99803] by Martin Robinson
  • 5 edits in trunk/Source/WebCore

[Cairo] Avoid clipping when painting more often
​https://bugs.webkit.org/show_bug.cgi?id=71179

Reviewed by Xan Lopez.

No new tests. These changes are covered by existing tests.

  • platform/graphics/Gradient.h: Add a Cairo-specific method

that gets the platform gradient with a particular alpha value.

  • platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha

value of the last created platform gradient.
(WebCore::Gradient::platformGradient): If the cached platform gradient
has a different alpha value than the one requested, destroy it and start
over.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::drawPathShadow): Adjust the source to avoid calling
cairo_clip/cairo_paint_with_alpha and just do a fill.
(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
call cairo_fill.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::drawPatternToCairoContext): If we have a >= 1 alpha value
we can simply fill and avoid calling cairo_clip here.
(WebCore::prepareCairoContextSource): Remove TODO about recreating the
gradient. No longer need to reduce the gradient source.

7:00 PM Changeset in webkit [99802] by Martin Robinson
  • 2 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
​https://bugs.webkit.org/show_bug.cgi?id=70877

Reviewed by Philippe Normand.

Add a script that runs gtkdoc manually instead of using the autotools
magic. Remove now unused gtkdoc files.

  • GNUmakefile.am: Remove references to removed gtkdoc files.
  • UIProcess/API/gtk/docs/GNUmakefile.am: Removed.
  • UIProcess/API/gtk/docs/build-gtkdoc: Added.
  • UIProcess/API/gtk/docs/gtkdoc.py: Added.
  • UIProcess/API/gtk/docs/version.xml.in: Removed.
6:56 PM Changeset in webkit [99801] by scherkus@chromium.org
  • 2 edits
    9 deletes in trunk/LayoutTests

2011-11-09 Andrew Scherkus <​scherkus@chromium.org>

More media rebaselines due to r98596.

  • media/controls-without-preload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
  • platform/mac/media/controls-strict-expected.txt: Removed.
  • platform/win-wk2/media/controls-without-preload-expected.txt: Removed.
  • platform/win-xp/media/controls-without-preload-expected.txt: Removed.
  • platform/win/media/controls-without-preload-expected.txt:
6:48 PM Changeset in webkit [99800] by ap@apple.com
  • 5 edits in trunk/Source

<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
​https://bugs.webkit.org/show_bug.cgi?id=71964

Reviewed by Darin Adler.

Source/WebCore:

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

Don't ask the client for proxy credentials. CFNetwork results are authoritative, and proxy
credentials are system-wide.

Source/WebKit2:

  • WebProcess/com.apple.WebProcess.sb: Allow mach-lookup of com.apple.cfnetwork.AuthBrokerAgent.
6:40 PM Changeset in webkit [99799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix typo in checkerboarding code
​https://bugs.webkit.org/show_bug.cgi?id=71981

Patch by Daniel Sievers <​sievers@chromium.org> on 2011-11-09
Reviewed by James Robinson.

No new tests.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::drawTiles):

6:32 PM Changeset in webkit [99798] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Renovate ARMv7 assembler/macro-assembler
​https://bugs.webkit.org/show_bug.cgi?id=71982

Reviewed by Geoff Garen.

ARMv7Assembler:

  • add support for strb (byte stores)
  • rename the VMOV_CtoS opcodes (there are currently backwards!)
  • add support for adc (add with carry)
  • add support for vsqrt, vabs
  • add support for vmov (between FPRs, and to/from GPR pairs).
  • remove '_F64' postfixes from instructions (these aren't helpful, functions can already be distinguished by their signatures).
  • rename vcvt_F64_S32 to vcvt_signedToFloatingPoint, the prior postfix was unhelpful in failing to distinguish the types (S32 indicates a single precision register, but the type could be float, int32, or uint32).
  • rename vcvtr_S32_F64 to vcvt_floatingPointToSigned, as for previous, also vcvtr was the incorrect name for the operation (the emitted instruction truncates).

MacroAssemblerARMv7:

  • add 3-operand versions of and32, lshift32, or32, rshift32, urshift32, sub32, xor32,
  • add store8, and store32 imm to base-index.
  • fix load32WithCompactAddressOffsetPatch to work for all gprs (the fix is a little kludgy but functional; to do better we'll have to also fix the repatching code).
  • Update supportsFloating* flags (all features now supported).
  • add moveDouble, storeDouble to absolute address, addDouble to absolute address
  • add 3-operand double operations.
  • implement sqrtDouble/absDouble
  • add branchTruncateDoubleToInt32, implement truncateDoubleToInt32
  • move should do nothing if src == dest
  • branchTest8-on-memory can be implemented in terms of branchTest32-on-register (branchTest8-on-register has been removed).
  • add 3-operand branchAdd32, branchSub32, also branchAdd32 absolute address.
6:27 PM Changeset in webkit [99797] by tkent@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Chromium] Add expectation files for locale-sensitive-fonts.html
​https://bugs.webkit.org/show_bug.cgi?id=67019

  • platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Added.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Added.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:25 PM Changeset in webkit [99796] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Add WebMediaStreamRegistry
​https://bugs.webkit.org/show_bug.cgi?id=71458

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-09
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaStreamRegistry.h: Added.
  • src/WebMediaStreamRegistry.cpp: Added.

(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):

6:05 PM Changeset in webkit [99795] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

[WinCairo] Further exclusions for unsupported features.

  • platform/wincairo/Skipped: Turn off mathml and webgl tests.
5:53 PM Changeset in webkit [99794] by commit-queue@webkit.org
  • 3 edits
    5 deletes in trunk

Unreviewed, rolling out r99782.
​http://trac.webkit.org/changeset/99782
​https://bugs.webkit.org/show_bug.cgi?id=71979

broke most of the feImage tests (Requested by thorton on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-09

Source/WebCore:

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

LayoutTests:

  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Removed.
  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Removed.
  • svg/filters/feImage-reference-svg-primitive.svg: Removed.
  • svg/filters/feImage-zero-size-crash-expected.txt: Removed.
  • svg/filters/feImage-zero-size-crash.svg: Removed.
5:41 PM Changeset in webkit [99793] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
​https://bugs.webkit.org/show_bug.cgi?id=71938

Reviewed by Darin Adler.

Now no IDL files are using [CanBeConstructed] IDL.
We can safely remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Removed [CanBeConstructed]-related code.

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateImplementation):

  • bindings/scripts/test/TestInterface.idl: Removed [CanBeConstructed].
  • bindings/v8/V8Proxy.h: Removed V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext, which had been used only by [CanBeConstructed].
5:33 PM Changeset in webkit [99792] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Remove unnecessary type conversion for unscaledDocumentRect

5:21 PM Changeset in webkit [99791] by eric@webkit.org
  • 2 edits in trunk/Tools

Remove the concept of platform-dependent unittests
​https://bugs.webkit.org/show_bug.cgi?id=71963

Unreviewed. Fix test-webkitpy on cygwin.

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
5:16 PM Changeset in webkit [99790] by ojan@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Fix up expected results after ​http://trac.webkit.org/changeset/99772.
The chromium mac results match the platform/mac results.

  • platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
5:15 PM Changeset in webkit [99789] by scherkus@chromium.org
  • 55 edits
    27 moves
    10 adds
    11 deletes in trunk/LayoutTests

2011-11-09 Andrew Scherkus <​scherkus@chromium.org>

Rebaseline media layout tests due to r98596.

  • platform/chromium-cg-mac-snowleopard/media/audio-controls-rendering-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-styling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/controls-without-preload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/media-controls-clone-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-empty-source-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-empty-source-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-no-audio-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.png.
  • platform/chromium-cg-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.png.
  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-empty-source-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.txt.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.txt.
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.txt.
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Added.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.txt.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png.
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.png.
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-volume-slider-expected.png.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png: Removed.
  • platform/chromium-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-mac/media/controls-styling-expected.txt: Removed.
  • platform/chromium-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-mac/media/media-controls-clone-expected.png: Removed.
  • platform/chromium-mac/media/media-controls-clone-expected.txt: Removed.
  • platform/chromium-mac/media/video-display-toggle-expected.txt: Removed.
  • platform/chromium-mac/media/video-empty-source-expected.png: Removed.
  • platform/chromium-mac/media/video-no-audio-expected.png: Removed.
  • platform/chromium-mac/media/video-no-audio-expected.txt: Removed.
  • platform/chromium-mac/media/video-volume-slider-expected.txt: Removed.
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.txt.
  • platform/chromium/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.txt.
  • platform/chromium/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.txt.
  • platform/chromium/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.txt.
  • platform/chromium/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.txt.
  • platform/chromium/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.txt.
  • platform/chromium/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.txt.
  • platform/chromium/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.txt.
  • platform/chromium/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.txt.
  • platform/chromium/test_expectations.txt:
5:10 PM Changeset in webkit [99788] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

5:08 PM Changeset in webkit [99787] by fpizlo@apple.com
  • 23 edits
    6 adds in trunk/Source/JavaScriptCore

DFG OSR exit code should be lazily generated
​https://bugs.webkit.org/show_bug.cgi?id=71744

Reviewed by Gavin Barraclough.

The OSR exit code is now generated the first time it is executed,
rather than right after speculative compilation. Because most OSR
exits are never taken, this should greatly reduce both code size
and compilation time.

This is a 1% win on SunSpider, and a 1% win on V8 when running in
my harness. No change in V8 in V8's harness (due to the long runs,
so compile time is not an issue) and no change in Kraken (again,
long runs of small code so compile time has no measurable effect).

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::jump):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::jump):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::jmp_m):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::createDFGDataIfNecessary):
(JSC::CodeBlock::appendDFGOSREntryData):
(JSC::CodeBlock::numberOfDFGOSREntries):
(JSC::CodeBlock::dfgOSREntryData):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(JSC::CodeBlock::numberOfOSRExits):
(JSC::CodeBlock::numberOfSpeculationRecoveries):
(JSC::CodeBlock::osrExit):
(JSC::CodeBlock::speculationRecovery):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGCorrectableJumpPoint.cpp: Added.

(JSC::DFG::CorrectableJumpPoint::codeLocationForRepatch):

  • dfg/DFGCorrectableJumpPoint.h: Added.

(JSC::DFG::CorrectableJumpPoint::CorrectableJumpPoint):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
(JSC::DFG::CorrectableJumpPoint::correctInitialJump):
(JSC::DFG::CorrectableJumpPoint::correctLateJump):
(JSC::DFG::CorrectableJumpPoint::initialJump):
(JSC::DFG::CorrectableJumpPoint::lateJump):
(JSC::DFG::CorrectableJumpPoint::correctJump):
(JSC::DFG::CorrectableJumpPoint::getJump):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExit.cpp: Added.

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.cpp: Added.
  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

  • dfg/DFGThunks.cpp: Added.

(JSC::DFG::osrExitGenerationThunkGenerator):

  • dfg/DFGThunks.h: Added.
  • jit/JITCode.h:

(JSC::JITCode::dataAddressAtOffset):

  • runtime/JSGlobalData.h:
5:07 PM Changeset in webkit [99786] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Add cc-bugs group to watch changes in chromium graphics
​https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <​danakj@chromium.org> on 2011-11-09
Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
  • Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
  • Scripts/webkitpy/common/config/watchlist: Add ​cc-bugs@google.com to watch list
  • Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
5:04 PM Changeset in webkit [99785] by eric@webkit.org
  • 5 edits in trunk/Tools

Remove more platform-dependent unittests
​https://bugs.webkit.org/show_bug.cgi?id=71971

Reviewed by Adam Barth.

Tests which only run on a couple platforms will break.
All tests should run on all platforms where possible.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
5:03 PM Changeset in webkit [99784] by eae@chromium.org
  • 5746 edits
    3944 copies
    216 deletes in branches/subpixellayout

Merging trunk changes up until 99750 into subpixel branch.

4:49 PM Changeset in webkit [99783] by ojan@chromium.org
  • 3 edits in trunk/Tools

Merge in results to the test results server even if build numbers conflict
​https://bugs.webkit.org/show_bug.cgi?id=71967

Reviewed by Tony Chang.

This was initially meant to be a sanity check that we don't
enter duplicate runs, but it turns out that we can reasonably get
in these situations when a builder is clobbered (e.g. the build
numbers start over again from 0).

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
4:39 PM Changeset in webkit [99782] by timothy_horton@apple.com
  • 3 edits
    5 adds in trunk

feImage referencing a primitive draws incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=71731
<rdar://problem/10408178>

Reviewed by Simon Fraser.

Don't attempt to resolve an <feImage>'s referenced element until it's used, as it
may not exist at the time the attribute is set on the <feImage>.

Don't attempt to render an <feImage> if the referenced element is of size 0x0.

Tests: svg/filters/feImage-reference-svg-primitive.svg

svg/filters/feImage-zero-size-crash.svg

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

Add a test (feImage-reference-svg-primitive) that ensures that having
an <feImage> referencing an SVG primitive which is declared after it
successfully paints the referenced object.

Add a test (feImage-zero-size-crash) to see if we crash when <feImage>
references an object with 0x0 size.

  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Added.
  • svg/filters/feImage-reference-svg-primitive.svg: Added.
  • svg/filters/feImage-zero-size-crash-expected.txt: Added.
  • svg/filters/feImage-zero-size-crash.svg: Added.
4:24 PM Changeset in webkit [99781] by eric@webkit.org
  • 14 edits in trunk/Tools

Remove the concept of platform-dependent unittests
​https://bugs.webkit.org/show_bug.cgi?id=71963

Reviewed by Adam Barth.

These have been the source of never-ending sadness.
We'd change behavior and forget to update results in
some unittests because they were only run on certain platforms.
This change removes a large source of these platform-dependent
unittests, which was caused by the port_maker stuff.

It's possible that this change will break test-webkitpy
on some platforms, but that will be a one-time cost.
I will fix the breakage by removing the platform-dependantness
of any such broken tests.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
4:11 PM Changeset in webkit [99780] by dominicc@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove WebGLContextEvent.initEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71720

Reviewed by Adam Barth.

The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.

No new tests--removing untested code.

  • html/canvas/WebGLContextEvent.cpp:
  • html/canvas/WebGLContextEvent.h:
  • html/canvas/WebGLContextEvent.idl:
4:04 PM Changeset in webkit [99779] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixing build breakage

Unreviewed build fix

3:59 PM Changeset in webkit [99778] by andersca@apple.com
  • 6 edits in trunk/Source

Element::boundsInWindowSpace should be Element::boundsInRootViewSpace
​https://bugs.webkit.org/show_bug.cgi?id=71955

Reviewed by Sam Weinig.

Source/WebCore:

Element::boundsInWindowSpace is only used by WebKit2, where the window coordinate space is the
same as the root view coordinate space. This lets us get rid of another use of contentsToWindow.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace):

  • dom/Element.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):
Call Element::boundsInRootViewSpace.

3:56 PM Changeset in webkit [99777] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix file formatting.

3:55 PM Changeset in webkit [99776] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rebaseline run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
3:55 PM Changeset in webkit [99775] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Fix break after r99644.

3:47 PM Changeset in webkit [99774] by commit-queue@webkit.org
  • 31 edits in trunk/Source

[chromium] Add draw-time scale delta to compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=71595

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-09
Reviewed by James Robinson.

There are two magnify values:

  1. The WebKit-side pageScale value corresponding to the resolution of the painted content.
  2. The Impl-side-only scaleDelta value representing the additional degree of current magnification, applied as a draw transform. WebKit is never explicitly aware of this value and the only way to change it currently is via pinch events (and in the future, double-tap/etc events). At the end of a pinch zoom, we multiply pageScale * scaleDelta and tell WebKit to use it as the new pageScale.

Scroll offsets and max-extents are maintained in pageScale space.
When the scale changes, we need to take care to convert them to the
new scale and avoid getting them clamped to the extents at the wrong
scale.

I removed maxScrollPosition on the non-impl side because it makes no
sense to precompute it in the presence of an impl-side zoom. Replaced
with a simple 'bool m_scrollable'.

zoomAnimatorTransform is not used because it currently isn't in the
branch, and mostly doesn't behave the way we want anyway (it does most
things in WebKit thread). We will need to unify these later.

Also introduce deviceOrPageScaleFactorChanged() call which invalidates
layers.

Source/WebCore:

No new tests (filed 71529 to remember to do it later).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::pageScaleChanged):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setPageMagnifyTransform):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setViewport):

  • platform/graphics/chromium/NonCompositedContentHost.h:

(WebCore::NonCompositedContentHost::topLevelRootLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scrollable):
(WebCore::CCLayerImpl::setScrollable):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScale):
(WebCore::CCLayerTreeHost::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::pageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setViewport):
(WebCore::CCLayerTreeHostImpl::setPageScale):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::pinchGestureEnd):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::pageScale):

  • platform/graphics/chromium/cc/CCScrollController.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebLayerTreeViewClient.h:
  • public/WebView.h:
  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::expectContains):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::applyScrollAndScale):
(WTF::MockLayerTreeHostClient::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollAndScale):

3:40 PM Changeset in webkit [99773] by eric@webkit.org
  • 40 edits in trunk/Tools

Make the Port object have a Host
​https://bugs.webkit.org/show_bug.cgi?id=71961

Reviewed by Adam Barth.

This has been a long time coming.
Now that Port has a Host object, it's very easy
to write unittests which use a properly mocked Port.
Soon we will remove the executive, filesystem and user
members of Port and get everything through the Host.

Note how in many callsites we're actually removing
explicit mocks, since we're now always going to get the
correct Executive/User/FileSystem from the
Host and callsites don't need to be careful to pass each one.

This is prep-work for adding a new Environment member to
Host and needing to be able to access the Environment
member from Port functions w/o needing to pass an Environment
object (or appropriate Mock) every place we create a Port object.
Now that we have a single Host object to reach out through, its
simple to add additional functionality (like Environment) while
keeping our unittests properly mocked.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/apple.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3:40 PM Changeset in webkit [99772] by haraken@chromium.org
  • 4 edits
    6 deletes in trunk/LayoutTests

Use dumpAsText() to avoid an image result being generated
​https://bugs.webkit.org/show_bug.cgi?id=71386

Reviewed by Tony Chang.

single-line-must-not-be-split-into-two-pages.html had been producing
a huge image result. What we need is a way by which we can generate a
DumpRenderTree result but do not generate an image even if
--pixel-test option is specified for ./Tools/Scripts/new-run-webkit-tests.
This patch realizes it using dumpAsText() and
window.internals.elementRenderTreeAsText.

  • printing/single-line-must-not-be-split-into-two-pages.html: Used dumpAsText() and window.internals.elementRenderTreeAsText.
  • platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
  • platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Updated a test result.
  • platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Ditto.
3:32 PM Changeset in webkit [99771] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-09 Andrew Scherkus <​scherkus@chromium.org>

Clean up a few media test expectations.

  • platform/chromium/test_expectations.txt:
3:28 PM Changeset in webkit [99770] by dmazzoni@google.com
  • 5 edits
    2 adds in trunk

Source/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForPosition
returns -1.
​https://bugs.webkit.org/show_bug.cgi?id=71561

Adds layout test: platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html

Reviewed by Dimitri Glazkov.

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::lineBreaks):

Tools: [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
​https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::insertionPointLineNumberGetterCallback):

LayoutTests: [Chromium] Add new test for crash in WebAccessibilityObject::lineBreaks
​https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

  • platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt: Added.
  • platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html: Added.
3:27 PM Changeset in webkit [99769] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebGraphicsLayer behaves wrongly when no contentsScale is set.
​https://bugs.webkit.org/show_bug.cgi?id=71959

Reviewed by Noam Rosenthal.

The contentsScale needs to get a default value just like
TiledBackingStore in case no value is explicitely set.

It is covered by existing tests.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):

3:21 PM Changeset in webkit [99768] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

De-virtualize JSVariableObject::isDynamicScope
​https://bugs.webkit.org/show_bug.cgi?id=71933

Reviewed by Geoffrey Garen.

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h: Inlined and de-virtualized isDynamicScope

(JSC::JSActivation::isDynamicScope):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h: Inlined and de-virtualized isDynamicScope

(JSC::JSGlobalObject::isDynamicScope):

  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h: Inlined and de-virtualized isDynamicScope

(JSC::JSStaticScopeObject::createStructure): Changed createStructure to use new JSType
(JSC::JSStaticScopeObject::isDynamicScope):

  • runtime/JSType.h: Added new type for JSStaticScopeObject
  • runtime/JSVariableObject.cpp: De-virtualized and added an implementation that checks the

object's type and calls the corresponding implementation.
(JSC::JSVariableObject::isDynamicScope):

  • runtime/JSVariableObject.h:
3:14 PM Changeset in webkit [99767] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

De-virtualize JSGlobalObject::hasOwnPropertyForWrite
​https://bugs.webkit.org/show_bug.cgi?id=71934

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalObject.h: Removed the virtual-ness of hasOwnPropertyForWrite since nobody overrides it.
3:13 PM Changeset in webkit [99766] by jcivelli@chromium.org
  • 4 edits in trunk/Source

Fix MHTML generation to use the QuotedPrintable encoding for text resources.
This was regressed when we added binary encoding support.
​https://bugs.webkit.org/show_bug.cgi?id=71857

Reviewed by Adam Barth.

Source/WebCore:

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WebKit/chromium:

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::LineReader::LineReader):
(WebKit::LineReader::getNextLine):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::TEST_F):

3:05 PM Changeset in webkit [99765] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::absDouble):

  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::absDouble):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::absDouble):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::absDouble):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::absDouble):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

2:58 PM Changeset in webkit [99764] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Replace [CanBeConstructed] IDL with [Constructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=71927

Reviewed by Adam Barth.

With respect to the IDL files that have [CanBeConstructed]
but do not have [Constructor] nor [CustomConstructor],
[CanBeConstructed] is now equivalent to [Constructor].
Thus, this patch replaces [CanBeConstructed] with [Constructor].

No tests. No change in behavior.

  • fileapi/FileReaderSync.idl: As I described above.
  • fileapi/WebKitBlobBuilder.idl: Ditto.
  • fileapi/WebKitFlags.idl: Ditto.
  • xml/DOMParser.idl: Ditto.
  • xml/XMLSerializer.idl: Ditto.
  • xml/XPathEvaluator.idl: Ditto.
2:53 PM Changeset in webkit [99763] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Separate image encoding from dataURL construction
​https://bugs.webkit.org/show_bug.cgi?id=71846

Reviewed by Adam Barth.

Remove the implicit assumption that a dataURL is the only desired output format of the
the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::encodeImage): Output the encoded image to a Vector.
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType encoded
image Vector here. Move the mimeType encoding debug check here to better align this
code with the CG (CoreGraphics) ImageBuffer.cpp implementation.
(WebCore::ImageDataToDataURL): ditto.

2:43 PM Changeset in webkit [99762] by commit-queue@webkit.org
  • 4 edits in trunk

Implement dumpProgressFinishedCallback() for Mac layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=66772

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2011-11-09
Reviewed by Simon Fraser.

Tools:

When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
"postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().

On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):

LayoutTests:

Unskip the skipped test.

  • platform/mac/Skipped:
2:29 PM Changeset in webkit [99761] by commit-queue@webkit.org
  • 3 edits
    12 adds in trunk

Chromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom scrollbar css.
​https://bugs.webkit.org/show_bug.cgi?id=71719

Source/WebCore:

This was caused by the overhang calculation logic not being consistent when subtracting the scrollbar sizes from the overhang areas. This resulted in for e.g. a horizontal overhang that didn't overlap with the scrollbar while the vertical overhang overlapped with it. This fix makes the logic consistent so that the overhang areas do not overlap with the scrollbars (when scrollbars are opaque).

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

Tests: platform/chromium/rubberbanding/custom-scrollbars-ne.html

platform/chromium/rubberbanding/custom-scrollbars-nw.html
platform/chromium/rubberbanding/custom-scrollbars-se.html
platform/chromium/rubberbanding/custom-scrollbars-sw.html

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

LayoutTests:

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-ne.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-nw.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-se.html: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
  • platform/chromium/rubberbanding/custom-scrollbars-sw.html: Added.
2:20 PM Changeset in webkit [99760] by jchaffraix@webkit.org
  • 1 edit
    15 adds
    1 delete in trunk/LayoutTests

Unreviewed rebaseline after r99752.

  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
  • platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
2:16 PM Changeset in webkit [99759] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=71880

Reviewed by Tony Chang.

Makes the test run ~10x faster by making the second select element only have 16
option elements. As best I can tell, that covers all the edge cases from r99653.

Also, cleaned up the test to make it a more normal js test:
-Gave it a doctype so it's in standards-mode.
-Moved the description to a description call.
-Generated both select element in script instead of just one of them.

  • fast/forms/select-clientheight-large-size-expected.txt:
  • fast/forms/select-clientheight-large-size.html:
  • platform/chromium/test_expectations.txt:
2:09 PM Changeset in webkit [99758] by vangelis@chromium.org
  • 12 edits in branches/chromium/912

Merge 99485 - Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForScrollableFrames):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:

TBR=​vangelis@chromium.org
Review URL: ​http://codereview.chromium.org/8506028

1:59 PM Changeset in webkit [99757] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Update test description.

Not reviewed.

  • svg/dom/rgb-color-parser-expected.txt:
1:25 PM Changeset in webkit [99756] by commit-queue@webkit.org
  • 5 edits in trunk

Source/WebCore: Indentation error in RenderObject::container
​https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

A conditional block was indented too far; correcting.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

LayoutTests: Rebaselining gtk and qt results for foreign object overflow
​https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.

  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
1:18 PM Changeset in webkit [99755] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
​https://bugs.webkit.org/show_bug.cgi?id=71947

Reviewed by Sam Weinig.

This gets rid of a few calls to contentsToWindow and windowToContents.

  • inspector/DOMNodeHighlighter.cpp:
  • page/DragController.cpp:

(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

1:09 PM Changeset in webkit [99754] by mhahnenberg@apple.com
  • 92 edits in trunk/Source

De-virtualize JSObject::getOwnPropertyDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=71523

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

(JSC::DebuggerActivation::getOwnPropertyDescriptor):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertyDescriptor):

  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:
  • runtime/ClassInfo.h:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/DatePrototype.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyDescriptor):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertyDescriptor):

  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertyDescriptor):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertyDescriptor):

  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::vtableAnchor):
(JSC::JSObject::propertyIsEnumerable):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a

bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject. There were
no call sites for this version of getOwnPropertyDescriptor in the entire project.

  • runtime/JSString.h:
  • runtime/Lookup.h:

(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/MathObject.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptor):

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertyDescriptor):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertyDescriptor):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
(JSC::StringObject::getOwnPropertyDescriptor):

  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/StringPrototype.h:

Source/WebCore:

No new tests.

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyDescriptor):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::vtableAnchor): Added to prevent a weak vtable.
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_method.h: Changed getOwnPropertyDescriptor from private to protected to allow

subclasses to use it in their MethodTables.

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):

  • bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyDescriptor):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
12:49 PM Changeset in webkit [99753] by xji@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Rebaseline after r99616 and r99736.
Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
so that cr-mac failed for text too.

  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
12:35 PM Changeset in webkit [99752] by jchaffraix@webkit.org
  • 4 edits
    24 adds in trunk

REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
​https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html

fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
fast/repaint/scroll-inside-table-cell.html
fast/repaint/scroll-relative-table-inside-table-cell.html
fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

  • rendering/RenderLayer.h:

Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • fast/repaint/scroll-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-inside-table-cell.html: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
12:28 PM Changeset in webkit [99751] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

Tests depending on video-paint-test.js can run non-deterministically
​https://bugs.webkit.org/show_bug.cgi?id=71878

Reviewed by Darin Adler.

  • media/video-frame-accurate-seek.html: changed init() to initAndSeeked()
  • media/video-paint-test.js:
12:22 PM Changeset in webkit [99750] by haraken@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

Generate the HTMLAudioElement constructor using [NamedConstructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=71924

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLAudioElement
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • Target.pri: Removed V8HTMLAudioElementConstructor.{h,cpp}
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Removed.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h: Removed.
  • html/HTMLAudioElement.idl: Added [NamedConstructor] IDL.
  • page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
12:13 PM Changeset in webkit [99749] by Antti Koivisto
  • 21 edits
    26 deletes in trunk

Eliminate CSSMutableValue
​https://bugs.webkit.org/show_bug.cgi?id=71811

Source/WebCore:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

Remove the implementations of setter functions in SVGColor and SVGPaint. These interfaces are
deprecated in SVG 1.1 (2nd edition) and are not really used by anybody. This allows
removal of CSSMutableValue and the associated (rather broken) code.

The setters now throw NO_MODIFICATION_ALLOWED_ERR.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):

  • css/CSSMutableValue.h: Removed.
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getPropertyCSSValue):

  • css/CSSValue.h:

(WebCore::CSSValue::CSSValue):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):

  • svg/SVGPaint.h:

LayoutTests:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

SVGColor and SVGPaint setter function are deprecated and throw exception.

  • Remove (mostly render tree dump based) tests for SVGColor mutations that have little useful coverage otherwise.
  • Fix some other tests to work without the feature.
  • Update rgb-color-parser.html to also cover the cases from rgbcolor-syntax.svg (which is removed). They test the same thing but the former uses a better mechanism.
  • Update the test results to capture the new behavior.
  • fast/css/parse-color-int-or-percent-crash.html:
  • platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/gtk/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/gtk/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/mac/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/mac/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
  • platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
  • platform/qt/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/qt/svg/custom/rgbcolor-syntax-expected.txt: Removed.
  • svg/custom/SVGPaint-mutate-attribute.svg: Removed.
  • svg/custom/SVGPaint-mutate-inline-style.svg: Removed.
  • svg/custom/fill-SVGPaint-interface.svg:
  • svg/custom/getPresentationAttribute-modify-expected.txt: Removed.
  • svg/custom/getPresentationAttribute-modify.svg: Removed.
  • svg/custom/getPresentationAttribute.svg:
  • svg/custom/rgbcolor-syntax.svg: Removed.
  • svg/dom/SVGColor-expected.txt:
  • svg/dom/SVGPaint-expected.txt:
  • svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Removed.
  • svg/dom/getPresentationAttribute-cache-corruption.svg: Removed.
  • svg/dom/rgb-color-parser-expected.txt:
  • svg/dom/rgb-color-parser.html:
  • svg/dom/script-tests/SVGColor.js:
  • svg/dom/script-tests/SVGPaint.js:
12:10 PM Changeset in webkit [99748] by Philippe Normand
  • 7 edits in trunk

[GTK][DRT] window internals object is not reset after each test
​https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Martin Robinson.

.:

  • Source/autotools/symbols.filter: Revert un-needed symbol.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic

calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

Call WebCoreTestSupport::resetInternalsObject without going
through DumpRenderTreeSupport.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

12:05 PM Changeset in webkit [99747] by haraken@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=71925

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
  • html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
  • page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
12:04 PM Changeset in webkit [99746] by Beth Dakin
  • 2 edits in trunk/Tools

Build fix.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementAttributeValue):

12:01 PM Changeset in webkit [99745] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

11:57 AM Changeset in webkit [99744] by jchaffraix@webkit.org
  • 4 edits
    6 adds in trunk

Crash in RenderTableSection::splitColumn
​https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
11:45 AM Changeset in webkit [99743] by Beth Dakin
  • 2 edits in trunk/Tools

Speculative build fix.

  • DumpRenderTree/AccessibilityUIElement.h:
11:35 AM Changeset in webkit [99742] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk

Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
​https://bugs.webkit.org/show_bug.cgi?id=71510

Patch by Arko Saha <​arko@motorola.com> on 2011-11-09
Reviewed by Darin Adler.

Source/WebCore:

Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr.
All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr.
Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it.

Test: fast/dom/MicroData/itemid-attribute-test-001.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isURLAttribute):

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::isURLAttribute):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isURLAttribute):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isURLAttribute):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::isURLAttribute):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAttribute):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute):

  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isURLAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isURLAttribute):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isURLAttribute):

  • html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isURLAttribute):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::isURLAttribute):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isURLAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isURLAttribute):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::isURLAttribute):

LayoutTests:

  • fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added.
  • fast/dom/MicroData/itemid-attribute-test-001.html: Added.
11:28 AM Changeset in webkit [99741] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build fix.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::makeJSAccessibilityUIElement):
A bad merge added this check that is making the bots sad.

11:08 AM Changeset in webkit [99740] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: crash when accessing selectedTab in a tab list
​https://bugs.webkit.org/show_bug.cgi?id=70938

Reviewed by Beth Dakin.

Source/WebCore:

There were a few methods accessing m_children directly without first validating that those elements
needed to be updated (because the layout changed). Changing those to call children() ensures
that they will have the correct children.

Test: platform/mac/accessibility/selected-tab-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):

Tools:

Add the ability to retrieve an element through an arbitrary attribute.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementAttributeValueCallback):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementAttributeValue):

LayoutTests:

  • platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
  • platform/mac/accessibility/selected-tab-crash.html: Added.
11:03 AM Changeset in webkit [99739] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Remove failures fixed with r99630.

  • platform/chromium/test_expectations.txt:
10:57 AM Changeset in webkit [99738] by Nate Chapin
  • 2 edits in branches/chromium/912/Source/WebCore/bindings/v8

Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:

TBR=Nate Chapin
Review URL: ​http://codereview.chromium.org/8511019

10:46 AM Changeset in webkit [99737] by Philippe Normand
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
test that needs investigation.

  • platform/gtk/Skipped:
  • platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
10:44 AM Changeset in webkit [99736] by xji@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Rebaseline after r99616.

  • platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:41 AM Changeset in webkit [99735] by Alexandru Chiculita
  • 2 edits in trunk/Source/WebKit2

Fixing build on MacOSX SL after 71838
​https://bugs.webkit.org/show_bug.cgi?id=71912

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

10:14 AM Changeset in webkit [99734] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Shrink HTMLCollection.
<​http://webkit.org/b/71928>

Reviewed by Darin Adler.

Rearrange the members of HTMLCollection, effectively shrinking
it by 16 bytes on 64-bit. This reduces memory consumption
by 531 kB when loading the full HTML5 spec.

On 32-bit it shrinks by 8 bytes, saving 265 kB.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::type):

10:11 AM Changeset in webkit [99733] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
​https://bugs.webkit.org/show_bug.cgi?id=71875

Reviewed by Anders Carlsson.

This is a step along the path of making OwnPtr work as HashMap value types.

  • wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.

Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
I did not change the code to fix style checker complaints.

  • wtf/HashTable.h: Added includes as needed and fixed include style.

(WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.

  • wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
10:07 AM Changeset in webkit [99732] by haraken@chromium.org
  • 42 edits in trunk/Source/WebCore

Remove redundant [CanBeConstructed] IDLs
​https://bugs.webkit.org/show_bug.cgi?id=71868

Reviewed by Adam Barth.

If a class has [Constructor] or [CustomConstructor],
then [CanBeConstructed] is not necessary.
This patch just removes [CanBeConstructed] from all the classes
that already have [Constructor] or [CustomConstructor].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.

(WebCore::ConfigureV8TestObjTemplate):

  • css/WebKitCSSMatrix.idl:
  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitMutationObserver.idl:
  • dom/WebKitTransitionEvent.idl:
  • fileapi/FileReader.idl:
  • html/DOMFormData.idl:
  • html/TextTrackCue.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/track/TrackEvent.idl:
  • mediastream/PeerConnection.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • webaudio/AudioContext.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XSLTProcessor.idl:
10:02 AM Changeset in webkit [99731] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

SVG foreignObject wrong container
​https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-09
Reviewed by Simon Fraser.

Source/WebCore:

Resubmitting a patch originally by ​scottmg@chromium.org.
In determining where to add to m_positionedObjects during a repaint,
containingBlock is used, which adds the absolute positioned object to
the containing foreignObject. But, when the contained object is
dirtied, container() was used to dirty up the tree, which skipped over
the foreignObject causing the wrong parent to needsLayout(). This fix
makes container() and containingBlock() handle svg foreignObject's in
the same way.

This patch will cause svg/overflow/overflow-on-foreignObject.svg to
require rebaselined results on qt and gtk ports.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

LayoutTests:

Added layout test for 64780 fix, rebaselined a test that it broke.
This will cause gtk and qt ports to also need rebaseline.

  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
  • svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
  • svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added
10:01 AM Changeset in webkit [99730] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

Shrink StyleSheet on 64-bit.
<​http://webkit.org/b/71923>

Reviewed by Darin Adler.

Move m_disabled to the top so it folds into the padding at
the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):

  • css/StyleSheet.h:
9:40 AM Changeset in webkit [99729] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add webkitdirs.pm:getArchitecture implementation for GTK
​https://bugs.webkit.org/show_bug.cgi?id=71370

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-09
Reviewed by Xan Lopez.

  • Scripts/webkitdirs.pm (determineArchitecture): Add an

implementation for ports using autotools, so that a vanilla
`run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
to build-jsc on x86-64 machines.

9:32 AM Changeset in webkit [99728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
​https://bugs.webkit.org/show_bug.cgi?id=71891

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-09
Reviewed by Antonio Gomes.

This is C++ code, there is no need to cast the new objects to their
parents when creating them.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

9:32 AM Changeset in webkit [99727] by Philippe Normand
  • 2 edits in trunk

Unreviewed, attempt to fix GTK 32-bits Release build after r99691.

  • Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.
9:15 AM BuildingQtOnLinux edited by Laszlo Gombos
(diff)
9:10 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Reorder bots (diff)
9:10 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Add new buildbots (diff)
9:07 AM Changeset in webkit [99726] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Adding missing implementation of WebMediaStreamDescriptor::label().

[Chromium] Missing WebMediaStreamDescriptor::label() implementation
​https://bugs.webkit.org/show_bug.cgi?id=71657

Patch by Henrik Grunell <​grunell@chromium.org> on 2011-11-09
Reviewed by Adam Barth.

  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::label):

9:07 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt versions on the bots (diff)
9:06 AM BuildingQtOnLinux edited by Laszlo Gombos
(diff)
9:01 AM Changeset in webkit [99725] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WebKit2] Prepare viewport meta handling for desktop usage
​https://bugs.webkit.org/show_bug.cgi?id=71907

Reviewed by Simon Hausmann.

This is only used by Qt so far. Now we don't always layout pages
without the viewport meta tag, using 980 as the layout width, but
instead we use that value (it is a setting) as a minimum value, or
else we use the viewport width.

  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewportSize):

8:31 AM Changeset in webkit [99724] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-09 Pavel Feldman <​pfeldman@google.com>

Not reviewed: make new inspector test pass on Qt.

  • http/tests/inspector-enabled/injected-script-discard.html:
8:29 AM Changeset in webkit [99723] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Esperanto-translation
​https://bugs.webkit.org/show_bug.cgi?id=69760

Unreviewed.
Patch by Kristjan SCHMIDT <​kristjan.schmidt@googlemail.com>

Patch by Philippe Normand <​pnormand@igalia.com> on 2011-11-09

  • eo.po: Added.
8:19 AM Changeset in webkit [99722] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

StyleSheet: Devirtualize styleSheetChanged().
<​http://webkit.org/b/71913>

Reviewed by Antti Koivisto.

Since this mechanism is only used by CSSStyleSheet, move it there.
Out-of-lined StyleSheet::setDisabled() so we can do a type check
before invoking it from there.

  • css/CSSStyleSheet.h:
  • css/StyleSheet.cpp:

(WebCore::StyleSheet::setDisabled):

  • css/StyleSheet.h:
8:12 AM Changeset in webkit [99721] by kbalazs@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Add platform results for Qt5.

  • platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.
7:58 AM Changeset in webkit [99720] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed, rolling out r99707.
​http://trac.webkit.org/changeset/99707

Re-enable until we can disable it together with tests in one
shot.

  • qmake/mkspecs/features/features.prf:
7:52 AM Changeset in webkit [99719] by vestbo@webkit.org
  • 3 edits
    1 add in trunk/Tools

[Qt] Disable use of QtUiTools if the library/module is not found

We rely on the lookup order of prf files to inject our own uitools.prf
that will verify that QtUiTools is in fact present before allowing the
CONFIG += uitools to have any effect.

Reviewed by Simon Hausmann.

7:46 AM Changeset in webkit [99718] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed, adding missing files to the build.

  • Target.pri: Add ContentTypeParser.cpp/h
7:40 AM Changeset in webkit [99717] by caseq@chromium.org
  • 5 edits in trunk

Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
​https://bugs.webkit.org/show_bug.cgi?id=71826

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

  • inspector/front-end/ScriptsPanel.js:

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

7:35 AM Changeset in webkit [99716] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-11-09 Pavel Feldman <​pfeldman@google.com>

Not reviewed: annotate inspector front-end javascript so that it compiled again.

  • inspector/front-end/ShortcutsScreen.js:
  • inspector/front-end/WorkerManager.js:
7:31 AM Changeset in webkit [99715] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r99711. (Signed/unsigned compare.)

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getDoubleValueInternal):

7:30 AM Changeset in webkit [99714] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
​https://bugs.webkit.org/show_bug.cgi?id=71842

These are the only WebKit-side changes needed. The rest will be done on the Chromium side.

Chromium bug: ​http://crbug.com/44350

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-11-09
Reviewed by Pavel Feldman.

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::moveWindowBy):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::moveWindowBy):

7:27 AM Changeset in webkit [99713] by apavlov@chromium.org
  • 32 edits in trunk

Web Inspector: Provisionally change StylesSidebarPane section DOM layout to allow media queries
​https://bugs.webkit.org/show_bug.cgi?id=71902

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

  • inspector/elements/elements-delete-inline-style-expected.txt:
  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/commit-selector-expected.txt:
  • inspector/styles/css-live-edit-expected.txt:
  • inspector/styles/metrics-box-sizing-expected.txt:
  • inspector/styles/metrics-box-sizing.html:
  • inspector/styles/parse-utf8-bom-expected.txt:
  • inspector/styles/parse-utf8-bom.html:
  • inspector/styles/show-user-agent-styles-expected.txt:
  • inspector/styles/show-user-agent-styles.html:
  • inspector/styles/styles-add-blank-property-expected.txt:
  • inspector/styles/styles-add-invalid-property-expected.txt:
  • inspector/styles/styles-add-new-rule-expected.txt:
  • inspector/styles/styles-cancel-editing-expected.txt:
  • inspector/styles/styles-change-node-while-editing-expected.txt:
  • inspector/styles/styles-commit-editing-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-disable-inherited-expected.txt:
  • inspector/styles/styles-disable-then-change-expected.txt:
  • inspector/styles/styles-disable-then-delete-expected.txt:
  • inspector/styles/styles-formatting-expected.txt:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-source-lines-inline-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:
7:12 AM Changeset in webkit [99712] by Simon Hausmann
  • 6 edits in trunk

Unreviewed, rolling out r99701.
​http://trac.webkit.org/changeset/99701

Breaks Qt mac build

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(initResources):
(WebKit::WebPage::platformInitialize):

Tools:

  • qmake/mkspecs/features/functions.prf:
7:10 AM Changeset in webkit [99711] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

CSSPrimitiveValue: Fix up bitfield member types.
<​http://webkit.org/b/71751>

Reviewed by Antti Koivisto.

The primitive unit type doesn't need to be a signed value,
and by making it unsigned, we can shave one bit off of it.
Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
bool, not unsigned.

  • css/CSSValue.h:
7:09 AM Changeset in webkit [99710] by Philippe Normand
  • 1 edit
    16 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/focus-rings-expected.txt: Added.
  • platform/gtk/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
7:04 AM Changeset in webkit [99709] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: discard injected scripts upon front-end disconnect.
​https://bugs.webkit.org/show_bug.cgi?id=71823

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector-enabled/injected-script-discard.html

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::clearFrontend):

LayoutTests:

  • http/tests/inspector-enabled/injected-script-discard-expected.txt: Added.
  • http/tests/inspector-enabled/injected-script-discard.html: Added.
7:03 AM Changeset in webkit [99708] by andreas.kling@nokia.com
  • 16 edits in trunk/Source/WebCore

CSS: Remove empty value and rule destructors.
<​http://webkit.org/b/71901>

Reviewed by Antti Koivisto.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::create):

  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):

  • css/CSSCharsetRule.cpp:
  • css/CSSCharsetRule.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSFlexValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSPageRule.cpp:
  • css/CSSPageRule.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSValueList.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.h:
7:02 AM Changeset in webkit [99707] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Prospective build fix for Win32/Mac with xmlpatterns

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf: Disable XSLT support initially.

We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
is not up to the task of full XSLT support, so we should disable it.

7:00 AM Changeset in webkit [99706] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
<​http://webkit.org/b/71897>

Reviewed by Antti Koivisto.

Everything that inherits from RefCounted<T> is already fast-allocated,
so we don't need this in subclasses.

  • css/CSSImageValue.h:
  • css/CSSImportRule.h:
  • css/WebKitCSSShaderValue.h:
6:58 AM Changeset in webkit [99705] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skip a crashing test.

  • platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-table.html
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
6:51 AM Changeset in webkit [99704] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
​https://bugs.webkit.org/show_bug.cgi?id=71906

Unreviewed gardening. Skip failing tests.

  • platform/qt-5.0/Skipped:
6:45 AM Changeset in webkit [99703] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] Clean up TextureMapperAnimation constructor
​https://bugs.webkit.org/show_bug.cgi?id=71892

Remove copyAnimationValue and copyTimingFunction static functions. KeyframeList has
a copy constructor and it does not need anymore these copy functions.

Reviewed by Simon Hausmann.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperAnimation::TextureMapperAnimation):

6:40 AM Changeset in webkit [99702] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails
​https://bugs.webkit.org/show_bug.cgi?id=71896

Unreviewed gardening.

  • platform/wk2/Skipped:
6:40 AM Changeset in webkit [99701] by Simon Hausmann
  • 6 edits in trunk

Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf: Use --whole-archive and their

mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

6:07 AM Changeset in webkit [99700] by rgabor@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Buildfix for 32bit debug mode.

Reviewed by Csaba Osztrogonác.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

6:00 AM Changeset in webkit [99699] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
​https://bugs.webkit.org/show_bug.cgi?id=71554

Patch by Deepak Sherveghar <​bpwv64@motorola.com> on 2011-11-09
Reviewed by Simon Hausmann.

Source/WebKit/qt:

We should check the error domain when checking the error code in shouldFallBack()

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check

LayoutTests:

Un-skip the 4 failing layout test, we now check the error domain along with the error code in shouldFallBack()

  • platform/qt/Skipped:
5:59 AM Changeset in webkit [99698] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
​https://bugs.webkit.org/show_bug.cgi?id=42331

Unreviewed. Skip dependent test.

  • platform/wk2/Skipped: Skip http/tests/security/xssAuditor/script-tag-with-callbacks-actual.txt
5:58 AM Changeset in webkit [99697] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Some passing tests removed from Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=45598
​https://bugs.webkit.org/show_bug.cgi?id=32961
​http://bugreports.qt.nokia.com/browse/QTBUG-15566

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-11-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
5:55 AM Changeset in webkit [99696] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Enable the DFG JIT on X86-64 Linux platforms
​https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-09
Reviewed by Csaba Osztrogonác.

  • wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the

x86-64 GNU/Linux platform.

  • CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
5:55 AM Changeset in webkit [99695] by Alexandru Chiculita
  • 18 edits
    7 adds in trunk

[Part 1] Parse the custom() function in -webkit-filter
​https://bugs.webkit.org/show_bug.cgi?id=71441

Source/WebCore:

Added code that parses the custom() function. There's no code
for the CSSStyleSelector yet, so the only way to test this was to
check the "styleSheets" rules.

Reviewed by Dean Jackson.

Tests: css3/filters/custom-filter-property-parsing-invalid.html

css3/filters/custom-filter-property-parsing.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedFilter):

  • css/CSSParser.cpp:

(WebCore::filterInfoForName):
(WebCore::acceptCommaOperator):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):

  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp:

(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSShaderValue):

  • css/CSSValueKeywords.in:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::typeUsesSpaceSeparator):
(WebCore::WebKitCSSFilterValue::customCssText):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSShaderValue.h: Added.

(WebCore::WebKitCSSShaderValue::create):
(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):

  • platform/graphics/filters/FilterOperation.h:

LayoutTests:

Reviewed by Dean Jackson.

  • css3/filters/custom-filter-property-parsing-expected.txt: Added.
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt: Added.
  • css3/filters/custom-filter-property-parsing-invalid.html: Added.
  • css3/filters/custom-filter-property-parsing.html: Added.
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • css3/filters/script-tests/custom-filter-property-parsing.js: Added.

(jsWrapperClass):
(expression):
(description):

5:41 AM Changeset in webkit [99694] by Simon Hausmann
  • 4 edits in trunk/Source/WebKit2

[Qt] Fix geolocation enabled build.

Reviewed by Tor Arne Vestbø.

  • Target.pri: Add QT += location to get the right module includes.
  • UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file with the right name (GeoLocation -> Geolocation)
  • UIProcess/qt/WebGeolocationProviderQt.h: Removed the ENABLE(GEOLOCATION) guards, otherwise moc doesn't generate

code, because it can't interpret the ENABLE() macro.

5:31 AM Changeset in webkit [99693] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

Enable the DFG JIT on x86-64 Linux platforms
​https://bugs.webkit.org/show_bug.cgi?id=71373

Enable DFG JIT by default on X86 Linux and Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=71686

Buildfix for stricter compilers: -Werror=unused-but-set-variable

Reviewed by Zoltan Herczeg.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:19 AM Changeset in webkit [99692] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception in remote front-end load handler due to undefined reference to workerManager
​https://bugs.webkit.org/show_bug.cgi?id=71889

Move calls to WorkerManager load handlers into doLoadedDone method which is
called in case of remote front-end too.

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.loaded):

5:14 AM Changeset in webkit [99691] by Philippe Normand
  • 5 edits in trunk

[GTK][DRT] window internals object is not reset after each test
​https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Xan Lopez.

Source/WebKit/gtk:

DRTSupport infrastructure to reset the Internals object, like in Qt.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest): reset the Internals object after each test.

5:03 AM Changeset in webkit [99690] by vestbo@webkit.org
  • 4 edits in trunk/Tools

[Qt] Detect presence of QtUiTools and enable it only when available

The disable_uitools option was a workaround for missing detection.

Reviewed by Simon Hausmann.

5:02 AM Changeset in webkit [99689] by vsevik@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
​https://bugs.webkit.org/show_bug.cgi?id=71850

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):

  • inspector/front-end/ApplicationCacheModel.js: Added.

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._initializeApplicationCacheModel):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:01 AM Changeset in webkit [99688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Removed unused variable
​https://bugs.webkit.org/show_bug.cgi?id=71877

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2011-11-09
Reviewed by Andreas Kling.

Removed unused rect variable declaration and renamed rect1 variable to rect.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_smart_calculate):

4:42 AM Changeset in webkit [99687] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] nrwt pixeltests crash while test
​https://bugs.webkit.org/show_bug.cgi?id=71688

Patch by Roland Takacs <​takacs.roland@stud.u-szeged.hu> on 2011-11-09
Reviewed by Zoltan Herczeg.

  • platform/qt-5.0/Skipped:

'editing/pasteboard/data-transfer-items-image-png.html' is skipped, because it caused an nrwt pixel test crash.

3:58 AM Changeset in webkit [99686] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
​https://bugs.webkit.org/show_bug.cgi?id=71848

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.BaseStorageTreeElement.prototype.get displayName):
(WebInspector.BaseStorageTreeElement.prototype._updateDisplayName):
(WebInspector.BaseStorageTreeElement.prototype._updateTitle):
(WebInspector.BaseStorageTreeElement.prototype._updateSubtitle):
(WebInspector.BaseStorageTreeElement.prototype.set titleText):
(WebInspector.BaseStorageTreeElement.prototype.get subtitleText):
(WebInspector.BaseStorageTreeElement.prototype.set subtitleText):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.FrameTreeElement.prototype.get itemURL):
(WebInspector.FrameTreeElement.prototype.onselect):

3:56 AM Changeset in webkit [99685] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't override config for the build_pass of debug_and_release

Qmake will parse the profile once for each configuration (debug and
release), with the build_pass option set. In that situation we don't
want to override what qmake is setting explicitly, otherwise the
debug-step will end up hitting all the release-scopes.

Reviewed by Simon Hausmann.

3:55 AM Changeset in webkit [99684] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Only copy framework headers once when debug_and_release is enabled

Otherwise we might end up in a race condition where we try to symlink
the headers directory in the makefile for debug and release at the same
time.

Reviewed by Simon Hausmann.

3:49 AM Changeset in webkit [99683] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
​https://bugs.webkit.org/show_bug.cgi?id=71806

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/resolve-alien-node.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::resolveNode):

  • inspector/InspectorValues.h:

(WebCore::InspectorObject::setValue):
(WebCore::InspectorObject::setObject):
(WebCore::InspectorObject::setArray):
(WebCore::InspectorArray::pushValue):
(WebCore::InspectorArray::pushObject):
(WebCore::InspectorArray::pushArray):

LayoutTests:

  • inspector/elements/resolve-alien-node-expected.txt: Added.
  • inspector/elements/resolve-alien-node.html: Added.
3:47 AM Changeset in webkit [99682] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed. HiDPI is supported after r97407.

  • platform/gtk/Skipped: unskipped fast/hidpi
  • platform/gtk-wk2/Skipped: unskipped fast/hidpi
3:26 AM Changeset in webkit [99681] by Simon Hausmann
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r99678.
​http://trac.webkit.org/changeset/99678
​https://bugs.webkit.org/show_bug.cgi?id=71882

broke the build with -Werror=unused-but-set-variable
(Requested by tronical_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-09

  • CMakeListsEfl.txt:
  • wtf/Platform.h:
3:19 AM Changeset in webkit [99680] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unbreak the Qt build (copy & paste mistake - oops)

  • qmake/mkspecs/features/functions.prf:
3:12 AM Changeset in webkit [99679] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

Move CSSPrimitiveValue bitfields up into CSSValue.
<​http://webkit.org/b/71835>

Reviewed by Darin Adler.

Move m_type (and rename it to m_primitiveUnitType),
m_hasCachedCSSText and m_isQuirkValue from CSSPrimitiveValue
up into CSSValue to share the space.

This, together with the devirtualization of CSSValue that
happened on <​http://webkit.org/b/71666>, reduces the size
of CSSPrimitiveValue by one CPU word.

More specifically, we go from 16 to 12 bytes on 32-bit,
and from 24 to 16 bytes on 64-bit.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBColorValue):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getIdent):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::setPrimitiveType):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBA32Value):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getDashboardRegionValue):
(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):

  • css/CSSValue.h:

(WebCore::CSSValue::CSSValue):

3:03 AM Changeset in webkit [99678] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Enable the DFG JIT on X86-64 Linux platforms
​https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-09
Reviewed by Filip Pizlo.

  • wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the

x86-64 GNU/Linux platform.

  • CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.
2:46 AM Changeset in webkit [99677] by rgabor@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected results again.

  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
2:37 AM Changeset in webkit [99676] by Simon Hausmann
  • 5 edits in trunk/Tools

[Qt] Centralize duplicated code for linking the static libs

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/functions.prf:
  • qmake/mkspecs/features/javascriptcore.prf:
  • qmake/mkspecs/features/webcore.prf:
  • qmake/mkspecs/features/webkit2.prf:
2:18 AM Changeset in webkit [99675] by mhahnenberg@apple.com
  • 15 edits in trunk/Source

De-virtualize JSObject::defineOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=71429

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineOwnProperty):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):

Source/WebCore:

No new tests.

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

2:11 AM Changeset in webkit [99674] by yutak@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrollbars.svg.

  • platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:56 AM Changeset in webkit [99673] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Make [CanBeConstructed] IDL redundant
​https://bugs.webkit.org/show_bug.cgi?id=71871

Reviewed by Adam Barth.

As the first step to remove [CanBeConstructed] IDL completely,
we need to make [CanBeConstructed] IDL redundant.
This patch replaces '[CanBeConstructed]' in CodeGeneratorV8.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]',
and replaces '[CanBeConstructed]' in CodeGeneratorJS.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [JSCustomConstructor]'

An example:

before: '[CanBeConstructed] and ![V8CustomConstructor]'
after: '([CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]) and ![V8CustomConstructor]' <==> '([CanBeConstructed] or [Constructor] or [CustomConstructor]) and ![V8CustomConstructor]'

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified as I described above.

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::JSTestObjConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::V8TestObj::constructorCallback):

1:50 AM Changeset in webkit [99672] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT.

  • platform/chromium/test_expectations.txt:
1:42 AM Changeset in webkit [99671] by rgabor@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.

  • platform/qt/fast/forms/listbox-clip-expected.png:
  • platform/qt/fast/forms/listbox-clip-expected.txt:
1:25 AM Changeset in webkit [99670] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac.

  • platform/chromium/test_expectations.txt:
1:15 AM Changeset in webkit [99669] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-11-09 Nikolas Zimmermann <​nzimmermann@rim.com>

svg failures after r99561
​https://bugs.webkit.org/show_bug.cgi?id=71830

Reviewed by Antti Koivisto.

Fix regressions in svg/zoom/page/relative-sized-document-scrollbars.svg and svg/zoom/page/zoom-svg-as-relative-image.html.
Fix merging problem in r99561, bug 71780. It moved several methods from SVGLength to SVGLengthContext, and unfortunately
the SVGLength changes part of r98852, bug 47156, got reverted again, making these two tests fail.

  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
1:14 AM Changeset in webkit [99668] by yutak@chromium.org
  • 1 edit
    8 moves
    24 deletes in trunk/LayoutTests

[Chromium] Rebaseline tests added in r99613. Check in correct baselines for
the Mac Skia bots.

  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
  • platform/chromium/fast/multicol/pagination-h-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png.
  • platform/chromium/fast/multicol/pagination-h-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png.
  • platform/chromium/fast/multicol/pagination-h-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png.
  • platform/chromium/fast/multicol/pagination-h-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png.
  • platform/chromium/fast/multicol/pagination-v-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png.
  • platform/chromium/fast/multicol/pagination-v-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png.
  • platform/chromium/fast/multicol/pagination-v-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png.
  • platform/chromium/fast/multicol/pagination-v-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png.
12:56 AM Changeset in webkit [99667] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Select multiple options with mouse drag in Select element.
​https://bugs.webkit.org/show_bug.cgi?id=71128

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Ryosuke Niwa.

Multiple selection of option elements in select element with an mouse drag.
Other browsers(IE, Firefox, Opera) support this feature.

Source/WebCore:

Test: fast/forms/select-multiple-elements-with-mouse-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
Allow auto scroll to be fired if current node(option) under mouse does not have renderer
but its container node(select) can autoscroll and has renderer for specific case of ListBox

LayoutTests:

  • fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag.html: Added.
12:52 AM Changeset in webkit [99666] by Simon Hausmann
  • 11 edits in trunk

[Qt] Build system cleanup
​https://bugs.webkit.org/show_bug.cgi?id=71815

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

  • wtf/wtf.pri: Moved the glib dependency to javascriptcore.prf.

Source/WebCore:

  • Target.pri: Removed CodeGenHSL.cpp from the angle build. In the angle build the back-end has to

be either GLSL or HSL, it can't be both. Make a choice for GLSL as that's what it seems to be used for
at the moment.

Source/WebKit2:

  • Target.pri: Removed duplicated sources that are compiled also into QtWebKit.so through api.pri.
  • UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file here, as it should only be compiled

if geolocation is enabled.

  • UIProcess/qt/WebGeolocationProviderQt.h: Provide ENABLE(GEOLOCATION) guards around class definition.

Tools:

  • WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2

static library.

  • qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency

(ownPtr functions for glib types). Propagate that to everyone using javascriptcore.

12:51 AM Changeset in webkit [99665] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Fix the build.

  • WebCore.exp.in: Export the right symbol names.
  • WebCore.xcodeproj/project.pbxproj: Make the header file available outside of WebCore.
12:42 AM Changeset in webkit [99664] by Simon Hausmann
  • 15 edits
    3 adds in trunk/Source

[Qt] Replace use of QApplication with QGuiApplication
​https://bugs.webkit.org/show_bug.cgi?id=71794

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Add compat headers for use when building with Qt 4: QGuiApplication
is typedef'ed to QApplication.

  • wtf/qt/compat/QGuiApplication: Added.
  • wtf/qt/compat/qguiapplication.h: Added.

Source/WebCore:

  • Target.pri: Add compat include dir when compiling with Qt 4.
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::closeEvent): Replace use of QApplication with QGuiApplication.
(FullScreenVideoWindow::hideCursor): Ditto.
(FullScreenVideoWindow::showCursor): Ditto.

  • platform/graphics/qt/TileQt.cpp: Remove unnecessary inclusion of QApplication.
  • platform/qt/ClipboardQt.cpp: Replace use of QApplication with QGuiApplication.

(WebCore::ClipboardQt::ClipboardQt):
(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::declareAndWriteDragImage):
(WebCore::ClipboardQt::writeURL):
(WebCore::ClipboardQt::writeRange):
(WebCore::ClipboardQt::writePlainText):

  • platform/qt/PasteboardQt.cpp: Ditto.

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):

Source/WebKit/qt:

  • WebCoreSupport/QtWebComboBox.cpp:

(WebCore::QtWebComboBox::showPopupAtCursorPosition): Replace use of QApplication
with QCoreApplication.

Source/WebKit2:

  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove unnecessary QApplication inclusion.
  • Platform/qt/RunLoopQt.cpp: Replace QApplication include with QCoreApplication.
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Ditto.
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Remove unnecessary QApplication inclusion.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleMousePressEvent): Replace QApplication usage with QStyleHints.
(QtWebPageProxy::handleMouseDoubleClickEvent): Ditto.

12:29 AM Changeset in webkit [99663] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Mac Build fix part 2: Oops, use the correct wtf/ prefix for the WTF include.

  • page/SecurityPolicy.cpp:
12:19 AM Changeset in webkit [99662] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Prospective build fix for Windows: Include MainThread.h for ASSERT(isMainThread())
to compile.

  • page/SecurityPolicy.cpp:
12:06 AM Changeset in webkit [99661] by jcivelli@chromium.org
  • 4 edits
    8 adds in trunk/Source/WebKit/chromium

Fixes and reenables the WebPageSerializer tests.
​https://bugs.webkit.org/show_bug.cgi?id=71874

Reviewed by Adam Barth.

  • WebKit.gypi:
  • tests/WebPageNewSerializerTest.cpp:

(WebKit::TestWebFrameClient::~TestWebFrameClient):
(WebKit::WebPageNewSerializeTest::SetUp):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::WebPageSerializerTest):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

12:00 AM Changeset in webkit [99660] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectation of listbox-clip.html.

  • platform/chromium/test_expectations.txt:

Nov 8, 2011:

11:58 PM Changeset in webkit [99659] by abarth@webkit.org
  • 34 edits
    2 adds in trunk/Source

Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
​https://bugs.webkit.org/show_bug.cgi?id=71755

Reviewed by Eric Seidel.

Source/WebCore:

The SecurityOrigin class should be focused on representing a web
security origin rather than being a dumping ground for all
security-related state. This patch moves a bunch of static "policy"
state into its own SecurityPolicy class.

  • WebCore.exp.in:
  • WebCore.gypi:
  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canRequest):
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::grantLoadLocalResources):

  • page/SecurityOrigin.h:

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setReferrerForRequest):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::addOriginAccessWhitelistEntry):
(WebKit::WebSecurityPolicy::removeOriginAccessWhitelistEntry):
(WebKit::WebSecurityPolicy::resetOriginAccessWhitelists):
(WebKit::WebSecurityPolicy::shouldHideReferrer):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::initializeMainFrame):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::whiteListAccessFromOrigin):
(DumpRenderTreeSupportGtk::resetOriginAccessWhiteLists):

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::removeWhiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):

Source/WebKit/win:

  • WebView.cpp:

(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::resetOriginAccessWhitelists):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

11:55 PM Changeset in webkit [99658] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed, land correct expectations for Kusa-Makura-background-canvas.html.
The background color of this test should be white, not transparent.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
11:41 PM Changeset in webkit [99657] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, fix expectation conflict in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
11:23 PM Changeset in webkit [99656] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening. Update platform specific expected results.

  • platform/qt/fast/forms/listbox-clip-expected.png:
  • platform/qt/test_expectations.txt:
11:22 PM Changeset in webkit [99655] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r99539.

  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
11:18 PM Changeset in webkit [99654] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening. Update platform specific expected results.

  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
11:11 PM Changeset in webkit [99653] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

Default <select multiple> expands up to 10 items instead of showing 4.
​https://bugs.webkit.org/show_bug.cgi?id=70765

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2011-11-08
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/forms/select-clientheight-large-size.html

fast/forms/select-clientheight-with-multiple-attr.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::size):

LayoutTests:

  • fast/forms/select-clientheight-large-size-expected.txt: Added.
  • fast/forms/select-clientheight-large-size.html: Added.
  • fast/forms/select-clientheight-with-multiple-attr-expected.txt: Added.
  • fast/forms/select-clientheight-with-multiple-attr.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/listbox-clip-expected.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
10:41 PM Changeset in webkit [99652] by Csaba Osztrogonác
  • 14 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r99647.
​http://trac.webkit.org/changeset/99647
​https://bugs.webkit.org/show_bug.cgi?id=71876

It broke jsc and layout tests on all bot (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-08

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsDoubleBitops):
(JSC::MacroAssemblerARM::andnotDouble):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsDoubleBitops):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::andnotDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsDoubleBitops):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsDoubleBitops):
(JSC::MacroAssemblerSH4::andnotDouble):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::MacroAssemblerX86):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsDoubleBitops):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::andnotDouble):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsDoubleBitops):

  • assembler/X86Assembler.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

  • runtime/JSGlobalData.cpp:
9:47 PM Core Builders edited by abarth@webkit.org
(diff)
9:46 PM Core Builders edited by abarth@webkit.org
(diff)
9:46 PM Core Builders edited by abarth@webkit.org
(diff)
9:44 PM Changeset in webkit [99651] by hayato@chromium.org
  • 5 edits in trunk/Tools

[NRWT] Make single_test_runner aware of reference filename of test_input.
​https://bugs.webkit.org/show_bug.cgi?id=71567

Reviewed by Ryosuke Niwa.

Make single_test_runner honor a reference filename of given test_input so that
we can use any file as reference html, instead of depending on implicit naming convention.
The typical use case is to support w3c reftests.

No tests since no functional changes until there is a client.
Test should be easily written with future clients.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/models/test_failures.py:
  • Scripts/webkitpy/layout_tests/models/test_input.py:
9:44 PM Core Builders edited by abarth@webkit.org
(diff)
9:44 PM Core Builders created by abarth@webkit.org
8:20 PM Changeset in webkit [99650] by Martin Robinson
  • 2 edits in trunk

Take another stab at fixing the GTK+ build.

  • Source/autotools/symbols.filter: The symbols.filter file was missing a semicolon.
8:17 PM Changeset in webkit [99649] by cevans@google.com
  • 3 edits
    3 adds in trunk

Crash accessing font fact rule parent
​https://bugs.webkit.org/show_bug.cgi?id=71860

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/css-fontface-rule-crash.html

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule): tell our child rule when we are going away.

LayoutTests:

  • fast/css/css-fontface-rule-crash-expected.txt: Added.
  • fast/css/css-fontface-rule-crash.html: Added.
  • resources/gc.js: Added. Add a re-usable best-of-breed gc().
8:03 PM Changeset in webkit [99648] by nduca@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying
​https://bugs.webkit.org/show_bug.cgi?id=71637

Reviewed by Kenneth Russell.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::initializeExtensions):

7:02 PM Changeset in webkit [99647] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Better abstract 'abs' operation through the MacroAssembler.
​https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Currently the x86 specific instruction sequence to perform a double abs
is duplicated throughout the JITs / thunk generators.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
(JSC::MacroAssemblerARM::absDouble):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::absDouble):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
(JSC::MacroAssemblerSH4::absDouble):

  • Renamed supportsFloatingPointAbs, make these methods static so that we can check the JIT's capabilites before we begin compilation.
  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::absDouble):
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):

  • Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble.
  • assembler/MacroAssemblerX86Common.h:
    • Removed andnotDouble, added s_maskSignBit.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::absDouble):
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):

  • Made supports* methods static so that we can check the JIT's capabilites before we begin compilation. Added absDouble.
  • assembler/X86Assembler.h:

(JSC::X86Assembler::andpd_rr):
(JSC::X86Assembler::andpd_mr):

  • Added support for andpd instruction.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • Added checks for supportsFloatingPointAbs, supportsFloatingPointSqrt.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Switched to use doubleAbs, we can now also reuse the operand register for the result.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Switched to use doubleAbs, we can now also reuse the operand register for the result.
  • jit/ThunkGenerators.cpp:
    • Switched to use doubleAbs.

(JSC::absThunkGenerator):

  • runtime/JSGlobalData.cpp:
    • Declared MacroAssemblerX86Common::s_maskSignBit here. This is a little ugly, but it doesn't seem worth adding a whole extra .cpp to the compile for just one constant.
6:50 PM Changeset in webkit [99646] by dbates@webkit.org
  • 2 edits in trunk

Attempt to fix the GTK build after <​http://trac.webkit.org/changeset/99613>
(​https://bugs.webkit.org/show_bug.cgi?id=71840)

  • Source/autotools/symbols.filter: Add symbol _ZN7WebCore4Page13setPaginationERKNS0_10PaginationE.
5:51 PM Changeset in webkit [99645] by adamk@chromium.org
  • 75 edits in trunk/Source

Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
​https://bugs.webkit.org/show_bug.cgi?id=71845

Reviewed by Adam Barth.

Source/WebCore:

Some headers in WebCore include ExceptionCode.h to get the ExceptionCode typedef,
while others provide the typedef themselves. Per Darin, the latter is preferred,
so this patch updates all references, and fixes up .cpp files that
need the include in order to access the enum.

  • bindings/js/JSSVGLengthCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): #include ExceptionCode.h when needed for SVG.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation): #include ExceptionCode.h when needed for SVG.

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • css/WebKitCSSMatrix.h:
  • fileapi/DirectoryReaderSync.h:
  • fileapi/EntrySync.h:
  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/SyncCallbackHelper.h:
  • html/ClassList.h:
  • html/DOMSettableTokenList.h:
  • html/DOMTokenList.cpp:
  • html/DOMTokenList.h:
  • html/TextTrack.cpp:
  • html/TextTrack.h:
  • html/TimeRanges.cpp:
  • html/TimeRanges.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.h:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.h:
  • html/canvas/OESVertexArrayObject.h:
  • html/canvas/WebGLDebugShaders.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • mediastream/MediaStreamFrameController.cpp:
  • mediastream/MediaStreamFrameController.h:
  • notifications/Notification.h:
  • notifications/NotificationCenter.h:
  • storage/AbstractDatabase.cpp:
  • storage/AbstractDatabase.h:
  • storage/Database.h:
  • storage/DatabaseSync.h:
  • storage/DatabaseTask.h:
  • storage/IDBCursor.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/SQLResultSet.cpp:
  • storage/SQLResultSet.h:
  • storage/SQLStatementSync.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • svg/ElementTimeControl.h:
  • svg/SVGAngle.cpp:
  • svg/SVGAngle.h:
  • svg/SVGLength.cpp:
  • svg/SVGLength.h:
  • svg/SVGLengthContext.cpp:
  • svg/SVGLengthContext.h:
  • svg/SVGLocatable.h:
  • svg/SVGMatrix.h:
  • svg/SVGPreserveAspectRatio.cpp:
  • svg/SVGPreserveAspectRatio.h:
  • testing/Internals.h:
  • webaudio/AudioContext.cpp:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:
5:50 PM Changeset in webkit [99644] by Lucas Forschler
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=71839
Update the leaks bot OS to Lion.
Update the config.json to reflect the update.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:40 PM Changeset in webkit [99643] by barraclough@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Move duplicates of SYMBOL_STRING* macros to the single location
​https://bugs.webkit.org/show_bug.cgi?id=71456

Reviewed by Sam Weinig.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:
  • wtf/InlineASM.h: Added.
    • Moved asm related macros.
5:15 PM Changeset in webkit [99642] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed skiplist update to match main Windows
build, and to skip a few failures.

  • platform/wincairo/Skipped: Updated.
5:14 PM Changeset in webkit [99641] by haraken@chromium.org
  • 4 edits
    13 adds in trunk/Source/WebCore

CodeGeneratorV8.pm can generate a NamedConstructor
​https://bugs.webkit.org/show_bug.cgi?id=71756

Reviewed by Adam Barth.

  • IDLParser.pm can parse [NamedConstructor] IDL.
  • CodeGeneratorV8.pm can generate a NamedConstructor

and a template getter for the NamedConstructor.

  • Added a new binding test named TestNamedConstructor.idl.

Tests: WebCore/bindings/scripts/test/TestNamedConstructor.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Generates a header for a NamedConstructor.
(GenerateNamedConstructorCallback): Generates the NamedConstructor and a template getter for the NamedConstructor.
(GenerateSingleBatchedAttribute): If an IDL type is "XXXXConstructorConstructor", then we do not add a header file of XXXXConstructor, because the XXXXConstructor declaration is written in the header file of class XXXX.

  • bindings/scripts/IDLParser.pm:

(parseExtendedAttributes): Parses 'NamedConstructor' '=' name '(' parameters ')' ','?
(ParseInterface): Creates the signature of a NamedConstructor.

  • bindings/scripts/test/TestNamedConstructor.idl: Added a new test for the [NamedConstructor] IDL.
  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp: Added a run-binding-test result of TestNamedConstructor.idl.

(WebDOMTestNamedConstructor::WebDOMTestNamedConstructorPrivate::WebDOMTestNamedConstructorPrivate):
(WebDOMTestNamedConstructor::WebDOMTestNamedConstructor):
(WebDOMTestNamedConstructor::operator=):
(WebDOMTestNamedConstructor::impl):
(WebDOMTestNamedConstructor::~WebDOMTestNamedConstructor):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp: Ditto.

(WebKit::kit):
(WebKit::core):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_set_property):
(webkit_dom_test_named_constructor_get_property):
(webkit_dom_test_named_constructor_constructed):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):
(WebKit::wrapTestNamedConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.

(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorPrototype::self):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::createPrototype):
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toJS):
(WebCore::toTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h: Ditto.

(WebCore::JSTestNamedConstructor::create):
(WebCore::JSTestNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructor::impl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::JSTestNamedConstructorPrototype::create):
(WebCore::JSTestNamedConstructorPrototype::createStructure):
(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm: Ditto.

(-[DOMTestNamedConstructor dealloc]):
(-[DOMTestNamedConstructor finalize]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h: Ditto.
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.

(WebCore::TestNamedConstructorInternal::V8_USE):
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore::V8TestNamedConstructor::toActiveDOMObject):
(WebCore::V8TestNamedConstructor::wrapSlow):
(WebCore::V8TestNamedConstructor::derefObject):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.

(WebCore::V8TestNamedConstructor::toNative):
(WebCore::V8TestNamedConstructor::existingWrapper):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • page/DOMWindow.idl: Added [CustomConstructor] IDL to HTMLAudioElement, HTMLImageElement and HTMLOptionElement.
5:11 PM Changeset in webkit [99640] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Move code to handle 8bit regs from X86Assembler to MacroAssembler
​https://bugs.webkit.org/show_bug.cgi?id=71867

Reviewed by Oliver Hunt.

This code is fine, but is in the wrong place really. X86 assembler should
basically just format up exactly the instruction you request - not expand
out to a set of instructions (that is what the macro assembler layer is
for!). For other 8-bit ops, on X86 we don't guard against clients accessing
the XH registers.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movb_rm):

  • moved some code.
5:05 PM Changeset in webkit [99639] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r99626.
​http://trac.webkit.org/changeset/99626
​https://bugs.webkit.org/show_bug.cgi?id=71866

"C++ exceptions cannot be disabled without influencing the
Objective-C exceptions" (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-08

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
5:02 PM Changeset in webkit [99638] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

fix REGRESSION: SVG feColorMatrix causes crash
​https://bugs.webkit.org/show_bug.cgi?id=71287

Patch by Philip Rogers <​pdr@google.com> on 2011-11-08
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/filters/feColorMatrix-invalid-animation.svg

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

LayoutTests:

  • svg/filters/feColorMatrix-invalid-animation-expected.png: Added.
  • svg/filters/feColorMatrix-invalid-animation-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-animation.svg: Added.
5:01 PM Changeset in webkit [99637] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for GTK.

  • GNUmakefile.list.am:
4:58 PM Changeset in webkit [99636] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

  • assembler/X86Assembler.h:
4:56 PM Changeset in webkit [99635] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk, failed to commit this in last change.

  • assembler/X86Assembler.h:
4:47 PM Changeset in webkit [99634] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove an unused method.

Rubber stamped by Geoff Garen.

  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:
    • removed rewindToLabel.
4:43 PM Changeset in webkit [99633] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Fix OSR entry points to calculate offsets correctly WRT to branch compaction.
​https://bugs.webkit.org/show_bug.cgi?id=71864

Reviewed by Filip Pizlo.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::offsetOf):

  • We use this to return the offsets into the code of the entry points.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • Move the construction of the speculative JIT outside of compileBody, such that it is still available to link the OSR entry points at the point we are linking.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • Pass the label of the block & linkbuffer into noticeOSREntry.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • Moved call to noticeOSREntry until we we linking.
  • dfg/DFGSpeculativeJIT.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • Moved calculation of entries until we we linking.
  • jit/JIT.h:
    • Removed some members.
4:43 PM Changeset in webkit [99632] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add support for arrays of numbers to IDL bindings code generator
​https://bugs.webkit.org/show_bug.cgi?id=71763

Adds support for float[] and double[] to IDL. Support for other types
appears to be more complicated (or at least more copy-paste) so not
doing that for now for lack of need.

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-08
Reviewed by Adam Barth.

Tests added to TestObj.idl.

  • bindings/scripts/CodeGeneratorV8.pm:

(IsRefPtrType):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::floatArrayAttrGetter):
(WebCore::TestObjInternal::floatArrayAttrSetter):
(WebCore::TestObjInternal::doubleArrayAttrGetter):
(WebCore::TestObjInternal::doubleArrayAttrSetter):

  • bindings/v8/V8Binding.h:

(WebCore::v8NumberArray):
(WebCore::v8NumberArrayToVector):

4:27 PM Changeset in webkit [99631] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update the expectations. This test appears to also fail on the chromium mac bots.

  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [99630] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
​https://bugs.webkit.org/show_bug.cgi?id=71863

Reviewed by Anders Carlsson.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers): Instead of unconditionally flipping the background
rect here...

  • rendering/RenderView.cpp:

(WebCore::RenderView::backgroundRect): ...flip it only in column mode here.

  • rendering/RenderView.h:
4:21 PM Changeset in webkit [99629] by fpizlo@apple.com
  • 6 edits
    3 adds
    1 delete in trunk/Source/JavaScriptCore

DFG OSR exit code should be generated by a separate compiler, not
related to DFG::JITCompiler
​https://bugs.webkit.org/show_bug.cgi?id=71787

Reviewed by Gavin Barraclough.

Moves the exitSpeculativeWithOSR() method from JITCompiler to
OSRExitCompiler::compileExit().

  • CMakeListsEfl.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • dfg/DFGJITCompiler32_64.cpp: Removed.
  • dfg/DFGOSRExitCompiler.h: Added.

(JSC::DFG::OSRExitCompiler::OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp: Added.

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp: Added.

(JSC::DFG::OSRExitCompiler::compileExit):

  • runtime/JSValue.h:
4:13 PM Changeset in webkit [99628] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/mac

Move NSRange / DOMRange functions back to WebFrameInternal
​https://bugs.webkit.org/show_bug.cgi?id=71844

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-08
Reviewed by Alexey Proskuryakov.

  • WebView/WebFrame.mm:

(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
4:12 PM Changeset in webkit [99627] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

Basic DFG definitions should be moved out of DFGNode.h
​https://bugs.webkit.org/show_bug.cgi?id=71861

Rubber-stamped by Gavin Barraclough.

(JSC::DFG::NodeIndexTraits::defaultValue):

  • dfg/DFGNode.h:
  • dfg/DFGOSRExit.h:
  • dfg/DFGRegisterBank.h:
3:57 PM Changeset in webkit [99626] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Mac] Disable C++ exceptions from DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=71834

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2011-11-08
Reviewed by Darin Adler.

DumpRenderTree Mac does not handle C++ exceptions. When such exception
happens, it tends to cause the AutoReleasePool stack to be corrupted,
which leads to crashes long after the exception was raised.

This patch disabled C++ exceptions in order to catch the problems where
they happen when a C++ exception is raised.

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3:52 PM Changeset in webkit [99625] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix after r99613.

  • win/WebKit2CFLite.def: Add missing export.
3:49 PM Changeset in webkit [99624] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Delete WebViewimpl::scalePage
​https://bugs.webkit.org/show_bug.cgi?id=71711

Reviewed by Darin Fisher.

Once this patch lands: ​http://codereview.chromium.org/8477033

WebViewImpl::scalePage will no longer be used in Chromium and
can safely be deleted.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
3:48 PM Changeset in webkit [99623] by ojan@chromium.org
  • 2 edits
    2 adds
    3 deletes in trunk/LayoutTests

Rebaseline test failing due to subtle antialiasing differences.
Garden-o-matic claims it broke at r99613.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
3:45 PM Changeset in webkit [99622] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
​https://bugs.webkit.org/show_bug.cgi?id=71761

Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.

Patch by Michael Saboff <​msaboff@apple.com> on 2011-11-08
Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError):

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::sourceCode):

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • parser/Parser.h:

(JSC::::parse):
(JSC::parse):

  • parser/SourceCode.h:

(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):

3:44 PM Changeset in webkit [99621] by ojan@chromium.org
  • 2 edits
    50 adds in trunk/LayoutTests

Rebaselines and expectations after r99609 and r99616 and r99613.

  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:42 PM Changeset in webkit [99620] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

Moved myself to the reviewer list (yay!).

  • Scripts/webkitpy/common/config/committers.py:
3:17 PM Changeset in webkit [99619] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix after r98624 and r99613.

  • win/WebKit2CFLite.def: Add missing exports.
2:49 PM Changeset in webkit [99618] by msaboff@apple.com
  • 13 edits in trunk/Source

Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
​https://bugs.webkit.org/show_bug.cgi?id=71761

Source/JavaScriptCore:

Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.

Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError):

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::sourceCode):

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • parser/Parser.h:

(JSC::::parse):
(JSC::parse):

  • parser/SourceCode.h:

(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::data):

Source/WebCore:

Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.

No tests added - refactored base class SourceCode and its subclasses.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::data):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::data):

Source/WebKit/mac:

Changed WKPCEvaluate() to use emptyString() when the source is
zero length.

Reviewed by Gavin Barraclough.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCEvaluate):

2:44 PM Changeset in webkit [99617] by Beth Dakin
  • 4 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=71856
WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
old NSWindowDidChangeResolutionNotification
-and corresponding-
<rdar://problem/10317253>

Reviewed by Tim Hatcher.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):

We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WebView _windowDidChangeBackingProperties:]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):

We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WKView _windowDidChangeBackingProperties:]):

2:22 PM Changeset in webkit [99616] by xji@chromium.org
  • 7 edits
    3 adds in trunk

REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
​https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

Change the condition to perform immediate scolling inside ScrollView::updateScrollbars()
to be correct for RTL page as well, which is checking either the scroll position change or
the m_scrollOrigin changes (such as in window resize in which scroll position might remain the same).

And remove condition checking inside ScrollableArea::scrollToOffsetWithoutAnimation() since
the pass-in offset is adjusted within the current scroll range, it could be the same as
m_currentPos when m_currentPos is (0, 0) and current scroll range is smaller than old
scroll range, but scolling is still needed when page resize and scroll range changes.

Test: fast/dom/rtl-scroll-to-leftmost-and-resize.html

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Remove condition checking.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Change condition to perform immediate scrolling to be
correct for RTL pages as well.

  • platform/ScrollableArea.cpp: Update m_scrollOriginChanged.

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):

  • platform/ScrollableArea.h: Add m_scrollOriginChanged.

(WebCore::ScrollableArea::scrollOriginChanged):
(WebCore::ScrollableArea::resetScrollOriginChanged):

LayoutTests:

  • fast/dom/rtl-scroll-to-leftmost-and-resize.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
2:01 PM Changeset in webkit [99615] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Add a basic layer hierarchy to the Core Animation drawing area
​https://bugs.webkit.org/show_bug.cgi?id=71838

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):
Return early if we're using a tiled drawing area.

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
If we're using a tiled drawing area, make the WKView layer backed and set its layer
to a simple CALayer with a white background and set the view's content redraw policy
to never to avoid ever calling drawRect.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):

  • UIProcess/DrawingAreaProxy.messages.in:

Add a new didUpdateGeometry message.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
Initialize m_isWaitingForDidUpdateGeometry.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
Send an UpdateGeometry message to the web process and wait for a reply.

(WebKit::TiledCoreAnimationDrawingAreaProxy::enterAcceleratedCompositingMode):
Tell the web page proxy to enter accelerated compositing mode.

(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode):
Assert that this function is never called.

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Send another UpdateGeometry message if needed.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
Add helper function to actually send the UpdateGeometry message.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateGeometry):

  • WebProcess/WebPage/DrawingArea.messages.in:

Add UpdateGeometry message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Create a red root layer and a remote layer client that hosts it.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the root layer and tell the UI process that we've updated the geometry.

1:57 PM Changeset in webkit [99614] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT calculation of OSR entry points is not THUMB2 safe
​https://bugs.webkit.org/show_bug.cgi?id=71852

Reviewed by Oliver Hunt.

Executable addresses are tagged with a low bit set to distinguish
between THUMB2 and traditional ARM.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • jit/JITCode.h:

(JSC::JITCode::executableAddressAtOffset):
(JSC::JITCode::start):
(JSC::JITCode::size):

1:14 PM Changeset in webkit [99613] by mitz@apple.com
  • 16 edits
    24 adds in trunk

<rdar://problem/10262225> Allow RenderView to have columns
​https://bugs.webkit.org/show_bug.cgi?id=71840

Source/WebCore:

Reviewed by Simon Fraser.

Tests: fast/multicol/pagination-h-horizontal-bt.html

fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-h-vertical-lr.html
fast/multicol/pagination-h-vertical-rl.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/pagination-v-vertical-lr.html
fast/multicol/pagination-v-vertical-rl.html

  • WebCore.exp.in: Export Page::setPagination() for WebCoreTestSupport.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument): Set the column axis and the column gap in the
document style if the view is paginated.

  • page/Page.cpp:

(WebCore::Page::setPagination): Added this setter.

  • page/Page.h:

(WebCore::Page::Pagination::Pagination):
(WebCore::Page::pagination): Added this getter.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::requiresColumns): Added and moved some logic to here from...
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): ...here.

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers): Changed to use the new RenderView::backgroundRect()
instead of unscaledDocumentRect().

  • rendering/RenderView.cpp:

(WebCore::RenderView::requiresColumns): Added this override that always returns true if the view
is paginated.
(WebCore::RenderView::backgroundRect): Added. In the paginated case, returns a rectangle stretching
across all columns.

  • rendering/RenderView.h:
  • testing/Internals.cpp:

(WebCore::Internals::reset): Also reset pagination.
(WebCore::Internals::setPagination): Added this setter for testing.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def: Export Page::setPagination() for WebCoreTestSupport.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/multicol/pagination-h-horizontal-bt.html: Added.
  • fast/multicol/pagination-h-horizontal-tb.html: Added.
  • fast/multicol/pagination-h-vertical-lr.html: Added.
  • fast/multicol/pagination-h-vertical-rl.html: Added.
  • fast/multicol/pagination-v-horizontal-bt.html: Added.
  • fast/multicol/pagination-v-horizontal-tb.html: Added.
  • fast/multicol/pagination-v-vertical-lr.html: Added.
  • fast/multicol/pagination-v-vertical-rl.html: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
1:02 PM Changeset in webkit [99612] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Document.importNode's 'deep' argument should default to true.
​https://bugs.webkit.org/show_bug.cgi?id=71190

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-08
Reviewed by Adam Barth.

Source/WebCore:

As new specification says deep argument of importNode should be default to true.

Test: fast/dom/document-importNode-arguments.html

  • dom/Document.h: Added supportive method.

(WebCore::Document::importNode):

  • dom/Document.idl: Modified deep argument as optional.

LayoutTests:

Added test to check document.importNode with No deep argument,
deep argument true and false.

  • fast/dom/document-importNode-arguments-expected.txt: Added.
  • fast/dom/document-importNode-arguments.html: Added.
12:59 PM Changeset in webkit [99611] by adamk@chromium.org
  • 9 edits in trunk

WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
​https://bugs.webkit.org/show_bug.cgi?id=71596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds two cases where WebKitMutationObserver.observe throws an exception:

  • When passed a null Node*.
  • When passed options that don't make sense, e.g., 'attributeOldValue' but not 'attributes'.
  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::validateOptions):
(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:
  • dom/WebKitMutationObserver.idl:

LayoutTests:

  • fast/mutation/observe-exceptions-expected.txt:
  • fast/mutation/observe-exceptions.html:
12:53 PM Changeset in webkit [99610] by hyatt@apple.com
  • 2 edits in trunk/Tools

Revert check-in. My mistake.

12:51 PM Changeset in webkit [99609] by commit-queue@webkit.org
  • 25 edits
    4 adds in trunk

IndexedDB: implement compound (array) key support
​https://bugs.webkit.org/show_bug.cgi?id=62284

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.

Source/WebCore:

Add support for Array values as IDBKeys. (Multirow indexes are still
not yet supported.)

Tests: storage/indexeddb/cursor-key-order.html

storage/indexeddb/key-type-array.html

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • storage/IDBKey.cpp:

(WebCore::IDBKey::compare):

  • storage/IDBKey.h:

(WebCore::IDBKey::createArray):
(WebCore::IDBKey::valid):
(WebCore::IDBKey::array):
(WebCore::IDBKey::compareTypes):

  • storage/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

  • storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Extend WebKit API to support Array values as IDBKeys.

  • public/WebIDBKey.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::createArray):
(WebKit::convertFromWebIDBKeyArray):
(WebKit::convertToWebIDBKeyArray):
(WebKit::WebIDBKey::assignArray):
(WebKit::WebIDBKey::array):

  • tests/IDBBindingUtilitiesTest.cpp:

(WebCore::TEST):

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::createArrayIDBKey):
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding::compareStrings):

LayoutTests:

  • storage/indexeddb/cursor-key-order-expected.txt: Added.
  • storage/indexeddb/cursor-key-order.html: Added.
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/key-type-array-expected.txt: Added.
  • storage/indexeddb/key-type-array.html: Added.
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
12:37 PM Changeset in webkit [99608] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC::Parser::Parser leaks Lexer member
​https://bugs.webkit.org/show_bug.cgi?id=71847

Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.

Reviewed by Oliver Hunt.

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):

  • parser/Parser.h:
12:33 PM Changeset in webkit [99607] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove get() defined in CredentialStorageQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=71829

Reviewed by Andreas Kling.

CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageQt.cpp.

  • Target.pri: Add files CredentialStorage.{cpp, h}.
  • platform/network/qt/CredentialStorageQt.cpp:
12:31 PM Changeset in webkit [99606] by jonlee@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Expose acceptMIMETypes for file inputs
​https://bugs.webkit.org/show_bug.cgi?id=71836
<rdar://problem/10407367>

Reviewed by Anders Carlsson.

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):

  • Shared/WebOpenPanelParameters.h:
  • UIProcess/API/C/WKOpenPanelParameters.cpp:

(WKOpenPanelParametersCopyAcceptedMIMETypes):

  • UIProcess/API/C/WKOpenPanelParameters.h:
12:20 PM Changeset in webkit [99605] by hyatt@apple.com
  • 1 edit in trunk/Tools/MiniBrowser/mac/BrowserWindowController.m

Fix more build bustage.

12:14 PM Changeset in webkit [99604] by hyatt@apple.com
  • 1 edit in trunk/Tools/WebKitTestRunner/TestController.cpp

Fix build bustage.

12:10 PM Changeset in webkit [99603] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] The default database & local storage directory names should note they exist for Gtk port's needs
​https://bugs.webkit.org/show_bug.cgi?id=71837

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.

Ensure that directories for databases and local storage are in a 'webkitgtk'
directory in current user's data directory, noting they originate from the Gtk port.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

12:08 PM Changeset in webkit [99602] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.2

New tag.

12:02 PM Changeset in webkit [99601] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

12:00 PM Changeset in webkit [99600] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r99508.

11:41 AM Changeset in webkit [99599] by commit-queue@webkit.org
  • 8 edits in trunk

IndexedDB: reference cycle between IDBDatabase and IDBTransaction
​https://bugs.webkit.org/show_bug.cgi?id=71749

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.

Source/WebCore:

Break a cyclic reference leak following a setVersion call.

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersionChangeTransaction):
(WebCore::IDBDatabase::clearVersionChangeTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):

  • storage/IDBDatabase.h:
  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

LayoutTests:

Add test case to verify that creating/deleting a store outside
a transaction throws same error if store exists. Also fix
the test to actually try removing stores.

  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
11:29 AM Changeset in webkit [99598] by zeno.albisser@nokia.com
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
11:19 AM Changeset in webkit [99597] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations mixup.

  • platform/chromium/test_expectations.txt:
11:13 AM Changeset in webkit [99596] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove get() defined in CredentialStorageSoup.cpp
​https://bugs.webkit.org/show_bug.cgi?id=71825

Reviewed by Martin Robinson.

CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageSoup.cpp.

  • GNUmakefile.list.am: Add source file CredentialStorage.cpp.
  • platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().

CredentialStorage::get() is defined in CredentialStorage.cpp.

11:04 AM Changeset in webkit [99595] by rolandsteiner@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename CSS document() -> findDocument(), to indicate tree climbing
​https://bugs.webkit.org/show_bug.cgi?id=71764

Renamed document() to findDocument(), styleSheetOwnerNode() to findStyleSheetOwnerNode().

Reviewed by Darin Adler.

No new tests. (simple refactoring)

  • css/CSSGrammar.y:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::requestStyleSheet):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::findDocument):
(WebCore::CSSParser::parseAttr):

  • css/CSSParser.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::findStyleSheetOwnerNode):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::styleSheetChanged):

  • css/CSSStyleSheet.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::bindStyleSheet):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ownerDocument):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

10:39 AM Changeset in webkit [99594] by rniwa@webkit.org
  • 4 edits
    6 adds in trunk

Indent command can insert block quote in non editable content
​https://bugs.webkit.org/show_bug.cgi?id=71754

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by IndentOutdentCommand's incorrectly using deprecatedNode to determine the outer block,
not updating the start after inserting the targetBlockquote, and cloneParagraphUnderNewElement's cloning
outerNode even if it was body. Fixed those bugs.

Test: editing/execCommand/indent-images.html

editing/execCommand/indent-images-2.html
editing/execCommand/indent-images-3.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Add tests to indent two images in a document.

  • editing/execCommand/indent-images-expected.txt: Added.
  • editing/execCommand/indent-images.html: Added.
  • editing/execCommand/indent-images-2-expected.txt: Added.
  • editing/execCommand/indent-images-2.html: Added.
  • editing/execCommand/indent-images-3-expected.txt: Added.
  • editing/execCommand/indent-images-3.html: Added.
10:29 AM Changeset in webkit [99593] by adamk@chromium.org
  • 8 edits
    2 adds in trunk

Only walk up the tree in search of MutationObservers if one has been added
​https://bugs.webkit.org/show_bug.cgi?id=71499

Reviewed by Ojan Vafai.

Source/WebCore:

Analogous to m_listenerTypes, added an m_subtreeMutationObserverTypes field
to Document that keeps track of which observer types have been added.
This allows us to avoid doing any extra work if MutationObservers are
not attached to a document.

This could be improved upon to keep a count of each type, as removing
an observer currently has no effect on m_subtreeMutationObserverTypes.
But that would require a more complex implementation: one counter per
mutation type. And it would be easier to get wrong: if the counter
gets out of sync with the actual state of the DOM, we could start
dropping mutation notifications.

Test: fast/mutation/cross-document.html

  • dom/Document.h:

(WebCore::Document::hasSubtreeMutationObserverOfType):
(WebCore::Document::hasSubtreeMutationObserver):
(WebCore::Document::addSubtreeMutationObserverTypes):

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):

  • dom/Node.cpp:

(WebCore::Node::didMoveToNewOwnerDocument): Update mutationObserverTypes when a Node is moved to a new document.
(WebCore::Node::getRegisteredMutationObserversOfType): Exit early if it's known that no observers of |type| are registered.
(WebCore::Node::notifyMutationObserversNodeWillDetach): Exit early if it's known no subtree observers of any type are registered.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe): Update mutationObserverTypes when an observation occurs.

  • dom/WebKitMutationObserver.h: Add WebKitMutationObserver::AllMutationTypes to enum

LayoutTests:

Created a basic test showing that MutationObservers
are preserved when a Node switches documents.

  • fast/mutation/cross-document-expected.txt: Added.
  • fast/mutation/cross-document.html: Added.
10:27 AM WebKitGTK/1.6.x edited by Martin Robinson
(diff)
10:27 AM Changeset in webkit [99592] by andreas.kling@nokia.com
  • 33 edits in trunk/Source/WebCore

Devirtualize CSSValue.
<​http://webkit.org/b/71666>

Reviewed by Antti Koivisto.

Make the CSSValue destructor non-virtual (along with all the subclasses.)
This removes the vtables, and the pointers thereto in each value instance,
shrinking each object by one CPU word (4 or 8 bytes.)

We use the same trick as CSSRule to implement destruction; providing our
own deref() instead of RefCounted's, and performing a statically typed
delete in a destroy() method called when the ref count reaches 0.

Also made all the empty subclass destructors inline.

  • css/CSSAspectRatioValue.cpp:
  • css/CSSAspectRatioValue.h:

(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSBorderImageSliceValue.h:

(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):

  • css/CSSBorderImageValue.cpp:
  • css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::~CSSBorderImageValue):

  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):

  • css/CSSCursorImageValue.h:
  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::~CSSFlexValue):

  • css/CSSFontFaceSrcValue.cpp:
  • css/CSSFontFaceSrcValue.h:

(WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:
  • css/CSSFunctionValue.h:

(WebCore::CSSFunctionValue::~CSSFunctionValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.h:
  • css/CSSMutableValue.h:

(WebCore::CSSMutableValue::~CSSMutableValue):

  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSUnicodeRangeValue.h:

(WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::deref):
(WebCore::CSSValue::~CSSValue):

  • css/CSSValueList.cpp:
  • css/CSSValueList.h:

(WebCore::CSSValueList::~CSSValueList):

  • css/WebKitCSSFilterValue.cpp:
  • css/WebKitCSSFilterValue.h:

(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::~WebKitCSSTransformValue):

10:26 AM WebKitGTK/1.6.x edited by Martin Robinson
(diff)
10:25 AM WebKitGTK/1.6.x edited by Martin Robinson
(diff)
10:25 AM Changeset in webkit [99591] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Speculative fix for crashes seen in DocumentWriter::deprecatedFrameEncoding
​https://bugs.webkit.org/show_bug.cgi?id=71828

Reviewed by Nate Chapin.

No new tests; not sure how to reproduce this, but crash traces indicate it
is an otherwise-harmless null dereference.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::deprecatedFrameEncoding):
Handle null document the same as a document without a URL.

10:24 AM Changeset in webkit [99590] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Move regressions from V8 roll to from the downstream expectations file.
Add regressions from ​http://trac.webkit.org/changeset/99561.

  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [99589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r95720.
​http://trac.webkit.org/changeset/95720
​https://bugs.webkit.org/show_bug.cgi?id=71831

This has made the menulists on WebKit patch reviews much less
usable (Requested by mrobinson on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-08

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::menuPositionFunction):

10:20 AM Changeset in webkit [99588] by thakis@chromium.org
  • 8 edits in trunk/Source/WebCore

[chromium] Remove 6 exit time destructors and 6 static initializers
​https://bugs.webkit.org/show_bug.cgi?id=71760

Reviewed by Nate Chapin.

Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.

No behavior change, so no new tests.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::sEventListeners):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/ScriptGCEvent.h:
  • bindings/v8/V8NPObject.cpp:

(WebCore::staticTemplateMap):
(WebCore::weakTemplateCallback):
(WebCore::npObjectGetProperty):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):

  • bindings/v8/V8Proxy.cpp:

(WebCore::staticExtensionsList):
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
(WebCore::V8Proxy::extensions):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/npruntime.cpp:
  • plugins/chromium/PluginDataChromium.cpp:

(WebCore::pluginCache):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh):
(WebCore::getPluginMimeTypeFromExtension):

10:17 AM Changeset in webkit [99587] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu.

  • platform/chromium/test_expectations.txt:
10:13 AM Changeset in webkit [99586] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.10

New tag.

10:13 AM Changeset in webkit [99585] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

10:10 AM Changeset in webkit [99584] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merged r99508.

10:10 AM Changeset in webkit [99583] by ojan@chromium.org
  • 19 edits
    2 adds
    15 deletes in trunk/LayoutTests

New tests results after r99539.

zoom-replaced-intrinsic-ratio-001-expected.png is just minor antialiasing differences.
The rest are all changing to a size that matched the pngs in platform/mac.

  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
10:04 AM Changeset in webkit [99582] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Autofocus inputs don't always honor selector input:focus.
​https://bugs.webkit.org/show_bug.cgi?id=24093

Already fixed and works on TOT. Adding layout test case for the same.

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-08
Reviewed by Kent Tamura.

  • fast/forms/autofocus-input-css-style-change-expected.txt: Added.
  • fast/forms/autofocus-input-css-style-change.html: Added.
9:51 AM Changeset in webkit [99581] by hans@chromium.org
  • 5 edits in trunk

IndexedDB: Start using the onSuccessWithContinuation() callback
​https://bugs.webkit.org/show_bug.cgi?id=71565

Reviewed by Tony Chang.

Source/WebCore:

This is a follow-up to r99169 where we start using this new
callback for cursors.

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunctionInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::setCursor):

LayoutTests:

The cursor-inconsistency.html test now passes completely.

  • storage/indexeddb/cursor-inconsistency-expected.txt:
9:49 AM Changeset in webkit [99580] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Skip some ECMAScript tests that fail on Linux in some time zones.
​https://bugs.webkit.org/show_bug.cgi?id=71371

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

  • Scripts/run-javascriptcore-tests: Skip some more tests.
9:42 AM Changeset in webkit [99579] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

Document::loader should use documentLoader(), not activeDocumentLoader()
​https://bugs.webkit.org/show_bug.cgi?id=65895

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/loader/stateobjects/replacestate-in-onunload.html

  • dom/Document.cpp:

(WebCore::Document::loader):

LayoutTests:

  • fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-in-onunload.html: Added.
9:36 AM Changeset in webkit [99578] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[WK][GTK] Application cache directory is incorrectly set
​https://bugs.webkit.org/show_bug.cgi?id=71769

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.

Set the application cache directory to be placed in current user's
cache directory and update documentation for
webkit_application_cache_get_database_directory_path after these
changes and changes in r80715;

  • webkit/webkitapplicationcache.cpp:
  • webkit/webkitglobals.cpp:

(webkitInit): Switch one string formation to use GOwnPtr<gchar>.

9:33 AM Changeset in webkit [99577] by andreas.kling@nokia.com
  • 6 edits in trunk/Source/WebCore

CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
<​http://webkit.org/b/71824>

Reviewed by Darin Adler.

Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::isFixedSize):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::isFixedSize):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isFixedSize):
(WebCore::CSSGradientValue::fixedSize):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):

  • css/CSSImageGeneratorValue.h:
9:09 AM Changeset in webkit [99576] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=71774

Patch by Philippe Normand <​pnormand@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:

Trigger the test when the iframe loaded to avoid potential
flakyness.

9:06 AM Changeset in webkit [99575] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
​https://bugs.webkit.org/show_bug.cgi?id=71822

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

8:46 AM Changeset in webkit [99574] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
<​http://webkit.org/b/71814>

Reviewed by Antti Koivisto.

Defer to CSSCursorImageValue (the only CSSImageValue subclass)
when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).

  • css/CSSCursorImageValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/CSSImageValue.h:
8:38 AM Changeset in webkit [99573] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: add "Evaluate in console" as a shortcut and context menu items to scripts panel
​https://bugs.webkit.org/show_bug.cgi?id=71817

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evaluate):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):

  • inspector/front-end/externs.js:

(WebInspector.evaluateInConsole):

  • inspector/front-end/inspector.js:

(WebInspector.evaluateInConsole):

8:26 AM Changeset in webkit [99572] by Nikolas Zimmermann
  • 3 edits
    6 adds in trunk/LayoutTests

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline qt results after the recent SVGImage changes.

  • platform/qt/Skipped:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
8:22 AM Changeset in webkit [99571] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Use qmake's builtin rules for copying framework headers on Mac OS

Now that we generate the forwarding headers eiher as part of QtWebKit.pro
(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
that the files are there and use $$files() to list the files to be copied.

Reviewed by Csaba Osztrogonác.

8:21 AM Changeset in webkit [99570] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Workaround some problems in QML API tests
​https://bugs.webkit.org/show_bug.cgi?id=71818

Reviewed by Tor Arne Vestbø.

This commit workaround the issue of QML's QtTest crashing when we run tests after
"windowShown". We delay to the next run of the mainloop. This workaround is not
pretty but shouldn't affect the semantics of the tests. And we benefit more from
having working tests right now.

This patch also improves Download to: wait for the load before emitting click, and
properly identifying the "succeeded" signal of the downloadItem object.

  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
7:40 AM Changeset in webkit [99569] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed trivial fix after build system refactoring.

  • Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
7:34 AM Changeset in webkit [99568] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

Clean up QtViewportInteractionEngine

Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):

Rename the method to make it more obvious what it does. Avoid implicit
conversion to/from QVariant.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

Only call this method on item size changes, and not for every interaction
with the viewport item. Before this change it was even being called during
animations.

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):

Rename to make it clean that this is called from the animator.

7:29 AM Changeset in webkit [99567] by andreas.kling@nokia.com
  • 53 edits in trunk/Source/WebCore

CSSValue: Devirtualize cssText().
<​http://webkit.org/b/71813>

Reviewed by Antti Koivisto.

Rename all subclass implementations to customCssText() and add
a CSSValue::cssText() that defers to the appropriate subclass
based on the type info.

The rename is both for clarity, and to ensure that calling
cssText() will always end up in the correct method.

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCssText):

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::customCssText):

  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::customCssText):

  • css/CSSBorderImageValue.h:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::customCssText):

  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::customCssText):

  • css/CSSCrossfadeValue.h:
  • css/CSSFlexValue.cpp:

(WebCore::CSSFlexValue::customCssText):

  • css/CSSFlexValue.h:
  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::customCssText):

  • css/CSSFontFaceSrcValue.h:
  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::customCssText):

  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::customCssText):

  • css/CSSGradientValue.h:
  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::customCssText):

  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::customCssText):

  • css/CSSInitialValue.h:
  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::customCssText):

  • css/CSSLineBoxContainValue.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):

  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::customCssText):

  • css/CSSReflectValue.h:
  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
(WebCore::CSSStepsTimingFunctionValue::customCssText):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::customCssText):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):

  • css/CSSValue.h:
  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCssText):

  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:

(WebCore::FontFamilyValue::customCssText):

  • css/FontFamilyValue.h:
  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::customCssText):

  • css/FontFeatureValue.h:
  • css/FontValue.cpp:

(WebCore::FontValue::customCssText):

  • css/FontValue.h:
  • css/ShadowValue.cpp:

(WebCore::ShadowValue::customCssText):

  • css/ShadowValue.h:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::customCssText):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::customCssText):

  • css/WebKitCSSTransformValue.h:
  • svg/SVGColor.cpp:

(WebCore::SVGColor::customCssText):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::customCssText):

  • svg/SVGPaint.h:
7:16 AM Changeset in webkit [99566] by Nikolas Zimmermann
  • 8 edits in trunk/LayoutTests

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
​https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Rob Buis.

Address some problems seen on Qt/Chromium:

  • Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
  • Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f. Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
  • svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
  • svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
  • svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
6:42 AM Changeset in webkit [99565] by gavinp@chromium.org
  • 4 edits
    2 adds in trunk

Fix width of m_type in CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=71727

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/dom/HTMLLinkElement/cachedresource-types.html

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

LayoutTests:

  • fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
  • fast/dom/HTMLLinkElement/cachedresource-types.html: Added.
6:40 AM Changeset in webkit [99564] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre

If a pro file needs to access the OBJECTS_DIR it should use the
form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
after defaults_post has been processed.

Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
the command line will override whatever we set in defaults_pre.

Reviewed by Simon Hausmann.

6:36 AM Changeset in webkit [99563] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add JavaScript keywords to the autocomplete.
​https://bugs.webkit.org/show_bug.cgi?id=71782

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

6:19 AM Changeset in webkit [99562] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

[Chromium] SVG test failures after r99539
​https://bugs.webkit.org/show_bug.cgi?id=71793

Reviewed by Zoltan Herczeg.

It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
That cries for problems if the machine is slow or loaded.

I left the 400ms sample snapshot for now, we can still relax it later.

  • fast/backgrounds/resources/animated-rect-relative-size.svg:
  • svg/as-background-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-fixed-size.svg:
  • svg/as-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-same-image.svg:
6:14 AM Changeset in webkit [99561] by Nikolas Zimmermann
  • 24 edits
    2 adds in trunk/Source/WebCore

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports
​https://bugs.webkit.org/show_bug.cgi?id=71780

Reviewed by Zoltan Herczeg.

Introduce SVGLengthContext to cleanup SVGLength, by moving all conversion of relative units that depend on style or viewport
out of SVGLength, into SVGLengthContext. Pass SVGLengthContext& to SVGLength::value/setValue/... functions instead of a pure
"const SVGElement* context", which was previously used to determine the viewport when resolving percentage units.
SVGLengthContext carries an additional FloatRect of the custom viewport, to which percentages are resolved, if specified.

This allows us to kill several duplicates of the same code, which handles objectBoundingBox mode for gradients/patterns/masks/etc..
A follow-up patch will convert filters to use the new SVGLengthContext::resolveRectangle code as well.

This is a preparation for bug 10430, to fix feImage + objectBoundingBox support when rendering referenced elements, instead of files.

Doesn't affect any tests yet.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::gradientUnits):
  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::buildTileImageTransform): (WebCore::RenderSVGResourcePattern::createTileImage):
  • rendering/svg/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::gradientUnits):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeCommonGradientProperties): (WebCore::writeSVGResourceContainer):
  • svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::gradientUnits): (WebCore::GradientAttributes::setGradientUnits): (WebCore::GradientAttributes::hasGradientUnits):
  • svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::patternUnits): (WebCore::PatternAttributes::patternContentUnits): (WebCore::PatternAttributes::setPatternUnits): (WebCore::PatternAttributes::setPatternContentUnits): (WebCore::PatternAttributes::hasPatternUnits): (WebCore::PatternAttributes::hasPatternContentUnits):
  • svg/SVGAllInOne.cpp:
  • svg/SVGElement.h: (WebCore::SVGElement::operator SVGLengthContext):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
  • svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::unitMode): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::convertToSpecifiedUnits):
  • svg/SVGLength.h: (WebCore::SVGLength::blend):
  • svg/SVGLengthContext.cpp: Added. (WebCore::SVGLengthContext::SVGLengthContext): (WebCore::SVGLengthContext::resolveRectangle): (WebCore::SVGLengthContext::resolvePoint): (WebCore::SVGLengthContext::resolveLength): (WebCore::SVGLengthContext::convertValueToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage): (WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS): (WebCore::SVGLengthContext::convertValueFromEMSToUserUnits): (WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS): (WebCore::SVGLengthContext::convertValueFromEXSToUserUnits): (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h: Added. (WebCore::SVGLengthContext::resolveRectangle):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
6:01 AM Changeset in webkit [99560] by andreas.kling@nokia.com
  • 8 edits in trunk/Source/WebCore

CSSValue: Devirtualize addSubresourceStyleURLs().
<​http://webkit.org/b/71805>

Reviewed by Antti Koivisto.

Make addSubresourceStyleURLs() non-virtual and call the appropriate
subclass implementation based on the subclass type info.

  • css/CSSBorderImageValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValueList.h:
5:46 AM Changeset in webkit [99559] by yuqiang.xian@intel.com
  • 5 edits in trunk

Enable DFG JIT by default on X86 Linux and Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=71686

Reviewed by Filip Pizlo.

.:

Remove the DFG cmake option for Efl port as we'll determine whether to
switch on DFG or not based on build target platforms.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

We can get 9% on SunSpider, 89% on Kraken and 37% on V8, on Linux X86.

  • wtf/Platform.h:
5:43 AM UsingIcecreamWithQtWebKit created by alexander.faeroy@nokia.com
5:38 AM Changeset in webkit [99558] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: do not show object popover when selection is active
​https://bugs.webkit.org/show_bug.cgi?id=71804

Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._shouldShowPopover):

5:34 AM Changeset in webkit [99557] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
​https://bugs.webkit.org/show_bug.cgi?id=71797

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):

5:23 AM Changeset in webkit [99556] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSGradientValue: Devirtualize createGradient().
<​http://webkit.org/b/71800>

Reviewed by Antti Koivisto.

Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

  • css/CSSGradientValue.h:
5:22 AM Changeset in webkit [99555] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSCanvasValue: Remove inheritance from CanvasObserver.
<​http://webkit.org/b/71796>

Reviewed by Antti Koivisto.

To completely devirtualize all the CSSValues, we need to remove
CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
a vptr into the class.

Use the same approach as CSSImportRule and make a simple proxying
CanvasObserver subclass and put that as a member variable of the value.

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::element):

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::CSSCanvasValue):
(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):

5:06 AM Changeset in webkit [99554] by yurys@chromium.org
  • 8 edits in trunk/Source

Web Inspector: display notification in the front-end when inspected worker terminates
​https://bugs.webkit.org/show_bug.cgi?id=71770

Source/WebCore:

When inspected worker terminates we will show a notification similar to the help
screen. The notification disappears when the worker restarts or the user closes it
manually.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.showWorkerTerminatedScreen):
(WebInspector.WorkerTerminatedScreen):

  • inspector/front-end/inspector.js:

(WebInspector.disconnectFromBackend):
(WebInspector.frontendReused):

Source/WebKit/chromium:

Exposed an API for the browser to notify inspector front-end when inspeced instance
terminates. It is used now for tracking shared workers termination.

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::createFrontendDisconnectedEvent):

5:03 AM Changeset in webkit [99553] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, add three more CG-only failures.

  • platform/chromium/test_expectations.txt:
4:48 AM Changeset in webkit [99552] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fast/backgrounds/svg-as-mask.html as IMAGE on MAC.

  • platform/chromium/test_expectations.txt:
4:40 AM Changeset in webkit [99551] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Improve the animation time constant
​https://bugs.webkit.org/show_bug.cgi?id=71790

Reviewed by Simon Hausmann.

Use 250 milliseconds instead of 400, which feels a lot more natural
and makes the mini browser feel more responsive.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:
4:37 AM Changeset in webkit [99550] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed fix of expectation conflict in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
4:29 AM Changeset in webkit [99549] by Nikolas Zimmermann
  • 9 edits
    2 deletes in trunk/Source/WebCore

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Fold ImageBySizeCache again into CSSImageGeneratorValue
​https://bugs.webkit.org/show_bug.cgi?id=71785

Reviewed by Zoltan Herczeg.

Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be.
CachedImage has switched to SVGImageCache and no longer needs it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage): (WebCore::CSSImageGeneratorValue::putImage):
  • css/CSSImageGeneratorValue.h: (WebCore::SizeAndCount::SizeAndCount): (WebCore::CSSImageGeneratorValue::clients):
  • rendering/ImageBySizeCache.cpp: Removed.
  • rendering/ImageBySizeCache.h: Removed.
4:22 AM Changeset in webkit [99548] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Avoid automatic Console suggestions with empty expression
​https://bugs.webkit.org/show_bug.cgi?id=71783

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleView.js:
4:14 AM Changeset in webkit [99547] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

4:00 AM Changeset in webkit [99546] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: add sanity test for automatic reattach to a page which is reloaded after crash
​https://bugs.webkit.org/show_bug.cgi?id=71786

Added a test function that checks if console evaluation works after crashed tab reloading.

Reviewed by Pavel Feldman.

  • src/js/Tests.js:

(.TestSuite.prototype.testReattachAfterCrash):

3:58 AM Changeset in webkit [99545] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which
started to fail after r99539.

  • platform/chromium/test_expectations.txt:
3:54 AM Changeset in webkit [99544] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix build, by removing an unused variable.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): (WebCore::CanvasRenderingContext2D::createPattern):
3:46 AM Changeset in webkit [99543] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
​https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Zoltan Herczeg.

When determining whether the canvas would be tainted, we need access to the SVGImage, not its cached BitmapImage.
Otherwhise wrong assumptions are mode, leading to regressions.

Fixes http/tests/security/canvas-remote-read-svg-image.html and related tests on the bots.

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): Forgot to switch them back to use cachedImage->image().
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): Ditto.
3:30 AM Changeset in webkit [99542] by vestbo@webkit.org
  • 3 edits in trunk

[Qt] Ensure forwarding headers are generated before generating install rules

The install rule for headers depends on qmake being able to walk the list of
headers in the $build_root/include/QtWebKit directory, but this directory is
empty until we've generated the forwarding headers. So we need to make sure
the forwarding headers are generated _before_ we run qmake on the api project
file. This applies to Qt 4.8 only, as Qt 5 will run synqt as part of the
root project file (due to the sync.profile file).

​https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

3:22 AM Changeset in webkit [99541] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Console should be scrolled to bottom when shown for the first time.
​https://bugs.webkit.org/show_bug.cgi?id=71781

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
1:34 AM Changeset in webkit [99540] by Simon Hausmann
  • 10 edits
    4 deletes in trunk/Source/WebKit2

[Qt] Merge QtDesktopWebPageProxy and QtTouchWebPageProxy into QtWebPageProxy. ​https://bugs.webkit.org/show_bug.cgi?id=71355

Patch by Alexis Menard <​alexis.menard@openbossa.org> on 2011-11-08
Reviewed by Simon Hausmann.

As we try to unify our public API offer we need to merge our double
WebPageProxy implementations first into a common class. That will help
to merge our TouchWebView and DesktopWebView views into one class later.
This commit just merge stuff around and doesn't contain any functional changes.

  • Target.pri:
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::init):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):

  • UIProcess/API/qt/qtouchwebview_p.h:
  • UIProcess/qt/QtDesktopWebPageProxy.cpp: Removed.
  • UIProcess/qt/QtDesktopWebPageProxy.h: Removed.
  • UIProcess/qt/QtTouchWebPageProxy.cpp: Removed.
  • UIProcess/qt/QtTouchWebPageProxy.h: Removed.
  • UIProcess/qt/QtWebPageProxy.cpp:

(dragOperationToDropAction):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleEvent):
(QtWebPageProxy::handleMouseMoveEvent):
(QtWebPageProxy::handleMousePressEvent):
(QtWebPageProxy::handleMouseReleaseEvent):
(QtWebPageProxy::handleMouseDoubleClickEvent):
(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::handleHoverLeaveEvent):
(QtWebPageProxy::handleHoverMoveEvent):
(QtWebPageProxy::handleDragEnterEvent):
(QtWebPageProxy::handleDragLeaveEvent):
(QtWebPageProxy::handleDragMoveEvent):
(QtWebPageProxy::handleDropEvent):
(QtWebPageProxy::timerEvent):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::didReceiveDownloadResponse):
(QtWebPageProxy::paintContent):
(QtWebPageProxy::createDrawingAreaProxy):
(QtWebPageProxy::renderToCurrentGLContext):
(QtWebPageProxy::doneWithTouchEvent):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtWebPageProxy::touchEvent):
(QtWebPageProxy::findZoomableAreaForPoint):

  • UIProcess/qt/QtWebPageProxy.h:
1:32 AM Changeset in webkit [99539] by Nikolas Zimmermann
  • 28 edits
    1 copy
    8 adds in trunk

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
​https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

Add some layout tests covering repainting of embedded SVG documents triggered by SMIL animations.

  • platform/chromium/test_expectations.txt: Fix test expectations, as described in bug 71226.
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html: Added.
  • svg/as-image/animated-svg-as-image-same-image.html: Added.
  • svg/as-image/resources/animated-rect-same-image.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Add comment, why scrollbars shouldn't appear anymore here.

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
​https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

Fix regressions/races introduced by r98852. SVGImage repainting didn't work under certain circumstances.
The problem was hard to reproduce on Mac ports, but easily visible on Chromium, when opening two files
that shared the same animated SVG image. The problem of sharing a single ImageObserver across multiple
instances of the same SVGImage, leads to nasty problems, that are timing dependant. changedInRect() calls
that should only by received in one document, are received in the other as well, due the shared nature
of CachedImage. To avoid these problems alltogether, a new approach is needed, that was initially suggested
by Antti.

Avoid creating multiple SVGImages and caching them for different sizes/zoom levels. Introduce SVGImageCache
which holds rendered versions of the SVGImage at certain sizes/zoom levels. It holds (ImageBuffer, Image) pairs
for each renderer, associated with a size and zoom level.

This is a major change to the cache as introduced some weeks ago. Instead of holding multiple SVGImages, each containing
a whole DOM/render tree, we now create bitmap images rendered at the requested sizes/zoom levels and cache them.

Revert ImageBySizeCache changes that were needed to make it usable wih SVGImage. Its now used only in CSSImageGeneratorValue and
thus the extra information that CSSImageGeneratorValue doesn't need can be removed again (desired/actual size differentations, and the zoom level).

Tests: svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html

svg/as-image/animated-svg-as-image-same-image.html

  • CMakeLists.txt: Add svg/graphics/SVGImageCache.* to build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from svg/graphics, as SVGImageCache is needed by CachedImage in SVG enabled builds.
  • WebCore.xcodeproj/project.pbxproj: Add svg/graphics/SVGImageCache.* to build.
  • css/CSSImageGeneratorValue.cpp: Remove zoom parameter from addClient/getImage, no need to pass 1 default values anymore. (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::getImage):
  • loader/cache/CachedImage.cpp: Stop using ImageBySizeCache, and switch to the new SVGImageCache. (WebCore::CachedImage::removeClientForRenderer): (WebCore::CachedImage::lookupOrCreateImageForRenderer): (WebCore::CachedImage::setContainerSizeForRenderer): (WebCore::CachedImage::imageSizeForRenderer): (WebCore::CachedImage::clear): (WebCore::CachedImage::createImage): (WebCore::CachedImage::destroyDecodedData): (WebCore::CachedImage::decodedSizeChanged): (WebCore::CachedImage::didDraw): (WebCore::CachedImage::shouldPauseAnimation): (WebCore::CachedImage::animationAdvanced): (WebCore::CachedImage::changedInRect):
  • loader/cache/CachedImage.h:
  • page/DragController.cpp: Stop using imageForRenderer(), as it may return cached BitmapImages, that don't carry a filename extension anymore, which is required here. (WebCore::getImage):
  • rendering/ImageBySizeCache.cpp: Revert changes to ImageBySizeCache, which were needed to make it usable for SVGImages. CSSImageGenerator doesn't need it. (WebCore::ImageBySizeCache::addClient): (WebCore::ImageBySizeCache::removeClient): (WebCore::ImageBySizeCache::getImage):
  • rendering/ImageBySizeCache.h: Ditto. (WebCore::SizeAndCount::SizeAndCount):
  • rendering/RenderImage.cpp: Stop using imageForRenderer(), use cachedImage()->image(), which is guaranteed to be a SVGImage for svg images, and not a cached bitmap copy. (WebCore::RenderImage::embeddedContentBox):
  • rendering/RenderReplaced.cpp: Simplify logic to figure out the intrinsic size - the special logic for the old SVGImage cache can go away now. (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): (WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
  • rendering/style/StyleCachedImage.cpp: Call removeClientForRenderer(), which takes care of clearing SVGImageCache entries as well. (WebCore::StyleCachedImage::removeClient): This change is needed, as we don't want to make removeClient() virtual in CachedResource.
  • rendering/svg/RenderSVGRoot.cpp: Rename isEmbeddedThroughImageElement to isEmbeddedThroughSVGImage, as this is what it actually checks. (WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGSVGElement.cpp: Fix bug that's visible now with the SVGImageCache, which was already there before, but hard to trigger. (WebCore::SVGSVGElement::currentViewBoxRect): The viewBox depends on who's asking for it: the host document or the embedded document? Take that into account.
  • svg/SVGSVGElement.h:
  • svg/graphics/SVGImage.cpp: Cleanup some code. Add new logic that draws a SVGImage into an ImageBuffer at a desired size & zoom. (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::drawSVGToImageBuffer):
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp: Added. SVGImageCache caches Image/ImageBuffer pairs for each _renderer_ and size/zoom level. The ImageBySizeCache only cared about size. (WebCore::SVGImageCache::SVGImageCache): (WebCore::SVGImageCache::~SVGImageCache): (WebCore::SVGImageCache::removeRendererFromCache): (WebCore::SVGImageCache::setRequestedSizeAndZoom): (WebCore::SVGImageCache::getRequestedSizeAndZoom): (WebCore::SVGImageCache::imageContentChanged): (WebCore::SVGImageCache::redrawTimerFired): (WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
  • svg/graphics/SVGImageCache.h: Added. (WebCore::SVGImageCache::create): (WebCore::SVGImageCache::CachedSizeAndZoom::CachedSizeAndZoom): (WebCore::SVGImageCache::CachedImageData::CachedImageData):

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
​https://bugs.webkit.org/show_bug.cgi?id=71368

Reviewed by Antti Koivisto.

  • CMakeLists.txt: Add svg/graphics include, for SVGImageCache.h.
1:13 AM Changeset in webkit [99538] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip flaky crasher on GTK.

  • platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-fieldset-legend.html
1:07 AM Changeset in webkit [99537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] Application cache directory is incorrectly set
​https://bugs.webkit.org/show_bug.cgi?id=70680

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-11-08
Reviewed by Philippe Normand.

Correctly set application cache directory to be in current
user's default cache directory.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::applicationCacheDirectory):

1:04 AM Changeset in webkit [99536] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Some tests are flaky with NRWT
​https://bugs.webkit.org/show_bug.cgi?id=64002
There can be found the skipped tests:
​https://bugs.webkit.org/show_bug.cgi?id=71693
​https://bugs.webkit.org/show_bug.cgi?id=71695

These 2 tests caused 7 tests timeouting.

Patch by Nándor Huszka <​huszka.nandor@stud.u-szeged.hu> on 2011-11-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip culprit tests
  • http/tests/notifications/icon-does-not-exist.html
  • http/tests/xmlhttprequest/workers/abort-exception-assert.html
  • platform/qt/test_expectations.txt: Unskip passing tests.
1:01 AM Changeset in webkit [99535] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
​https://bugs.webkit.org/show_bug.cgi?id=71759

Patch by Luiz Agostini <​luiz.agostini@palm.com> on 2011-11-08
Reviewed by Simon Hausmann.

qwebkitplatformplugin.h must not depend on qwebkitglobal.h.

  • Api/qwebkitplatformplugin.h:

Updating the copy of qwebkitplatformplugin.h that is used by the example plugin. The previous
one was very outdated.

  • examples/platformplugin/qwebkitplatformplugin.h:
12:57 AM Changeset in webkit [99534] by Csaba Osztrogonác
  • 1 edit
    14 adds in trunk/LayoutTests

[Qt] Unreivewed gardening. Reset test results.

Patch by Fehér Zsolt <​feherzs@inf.u-szeged.hu> on 2011-11-08

  • platform/qt-5.0/fast/css/child-style-can-override-visited-style-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/qt-5.0/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
  • platform/qt-5.0/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/svg-image-change-content-size-expected.txt: Added.
12:55 AM Changeset in webkit [99533] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: refactor shortcuts and settings screens
​https://bugs.webkit.org/show_bug.cgi?id=71773

Keep pointer to the visible screen and hide it automatically when new one is going
to be displayed.

Reviewed by Pavel Feldman.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen): ShortcutsScreen is now a descendant of HelpScreen.
(WebInspector.ShortcutsScreen.prototype.show):

  • inspector/front-end/inspector.js:

(WebInspector._hideSettingsScreen):
(WebInspector.documentKeyDown):

12:52 AM Changeset in webkit [99532] by yuqiang.xian@intel.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
​https://bugs.webkit.org/show_bug.cgi?id=71768

Reviewed by Geoffrey Garen.

Also includes a fix to make the newly introduced AssemblyHelpers
friend of JSValue as we need the Tag definitions.

  • CMakeListsEfl.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • runtime/JSValue.h:
12:52 AM Changeset in webkit [99531] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, mark 2 tests flaky in GTK.

  • platform/gtk/test_expectations.txt:

fast/forms/password-placeholder-text-security.html and
fast/lists/inlineBoxWrapperNullCheck.html are flaky.

12:43 AM Changeset in webkit [99530] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

2011-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix Snow Leopard 32bit builds.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAspectRatio): CSSParserValue::fValue is a double, use narrowPrecisionToFloat() to convert double->float.
  • platform/ClockGeneric.cpp: Remove unneeded variable out of 32bit integer value range.
  • webaudio/BiquadDSPKernel.cpp: (WebCore::BiquadDSPKernel::getFrequencyResponse): Use narrowPrecisionTofloat() to convert double->float.
12:14 AM Changeset in webkit [99529] by yutak@chromium.org
  • 5 edits
    1 move
    4 adds
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline tests after r99454. Mark one SVG test as flaky.

  • platform/chromium-cg-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png.
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.png: Added.
  • platform/chromium-mac/fast/borders/outline-alpha-block-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png: Removed.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.png:
  • platform/chromium/test_expectations.txt:
12:10 AM Changeset in webkit [99528] by Simon Hausmann
  • 1 edit in trunk/Tools/MiniBrowser/qt/MiniBrowser.pro

Touch the pro file to trigger a proper (re)build of the Makefile on
the bot (removed redundant line)

Nov 7, 2011:

11:49 PM Changeset in webkit [99527] by Simon Hausmann
  • 5 edits in trunk/Tools

[Qt][WK2] MiniBrowser should use urlFromUserInput()
​https://bugs.webkit.org/show_bug.cgi?id=71680

Use urlFromUserInput() / QUrl::fromUserInput() to automatically
complete urls in MiniBrowser.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-11-07
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::load):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/utils.cpp:

(Utils::urlFromUserInput):

  • MiniBrowser/qt/utils.h:

(Utils::Utils):

11:32 PM Changeset in webkit [99526] by yuqiang.xian@intel.com
  • 2 edits in trunk/Tools

Added myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:51 PM Changeset in webkit [99525] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix gcc 4.4 compilation warnings in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=71762

Reviewed by Filip Pizlo.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::registersMatched):

10:49 PM Changeset in webkit [99524] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=71653

Reviewed by Kent Tamura.

  • platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html: Calls doTest() after iframe is loaded.
10:40 PM Changeset in webkit [99523] by dbates@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Add CredentialStorage.cpp to WebCore/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=71748

Reviewed by Martin Robinson.

Adds CredentialStorage.cpp to WebCore/CMakeLists.txt since its provides a
base implementation of this feature.

Also adds a stub implementation of CredentialStorage to the WinCE port.

  • CMakeLists.txt: Added source file CredentialStorage.cpp.
  • CMakeListsEfl.txt: Added source file CredentialStorageCurl.cpp when building with the Curl networking backend.
  • CMakeListsWinCE.txt: Added source file CredentialStorageWin.cpp.
  • platform/network/win/CredentialStorageWin.cpp: Added.

(WebCore::Credential::getFromPersistentStorage): Stub implementation.

10:27 PM Changeset in webkit [99522] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip a failing new test: svg/custom/getBBox-path.svg.
​https://bugs.webkit.org/show_bug.cgi?id=71766

  • platform/qt/Skipped:
10:12 PM Changeset in webkit [99521] by ravi.kasibhatla@motorola.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to the committer script.

10:03 PM Changeset in webkit [99520] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed webkitpy test fix after r99512.

  • Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:

Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.

9:48 PM Changeset in webkit [99519] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk/Source/JavaScriptCore

DFG code base should allow for classes not related to DFG::JITCompiler
to use DFG idioms
​https://bugs.webkit.org/show_bug.cgi?id=71746

Reviewed by Gavin Barraclough.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAssemblyHelpers.cpp: Added.

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):

  • dfg/DFGAssemblyHelpers.h: Added.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::graph):

  • dfg/DFGJITCompiler32_64.cpp:
  • dfg/DFGOSRExit.h: Added.

(JSC::DFG::SpeculationRecovery::SpeculationRecovery):
(JSC::DFG::SpeculationRecovery::type):
(JSC::DFG::SpeculationRecovery::dest):
(JSC::DFG::SpeculationRecovery::src):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::isVariable):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):

  • dfg/DFGSpeculativeJIT.h:
8:44 PM Changeset in webkit [99518] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Need to replace api's object parameter with proper name.
​https://bugs.webkit.org/show_bug.cgi?id=71553

Fix wrong parameter names in tiled backing store functions and ewk_view_xxx files.

Reviewed by Filip Pizlo.

  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
8:31 PM Changeset in webkit [99517] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/LayoutTests

Add layout test for locale-based font selection
​https://bugs.webkit.org/show_bug.cgi?id=67019

This test relies on overridePreference("WebKit*FontMap"...) which is
implemented only on Chromium DumpRenderTree so far.

Patch by Matt Falkenhagen <​falken@chromium.org> on 2011-11-07
Reviewed by Kent Tamura.

  • fast/text/international/locale-sensitive-fonts.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped: Added skip for non-Chromium ports.
  • platform/gtk-wk2/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
7:02 PM Changeset in webkit [99516] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.

Rubber stamped by Oliver Hunt.

  • bytecode/ValueProfile.h:
6:41 PM Changeset in webkit [99515] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL for window.Image of V8
​https://bugs.webkit.org/show_bug.cgi?id=71739

Reviewed by Adam Barth.

Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/dom/image-object.html
fast/dom/gc-image-element.html
fast/dom/Window/custom-constructors.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
6:25 PM Changeset in webkit [99514] by Chris Fleizach
  • 4 edits in trunk

REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
​https://bugs.webkit.org/show_bug.cgi?id=71421

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectOption):

LayoutTests:

Re-enable test after removing an erroneous assert.

  • platform/mac/test_expectations.txt:
6:25 PM Changeset in webkit [99513] by ariya@webkit.org
  • 6 edits in trunk

"use strict" can not contain escape sequences or line continuation
​https://bugs.webkit.org/show_bug.cgi?id=71532

Reviewed by Darin Adler.

Source/JavaScriptCore:

Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.

  • parser/Parser.cpp:

(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):

  • parser/Parser.h:

LayoutTests:

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

(testLineContinuation): Added.
(testEscapeSequence): Added.

6:14 PM Changeset in webkit [99512] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Add myself as a committer.

6:11 PM Changeset in webkit [99511] by eae@chromium.org
  • 22 edits in trunk/Source

Revert platform and scrolling to ints
​https://bugs.webkit.org/show_bug.cgi?id=71585

Reviewed by Eric Seidel.

Replace all uses of LayoutUnit and related types with ints in platform
and scrolling code.

Source/WebCore:

No new tests.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollAnimatorNone.h:
  • platform/ScrollView.cpp:
  • platform/ScrollView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::invalidateScrollbarRect):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
6:08 PM Changeset in webkit [99510] by haraken@chromium.org
  • 9 edits in trunk

Fixed wrong test results of fast/js/custom-constructors.html
​https://bugs.webkit.org/show_bug.cgi?id=71669

Reviewed by Darin Adler.

According to the HTMLOptionElement spec
(​http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
converted to a string "undefined" and a null value should be
converted to a string "null", following the step 3 of the IDL
conversion spec (​http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).

Source/WebCore:

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement): Removed isUndefined() check from 'text' and 'value' since the spec does not have [TreatUndefinedAs=EmptyString].

  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:

(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.

  • html/HTMLOptionElement.idl: Removed [ConvertNullToNullString] from 'text', 'label' and 'value' since the spec does not have [TreatNullAs=EmptyString].

LayoutTests:

  • fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
  • fast/dom/element-attribute-js-null.html: Ditto.
  • fast/js/custom-constructors-expected.txt: Ditto.
  • fast/js/script-tests/custom-constructors.js: Ditto.
5:40 PM WebKit Team edited by yuqiang.xian@intel.com
add me to the committer list (diff)
5:37 PM Changeset in webkit [99509] by abarth@webkit.org
  • 17 edits in trunk/Source

Move DomainRelaxationForbidden scheme registry to SchemeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=71750

Reviewed by Eric Seidel.

Source/WebCore:

As stated in the FIXME, scheme registries belong in SchemeRegistry, not
in SecurityOrigin.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::setDomain):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
  • platform/SchemeRegistry.cpp:

(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):

  • platform/SchemeRegistry.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDomainRelaxationForbidden):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit/win:

  • WebView.cpp:

(WebView::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):

5:16 PM Changeset in webkit [99508] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
​https://bugs.webkit.org/show_bug.cgi?id=71743

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.

4:59 PM Changeset in webkit [99507] by dslomov@google.com
  • 14 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.

Reviewed by David Levin.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.h:
  • html/canvas/Float32Array.h:
  • html/canvas/Float64Array.h:
  • html/canvas/Int16Array.h:
  • html/canvas/Int32Array.h:
  • html/canvas/Int8Array.h:
  • html/canvas/TypedArrayBase.h:
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint8Array.h:
4:57 PM Changeset in webkit [99506] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

addMessage's last few arguments should be optional
​https://bugs.webkit.org/show_bug.cgi?id=70946

Reviewed by Darin Adler.

As requested by Darin Adler. I wanted to call this method addMessage,
but the compiler was unhappy locating the overload on
ScriptExecutionContext when Document had an override too. Changing the
name to addConsoleMessage made all the code happier.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addMessage):

  • dom/ScriptExecutionContext.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logUnrecognizedDirective):

  • page/EventSource.cpp:

(WebCore::EventSource::didReceiveResponse):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createLowPass2Filter):
(WebCore::AudioContext::createHighPass2Filter):

  • xml/XMLHttpRequest.cpp:

(WebCore::reportUnsafeUsage):

4:51 PM Changeset in webkit [99505] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

WebWorkers fail with document.domain set when accessing from subdomain
​https://bugs.webkit.org/show_bug.cgi?id=67978

Reviewed by Sam Weinig.

Source/WebCore:

Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.

Test: http/tests/workers/worker-document-domain-security.html

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Test that a document can still create same-origin workers after setting
document.domain.

  • http/tests/workers/worker-document-domain-security-expected.txt: Added.
  • http/tests/workers/worker-document-domain-security.html: Added.
4:44 PM Changeset in webkit [99504] by vangelis@chromium.org
  • 2 edits in branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc

Merge 98392 - LayerRendererChromium::setVisible called needlessly without a visibility change
​https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <​mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/8491030

4:42 PM Changeset in webkit [99503] by vangelis@chromium.org
  • 10 edits in branches/chromium/912/Source

Merge 98185 - [chromium] Make setVisibility extension- and thread-correct
​https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

TBR=​nduca@chromium.org
Review URL: ​http://codereview.chromium.org/8479052

4:37 PM Changeset in webkit [99502] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG operationCreateThis slow path may get the wrong callee in case of inlining
​https://bugs.webkit.org/show_bug.cgi?id=71647

Reviewed by Oliver Hunt.

No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:33 PM Changeset in webkit [99501] by tony@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html

  • platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.
4:27 PM Changeset in webkit [99500] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Allow gamepad API to be enabled at runtime
​https://bugs.webkit.org/show_bug.cgi?id=71736

Part of full patch, found at
​https://bugs.webkit.org/show_bug.cgi?id=69451

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

No new tests. No new functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):

4:21 PM Changeset in webkit [99499] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.1

New tag.

4:10 PM Changeset in webkit [99498] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL for window.Option of V8
​https://bugs.webkit.org/show_bug.cgi?id=71735

Reviewed by Nate Chapin.

Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
3:57 PM Changeset in webkit [99497] by mhahnenberg@apple.com
  • 23 edits in trunk/Source

De-virtualize JSObject::putWithAttributes
​https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • API/JSObjectRef.cpp:

(JSObjectSetProperty):

(JSC::DebuggerActivation::putWithAttributes):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):

  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::putWithAttributes):

  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putWithAttributes):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):

  • runtime/JSObject.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putWithAttributes):

  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::putWithAttributes):

  • runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putWithAttributes):

  • bindings/js/JSDOMWindowShell.h:
3:53 PM Changeset in webkit [99496] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html

  • platform/chromium/test_expectations.txt:
3:49 PM Changeset in webkit [99495] by dslomov@google.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Release build fix.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):

3:46 PM Changeset in webkit [99494] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r99470.
​http://trac.webkit.org/changeset/99470
​https://bugs.webkit.org/show_bug.cgi?id=71740

"Broke test-webkitpy" (Requested by eseidel2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • Scripts/webkitpy/common/config/watchlist:
3:45 PM Changeset in webkit [99493] by Beth Dakin
  • 18 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>

Reviewed by Sam Weinig.

Source/WebCore:

Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has
entered or exited a scrollbar. These changes to Scrollbar pass that information
on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a
PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not
always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if
the mouse has exited the scrollbar.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):

  • platform/Scrollbar.h:

These changes are required now that Scrollbar::mouseUp() takes a parameter.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::handleMouseReleaseEvent):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::wndProc):

ScrollAnimator passes the information on to AppKit.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::mouseEnteredScrollbar):
(WebCore::ScrollAnimator::mouseExitedScrollbar):

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

There are several new pieces of AppKit api we must call into.

  • platform/mac/NSScrollerImpDetails.h:

This is a temporary function that is needed for the time being since there is new
AppKit api required for this to work.

  • platform/mac/ScrollAnimatorMac.mm:

(supportsUIStateTransitionProgress):

I refactored WebScrollbarPartAnimation so that it can handle the
uiStateTransitionProgress animation as well as the alpha animations it already
handled. This mostly involved re-naming things and making use of a new enum called
FeatureToAnimate which keeps track of what the instance of
WebScrollbarPartAnimation is animating.
(-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation setScrollbarPainter:]):
(-[WebScrollbarPartAnimation setStartValue:]):
(-[WebScrollbarPartAnimation setEndValue:]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):

WebScrollbarPainterDelegate has two new animations,
_verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It
also responds to a few new delegate calls.
(-[WebScrollbarPainterDelegate cancelAnimations]):

This is a new delegate call needed for uiStateTransitionProgress.
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things
that are specific to the alpha animation and I chose not to re-use it for
uiStateTransition.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

New delegate call for the uiStateTransition animation that sets up that animation
and kicks it off.
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Source/WebKit/chromium:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::onMouseUp):

Source/WebKit/win:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • WebScrollBar.cpp:

(WebScrollBar::handleMouseEvent):

Source/WebKit2:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onLButtonUp):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::handleMouseEvent):

3:43 PM Changeset in webkit [99492] by aboxhall@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary use of function pointer in FrameSelection::modify()
​https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):

3:39 PM Changeset in webkit [99491] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r99468.

  • css/CSSPrimitiveValue.h: Unmark single-argument constructors

as explicit, since this conflicts with the template constructors
in CSSPrimitiveValueMappings.h.

3:25 PM Changeset in webkit [99490] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix due to a erroneous search-and-replace.

Unreviewed build fix.

Replace all instances of GenericClock with ClockGeneric.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):

3:20 PM Changeset in webkit [99489] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Move parseSandboxPolicy to SecurityContext
​https://bugs.webkit.org/show_bug.cgi?id=71732

Reviewed by Eric Seidel.

As requested by Eric, this patch resolves a layering inversion. Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

  • dom/SecurityContext.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::applySandboxPolicy):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
3:17 PM Changeset in webkit [99488] by jer.noble@apple.com
  • 6 edits
    2 moves in trunk/Source/WebCore

Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source.
​https://bugs.webkit.org/show_bug.cgi?id=71702

Reviewed by Sam Weinig.

No new tests; covered by existing tests.

  • platform/Clock.cpp:

(Clock::create):

  • platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.

(ClockGeneric::GenericClock):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):

  • platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h.

(WebCore::ClockGeneric::playRate):
(WebCore::ClockGeneric::isRunning):

Boilerplate project file changes:

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
3:16 PM Changeset in webkit [99487] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] disable 2 tests that are slow in debug

  • platform/chromium/test_expectations.txt: only run

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
in release builds

3:08 PM Changeset in webkit [99486] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.

Rubber stamped by Geoff Garen.

  • bytecode/ValueProfile.h:
3:03 PM Changeset in webkit [99485] by vangelis@chromium.org
  • 14 edits in trunk

Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Reviewed by James Robinson.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

  • testing/Internals.cpp:

(WebCore::Internals::setEnableCompositingForScrollableFrames):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
​https://bugs.webkit.org/show_bug.cgi?id=71714

Adjust the force-compositing-mode layout tests to explicitly set the new flag.

Reviewed by James Robinson.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
2:55 PM Changeset in webkit [99484] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Fix mac build (with mutation_observers enabled)
​https://bugs.webkit.org/show_bug.cgi?id=71728

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

Errant forward declaration of MutationObserverRegistration removed from
Node.h this would have broken a port that tried to build with mutation_observers=1.

  • dom/Node.h:
2:51 PM Changeset in webkit [99483] by ap@apple.com
  • 14 edits
    2 moves in trunk/Source/WebKit2

The Full Keyboard Access preference should be read in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=71734
<rdar://problem/9237619>

Reviewed by Darin Adler.

This is consistent with how other global preferences (like language) are handled, and lets
us tighten up the sandbox a little.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value.
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process is already running, tell it. (WebKit::WebContext::ensureWebProcess): Set parameters.fullKeyboardAccessEnabled from current preference.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled):
  • UIProcess/WebProcessProxy.h: Proxy it to Objective-C code. WebProcessProxy is as good place to have the static function as any. One day, we will make code more consistent with language and other global preferences.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h.
  • UIProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.h: Removed.
  • WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Removed. (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): Once retrieved, push the preference value.
  • WebKit2.xcodeproj/project.pbxproj: WKFullKeyboardAccessWatcher is now in UI process.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::fullKeyboardAccessModeChanged): (WebKit::WebProcess::fullKeyboardAccessEnabled):
  • WebProcess/mac/WebProcessMac.mm: WebCprocess now holds the preference value in a mamber value, which UI process pushes updates to.
  • WebProcess/WebProcess.messages.in: Added a message for changes preference value.
  • WebProcess/com.apple.WebProcess.sb: We no longer need read access to com.apple.universalaccess.plist.
2:46 PM Changeset in webkit [99482] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Update chromium test_expectations.txt.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png:

Fix result that was attempted to be fixed in r99457.

  • platform/chromium/test_expectations.txt: Tests that need a baseline

after 99454.

2:39 PM Changeset in webkit [99481] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
​https://bugs.webkit.org/show_bug.cgi?id=71660

Reviewed by Adam Barth.

Currently, "new Audio()" uses a custom getter to get the template
of 'HTMLAudioElementConstructor'. However, this getter does not need to
be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
  • page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): If an IDL type is 'XXXXConstructorConstructor', then we do not add a header file 'XXXXConstructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class XXXX 'XXXX.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'XXXXConstructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.

2:38 PM Changeset in webkit [99480] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Emit the "frame,created" signal earlier.
​https://bugs.webkit.org/show_bug.cgi?id=71696

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-07
Reviewed by Kenneth Rohde Christiansen.

FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
emitting the "frame,created" signal after that, applications would connect to
it after some other frame signals had already been emitted. Should help tests
such as http/tests/loading/empty-subframe.html pass.

  • ewk/ewk_frame.cpp:

(ewk_frame_child_add):

  • ewk/ewk_view.cpp:

(ewk_view_frame_create):

2:35 PM Changeset in webkit [99479] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=71606

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-07
Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt: Remove the expected failure.
2:31 PM Changeset in webkit [99478] by tony@chromium.org
  • 3 edits in trunk/Tools

[chromium] update flakiness dashboard to reflect current bots

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js: Remove (deps) debug

bots and merged linux debug bots into a single bot.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(setupExpectationsTest):

2:20 PM Changeset in webkit [99477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Uninitialized Heap member var
​https://bugs.webkit.org/show_bug.cgi?id=71722

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-11-07
Reviewed by Filip Pizlo.

  • heap/Heap.cpp:

(JSC::Heap::Heap): Initialize m_blockFreeingThreadShouldQuit

2:13 PM Changeset in webkit [99476] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible
​https://bugs.webkit.org/show_bug.cgi?id=71684

Reviewed by Filip Pizlo.

Currently in DFG JIT, we try to reuse the physical register of an
operand for temporary usage if the current use of the operand is the
last use. But sometimes this can be wrong, for example if there are
possible speculation failures and we need to fallback to baseline JIT,
the value of the operand which is supposed to be hold in the physical
register can be modified by register reusing. The fixes the last
inspector failures in layout test on Mac 32-bit if switching on DFG.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

2:13 PM Changeset in webkit [99475] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

2:10 PM Changeset in webkit [99474] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r99436): Broke Snow Leopard debug build
​https://bugs.webkit.org/show_bug.cgi?id=71713

Reviewed by Darin Adler.

Put the assertion in a template and use template specialization
to avoid warning when instantiated with UChar or LChar.

In the long term, we should have traits for unsigned integral types
and use that to specialize template instead of specializing it for UChar and LChar.

  • parser/Lexer.cpp:

(JSC::assertCharIsIn8BitRange):
(JSC::::append8):

2:09 PM Changeset in webkit [99473] by andersca@apple.com
  • 5 edits
    4 copies in trunk/Source/WebKit2

Add TiledCoreAnimationDrawingArea stub classes
​https://bugs.webkit.org/show_bug.cgi?id=71729

Reviewed by Sam Weinig.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _shouldUseTiledDrawingArea]):
(-[WKView WebKit::]):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingAreaProxy::create):
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: Copied from Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp.

(WebKit::TiledCoreAnimationDrawingArea::create):
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):

2:03 PM Changeset in webkit [99472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
​https://bugs.webkit.org/show_bug.cgi?id=71694

Patch by Robert Sesek <​rsesek@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
1:59 PM Changeset in webkit [99471] by dominicc@chromium.org
  • 6 edits in trunk

Remove initPopStateEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71691

Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/PopStateEvent.cpp:
  • dom/PopStateEvent.h:
  • dom/PopStateEvent.idl:

LayoutTests:

  • fast/events/fire-popstate-event.html: use 'new PopStateEvent' now
1:30 PM Changeset in webkit [99470] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add cc-bugs group to watch changes in chromium graphics
​https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <​danakj@chromium.org> on 2011-11-07
Reviewed by James Robinson.

  • Scripts/webkitpy/common/config/watchlist:
1:20 PM Changeset in webkit [99469] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
​https://bugs.webkit.org/show_bug.cgi?id=70912

Patch by Balazs Ankes <​Ankes.Balazs@stud.u-szeged.hu> on 2011-11-07
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
1:19 PM Changeset in webkit [99468] by andreas.kling@nokia.com
  • 53 edits
    1 add in trunk/Source/WebCore

CSSValue: Devirtualize isFooType().
<​http://webkit.org/b/71668>

Reviewed by Darin Adler.

Add a member to CSSValue to determine which subclass a given
value object is, along with 5 bits to tell us whether the
value is primitive/mutable/initial/inherited/a list.

All non-private subclass constructors now take CSSValue::ClassType
as their first argument. A few constructors were duplicated as
private members to allow calling them from ::create() methods
without passing an explicit ClassType.

Furthermore, since CSSValue::cssValueType() can be inferred from
the subclass type, we compute it instead of storing it in a member.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Adding CSSValue.cpp.

  • css/CSSValue.cpp: Added.

(WebCore::CSSValue::cssValueType):

Out-of-line implementation of this method. Only used by CSSOM.

  • css/CSSValue.h:

(WebCore::CSSValue::isMutableValue):
(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isBorderImageValue):
(WebCore::CSSValue::isBorderImageSliceValue):
(WebCore::CSSValue::isCursorImageValue):
(WebCore::CSSValue::isFontFamilyValue):
(WebCore::CSSValue::isFontFeatureValue):
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isReflectValue):
(WebCore::CSSValue::isShadowValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::isWebKitCSSTransformValue):
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isFlexValue):
(WebCore::CSSValue::isWebKitCSSFilterValue):
(WebCore::CSSValue::isSVGColor):
(WebCore::CSSValue::isSVGPaint):
(WebCore::CSSValue::classType):
(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::isPrimitiveType):
(WebCore::CSSValue::isListType):
(WebCore::CSSValue::isMutableType):
(WebCore::CSSValue::isInheritedType):
(WebCore::CSSValue::isInitialType):

Store subclass type information into a member variable and
made all the isFooValue() functions non-virtual and inline.
Some subclass type lookups (primitive values, notably) are
cached in a bool member on construction.

  • css/CSSAspectRatioValue.h:

(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):

  • css/CSSBorderImageSliceValue.h:
  • css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):

  • css/CSSBorderImageValue.h:
  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::CSSCanvasValue):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::CSSCursorImageValue):

  • css/CSSCursorImageValue.h:
  • css/CSSFlexValue.h:

(WebCore::CSSFlexValue::CSSFlexValue):

  • css/CSSFontFaceSrcValue.h:

(WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::CSSFunctionValue):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isLinearGradient):
(WebCore::CSSGradientValue::isRadialGradient):
(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue):
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):

  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):
(WebCore::CSSInitialValue::create):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):

  • css/CSSLineBoxContainValue.h:
  • css/CSSMutableValue.h:

(WebCore::CSSMutableValue::CSSMutableValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSReflectValue.h:

(WebCore::CSSReflectValue::CSSReflectValue):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):

  • css/CSSUnicodeRangeValue.h:

(WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
  • css/FontFamilyValue.cpp:

(WebCore::FontFamilyValue::FontFamilyValue):

  • css/FontFamilyValue.h:
  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::FontFeatureValue):

  • css/FontFeatureValue.h:
  • css/FontValue.h:

(WebCore::FontValue::FontValue):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::ShadowValue):

  • css/ShadowValue.h:
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

  • css/WebKitCSSTransformValue.h:
  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):

  • svg/SVGColor.h:
  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::SVGPaint):

  • svg/SVGPaint.h:

Propagate subclass type information and kill isFooType() virtuals.

1:14 PM Changeset in webkit [99467] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=71259

Reviewed by Darin Adler.

Leak fixes covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
The RenderBoxRegionInfo taken out of RenderRegion must be deleted on all code paths.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::removeRenderBoxRegionInfo):
The RenderBoxRegionInfo map owns the values, therefore, when values are removed from map
they must also be deleted.

1:07 PM WebKit Team edited by haraken@chromium.org
(diff)
1:05 PM Changeset in webkit [99466] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

iframe sandbox treats vertical tab as a valid delimiter
​https://bugs.webkit.org/show_bug.cgi?id=71704

Reviewed by Eric Seidel.

Source/WebCore:

This patch adjusts our parser slightly to match the HTML5 spec. The
only difference is in how we handle vertical tabs. Previously, we
treated them as a delimiter, but we're not supposed to do that.

Test: fast/frames/sandboxed-iframe-parsing-space-characters.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::parseSandboxPolicy):

LayoutTests:

Test which space-like charaters are treating as delimiters.

  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt: Added.
  • fast/frames/sandboxed-iframe-parsing-space-characters.html: Added.
1:01 PM Changeset in webkit [99465] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Follow-up build fix.

  • WebProcess/WebPage/DrawingAreaImpl.h:
1:01 PM Changeset in webkit [99464] by abarth@webkit.org
  • 13 edits
    2 adds in trunk/Source/WebCore

Factor SecurityContext out of ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=71721

Reviewed by Eric Seidel.

The new SecurityContext object lets us tightly scope control of
the security-critical information in ScriptExecutionContext.
Originally I had hoped to put all this state on SecurityOrigin, but
SecurityOrigin gets shared between documents in some corner cases, so
it's not a good fit for state like the sandbox flags and the CSP policy
that really needs to be per-document.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • page/SecurityOrigin.h:
12:50 PM Changeset in webkit [99463] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
​https://bugs.webkit.org/show_bug.cgi?id=71659

Reviewed by Adam Barth.

Just refactor CodeGeneratorV8.pm without any change in behavior,
as the first step for fixing bug 71093.

Tests: WebCore/bindings/scripts/test/TestObj.idl

WebCore/bindings/scripts/test/TestInterface.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new TestXXXX.idl is added.
(GenerateConstructorCallback): Renamed variables to clarify their roles.
(WriteData): Removed an unused array @implHeaderContent.

  • bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
  • bindings/scripts/test/V8/V8TestObj.h: Ditto.
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
12:48 PM Changeset in webkit [99462] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash due to mixed direction text runs
​https://bugs.webkit.org/show_bug.cgi?id=66015

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-07
Reviewed by David Hyatt.

Source/WebCore:

Test for bug fix.

  • fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
  • fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added

LayoutTests:

In some cases extra bidi runs were being added because appendRun() was being called
after the last run of the line was already appended.

This converts a previous fix for this bug to an ASSERT, because the check is
unnecessary, though it is a symptom that text runs have somehow gotten messed up.

  • rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
run of the line

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert

12:42 PM Changeset in webkit [99461] by eric@webkit.org
  • 4 edits in trunk/Tools

new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=62199

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12:40 PM Changeset in webkit [99460] by timothy_horton@apple.com
  • 13 edits
    2 adds in trunk

getBBox() on a SVGPathElement with curves incorrectly includes control points
​https://bugs.webkit.org/show_bug.cgi?id=53512
<rdar://problem/9861154>

Reviewed by Oliver Hunt.

Split Path::boundingRect() into two, adding Path::fastBoundingRect()
for a rough estimate of the bounding rect (always equal to or larger
than boundingRect()). fastBoundingRect() currently falls back to
boundingRect() for all ports besides CG, though in most cases
(on a port-by-port basis) the current implementation of boundingRect()
will need to become fastBoundingRect(), and a new, more accurate method will
be implemented for boundingRect().

All previous callers of boundingRect() are transitioned to using fastBoundingRect()
except SVGPathElement::getBBox, which wants an accurate bounding box.

The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.

Test: svg/custom/getBBox-path.svg

  • html/HTMLAreaElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGPath.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:

Add a test that ensures that getBBox does not include control points in the rect it returns.

  • platform/chromium/test_expectations.txt:
  • svg/custom/getBBox-path-expected.txt: Added.
  • svg/custom/getBBox-path.svg: Added.
12:37 PM Changeset in webkit [99459] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
​https://bugs.webkit.org/show_bug.cgi?id=71710

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):

12:35 PM Changeset in webkit [99458] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Suggest box should consume enter key pressed event.
​https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.evaluateInConsole):

12:29 PM Changeset in webkit [99457] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=71214

Reviewed by Adam Barth.

  • platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
12:26 PM Changeset in webkit [99456] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Build all libraries in both debug and release on Mac OS X

We were already building the final shared library in debug and release,
but were missing the static JavaScriptCore and WebCore libraries, which
then broke the build.

Reviewed-by Andreas Kling.

12:21 PM Changeset in webkit [99455] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove unused DrawingArea::syncCompositingLayers
​https://bugs.webkit.org/show_bug.cgi?id=71717

Reviewed by John Sullivan.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
12:18 PM Changeset in webkit [99454] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Optimize outline rendering to avoid transparency layers
​https://bugs.webkit.org/show_bug.cgi?id=60750

Source/WebCore:

Add fast path for solid block outlines with alpha.
Improve readability of piecewise path while at it.

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

Rebaseline pixel tests to accommodate subtle change in rounding.

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-07
Reviewed by Simon Fraser.

  • platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.
12:09 PM Changeset in webkit [99453] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Suggest box should not accept suggestion on space key pressed.
​https://bugs.webkit.org/show_bug.cgi?id=71706

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):

11:46 AM Changeset in webkit [99452] by Nate Chapin
  • 2 edits in branches/chromium/874/Source/WebCore/bindings/v8

Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
​https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

  • bindings/v8/npruntime.cpp:

TBR=Nate Chapin
Review URL: ​http://codereview.chromium.org/8493015

11:32 AM Changeset in webkit [99451] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark perf/documnet-contians.html as slow.

  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [99450] by andreas.kling@nokia.com
  • 10 edits in trunk/Source/WebCore

Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
<​http://webkit.org/b/71679>

Reviewed by Darin Adler.

Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue()
and isInheritedValue() to increase code clarity.

The plan is to turn cssValueType() into a computed value based on the
CSSValue subclass (coming soon to <​http://webkit.org/b/71668>.)
This is a clean-up in preparation for that.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):

  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::isInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::isInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillAttachment):
(WebCore::CSSStyleSelector::mapFillClip):
(WebCore::CSSStyleSelector::mapFillComposite):
(WebCore::CSSStyleSelector::mapFillOrigin):
(WebCore::CSSStyleSelector::mapFillImage):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::mapAnimationDelay):
(WebCore::CSSStyleSelector::mapAnimationDirection):
(WebCore::CSSStyleSelector::mapAnimationDuration):
(WebCore::CSSStyleSelector::mapAnimationFillMode):
(WebCore::CSSStyleSelector::mapAnimationIterationCount):
(WebCore::CSSStyleSelector::mapAnimationName):
(WebCore::CSSStyleSelector::mapAnimationPlayState):
(WebCore::CSSStyleSelector::mapAnimationProperty):
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

11:20 AM Changeset in webkit [99449] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Rename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin::wantsPluginRelativeNPWindowCoordinates
​https://bugs.webkit.org/show_bug.cgi?id=71708

Reviewed by Sam Weinig.

The name wantsPluginRelativeNPWindowCoordinates is more clear than wantsWindowRelativeNPWindowCoordinates. Rename the functions
everywhere and, since the meaning is now inverted, invert the checks and return values.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):

11:20 AM Changeset in webkit [99448] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

NetscapePlugin::wantsWindowRelativeNPWindowCoordinates should return false on Mac
​https://bugs.webkit.org/show_bug.cgi?id=71707

Reviewed by Sam Weinig.

This changes the way the fake Carbon plug-in window is positioned, so that it's always the same size
and location as the plug-in (relative to the screen).

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformGeometryDidChange):
Call updateFakeWindowBounds.

(WebKit::NetscapePlugin::updateFakeWindowBounds):
Convert the plug-in position to screen coordinates and set the window bounds to be the location and
size of the plug-in, where the location is relative to the screen.

(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Return false.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Call updateFakeWindowBounds.

11:12 AM Changeset in webkit [99447] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r99432.
​http://trac.webkit.org/changeset/99432
​https://bugs.webkit.org/show_bug.cgi?id=71709

It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

11:10 AM Changeset in webkit [99446] by Lucas Forschler
  • 1 copy in branches/safari-534.54-branch

New Branch.

11:10 AM Changeset in webkit [99445] by Lucas Forschler
  • 1 copy in branches/safari-534.53-branch

New Branch.

11:09 AM Changeset in webkit [99444] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r99409): Broke transitions/clip-transition.html
<​http://webkit.org/b/71692>

Reviewed by Darin Adler.

Add missing base class initializers to CSSPrimitiveValue constructors.
This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

10:46 AM Changeset in webkit [99443] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPage.h should be in PrivateHeaders.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Mark WKPage.h private.

10:28 AM Changeset in webkit [99442] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Support requestAnimationFrame API
​https://bugs.webkit.org/show_bug.cgi?id=67112

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-11-07
Reviewed by Andreas Kling.

.:

Add build-option for requestAnimationFrame feature.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.

  • wtf/Platform.h:

Source/WebCore:

Add some files to build-target when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • CMakeLists.txt:
  • UseJSC.cmake:
10:26 AM Changeset in webkit [99441] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Add missing .in and .pl files to the Xcode project for easy access.

Reviewed by Eric Carlson.

  • WebCore.xcodeproj/project.pbxproj:

Add some missing files to the Xcode project.

10:24 AM Changeset in webkit [99440] by fsamuel@chromium.org
  • 7 edits in trunk

[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
​https://bugs.webkit.org/show_bug.cgi?id=71485

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Created new method setPageScaleFactor to replace scalePage to match
renamed method in WebCore. This change will happen in three stages:

  1. A new method is created called setPageScaleFactor with the same functionality as scalePage.
  2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium repository.
  3. scalePage is deleted from WebView/WebViewImpl
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):
(WebKit::WebViewImpl::setPageScaleFactor):

  • src/WebViewImpl.h:

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

10:16 AM Changeset in webkit [99439] by jberlin@webkit.org
  • 14 edits in trunk/Source

Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
enabled.
​https://bugs.webkit.org/show_bug.cgi?id=71631

Reviewed by Jon Honeycutt.

Source/WebCore:

Check the SchemeRegistry before preventing read/write access to Local Storage and Databases
in Private Browsing.

  • WebCore.exp.in:

Export the symbols for registering the schemes as allowing Local Storage and Database access
in Private Browsing.

  • dom/Document.cpp:

(WebCore::Document::allowDatabaseAccess):
Check if the scheme allows Database access in Private Browsing.

  • platform/SchemeRegistry.cpp:

(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
(WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing):

  • platform/SchemeRegistry.h:
  • storage/Storage.cpp:

(WebCore::Storage::length):
Ask the storage area if it is disabled by Private Browsing in the frame instead of just
checking if Private Browsing is enabled for that frame because the answer might depend on
what type of storage that storage area is.
(WebCore::Storage::key):
Ditto.
(WebCore::Storage::getItem):
Ditto.
(WebCore::Storage::contains):
Ditto.

  • storage/StorageArea.h:

Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a
Frame.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
Renamed from privateBrowsingEnabled.
Check not only if Private Browsing is enabled for the Frame, but also if the storage type is
Local Storage and if there is an exception for the scheme of the resource currently loaded
into the Frame.
(WebCore::StorageAreaImpl::setItem):
Renamed privateBrowsingEnabled -> disabledByPrivateBrowsingInFrame.
(WebCore::StorageAreaImpl::removeItem):
Ditto.
(WebCore::StorageAreaImpl::clear):
Ditto.

  • storage/StorageAreaImpl.h:

Source/WebKit/chromium:

  • src/StorageAreaProxy.h:

(WebCore::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Chromium uses a different method to track its icognito mode, so always return false.

Source/WebKit/mac:

Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
Databases.

  • WebView/WebView.mm:

(+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
Call through to the SchemeRegistry function.
(+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
Ditto.

  • WebView/WebViewPrivate.h:
10:04 AM Changeset in webkit [99438] by dominicc@chromium.org
  • 11 edits in trunk

Remove initCloseEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71374

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • websockets/CloseEvent.h:

(WebCore::CloseEvent::initCloseEvent):

  • websockets/CloseEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
10:00 AM Changeset in webkit [99437] by andersca@apple.com
  • 6 edits in trunk/Source

Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=71699

Reviewed by Sam Weinig.

Source/WebCore:

Export AffineTransform symbols used by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Add a getScreenTransform function which given a coordinate space returns a transform that converts a
point from that coordinate space to the screen coordinate space. We then get the source -> screen transform
and the destination -> screen transform. We invert the destination -> screen transform, multiply it with the
source -> screen transform and use mapPoint to get a complete affine transform from the source to the destination space
and use mapPoint to map the source point and return the destination point.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::getScreenTransform):
(WebKit::NetscapePlugin::convertPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
Call windowAndViewFramesChanged before viewGeometryDidChange so that the window and view frames will be up to date by
the time NPP_SetWindow is called in the plug-in.

9:54 AM Changeset in webkit [99436] by msaboff@apple.com
  • 25 edits in trunk/Source

Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
​https://bugs.webkit.org/show_bug.cgi?id=71331

Source/JavaScriptCore:

Change the Lexer class to be a template class based on the character
type of the source. In the process updated the parseIdentifier()
and parseString() methods to create 8 bit strings where possible.
Also added some helper methods for accumulating temporary string
data in the 8 and 16 bit vectors.

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.

Updated the KeywordLookup generator to create code to match keywords
for both 8 and 16 bit source strings.

Due to a compiler bug (<rdar://problem/10194295>) moved enum
definition outside of Lexer class declaration. Remove second enum
no longer needed.

Reviewed by Darin Adler.

  • KeywordLookupGenerator.py:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

  • parser/Lexer.cpp:

(JSC::::Lexer):
(JSC::::~Lexer):
(JSC::::getInvalidCharMessage):
(JSC::::currentCharacter):
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::peek):
(JSC::::getUnicodeCharacter):
(JSC::::shiftLineTerminator):
(JSC::::lastTokenWasRestrKeyword):
(JSC::::record8):
(JSC::::append8):
(JSC::::append16):
(JSC::::record16):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::parseHex):
(JSC::::parseOctal):
(JSC::::parseDecimal):
(JSC::::parseNumberAfterDecimalPoint):
(JSC::::parseNumberAfterExponentIndicator):
(JSC::::parseMultilineComment):
(JSC::::nextTokenIsColon):
(JSC::::lex):
(JSC::::scanRegExp):
(JSC::::skipRegExp):
(JSC::::clear):
(JSC::::sourceCode):

  • parser/Lexer.h:

(JSC::Lexer::append16):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffsetFromCharOffset):
(JSC::::isWhiteSpace):
(JSC::::isLineTerminator):
(JSC::::convertHex):
(JSC::::convertUnicode):
(JSC::::makeIdentifier):
(JSC::::setCodeStart):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::lexExpectIdentifier):

  • parser/Parser.cpp:

(JSC::Parser::Parser):
(JSC::Parser::parseProperty):
(JSC::Parser::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):

  • parser/SourceCode.h:

(JSC::SourceCode::subExpression):

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::stringData):

  • parser/SourceProviderCache.h:
  • parser/SyntaxChecker.h:
  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::add):
(JSC::IdentifierLCharFromUCharTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::equal):
(JSC::IdentifierLCharFromUCharTranslator::translate):
(JSC::Identifier::add8):

  • runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(JSC::Identifier::canUseSingleCharacterString):
(JSC::IdentifierCharBufferTranslator::hash):
(JSC::IdentifierCharBufferTranslator::equal):
(JSC::IdentifierCharBufferTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::equal):
(JSC::IdentifierTable::add):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseIntOverflow):
(JSC::globalFuncUnescape):

  • runtime/JSGlobalObjectFunctions.h:

(JSC::parseIntOverflow):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lexString):

  • wtf/text/StringImpl.h:

Source/WebCore:

Changed the SourceProvider::data() virtual method to return a
StringImpl* instead of a UChar*.
Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

No new tests - refactored SourceProvider class and sub-classes.

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::stringData):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::stringData):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

Source/WebKit/qt:

Changed Identifier() constructor to use JSGlobalData*.

Reviewed by Darin Adler.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

9:51 AM Changeset in webkit [99435] by dominicc@chromium.org
  • 5 edits in trunk

Remove initOverflowEvent from JavaScript bindings
​https://bugs.webkit.org/show_bug.cgi?id=71687

Reviewed by Ojan Vafai.

Source/WebCore:

Now that OverflowEvent has a constructor, we don't need the
initOverflowEvent method. It has to remain in the Objective C
binding because it is part of the Objective C public API.

  • dom/OverflowEvent.idl:

LayoutTests:

OverflowEvent initialization is tested in
fast/events/constructors/overflow-event-constructor.html

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
9:48 AM Changeset in webkit [99434] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

Refactor canvas encoding mimeType validation
​https://bugs.webkit.org/show_bug.cgi?id=71651

Reviewed by Andreas Kling.

No new tests, refactoring only, covered by existing canvas tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toEncodingMimeType): move encoder mimeType
validation logic into a helper routine.
(WebCore::HTMLCanvasElement::toDataURL):

  • html/HTMLCanvasElement.h:
9:43 AM Changeset in webkit [99433] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=71655

Reviewed by Martin Robinson.

  • fast/frames/flattening/frameset-flattening-simple.html: Trigger

the test only after the embedded frame has been loaded.

9:36 AM Changeset in webkit [99432] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Suggest box should consume enter key pressed event.
​https://bugs.webkit.org/show_bug.cgi?id=71700

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):

9:16 AM Changeset in webkit [99431] by dominicc@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove initPageTransitionEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71689

Reviewed by Ojan Vafai.

initPageTransitionEvent was removed from the HTML spec; it has
been replaced by new PageTransitionEvent(...).

Removing a method, so no new tests.

  • dom/PageTransitionEvent.cpp:
  • dom/PageTransitionEvent.h:
  • dom/PageTransitionEvent.idl:
9:15 AM Changeset in webkit [99430] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place
​https://bugs.webkit.org/show_bug.cgi?id=71676

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):

  • inspector/front-end/inspectorCommon.css:

(body): Revert inadvertent style change from a preceding commit.

8:51 AM Changeset in webkit [99429] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Qt build on Mac OS X when using the QuickTime media backend

When QtWebKit is built on Mac OS X using the QuickTime media backend
we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
we have to guard the potentially duplicate symbol createCFURL with
more than just !PLATFORM(MAC).

Reviewed by Andreas Kling.

8:51 AM Changeset in webkit [99428] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree

Allows us to not package up the whole Source/JavaScriptCore directory for the
buildbots.

Reviewed-by Simon Hausmann.

8:48 AM Changeset in webkit [99427] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-11-07 Pavel Feldman <​pfeldman@google.com>

Not reviewed: follow up to r99407. Style the suggest box.
​https://bugs.webkit.org/show_bug.cgi?id=65511

  • inspector/front-end/TextPrompt.js:
  • inspector/front-end/inspector.css:
  • inspector/front-end/textPrompt.css:
8:31 AM Changeset in webkit [99426] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=70223
CSSStyleSheet: finding the owner node should be in its own method

Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.

Reviewed by Dimitri Glazkov.

No new tests. (refactoring)

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::styleSheetOwnerNode):
(WebCore::CSSStyleSheet::document):

  • css/CSSStyleSheet.h:
8:24 AM Changeset in webkit [99425] by kenneth@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt] Put handling of gestures and their interaction in one place
​https://bugs.webkit.org/show_bug.cgi?id=71682

Reviewed by Simon Hausmann.

Before this patch, the interaction (ie. cancelling animations, events)
was handled in the respective recognizers which then knew about each
others.

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit::QtGestureRecognizer::isRecognized):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:
  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtPinchGestureRecognizer.h:
  • UIProcess/qt/QtTouchWebPageProxy.cpp:

(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::doneWithTouchEvent):

  • UIProcess/qt/QtTouchWebPageProxy.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):

  • UIProcess/qt/QtViewportInteractionEngine.h:
7:58 AM Changeset in webkit [99424] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Make it possible to include qdesktopwebview.h from apps

Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward

declare the structs manually.

7:43 AM Changeset in webkit [99423] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] More gardening. Skip keygen related tests.

Rubber-stamped by Ossy.

  • platform/qt/Skipped: We don't support <keygen>, so group

the keygen failures and add a comment.

7:22 AM Changeset in webkit [99422] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, unskip tests that appear to pass now.

Rubber-stamped by Ossy.

  • platform/qt/Skipped:
6:43 AM Changeset in webkit [99421] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit

Reviewed-by Simon Hausmann.

6:43 AM Changeset in webkit [99420] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Sanitize qmake paths correctly before comparing

The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
which caused us to always generate derived webcore sources, but never build
them. The bug has been fixed, and we now also sanitize paths for the injected
bundle derived sources.

Reviewed-by Simon Husmann.

6:42 AM Changeset in webkit [99419] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Print right order for changing feature defines

Reviewed by Simon Hausmann.

6:32 AM Changeset in webkit [99418] by Simon Hausmann
  • 6 edits in trunk

[Qt] Fix failing inspector tests after build system changes ​https://bugs.webkit.org/show_bug.cgi?id=71677

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • Api/qwebpage.cpp:

(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(initResources):
(WebKit::WebPage::platformInitialize):

LayoutTests:

  • platform/qt/Skipped: Unskip previously failing tests.
6:30 AM Changeset in webkit [99417] by yurys@chromium.org
  • 8 edits in trunk/Source

[Chromium] Web Inspector: use native worker inspector instead of fake workers
​https://bugs.webkit.org/show_bug.cgi?id=71670

Source/WebCore:

Removed context menu option for switching between native and "fake" workers
debugger. Native debugger is used by default on platforms that support it.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):

  • inspector/front-end/scriptsPanel.css:

(#shared-workers-list):

Source/WebKit/chromium:

chrome://workers link is replaced with instructions on discovering shared workers
in Task Manager.

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

():

6:20 AM Changeset in webkit [99416] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add advanced search shortcut to ShortcutsScreen.
​https://bugs.webkit.org/show_bug.cgi?id=71302

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.createShortcut):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

6:10 AM Changeset in webkit [99415] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSImageValue: Remove inheritance from CachedImageClient.
<​http://webkit.org/b/71675>

Reviewed by Antti Koivisto.

CSSImageValue doesn't actually use any of the CachedImageClient
functionality, and holds a reference to the resource via the
CachedResourceHandle in StyleCachedImage.

So we can safely remove the multiple inheritance and simplify
the class.

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::clearCachedImage):

  • css/CSSImageValue.h:
6:09 AM Changeset in webkit [99414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-07

  • DEPS:
6:04 AM Changeset in webkit [99413] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip a new failing test on Qt
​https://bugs.webkit.org/show_bug.cgi?id=70893

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
5:46 AM Changeset in webkit [99412] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

CSSPrimitiveValue: Remove unused virtual function parseString().
<​http://webkit.org/b/71671>

Reviewed by Antti Koivisto.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
5:43 AM Changeset in webkit [99411] by caseq@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: use toString as the Date object description.
​https://bugs.webkit.org/show_bug.cgi?id=71605

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/remote-object.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/remote-object-expected.txt: Added.
  • inspector/remote-object.html: Added.
5:40 AM Changeset in webkit [99410] by caseq@chromium.org
  • 7 edits in trunk

Web Inspector: [refactoring] get JS-specific methods out of SourceFrame
​https://bugs.webkit.org/show_bug.cgi?id=70885

Reviewed by Pavel Feldman.

No new tests, as there's no new functionality.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.contentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadonly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.cancelEditing):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onShowPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._mouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._createConditionElement):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrameDelegate):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.requestContent):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.continueToLine):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSource):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrameDelegate.prototype.addToWatch):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.SourceFrameDelegateForScriptsPanel):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.get textViewer):
(WebInspector.SourceFrame.prototype.requestContent):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.SourceFrame.prototype.setReadOnly):

  • inspector/front-end/inspector.html:
5:31 AM Changeset in webkit [99409] by andreas.kling@nokia.com
  • 10 edits in trunk/Source/WebCore

CSSValue: Devirtualize cssValueType().
<​http://webkit.org/b/71667>

Reviewed by Antti Koivisto.

Keep the cssValueType in a CSSValue member instead of using
virtual functions.

This is part of a project to completely devirtualize CSSValue
<​http://webkit.org/b/71666> and will incur a temporary object
size regression for CSSValue while the work is ongoing.

  • css/CSSInheritedValue.cpp:
  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::CSSInheritedValue):

  • css/CSSInitialValue.cpp:
  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:
  • css/CSSValue.h:

(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:
5:22 AM Changeset in webkit [99408] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: introduce UserAgent override setting.
​https://bugs.webkit.org/show_bug.cgi?id=71627

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::setUserAgentOverride):

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype._onBlur):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkManager.prototype._userAgentSettingChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get for):
(WebInspector.SettingsScreen.prototype._createCustomSetting):
(WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged):

  • inspector/front-end/helpScreen.css:

(.help-table td):
(.help-content fieldset label):

4:50 AM Changeset in webkit [99407] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: autocomplete combobox for Styles sidebar and Console.
​https://bugs.webkit.org/show_bug.cgi?id=65511

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):
():

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestBoxEnabled):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPromptWithHistory):

  • inspector/front-end/inspector.css:

(.suggest-box.generic-suggest):
(.suggest-box.generic-suggest.above-anchor):
(.suggest-box.generic-suggest .content):

4:44 AM Changeset in webkit [99406] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK flaky tests clean-up. Moved most of them to
test_expectations.

  • platform/gtk/Skipped:
  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/gtk/test_expectations.txt:
4:19 AM Changeset in webkit [99405] by pfeldman@chromium.org
  • 8 edits
    4 adds in trunk

Web Inspector: split script-formatter test into multiple tests.
​https://bugs.webkit.org/show_bug.cgi?id=71607

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2011-11-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/debugger/script-formatter-breakpoints.html

inspector/debugger/script-formatter-console.html

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._removeSourceFrame):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
  • inspector/debugger/script-formatter-breakpoints.html: Added.
  • inspector/debugger/script-formatter-console-expected.txt: Added.
  • inspector/debugger/script-formatter-console.html: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:46 AM Changeset in webkit [99404] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.

  • platform/gtk/Skipped:
3:39 AM Changeset in webkit [99403] by keishi@webkit.org
  • 17 edits in trunk

Change ColorChooser from singleton to ordinary object
​https://bugs.webkit.org/show_bug.cgi?id=71644

Reviewed by Kent Tamura.

Source/WebCore:

Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.

  • WebCore.exp.in:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
(WebCore::ColorInputType::handleDOMActivateEvent):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
(WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.

  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::selectColorInColorChooser):

  • html/HTMLInputElement.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.cpp:

(WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::Chrome::setSelectedColorInColorChooser): Ditto.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp:

(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
(WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
(WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
(WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
(WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup

  • platform/ColorChooser.h:

(WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
(WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.

  • testing/Internals.h:
  • testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.

LayoutTests:

  • fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
2:51 AM Changeset in webkit [99402] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Cannot edit elements commented with <!--
​https://bugs.webkit.org/show_bug.cgi?id=71357

Patch by Alexander Pavlov <​apavlov@chromium.org> on 2011-11-07
Reviewed by Pavel Feldman.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
2:03 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
1:59 AM Changeset in webkit [99401] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: Cannot edit elements commented with <!--
​https://bugs.webkit.org/show_bug.cgi?id=71357

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
1:26 AM Changeset in webkit [99400] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features.

  • platform/gtk/Skipped:
12:48 AM Changeset in webkit [99399] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark two tests as flaky. Remove some obsolete expectations.

12:09 AM Changeset in webkit [99398] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/events/platform-wheelevent-paging on GTK
because this platform does not support a paging mouse wheel event.

  • platform/gtk/Skipped:

Nov 6, 2011:

11:18 PM Changeset in webkit [99397] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix some style issues in ImageBuffer.h
​https://bugs.webkit.org/show_bug.cgi?id=71649

Reviewed by Kent Tamura.

No new tests. Style change only.

  • platform/graphics/ImageBuffer.h:
10:48 PM Changeset in webkit [99396] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Skip new failing test.
​https://bugs.webkit.org/show_bug.cgi?id=71022

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-06
Reviewed by Martin Robinson.

  • platform/gtk/Skipped:
10:27 PM Changeset in webkit [99395] by keishi@webkit.org
  • 13 edits in trunk/Source/WebCore

InputType::fallbackValue and defaultValue should be const
​https://bugs.webkit.org/show_bug.cgi?id=71641

Reviewed by Kent Tamura.

Changing InputType::fallbackValue and defaultValue to const. Also adding OVERRIDE.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::fallbackValue):

  • html/BaseCheckableInputType.h:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::fallbackValue):

  • html/ColorInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::fallbackValue):
(WebCore::InputType::defaultValue):

  • html/InputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::fallbackValue):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::defaultValue):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::defaultValue):

  • html/SubmitInputType.h:
7:17 PM Changeset in webkit [99394] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

fast/events/platform-wheelevent-paging-{x,y,xy}-in-scrolling-page.html fails on chromium-cg-mac.

7:13 PM Changeset in webkit [99393] by rniwa@webkit.org
  • 3 edits
    4 copies in branches/chromium/912

Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com
​https://bugs.webkit.org/show_bug.cgi?id=71203

Reviewed by Ojan Vafai.

Source/WebCore:

Remove the transparent background color from inline style declarations in the pasted content.
Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style
declarations even if those properties were overridden.

Tests: editing/deleting/merge-paragraphs-with-transparent-background.html

editing/deleting/paste-with-transparent-background-color.html

  • editing/EditingStyle.cpp:

(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):

LayoutTests:

Added a test to merge paragraphs inside a document with background: transparent, and a test to
cut and paste contents with background: transparent, which is overriding a style rule background: blue.

WebKit should preserve the appearance of the pasted content but should not add a redundant
background: transparent.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added.
  • editing/deleting/merge-paragraphs-with-transparent-background.html: Added.
  • editing/deleting/paste-with-transparent-background-color-expected.txt: Added.
  • editing/deleting/paste-with-transparent-background-color.html: Added.

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/8493001

6:51 PM Changeset in webkit [99392] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r99374): GTK+ build of the jsc binary doesn't like the call
to initializeMainThread, and crashes
​https://bugs.webkit.org/show_bug.cgi?id=71643

Reviewed by Sam Weinig.

  • jsc.cpp:

(main):

6:34 PM Changeset in webkit [99391] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove ColorInputType::handleClickEvent
​https://bugs.webkit.org/show_bug.cgi?id=71640

Reviewed by Kent Tamura.

When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.

  • html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
  • html/ColorInputType.h: Removed ColorInputType::handleClickEvent
6:25 PM Changeset in webkit [99390] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove extra semicolon in ColorInputType
​https://bugs.webkit.org/show_bug.cgi?id=71639

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

6:07 PM Changeset in webkit [99389] by dominicc@chromium.org
  • 10 edits in trunk

Remove initBeforeLoadEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71636

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/Window/window-properties.html

  • dom/BeforeLoadEvent.h:
  • dom/BeforeLoadEvent.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
4:42 PM Changeset in webkit [99388] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests for autocorrection panel on Chromium port since
Chromium Mac port doesn't support autocorrection panel.

The failure was tracked by the Chromium issue 58254 (​http://crbug.com/58254).

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [99387] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

editing/input/scroll-viewport-page-up-down.html is very flaky on chromium win release
​https://bugs.webkit.org/show_bug.cgi?id=59642

Unreviewed; remove the failing test expectation since we can no longer observe the said failure.

  • platform/chromium/test_expectations.txt:
2:52 PM Changeset in webkit [99386] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't crash when a context hasn't been created. This fixed a
testing-only crash on the bots in the Chromium port.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

2:45 PM Changeset in webkit [99385] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed trivial fix after build system refactoring.

  • Scripts/run-qtwebkit-tests: Fix qml_import_path.
2:27 PM Changeset in webkit [99384] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=71260

Reviewed by Mark Rowe.

Memory leak fix covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.

1:31 PM Changeset in webkit [99383] by abarth@webkit.org
  • 4 edits
    8 adds in trunk

Implement the sandbox directive for CSP
​https://bugs.webkit.org/show_bug.cgi?id=71604

Reviewed by Sam Weinig.

Source/WebCore:

At TPAC, Microsoft was pushing pretty hard to add the sandbox directive
to CSP. There's a question about whether it's going to be in CSP 1.0
or CSP 1.1, but it seems to be clearly headed into the spec.

This patch implements the sandbox directive for CSP. It's built on the
same machinery we use for the sandbox attribute for iframe. Now that
I've done the implementation, I'm going to write up some concrete text
for the spec.

Tests: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html
http/tests/security/contentSecurityPolicy/sandbox-empty.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
(WebCore::ContentSecurityPolicy::addDirective):

  • page/ContentSecurityPolicy.h:

LayoutTests:

Test that the sandbox directive correctly wires up to the sandbox
flags. Also, test that the policy inherits into subframes. These are
essentially integration tests between the CSP and sandbox subsystems,
which is why they don't cover all the permutations of the sandbox
flags. Those are covered in more detail via tests of the sandbox
attribute.

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-empty.html: Added.
1:29 PM Changeset in webkit [99382] by weinig@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Add space missing from some class declarations
​https://bugs.webkit.org/show_bug.cgi?id=71632

Reviewed by Anders Carlsson.

  • assembler/AssemblerBufferWithConstantPool.h:
  • bytecode/CodeBlock.h:
  • dfg/DFGVariableAccessData.h:
  • heap/VTableSpectrum.h:
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • wtf/MetaAllocatorHandle.h:
  • wtf/UnionFind.h:
1:01 PM Changeset in webkit [99381] by eric@webkit.org
  • 3 edits in trunk/Tools

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
​https://bugs.webkit.org/show_bug.cgi?id=66078

Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:00 PM Changeset in webkit [99380] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a crash expectation for platform/mac/accessibility/select-element-selection-with-optgroups.html on Mac.
The failure is tracked by the bug 71421.

  • platform/mac/test_expectations.txt:
12:49 PM Changeset in webkit [99379] by eric@webkit.org
  • 2 edits in trunk/Tools

Split chunk handling out of prepare_lists_and_print_output to make it more readable
​https://bugs.webkit.org/show_bug.cgi?id=71629

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
12:38 PM Changeset in webkit [99378] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Allow use of FINAL in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=71630

Reviewed by Anders Carlsson.

  • Configurations/Base.xcconfig:

Don't warn about C++11 extensions used in C++98 mode.

11:48 AM Changeset in webkit [99377] by eric@webkit.org
  • 6 edits in trunk/Tools

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
​https://bugs.webkit.org/show_bug.cgi?id=66078

Reviewed by Adam Barth.

The runtime feature detection was fixed to work in bug 64472.
In this bug I moved the symbol-based feature detection from
popen() to Executive.run_command and cleaned up the callers
and unittests to make sure that we're correctly parsing the
nm output correctly. The old code happened to work even though
the runtime-features path was using "str in list" and the
symbol features path was using "str in str" and it just happened
to do what we wanted to. Now runtime features and symbol feature
blacklists are computed separately (and with better documentation).

This system remains confusing, partially because these are black-lists
which are amended to whatever static blacklist may exist for the
port as part of a Skipped list file.

For example, notice how the runtime feature list only has directory
blacklists for a couple features. If all features are off,
how do we skip enough tests with only 2 entries in the blacklist map?
The answer is that Windows is the only port to use runtime feature
detection, and the win/Skipped file turns off all the other features
statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
which use symbol-based feature detection turn of mathml, wcss, etc
using the blacklists found in _missing_symbol_to_skipped_tests.

I also noticed a couple places where we still referenced xhtmlmp
even though support for such has been removed from WebKit. Removed those.

This should result in no functional change.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
    • Use self._filesystem instead of os.path
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
9:22 AM Changeset in webkit [99376] by mitz@apple.com
  • 2 edits in trunk/Tools

Made show-pretty-diff work when the input path contains spaces.

Reviewed by Anders Carlsson.

  • Scripts/show-pretty-diff:
3:54 AM Changeset in webkit [99375] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Value profiling should just use two buckets
​https://bugs.webkit.org/show_bug.cgi?id=71619

Reviewed by Gavin Barraclough.

Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/ValueProfile.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Heuristics.cpp:

(JSC::Heuristics::initializeHeuristics):

  • runtime/Heuristics.h:
3:39 AM Changeset in webkit [99374] by fpizlo@apple.com
  • 18 edits
    3 adds in trunk/Source

JSC should be able to sample itself in a more flexible way than just sampling flags
​https://bugs.webkit.org/show_bug.cgi?id=71522

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Added a construct that looks like SamplingRegion samplingRegion("name").

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/VTableSpectrum.cpp:

(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):

  • heap/VTableSpectrum.h:
  • jsc.cpp:

(main):
(runWithScripts):

  • parser/Parser.h:

(JSC::parse):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/Platform.h:
  • wtf/Spectrum.h: Added.

(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):

  • wtf/wtf.pri:

Source/JavaScriptGlue:

Reviewed by Gavin Barraclough.

  • ForwardingHeaders/wtf/Spectrum.h: Added.

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, since no functionality changed.

  • ForwardingHeaders/wtf/Spectrum.h: Added.
3:04 AM Changeset in webkit [99373] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip paged wheel events for Qt, as we don't support them yet.

  • platform/qt/Skipped:

Nov 6, 2011:

12:23 AM Changeset in webkit [99372] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Unindent edited text by pressing Shift + Tab
​https://bugs.webkit.org/show_bug.cgi?id=70181

Indent and unindent text in all selected lines.

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2011-11-06
Reviewed by Pavel Feldman.

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype.unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype.unindentLines):

Nov 5, 2011:

11:10 PM Changeset in webkit [99371] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip a newly failing test and reclassify some missing DRT features.

  • platform/gtk/Skipped: Update skipped list.
10:33 PM Changeset in webkit [99370] by Martin Robinson
  • 4 edits
    2 deletes in trunk/Source/WebCore

Remove ContextShadow
​https://bugs.webkit.org/show_bug.cgi?id=71617

Reviewed by Ariya Hidayat.

No new tests. This patch does not change behavior.

Completely remove ContextShadow. It's unused, unmaintained, and
replaced by ShadowBlur.

  • WebCore.gypi: Remove references to deleted files.
  • WebCore.vcproj/WebCore.vcproj: Remove references to deleted files.
  • platform/graphics/ContextShadow.cpp: Removed.
  • platform/graphics/ContextShadow.h: Removed.
  • platform/gtk/WidgetRenderingContext.cpp: Remove now-inaccurate TODO.
9:27 PM Changeset in webkit [99369] by jonlee@apple.com
  • 6 edits in trunk/Source/WebCore

Dragging a file onto <input type="file"> should give distinct visual feedback
​https://bugs.webkit.org/show_bug.cgi?id=13897
<rdar://problem/5232483>

Reviewed by Dan Bernstein.

When hovering over a file input element, we set the button's state to active
to differentiate dragging one file over the input element (which populates that
element) versus over the document (which would load the file into the view).

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::canReceiveDroppedFiles):
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): If set, the element
is updated, which sets the active state on the button control.

  • html/HTMLInputElement.h: Add a boolean member representing whether the file

input can receive dropped files.

  • page/DragController.cpp:

(WebCore::DragController::DragController): Update/set the file input that
can receive dropped files.
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

  • page/DragController.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Sets the button active
state if the input can receive dropped files.

9:14 PM Changeset in webkit [99368] by dcheng@chromium.org
  • 6 edits in trunk

[chromium] Use the security origin instead of the URL when checking notification permissions
​https://bugs.webkit.org/show_bug.cgi?id=71590

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::checkPermission):

Tools:

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::checkPermission):

  • DumpRenderTree/chromium/NotificationPresenter.h:
7:26 PM Changeset in webkit [99367] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Improve pending resource hash table code, including fixing a memory leak
​https://bugs.webkit.org/show_bug.cgi?id=71616

Reviewed by Adam Roben.

Memory leak fix and refactoring covered by existing tests.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource): Replace the combination
of contains, get, and add with just add, removing an extra unneeded hash table
lookup each time this function is called.
(WebCore::SVGDocumentExtensions::isElementInPendingResources): Added a comment
about the performance of this function. Removed unnecessary check for an empty
map; the code already efficiently exits doing nothing without the check.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): Removed
unnecessary check for an empty map; the code already efficiently does nothing
without the check. Use removePendingResource rather than calling remove to
avoid leaking the SVGPendingElements set.
(WebCore::SVGDocumentExtensions::removePendingResource): Replace the
combination of get and remove with a call to take, removing an extra
unneeded hash table lookup each time this function is called

6:07 PM Changeset in webkit [99366] by Darin Adler
  • 2 edits in trunk/Tools

Fix a small leak in Mac version of LayoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=71615

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
(LayoutTestController::localStorageDiskUsageForOrigin): Ditto.

5:56 PM Changeset in webkit [99365] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Unskip some tests on GTK+ that seem to be passing.

  • platform/gtk/Skipped: Unskip tests.
5:50 PM Changeset in webkit [99364] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Actually use the user_data arguments to gio async functions
instead of using g_object_set_data() to basically reinvent them.
​https://bugs.webkit.org/show_bug.cgi?id=71614

Patch by Dan Winship <​danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startNonHTTPRequest):

5:39 PM Changeset in webkit [99363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Don't unnecessarily 0-initialize read buffers.
​https://bugs.webkit.org/show_bug.cgi?id=71612

Patch by Dan Winship <​danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):

5:37 PM Changeset in webkit [99362] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove a bit of dead code
​https://bugs.webkit.org/show_bug.cgi?id=71613

Patch by Dan Winship <​danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::readCallback): the caller that needed the convertToUTF16
code was removed in r77408, but the code was accidentally left
behind.

5:34 PM Changeset in webkit [99361] by Martin Robinson
  • 20 edits in trunk/LayoutTests

[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
​https://bugs.webkit.org/show_bug.cgi?id=71576

Reviewed by Antonio Gomes.

Instead of waiting until <body onload> to toggle the frame flattening
setting. Toggle is as soon as possible. This fixes an issue where
layouts that happen before the onload event lead to flaky results.

  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/iframe-flattening-fixed-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width.html:
  • fast/frames/flattening/iframe-flattening-nested.html:
  • fast/frames/flattening/iframe-flattening-offscreen.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
  • fast/frames/flattening/iframe-flattening-out-of-view.html:
  • fast/frames/flattening/iframe-flattening-selection-crash.html:
  • fast/frames/flattening/iframe-flattening-simple.html:
  • platform/gtk/Skipped: Unskip tests which are no longer flaky.
4:45 PM Changeset in webkit [99360] by Martin Robinson
  • 2 edits in trunk/LayoutTests

[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
​https://bugs.webkit.org/show_bug.cgi?id=71576

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-11-05
Reviewed by Martin Robinson.

Skip frame flattening tests. These became flaky after backing store for
painting was introduced for the GTK port in r98827.

  • platform/gtk/Skipped:
2:55 PM Changeset in webkit [99359] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactor sandbox flag calculation to make implementing CSP sandbox directive easier
​https://bugs.webkit.org/show_bug.cgi?id=71603

Reviewed by Sam Weinig.

This patch changes the way we compute sandbox bits. Instead of caching
the result on Frame, we always compute the sandbox bits for a new
document fresh from the inputs to the process (the sandbox attribute
and the forced sandbox flags).

This patch is just refactoring. It shouldn't have an observable
effects. This patch makes it easier to implement CSP's sandbox
directive in a subsequent patch.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::setSandboxFlags):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::effectiveSandboxFlags):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::forceSandboxFlags):

1:37 PM Changeset in webkit [99358] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

1:29 PM Changeset in webkit [99357] by weinig@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Reduce the number of putWithAttributes
​https://bugs.webkit.org/show_bug.cgi?id=71597

Reviewed by Adam Roben.

Remove exports of removed functions.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.

  • runtime/JSObject.cpp:

(JSC::JSObject::putWithAttributes):

  • runtime/JSObject.h:

Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.

11:16 AM Changeset in webkit [99356] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Unskip a test on GTK+ that doesn't seem to be failing on the bots
or locally.

  • platform/gtk/Skipped: Unskip a test.
9:28 AM Changeset in webkit [99355] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

CSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
​https://bugs.webkit.org/show_bug.cgi?id=71609

Reviewed by Anders Carlsson.

Add a bool member to CSSStyleDeclaration that determines whether
it's a CSSMutableDeclaration.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::isMutableStyleDeclaration):

9:25 AM Changeset in webkit [99354] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Web Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
​https://bugs.webkit.org/show_bug.cgi?id=71608

Reviewed by Pavel Feldman.

Use CSSMutableStyleDeclaration::isInlineStyleDeclaration() instead
of doing the same checks manually.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

7:50 AM Changeset in webkit [99353] by Simon Hausmann
  • 2 edits
    1 delete in trunk/Source/WebCore

Reviewed by Andreas Kling.

Removed duplicated npruntime_internal.h from bindings/v8
in favour of the one from bridge/, which has a few more

​https://bugs.webkit.org/show_bug.cgi?id=45617

  • bindings/v8/npruntime_internal.h: Removed.
  • Target.pri: Removed strange occurence here.
5:15 AM Changeset in webkit [99352] by Simon Hausmann
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove empty and unused dom/PositionCreationFunctions.h header file
​https://bugs.webkit.org/show_bug.cgi?id=71552

Reviewed by Kenneth Rohde Christiansen.

The file is empty (0 bytes) and not used anywhere. It was added in
2009 in r48234 but hasn't been touched since then.

  • WebCore.gypi:
  • dom/PositionCreationFunctions.h: Removed.
12:00 AM Changeset in webkit [99351] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix assert after running tests in dumpAsText folders. See
​https://bugs.webkit.org/show_bug.cgi?id=71599 for discussion. This
patch reverts part of a slightly over-agressive refactoring in
​http://trac.webkit.org/changeset/99347.

  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):

Note: See TracTimeline for information about the timeline view.