Timeline



Nov 15, 2011:

11:51 PM Changeset in webkit [100416] by Alexandru Chiculita
  • 16 edits
    7 copies
    4 adds in trunk

[CSSShaders] Implement the style cached resources and computed style for the shader urls
​https://bugs.webkit.org/show_bug.cgi?id=72378

Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/filters/custom-filter-property-computed-style.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
(WebCore::CSSStyleSelector::styleShader):
(WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::cachedOrPendingShader):

  • css/WebKitCSSShaderValue.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::~CachedShader):

  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterOperation.h:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::filter):

  • rendering/style/StyleCachedShader.cpp:

(WebCore::StyleCachedShader::StyleCachedShader):
(WebCore::StyleCachedShader::cssValue):

  • rendering/style/StyleCachedShader.h:

(WebCore::StyleCachedShader::create):

  • rendering/style/StylePendingShader.h:

(WebCore::StylePendingShader::create):
(WebCore::StylePendingShader::cssValue):
(WebCore::StylePendingShader::cssShaderValue):
(WebCore::StylePendingShader::StylePendingShader):

  • rendering/style/StyleShader.h:

(WebCore::StyleShader::~StyleShader):
(WebCore::StyleShader::isCachedShader):
(WebCore::StyleShader::isPendingShader):
(WebCore::StyleShader::StyleShader):

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt: Added.
  • css3/filters/custom-filter-property-computed-style.html: Added.
  • css3/filters/script-tests/custom-filter-property-computed-style.js: Added.

(jsWrapperClass):
(expression):
(description):

11:48 PM Changeset in webkit [100415] by jamesr@google.com
  • 2 edits
    1 copy
    11 moves
    17 adds
    3 deletes in trunk/LayoutTests

[chromium] Update chromium mac compositing baselines
​https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
  • platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
  • platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
  • platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
  • platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/test_expectations.txt:
11:47 PM Changeset in webkit [100414] by Carlos Garcia Campos
  • 10 edits
    2 adds in trunk/Source/WebKit2

[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.

(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):

  • UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadRequest):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadRequest):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h:
11:24 PM Changeset in webkit [100413] by sergio@webkit.org
  • 5 edits in trunk

[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
​https://bugs.webkit.org/show_bug.cgi?id=69510

Reviewed by Simon Fraser.

Source/WebCore:

End the current transparency layer before early returning from
paintMask() when there is a maskBoxImage which is still being
loaded. This will balance the previous call to
beginTransparencyLayer().

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintMask):

LayoutTests:

Unskipped tests that are now passing.

  • platform/gtk/Skipped:
  • platform/gtk-wk2/Skipped:
11:23 PM Changeset in webkit [100412] by Csaba Osztrogonác
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r100375 and r100385.
​http://trac.webkit.org/changeset/100375
​http://trac.webkit.org/changeset/100385
​https://bugs.webkit.org/show_bug.cgi?id=72465

They broke 32 bit builds on Qt (Requested by ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

  • runtime/ArgList.h:

(JSC::ArgList::ArgList):

  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSGlobalObject.h:
11:19 PM Changeset in webkit [100411] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Land specific expectations for compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium/test_expectations.txt:
11:09 PM Changeset in webkit [100410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
is inactive.
​https://bugs.webkit.org/show_bug.cgi?id=70407

Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly.

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-11-15
Reviewed by Noam Rosenthal.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::markForSync):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::markForSync):

  • WebCoreSupport/PageClientQt.h:

(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

10:46 PM Changeset in webkit [100409] by Darin Adler
  • 2 edits in trunk/Tools

DRT's uiElementAttributeValueCallback function is leaky
​https://bugs.webkit.org/show_bug.cgi?id=72453

Reviewed by Dan Bernstein.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

10:46 PM Changeset in webkit [100408] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Incorrect type checks in RenderTheme media code
​https://bugs.webkit.org/show_bug.cgi?id=72184

Reviewed by Eric Carlson.

No tests added. Ideally this patch should be revised to add tests!

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
(WebCore::AccessibilityMediaControl::controlType): Ditto.
(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
rather than an assertion to check type of input element.

  • html/shadow/MediaControlElements.cpp:

(WebCore::mediaControlElementType): Added. A type-safe way to get the
media control element type after checking isMediaControlElement but with
no other assumptions.

  • html/shadow/MediaControlElements.h: Added mediaControlElementType.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
use mediaControlElementType.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
redundant null check.
(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.

10:41 PM Changeset in webkit [100407] by rniwa@webkit.org
  • 6 edits
    2 adds
    1 delete in trunk/Tools

Implement edit-distance based reviewer recognition algorithm
​https://bugs.webkit.org/show_bug.cgi?id=72351

Reviewed by Eric Seidel.

Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
"build fix" to a reviewer's name (e.g. with with edit distance 9).

This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
the edit distance is implemented in edit_distance.py.

Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/common/editdistance.py: Added.
  • Scripts/webkitpy/common/editdistance_unittest.py: Added.
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
10:21 PM Changeset in webkit [100406] by staikos@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove the guard page from the addressable stack region on QNX.
​https://bugs.webkit.org/show_bug.cgi?id=72455

Reviewed by Daniel Bates.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

10:06 PM Changeset in webkit [100405] by msaboff@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=72323

Added 8 bit optimized paths for String and UString ascii() and utf8() methods.

Added String::characters8(), characters16() and is8Bit() helper methods.

Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().

Reviewed by Geoff Garen.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp:

(JSC::UString::utf8):

  • wtf/text/WTFString.cpp:

(WTF::String::ascii):
(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):

  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertLatin1ToUTF8):

  • wtf/unicode/UTF8.h:
  • wtf/unicode/Unicode.h:
9:46 PM Changeset in webkit [100404] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove expected PASS expectations for compositing tests.

This will result in a temporary spike in the number of unexpected
PASSes reported by the bots, but will allow me to add specific
expectations for all the compositing tests instead of the current
blanket PASS FAIL line.

  • platform/chromium/test_expectations.txt:
9:40 PM Changeset in webkit [100403] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove failing expectations from various JS tests that now pass.

  • platform/chromium/test_expectations.txt:
9:33 PM Changeset in webkit [100402] by annacc@chromium.org
  • 4 edits in trunk/LayoutTests

Make sure both the video and the track are ready to be tested before testing.
​https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Eric Carlson.

  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
9:12 PM Changeset in webkit [100401] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
​https://bugs.webkit.org/show_bug.cgi?id=72423

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::setDrawingBuffer):

9:10 PM Changeset in webkit [100400] by mhahnenberg@apple.com
  • 13 edits in trunk/Source/WebCore

Rebaseline generated WebCore bindings

Unreviewed build fix

No new tests.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::isObservable):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::clearImpl):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::isObservable):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::clearImpl):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::isObservable):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::isObservable):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

8:47 PM Changeset in webkit [100399] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
​https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

8:29 PM Changeset in webkit [100398] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/WebCore

JS DOM wrappers depend on destructor to deref impl RefPtrs
​https://bugs.webkit.org/show_bug.cgi?id=72341

Reviewed by Sam Weinig.

No new tests.

Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default
wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

8:28 PM Changeset in webkit [100397] by tony@chromium.org
  • 2 edits in trunk/Tools

Skip a failing webkitpy test on cygwin.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
8:17 PM Changeset in webkit [100396] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fix overlapping expectations
​https://bugs.webkit.org/show_bug.cgi?id=72458

  • platform/chromium/test_expectations.txt:
7:54 PM Changeset in webkit [100395] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Share Highlight Code for Drawing Outlined Quad
​https://bugs.webkit.org/show_bug.cgi?id=72451

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-15
Reviewed by Timothy Hatcher.

  • inspector/DOMNodeHighlighter.cpp:
7:18 PM Changeset in webkit [100394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100308.
​http://trac.webkit.org/changeset/100308
​https://bugs.webkit.org/show_bug.cgi?id=72450

Introduces WebGL conformance test regressions. (Requested by
twiz on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

7:06 PM Changeset in webkit [100393] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [100392] by jamesr@google.com
  • 9 edits
    1 move
    1 add
    7 deletes in trunk/Source/WebCore

Rollout ​http://trac.webkit.org/changeset/99813, caused some crashes in
TiledLayerChromium::updateCompositorResources()

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.

(WebCore::LayerTextureUpdaterCanvas::contentRect):
(WebCore::LayerTextureUpdaterBitmap::orientation):
(WebCore::LayerTextureUpdaterSkPicture::orientation):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
6:53 PM Changeset in webkit [100391] by Darin Adler
  • 5 edits in trunk/Source/JavaScriptCore

REGRESSION (r98887): ParserArena and Keywords leaking
​https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
6:51 PM Changeset in webkit [100390] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix overlapping expectations on chromium mac

  • platform/chromium/test_expectations.txt:
6:49 PM Changeset in webkit [100389] by jchaffraix@webkit.org
  • 10 edits in trunk

Add the needed plumbing to parse display: -webkit-inline-grid
​https://bugs.webkit.org/show_bug.cgi?id=72438

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added the needed constants and plugged everything together.
Again we treat display: -webkit-inline-grid like display: none
for the moment.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Integrated testing for display: -webkit-inline-grid into the existing test.

  • fast/css-grid-layout/display-grid-set-get-expected.txt:
  • fast/css-grid-layout/display-grid-set-get.html:
  • fast/css-grid-layout/resources/display-grid-set-get.js:
6:38 PM Changeset in webkit [100388] by wjmaclean@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
​https://bugs.webkit.org/show_bug.cgi?id=72162

Reviewed by Kenneth Russell.

Refactoring of existing functionality, so uses existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

6:13 PM Changeset in webkit [100387] by pkasting@chromium.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r100340.
​http://trac.webkit.org/changeset/100340
​https://bugs.webkit.org/show_bug.cgi?id=72448

Caused assertion failure in Win dbg canary. (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
6:03 PM Changeset in webkit [100386] by jchaffraix@webkit.org
  • 12 edits in trunk/Source/WebCore

Switch table indexing to unsigned
​https://bugs.webkit.org/show_bug.cgi?id=72083

Reviewed by Darin Adler.

No expected change in behavior.

All of the code is now using unsigned for indexing!

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::colElement):
(WebCore::RenderTable::cellAbove):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):
Added some ASSERTs to make sure we don't underflow. Looking at how
the different variables are populated, they should not be reached.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Those 2 functions promotes HTMLTableCellElement's int to unsigned
which should be fine as we make sure their are positive. Also HTML5
makes those 2 fields "unsigned long" which goes in the same direction.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):
Rewrote a couple of reverse iterating to be able to use unsigned
without overflowing.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):

  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
(WebCore::RenderTable::recalcSections):

  • rendering/RenderTable.h:

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::spanOfEffCol):
(WebCore::RenderTable::effColToCol):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::CollapsedBorders::nextBorder):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::updateFromElement):

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::span):
(WebCore::RenderTableCol::setSpan):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::appendColumn):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
(WebCore::RenderTableSection::getBaseline):
Mechanical change int -> unsigned.

5:53 PM Changeset in webkit [100385] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

  • runtime/ArgList.h: Removed!
5:52 PM Changeset in webkit [100384] by aestes@apple.com
  • 10 edits
    4 adds in trunk/Source

Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
​https://bugs.webkit.org/show_bug.cgi?id=72106

Reviewed by Anders Carlsson.

Source/WebCore:

Add a class that encapsulates the logic of scheduling, enabling and
invalidating a run loop observer that fires before Core Animation's
commit observer. Clients can subclass LayerFlushSchedulerClient and
implement flushLayers(), which will be called by the observer.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/LayerFlushScheduler.cpp: Added.

(WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
invalidating the run loop observer. Keep a count of calls to suspend()
in m_suspendCount.
(WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
Install the run loop observer when it reaches 0.

  • platform/graphics/ca/LayerFlushSchedulerClient.h: Added.

(WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):

  • platform/graphics/ca/LayerFlushScheduler.h: Added.
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.

(LayerFlushScheduler::LayerFlushScheduler):
(LayerFlushScheduler::~LayerFlushScheduler):
(LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
the LayerFlushSchedulerClient.
(LayerFlushScheduler::schedule): Install the run loop observer.
(LayerFlushScheduler::invalidate): Remove the run loop
observer if it is installed.

Source/WebKit/mac:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebView/WebView.mm:

(-[WebView _close]): Invalidate the run loop observer and destroy the
LayerFlushController.
(LayerFlushController::flushLayers): Perform the work that
layerSyncRunLoopObserverCallBack used to do.
(-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
yet to be created, create it, then schedule a layer flush.

  • WebView/WebViewData.h:

(LayerFlushController::create): Create a LayerFlushController that
implements the LayerFlushSchedulerClient interface and contains a
LayerFlushScheduler with itself as the client.

  • WebView/WebViewData.mm:

(LayerFlushController::scheduleLayerFlush):
(LayerFlushController::invalidateObserver):
(LayerFlushController::LayerFlushController):

Source/WebKit2:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Replace

m_flushPendingLayerChangesRunLoopObserver with m_layerFlushScheduler
and implement the LayerFlushSchedulerClient interface.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Instantiate
m_layerFlushScheduler with the LayerTreeHost as the client.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Call LayerFlushScheduler::schedule().
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Call
LayerFlushScheduler::suspend() or LayerFlushScheduler::resume().
(WebKit::LayerTreeHostCAMac::invalidate): Call LayerFlushScheduler::invalidate().
(WebKit::LayerTreeHostCAMac::flushLayers): Do the work that
flushPendingLayerChangesRunLoopObserverCallback() used to do.
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush): Call LayerFlushScheduler::invalidate().

5:51 PM Changeset in webkit [100383] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Maybe the reason we're fiddling with line endings is that this file
didn't set svn:eol-style. Set it.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
5:47 PM Changeset in webkit [100382] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
5:43 PM Changeset in webkit [100381] by dslomov@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
until ​https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
5:41 PM Changeset in webkit [100380] by weinig@apple.com
  • 7 edits in trunk/Tools

TestWebKitAPI should not put its resources in the root products directory
​https://bugs.webkit.org/show_bug.cgi?id=72446

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Change the copy resources phase to place the resources in a TestWebKitAPI.resources
directory.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F):

  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::url):

  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::url):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::createURLForResource):
Update calls to retrieve files from the bundle to look in the newly
created subdirectory.

5:36 PM Changeset in webkit [100379] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r100289

Unreviewed.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings
5:35 PM Changeset in webkit [100378] by weinig@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
​https://bugs.webkit.org/show_bug.cgi?id=72433

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetConnectionClient):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeConnectionClient):

  • UIProcess/WebContext.h:

Add connection client API.

  • UIProcess/WebContextConnectionClient.cpp: Added.

(WebKit::WebContextConnectionClient::didCreateConnection):

  • UIProcess/WebContextConnectionClient.h: Added.

Add basic implementation of the client. It is currently never triggered.

5:29 PM Changeset in webkit [100377] by tony@chromium.org
  • 2 edits in trunk/Tools

Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5:27 PM Changeset in webkit [100376] by adamk@chromium.org
  • 3 edits
    1 add
    3 deletes in trunk

[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
​https://bugs.webkit.org/show_bug.cgi?id=72432

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):

LayoutTests:

Updated test that depends on the error message. The new message is a
strict improvement, as it includes the line number at which the
too-deep call was triggered. Also, we only expect a single error
message; it's not clear why the previous version generated a dup.

Also consolidate expectations, as the test does not differ per platform.

  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
5:25 PM Changeset in webkit [100375] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use new API.

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.

  • runtime/ArgList.h: Removed constructor that took a forward-contiguous

set of arguments.

  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSGlobalObject.h:

(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.

5:23 PM Changeset in webkit [100374] by tony@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, fix test-webkitpy tests. Move the check for image results
earlier.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:06 PM Changeset in webkit [100373] by scheib@chromium.org
  • 4 edits in trunk/Source/WebCore

Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
​https://bugs.webkit.org/show_bug.cgi?id=72431

Reviewed by Adam Barth.

  • page/PointerLock.cpp:

(WebCore::PointerLock::lock):
(WebCore::PointerLock::unlock):
(WebCore::PointerLock::isLocked):

  • page/PointerLock.h:
  • page/PointerLock.idl:
5:03 PM Changeset in webkit [100372] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/rendering

Converting table row height calculations back to ints and avoiding enclosingIntRect when outputting test expectations for table parts.

5:03 PM Changeset in webkit [100371] by oliver@apple.com
  • 652 edits
    148 adds
    85 deletes in branches/safari-534.54-branch

2011-11-15 Oliver Hunt <​oliver@apple.com>

Merged JavaScriptCore r92804-r99898.

Disabled thread verification on RefPtr, so as to minimise
changes needed by WebCore.

4:56 PM Changeset in webkit [100370] by nduca@chromium.org
  • 17 edits
    1 move
    5 deletes in trunk/Source

[chromium] Fuse MainThread and CCThread
​https://bugs.webkit.org/show_bug.cgi?id=72426

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCMainThread.cpp: Removed.
  • platform/graphics/chromium/cc/CCMainThread.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h: Removed.
  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::mainThread):
(WebCore::CCProxy::setImplThread):
(WebCore::CCProxy::implThread):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::~CCProxy):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScopedThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCScopedMainThreadProxy.h.

(WebCore::CCScopedThreadProxy::create):
(WebCore::CCScopedThreadProxy::postTask):
(WebCore::CCScopedThreadProxy::shutdown):
(WebCore::CCScopedThreadProxy::CCScopedThreadProxy):
(WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • src/CCMainThreadImpl.cpp: Removed.
  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::CCThreadImpl):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):
(WebKit::shutdown):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):

  • tests/CCThreadTest.cpp: Removed.
4:45 PM Changeset in webkit [100369] by arv@chromium.org
  • 8 edits in trunk/LayoutTests

JS Test Harness: Remove need to load external css file to reduce flakiness
​https://bugs.webkit.org/show_bug.cgi?id=72295

Reviewed by Ojan Vafai.

Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
pre-wrap the output was therefore different depending on this race condition. By changing this to use a
style element with the CSS inline there is no longer a race condition.

  • css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
  • fast/css/counters/counter-cssText.html: Ditto.
  • fast/css/counters/getCounterValue.html: Ditto.
  • fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
  • traversal/script-tests/exception-forwarding.js: Ditto.
  • fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
  • fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.
4:43 PM Changeset in webkit [100368] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
​https://bugs.webkit.org/show_bug.cgi?id=72444

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
4:40 PM Changeset in webkit [100367] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72269

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [100366] by scheib@chromium.org
  • 4 edits in trunk/Source/WebCore

Pointer Lock: Refactor: MouseEvent.idl movementX/Y
​https://bugs.webkit.org/show_bug.cgi?id=72427

  • [Conditional...] vs #if defined
  • Runtime enabled
  • .movementX/Y prefixed with 'webkit'

Reviewed by Adam Barth.

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):

4:29 PM Changeset in webkit [100365] by ojan@chromium.org
  • 4 edits
    4 adds in trunk

implement flex-align for flex-flow: column
​https://bugs.webkit.org/show_bug.cgi?id=70754

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-column.html

css3/flexbox/line-wrapping.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
This was just using the wrong, non-flow-aware method.

LayoutTests:

  • css3/flexbox/flex-align-column-expected.txt: Added.
  • css3/flexbox/flex-align-column.html: Added.

Tests the basic flex-align cases with column.

  • css3/flexbox/line-wrapping-expected.txt: Added.
  • css3/flexbox/line-wrapping.html: Added.

This tests that wrapping inside flexitems uses the correct width.
Notably, auto-sizing properly falls back on the initial containing block.

4:27 PM Changeset in webkit [100364] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark another test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:26 PM Changeset in webkit [100363] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
​https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

4:26 PM Changeset in webkit [100362] by commit-queue@webkit.org
  • 2 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
​https://bugs.webkit.org/show_bug.cgi?id=72235

Patch by Jongseok Yang <​js45.yang@samsung.com> on 2011-11-15
Reviewed by Gustavo Noronha Silva.

Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
It's required when using the soup network backend.
Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
EFL port use soup network backend without a network backend of their own.

  • GNUmakefile.am:
  • WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
  • WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

4:24 PM Changeset in webkit [100361] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

r100331 did not seem to commit precisely the right expectation.
​https://bugs.webkit.org/show_bug.cgi?id=72391

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
4:23 PM Changeset in webkit [100360] by jamesr@google.com
  • 2 edits
    610 deletes in trunk/LayoutTests

[chromium] Unreviewed expectations update for compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=72402

Remove now-unnecessary expectations for compositing tests in chromium-gpu* directories and update
test_expectations.txt to un-SKIP compositing tests. Compositing tests are still marked as PASS FAIL
in order to ensure they pass on all bots before turning them on.

File list removed due to length.

4:20 PM Changeset in webkit [100359] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
don't currently support DataTransferItems.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
4:17 PM Changeset in webkit [100358] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=72436

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [100357] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Chromium baselines after ​http://trac.webkit.org/changeset/100324.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:
4:04 PM Changeset in webkit [100356] by tony@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, better fix for ref tests failures on SL Intel bot.
Revert the previous change and return None if pixel results from
either the test page or the expected page is missing.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
4:02 PM Changeset in webkit [100355] by jamesr@google.com
  • 12 edits in trunk

[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
​https://bugs.webkit.org/show_bug.cgi?id=72402

Reviewed by Dirk Pranke.

Tools:

Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
the normal compositing triggers since we currently run the compositing tests in only one configuration - with
compositing enabled.

Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
patch should not impact any tests.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAcceleratedCompositingForVideoEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [100354] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [100353] by jochen@chromium.org
  • 19 edits in trunk/Source

Rename ReferrerPolicy to clarify its meaning
​https://bugs.webkit.org/show_bug.cgi?id=72420

Reviewed by Nate Chapin.

Source/WebCore:

On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
referrer wasn't necessarily send. On the other hand, I want to use the
name ReferrerPolicy when implementing the meta referrer tag.

No change in behavior expected so no test.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):
(WebCore::handleLinkClick):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadFrameRequest):

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

  • WebCore.exp.in: updated.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

Source/WebKit/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(openNewWindow):
(QWebPage::triggerAction):

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::linkClicked):

3:50 PM Changeset in webkit [100352] by tony@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3:46 PM Changeset in webkit [100351] by jchaffraix@webkit.org
  • 2 edits
    24 copies in branches/chromium/912

Merge 99752 - REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
​https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html

fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
fast/repaint/scroll-inside-table-cell.html
fast/repaint/scroll-relative-table-inside-table-cell.html
fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

  • rendering/RenderLayer.h:

Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • fast/repaint/scroll-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-inside-table-cell.html: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

TBR=​jchaffraix@webkit.org
Review URL: ​http://codereview.chromium.org/8520027

3:41 PM Changeset in webkit [100350] by tony@chromium.org
  • 2 edits in trunk/Tools

Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
3:40 PM Changeset in webkit [100349] by tony@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

set a max-width on the codereview overall comments textarea
​https://bugs.webkit.org/show_bug.cgi?id=72415

Reviewed by Ojan Vafai.

Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).

  • PrettyPatch/PrettyPatch.rb:
3:36 PM Changeset in webkit [100348] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/ChangeLog

rollout unneeded merge of 91147.

3:34 PM Changeset in webkit [100347] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Factor out V8Proxy's max recursion depth handling code
​https://bugs.webkit.org/show_bug.cgi?id=72422

Reviewed by Nate Chapin.

Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in ​http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.

No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.

3:29 PM Changeset in webkit [100346] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Skip failing ref tests on Qt.

  • platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and

fast/forms/file/file-input-reset.html are failing. See bugs.

3:27 PM Changeset in webkit [100345] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix windows build.

  • win/WebKit2Generated.make:
3:23 PM Changeset in webkit [100344] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark another test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
3:21 PM Changeset in webkit [100343] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
​https://bugs.webkit.org/show_bug.cgi?id=72419

Reviewed by Adam Roben.

Adopt the copied NSURLRequest.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::setStorageSession):

3:09 PM Changeset in webkit [100342] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/ChangeLog

Merged r91147.

3:08 PM Changeset in webkit [100341] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit/win

Merged r91145.

3:07 PM Changeset in webkit [100340] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Page/layer flashes after GPU-accelerated CSS transition
​https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <​jbates@google.com> on 2011-11-15
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
3:07 PM Changeset in webkit [100339] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r91140.

3:05 PM Changeset in webkit [100338] by jchaffraix@webkit.org
  • 14 edits
    5 adds in trunk

Add the needed plumbing to parse display: -webkit-grid
​https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

Added the new CSS value and plumbed the parsing and style application of
the new value.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

  • fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
  • fast/css-grid-layout/display-grid-set-get.html: Added.
  • fast/css-grid-layout/resources/display-grid-set-get.js: Added.

Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:

SKIP the css-grid-layout tests on all platforms for now.

3:01 PM Changeset in webkit [100337] by jamesr@google.com
  • 7 edits
    3 copies
    229 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-win into their correct locations.

File list omitted due to length.

3:01 PM Changeset in webkit [100336] by weinig@apple.com
  • 9 edits
    6 adds in trunk/Source/WebKit2

Add WebKit2 API object to represent a connection
​https://bugs.webkit.org/show_bug.cgi?id=72421

Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • Shared/API/c/WKBase.h:

Add type.

  • Shared/API/c/WKConnectionRef.cpp: Added.

(WKConnectionGetTypeID):
(WKConnectionSetConnectionClient):
(WKConnectionPostMessage):

  • Shared/API/c/WKConnectionRef.h: Added.

Expose interface. Currently no support for synchronous messages.

  • Shared/API/c/WKSharedAPICast.h:

Define relationship between WebConnection <-> WKConnectionRef.

  • Shared/APIObject.h:

Add API type.

  • Shared/WebConnection.cpp: Added.

(WebKit::WebConnection::~WebConnection):
(WebKit::WebConnection::initializeConnectionClient):

  • Shared/WebConnection.h: Added.

(WebKit::WebConnection::type):
Sketch out the connection object. It is currently abstract
to allow different implementations for the UI and WebProcess sides
while retaining the same interface.

  • Shared/WebConnectionClient.cpp: Added.

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

  • Shared/WebConnectionClient.h: Added.

Add simple client.

  • UIProcess/API/C/WebKit2.h:

Add new file.

3:00 PM Changeset in webkit [100335] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r91138.

2:59 PM Changeset in webkit [100334] by Lucas Forschler
  • 17 edits in branches/safari-534.53-branch/Source

Merged r91137.

2:53 PM Changeset in webkit [100333] by jamesr@google.com
  • 4 edits
    1 copy
    231 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-linux and chromium-mac into their correct locations.

File list omitted due to length.

2:52 PM Changeset in webkit [100332] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Merged r90954.

2:48 PM Changeset in webkit [100331] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100289.
​https://bugs.webkit.org/show_bug.cgi?id=72391

fast/dom/Orientation/create-event-orientationchange.html was updated but
the expected text was not.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
2:46 PM Changeset in webkit [100330] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Pixel result accidentally left out of ​http://trac.webkit.org/changeset/100324.

  • platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png:
2:43 PM Changeset in webkit [100329] by jamesr@google.com
  • 2 edits
    189 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectation shuffle.

Copy compositing expectations for chromium/ and chromium-cg-mac/ into their correct locations.

  • platform/chromium-cg-mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/chromium-cg-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/generated-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-cg-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-cg-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/iframes/resizer-expected.txt: Added.
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/chromium/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/chromium/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w.html: Added.
  • platform/chromium/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
2:38 PM Changeset in webkit [100328] by scheib@chromium.org
  • 5 edits
    3 moves in trunk/Source/WebCore

Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
​https://bugs.webkit.org/show_bug.cgi?id=72315

Reviewed by Dimitri Glazkov.

  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
  • page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.

(WebCore::PointerLock::PointerLock):
(WebCore::PointerLock::~PointerLock):
(WebCore::PointerLock::webkitLock):
(WebCore::PointerLock::webkitUnlock):
(WebCore::PointerLock::webkitIsLocked):

  • page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.

(WebCore::PointerLock::create):

  • page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.
2:36 PM Changeset in webkit [100327] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline mac pixel results for complex inner border change
​https://bugs.webkit.org/show_bug.cgi?id=72355

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • platform/mac/fast/borders/border-radius-complex-inner-expected.png: Added.
  • platform/mac/fast/borders/border-radius-different-width-001-expected.png:
2:30 PM Changeset in webkit [100326] by tony@chromium.org
  • 13 edits in trunk/Tools

[NRWT] Reftests should run even when pixel tests are disabled.
​https://bugs.webkit.org/show_bug.cgi?id=60605

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.

Also add an assert to make sure we get image hashes back when running ref tests.

  • Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
  • Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work

of starting a pixel driver if needed. It handles the logic of sending the test
to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2:29 PM Changeset in webkit [100325] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100283.
​https://bugs.webkit.org/show_bug.cgi?id=72137

We don't have a LION modifier, and I'm not sure why one test was only
skipped for SNOWLEOPARD RELEASE as it fails on Debug also.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [100324] by ojan@chromium.org
  • 3 edits
    4 adds in trunk

Overflow and relayout are broken in the new flexboxes
​https://bugs.webkit.org/show_bug.cgi?id=71161

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/auto-height-dynamic.html

css3/flexbox/flex-item-child-overflow-expected.html
css3/flexbox/flex-item-child-overflow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
-Always set the logical height to 0 to start with to ensure we don't
use the height from the previous layout when we are computing the
intrinsic size of the flexbox.
-Call computeOverflow after computeLogicalHeight so that flex-item's children's
overflow is properly rendered.

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
-Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
-Refactor flipping code. The behavior is the same, but the variable names are just
more correct.

LayoutTests:

  • css3/flexbox/auto-height-dynamic-expected.txt: Added.
  • css3/flexbox/auto-height-dynamic.html: Added.
  • css3/flexbox/flex-item-child-overflow-expected.html: Added.
  • css3/flexbox/flex-item-child-overflow.html: Added.
2:23 PM Changeset in webkit [100323] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue:
​https://bugs.webkit.org/show_bug.cgi?id=72344

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

2:22 PM Changeset in webkit [100322] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Properly bounding CSS lengths to AppUnit's bounds. Rounding instead of truncating offset values.

2:21 PM Changeset in webkit [100321] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source/WebCore

Merged r90925. needed for 93040.

2:19 PM Changeset in webkit [100320] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use MarkedArgumentBuffer to avoid making assumptions about argument order
​https://bugs.webkit.org/show_bug.cgi?id=72418

Reviewed by Sam Weinig.

A step toward reversing the argument order.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::callReviver): Don't assume that ArgList wants to point
at arguments in forward order. Instead, use MarkedArgumentBuffer, which
will make the decision for us.

2:17 PM Changeset in webkit [100319] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100276.
​https://bugs.webkit.org/show_bug.cgi?id=72270

Some lines were commented out to avoid expectation conflicts but this
erroneously removed an expectation that some tests would fail on the
Leopard (CG) bots.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
2:12 PM Changeset in webkit [100318] by commit-queue@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test
​https://bugs.webkit.org/show_bug.cgi?id=72410

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-15
Reviewed by Simon Fraser.

  • compositing/plugins/invalidate_rect-expected.txt: Renamed from LayoutTests/plugins/invalidate_rect-expected.txt.
  • compositing/plugins/invalidate_rect.html: Renamed from LayoutTests/plugins/invalidate_rect.html.
2:00 PM Changeset in webkit [100317] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] enable regions and exclusions tests, the compile flag was removed a long time ago
​https://bugs.webkit.org/show_bug.cgi?id=72395

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [100316] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering/svg

Have SVGRenderTreeAsText print pixel snapped coordinates and sizes for the root and container elements.

1:54 PM Changeset in webkit [100315] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG should distinguish between constants in the constant pool and weak
constants added as artifacts of code generation
​https://bugs.webkit.org/show_bug.cgi?id=72367

Reviewed by Geoff Garen.

Added the notion of a WeakJSConstant, which is like a JSConstant except that
it can only refer to JSCell*. Currently all WeakJSConstants are also backed
by constants in the constant pool, since weak references originated from
machine code are not yet properly handled.

Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant
and CheckStructure. This results in improved CSE, leading to a 1% win on V8.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::weakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::hasIdentifier):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:38 PM Changeset in webkit [100314] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Towards 8 bit Strings - Initial JS String Tuning
​https://bugs.webkit.org/show_bug.cgi?id=72326

Added 8 bit optimized paths for the methods below.

Reviewed by Geoffrey Garen.

  • runtime/JSString.h:

(JSC::jsSubstring8):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharCodeAt):

1:03 PM Changeset in webkit [100313] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests/SunSpider

Extend sunspider driver to be able to run kraken
​https://bugs.webkit.org/show_bug.cgi?id=71799

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-15
Reviewed by Filip Pizlo.

  • resources/sunspider-standalone-driver.js: Try to load a -data

file. If that succeeds, we have a kraken-like test, so we time
the test using load'. Otherwise fall back to using run'.

12:43 PM Changeset in webkit [100312] by commit-queue@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r100291.
​http://trac.webkit.org/changeset/100291
​https://bugs.webkit.org/show_bug.cgi?id=72403

For some unexpected reason the behavior is different across
platforms, causing test failures (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Removed.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Removed.
  • svg/custom/zero-path-square-cap-rendering3.svg: Removed.
12:40 PM Changeset in webkit [100311] by Nate Chapin
  • 28 edits
    4 deletes in trunk

Source/WebCore: CachedResourceRequest is now the only SubresourceLoaderClient
Merge CachedResourceRequest into SubresourceLoader and delete
the SubresourceLoaderClient interface. A few items were moved
to CachedResource instead of SubresourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::init): Do work that had previously been

done in SubresourceLoader::create() after the constructor.

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didSendData):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::didReceiveCachedMetadata):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::releaseResources): Do the cleanup work that was

duplicated throughout the various terminal CachedResourceRequest callbacks.

  • loader/SubresourceLoader.h: Fix indentation style issues.
  • loader/SubresourceLoaderClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load): Do the work that had been done in

CachedResourceRequest::load().

(WebCore::CachedResource::finish):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::stopLoading):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::canDelete):

  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceRequest.cpp: Removed.
  • loader/cache/CachedResourceRequest.h: Removed.
  • loader/cf/SubresourceLoaderCF.cpp:
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/SubresourceLoaderChromium.cpp:

LayoutTests: Test udpates for ​https://bugs.webkit.org/show_bug.cgi?id=71149.
The changes to SubresourceLoader slightly change the timings of
certain resource load callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • fast/loader/file-protocol-fragment-expected.txt:
  • platform/chromium-cg-mac/security/block-test-expected.txt:
  • platform/chromium-mac/security/block-test-expected.txt:
  • platform/chromium-win/security/block-test-expected.txt:
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
12:34 PM Changeset in webkit [100310] by barraclough@apple.com
  • 7 edits in trunk

Result of Error.prototype.toString not ES5 conformant
​https://bugs.webkit.org/show_bug.cgi?id=70889

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

LayoutTests:

  • fast/js/native-error-prototype-expected.txt:
  • fast/js/script-tests/native-error-prototype.js:
  • fast/js/script-tests/toString-recursion.js:
  • fast/js/toString-recursion-expected.txt:
12:25 PM Changeset in webkit [100309] by andersca@apple.com
  • 39 edits in trunk/Source

HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
​https://bugs.webkit.org/show_bug.cgi?id=72397

Reviewed by Dan Bernstein.

Source/WebCore:

screenToWindow and windowToScreen already use root view coordinates everywhere, with the
exception of Mac WebKit1 which doesn't even implement the functions.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::screenToRootView):
(WebCore::Chrome::rootViewToScreen):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::refresh):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenToRootView):
(WebKit::ChromeClientImpl::rootViewToScreen):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::screenToRootView):
(WebKit::WebPopupMenuImpl::rootViewToScreen):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::rootViewToScreen):
(WebCore::ChromeClientEfl::screenToRootView):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::rootViewToScreen):
(WebKit::ChromeClient::screenToRootView):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::screenToRootView):
(WebChromeClient::rootViewToScreen):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::rootViewToScreen):
(WebCore::ChromeClientQt::screenToRootView):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::rootViewToScreen):
(WebChromeClient::screenToRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::rootViewToScreen):
(WebKit::ChromeClientWinCE::screenToRootView):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::rootViewToScreen):
(WebCore::ChromeClientWx::screenToRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenToRootView):
(WebKit::WebChromeClient::rootViewToScreen):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:21 PM Changeset in webkit [100308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
​https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

12:13 PM Changeset in webkit [100307] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

Source/WebCore: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
​https://bugs.webkit.org/show_bug.cgi?id=70421

Patch by Eugene Nalimov <​enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object.
Before that there were no DOM objects that simultaneously were nodes and active objects.
DOM object could be held in one of 3 maps -- node map, active objects map, and all other
objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the
active DOM objects map only, its event listener could be garbage collected, because special
code that groups listeners with wrappers could handle only wrappers for objects in the node
map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be
garbage collected prematurely itself (see ​https://bugs.webkit.org/show_bug.cgi?id=66878).
Fix is to introduce 4th map -- active nodes map, and change the code accordingly.

Test: media/audio-garbage-collect.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GetDomMapFunction):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
(WebCore::DOMDataStore::weakNodeCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::activeDomNodeMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8GCController.cpp:

(WebCore::GCPrologueSpecialCase):
(WebCore::void):
(WebCore::Node):
(WebCore::GCPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::GCEpilogueHelper::GCEpilogueSpecialCase):
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcEpilogue):

  • dom/Node.h:

(WebCore::Node::isActiveNode):

  • html/HTMLAudioElement.h:

(WebCore::HTMLAudioElement::isActiveNode):

LayoutTests: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
​https://bugs.webkit.org/show_bug.cgi?id=70421 and ​https://bugs.webkit.org/show_bug.cgi?id=66878

Patch by Eugene Nalimov <​enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

  • media/audio-garbage-collect-expected.txt: Added.
  • media/audio-garbage-collect.html: Added.
12:05 PM Changeset in webkit [100306] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit/chromium

[Chromium] gamepad changes to the public interface of Chromium port
​https://bugs.webkit.org/show_bug.cgi?id=71518

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-15
Reviewed by Darin Fisher.

Adds stubs for Chromium port, and defines shared memory structure to
be used between browser and WebKit.

Includes just the parts that touch the public interface so they can be
reviewed separately. See also:
​https://bugs.webkit.org/show_bug.cgi?id=69451 and
​http://codereview.chromium.org/8345027

  • WebKit.gyp:
  • public/WebGamepad.h: Added.

(WebKit::WebGamepad::WebGamepad):

  • public/WebGamepads.h: Added.

(WebKit::WebGamepads::WebGamepads):

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::sampleGamepads):

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

11:58 AM Changeset in webkit [100305] by robert@webkit.org
  • 5 edits
    7 adds in trunk/LayoutTests

Mac results for r100177

Unreviewed gardening.

  • platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/mac/fast/table/multiple-captions-display-expected.txt:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
11:54 AM Changeset in webkit [100304] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening after r100289.

  • platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt:
11:49 AM Changeset in webkit [100303] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Make sure both the video and the track are ready to be tested before testing.
​https://bugs.webkit.org/show_bug.cgi?id=72399

Reviewed by Eric Carlson.

  • media/track/track-cues-seeking.html:
11:48 AM Changeset in webkit [100302] by leviw@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore

Fixing overloaded scrollbar painting methods on Mac

11:47 AM Changeset in webkit [100301] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Land chromium win results for flexbox repaint tests.
Still waiting on mac results.

  • platform/chromium-win/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:37 AM Changeset in webkit [100300] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Guarantee tests run in order.
​https://bugs.webkit.org/show_bug.cgi?id=72398

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc013-settings.html:
11:29 AM Changeset in webkit [100299] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Guarantee tests run in order.
​https://bugs.webkit.org/show_bug.cgi?id=72369

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc003-newlines.html:
  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [100298] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove useless const modifier from KURL::init
<​http://webkit.org/b/72387>

Reviewed by Darin Adler.

  • platform/KURL.cpp:

(WebCore::KURL::init): Remove useless const.

11:16 AM Changeset in webkit [100297] by tonyg@chromium.org
  • 6 edits in trunk/LayoutTests

editing/pasteboard/drag-drop-dead-frame.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72379

Reviewed by Adam Barth.

  • editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
  • platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
11:14 AM Changeset in webkit [100296] by annacc@chromium.org
  • 6 edits in trunk/LayoutTests

Change layout tests for cuechange, enter, and exit events to check the order
rather than the timing of the events (since actual timing can not be guaranteed).
​https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Tony Gentilcore.

  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [100295] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.3

New tag.

10:56 AM Changeset in webkit [100294] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

10:51 AM Changeset in webkit [100293] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merge 100022.

10:25 AM Changeset in webkit [100292] by tony@chromium.org
  • 8 edits in trunk/LayoutTests

enable new flexbox tests everywhere
​https://bugs.webkit.org/show_bug.cgi?id=72325

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:21 AM Changeset in webkit [100291] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

REGRESSION (r91125): Polyline tool in google docs is broken
​https://bugs.webkit.org/show_bug.cgi?id=65796

This adds test to ensure that the bug does not reappear unnoticed.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-15
Reviewed by Nikolas Zimmermann.

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
  • svg/custom/zero-path-square-cap-rendering3.svg: Added.
9:54 AM Changeset in webkit [100290] by andersca@apple.com
  • 40 edits in trunk/Source

HostWindow invalidation functions should use root view coordinates
​https://bugs.webkit.org/show_bug.cgi?id=72338

Reviewed by Dan Bernstein.

Source/WebCore:

Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
are in root view coordinates by changing contentsToWindow calls to contentsToRootView.

In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):

  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/chromium/FramelessScrollView.cpp:

(WebCore::FramelessScrollView::invalidateRect):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateRootView):
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::invalidateRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateRootView):
(WebCore::ChromeClientQt::invalidateContentsAndRootView):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::invalidateRootView):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateRootView):
(WebKit::WebChromeClient::invalidateContentsAndRootView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
9:52 AM Changeset in webkit [100289] by arv@chromium.org
  • 60 edits in trunk/LayoutTests

Fix invalid markup in some tests
​https://bugs.webkit.org/show_bug.cgi?id=72391

Reviewed by Ojan Vafai.

These tests had <div id="console"></p> in them which causes a lot of extra whitespace.

  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text.html:
  • fast/dom/HTMLElement/attr-dir-auto-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto.html:
  • fast/dom/HTMLElement/attr-dir-value-change-expected.txt:
  • fast/dom/HTMLElement/attr-dir-value-change.html:
  • fast/dom/HTMLElement/attr-empty-string-expected.txt:
  • fast/dom/HTMLElement/attr-empty-string.html:
  • fast/dom/HTMLElement/attr-false-string-expected.txt:
  • fast/dom/HTMLElement/attr-false-string.html:
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt:
  • fast/dom/HTMLElement/attr-invalid-string.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-false.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-true.html:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html:
  • fast/dom/HTMLElement/attr-missing-parent-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-false.html:
  • fast/dom/HTMLElement/attr-missing-parent-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-true.html:
  • fast/dom/HTMLElement/attr-true-string-expected.txt:
  • fast/dom/HTMLElement/attr-true-string.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon.html:
  • fast/dom/HTMLElement/set-false-expected.txt:
  • fast/dom/HTMLElement/set-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-true.html:
  • fast/dom/HTMLElement/set-invalid-value-expected.txt:
  • fast/dom/HTMLElement/set-invalid-value.html:
  • fast/dom/HTMLElement/set-true-expected.txt:
  • fast/dom/HTMLElement/set-true.html:
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive.html:
  • fast/dom/Orientation/create-event-orientationchange.html:
9:30 AM Changeset in webkit [100288] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
9:25 AM Changeset in webkit [100287] by ddkilzer@apple.com
  • 4 edits
    1 add in trunk/Tools

Don't use File::Slurp for run-leaks unit tests
<​http://webkit.org/b/72356>

Reviewed by Daniel Bates.

  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:

Extracted common package logic into RunLeaks.pm. Fixed call to
RunLeaks::parseLeaksOutput().

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
8:37 AM Changeset in webkit [100286] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Handle svn 1.7 when detecting whether a directory is in an svn checkout.
​https://bugs.webkit.org/show_bug.cgi?id=72349

Patch by Peter Kasting <​pkasting@google.com> on 2011-11-15
Reviewed by Adam Roben.

  • Scripts/VCSUtils.pm:

(isSVNDirectory):

8:32 AM Changeset in webkit [100285] by commit-queue@webkit.org
  • 8 edits
    9 adds
    1 delete in trunk

Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
​https://bugs.webkit.org/show_bug.cgi?id=61528

Patch by Philip Rogers <​pdr@google.com> on 2011-11-15
Reviewed by Stephen White.

Source/WebCore:

Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html

fast/canvas/2d.text.draw.fill.maxWidth.negative.html
fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.gradient.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/qt/Skipped:
  • resources/Ahem.ttf: Added.
8:24 AM Changeset in webkit [100284] by Carlos Garcia Campos
  • 8 edits in trunk/Source

[GTK] Implement download support in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72258

Reviewed by Martin Robinson.

Source/WebCore:

Add common download errors to ErrorsGtk.

  • platform/gtk/ErrorsGtk.cpp:

(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):

  • platform/gtk/ErrorsGtk.h:

Source/WebKit/gtk:

Use errors from WebCore to emit the error signals.

  • webkit/webkitdownload.cpp:

(webkitDownloadEmitError): Helper function that emits the error
signal for the given ResourceError.
(webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
(webkit_download_cancel): Ditto.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Ditto.
(webkit_download_error): Ditto.

Source/WebKit2:

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked):
(WebKit::DownloadClient::cannotShowURL):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

8:17 AM Changeset in webkit [100283] by caryclark@google.com
  • 4 edits in trunk

[chromium-mac] Enable vertical text using Skia
​https://bugs.webkit.org/show_bug.cgi?id=72137

Source/WebCore:

Use Skia to draw vertical text. This is much
faster and has higher fidelity than the old method
of drawing text on a path.

The graphics context passed to Skia has been
rotated 90 degrees but the character advances
have not, so it is necessary to unrotate the canvas,
and re-rotate the positions.

This generates correct output (or, at least,
consistent with Chromium CG on Mac) for all vertical
text tests, one of which is mentioned below.

Reviewed by Stephen White.

Test: fast/writing-mode/text-orientation-basic.html

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

LayoutTests:

Ignore vertical text tests on Skia on Mac for now.

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
8:14 AM Changeset in webkit [100282] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

media-blocked-by-willsendrequest.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72381

Reviewed by Tony Gentilcore.

  • media/media-blocked-by-willsendrequest.html:

Don't assume the media events will be dispatched before the window 'load' event.

  • platform/chromium/test_expectations.txt:

Don't skip media/media-blocked-by-willsendrequest.html.

7:59 AM Changeset in webkit [100281] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Enable skipped but now passing tests (http/tests)
​https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-11-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip 24 tests.
7:38 AM Changeset in webkit [100280] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix SVG hit testing when padding is present
​https://bugs.webkit.org/show_bug.cgi?id=37325

Patch by Philip Rogers <​pdr@google.com> on 2011-11-15
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/svg-padding.xhtml

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

  • svg/hittest/svg-padding-expected.txt: Added.
  • svg/hittest/svg-padding.xhtml: Added.
7:11 AM Changeset in webkit [100279] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, marked
fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK.

  • platform/gtk/test_expectations.txt:
6:58 AM Changeset in webkit [100278] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing.
6:52 AM Changeset in webkit [100277] by pfeldman@chromium.org
  • 10 edits in trunk/Source

Web Inspector: move generic code from DevTools.js into the WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72377

re-landing r100269.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

6:51 AM Changeset in webkit [100276] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] mark to rebaseline aft cr104128 lands (colorfilter optimization)
​https://bugs.webkit.org/show_bug.cgi?id=72270

Reviewed by NOBODY.

  • platform/chromium/test_expectations.txt:
6:43 AM Changeset in webkit [100275] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media-blocked-by-willsendrequest.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72381

  • platform/chromium/test_expectations.txt: Mark test as flaky.
6:43 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:40 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:39 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:31 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:30 AM Changeset in webkit [100274] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r100269.
​http://trac.webkit.org/changeset/100269
​https://bugs.webkit.org/show_bug.cgi?id=72383

"Broke dozens of tests due to exception in loadingFinished"
(Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:
  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

():
(devtools.domContentLoaded):
(WebInspector.UIString):
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

6:14 AM QtWebKitLayoutInteraction created by kenneth@webkit.org
6:12 AM Changeset in webkit [100273] by apavlov@chromium.org
  • 15 edits
    2 adds in trunk

font property does not show up as "shorthand" in inspector
​https://bugs.webkit.org/show_bug.cgi?id=15598

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The "font" CSS property is turned into a real shorthand, as its longhands used to float around
in the resulting style declaration without any reference to their underlying "font" property.

Test: fast/css/font-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
(WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
(WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
(WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.

  • css/CSSParser.h: Added optional "implicit" parameter to addProperty().
  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap): Added "font" shorthand map entry.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
(WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.

  • css/CSSStyleSelector.h: Made updateFont() public.
  • css/FontValue.cpp:

(WebCore::FontValue::customCssText): Made use of StringBuilder.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.

LayoutTests:

  • fast/css/font-shorthand-expected.txt: Added.
  • fast/css/font-shorthand.html: Added.
  • fast/inspector-support/style-expected.txt:
  • fast/inspector-support/style.html:
6:06 AM Changeset in webkit [100272] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug
​https://bugs.webkit.org/show_bug.cgi?id=72297

Unreviewed, GTK rebaseline after r100159.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
5:48 AM Changeset in webkit [100271] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some new GTK test failures.

  • platform/gtk/Skipped:
5:43 AM Changeset in webkit [100270] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
​https://bugs.webkit.org/show_bug.cgi?id=72262

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-11-15
Reviewed by Antonio Gomes.

No new tests needed, this is purely cosmetic.

  • platform/qt/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):

  • platform/qt/RenderThemeQStyle.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
since the mobile theme actually didn't do this.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

5:38 AM Changeset in webkit [100269] by pfeldman@chromium.org
  • 10 edits in trunk/Source

Web Inspector: move generic code from DevTools.js into the WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72377

This includes support for themed toolbar, remote debugging routines,
removes a couple of obsolete overrides from the DevTools.js

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

5:02 AM Changeset in webkit [100268] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r100182): It broke 2 http/tests/security tests
​https://bugs.webkit.org/show_bug.cgi?id=72364

  • platform/qt/Skipped: Skip failing tests until fix.
4:35 AM Changeset in webkit [100267] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/forms/file/input-file-label.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72376

  • platform/chromium/test_expectations.txt: Mark test flaky on win.
4:02 AM Changeset in webkit [100266] by Simon Hausmann
  • 8 edits in trunk

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

  • qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

3:33 AM Changeset in webkit [100265] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unreviewed prospective --minimal build fix.

  • DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0

and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.

3:30 AM Changeset in webkit [100264] by noel.gordon@gmail.com
  • 2 edits
    1 move
    3 adds
    1 delete in trunk/LayoutTests

Rebaseline gray-scale-jpeg-with-color-profile.html
​https://bugs.webkit.org/show_bug.cgi?id=72240

Reviewed by Eric Seidel.

  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
3:24 AM Changeset in webkit [100263] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] perf/document-contains.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72372

  • platform/chromium/test_expectations.txt: Marking flaky on WIN.
3:14 AM Changeset in webkit [100262] by commit-queue@webkit.org
  • 19 edits in trunk

Unreviewed, rolling out r100213.
​http://trac.webkit.org/changeset/100213
​https://bugs.webkit.org/show_bug.cgi?id=72371

"Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
3:03 AM Changeset in webkit [100261] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
​https://bugs.webkit.org/show_bug.cgi?id=70091

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-11-15
Reviewed by Filip Pizlo.

Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
with WebKit-EFL functions.

  • ewk/ewk_frame.cpp:

(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):

3:01 AM Changeset in webkit [100260] by yuqiang.xian@intel.com
  • 7 edits
    1 delete in trunk/Source/JavaScriptCore

Remove DFGJITCompilerInlineMethods
​https://bugs.webkit.org/show_bug.cgi?id=72366

Reviewed by Filip Pizlo.

Those methods are actually seldom used. Modify the few such places and
remove DFGJITCompilerInlineMethods stuffs totally.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addressOfDoubleConstant):

  • dfg/DFGJITCompilerInlineMethods.h: Removed.
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillFPR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):

2:59 AM Changeset in webkit [100259] by Csaba Osztrogonác
  • 7 edits
    2 adds in trunk/LayoutTests

[Qt] Unviewed fix after r100254, because committed results was incorrect.

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
2:52 AM Changeset in webkit [100258] by hclam@chromium.org
  • 6 edits in trunk/Source

[chromium] scroll deltas are cleared during commit to the main thread
​https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

Patch is covered by unit test.

Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
sent to the main thread during commit. This gives a simpler approach to keep tracking of a
layer's scroll delta in impl thread.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::sentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::sentScrollDelta):
(WebCore::CCLayerImpl::setSentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Modify test to verify sentScrollDeltas() values of CCLayerImpl during commit.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

2:37 AM Changeset in webkit [100257] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-webvtt-tc003-newlines.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72369

  • platform/chromium/test_expectations.txt: Marked test flaky.
2:34 AM Changeset in webkit [100256] by Simon Hausmann
  • 4 edits in trunk

[Qt] REGRESSION(100123): It made inspector tests crash ​https://bugs.webkit.org/show_bug.cgi?id=72274

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated

m_page member that should really come from RenderThemeQt.

LayoutTests:

  • platform/qt/Skipped: Unskip passing tests.
1:56 AM Changeset in webkit [100255] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix build breaks when EFL port is built.

  • CMakeLists.txt:
  • UseJSC.cmake:
1:47 AM Changeset in webkit [100254] by reni@webkit.org
  • 9 edits in trunk/LayoutTests

Unviewed gardening after r100159.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:37 AM Changeset in webkit [100253] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unreviewed --minimal build fix.

  • Scripts/build-webkit: Add to DEFINES+= from @options only if there is

a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
to make moc's preprocessor abort.

1:36 AM Changeset in webkit [100252] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Make ImageFrame member getAddr() public
​https://bugs.webkit.org/show_bug.cgi?id=72321

Reviewed by Adam Barth.

Make ImageFrame member getAddr() public to allow ImageFrame users access to the
underlying frame pixels if needed. Image decoders, for example, could with care
use this service to write decoded pixels direct to the ImageFrame pixel buffer,
avoiding intermeadiate data copies from temporary decoded pixel row buffers and
the decoding performance loss that that entails.

No new tests, refactoring only.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

1:32 AM Changeset in webkit [100251] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
​https://bugs.webkit.org/show_bug.cgi?id=72261

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/svg-style.xhtml

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

LayoutTests:

  • inspector/styles/svg-style-expected.txt: Added.
  • inspector/styles/svg-style.xhtml: Added.
1:24 AM Changeset in webkit [100250] by reni@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Platform-specific result for r100157.

Unreviewed, gardening.

Patch by Czene Tamás <​tczene@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
1:13 AM Changeset in webkit [100249] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests are skipped after r100182 and r100239.

Unreviewed gardening.

  • platform/qt/Skipped:
1:05 AM Changeset in webkit [100248] by mario@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=72267

Reviewed by Martin Robinson.

Allow getting and setting the 'enable-caret-browsing' property
through WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added property setter.
(webKitSettingsGetProperty): Added propery getter.
(webkit_settings_class_init): Install property.
(webkit_settings_get_enable_caret_browsing): Added.
(webkit_settings_set_enable_caret_browsing): Added.

  • UIProcess/API/gtk/WebKitSettings.h: Expose new public APIs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Added new API test.

12:36 AM Changeset in webkit [100247] by tkent@chromium.org
  • 4 edits in trunk

[V8] Fix incorrect handling of JavaScript properties in DOMStringMap
​https://bugs.webkit.org/show_bug.cgi?id=53578

Reviewed by Adam Barth.

Source/WebCore:

Follows a JSC behavior change by r96893.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):
Propagate to the JavaScript object if the DOMStringMap object
doesn't have the requested item.
(WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
(WebCore::V8DOMStringMap::namedPropertySetter):
Try to set a property to only a DOMStringMap object.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Remove failure expectations of fast/dom/dataset.html and
fast/dom/dataset-xhtml.xhtml.

12:08 AM Changeset in webkit [100246] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Command line $x fails for 3 of 4 types of XPath query
​https://bugs.webkit.org/show_bug.cgi?id=72276

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/console/console-xpath.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/console-xpath-expected.txt: Added.
  • inspector/console/console-xpath.html: Added.

Nov 14, 2011:

11:10 PM Changeset in webkit [100245] by pkasting@chromium.org
  • 1 edit
    7 moves in trunk/LayoutTests

r100237 moved some pixel baselines into platform/chromium without also
moving the text baselines. As a result all the Chromium Mac "not 10.6
CG" bots were still failing due to MISSING expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt.
11:04 PM Changeset in webkit [100244] by fpizlo@apple.com
  • 12 edits
    4 deletes in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
​https://bugs.webkit.org/show_bug.cgi?id=72348

Reviewed by Gavin Barraclough.

Moved all of JITCodeGenerator into SpeculativeJIT.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCodeGenerator.cpp: Removed.
  • dfg/DFGJITCodeGenerator.h: Removed.
  • dfg/DFGJITCodeGenerator32_64.cpp: Removed.
  • dfg/DFGJITCodeGenerator64.cpp: Removed.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • runtime/JSFunction.h:
11:01 PM Changeset in webkit [100243] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the change log entry for r59190.

  • ChangeLog-2010-05-24:
10:58 PM Changeset in webkit [100242] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Weak reference harvesters should run to fixpoint
​https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

10:43 PM Changeset in webkit [100241] by dbates@webkit.org
  • 3 edits in trunk/Tools

build-webkit: Accept --cmakearg to pass additional arguments to CMake.
​https://bugs.webkit.org/show_bug.cgi?id=72156

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-14
Reviewed by Daniel Bates.

Similar to --makearg and --qmakearg, --cmakearg lets one pass
additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

10:29 PM Changeset in webkit [100240] by pkasting@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

r100196 needed to also rebaseline Windows, not just Linux.

Unreviewed, gardening.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png:
10:14 PM Changeset in webkit [100239] by dslomov@google.com
  • 4 edits
    2 adds in trunk

Source/WebCore: [V8][Chromium]Serialize dense arrays densly
​https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:

  • Dense arrays are serialized densly, and not as name-value pairs
  • Sparse arrays are allocated as sparse on deserialization.

The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.

Reviewed by David Levin.

Test: fast/dom/Window/window-postmessage-arrays.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):

LayoutTests: [V8][Chromium]Serialize dense arrays densly.
​https://bugs.webkit.org/show_bug.cgi?id=72198

Reviewed by David Levin.

  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
  • fast/dom/Window/window-postmessage-arrays.html: Added.
10:07 PM Changeset in webkit [100238] by pkasting@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Removed.
  • platform/chromium/fast/table/prepend-in-anonymous-table-expected.txt: Added.
9:39 PM Changeset in webkit [100237] by pkasting@chromium.org
  • 11 edits
    24 adds
    8 deletes in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:27 PM Changeset in webkit [100236] by pkasting@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline svg/foreignObject/multiple-foreign-objects.html on Snow
Leopard and earlier.

Unreviewed, gardening.

  • platform/mac-snowleopard/svg/foreignObject: Added.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
8:08 PM Changeset in webkit [100235] by commit-queue@webkit.org
  • 11 edits
    10 deletes in trunk

[chromium] Fix scaleDelta zoom-out visibility rect bug
​https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way. I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: ​https://bugs.webkit.org/show_bug.cgi?id=71529)

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scaleDelta):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scaleDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

7:14 PM Changeset in webkit [100234] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix the build after moving some arrays to WTF
​https://bugs.webkit.org/show_bug.cgi?id=72345

Reviewed by Dirk Pranke.

  • public/WebArrayBufferView.h: s/WebCore/WTF/g.
7:08 PM Changeset in webkit [100233] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Improve ChangeLogEntry's reviewer parsing algorithm part 2
​https://bugs.webkit.org/show_bug.cgi?id=72340

Reviewed by Eric Seidel.

This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
6:46 PM Changeset in webkit [100232] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

WebProcess crashes when trying to display your "uploaded videos" page on Facebook
​https://bugs.webkit.org/show_bug.cgi?id=72334

Reviewed by Beth Dakin.

Protect against documents without frames.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

6:33 PM Changeset in webkit [100231] by eric@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
​https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

The TestExpectationsChecker was using a generic try/except block
which caught all exceptions, so we didn't notice that failing
to pass a Host to PortFactory was causing an exception in port instantiation.
I've factored out the "lookup the port" logic into a separate function
which I've now unittested. This should fix the bug and prevent
others like it from occuring the the future.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
6:18 PM Changeset in webkit [100230] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

More V8 build fixes.

6:06 PM Changeset in webkit [100229] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build again.

5:58 PM Changeset in webkit [100228] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build

5:52 PM Changeset in webkit [100227] by oliver@apple.com
  • 46 edits
    4 copies
    9 adds in trunk/Source

Start migrating typed array impl types to WTF
​https://bugs.webkit.org/show_bug.cgi?id=72336

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add typed array impls to WTF forwarding header.

  • wtf/Forward.h:

Source/WebCore:

Move typed arrays from WebCore namespace to WTF, and
start reducing dependencies on WebCore types.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(AddClassForwardIfNeeded):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.

(WebDOMFloat64Array::~WebDOMFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.

(WebKit::kit):
(WebKit::core):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_set_property):
(webkit_dom_float64array_get_property):
(webkit_dom_float64array_constructed):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
(WebKit::wrapFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Added.

(WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::JSFloat64ArrayPrototype::self):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::JSFloat64Array):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::put):
(WebCore::JSFloat64Array::putByIndex):
(WebCore::JSFloat64Array::getOwnPropertyNames):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::JSFloat64Array::getByIndex):
(WebCore::toFloat64Array):
(WTF::Float64Array::neuterBinding):

  • bindings/scripts/test/JS/JSFloat64Array.h: Added.

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(WebCore::JSFloat64Array::impl):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::create):
(WebCore::JSFloat64ArrayConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.

(core):
(kit):

  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
  • bindings/scripts/test/V8/V8Float64Array.cpp: Added.

(WebCore::Float64ArrayInternal::V8_USE):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore::V8Float64Array::wrapSlow):
(WTF::Float64Array::neuterBinding):
(WebCore::V8Float64Array::derefObject):

  • bindings/scripts/test/V8/V8Float64Array.h: Added.

(WebCore::V8Float64Array::toNative):
(WebCore::V8Float64Array::existingWrapper):
(WebCore::V8Float64Array::wrap):
(WebCore::toV8):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.h:

(WTF::Float32Array::set):

  • html/canvas/Float64Array.cpp:
  • html/canvas/Float64Array.h:

(WTF::Float64Array::set):

  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.h:

(WTF::Int16Array::set):

  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.h:

(WTF::Int32Array::set):

  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.h:

(WTF::Int8Array::set):

  • html/canvas/IntegralTypedArrayBase.h:
  • html/canvas/TypedArrayBase.h:

(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):

  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.h:

(WTF::Uint16Array::set):

  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.h:

(WTF::Uint32Array::set):

  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.h:

(WTF::Uint8Array::set):

  • html/canvas/WebGLBuffer.h:
  • page/Crypto.h:
  • webaudio/AsyncAudioDecoder.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::zero):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperNode.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • xml/XMLHttpRequest.h:
5:48 PM Changeset in webkit [100226] by jchaffraix@webkit.org
  • 13 edits in trunk

Add --css-grid-layout to build-webkit and the build systems
​https://bugs.webkit.org/show_bug.cgi?id=72320

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

Added the option.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
5:43 PM Changeset in webkit [100225] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
​https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <​dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

  • rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
  • rendering/svg/RenderSVGContainer.cpp: Ditto.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • rendering/svg/RenderSVGImage.cpp: Ditto.
  • rendering/svg/RenderSVGInline.cpp: Ditto.
  • rendering/svg/RenderSVGModelObject.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto.
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
  • rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
  • rendering/svg/RenderSVGRoot.cpp: Ditto.
  • rendering/svg/RenderSVGText.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
  • svg/SVGDocumentExtensions.cpp: Ditto.
  • svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
5:39 PM Changeset in webkit [100224] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

A little bit of arguments / activation cleanup
​https://bugs.webkit.org/show_bug.cgi?id=72339

Reviewed by Gavin Barraclough.

Renamed copyRegisters => tearOff to match bytecode and other terminology.

Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.

5:32 PM Changeset in webkit [100223] by barraclough@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Should sign the jsc binary
​https://bugs.webkit.org/show_bug.cgi?id=72332

Reviewed by David Kilzer.

  • Configurations/JSC.xcconfig:
  • entitlements.plist: Added.
5:23 PM Changeset in webkit [100222] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
​https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

  • dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

5:22 PM Changeset in webkit [100221] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG's inline references to objects should be tracked
​https://bugs.webkit.org/show_bug.cgi?id=72313

Reviewed by Gavin Barraclough.

Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

5:13 PM Changeset in webkit [100220] by noel.gordon@gmail.com
  • 1 edit
    5 adds in trunk/LayoutTests

Test JPEG image decoding RGB pixel endianess
​https://bugs.webkit.org/show_bug.cgi?id=72234

Reviewed by Kent Tamura.

JPEG image RGB pixels should render without color corruption and in strict
order, regardless of the underlying machine pixel buffer endianess.

  • fast/images/resources/rgb-jpeg-blue.jpg: Added.
  • fast/images/resources/rgb-jpeg-green.jpg: Added.
  • fast/images/resources/rgb-jpeg-red.jpg: Added.
  • fast/images/rgb-jpeg-endian-pixels-expected.txt: Added.
  • fast/images/rgb-jpeg-endian-pixels.html: Added.
5:04 PM Changeset in webkit [100219] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG put_by_id transition optimizations test the wrong structures
​https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

4:57 PM Changeset in webkit [100218] by gavinp@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/loader/cache/CachedResourceRequest.cpp

MERGE 71122 and 72068 simultaniously.

71122:

properly end requests when a bad status code return happens

​https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.

There is a chromium test going through code review at ​http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

72068:

Protect Document during error responses

​https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

4:51 PM Changeset in webkit [100217] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Expose compositeAndReadback in WebLayerTreeView
​https://bugs.webkit.org/show_bug.cgi?id=72188

Patch by Ian Vollick <​vollick@chromium.org> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebLayerTreeView.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::compositeAndReadback):

4:47 PM Changeset in webkit [100216] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r100192.
​http://trac.webkit.org/changeset/100192
​https://bugs.webkit.org/show_bug.cgi?id=72328

Caused infinite tests to fail (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-14

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
4:39 PM Changeset in webkit [100215] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/rendering

Remove FixedRect stream operator and move FloatRect version back to svg/

4:34 PM Changeset in webkit [100214] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

div with webkit-transform + webkit-box-reflect disappears when switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

4:24 PM Changeset in webkit [100213] by abarth@webkit.org
  • 19 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
​https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
    • Update test results to show that we no longer leak the scheme in storage identifiers.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
4:21 PM Changeset in webkit [100212] by mrowe@apple.com
  • 3 edits
    5 adds in trunk/Websites/webkit.org

Upgrade WordPress's Akismet plug-in to the latest version.

  • blog/wp-content/plugins/akismet:
4:20 PM Changeset in webkit [100211] by jchaffraix@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
​https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

  • css3/flexbox/display-flexbox-set-get-expected.txt: Added.
  • css3/flexbox/display-flexbox-set-get.html: Added.
  • css3/flexbox/resources/display-flexbox-set-get.js: Added.
4:18 PM Changeset in webkit [100210] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add buffering to handle mismatch between hardware buffer size and webaudio render size
​https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <Raymond Toy> on 2011-11-14
Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render): Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer. Also
remove the rounding of the callback size so we use whatever the
hardware returns. Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

4:16 PM Changeset in webkit [100209] by mrowe@apple.com
  • 2 edits in trunk/Websites/webkit.org

Update one file that was missed.

  • blog/wp-settings.php:
4:16 PM Changeset in webkit [100208] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.

  • runtime/JSString.h:
4:12 PM Changeset in webkit [100207] by mrowe@apple.com
  • 397 edits
    21 copies
    7 moves
    230 adds
    106 deletes in trunk/Websites/webkit.org

Upgrade WordPress to v3.2.1.

  • blog:
4:05 PM Changeset in webkit [100206] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Correcting usage of intMaxForLength in AutoTableLayout.

4:04 PM Changeset in webkit [100205] by abarth@webkit.org
  • 15 edits
    1 copy
    1 add in trunk/Source/JavaScriptCore

DateMath.cpp should not depend on JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstanceCache.h:
  • runtime/DatePrototype.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.

(JSC::timeToMS):
(JSC::msToSeconds):

  • runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
  • wtf/DateMath.cpp:

(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):

  • wtf/DateMath.h:
4:01 PM Changeset in webkit [100204] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Update ewk_frame_script_execute to return the result for JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <​js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_frame.h:
4:00 PM Changeset in webkit [100203] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
​https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
​https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

  • editing/pasteboard/drag-drop-dead-frame.html:
  • editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
  • editing/pasteboard/drag-drop-to-data-url.html: Added.
3:51 PM Changeset in webkit [100202] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit handling to JSString Ropes
​https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

3:33 PM Changeset in webkit [100201] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Round width and height when computing the scroll size (as opposed to flooring).

3:16 PM Changeset in webkit [100200] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

A little bit of function call cleanup
​https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

  • bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because

16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

3:10 PM Changeset in webkit [100199] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Pipe compositor commit/swap up to WebWidgetClient
​https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

2:51 PM Changeset in webkit [100198] by tony@chromium.org
  • 45 edits in trunk

Remove the CSS3_FLEXBOX compile time flag and enable on all ports
​https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:
  • rendering/style/StyleFlexibleBoxData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:47 PM Changeset in webkit [100197] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/Source/JavaScriptCore

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:47 PM Changeset in webkit [100196] by fsamuel@chromium.org
  • 6 edits
    1 copy
    2 adds in trunk

[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
​https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

  1. setPageScaleFactorLimits now affects the behavior of other scaling methods including setPageScaleFactor.
  2. setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset along with the page, preserving the scroll position within the page bounds.
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
  • platform/chromium/fast/repaint/background-scaling-expected.txt: Added.
2:42 PM Changeset in webkit [100195] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit paths to StringImpl methods
​https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

  • wtf/text/WTFString.cpp:

(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):

  • wtf/text/WTFString.h:

(WTF::find):
(WTF::reverseFind):

2:39 PM Changeset in webkit [100194] by scheib@chromium.org
  • 11 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
​https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

  • src/WebSettingsImpl.h:
2:32 PM Changeset in webkit [100193] by robert@webkit.org
  • 12 edits
    13 copies
    11 moves
    31 adds
    1 delete in trunk/LayoutTests

Platform-specific results for r100177

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/qt/fast/table/multiple-captions-display-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
2:29 PM Changeset in webkit [100192] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests should not be locale dependent ​https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <​vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/base.py:
2:25 PM Changeset in webkit [100191] by commit-queue@webkit.org
  • 20 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r100176.
​http://trac.webkit.org/changeset/100176
​https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:
2:22 PM Changeset in webkit [100190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
​https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

2:19 PM Changeset in webkit [100189] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Reverting lengths to being stored as pixel values for the specified zoom level and adopting an enclosingIntRect model for reporting sizes in RenderTreeAsText. This vastly lowers the number of failing layout tests on our branch.

1:56 PM Changeset in webkit [100188] by eae@chromium.org
  • 1569 edits
    513 copies
    162 deletes in branches/subpixellayout

Merging trunk changes up until 100042 into subpixel branch.

1:55 PM Changeset in webkit [100187] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

remove -wap-marquee css propery value
​https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

  • css/CSSValueKeywords.in:
1:49 PM Changeset in webkit [100186] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

JS Test Harness: Remove one more reference to non existing js-test-post-function.js
​https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

  • storage/indexeddb/mozilla/delete-result.html:
1:48 PM Changeset in webkit [100185] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Only send progress notifications for the main frame
​https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

1:45 PM Changeset in webkit [100184] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

[Chromium] build-webkit silently drops the features flags
​https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

  • Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

1:21 PM Changeset in webkit [100183] by jchaffraix@webkit.org
  • 4 edits
    6 adds in trunk

Crash in RenderTableSection::splitColumn
​https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
12:58 PM Changeset in webkit [100182] by abarth@webkit.org
  • 6 edits in trunk/Source

Remove the concept of an empty SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs. Previous
patches have removed most of the code relying upon this function. This
patch removes a couple stragglers.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

  • This check should really be about unique origins because it doesn't make sense to target postMessages at unique origins, as explained in the comment.
  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isEmpty):

12:56 PM Changeset in webkit [100181] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityContext::isSecureTransitionTo should not refer to empty security origins
​https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

12:50 PM Changeset in webkit [100180] by scheib@chromium.org
  • 19 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
​https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
  • page/MouseLockable.cpp:
  • page/MouseLockable.h:
  • page/MouseLockable.idl:
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

12:48 PM Changeset in webkit [100179] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by ​https://bugs.webkit.org/show_bug.cgi?id=72297.

  • platform/gtk/Skipped:
12:46 PM Changeset in webkit [100178] by annacc@chromium.org
  • 6 edits
    2 deletes in trunk/Source/WebCore

Remove TextTrackCueIndex and TextTrackCueSet. No longer needed.
​https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCueIndex.cpp: Removed.
  • html/TextTrackCueIndex.h: Removed.
12:41 PM Changeset in webkit [100177] by robert@webkit.org
  • 15 edits
    21 adds in trunk

CSS 2.1 failure: border-spacing-applies-to-015.htm
​https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:

LayoutTests:

  • css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
  • css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-002.htm: Added. Now passes!
  • css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
  • fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-display.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Result reflects extra captions.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Result reflects extra captions.
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png: Result reflects extra caption.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt: Result reflects extra caption.
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt: Result reflects extra caption.
12:24 PM Changeset in webkit [100176] by commit-queue@webkit.org
  • 20 edits
    1 copy
    2 adds in trunk/Source

Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
​https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <​gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.

(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):

  • html/canvas/WebGLExperimentalCompressedTextures.h: Added.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

12:23 PM Changeset in webkit [100175] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

(WTF::OSAllocator::reserveAndCommit):

12:08 PM Changeset in webkit [100174] by ddkilzer@apple.com
  • 2 edits
    4 adds in trunk/Tools

run-leaks does not work on Lion?
<​http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing. This required using a more generic
algorithm to find the start of the "Process " lines.

  • Scripts/run-leaks:

(parseLeaksOutput): Make the code to skip headers more generic.

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
12:04 PM Changeset in webkit [100173] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

  • src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

11:46 AM Changeset in webkit [100172] by Michael Nordman
  • 32 edits in trunk

Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
​https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

  • platform/sql/SQLiteDatabase.h:
  • storage/AbstractDatabase.cpp:

(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

  • storage/AbstractDatabase.h:
  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:

(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):

  • storage/DatabaseSync.idl:

Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

  • storage/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

  • storage/SQLError.h:

(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatementSync.cpp:

(WebCore::SQLStatementSync::execute):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for new websql error messages and console logging.
​https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/workers/storage/test-authorizer-expected.txt:
  • fast/workers/storage/transaction-in-transaction-sync.html:
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt:
  • storage/change-version-handle-reuse-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
  • storage/private-browsing-noread-nowrite-expected.txt:
  • storage/test-authorizer-expected.txt:
11:44 AM Changeset in webkit [100171] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

11:39 AM Changeset in webkit [100170] by abarth@webkit.org
  • 1 edit in trunk/Source/WebCore/dom/Document.cpp

Fix typo.

11:33 AM Changeset in webkit [100169] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec. I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

11:26 AM Changeset in webkit [100168] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused m_data member from UStringSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::UStringSourceProvider):

11:25 AM Changeset in webkit [100167] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize YARR Parser
​https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

11:23 AM Changeset in webkit [100166] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit build fix: Removed unused declaration.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

11:21 AM Changeset in webkit [100165] by ggaren@apple.com
  • 31 edits in trunk/Source/JavaScriptCore

Standardized the JS calling convention
​https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):

  • bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows

us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

  • dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before

doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

  • interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute): Headers are fun and educational!

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

  • runtime/Arguments.h:

(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

11:14 AM Changeset in webkit [100164] by arv@chromium.org
  • 16 edits
    6 deletes in trunk

Remove getParameter from HTMLAnchorElement and Location
​https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

  • html/HTMLAnchorElement.cpp: Removed getParameter.
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLAnchorElement.idl: Ditto.
  • page/Location.cpp: Ditto.
  • page/Location.h: Ditto.
  • page/Location.idl: Ditto.

LayoutTests:

  • fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/anchor-getParameter-expected.txt: Removed.
  • fast/dom/anchor-getParameter.html: Removed.
  • http/tests/misc/location-getParameter-expected.txt: Removed.
  • http/tests/misc/location-getParameter.html: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
11:11 AM Changeset in webkit [100163] by arv@chromium.org
  • 22 edits
    2 adds in trunk

Remove RequiresAllArguments
​https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
  • page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
  • websockets/WebSocket.idl: Comment changes only.

LayoutTests:

  • fast/dom/Window/window-resize-and-move-arguments-expected.txt:
  • fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
  • fast/dom/Window/window-scroll-arguments-expected.txt:
  • fast/dom/Window/window-scroll-arguments.html: Ditto.
  • fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
  • fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
10:06 AM Changeset in webkit [100162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
​https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

  • bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • public/WebKitPlatformSupport.h:
9:59 AM Changeset in webkit [100161] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.11

New tag.

9:56 AM Changeset in webkit [100160] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
​https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <​thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
9:55 AM Changeset in webkit [100159] by jer.noble@apple.com
  • 32 edits
    3 copies
    7 adds in trunk

Implement MediaController.
​https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

  • wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html

media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.

  • html/MediaControllerInterface.h: Added.

(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.

  • html/MediaController.cpp: Added.

(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):

  • html/MediaController.h: Added.

(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):

  • html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.

  • html/TimeRanges.cpp:

(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):

  • html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.

  • page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.

  • html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):

  • html/HTMLMediaElement.idl:
  • bindings/js/JSHTMLMediaElementCustom.cpp: Added.

(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:

  • html/HTMLMediaElement.cpp:

(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element. By default this is a single range of [0, maxTimeSeekable].

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::seekable):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toMediaController):

  • dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:

  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):

  • platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • media/media-controller-expected.txt: Added.
  • media/media-controller-playback-expected.txt: Added.
  • media/media-controller-playback.html: Added.
  • media/media-controller.html: Added.
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
9:44 AM Changeset in webkit [100158] by scherkus@chromium.org
  • 4 edits in trunk

[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
​https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
9:31 AM Changeset in webkit [100157] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Multiple foreign objects not rendered
​https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <​fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/runner-expected.txt: Rebaselined.
  • platform/chromium/html5lib/runner-expected.txt: Rebaselined.
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
  • svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
  • svg/foreignObject/multiple-foreign-objects.html: Added.
9:29 AM Changeset in webkit [100156] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
​https://bugs.webkit.org/show_bug.cgi?id=59771

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
9:16 AM Changeset in webkit [100155] by alexis.menard@openbossa.org
  • 2 edits
    10 moves
    2 adds
    7 deletes in trunk/Source/WebKit2

[Qt][WK2] Cleanup QML tests.
​https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
9:10 AM Changeset in webkit [100154] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merge r100022.

9:05 AM Changeset in webkit [100153] by mario@webkit.org
  • 7 edits in trunk/Source

Add support for the caretBrowsingEnabled preference in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

  • WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter

and setter macro.

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

9:01 AM Changeset in webkit [100152] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Remove dependency on pthread from FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

  • wtf/FastMalloc.cpp:
8:59 AM Changeset in webkit [100151] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
8:56 AM Changeset in webkit [100150] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

8:52 AM Changeset in webkit [100149] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-webvtt-tc004-magic-header.html flakily times out
​https://bugs.webkit.org/show_bug.cgi?id=72279

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
8:45 AM Changeset in webkit [100148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove expected crashes for skia-gpu canvas from test expectations
​https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <​bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
8:41 AM Changeset in webkit [100147] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
8:30 AM Changeset in webkit [100146] by fsamuel@chromium.org
  • 10 edits in trunk/Source

[chromium] Plumb through partial swap
​https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <​backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

8:29 AM Changeset in webkit [100145] by caseq@chromium.org
  • 16 edits
    1 delete in trunk

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
​https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

  • replace IFrameView with ExtensionView;
  • inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
  • move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
  • expose iframe's window object in the onShow event handler.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):

  • inspector/front-end/IFrameView.js: Removed.
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt:
8:22 AM Changeset in webkit [100144] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Try to make the bot green.

7:56 AM Changeset in webkit [100143] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: add 'Show function definition' context menu item for function values
​https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

  • inspector/front-end/inspector.js:

(WebInspector.showPanelForAnchorNavigation):

7:44 AM Changeset in webkit [100142] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
​https://bugs.webkit.org/show_bug.cgi?id=72249

7:33 AM Changeset in webkit [100141] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] security/crypto-random-values-types.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72272

  • platform/chromium/test_expectations.txt: Mark test as flaky.
7:17 AM Changeset in webkit [100140] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=72271

  • platform/chromium/test_expectations.txt: Expect test to crash sometimes.
6:58 AM UsingGitWithWebKit edited by Adam Roben
Added some tips for breaking up large patches (diff)
6:53 AM Changeset in webkit [100139] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-cues-cuechange.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72269

  • platform/chromium/test_expectations.txt: Mark test as flaky.
6:29 AM Changeset in webkit [100138] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping passing test.

  • platform/chromium/test_expectations.txt:
6:14 AM Changeset in webkit [100137] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: console's protocol payload does not have url and line properties.
​https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):

LayoutTests:

  • inspector/console/console-url-and-line-expected.txt: Added.
  • inspector/console/console-url-and-line.html: Added.
  • inspector/protocol/console-agent-expected.txt:
6:06 AM Changeset in webkit [100136] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Two inspector tests timeout on mac
​https://bugs.webkit.org/show_bug.cgi?id=72264

  • platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.
6:03 AM Changeset in webkit [100135] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [regression r99960] null callback access.
​https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.py:
5:19 AM Changeset in webkit [100134] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

5:19 AM Changeset in webkit [100133] by vestbo@webkit.org
  • 4 edits
    1 move
    1 add in trunk

[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

5:06 AM Changeset in webkit [100132] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

  • qmake/mkspecs/features/features.prf:
5:01 AM Changeset in webkit [100131] by Simon Hausmann
  • 4 edits in trunk/Source

[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • wtf/qt/compat/qguiapplication.h:

(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

4:58 AM Changeset in webkit [100130] by vestbo@webkit.org
  • 4 edits
    2 adds in trunk/Tools

[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

4:46 AM Changeset in webkit [100129] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove reference to QWebNavigationController
​https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p.h:
4:44 AM Changeset in webkit [100128] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.
4:41 AM Changeset in webkit [100127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
​https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <​husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

4:20 AM Changeset in webkit [100126] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[CMAKE] Add the UseV8.cmake to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <​jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

  • UseV8.cmake: Added.
3:55 AM Changeset in webkit [100125] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] the QQuickWebView should support double-tap to zoom
​https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

3:52 AM Changeset in webkit [100124] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
​https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-test.js:

(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [100123] by Simon Hausmann
  • 14 edits
    4 adds
    2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme ​https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
3:49 AM Changeset in webkit [100122] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
​https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
3:24 AM Changeset in webkit [100121] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Possible crash when destroying after called widgetSizeChanged.
​https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::chromeDestroyed):

3:15 AM Changeset in webkit [100120] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

  • platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.
2:53 AM Changeset in webkit [100119] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r100116.
​http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

  • Scripts/run-bindings-tests:
2:48 AM Changeset in webkit [100118] by tonyg@chromium.org
  • 18 edits in trunk/Tools

Unreviewed, rolling out r100104.
​http://trac.webkit.org/changeset/100104
​https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
2:26 AM Changeset in webkit [100117] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

SecurityContext should track whether the SecurityOrigin has been initialized
​https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards ​https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized. In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):

  • dom/SecurityContext.h:

(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

2:00 AM Changeset in webkit [100116] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, build fix after r100104. run-binding-tests broke.

  • Scripts/run-bindings-tests: Explicitely use scm.detection.
1:50 AM Changeset in webkit [100115] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
1:40 AM Changeset in webkit [100114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Give HTML ContextMenu a more Native look
​https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-14
Reviewed by Pavel Feldman.

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

  • inspector/front-end/inspector.css:

(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

1:27 AM Changeset in webkit [100113] by yurys@chromium.org
  • 16 edits
    3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
​https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

(JSC::JSFunction::sourceCode):

  • runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
1:25 AM Changeset in webkit [100112] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100050
​https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-11-14

  • platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html
1:18 AM Changeset in webkit [100111] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
​https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.
1:16 AM Changeset in webkit [100110] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
​https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

1:14 AM Changeset in webkit [100109] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Build breaks with --no-javascript-debugger --no-inspector
​https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

  • workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

12:27 AM Changeset in webkit [100108] by haraken@chromium.org
  • 16 edits
    1 delete in trunk/Source/WebCore

Remove all custom constructors of Events in V8
​https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • Target.pri: Removed V8EventConstructors.cpp.
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
12:23 AM BuildingQtOnLinux edited by Csaba Osztrogonác
(diff)
12:20 AM Changeset in webkit [100107] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 2 new svg tests.

  • platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
12:16 AM Changeset in webkit [100106] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WX] Make FontPlatformData::m_size private
​https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

  • platform/graphics/wx/FontPlatformData.h:
12:15 AM Changeset in webkit [100105] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

  • platform/gtk/Skipped:
12:07 AM Changeset in webkit [100104] by eric@webkit.org
  • 18 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
​https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

Nov 13, 2011:

11:57 PM Changeset in webkit [100103] by Csaba Osztrogonác
  • 1 edit
    9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r100036.

  • platform/qt/svg/foreignObject/clip-expected.png: Added.
  • platform/qt/svg/foreignObject/clip-expected.txt: Added.
  • platform/qt/svg/foreignObject/filter-expected.png: Added.
  • platform/qt/svg/foreignObject/filter-expected.txt: Added.
  • platform/qt/svg/foreignObject/mask-expected.png: Added.
  • platform/qt/svg/foreignObject/mask-expected.txt: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.
11:57 PM Changeset in webkit [100102] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Document::initSecurityOrigin should return earlier more often
​https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

11:53 PM Changeset in webkit [100101] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityPolicy should refer to isUnique rather than isEmpty
​https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time. Previously, this code checked
for empty origins, which are technically a subset of unique origins. I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

11:50 PM Changeset in webkit [100100] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Move isSecureTransitionTo from SecurityOrigin to SecurityContext
​https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
​https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

  • dom/SecurityContext.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:
9:14 PM Changeset in webkit [100099] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
​https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

7:06 PM Changeset in webkit [100098] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebFileChooserParams::acceptTypes
​https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h: Remove acceptTypes.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

4:02 PM Changeset in webkit [100097] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
​https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

  • ewk/ewk_view.h:
3:03 PM Changeset in webkit [100096] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Simplify eina_stringshare usage in ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

2:44 PM Changeset in webkit [100095] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix silent spilling/filling GPRs in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

1:30 PM Changeset in webkit [100094] by gavinp@chromium.org
  • 2 edits in trunk/Tools

command line control of webcore log channels in chromium DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

1:05 PM Changeset in webkit [100093] by scheib@chromium.org
  • 3 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
​https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

9:43 AM Changeset in webkit [100092] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
​https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

  • css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

  • fast/media/update-media-query-css-parser-expected.txt: Added.
  • fast/media/update-media-query-css-parser.html: Added.
7:26 AM Changeset in webkit [100091] by scheib@chromium.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
​https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
6:53 AM Changeset in webkit [100090] by andreas.kling@nokia.com
  • 7 edits in trunk/Source/WebCore

Only HTMLAllCollection needs stateful named item traversal.
<​http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <​http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

  • html/HTMLCollection.h:

Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
Promoted itemAfter() and checkForNameMatch() to protected methods so
they can be called from HTMLAllCollection.

  • html/HTMLAllCollection.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::namedItem):

  • html/HTMLFormCollection.h:
1:28 AM Changeset in webkit [100089] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

12:09 AM Changeset in webkit [100088] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Update binding generator tests to use jsCast
​https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

Nov 12, 2011:

11:40 PM Changeset in webkit [100087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100038.
​http://trac.webkit.org/changeset/100038
​https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-12

  • platform/qt/ScrollbarThemeQt.h:
8:37 PM Changeset in webkit [100086] by Laszlo Gombos
  • 29 edits in trunk/Source

[Qt][Symbian] Remove support for WINSCW compiler
​https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

  • API/JSStringRef.h:
  • create_hash_table: Revert r45553.
  • runtime/JSGlobalData.cpp: Revert r45553.
  • runtime/LiteralParser.cpp: Remove WINSCW comment.

(JSC::LiteralParser::Lexer::lexString):

  • runtime/Lookup.h: Revert r45553.
  • runtime/Structure.h: Revert r48461.
  • wtf/Alignment.h:
  • wtf/Assertions.h: Revert r52337.
  • wtf/Compiler.h:
  • wtf/ListRefPtr.h: Revert r48988.

(WTF::ListRefPtr::~ListRefPtr):

  • wtf/OwnArrayPtr.h: Revert r45911.

(WTF::OwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassOwnArrayPtr.h:

(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):

  • wtf/PassRefPtr.h:
  • wtf/StaticConstructors.h:
  • wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

(WebCore::CachedResourceHandle::CachedResourceHandle):

  • rendering/style/RenderStyle.h: Revert r52733.

(compareEqual):

  • bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

  • Shared/API/c/WKString.h:
4:47 PM Changeset in webkit [100085] by annacc@chromium.org
  • 6 edits
    58 adds in trunk

Add WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
​https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html

media/track/track-webvtt-tc001-utf8.html
media/track/track-webvtt-tc002-bom.html
media/track/track-webvtt-tc003-newlines.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc006-cue-identifiers.html
media/track/track-webvtt-tc007-cue-no-id.html
media/track/track-webvtt-tc008-timings-no-hours.html
media/track/track-webvtt-tc009-timings-hour.html
media/track/track-webvtt-tc010-no-timings.html
media/track/track-webvtt-tc011-blank-lines.html
media/track/track-webvtt-tc012-out-of-order.html
media/track/track-webvtt-tc013-settings.html
media/track/track-webvtt-tc014-alignment.html
media/track/track-webvtt-tc015-positioning.html
media/track/track-webvtt-tc016-align-positioning.html
media/track/track-webvtt-tc017-line-position.html
media/track/track-webvtt-tc018-align-text-line-position.html
media/track/track-webvtt-tc019-cue-size.html
media/track/track-webvtt-tc020-cue-size-align.html
media/track/track-webvtt-tc021-valign.html
media/track/track-webvtt-tc022-entities.html
media/track/track-webvtt-tc023-markup.html
media/track/track-webvtt-tc024-timestamp.html
media/track/track-webvtt-tc025-class-markup.html
media/track/track-webvtt-tc026-voice.html
media/track/track-webvtt-tc027-empty-cue.html
media/track/track-webvtt-tc028-unsupported-markup.html

  • html/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.

  • html/TextTrack.h: The cues() function can no longer be const.
  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after

all other startTimes in the list.

LayoutTests:

  • media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
  • media/track/track-webvtt-tc000-empty-expected.txt: Added.
  • media/track/track-webvtt-tc000-empty.html: Added.
  • media/track/track-webvtt-tc001-utf8-expected.txt: Added.
  • media/track/track-webvtt-tc001-utf8.html: Added.
  • media/track/track-webvtt-tc002-bom-expected.txt: Added.
  • media/track/track-webvtt-tc002-bom.html: Added.
  • media/track/track-webvtt-tc003-newlines-expected.txt: Added.
  • media/track/track-webvtt-tc003-newlines.html: Added.
  • media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
  • media/track/track-webvtt-tc004-magic-header.html: Added.
  • media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
  • media/track/track-webvtt-tc005-header-comment.html: Added.
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
  • media/track/track-webvtt-tc006-cue-identifiers.html: Added.
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
  • media/track/track-webvtt-tc007-cue-no-id.html: Added.
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
  • media/track/track-webvtt-tc008-timings-no-hours.html: Added.
  • media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
  • media/track/track-webvtt-tc009-timings-hour.html: Added.
  • media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
  • media/track/track-webvtt-tc010-no-timings.html: Added.
  • media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
  • media/track/track-webvtt-tc011-blank-lines.html: Added.
  • media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
  • media/track/track-webvtt-tc012-out-of-order.html: Added.
  • media/track/track-webvtt-tc013-settings-expected.txt: Added.
  • media/track/track-webvtt-tc013-settings.html: Added.
  • media/track/track-webvtt-tc014-alignment-expected.txt: Added.
  • media/track/track-webvtt-tc014-alignment.html: Added.
  • media/track/track-webvtt-tc015-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc015-positioning.html: Added.
  • media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
  • media/track/track-webvtt-tc016-align-positioning.html: Added.
  • media/track/track-webvtt-tc017-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc017-line-position.html: Added.
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
  • media/track/track-webvtt-tc018-align-text-line-position.html: Added.
  • media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
  • media/track/track-webvtt-tc019-cue-size.html: Added.
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
  • media/track/track-webvtt-tc020-cue-size-align.html: Added.
  • media/track/track-webvtt-tc021-valign-expected.txt: Added.
  • media/track/track-webvtt-tc021-valign.html: Added.
  • media/track/track-webvtt-tc022-entities-expected.txt: Added.
  • media/track/track-webvtt-tc022-entities.html: Added.
  • media/track/track-webvtt-tc023-markup-expected.txt: Added.
  • media/track/track-webvtt-tc023-markup.html: Added.
  • media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
  • media/track/track-webvtt-tc024-timestamp.html: Added.
  • media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
  • media/track/track-webvtt-tc025-class-markup.html: Added.
  • media/track/track-webvtt-tc026-voice-expected.txt: Added.
  • media/track/track-webvtt-tc026-voice.html: Added.
  • media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
  • media/track/track-webvtt-tc027-empty-cue.html: Added.
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
  • media/track/track-webvtt-tc028-unsupported-markup.html: Added.
3:27 PM Changeset in webkit [100084] by nduca@chromium.org
  • 4 edits in trunk/Source/WebCore

Fixes to GraphicsContext3D::makeCurrent on gtk and mac
​https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

2:13 PM Changeset in webkit [100083] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
​https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

10:43 AM Changeset in webkit [100082] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

  • dfg/DFGCorrectableJumpPoint.cpp:
  • dfg/DFGCorrectableJumpPoint.h:
9:30 AM Changeset in webkit [100081] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

[CMake] Move list of DFG source files into correct file
​https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
8:14 AM Changeset in webkit [100080] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix "unused variable" warning in JSLock
​https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

5:51 AM Changeset in webkit [100079] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

Add stub implementation for SVGResources::filter()
​https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::selfWillPaint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::selfWillPaint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::filter):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

5:33 AM Changeset in webkit [100078] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r98542): Rendering error on Google maps
​https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

  • fast/css/vertical-align-length-copy-bug-expected.txt: Added.
  • fast/css/vertical-align-length-copy-bug.html: Added.
4:01 AM Changeset in webkit [100077] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix minor config typo in the build tool documentation
​https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <​ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

  • qmake/README:
3:09 AM Changeset in webkit [100076] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r100013.
​http://trac.webkit.org/changeset/100013
​https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/access-key-for-all-elements-expected.txt: Removed.
  • fast/forms/access-key-for-all-elements.html: Removed.
2:39 AM Changeset in webkit [100075] by Nikolas Zimmermann
  • 24 edits in trunk/Source/WebCore

2011-11-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Finish SVGLengthContext conversion in svg/
​https://bugs.webkit.org/show_bug.cgi?id=72105

Reviewed by Antti Koivisto.

Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
Now that this process is finished, SVGLengthContext can be shared across renders,
so that its possible to override the length context in a single place. This will
be done in future patches.

Doesn't affect any tests yet.

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport):
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::containerTranslation):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • svg/SVGElement.h:
  • svg/SVGLengthContext.cpp: (WebCore::SVGLengthContext::determineViewport):
  • svg/SVGLengthContext.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::currentViewBoxRect):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
12:52 AM Changeset in webkit [100074] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
​https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

  • Source/cmake/WebKitMacros.cmake:
12:40 AM Changeset in webkit [100073] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(FILTERS) after r100036.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::filtersForceContainerLayout):

Nov 11, 2011:

11:57 PM Changeset in webkit [100072] by Patrick Gansterer
  • 8 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header.
​https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

  • platform/ContextMenu.h:
  • platform/graphics/win/DIBPixelData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/network/cf/ResourceError.h:
  • platform/win/LanguageWin.cpp:
  • platform/win/LocalizedStringsWin.cpp:
  • platform/win/LoggingWin.cpp:
11:11 PM Changeset in webkit [100071] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

  • WebCore.exp.in: Remove duplicate symbols listed.

Each dup in this case was already always exported.

9:24 PM Changeset in webkit [100070] by thakis@chromium.org
  • 11 edits in trunk/Source

[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
​https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/DebuggerAgentManager.cpp:

(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):

  • src/DebuggerAgentManager.h:
  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • src/WebViewImpl.cpp:

(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

8:48 PM Changeset in webkit [100069] by ojan@chromium.org
  • 2 edits
    2 moves
    16 adds in trunk/LayoutTests

Chromium layout test rebaselines after ​http://trac.webkit.org/changeset/100045
and ​http://trac.webkit.org/changeset/100036.

Also add line for failing text test after ​http://trac.webkit.org/changeset/99963.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
  • platform/chromium/svg/foreignObject/clip-expected.txt: Added.
  • platform/chromium/svg/foreignObject/filter-expected.txt: Added.
  • platform/chromium/svg/foreignObject/mask-expected.txt: Added.
  • platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
  • platform/chromium/test_expectations.txt:
8:45 PM Changeset in webkit [100068] by nduca@chromium.org
  • 10 edits in trunk/Source

Since GraphicsContext3D::makeContextCurrent can fail, return bool.

​https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/gtk/GraphicsContext3DPrivate.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::makeContextCurrent):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:
8:40 PM Changeset in webkit [100067] by ojan@chromium.org
  • 4 edits
    6 deletes in trunk

Source/WebCore: Unreviewed. Rollout ​http://trac.webkit.org/changeset/99744.
​https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout ​http://trac.webkit.org/changeset/99744.
​https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

  • fast/table/crash-splitColumn-2-expected.txt: Removed.
  • fast/table/crash-splitColumn-2.html: Removed.
  • fast/table/crash-splitColumn-3-expected.txt: Removed.
  • fast/table/crash-splitColumn-3.html: Removed.
  • fast/table/crash-splitColumn-expected.txt: Removed.
  • fast/table/crash-splitColumn.html: Removed.
8:28 PM Changeset in webkit [100066] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
​https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionCommit):

8:23 PM Changeset in webkit [100065] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
​https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
​https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

  • accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
  • accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.
7:37 PM Changeset in webkit [100064] by annacc@chromium.org
  • 19 edits
    8 adds in trunk

Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
​https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html

media/track/track-cues-enter-exit.html
media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:

  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadTimerFired):

Use scheduleLoad() instead of configureTextTracks() to start an async load.

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Updates the list of currently active cues during playback.

(WebCore::HTMLMediaElement::textTrackAddCues):

Adds cues to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCues):

Removes cues from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::textTrackAddCue):

Adds a cue to cueTree. Called when cues are discovered/loaded.

(WebCore::HTMLMediaElement::textTrackRemoveCue):

Removes a cue from cueTree. Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):

Update the active TextTrackCues when playbackProgressTimerFired.

(WebCore::HTMLMediaElement::addTrack):

Pass along a ScriptExecutionContext to TextTrack::create().

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

Update the active TextTrackCues when the media player time changes.

  • html/HTMLMediaElement.h:

Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
during playback.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::ensureTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::LoadableTextTrack::fireCueChangeEvent):

Fire a cue change event on this TextTrack's <track>

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

Pass along a ScriptExecutionContext needed for EventTarget interface.

(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):

Return a TextTrackCueList that represents the currently active cues.

(WebCore::TextTrack::fireCueChangeEvent):

Fires a cue change event.

  • html/TextTrack.h:

(WebCore::TextTrack::create):

Pass along a ScriptExecutionContext needed for EventTarget interface.

  • html/TextTrack.idl:

Makes TextTrack extend EventTarget interface and add oncuechange.

  • html/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):

TextTrackCue should extend EventTarget, not ActiveDOMObject.

(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):

Dispatch an enter or exit event depending on active state and notify
the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):

  • html/TextTrackCue.h:

(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

  • html/TextTrackCue.idl:

Extend EventTarget and add onenter and onexit.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::activeCues):

Update and return the list of currently active cues.

(WebCore::TextTrackCueList::clear):

Clear the cues from list (needed to return same object each time).

  • html/TextTrackCueList.h:

The following are needed for EventTarget interface:

  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):

  • html/track/TrackBase.h:

(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

  • media/track/captions-webvtt/cues-chrono-order.vtt: Added.
  • media/track/captions-webvtt/cues-overlapping.vtt: Added.
  • media/track/track-cues-cuechange-expected.txt: Added.
  • media/track/track-cues-cuechange.html: Added.
  • media/track/track-cues-enter-exit-expected.txt: Added.
  • media/track/track-cues-enter-exit.html: Added.
  • media/track/track-cues-seeking-expected.txt: Added.
  • media/track/track-cues-seeking.html: Added.
7:29 PM Changeset in webkit [100063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused variable added by r99813.
​https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <​reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdate):

7:15 PM Changeset in webkit [100062] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.
​https://bugs.webkit.org/show_bug.cgi?id=72174

  • DEPS:
6:58 PM Changeset in webkit [100061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <​luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

6:56 PM Changeset in webkit [100060] by jamesr@google.com
  • 14 edits in trunk/Source

Rollout ​http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

6:53 PM Changeset in webkit [100059] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

Revert Page to operate on integers
​https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):

  • page/EventHandler.h:
  • page/Frame.cpp:

(WebCore::Frame::documentAtPoint):

  • page/Frame.h:
  • page/FrameView.cpp:

(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • page/Page.h:
  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

6:24 PM Changeset in webkit [100058] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Updating the expected value, missed in r81312
​https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <​chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

  • fast/viewport/viewport-128-expected.txt:
6:23 PM Changeset in webkit [100057] by dmazzoni@google.com
  • 8 edits
    2 adds in trunk

New iframe content may not be reflected in the ax tree.
​https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

  • accessibility/loading-iframe-updates-axtree-expected.txt: Added.
  • accessibility/loading-iframe-updates-axtree.html: Added.
6:10 PM Changeset in webkit [100056] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
​https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

  • UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.

(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.

  • UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

6:05 PM Changeset in webkit [100055] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Fix CCThreadProxy::setVisible
​https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <​husky@google.com> on 2011-11-11
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCCompletionEvent.h:

(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setVisible):

5:52 PM Changeset in webkit [100054] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] CCThreadProxy::finishAllRendering hangs if !visible
​https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <​husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCScheduler.h:
  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

5:38 PM Changeset in webkit [100053] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Skip tests when no network is present
​https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

  • tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load): Skip test if no network is present.

  • tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint): Skip test if no network is present.

5:37 PM Changeset in webkit [100052] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Enable building without shared workers.
​https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::retrieveWorkerContext):

5:26 PM Changeset in webkit [100051] by jchaffraix@webkit.org
  • 4 edits
    8 adds in trunk

Crash in styleDidChange when changing a table cell's height.
<​http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html

fast/table/table-cell-change-height-with-needsCellRecalc-section.html
fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

  • fast/table/crash-table-cell-change-height-expected.txt: Added.
  • fast/table/crash-table-cell-change-height.html: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
  • fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.

Those tests checks that we don't try to access bad rows when the section needs a recalc.

5:21 PM Changeset in webkit [100050] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Implement legacy text check emulation in unified text check interface.
​https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):

Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.

  • testing/Internals.cpp:

(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

  • editing/spelling/spelling-unified-emulation-expected.txt: Added.
  • editing/spelling/spelling-unified-emulation.html: Added.
5:15 PM Changeset in webkit [100049] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

  • PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.
5:12 PM Changeset in webkit [100048] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Switch remaining RenderBlock/Box methods to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

4:57 PM Changeset in webkit [100047] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Add translation/scaling to WebExternalTextureLayer
​https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <​piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::uvRect):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

  • public/WebExternalTextureLayer.h:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

4:34 PM Changeset in webkit [100046] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Null deref when no use element exists for SVG element instance
​https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear

anything not yet cleared.

(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one

clears all the pointers it can, and removes the instance from the corresponding elements
instance list.

  • svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

  • svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
  • svg/custom/element-instance-held-by-js-crash.svg: Added.
4:30 PM Changeset in webkit [100045] by commit-queue@webkit.org
  • 4 edits
    9 adds in trunk

clipPath does not work on foreignObject
​https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <​fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html

svg/foreignObject/filter.html
svg/foreignObject/mask.html

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/SVGResources.cpp:

(WebCore::clipperFilterMaskerTags):

LayoutTests:

  • svg/foreignObject/clip-expected.png: Added.
  • svg/foreignObject/clip-expected.txt: Added.
  • svg/foreignObject/clip.html: Added.
  • svg/foreignObject/filter-expected.png: Added.
  • svg/foreignObject/filter-expected.txt: Added.
  • svg/foreignObject/filter.html: Added.
  • svg/foreignObject/mask-expected.png: Added.
  • svg/foreignObject/mask-expected.txt: Added.
  • svg/foreignObject/mask.html: Added.
4:07 PM Changeset in webkit [100044] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

Revert ​http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
​https://bugs.webkit.org/show_bug.cgi?id=68270

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [100043] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations for failing test.

  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [100042] by eae@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Round offsetWidth/Height/Top/Left and client* before returning instead of flooring the values in the binding code

3:54 PM Changeset in webkit [100041] by adamk@chromium.org
  • 10 edits in trunk/Source

Remove no-op StorageNamespace::unlock method
​https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see ​http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().

  • page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.

  • page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:
  • storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

  • src/StorageNamespaceProxy.cpp:
  • src/StorageNamespaceProxy.h:
3:52 PM Changeset in webkit [100040] by commit-queue@webkit.org
  • 9 edits in trunk

[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
​https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::getPageProperty):

  • src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode

  • DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

  • platform/chromium/test_expectations.txt: Removed expected fails for

printing tests that were using missing functionality in LayoutTestController.

3:50 PM Changeset in webkit [100039] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update iOS compiler version.

Reviewed by David Kilzer.

  • Configurations/CompilerVersion.xcconfig:
    • Update compiler version.
3:44 PM Changeset in webkit [100038] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Make sure Scrollbars are in their own layer.
​https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

  • platform/qt/ScrollbarThemeQt.h:

(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

3:43 PM Changeset in webkit [100037] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Update iOS port's configuration setting, particularly in Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

  • interpreter/Interpreter.h:
    • Lower the reentry depth.
  • runtime/DatePrototype.cpp:
    • iOS also uses CF.
  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

  • Update fastmalloc configuration for iOS.
  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • Added flag.
  • wtf/Platform.h:
    • Update platform configuration for iOS.
3:40 PM Changeset in webkit [100036] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Repaint broken when children of filtered SVG elements are updated
​https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <​jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
  • svg/repaint/filter-child-repaint.svg: Added.
3:19 PM Changeset in webkit [100035] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

​https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

  • WebCore.xcodeproj/project.pbxproj:
3:15 PM Changeset in webkit [100034] by leviw@chromium.org
  • 6 edits in branches/chromium/874

<svg> fails to use explicit width and height inside <html> inside IFRAME
​https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

  • platform/chromium/test_expectations.txt: Will update with results on other platforms.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
3:06 PM Changeset in webkit [100033] by ap@apple.com
  • 7 edits in trunk

WebProcess should use AppSandbox style quarantine
​https://bugs.webkit.org/show_bug.cgi?id=72168
<rdar://problem/10434292>

Reviewed by Darin Adler.

  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.
2:55 PM Changeset in webkit [100032] by commit-queue@webkit.org
  • 19 edits in trunk/Source

[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
​https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer

during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h: WebGLLayerChromium instances

are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):

  • platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances

have a raw reference to their owning DrawingBuffer. This reference is set to NULL on
destruction of the DrawingBuffer. This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the

central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes. GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setScissorEnabled):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches

the WebGLLayerChromium instance. Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

  • src/GraphicsContext3DPrivate.h:
2:54 PM Changeset in webkit [100031] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<​http://webkit.org/b/72175>

Reviewed by Joseph Pecoraro.

  • wtf/Platform.h: Move the definition of the BUILDING_ON_* and

TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds. Also include
Availability.h, which is needed on iOS builds.

2:51 PM Changeset in webkit [100030] by Darin Adler
  • 7 edits in trunk

Remove all releaseRef implementations except for RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=71423

Reviewed by Julien Chaffraix.

Source/JavaScriptCore:

  • API/JSRetainPtr.h: Removed releaseRef.
  • wtf/PassRefPtr.h: Removed releaseRef.

Source/WebCore:

  • platform/win/COMPtr.h: Removed releaseRef.

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

2:50 PM Changeset in webkit [100029] by Darin Adler
  • 2 edits in trunk/Source/WebCore
  • WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:41 PM Changeset in webkit [100028] by ojan@chromium.org
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r99953.
Caused 4 tests to hit an assert.
​https://bugs.webkit.org/show_bug.cgi?id=72163

Source/WebCore:

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Removed.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Removed.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Removed.
  • platform/chromium/test_expectations.txt:
2:37 PM Changeset in webkit [100027] by scheib@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r100024.
​http://trac.webkit.org/changeset/100024
​https://bugs.webkit.org/show_bug.cgi?id=72158

Broke chromium build

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
2:35 PM Changeset in webkit [100026] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fixup wrong expectations from ​http://trac.webkit.org/changeset/100008.
Pull in expectations from downstream expectations due to V8 roll.
Add new expectation for failure.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [100025] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused flags in pre-render implementation
​https://bugs.webkit.org/show_bug.cgi?id=65504

The high priority pre-render flag was not used anywhere,
so we can get rid of the whole concept and always consider the requests have low priority

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-11-11
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_pre_render_request_add):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

2:29 PM Changeset in webkit [100024] by scheib@chromium.org
  • 5 edits in trunk/Source/WebCore

Mouse Lock: MouseEvent IDL
​https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

2:20 PM Changeset in webkit [100023] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed, rolling out r99990.
​http://trac.webkit.org/changeset/99990
​https://bugs.webkit.org/show_bug.cgi?id=72134

Caused worker tests to fail on the chromium bots.

  • fast/workers/resources/worker-replace-self.js:

(worker.onmessage):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
2:19 PM Changeset in webkit [100022] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=72167
REGRESSION: Scroll position not restored on back after scroll
-and corresponding-
<rdar://problem/10410684>

Reviewed by Simon Fraser.

We can't just return early if we are not on an active page.
notifyPositionChanged() is called when a page is going into the page cache (and
therefore when not on an active page). We should not notify AppKit that the page
has scrolled in that case, but we still need to call
ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
and replaces it with a conditional around the relevant code.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyPositionChanged):

2:18 PM Changeset in webkit [100021] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/Source/WebCore

Added TileCairo and TiledBackingStoreBackendCairo files
​https://bugs.webkit.org/show_bug.cgi?id=71350

Patch by Julien Chaffraix <​jchaffraix@codeaurora.org>, Zaheer Ahmad <​zahimad@codeaurora.org>, Joone Hur <​joone.hur@collabora.co.uk>, Tomasz Morawski <​t.morawski@samsung.com> on 2011-11-11
Reviewed by Martin Robinson.

Added TileCairo and TiledBackingStoreBackend files needed by Tiled Backing Store implementation that uses cairo
library eg. EFL and Gtk WebKit port.

This patch contains some parts of rebased and updated code from 45423 bug. Originals authors of the code are:

  • platform/graphics/cairo/RefPtrCairo.cpp: Added support of RefPtr for cairo_region object.

(WTF::refIfNotNull): New refIfNotNull function for cairo_region object.
(WTF::derefIfNotNull): New derefIfNotNull function for cairo_region object.

  • platform/graphics/cairo/RefPtrCairo.h: Added support of RefPtr for cairo_region object.
  • platform/graphics/cairo/TileCairo.cpp: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::TileCairo):
(WebCore::TileCairo::~TileCairo):
(WebCore::TileCairo::isDirty):
(WebCore::TileCairo::isReadyToPaint):
(WebCore::TileCairo::invalidate):
(WebCore::TileCairo::updateBackBuffer):
(WebCore::TileCairo::swapBackBufferToFront):
(WebCore::TileCairo::paint):
(WebCore::TileCairo::resize):

  • platform/graphics/cairo/TileCairo.h: Added a new file. Implementation of TileCairo class.

(WebCore::TileCairo::create):
(WebCore::TileCairo::coordinate):
(WebCore::TileCairo::rect):

  • platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp: Added a new file. Implementation of

TiledBackingStoreBackend methods.
(WebCore::TiledBackingStoreBackend::createTile):
(WebCore::checkeredSurface): Helper function that creates checkered surface (see below function)
(WebCore::TiledBackingStoreBackend::paintCheckerPattern): Function is used to draw a place holder when tile no
exist or it is not ready to paint yet. The checkered surface is used here.

2:15 PM Changeset in webkit [100020] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore
  • JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:15 PM Changeset in webkit [100019] by Darin Adler
  • 2 edits in trunk/Source/ThirdParty/ANGLE
  • ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:15 PM Changeset in webkit [100018] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:14 PM Changeset in webkit [100017] by Darin Adler
  • 2 edits in trunk/Source/WebKit
  • WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.

If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

2:07 PM Changeset in webkit [100016] by leviw@chromium.org
  • 19 edits in branches/subpixellayout/Source

Reverting Page to integers

2:02 PM Changeset in webkit [100015] by commit-queue@webkit.org
  • 11 edits in trunk/LayoutTests

Update expected results for composited canvas operations
​https://bugs.webkit.org/show_bug.cgi?id=71995

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
2:01 PM Changeset in webkit [100014] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded frame check in FrameView::detachCustomScrollbars
​https://bugs.webkit.org/show_bug.cgi?id=71980

Reviewed by Anders Carlsson.

Change covered by the existing tests in scrollbars/.

  • page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Remove the leftover check that was forgotten by the different refactoring.

1:58 PM Changeset in webkit [100013] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Access key should work on all elements.
​https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification ​http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLButtonElement.idl: Ditto.
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLabelElement.idl: Ditto.
  • html/HTMLLegendElement.idl: Ditto.
  • html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
1:42 PM Changeset in webkit [100012] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Remove color space information from canvas composited drawImage tests
​https://bugs.webkit.org/show_bug.cgi?id=71970

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-11
Reviewed by Stephen White.

  • fast/canvas/canvas-composite-canvas.html:
  • fast/canvas/canvas-composite-image.html:
1:25 PM Changeset in webkit [100011] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100010.
​http://trac.webkit.org/changeset/100010
​https://bugs.webkit.org/show_bug.cgi?id=72172

"Broke gclient syncing on the chromium bots." (Requested by
ojan on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

  • DEPS:
1:05 PM Changeset in webkit [100010] by ojan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
12:52 PM Changeset in webkit [100009] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Assertion failed if text field is cleared while drag&drop.
​https://bugs.webkit.org/show_bug.cgi?id=61008

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-11
Reviewed by Ryosuke Niwa.

Test to drag-drop text from one input element to another clearing the first input
element. Fixed in Change set - ​http://trac.webkit.org/changeset/99085

  • fast/events/drag-text-with-clear-expected.txt: Added.
  • fast/events/drag-text-with-clear.html: Added.
12:51 PM Changeset in webkit [100008] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Re-enable layout test comparisons on chromium-mac-leopard.
​https://bugs.webkit.org/show_bug.cgi?id=68270

Patch by Elliot Poger <​epoger@google.com> on 2011-11-11
Reviewed by Adam Barth.

  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium/test_expectations.txt:
12:48 PM Changeset in webkit [100007] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Removing the 4th test in factory-deletedatabase-interactions.html
​https://bugs.webkit.org/show_bug.cgi?id=72037

Reviewed by Ojan Vafai.

Removing the test since it's testing not-yet-written code. Once the new
code is written it will obviously come with the appropriate tests.

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
12:40 PM Changeset in webkit [100006] by mhahnenberg@apple.com
  • 96 edits in trunk/Source

Add jsCast to replace static_cast
​https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):

  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):

  • runtime/JSCell.h:

(JSC::JSCell::visitChildren):
(JSC::jsCast):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):

  • runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::visitChildren):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):

  • runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlot):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • UserObjectImp.cpp:

(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::toThisObject):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getCallData):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getCallData):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getCallData):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildren):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

12:31 PM Changeset in webkit [100005] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

  • wtf/Platform.h:
    • enable DFG JIT for ARMv7/iOS.
12:24 PM Changeset in webkit [100004] by scheib@chromium.org
  • 6 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r99994.
​http://trac.webkit.org/changeset/99994
​https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):

  • page/MouseLockable.cpp: Removed.
  • page/MouseLockable.h: Removed.
  • page/MouseLockable.idl: Removed.
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
11:49 AM Changeset in webkit [100003] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

[v8] Remove unused V8Proxy::executingScript method
​https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
11:47 AM Changeset in webkit [100002] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
​https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
11:45 AM Changeset in webkit [100001] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

  • ChangeLog: Point out revision 100,000.
11:45 AM Changeset in webkit [100000] by Csaba Osztrogonác
  • 1 edit in trunk/Source/ThirdParty/ChangeLog

100,000 !!!

Reviewed by Zoltan Herczeg.

  • ChangeLog: Point out revision 100,000.
11:45 AM Changeset in webkit [99999] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

  • platform/KURL.cpp:

(WebCore::KURL::init): Replace strcpy() with strncpy().

11:41 AM Changeset in webkit [99998] by tony@chromium.org
  • 2 edits in trunk/Tools

Remove --force from gclient sync. The bots seem to have made it past
the update step.

  • Scripts/update-webkit:
11:32 AM Changeset in webkit [99997] by mhahnenberg@apple.com
  • 13 edits in trunk/Source

De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.

(JSC::BytecodeGenerator::BytecodeGenerator):

  • interpreter/Interpreter.cpp: Ditto.

(JSC::Interpreter::execute):

  • runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
  • runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.

  • runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.

(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.

  • bindings/js/JSDOMWindowBase.h:
11:28 AM Changeset in webkit [99996] by tony@chromium.org
  • 2 edits in trunk/Tools

Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

  • Scripts/update-webkit:
11:14 AM Changeset in webkit [99995] by ojan@chromium.org
  • 7 edits in trunk

Unreviewed, rolling out r99869.
​http://trac.webkit.org/changeset/99869
​https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):

  • dom/Document.h:
  • html/CollectionType.h:

LayoutTests:

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
11:09 AM Changeset in webkit [99994] by scheib@chromium.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Mouse Lock Navigator IDL
​https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/MouseLockable.cpp: Added.

(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):

  • page/MouseLockable.h: Added.

(WebCore::MouseLockable::create):

  • page/MouseLockable.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
11:07 AM Changeset in webkit [99993] by mhahnenberg@apple.com
  • 5 edits in trunk/Source

De-virtualize JSGlobalObject::allowsAccessFrom
​https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to

JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

  • bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

10:56 AM Changeset in webkit [99992] by adamk@chromium.org
  • 17 edits in trunk

[MutationObservers] Support attributeFilter for attribute mutations
​https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):

  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):

  • dom/MutationObserverRegistration.h:
  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:
  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::observe):

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
10:40 AM Changeset in webkit [99991] by tony@chromium.org
  • 2 edits in trunk/Tools

When --force is used, also use --reset
​https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <​maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

  • Scripts/update-webkit-chromium:
10:35 AM Changeset in webkit [99990] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

Speculative fix for a few worker tests.
​https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

  • fast/workers/resources/worker-replace-self.js:

(startTest.worker.onmessage):
(startTest):

  • fast/workers/worker-call.html:
  • fast/workers/worker-close.html:
  • fast/workers/worker-messageport-gc.html:
  • fast/workers/worker-replace-self.html:
10:30 AM Changeset in webkit [99989] by tony@chromium.org
  • 3 edits in trunk/Tools

allow two chromium drivers to run at the same time in NRWT
​https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on

posix prevents the subprocesses from sharing the same fd for stdin.
Sharing the same fd prevents us from closing the files unless all references
to the fd are closed.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition

to adding a test for this, speed up a test (from 3sec to 0) by fixing
the timeout override. It looks like it regressed in r95875.

10:28 AM Changeset in webkit [99988] by vsevik@chromium.org
  • 9 edits
    6 adds in trunk

Application cache status indicator gets stuck at DOWNLOADING after a failure
​https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
  • http/tests/inspector/resource-tree/appcache-test.js: Added.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/resource-tree/resources/manifest.php:
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
10:20 AM Changeset in webkit [99987] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] failing media/track/tracklist-is-reachable
​https://bugs.webkit.org/show_bug.cgi?id=72149

  • platform/chromium/test_expectations.txt: Expect test to fail for now.
10:03 AM Changeset in webkit [99986] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Only use the textured window style mask when there is no override inspector page.

​https://webkit.org/b/72142

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

9:58 AM Changeset in webkit [99985] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Expect chromium to pass this test after r99958.

  • platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
9:33 AM Changeset in webkit [99984] by eric.carlson@apple.com
  • 28 edits
    8 adds in trunk

Implement TextTrackList and the textTracks attribute of HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html

media/track/tracklist-is-reachable.html

  • CMakeLists.txt: Add new files for TextTrackList.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSTextTrackListCustom.cpp: Added.

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

  • dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.
  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if

the main resource or a text track should be loaded.

(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from

generic Vector to TextTrackList.

(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should

do eventually.

(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule

asynchronous text track load.

(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl: Add textTracks attribute.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad

instead of HTMLMediaElement

(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK

to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
load.

(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface

used to inform parent of TextTrack state changes.

(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if

new url is allowed to load, and start new load.

(WebCore::LoadableTextTrack::cueLoadingCompleted):

  • html/LoadableTextTrack.h:

(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().

  • html/TextTrack.h:

(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

  • html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.

(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):

  • html/track/TextTrackList.h: Added.

(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):

  • html/track/TextTrackList.idl: Added.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.

  • loader/TextTrackLoader.h:
  • page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

  • media/track/track-add-track-expected.txt: Added.
  • media/track/track-add-track.html: Added.
  • media/track/tracklist-is-reachable-expected.txt: Added.
  • media/track/tracklist-is-reachable.html: Added.
9:18 AM Changeset in webkit [99983] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: reimplement DOM search using no XPath.
​https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorDOMAgent.h:
8:55 AM Changeset in webkit [99982] by gavinp@chromium.org
  • 3 edits
    3 adds in trunk

Protect Document during error responses
​https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

  • http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
  • http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
  • http/tests/misc/xslt-bad-import-expected.txt: Added.
  • http/tests/misc/xslt-bad-import.html: Added.
8:53 AM Changeset in webkit [99981] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r99979.
​http://trac.webkit.org/changeset/99979
​https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

8:50 AM Changeset in webkit [99980] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <​yurys@chromium.org>

Fixed overlapping expectations.

  • platform/chromium/test_expectations.txt:
8:47 AM Changeset in webkit [99979] by gavinp@chromium.org
  • 3 edits in trunk

Protect Document during error responses
​https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by NOBODY (OOPS!).

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

8:43 AM Changeset in webkit [99978] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark http/tests/inspector-enabled/dedicated-workers-list.html as timing out on Mac.

  • platform/chromium/test_expectations.txt:
8:35 AM Changeset in webkit [99977] by Philippe Normand
  • 6 edits in trunk/Source/WebCore

[GStreamer] GstCaps and GstPad RefPtr implementation
​https://bugs.webkit.org/show_bug.cgi?id=72023

Reviewed by Martin Robinson.

Smart pointer implementations for GstCaps and GstPad and them
in the media player code.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstPad):
(WTF::GstCaps):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(StreamingClient::didReceiveResponse):

8:33 AM Changeset in webkit [99976] by Csaba Osztrogonác
  • 1 edit
    16 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
8:31 AM Changeset in webkit [99975] by gavinp@chromium.org
  • 3 deletes in trunk/LayoutTests/http/tests/misc

Unreviewed, rilling out 99971,99972.

They were landed in error in using git-svn by ​gavinp@chromium.org.

8:28 AM Changeset in webkit [99974] by Csaba Osztrogonác
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
8:27 AM Changeset in webkit [99973] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 failing pasteboard tests after r99924.

  • platform/gtk/Skipped:
8:25 AM Changeset in webkit [99972] by gavinp@chromium.org
  • 1 add in trunk/LayoutTests/http/tests/misc/xslt-bad-import-expected.txt

Moar

8:25 AM Changeset in webkit [99971] by gavinp@chromium.org
  • 3 adds in trunk/LayoutTests/http/tests/misc

first shot yo

8:22 AM Changeset in webkit [99970] by Csaba Osztrogonác
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
8:14 AM Changeset in webkit [99969] by tonyg@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
7:52 AM Changeset in webkit [99968] by Simon Hausmann
  • 14 edits
    2 adds
    4 deletes in trunk

Unreviewed, rolling out r99964.
​http://trac.webkit.org/changeset/99964
​https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • Target.pri:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::usesMenuList):

  • platform/qt/QtMobileWebStyle.cpp: Added.

(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):

  • platform/qt/QtMobileWebStyle.h: Added.
  • platform/qt/QtStyleOptionWebComboBox.h:

(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):

  • platform/qt/RenderThemeQStyle.cpp: Removed.
  • platform/qt/RenderThemeQStyle.h: Removed.
  • platform/qt/RenderThemeQt.cpp:

(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:

(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):

  • platform/qt/RenderThemeQtMobile.cpp: Removed.
  • platform/qt/RenderThemeQtMobile.h: Removed.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/webcore.prf:
7:42 AM Changeset in webkit [99967] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fix Snow Leopard build.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

7:35 AM Changeset in webkit [99966] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

7:22 AM Changeset in webkit [99965] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: make search in DOM panel scale.
​https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
7:16 AM Changeset in webkit [99964] by Simon Hausmann
  • 14 edits
    4 adds
    2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme ​https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
7:14 AM Changeset in webkit [99963] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: Option to configure indentation of pretty-printed Javascript
​https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

  • inspector/front-end/JavaScriptFormatter.js:

(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):

  • inspector/front-end/ScriptFormatter.js:
  • inspector/front-end/ScriptFormatterWorker.js:

(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:
7:08 AM Changeset in webkit [99962] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix after r99958.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationCustomCall):o

Remove hack that forced HTMLOptionsCollection to have a custom
callAsFunctionCallback().

6:55 AM Changeset in webkit [99961] by alexis.menard@openbossa.org
  • 2 edits in trunk

[Qt] Build fix of the private QML module with --no-webkit2.
​https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

  • Source/QtWebKit.pro:
6:50 AM Changeset in webkit [99960] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
​https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <​mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.py:
6:50 AM Changeset in webkit [99959] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip a svg test and GTK rebaseline after r99941.

  • platform/gtk/Skipped:
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
6:37 AM Changeset in webkit [99958] by andreas.kling@nokia.com
  • 7 edits in trunk

Remove ability to call HTMLCollections in V8 bindings as well.
<​http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):

  • dom/NodeList.idl:
  • html/HTMLCollection.idl:

Remove the V8CustomCall attribute as it's no longer needed.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

  • fast/dom/collection-calling-expected.txt: Added.
  • fast/dom/collection-calling.html: Added.
  • fast/dom/script-tests/collection-calling.js: Added.
6:22 AM Changeset in webkit [99957] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Interactive color box for gradients in CSS property values
​https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

  • inspector/front-end/CSSKeywordCompletions.js:
5:47 AM Changeset in webkit [99956] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

5:40 AM Changeset in webkit [99955] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-11-11 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Correct test_expectations.

  • platform/chromium/test_expectations.txt:
5:34 AM Changeset in webkit [99954] by tonyg@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
5:20 AM Changeset in webkit [99953] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
​https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

5:19 AM Changeset in webkit [99952] by alexis.menard@openbossa.org
  • 7 edits
    6 adds in trunk

[Qt] Add a way to have experimental features in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.:

Add the new private QML module in the build.

  • Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

  • declarative/private/plugin.cpp: Added.

(WebKitQmlPluginPrivate::registerTypes):

  • declarative/private/private.pro: Added.
  • declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.

(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):

  • UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.
5:12 AM Changeset in webkit [99951] by yurys@chromium.org
  • 15 edits
    3 deletes in trunk

Unreviewed, rolling out r99950.
​http://trac.webkit.org/changeset/99950
​https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

  • inspector/debugger/function-location-expected.txt: Removed.
  • inspector/debugger/function-location.html: Removed.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Removed.
5:05 AM Changeset in webkit [99950] by yurys@chromium.org
  • 14 edits
    3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
​https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
4:47 AM Changeset in webkit [99949] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

​https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

4:46 AM Changeset in webkit [99948] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

4:44 AM Changeset in webkit [99947] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
​https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

4:40 AM Changeset in webkit [99946] by Simon Hausmann
  • 14 edits
    2 deletes in trunk

[Qt][WK2] Remove QWebNavigationController
​https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

  • Target.pri:
  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage.h:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):

  • UIProcess/API/qt/qquickwebview.h:
  • UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
  • UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
4:33 AM Changeset in webkit [99945] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

  • qmake/mkspecs/features/functions.prf:
4:33 AM Changeset in webkit [99944] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Chromium expectations for new test in r99937.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
4:17 AM Changeset in webkit [99943] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

4:16 AM Changeset in webkit [99942] by hclam@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] scrolling is broken with compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::scrollLayer):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

3:49 AM Changeset in webkit [99941] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-11-11 Nikolas Zimmermann <​nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
​https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Zoltan Herczeg.

Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

  • fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
  • fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
  • platform/qt/Skipped: Unskip last regression from bug 7153.
3:47 AM Changeset in webkit [99940] by tonyg@chromium.org
  • 7 edits
    1 delete in trunk/Source

Unreviewed, rolling out r99826.
​http://trac.webkit.org/changeset/99826
​https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):

  • tests/data/page_with_image.mht: Removed.
3:37 AM Changeset in webkit [99939] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

  • qmake/qt_webkit.pri: Declare private headers.
3:02 AM Changeset in webkit [99938] by tonyg@chromium.org
  • 1 edit
    3 moves
    2 deletes in trunk/LayoutTests

Fixing media/video-frame-accurate-seek.html expectation after r99887.

  • platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
  • platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.
2:31 AM BuildingQt5OnHarmattan edited by Simon Hausmann
(diff)
1:52 AM Changeset in webkit [99937] by Nikolas Zimmermann
  • 7 edits
    4 adds in trunk

2011-11-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
​https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

Add another minimal testcase using <object> embedding SVGs + zooming.

  • platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
  • svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Zooming in SVGs in <object> is flakey
​https://bugs.webkit.org/show_bug.cgi?id=71673

Reviewed by Zoltan Herczeg.

It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
"visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
as overflow "hidden" already.

The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
All svg/overflow tests, still work as expected.

Test: svg/zoom/page/zoom-svg-as-object.html

  • page/Frame.cpp: (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.

Otherwise scrollbars will appear, even though the contents would fit without them.

(WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has

an effect though, when the FrameView of the SVG is embedded through <object>/etc.

(WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before! (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
  • rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.
1:44 AM Changeset in webkit [99936] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-11-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Unbreak my 32bit SL build.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.
1:03 AM Changeset in webkit [99935] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:40 AM Changeset in webkit [99934] by Philippe Normand
  • 3 edits
    1 add in trunk/Source/WebCore

HRTF Database consolidation
​https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

  • platform/audio/HRTFDatabase.h:
  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

  • platform/audio/resources/Composite.wav: Added.
12:37 AM Changeset in webkit [99933] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: provide an id to the root inspector element for third party UA styling.
​https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.html:
12:11 AM Changeset in webkit [99932] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r99898.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Note: See TracTimeline for information about the timeline view.