Timeline



Nov 18, 2011:

11:19 PM Changeset in webkit [100849] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk/Source

[Chromium] [WebSocket] export WebSocketChannel interface for plugins
​https://bugs.webkit.org/show_bug.cgi?id=72016

Source/WebCore:

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

Add a interface to send raw binary data.
This interface is used by WebWebSocketChannel implementation
in WebKit API.

No new tests because just export a interface.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • websockets/WebSocketChannel.h:

Source/WebKit/chromium:

Add WebSocket and WebSocketClient to WebKit API.

Currently, only WebSocketStreamHandle class is exported to WebKit API.
WebSocketStreamHandle implements bi-directional communication ports.
If plugins handles the WebSocket protocol, WebSocketChannel and
WebSocketChannelClient must be exported as WebSocket because they are
the classes which implement the WebSocket protocol stack.

Normally, we use WebWebSocketChannel and WebWebSocketChannelClient as
their class names. But here we use just WebSocket and WebSocketClient
because of avoiding WebWeb prefix and class name confliction on
header include.

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebSocket.h: Added.

(WebKit::WebSocket::~WebSocket):

  • public/WebSocketClient.h: Added.

(WebKit::WebSocketClient::~WebSocketClient):

  • src/WebRuntimeFeatures.cpp: Insert websockets directory to include path in order to avoid filename confliction.

(WebKit::WebRuntimeFeatures::enableSockets): Use WebCore namespace explicitly.

  • src/WebSocket.cpp: Added.

(WebKit::WebSocket::create):

  • src/WebSocketImpl.cpp: Added.

(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::~WebSocketImpl):
(WebKit::WebSocketImpl::connect):
(WebKit::WebSocketImpl::subprotocol):
(WebKit::WebSocketImpl::sendText):
(WebKit::WebSocketImpl::sendBinary):
(WebKit::WebSocketImpl::bufferedAmount):
(WebKit::WebSocketImpl::close):
(WebKit::WebSocketImpl::fail):
(WebKit::WebSocketImpl::disconnect):
(WebKit::WebSocketImpl::didConnect):
(WebKit::WebSocketImpl::didReceiveMessage):
(WebKit::WebSocketImpl::didReceiveBinaryData):
(WebKit::WebSocketImpl::didReceiveMessageError):
(WebKit::WebSocketImpl::didStartClosingHandshake):
(WebKit::WebSocketImpl::didClose):

  • src/WebSocketImpl.h: Added.

(WebKit::WebSocketImpl::isNull):

11:11 PM Changeset in webkit [100848] by mihnea@adobe.com
  • 1 edit
    1 add in trunk/LayoutTests

Pixel results missing for fast/regions/render-region-custom-style-mark.html
​https://bugs.webkit.org/show_bug.cgi?id=72775

Reviewed by Adam Barth.

  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Added.
10:05 PM Changeset in webkit [100847] by commit-queue@webkit.org
  • 7 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Darin Adler.

Source/WebCore:

Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.

  • html/HTMLDocument.idl:

LayoutTests:

As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.

  • fast/dom/document-width-height-force-layout-expected.txt:
  • fast/dom/document-width-height-force-layout.html:

Modified test case to use document.body.clientWidth and document.body.clientHeight.

  • fullscreen/video-specified-size-expected.txt:
  • fullscreen/video-specified-size.html:

Modified test case to use document.body.clientWidth.

9:24 PM Changeset in webkit [100846] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ build.

  • page/Navigator.idl: Properly disable the webkitGamepads API if gamepad

isn't enabled at compile time.

9:10 PM Changeset in webkit [100845] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed, add one failing test to the Skipped list.

  • platform/qt/Skipped:
7:56 PM Changeset in webkit [100844] by dbates@webkit.org
  • 10 edits
    7 adds in trunk

Add CMake build infrastructure for the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=72768

.:

Reviewed by Adam Barth and Antonio Gomes.

  • Source/CMakeLists.txt: Add the BlackBerry port and support for building on QNX.
  • Source/cmake/OptionsBlackBerry.cmake: Added.
  • Source/cmake/OptionsCommon.cmake: Add QNX QCC-variant of CODE_GENERATOR_PREPROCESSOR. We may be able to fold this into the non-MSVC CODE_GENERATOR_PREPROCESSOR.

Source/JavaScriptCore:

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake: Added.
  • shell/PlatformBlackBerry.cmake: Added.
  • wtf/PlatformBlackBerry.cmake: Added.

Source/WebCore:

Reviewed by Antonio Gomes.

  • CMakeLists.txt: At this time the BlackBerry port doesn't support generating DOM bindings from the SVG IDLs. See WebKit bug #72773.
  • PlatformBlackBerry.cmake: Added.

Source/WebKit:

Reviewed by Antonio Gomes.

  • blackberry: Added.
  • blackberry/CMakeListsBlackBerry.txt: Added.

Tools:

Reviewed by Antonio Gomes.

Add optional --blackberry command line argument to build-webkit to build the
BlackBerry port.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isBlackBerry): Added.
(determineIsBlackBerry): Added.
(blackberryTargetArchitecture): Added.
(isAppleWebKit):

7:40 PM Changeset in webkit [100843] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Add another isfinite assertion failure for fast/borders/
​https://bugs.webkit.org/show_bug.cgi?id=72053

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:18 PM Changeset in webkit [100842] by adamk@chromium.org
  • 19 edits in trunk/Source

Unreviewed, rolling out r100826.
​http://trac.webkit.org/changeset/100826
​https://bugs.webkit.org/show_bug.cgi?id=72786

Broke Chromium Mac build (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • page/ChromeClient.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
7:05 PM Changeset in webkit [100841] by adamk@chromium.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Rebaseline after r100819.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png.
  • platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt.
7:04 PM Changeset in webkit [100840] by jamesr@google.com
  • 3 edits in trunk

Fix reviewed by lines in ChangeLogs

7:02 PM Changeset in webkit [100839] by jamesr@google.com
  • 17 edits
    18 adds in trunk

[chromium] composited layers are blurry with a zoom-in page scale factor
​https://bugs.webkit.org/show_bug.cgi?id=71225

Source/WebCore:

Patch by Alpha Lam <​hclam@chromium.org> on 2011-11-18
Reviewed by James.

Pass contents scale factor to the compositor such that it can:

  1. Adjust contentBounds() of the compositoer layers with content scale.
  2. Apply the content scale in the painter for texture update in better resolution.
  3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater.

This change fixed blurry problem for all tiled layer types and is not limited to
position:fixed layers.

Tests: compositing/geometry/fixed-position-composited-page-scale-down.html

compositing/geometry/fixed-position-composited-page-scale.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
compositing/geometry/fixed-position-transform-composited-page-scale.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::contentsScale):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
(WebCore::ImageLayerChromium::needsContentsScale):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::needsContentsScale):
(WebCore::LayerChromium::contentsScale):

  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::needsContentsScale):
(WebCore::TiledLayerChromium::contentBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

Patch by Alpha Lam <​hclam@chromium.org> on 2011-11-18
Reviewed by James.

Implements GraphicsLayerClient to return values for pageScaleFactor and deviceScaleFactor. They are used to determine contents scale factor compositer layers.

  • src/PageOverlay.cpp:

(WebKit::OverlayGraphicsLayerClientImpl::deviceScaleFactor):
(WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):

LayoutTests:

Added test cases that has position:fixed and page scale.

Patch by Alpha Lam <​hclam@chromium.org> on 2011-11-18
Reviewed by James.

  • compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • compositing/geometry/fixed-position-transform-composited-page-scale.html: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:43 PM Changeset in webkit [100838] by abarth@webkit.org
  • 1 move in trunk/ManualTests

Move manual-tests out of WebCore.

6:40 PM Changeset in webkit [100837] by jamesr@google.com
  • 2 edits in trunk/Tools

Unreviewed, rolling out r100835.
​http://trac.webkit.org/changeset/100835
​https://bugs.webkit.org/show_bug.cgi?id=72778

Broke some page scale tests

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

6:36 PM Changeset in webkit [100836] by abarth@webkit.org
  • 5 edits in trunk

Prepare to move manual-tests out of WebCore
​https://bugs.webkit.org/show_bug.cgi?id=72782

Reviewed by Eric Seidel.

.:

Update these files to refer to the new location of ManualTests.

  • .gitattributes:
  • Source/cmake/WebKitPackaging.cmake:

Tools:

Update this file to refer to the new location of ManualTests.

  • Scripts/webkitpy/common/config/build.py:
6:25 PM Changeset in webkit [100835] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
​https://bugs.webkit.org/show_bug.cgi?id=72778

Reviewed by Kenneth Russell.

Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::scalePageBy):

6:23 PM Changeset in webkit [100834] by igor.oliveira@openbossa.org
  • 11 edits in trunk/Source

[WK2][Qt] Move Accelerated Composite animations to UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=72753

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::updateSceneGraphUpdateTimerFired):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

6:03 PM Changeset in webkit [100833] by commit-queue@webkit.org
  • 18 edits
    10 adds in trunk

IDL changes for gamepad support
​https://bugs.webkit.org/show_bug.cgi?id=71753

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-18
Reviewed by Adam Barth.

Source/WebCore:

IDL changes and associated plumbing to expose list of gamepad objects
on navigator object (per current spec). Full patch is
​https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
test until more plumbing in future patches.

Test: gamepad/gamepad-api.html

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):

  • page/Gamepad.cpp: Added.

(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):

  • page/Gamepad.h: Added.
  • page/Gamepad.idl: Added.
  • page/GamepadList.cpp: Added.

(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):

  • page/GamepadList.h: Added.

(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):

  • page/GamepadList.idl: Added.
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

  • page/Navigator.h:
  • page/Navigator.idl:

Source/WebKit/chromium:

Update to use vendor-prefixed enable.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

Tools:

Runtime enable gamepad in chromium test shell.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Add basic api existence test.

  • gamepad/gamepad-api-expected.txt: Added.
  • gamepad/gamepad-api.html: Added.
  • gamepad/gamepad-test.js: Added.

(logConsole):
(testExpected):
(reportExpected):
(waitForEventAndEnd):
(waitForEvent._eventCallback):
(waitForEvent):
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
(endTest):
(logResult):
(consoleWrite):

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
5:48 PM Changeset in webkit [100832] by commit-queue@webkit.org
  • 4 edits
    3 deletes in trunk

Unreviewed, rolling out r100693.
​http://trac.webkit.org/changeset/100693
​https://bugs.webkit.org/show_bug.cgi?id=72779

This patch caused a rendering regression (see bug 72770)
(Requested by philip on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

  • fast/layers/layer-absolute-parent-opacity-expected.png: Removed.
  • fast/layers/layer-absolute-parent-opacity-expected.txt: Removed.
  • fast/layers/layer-absolute-parent-opacity.html: Removed.
5:17 PM Changeset in webkit [100831] by Simon Fraser
  • 3 edits
    3 adds in trunk

Reflection on composited element doesn't update if the element changes to show no content
​https://bugs.webkit.org/show_bug.cgi?id=72774

Source/WebCore:

Reviewed by Chris Marrin.

When a style change results in a reflected element losing its backing store,
we need to clear the backing stores on the layer clones as well.

Test: compositing/reflections/become-simple-composited-reflection.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerDrawsContent):

LayoutTests:

Reviewed by Chris Marrin.

Test that removes the background-color of a reflected, composited element.

  • compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
  • compositing/reflections/become-simple-composited-reflection.html: Added.
5:12 PM Changeset in webkit [100830] by rniwa@webkit.org
  • 1 edit in trunk/Source/JavaScriptGlue/ChangeLog

Convert the encoding of JavaScriptGlue/Change from MacRoman to UTF-8 as it should be.

5:00 PM Changeset in webkit [100829] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT fails speculation on InstanceOf if the base is not an object
​https://bugs.webkit.org/show_bug.cgi?id=72709

Reviewed by Geoff Garen.

InstanceOf already leverages the fact that we only allow the default
hasInstance implementation. So, if the base is predicted to possibly
be not an object and the CFA has not yet proven otherwise, InstanceOf
will abstain from speculating cell and instead return false if the
base is not a cell.

This appears to be a 1% speed-up on V8 on the V8 harness. 3-4% or so
speed-up in earley-boyer. Neutral according to bencher on SunSpider,
V8, and Kraken. In 32-bit, it's a 0.5% win on SunSpider and a 1.9%
win on V8 even on my harness, due to a 12.5% win on earley-boyer.

I also took this opportunity to make the code for InstanceOf common
between the two JITs. This was partially successful, in that the
"common code" has a bunch of #if's, but overall it seems like a code
size reduction.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:46 PM Changeset in webkit [100828] by dcheng@chromium.org
  • 10 edits in trunk

[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
​https://bugs.webkit.org/show_bug.cgi?id=72767

Source/WebCore:

Reviewed by Tony Chang.

Covered by existing tests.

  • editing/chromium/EditorChromium.cpp:

(WebCore::Editor::newGeneralClipboard):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::storageMode):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::hasData):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • src/WebDragData.cpp:

(WebKit::WebDragData::initialize):
(WebKit::WebDragData::assign):

LayoutTests:

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [100827] by cevans@google.com
  • 3 edits
    2 adds in trunk

Crash with ranges across a detached, reparented node tree
​https://bugs.webkit.org/show_bug.cgi?id=72757

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/move-detached-child-in-range.html

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us.

LayoutTests:

  • fast/dom/move-detached-child-in-range-expected.txt: Added.
  • fast/dom/move-detached-child-in-range.html: Added.
4:31 PM Changeset in webkit [100826] by Beth Dakin
  • 19 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=72551
When the recommended scrollbar style changes, WKView's tracking options should
adjust accordingly
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This new ChromeClient function is called when the recommended scrollbar style
changes. This way, WebKit can respond to the change by adjusting its mouse
tracking.

  • page/ChromeClient.h:

(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):

Existing ScrollableArea function scrollbarStyleChanged() now takes an int
indicating the new scrollbar style and a bool indicating whether it is necessary
to force an update. It used to be the case that this function was ONLY used to
force an update (and only called when an updated was needed), but now that it must
also call into the ChromeClient, it is necessary to include a bool tracking
whether we need to force an update. New implementation on FrameView is responsible
for calling ChromeClient, and then that calls into the pre-existing ScrollView
function for the forceUpdate part.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView:: scrollbarStyleChanged):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarStyleChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

These new functions take care of passing along the
recommendedScrollbarStyleDidChange() message that originates in the ChromeClient.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::recommendedScrollbarStyleDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

This is where we actually respond to the recommendedScrollbarStyleDidChange
message. We remove the existing tracking area and create a new tracking area with
the appropriate tracking options.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

BuiltInPDFView inherits from WebCore::ScrollableArea, so scrollbarStyleChanged()
must now take two parameters like the one in ScrollableArea.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::scrollbarStyleChanged):

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
4:29 PM Changeset in webkit [100825] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
​https://bugs.webkit.org/show_bug.cgi?id=72758

Allow these tests to timeout until the bug is fixed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [100824] by knorton@google.com
  • 2 edits in trunk/Source/WebCore

Fixes several more void functions in RenderObject that return values.
​https://bugs.webkit.org/show_bug.cgi?id=72750

Reviewed by Adam Barth.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateBeforeAfterContent):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):

4:14 PM Changeset in webkit [100823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Add some useful text to existing debug dump
​https://bugs.webkit.org/show_bug.cgi?id=72576

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-11-18
Reviewed by James Robinson.

No new tests needed.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::dumpSurface):

4:12 PM Changeset in webkit [100822] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Forgot to completely de-virtualize isDynamicScope
​https://bugs.webkit.org/show_bug.cgi?id=72763

Reviewed by Darin Adler.

  • runtime/JSActivation.h: Removed virtual keyword.
3:35 PM Changeset in webkit [100821] by darin@chromium.org
  • 15 edits in trunk

2011-10-24 Darin Fisher <​darin@chromium.org>

[chromium] Improve fullscreen API
​https://bugs.webkit.org/show_bug.cgi?id=70477

Reviewed by Adam Barth.

Move fullscreen entry points from WebView to WebWidget since they are
just about widget geometry.

Delay webkitfullscreenchange event until we know that we have entered
fullscreen mode. This is accomplished by expanding the WebKit APIs to
differentiate will{Enter,Exit} from did{Enter,Exit} state changes.

WebViewImpl is forced to keep a reference to the requested fullscreen
element while we are requesting to enter fullscreen mode. Once in
fullscreen mode, we switch to keeping only a reference to the Frame
containing the fullscreen element, which we drop upon exiting
fullscreen mode.

  • public/WebView.h:
  • public/WebViewClient.h:
  • public/WebWidget.h: (WebKit::WebWidget::willEnterFullScreen): (WebKit::WebWidget::didEnterFullScreen): (WebKit::WebWidget::willExitFullScreen): (WebKit::WebWidget::didExitFullScreen):
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::enterFullScreen): (WebKit::WebWidgetClient::exitFullScreen):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullscreenForNode): (WebKit::ChromeClientImpl::enterFullscreenForNode): (WebKit::ChromeClientImpl::exitFullscreenForNode): (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willEnterFullScreen): (WebKit::WebViewImpl::didEnterFullScreen): (WebKit::WebViewImpl::willExitFullScreen): (WebKit::WebViewImpl::didExitFullScreen): (WebKit::WebViewImpl::enterFullScreenForElement): (WebKit::WebViewImpl::exitFullScreenForElement):
  • src/WebViewImpl.h:
3:29 PM Changeset in webkit [100820] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
​https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Darin Adler.

Fix this for 32_64.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

3:22 PM Changeset in webkit [100819] by xji@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
​https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

This patch fixes the problem in Mac and Chromium Mac.

The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT
(the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code
is forked from Mac.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollToPoint):

LayoutTests:

The test still marks as FAIL in test_expectations because cg-mac might need rebase.

  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
3:16 PM Changeset in webkit [100818] by eae@chromium.org
  • 1670 edits
    1310 copies
    818 deletes in branches/subpixellayout

Merging trunk changes up until 100802 into subpixel branch.

3:09 PM Changeset in webkit [100817] by Martin Robinson
  • 10 edits in trunk

REGRESSION (r99924): broke 2 pasteboard tests on GTK
​https://bugs.webkit.org/show_bug.cgi?id=72131

Reviewed by Tony Chang.

Source/WebCore:

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData): Call clearAll now.
(WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear.
(WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames.

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data.

(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::clearClipboardContentsCallback): Use the clearAll method now.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::setSelectionPrimaryClipboardIfNeeded): Use the new clearAll method.

LayoutTests:

  • platform/gtk/Skipped: Unskip passing tests.
3:01 PM Changeset in webkit [100816] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt][Wk2] Add an API test for scroll request from javascript
​https://bugs.webkit.org/show_bug.cgi?id=72407

New API test added for QQuickWebView for javascript scroll request
Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/tests/html/scroll.html: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

2:52 PM Changeset in webkit [100815] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72761

Mark test as PASS TIMEOUT as it occasionally times out on the bots.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
2:43 PM WebKit Team edited by Michelangelo De Simone
(diff)
2:35 PM Changeset in webkit [100814] by timothy@apple.com
  • 1 copy in tags/Safari-534.52.12

New tag.

2:33 PM Changeset in webkit [100813] by timothy@apple.com
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

2:26 PM Changeset in webkit [100812] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] The exclusions tests are all passing. Remove the
test_expectations.txt entry for them.

  • platform/chromium/test_expectations.txt:
2:24 PM Changeset in webkit [100811] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Test fast/events/dropzone-002.html is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=61625

Test is no longer failing since the end of October.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [100810] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

De-virtualize ExecutableBase::intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=72548

Reviewed by Oliver Hunt.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.

  • runtime/Executable.h:
  • runtime/JSCell.h:

(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.

1:52 PM Changeset in webkit [100809] by Beth Dakin
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

<rdar://problem/10466170> Regression: Scroll bars disappear and don't come back

Reviewed by Sam Weinig.

Fixing a merge issue. On TOT we use #if USE(SCROLLBAR_PAINTER), but on the branch
it is still #if USE(WK_SCROLLBAR_PAINTER). Also, on the branch, all of the
m_scrollbarPainterController functions go through WebKitSystemInterface instead of
using forward declaration. We should consider merging those changes, but in the
meantime, for this to work, we have to go back to the branch-style.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notityPositionChanged):

1:42 PM Changeset in webkit [100808] by adamk@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaseline chromium expectations after r100800.
Note that previous rebaseline was actually meant for r100786.

Unreviewed gardening.

  • platform/chromium-win/animations/additive-transform-animations-expected.png: Added.
  • platform/chromium-win/animations/additive-transform-animations-expected.txt: Added.
  • platform/chromium/animations/additive-transform-animations-expected.png: Added.
1:39 PM Changeset in webkit [100807] by adamk@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Rebaseline chromium expectations after r100800.

Unreviewed gardening.

  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png: Added.
1:26 PM Changeset in webkit [100806] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=66900

Re-adding SNOWLEOPARD flakiness on CG bots that seems to have been
erroneously removed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [100805] by commit-queue@webkit.org
  • 37 edits
    2 adds in trunk

Access key should work on all elements.
​https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification ​http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/BaseButtonInputType.h: Ditto
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::accessKeyAction): Ditto

  • html/BaseCheckableInputType.h: Ditto
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction): Ditto

  • html/HTMLAnchorElement.h: Ditto
  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLButtonElement.h: Ditto
  • html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.

  • html/HTMLElement.h: Ditto
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLInputElement.h: Ditto
  • html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLabelElement.h: Ditto
  • html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLegendElement.h: Ditto
  • html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction): Ditto

  • html/HTMLSelectElement.h: Ditto
  • html/HTMLTextAreaElement.h: Ditto
  • html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/InputType.h: Ditto
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::accessKeyAction): Ditto

  • html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
  • fast/forms/access-key.html: Added more test coverage for select and textarea elements.
12:07 PM Changeset in webkit [100804] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
​https://bugs.webkit.org/show_bug.cgi?id=72747

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [100803] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectation for fast/js/delete-syntax.html, which seems to have
been fixed by ​http://code.google.com/p/v8/source/detail?r=9993.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:32 AM Changeset in webkit [100802] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove IMAGE suppression for css3/images/cross-fade-overflow-position.html
to let me use garden-o-matic for rebaselining.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [100801] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Infinite recursion in WebCore::RenderInline::computeRectForRepaint
​https://bugs.webkit.org/show_bug.cgi?id=52144

Reviewed by Tony Chang.

The bug got fixed, landing the test. As I could not test the old test case, it is
landed as-is (apart from making it dumpAsText which was deemed safe).

  • editing/execCommand/infinite-recursion-computeRectForRepaint-expected.txt: Added.
  • editing/execCommand/infinite-recursion-computeRectForRepaint.html: Added.
11:18 AM Changeset in webkit [100800] by Simon Fraser
  • 4 edits
    3 adds in trunk

Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

  • platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

  • animations/additive-transform-animations-expected.png: Added.
  • animations/additive-transform-animations.html: Added.
  • platform/mac/animations/additive-transform-animations-expected.txt: Added.
11:15 AM Changeset in webkit [100799] by Adam Roben
  • 3 edits in trunk/Tools

Ignore an ANGLE leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added ScanFromString to the call stacks to exclude on all OS versions.

11:11 AM Changeset in webkit [100798] by oliver@apple.com
  • 5 edits
    3 adds in branches/safari-534.54-branch

Merge r100514

DFG global variable CSE mishandles the cross-global-object inlining corner case
​https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/cross-global-object-inline-global-var-expected.txt: Added.
  • fast/js/cross-global-object-inline-global-var.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

11:08 AM Changeset in webkit [100797] by oliver@apple.com
  • 5 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100391

REGRESSION (r98887): ParserArena and Keywords leaking
​https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
11:06 AM Changeset in webkit [100796] by oliver@apple.com
  • 6 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100363

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
​https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:03 AM Changeset in webkit [100795] by oliver@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100219

DFG put_by_id transition optimizations test the wrong structures
​https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

11:02 AM Changeset in webkit [100794] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress IMAGE failures for css3/images/cross-fade-overflow-position.html
Needs rebaseline after r100786.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [100793] by oliver@apple.com
  • 3 edits
    2 copies in branches/safari-534.54-branch/Source/JavaScriptCore

Merge r100197

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
10:58 AM Changeset in webkit [100792] by adauria@apple.com
  • 2 edits in trunk/Source/WebKit/mac

bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
​https://bugs.webkit.org/show_bug.cgi?id=72568

Reviewed by David Kilzer.

WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
as the return value, which was then cast to a bool and always returned true. This
patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
return value of NO.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldInterruptJavaScript):

10:55 AM Changeset in webkit [100791] by oliver@apple.com
  • 3 edits
    3 adds in branches/safari-534.54-branch

2011-11-18 Oliver Hunt <​oliver@apple.com>

Merge r99917

2011-11-09 Filip Pizlo <​fpizlo@apple.com>

DFG byte array support sometimes clamps values incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=71975

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
10:39 AM Changeset in webkit [100790] by Adam Roben
  • 3 edits in trunk/Tools

Ignore another Lion-specific leak that is not WebKit's fault

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added SecTransformExecute to the call stacks to exclude.

10:36 AM Changeset in webkit [100789] by igor.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit2

No'am Rosenthal <​noam.rosenthal@nokia.com>

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for KeyframeValueList, and modify the TimingFunction ArgumentCoder to
allow encoding const TimingFunctions and not just RefPtr<TimingFunction>.

Reviewed by Simon Hausmann.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
10:24 AM Changeset in webkit [100788] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

Added CRASH to expectations for fast/encoding/parser-tests-50.html.
It's only crashing on Snow Leopard, but I didn't want to split the
existing line in two.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 AM Changeset in webkit [100787] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Remove duplicate dtoa files from CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=72711

Reviewed by Brent Fulgham.

  • wtf/CMakeLists.txt:
10:06 AM Changeset in webkit [100786] by timothy_horton@apple.com
  • 4 edits
    4 adds in trunk

-webkit-cross-fade rendered incorrectly in overflow divs
​https://bugs.webkit.org/show_bug.cgi?id=72693
<rdar://problem/10468564>

Reviewed by Simon Fraser.

Respect the desired source rectangle when rendering the cross-fade.

Test: css3/images/cross-fade-overflow-position.html

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:

Add a test to make sure that -webkit-cross-fade renders correctly inside overflowed areas.

  • css3/images/cross-fade-overflow-position.html: Added.
  • css3/images/resources/half-circles.svg: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/mac/css3/images/cross-fade-overflow-position-expected.txt: Added.
9:49 AM Changeset in webkit [100785] by Patrick Gansterer
  • 4 edits in trunk

[CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files
​https://bugs.webkit.org/show_bug.cgi?id=72710

Reviewed by Brent Fulgham.

.:

  • Source/CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:
9:33 AM Changeset in webkit [100784] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for
fast/frames/sandboxed-iframe-parsing-space-characters.html on Mac 10.6
dbg.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
9:05 AM Changeset in webkit [100783] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Accessibility API tests not loading Gtk's accessibility implementation
​https://bugs.webkit.org/show_bug.cgi?id=72732

Reviewed by Philippe Normand.

Ensure that the GAIL module is being loaded by avoiding using
gtk_test_init() directly, but a modified version of it.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a normal GtkWidget (a
GtkWindow) as the parent container for the webView, instead of
using a dummy webView for that, which was hackish.
(testWebkitAtkSetParentForObject): Use normal GtkWidgets instead
of dummy webViews (a GtkWindow and a GtkButton).
(initializeTestingFramework): New function, identical to
gtk_test_init(), but loading GAIL as the only GTK module.
(main): Use initializeTestingFramework().

8:57 AM Changeset in webkit [100782] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; r100686 broke the EFL build when Geolocation
support is enabled.

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-18

  • platform/efl/GeolocationServiceEfl.cpp: Only declare

s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is
also declared in GeolocationService.cpp.

8:43 AM Changeset in webkit [100781] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState
​https://bugs.webkit.org/show_bug.cgi?id=72727

TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded,
so it does not need to be called again after TextureMapperNode::computeAllTransforms.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingState):

8:38 AM Changeset in webkit [100780] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
​https://bugs.webkit.org/show_bug.cgi?id=72631

Add CRASH expectation for fast/filesystem/file-writer-abort.html on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
8:18 AM Changeset in webkit [100779] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Guard for the viewportInteractionEngine as it doesn't always exist.

Reviewed by Antonio Gomes.

The engine is non-existent when the view is configured to use desktop
behavior.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::didFindZoomableArea):

8:03 AM Changeset in webkit [100778] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test for strange scrollbars with non-integer scaled SVG image
​https://bugs.webkit.org/show_bug.cgi?id=43018

Patch by Philip Rogers <​pdr@google.com> on 2011-11-18
Reviewed by Nikolas Zimmermann.

  • svg/as-image/resources/green-non-integer-size-rect.svg: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
  • svg/as-image/svg-non-integer-scaled-image.html: Added.
7:47 AM Changeset in webkit [100777] by steveblock@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

Another attempt at rebaselining fast/box-shadow for Chromium Mac 10.5.
It seems the rebaseline tool made a mess of
​http://trac.webkit.org/changeset/100742.

Unreviewed gardening.

7:43 AM Changeset in webkit [100776] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
​https://bugs.webkit.org/show_bug.cgi?id=72651

Add CRASH and TIMEOUT expectations for severla more tests.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:27 AM Changeset in webkit [100775] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation for canvas/philip/tests/2d.imageData.put.unchanged.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:22 AM Changeset in webkit [100774] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/canvas/canvas-alphaImageData-behavior.html has TEXT failure on Mac 10.5 CG
​https://bugs.webkit.org/show_bug.cgi?id=72728

Add a TEXT expectation.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
6:58 AM Changeset in webkit [100773] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip another GTK crasher.

  • platform/gtk/Skipped: Skip fast/borders/inline-mask-overlay-image-outset.html
6:56 AM Changeset in webkit [100772] by steveblock@google.com
  • 3 edits
    2 moves
    1 add in trunk/LayoutTests

Rebaseline remaining fast/ tests for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

6:50 AM Changeset in webkit [100771] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Send DidCreateDestination to DownloadProxy when destination has been created
​https://bugs.webkit.org/show_bug.cgi?id=72724

Reviewed by Martin Robinson.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Call
didCreateDestination() when destination URI has been successfully
created.

6:48 AM Changeset in webkit [100770] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Cancel current download operation before download object is deleted
​https://bugs.webkit.org/show_bug.cgi?id=72721

Reviewed by Martin Robinson.

It fixes a crash in the web process when a download finishes early
due to a failure.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::cancel): Delete current ResourceHandle.
(WebKit::Download::platformInvalidate): If there's a
ResourceHandle active, cancel the download operation and delete
the handle.
(WebKit::Download::platformDidFinish): Delete current ResourceHandle.

6:45 AM Changeset in webkit [100769] by Carlos Garcia Campos
  • 5 edits in trunk/Source

[GTK] Downloads not started by WebView only fail for transport errors
​https://bugs.webkit.org/show_bug.cgi?id=72718

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Abort the download with an error if the response contains an
error code. It adds a new test case to the download unit tests.

  • tests/testdownload.c:

(notifyDownloadStatusCallback):
(serverCallback):
(test_webkit_download_not_found):
(main):

  • webkit/webkitdownload.cpp:

(DownloadClient::didReceiveResponse): Check whether http status of
the response is an error code and emit error signal in such case.

Source/WebKit2:

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Check if the http
status of the response is an error code and finish the download
with an error in such case.

6:43 AM Changeset in webkit [100768] by steveblock@google.com
  • 4 edits
    8 moves
    5 adds
    1 delete in trunk/LayoutTests

Rebaseline remaining svg/ tests for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

6:33 AM Changeset in webkit [100767] by caio.oliveira@openbossa.org
  • 6 edits
    6 adds in trunk/Source/WebKit2

[Qt] Support customizing JS alert/confirm/prompt dialogs using QML
​https://bugs.webkit.org/show_bug.cgi?id=72319

Reviewed by Simon Hausmann.

Adds alertDialog, confirmDialog and promptDialog properties to QQuickWebView's
privateObject. These are QML components that are created by the webview when the
corresponding function is called in JS.

The dialogs are created in a context that contains a model object, similar to
ListView delegates. The "message" and "defaultValue" parameters are available
in the model object, as well as slots expected to be called by the dialog.

This commit removes the old code for supporting QWidget builtin dialogs. The code
wasn't working properly (closing any dialog was closing the app after QWindow
refactoring in Qt5).

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/alert.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/confirm.html: Added.
  • UIProcess/API/qt/tests/qmltests/common/prompt.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtDialogRunner.cpp: Added.

(QtDialogRunner::QtDialogRunner):
(QtDialogRunner::~QtDialogRunner):
(DialogContextObject::DialogContextObject):
(DialogContextObject::message):
(DialogContextObject::defaultValue):
(DialogContextObject::dismiss):
(DialogContextObject::accept):
(DialogContextObject::reject):
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::createDialog):

  • UIProcess/qt/QtDialogRunner.h: Added.

(QtDialogRunner::wasAccepted):
(QtDialogRunner::result):
(QtDialogRunner::onAccepted):

6:23 AM Changeset in webkit [100766] by steveblock@google.com
  • 1 edit
    6 moves
    3 adds in trunk/LayoutTests

Rebaseline fast/writing-mode for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

6:16 AM Changeset in webkit [100765] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

Fix compilation warning in ComplexTextControllerCoreText.mm
​https://bugs.webkit.org/show_bug.cgi?id=72702

Reviewed by Andreas Kling.

No functionality changed, so no new tests.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

6:15 AM Changeset in webkit [100764] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Support wheel event together with resizesToContents

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::handleWheelEvent):

6:00 AM Changeset in webkit [100763] by yutak@chromium.org
  • 8 edits in trunk

[Qt] Enable WebSocket hybi tests
​https://bugs.webkit.org/show_bug.cgi?id=72687

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
(DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • platform/qt/Skipped:

Unskip WebSocket hybi tests. Skip some of them which are known to fail probably due to
a bug in SocketStreamHandleQt implementation.

5:56 AM Changeset in webkit [100762] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Layer violation: WebPopupMenuProxyQtDesktop.cpp uses files from WebKit/qt ​https://bugs.webkit.org/show_bug.cgi?id=72696

Reviewed by Kenneth Rohde Christiansen.

Implement the WK2 desktop popup by simply subclassing QComboBox and doing the
same thing as QtWebComboBox from WK1 (a few lines of code).

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::eventFilter):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::populate):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.h:
5:52 AM Changeset in webkit [100761] by steveblock@google.com
  • 1 edit
    8 moves
    4 adds in trunk/LayoutTests

Rebaseline fast/repaint for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

5:48 AM Changeset in webkit [100760] by zeno.albisser@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer.
​https://bugs.webkit.org/show_bug.cgi?id=72717

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::setViewportInteractionEngine):

  • UIProcess/qt/QtTapGestureRecognizer.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setViewportInteractionEngine):

  • UIProcess/qt/QtWebPageProxy.h:
5:45 AM Changeset in webkit [100759] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Not reviewed: restore front-end compilability via updating externs and JS generator.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/externs.js:

(WebInspector.showPanelForAnchorNavigation):

  • inspector/generate-protocol-externs:
5:42 AM Changeset in webkit [100758] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix popups for select elements.

Reviewed by Tor Arne Vestbø.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createPopupMenuProxy): Fall back to the "desktop" implementation
for the moment. Better than nothing :)

5:42 AM Changeset in webkit [100757] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed debug build fix

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy): Don't assert on a non-existant
variable.

5:29 AM Changeset in webkit [100756] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: dispatch messages from the front-end to the backend asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=72621

Source/WebCore:

We should align the way we dispatch messages from the front-end to backend across the environments:

  • WebKit has it synchronoulsly
  • Chromium has it asynchronously
  • Remote debugging has it asynchronously

Making it asynchronous made a number of flaky Qt tests pass.

Tests uncovered console agent problem that was also fixed.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::clearFrontend):

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::onTimer):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::sendMessageToBackend):

  • inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::performDisconnectFromBackend):

  • src/InspectorFrontendClientImpl.h:

LayoutTests:

Now that dispatching is asynchronous, timeline test needed a fix.

Reviewed by Yury Semikhatsky.

  • inspector/timeline/timeline-script-tag-1.html:
  • platform/qt/Skipped:
5:28 AM Changeset in webkit [100755] by sergio@webkit.org
  • 4 edits in trunk

[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=72707

Reviewed by Philippe Normand.

Tools:

Make new-run-webkit-tests use the right path to locate the test
plugin used by WebKitTestRunner.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

LayoutTests:

Unskipped a test that is passing now.

  • platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html
5:16 AM Changeset in webkit [100754] by Simon Hausmann
  • 2 edits in trunk

[Qt] Unreviewed build fix: Export QQuickWebPage/Preferences private API
needed for the qml plugin.

  • Source/qtwebkit-export.map:
5:15 AM Changeset in webkit [100753] by steveblock@google.com
  • 3 edits
    3 copies
    11 moves
    2 adds in trunk/LayoutTests

Rebaseline svg/custom for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

4:56 AM Changeset in webkit [100752] by steveblock@google.com
  • 1 edit
    15 moves
    9 adds in trunk/LayoutTests

Rebaseline svg/clip-path for Chromium Mac 10.5 CG after ​http://crrev.com/110543

Unreviewed gardening.

4:43 AM Changeset in webkit [100751] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Pass screen refresh rate into compositor.
​https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <​husky@google.com> on 2011-11-18
Reviewed by Tony Gentilcore.

Source/WebCore:

Covered by CCLayerTreeHostTest.

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):

4:43 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt5 on the bots (diff)
4:42 AM EFLWebKit edited by rakuco@FreeBSD.org
Backout --data-transfer-items from the DRT build parameters as it … (diff)
4:30 AM Changeset in webkit [100750] by steveblock@google.com
  • 15 edits
    14 moves
    1 add in trunk/LayoutTests

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
​https://bugs.webkit.org/show_bug.cgi?id=72478

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-11-18
Reviewed by Dean Jackson.

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
4:12 AM Changeset in webkit [100749] by Alexandru Chiculita
  • 12 edits in trunk

[CSSShaders] Implement the computed style for mesh parameters of the custom() filter
​https://bugs.webkit.org/show_bug.cgi?id=72478

Reviewed by Dean Jackson.

Source/WebCore:

Added parsing and computed style for the mesh rows, columns, mesh box type
(filter-box, border-box, content-box and padding-box) and the detached mode.

Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly
treated as "custom(none, 10)".

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createCustomFilterOperation):

  • css/CSSValueList.h:

(WebCore::CSSValueListIterator::isPrimitiveValue):

  • platform/graphics/filters/CustomFilterOperation.h:

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
3:50 AM Changeset in webkit [100748] by Simon Hausmann
  • 2 edits in trunk

[Qt] Unreviewed build fix: Export QQuickWebViewExperimental private API
that was added since I made the export patch.

  • Source/qtwebkit-export.map:
3:46 AM Changeset in webkit [100747] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets
​https://bugs.webkit.org/show_bug.cgi?id=72708

Reviewed by Xan Lopez.

Do not use non-WebKit GtkWidget's in unit tests, to avoid problems
when GTK's accessibility implementation is not being loaded.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Use a dummy WebKitWebView
widget as the parent container needed for this unit test.
(testWebkitAtkSetParentForObject): Ditto.

3:41 AM Changeset in webkit [100746] by Simon Hausmann
  • 7 edits
    1 add in trunk

[Qt] WTR and InjectedBundle should not link statically against JSC/WTF ​https://bugs.webkit.org/show_bug.cgi?id=72697

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri: On Linux, use a GNU LD version script to manage the

symbol exports, which includes the public WK1/WK2 API as well as a bunch
of private WTF symbols needed for WTR and the Injected Bundle.

  • Source/qtwebkit-export.map: Added.

Tools:

  • Tools.pro: Make WTR linux only for the moment.
  • WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
  • WebKitTestRunner/Target.pri: Ditto.
  • qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources

with ELF visibility on Linux. Instead we're temporarily using an LD version script.

3:35 AM Changeset in webkit [100745] by Simon Hausmann
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Oops, fix ChangeLog text

3:34 AM Changeset in webkit [100744] by Simon Hausmann
  • 12 edits
    2 deletes in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 3

Reviewed by Kenneth Rohde Christiansen.

Move the remaining forwarded calls from ClientImpl that went through
ViewInterface and then PageProxy or WebView to go straight to
QtWebPageProxy. QtViewInterface is empty now and therefore removed.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::chooseFiles):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(setupPageUiClient):

  • UIProcess/qt/QtViewInterface.cpp: Removed.
  • UIProcess/qt/QtViewInterface.h: Removed.
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeStatusText):
(QtWebPageProxy::didMouseMoveOverElement):
(QtWebPageProxy::showContextMenu):
(QtWebPageProxy::hideContextMenu):
(QtWebPageProxy::runJavaScriptAlert):
(QtWebPageProxy::runJavaScriptConfirm):
(QtWebPageProxy::runJavaScriptPrompt):
(QtWebPageProxy::chooseFiles):
(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::didChangeLoadProgress):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::contextMenuItemSelected):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::hideContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
3:33 AM Changeset in webkit [100743] by kenneth@webkit.org
  • 2 edits in trunk/Tools

[Qt] Change default size of the MiniBrowser

Reviewed by Simon Hausmann.

As we lay out desktop pages using the width of 980, change our default
size to 980x735 so that we are not scaling down by default.

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

3:27 AM Changeset in webkit [100742] by steveblock@google.com
  • 2 edits
    4 adds
    9 deletes in trunk/LayoutTests

Rebaseline fast/box-shadow for Chromium Mac 10.5 after ​http://crrev.com/110543

Unreviewed gardening.

3:16 AM Changeset in webkit [100741] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] UI process segfaults, when visiblity properties are set while the WebProcess is dead.
​https://bugs.webkit.org/show_bug.cgi?id=72699

The drawing area may be null, if the web process has crashed, but not yet recovered.
Always null check against drawing area.

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-11-18
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setDrawingAreaSize):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):

3:07 AM Changeset in webkit [100740] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
​https://bugs.webkit.org/show_bug.cgi?id=72705

Reviewed by Eric Seidel.

Death to ifdefs!

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
3:01 AM Changeset in webkit [100739] by Simon Hausmann
  • 8 edits in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Move all functions that forwarded from QtWebPageProxy to QtViewInterface and then
to QQuickWebView straight into QtWebPageProxy.

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::isViewWindowActive):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::pageDidRequestScroll):
(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::toolTipChanged):
(QtWebPageProxy::didChangeUrl):
(QtWebPageProxy::didChangeTitle):
(QtWebPageProxy::loadDidBegin):
(QtWebPageProxy::loadDidCommit):
(QtWebPageProxy::loadDidSucceed):
(QtWebPageProxy::loadDidFail):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::startDrag):
(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:
2:54 AM Changeset in webkit [100738] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline acid3.html for Chromium Mac 10.5

The image contains the text 'YOU SHOULD NOT SEE THIS AT ALL', but so do
all other Chromium expected results for this test, so I'm guessing this
is expected.

Unreviewed gardening.

2:37 AM Changeset in webkit [100737] by abarth@webkit.org
  • 3 edits
    6 moves in trunk/Source/WebCore

Move some mediastream related files into the mediastream directory
​https://bugs.webkit.org/show_bug.cgi?id=72695

Reviewed by Eric Seidel.

Just moving the files to the proper directory.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h.

(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
(WebCore::NavigatorUserMediaError::code):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

  • mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl.
  • mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h.

(WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):

  • mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl.
  • mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h.

(WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):

  • mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl.
2:27 AM Changeset in webkit [100736] by Simon Hausmann
  • 10 edits in trunk/Source/WebKit2

[Qt] Removal of QtViewInterface part 1

Reviewed by Kenneth Rohde Christiansen.

Replace functions of QtViewInterface that forward to QQuickWebPage with direct
usage of QQuickWebPage. Also removed some dead code.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::sceneGraphUpdateQueue):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::isVisible):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setViewNeedsDisplay):
(QtWebPageProxy::viewSize):
(QtWebPageProxy::isViewFocused):
(QtWebPageProxy::isViewVisible):
(QtWebPageProxy::didRelaunchProcess):

  • UIProcess/qt/QtWebPageProxy.h:

(QtWebPageProxy::qmlWebPage):

  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
2:22 AM Changeset in webkit [100735] by caseq@chromium.org
  • 8 edits in trunk

Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon
​https://bugs.webkit.org/show_bug.cgi?id=45955

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI):
(injectedExtensionAPI.ButtonImpl.prototype.update):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get statusBarItems):
(WebInspector.ExtensionPanel.prototype.addStatusBarItem):
(WebInspector.ExtensionButton):
(WebInspector.ExtensionButton.prototype.update):
(WebInspector.ExtensionButton.prototype._onClicked):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyButtonClicked):
(WebInspector.ExtensionServer.prototype._onCreateStatusBarButton):
(WebInspector.ExtensionServer.prototype._onUpdateButton):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/inspector.css:

(button.status-bar-item.extension):

LayoutTests:

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
2:05 AM Changeset in webkit [100734] by commit-queue@webkit.org
  • 5 edits
    1 move
    1 delete in trunk/Source/WebCore

MediaStream API: Merging the PeerConnectionHandler.h files
​https://bugs.webkit.org/show_bug.cgi?id=72611

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-18
Reviewed by Adam Barth.

No actual code changes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h.
  • platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed.
1:04 AM Changeset in webkit [100733] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, mark media/audio-garbage-collect.html flaky on GTK.

  • platform/gtk/test_expectations.txt:
12:36 AM Changeset in webkit [100732] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit
​https://bugs.webkit.org/show_bug.cgi?id=72694

  • platform/qt/Skipped: Skip fast/canvas/canvas-lineWidth.html until fix.
12:21 AM Changeset in webkit [100731] by Simon Hausmann
  • 18 edits in trunk/Source

[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places ​https://bugs.webkit.org/show_bug.cgi?id=72597

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved code that queries the third party cookie policy from QWebSettings
out of WebCore. Instead NetworkingContext has now the interface that allows
delegating the functionality into WebKit/qt.

In order to do that we need to pass the NetworkingContext around, which is used to
retrieve the cookie jar and the originating frame object pointer.

  • platform/network/NetworkingContext.h: Add interface.
  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest.
(WebCore::QNetworkReplyHandler::redirect): Ditto.

  • platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can

also provide the same plus more (cookie jar, policy callback).

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest): Ditto.

  • platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and

call new thirdPartyCookiePolicyPermits API that takes the context as parameter.
(WebCore::networkingContext):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

  • platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings

with useage of NetworkingContext.
(WebCore::thirdPartyCookiePolicyPermits):

  • platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

Implemented NetworkingContext::thirdPartyCookiePolicyPermission, which queries
QWebSettings.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows): Adapt to the
changed thirdPartyCookiePolicyPermits WebCore API that operates on a networking context.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Pass networking
context to ResourceRequest::toNetworkRequest.
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
(WebCore::FrameLoaderClientQt::startDownload): Ditto.

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::thirdPartyCookiePolicyPermission): Implement.

  • WebCoreSupport/FrameNetworkingContextQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::thirdPartyCookiePolicy): Adapt to QtDRTSupport API change.

Source/WebKit2:

Stub implementation of new NetworkingContext::thirdPartyCookiePolicyPermission
API.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

Nov 17, 2011:

11:42 PM Changeset in webkit [100730] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=72602

Unskip tests after the fix on Qt.

  • platform/qt/Skipped:
11:41 PM Changeset in webkit [100729] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=72602

Fixed StringImpl::foldCase by adding return in the case we need to handle
folding of 8 bit strings with Latin-1 characters.

Fixed case where StringImpl::replace was using a char temp instead of an
LChar temp.

Because of the second change, I changed other uses of char or
unsigned char to LChar.

Patch by Michael Saboff <​msaboff@apple.com> on 2011-11-17
Reviewed by Zoltan Herczeg.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::replace):

11:27 PM Changeset in webkit [100728] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
​https://bugs.webkit.org/show_bug.cgi?id=71997

Reviewed by Dan Bernstein.

The cause is a null dereference of a fontData that is stored in
ComplexTextRun. The fontData is initialized by using the
fontCache, but it could be null when the font is in fallback
list. The reason a font from the fallback list might not be in the
font Cache is that it may be a web font. Before looking up the
fontCache, try to see whether the font is in the fallback list.

No new tests. We don't have webfonts that can produce the problem.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache.

10:57 PM Changeset in webkit [100727] by commit-queue@webkit.org
  • 13 edits in trunk

Remove initProgressEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
​http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

  • dom/ProgressEvent.cpp:
  • dom/ProgressEvent.h:
  • dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
10:14 PM Changeset in webkit [100726] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

[EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
EflKeyboardUtilities.cpp to use in the WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=62451

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions
in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I
moved them to the separated file - EflKeyboardUtilities.cpp.

  • PlatformEfl.cmake:
  • platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp.

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
(WebCore::keyIdentifierForEvasKeyName):
(WebCore::windowsKeyCodeForEvasKeyName):

  • platform/efl/EflKeyboardUtilities.h: Added.
  • platform/efl/PlatformKeyboardEventEfl.cpp:
10:09 PM Changeset in webkit [100725] by Martin Robinson
  • 7 edits in trunk/Source

[GTK] The process freezes when you right click on windowless Flash
​https://bugs.webkit.org/show_bug.cgi?id=69123

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. I tried to create a layout test that exercised this
issue, but it appears that EventSender clicks do not trigger
it. This is covered by the manual tests containing Flash.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks): Always activate the
windowless Flash quirk if on x86_64 and X11.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handleMouseEvent): Avoid sending right-click
events if we have the quirk.

Source/WebKit2:

Add a new plugin quirk for dealing with right-clicking on
windowless Flash on x86_64 machines. This already exists for
WebKit1.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks): If the plugin is
Flash and we are on x86_64, then disable sending right-clicking
events while in windowless mode.

  • Shared/Plugins/PluginQuirks.h: Add the new quirk.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent): If the quirk
is active don't send right click events.

9:52 PM Changeset in webkit [100724] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Add matrix list to reuse tile matrix for each different zoom level.
​https://bugs.webkit.org/show_bug.cgi?id=68595

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

Add matrix list to keep each tile matrix corresponding to each different zoom level when zoom level is changed.
Then backing store can reuse tile matrix by getting it from this matrix list.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_model_matrix_create):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_new):

  • ewk/ewk_tiled_matrix.h:
9:47 PM Changeset in webkit [100723] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clear fixme in generator script
​https://bugs.webkit.org/show_bug.cgi?id=71372

Remove unnecessary field name map and update license year number.

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2011-11-17
Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.py:
9:43 PM Changeset in webkit [100722] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Clean up the use of DATA_DIR in the buildsystem
​https://bugs.webkit.org/show_bug.cgi?id=72681

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

.:

  • Source/cmake/OptionsEfl.cmake: Rename DATA_DIR to DATA_INSTALL_DIR

and add it to the cache; add a variable with the path of the generated
theme and remove the -DDATA_DIR definition, it was moved to
PlatformEFL.cmake in WebCore.

Source/WebCore:

Add the -DDATA_DIR definition here instead of defining it globally in
OptionsEfl.cmake, as WebCore is the only place which needs it.

No new tests, this is a buildsystem change.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Instead of messing with BUILD_DATA_DIR and PARENT_SCOPE, just use
THEME_BINARY_DIR as defined in OptionsEfl.cmake.

  • CMakeListsEfl.txt:

Tools:

Instead of adding -DDATA_DIR in all scopes, only define it in
WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
it.

We can then define DATA_DIR to the generated theme directory for
EWebLauncher, since it's what we want here.

  • CMakeListsEfl.txt:
9:41 PM Changeset in webkit [100721] by adamk@chromium.org
  • 6 edits
    2 adds in trunk

Move JS recursion counter from V8Proxy to V8BindingPerIsolateData
​https://bugs.webkit.org/show_bug.cgi?id=72645

Reviewed by Adam Barth.

Source/WebCore:

With the JS recursion level stored as a member of V8Proxy, it's tied
to a frame. But this is incorrect, as there's no reason that a JS call
stack need be restricted to a single frame (see my new test case for
an example of code going across frames).

In order to get the correct accounting of JS recursion level, per-Isolate
is the right granularity (per dslomov), which is what this patch accomplishes.

Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::recursionLevel):
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

  • bindings/v8/V8Proxy.cpp:

(WebCore::incrementRecursionLevel):
(WebCore::decrementRecursionLevel):
(WebCore::recursionLevel):
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::didLeaveScriptContext):

  • bindings/v8/V8Proxy.h:

LayoutTests:

Added tests to exercise new timing of call to V8Proxy::didLeaveScriptContext().

  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt: Added.
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Added.
9:38 PM Changeset in webkit [100720] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Move platform includes last in DRT's include directories.
​https://bugs.webkit.org/show_bug.cgi?id=72684

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-17
Reviewed by Daniel Bates.

This is the first step in fixing the build when a platform include (in
this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
is included instead of WebKit's.

  • DumpRenderTree/efl/CMakeLists.txt:
9:30 PM Changeset in webkit [100719] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] acid3.html didn't actually get rebaselined like I wanted.

Unreviewed, gardening.

  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
  • platform/chromium/test_expectations.txt:
9:25 PM Changeset in webkit [100718] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[chromium] Font::drawComplexText can not draw a segment of text run
​https://bugs.webkit.org/show_bug.cgi?id=72095

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2011-11-17
Reviewed by Adam Barth.

Source/WebCore:

drawComplexText() should respect the 'from' and 'to' arguments.
Drawing the whole text run may result in text overlapping.

Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::ComplexTextController::glyphsForRange):

  • platform/graphics/chromium/ComplexTextControllerLinux.h:
  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::drawComplexText):

LayoutTests:

  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.png: Added.
  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html: Added.
9:02 PM Changeset in webkit [100717] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix broken expectation.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
8:58 PM Changeset in webkit [100716] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Unique SecurityOrigins shouldn't remember their old schemes and hosts
​https://bugs.webkit.org/show_bug.cgi?id=71745

Reviewed by Darin Adler.

This is the final step in this series of patches.

This patch removes the forceUnique flag from SecurityOrigin::create.
Now, we create unique origins without passing in the document's URL,
preventing information from the document's URL from leaking into the
unique origin.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getOriginsWithCache):

  • Update this callsite to use createFromString, which does exactly what this code is doing manually.
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create):

  • page/SecurityOrigin.h:
8:55 PM Changeset in webkit [100715] by scheib@chromium.org
  • 7 edits in trunk/Source

Pointer Lock: Page Settings unecessary
​https://bugs.webkit.org/show_bug.cgi?id=72662

Reviewed by Darin Fisher.

Source/WebCore:

No new tests.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
8:30 PM Changeset in webkit [100714] by cevans@google.com
  • 2 edits
    6 copies in branches/chromium/912

Merge 99744
BUG=99732

8:23 PM Changeset in webkit [100713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't clamp minimumPageScaleFactor when doc width is zero
​https://bugs.webkit.org/show_bug.cgi?id=72679

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-17
Reviewed by James Robinson.

For a brief period during initialization, the document width can be
zero. In that situation, don't try to limit minimumPageScaleFactor
to the document size.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactorLimits):

8:13 PM Changeset in webkit [100712] by pkasting@chromium.org
  • 9 edits
    20 adds
    7 deletes in trunk/LayoutTests

[chromium] Try to rebaseline more tests.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
8:12 PM Changeset in webkit [100711] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/912

Merge 100502
BUG=102359
Review URL: ​http://codereview.chromium.org/8598007

8:09 PM Changeset in webkit [100710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Disable incremental uploading in threaded compositing path
​https://bugs.webkit.org/show_bug.cgi?id=72669

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-17
Reviewed by Kenneth Russell.

Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
updates in an atomic fashion.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

6:51 PM Changeset in webkit [100709] by pkasting@chromium.org
  • 4 edits
    1 copy in trunk/LayoutTests

[chromium] Attempt to rebaseline a test after ​http://crrev.com/110053 .

Unreviewed, gardening.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Copied from platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [100708] by nduca@chromium.org
  • 5 edits in trunk/Source

[chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
​https://bugs.webkit.org/show_bug.cgi?id=71638

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(TestHooks::animateAndLayout):
(MockLayerTreeHostClient::animateAndLayout):
(CCLayerTreeHostTest::postSetNeedsAnimateToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::CCLayerTreeHostTestSetNeedsAnimate):
(CCLayerTreeHostTestSetNeedsAnimate::beginTest):
(CCLayerTreeHostTestSetNeedsAnimate::animateAndLayout):
(CCLayerTreeHostTestSetNeedsAnimate::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsAnimate::afterTest):

5:46 PM Changeset in webkit [100707] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark some inspector tests as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=72651

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [100706] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove bogus ASSERT.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

5:28 PM Changeset in webkit [100705] by pkasting@chromium.org
  • 3 edits
    2 copies in trunk

Unreviewed, rolling out r100698.
​http://trac.webkit.org/changeset/100698
​https://bugs.webkit.org/show_bug.cgi?id=72239

This change wasn't the problem either.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

  • accessibility/loading-iframe-sends-notification.html: Copied from LayoutTests/accessibility/loading-iframe-sends-notification.html.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt.
5:21 PM Changeset in webkit [100704] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't include internal GTK headers so we build with GTK_DISABLE_SINGLE_INCLUDES

​https://bugs.webkit.org/show_bug.cgi?id=72653

Patch by Elliot Glaysher <​erg@chromium.org> on 2011-11-17
Reviewed by James Robinson.

  • src/gtk/WebInputEventFactory.cpp:

(WebKit::gdkStateToWebEventModifiers): Remove a
GTK_CHECK_VERSION that will always be true, as the oldest
libgtk we support is 2.18.

5:18 PM Changeset in webkit [100703] by mrowe@apple.com
  • 8 edits in trunk/Source

Roll out r100668 until I can work out why we're using such an ancient version of Xcode on our SnowLeopard bots.

4:48 PM Changeset in webkit [100702] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Calls to paintContentsIfDirty() and updateCompositorResources() should be balanced.
​https://bugs.webkit.org/show_bug.cgi?id=72630

Patch by David Reveman <​reveman@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Source/WebCore:

Layer property changes during paintContent() can leave the layer
in an invalid state as paintContentsIfDirty() has been called
without a matching updateCompositorResources() call. Removing
conditionals around these calls ensure they are balanced.

This patch is tested by the following unit test:

  • CCLayerTreeHostTestOpacityChange.runMultiThread
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Add test that check if calls to paintContentsIfDirty() and
updateCompositorResources() are balanced when layer opacity
changes during paintContent().

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::layerTreeHost):
(WTF::TestOpacityChangeLayerDelegate::TestOpacityChangeLayerDelegate):
(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::TestOpacityChangeLayerDelegate::drawsContent):
(WTF::TestOpacityChangeLayerDelegate::preserves3D):
(WTF::TestOpacityChangeLayerDelegate::notifySyncRequired):
(WTF::ContentLayerChromiumWithUpdateTracking::create):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::resetUpdateCount):
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::updateCompositorResources):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::CCLayerTreeHostTestOpacityChange):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestOpacityChange::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::TEST_F):

4:47 PM Changeset in webkit [100701] by Patrick Gansterer
  • 4 edits in trunk/Source/JavaScriptCore

[CMake] Move FAST_MALLOC specific lines from Platform*.cmake to CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=72644

Reviewed by Brent Fulgham.

All ports need to do the same determination about fast malloc. Move the CMake code from
platform specific files into the generic one, so that additional ports can reuse it.

  • wtf/CMakeLists.txt:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformWinCE.cmake:
4:46 PM Changeset in webkit [100700] by rniwa@webkit.org
  • 3 edits in trunk/Tools

fuzzy_match doesn't recognize "Dan B" or "hyatt"
​https://bugs.webkit.org/show_bug.cgi?id=72636

Reviewed by Eric Seidel.

Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
and user names of email addreses such as rniwa in ​rniwa@webkit.org.

Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
4:39 PM Changeset in webkit [100699] by eric@webkit.org
  • 3 edits in trunk/Tools

Remove support for running check-webkit-style w/o a webkit checkout
​https://bugs.webkit.org/show_bug.cgi?id=72678

Reviewed by Adam Barth.

After talking to Dave Levin we've decided to remove this
code. I know of no users of check-webkit-style w/o a webkit checkout
and this needlessly adds complexity.

  • Scripts/webkitpy/style/main.py:
4:27 PM Changeset in webkit [100698] by pkasting@chromium.org
  • 3 edits
    2 deletes in trunk

Source/WebCore: Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
​https://bugs.webkit.org/show_bug.cgi?id=72676

Patch by Adam Barth <​abarth@webkit.org> on 2011-11-17
Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

  • dom/DOMImplementation.cpp:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

  • dom/Document.h:
  • xml/XSLTProcessor.cpp:

LayoutTests: Unreviewed, rolling out r100584.
​http://trac.webkit.org/changeset/100584
​https://bugs.webkit.org/show_bug.cgi?id=72239

See if this change caused Linux dbg crashes.

  • accessibility/loading-iframe-sends-notification.html: Removed.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Removed.
4:23 PM Changeset in webkit [100697] by eric@webkit.org
  • 7 edits in trunk/Tools

Remove more direct uses of os.path
​https://bugs.webkit.org/show_bug.cgi?id=72677

Reviewed by Adam Barth.

Remove more uses of os.path, including refactoring
CommitterValidator to use a Host object instead of
manual hacks to emulate what SCM and FileSystem provide.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/config/committervalidator.py:
  • Scripts/webkitpy/common/config/committervalidator_unittest.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
    • Turns out none of our unittests actually looked at this path. now I've made it be a valid path.
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/commands/queues.py:
4:20 PM Changeset in webkit [100696] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
​https://bugs.webkit.org/show_bug.cgi?id=72676

Reviewed by Eric Seidel.

It looks like this cargo-cult started with initDNSPrefetch being hacked
into setSecurityOrigin. I've removed this hack along with the
copy/paste code.

  • dom/DOMImplementation.cpp:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::open):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setSecurityOrigin):

  • dom/Document.h:
  • xml/XSLTProcessor.cpp:
4:11 PM Changeset in webkit [100695] by pkasting@chromium.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r100676.
​http://trac.webkit.org/changeset/100676
​https://bugs.webkit.org/show_bug.cgi?id=72393

Looks like r100572 was not the source of the crashes.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
3:55 PM Changeset in webkit [100694] by eric@webkit.org
  • 4 edits in trunk/Tools

Teach TextFileReader about FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=72673

Reviewed by Adam Barth.

Unfortunately TextFileReader doesn't use FileSystem
everywhere yet, so we can't move the unittests to
using MockFileSystem, but we're close.

  • Scripts/webkitpy/style/filereader.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/style/main.py:
3:53 PM Changeset in webkit [100693] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Absolute child is not repainted when parent opacity changes
​https://bugs.webkit.org/show_bug.cgi?id=68777

Patch by Konstantin Scheglov <​scheglov@google.com> on 2011-11-17
Reviewed by Simon Fraser.

Source/WebCore:

First time when we change opacity for parent we don't have layer, so
diff=StyleDifferenceRepaint is used instead of diff=StyleDifferenceRepaintLayer.
Layer is created later, in styleDidChange().
So, when we recalculate later diff, we now check for diff=StyleDifferenceRepaintLayer and
performs repaintIncludingDescendants().

Test: fast/layers/layer-absolute-parent-opacity.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle): Call repaintIncludingDescendants() instead of repaint().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Add ContextSensitivePropertyOpacity when change opacity.

LayoutTests:

  • fast/layers/layer-absolute-parent-opacity-expected.png: Added.
  • fast/layers/layer-absolute-parent-opacity-expected.txt: Added.
  • fast/layers/layer-absolute-parent-opacity.html: Added.
3:35 PM Changeset in webkit [100692] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

r100311 dropped a RefPtr that is very
helpful. Add it back.
​https://bugs.webkit.org/show_bug.cgi?id=72647

Reviewed by Adam Barth.

http/tests/misc/xslt-bad-import.html should
stop crashing in full chromium builds.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadDone):

3:33 PM Changeset in webkit [100691] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor SecurityOrigin::create to be easier to understand
​https://bugs.webkit.org/show_bug.cgi?id=72342

Reviewed by Eric Seidel.

Over time, the SecurityOrigin constructor has grown a bit out of
control. This patch attempts to separate the different concerns into
free functions. The general approach is to put more logic in the
"create" function and introduce a simple constructor for unique
origins.

This patch shouldn't change any behavior.

  • page/SecurityOrigin.cpp:

(WebCore::schemeRequiresAuthority):
(WebCore::shouldUseInnerURL):
(WebCore::extractInnerURL):
(WebCore::isDirectory):
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
(WebCore::SecurityOrigin::databaseIdentifier):

  • page/SecurityOrigin.h:
3:27 PM Changeset in webkit [100690] by enne@google.com
  • 9 edits
    4 adds
    11 deletes in trunk/LayoutTests

[chromium] Unreviewed, rebaseline tests after r100545.

  • platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [100689] by eric@webkit.org
  • 5 edits in trunk/Tools

Give check-webkit-style a Host
​https://bugs.webkit.org/show_bug.cgi?id=72670

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
    • We don't run these unittests, but this one was looking for the wrong exception.
  • Scripts/webkitpy/style/main.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
    • This was create a new scm object even though it already had one?
3:22 PM Changeset in webkit [100688] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed - skipping accessibility/loading-iframe-sends-notification.html
on Mac until bug 72624 is resolved.

3:19 PM Changeset in webkit [100687] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

Implement CSS3 Images cross-fade() image function
​https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Patch by Tim Horton <​hortont424@gmail.com> on 2011-11-17
Reviewed by Simon Fraser.

Fix fast/css/getComputedStyle/computed-style-cross-fade.html to use the "dummy" protocol for its
images, so that we don't have loading errors.

Unskip the test on Qt.

Remove the (now) unnecessary Gtk baselines.

  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
  • fast/css/getComputedStyle/computed-style-cross-fade.html:
  • platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Removed.
  • platform/qt/Skipped:
3:14 PM Changeset in webkit [100686] by Patrick Gansterer
  • 4 edits in trunk

[CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=72643

Reviewed by Brent Fulgham.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
3:05 PM Changeset in webkit [100685] by knorton@google.com
  • 3 edits in trunk

Several void functions in FrameView and RenderObject actually return values.
​https://bugs.webkit.org/show_bug.cgi?id=72640

Reviewed by Adam Barth.

  • ../../Source/WebCore/page/FrameView.cpp:
  • ../../Source/WebCore/rendering/RenderObject.cpp:
3:02 PM Changeset in webkit [100684] by eric@webkit.org
  • 4 edits in trunk/Tools

Move check-webkit-style change_directory code to more modern mocks
​https://bugs.webkit.org/show_bug.cgi?id=72664

Reviewed by Adam Barth.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/main.py:
  • Scripts/webkitpy/style/main_unittest.py:
3:01 PM Changeset in webkit [100683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] enable ref tests
​https://bugs.webkit.org/show_bug.cgi?id=72601

Re-enable ref tests. Run the driver under evenly numbered display if performing
pixel tests or under oddly numbered display otherwise. This prevents the ref tests
being run in an already used Xvfb instance if pixel tests are disabled.

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-11-17
Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None

after the process is killed

2:51 PM Changeset in webkit [100682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix minor style nit in CCLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=71070

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-11-17
Reviewed by James Robinson.

Fixes if-statements on several settors to follow WebKit
conventions. Existing CCLayerImplTest unit tests already cover
this change.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBounds):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
(WebCore::CCLayerImpl::setDrawsContent):
(WebCore::CCLayerImpl::setAnchorPoint):
(WebCore::CCLayerImpl::setAnchorPointZ):
(WebCore::CCLayerImpl::setBackgroundColor):
(WebCore::CCLayerImpl::setMasksToBounds):
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setPosition):
(WebCore::CCLayerImpl::setPreserves3D):
(WebCore::CCLayerImpl::setZoomAnimatorTransform):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
(WebCore::CCLayerImpl::setDebugBorderColor):
(WebCore::CCLayerImpl::setDebugBorderWidth):
(WebCore::CCLayerImpl::setContentBounds):
(WebCore::CCLayerImpl::setScrollPosition):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::setScaleDelta):
(WebCore::CCLayerImpl::setDoubleSided):

2:49 PM Changeset in webkit [100681] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=72416

Added code to release _cache_event_source and _timer_event_source
after they are canceled. Also added defensive code to
clean up the _timer_event_source in uninstall().

Reviewed by Geoffrey Garen.

No new tests, fixing leaks caught by leaks bot.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):

2:49 PM Changeset in webkit [100680] by igor.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Fix TransformOperation serialization
​https://bugs.webkit.org/show_bug.cgi?id=72625

SimpleArgumentCoder can encode and decode just POD types. And according the
ISO/IEC 14882, POD types does not have virtual methods, however TransformOperation
has pure virtual methods.

This patch fixes TransformOperation subclass serialization.

Reviewed by Noam Rosenthal.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
(CoreIPC::encodeOperation):
(CoreIPC::decodeOperation):

  • Shared/WebCoreArgumentCoders.h:
2:36 PM Changeset in webkit [100679] by leviw@chromium.org
  • 12 edits in branches/subpixellayout/Source/WebCore

Correcting MathML painting to use integers and rounding MouseRelatedEvent's offsetX and offsetY results.

2:34 PM Changeset in webkit [100678] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Tools

Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
​https://bugs.webkit.org/show_bug.cgi?id=72620

Reviewed by David Levin.

Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
adding the suffix the cpp file. One example of false positive
​https://bugs.webkit.org/show_bug.cgi?id=72319#c12.

  • Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its

basename contains the cpp's basename.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
2:34 PM Changeset in webkit [100677] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from positioned generated content under run-in
​https://bugs.webkit.org/show_bug.cgi?id=70456

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

Modified handling of run-in children to clear generated children
before removing the parent from the render tree. This caused problems
with absolute positioned children being not properly removed from the
positioned object list of the RenderView.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

Layout test for crash condition.

  • fast/css-generated-content/positioned-generated-content-under-run-in-crash-expected.html: Added
  • fast/css-generated-content/positioned-generated-content-under-run-in-crash.html: Added
2:32 PM Changeset in webkit [100676] by pkasting@chromium.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r100572.
​https://bugs.webkit.org/show_bug.cgi?id=72393
​https://bugs.webkit.org/show_bug.cgi?id=72651

May have caused seg faults on Chromium Linux dbg bot.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
2:27 PM Changeset in webkit [100675] by eric@webkit.org
  • 3 edits in trunk/Tools

Move check-webkit-style's guts into webkitpy/style/main.py
​https://bugs.webkit.org/show_bug.cgi?id=72657

Reviewed by Adam Barth.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/main.py:
2:13 PM Changeset in webkit [100674] by eric@webkit.org
  • 13 edits in trunk/Tools

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment, just like ORWT did.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/efl.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
2:08 PM Changeset in webkit [100673] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
​https://bugs.webkit.org/show_bug.cgi?id=72615

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2:04 PM Changeset in webkit [100672] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add finalizer to JSActivation
​https://bugs.webkit.org/show_bug.cgi?id=72575

Reviewed by Geoffrey Garen.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
(JSC::JSActivation::finalize):

  • runtime/JSActivation.h: Replaced virtual destructor with static finalize function.
2:03 PM Changeset in webkit [100671] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

1:57 PM Changeset in webkit [100670] by commit-queue@webkit.org
  • 3 edits
    441 deletes in trunk

Unreviewed, rolling out r100652.
​http://trac.webkit.org/changeset/100652
​https://bugs.webkit.org/show_bug.cgi?id=72648

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-17

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline):

LayoutTests:

  • css2.1/20110323/outline-color-001.htm: Removed.
  • css2.1/20110323/outline-color-002.htm: Removed.
  • css2.1/20110323/outline-color-003.htm: Removed.
  • css2.1/20110323/outline-color-004.htm: Removed.
  • css2.1/20110323/outline-color-005.htm: Removed.
  • css2.1/20110323/outline-color-006.htm: Removed.
  • css2.1/20110323/outline-color-007.htm: Removed.
  • css2.1/20110323/outline-color-008.htm: Removed.
  • css2.1/20110323/outline-color-009.htm: Removed.
  • css2.1/20110323/outline-color-010.htm: Removed.
  • css2.1/20110323/outline-color-011.htm: Removed.
  • css2.1/20110323/outline-color-012.htm: Removed.
  • css2.1/20110323/outline-color-013.htm: Removed.
  • css2.1/20110323/outline-color-014.htm: Removed.
  • css2.1/20110323/outline-color-015.htm: Removed.
  • css2.1/20110323/outline-color-016.htm: Removed.
  • css2.1/20110323/outline-color-017.htm: Removed.
  • css2.1/20110323/outline-color-018.htm: Removed.
  • css2.1/20110323/outline-color-019.htm: Removed.
  • css2.1/20110323/outline-color-020.htm: Removed.
  • css2.1/20110323/outline-color-021.htm: Removed.
  • css2.1/20110323/outline-color-022.htm: Removed.
  • css2.1/20110323/outline-color-023.htm: Removed.
  • css2.1/20110323/outline-color-024.htm: Removed.
  • css2.1/20110323/outline-color-025.htm: Removed.
  • css2.1/20110323/outline-color-026.htm: Removed.
  • css2.1/20110323/outline-color-027.htm: Removed.
  • css2.1/20110323/outline-color-028.htm: Removed.
  • css2.1/20110323/outline-color-029.htm: Removed.
  • css2.1/20110323/outline-color-030.htm: Removed.
  • css2.1/20110323/outline-color-031.htm: Removed.
  • css2.1/20110323/outline-color-032.htm: Removed.
  • css2.1/20110323/outline-color-033.htm: Removed.
  • css2.1/20110323/outline-color-034.htm: Removed.
  • css2.1/20110323/outline-color-035.htm: Removed.
  • css2.1/20110323/outline-color-036.htm: Removed.
  • css2.1/20110323/outline-color-037.htm: Removed.
  • css2.1/20110323/outline-color-038.htm: Removed.
  • css2.1/20110323/outline-color-039.htm: Removed.
  • css2.1/20110323/outline-color-040.htm: Removed.
  • css2.1/20110323/outline-color-041.htm: Removed.
  • css2.1/20110323/outline-color-042.htm: Removed.
  • css2.1/20110323/outline-color-043.htm: Removed.
  • css2.1/20110323/outline-color-044.htm: Removed.
  • css2.1/20110323/outline-color-045.htm: Removed.
  • css2.1/20110323/outline-color-046.htm: Removed.
  • css2.1/20110323/outline-color-047.htm: Removed.
  • css2.1/20110323/outline-color-048.htm: Removed.
  • css2.1/20110323/outline-color-049.htm: Removed.
  • css2.1/20110323/outline-color-050.htm: Removed.
  • css2.1/20110323/outline-color-051.htm: Removed.
  • css2.1/20110323/outline-color-052.htm: Removed.
  • css2.1/20110323/outline-color-053.htm: Removed.
  • css2.1/20110323/outline-color-054.htm: Removed.
  • css2.1/20110323/outline-color-055.htm: Removed.
  • css2.1/20110323/outline-color-056.htm: Removed.
  • css2.1/20110323/outline-color-057.htm: Removed.
  • css2.1/20110323/outline-color-058.htm: Removed.
  • css2.1/20110323/outline-color-059.htm: Removed.
  • css2.1/20110323/outline-color-060.htm: Removed.
  • css2.1/20110323/outline-color-061.htm: Removed.
  • css2.1/20110323/outline-color-062.htm: Removed.
  • css2.1/20110323/outline-color-063.htm: Removed.
  • css2.1/20110323/outline-color-064.htm: Removed.
  • css2.1/20110323/outline-color-065.htm: Removed.
  • css2.1/20110323/outline-color-066.htm: Removed.
  • css2.1/20110323/outline-color-067.htm: Removed.
  • css2.1/20110323/outline-color-068.htm: Removed.
  • css2.1/20110323/outline-color-069.htm: Removed.
  • css2.1/20110323/outline-color-070.htm: Removed.
  • css2.1/20110323/outline-color-071.htm: Removed.
  • css2.1/20110323/outline-color-072.htm: Removed.
  • css2.1/20110323/outline-color-073.htm: Removed.
  • css2.1/20110323/outline-color-074.htm: Removed.
  • css2.1/20110323/outline-color-075.htm: Removed.
  • css2.1/20110323/outline-color-076.htm: Removed.
  • css2.1/20110323/outline-color-077.htm: Removed.
  • css2.1/20110323/outline-color-078.htm: Removed.
  • css2.1/20110323/outline-color-079.htm: Removed.
  • css2.1/20110323/outline-color-080.htm: Removed.
  • css2.1/20110323/outline-color-081.htm: Removed.
  • css2.1/20110323/outline-color-082.htm: Removed.
  • css2.1/20110323/outline-color-083.htm: Removed.
  • css2.1/20110323/outline-color-084.htm: Removed.
  • css2.1/20110323/outline-color-085.htm: Removed.
  • css2.1/20110323/outline-color-086.htm: Removed.
  • css2.1/20110323/outline-color-087.htm: Removed.
  • css2.1/20110323/outline-color-088.htm: Removed.
  • css2.1/20110323/outline-color-089.htm: Removed.
  • css2.1/20110323/outline-color-090.htm: Removed.
  • css2.1/20110323/outline-color-091.htm: Removed.
  • css2.1/20110323/outline-color-092.htm: Removed.
  • css2.1/20110323/outline-color-093.htm: Removed.
  • css2.1/20110323/outline-color-094.htm: Removed.
  • css2.1/20110323/outline-color-095.htm: Removed.
  • css2.1/20110323/outline-color-096.htm: Removed.
  • css2.1/20110323/outline-color-097.htm: Removed.
  • css2.1/20110323/outline-color-098.htm: Removed.
  • css2.1/20110323/outline-color-099.htm: Removed.
  • css2.1/20110323/outline-color-100.htm: Removed.
  • css2.1/20110323/outline-color-101.htm: Removed.
  • css2.1/20110323/outline-color-102.htm: Removed.
  • css2.1/20110323/outline-color-103.htm: Removed.
  • css2.1/20110323/outline-color-104.htm: Removed.
  • css2.1/20110323/outline-color-105.htm: Removed.
  • css2.1/20110323/outline-color-106.htm: Removed.
  • css2.1/20110323/outline-color-107.htm: Removed.
  • css2.1/20110323/outline-color-108.htm: Removed.
  • css2.1/20110323/outline-color-109.htm: Removed.
  • css2.1/20110323/outline-color-110.htm: Removed.
  • css2.1/20110323/outline-color-111.htm: Removed.
  • css2.1/20110323/outline-color-112.htm: Removed.
  • css2.1/20110323/outline-color-113.htm: Removed.
  • css2.1/20110323/outline-color-114.htm: Removed.
  • css2.1/20110323/outline-color-115.htm: Removed.
  • css2.1/20110323/outline-color-116.htm: Removed.
  • css2.1/20110323/outline-color-117.htm: Removed.
  • css2.1/20110323/outline-color-118.htm: Removed.
  • css2.1/20110323/outline-color-119.htm: Removed.
  • css2.1/20110323/outline-color-120.htm: Removed.
  • css2.1/20110323/outline-color-121.htm: Removed.
  • css2.1/20110323/outline-color-122.htm: Removed.
  • css2.1/20110323/outline-color-123.htm: Removed.
  • css2.1/20110323/outline-color-124.htm: Removed.
  • css2.1/20110323/outline-color-125.htm: Removed.
  • css2.1/20110323/outline-color-126.htm: Removed.
  • css2.1/20110323/outline-color-127.htm: Removed.
  • css2.1/20110323/outline-color-128.htm: Removed.
  • css2.1/20110323/outline-color-129.htm: Removed.
  • css2.1/20110323/outline-color-130.htm: Removed.
  • css2.1/20110323/outline-color-131.htm: Removed.
  • css2.1/20110323/outline-color-132.htm: Removed.
  • css2.1/20110323/outline-color-133.htm: Removed.
  • css2.1/20110323/outline-color-134.htm: Removed.
  • css2.1/20110323/outline-color-135.htm: Removed.
  • css2.1/20110323/outline-color-136.htm: Removed.
  • css2.1/20110323/outline-color-137.htm: Removed.
  • css2.1/20110323/outline-color-138.htm: Removed.
  • css2.1/20110323/outline-color-139.htm: Removed.
  • css2.1/20110323/outline-color-140.htm: Removed.
  • css2.1/20110323/outline-color-141.htm: Removed.
  • css2.1/20110323/outline-color-142.htm: Removed.
  • css2.1/20110323/outline-color-143.htm: Removed.
  • css2.1/20110323/outline-color-144.htm: Removed.
  • css2.1/20110323/outline-color-145.htm: Removed.
  • css2.1/20110323/outline-color-174.htm: Removed.
  • css2.1/20110323/outline-color-175.htm: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Removed.
1:56 PM Changeset in webkit [100669] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

1:51 PM Changeset in webkit [100668] by mrowe@apple.com
  • 8 edits in trunk/Source

<​http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/mac/WebCoreNSStringExtras.mm:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
1:50 PM Changeset in webkit [100667] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/72637> Stop performing runtime version checks on OS versions where the check can never possibly fail.

Reviewed by Simon Fraser.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::haveVImageRoundingErrorFix): When not targeting Snow Leopard we always have the fix.

1:48 PM Changeset in webkit [100666] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: The scrollArea is not correctly returning the scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=70247

Reviewed by Beth Dakin.

Source/WebCore:

A few bugs that were preventing this from working.

1) In accessibilityAttributeValue: when an element did not have a renderer() we were returning earlier than we should have
2) We were not updating and clearing the scrollbars correctly when children were cleared or when asked for.

Test: platform/mac/accessibility/scrollbars.html

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::clearChildren):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/scrollbars-expected.txt: Added.
  • platform/mac/accessibility/scrollbars.html: Added.
1:47 PM Changeset in webkit [100665] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
​https://bugs.webkit.org/show_bug.cgi?id=72516

Reviewed by Brent Fulgham.

On windows some code generators fail, if the path to the preprocessor contains spaces.
Use only the executable name to avoid this issue for now.

  • Source/cmake/OptionsCommon.cmake:
1:40 PM Changeset in webkit [100664] by commit-queue@webkit.org
  • 1 edit
    135 deletes in trunk/LayoutTests

Unreviewed, rolling out r100659.
​http://trac.webkit.org/changeset/100659
​https://bugs.webkit.org/show_bug.cgi?id=72649

"Caused outline-offset-min-assert.html to assert on debug
builds" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-17

  • platform/qt/css2.1/20110323/outline-color-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-006-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-008-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-009-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-010-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-011-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-012-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-013-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-014-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-015-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-016-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-017-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-018-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-019-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-020-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-021-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-024-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-025-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-026-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-027-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-028-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-029-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-030-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-031-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-032-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-033-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-034-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-035-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-036-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-037-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-038-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-039-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-040-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-041-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-042-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-045-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-046-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-047-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-048-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-049-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-050-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-051-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-052-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-053-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-054-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-055-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-056-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-057-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-058-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-059-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-060-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-061-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-062-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-063-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-066-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-067-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-068-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-069-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-070-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-071-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-072-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-073-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-074-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-075-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-076-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-077-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-078-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-079-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-080-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-081-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-082-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-083-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-084-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-087-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-088-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-089-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-090-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-091-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-092-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-093-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-094-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-095-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-096-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-097-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-098-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-099-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-100-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-101-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-102-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-103-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-104-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-105-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-108-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-109-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-110-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-111-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-112-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-113-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-114-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-115-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-116-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-117-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-118-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-119-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-120-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-121-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-122-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-123-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-124-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-125-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-126-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-129-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-130-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-131-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-132-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-133-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-134-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-135-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-136-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-137-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-138-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-139-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-140-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-141-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-142-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-143-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-144-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-145-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-174-expected.txt: Removed.
  • platform/qt/css2.1/20110323/outline-color-175-expected.txt: Removed.
1:34 PM Changeset in webkit [100663] by abarth@webkit.org
  • 14 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
​https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
1:15 PM Changeset in webkit [100662] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: cleanup style and naming and code in accessibility search mechanism
​https://bugs.webkit.org/show_bug.cgi?id=72570

Reviewed by Beth Dakin.

Cleanup the naming and code style within the element searching mechanism.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

1:06 PM Changeset in webkit [100661] by jchaffraix@webkit.org
  • 3 edits
    12 adds in trunk

CSS table with 100% width can overflow their containing block
​https://bugs.webkit.org/show_bug.cgi?id=72180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html

fast/table/table-in-table-percent-width-collapsing-border.html
fast/table/table-in-table-percent-width-quirks-mode.html
fast/table/table-in-table-percent-width.html

After r97555, we would include the borders in a CSS table's logical width even if the 'width'
property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
this behavior to percent 'width'.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

Several tests to check that we don't overflow our containing block with width: 100%.

  • fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width-collapsing-border.html: Added.
  • fast/table/table-in-table-percent-width-expected.png: Added.
  • fast/table/table-in-table-percent-width-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width.html: Added.
1:01 PM Changeset in webkit [100660] by enne@google.com
  • 6 edits in trunk/Source

[chromium] Implicitly skip render surfaces that won't be drawn
​https://bugs.webkit.org/show_bug.cgi?id=71038

Source/WebCore:

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests and unit tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Update a test that depends on a layer not getting removed.

Reviewed by James Robinson.

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

12:40 PM Changeset in webkit [100659] by robert@webkit.org
  • 1 edit
    135 adds in trunk/LayoutTests

Qt-specific results for tests added in r100652

Unreviewed Qt gardening.

  • platform/qt/css2.1/20110323/outline-color-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-017-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-019-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-036-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-037-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-038-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-039-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-040-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-041-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-042-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-045-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-046-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-047-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-048-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-049-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-050-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-051-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-052-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-053-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-054-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-055-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-056-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-057-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-058-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-059-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-060-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-061-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-062-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-063-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-066-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-067-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-068-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-069-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-070-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-071-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-072-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-073-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-074-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-075-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-076-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-077-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-078-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-079-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-080-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-081-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-082-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-083-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-084-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-087-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-088-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-089-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-090-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-091-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-092-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-093-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-094-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-095-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-096-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-097-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-098-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-099-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-100-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-101-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-102-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-103-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-104-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-105-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-108-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-109-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-110-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-111-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-112-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-113-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-114-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-115-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-116-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-117-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-118-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-119-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-120-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-121-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-122-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-123-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-124-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-125-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-126-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-129-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-130-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-131-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-132-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-133-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-134-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-135-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-136-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-137-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-138-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-139-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-140-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-141-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-142-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-143-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-144-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-145-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-174-expected.txt: Added.
  • platform/qt/css2.1/20110323/outline-color-175-expected.txt: Added.
12:30 PM Changeset in webkit [100658] by Simon Hausmann
  • 15 edits
    1 add in trunk

[Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode ​https://bugs.webkit.org/show_bug.cgi?id=72595

Reviewed by Noam Rosenthal.

Source/WebCore:

Removed QWebElement and QtDRTNode usage that reached from WebCore into
WebKit/qt and replaced it with the ability to register custom JSValue
conversion functions. The old code has been moved to WebKit/qt.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::QtInstance): Remove unnecessary meta type registration
(now done in QtWebElementRuntime::initialize in WebKit/qt).

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::registerCustomType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime.h:

Source/WebKit:

  • WebKit.pri: Add qwebelement_p.h to HEADERS.

Source/WebKit/qt:

Move QWebElement and QtDRTNode JS bindings from WebCore to WebKit/qt.

  • Api/qwebelement.cpp: Add QWebElement to JSValue and JSValue to QWebElement

conversion through intermediate QVariant.
(QtWebElementRuntime::create):
(QtWebElementRuntime::get):
(convertJSValueToWebElementVariant):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize): Register conversion functions for QWebElement.

  • Api/qwebelement.h:
  • Api/qwebelement_p.h: Added.
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Initialize QWebElement conversion functions for
the JS runtime.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Add QtDRTNode to JSValue and JSValue to

QtDRTNode conversion through intermediate QVariant.
(QtDRTNodeRuntime::create):
(QtDRTNodeRuntime::get):
(convertJSValueToNodeVariant):
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::initialize): Register conversion functions for QtDRTNode.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
ensure the registration of the DRTNode JS bindings.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
registration of QWebElement (now done implicitly through QWebPage ->
QtWebElementRunTime::initialize code path)

12:25 PM Changeset in webkit [100657] by Adam Roben
  • 3 edits in trunk/Tools

Fix a crash-inducing typo I introduced in r100648

Fixes <​http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
handling a crashing test

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Get the driver name from the port.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
right crashed process name.

12:09 PM Changeset in webkit [100656] by fsamuel@chromium.org
  • 8 edits in trunk/Source/WebCore

Pass Aspect Ratio to RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=72350

Reviewed by Ojan Vafai.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.h:

(WebCore::CSSValue::isAspectRatioValue):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasAspectRatio):
(WebCore::InheritedFlags::aspectRatio):
(WebCore::InheritedFlags::aspectRatioDenominator):
(WebCore::InheritedFlags::aspectRatioNumerator):
(WebCore::InheritedFlags::setHasAspectRatio):
(WebCore::InheritedFlags::setAspectRatioDenominator):
(WebCore::InheritedFlags::setAspectRatioNumerator):
(WebCore::InheritedFlags::initialHasAspectRatio):
(WebCore::InheritedFlags::initialAspectRatioDenominator):
(WebCore::InheritedFlags::initialAspectRatioNumerator):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
11:58 AM Changeset in webkit [100655] by Adam Roben
  • 3 edits in trunk/Tools

Fix NRWT's parsing of the number of excluded leaks

Fixes <​http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
leaks were excluded

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
regular expression match, not the entire matched string.

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest): Added some example output that shows how things look when leaks are
excluded.
(LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
correctly.

11:54 AM Changeset in webkit [100654] by Lucas Forschler
  • 5 edits in tags/Safari-535.9/Source

Versioning.

11:46 AM Changeset in webkit [100653] by jesus@webkit.org
  • 7 edits
    1 delete in trunk/Source/WebKit2

[Qt][WK2] Fix zero sized views in all QML tests
​https://bugs.webkit.org/show_bug.cgi?id=72633

Reviewed by Noam Rosenthal.

After r100590, zero sized WebViews are no longer supported and,
therefore, the QML API tests need to be fixed.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
11:44 AM Changeset in webkit [100652] by robert@webkit.org
  • 3 edits
    441 adds in trunk

CSS 2.1 failure: outline-color-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=71931

Source/WebCore:

Reviewed by Julien Chaffraix.

WebKit wasn't displaying the top block in these tests because it did not paint the outline
of divs with zero size.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size

LayoutTests:

Add tests covering dynamic outlines. At first glance the result
for outline-color-174.htm looks like it might be wrong but it's
really the statement at the top of the test that's misleading,
only the outline should be black not the entire box.

Reviewed by Julien Chaffraix.

  • css2.1/20110323/outline-color-001.htm: Added.
  • css2.1/20110323/outline-color-002.htm: Added.
  • css2.1/20110323/outline-color-003.htm: Added.
  • css2.1/20110323/outline-color-004.htm: Added.
  • css2.1/20110323/outline-color-005.htm: Added.
  • css2.1/20110323/outline-color-006.htm: Added.
  • css2.1/20110323/outline-color-007.htm: Added.
  • css2.1/20110323/outline-color-008.htm: Added.
  • css2.1/20110323/outline-color-009.htm: Added.
  • css2.1/20110323/outline-color-010.htm: Added.
  • css2.1/20110323/outline-color-011.htm: Added.
  • css2.1/20110323/outline-color-012.htm: Added.
  • css2.1/20110323/outline-color-013.htm: Added.
  • css2.1/20110323/outline-color-014.htm: Added.
  • css2.1/20110323/outline-color-015.htm: Added.
  • css2.1/20110323/outline-color-016.htm: Added.
  • css2.1/20110323/outline-color-017.htm: Added.
  • css2.1/20110323/outline-color-018.htm: Added.
  • css2.1/20110323/outline-color-019.htm: Added.
  • css2.1/20110323/outline-color-020.htm: Added.
  • css2.1/20110323/outline-color-021.htm: Added.
  • css2.1/20110323/outline-color-022.htm: Added.
  • css2.1/20110323/outline-color-023.htm: Added.
  • css2.1/20110323/outline-color-024.htm: Added.
  • css2.1/20110323/outline-color-025.htm: Added.
  • css2.1/20110323/outline-color-026.htm: Added.
  • css2.1/20110323/outline-color-027.htm: Added.
  • css2.1/20110323/outline-color-028.htm: Added.
  • css2.1/20110323/outline-color-029.htm: Added.
  • css2.1/20110323/outline-color-030.htm: Added.
  • css2.1/20110323/outline-color-031.htm: Added.
  • css2.1/20110323/outline-color-032.htm: Added.
  • css2.1/20110323/outline-color-033.htm: Added.
  • css2.1/20110323/outline-color-034.htm: Added.
  • css2.1/20110323/outline-color-035.htm: Added.
  • css2.1/20110323/outline-color-036.htm: Added.
  • css2.1/20110323/outline-color-037.htm: Added.
  • css2.1/20110323/outline-color-038.htm: Added.
  • css2.1/20110323/outline-color-039.htm: Added.
  • css2.1/20110323/outline-color-040.htm: Added.
  • css2.1/20110323/outline-color-041.htm: Added.
  • css2.1/20110323/outline-color-042.htm: Added.
  • css2.1/20110323/outline-color-043.htm: Added.
  • css2.1/20110323/outline-color-044.htm: Added.
  • css2.1/20110323/outline-color-045.htm: Added.
  • css2.1/20110323/outline-color-046.htm: Added.
  • css2.1/20110323/outline-color-047.htm: Added.
  • css2.1/20110323/outline-color-048.htm: Added.
  • css2.1/20110323/outline-color-049.htm: Added.
  • css2.1/20110323/outline-color-050.htm: Added.
  • css2.1/20110323/outline-color-051.htm: Added.
  • css2.1/20110323/outline-color-052.htm: Added.
  • css2.1/20110323/outline-color-053.htm: Added.
  • css2.1/20110323/outline-color-054.htm: Added.
  • css2.1/20110323/outline-color-055.htm: Added.
  • css2.1/20110323/outline-color-056.htm: Added.
  • css2.1/20110323/outline-color-057.htm: Added.
  • css2.1/20110323/outline-color-058.htm: Added.
  • css2.1/20110323/outline-color-059.htm: Added.
  • css2.1/20110323/outline-color-060.htm: Added.
  • css2.1/20110323/outline-color-061.htm: Added.
  • css2.1/20110323/outline-color-062.htm: Added.
  • css2.1/20110323/outline-color-063.htm: Added.
  • css2.1/20110323/outline-color-064.htm: Added.
  • css2.1/20110323/outline-color-065.htm: Added.
  • css2.1/20110323/outline-color-066.htm: Added.
  • css2.1/20110323/outline-color-067.htm: Added.
  • css2.1/20110323/outline-color-068.htm: Added.
  • css2.1/20110323/outline-color-069.htm: Added.
  • css2.1/20110323/outline-color-070.htm: Added.
  • css2.1/20110323/outline-color-071.htm: Added.
  • css2.1/20110323/outline-color-072.htm: Added.
  • css2.1/20110323/outline-color-073.htm: Added.
  • css2.1/20110323/outline-color-074.htm: Added.
  • css2.1/20110323/outline-color-075.htm: Added.
  • css2.1/20110323/outline-color-076.htm: Added.
  • css2.1/20110323/outline-color-077.htm: Added.
  • css2.1/20110323/outline-color-078.htm: Added.
  • css2.1/20110323/outline-color-079.htm: Added.
  • css2.1/20110323/outline-color-080.htm: Added.
  • css2.1/20110323/outline-color-081.htm: Added.
  • css2.1/20110323/outline-color-082.htm: Added.
  • css2.1/20110323/outline-color-083.htm: Added.
  • css2.1/20110323/outline-color-084.htm: Added.
  • css2.1/20110323/outline-color-085.htm: Added.
  • css2.1/20110323/outline-color-086.htm: Added.
  • css2.1/20110323/outline-color-087.htm: Added.
  • css2.1/20110323/outline-color-088.htm: Added.
  • css2.1/20110323/outline-color-089.htm: Added.
  • css2.1/20110323/outline-color-090.htm: Added.
  • css2.1/20110323/outline-color-091.htm: Added.
  • css2.1/20110323/outline-color-092.htm: Added.
  • css2.1/20110323/outline-color-093.htm: Added.
  • css2.1/20110323/outline-color-094.htm: Added.
  • css2.1/20110323/outline-color-095.htm: Added.
  • css2.1/20110323/outline-color-096.htm: Added.
  • css2.1/20110323/outline-color-097.htm: Added.
  • css2.1/20110323/outline-color-098.htm: Added.
  • css2.1/20110323/outline-color-099.htm: Added.
  • css2.1/20110323/outline-color-100.htm: Added.
  • css2.1/20110323/outline-color-101.htm: Added.
  • css2.1/20110323/outline-color-102.htm: Added.
  • css2.1/20110323/outline-color-103.htm: Added.
  • css2.1/20110323/outline-color-104.htm: Added.
  • css2.1/20110323/outline-color-105.htm: Added.
  • css2.1/20110323/outline-color-106.htm: Added.
  • css2.1/20110323/outline-color-107.htm: Added.
  • css2.1/20110323/outline-color-108.htm: Added.
  • css2.1/20110323/outline-color-109.htm: Added.
  • css2.1/20110323/outline-color-110.htm: Added.
  • css2.1/20110323/outline-color-111.htm: Added.
  • css2.1/20110323/outline-color-112.htm: Added.
  • css2.1/20110323/outline-color-113.htm: Added.
  • css2.1/20110323/outline-color-114.htm: Added.
  • css2.1/20110323/outline-color-115.htm: Added.
  • css2.1/20110323/outline-color-116.htm: Added.
  • css2.1/20110323/outline-color-117.htm: Added.
  • css2.1/20110323/outline-color-118.htm: Added.
  • css2.1/20110323/outline-color-119.htm: Added.
  • css2.1/20110323/outline-color-120.htm: Added.
  • css2.1/20110323/outline-color-121.htm: Added.
  • css2.1/20110323/outline-color-122.htm: Added.
  • css2.1/20110323/outline-color-123.htm: Added.
  • css2.1/20110323/outline-color-124.htm: Added.
  • css2.1/20110323/outline-color-125.htm: Added.
  • css2.1/20110323/outline-color-126.htm: Added.
  • css2.1/20110323/outline-color-127.htm: Added.
  • css2.1/20110323/outline-color-128.htm: Added.
  • css2.1/20110323/outline-color-129.htm: Added.
  • css2.1/20110323/outline-color-130.htm: Added.
  • css2.1/20110323/outline-color-131.htm: Added.
  • css2.1/20110323/outline-color-132.htm: Added.
  • css2.1/20110323/outline-color-133.htm: Added.
  • css2.1/20110323/outline-color-134.htm: Added.
  • css2.1/20110323/outline-color-135.htm: Added.
  • css2.1/20110323/outline-color-136.htm: Added.
  • css2.1/20110323/outline-color-137.htm: Added.
  • css2.1/20110323/outline-color-138.htm: Added.
  • css2.1/20110323/outline-color-139.htm: Added.
  • css2.1/20110323/outline-color-140.htm: Added.
  • css2.1/20110323/outline-color-141.htm: Added.
  • css2.1/20110323/outline-color-142.htm: Added.
  • css2.1/20110323/outline-color-143.htm: Added.
  • css2.1/20110323/outline-color-144.htm: Added.
  • css2.1/20110323/outline-color-145.htm: Added.
  • css2.1/20110323/outline-color-174.htm: Added.
  • css2.1/20110323/outline-color-175.htm: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-003-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-006-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-007-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-008-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-009-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-010-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-011-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-012-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-013-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-014-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-015-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-016-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-017-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-018-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-019-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-020-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-021-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-022-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-023-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-024-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-025-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-026-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-027-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-028-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-029-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-030-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-031-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-032-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-033-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-034-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-035-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-036-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-037-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-038-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-039-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-040-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-041-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-042-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-043-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-044-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-045-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-046-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-047-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-048-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-049-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-050-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-051-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-052-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-053-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-054-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-055-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-056-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-057-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-058-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-059-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-060-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-061-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-062-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-063-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-064-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-065-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-066-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-067-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-068-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-069-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-070-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-071-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-072-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-073-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-074-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-075-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-076-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-077-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-078-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-079-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-080-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-081-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-082-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-083-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-084-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-085-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-086-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-087-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-088-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-089-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-090-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-091-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-092-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-093-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-094-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-095-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-096-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-097-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-098-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-099-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-100-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-101-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-102-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-103-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-104-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-105-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-106-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-107-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-108-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-109-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-110-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-111-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-112-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-113-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-114-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-115-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-116-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-117-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-118-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-119-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-120-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-121-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-122-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-123-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-124-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-125-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-126-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-127-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-128-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-129-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-130-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-131-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-132-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-133-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-134-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-135-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-136-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-137-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-138-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-139-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-140-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-141-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-142-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-143-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-144-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-145-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-174-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/outline-color-175-expected.txt: Added.
11:27 AM Changeset in webkit [100651] by Lucas Forschler
  • 1 copy in tags/Safari-535.9

New Tag.

11:27 AM Changeset in webkit [100650] by Lucas Forschler
  • 1 delete in tags/Safari-535.9

remove incorrect tag

11:20 AM Changeset in webkit [100649] by Lucas Forschler
  • 1 copy in tags/Safari-535.9

New Tag.

11:17 AM Changeset in webkit [100648] by Adam Roben
  • 5 edits in trunk/Tools

Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process

Fixes <​http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
when web process crashes, but WebProcess crash log should get saved instead

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result): Simplified a little to share more code between the case where we
crashed when running the test and where we crashed when checking the expected rendering for
a reftest. Changed to pass the crashed process name down to write_crash_report.
(TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
along to CrashLogs.find_newest_log rather than always using the driver name.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
crashed.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init): Initialize new web_process_crash attribute.
(unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
test this patch adds.
(TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
specifies that the driver crashed or the web process crashed.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
which we pretend the web process crashed rather than the driver process.

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):
Updated magic numbers to account for new unexpected failing test added to unit_test_list.

11:16 AM Changeset in webkit [100647] by Lucas Forschler
  • 5 edits in trunk/Source

Revert revision change.

11:12 AM Changeset in webkit [100646] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] stop spamming features warning on every build
​https://bugs.webkit.org/show_bug.cgi?id=72629

Reviewed by Ojan Vafai.

We toggle $blobSupport on if $mediaStreamSupport is on. Since
$mediaStreamSupport is on by default for chromium, make the default
for $blobSupport also on.

  • Scripts/build-webkit:
11:11 AM Changeset in webkit [100645] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

10:55 AM Changeset in webkit [100644] by Adam Roben
  • 3 edits in trunk/Tools

Remove extra quoting of call stacks and types passed to run-leaks by NRWT

Fixes <​http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
that are supposed to be ignored

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
required when passing arguments via the shell (which we aren't doing here). It is not
required by Perl's option-parsing code (as the comment I removed mistakenly claimed).

  • Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args): Updated expectations.

10:29 AM Changeset in webkit [100643] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/file-writer-abort-depth.html crashes occasionally on Win dbg
​https://bugs.webkit.org/show_bug.cgi?id=72631

Add a CRASH expectation for
fast/filesystem/file-writer-abort-depth.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [100642] by Martin Robinson
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Remove the last remaining WebKit1 gtkdoc warnings
​https://bugs.webkit.org/show_bug.cgi?id=72627

Reviewed by Philippe Normand.

  • webkit/webkitdownload.h: Add missing enum documentation.
  • webkit/webkiterror.h: Ditto.
  • webkit/webkitwebview.h: Ditto.
10:07 AM Changeset in webkit [100641] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs to support accessibility-related DRT APIs
​https://bugs.webkit.org/show_bug.cgi?id=42131

Unreviewed layout test fix.

I hadn't realized that selection-value-changes-for-aria-textbox.html was being skipped on Lion,
so this test started failing on snow leopard on the bots.

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
9:49 AM Changeset in webkit [100640] by sergio@webkit.org
  • 4 edits in trunk

[GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466
​https://bugs.webkit.org/show_bug.cgi?id=72613

Reviewed by Martin Robinson.

Source/WebCore:

Do not assume that a SoupRequest always exists, it is not
generated for example when the provided URL is
invalid. ResourceHandle::platformSetDefersLoading was crashing
because of that.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::platformSetDefersLoading):

LayoutTests:

Added a test that times out in WK2.

  • platform/gtk-wk2/Skipped: added plugins/get-url-notify-with-url-that-fails-to-load.html
9:40 AM Changeset in webkit [100639] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

Added a CRASH expectation for
fast/dom/null-document-location-put-crash.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
9:31 AM Changeset in webkit [100638] by steveblock@google.com
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Rebaseline
fast/css-generated-content/nested-tables-with-before-after-content-crash.html
for Chromium Linux. Also remove a duplicated text expectation.

Unreviewed gardening.

  • platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed
9:17 AM Changeset in webkit [100637] by steveblock@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results still aren't quite right after
​http://trac.webkit.org/changeset/100615.

  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.
9:16 AM Changeset in webkit [100636] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, run-bindings-tests fix after r91028.

  • Scripts/run-bindings-tests: Use scm.detection module.
9:14 AM Changeset in webkit [100635] by vsevik@chromium.org
  • 5 edits in trunk/Source

Web Inspector: Remove onlineDetectionEnabled from Preferences
​https://bugs.webkit.org/show_bug.cgi?id=72617

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
9:09 AM Changeset in webkit [100634] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] http/tests/inspector/resource-tree/resource-tree-no-xhrs.html fails occasionally
​https://bugs.webkit.org/show_bug.cgi?id=72622

Add MISSING and TEXT expectations for
http/tests/inspector/resource-tree/resource-tree-no-xhrs.html.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
8:53 AM Changeset in webkit [100633] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip a failing test temporarily.
8:49 AM Changeset in webkit [100632] by Philippe Normand
  • 1 edit
    9 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new css3 tests and an accessibility test.

  • platform/gtk/accessibility/loading-iframe-sends-notification-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-blending-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-simple-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-sizing-expected.txt: Added.
  • platform/gtk/css3/images/cross-fade-tiled-expected.txt: Added.
  • platform/gtk/fast/borders/border-mixed-alpha-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
8:45 AM Changeset in webkit [100631] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Ensure the parent for the webView's a11y object is set.

This should fix some accessibility related GTK API tests.

Rubber-stamped by Philippe Normand.

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Always set the parent to make
navigation across GTK and WebKit worlds work properly.

8:43 AM Changeset in webkit [100630] by inferno@chromium.org
  • 9 edits
    5 adds in trunk

Crash from nested tables with generated content
​https://bugs.webkit.org/show_bug.cgi?id=68811

Patch by Ken Buchanan <​kenrb@chromium.org> on 2011-11-17
Reviewed by David Hyatt.

Source/WebCore:

When adding a child to a table that has generated content, this change
ensures that we leave alone any generated content renderers that belong
to descendants in the tree. They don't need to be touched, and doing so
can create confusion about who the content belongs to.

This patch also simplifies some existing code for finding pseudoelement
renderers.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
(WebCore::RenderObject::isBeforeAfterContentGeneratedByAncestor): Added

  • rendering/RenderObject.h:

(WebCore::RenderObject::findAfterContentRenderer): Deleted
(WebCore::RenderObject::findBeforeContentRenderer): Deleted

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::beforePseudoElementRenderer):
(WebCore::RenderObjectChildList::afterPseudoElementRenderer):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

LayoutTests:

Layout test for nesting tables with generated content and forcing a
style recalculation.

  • fast/css-generated-content/nested-tables-with-before-after-content-crash.html: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added
8:40 AM Changeset in webkit [100629] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Don't export the private QQuickView.

Reviewed by Kenneth Rohde Christiansen.

We don't need to export that class anymore as the experimental QML plugin
does not expose this object anymore.

  • UIProcess/API/qt/qquickwebview_p_p.h:
8:32 AM Changeset in webkit [100628] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed WinCE build fix for r94119.

MSVC throws multiply defined symbols linker error when using local class in inline function.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::IdentitySetter::identitySetter):
(WebCore::JSDictionary::tryGetProperty):

8:27 AM Changeset in webkit [100627] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/plugins/plugin-javascript-access-expected.txt: Updated.
8:26 AM Changeset in webkit [100626] by steveblock@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
​https://bugs.webkit.org/show_bug.cgi?id=66953

Remove expectation for animations/missing-values-last-keyframe.html from
platform/chromium-cg-mac-snowleopard. This was incorrectly added by the
rebaseline tool in r100611.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Removed.
8:15 AM Changeset in webkit [100625] by jochen@chromium.org
  • 2 edits in trunk/Tools

Silence a warning about control reaching the end of a non-void function
​https://bugs.webkit.org/show_bug.cgi?id=72616

Reviewed by Tony Gentilcore.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::verticalScrollbar):

8:10 AM Changeset in webkit [100624] by jochen@chromium.org
  • 2 edits in trunk

[chromium] add gyp-mac-tool to .gitignore
​https://bugs.webkit.org/show_bug.cgi?id=72603

Reviewed by Tony Gentilcore.

This file is generated by the make-based build of the chromium/mac port

  • .: Modified property svn:ignore.
  • .gitignore:
7:50 AM Changeset in webkit [100623] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Expose setUseTraditionalDesktopBehaviour() in QML experimental API
​https://bugs.webkit.org/show_bug.cgi?id=72610

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview_p.h:
7:42 AM Changeset in webkit [100622] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Enable skipped but now passing tests (http/tests)
​https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-11-17
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip 24 tests.
7:38 AM Changeset in webkit [100621] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

Print warning for the Qt port when a process crashes and is relaunched
​https://bugs.webkit.org/show_bug.cgi?id=72607

Reviewed by Antonio Gomes.

Make the QtViewInterface::processDidCrash take a URL string argument,
for being able to say which url was the origin of the crash.

We now additionally store the load state and url at process exit. This
is needed for printing the warning and for further crash handling.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
7:05 AM Changeset in webkit [100620] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

Add a CRASH expectation for fast/frames/frame-unload-crash.html on
SnowLeopard dbg.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
6:55 AM Changeset in webkit [100619] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] The experimental plugin doesn't work after being renamed.

Reviewed by Tor Arne Vestbø.

It was renamed from private to experimental but the qmldir file
was forgotten.

  • declarative/experimental/qmldir:
6:53 AM Changeset in webkit [100618] by Adam Roben
  • 5 edits in trunk/Tools

Ignore some leaks in frameworks we link against on Lion

Fixes <​http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
aren't WebKit's fault

Reviewed by Antti Koivisto.

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks):

  • Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):
Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.is_lion): Added.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
methods.

6:51 AM Changeset in webkit [100617] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Cleanup dead code in QtWebPageProxy.
​https://bugs.webkit.org/show_bug.cgi?id=72608

Reviewed by Simon Hausmann.

Remove some dead code after we merged our views.
QQuickWebView is now using AC which means that this
path is never called now.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

  • UIProcess/qt/QtWebPageProxy.h:
6:49 AM Changeset in webkit [100616] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

TextTrackList not sorted correctly
​https://bugs.webkit.org/show_bug.cgi?id=72545

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-texttracks.html

  • WebCore.xcodeproj/project.pbxproj: Add TextTrack.h to WebCore private headers because

it is included by HTMLMediaElement.h.

  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Pass track type to base class constructor.
(WebCore::LoadableTextTrack::trackElementIndex): New, return the <track> element's tree order

for sorting.

  • html/LoadableTextTrack.h:
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Set track type.

  • html/TextTrack.h:

(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::trackType): Ditto.

  • html/track/TextTrackList.cpp:

(TextTrackList::length): Update to deal with two TextTrack vectors.
(TextTrackList::item): Ditto.
(TextTrackList::append): Ditto.
(TextTrackList::remove): Ditto

  • html/track/TextTrackList.h: Store the two types of TextTracks in separate Vectors to make

it simpler to keep them in the correct order.

LayoutTests:

  • media/track/track-texttracks-expected.txt: Added.
  • media/track/track-texttracks.html: Added.
6:42 AM Changeset in webkit [100615] by steveblock@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Layout test failures under Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=54322

Rebaseline transforms/no_transform_hit_testing.html. It looks like the
expected results aren't quite right after
​http://trac.webkit.org/changeset/100507.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Added.
6:23 AM Changeset in webkit [100614] by Simon Hausmann
  • 5 edits in trunk/Source

[Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings()
​https://bugs.webkit.org/show_bug.cgi?id=72596

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

We don't need to use QWebSettings here, because we now propagate the DNS prefetch
setting to WebCore::Settings and the rest of WebCore checks the setting before calling
WebCore::prefetchDNS.

  • platform/network/qt/DnsPrefetchHelper.cpp:

(WebCore::prefetchDNS): Removed the use of QWebSettings.

  • platform/network/qt/DnsPrefetchHelper.h: Remove offending qwebsettings.h inclusion.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Propagate the DNS prefetch setting to WebCore::Settings.

6:22 AM Changeset in webkit [100613] by Simon Hausmann
  • 5 edits in trunk/Source

[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
​https://bugs.webkit.org/show_bug.cgi?id=72594

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the cache for the resource pixmaps into ImageQt.cpp.

  • platform/graphics/Image.h: Add Qt specific setter for resource pixmaps.
  • platform/graphics/qt/ImageQt.cpp: Moved resource pixmap hash from qwebsettings.

(earlyClearGraphics):
(graphics):
(loadResourcePixmap):
(WebCore::Image::setPlatformResource):

Source/WebKit/qt:

Move resource pixmap cache into ImageQt.cpp.

  • Api/qwebsettings.cpp:

(resourceNameForWebGraphic): Helper function to translate between public API enums and
resource names.
(QWebSettings::setWebGraphic): Call the new ImageQt::setPlatformResource setter.
(QWebSettings::webGraphic): Call Image::loadPlatformResource to read from the cache
in WebCore.

6:15 AM Changeset in webkit [100612] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Touch/Mouse events are delivered with wrong coordinates.
​https://bugs.webkit.org/show_bug.cgi?id=72604

When using the QtViewportInterationEngine for zooming/panning,
no additional scroll offset should be applied to input events
by the ScrollView.

This patch is based on work by Andreas Kling.

Reviewed by Kenneth Rohde Christiansen.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):

5:39 AM Changeset in webkit [100611] by steveblock@google.com
  • 1 edit
    1 copy
    5 moves
    9 deletes in trunk/LayoutTests

Several animations/ tests flakily fail due to fragile setTimeout()-based framework
​https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselined missing-values-first-keyframe.html,
missing-values-last-keyframe.html and opacity-transform-animation.html.
Looks like these weren't quite right after
​http://trac.webkit.org/changeset/100520.

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/animations/missing-values-last-keyframe-expected.txt: Copied from LayoutTests/animations/missing-values-last-keyframe-expected.txt.
  • platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-linux/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium/animations/missing-values-first-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png.
  • platform/chromium/animations/missing-values-last-keyframe-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png.
  • platform/mac/animations/missing-values-first-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-first-keyframe-expected.txt.
  • platform/mac/animations/missing-values-last-keyframe-expected.txt: Renamed from LayoutTests/animations/missing-values-last-keyframe-expected.txt.
5:22 AM Changeset in webkit [100610] by vestbo@webkit.org
  • 1 edit in trunk/Tools/WebKitTestRunner/qt/main.cpp

[Qt] Prospective build fix for WebKit2 on Linux

5:19 AM Changeset in webkit [100609] by benm@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix the Windows builds by adding WorkerEventQueue.cpp|h to the
vcproj. Build break was introduced in
​https://bugs.webkit.org/show_bug.cgi?id=72528

  • WebCore.vcproj/WebCore.vcproj: Add missing files.
5:04 AM Changeset in webkit [100608] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore ​https://bugs.webkit.org/show_bug.cgi?id=72602

Unreviewed gardening after r100510.

  • platform/qt/Skipped:
5:02 AM Changeset in webkit [100607] by vestbo@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebKit2

[Qt] Remove forwarding header for WebKit2 C API

The Qt port of WebKit does not provide a C-API for the View classes.

Reviewed by Simon Hausmann.

5:01 AM Changeset in webkit [100606] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] perf/array-binary-search.html fails as MISSING
​https://bugs.webkit.org/show_bug.cgi?id=63057

This is really a TEXT failure, but is reported as MISSING due to Bug

  1. Addding both MISSING and TEXT expectations to keep the tree green

working if/when Bug 63104 is fixed.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:53 AM Changeset in webkit [100605] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] Disable ref tests
​https://bugs.webkit.org/show_bug.cgi?id=72599

Reviewed by Xan Lopez.

  • Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref

tests to avoid massive flakiness.

4:46 AM Changeset in webkit [100604] by mihnea@adobe.com
  • 18 edits
    6 adds in trunk

CSS Exclusions: parse the wrap-margin and wrap-padding properties
​https://bugs.webkit.org/show_bug.cgi?id=71900

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-margin-parsing.html

fast/exclusions/wrap-padding-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapPadding):
(WebCore::InheritedFlags::setWrapPadding):
(WebCore::InheritedFlags::initialWrapPadding):
(WebCore::InheritedFlags::wrapMargin):
(WebCore::InheritedFlags::setWrapMargin):
(WebCore::InheritedFlags::initialWrapMargin):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/exclusions/script-tests/wrap-margin-parsing.js: Added.
  • fast/exclusions/script-tests/wrap-padding-parsing.js: Added.
  • fast/exclusions/wrap-margin-parsing-expected.txt: Added.
  • fast/exclusions/wrap-margin-parsing.html: Added.
  • fast/exclusions/wrap-padding-parsing-expected.txt: Added.
  • fast/exclusions/wrap-padding-parsing.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:28 AM Changeset in webkit [100603] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Resolve import and web-process paths automatically for QML tests

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

4:27 AM Changeset in webkit [100602] by vestbo@webkit.org
  • 32 edits
    7 copies
    1 move
    2 adds
    6 deletes in trunk

[Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that

A new extension object has been added to QQuickWebView (the same approach should be used
for other API classes that need experimental APIs). The QML extension mechanism is then
built on top of the experimental object.

​https://bugs.webkit.org/show_bug.cgi?id=72522

Reviewed by Simon Hausmann.

4:16 AM Changeset in webkit [100601] by bashi@chromium.org
  • 9 edits
    1 copy in trunk/Source

[chromium] don't call fontconfig twice in complex text path
​https://bugs.webkit.org/show_bug.cgi?id=38701

Source/WebCore:

Adds a new API for getting font family. For now, FontCacheLinux calls the new API, but don't use additional properties for compatibility. The old API will be removed when Chromium is ready to use new API.

Reviewed by Tony Chang.

No new tests. No behavior changes for now.

  • platform/chromium/PlatformSupport.h: Added FontFamily struct and changed the declaration of getFontFamilyForCharacters().
  • platform/graphics/chromium/FontCacheLinux.cpp:

(WebCore::FontCache::getFontDataForCharacters): Uses new PlatformSupport::getFontFamilyForCharacters().

  • platform/graphics/chromium/FontPlatformDataLinux.h:

(WebCore::FontPlatformData::setFakeBold): Added.
(WebCore::FontPlatformData::setFakeItalic): Added.

Source/WebKit/chromium:

Reviewed by Tony Chang.

Add new API for getFamilyForChars() so that keeping correct font mapping of the given characters.

  • public/linux/WebFontFamily.h: Added.
  • public/linux/WebFontInfo.h: Add a new API.
  • public/linux/WebSandboxSupport.h:

(WebKit::WebSandboxSupport::getFontFamilyForCharacters): Ditto.

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFontFamilyForCharacters): Ditto.

  • src/linux/WebFontInfo.cpp:

(WebKit::WebFontInfo::familyForChars): Modified to get weight and italic properties of the font. Old API uses new API internally.

4:06 AM Changeset in webkit [100600] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

CSS3 cross-fade tests failing on Chromium after r100535
​https://bugs.webkit.org/show_bug.cgi?id=72598

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [100599] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

3:51 AM Changeset in webkit [100598] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Compositing LayoutTests failing on Chromium Mac
​https://bugs.webkit.org/show_bug.cgi?id=72487

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:50 AM Changeset in webkit [100597] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set
​https://bugs.webkit.org/show_bug.cgi?id=72525

Reviewed by Xan Lopez.

Source/WebCore:

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_parent): Call to the implementation of
atk_object_get_parent in AtkObject class to check whether a parent
AtkObject has been previously set, before trying to find one.

Source/WebKit/gtk:

  • tests/testatk.c:

(testWebkitAtkSetParentForObject): New unit test to check that
calls to atk_object_get_parent() over a WebKitGTK's accessibility
wrapper object returns its parent AtkObject if previously set.
(main): Added new test.

3:47 AM Changeset in webkit [100596] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] ATK API tests failing because of patch for bug 72390
​https://bugs.webkit.org/show_bug.cgi?id=72592

Reviewed by Philippe Normand.

  • tests/testatk.c:

(testWebkitAtkParentForRootObject): Remove the offending line in
the unit test, which is not actually required to test the new
functionality and causes problems in some scenarios, due to the
lazy creation mechanism of AtkObjects.

  • tests/testatkroles.c:

(finish_loading): Reflect that the document frame object is no
longer the root accessibility object (a scroll pane from now on),
but the only child of that one. Thus, skip that root object.

3:27 AM Changeset in webkit [100595] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fix IE user agents strings in the inspector.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

3:26 AM Changeset in webkit [100594] by kenneth@webkit.org
  • 6 edits in trunk/Source

Make use-fixed-layout work reliable
​https://bugs.webkit.org/show_bug.cgi?id=72511

Reviewed by Simon Hausmann.

Source/WebCore:

Always send a viewport update per page load as we depend on that,
to reset all viewport handling before doing layout.

  • page/Page.cpp:

(WebCore::Page::updateViewportArguments):

Source/WebKit2:

The code handling use-fixed-layout wasn't 100% reliable. The code
was changed to make sure the value is always correct.

It also doesn't set the value by looking at the previous FrameView,
as that wouldn't work in cases, such as when the web process has
crashes.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::setUseFixedLayout):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::useFixedLayout):

Store the state as m_useFixedLayout so that it can be used
from the WebFrameLoaderClient.

3:13 AM Changeset in webkit [100593] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Support CoreAnimation plugin model on Mac
​https://bugs.webkit.org/show_bug.cgi?id=47925

Update test expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:01 AM Changeset in webkit [100592] by abarth@webkit.org
  • 2 edits
    1 move in trunk/Tools

Move test_results_uploader.py out of layout_package
​https://bugs.webkit.org/show_bug.cgi?id=72590

Reviewed by Eric Seidel.

Most of the lines of code in this file are wrong, but I've restrained
myself and only changed a few of them to generalized this class to the
common package.

This is part of a series of patches to remove layout_package.

  • Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
2:58 AM Changeset in webkit [100591] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Fix style nits in printing.py.

  • Scripts/webkitpy/layout_tests/views/printing.py:
2:56 AM Changeset in webkit [100590] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt][WK2] Do not apply new viewport properties until after the first visually non-empty layout.
​https://bugs.webkit.org/show_bug.cgi?id=72508

Delay applying viewport properties on the viewport item until after the first visually non-empty
layout finished. It enables the viewport to be intact until the new page is ready to be rendered.

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-11-17
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::computeViewportConstraints):

  • UIProcess/API/qt/qquickwebview_p.h:

(PostTransitionState::isTransitioningToNewPage):

  • UIProcess/qt/ClientImpl.cpp:

(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(setupPageLoaderClient):

  • UIProcess/qt/QtViewInterface.cpp:

(WebKit::QtViewInterface::didFinishFirstNonEmptyLayout):
(WebKit::QtViewInterface::didChangeContentsSize):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::startDrag):

  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFinishFirstNonEmptyLayout):
(QtWebPageProxy::didChangeContentsSize):
(QtWebPageProxy::didChangeViewportProperties):
(QtWebPageProxy::startDrag):

  • UIProcess/qt/QtWebPageProxy.h:
2:12 AM Changeset in webkit [100589] by abarth@webkit.org
  • 2 edits in trunk/Tools

Minor style nits in run_webkit_tests.py
​https://bugs.webkit.org/show_bug.cgi?id=72583

Reviewed by Eric Seidel.

This patch just fixes some minor style issues as I work my way back
into this code.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:10 AM Changeset in webkit [100588] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: inspector follows javascript: hrefs as relative
​https://bugs.webkit.org/show_bug.cgi?id=72373

Source/WebCore:

javascript: hrefs should never be linkified for security.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.completeURL):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
2:09 AM Changeset in webkit [100587] by abarth@webkit.org
  • 3 edits
    1 move in trunk/Tools

Move test_result_writer out of layout_package
​https://bugs.webkit.org/show_bug.cgi?id=72586

Rubber-stamped by Eric Seidel.

This is part of a series of patches to remove layout_package.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
  • Scripts/webkitpy/tool/commands/rebaseline.py:
2:08 AM Changeset in webkit [100586] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-11-17 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix 32bit builds.

  • platform/ClockGeneric.cpp: (ClockGeneric::now): Use narrowPrecisionToFloat.
  • rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Use it correctly.
2:04 AM Changeset in webkit [100585] by abarth@webkit.org
  • 2 edits in trunk/Tools

svn-apply shouldn't magically move files into Source anymore
​https://bugs.webkit.org/show_bug.cgi?id=72579

Reviewed by Eric Seidel.

The Source directory has existed for long enough that we don't need
svn-apply to magically re-write old-style patches anymore.

  • Scripts/VCSUtils.pm:

(parseGitDiffHeader):
(parseSvnDiffHeader):

1:44 AM Changeset in webkit [100584] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

Accessibility: Chromium requires an AX notification when an iframe loads.
​https://bugs.webkit.org/show_bug.cgi?id=72239

Source/WebCore:

When a document finishes loading, we were sending an AXLoadComplete if it
was the top document. Now, if it's a document in an iframe, send an
AXLayoutComplete on the iframe.

Reviewed by Chris Fleizach.

Test: accessibility/loading-iframe-sends-notification.html

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

LayoutTests:

Reviewed by Chris Fleizach.

  • accessibility/loading-iframe-sends-notification.html: Added.
  • platform/chromium/accessibility/loading-iframe-sends-notification-expected.txt: Added.
1:27 AM Changeset in webkit [100583] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 add in trunk/Source/WebKit2

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2011-11-17
Reviewed by Martin Robinson.

[WK2] Move gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
​https://bugs.webkit.org/show_bug.cgi?id=62444

Rename gtk/BackingStoreGtk.cpp to cairo/BackingStoreCairo.cpp to share with EFL port.
The gtk/BackingStoreGtk.cpp only has cairo dependency, so it can be shared with other port
that uses cairo.

  • GNUmakefile.am:
  • UIProcess/BackingStore.h:
  • UIProcess/cairo/BackingStoreCairo.cpp: Renamed from Source/WebKit2/UIProcess/gtk/BackingStoreGtk.cpp.

(WebKit::BackingStore::paint):
(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

1:27 AM Changeset in webkit [100582] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Introduce WebSecurityOrigin::isUnique in preparation for removing WebSecurityOrigin::isEmpty
​https://bugs.webkit.org/show_bug.cgi?id=72580

Reviewed by Darin Fisher.

We've removed the concept of empty security origins from WebKit because
it doesn't exist in the specs. Now it's time to remove it from the API.

  • public/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::isUnique):

1:21 AM Changeset in webkit [100581] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

<​http://webkit.org/b/72574> Remove unnecessary use of CarbonCore APIs from Audio code

Reviewed by Andy Estes.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac): Switch from using the Carbon Component Manager
to using AudioUnit's own component interface.
(WebCore::AudioDestinationMac::~AudioDestinationMac): Ditto.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader): Remove an unncessary trip through the Carbon File Manager
when converting a char* path to a CFURLRef representing the same.

1:10 AM Changeset in webkit [100580] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add few more properties to WebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=72468

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

Add 'enable-private-browsing', 'enable-developer-extras, 'enable-resizable-text-areas'
and 'enable-tabs-to-links' properties to WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set functions.
(webKitSettingsGetProperty): Add new get functions.
(webkit_settings_class_init): Add new properties.
(webkit_settings_get_enable_private_browsing): Get 'enable-private-browsing' property.
(webkit_settings_set_enable_private_browsing): Set 'enable-private-browsing' property.
(webkit_settings_get_enable_developer_extras): Get 'enable-developer-extras' property.
(webkit_settings_set_enable_developer_extras): Set 'enable-developer-extras' property.
(webkit_settings_get_enable_resizable_text_areas): Get 'enable-resizable-text-areas' property.
(webkit_settings_set_enable_resizable_text_areas): Set 'enable-resizable-text-areas' property.
(webkit_settings_get_enable_tabs_to_links): Get 'enable-tabs-to-links' property.
(webkit_settings_set_enable_tabs_to_links): Set 'enable-tabs-to-links' property.

  • UIProcess/API/gtk/WebKitSettings.h: New public APIs added.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New APIs added.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

1:02 AM Changeset in webkit [100579] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2 GTK+ build after r100569.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):

12:53 AM Changeset in webkit [100578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Fix assert while running TestWebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=72469

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Correct the test.

12:48 AM Changeset in webkit [100577] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/912

Merge 100550
BUG=104223
Review URL: ​http://codereview.chromium.org/8585026

12:42 AM Changeset in webkit [100576] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/912

Merge 99462
BUG=91911
Review URL: ​http://codereview.chromium.org/8586021

12:37 AM Changeset in webkit [100575] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/912

Merge 99579
BUG=101235
Review URL: ​http://codereview.chromium.org/8587027

12:25 AM Changeset in webkit [100574] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

CSP report-only mode doesn't work from an HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=71958

Reviewed by Eric Seidel.

Source/WebCore:

"It's tested or it's broken." -- Adam Leventhal

Test: http/tests/security/contentSecurityPolicy/report-only-from-header.php

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

LayoutTests:

Test that X-WebKit-CSP-Report-Only actually sends reports.

  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only-from-header.php: Added.
12:24 AM Changeset in webkit [100573] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/912

Merge 9964
BUG=102037
Review URL: ​http://codereview.chromium.org/8480029

12:16 AM Changeset in webkit [100572] by pfeldman@chromium.org
  • 14 edits in trunk/Source

Web Inspector: introduce Debugger domain capabilities concept.
​https://bugs.webkit.org/show_bug.cgi?id=72393

Many of the Preferences that we have in Settings.js and override in DevTools.js
are really not preferences, but capabilities. Protocol clients should have a way
of figuring out whether some capability is present before using it.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::canSetScriptSource):

  • bindings/v8/ScriptDebugServer.h:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getCapabilities):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
12:10 AM Changeset in webkit [100571] by cevans@google.com
  • 1 edit
    3 deletes in branches/chromium/912

Revert 100566 - Merge 99649
BUG=102037
Review URL: ​http://codereview.chromium.org/8587026

12:08 AM Changeset in webkit [100570] by mihnea@adobe.com
  • 20 edits
    6 adds in trunk

CSS exclusions: parse the wrap-flow and wrap-through properties
​https://bugs.webkit.org/show_bug.cgi?id=71904

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/wrap-flow-parsing.html

fast/exclusions/wrap-through-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::wrapFlow):
(WebCore::InheritedFlags::wrapThrough):
(WebCore::InheritedFlags::setWrapFlow):
(WebCore::InheritedFlags::setWrapThrough):
(WebCore::InheritedFlags::initialWrapFlow):
(WebCore::InheritedFlags::initialWrapThrough):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/exclusions/script-tests/wrap-flow-parsing.js: Added.
  • fast/exclusions/script-tests/wrap-through-parsing.js: Added.
  • fast/exclusions/wrap-flow-parsing-expected.txt: Added.
  • fast/exclusions/wrap-flow-parsing.html: Added.
  • fast/exclusions/wrap-through-parsing-expected.txt: Added.
  • fast/exclusions/wrap-through-parsing.html: Added.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:

Nov 16, 2011:

11:59 PM Changeset in webkit [100569] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Use a URI instead of local path to create download destination in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72500

Reviewed by Philippe Normand.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Use
g_file_new_for_uri() instad of g_file_new_for_path(). Also use
adoptGRef to fix a memory leak.

11:50 PM Changeset in webkit [100568] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/912

Merge 99731
BUG=89493
Review URL: ​http://codereview.chromium.org/8591014

11:46 PM Changeset in webkit [100567] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/912

Merge 99565
BUG=102810
Review URL: ​http://codereview.chromium.org/8588025

11:42 PM Changeset in webkit [100566] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/912

Merge 99649
BUG=102037
Review URL: ​http://codereview.chromium.org/8591013

11:24 PM Changeset in webkit [100565] by dino@apple.com
  • 12 edits
    32 adds in trunk

Implement filter function shorthands
​https://bugs.webkit.org/show_bug.cgi?id=68475

Reviewed by Simon Fraser.

Source/WebCore:

Implement the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

CSSParser needed to be updated because it was mistakenly
clamping saturation values to [0,1]. Any positive number
is allowed so you can produce super-saturated images.

The biggest change was the API to FilterEffectRenderer. It now
builds a list of effects and applies the filter itself.

Note that the drop-shadow and blur operations don't yet
provide accurate results because they produce an output image
that is larger than the input. See
​https://bugs.webkit.org/show_bug.cgi?id=71929
​https://bugs.webkit.org/show_bug.cgi?id=71930

While I was there, I fixed a small style issue in
CustomFilterOperation.

Tests: css3/filters/effect-blur.html

css3/filters/effect-combined.html
css3/filters/effect-drop-shadow.html
css3/filters/effect-gamma.html
css3/filters/effect-grayscale.html
css3/filters/effect-hue-rotate.html
css3/filters/effect-invert.html
css3/filters/effect-opacity.html
css3/filters/effect-saturate.html
css3/filters/effect-sepia.html

  • WebCore.xcodeproj/project.pbxproj: Add StyleShader.h to

the project (missing from earlier commit).

  • css/CSSParser.cpp:

(WebCore::CSSParser::isValidFilterArgument): Don't clamp
saturate to [0,1]

  • platform/graphics/filters/CustomFilterOperation.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::endMatrixRow):
(WebCore::lastMatrixRow):
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::inputContext):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):
(WebCore::FilterEffectRenderer::apply):

  • rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::output):
(WebCore::FilterEffectRenderer::setMaxEffectRects):
(WebCore::FilterEffectRenderer::lastEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):

LayoutTests:

Test the shorthand functions for filter effects.
This includes grayscale, sepia, invert, hue-rotate, saturate,
opacity, gamma, drop-shadow and blur. At the moment sharpen
and url are not supported.

Note that the drop-shadow and blur operations don't yet
provide accurate results because they produce an output image
that is larger than the input. See
​https://bugs.webkit.org/show_bug.cgi?id=71929
​https://bugs.webkit.org/show_bug.cgi?id=71930

  • css3/filters/effect-blur-expected.png: Added.
  • css3/filters/effect-blur-expected.txt: Added.
  • css3/filters/effect-blur.html: Added.
  • css3/filters/effect-combined-expected.png: Added.
  • css3/filters/effect-combined-expected.txt: Added.
  • css3/filters/effect-combined.html: Added.
  • css3/filters/effect-drop-shadow-expected.png: Added.
  • css3/filters/effect-drop-shadow-expected.txt: Added.
  • css3/filters/effect-drop-shadow.html: Added.
  • css3/filters/effect-gamma-expected.png: Added.
  • css3/filters/effect-gamma-expected.txt: Added.
  • css3/filters/effect-gamma.html: Added.
  • css3/filters/effect-grayscale-expected.png: Added.
  • css3/filters/effect-grayscale-expected.txt: Added.
  • css3/filters/effect-grayscale.html: Added.
  • css3/filters/effect-hue-rotate-expected.png: Added.
  • css3/filters/effect-hue-rotate-expected.txt: Added.
  • css3/filters/effect-hue-rotate.html: Added.
  • css3/filters/effect-invert-expected.png: Added.
  • css3/filters/effect-invert-expected.txt: Added.
  • css3/filters/effect-invert.html: Added.
  • css3/filters/effect-opacity-expected.png: Added.
  • css3/filters/effect-opacity-expected.txt: Added.
  • css3/filters/effect-opacity.html: Added.
  • css3/filters/effect-saturate-expected.png: Added.
  • css3/filters/effect-saturate-expected.txt: Added.
  • css3/filters/effect-saturate.html: Added.
  • css3/filters/effect-sepia-expected.png: Added.
  • css3/filters/effect-sepia-expected.txt: Added.
  • css3/filters/effect-sepia.html: Added.
  • css3/filters/resources/reference.png: Added.
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • css3/filters/script-tests/filter-property-parsing.js:
11:11 PM Changeset in webkit [100564] by haraken@chromium.org
  • 28 edits
    2 deletes in trunk/Source/WebCore

Remove all custom constructors of Events from JSC
​https://bugs.webkit.org/show_bug.cgi?id=72577

Reviewed by Adam Barth.

  • Makes CodeGeneratorJS.pm generate Event constructors

if [ConstructorTemplate=Event] IDL is specified.

  • Removes EventConstructors.h and JSEventConstructors.cpp.
  • Replaces all JSC custom constructors of Events

with the generated code by [ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • bindings/generic/EventConstructors.h: Removed. This is what we wanted to do in this patch.
  • bindings/js/JSEventConstructors.cpp: Ditto.
  • GNUmakefile.list.am: Removed EventConstructors.h and JSEventConstructors.cpp.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Added JSDictionary.h.
(GenerateConstructorDeclaration): Added a header for fillXXXXEventInit(...).
(GenerateConstructorDefinition): Generates an Event constructor. The generated code is the same as the code that had been written in JSEventConstructors.cpp.
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].

  • bindings/scripts/test/TestEventConstructor.idl: Changed 'CustomConstructor=Event' to 'ConstructorTemplate=Event'. We should have changed this in r100108.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.
  • dom/BeforeLoadEvent.idl: In essence, replaced [JSCustomConstructor] IDL with [JSConstructorTemplate=Event] IDL.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/Event.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
10:33 PM Changeset in webkit [100563] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for Apple WebKit due to r100560.
When I removed the violating header file it lost the
reference to Color.

No review.

  • platform/graphics/filters/FilterOperation.h:
10:22 PM Changeset in webkit [100562] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/Tools

Add a list of contribution areas
​https://bugs.webkit.org/show_bug.cgi?id=72566

Reviewed by Eric Seidel.

Added ContributionAreas class.

  • Scripts/webkitpy/common/config/contributionareas.py: Added.
  • Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
10:20 PM Changeset in webkit [100561] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Refactor ChangeLogTest.test_parse_reviewer_text
​https://bugs.webkit.org/show_bug.cgi?id=72572

Reviewed by Eric Seidel.

Refactored the test code by introduing two helper functions.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
9:24 PM Changeset in webkit [100560] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

DropShadowFilterOperation violates platform isolation
​https://bugs.webkit.org/show_bug.cgi?id=72544

Reviewed by Simon Fraser.

Move ShadowData properties into the DropShadowFilterOperation
to avoid depending on something outside platform.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::create):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::stdDeviation):
(WebCore::DropShadowFilterOperation::color):
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):

9:14 PM Changeset in webkit [100559] by jamesr@google.com
  • 4 edits
    3 adds in trunk/LayoutTests

[chromium] Update more chromium baselines and expectations

  • platform/chromium-cg-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium/test_expectations.txt:
9:08 PM Changeset in webkit [100558] by eric@webkit.org
  • 19 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
​https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
8:51 PM Changeset in webkit [100557] by jamesr@google.com
  • 15 edits
    2 moves
    36 adds
    7 deletes in trunk/LayoutTests

[chromium] Update baselines for compositing tests with video and canvas

  • platform/chromium-cg-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png.
  • platform/chromium-gpu-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-gpu-cg-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/geometry/clipped-video-controller-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/video-page-visibility-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-lion/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
7:58 PM Changeset in webkit [100556] by fpizlo@apple.com
  • 15 edits
    2 adds
    2 deletes in trunk/Source/JavaScriptCore

Code block jettisoning should be part of the GC's transitive closure
​https://bugs.webkit.org/show_bug.cgi?id=72467

Reviewed by Geoff Garen.

Replaced JettisonedCodeBlocks with DFGCodeBlocks. The latter knows about all
DFG code blocks (i.e. those that may be jettisoned, and may have inlined weak
references) and helps track what state each of those code blocks is in during
GC. The state consists of two flags; mayBeExecuting, which tells if the code block
is live from call frames; and isJettisoned, which tells if the code block is
not owned by any executable and thus should be deleted as soon as it is not
mayBeExecuting.

  • Not executing, Not jettisoned: The code block may or may not be reachable from any executables, but it is owned by an executable, and hence should be kept alive if its executable is live and if all of its weak references are live. Otherwise it should be deleted during the current GC cycle, and its outgoing references should not be scanned.


  • Not executing but jettisoned: The code block should be deleted as soon as possible and none of its outgoing references should be scanned.


  • Executing but not jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. The mayBeExecuting bit will be cleared at the end of the GC cycle.


  • Executing and jettisoned: The code block should be kept alive during this GC cycle, and all of its outgoing references (including the weak ones) should be scanned and marked strongly. However, on the next GC cycle, it will have its mayBeExecuting bit cleared and hence it will become a candidate for immediate deletion provided it is not executing again.

This is performance-neutral.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::DFGData::DFGData):
(JSC::DFGCodeBlocks::mark):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::add):

  • heap/ConservativeRoots.h:
  • heap/DFGCodeBlocks.cpp: Added.

(JSC::DFGCodeBlocks::DFGCodeBlocks):
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):

  • heap/DFGCodeBlocks.h: Added.
  • heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/JettisonedCodeBlocks.cpp: Removed.
  • heap/JettisonedCodeBlocks.h: Removed.
  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:
  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):

7:50 PM Changeset in webkit [100555] by commit-queue@webkit.org
  • 9 edits
    3 adds
    6 deletes in trunk/Source/WebCore

Use a simple page client for user consent in getUserMedia()
​https://bugs.webkit.org/show_bug.cgi?id=70897

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-11-16
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Covered by existing tests.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/MediaStreamClient.h: Removed.
  • mediastream/MediaStreamController.cpp: Removed.
  • mediastream/MediaStreamController.h: Removed.
  • mediastream/MediaStreamFrameController.cpp: Removed.
  • mediastream/MediaStreamFrameController.h: Removed.
  • mediastream/UserMediaClient.h: Added.

(WebCore::UserMediaClient::~UserMediaClient):

  • mediastream/UserMediaRequest.cpp: Added.

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::~UserMediaRequest):
(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::fail):
(WebCore::UserMediaRequest::contextDestroyed):
(WebCore::UserMediaRequest::parseOptions):

  • mediastream/UserMediaRequest.h: Added.

(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):
(WebCore::UserMediaRequest::successCallback):
(WebCore::UserMediaRequest::errorCallback):

  • page/CallbackTask.h: Removed.
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

  • page/Frame.h:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitGetUserMedia):

  • page/NavigatorUserMediaErrorCallback.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore::Page::userMediaClient):

7:42 PM Changeset in webkit [100554] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix duplicate expectations for chromium mac leopard

  • platform/chromium/test_expectations.txt:
7:32 PM Changeset in webkit [100553] by mrowe@apple.com
  • 4 edits in trunk/Tools

Fix the build.

The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
Apply the workaround that we use in other projects to WebKitTestRunner.

  • WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
  • WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
7:22 PM Changeset in webkit [100552] by dgrogan@chromium.org
  • 4 edits in trunk/Source/WebCore

instantiate WorkerEventQueue in WorkerContext
​https://bugs.webkit.org/show_bug.cgi?id=72528

Reviewed by David Levin.

No new tests - nothing uses it yet.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
Instantiate WorkerEventQueue in InitializerList

  • workers/WorkerEventQueue.h:

Don't inherit from RefCounted, WorkerContext has an OwnPtr to it

7:13 PM Changeset in webkit [100551] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructor::releaseImpl):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::impl):
(WebCore::JSTestInterface::releaseImpl):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::impl):
(WebCore::JSTestMediaQueryListListener::releaseImpl):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::impl):
(WebCore::JSTestNamedConstructor::releaseImpl):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::impl):
(WebCore::JSTestObj::releaseImpl):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::impl):
(WebCore::JSTestSerializedScriptValueInterface::releaseImpl):

7:08 PM Changeset in webkit [100550] by jcivelli@chromium.org
  • 5 edits
    2 adds in trunk

Make sure MHTML documents use the domain of the MHTML file.
​https://bugs.webkit.org/show_bug.cgi?id=72445

Reviewed by Adam Barth.

Source/WebCore:

  • dom/Document.h:

(WebCore::Document::setBaseURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

LayoutTests:

  • mhtml/check_domain-expected.txt: Added.
  • mhtml/check_domain.mht: Added.
7:06 PM Changeset in webkit [100549] by caio.oliveira@openbossa.org
  • 5 edits in trunk

[Qt] Fix build after WTR AX support
​https://bugs.webkit.org/show_bug.cgi?id=72560

Reviewed by Geoffrey Garen.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

Tools:

  • WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  • WebKitTestRunner/InjectedBundle/Target.pri:
6:58 PM Changeset in webkit [100548] by tony@chromium.org
  • 2 edits in trunk/Tools

repurpose the flexbox bot for grid layout
​https://bugs.webkit.org/show_bug.cgi?id=72557

Reviewed by Ryosuke Niwa.

Since new flexbox is enabled everywhere, we don't need this bot
anymore. However, work on grid layout has begun, so we can use this
bot to compile with ENABLE_CSS_GRID_LAYOUT.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Just rename

the bot on the waterfall, I will change the slave config to enable
the compile flag and tests.

6:54 PM Changeset in webkit [100547] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Use standard booleand data type in struct.
​https://bugs.webkit.org/show_bug.cgi?id=72565

Reviewed by Martin Robinson.

Change *Eina_Bool* usages with *bool* in member variables of internal struct.

  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_view.cpp:
6:20 PM Changeset in webkit [100546] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Update supported display list after -webkit-grid and -webkit-inline-grid addition
​https://bugs.webkit.org/show_bug.cgi?id=72559

Reviewed by Tony Chang.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added the 2 new supported
values (forgotten in the previous change).

6:09 PM Changeset in webkit [100545] by enne@google.com
  • 20 edits
    1 add in trunk

[chromium] Expose mock scrollbars to window.internals
​https://bugs.webkit.org/show_bug.cgi?id=72195

Reviewed by James Robinson.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::setMockScrollbarsEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMockScrollbarsEnabled):

  • src/WebSettingsImpl.h:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Because mock scrollbars are a global setting, reset between runs.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

LayoutTests:

Change a small number of initial tests that are failing on Chromium
due to small scrollbar pixel differences to use mock scrollbars. These
tests will be rebaselined once they have run through the bots.

  • compositing/geometry/fixed-position.html:
  • compositing/geometry/horizontal-scroll-composited.html:
  • compositing/geometry/vertical-scroll-composited.html:
  • compositing/overflow/fixed-position-ancestor-clip.html:
  • compositing/resources/mock_scrollbars.js: Added.
6:00 PM Changeset in webkit [100544] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for 32-bit.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:53 PM Changeset in webkit [100543] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source

Fix the build.

5:49 PM Changeset in webkit [100542] by eae@chromium.org
  • 36 edits in branches/subpixellayout/Source

Update chromium/mac port

5:46 PM Changeset in webkit [100541] by Michael Nordman
  • 6 edits
    3 deletes in trunk

ApplicationCache manifest should work with any MIME type.
​https://bugs.webkit.org/show_bug.cgi?id=72082

Source/WebCore:

Reviewed by Alexey Proskuryakov.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Remove the test for a particular type.

LayoutTests:

Update the wrong-content-type test to expect the appcache to succeed given a text/plain contentType.

Reviewed by Alexey Proskuryakov.

  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-content-type.html:
  • platform/chromium/test_expectations.txt: Temporarily skip this test in chromium.
  • platform/chromium-cg-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-mac/http/tests/appcache/wrong-content-type-expected.txt: Removed.
  • platform/chromium-win/http/tests/appcache/wrong-content-type-expected.txt: Removed.
5:43 PM Changeset in webkit [100540] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Some CachedCall cleanup, in preparation for reversing argument order.

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitWeakReferences): A build fix for the interpreter,
so I can test it.

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall): Renamed argCount to argumentCount because
we are not that desperate for character saving.

(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument): Adopted new 0-based argument indexing for
CallFrameClosure.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Provide 0-based argument indexing,
with an explicit setter for 'this', since that's how most clients think.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h: Change argCount to argumentCountIncludingThis,

for clarity.

5:43 PM Changeset in webkit [100539] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Skip failing ref tests on gtk and mac.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
5:34 PM Changeset in webkit [100538] by Lucas Forschler
  • 10 edits in branches/safari-534.53-branch/Source

Merge 94247.

5:33 PM Changeset in webkit [100537] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

De-virtualize ScriptExecutable::unlinkCalls
​https://bugs.webkit.org/show_bug.cgi?id=72546

Reviewed by Geoffrey Garen.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable): Added an empty explicit virtual destructor to prevent a very odd compilation error
due to the fact that the compiler was trying to generate the implicit inline destructor in every translation unit, some of which
didn't have complete type information on the things that needed to be destructed in the implicit destructor.

  • runtime/Executable.h:

(JSC::EvalExecutable::createStructure): Used new type value from JSType
(JSC::ProgramExecutable::createStructure): Ditto
(JSC::FunctionExecutable::createStructure): Ditto
(JSC::ScriptExecutable::unlinkCalls): Condition upon the type value, cast and call the corresponding unlinkCalls implementation.

  • runtime/JSType.h: Added new values for EvalExecutable, ProgramExecutable, and FunctionExecutable. Remove explicit numbers, since

that just adds noise to patches and they currently have no significance.

5:29 PM Changeset in webkit [100536] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Chromium] Avoid color mask operations for root layers
​https://bugs.webkit.org/show_bug.cgi?id=72452

Instead of relying on the combination of clearing the surface and initializing
the alpha channel to 1.0 followed by disabling alpha in the color mask when
rendering the root layer tiles, add shaders to support writing out opaque layers
(alpha channel values written as 1.0).

Patch by Daniel Sievers <​sievers@chromium.org> on 2011-11-16
Reviewed by James Robinson.

No functional change made that requires new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgramOpaque):
(WebCore::LayerRendererChromium::tilerProgramOpaqueAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tilerProgramSwizzleOpaqueAA):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentTexOpaqueBinding::FragmentTexOpaqueBinding):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderRGBATexOpaque::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleOpaque::getShaderString):
(WebCore::FragmentTexClampOpaqueAABinding::FragmentTexClampOpaqueAABinding):
(WebCore::FragmentTexClampOpaqueAABinding::init):
(WebCore::FragmentShaderRGBATexClampOpaqueAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleOpaqueAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::FragmentTexOpaqueBinding::alphaLocation):
(WebCore::FragmentTexOpaqueBinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::alphaLocation):
(WebCore::FragmentTexClampOpaqueAABinding::samplerLocation):
(WebCore::FragmentTexClampOpaqueAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexClampOpaqueAABinding::edgeLocation):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
5:28 PM Changeset in webkit [100535] by timothy_horton@apple.com
  • 25 edits
    28 adds in trunk

Implement CSS3 Images cross-fade() image function
​https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Render -webkit-cross-fade. Only cross-fades entirely composed of images will render for now,
cross-fades involving generated images are not yet implemented.

Reorganize GeneratedImage to be the base class for GeneratorGeneratedImage and CrossfadeGeneratedImage.

Add a pending state to CSSImageGeneratorValue, which is used to enable the pending-images loading
mechanism for -webkit-cross-fade's sub-images. Rework the logic in CSSStyleSelector to support pending
generated images.

Support parsing fractional values for the cross-fade amount (for example, 0.5 = 50%). Clamp cross-fade
amount to 0-1 range.

Tests: css3/images/cross-fade-invalidation.html

css3/images/cross-fade-simple.html
css3/images/cross-fade-sizing.html
css3/images/cross-fade-tiled.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::isPending):
(WebCore::CSSCanvasValue::loadSubimages):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::loadSubimages):
(WebCore::subimageIsPending):
(WebCore::loadSubimage):
(WebCore::cachedImageForCSSValue):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeObserverProxy::CrossfadeObserverProxy):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::isPending):
(WebCore::CSSGradientValue::loadSubimages):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::generatedOrPendingImage):
(WebCore::CSSImageGeneratorValue::generatedImage):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSImageGeneratorValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCrossfade):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleImage):
(WebCore::CSSStyleSelector::generatedOrPendingFromValue):
(WebCore::CSSStyleSelector::loadPendingImage):
(WebCore::CSSStyleSelector::loadPendingImages):

  • css/CSSStyleSelector.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp: Added.

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::~CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):
(WebCore::CrossfadeGeneratedImage::imageChanged):

  • platform/graphics/CrossfadeGeneratedImage.h: Added.

(WebCore::CrossfadeGeneratedImage::create):
(WebCore::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
(WebCore::CrossfadeSubimageObserverProxy::setReady):

  • platform/graphics/GeneratedImage.h:

(WebCore::GeneratedImage::GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratedImage.cpp.

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
(WebCore::GeneratedImage::computeIntrinsicDimensions):

  • platform/graphics/GeneratorGeneratedImage.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.h.

(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::create):
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::StylePendingImage):

Add tests of -webkit-cross-fade, ensuring that simple cross-fades between
two images work correctly.

Adjust fast/css/getComputedStyle/computed-style-cross-fade.html to test
fractional and out-of-range cross-fade percentage values.

  • css3/images/cross-fade-invalidation.html: Added.
  • css3/images/cross-fade-simple.html: Added.
  • css3/images/cross-fade-sizing.html: Added.
  • css3/images/cross-fade-tiled.html: Added.
  • css3/images/resources/blue-10.png: Added.
  • css3/images/resources/blue-100.png: Added.
  • css3/images/resources/green-10.png: Added.
  • css3/images/resources/green-100.png: Added.
  • css3/images/resources/green-circle.svg: Added.
  • css3/images/resources/red-10.png: Added.
  • css3/images/resources/red-100.png: Added.
  • fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
  • fast/css/getComputedStyle/computed-style-cross-fade.html:
  • platform/mac/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/mac/css3/images/cross-fade-invalidation-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-simple-expected.png: Added.
  • platform/mac/css3/images/cross-fade-simple-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/mac/css3/images/cross-fade-sizing-expected.txt: Added.
  • platform/mac/css3/images/cross-fade-tiled-expected.png: Added.
  • platform/mac/css3/images/cross-fade-tiled-expected.txt: Added.
5:19 PM Changeset in webkit [100534] by mitz@apple.com
  • 21 edits
    1 add in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/10262242> Add API for paginated display
​https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Exported Page::pageCount().
  • page/Page.cpp:

(WebCore::Page::pageCount): Added this getter.

  • page/Page.h:

Source/WebKit/mac: WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
​https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • WebView/WebView.mm:

(-[WebView _setPaginationMode:]): Added this accessor.
(-[WebView _paginationMode]): Ditto.
(-[WebView _setGapBetweenPages:]): Ditto.
(-[WebView _gapBetweenPages]): Ditto.
(-[WebView _pageCount]): Ditto.

  • WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.

Source/WebKit2: WebKit2 part of <rdar://problem/10262242> Add API for paginated display
​https://bugs.webkit.org/show_bug.cgi?id=72537

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode the pagination mode and gap between pages.
(WebKit::WebPageCreationParameters::decode): Decode the pagination mode and gap between pages.

  • Shared/WebPageCreationParameters.h: Added paginationMode and gapBetweenPages members.
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationMode): Added this API wrapper.
(WKPageGetPaginationMode): Ditto.
(WKPageSetGapBetweenPages): Ditto.
(WKPageGetGapBetweenPages): Ditto.
(WKPageGetPageCount): Ditto.

  • UIProcess/API/C/WKPagePrivate.h: Added an enum and a definition of WKPaginationMode and

accessors.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationMode:]): Added this API wrapper.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added. Includes an enum and a definition

of WKBrowsingContextPaginationMode and property declarations.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added intialization of m_paginationMode, m_gapBetweenPages,
and m_pageCount.
(WebKit::WebPageProxy::setPaginationMode): Added this accessor, which caches the value and sends
a message to the WebPage.
(WebKit::WebPageProxy::setGapBetweenPages): Ditto.
(WebKit::WebPageProxy::creationParameters): Set the pagination mode and gap between pages in the
creation parameters.
(WebKit::WebPageProxy::didChangePageCount): Added. Updates the cached page count.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::paginationMode): Added this getter that returns a cached value.
(WebKit::WebPageProxy::gapBetweenPages): Ditto.
(WebKit::WebPageProxy::pageCount): Ditto.

  • UIProcess/WebPageProxy.messages.in: Added DidChangedPageCount, sent when the page count changes

after layout.

  • WebKit2.xcodeproj/project.pbxproj: Added WKBrowsingContextControllerPrivate.h.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout): Added a call to WebPage::mainFrameDidLayout(),
allowing the page to respond to changes in the column count.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Added initializer for m_cachedPageCount.
(WebKit::WebPage::setPaginationMode): Added.
(WebKit::WebPage::setGapBetweenPages): Added.
(WebKit::WebPage::mainFrameDidLayout): Added. Sends a DidChangePageCount message to the UI process
if the page count has changed.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added SetPaginationMode and SetGapBetweenPages messages.
5:14 PM Changeset in webkit [100533] by commit-queue@webkit.org
  • 4 edits in trunk

[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
​https://bugs.webkit.org/show_bug.cgi?id=72562

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-16
Reviewed by Dirk Pranke.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:08 PM Changeset in webkit [100532] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source

Merge 94122.

5:02 PM Changeset in webkit [100531] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source/WebCore

Merged r93669.

4:59 PM Changeset in webkit [100530] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source

[chromium] Track property changes for render surfaces.
​https://bugs.webkit.org/show_bug.cgi?id=72521

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2011-11-16
Reviewed by James Robinson.

Source/WebCore:

Created CCRenderSurfaceTest for testing.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::surfacePropertyChanged):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::resetPropertyChangedFlag):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCRenderSurfaceTest.cpp: Added.

(WebCore::TEST):

4:58 PM Changeset in webkit [100529] by Lucas Forschler
  • 8 edits
    6 copies in branches/safari-534.53-branch

Merge 99315.

4:57 PM Changeset in webkit [100528] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Seaming on border corners with mixed colour alpha borders
​https://bugs.webkit.org/show_bug.cgi?id=70471

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-16
Reviewed by Simon Fraser.

Source/WebCore:

Seaming is fixed by antialiasing mitred corners for edges that have alpha and are joining
a side that is of a different color.

Test: fast/borders/border-mixed-alpha.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::colorNeedsAntiAliasAtCorner):
(WebCore::RenderBoxModelObject::paintOneBorderSide):

LayoutTests:

  • fast/borders/border-mixed-alpha.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/mac/fast/borders/border-mixed-alpha-expected.txt: Added.
4:49 PM Changeset in webkit [100527] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

JSC::CodeBlock should know which references generated by the DFG are weak
​https://bugs.webkit.org/show_bug.cgi?id=72563

Reviewed by Geoff Garen.

CodeBlock::m_dfgData now tracks weak references and weak reference transitions
(like ephemerons) generated by the DFG. The DFG makes sure to notify the
CodeBlock of all uses of weak references and weak reference transitions.
CodeBlock currently marks them strongly, since the weak marking logic is not
in place, yet.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::stronglyVisitWeakReferences):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::shrinkWeakReferencesToFit):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::codeOriginOwner):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::addWeakReferenceTransition):
(JSC::DFG::JITCompiler::branchWeakPtr):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::compile):

4:46 PM Changeset in webkit [100526] by Lucas Forschler
  • 7 edits in branches/safari-534.53-branch/Tools

Merged r93052.

4:39 PM Changeset in webkit [100525] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source/WebKit2

Merge 93314.

4:35 PM Changeset in webkit [100524] by Lucas Forschler
  • 54 edits in branches/safari-534.53-branch/Source

Merge 93303.

4:25 PM Changeset in webkit [100523] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.cpp(185)
​https://bugs.webkit.org/show_bug.cgi?id=72561

Removed #if USE(JSC) and therefore the ASSERT_NOT_REACHED().
Simplified the code in the process.

Reviewed by James Robinson.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):

4:23 PM Changeset in webkit [100522] by Lucas Forschler
  • 54 edits in branches/safari-534.53-branch/Source

rollout merge of 93303, nee to fixup changelogs.

4:21 PM Changeset in webkit [100521] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Interpreter build fixes.

  • bytecode/CodeBlock.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:20 PM Changeset in webkit [100520] by pkasting@chromium.org
  • 5 edits
    9 adds
    3 deletes in trunk/LayoutTests

[chromium] Clean up some animations/ expectations.
​https://bugs.webkit.org/show_bug.cgi?id=66953

Rebaselines some tests that clearly just needed that, tries to condense
a number of other flaky tests onto one bug, updates the set of bots that
are actually failing for some expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed.
  • platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed.
  • platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed.
  • platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.png:
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.png:
  • platform/chromium-win/animations/opacity-transform-animation-expected.png:
  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [100519] by Lucas Forschler
  • 54 edits in branches/safari-534.53-branch/Source

Merge 93303.

4:04 PM Changeset in webkit [100518] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r100363.

  • bytecode/CodeBlock.h:
3:46 PM Changeset in webkit [100517] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

JS wrappers of DOM objects should have no-op constructors
​https://bugs.webkit.org/show_bug.cgi?id=72556

Reviewed by Geoffrey Garen.

Stop using a RefPtr to hold DOM objects contained by JavaScript
wrappers and instead use a raw pointer. We were already releasing
the underlying object before the destructor ran (via the finalizer)
so the default behavior of destroying the RefPtr is always unnecessary
busy work.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):
(WebCore::JSNode::visitChildren):
Call releaseImpl() instead of clearImpl().

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
clearImpl() to releaseImpl(), which explicitly derefs the pointer and
clear it.

(GenerateImplementation):
Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
Change default finalize to call releaseImpl() instead of clearImpl().

3:37 PM Changeset in webkit [100516] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Rolled back in r100375 and r100385 with 32-bit build fixed.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

  • runtime/ArgList.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSGlobalObject.h:

(JSC::constructArray):

3:33 PM Changeset in webkit [100515] by Lucas Forschler
  • 23 edits in branches/safari-534.53-branch/Source

Merge 93058.

3:21 PM Changeset in webkit [100514] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG global variable CSE mishandles the cross-global-object inlining corner case
​https://bugs.webkit.org/show_bug.cgi?id=72542

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::globalObjectFor):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::globalObjectFor):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/cross-global-object-inline-global-var-expected.txt: Added.
  • fast/js/cross-global-object-inline-global-var.html: Added.
  • fast/js/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

3:02 PM Changeset in webkit [100513] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Revert r100509; change was committed twice (first time as r100491).
Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2:57 PM Changeset in webkit [100512] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

[chromium] Update text baselines for mq-transform-0[23] tests

  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:
2:53 PM Changeset in webkit [100511] by tony@chromium.org
  • 3 edits in trunk/Tools

[NRWT] speculative fix for multiple subprocess test on cygwin
​https://bugs.webkit.org/show_bug.cgi?id=72518

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably

tries to emulate posix fd behavior.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2:46 PM Changeset in webkit [100510] by msaboff@apple.com
  • 22 edits in trunk/Source

Enable 8 Bit Strings in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=71337

Source/JavaScriptCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change rippled into WebCore code as well.

Reviewed by Geoffrey Garen.

(JSC::::append8): Changed to use 8 bit buffers.
(JSC::::parseIdentifier): Changed to use 8 bit buffers.
(JSC::::parseString): Changed to use 8 bit buffers.

  • runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::translate): 8 bit version keeps data 8 bit
(JSC::Identifier::toUInt32FromCharacters): Templated helper.
(JSC::Identifier::toUInt32): Added 8 bit optimized path.

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage): Changed to be 8 bit strings

  • runtime/UString.h:

(JSC::UString::characters): Now calls StringImpl::characters()

  • wtf/Forward.h:
  • wtf/text/StringBuffer.h: Made StringBuffer a template base on character type.

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::characters):
(WTF::StringBuffer::release):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase): Fixed null terminated case.
(WTF::StringImpl::removeCharacters): Added 8 bit path.
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::simplifyWhiteSpace):
(WTF::equal): Removed bug from code copied from null terminated version.
(WTF::StringImpl::adopt): Added 8 bit path.
(WTF::StringImpl::createWithTerminatingNullCharacter): Fixed 8 bi flag propagation.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl): Added new 8 bit constructor.
(WTF::StringImpl::characters8): Removed ASSERT_NOT_REACHED().
(WTF::getCharacters<LChar>): Added templated accessor for 8 bit strings.
(WTF::getCharacters<UChar>): Added templated accessor for 16 bit strings.

  • wtf/text/WTFString.h:

(WTF::String::adopt): Changed to use StringBuffer template.

Source/WebCore:

This patch turns on 8 bit strings in StringImpl and enables
their use in JavaScriptCore. Some of the changes are to
turn on code that had been staged (Lexer.cpp, Identifier.cpp,
SmallStrings.cpp and some of StringImpl.{h,cpp}).
Other changes are minor fixes to make 8 bit strings work
(UString.h, StringImpl::getData16SlowCase()).
Changed StringBuffer to be a templated class based on character
type. This change riplled into WebCore code as well.

Reviewed by Geoffrey Garen.

No new tests - Changes in response to refactoring StringBuffer to
be a template on character type.

  • css/CSSParser.cpp:

(WebCore::quoteCSSString):

  • css/CSSPrimitiveValue.cpp:

(WebCore::formatNumber):

  • dom/Document.cpp:

(WebCore::canonicalizedTitle):

  • platform/Length.cpp:

(WebCore::newCoordsArray):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):

2:44 PM Changeset in webkit [100509] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Run a dummy test in the gpu configurations if there's nothing to do.
​https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2:37 PM Changeset in webkit [100508] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Improvements for page scale delta during commit
​https://bugs.webkit.org/show_bug.cgi?id=72471

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

Page scale now follows the same commit flow as scroll position:
the delta is folded into m_pageScale at BFAC time, and a "sent" value
is preserved for temporary use until the commit finishes.

I also merged setPageScaleFactor and setPageScaleFactorLimits into one
function on the impl side. The reason is that setPageFactor must
be applied after the limits are updated, but on the other hand setting
the limits first may cause an unnecessary clamp of the scale delta.
Merging the methods avoids this bind.

No new tests. (planning to add later: ​https://bugs.webkit.org/show_bug.cgi?id=71529)

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyScrollAndScale):

2:34 PM Changeset in webkit [100507] by pkasting@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Attempt to rebaseline a test.
​https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
  • platform/chromium/test_expectations.txt:
2:24 PM Changeset in webkit [100506] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Platform specific results for svg/foreignObject/{clip,filter,mask}.html
​https://bugs.webkit.org/show_bug.cgi?id=72532

Patch by Florin Malita <​fmalita@google.com> on 2011-11-16
Reviewed by Steve Block.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
2:24 PM Changeset in webkit [100505] by rniwa@webkit.org
  • 3 edits in trunk/Tools

contributors_by_fuzzy_match is super slow
​https://bugs.webkit.org/show_bug.cgi?id=72540

Reviewed by Eric Seidel.

Make contributors_by_name do case insensitive search using a dictionary.

Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
because that's the most common case.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
2:21 PM Changeset in webkit [100504] by commit-queue@webkit.org
  • 6 edits in trunk

IndexedDB: Reduce nested key depth threshold, re-enable flaky test
​https://bugs.webkit.org/show_bug.cgi?id=72529

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-16
Reviewed by Adam Barth.

Source/WebCore:

Drop maximum array key depth from 20k to 2k.

  • bindings/v8/IDBBindingUtilities.cpp:

LayoutTests:

Re-enable flaky test, and drop the maximum depth tested to avoid
crashes/timeouts on test boxes when prepping the test.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
2:10 PM Changeset in webkit [100503] by Nate Chapin
  • 5 edits in trunk

Source/WebCore: Fix incorrect multipart handling in r100311.
SubresourceLoader::didReceiveData() is getting called
twice, which has unintended side effects.
​https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

http/tests/multipart/invalid-image-data.html should stop
asserting after this.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

  • loader/SubresourceLoader.h:

LayoutTests: Remove CRASH expectation for
http/tests/multipart/invalid-image-data.html.
​https://bugs.webkit.org/show_bug.cgi?id=72436

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [100502] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

Clear SVG filter client when its node is detached
​https://bugs.webkit.org/show_bug.cgi?id=71741

Reviewed by Eric Seidel.

Source/WebCore:

Test: svg/filters/reparent-animated-filter-target.html

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientDestroyed):

LayoutTests:

  • svg/filters/reparent-animated-filter-target-expected.txt: Added.
  • svg/filters/reparent-animated-filter-target.html: Added.
2:02 PM Changeset in webkit [100501] by pkasting@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
Linux, and as expected to fail for now on Mac; remove current expected
Mac baselines.
​https://bugs.webkit.org/show_bug.cgi?id=47925

Unreviewed, gardening.

  • platform/chromium-mac/compositing/plugins/composited-plugin-expected.txt: Removed.
  • platform/chromium-mac/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
  • platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [100500] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Page/layer flashes after GPU-accelerated CSS transition
​https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <​jbates@google.com> on 2011-11-16
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
1:51 PM Changeset in webkit [100499] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style should recognize functions even if they have OVERRIDE after them.
​https://bugs.webkit.org/show_bug.cgi?id=72515

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
1:22 PM Changeset in webkit [100498] by jamesr@google.com
  • 10 edits
    12 copies
    23 adds in trunk/LayoutTests

[chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to reflect that chromium DRT has
2d and 3d transforms enabled

  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-linux-x86/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-linux-x86/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-linux-x86/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-linux-x86/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win-vista/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-win-vista/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-win-vista/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-win-vista/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win-xp/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-win-xp/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt.
  • platform/chromium-win-xp/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-win-xp/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt.
  • platform/chromium-win/fast/media/mq-transform-02-expected.png:
  • platform/chromium-win/fast/media/mq-transform-02-expected.txt:
  • platform/chromium-win/fast/media/mq-transform-03-expected.png:
  • platform/chromium-win/fast/media/mq-transform-03-expected.txt:
  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [100497] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Fix up chromium API for creating events, initializing message events
​https://bugs.webkit.org/show_bug.cgi?id=71478

  • Fix a mistake when checking the exception code during event creation.
  • Change WebFrame parameter to pointer so that NULL may be passed.

This is required for the following chromium CL: ​http://codereview.chromium.org/8437093/

Tested in Chromium by:

ui_test --gtest_filter=*PPAPITest.PostMessage*

Patch by Dave Michael <​dmichael@chromium.org> on 2011-11-16
Reviewed by Darin Fisher.

  • public/WebDOMMessageEvent.h:
  • src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebDocument.cpp:

(WebKit::WebDocument::createEvent):

1:11 PM Changeset in webkit [100496] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add null pointer check in setDeviceScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=72464

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-16
Reviewed by James Robinson.

No new tests. (Tiny fix.)

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

1:07 PM Changeset in webkit [100495] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r100438.
​http://trac.webkit.org/changeset/100438
​https://bugs.webkit.org/show_bug.cgi?id=72536

Broke unit tests (Requested by jamesr_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:
  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

1:03 PM Changeset in webkit [100494] by tony@chromium.org
  • 5 edits in trunk/Tools

[NRWT] refactor drivers to require pixel_tests param
​https://bugs.webkit.org/show_bug.cgi?id=72517

Reviewed by Ojan Vafai.

No tests, just a refactoring.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:50 PM Changeset in webkit [100493] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

De-virtualize ExecutableBase::clearCodeVirtual
​https://bugs.webkit.org/show_bug.cgi?id=72337

Reviewed by Darin Adler.

Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):

12:43 PM Changeset in webkit [100492] by aestes@apple.com
  • 4 edits in trunk/Source/WebCore

Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=72535

Reviewed by Anders Carlsson.

LayerFlushScheduler attempted to use a counter strategy for calls to
suspend() and resume(), which allowed us to assert that these calls
were balanced. Unfortunately it is hard to guarantee this in WebKit2,
where we sometimes try to call suspend() before we've entered
compositing mode (hence before we have a LayerTreeHost and a
LayerFlushScheduler). When we later call resume(), this call ends up
being unbalanced and asserts.

For now, remove the assertions and allow unbalanced calls to suspend()
and resume().

  • platform/graphics/ca/LayerFlushScheduler.cpp:

(WebCore::LayerFlushScheduler::suspend):
(WebCore::LayerFlushScheduler::resume):

  • platform/graphics/ca/LayerFlushScheduler.h:
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
(WebCore::LayerFlushScheduler::schedule):

12:42 PM Changeset in webkit [100491] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Run a dummy test in the gpu configurations if there's nothing to do.
​https://bugs.webkit.org/show_bug.cgi?id=72498

Reviewed by James Robinson.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:27 PM Changeset in webkit [100490] by robert@webkit.org
  • 17 edits
    5 deletes in trunk

Unreviewed, rolling out r100473.
​http://trac.webkit.org/changeset/100473
​https://bugs.webkit.org/show_bug.cgi?id=72534

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-16

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::addChild):

  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp: Removed.
  • rendering/RenderTableCaption.h: Removed.

LayoutTests:

  • css2.1/20110323/border-collapse-offset-002.htm: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/mac/fast/repaint/table-section-repaint-expected.txt:
12:25 PM Changeset in webkit [100489] by robert@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r100479.
​http://trac.webkit.org/changeset/100479
​https://bugs.webkit.org/show_bug.cgi?id=72533

"Broke the Mac Build" (Requested by mwenge2 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-16

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderingAllInOne.cpp:
12:17 PM Changeset in webkit [100488] by Chris Fleizach
  • 47 edits
    17 adds in trunk

WebKitTestRunner needs to support accessibility-related DRT APIs
​https://bugs.webkit.org/show_bug.cgi?id=42131

Tools:

Reviewed by Beth Dakin.

Port the AX code in DRT to WKTestRunner by using IDL.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(horizontalScrollbarCallback):
(verticalScrollbarCallback):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.

(WTR::AccessibilityController::create):
(WTR::AccessibilityController::AccessibilityController):
(WTR::AccessibilityController::~AccessibilityController):
(WTR::AccessibilityController::makeWindowObject):
(WTR::AccessibilityController::wrapperClass):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::elementAtPoint):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.

(WTR::AccessibilityController::logFocusEvents):
(WTR::AccessibilityController::logValueChangeEvents):
(WTR::AccessibilityController::logScrollingStartEvents):
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::notificationReceived):
(WTR::AccessibilityController::resetToConsistentState):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.

(WTR::AccessibilityTextMarker::create):
(WTR::AccessibilityTextMarker::AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
(WTR::AccessibilityTextMarker::platformTextMarker):
(WTR::AccessibilityTextMarker::wrapperClass):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.

(WTR::AccessibilityTextMarker::isEqual):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.

(WTR::AccessibilityTextMarkerRange::create):
(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
(WTR::AccessibilityTextMarkerRange::wrapperClass):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.

(WTR::AccessibilityUIElement::create):
(WTR::AccessibilityUIElement::wrapperClass):
(WTR::AccessibilityUIElement::isValid):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.

(WTR::AccessibilityUIElement::platformUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::accessibilityController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.

(WTR::AccessibilityTextMarker::isEqual):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.

(WTR::AccessibilityTextMarkerRange::isEqual):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.

(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::descriptionOfValue):
(WTR::attributesOfElement):
(WTR::concatenateAttributeAndValue):
(WTR::convertNSArrayToVector):
(WTR::descriptionOfElements):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

(WTR::LayoutTestController::platformName):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

Cleanup tests and skip lists so that accessibility tests can run
in WK2. This mostly involved handling returned elements that might be nil,
something that did not happen in DRT.

Reviewed by Beth Dakin.

  • accessibility/aria-labelledby-overrides-label-expected.txt:
  • accessibility/aria-labelledby-overrides-label.html:
  • accessibility/non-data-table-cell-title-ui-element.html:
  • accessibility/th-as-title-ui.html:

Make sure a nil titleUIElement is accounted for in these tests.

  • platform/gtk-wk2/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt:
  • platform/mac/accessibility/aria-expanded-notifications.html:
  • platform/mac/accessibility/aria-invalid-expected.txt:
  • platform/mac/accessibility/aria-invalid.html:
  • platform/mac/accessibility/aria-liveregions-addedelement-expected.txt:
  • platform/mac/accessibility/aria-liveregions-addedelement.html:
  • platform/mac/accessibility/aria-liveregions-changedalt-expected.txt:
  • platform/mac/accessibility/aria-liveregions-changedalt.html:
  • platform/mac/accessibility/aria-liveregions-changedtext-expected.txt:
  • platform/mac/accessibility/aria-liveregions-changedtext.html:
  • platform/mac/accessibility/aria-liveregions-removedelement-expected.txt:
  • platform/mac/accessibility/aria-liveregions-removedelement.html:

All the preceeding layout tests use alert() to output the results of notifications. This
is causing re-ordering issues on WK2, so I've moved them all to output that notification
data to a separate element from "console".

  • platform/mac/accessibility/html-section-elements-expected.txt:
  • platform/mac/accessibility/html-section-elements.html:

Remove nil element access that is unnecessary.

  • platform/mac/accessibility/html-slider-indicator-expected.txt:
  • platform/mac/accessibility/html-slider-indicator.html:
  • platform/mac/accessibility/search-predicate.html:

Add an alt tag to <img> so that it always shows up in the AX tree.

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox.html:
  • platform/mac/accessibility/textbox-role-reports-notifications-expected.txt:

Remove the notification listener properly (was causing flakiness).

  • platform/mac/accessibility/textbox-role-reports-notifications.html:
  • platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt:
  • platform/mac/accessibility/update-children-when-aria-role-changes.html:

Account for when element's returned are nil.

  • platform/win-wk2/Skipped:

Skip all accessibility tests on win.

  • platform/wk2/Skipped:

Skip all accessibility tests on gtk.

12:14 PM Changeset in webkit [100487] by Chris Fleizach
  • 6 edits in trunk/Source

WebKitTestRunner needs to support accessibility-related DRT APIs
​https://bugs.webkit.org/show_bug.cgi?id=42131

../WebCore:

Minor changes needed to support AX testing in WKTestRunner.

Reviewed by Beth Dakin.

  • WebCore.exp.in:

Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(accessibilitySearchKeyForString):

Remove an unncessary assert that was causing issues with the WK2 test run.

../WebKit2:

Allow the injected bundle to retrieve the focused and root accessibility
objects.

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
12:12 PM Changeset in webkit [100486] by sergio@webkit.org
  • 4 edits in trunk

[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
​https://bugs.webkit.org/show_bug.cgi?id=69219

Reviewed by Martin Robinson.

Source/WebCore:

Do not stop appending data to the request body if any of the blob
items to upload is not accesible.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addEncodedBlobToSoupMessageBody):

LayoutTests:

Unskipped a test that now pass.

  • platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html
11:59 AM Changeset in webkit [100485] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg
​https://bugs.webkit.org/show_bug.cgi?id=72530

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [100484] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Merged r93043.

11:53 AM Changeset in webkit [100483] by Beth Dakin
  • 9 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=72400
Scrollbar uiStateTransitionProgress requires tracking the mouse all the time
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This patch makes it so we track the mouse all the time when we have legacy
scrollbars (rather than only tracking the mouse when the window is key). When
we're in that mode, we want to do as little work as possible when handling the
mouseMoved event so that this extra tracking has little to no performance impact.
Also, we don't want to change basic behaviors by having normal web content hover
effects start happening when a window is in the background. So this patch also
introduces a way to handle a mouseMoved event that will only affect scrollbars.

EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a
boolean parameter that indicates if we are only updating scrollbars. If that is
the case, then we make our HitTestRequest ReadOnly, and we return early once
updateLastScrollbarUnderMouse() is called.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):

In addition to calling Scrollbar::mouseExited() when appropriate, this function
now calls a new function, Scrollbar::mouseEntered() when appropriate.
(WebCore::EventHandler::updateLastScrollbarUnderMouse):

  • page/EventHandler.h:

Scrollbar::mouseMoved() used to be responsible for calling
ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes
care of that instead, much like how Scrollbar::mouseExited() takes care of calling
the animator's exit function.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseEntered):

  • platform/Scrollbar.h:

Source/WebKit2:

Set up our initial tracking area based on the currently recommended scrollbar
style. Track the mouse all the time if the style is legacy.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

Now that we might be getting mouseMoved events all the time even when the window
is not key, make sure we opt into the new 'onlyUpdateScrollbars' mode for
EventHandler::mouseMoved() when the window is not focused.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

11:47 AM Changeset in webkit [100482] by Lucas Forschler
  • 86 edits in branches/safari-534.53-branch/Source

Merge 93040.

11:42 AM Changeset in webkit [100481] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSValue: isInheritedValue() doesn't need a dedicated bit.
<​http://webkit.org/b/72514>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Remove CSSValue::m_isInherited and have isInheritedValue() check the
class type instead. There's no compelling reason for CSSInheritedValue
to have a dedicated bit, since nobody subclasses it anyway.

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::CSSValue):

11:42 AM Changeset in webkit [100480] by Lucas Forschler
  • 15 edits in branches/safari-534.53-branch/Source

Merge 91161.

11:39 AM Changeset in webkit [100479] by robert@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix build on Windows and Mac after r100473

Unreviewed, fix build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderingAllInOne.cpp:
11:34 AM Changeset in webkit [100478] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Unskip these tests now that they should pass again.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
11:31 AM Changeset in webkit [100477] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Merge 89441.

11:29 AM Changeset in webkit [100476] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Update test results after tightening up SecurityOrigin logic in
​http://trac.webkit.org/changeset/100182. These new results are (minor)
progressions on these tests.

  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
11:16 AM Changeset in webkit [100475] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove extra GraphicsContextStateSaver restore() call.
​https://bugs.webkit.org/show_bug.cgi?id=72497

Patch by Philip Rogers <​pdr@google.com> on 2011-11-16
Reviewed by Andreas Kling.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

11:13 AM Changeset in webkit [100474] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add minimum/maximumPageScaleFactor API and clamp fixes
​https://bugs.webkit.org/show_bug.cgi?id=72463

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-16
Reviewed by Darin Fisher.

We need a way to read back the computed min/max page scale factor in
order to support the software path, and for some application logic
such as zooming in/out when tapping form fields.

I also added a few clamp calls that are needed in some corner cases.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::minimumPageScaleFactor):
(WebKit::WebViewImpl::maximumPageScaleFactor):

  • src/WebViewImpl.h:
11:11 AM Changeset in webkit [100473] by robert@webkit.org
  • 17 edits
    5 adds in trunk

CSS 2.1 failure: border-collapse-offset-002.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=71705

Source/WebCore:

Table captions are implemented as children of the table but have a special
requirement to expand to the full width of the table rather than just the 'available'
width, i.e. the full width minus padding and borders.

To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
to return the full width of the containing block (i.e. the table) rather than the available width.

Reviewed by Antti Koivisto.

  • CMakeLists.txt: Add RenderTableCaption.[cpp|h]
  • GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
  • Target.pri: Add RenderTableCaption.[cpp|h]
  • WebCore.gypi: Add RenderTableCaption.[cpp|h]
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
(WebCore::RenderObject::addChild): ditto

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp: Added.

(WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
(WebCore::RenderTableCaption::~RenderTableCaption):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.

  • rendering/RenderTableCaption.h: Added.

(WebCore::RenderTableCaption::isTableCaption):
(WebCore::toRenderTableCaption):

LayoutTests:

Table captions now use the width of the table rather than the width of the table minus
the borders. This allows captions to center accurately but unfortunately a lot of mozilla
table tests need to be rebaselined as many of them use captions for explaining the purpose
of individual test files!

Add border-collapse-offset-002.htm which now renders correctly.

Affected tables/mozilla tests are rebaselined in a follow-up patch.

Reviewed by Antti Koivisto.

  • css2.1/20110323/border-collapse-offset-002.htm: Added.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/mac/fast/repaint/table-section-repaint-expected.txt:
11:03 AM Changeset in webkit [100472] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add ewk_settings_memory_cache_clear().
​https://bugs.webkit.org/show_bug.cgi?id=72141

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

This is the same as Qt's QWebSettings::clearMemoryCaches() and is
responsible for clearing, among others, the page, memory and font
caches.

  • ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

  • ewk/ewk_settings.h:
11:03 AM Changeset in webkit [100471] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
​https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-11-16
Reviewed by Adam Barth.

  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Added.
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Added.
10:56 AM Changeset in webkit [100470] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Gtk] display:none has no effect on <option> element.
​https://bugs.webkit.org/show_bug.cgi?id=72370

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Martin Robinson.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem):

10:44 AM Changeset in webkit [100469] by commit-queue@webkit.org
  • 5 edits in trunk

String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
​https://bugs.webkit.org/show_bug.cgi?id=71572

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2011-11-16
Reviewed by Gavin Barraclough and Darin Adler.

Source/JavaScriptCore:

  • runtime/RegExpObject.cpp:

(JSC::regExpObjectSource):

LayoutTests:

  • fast/regex/script-tests/toString.js:

(testLineTerminator):

  • fast/regex/toString-expected.txt:
10:32 AM Changeset in webkit [100468] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Link error running gtkdoc-scangobj
​https://bugs.webkit.org/show_bug.cgi?id=72365

Patch by Martin Robinson <​mrobinson@igalia.com> on 2011-11-16
Reviewed by Xan Lopez.

  • webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig

file so that the compiler links to it.

10:30 AM Changeset in webkit [100467] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

10:20 AM Changeset in webkit [100466] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Fix platformDefersLoading to handle non-http requests, and
to not use broken-ish libsoup APIs.
​https://bugs.webkit.org/show_bug.cgi?id=72227

Patch by Dan Winship <​danw@gnome.org> on 2011-11-16
Reviewed by Martin Robinson.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::hasBeenSent):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback): rather than deferring by using
soup_session_pause_message(), let the read complete, but just don't
process the result until we're no longer deferred.
(WebCore::startNonHTTPRequest): Don't start the request if
it's deferred.

10:16 AM Changeset in webkit [100465] by commit-queue@webkit.org
  • 14 edits
    22 deletes in trunk/LayoutTests

Recent svg/foreignObject tests failing on Mac & Win
​https://bugs.webkit.org/show_bug.cgi?id=72386

Patch by Florin Malita <​fmalita@google.com> on 2011-11-16
Reviewed by Simon Fraser.

Drop unnecessary text elements from the svg/FO tests to avoid platform font size variance.

  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Removed.
  • platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/clip-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/filter-expected.txt: Removed.
  • platform/chromium-win/svg/foreignObject/mask-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/clip-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/filter-expected.txt: Removed.
  • platform/chromium/svg/foreignObject/mask-expected.txt: Removed.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
  • platform/qt/svg/foreignObject/background-render-phase-expected.png: Removed.
  • platform/qt/svg/foreignObject/background-render-phase-expected.txt: Removed.
  • platform/qt/svg/foreignObject/clip-expected.png: Removed.
  • platform/qt/svg/foreignObject/clip-expected.txt: Removed.
  • platform/qt/svg/foreignObject/filter-expected.png: Removed.
  • platform/qt/svg/foreignObject/filter-expected.txt: Removed.
  • platform/qt/svg/foreignObject/mask-expected.png: Removed.
  • platform/qt/svg/foreignObject/mask-expected.txt: Removed.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Removed.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Removed.
  • svg/foreignObject/background-render-phase-expected.txt:
  • svg/foreignObject/background-render-phase.html:
  • svg/foreignObject/clip-expected.png:
  • svg/foreignObject/clip-expected.txt:
  • svg/foreignObject/clip.html:
  • svg/foreignObject/filter-expected.png:
  • svg/foreignObject/filter-expected.txt:
  • svg/foreignObject/filter.html:
  • svg/foreignObject/mask-expected.png:
  • svg/foreignObject/mask-expected.txt:
  • svg/foreignObject/mask.html:
  • svg/foreignObject/multiple-foreign-objects-expected.txt:
  • svg/foreignObject/multiple-foreign-objects.html:
10:05 AM Changeset in webkit [100464] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][X11] Don't leak the colormap we created for the plugin
​https://bugs.webkit.org/show_bug.cgi?id=72144

Reviewed by Xan Lopez.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformDestroy):

9:33 AM Changeset in webkit [100463] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Clean up the web database-related functions in ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=72139

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
more standard naming scheme for the related static variables.

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):

  • ewk/ewk_settings.h: Document the default web database path on disk.
9:29 AM Changeset in webkit [100462] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
​https://bugs.webkit.org/show_bug.cgi?id=72475

Reviewed by Adam Roben.

  • wtf/HashTraits.h: Specialize HashTraits for OwnPtr.

Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtr<T> and OwnPtr<T*>.

9:27 AM Changeset in webkit [100461] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Fix use of config.tests

We were checking @buildArgs to determine if the optional argument was
passed or not, but this is not the right way to do that in Perl. The
right way is to not use a prototype for the function, and to pass
the list as a reference (to avoid list expansion). That way we can
check the number of arguments, and choose the right code path based
on that.

We were also missing a default-value of 0 for any feature that's not
set in features.prf.

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(qtFeatureDefaults):
(buildQMakeProject):

9:20 AM Changeset in webkit [100460] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Prospective fix for broken plugin tests

Don't hide symbols for the NPAPI test plugin

Rubber-stamped by Andreas Kling.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8:57 AM Changeset in webkit [100459] by jesus@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r100448.
​http://trac.webkit.org/changeset/100448
​https://bugs.webkit.org/show_bug.cgi?id=72512

It caused a regression breaking LayoutTests/http/tests/loading
/text-content-type-with-binary-extension.html (Requested by
jeez_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-16

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

8:55 AM Changeset in webkit [100458] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Web Inspector: Application cache status should be updated after swapCache().
​https://bugs.webkit.org/show_bug.cgi?id=72123

Patch by Vsevolod Vlasov <​vsevik@chromium.org> on 2011-11-16
Reviewed by Pavel Feldman.

  • http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
  • http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-swap.html: Added.
  • http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
  • http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
  • http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
  • http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.
8:50 AM Changeset in webkit [100457] by Adam Roben
  • 3 edits in trunk/Tools

Move filenames/line numbers off to the right edge in Leaks Viewer

Fixes <​http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
because filenames/line numbers are right next to function names

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:

(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
function name. Use the filename as the profile node's URL (we don't have enough info to
compute a real URL currently) and the line number as the profile node's line number so the
Inspector code will put them on the right side of the callstack graph.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
passed here, just filenames.

(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyResourceAsNode):
Copied and slightly modified from inspector.js.

8:50 AM Changeset in webkit [100456] by Adam Roben
  • 2 edits in trunk/Tools

Make Leaks Viewer load builds from the new Lion Leaks bot

Fixes <​http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
SnowLeopard one.

8:37 AM Changeset in webkit [100455] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
​https://bugs.webkit.org/show_bug.cgi?id=72392

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-11-16
Reviewed by Simon Hausmann.

Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
deallocation of referenced object.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):

8:09 AM Changeset in webkit [100454] by vsevik@chromium.org
  • 7 edits
    6 moves
    9 adds
    3 deletes in trunk

Web Inspector: Application cache status should be updated after swapCache().
​https://bugs.webkit.org/show_bug.cgi?id=72123

Reviewed by Pavel Feldman.

Source/WebCore:

Application cache view resources and status are now updated after swapCache() call.
Refresh button removed from application cache view.
Application cache inspector tests are moved to their own folder.

Tests: http/tests/inspector/appcache/appcache-iframe-manifests.html

http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/appcache/appcache-swap.html

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
(WebInspector.ApplicationCacheItemsView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheItemsView.prototype._markDirty):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::setNewestCache):
(WebCore::ApplicationCacheGroup::makeObsolete):
(WebCore::ApplicationCacheGroup::setUpdateStatus):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::swapCache):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::swapCache):

LayoutTests:

  • http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt.
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html.
  • http/tests/inspector/appcache/appcache-swap-expected.txt: Added.
  • http/tests/inspector/appcache/appcache-swap.html: Added.
  • http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js.

(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.swapFrameCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived):
(initialize_ApplicationCacheTest):

  • http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php.
  • http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php.
  • http/tests/inspector/appcache/resources/versioned-manifest.php: Added.
  • http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added.
  • http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed.
  • platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed.
8:05 AM Changeset in webkit [100453] by eric.carlson@apple.com
  • 9 edits
    4 adds in trunk

addTrack() must throw an exception if 'kind' is unknown
​https://bugs.webkit.org/show_bug.cgi?id=71915

Reviewed by Philippe Normand.

Source/WebCore:

Tests: media/track/track-addtrack-kind.html

media/track/track-kind.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
(WebCore::HTMLMediaElement::addTrack): Throw if 'kind' is not a known value.
(WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track

list object if necessary.

(WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks

is allowed.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus

a mandatory ExceptionCode parameter.

  • html/HTMLMediaElement.idl: addTrack can generate an exception.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should

percolate down the the TextTrack.

(WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the

same as the attribute value.

(WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
(WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.

  • html/HTMLTrackElement.h:
  • html/TextTrack.cpp:

(WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
(WebCore::TextTrack::captionsKeyword): Ditto.
(WebCore::TextTrack::descriptionsKeyword): Ditto.
(WebCore::TextTrack::chaptersKeyword): Ditto.
(WebCore::TextTrack::metadataKeyword): Ditto.
(WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
(WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
(WebCore::TextTrack::setKind): Only allow legal values.

  • html/TextTrack.h:

(WebCore::TextTrack::kind):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
(WebCore::TextTrack::readyState):
(WebCore::TextTrack::mode):

LayoutTests:

  • media/track/track-addtrack-kind-expected.txt: Added.
  • media/track/track-addtrack-kind.html: Added.
  • media/track/track-kind-expected.txt: Added.
  • media/track/track-kind.html: Added.
8:01 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
7:58 AM Changeset in webkit [100452] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Clean up the offline apps-related functions in ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=72132

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.

ewk_settings_cache' and ewk_view_setting_cache' are too common
prefixes for code that is related only to the HTML5 app cache
features.

Use `ewk_settings_application_cache' and
`ewk_view_setting_application_cache' instead.

Source/WebKit/efl:

While here, improve the documentation and use a more common naming
scheme for the static variable which holds the cache path.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_application_cache_path_set):
(ewk_settings_application_cache_path_get):

  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp:

(ewk_view_setting_application_cache_get):
(ewk_view_setting_application_cache_set):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

7:57 AM Changeset in webkit [100451] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, test fix after ​http://trac.webkit.org/changeset/100273.

"font" property is no longer mapped to DOMCSSValue, so use "font-family" mapped to DOMCSSValueList instead.

  • platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
  • platform/mac/plugins/jsobjc-dom-wrappers.html:
7:52 AM Changeset in webkit [100450] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
​https://bugs.webkit.org/show_bug.cgi?id=72504

Unreviewed gardening. Skip crashing test.

  • platform/qt/Skipped:
7:49 AM Changeset in webkit [100449] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

CSSValue: Clean up initial value construction.
<​http://webkit.org/b/72502>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-16
Reviewed by Antti Koivisto.

Instead of determining whether a given CSSInitialValue is 'implicit' or not by
querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
add a protected CSSValue member and set it from the CSSInitialValue constructor.

Also get rid of the CSSValue::m_isInitial bit since we can now replace the
checks by classType() == InitialClass.

No new tests, this is a cleanup.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

Poke 'implicit' constructor argument into CSSValue::m_isImplicit.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

Remove ImplicitInitialClass cases.

  • css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::CSSValue):

7:12 AM Changeset in webkit [100448] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
​https://bugs.webkit.org/show_bug.cgi?id=72169

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-11-16
Reviewed by Simon Hausmann.

Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMEType):

7:07 AM Rebaseline edited by epoger@google.com
(diff)
7:05 AM Rebaseline edited by epoger@google.com
(diff)
7:04 AM Changeset in webkit [100447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary if check from RenderListBox::paintItemForeground.
​https://bugs.webkit.org/show_bug.cgi?id=72488

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2011-11-16
Reviewed by Andreas Kling.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

7:04 AM Rebaseline edited by epoger@google.com
(diff)
7:00 AM Changeset in webkit [100446] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Layout Test inspector/styles/svg-style.xhtml is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
6:56 AM Changeset in webkit [100445] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
​https://bugs.webkit.org/show_bug.cgi?id=72389

Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET.

Reviewed by Tor Arne Vestbø.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
6:54 AM Changeset in webkit [100444] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip new failing tests.

Unreviewed gardening.

  • platform/qt-mac/Skipped:
6:42 AM Changeset in webkit [100443] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
​https://bugs.webkit.org/show_bug.cgi?id=72493

[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311
​https://bugs.webkit.org/show_bug.cgi?id=72491

Unreviewed gardening.

  • platform/qt/Skipped:
6:28 AM Changeset in webkit [100442] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r100281 and r100437.
​http://trac.webkit.org/changeset/100281
​http://trac.webkit.org/changeset/100437
​https://bugs.webkit.org/show_bug.cgi?id=72496

It made all plugin tests fail with paralel NRWT (Requested by
ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-16

  • platform/qt/Skipped:
6:20 AM Changeset in webkit [100441] by Simon Hausmann
  • 9 edits in trunk

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

  • qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

6:17 AM Changeset in webkit [100440] by vestbo@webkit.org
  • 2 edits in trunk

Fix path to module file in root project file

Reviewed by Simon Hausmann.

  • WebKit.pro:
6:08 AM Changeset in webkit [100439] by caseq@chromium.org
  • 4 edits in trunk/LayoutTests

Layout Test inspector/extensions/extensions-events.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72447

Reviewed by Yury Semikhatsky.

  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • platform/chromium/test_expectations.txt:
6:04 AM Changeset in webkit [100438] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[chromium] Pass screen refresh rate into compositor.
​https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <​husky@google.com> on 2011-11-16
Reviewed by Tony Gentilcore.

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRefreshRate):

  • platform/chromium/PlatformSupport.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRefreshRate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

6:03 AM Changeset in webkit [100437] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100281.

  • platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html

again, because it makes all plugin related tests fail intermittently.

5:51 AM Changeset in webkit [100436] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
​https://bugs.webkit.org/show_bug.cgi?id=72494

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
5:28 AM EFLWebKit edited by rakuco@FreeBSD.org
Update the port information (diff)
5:13 AM Changeset in webkit [100435] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Layout Test inspector/extensions/extensions-events.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
5:09 AM Changeset in webkit [100434] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test css3/flexbox/line-wrapping.html failing
​https://bugs.webkit.org/show_bug.cgi?id=72490

Unreviewed gardening.

  • platform/qt/Skipped:
4:56 AM Changeset in webkit [100433] by caseq@chromium.org
  • 6 edits
    2 moves
    2 adds in trunk

Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
​https://bugs.webkit.org/show_bug.cgi?id=72388

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/extensions/extensions-panel.html

inspector/extensions/extensions-sidebar.html

  • fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
  • drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
  • fix an exception when a page is replaced with object/expression.

inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.detach):

LayoutTests:

  • split LayoutTests/inspector/extensions.html into extensions-panel.html & extensions-sidebar.html.
  • inspector/extensions/extensions-panel-expected.txt: Added.
  • inspector/extensions/extensions-panel.html: Added.
  • inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
  • inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.
4:52 AM Changeset in webkit [100432] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Explicitly include unistd.h in TestNetscapePlugIn
​https://bugs.webkit.org/show_bug.cgi?id=72385

This is needed for the sleep() call in the indicateTestFailure method,
which seems to be implicitly available for other platforms. This is not
the case on Android.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4:48 AM Changeset in webkit [100431] by rgabor@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

[Qt] Update Qt specific expected results.

Unreviewed gardening.

  • platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
  • platform/qt/fast/loader/file-protocol-fragment-expected.txt:
  • platform/qt/inspector: Added.
  • platform/qt/inspector/console: Added.
  • platform/qt/inspector/console/console-format-expected.png: Added.
  • platform/qt/inspector/console/console-format-expected.txt: Added.
4:33 AM Changeset in webkit [100430] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Compositing LayoutTests failing on Chromium Mac
​https://bugs.webkit.org/show_bug.cgi?id=72487

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [100429] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
​https://bugs.webkit.org/show_bug.cgi?id=72485

Unreviewed gardening

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [100428] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
​https://bugs.webkit.org/show_bug.cgi?id=72384

Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):

2:56 AM Changeset in webkit [100427] by Simon Hausmann
  • 8 edits in trunk

Unreviewed, rolling out r100266.
​http://trac.webkit.org/changeset/100266

Broke WTR.

.:

  • Source/api.pri:

Source/JavaScriptCore:

  • Target.pri:

Source/WebCore:

  • Target.pri:

Tools:

  • qmake/mkspecs/features/default_post.prf:
2:51 AM Changeset in webkit [100426] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][ARMv5] Websocket tests are fail, skip until fix

Unreviewed, gardening.

  • platform/qt-arm/Skipped:
2:35 AM Changeset in webkit [100425] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
​https://bugs.webkit.org/show_bug.cgi?id=70720

Patch by Per-Erik Brodin <​per-erik.brodin@ericsson.com> on 2011-11-16
Reviewed by Philippe Normand.

Source/WebCore:

Added missing overriding of Event::interfaceName()

  • mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.

  • mediastream/MediaStreamEvent.h:
  • mediastream/MediaStreamEvent.idl: Changed module name to "events".

LayoutTests:

  • platform/gtk/Skipped: Unskipped fast/events/event-creation.html
1:46 AM Changeset in webkit [100424] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Do not hide accessibility root object from AT's
​https://bugs.webkit.org/show_bug.cgi?id=72390

Reviewed by Martin Robinson.

  • tests/testatk.c:

(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.

1:06 AM Changeset in webkit [100423] by eric@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
​https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

I will continue engaging hacks, until windows improves.

  • Scripts/webkitpy/common/host.py:
    • Host uses self.executive instead of self._executive like Port does.
    • I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
12:48 AM Changeset in webkit [100422] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium expectations for compositing tests

  • platform/chromium/test_expectations.txt:
12:41 AM Changeset in webkit [100421] by eric@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
​https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

Engage windows hacks harder.

This is a speculative fix for ChromiumWin. We're now
creating an SCM object much earlier, so we need to
engage our "awesome" windows hacks earlier.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
12:16 AM Changeset in webkit [100420] by jamesr@google.com
  • 10 edits
    5 moves
    1 add
    3 deletes in trunk/LayoutTests

[chromium] Update chromium win and linux compositing baselines
​https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png.
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
  • platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed.
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png.
  • platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png.
  • platform/chromium/test_expectations.txt:
12:16 AM Changeset in webkit [100419] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
​https://bugs.webkit.org/show_bug.cgi?id=72394

Reviewed by Martin Robinson.

No new functionality, no new tests needed.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.

12:06 AM Changeset in webkit [100418] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

Add a "pass type" and "peek type" concept to HashTraits
​https://bugs.webkit.org/show_bug.cgi?id=72473

Reviewed by Filip Pizlo.

  • wtf/HashTraits.h: Added the pass type and peek type.

For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.

12:05 AM Changeset in webkit [100417] by Darin Adler
  • 3 edits in trunk/Source/JavaScriptCore

Fix some hash traits that don't derive from the base hash traits
​https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

  • runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from

HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

  • runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive

from HashTraits<SymbolTableEntry> and removed redundant members.

Nov 15, 2011:

11:51 PM Changeset in webkit [100416] by Alexandru Chiculita
  • 16 edits
    7 copies
    4 adds in trunk

[CSSShaders] Implement the style cached resources and computed style for the shader urls
​https://bugs.webkit.org/show_bug.cgi?id=72378

Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/filters/custom-filter-property-computed-style.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
(WebCore::CSSStyleSelector::styleShader):
(WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::cachedOrPendingShader):

  • css/WebKitCSSShaderValue.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::~CachedShader):

  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterOperation.h:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::filter):

  • rendering/style/StyleCachedShader.cpp:

(WebCore::StyleCachedShader::StyleCachedShader):
(WebCore::StyleCachedShader::cssValue):

  • rendering/style/StyleCachedShader.h:

(WebCore::StyleCachedShader::create):

  • rendering/style/StylePendingShader.h:

(WebCore::StylePendingShader::create):
(WebCore::StylePendingShader::cssValue):
(WebCore::StylePendingShader::cssShaderValue):
(WebCore::StylePendingShader::StylePendingShader):

  • rendering/style/StyleShader.h:

(WebCore::StyleShader::~StyleShader):
(WebCore::StyleShader::isCachedShader):
(WebCore::StyleShader::isPendingShader):
(WebCore::StyleShader::StyleShader):

LayoutTests:

  • css3/filters/custom-filter-property-computed-style-expected.txt: Added.
  • css3/filters/custom-filter-property-computed-style.html: Added.
  • css3/filters/script-tests/custom-filter-property-computed-style.js: Added.

(jsWrapperClass):
(expression):
(description):

11:48 PM Changeset in webkit [100415] by jamesr@google.com
  • 2 edits
    1 copy
    11 moves
    17 adds
    3 deletes in trunk/LayoutTests

[chromium] Update chromium mac compositing baselines
​https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
  • platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
  • platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
  • platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
  • platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
  • platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
  • platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
  • platform/chromium/test_expectations.txt:
11:47 PM Changeset in webkit [100414] by Carlos Garcia Campos
  • 10 edits
    2 adds in trunk/Source/WebKit2

[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.

(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):

  • UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadRequest):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadRequest):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h:
11:24 PM Changeset in webkit [100413] by sergio@webkit.org
  • 5 edits in trunk

[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
​https://bugs.webkit.org/show_bug.cgi?id=69510

Reviewed by Simon Fraser.

Source/WebCore:

End the current transparency layer before early returning from
paintMask() when there is a maskBoxImage which is still being
loaded. This will balance the previous call to
beginTransparencyLayer().

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintMask):

LayoutTests:

Unskipped tests that are now passing.

  • platform/gtk/Skipped:
  • platform/gtk-wk2/Skipped:
11:23 PM Changeset in webkit [100412] by Csaba Osztrogonác
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r100375 and r100385.
​http://trac.webkit.org/changeset/100375
​http://trac.webkit.org/changeset/100385
​https://bugs.webkit.org/show_bug.cgi?id=72465

They broke 32 bit builds on Qt (Requested by ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice):

  • runtime/ArgList.h:

(JSC::ArgList::ArgList):

  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSGlobalObject.h:
11:19 PM Changeset in webkit [100411] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Land specific expectations for compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=72402

  • platform/chromium/test_expectations.txt:
11:09 PM Changeset in webkit [100410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
is inactive.
​https://bugs.webkit.org/show_bug.cgi?id=70407

Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly.

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-11-15
Reviewed by Noam Rosenthal.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::markForSync):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::markForSync):

  • WebCoreSupport/PageClientQt.h:

(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

10:46 PM Changeset in webkit [100409] by Darin Adler
  • 2 edits in trunk/Tools

DRT's uiElementAttributeValueCallback function is leaky
​https://bugs.webkit.org/show_bug.cgi?id=72453

Reviewed by Dan Bernstein.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

10:46 PM Changeset in webkit [100408] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Incorrect type checks in RenderTheme media code
​https://bugs.webkit.org/show_bug.cgi?id=72184

Reviewed by Eric Carlson.

No tests added. Ideally this patch should be revised to add tests!

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
(WebCore::AccessibilityMediaControl::controlType): Ditto.
(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
rather than an assertion to check type of input element.

  • html/shadow/MediaControlElements.cpp:

(WebCore::mediaControlElementType): Added. A type-safe way to get the
media control element type after checking isMediaControlElement but with
no other assumptions.

  • html/shadow/MediaControlElements.h: Added mediaControlElementType.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
use mediaControlElementType.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
redundant null check.
(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.

10:41 PM Changeset in webkit [100407] by rniwa@webkit.org
  • 6 edits
    2 adds
    1 delete in trunk/Tools

Implement edit-distance based reviewer recognition algorithm
​https://bugs.webkit.org/show_bug.cgi?id=72351

Reviewed by Eric Seidel.

Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
"build fix" to a reviewer's name (e.g. with with edit distance 9).

This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
the edit distance is implemented in edit_distance.py.

Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/common/editdistance.py: Added.
  • Scripts/webkitpy/common/editdistance_unittest.py: Added.
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
10:21 PM Changeset in webkit [100406] by staikos@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove the guard page from the addressable stack region on QNX.
​https://bugs.webkit.org/show_bug.cgi?id=72455

Reviewed by Daniel Bates.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

10:06 PM Changeset in webkit [100405] by msaboff@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=72323

Added 8 bit optimized paths for String and UString ascii() and utf8() methods.

Added String::characters8(), characters16() and is8Bit() helper methods.

Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().

Reviewed by Geoff Garen.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp:

(JSC::UString::utf8):

  • wtf/text/WTFString.cpp:

(WTF::String::ascii):
(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):

  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertLatin1ToUTF8):

  • wtf/unicode/UTF8.h:
  • wtf/unicode/Unicode.h:
9:46 PM Changeset in webkit [100404] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove expected PASS expectations for compositing tests.

This will result in a temporary spike in the number of unexpected
PASSes reported by the bots, but will allow me to add specific
expectations for all the compositing tests instead of the current
blanket PASS FAIL line.

  • platform/chromium/test_expectations.txt:
9:40 PM Changeset in webkit [100403] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove failing expectations from various JS tests that now pass.

  • platform/chromium/test_expectations.txt:
9:33 PM Changeset in webkit [100402] by annacc@chromium.org
  • 4 edits in trunk/LayoutTests

Make sure both the video and the track are ready to be tested before testing.
​https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Eric Carlson.

  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
9:12 PM Changeset in webkit [100401] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
​https://bugs.webkit.org/show_bug.cgi?id=72423

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::setDrawingBuffer):

9:10 PM Changeset in webkit [100400] by mhahnenberg@apple.com
  • 13 edits in trunk/Source/WebCore

Rebaseline generated WebCore bindings

Unreviewed build fix

No new tests.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::isObservable):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::clearImpl):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::isObservable):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::clearImpl):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::isObservable):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::isObservable):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

8:47 PM Changeset in webkit [100399] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
​https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

8:29 PM Changeset in webkit [100398] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/WebCore

JS DOM wrappers depend on destructor to deref impl RefPtrs
​https://bugs.webkit.org/show_bug.cgi?id=72341

Reviewed by Sam Weinig.

No new tests.

Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default
wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

8:28 PM Changeset in webkit [100397] by tony@chromium.org
  • 2 edits in trunk/Tools

Skip a failing webkitpy test on cygwin.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
8:17 PM Changeset in webkit [100396] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fix overlapping expectations
​https://bugs.webkit.org/show_bug.cgi?id=72458

  • platform/chromium/test_expectations.txt:
7:54 PM Changeset in webkit [100395] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Share Highlight Code for Drawing Outlined Quad
​https://bugs.webkit.org/show_bug.cgi?id=72451

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-15
Reviewed by Timothy Hatcher.

  • inspector/DOMNodeHighlighter.cpp:
7:18 PM Changeset in webkit [100394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r100308.
​http://trac.webkit.org/changeset/100308
​https://bugs.webkit.org/show_bug.cgi?id=72450

Introduces WebGL conformance test regressions. (Requested by
twiz on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

7:06 PM Changeset in webkit [100393] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [100392] by jamesr@google.com
  • 9 edits
    1 move
    1 add
    7 deletes in trunk/Source/WebCore

Rollout ​http://trac.webkit.org/changeset/99813, caused some crashes in
TiledLayerChromium::updateCompositorResources()

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.

(WebCore::LayerTextureUpdaterCanvas::contentRect):
(WebCore::LayerTextureUpdaterBitmap::orientation):
(WebCore::LayerTextureUpdaterSkPicture::orientation):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:
6:53 PM Changeset in webkit [100391] by Darin Adler
  • 5 edits in trunk/Source/JavaScriptCore

REGRESSION (r98887): ParserArena and Keywords leaking
​https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

  • parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

  • parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

  • runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
6:51 PM Changeset in webkit [100390] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix overlapping expectations on chromium mac

  • platform/chromium/test_expectations.txt:
6:49 PM Changeset in webkit [100389] by jchaffraix@webkit.org
  • 10 edits in trunk

Add the needed plumbing to parse display: -webkit-inline-grid
​https://bugs.webkit.org/show_bug.cgi?id=72438

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added the needed constants and plugged everything together.
Again we treat display: -webkit-inline-grid like display: none
for the moment.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Integrated testing for display: -webkit-inline-grid into the existing test.

  • fast/css-grid-layout/display-grid-set-get-expected.txt:
  • fast/css-grid-layout/display-grid-set-get.html:
  • fast/css-grid-layout/resources/display-grid-set-get.js:
6:38 PM Changeset in webkit [100388] by wjmaclean@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
​https://bugs.webkit.org/show_bug.cgi?id=72162

Reviewed by Kenneth Russell.

Refactoring of existing functionality, so uses existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

6:13 PM Changeset in webkit [100387] by pkasting@chromium.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r100340.
​http://trac.webkit.org/changeset/100340
​https://bugs.webkit.org/show_bug.cgi?id=72448

Caused assertion failure in Win dbg canary. (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
6:03 PM Changeset in webkit [100386] by jchaffraix@webkit.org
  • 12 edits in trunk/Source/WebCore

Switch table indexing to unsigned
​https://bugs.webkit.org/show_bug.cgi?id=72083

Reviewed by Darin Adler.

No expected change in behavior.

All of the code is now using unsigned for indexing!

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::colElement):
(WebCore::RenderTable::cellAbove):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):
Added some ASSERTs to make sure we don't underflow. Looking at how
the different variables are populated, they should not be reached.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Those 2 functions promotes HTMLTableCellElement's int to unsigned
which should be fine as we make sure their are positive. Also HTML5
makes those 2 fields "unsigned long" which goes in the same direction.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):
Rewrote a couple of reverse iterating to be able to use unsigned
without overflowing.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):

  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
(WebCore::RenderTable::recalcSections):

  • rendering/RenderTable.h:

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::spanOfEffCol):
(WebCore::RenderTable::effColToCol):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::CollapsedBorders::nextBorder):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::updateFromElement):

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::span):
(WebCore::RenderTableCol::setSpan):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::appendColumn):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
(WebCore::RenderTableSection::getBaseline):
Mechanical change int -> unsigned.

5:53 PM Changeset in webkit [100385] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

  • runtime/ArgList.h: Removed!
5:52 PM Changeset in webkit [100384] by aestes@apple.com
  • 10 edits
    4 adds in trunk/Source

Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
​https://bugs.webkit.org/show_bug.cgi?id=72106

Reviewed by Anders Carlsson.

Source/WebCore:

Add a class that encapsulates the logic of scheduling, enabling and
invalidating a run loop observer that fires before Core Animation's
commit observer. Clients can subclass LayerFlushSchedulerClient and
implement flushLayers(), which will be called by the observer.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/LayerFlushScheduler.cpp: Added.

(WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
invalidating the run loop observer. Keep a count of calls to suspend()
in m_suspendCount.
(WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
Install the run loop observer when it reaches 0.

  • platform/graphics/ca/LayerFlushSchedulerClient.h: Added.

(WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):

  • platform/graphics/ca/LayerFlushScheduler.h: Added.
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.

(LayerFlushScheduler::LayerFlushScheduler):
(LayerFlushScheduler::~LayerFlushScheduler):
(LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
the LayerFlushSchedulerClient.
(LayerFlushScheduler::schedule): Install the run loop observer.
(LayerFlushScheduler::invalidate): Remove the run loop
observer if it is installed.

Source/WebKit/mac:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebView/WebView.mm:

(-[WebView _close]): Invalidate the run loop observer and destroy the
LayerFlushController.
(LayerFlushController::flushLayers): Perform the work that
layerSyncRunLoopObserverCallBack used to do.
(-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
yet to be created, create it, then schedule a layer flush.

  • WebView/WebViewData.h:

(LayerFlushController::create): Create a LayerFlushController that
implements the LayerFlushSchedulerClient interface and contains a
LayerFlushScheduler with itself as the client.

  • WebView/WebViewData.mm:

(LayerFlushController::scheduleLayerFlush):
(LayerFlushController::invalidateObserver):
(LayerFlushController::LayerFlushController):

Source/WebKit2:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Replace

m_flushPendingLayerChangesRunLoopObserver with m_layerFlushScheduler
and implement the LayerFlushSchedulerClient interface.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Instantiate
m_layerFlushScheduler with the LayerTreeHost as the client.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Call LayerFlushScheduler::schedule().
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Call
LayerFlushScheduler::suspend() or LayerFlushScheduler::resume().
(WebKit::LayerTreeHostCAMac::invalidate): Call LayerFlushScheduler::invalidate().
(WebKit::LayerTreeHostCAMac::flushLayers): Do the work that
flushPendingLayerChangesRunLoopObserverCallback() used to do.
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush): Call LayerFlushScheduler::invalidate().

5:51 PM Changeset in webkit [100383] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Maybe the reason we're fiddling with line endings is that this file
didn't set svn:eol-style. Set it.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
5:47 PM Changeset in webkit [100382] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
5:43 PM Changeset in webkit [100381] by dslomov@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
until ​https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
5:41 PM Changeset in webkit [100380] by weinig@apple.com
  • 7 edits in trunk/Tools

TestWebKitAPI should not put its resources in the root products directory
​https://bugs.webkit.org/show_bug.cgi?id=72446

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Change the copy resources phase to place the resources in a TestWebKitAPI.resources
directory.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(TEST_F):

  • TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::url):

  • TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::url):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::createURLForResource):
Update calls to retrieve files from the bundle to look in the newly
created subdirectory.

5:36 PM Changeset in webkit [100379] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r100289

Unreviewed.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings
5:35 PM Changeset in webkit [100378] by weinig@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
​https://bugs.webkit.org/show_bug.cgi?id=72433

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetConnectionClient):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeConnectionClient):

  • UIProcess/WebContext.h:

Add connection client API.

  • UIProcess/WebContextConnectionClient.cpp: Added.

(WebKit::WebContextConnectionClient::didCreateConnection):

  • UIProcess/WebContextConnectionClient.h: Added.

Add basic implementation of the client. It is currently never triggered.

5:29 PM Changeset in webkit [100377] by tony@chromium.org
  • 2 edits in trunk/Tools

Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5:27 PM Changeset in webkit [100376] by adamk@chromium.org
  • 3 edits
    1 add
    3 deletes in trunk

[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
​https://bugs.webkit.org/show_bug.cgi?id=72432

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):

LayoutTests:

Updated test that depends on the error message. The new message is a
strict improvement, as it includes the line number at which the
too-deep call was triggered. Also, we only expect a single error
message; it's not clear why the previous version generated a dup.

Also consolidate expectations, as the test does not differ per platform.

  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
5:25 PM Changeset in webkit [100375] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use new API.

  • runtime/ArgList.cpp:

(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.

  • runtime/ArgList.h: Removed constructor that took a forward-contiguous

set of arguments.

  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • runtime/JSGlobalObject.h:

(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.

5:23 PM Changeset in webkit [100374] by tony@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, fix test-webkitpy tests. Move the check for image results
earlier.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:06 PM Changeset in webkit [100373] by scheib@chromium.org
  • 4 edits in trunk/Source/WebCore

Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
​https://bugs.webkit.org/show_bug.cgi?id=72431

Reviewed by Adam Barth.

  • page/PointerLock.cpp:

(WebCore::PointerLock::lock):
(WebCore::PointerLock::unlock):
(WebCore::PointerLock::isLocked):

  • page/PointerLock.h:
  • page/PointerLock.idl:
5:03 PM Changeset in webkit [100372] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/rendering

Converting table row height calculations back to ints and avoiding enclosingIntRect when outputting test expectations for table parts.

5:03 PM Changeset in webkit [100371] by oliver@apple.com
  • 652 edits
    148 adds
    85 deletes in branches/safari-534.54-branch

2011-11-15 Oliver Hunt <​oliver@apple.com>

Merged JavaScriptCore r92804-r99898.

Disabled thread verification on RefPtr, so as to minimise
changes needed by WebCore.

4:56 PM Changeset in webkit [100370] by nduca@chromium.org
  • 17 edits
    1 move
    5 deletes in trunk/Source

[chromium] Fuse MainThread and CCThread
​https://bugs.webkit.org/show_bug.cgi?id=72426

Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCMainThread.cpp: Removed.
  • platform/graphics/chromium/cc/CCMainThread.h: Removed.
  • platform/graphics/chromium/cc/CCMainThreadTask.h: Removed.
  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::mainThread):
(WebCore::CCProxy::setImplThread):
(WebCore::CCProxy::implThread):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::~CCProxy):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCScopedThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCScopedMainThreadProxy.h.

(WebCore::CCScopedThreadProxy::create):
(WebCore::CCScopedThreadProxy::postTask):
(WebCore::CCScopedThreadProxy::shutdown):
(WebCore::CCScopedThreadProxy::CCScopedThreadProxy):
(WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • src/CCMainThreadImpl.cpp: Removed.
  • src/CCThreadImpl.cpp:

(WebKit::CCThreadImpl::CCThreadImpl):

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::setThread):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):
(WebKit::shutdown):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):

  • tests/CCThreadTest.cpp: Removed.
4:45 PM Changeset in webkit [100369] by arv@chromium.org
  • 8 edits in trunk/LayoutTests

JS Test Harness: Remove need to load external css file to reduce flakiness
​https://bugs.webkit.org/show_bug.cgi?id=72295

Reviewed by Ojan Vafai.

Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
pre-wrap the output was therefore different depending on this race condition. By changing this to use a
style element with the CSS inline there is no longer a race condition.

  • css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
  • fast/css/counters/counter-cssText.html: Ditto.
  • fast/css/counters/getCounterValue.html: Ditto.
  • fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
  • traversal/script-tests/exception-forwarding.js: Ditto.
  • fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
  • fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.
4:43 PM Changeset in webkit [100368] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
​https://bugs.webkit.org/show_bug.cgi?id=72444

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
4:40 PM Changeset in webkit [100367] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72269

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [100366] by scheib@chromium.org
  • 4 edits in trunk/Source/WebCore

Pointer Lock: Refactor: MouseEvent.idl movementX/Y
​https://bugs.webkit.org/show_bug.cgi?id=72427

  • [Conditional...] vs #if defined
  • Runtime enabled
  • .movementX/Y prefixed with 'webkit'

Reviewed by Adam Barth.

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):

  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:

(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):

4:29 PM Changeset in webkit [100365] by ojan@chromium.org
  • 4 edits
    4 adds in trunk

implement flex-align for flex-flow: column
​https://bugs.webkit.org/show_bug.cgi?id=70754

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-column.html

css3/flexbox/line-wrapping.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
This was just using the wrong, non-flow-aware method.

LayoutTests:

  • css3/flexbox/flex-align-column-expected.txt: Added.
  • css3/flexbox/flex-align-column.html: Added.

Tests the basic flex-align cases with column.

  • css3/flexbox/line-wrapping-expected.txt: Added.
  • css3/flexbox/line-wrapping.html: Added.

This tests that wrapping inside flexitems uses the correct width.
Notably, auto-sizing properly falls back on the initial containing block.

4:27 PM Changeset in webkit [100364] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark another test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:26 PM Changeset in webkit [100363] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
​https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

4:26 PM Changeset in webkit [100362] by commit-queue@webkit.org
  • 2 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
​https://bugs.webkit.org/show_bug.cgi?id=72235

Patch by Jongseok Yang <​js45.yang@samsung.com> on 2011-11-15
Reviewed by Gustavo Noronha Silva.

Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
It's required when using the soup network backend.
Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
EFL port use soup network backend without a network backend of their own.

  • GNUmakefile.am:
  • WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
  • WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

4:24 PM Changeset in webkit [100361] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

r100331 did not seem to commit precisely the right expectation.
​https://bugs.webkit.org/show_bug.cgi?id=72391

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
4:23 PM Changeset in webkit [100360] by jamesr@google.com
  • 2 edits
    610 deletes in trunk/LayoutTests

[chromium] Unreviewed expectations update for compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=72402

Remove now-unnecessary expectations for compositing tests in chromium-gpu* directories and update
test_expectations.txt to un-SKIP compositing tests. Compositing tests are still marked as PASS FAIL
in order to ensure they pass on all bots before turning them on.

File list removed due to length.

4:20 PM Changeset in webkit [100359] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
don't currently support DataTransferItems.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
4:17 PM Changeset in webkit [100358] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=72436

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [100357] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Chromium baselines after ​http://trac.webkit.org/changeset/100324.

  • platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:
4:04 PM Changeset in webkit [100356] by tony@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, better fix for ref tests failures on SL Intel bot.
Revert the previous change and return None if pixel results from
either the test page or the expected page is missing.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
4:02 PM Changeset in webkit [100355] by jamesr@google.com
  • 12 edits in trunk

[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
​https://bugs.webkit.org/show_bug.cgi?id=72402

Reviewed by Dirk Pranke.

Tools:

Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
the normal compositing triggers since we currently run the compositing tests in only one configuration - with
compositing enabled.

Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
patch should not impact any tests.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAcceleratedCompositingForVideoEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [100354] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a test as flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [100353] by jochen@chromium.org
  • 19 edits in trunk/Source

Rename ReferrerPolicy to clarify its meaning
​https://bugs.webkit.org/show_bug.cgi?id=72420

Reviewed by Nate Chapin.

Source/WebCore:

On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
referrer wasn't necessarily send. On the other hand, I want to use the
name ReferrerPolicy when implementing the meta referrer tag.

No change in behavior expected so no test.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):
(WebCore::handleLinkClick):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadFrameRequest):

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

  • WebCore.exp.in: updated.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

Source/WebKit/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(openNewWindow):
(QWebPage::triggerAction):

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::linkClicked):

3:50 PM Changeset in webkit [100352] by tony@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3:46 PM Changeset in webkit [100351] by jchaffraix@webkit.org
  • 2 edits
    24 copies in branches/chromium/912

Merge 99752 - REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
​https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html

fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
fast/repaint/scroll-inside-table-cell.html
fast/repaint/scroll-relative-table-inside-table-cell.html
fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

  • rendering/RenderLayer.h:

Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • fast/repaint/scroll-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-inside-table-cell.html: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

TBR=​jchaffraix@webkit.org
Review URL: ​http://codereview.chromium.org/8520027

3:41 PM Changeset in webkit [100350] by tony@chromium.org
  • 2 edits in trunk/Tools

Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
3:40 PM Changeset in webkit [100349] by tony@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

set a max-width on the codereview overall comments textarea
​https://bugs.webkit.org/show_bug.cgi?id=72415

Reviewed by Ojan Vafai.

Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).

  • PrettyPatch/PrettyPatch.rb:
3:36 PM Changeset in webkit [100348] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/ChangeLog

rollout unneeded merge of 91147.

3:34 PM Changeset in webkit [100347] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Factor out V8Proxy's max recursion depth handling code
​https://bugs.webkit.org/show_bug.cgi?id=72422

Reviewed by Nate Chapin.

Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in ​http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.

No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.

3:29 PM Changeset in webkit [100346] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Skip failing ref tests on Qt.

  • platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and

fast/forms/file/file-input-reset.html are failing. See bugs.

3:27 PM Changeset in webkit [100345] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix windows build.

  • win/WebKit2Generated.make:
3:23 PM Changeset in webkit [100344] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Mark another test as flakily crashing.
​https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
3:21 PM Changeset in webkit [100343] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
​https://bugs.webkit.org/show_bug.cgi?id=72419

Reviewed by Adam Roben.

Adopt the copied NSURLRequest.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::setStorageSession):

3:09 PM Changeset in webkit [100342] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/ChangeLog

Merged r91147.

3:08 PM Changeset in webkit [100341] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebKit/win

Merged r91145.

3:07 PM Changeset in webkit [100340] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Page/layer flashes after GPU-accelerated CSS transition
​https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <​jbates@google.com> on 2011-11-15
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
3:07 PM Changeset in webkit [100339] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r91140.

3:05 PM Changeset in webkit [100338] by jchaffraix@webkit.org
  • 14 edits
    5 adds in trunk

Add the needed plumbing to parse display: -webkit-grid
​https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:

Added the new CSS value and plumbed the parsing and style application of
the new value.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

  • fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
  • fast/css-grid-layout/display-grid-set-get.html: Added.
  • fast/css-grid-layout/resources/display-grid-set-get.js: Added.

Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:

SKIP the css-grid-layout tests on all platforms for now.

3:01 PM Changeset in webkit [100337] by jamesr@google.com
  • 7 edits
    3 copies
    229 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-win into their correct locations.

File list omitted due to length.

3:01 PM Changeset in webkit [100336] by weinig@apple.com
  • 9 edits
    6 adds in trunk/Source/WebKit2

Add WebKit2 API object to represent a connection
​https://bugs.webkit.org/show_bug.cgi?id=72421

Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • Shared/API/c/WKBase.h:

Add type.

  • Shared/API/c/WKConnectionRef.cpp: Added.

(WKConnectionGetTypeID):
(WKConnectionSetConnectionClient):
(WKConnectionPostMessage):

  • Shared/API/c/WKConnectionRef.h: Added.

Expose interface. Currently no support for synchronous messages.

  • Shared/API/c/WKSharedAPICast.h:

Define relationship between WebConnection <-> WKConnectionRef.

  • Shared/APIObject.h:

Add API type.

  • Shared/WebConnection.cpp: Added.

(WebKit::WebConnection::~WebConnection):
(WebKit::WebConnection::initializeConnectionClient):

  • Shared/WebConnection.h: Added.

(WebKit::WebConnection::type):
Sketch out the connection object. It is currently abstract
to allow different implementations for the UI and WebProcess sides
while retaining the same interface.

  • Shared/WebConnectionClient.cpp: Added.

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

  • Shared/WebConnectionClient.h: Added.

Add simple client.

  • UIProcess/API/C/WebKit2.h:

Add new file.

3:00 PM Changeset in webkit [100335] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r91138.

2:59 PM Changeset in webkit [100334] by Lucas Forschler
  • 17 edits in branches/safari-534.53-branch/Source

Merged r91137.

2:53 PM Changeset in webkit [100333] by jamesr@google.com
  • 4 edits
    1 copy
    231 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectations shuffle.

Copy compositing expectations for chromium-linux and chromium-mac into their correct locations.

File list omitted due to length.

2:52 PM Changeset in webkit [100332] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Merged r90954.

2:48 PM Changeset in webkit [100331] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100289.
​https://bugs.webkit.org/show_bug.cgi?id=72391

fast/dom/Orientation/create-event-orientationchange.html was updated but
the expected text was not.

Unreviewed, gardening.

  • fast/dom/Orientation/create-event-orientationchange-expected.txt:
2:46 PM Changeset in webkit [100330] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Pixel result accidentally left out of ​http://trac.webkit.org/changeset/100324.

  • platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png:
2:43 PM Changeset in webkit [100329] by jamesr@google.com
  • 2 edits
    189 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=72402
Unreviewed expectation shuffle.

Copy compositing expectations for chromium/ and chromium-cg-mac/ into their correct locations.

  • platform/chromium-cg-mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/chromium-cg-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/generated-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-cg-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/images/content-image-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-cg-mac/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-cg-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-cg-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-cg-mac/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-cg-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-cg-mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.png: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-cg-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-cg-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/chromium-cg-mac/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-cg-mac/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/chromium/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/iframes/resizer-expected.txt: Added.
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/chromium/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/chromium/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-e.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-n.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-ne.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-nw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-s.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-se.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-size-change.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-sw.html: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.txt: Added.
  • platform/chromium/compositing/rubberbanding/transform-overhang-w.html: Added.
  • platform/chromium/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
  • platform/chromium/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
  • platform/chromium/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
2:38 PM Changeset in webkit [100328] by scheib@chromium.org
  • 5 edits
    3 moves in trunk/Source/WebCore

Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
​https://bugs.webkit.org/show_bug.cgi?id=72315

Reviewed by Dimitri Glazkov.

  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::webkitPointer):

  • page/Navigator.h:
  • page/Navigator.idl:
  • page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.

(WebCore::PointerLock::PointerLock):
(WebCore::PointerLock::~PointerLock):
(WebCore::PointerLock::webkitLock):
(WebCore::PointerLock::webkitUnlock):
(WebCore::PointerLock::webkitIsLocked):

  • page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.

(WebCore::PointerLock::create):

  • page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.
2:36 PM Changeset in webkit [100327] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline mac pixel results for complex inner border change
​https://bugs.webkit.org/show_bug.cgi?id=72355

Patch by Ben Wells <​benwells@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • platform/mac/fast/borders/border-radius-complex-inner-expected.png: Added.
  • platform/mac/fast/borders/border-radius-different-width-001-expected.png:
2:30 PM Changeset in webkit [100326] by tony@chromium.org
  • 13 edits in trunk/Tools

[NRWT] Reftests should run even when pixel tests are disabled.
​https://bugs.webkit.org/show_bug.cgi?id=60605

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.

Also add an assert to make sure we get image hashes back when running ref tests.

  • Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
  • Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work

of starting a pixel driver if needed. It handles the logic of sending the test
to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2:29 PM Changeset in webkit [100325] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100283.
​https://bugs.webkit.org/show_bug.cgi?id=72137

We don't have a LION modifier, and I'm not sure why one test was only
skipped for SNOWLEOPARD RELEASE as it fails on Debug also.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [100324] by ojan@chromium.org
  • 3 edits
    4 adds in trunk

Overflow and relayout are broken in the new flexboxes
​https://bugs.webkit.org/show_bug.cgi?id=71161

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/auto-height-dynamic.html

css3/flexbox/flex-item-child-overflow-expected.html
css3/flexbox/flex-item-child-overflow.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
-Always set the logical height to 0 to start with to ensure we don't
use the height from the previous layout when we are computing the
intrinsic size of the flexbox.
-Call computeOverflow after computeLogicalHeight so that flex-item's children's
overflow is properly rendered.

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
-Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
-Refactor flipping code. The behavior is the same, but the variable names are just
more correct.

LayoutTests:

  • css3/flexbox/auto-height-dynamic-expected.txt: Added.
  • css3/flexbox/auto-height-dynamic.html: Added.
  • css3/flexbox/flex-item-child-overflow-expected.html: Added.
  • css3/flexbox/flex-item-child-overflow.html: Added.
2:23 PM Changeset in webkit [100323] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue:
​https://bugs.webkit.org/show_bug.cgi?id=72344

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

2:22 PM Changeset in webkit [100322] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Properly bounding CSS lengths to AppUnit's bounds. Rounding instead of truncating offset values.

2:21 PM Changeset in webkit [100321] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source/WebCore

Merged r90925. needed for 93040.

2:19 PM Changeset in webkit [100320] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use MarkedArgumentBuffer to avoid making assumptions about argument order
​https://bugs.webkit.org/show_bug.cgi?id=72418

Reviewed by Sam Weinig.

A step toward reversing the argument order.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::callReviver): Don't assume that ArgList wants to point
at arguments in forward order. Instead, use MarkedArgumentBuffer, which
will make the decision for us.

2:17 PM Changeset in webkit [100319] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations after r100276.
​https://bugs.webkit.org/show_bug.cgi?id=72270

Some lines were commented out to avoid expectation conflicts but this
erroneously removed an expectation that some tests would fail on the
Leopard (CG) bots.

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
2:12 PM Changeset in webkit [100318] by commit-queue@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test
​https://bugs.webkit.org/show_bug.cgi?id=72410

Patch by James Robinson <​jamesr@chromium.org> on 2011-11-15
Reviewed by Simon Fraser.

  • compositing/plugins/invalidate_rect-expected.txt: Renamed from LayoutTests/plugins/invalidate_rect-expected.txt.
  • compositing/plugins/invalidate_rect.html: Renamed from LayoutTests/plugins/invalidate_rect.html.
2:00 PM Changeset in webkit [100317] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] enable regions and exclusions tests, the compile flag was removed a long time ago
​https://bugs.webkit.org/show_bug.cgi?id=72395

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [100316] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering/svg

Have SVGRenderTreeAsText print pixel snapped coordinates and sizes for the root and container elements.

1:54 PM Changeset in webkit [100315] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG should distinguish between constants in the constant pool and weak
constants added as artifacts of code generation
​https://bugs.webkit.org/show_bug.cgi?id=72367

Reviewed by Geoff Garen.

Added the notion of a WeakJSConstant, which is like a JSConstant except that
it can only refer to JSCell*. Currently all WeakJSConstants are also backed
by constants in the constant pool, since weak references originated from
machine code are not yet properly handled.

Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant
and CheckStructure. This results in improved CSE, leading to a 1% win on V8.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::weakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::hasIdentifier):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:38 PM Changeset in webkit [100314] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Towards 8 bit Strings - Initial JS String Tuning
​https://bugs.webkit.org/show_bug.cgi?id=72326

Added 8 bit optimized paths for the methods below.

Reviewed by Geoffrey Garen.

  • runtime/JSString.h:

(JSC::jsSubstring8):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharCodeAt):

1:03 PM Changeset in webkit [100313] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests/SunSpider

Extend sunspider driver to be able to run kraken
​https://bugs.webkit.org/show_bug.cgi?id=71799

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-15
Reviewed by Filip Pizlo.

  • resources/sunspider-standalone-driver.js: Try to load a -data

file. If that succeeds, we have a kraken-like test, so we time
the test using load'. Otherwise fall back to using run'.

12:43 PM Changeset in webkit [100312] by commit-queue@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r100291.
​http://trac.webkit.org/changeset/100291
​https://bugs.webkit.org/show_bug.cgi?id=72403

For some unexpected reason the behavior is different across
platforms, causing test failures (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Removed.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Removed.
  • svg/custom/zero-path-square-cap-rendering3.svg: Removed.
12:40 PM Changeset in webkit [100311] by Nate Chapin
  • 28 edits
    4 deletes in trunk

Source/WebCore: CachedResourceRequest is now the only SubresourceLoaderClient
Merge CachedResourceRequest into SubresourceLoader and delete
the SubresourceLoaderClient interface. A few items were moved
to CachedResource instead of SubresourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::init): Do work that had previously been

done in SubresourceLoader::create() after the constructor.

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didSendData):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::didReceiveCachedMetadata):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::releaseResources): Do the cleanup work that was

duplicated throughout the various terminal CachedResourceRequest callbacks.

  • loader/SubresourceLoader.h: Fix indentation style issues.
  • loader/SubresourceLoaderClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load): Do the work that had been done in

CachedResourceRequest::load().

(WebCore::CachedResource::finish):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::stopLoading):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::canDelete):

  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceRequest.cpp: Removed.
  • loader/cache/CachedResourceRequest.h: Removed.
  • loader/cf/SubresourceLoaderCF.cpp:
  • loader/chromium/CachedResourceRequestChromium.cpp: Removed.
  • loader/chromium/SubresourceLoaderChromium.cpp:

LayoutTests: Test udpates for ​https://bugs.webkit.org/show_bug.cgi?id=71149.
The changes to SubresourceLoader slightly change the timings of
certain resource load callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=71149

Reviewed by Adam Barth.

  • fast/loader/file-protocol-fragment-expected.txt:
  • platform/chromium-cg-mac/security/block-test-expected.txt:
  • platform/chromium-mac/security/block-test-expected.txt:
  • platform/chromium-win/security/block-test-expected.txt:
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
12:34 PM Changeset in webkit [100310] by barraclough@apple.com
  • 7 edits in trunk

Result of Error.prototype.toString not ES5 conformant
​https://bugs.webkit.org/show_bug.cgi?id=70889

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

LayoutTests:

  • fast/js/native-error-prototype-expected.txt:
  • fast/js/script-tests/native-error-prototype.js:
  • fast/js/script-tests/toString-recursion.js:
  • fast/js/toString-recursion-expected.txt:
12:25 PM Changeset in webkit [100309] by andersca@apple.com
  • 39 edits in trunk/Source

HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
​https://bugs.webkit.org/show_bug.cgi?id=72397

Reviewed by Dan Bernstein.

Source/WebCore:

screenToWindow and windowToScreen already use root view coordinates everywhere, with the
exception of Mac WebKit1 which doesn't even implement the functions.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::screenToRootView):
(WebCore::Chrome::rootViewToScreen):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupContainer::refresh):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenToRootView):
(WebKit::ChromeClientImpl::rootViewToScreen):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::screenToRootView):
(WebKit::WebPopupMenuImpl::rootViewToScreen):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::rootViewToScreen):
(WebCore::ChromeClientEfl::screenToRootView):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::rootViewToScreen):
(WebKit::ChromeClient::screenToRootView):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::screenToRootView):
(WebChromeClient::rootViewToScreen):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::rootViewToScreen):
(WebCore::ChromeClientQt::screenToRootView):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::rootViewToScreen):
(WebChromeClient::screenToRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::rootViewToScreen):
(WebKit::ChromeClientWinCE::screenToRootView):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::rootViewToScreen):
(WebCore::ChromeClientWx::screenToRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenToRootView):
(WebKit::WebChromeClient::rootViewToScreen):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:21 PM Changeset in webkit [100308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
​https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-15
Reviewed by Julien Chaffraix.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

12:13 PM Changeset in webkit [100307] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

Source/WebCore: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
​https://bugs.webkit.org/show_bug.cgi?id=70421

Patch by Eugene Nalimov <​enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object.
Before that there were no DOM objects that simultaneously were nodes and active objects.
DOM object could be held in one of 3 maps -- node map, active objects map, and all other
objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the
active DOM objects map only, its event listener could be garbage collected, because special
code that groups listeners with wrappers could handle only wrappers for objects in the node
map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be
garbage collected prematurely itself (see ​https://bugs.webkit.org/show_bug.cgi?id=66878).
Fix is to introduce 4th map -- active nodes map, and change the code accordingly.

Test: media/audio-garbage-collect.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GetDomMapFunction):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
(WebCore::DOMDataStore::weakNodeCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::activeDomNodeMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8GCController.cpp:

(WebCore::GCPrologueSpecialCase):
(WebCore::void):
(WebCore::Node):
(WebCore::GCPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::GCEpilogueHelper::GCEpilogueSpecialCase):
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcEpilogue):

  • dom/Node.h:

(WebCore::Node::isActiveNode):

  • html/HTMLAudioElement.h:

(WebCore::HTMLAudioElement::isActiveNode):

LayoutTests: Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
​https://bugs.webkit.org/show_bug.cgi?id=70421 and ​https://bugs.webkit.org/show_bug.cgi?id=66878

Patch by Eugene Nalimov <​enal@google.com> on 2011-11-15
Reviewed by Adam Barth.

  • media/audio-garbage-collect-expected.txt: Added.
  • media/audio-garbage-collect.html: Added.
12:05 PM Changeset in webkit [100306] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit/chromium

[Chromium] gamepad changes to the public interface of Chromium port
​https://bugs.webkit.org/show_bug.cgi?id=71518

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-15
Reviewed by Darin Fisher.

Adds stubs for Chromium port, and defines shared memory structure to
be used between browser and WebKit.

Includes just the parts that touch the public interface so they can be
reviewed separately. See also:
​https://bugs.webkit.org/show_bug.cgi?id=69451 and
​http://codereview.chromium.org/8345027

  • WebKit.gyp:
  • public/WebGamepad.h: Added.

(WebKit::WebGamepad::WebGamepad):

  • public/WebGamepads.h: Added.

(WebKit::WebGamepads::WebGamepads):

  • public/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::sampleGamepads):

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

11:58 AM Changeset in webkit [100305] by robert@webkit.org
  • 5 edits
    7 adds in trunk/LayoutTests

Mac results for r100177

Unreviewed gardening.

  • platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/mac/fast/table/multiple-captions-display-expected.txt:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
11:54 AM Changeset in webkit [100304] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening after r100289.

  • platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt:
11:49 AM Changeset in webkit [100303] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Make sure both the video and the track are ready to be tested before testing.
​https://bugs.webkit.org/show_bug.cgi?id=72399

Reviewed by Eric Carlson.

  • media/track/track-cues-seeking.html:
11:48 AM Changeset in webkit [100302] by leviw@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore

Fixing overloaded scrollbar painting methods on Mac

11:47 AM Changeset in webkit [100301] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Land chromium win results for flexbox repaint tests.
Still waiting on mac results.

  • platform/chromium-win/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:37 AM Changeset in webkit [100300] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Guarantee tests run in order.
​https://bugs.webkit.org/show_bug.cgi?id=72398

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc013-settings.html:
11:29 AM Changeset in webkit [100299] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Guarantee tests run in order.
​https://bugs.webkit.org/show_bug.cgi?id=72369

Reviewed by Eric Carlson.

  • media/track/track-webvtt-tc003-newlines.html:
  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [100298] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove useless const modifier from KURL::init
<​http://webkit.org/b/72387>

Reviewed by Darin Adler.

  • platform/KURL.cpp:

(WebCore::KURL::init): Remove useless const.

11:16 AM Changeset in webkit [100297] by tonyg@chromium.org
  • 6 edits in trunk/LayoutTests

editing/pasteboard/drag-drop-dead-frame.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72379

Reviewed by Adam Barth.

  • editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
  • platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
  • platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
11:14 AM Changeset in webkit [100296] by annacc@chromium.org
  • 6 edits in trunk/LayoutTests

Change layout tests for cuechange, enter, and exit events to check the order
rather than the timing of the events (since actual timing can not be guaranteed).
​https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Tony Gentilcore.

  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-cuechange.html:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-enter-exit.html:
  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [100295] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.3

New tag.

10:56 AM Changeset in webkit [100294] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

10:51 AM Changeset in webkit [100293] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merge 100022.

10:25 AM Changeset in webkit [100292] by tony@chromium.org
  • 8 edits in trunk/LayoutTests

enable new flexbox tests everywhere
​https://bugs.webkit.org/show_bug.cgi?id=72325

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:21 AM Changeset in webkit [100291] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

REGRESSION (r91125): Polyline tool in google docs is broken
​https://bugs.webkit.org/show_bug.cgi?id=65796

This adds test to ensure that the bug does not reappear unnoticed.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-11-15
Reviewed by Nikolas Zimmermann.

  • svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
  • svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
  • svg/custom/zero-path-square-cap-rendering3.svg: Added.
9:54 AM Changeset in webkit [100290] by andersca@apple.com
  • 40 edits in trunk/Source

HostWindow invalidation functions should use root view coordinates
​https://bugs.webkit.org/show_bug.cgi?id=72338

Reviewed by Dan Bernstein.

Source/WebCore:

Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
are in root view coordinates by changing contentsToWindow calls to contentsToRootView.

In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):

  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/chromium/FramelessScrollView.cpp:

(WebCore::FramelessScrollView::invalidateRect):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateRootView):
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):

  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::invalidateRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
(WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateRootView):
(WebCore::ChromeClientQt::invalidateContentsAndRootView):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::invalidateRootView):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndRootView):

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateRootView):
(WebKit::WebChromeClient::invalidateContentsAndRootView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
9:52 AM Changeset in webkit [100289] by arv@chromium.org
  • 60 edits in trunk/LayoutTests

Fix invalid markup in some tests
​https://bugs.webkit.org/show_bug.cgi?id=72391

Reviewed by Ojan Vafai.

These tests had <div id="console"></p> in them which causes a lot of extra whitespace.

  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto-change-text.html:
  • fast/dom/HTMLElement/attr-dir-auto-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control.html:
  • fast/dom/HTMLElement/attr-dir-auto.html:
  • fast/dom/HTMLElement/attr-dir-value-change-expected.txt:
  • fast/dom/HTMLElement/attr-dir-value-change.html:
  • fast/dom/HTMLElement/attr-empty-string-expected.txt:
  • fast/dom/HTMLElement/attr-empty-string.html:
  • fast/dom/HTMLElement/attr-false-string-expected.txt:
  • fast/dom/HTMLElement/attr-false-string.html:
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt:
  • fast/dom/HTMLElement/attr-invalid-string.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-false.html:
  • fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-ancestor-true.html:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html:
  • fast/dom/HTMLElement/attr-missing-parent-false-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-false.html:
  • fast/dom/HTMLElement/attr-missing-parent-true-expected.txt:
  • fast/dom/HTMLElement/attr-missing-parent-true.html:
  • fast/dom/HTMLElement/attr-true-string-expected.txt:
  • fast/dom/HTMLElement/attr-true-string.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon.html:
  • fast/dom/HTMLElement/set-false-expected.txt:
  • fast/dom/HTMLElement/set-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-true.html:
  • fast/dom/HTMLElement/set-invalid-value-expected.txt:
  • fast/dom/HTMLElement/set-invalid-value.html:
  • fast/dom/HTMLElement/set-true-expected.txt:
  • fast/dom/HTMLElement/set-true.html:
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive.html:
  • fast/dom/Orientation/create-event-orientationchange.html:
9:30 AM Changeset in webkit [100288] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
9:25 AM Changeset in webkit [100287] by ddkilzer@apple.com
  • 4 edits
    1 add in trunk/Tools

Don't use File::Slurp for run-leaks unit tests
<​http://webkit.org/b/72356>

Reviewed by Daniel Bates.

  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:

Extracted common package logic into RunLeaks.pm. Fixed call to
RunLeaks::parseLeaksOutput().

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
8:37 AM Changeset in webkit [100286] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Handle svn 1.7 when detecting whether a directory is in an svn checkout.
​https://bugs.webkit.org/show_bug.cgi?id=72349

Patch by Peter Kasting <​pkasting@google.com> on 2011-11-15
Reviewed by Adam Roben.

  • Scripts/VCSUtils.pm:

(isSVNDirectory):

8:32 AM Changeset in webkit [100285] by commit-queue@webkit.org
  • 8 edits
    9 adds
    1 delete in trunk

Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
​https://bugs.webkit.org/show_bug.cgi?id=61528

Patch by Philip Rogers <​pdr@google.com> on 2011-11-15
Reviewed by Stephen White.

Source/WebCore:

Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html

fast/canvas/2d.text.draw.fill.maxWidth.negative.html
fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.gradient.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall-expected.txt: Added.
  • fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/qt/Skipped:
  • resources/Ahem.ttf: Added.
8:24 AM Changeset in webkit [100284] by Carlos Garcia Campos
  • 8 edits in trunk/Source

[GTK] Implement download support in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72258

Reviewed by Martin Robinson.

Source/WebCore:

Add common download errors to ErrorsGtk.

  • platform/gtk/ErrorsGtk.cpp:

(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):

  • platform/gtk/ErrorsGtk.h:

Source/WebKit/gtk:

Use errors from WebCore to emit the error signals.

  • webkit/webkitdownload.cpp:

(webkitDownloadEmitError): Helper function that emits the error
signal for the given ResourceError.
(webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
(webkit_download_cancel): Ditto.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Ditto.
(webkit_download_error): Ditto.

Source/WebKit2:

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked):
(WebKit::DownloadClient::cannotShowURL):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

8:17 AM Changeset in webkit [100283] by caryclark@google.com
  • 4 edits in trunk

[chromium-mac] Enable vertical text using Skia
​https://bugs.webkit.org/show_bug.cgi?id=72137

Source/WebCore:

Use Skia to draw vertical text. This is much
faster and has higher fidelity than the old method
of drawing text on a path.

The graphics context passed to Skia has been
rotated 90 degrees but the character advances
have not, so it is necessary to unrotate the canvas,
and re-rotate the positions.

This generates correct output (or, at least,
consistent with Chromium CG on Mac) for all vertical
text tests, one of which is mentioned below.

Reviewed by Stephen White.

Test: fast/writing-mode/text-orientation-basic.html

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

LayoutTests:

Ignore vertical text tests on Skia on Mac for now.

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
8:14 AM Changeset in webkit [100282] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

media-blocked-by-willsendrequest.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72381

Reviewed by Tony Gentilcore.

  • media/media-blocked-by-willsendrequest.html:

Don't assume the media events will be dispatched before the window 'load' event.

  • platform/chromium/test_expectations.txt:

Don't skip media/media-blocked-by-willsendrequest.html.

7:59 AM Changeset in webkit [100281] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Enable skipped but now passing tests (http/tests)
​https://bugs.webkit.org/show_bug.cgi?id=71911

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2011-11-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip 24 tests.
7:38 AM Changeset in webkit [100280] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix SVG hit testing when padding is present
​https://bugs.webkit.org/show_bug.cgi?id=37325

Patch by Philip Rogers <​pdr@google.com> on 2011-11-15
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/svg-padding.xhtml

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

  • svg/hittest/svg-padding-expected.txt: Added.
  • svg/hittest/svg-padding.xhtml: Added.
7:11 AM Changeset in webkit [100279] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, marked
fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK.

  • platform/gtk/test_expectations.txt:
6:58 AM Changeset in webkit [100278] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing.
6:52 AM Changeset in webkit [100277] by pfeldman@chromium.org
  • 10 edits in trunk/Source

Web Inspector: move generic code from DevTools.js into the WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72377

re-landing r100269.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

6:51 AM Changeset in webkit [100276] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] mark to rebaseline aft cr104128 lands (colorfilter optimization)
​https://bugs.webkit.org/show_bug.cgi?id=72270

Reviewed by NOBODY.

  • platform/chromium/test_expectations.txt:
6:43 AM Changeset in webkit [100275] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media-blocked-by-willsendrequest.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72381

  • platform/chromium/test_expectations.txt: Mark test as flaky.
6:43 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:40 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:39 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:31 AM QtWebKitLayoutInteraction edited by kenneth@webkit.org
(diff)
6:30 AM Changeset in webkit [100274] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r100269.
​http://trac.webkit.org/changeset/100269
​https://bugs.webkit.org/show_bug.cgi?id=72383

"Broke dozens of tests due to exception in loadingFinished"
(Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:
  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

():
(devtools.domContentLoaded):
(WebInspector.UIString):
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

6:14 AM QtWebKitLayoutInteraction created by kenneth@webkit.org
6:12 AM Changeset in webkit [100273] by apavlov@chromium.org
  • 15 edits
    2 adds in trunk

font property does not show up as "shorthand" in inspector
​https://bugs.webkit.org/show_bug.cgi?id=15598

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The "font" CSS property is turned into a real shorthand, as its longhands used to float around
in the resulting style declaration without any reference to their underlying "font" property.

Test: fast/css/font-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
(WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
(WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
(WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.

  • css/CSSParser.h: Added optional "implicit" parameter to addProperty().
  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap): Added "font" shorthand map entry.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
(WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.

  • css/CSSStyleSelector.h: Made updateFont() public.
  • css/FontValue.cpp:

(WebCore::FontValue::customCssText): Made use of StringBuilder.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.

LayoutTests:

  • fast/css/font-shorthand-expected.txt: Added.
  • fast/css/font-shorthand.html: Added.
  • fast/inspector-support/style-expected.txt:
  • fast/inspector-support/style.html:
6:06 AM Changeset in webkit [100272] by Philippe Normand
  • 6 edits
    1 add in trunk/LayoutTests

REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug
​https://bugs.webkit.org/show_bug.cgi?id=72297

Unreviewed, GTK rebaseline after r100159.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
5:48 AM Changeset in webkit [100271] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some new GTK test failures.

  • platform/gtk/Skipped:
5:43 AM Changeset in webkit [100270] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
​https://bugs.webkit.org/show_bug.cgi?id=72262

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-11-15
Reviewed by Antonio Gomes.

No new tests needed, this is purely cosmetic.

  • platform/qt/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):

  • platform/qt/RenderThemeQStyle.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
since the mobile theme actually didn't do this.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustMenuListStyle):

5:38 AM Changeset in webkit [100269] by pfeldman@chromium.org
  • 10 edits in trunk/Source

Web Inspector: move generic code from DevTools.js into the WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72377

This includes support for themed toolbar, remote debugging routines,
removes a couple of obsolete overrides from the DevTools.js

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.setInspectedTabId):

5:02 AM Changeset in webkit [100268] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r100182): It broke 2 http/tests/security tests
​https://bugs.webkit.org/show_bug.cgi?id=72364

  • platform/qt/Skipped: Skip failing tests until fix.
4:35 AM Changeset in webkit [100267] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/forms/file/input-file-label.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72376

  • platform/chromium/test_expectations.txt: Mark test flaky on win.
4:02 AM Changeset in webkit [100266] by Simon Hausmann
  • 8 edits in trunk

[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

  • Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

  • qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions

magic here where we handle all TEMPLATE = lib .pro files.

3:33 AM Changeset in webkit [100265] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unreviewed prospective --minimal build fix.

  • DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0

and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.

3:30 AM Changeset in webkit [100264] by noel.gordon@gmail.com
  • 2 edits
    1 move
    3 adds
    1 delete in trunk/LayoutTests

Rebaseline gray-scale-jpeg-with-color-profile.html
​https://bugs.webkit.org/show_bug.cgi?id=72240

Reviewed by Eric Seidel.

  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
3:24 AM Changeset in webkit [100263] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] perf/document-contains.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72372

  • platform/chromium/test_expectations.txt: Marking flaky on WIN.
3:14 AM Changeset in webkit [100262] by commit-queue@webkit.org
  • 19 edits in trunk

Unreviewed, rolling out r100213.
​http://trac.webkit.org/changeset/100213
​https://bugs.webkit.org/show_bug.cgi?id=72371

"Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
3:03 AM Changeset in webkit [100261] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
​https://bugs.webkit.org/show_bug.cgi?id=70091

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-11-15
Reviewed by Filip Pizlo.

Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
with WebKit-EFL functions.

  • ewk/ewk_frame.cpp:

(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):

3:01 AM Changeset in webkit [100260] by yuqiang.xian@intel.com
  • 7 edits
    1 delete in trunk/Source/JavaScriptCore

Remove DFGJITCompilerInlineMethods
​https://bugs.webkit.org/show_bug.cgi?id=72366

Reviewed by Filip Pizlo.

Those methods are actually seldom used. Modify the few such places and
remove DFGJITCompilerInlineMethods stuffs totally.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addressOfDoubleConstant):

  • dfg/DFGJITCompilerInlineMethods.h: Removed.
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillFPR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):

2:59 AM Changeset in webkit [100259] by Csaba Osztrogonác
  • 7 edits
    2 adds in trunk/LayoutTests

[Qt] Unviewed fix after r100254, because committed results was incorrect.

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
2:52 AM Changeset in webkit [100258] by hclam@chromium.org
  • 6 edits in trunk/Source

[chromium] scroll deltas are cleared during commit to the main thread
​https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

Patch is covered by unit test.

Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
sent to the main thread during commit. This gives a simpler approach to keep tracking of a
layer's scroll delta in impl thread.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::sentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::sentScrollDelta):
(WebCore::CCLayerImpl::setSentScrollDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

Modify test to verify sentScrollDeltas() values of CCLayerImpl during commit.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

2:37 AM Changeset in webkit [100257] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-webvtt-tc003-newlines.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72369

  • platform/chromium/test_expectations.txt: Marked test flaky.
2:34 AM Changeset in webkit [100256] by Simon Hausmann
  • 4 edits in trunk

[Qt] REGRESSION(100123): It made inspector tests crash ​https://bugs.webkit.org/show_bug.cgi?id=72274

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated

m_page member that should really come from RenderThemeQt.

LayoutTests:

  • platform/qt/Skipped: Unskip passing tests.
1:56 AM Changeset in webkit [100255] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix build breaks when EFL port is built.

  • CMakeLists.txt:
  • UseJSC.cmake:
1:47 AM Changeset in webkit [100254] by reni@webkit.org
  • 9 edits in trunk/LayoutTests

Unviewed gardening after r100159.

Patch by Oliver Varga <​voliver@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/fast/dom/Window/window-properties-expected.png:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:37 AM Changeset in webkit [100253] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Unreviewed --minimal build fix.

  • Scripts/build-webkit: Add to DEFINES+= from @options only if there is

a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
to make moc's preprocessor abort.

1:36 AM Changeset in webkit [100252] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Make ImageFrame member getAddr() public
​https://bugs.webkit.org/show_bug.cgi?id=72321

Reviewed by Adam Barth.

Make ImageFrame member getAddr() public to allow ImageFrame users access to the
underlying frame pixels if needed. Image decoders, for example, could with care
use this service to write decoded pixels direct to the ImageFrame pixel buffer,
avoiding intermeadiate data copies from temporary decoded pixel row buffers and
the decoding performance loss that that entails.

No new tests, refactoring only.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):

1:32 AM Changeset in webkit [100251] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
​https://bugs.webkit.org/show_bug.cgi?id=72261

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/svg-style.xhtml

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

LayoutTests:

  • inspector/styles/svg-style-expected.txt: Added.
  • inspector/styles/svg-style.xhtml: Added.
1:24 AM Changeset in webkit [100250] by reni@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Platform-specific result for r100157.

Unreviewed, gardening.

Patch by Czene Tamás <​tczene@inf.u-szeged.hu> on 2011-11-15

  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
1:13 AM Changeset in webkit [100249] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Two tests are skipped after r100182 and r100239.

Unreviewed gardening.

  • platform/qt/Skipped:
1:05 AM Changeset in webkit [100248] by mario@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=72267

Reviewed by Martin Robinson.

Allow getting and setting the 'enable-caret-browsing' property
through WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added property setter.
(webKitSettingsGetProperty): Added propery getter.
(webkit_settings_class_init): Install property.
(webkit_settings_get_enable_caret_browsing): Added.
(webkit_settings_set_enable_caret_browsing): Added.

  • UIProcess/API/gtk/WebKitSettings.h: Expose new public APIs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new sections for gtk-doc generation.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Added new API test.

12:36 AM Changeset in webkit [100247] by tkent@chromium.org
  • 4 edits in trunk

[V8] Fix incorrect handling of JavaScript properties in DOMStringMap
​https://bugs.webkit.org/show_bug.cgi?id=53578

Reviewed by Adam Barth.

Source/WebCore:

Follows a JSC behavior change by r96893.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):
Propagate to the JavaScript object if the DOMStringMap object
doesn't have the requested item.
(WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
(WebCore::V8DOMStringMap::namedPropertySetter):
Try to set a property to only a DOMStringMap object.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Remove failure expectations of fast/dom/dataset.html and
fast/dom/dataset-xhtml.xhtml.

12:08 AM Changeset in webkit [100246] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Command line $x fails for 3 of 4 types of XPath query
​https://bugs.webkit.org/show_bug.cgi?id=72276

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/console/console-xpath.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/console-xpath-expected.txt: Added.
  • inspector/console/console-xpath.html: Added.

Nov 14, 2011:

11:10 PM Changeset in webkit [100245] by pkasting@chromium.org
  • 1 edit
    7 moves in trunk/LayoutTests

r100237 moved some pixel baselines into platform/chromium without also
moving the text baselines. As a result all the Chromium Mac "not 10.6
CG" bots were still failing due to MISSING expectations.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
  • platform/chromium/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt.
11:04 PM Changeset in webkit [100244] by fpizlo@apple.com
  • 12 edits
    4 deletes in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT and DFG::JITCodeGenerator should be combined
​https://bugs.webkit.org/show_bug.cgi?id=72348

Reviewed by Gavin Barraclough.

Moved all of JITCodeGenerator into SpeculativeJIT.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGJITCodeGenerator.cpp: Removed.
  • dfg/DFGJITCodeGenerator.h: Removed.
  • dfg/DFGJITCodeGenerator32_64.cpp: Removed.
  • dfg/DFGJITCodeGenerator64.cpp: Removed.
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::clearGenerationInfo):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownBoolean):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::markCellCard):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::dataFormatString):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::GPRTemporary::adopt):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::lock):
(JSC::DFG::SpeculativeJIT::unlock):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::reuse):
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::tryAllocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
(JSC::DFG::SpeculativeJIT::silentSpillGPR):
(JSC::DFG::SpeculativeJIT::silentSpillFPR):
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::silentFillFPR):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::unboxDouble):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::identifier):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImmPtr):
(JSC::DFG::SpeculativeJIT::bitOp):
(JSC::DFG::SpeculativeJIT::shiftOp):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::addressOfCallData):
(JSC::DFG::SpeculativeJIT::tagOfCallData):
(JSC::DFG::SpeculativeJIT::payloadOfCallData):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::resetCallArguments):
(JSC::DFG::SpeculativeJIT::addCallArgument):
(JSC::DFG::SpeculativeJIT::setupArguments):
(JSC::DFG::SpeculativeJIT::setupArgumentsExecState):
(JSC::DFG::SpeculativeJIT::setupArgumentsWithExecState):
(JSC::DFG::SpeculativeJIT::setupTwoStubArgs):
(JSC::DFG::SpeculativeJIT::setupStubArguments):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::setupResults):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::block):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::~IntegerOperand):
(JSC::DFG::IntegerOperand::index):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::~DoubleOperand):
(JSC::DFG::DoubleOperand::index):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::~JSValueOperand):
(JSC::DFG::JSValueOperand::index):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::jsValueRegs):
(JSC::DFG::JSValueOperand::isDouble):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::tagGPR):
(JSC::DFG::JSValueOperand::payloadGPR):
(JSC::DFG::JSValueOperand::fpr):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::~StorageOperand):
(JSC::DFG::StorageOperand::index):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::GPRTemporary::~GPRTemporary):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::~FPRTemporary):
(JSC::DFG::FPRTemporary::fpr):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::GPRResult::GPRResult):
(JSC::DFG::GPRResult2::GPRResult2):
(JSC::DFG::FPRResult::FPRResult):
(JSC::DFG::FPRResult::lockedResult):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::SpeculativeJIT::nonSpeculativeBasicArithOp):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::cachedGetMethod):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):

  • runtime/JSFunction.h:
11:01 PM Changeset in webkit [100243] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the change log entry for r59190.

  • ChangeLog-2010-05-24:
10:58 PM Changeset in webkit [100242] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Weak reference harvesters should run to fixpoint
​https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

  • heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

10:43 PM Changeset in webkit [100241] by dbates@webkit.org
  • 3 edits in trunk/Tools

build-webkit: Accept --cmakearg to pass additional arguments to CMake.
​https://bugs.webkit.org/show_bug.cgi?id=72156

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-14
Reviewed by Daniel Bates.

Similar to --makearg and --qmakearg, --cmakearg lets one pass
additional arguments to CMake (eg. --cmakearg="-DFOO=bar").

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

10:29 PM Changeset in webkit [100240] by pkasting@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

r100196 needed to also rebaseline Windows, not just Linux.

Unreviewed, gardening.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/scale-page-shrink-expected.png:
10:14 PM Changeset in webkit [100239] by dslomov@google.com
  • 4 edits
    2 adds in trunk

Source/WebCore: [V8][Chromium]Serialize dense arrays densly
​https://bugs.webkit.org/show_bug.cgi?id=72198
This patch ensures that:

  • Dense arrays are serialized densly, and not as name-value pairs
  • Sparse arrays are allocated as sparse on deserialization.

The criteria to choose whether to serialize densly or sparsely is the size
of a resulting serialized stream.

Reviewed by David Levin.

Test: fast/dom/Window/window-postmessage-arrays.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDenseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
(WebCore::V8ObjectMap::Serializer::writeDenseArray):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
(WebCore::V8ObjectMap::Serializer::ObjectState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
(WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
(WebCore::V8ObjectMap::Serializer::serializeDensely):
(WebCore::V8ObjectMap::Serializer::startArrayState):
(WebCore::V8ObjectMap::Serializer::startObjectState):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::newSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::completeDenseArray):

LayoutTests: [V8][Chromium]Serialize dense arrays densly.
​https://bugs.webkit.org/show_bug.cgi?id=72198

Reviewed by David Levin.

  • fast/dom/Window/script-tests/postmessage-clone.js:
  • fast/dom/Window/window-postmessage-arrays-expected.txt: Added.
  • fast/dom/Window/window-postmessage-arrays.html: Added.
10:07 PM Changeset in webkit [100238] by pkasting@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Removed.
  • platform/chromium/fast/table/prepend-in-anonymous-table-expected.txt: Added.
9:39 PM Changeset in webkit [100237] by pkasting@chromium.org
  • 11 edits
    24 adds
    8 deletes in trunk/LayoutTests

[chromium] More rebaselines for r100177 after r100193 did not fully
green the Chromium Mac bots.

Unreviewed, gardening.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-cg-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:27 PM Changeset in webkit [100236] by pkasting@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline svg/foreignObject/multiple-foreign-objects.html on Snow
Leopard and earlier.

Unreviewed, gardening.

  • platform/mac-snowleopard/svg/foreignObject: Added.
  • platform/mac-snowleopard/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
8:08 PM Changeset in webkit [100235] by commit-queue@webkit.org
  • 11 edits
    10 deletes in trunk

[chromium] Fix scaleDelta zoom-out visibility rect bug
​https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way. I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <​aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: ​https://bugs.webkit.org/show_bug.cgi?id=71529)

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scaleDelta):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersInternal):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::scaleDelta):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

7:14 PM Changeset in webkit [100234] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix the build after moving some arrays to WTF
​https://bugs.webkit.org/show_bug.cgi?id=72345

Reviewed by Dirk Pranke.

  • public/WebArrayBufferView.h: s/WebCore/WTF/g.
7:08 PM Changeset in webkit [100233] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Improve ChangeLogEntry's reviewer parsing algorithm part 2
​https://bugs.webkit.org/show_bug.cgi?id=72340

Reviewed by Eric Seidel.

This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
6:46 PM Changeset in webkit [100232] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

WebProcess crashes when trying to display your "uploaded videos" page on Facebook
​https://bugs.webkit.org/show_bug.cgi?id=72334

Reviewed by Beth Dakin.

Protect against documents without frames.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

6:33 PM Changeset in webkit [100231] by eric@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style broken by r99773: "Could not determine the port"
​https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

The TestExpectationsChecker was using a generic try/except block
which caught all exceptions, so we didn't notice that failing
to pass a Host to PortFactory was causing an exception in port instantiation.
I've factored out the "lookup the port" logic into a separate function
which I've now unittested. This should fix the bug and prevent
others like it from occuring the the future.

  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
6:18 PM Changeset in webkit [100230] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

More V8 build fixes.

6:06 PM Changeset in webkit [100229] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build again.

5:58 PM Changeset in webkit [100228] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fix V8 build

5:52 PM Changeset in webkit [100227] by oliver@apple.com
  • 46 edits
    4 copies
    9 adds in trunk/Source

Start migrating typed array impl types to WTF
​https://bugs.webkit.org/show_bug.cgi?id=72336

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add typed array impls to WTF forwarding header.

  • wtf/Forward.h:

Source/WebCore:

Move typed arrays from WebCore namespace to WTF, and
start reducing dependencies on WebCore types.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsTypedArrayType):
(AddClassForwardIfNeeded):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.

(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.

(WebDOMFloat64Array::~WebDOMFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.

(WebKit::kit):
(WebKit::core):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_set_property):
(webkit_dom_float64array_get_property):
(webkit_dom_float64array_constructed):
(webkit_dom_float64array_class_init):
(webkit_dom_float64array_init):
(WebKit::wrapFloat64Array):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Added.

(WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::JSFloat64ArrayPrototype::self):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::JSFloat64Array):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::put):
(WebCore::JSFloat64Array::putByIndex):
(WebCore::JSFloat64Array::getOwnPropertyNames):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::JSFloat64Array::getByIndex):
(WebCore::toFloat64Array):
(WTF::Float64Array::neuterBinding):

  • bindings/scripts/test/JS/JSFloat64Array.h: Added.

(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(WebCore::JSFloat64Array::impl):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::create):
(WebCore::JSFloat64ArrayConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.

(core):
(kit):

  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
  • bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
  • bindings/scripts/test/V8/V8Float64Array.cpp: Added.

(WebCore::Float64ArrayInternal::V8_USE):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore::V8Float64Array::wrapSlow):
(WTF::Float64Array::neuterBinding):
(WebCore::V8Float64Array::derefObject):

  • bindings/scripts/test/V8/V8Float64Array.h: Added.

(WebCore::V8Float64Array::toNative):
(WebCore::V8Float64Array::existingWrapper):
(WebCore::V8Float64Array::wrap):
(WebCore::toV8):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.h:
  • html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::setImpl):
(WTF::ArrayBufferView::setRangeImpl):
(WTF::ArrayBufferView::zeroRangeImpl):
(WTF::ArrayBufferView::neuter):

  • html/canvas/ArrayBufferView.h:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.h:

(WTF::Float32Array::set):

  • html/canvas/Float64Array.cpp:
  • html/canvas/Float64Array.h:

(WTF::Float64Array::set):

  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.h:

(WTF::Int16Array::set):

  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.h:

(WTF::Int32Array::set):

  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.h:

(WTF::Int8Array::set):

  • html/canvas/IntegralTypedArrayBase.h:
  • html/canvas/TypedArrayBase.h:

(WTF::TypedArrayBase::set):
(WTF::TypedArrayBase::setRange):
(WTF::TypedArrayBase::zeroRange):

  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.h:

(WTF::Uint16Array::set):

  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.h:

(WTF::Uint32Array::set):

  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.h:

(WTF::Uint8Array::set):

  • html/canvas/WebGLBuffer.h:
  • page/Crypto.h:
  • webaudio/AsyncAudioDecoder.h:
  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::zero):

  • webaudio/AudioContext.h:
  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperNode.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • xml/XMLHttpRequest.h:
5:48 PM Changeset in webkit [100226] by jchaffraix@webkit.org
  • 13 edits in trunk

Add --css-grid-layout to build-webkit and the build systems
​https://bugs.webkit.org/show_bug.cgi?id=72320

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

Added the option.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
5:43 PM Changeset in webkit [100225] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
​https://bugs.webkit.org/show_bug.cgi?id=72335

Patch by Daniel Bates <​dbates@rim.com> on 2011-11-14
Reviewed by Eric Seidel.

It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.

  • rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
  • rendering/svg/RenderSVGContainer.cpp: Ditto.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • rendering/svg/RenderSVGImage.cpp: Ditto.
  • rendering/svg/RenderSVGInline.cpp: Ditto.
  • rendering/svg/RenderSVGModelObject.cpp: Ditto.
  • rendering/svg/RenderSVGPath.cpp: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto.
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
  • rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
  • rendering/svg/RenderSVGRoot.cpp: Ditto.
  • rendering/svg/RenderSVGText.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
  • svg/SVGDocumentExtensions.cpp: Ditto.
  • svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
5:39 PM Changeset in webkit [100224] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

A little bit of arguments / activation cleanup
​https://bugs.webkit.org/show_bug.cgi?id=72339

Reviewed by Gavin Barraclough.

Renamed copyRegisters => tearOff to match bytecode and other terminology.

Renamed setActivation => didTearOffActivation to indicate that this is a
notification the object may choose to ignore. Moved "Should I ignore?"
code into the arguments object to avoid duplication elsewhere.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::createAndTearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::finishCreationButDontTearOff):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndTearOff):
(JSC::Arguments::tearOff):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff): Moved Activation's code into its own header
because that's where it belongs.

5:32 PM Changeset in webkit [100223] by barraclough@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Should sign the jsc binary
​https://bugs.webkit.org/show_bug.cgi?id=72332

Reviewed by David Kilzer.

  • Configurations/JSC.xcconfig:
  • entitlements.plist: Added.
5:23 PM Changeset in webkit [100222] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
​https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

  • dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

5:22 PM Changeset in webkit [100221] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG's inline references to objects should be tracked
​https://bugs.webkit.org/show_bug.cgi?id=72313

Reviewed by Gavin Barraclough.

Added a pinCell() method in the parser that currently creates a
dummy constant in CodeBlock. Added calls to pinCell() wherever the
DFG would inline a constant reference that the original code would
not have referred to.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getCellConstantIndex):
(JSC::DFG::ByteCodeParser::pinCell):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

5:13 PM Changeset in webkit [100220] by noel.gordon@gmail.com
  • 1 edit
    5 adds in trunk/LayoutTests

Test JPEG image decoding RGB pixel endianess
​https://bugs.webkit.org/show_bug.cgi?id=72234

Reviewed by Kent Tamura.

JPEG image RGB pixels should render without color corruption and in strict
order, regardless of the underlying machine pixel buffer endianess.

  • fast/images/resources/rgb-jpeg-blue.jpg: Added.
  • fast/images/resources/rgb-jpeg-green.jpg: Added.
  • fast/images/resources/rgb-jpeg-red.jpg: Added.
  • fast/images/rgb-jpeg-endian-pixels-expected.txt: Added.
  • fast/images/rgb-jpeg-endian-pixels.html: Added.
5:04 PM Changeset in webkit [100219] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG put_by_id transition optimizations test the wrong structures
​https://bugs.webkit.org/show_bug.cgi?id=72324

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::structureChainIsStillValid):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

4:57 PM Changeset in webkit [100218] by gavinp@chromium.org
  • 1 edit in branches/chromium/912/Source/WebCore/loader/cache/CachedResourceRequest.cpp

MERGE 71122 and 72068 simultaniously.

71122:

properly end requests when a bad status code return happens

​https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.

There is a chromium test going through code review at ​http://codereview.chromium.org/8404001/

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

72068:

Protect Document during error responses

​https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::didReceiveData):

4:51 PM Changeset in webkit [100217] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Expose compositeAndReadback in WebLayerTreeView
​https://bugs.webkit.org/show_bug.cgi?id=72188

Patch by Ian Vollick <​vollick@chromium.org> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebLayerTreeView.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::compositeAndReadback):

4:47 PM Changeset in webkit [100216] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r100192.
​http://trac.webkit.org/changeset/100192
​https://bugs.webkit.org/show_bug.cgi?id=72328

Caused infinite tests to fail (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-14

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
4:39 PM Changeset in webkit [100215] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/rendering

Remove FixedRect stream operator and move FloatRect version back to svg/

4:34 PM Changeset in webkit [100214] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

div with webkit-transform + webkit-box-reflect disappears when switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=53355

Reviewed by Dean Jackson.

Tickle Core Animation into updating the layer's content property when
switching back to a tab which has composited reflections. This hack is
needed becuase reflections involve sharing layer contents between layers.

  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer actionForKey:]):

4:24 PM Changeset in webkit [100213] by abarth@webkit.org
  • 19 edits in trunk

Unique origins shouldn't remember their scheme, host, or port
​https://bugs.webkit.org/show_bug.cgi?id=72308

Reviewed by Eric Seidel.

Source/WebCore:

This patch contains the bulk (all?) of the behavior differences in this
patch series. Unique origins shouldn't remember their schemes. Doing
so causes some privileges (e.g., local access) to leak into unique
origins.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):

  • Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant.
  • platform/SchemeRegistry.cpp:

(WebCore::schemesWithUniqueOrigins):

  • Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin.

LayoutTests:

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-readonly-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
    • Update test results to show that we no longer leak the scheme in storage identifiers.
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
    • Inline script because the sandbox iframe isn't allowed to load local resources.
  • fast/frames/sandboxed-iframe-attribute-parsing.html:
  • fast/frames/sandboxed-iframe-forms-dynamic.html:
  • fast/frames/sandboxed-iframe-forms.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html:
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html:
  • fast/frames/sandboxed-iframe-navigation-top.html:
  • media/video-controls-no-scripting.html:
    • Previously sandboxed local iframes still got universal access when we're running with universal access for file URLs! Now that they correctly get unique origins, we need to update these tests to allow-same-origin access in order for them to function properly.
4:21 PM Changeset in webkit [100212] by mrowe@apple.com
  • 3 edits
    5 adds in trunk/Websites/webkit.org

Upgrade WordPress's Akismet plug-in to the latest version.

  • blog/wp-content/plugins/akismet:
4:20 PM Changeset in webkit [100211] by jchaffraix@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
​https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

  • css3/flexbox/display-flexbox-set-get-expected.txt: Added.
  • css3/flexbox/display-flexbox-set-get.html: Added.
  • css3/flexbox/resources/display-flexbox-set-get.js: Added.
4:18 PM Changeset in webkit [100210] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add buffering to handle mismatch between hardware buffer size and webaudio render size
​https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <Raymond Toy> on 2011-11-14
Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render): Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer. Also
remove the rounding of the callback size so we use whatever the
hardware returns. Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.

  • src/AudioDestinationChromium.h:

(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

4:16 PM Changeset in webkit [100209] by mrowe@apple.com
  • 2 edits in trunk/Websites/webkit.org

Update one file that was missed.

  • blog/wp-settings.php:
4:16 PM Changeset in webkit [100208] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr. Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.

  • runtime/JSString.h:
4:12 PM Changeset in webkit [100207] by mrowe@apple.com
  • 397 edits
    21 copies
    7 moves
    230 adds
    106 deletes in trunk/Websites/webkit.org

Upgrade WordPress to v3.2.1.

  • blog:
4:05 PM Changeset in webkit [100206] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Correcting usage of intMaxForLength in AutoTableLayout.

4:04 PM Changeset in webkit [100205] by abarth@webkit.org
  • 15 edits
    1 copy
    1 add in trunk/Source/JavaScriptCore

DateMath.cpp should not depend on JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore. There shouldn't be any behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstanceCache.h:
  • runtime/DatePrototype.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.

(JSC::timeToMS):
(JSC::msToSeconds):

  • runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
  • wtf/DateMath.cpp:

(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):

  • wtf/DateMath.h:
4:01 PM Changeset in webkit [100204] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Update ewk_frame_script_execute to return the result for JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <​js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_frame.h:
4:00 PM Changeset in webkit [100203] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
​https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
​https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

  • editing/pasteboard/drag-drop-dead-frame.html:
  • editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
  • editing/pasteboard/drag-drop-to-data-url.html: Added.
3:51 PM Changeset in webkit [100202] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit handling to JSString Ropes
​https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):

  • runtime/JSString.h:

(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

3:33 PM Changeset in webkit [100201] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Round width and height when computing the scroll size (as opposed to flooring).

3:16 PM Changeset in webkit [100200] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

A little bit of function call cleanup
​https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

  • bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because

16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

3:10 PM Changeset in webkit [100199] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Pipe compositor commit/swap up to WebWidgetClient
​https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebLayerTreeViewImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

2:51 PM Changeset in webkit [100198] by tony@chromium.org
  • 45 edits in trunk

Remove the CSS3_FLEXBOX compile time flag and enable on all ports
​https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSFlexValue.cpp:
  • css/CSSFlexValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:
  • rendering/style/StyleFlexibleBoxData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:47 PM Changeset in webkit [100197] by mrowe@apple.com
  • 3 edits
    2 copies in trunk/Source/JavaScriptCore

<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when

FORCE_TOOL_INSTALL is YES.

3) Switches the testapi target to using a script build phase to install testapi.js

so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
why this isn't the built-in behavior when a Copy Files build phase has "Copy only
when installing" checked, but it doesn't seem to be.

4) Other random cleanup such as removing a bogus group that refers to files that do

not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

  • Configurations/JSC.xcconfig: Added.
  • Configurations/TestRegExp.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:47 PM Changeset in webkit [100196] by fsamuel@chromium.org
  • 6 edits
    1 copy
    2 adds in trunk

[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
​https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

  1. setPageScaleFactorLimits now affects the behavior of other scaling methods including setPageScaleFactor.
  2. setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset along with the page, preserving the scroll position within the page bounds.
  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
  • platform/chromium/fast/repaint/background-scaling-expected.txt: Added.
2:42 PM Changeset in webkit [100195] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Towards 8 bit strings - Add 8 bit paths to StringImpl methods
​https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

  • wtf/text/WTFString.cpp:

(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):

  • wtf/text/WTFString.h:

(WTF::find):
(WTF::reverseFind):

2:39 PM Changeset in webkit [100194] by scheib@chromium.org
  • 11 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
​https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPointerLockEnabled):

  • src/WebSettingsImpl.h:
2:32 PM Changeset in webkit [100193] by robert@webkit.org
  • 12 edits
    13 copies
    11 moves
    31 adds
    1 delete in trunk/LayoutTests

Platform-specific results for r100177

Unreviewed gardening.

  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
  • platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/qt/fast/table/multiple-captions-display-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
2:29 PM Changeset in webkit [100192] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests should not be locale dependent ​https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <​vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/base.py:
2:25 PM Changeset in webkit [100191] by commit-queue@webkit.org
  • 20 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r100176.
​http://trac.webkit.org/changeset/100176
​https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:
2:22 PM Changeset in webkit [100190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
​https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):

2:19 PM Changeset in webkit [100189] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Reverting lengths to being stored as pixel values for the specified zoom level and adopting an enclosingIntRect model for reporting sizes in RenderTreeAsText. This vastly lowers the number of failing layout tests on our branch.

1:56 PM Changeset in webkit [100188] by eae@chromium.org
  • 1569 edits
    513 copies
    162 deletes in branches/subpixellayout

Merging trunk changes up until 100042 into subpixel branch.

1:55 PM Changeset in webkit [100187] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

remove -wap-marquee css propery value
​https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

  • css/CSSValueKeywords.in:
1:49 PM Changeset in webkit [100186] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

JS Test Harness: Remove one more reference to non existing js-test-post-function.js
​https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

  • storage/indexeddb/mozilla/delete-result.html:
1:48 PM Changeset in webkit [100185] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Only send progress notifications for the main frame
​https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

1:45 PM Changeset in webkit [100184] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

[Chromium] build-webkit silently drops the features flags
​https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

  • Scripts/build-webkit: Check if one of the features is different

from the default and print a warning in this case.

1:21 PM Changeset in webkit [100183] by jchaffraix@webkit.org
  • 4 edits
    6 adds in trunk

Crash in RenderTableSection::splitColumn
​https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html

fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

  • fast/table/crash-splitColumn-2-expected.txt: Added.
  • fast/table/crash-splitColumn-2.html: Added.
  • fast/table/crash-splitColumn-3-expected.txt: Added.
  • fast/table/crash-splitColumn-3.html: Added.
  • fast/table/crash-splitColumn-expected.txt: Added.
  • fast/table/crash-splitColumn.html: Added.
12:58 PM Changeset in webkit [100182] by abarth@webkit.org
  • 6 edits in trunk/Source

Remove the concept of an empty SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs. Previous
patches have removed most of the code relying upon this function. This
patch removes a couple stragglers.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

  • This check should really be about unique origins because it doesn't make sense to target postMessages at unique origins, as explained in the comment.
  • page/SecurityOrigin.cpp:
  • page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isEmpty):

12:56 PM Changeset in webkit [100181] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityContext::isSecureTransitionTo should not refer to empty security origins
​https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSecureTransitionTo):

12:50 PM Changeset in webkit [100180] by scheib@chromium.org
  • 19 edits in trunk/Source

Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
​https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • dom/MouseEvent.idl:
  • dom/MouseRelatedEvent.h:
  • page/MouseLockable.cpp:
  • page/MouseLockable.h:
  • page/MouseLockable.idl:
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMouseLockEnabled):

12:48 PM Changeset in webkit [100179] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by ​https://bugs.webkit.org/show_bug.cgi?id=72297.

  • platform/gtk/Skipped:
12:46 PM Changeset in webkit [100178] by annacc@chromium.org
  • 6 edits
    2 deletes in trunk/Source/WebCore

Remove TextTrackCueIndex and TextTrackCueSet. No longer needed.
​https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCueIndex.cpp: Removed.
  • html/TextTrackCueIndex.h: Removed.
12:41 PM Changeset in webkit [100177] by robert@webkit.org
  • 15 edits
    21 adds in trunk

CSS 2.1 failure: border-spacing-applies-to-015.htm
​https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:

LayoutTests:

  • css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
  • css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-002.htm: Added. Now passes!
  • css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
  • css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
  • fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
  • fast/table/multiple-captions-display.xhtml: Extra captions now appear in result

so remove their FAIL notices.

  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Result reflects extra captions.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Result reflects extra captions.
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png: Result reflects extra caption.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Result reflects extra captions.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt: Result reflects extra caption.
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt: Result reflects extra caption.
12:24 PM Changeset in webkit [100176] by commit-queue@webkit.org
  • 20 edits
    1 copy
    2 adds in trunk/Source

Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
​https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <​gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.

(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):

  • html/canvas/WebGLExperimentalCompressedTextures.h: Added.
  • html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

12:23 PM Changeset in webkit [100175] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

(WTF::OSAllocator::reserveAndCommit):

12:08 PM Changeset in webkit [100174] by ddkilzer@apple.com
  • 2 edits
    4 adds in trunk/Tools

run-leaks does not work on Lion?
<​http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing. This required using a more generic
algorithm to find the start of the "Process " lines.

  • Scripts/run-leaks:

(parseLeaksOutput): Make the code to skip headers more generic.

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
12:04 PM Changeset in webkit [100173] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

  • public/WebMediaStreamDescriptor.h:
  • public/WebMediaStreamSource.h:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):

  • src/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::operator=):

11:46 AM Changeset in webkit [100172] by Michael Nordman
  • 32 edits in trunk

Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
​https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

  • platform/sql/SQLiteDatabase.h:
  • storage/AbstractDatabase.cpp:

(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

  • storage/AbstractDatabase.h:
  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:

(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):

  • storage/DatabaseSync.idl:

Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

  • storage/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

  • storage/SQLError.h:

(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatementSync.cpp:

(WebCore::SQLStatementSync::execute):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for new websql error messages and console logging.
​https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/workers/storage/test-authorizer-expected.txt:
  • fast/workers/storage/transaction-in-transaction-sync.html:
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt:
  • storage/change-version-handle-reuse-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
  • storage/private-browsing-noread-nowrite-expected.txt:
  • storage/test-authorizer-expected.txt:
11:44 AM Changeset in webkit [100171] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

11:39 AM Changeset in webkit [100170] by abarth@webkit.org
  • 1 edit in trunk/Source/WebCore/dom/Document.cpp

Fix typo.

11:33 AM Changeset in webkit [100169] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec. I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

11:26 AM Changeset in webkit [100168] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused m_data member from UStringSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

  • parser/SourceProvider.h:

(JSC::UStringSourceProvider::UStringSourceProvider):

11:25 AM Changeset in webkit [100167] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Towards 8 Bit Strings: Templatize YARR Parser
​https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

11:23 AM Changeset in webkit [100166] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit build fix: Removed unused declaration.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

11:21 AM Changeset in webkit [100165] by ggaren@apple.com
  • 31 edits in trunk/Source/JavaScriptCore

Standardized the JS calling convention
​https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):

  • bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows

us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.
  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

  • dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

  • dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before

doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

  • interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

  • interpreter/Interpreter.h:

(JSC::Interpreter::execute): Headers are fun and educational!

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::growSlowCase):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

  • jit/JITStubs.cpp:

(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

  • runtime/Arguments.h:

(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

11:14 AM Changeset in webkit [100164] by arv@chromium.org
  • 16 edits
    6 deletes in trunk

Remove getParameter from HTMLAnchorElement and Location
​https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

  • html/HTMLAnchorElement.cpp: Removed getParameter.
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLAnchorElement.idl: Ditto.
  • page/Location.cpp: Ditto.
  • page/Location.h: Ditto.
  • page/Location.idl: Ditto.

LayoutTests:

  • fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/anchor-getParameter-expected.txt: Removed.
  • fast/dom/anchor-getParameter.html: Removed.
  • http/tests/misc/location-getParameter-expected.txt: Removed.
  • http/tests/misc/location-getParameter.html: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
11:11 AM Changeset in webkit [100163] by arv@chromium.org
  • 22 edits
    2 adds in trunk

Remove RequiresAllArguments
​https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
  • page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
  • websockets/WebSocket.idl: Comment changes only.

LayoutTests:

  • fast/dom/Window/window-resize-and-move-arguments-expected.txt:
  • fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
  • fast/dom/Window/window-scroll-arguments-expected.txt:
  • fast/dom/Window/window-scroll-arguments.html: Ditto.
  • fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
  • fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
10:06 AM Changeset in webkit [100162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
​https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

  • bridge/PeerConnectionHandlerInternal.cpp:

(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):

  • public/WebKitPlatformSupport.h:
9:59 AM Changeset in webkit [100161] by Lucas Forschler
  • 1 copy in tags/Safari-534.52.11

New tag.

9:56 AM Changeset in webkit [100160] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
​https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <​thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/AccessibilityUIElement.h:
9:55 AM Changeset in webkit [100159] by jer.noble@apple.com
  • 32 edits
    3 copies
    7 adds in trunk

Implement MediaController.
​https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

  • wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html

media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.

  • html/MediaControllerInterface.h: Added.

(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.

  • html/MediaController.cpp: Added.

(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):

  • html/MediaController.h: Added.

(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):

  • html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.

  • html/TimeRanges.cpp:

(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):

  • html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.

  • page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.

  • html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):

  • html/HTMLMediaElement.idl:
  • bindings/js/JSHTMLMediaElementCustom.cpp: Added.

(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:

  • html/HTMLMediaElement.cpp:

(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element. By default this is a single range of [0, maxTimeSeekable].

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::seekable):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toMediaController):

  • dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:

  • platform/ClockGeneric.cpp:

(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):

  • platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • media/media-controller-expected.txt: Added.
  • media/media-controller-playback-expected.txt: Added.
  • media/media-controller-playback.html: Added.
  • media/media-controller.html: Added.
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
9:44 AM Changeset in webkit [100158] by scherkus@chromium.org
  • 4 edits in trunk

[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
​https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

  • platform/chromium/test_expectations.txt:
9:31 AM Changeset in webkit [100157] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Multiple foreign objects not rendered
​https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <​fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/runner-expected.txt: Rebaselined.
  • platform/chromium/html5lib/runner-expected.txt: Rebaselined.
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
  • svg/foreignObject/multiple-foreign-objects-expected.png: Added.
  • svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
  • svg/foreignObject/multiple-foreign-objects.html: Added.
9:29 AM Changeset in webkit [100156] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
​https://bugs.webkit.org/show_bug.cgi?id=59771

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
9:16 AM Changeset in webkit [100155] by alexis.menard@openbossa.org
  • 2 edits
    10 moves
    2 adds
    7 deletes in trunk/Source/WebKit2

[Qt][WK2] Cleanup QML tests.
​https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
9:10 AM Changeset in webkit [100154] by Lucas Forschler
  • 2 edits in branches/safari-534.52-branch/Source/WebCore

Merge r100022.

9:05 AM Changeset in webkit [100153] by mario@webkit.org
  • 7 edits in trunk/Source

Add support for the caretBrowsingEnabled preference in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

  • WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter

and setter macro.

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

9:01 AM Changeset in webkit [100152] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Remove dependency on pthread from FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

  • wtf/FastMalloc.cpp:
8:59 AM Changeset in webkit [100151] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
8:56 AM Changeset in webkit [100150] by Lucas Forschler
  • 5 edits in branches/safari-534.52-branch/Source

Versioning.

8:52 AM Changeset in webkit [100149] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-webvtt-tc004-magic-header.html flakily times out
​https://bugs.webkit.org/show_bug.cgi?id=72279

  • platform/chromium/test_expectations.txt: Expect test to flakily timeout.
8:45 AM Changeset in webkit [100148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove expected crashes for skia-gpu canvas from test expectations
​https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <​bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
8:41 AM Changeset in webkit [100147] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.
8:30 AM Changeset in webkit [100146] by fsamuel@chromium.org
  • 10 edits in trunk/Source

[chromium] Plumb through partial swap
​https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <​backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

8:29 AM Changeset in webkit [100145] by caseq@chromium.org
  • 16 edits
    1 delete in trunk

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
​https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

  • replace IFrameView with ExtensionView;
  • inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
  • move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
  • expose iframe's window object in the onShow event handler.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):

  • inspector/front-end/IFrameView.js: Removed.
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:
  • platform/chromium/inspector/extensions/extensions-api-expected.txt:
8:22 AM Changeset in webkit [100144] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed evening gardening. Try to make the bot green.

7:56 AM Changeset in webkit [100143] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: add 'Show function definition' context menu item for function values
​https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

  • inspector/front-end/inspector.js:

(WebInspector.showPanelForAnchorNavigation):

7:44 AM Changeset in webkit [100142] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
​https://bugs.webkit.org/show_bug.cgi?id=72249

7:33 AM Changeset in webkit [100141] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] security/crypto-random-values-types.html is flaky on win
​https://bugs.webkit.org/show_bug.cgi?id=72272

  • platform/chromium/test_expectations.txt: Mark test as flaky.
7:17 AM Changeset in webkit [100140] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=72271

  • platform/chromium/test_expectations.txt: Expect test to crash sometimes.
6:58 AM UsingGitWithWebKit edited by Adam Roben
Added some tips for breaking up large patches (diff)
6:53 AM Changeset in webkit [100139] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

media/track/track-cues-cuechange.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72269

  • platform/chromium/test_expectations.txt: Mark test as flaky.
6:29 AM Changeset in webkit [100138] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping passing test.

  • platform/chromium/test_expectations.txt:
6:14 AM Changeset in webkit [100137] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: console's protocol payload does not have url and line properties.
​https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):

LayoutTests:

  • inspector/console/console-url-and-line-expected.txt: Added.
  • inspector/console/console-url-and-line.html: Added.
  • inspector/protocol/console-agent-expected.txt:
6:06 AM Changeset in webkit [100136] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Two inspector tests timeout on mac
​https://bugs.webkit.org/show_bug.cgi?id=72264

  • platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.
6:03 AM Changeset in webkit [100135] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [regression r99960] null callback access.
​https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

  • inspector/CodeGeneratorInspector.py:
5:19 AM Changeset in webkit [100134] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

5:19 AM Changeset in webkit [100133] by vestbo@webkit.org
  • 4 edits
    1 move
    1 add in trunk

[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

5:06 AM Changeset in webkit [100132] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

  • qmake/mkspecs/features/features.prf:
5:01 AM Changeset in webkit [100131] by Simon Hausmann
  • 4 edits in trunk/Source

[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

  • wtf/qt/compat/qguiapplication.h:

(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

4:58 AM Changeset in webkit [100130] by vestbo@webkit.org
  • 4 edits
    2 adds in trunk/Tools

[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

4:46 AM Changeset in webkit [100129] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove reference to QWebNavigationController
​https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p.h:
4:44 AM Changeset in webkit [100128] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Tests occasionally report missing expectations
​https://bugs.webkit.org/show_bug.cgi?id=72039

  • platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.
4:41 AM Changeset in webkit [100127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
​https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <​husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

4:20 AM Changeset in webkit [100126] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[CMAKE] Add the UseV8.cmake to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <​jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

  • UseV8.cmake: Added.
3:55 AM Changeset in webkit [100125] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] the QQuickWebView should support double-tap to zoom
​https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

  • UIProcess/qt/QtViewInterface.cpp:
  • UIProcess/qt/QtViewInterface.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

3:52 AM Changeset in webkit [100124] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
​https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

  • http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
  • http/tests/inspector/resource-tree/appcache-test.js:

(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [100123] by Simon Hausmann
  • 14 edits
    4 adds
    2 deletes in trunk

[Qt] Remove the QStyle dependency in Qt's mobile theme ​https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <​pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

  • Target.pri:
  • platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic

now lives within RenderThemeQtMobile.

  • platform/qt/QtMobileWebStyle.h: Removed. Ditto.
  • platform/qt/RenderThemeQStyle.cpp: Added.

(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Added.

(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):

  • platform/qt/RenderThemeQt.h:

(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):

  • platform/qt/RenderThemeQtMobile.cpp: Added.

(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h: Added.
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • tests/tests.pri:

Tools:

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,

based on availability of QtWidgets.

  • qmake/mkspecs/features/webcore.prf: cleanup.
3:49 AM Changeset in webkit [100122] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
​https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:
3:24 AM Changeset in webkit [100121] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Possible crash when destroying after called widgetSizeChanged.
​https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::chromeDestroyed):

3:15 AM Changeset in webkit [100120] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

  • platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.
2:53 AM Changeset in webkit [100119] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r100116.
​http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

  • Scripts/run-bindings-tests:
2:48 AM Changeset in webkit [100118] by tonyg@chromium.org
  • 18 edits in trunk/Tools

Unreviewed, rolling out r100104.
​http://trac.webkit.org/changeset/100104
​https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
2:26 AM Changeset in webkit [100117] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

SecurityContext should track whether the SecurityOrigin has been initialized
​https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards ​https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized. In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):

  • dom/SecurityContext.h:

(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

2:00 AM Changeset in webkit [100116] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, build fix after r100104. run-binding-tests broke.

  • Scripts/run-bindings-tests: Explicitely use scm.detection.
1:50 AM Changeset in webkit [100115] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
1:40 AM Changeset in webkit [100114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Give HTML ContextMenu a more Native look
​https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2011-11-14
Reviewed by Pavel Feldman.

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

  • inspector/front-end/inspector.css:

(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

1:27 AM Changeset in webkit [100113] by yurys@chromium.org
  • 16 edits
    3 adds in trunk

Web Inspector: function remote objetct should provide access to function position in the script
​https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

(JSC::JSFunction::sourceCode):

  • runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionLocation):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getFunctionLocation):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionLocation):

  • inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

  • inspector/debugger/function-location-expected.txt: Added.
  • inspector/debugger/function-location.html: Added.
  • platform/chromium/inspector/debugger/function-location-expected.txt: Added.
1:25 AM Changeset in webkit [100112] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r100050
​https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-11-14

  • platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html
1:18 AM Changeset in webkit [100111] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
​https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
  • fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.
1:16 AM Changeset in webkit [100110] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
​https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerContext):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
  • http/tests/inspector-enabled/dedicated-workers-list.html: Added.
  • http/tests/inspector-enabled/resources/dedicated-worker.js: Added.

(doWork):

1:14 AM Changeset in webkit [100109] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Build breaks with --no-javascript-debugger --no-inspector
​https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

  • workers/WorkerMessagingProxy.cpp:

(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

12:27 AM Changeset in webkit [100108] by haraken@chromium.org
  • 16 edits
    1 delete in trunk/Source/WebCore

Remove all custom constructors of Events in V8
​https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html

fast/events/constructors/close-event-constructor.html
fast/events/constructors/custom-event-constructor.html
fast/events/constructors/error-event-constructor.html
fast/events/constructors/event-constructors.html
fast/events/constructors/hash-change-event-constructor.html
fast/events/constructors/message-event-constructor.html
fast/events/constructors/overflow-event-constructor.html
fast/events/constructors/page-transition-event-constructor.html
fast/events/constructors/pop-state-event-constructor.html
fast/events/constructors/progress-event-constructor.html
fast/events/constructors/track-event-constructor.html
fast/events/constructors/webkit-animation-event-constructor.html
fast/events/constructors/webkit-transition-event-constructor.html

  • Target.pri: Removed V8EventConstructors.cpp.
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
  • dom/CustomEvent.idl: Ditto.
  • dom/ErrorEvent.idl: Ditto.
  • dom/HashChangeEvent.idl: Ditto.
  • dom/MessageEvent.idl: Ditto.
  • dom/OverflowEvent.idl: Ditto.
  • dom/PageTransitionEvent.idl: Ditto.
  • dom/PopStateEvent.idl: Ditto.
  • dom/ProgressEvent.idl: Ditto.
  • dom/WebKitAnimationEvent.idl: Ditto.
  • dom/WebKitTransitionEvent.idl: Ditto.
  • html/track/TrackEvent.idl: Ditto.
  • websockets/CloseEvent.idl: Ditto.
12:23 AM BuildingQtOnLinux edited by Csaba Osztrogonác
(diff)
12:20 AM Changeset in webkit [100107] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 2 new svg tests.

  • platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
12:16 AM Changeset in webkit [100106] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WX] Make FontPlatformData::m_size private
​https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

  • platform/graphics/wx/FontPlatformData.h:
12:15 AM Changeset in webkit [100105] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

  • platform/gtk/Skipped:
12:07 AM Changeset in webkit [100104] by eric@webkit.org
  • 18 edits in trunk/Tools

Add SCMDetector object to make scm detection mockable
​https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py:
  • Scripts/webkitpy/common/checkout/scm/init.py:
  • Scripts/webkitpy/common/checkout/scm/detection.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/common/host_mock.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
Note: See TracTimeline for information about the timeline view.