Timeline

Nov 23, 2011:

11:47 PM Changeset in webkit [101124] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
​https://bugs.webkit.org/show_bug.cgi?id=52810

Unreviewed gardening.

• platform/qt/Skipped: Skip svg/dom/css-transforms.xhtml introduced in r101062, because 0.0 != -0.0.

11:46 PM Changeset in webkit [101123] by commit-queue@webkit.org

• 4 edits
  2 copies in trunk/Source/WebKit/chromium

Add simple implementation for web intents chromium API data classes.
​https://bugs.webkit.org/show_bug.cgi?id=73036

Patch by Greg Billock <​gbillock@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebIntent.h:
• public/WebIntentServiceInfo.h:
• src/WebIntent.cpp: Copied from Source/WebKit/chromium/public/WebIntent.h.

(WebKit::WebIntent::WebIntent):
(WebKit::WebIntent::action):
(WebKit::WebIntent::setAction):
(WebKit::WebIntent::type):
(WebKit::WebIntent::setType):
(WebKit::WebIntent::data):
(WebKit::WebIntent::setData):
(WebKit::WebIntent::identifier):
(WebKit::WebIntent::setIdentifier):

• src/WebIntentServiceInfo.cpp: Copied from Source/WebKit/chromium/public/WebIntentServiceInfo.h.

(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::url):
(WebKit::WebIntentServiceInfo::setURL):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::setTitle):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::setAction):
(WebKit::WebIntentServiceInfo::type):
(WebKit::WebIntentServiceInfo::setType):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::setDisposition):

11:13 PM Changeset in webkit [101122] by abarth@webkit.org

• 168 edits
  15 copies
  16 adds in trunk/Source/WebKit/chromium

[Chromium] Move WebKitPlatformSupport.h and dependencies to new public/platform directory
​https://bugs.webkit.org/show_bug.cgi?id=73066

Reviewed by Darin Fisher.

This patch creates a new subdirectory in the Chromium WebKit API to
house "platform" header files. As with the other Platform directories
in WebKit, the platform directory cannot depend on headers outside of
platform, but headers outside of platform can depend on platform.

This patch moves WebKitPlatformSupport and its dependencies into this
new directory and creates forwarding headers to easy migration for
embedders of this API. Over time, we will migrate more headers into
this folder, as appropriate.

• public/WebAccessibilityObject.h:
• public/WebAccessibilityRole.h:
• public/WebAnimationController.h:
• public/WebApplicationCacheHost.h:
• public/WebApplicationCacheHostClient.h:
• public/WebArrayBufferView.h:
• public/WebAttribute.h:
• public/WebAudioBus.h: Replaced.
• public/WebAudioDevice.h: Replaced.
• public/WebAudioSourceProvider.h:
• public/WebBindings.h:
• public/WebBlob.h:
• public/WebBlobData.h:
• public/WebBlobRegistry.h:
• public/WebCString.h: Replaced.
• public/WebCache.h:
• public/WebCanvas.h:
• public/WebClipboard.h:
• public/WebColor.h:
• public/WebCommon.h: Replaced.
• public/WebCommonWorkerClient.h:
• public/WebCompositor.h:
• public/WebConsoleMessage.h:
• public/WebContentLayer.h:
• public/WebContextMenuData.h:
• public/WebCookie.h:
• public/WebCrossOriginPreflightResultCache.h:
• public/WebDOMEvent.h:
• public/WebDOMEventListener.h:
• public/WebDOMStringList.h:
• public/WebData.h: Replaced.
• public/WebDataSource.h:
• public/WebDatabase.h:
• public/WebDevToolsAgent.h:
• public/WebDevToolsAgentClient.h:
• public/WebDevToolsFrontend.h:
• public/WebDeviceOrientationClientMock.h:
• public/WebDeviceOrientationController.h:
• public/WebDocument.h:
• public/WebDragData.h:
• public/WebExternalPopupMenuClient.h:
• public/WebExternalTextureLayer.h:
• public/WebFileChooserParams.h:
• public/WebFileInfo.h:
• public/WebFileSystem.h:
• public/WebFileSystemCallbacks.h:
• public/WebFileSystemEntry.h:
• public/WebFileUtilities.h:
• public/WebFileWriter.h:
• public/WebFileWriterClient.h:
• public/WebFindOptions.h:
• public/WebFloatPoint.h:
• public/WebFloatQuad.h:
• public/WebFloatRect.h:
• public/WebFont.h:
• public/WebFontCache.h:
• public/WebFontDescription.h:
• public/WebFormControlElement.h:
• public/WebFormElement.h:
• public/WebFrame.h:
• public/WebFrameClient.h:
• public/WebGamepad.h: Replaced.
• public/WebGamepads.h: Replaced.
• public/WebGeolocationClientMock.h:
• public/WebGeolocationController.h:
• public/WebGeolocationError.h:
• public/WebGeolocationPermissionRequest.h:
• public/WebGeolocationPermissionRequestManager.h:
• public/WebGeolocationPosition.h:
• public/WebGlyphCache.h:
• public/WebGraphicsContext3D.h:
• public/WebHTTPBody.h:
• public/WebHTTPLoadInfo.h:
• public/WebHistoryItem.h:
• public/WebIDBCallbacks.h:
• public/WebIDBCursor.h:
• public/WebIDBDatabase.h:
• public/WebIDBDatabaseCallbacks.h:
• public/WebIDBDatabaseError.h:
• public/WebIDBFactory.h:
• public/WebIDBIndex.h:
• public/WebIDBKey.h:
• public/WebIDBKeyPath.h:
• public/WebIDBKeyRange.h:
• public/WebIDBObjectStore.h:
• public/WebIDBTransaction.h:
• public/WebIDBTransactionCallbacks.h:
• public/WebIconURL.h:
• public/WebImage.h:
• public/WebInputEvent.h:
• public/WebKit.h:
• public/WebKitPlatformSupport.h: Replaced.
• public/WebLayer.h:
• public/WebLayerTreeView.h:
• public/WebLocalizedString.h: Replaced.
• public/WebMediaPlayer.h:
• public/WebMediaStreamDescriptor.h:
• public/WebMediaStreamRegistry.h:
• public/WebMediaStreamSource.h:
• public/WebMenuItemInfo.h:
• public/WebMessagePortChannel.h:
• public/WebMimeRegistry.h:
• public/WebNamedNodeMap.h:
• public/WebNetworkStateNotifier.h:
• public/WebNode.h:
• public/WebNodeCollection.h:
• public/WebNodeList.h:
• public/WebNotification.h:
• public/WebNotificationPresenter.h:
• public/WebOptionElement.h:
• public/WebPageSerializer.h:
• public/WebPasswordFormData.h:
• public/WebPeerConnectionHandler.h:
• public/WebPerformance.h:
• public/WebPlugin.h:
• public/WebPluginParams.h:
• public/WebPoint.h:
• public/WebPopupMenu.h:
• public/WebPopupMenuInfo.h:
• public/WebPrivateOwnPtr.h: Replaced.
• public/WebPrivatePtr.h: Replaced.
• public/WebRange.h:
• public/WebRect.h:
• public/WebRegularExpression.h:
• public/WebRuntimeFeatures.h:
• public/WebScriptController.h:
• public/WebScriptSource.h:
• public/WebScrollbar.h:
• public/WebSearchableFormData.h:
• public/WebSecurityOrigin.h:
• public/WebSecurityPolicy.h:
• public/WebSelectElement.h:
• public/WebSerializedScriptValue.h: Replaced.
• public/WebSettings.h:
• public/WebSharedWorker.h:
• public/WebSharedWorkerRepository.h:
• public/WebSize.h:
• public/WebSocket.h:
• public/WebSocketClient.h:
• public/WebSocketStreamError.h:
• public/WebSocketStreamHandle.h:
• public/WebSocketStreamHandleClient.h:
• public/WebSpeechInputController.h:
• public/WebSpeechInputResult.h:
• public/WebSpellCheckClient.h:
• public/WebStorageArea.h:
• public/WebStorageEventDispatcher.h:
• public/WebStorageNamespace.h:
• public/WebString.h: Replaced.
• public/WebTestingSupport.h:
• public/WebTextCheckingCompletion.h:
• public/WebTextCheckingResult.h:
• public/WebTextRun.h:
• public/WebThread.h:
• public/WebThreadSafeData.h:
• public/WebTouchPoint.h:
• public/WebURL.h: Replaced.
• public/WebURLError.h:
• public/WebURLLoadTiming.h:
• public/WebURLLoader.h:
• public/WebURLRequest.h:
• public/WebURLResponse.h:
• public/WebUserMediaRequest.h:
• public/WebVector.h: Replaced.
• public/WebView.h:
• public/WebViewClient.h:
• public/WebWidget.h:
• public/WebWidgetClient.h:
• public/WebWindowFeatures.h:
• public/android/WebInputEventFactory.h:
• public/gtk/WebInputEventFactory.h:
• public/linux/WebFontFamily.h:
• public/linux/WebFontInfo.h:
• public/linux/WebFontRenderStyle.h:
• public/linux/WebFontRendering.h:
• public/linux/WebRenderTheme.h:
• public/linux/WebSandboxSupport.h:
• public/mac/WebInputEventFactory.h:
• public/mac/WebScreenInfoFactory.h:
• public/platform: Added.
• public/platform/WebAudioBus.h: Copied from Source/WebKit/chromium/public/WebAudioBus.h.
• public/platform/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/WebAudioDevice.h.
• public/platform/WebCString.h: Copied from Source/WebKit/chromium/public/WebCString.h.
• public/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/WebCommon.h.
• public/platform/WebData.h: Copied from Source/WebKit/chromium/public/WebData.h.
• public/platform/WebGamepad.h: Copied from Source/WebKit/chromium/public/WebGamepad.h.
• public/platform/WebGamepads.h: Copied from Source/WebKit/chromium/public/WebGamepads.h.
• public/platform/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitPlatformSupport.h.
• public/platform/WebLocalizedString.h: Copied from Source/WebKit/chromium/public/WebLocalizedString.h.
• public/platform/WebPrivateOwnPtr.h: Copied from Source/WebKit/chromium/public/WebPrivateOwnPtr.h.
• public/platform/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/WebPrivatePtr.h.
• public/platform/WebSerializedScriptValue.h: Copied from Source/WebKit/chromium/public/WebSerializedScriptValue.h.
• public/platform/WebString.h: Copied from Source/WebKit/chromium/public/WebString.h.
• public/platform/WebURL.h: Copied from Source/WebKit/chromium/public/WebURL.h.
• public/platform/WebVector.h: Copied from Source/WebKit/chromium/public/WebVector.h.
• public/win/WebInputEventFactory.h:
• public/win/WebScreenInfoFactory.h:
• public/x11/WebScreenInfoFactory.h:

11:03 PM Changeset in webkit [101121] by abarth@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=73065

Reviewed by Eric Seidel.

This API no longer has any callers.

• public/WebSecurityOrigin.h:
• src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::isUnique):

10:06 PM Changeset in webkit [101120] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

[Chromium] Prevent DrawingBuffer instances from corrupting the active
texture state of the WebGL contexts. The DrawingBuffer now tracks the
state of texture unit 0, and the active texture unit, so that state can
be restored.
​https://bugs.webkit.org/show_bug.cgi?id=73033

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-texture-binding-preserved.html

Source/WebCore:

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindTexture):

• platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

• platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::setTexture2DBinding):
(WebCore::DrawingBuffer::setActiveTextureUnit):

• platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

LayoutTests:

• fast/canvas/webgl/webgl-texture-binding-preserved-expected.txt: Added.
• fast/canvas/webgl/webgl-texture-binding-preserved.html: Added.

10:03 PM Changeset in webkit [101119] by macpherson@chromium.org

• 3 edits in trunk/Source/WebCore

CSSValue: reorder ClassType enum to allow faster comparisons, add COMPILE_ASSERT on class size.
​https://bugs.webkit.org/show_bug.cgi?id=72924

Reviewed by Andreas Kling.

Note that the change from unsigned to unsigned char is to improve bit packing when using MSVC.

Covered by existing CSS tests.

• css/CSSValue.h:

(WebCore::CSSValue::isPrimitiveValue):
(WebCore::CSSValue::isValueList):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isTimingFunctionValue):
(WebCore::CSSValue::CSSValue):

9:14 PM Changeset in webkit [101118] by dslomov@google.com

• 19 edits
  1 delete in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

• bindings/v8/OptionsObject.cpp:

• bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):

• bindings/v8/SerializedScriptValue.h:
• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):

• bindings/v8/V8Utilities.h:
• bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

• bindings/v8/custom/V8MessageEventCustom.cpp:
• bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

• bindings/v8/custom/V8MessagePortCustom.h: Removed.
• bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

Source/WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.

Reviewed by David Levin.

• src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=73054
[V8][Chromium] Add list of transferred ArrayBuffers to SerializedScriptValue::create.
Tests rebaselined to reflect new error message.

Reviewed by David Levin.

• platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
• platform/chromium/fast/events/constructors/message-event-constructor-expected.txt:

7:24 PM Changeset in webkit [101117] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Cleanup #if usage in V8GCController
​https://bugs.webkit.org/show_bug.cgi?id=73060

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. Just code cleanup

• bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

6:45 PM Changeset in webkit [101116] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Change CSSMutableStyleDeclaration::m_node to m_element (along with getter/setter)
​https://bugs.webkit.org/show_bug.cgi?id=73050

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is just a refactor.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::operator=):
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

• css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setElement):
(WebCore::CSSMutableStyleDeclaration::element):

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

• dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::createMappedDecl):

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::inlineStyleElement):

6:31 PM Changeset in webkit [101115] by commit-queue@webkit.org

• 12 edits in trunk/Source

Teach VideoLayerChromium how to render native texture (to support HW video decode).
​https://bugs.webkit.org/show_bug.cgi?id=73043

Patch by Ami Fischman <​fischman@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. (depends on chromium support landing, and supporting HW being available)

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::videoLayerNativeTextureProgram):

• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/VideoFrameChromium.h:
• platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::determineTextureFormat):

• platform/graphics/chromium/VideoLayerChromium.h:
• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::setNativeTexture):
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawNativeTexture):

• platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

• public/WebVideoFrame.h:
• src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::textureId):

• src/VideoFrameChromiumImpl.h:

6:29 PM Changeset in webkit [101114] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

IndexedDB: Remove stylesheet links from layout tests
​https://bugs.webkit.org/show_bug.cgi?id=73053

Remove links to js-test-style.css that slipped in.

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

• storage/indexeddb/cursor-key-order.html:
• storage/indexeddb/key-type-array.html:
• storage/indexeddb/mozilla/delete-result.html:

5:21 PM Changeset in webkit [101113] by abarth@webkit.org

• 9 edits
  2 deletes in trunk/Tools

Unreviewed, rolling out r101107.
​http://trac.webkit.org/changeset/101107
​https://bugs.webkit.org/show_bug.cgi?id=73062

Breaks the commit-queue (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

• Scripts/webkitpy/common/host.py:

(Host._engage_awesome_windows_hacks):

• Scripts/webkitpy/common/host_mock.py:

(MockHost.init):

• Scripts/webkitpy/common/system/environment.py: Removed.
• Scripts/webkitpy/common/system/environment_unittest.py: Removed.
• Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output):
(Executive.run_and_throw_if_fail):

• Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_and_throw_if_fail):
(MockExecutive.run_command):

• Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._driver_build_script_name):
(WebKitPort._run_script):
(WebKitPort._build_driver):

• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_build_driver):

• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/steps/build.py:

(Build.build):

5:15 PM Changeset in webkit [101112] by ojan@chromium.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r101110.
​http://trac.webkit.org/changeset/101110
​https://bugs.webkit.org/show_bug.cgi?id=73057

The bots have now cycled and this patch is no longer needed.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:25 PM Changeset in webkit [101111] by scheib@chromium.org

• 11 edits in trunk/Source

Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to MouseEvents.
​https://bugs.webkit.org/show_bug.cgi?id=73031

Reviewed by Dimitri Glazkov.

Source/WebCore:

No tests for now, but this patch gets us closer to being able to write layout tests for pointer lock.

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

• dom/MouseEvent.h:

(WebCore::MouseEvent::create):

• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

• dom/MouseRelatedEvent.h:
• dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):

• dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

• platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::movementX):
(WebCore::PlatformMouseEvent::movementY):

Source/WebKit/chromium:

• src/WebInputEventConversion.cpp:

(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

4:16 PM Changeset in webkit [101110] by ojan@chromium.org

• 2 edits in trunk/Tools

Temporarily save the incremental results json in order to identify bug
​https://bugs.webkit.org/show_bug.cgi?id=73057

Reviewed by Dean Jackson.

The test results server needed to be rolled back from tip of tree
due to a JSON merging bug. It's hard to identify what the bug is without
the raw data.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

4:04 PM Changeset in webkit [101109] by ojan@chromium.org

• 3 edits in trunk/Tools

Merging two version 4 results hits an error in the test results server
​https://bugs.webkit.org/show_bug.cgi?id=73042

Reviewed by Adam Barth.

The old code assumed that if the aggregate results value was not a leaf
value that the incremental results would exist, which is just totally
wrong. Added a test for that case as well.

• TestResultServer/model/jsonresults.py:

(JsonResults._merge_tests):

• TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
(JsonResultsTest.test_merge_build_directory_hierarchy):

3:34 PM Changeset in webkit [101108] by thakis@chromium.org

• 2 edits in trunk/Source/WebCore

Remove one static initializer (for kTickTime)
​https://bugs.webkit.org/show_bug.cgi?id=73049

Reviewed by Adam Barth.

• platform/ScrollAnimatorNone.cpp:

3:23 PM Changeset in webkit [101107] by eric@webkit.org

• 9 edits
  2 copies in trunk/Tools

Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=71983

Reviewed by Adam Barth.

We'll add more code to Environment overtime,
allowing us to mock out more of our direct interactions with os.environ.

This patch also makes run_command print the passed in environment.

• Scripts/webkitpy/common/host_mock.py:
• Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/common/system/executive_mock.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/steps/build.py:

3:11 PM Changeset in webkit [101106] by adamk@chromium.org

• 2 edits
  8 moves
  37 adds
  12 deletes in trunk/LayoutTests

More Chromium rebaselines for r101062. Unreviewed gardening.

• platform/chromium-cg-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-linux/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-linux/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-linux/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
• platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Removed.
• platform/chromium-win/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/chromium-win/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png.
• platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt.
• platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png.
• platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt.
• platform/chromium-win/svg/dom/css-transforms-expected.png: Added.
• platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png.
• platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt.
• platform/chromium-win/svg/transforms/svg-css-transforms-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png.
• platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt.
• platform/chromium/test_expectations.txt:

3:04 PM Changeset in webkit [101105] by reed@google.com

• 2 edits in trunk/LayoutTests

[skia] need to rebaseline after SK_ENABLE_FAST_SHADERMASK is enabled in skia/skia.gyp
​https://bugs.webkit.org/show_bug.cgi?id=73044

unreviewed, expectations update

• platform/chromium/test_expectations.txt:

2:48 PM Changeset in webkit [101104] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[chromium] Drop root layer tiles on platforms that cache the front buffer
​https://bugs.webkit.org/show_bug.cgi?id=72956

Patch by Jonathan Backer <​backer@chromium.org> on 2011-11-23
Reviewed by Kenneth Russell.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

2:03 PM Changeset in webkit [101103] by jesus@webkit.org

• 4 edits
  1 move
  1 delete in trunk/Source/WebKit2

[Qt][WK2] Move QQuickWebView::downloadRequested signal into experimental
​https://bugs.webkit.org/show_bug.cgi?id=72914

Reviewed by Andreas Kling.

Make the signal downloadRequested an experimental API from QQuickWebView
and modify the qml test to use a WebView instead of a DesktopWebView.

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml.
• UIProcess/API/qt/tests/qmltests/common/download.html: Removed.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didReceiveDownloadResponse):

2:03 PM Changeset in webkit [101102] by arv@chromium.org

• 12 edits in trunk/Source/WebCore

Binding CodeGenerators don't support Conditional= on constants
​https://bugs.webkit.org/show_bug.cgi?id=67666

Reviewed by Adam Barth.

Adds support for [Conditional=LABEL] to const IDL fields.

• bindings/scripts/CodeGenerator.pm:

(GenerateConditionalStringFromAttributeValue): Moved out of CodeGenerator{CPP,JS,V8}.pm.
(GenerateCompileTimeCheckForEnumsIfNeeded): Wrap in conditional #if.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateConditionalString):
(GenerateHeader): Ditto.
(GenerateImplementation): Ditto.
(GenerateHashTable):
(WriteData):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader): Ditto.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateConditionalString): Ditto.
(GenerateImplementation):
(WriteData):

• bindings/scripts/test/CPP/WebDOMTestObj.h: Generated code now wraps conditional const in #if.
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjCONDITIONAL_CONST): Ditto

• bindings/scripts/test/JS/JSTestObj.h: Ditto
• bindings/scripts/test/ObjC/DOMTestObj.h: Ditto
• bindings/scripts/test/TestObj.idl: Added a conditional const.
• bindings/scripts/test/V8/V8TestObj.cpp: Generated code now wraps conditional const in #if.

1:40 PM Changeset in webkit [101101] by commit-queue@webkit.org

• 8 edits in trunk

[MutationObservers] Modifications to the style property don't dispatch "attributes" Mutation Records
​https://bugs.webkit.org/show_bug.cgi?id=70137

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a private AttributesMutationScope mechanism to CSSMutableStyleDeclaration (which uses
the RAII pattern similar to the public ChildListMutationScope). This manages the (sometimes conditional)
pre-change serialization of the style attribute (if an observer has requested oldValue), creation of
the mutation record, and dispatch if the declaration was actual affected.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
(WebCore::CSSMutableStyleDeclaration::parseDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperties):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::setCssText):
(WebCore::CSSMutableStyleDeclaration::merge):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

• dom/Element.cpp:

(WebCore::Element::setAttribute):

LayoutTests:

Added tests asserting that changes to the style property are observable and work correctly if oldValue is requested.

• fast/mutation/observe-attributes-expected.txt:
• fast/mutation/observe-attributes.html:

12:18 PM Changeset in webkit [101100] by staikos@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
​https://bugs.webkit.org/show_bug.cgi?id=73028

Reviewed by Daniel Bates.

• wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

11:58 AM Changeset in webkit [101099] by dslomov@google.com

• 3 edits in trunk/Source/WebCore

Unreviewed, rebaseline binding tests after ​http://trac.webkit.org/changeset/101064.

• bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::toFloat64Array):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

11:40 AM Changeset in webkit [101098] by adamk@chromium.org

• 1 edit
  1 delete in trunk/LayoutTests

Rebaseline Chromium after r101056. Unreviewed gardening.

• platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Removed.

11:33 AM Changeset in webkit [101097] by eae@chromium.org

• 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp

Initialize Lengths from float css values as opposed to the rounded int values.

11:30 AM Changeset in webkit [101096] by adamk@chromium.org

• 1 edit
  26 adds in trunk/LayoutTests

Chromium rebaselines after r101062. Unreviewed gardening.

• platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-linux-x86/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-linux-x86/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-linux-x86/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-linux/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/chromium-win-vista/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/chromium-win-vista/svg/transforms/svg-css-transforms-expected.txt: Added.
• platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/chromium-win-xp/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/chromium-win-xp/svg/transforms/svg-css-transforms-expected.txt: Added.

11:18 AM Changeset in webkit [101095] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Last rebaseline (really this time) for video-zoom-controls.html.

Unreviewed gardening.

• platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png: Copied by hand from bot's zip file.

11:04 AM Changeset in webkit [101094] by commit-queue@webkit.org

• 11 edits
  2 deletes in trunk

Unreviewed, rolling out r101069.
​http://trac.webkit.org/changeset/101069
​https://bugs.webkit.org/show_bug.cgi?id=73032

New test always times out (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

• http/tests/inspector/compiler-source-mapping-debug-expected.txt: Removed.
• http/tests/inspector/compiler-source-mapping-debug.html: Removed.
• http/tests/inspector/resources/source-map.json:
• http/tests/inspector/resources/source1.js:

(window.onload):

• http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:

10:51 AM Changeset in webkit [101093] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=72271

Unreviewed gardening.

• platform/chromium/test_expectations.txt: Mark fast/dom/node-iterator-reference-node-moved-crash.html as flaky

10:41 AM Changeset in webkit [101092] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test http/tests/loading/307-after-303-after-post.html is flaky on cr-mac
​https://bugs.webkit.org/show_bug.cgi?id=73030

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

10:33 AM Changeset in webkit [101091] by Antti Koivisto

• 3 edits
  2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=72354
Image pointer in FillLayer not cleared correctly

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/css/fill-layer-crash.html

We should clear the image pointer too, not just the m_imageSet bit.

• rendering/style/FillLayer.h:

(WebCore::FillLayer::clearImage):

LayoutTests:

• fast/css/fill-layer-crash-expected.txt: Added.
• fast/css/fill-layer-crash.html: Added.

10:29 AM Changeset in webkit [101090] by reed@google.com

• 2 edits in trunk/LayoutTests

[skia] need rebaselining after skia rev. 2735 lands
​https://bugs.webkit.org/show_bug.cgi?id=73023

unreviewed, expectations update

• platform/chromium/test_expectations.txt:

10:19 AM Changeset in webkit [101089] by vestbo@webkit.org

• 6 edits
  1 move in trunk

[Qt] Re-generate QtWebKit API forwarding headers when API changes

The forwarding headers are generated by syncqt, and syncqt is run by qmake,
so we need sync.profile to live in the same directory as the project file
that will be touched when adding/removing API (api.pri in our case).

Since the WebKit2 APIs live in a separate static library, we have to
add the project file for WebKit2 as a dependency of the api.pri file
as well, so that any changes to the WebKit2 API will still trigger a
run of qmake (and then syncqt).

Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
that the forwarding headers are still generated in the root build dir,
not in the Source dir along with the internal forwarding headers.

Reviewed by Andreas Kling.

10:12 AM Changeset in webkit [101088] by commit-queue@webkit.org

• 19 edits in trunk

Unreviewed, rolling out r101057.
​http://trac.webkit.org/changeset/101057
​https://bugs.webkit.org/show_bug.cgi?id=73027

Broke Chromium Windows build (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-23

Source/WebCore:

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::didCompleteLoad):
(WebCore::HTMLTrackElement::textTrackReadyStateChanged):

• html/HTMLTrackElement.h:
• html/HTMLTrackElement.idl:
• html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):

• html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setReadyState):

• html/TextTrack.h:

(WebCore::TextTrack::readyState):

• html/TextTrack.idl:

LayoutTests:

• media/track/track-add-track-expected.txt:
• media/track/track-add-track.html:
• media/track/track-constants-expected.txt:
• media/track/track-constants.html:
• media/track/track-load-error-readyState-expected.txt:
• media/track/track-load-error-readyState.html:
• media/track/track-load-from-element-readyState-expected.txt:
• media/track/track-load-from-element-readyState.html:
• media/track/track-load-from-src-readyState-expected.txt:
• media/track/track-load-from-src-readyState.html:

9:49 AM Changeset in webkit [101087] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Missing WEBKIT_EXPORT in WebMediaStreamRegistry
​https://bugs.webkit.org/show_bug.cgi?id=73010

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• public/WebMediaStreamRegistry.h:

8:52 AM Changeset in webkit [101086] by caio.oliveira@openbossa.org

• 7 edits
  1 move in trunk/Source/WebKit2

[Qt] [WK2] Expose onNavigationRequested signal instead of expecting a slot be defined from QML
​https://bugs.webkit.org/show_bug.cgi?id=72976

Reviewed by Tor Arne Vestbø.

Expecting slots/methods to be implemented in QML isn't very idiomatic in
comparison with the alternative of having a signal. So we now use a signal
for handling navigation requests, and expose a 'request' object with relevant
metadata. There's also a settable property 'action' used to indicate whether
the navigation should be ignored or trigger a download.

The pattern signal with an object parameter that can keep the reply is common in QML,
and used for example for mouse signals.

• UIProcess/API/qt/qquickwebview.cpp:
• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/QtWebPagePolicyClient.cpp:

(NavigationRequest::NavigationRequest):
(NavigationRequest::url):
(NavigationRequest::button):
(NavigationRequest::modifiers):
(NavigationRequest::action):
(NavigationRequest::setAction):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):

• UIProcess/qt/QtWebPagePolicyClient.h:

8:04 AM Changeset in webkit [101085] by yurys@chromium.org

• 5 edits in trunk/Source/WebCore

2011-11-23 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix. Added missing ENABLE(WORKERS) guards.

• inspector/WorkerConsoleAgent.cpp:
• inspector/WorkerConsoleAgent.h:
• inspector/WorkerRuntimeAgent.cpp:
• inspector/WorkerRuntimeAgent.h:

7:53 AM Changeset in webkit [101084] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip another svg test on GTK showing signed zero issues.

• platform/gtk/Skipped: Skip svg/dom/css-transforms.xhtml.

7:36 AM Changeset in webkit [101083] by Philippe Normand

• 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101060.

• platform/gtk/fast/dom/Window/window-properties-expected.txt:
• platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/gtk/fast/js/global-constructors-expected.txt:

7:33 AM Changeset in webkit [101082] by Philippe Normand

• 3 edits in trunk/Source/WebCore

[GStreamer] improper usage of gst_object_ref_sink
​https://bugs.webkit.org/show_bug.cgi?id=73014

Reviewed by Martin Robinson.

No new tests. Existing tests cover this already.

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef): Ensure this is called with non-floating GstObjects.
(WTF::GstElement): Replace gst_object_ref_sink with
gst_object_ref+gst_object_sink like advised in the GstObject documentation.
(WTF::GstPad): Ditto.

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

7:28 AM Changeset in webkit [101081] by yurys@chromium.org

• 18 edits
  8 copies in trunk/Source/WebCore

Web Inspector: split console agent into worker and page console agents
​https://bugs.webkit.org/show_bug.cgi?id=73019

InspectorConsoleAgent now has two descendants: WorkerConsoleAgent and PageConsoleAgent
which encapsulate functionality specific for the type of inspected instance.

Reviewed by Pavel Feldman.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

• inspector/InspectorConsoleAgent.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InspectorStyleTextEditor.cpp:
• inspector/InspectorStyleTextEditor.h:
• inspector/PageConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.cpp.

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):
(WebCore::PageConsoleAgent::developerExtrasEnabled):

• inspector/PageConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/PageDebuggerAgent.cpp:
• inspector/PageDebuggerAgent.h:
• inspector/PageRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::PageRuntimeAgent::PageRuntimeAgent): PageRuntimeAgent was moved into its own file.
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::scriptStateForFrameId):
(WebCore::PageRuntimeAgent::getDefaultInspectedState):

• inspector/PageRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/WorkerConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::~WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):
(WebCore::WorkerConsoleAgent::developerExtrasEnabled):

• inspector/WorkerConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.
• inspector/WorkerDebuggerAgent.cpp:
• inspector/WorkerDebuggerAgent.h:
• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

• inspector/WorkerInspectorController.h:
• inspector/WorkerRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): WorkerRuntimeAgent was moved into its own file.
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::scriptStateForFrameId):
(WebCore::WorkerRuntimeAgent::getDefaultInspectedState):

• inspector/WorkerRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h.

6:34 AM Changeset in webkit [101080] by apavlov@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: warning icon for unrecognized style rule should have tooltip
​https://bugs.webkit.org/show_bug.cgi?id=50638

Reviewed by Yury Semikhatsky.

• English.lproj/localizedStrings.js: Add new tooltip strings.
• inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.prototype.keySet): Added.

• inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
• inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

6:25 AM Changeset in webkit [101079] by commit-queue@webkit.org

• 4 edits in trunk

[EFL] Add zlib depend when freetype is used.
​https://bugs.webkit.org/show_bug.cgi?id=66365

Unreviewed build fix.

When freetype is enabled, uncompress() function is used by
WOFFFileFormat.cpp. Since zlib is not required by freetype, we need to
add libz as dependency for fix linking issue.

.:

Patch by Halton Huo <​halton.huo@intel.com> on 2011-11-23

• Source/cmake/OptionsEfl.cmake: search for ZLIB

Source/WebCore:

No new test because this change is only to fix linking issue.

Patch by Halton Huo <​halton.huo@intel.com> on 2011-11-23

• PlatformEfl.cmake: add ZLIB as dependency when using freetype

6:23 AM Changeset in webkit [101078] by mihnea@adobe.com

• 10 edits
  3 adds in trunk

CSS Exclusions: parse the shorthand "wrap" property
​https://bugs.webkit.org/show_bug.cgi?id=71905

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/exclusions/wrap-parsing.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

• css/CSSPropertyNames.in:
• css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

• fast/exclusions/script-tests/wrap-parsing.js: Added.
• fast/exclusions/wrap-parsing-expected.txt: Added.
• fast/exclusions/wrap-parsing.html: Added.

6:14 AM Changeset in webkit [101077] by Alexandru Chiculita

• 4 edits
  3 adds in trunk

[CSS Filters] WebKit crashes when changing the filter
​https://bugs.webkit.org/show_bug.cgi?id=72723

Reviewed by Simon Fraser.

Source/WebCore:

There are three things fixed with this patch:

1. The list of effects wasn't cleared when the FilterOperations were changed.
2. The sourceImage was going to be 0, because the m_sourceGraphicBuffer.release()

was also clearing the reference to m_sourceGraphicBuffer. Next time the build() method
was called m_graphicsBufferAttached was set to false, but the m_sourceGraphicBuffer was
not regenerated, because the size was not invalidated.

3. maxEffectRects were not updated when a new list of effects was built.

Test: css3/filters/crash-filter-change.html

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::prepare):

• rendering/FilterEffectRenderer.h:

(WebCore::FilterEffectRenderer::setSourceImageRect):

LayoutTests:

• css3/filters/crash-filter-change-expected.png: Added.
• css3/filters/crash-filter-change-expected.txt: Added.
• css3/filters/crash-filter-change.html: Added.

6:12 AM Changeset in webkit [101076] by jnd@chromium.org

• 4 edits in trunk

Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
​https://bugs.webkit.org/show_bug.cgi?id=72950

Reviewed by Tony Chang.

Tools:

• DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::queueLoadHTMLString):

LayoutTests:

• platform/chromium/test_expectations.txt:

6:09 AM Changeset in webkit [101075] by caryclark@google.com

• 2 edits
  2 deletes in trunk/LayoutTests

Unreviewed rebaselining: update incorrectly generated baseline images
that masked ​http://crbug.com/105025 ('Regression: WebGL content flipped
with use_skia enabled on mac.')

Marking these tests as expected to fail until we fix the underlying bug.

• platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
• platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
• platform/chromium/test_expectations.txt:

5:58 AM Changeset in webkit [101074] by abarth@webkit.org

• 4 edits in trunk/Tools

garden-o-matic should display a message if it can't find results to display
​https://bugs.webkit.org/show_bug.cgi?id=72991

Reviewed by Dimitri Glazkov.

Not all failures (e.g., TIMEOUT) have results that we can display.
This patch adds a short message so that the user can see that we're
done trying to load the results.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

5:45 AM Changeset in webkit [101073] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Skia] fix duplicate symbol ZN7WebCore11BitmapImage16initPlatformDataEv error
​https://bugs.webkit.org/show_bug.cgi?id=72954

Patch by Elliot Poger <​epoger@google.com> on 2011-11-23
Reviewed by Adam Barth.

• WebCore.gyp/WebCore.gyp:

5:38 AM Changeset in webkit [101072] by abarth@webkit.org

• 5 edits in trunk/Tools

garden-o-matic should explain more clearly what the builder lists at the top of the page mean
​https://bugs.webkit.org/show_bug.cgi?id=72992

Reviewed by Dimitri Glazkov.

This patch also prepares us to list other sorts of failures, like
performance and unit test.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

5:20 AM Changeset in webkit [101071] by caio.oliveira@openbossa.org

• 9 edits
  1 move
  1 add in trunk/Source/WebKit2

[Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient
​https://bugs.webkit.org/show_bug.cgi?id=72959

Reviewed by Andreas Kling.

Split PagePolicyClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPagePolicyClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

QtPolicyInterface abstraction was not helping us as much as the separation of
the client code will. It was more useful when we had multiple WebViews.

• Target.pri:
• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(toPolicyAction):
(QQuickWebViewPrivate::navigationPolicyForURL):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/qt/ClientImpl.cpp:
• UIProcess/qt/ClientImpl.h:
• UIProcess/qt/QtWebPagePolicyClient.cpp: Added.

(QtWebPagePolicyClient::QtWebPagePolicyClient):
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQtWebPagePolicyClient):
(toQtMouseButton):
(toQtKeyboardModifiers):
(QtWebPagePolicyClient::decidePolicyForResponse):

• UIProcess/qt/QtWebPagePolicyClient.h: Renamed from Source/WebKit2/UIProcess/qt/QtPolicyInterface.h.
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):

• UIProcess/qt/QtWebPageProxy.h:

5:15 AM Changeset in webkit [101070] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add new Chromium tests to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=72997

Patch by Ryan Sleevi <​rsleevi@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

• TestResultServer/static-dashboards/dashboard_base.js:

():

5:10 AM Changeset in webkit [101069] by podivilov@chromium.org

• 11 edits
  2 adds in trunk

Web Inspector: add integration test for compiler source maps.
​https://bugs.webkit.org/show_bug.cgi?id=72730

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/compiler-source-mapping-debug.html

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

• http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
• http/tests/inspector/compiler-source-mapping-debug.html: Added.
• http/tests/inspector/resources/source-map.json:
• http/tests/inspector/resources/source1.js:
• http/tests/inspector/resources/source2.js:

(ClickHandler.prototype.handle):

5:03 AM Changeset in webkit [101068] by abarth@webkit.org

• 3 edits in trunk/Tools

garden-o-matic should support AUDIO failures
​https://bugs.webkit.org/show_bug.cgi?id=69477

Reviewed by Dimitri Glazkov.

This is a first iteration at supporting AUDIO failures in
garden-o-matic. We'll probably need to iterate a bit when we have a
real audio failure in the tree to play with. For example, we'll
probably want to add and <audio> element to the "Examine" view to hear
the differences, but that all can be done in a subsequent patch.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

4:48 AM Changeset in webkit [101067] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Build fix for GTK+.

• platform/graphics/gtk/DrawingBufferGtk.cpp:

(WebCore::DrawingBuffer::DrawingBuffer): Update signature and ASSERT
for the GTK+ port.

4:19 AM Changeset in webkit [101066] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Remove notifyChange from the public interface of CSSMutableStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=72660

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

No tests needed. This is only a refactor.

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):

• css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::removeProperty):
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):

• css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setContentEditable):

4:16 AM Changeset in webkit [101065] by commit-queue@webkit.org

• 13 edits
  6 adds in trunk

Adding gamepad support
​https://bugs.webkit.org/show_bug.cgi?id=69451

Source/WebCore:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Plumb gamepad data access through platform.

Test: gamepad/gamepad-polling-access.html

• WebCore.gypi:
• page/Navigator.cpp:

(WebCore::Navigator::webkitGamepads):

• page/Navigator.h:
• platform/Gamepads.h: Added.
• platform/chromium/GamepadsChromium.cpp: Added.

(WebCore::sampleGamepads):

• platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add implementation of sampleGamepads in Chromium platform. Retrieves
gamepad data from Chromium port and converts to DOM format, i.e.
GamepadList.

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• src/PlatformSupport.cpp:

(WebCore::PlatformSupport::sampleGamepads):

Tools:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
gamepad data that will be retrieved when JS code pulls via API access.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/chromium/GamepadController.cpp: Added.

(GamepadController::GamepadController):
(GamepadController::bindToJavascript):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):

• DumpRenderTree/chromium/GamepadController.h: Added.
• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

• DumpRenderTree/chromium/TestShell.h:

(TestShell::gamepadController):

LayoutTests:

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• fast/dom/script-tests/prototype-inheritance.js: Exclude

gamepadController from enumeration.

• gamepad/gamepad-polling-access-expected.txt: Added.
• gamepad/gamepad-polling-access.html: Added.

4:06 AM Changeset in webkit [101064] by dslomov@google.com

• 19 edits in trunk/Source

Source/WebCore: Get rid of WebCore dependencies from TypedArray implementation types
​https://bugs.webkit.org/show_bug.cgi?id=72783

Reviewed by David Levin.

Remove WebCore specific logic for neutering Typed Array implementations.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:
• html/canvas/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer):

• html/canvas/ArrayBuffer.h:
• html/canvas/ArrayBufferView.cpp:

(WTF::ArrayBufferView::neuter):

• html/canvas/ArrayBufferView.h:
• html/canvas/DataView.cpp:

(WebCore::DataView::neuter):

• html/canvas/DataView.h:
• html/canvas/Float32Array.h:
• html/canvas/Float64Array.h:
• html/canvas/Int16Array.h:
• html/canvas/Int32Array.h:
• html/canvas/Int8Array.h:
• html/canvas/Uint16Array.h:
• html/canvas/Uint32Array.h:
• html/canvas/Uint8Array.h:

Source/WebKit/chromium: Get rid of WebCore dependencies from TypedArray implementation types
​https://bugs.webkit.org/show_bug.cgi?id=72783
Reviewed by David Levin.

• src/WebArrayBufferView.cpp: WebCore replaced with WTF

3:55 AM Changeset in webkit [101063] by Nikolas Zimmermann

• 1 edit
  1 delete in trunk/LayoutTests

2011-11-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline win results after r101052.

Win/Mac share the same results now, I suspect the same will hold true for gtk/qt/cr.

• platform/win/svg/dom: Removed.
• platform/win/svg/dom/length-list-parser-expected.txt: Removed.

3:34 AM Changeset in webkit [101062] by commit-queue@webkit.org

• 6 edits
  38 adds in trunk

First step towards ​http://webkit.org/b/70025

Allow -webkit-transform to be have effect to SVG elements.
Currently, the CSS transform takes precedence over the SVG transform attribute

Allow SVG elements to be transformed using webkit-transform
​https://bugs.webkit.org/show_bug.cgi?id=71309

Patch by Raul Hudea <​rhudea@adobe.com> on 2011-11-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/clip-path/clip-path-css-transform-1.svg

svg/clip-path/clip-path-css-transform-2.svg
svg/custom/clip-path-with-css-transform-1.svg
svg/custom/clip-path-with-css-transform-2.svg
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-text-css-transform.svg
svg/dom/css-transforms.xhtml
svg/dynamic-updates/SVG-dynamic-css-transform.html
svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html
svg/transforms/svg-css-transforms-clip-path.xhtml
svg/transforms/svg-css-transforms.xhtml

• manual-tests/svg-animation-css-transform.html: Added.
• manual-tests/svg-css-animate-compound.html: Added.
• manual-tests/svg-css-transition-compound.html: Added.
• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::styleWillChange):

Set the updateTransform flag on SVG elements whenever a CSS transform is present on the style

• svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

• svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform):

Use the RenderStyle's transform (if it exists) over the SVG's transform

LayoutTests:

• platform/chromium/test_expectations.txt:
• platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
• platform/mac/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-1-expected.txt: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Added.
• platform/mac/svg/custom/clip-path-with-css-transform-2-expected.txt: Added.
• platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Added.
• platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
• platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Added.
• platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
• platform/mac/svg/dom/css-transforms-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
• platform/mac/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
• platform/mac/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/mac/svg/transforms/svg-css-transforms-expected.txt: Added.
• svg/clip-path/clip-path-css-transform-1.svg: Added.
• svg/clip-path/clip-path-css-transform-2.svg: Added.
• svg/custom/clip-path-with-css-transform-1.svg: Added.
• svg/custom/clip-path-with-css-transform-2.svg: Added.
• svg/custom/pointer-events-image-css-transform.svg: Added.
• svg/custom/pointer-events-text-css-transform.svg: Added.
• svg/dom/css-transforms-expected.txt: Added.
• svg/dom/css-transforms.xhtml: Added.
• svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Added.
• svg/dynamic-updates/SVG-dynamic-css-transform.html: Added.
• svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Added.
• svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html: Added.
• svg/dynamic-updates/script-tests/SVGClipPathElement-css-transform-influences-hitTesting.js: Added.

(executeBackgroundTest):
(executeTest):

• svg/transforms/svg-css-transforms-clip-path.xhtml: Added.
• svg/transforms/svg-css-transforms.xhtml: Added.

2:46 AM Changeset in webkit [101061] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[MutationObservers] Cleanup duplicated code in Element & CharacterData
​https://bugs.webkit.org/show_bug.cgi?id=72986

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-23
Reviewed by Ojan Vafai.

This patch creates a MutationObserverInterestGroup which represents the set
of MutationObservers which should receive all mutations of a given type generated
from a specific node.

No tests needed. This patch is only a refactor.

• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

• dom/ChildListMutationScope.cpp:

(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):

• dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):

• dom/WebKitMutationObserver.cpp:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

• dom/WebKitMutationObserver.h:

(WebCore::MutationObserverInterestGroup::isEmpty):
(WebCore::MutationObserverInterestGroup::hasOldValue):

2:35 AM Changeset in webkit [101060] by Martin Robinson

• 5 edits in trunk

[GTK] Enable WebGL by default
​https://bugs.webkit.org/show_bug.cgi?id=69706

Reviewed by Xan Lopez.

.:

• configure.ac: Enable WebGL by default if the build target is X11.

LayoutTests:

• platform/gtk/Skipped: Skip all WebGL tests until we can ensure they

run properly on the bots.

• platform/platform/gtk-wk2/Skipped: Ditto.

2:10 AM Changeset in webkit [101059] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[chromium] HDC leak in Uniscribe Helper
​https://bugs.webkit.org/show_bug.cgi?id=68598

Patch by Marc-Andre Decoste <​mad@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

For some reason the Script functions on Windows sometimes return
E_PENDING even with a non-NULL DC, so we must handle that case.
Also, we should not use the screen DC to select font since this
refreshes the whole desktop, so I added a cached compatible DC.

Note that this doesn't reproduce with WebKit alone, it only reproduces
within Chrome, so we can't write a WebKit test for it. A chromium
browser test will be added once this change gets rolled in the
chromium DEPS file.

• platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::shape):
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
(WebCore::UniscribeHelper::fillShapes):

• platform/graphics/chromium/UniscribeHelper.h:

2:02 AM Changeset in webkit [101058] by commit-queue@webkit.org

• 5 edits
  5 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding embedding code for GetUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=71678

This patch includes a fix for ​https://bugs.webkit.org/show_bug.cgi?id=72925.

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-23
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

• public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

• public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

• src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

• src/UserMediaClientImpl.h: Added.
• src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator UserMediaRequest*):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

• src/WebViewImpl.h:

1:25 AM Changeset in webkit [101057] by annacc@chromium.org

• 19 edits in trunk

Move readyState from TextTrack to HTMLTrackElement
​https://bugs.webkit.org/show_bug.cgi?id=72553

Reviewed by Eric Carlson.

Source/WebCore:

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement):

Set initial readyState to NONE.

(WebCore::HTMLTrackElement::didCompleteLoad):

Set readyState based on load completed status.

(WebCore::HTMLTrackElement::setReadyState):

This replaces textTrackReadyStateChanged() because only LoadableTextTrack
needs to notify HTMLTrackElement of readyState changes (i.e.
textTrackReadyStateChanged() is no longer required of TextTrackClient).

• html/HTMLTrackElement.h:

ReadyState enum and m_readyState member variable moved from TextTrack.

(WebCore::HTMLTrackElement::readyState):

New: readyState() getter.

• html/HTMLTrackElement.idl:

Add readyState attribute and associated constants.

• html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement.
(WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState

to HTMLTrackElement (it can set it based on loading status).

• html/TextTrack.cpp: Remove readyState from TextTrack.

(WebCore::TextTrack::TextTrack): Ditto.

• html/TextTrack.h: Ditto.
• html/TextTrack.idl: Ditto.

LayoutTests:

• media/track/track-add-track-expected.txt:
• media/track/track-add-track.html:
• media/track/track-constants-expected.txt:
• media/track/track-constants.html:
• media/track/track-load-error-readyState-expected.txt:
• media/track/track-load-error-readyState.html:
• media/track/track-load-from-element-readyState-expected.txt:
• media/track/track-load-from-element-readyState.html:
• media/track/track-load-from-src-readyState-expected.txt:
• media/track/track-load-from-src-readyState.html:

1:22 AM Changeset in webkit [101056] by Nikolas Zimmermann

• 11 edits in trunk

Add flags/precision arguments to String::number(double) to allow fine-grained control over the result string
​https://bugs.webkit.org/show_bug.cgi?id=72793

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

This new code will be used in follow-up patches to replace the String::format("%.2f") usage in
platform/text/TextStream.cpp, and String::format("%.6lg") usage in svg/SVGPathStringBuilder.cpp.

The String::number(double) currently calls String::format("%.6lg") in trunk. In order to replace
this by a variant that properly rounds to six significant figures, JSC code could be refactored.
JSCs Number.toPrecision/toFixed uses wtf/dtoa/double-conversion which provides all features we need,
except truncating trailing zeros, needed to mimic the "g" format, which is either f or e but with
trailing zeros removed, producing shorter results. Changed the default signature to:

"static String number(double, unsigned = ShouldRoundSignificantFigures | ShouldTruncateTrailingZeros, unsigned precision = 6);".

In WebCore we can now replace String::format() calls like this:
String::format("%.2f", f) -> String::number(f, ShouldRoundDecimalPlaces, 2)
String::format("%.6lg", f) -> String::number(f)

The default parameters for precison & flags exactly match the format of the string produced now, except that the result
is rounded according to the rounding mode / formatting mode and precision. This paves the way towards reliable results
in the d="" attribute dumps of SVG paths across platforms. The dtoa rounding code enforces a unique zero, resolving
all 0.0 vs. -0.0 issues currently seen on Windows, and some Gtk/Qt bots.

This patch needs a rebaseline of svg/dom/length-list-parser.html as we don't perfecly mimic the String::format() "lg" mode
result for exponentials, we used to return eg. "e-7" and now return "e-07" - the trailing zero truncation hasn't been
implemented for exponentials, as this really affects only this test and thus wasn't worth the trouble - in contrary the
trailing zero truncation is needed for thousands of other results in "f" notation, and thus needed to match the DRT results.

Here's a performance comparision using a JSC release build and some arbitary numbers:
Converting 123.456 using old approach took 95.527100ms. avg 0.000955ms/call.
Converting 123.456 using new approach took 28.126953ms. avg 0.000281ms/call.

Converting 123 using old approach took 85.411133ms. avg 0.000854ms/call.
Converting 123 using new approach took 24.190186ms. avg 0.000242ms/call.

Converting 0.1 using old approach took 92.622803ms. avg 0.000926ms/call.
Converting 0.1 using new approach took 23.317871ms. avg 0.000233ms/call.

Converting 1/i using old approach took 106.893066ms. avg 0.001069ms/call.
Converting 1/i using new approach took 27.164062ms. avg 0.000272ms/call.

For all numbers I've tested in RoundingSignificantFigures mode and 6 digit precision the speedup was at least 250%.

• JavaScriptCore.exp: Change String::number(double) signature.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Ditto.
• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed): Refactor this into numberToFixedPrecisionString(), move to wtf/dtoa.cpp.
(JSC::numberProtoFuncToPrecision): Ditto, refactor this into numberToFixedWidthString.

• wtf/dtoa.cpp: Moved fixedWidth/Precision helpers into dtoa, extend numberToFixedPrecisionString(). Add a mode which allows to truncate trailing zeros/decimal point.

to make it possible to use them to generate strings that match the output from String::format("%6.lg"), while using our dtoas rounding facilities.

• wtf/dtoa.h:
• wtf/dtoa/utils.h: Expose new helper method, which allows us to truncate the result, before generating the output const char*.

(WTF::double_conversion::StringBuilder::SetPosition):

• wtf/text/WTFString.cpp:

(WTF::String::number): Remove String::format("%6.lg") usage! Switch to rounding to six significant figures, while matching the output of String::format.

• wtf/text/WTFString.h:

LayoutTests:

Rebaseline one test result, after the String::number(double) changes. Trailing zeros are no longer removed
in the exponential form of the string: e-07 is reported instead of e-7 now. It was decided to leave it as-is
and not introduce trailing zero removal for the exponential formatting, as it only affects this test.

I'll rebaseline other platforms once results are available.

• svg/dom/length-list-parser-expected.txt:

1:20 AM Changeset in webkit [101055] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[chromium] Expose showFPSCounter and showPlatformLayerTree in WebLayerTreeView::Settings
​https://bugs.webkit.org/show_bug.cgi?id=72973

Patch by Antoine Labour <​piman@chromium.org> on 2011-11-23
Reviewed by Darin Fisher.

• public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

• src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

1:10 AM Changeset in webkit [101054] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

WTF::String has extra WTF_EXPORT_PRIVATE
​https://bugs.webkit.org/show_bug.cgi?id=72858

Patch by Hajime Morrita <​morrita@chromium.org> on 2011-11-23
Reviewed by Kevin Ollivier.

• wtf/text/WTFString.h:

(WTF::String::String):

1:09 AM Changeset in webkit [101053] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip failing accessibility test on GTK.

• platform/gtk/Skipped: Skip accessibility/multiselect-list-reports-active-option.html

1:08 AM Changeset in webkit [101052] by Patrick Gansterer

• 15 edits
  1 copy
  2 moves
  1 add in trunk

[CMake] Move the top-level logic to the top-level directory.
​https://bugs.webkit.org/show_bug.cgi?id=72685

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-23
Reviewed by Brent Fulgham.

.:

Move most of the top-level code in Source/CMakeLists.txt to
CMakeLists.txt. This allows us to replace some INCLUDE() hacks with
proper ADD_SUBDIRECTORY() calls, and actually moves non-Source related
to a non-Source directory.

• CMakeLists.txt: Copied from Source/CMakeLists.txt.

Source/JavaScriptCore:

• CMakeLists.txt: Point to the right Source/ directory.
• wtf/CMakeLists.txt: Ditto.

Source/WebCore:

No new tests, this is a buildsystem changes.

• CMakeLists.txt: Adjust the Source/ directory.
• PlatformBlackBerry.cmake: Ditto.

Source/WebKit:

• blackberry/CMakeListsBlackBerry.txt: Adjust the Source/ directory.

Source/WebKit2:

• CMakeLists.txt: Adjust Source/ directory.

Tools:

• CMakeLists.txt: Added.
• DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
• EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

• WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.

1:00 AM Changeset in webkit [101051] by Philippe Normand

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 3 new tests.

• platform/gtk/animations/additive-transform-animations-expected.txt: Added.
• platform/gtk/css3/images/cross-fade-overflow-position-expected.txt: Added.
• platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.

12:55 AM Changeset in webkit [101050] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip failing editing/spelling/spellcheck-async.html
test on GTK.

• platform/gtk/Skipped:

12:48 AM Changeset in webkit [101049] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

Documentation fix for load-committed in webkitwebframe
​https://bugs.webkit.org/show_bug.cgi?id=72927

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-23
Reviewed by Martin Robinson.

• webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

12:42 AM Changeset in webkit [101048] by mihnea@adobe.com

• 12 edits
  3 copies
  3 moves in trunk

CSS Exclusions: update the name of the shape CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=71898
Instead of a single wrap-shape property, we have wrap-shape-inside and wrap-shape-outside.

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/exclusions/parsing-wrap-shape-inside.html

fast/exclusions/parsing-wrap-shape-outside.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShape):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

• rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setWrapShapeInside):
(WebCore::InheritedFlags::wrapShapeInside):
(WebCore::InheritedFlags::setWrapShapeOutside):
(WebCore::InheritedFlags::wrapShapeOutside):
(WebCore::InheritedFlags::initialWrapShapeInside):
(WebCore::InheritedFlags::initialWrapShapeOutside):

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

• fast/exclusions/parsing-wrap-shape-inside-expected.txt: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
• fast/exclusions/parsing-wrap-shape-inside.html: Copied from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
• fast/exclusions/parsing-wrap-shape-outside-expected.txt: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape-expected.txt.
• fast/exclusions/parsing-wrap-shape-outside.html: Renamed from LayoutTests/fast/exclusions/parsing-wrap-shape.html.
• fast/exclusions/script-tests/parsing-wrap-shape-inside.js: Copied from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.
• fast/exclusions/script-tests/parsing-wrap-shape-outside.js: Renamed from LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape.js.

12:29 AM Changeset in webkit [101047] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] avoid exception in initExtensions() if elements panel is not present
​https://bugs.webkit.org/show_bug.cgi?id=73007

Reviewed by Yury Semikhatsky.

• inspector/front-end/ExtensionServer.js:

12:26 AM Changeset in webkit [101046] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use new name for pixel config field of GrTextureDesc
​https://bugs.webkit.org/show_bug.cgi?id=72543

Patch by Brian Salomon <​bsalomon@google.com> on 2011-11-23
Reviewed by Stephen White.

Tested by every canvas2d layout test.

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

12:21 AM Changeset in webkit [101045] by eae@chromium.org

• 7 edits in trunk/Source/WebCore

Change remaining scrollTop/Left/Width/Height methods back to int
​https://bugs.webkit.org/show_bug.cgi?id=72771

Reviewed by Eric Seidel.

Change remaining scrollTop/Left/Width/Height, setScrollLeft/Top and
verticalScrollbarWidth, horizontalScrollbarHeight methods back to int as
scrolling will remain int based to line up with device pixels.

No new tests.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):

• rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):
(WebCore::RenderListBox::scrollHeight):
(WebCore::RenderListBox::scrollLeft):
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::scrollTop):
(WebCore::RenderListBox::setScrollTop):

• rendering/RenderListBox.h:
• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):

• rendering/RenderTextControlSingleLine.h:

Nov 22, 2011:

11:12 PM Changeset in webkit [101044] by dpranke@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Roll DEPS to r111325 to fix an issue with the linux build

​https://bugs.webkit.org/show_bug.cgi?id=73004

Unreviewed, build fix.

There appears to be a bug in the Makefile generator for gyp
that is causing make to not rebuild DRT on Linux.

• DEPS:

11:09 PM Changeset in webkit [101043] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt][GTK] editing/spelling/spellcheck-async.html fails
​https://bugs.webkit.org/show_bug.cgi?id=73003

Unreviewed morning gardening.

• platform/qt/Skipped: Skip editing/spelling/spellcheck-async.html.

8:08 PM Changeset in webkit [101042] by yuqiang.xian@intel.com

• 6 edits in trunk/Source/JavaScriptCore

Strength reduction for Mul and Mod operations for known constants in DFG
​https://bugs.webkit.org/show_bug.cgi?id=72878

Reviewed by Filip Pizlo.

Also the code should be commonly shared by both 32_64 and 64.

• dfg/DFGNode.h:

(JSC::DFG::nodeMayOverflow):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::isPowerOfTwo):
(JSC::DFG::logTwo):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

7:30 PM Changeset in webkit [101041] by dbates@webkit.org

• 7 edits
  2 adds in trunk/Source/JavaScriptCore

Add WTF infrastructure for the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=72970

Reviewed by Antonio Gomes.

• wtf/Assertions.cpp: Added BlackBerry-specific logging directive.
• wtf/MathExtras.h:

(abs): Added; stdlib doesn't contain abs() on QNX.

• wtf/Platform.h: Define WTF_PLATFORM_BLACKBERRY and enable some platform features.
• wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator): For the BlackBerry port, we initialize
the bad pseudo random number generator using time(3) before initializing the
Mersenne Twister random number generator.

• wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal): Added.

• wtf/blackberry: Added.
• wtf/blackberry/MainThreadBlackBerry.cpp: Added.

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

• wtf/text/WTFString.h: Added constructor and conversion operator for

BlackBerry WebString string object.

7:16 PM Changeset in webkit [101040] by cevans@google.com

• 2 edits
  3 copies in branches/chromium/912

Merge 100203
BUG=105143
Review URL: ​http://codereview.chromium.org/8673010

7:08 PM Changeset in webkit [101039] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/912

Merge 100677
BUG=100958
Review URL: ​http://codereview.chromium.org/8674006

6:58 PM Changeset in webkit [101038] by alexis.menard@openbossa.org

• 1 edit
  2 deletes in trunk/Source/WebKit2

Unreviewed : remove empty folders related to TouchWebView and DesktopWebView
​https://bugs.webkit.org/show_bug.cgi?id=72985

Patch by Gopal Raghavan <​gopal.1.raghavan@nokia.com> on 2011-11-22

• UIProcess/API/qt/tests/qmltests/DesktopWebView: Removed.
• UIProcess/API/qt/tests/qmltests/TouchWebView: Removed.

6:51 PM Changeset in webkit [101037] by cevans@google.com

• 7 edits
  5 copies in branches/chromium/912

Merge 100630
BUG=101065
Review URL: ​http://codereview.chromium.org/8666016

6:15 PM Changeset in webkit [101036] by adamk@chromium.org

• 2 edits in trunk

Add new WebKit/chromium/dbus directory to .gitignore.

• .gitignore:

6:01 PM Changeset in webkit [101035] by kbr@google.com

• 19 edits in trunk/Source

[chromium] Support Core Animation plugins in compositor
​https://bugs.webkit.org/show_bug.cgi?id=72921

Reviewed by Stephen White.

Source/WebCore:

Added support to PluginLayerChromium and CCPluginLayerImpl for
using an IOSurface as the backing store for a plugin. Added minimal
ARB_texture_rectangle support to Extensions3D.h and a Chromium-
specific extension for binding an IOSurface to a texture.

These changes themselves do not have any effect. A follow-on
Chromium CL will make the switch to this new code path.

Tested manually both with and without the Chromium side changes;
Chromium's DumpRenderTree port does not support Core Animation
plugins. Ran video and Stage3D in Flash, and Unity 3D content, to
verify.

• platform/graphics/Extensions3D.h:
• platform/graphics/chromium/Extensions3DChromium.h:
• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgram):
(WebCore::LayerRendererChromium::pluginLayerTexRectProgramFlip):

• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::getIOSurfaceId):
(WebCore::PluginLayerChromium::pushPropertiesTo):

• platform/graphics/chromium/PluginLayerChromium.h:
• platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexRectFlipAlpha::getShaderString):
(WebCore::FragmentShaderRGBATexRectAlpha::getShaderString):

• platform/graphics/chromium/ShaderChromium.h:
• platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(PluginProgramBinding::TexStretchPluginProgramBinding::set):
(PluginProgramBinding::TexTransformPluginProgramBinding::set):
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
(WebCore::CCPluginLayerImpl::setIOSurfaceProperties):
(WebCore::CCPluginLayerImpl::cleanupResources):

• platform/graphics/chromium/cc/CCPluginLayerImpl.h:

Source/WebKit/chromium:

Added IOSurface support to WebPluginContainer. This code path is
used only on Mac OS X, but is defined in the header on all
platforms for simplicity.

• public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):

• public/WebPluginContainer.h:
• src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):

• src/GraphicsContext3DChromium.cpp:
• src/GraphicsContext3DPrivate.h:
• src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::handleKeyboardEvent):

• src/WebPluginContainerImpl.h:

5:58 PM Changeset in webkit [101034] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/912

Merge 100827
BUG=103921
Review URL: ​http://codereview.chromium.org/8666014

4:44 PM Changeset in webkit [101033] by dcheng@chromium.org

• 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Fix ChangeLog typo in r101031.

4:44 PM Changeset in webkit [101032] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Remove some flaky expectations added by me five months ago.
Unreviewed gardening.

• platform/chromium/test_expectations.txt:

4:39 PM Changeset in webkit [101031] by dcheng@chromium.org

• 11 edits in trunk/Source

[chromium] Fix plumbing for differentiating between clipboard/selection pastes.
​https://bugs.webkit.org/show_bug.cgi?id=72056

Reviewed by ​tony@chromium.org.

Source/WebCore:

Add a buffer parameter when retrieving the clipboard sequence number and fix several call
sites that incorrectly assume use of the standard buffer in pastes.

• platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):

• platform/chromium/ChromiumDataObject.h:
• platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::platformClipboardChanged):

• platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::currentPasteboardBuffer):

• platform/chromium/ClipboardUtilitiesChromium.h:
• platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

• platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add a buffer parameter when retrieving the clipboard sequence number.

• public/WebClipboard.h:

(WebKit::WebClipboard::sequenceNumber):

• src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardSequenceNumber):

4:24 PM Changeset in webkit [101030] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Make two accessibility tests as PASS TIMEOUT on Windows.
Unreviewed gardening.

• platform/chromium/test_expectations.txt:

4:12 PM Changeset in webkit [101029] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

One more video-zoom-controls rebaseline for Linux GPU.

• platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:

3:09 PM Changeset in webkit [101028] by adamk@chromium.org

• 6 edits
  4 copies
  4 moves
  83 adds
  2 deletes in trunk/LayoutTests

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Rebaseline these tests as they should be stable since r99937.

• platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
• platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
• platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png.
• platform/chromium-gpu-cg-mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-gpu-cg-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-linux-x86/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-linux-x86/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-linux/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-linux/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-mac-leopard/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png.
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-win-vista/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-win-vista/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
• platform/chromium-win-xp/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-win-xp/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-win/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
• platform/chromium-win/svg/as-object/embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt.
• platform/chromium/test_expectations.txt:

2:42 PM Changeset in webkit [101027] by adamk@chromium.org

• 10 edits
  2 deletes in trunk/LayoutTests

Layout Test media/video-zoom-controls.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=67913

Rebaseline video-zoom-controls: it had already been
partially-rebaselined for WinXP, so the options were to remove those
baselines and let the test fail as expected, mark it as passing on
only XP, or rebaseline with what seem to be reasonable visual changes
(along with some extra noise in the render tree).

Unreviewed gardening.

• platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
• platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
• platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
• platform/chromium-linux/media/video-zoom-controls-expected.png:
• platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
• platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
• platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Removed.
• platform/chromium-win/media/video-zoom-controls-expected.png:
• platform/chromium-win/media/video-zoom-controls-expected.txt:
• platform/chromium/media/video-zoom-controls-expected.txt:
• platform/chromium/test_expectations.txt:

1:51 PM Changeset in webkit [101026] by adamk@chromium.org

• 5 edits in trunk/LayoutTests

Rebaselines and expectation-removal for now-passing Mac tests.
Unreviewed gardening.

• platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
• platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
• platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
• platform/chromium/test_expectations.txt:

1:41 PM Changeset in webkit [101025] by scheib@chromium.org

• 10 edits
  5 adds in trunk

Pointer Lock: Initial Tests for navigator.webkitPonter
​https://bugs.webkit.org/show_bug.cgi?id=72659

Reviewed by Darin Fisher.

Tools:

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

Enabling PointerLock in TestShell

LayoutTests:

• platform/efl/Skipped:
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:
• pointer-lock/mouse-event-api-expected.txt:
• pointer-lock/mouse-event-api.html:
• pointer-lock/pointer-lock-api-expected.txt:
• pointer-lock/pointer-lock-api.html:

12:39 PM Changeset in webkit [101024] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed gardening, remove expectations for now-passing tests.

• platform/chromium/test_expectations.txt:

12:30 PM Changeset in webkit [101023] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Expand slowness of dispatch-message-string-data.html to debug builds.
Unreviewed gardening.

• platform/chromium/test_expectations.txt:

12:28 PM Changeset in webkit [101022] by adamk@chromium.org

• 2 edits in trunk

Ignore more gyp-generated build files in WTF.gyp.

• .gitignore:

11:45 AM Changeset in webkit [101021] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk/Source/WebKit/chromium

Empty API for web intents
​https://bugs.webkit.org/show_bug.cgi?id=69870

Patch by Greg Billock <​gbillock@google.com> on 2011-11-22
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebIntent.h: Added.
• public/WebIntentServiceInfo.h: Added.
• public/WebFrame.h:
• public/WebFrameClient.h:

11:39 AM Changeset in webkit [101020] by adamk@chromium.org

• 2 edits
  1 move
  3 deletes in trunk/LayoutTests

More rebaselines from Skia roll.
Unreviewed gardening.

• platform/chromium-cg-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
• platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/moving-shadow-on-path-expected.txt.

11:13 AM Changeset in webkit [101019] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Update flakiness dashboard for new Chromium builders and tests
​https://bugs.webkit.org/show_bug.cgi?id=72931

Patch by Ryan Sleevi <​rsleevi@chromium.org> on 2011-11-22
Reviewed by Ojan Vafai.

• TestResultServer/static-dashboards/builders.js:
• TestResultServer/static-dashboards/dashboard_base.js:

11:10 AM Changeset in webkit [101018] by dpranke@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=72972

Add dbus in Chromium as pulled dep and update to HEAD.

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-22
Reviewed by Dirk Pranke.

• DEPS:

11:08 AM Changeset in webkit [101017] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Expand MISSING expectation for form-associated-element-crash3.html.
Unreviewed gardening.

• platform/chromium/test_expectations.txt:

11:02 AM Changeset in webkit [101016] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Mark file-writer-abort.html as flakily crashing on Mac Debug.
Unreviewed gardening.

• platform/chromium/test_expectations.txt:

10:55 AM Changeset in webkit [101015] by adamk@chromium.org

• 2 edits
  7 deletes in trunk/LayoutTests

Mark some tests as passing after Skia roll in ​http://crrev.com/111151.

Unreviewed gardening.

• platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Removed.
• platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Removed.
• platform/chromium/test_expectations.txt:

10:37 AM Changeset in webkit [101014] by caseq@chromium.org

• 3 edits in trunk

Layout Test inspector/extensions/extensions-events.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=72966

Reviewed by Pavel Feldman.

• always bind to {add,remove}EventListener() of event target, not WebInspector.Object

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler):

10:35 AM Changeset in webkit [101013] by commit-queue@webkit.org

• 2 edits in trunk

Fix .dir-locals.el to only apply to specific modes
​https://bugs.webkit.org/show_bug.cgi?id=72963

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-22
Reviewed by Xan Lopez.

• .dir-locals.el: Remove `nil' block, as it was causing

makefile-mode not to insert tabs.

10:33 AM Changeset in webkit [101012] by adamk@chromium.org

• 2 edits in trunk/Source/WebCore

Move splitView.css (added in r100991) to the correct target.

• WebCore.gypi:

10:30 AM Changeset in webkit [101011] by dpranke@chromium.org

• 3 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to r110960 and set the disable_nacl flag.
​https://bugs.webkit.org/show_bug.cgi?id=72911

Unreviewed, build fix.

ppapi starts to depend on the NaCl gyp files as of r109739, so
we need to pass disable_nacl when running gyp to avoid pulling
in too much of NaCl.

• DEPS:
• gyp_webkit:

10:10 AM Changeset in webkit [101010] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test inspector/extensions/extensions-events.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=72966

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

9:55 AM Changeset in webkit [101009] by adamk@chromium.org

• 10 edits
  1 copy
  6 deletes in trunk/LayoutTests

Rebaselines after Skia roll (​http://crrev.com/111151).

Unreviewed gardening.

• platform/chromium-linux-x86/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
• platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
• platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
• platform/chromium-mac-leopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
• platform/chromium-mac-leopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
• platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
• platform/chromium-win-xp/fast/css/shadow-multiple-expected.png:
• platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-win-xp/fast/repaint/moving-shadow-on-path-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt.
• platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
• platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
• platform/chromium-win/fast/css/shadow-multiple-expected.png:
• platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt:
• platform/chromium/test_expectations.txt:

9:42 AM Changeset in webkit [101008] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

CSSProperty: Remove unnecessary operator overloads.
<​http://webkit.org/b/72953>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-22
Reviewed by Antti Koivisto.

• css/CSSProperty.cpp:
• css/CSSProperty.h:

Remove operator= and operator== from CSSProperty. They were neither
implemented correctly nor used anywhere.

9:39 AM Changeset in webkit [101007] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CSSStyleDeclaration: Kill FIXME in setProperty().
<​http://webkit.org/b/72958>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-22
Reviewed by Antonio Gomes.

Remove FIXME about possibly throwing an exception when setProperty()
is called with an invalid property name. CSSOM specifies that the
method should simply return in this case.

Spec: ​http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty

• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::setProperty):

9:03 AM Changeset in webkit [101006] by Adam Roben

• 2 edits in trunk/Tools

Remove some debugging code I accidentally left in r101005

• Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python):

8:52 AM Changeset in webkit [101005] by Adam Roben

• 2 edits in trunk/Tools

Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files

Fixes <​http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
classes/methods in Python source files

Reviewed by Dan Bates.

• Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
or that use python as their interpreter. Modified the code that extracts the interpreter to
ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
scripts.
(get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
for class/def lines and generate ranges based on them.

8:43 AM Changeset in webkit [101004] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

Ensure web process before starting a download
​https://bugs.webkit.org/show_bug.cgi?id=72499

Reviewed by Anders Carlsson.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::download): Call ensureWebProcess().

7:40 AM Changeset in webkit [101003] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebKit2

Unreviewed buildfix after r101001.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend): Use ASSERT_UNUSED instead of ASSERT.

7:39 AM Changeset in webkit [101002] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Source/WebCore: Spellcheck should be able to run asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.

When multiple asynchronous spellchecking are requested, only the first request will be processed.

Test: editing/spelling/spellcheck-async.html

• editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Uses asynchronous spell checker if asynchronous flag is ON.

LayoutTests: Spellcheck should be able to run asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=71991

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-22
Reviewed by Hajime Morita.

Added asynchronouse spell checking tests.
Fixed tests that fails tearing down.

• editing/spelling/script-tests/spellcheck-paste.js: Fixed tearing down.
• editing/spelling/spellcheck-async-expected.txt: Added.
• editing/spelling/spellcheck-async.html: Added.
• editing/spelling/spelling-unified-emulation.html: Fixed tearing down.

7:18 AM Changeset in webkit [101001] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebKit2

cvel Feldman <​pfeldman@google.com>

Not reviewed: moving inspector frontend creation out of assert in WebKit2.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp: (WebKit::WebInspectorClient::openInspectorFrontend):lean

6:43 AM Changeset in webkit [101000] by apavlov@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
​https://bugs.webkit.org/show_bug.cgi?id=72951

Reviewed by Pavel Feldman.

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

6:37 AM Changeset in webkit [100999] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

2011-11-22 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix inspector front-end compilation.

• inspector/front-end/externs.js: (WebInspector.showPanel):

6:35 AM Changeset in webkit [100998] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] fix internactive ui test for scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=72935

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-11-22
Reviewed by Yury Semikhatsky.

• src/js/Tests.js:

(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):

6:26 AM Changeset in webkit [100997] by commit-queue@webkit.org

• 10 edits
  2 copies in trunk/Source/WebCore

Add WebCore platform interface needed by updated MediaStream API design
​https://bugs.webkit.org/show_bug.cgi?id=70895

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2011-11-22
Reviewed by Adam Barth.

This is one in a series of patches that update the MediaStream feature
to use WebCore platform interfaces.

Tests will be provided by ​http://webkit.org/b/56587

• GNUmakefile.list.am:
• WebCore.gypi:
• mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::stopTimerFired):

• mediastream/MediaStream.h:
• mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

• mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::didRemoveRemoteStream):

• mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

• mediastream/UserMediaRequest.h:
• platform/mediastream/MediaStreamCenter.cpp: Added.

(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenter::endLocalMediaStream):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):

• platform/mediastream/MediaStreamCenter.h: Added.

(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):

• platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner):
(WebCore::MediaStreamDescriptor::owner):
(WebCore::MediaStreamDescriptor::setOwner):

6:14 AM Changeset in webkit [100996] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix and unskip loadHtml api test
​https://bugs.webkit.org/show_bug.cgi?id=72916

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2011-11-22
Reviewed by Andreas Kling.

Now that linkHovered events are working again we can fix and unskip this
loadHtml test.

• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:

6:11 AM Changeset in webkit [100995] by pfeldman@chromium.org

• 35 edits in trunk/Source

Web Inspector: remove Inspector::bringToFront from the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=72937

Source/WebCore:

Inspector::bringToFront protocol method is currently used on the backend
in order to reveal the front-end window. We should do that by means of
the inspector client interface instead.

Reviewed by Yury Semikhatsky.

• inspector/Inspector.json:
• inspector/InspectorClient.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::show):

• loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::bringFrontendToFront):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

• src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::bringFrontendToFront):

• src/InspectorClientImpl.h:
• src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::bringFrontendToFront):

• src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::bringFrontendToFront):

• WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::bringFrontendToFront):

• WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):

Source/WebKit/qt:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::bringFrontendToFront):

• WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::bringFrontendToFront):

• WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

Reviewed by Yury Semikhatsky.

• WebCoreSupport/InspectorClientWinCE.cpp:

(WebKit::InspectorClientWinCE::bringFrontendToFront):

• WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

Reviewed by Yury Semikhatsky.

• WebKitSupport/InspectorClientWx.cpp:

(WebCore::InspectorClientWx::bringFrontendToFront):

• WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

Reviewed by Yury Semikhatsky.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):

• WebProcess/WebCoreSupport/WebInspectorClient.h:

5:40 AM Changeset in webkit [100994] by caseq@chromium.org

• 7 edits in trunk/Source/WebCore

Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
​https://bugs.webkit.org/show_bug.cgi?id=72899

Reviewed by Pavel Feldman.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):

• inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.addRevision):

• inspector/front-end/externs.js:

5:38 AM Changeset in webkit [100993] by zoltan@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt] Build fix for MHTML support

• Target.pri: Add missing includepath.

5:38 AM Changeset in webkit [100992] by caio.oliveira@openbossa.org

• 9 edits
  2 adds in trunk/Source/WebKit2

[Qt] [WK2] Move PageLoadClient related code to QtWebPageLoadClient
​https://bugs.webkit.org/show_bug.cgi?id=72928

Reviewed by Andreas Kling.

Split PageLoadClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageLoadClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

• Target.pri:
• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::loadProgress):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/qt/ClientImpl.cpp:
• UIProcess/qt/ClientImpl.h:
• UIProcess/qt/QtWebPageLoadClient.cpp: Added.

(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::didFirstVisuallyNonEmptyLayoutForFrame):
(QtWebPageLoadClient::dispatchLoadSucceeded):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::setLoadProgress):
(toQtWebPageLoadClient):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFinishLoadForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(QtWebPageLoadClient::didStartProgress):
(QtWebPageLoadClient::didChangeProgress):
(QtWebPageLoadClient::didFinishProgress):

• UIProcess/qt/QtWebPageLoadClient.h: Added.

(QtWebPageLoadClient::loadProgress):

• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
(QtWebPageProxy::updateNavigationState):

• UIProcess/qt/QtWebPageProxy.h:

5:24 AM Changeset in webkit [100991] by vsevik@chromium.org

• 27 edits
  2 adds in trunk

Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
​https://bugs.webkit.org/show_bug.cgi?id=72920

Reviewed by Pavel Feldman.

Source/WebCore:

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/compile-front-end.sh:
• inspector/front-end/ApplicationCacheModel.js:
• inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.sidebarResized):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.wasShown):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):

• inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.createSplitView):
(WebInspector.Panel.prototype.createSplitViewWithSidebarTree):
(WebInspector.Panel.prototype.sidebarResized):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.sidebarResized):

• inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.sidebarResized):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.sidebarResized):

• inspector/front-end/SplitView.js: Added.

(WebInspector.SplitView):

• inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.sidebarResized):

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refreshRecords):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/auditsPanel.css:
• inspector/front-end/elementsPanel.css:
• inspector/front-end/inspector.css:

(.sidebar):

• inspector/front-end/inspector.html:
• inspector/front-end/networkLogView.css:
• inspector/front-end/networkPanel.css:

(#network-views):

• inspector/front-end/profilesPanel.css:

(#profile-views):

• inspector/front-end/resourcesPanel.css:
• inspector/front-end/scriptsPanel.css:

(#scripts-split-view):

• inspector/front-end/splitView.css: Added.
• inspector/front-end/timelinePanel.css:

(.timeline .sidebar):
(.timeline-sidebar-background):
(#resources-container-content):

LayoutTests:

• http/tests/inspector/network/network-sidebar-width.html:

5:21 AM Changeset in webkit [100990] by caio.oliveira@openbossa.org

• 9 edits
  2 adds in trunk/Source/WebKit2

[Qt] [WK2] Move PageUIClient related code to QtWebPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=72910

Reviewed by Andreas Kling.

Split PageUIClient related code from QtWebPageProxy/ClientImpl. The new
QtWebPageUIClient registers itself with WKPageRef and it's owned by the
QQuickWebViewPrivate. This is a move to clean up QtWebPageProxy object.

• Target.pri:
• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/qt/ClientImpl.cpp:
• UIProcess/qt/ClientImpl.h:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

• UIProcess/qt/QtWebPageProxy.h:
• UIProcess/qt/QtWebPageUIClient.cpp: Added.

(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::runJavaScriptAlert):
(QtWebPageUIClient::runJavaScriptConfirm):
(QtWebPageUIClient::runJavaScriptPrompt):
(QtWebPageUIClient::runOpenPanel):
(QtWebPageUIClient::setStatusText):
(QtWebPageUIClient::mouseDidMoveOverElement):
(toQtWebPageUIClient):
(createNullWKString):

• UIProcess/qt/QtWebPageUIClient.h: Added.

4:58 AM Changeset in webkit [100989] by kbalazs@webkit.org

• 20 edits in trunk/Source

Unreviewed, rolling out r100988.
​http://trac.webkit.org/changeset/100988
​https://bugs.webkit.org/show_bug.cgi?id=72941

"Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-22

Source/JavaScriptCore:

• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• wtf/ParallelJobs.h:
• wtf/ParallelJobsGeneric.cpp:
• wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

• wtf/Platform.h:

Source/WebCore:

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/arm/FELightingNEON.cpp:
• platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

3:42 AM Changeset in webkit [100988] by kbalazs@webkit.org

• 20 edits in trunk/Source

Enable ParallelJobs by default
​https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

• JavaScriptCore.gypi: Add the files to the build. It was

missing for the gyp build system.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Export symbols.

• wtf/ParallelJobs.h:
• wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

• wtf/ParallelJobsGeneric.h:
• wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

• platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

3:14 AM Changeset in webkit [100987] by apavlov@chromium.org

• 9 edits in trunk

Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
​https://bugs.webkit.org/show_bug.cgi?id=72733

Reviewed by Pavel Feldman.

Source/WebCore:

• inspector/Inspector.json:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getComputedStyleForNode):

• inspector/InspectorCSSAgent.h:
• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::buildArrayForComputedStyle):

• inspector/InspectorStyleSheet.h:
• inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):

LayoutTests:

• inspector/styles/styles-new-API.html:

1:57 AM Changeset in webkit [100986] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r100979.

• platform/gtk/accessibility/name-from-label-expected.txt:

1:52 AM Changeset in webkit [100985] by pfeldman@chromium.org

• 20 edits in trunk/Source

Web Inspector: strip unused InspectorController methods.
​https://bugs.webkit.org/show_bug.cgi?id=72886

Source/WebCore:

This is a follow up to the ​https://bugs.webkit.org/show_bug.cgi?id=63009.
I am now able to remove following InspectorController methods:
::startUserInitiatedProfiling,
::isRecordingUserInitiatedProfile,
::stopUserInitiatedProfiling,
::showAndEnableDebugger,
::debuggerEnabled,
::disableDebugger,
::startTimelineProfiler,
::stopTimelineProfiler,
::timelineProfilerEnabled,
::showConsole.

Reviewed by Yury Semikhatsky.

• WebCore.exp.in:
• WebCore.order:
• inspector/Inspector.json:
• inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::setFrontend):

• inspector/InspectorAgent.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):

• inspector/InspectorController.h:
• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):

• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):

• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::resetState):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):

• inspector/InspectorProfilerAgent.h:
• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

• inspector/InspectorTimelineAgent.h:
• inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):

• inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):
(WebInspector.TimelineManager.prototype.stop):
(WebInspector.TimelineManager.prototype._started):
(WebInspector.TimelineManager.prototype._stopped):

• inspector/front-end/inspector.js:

Source/WebKit/gtk:

Reviewed by Yury Semikhatsky.

• webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):

1:34 AM Changeset in webkit [100984] by nduca@chromium.org

• 16 edits
  1 delete in trunk/Source

[chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
​https://bugs.webkit.org/show_bug.cgi?id=72688

Source/WebCore:

This allows CCInputFilter and CCLayerTreeHostImpl to
perform requestAnimationFrame-style animations. The bulk of
work here is to make the scheduler recover gracefully when you
call setNeedsRedraw inside scheduledActionDraw.

Reviewed by James Robinson.

• WebCore.gypi:
• platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore::CCInputHandlerTarget::CCInputHandlerTarget):
(WebCore::CCInputHandlerTarget::~CCInputHandlerTarget):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
• platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrame):
(WebCore::CCScheduler::processScheduledActions):

• platform/graphics/chromium/cc/CCScheduler.h:
• platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setInsideVSync):
(WebCore::CCSchedulerStateMachine::setOutsideVSync):

• platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
• platform/graphics/chromium/cc/CCScrollController.h: Removed.
• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Reviewed by James Robinson.

• src/WebCompositorImpl.cpp:

(WebCore::CCInputHandler::create):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::willDraw):

• src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

• tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):

• tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

• tests/CCSchedulerTest.cpp:

(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::setScheduler):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::numDraws):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::hasMoreResourceUpdates):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginFrame):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwap):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionUpdateMoreResources):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionCommit):
(WebKitTests::TEST):

1:32 AM Changeset in webkit [100983] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's
keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName().
​https://bugs.webkit.org/show_bug.cgi?id=72850

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2011-11-22
Reviewed by Anders Carlsson.

The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and
windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory.

• Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):

1:19 AM Changeset in webkit [100982] by reni@webkit.org

• 1 edit
  10 adds in trunk/LayoutTests

Unreviewed gardening. Reset test results.

Patch by Feher Zsolt <​feherzs@inf.u-szeged.hu> on 2011-11-22

• platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
• platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Added.
• platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
• platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
• platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
• platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
• platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
• platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
• platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
• platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.

1:18 AM Changeset in webkit [100981] by apavlov@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: Design of the autocomplete suggest
​https://bugs.webkit.org/show_bug.cgi?id=72798

Reviewed by Pavel Feldman.

Implemented a combination of grayed text for the first/only completion and hid
the suggest box for a single suggestion (the grayed text is displayed instead.)
Drive-by fix for the "trailing spaces in the prompt" issue
(got regressed when the suggest box was introduced for the first time.)

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView): Fix the "trailing spaces" issue

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

12:50 AM Changeset in webkit [100980] by reni@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] inspector/extensions/extensions-events.html crashing after r100926
​https://bugs.webkit.org/show_bug.cgi?id=72932

Unreviewed gardening.

• platform/qt/Skipped:

12:30 AM Changeset in webkit [100979] by mario@webkit.org

• 3 edits in trunk/LayoutTests

[GTK] platform/gtk/accessibility/name-from-label.html fails
​https://bugs.webkit.org/show_bug.cgi?id=71665

Reviewed by Philippe Normand.

Fix layout test to properly consider 'form' accessibility objects.

• platform/gtk/Skipped: Unskip name-from-label.html.
• platform/gtk/accessibility/name-from-label.html: Re-write layout test to properly take into account the accessibility hierarchy.

Nov 21, 2011:

7:38 PM Changeset in webkit [100978] by yutak@chromium.org

• 8 edits in trunk

[GTK] Enable WebSocket hybi tests
​https://bugs.webkit.org/show_bug.cgi?id=72870

Reviewed by Xan Lopez.

Source/WebKit/gtk:

Change the settings value through DumpRenderTreeSupportGtk, because we do not
want to expose this as a public API.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled):
Change the value of a flag in WebCore::Settings.

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
Reset the setting value to the default value (true).

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):
Change the setting value through a function in DumpRenderTreeSupportGtk.

LayoutTests:

• platform/gtk/Skipped:

Unskip WebSocket hybi tests. Skip two tests using FileSystem API, which is not yet
supported in GTK port.

7:19 PM Changeset in webkit [100977] by commit-queue@webkit.org

• 5 edits
  5 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r100970.
​http://trac.webkit.org/changeset/100970
​https://bugs.webkit.org/show_bug.cgi?id=72925

Caused AssociatedURLLoaderTest.Success to fail (Requested by
koz on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-21

• WebKit.gyp:
• public/WebUserMediaClient.h: Removed.
• public/WebUserMediaRequest.h: Removed.
• public/WebViewClient.h:
• src/UserMediaClientImpl.cpp: Removed.
• src/UserMediaClientImpl.h: Removed.
• src/WebUserMediaRequest.cpp: Removed.
• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

• src/WebViewImpl.h:

7:15 PM Changeset in webkit [100976] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

REGRESSION(r98542): Chromium: CSS text is rendered on page
​https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-21
Reviewed by Dimitri Glazkov.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

• fast/css/style-tag-display-none-expected.txt: Added.
• fast/css/style-tag-display-none.html: Added.
• fast/css/style-tag-display-none-expected.png: Added.

7:02 PM Changeset in webkit [100975] by fpizlo@apple.com

• 11 edits in trunk

DFG should have richer debug output for CFA and phi processing
​https://bugs.webkit.org/show_bug.cgi?id=72922

Reviewed by Gavin Barraclough.

In the default verbose mode, we now print information about variable
state at the bottom of basic blocks in addition to the top, and we
also print local variable linking. In the verbose propagation mode,
the state of phi processing is dumped more richly and CFA merging (the
most subtle part of CFA) is traced as well.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):

• dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::AbstractValue::dump):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

• dfg/DFGCommon.h:

(JSC::DFG::NodeIndexTraits::dump):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNode.h:

(JSC::DFG::Node::dumpChildren):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOperands.h:

(JSC::DFG::OperandValueTraits::dump):
(JSC::DFG::dumpOperands):

6:59 PM Changeset in webkit [100974] by commit-queue@webkit.org

• 4 edits
  4 adds in trunk

If an event listener is a function, it should be called and not checked for handleEvent.
This also covers callbacks, which follow the same spec but are implemented separately.
​https://bugs.webkit.org/show_bug.cgi?id=62518

Patch by Rob Brackett <​rob@robbrackett.com> on 2011-11-21
Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/events/dispatch-to-function-with-handle-event.html

fast/js/callback-function-with-handle-event.html

• bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

• fast/events/dispatch-to-function-with-handle-event-expected.txt: Added.
• fast/events/dispatch-to-function-with-handle-event.html: Added.
• fast/js/callback-function-with-handle-event-expected.txt: Added.
• fast/js/callback-function-with-handle-event.html: Added.

6:56 PM Changeset in webkit [100973] by fpizlo@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Should have a test for corner cases of DFG's integer optimization and CSE.
​https://bugs.webkit.org/show_bug.cgi?id=72917

Reviewed by Sam Weinig.

• fast/js/dfg-integer-optimization-expected.txt: Added.
• fast/js/dfg-integer-optimization.html: Added.
• fast/js/script-tests/dfg-integer-optimization.js: Added.

(doAdd):

6:15 PM Changeset in webkit [100972] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
​https://bugs.webkit.org/show_bug.cgi?id=71505

Reviewed by Gavin Barraclough.

It turns out that we were corrupting phi nodes in case of overflow. The bug is
really obvious, but producing a test case that causes the badness is hard. Even
when the phi nodes do get corrupt, there's more that has to happen before it
causes incorrect execution - and I wasn't able to reproduce in any kind of
sensible reduced case.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

5:27 PM Changeset in webkit [100971] by leviw@chromium.org

• 4 edits in branches/subpixellayout/Source/WebCore/rendering

Adding pixel snapped methods for clientWidth/Height and moving internal callers to LayoutUnit versions.

5:20 PM Changeset in webkit [100970] by commit-queue@webkit.org

• 5 edits
  5 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API: Adding embedding code for GetUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=71678

Patch by Tommy Widenflycht <​tommyw@google.com> on 2011-11-21
Reviewed by Darin Fisher.

• WebKit.gyp:
• public/WebUserMediaClient.h: Added.

(WebKit::WebUserMediaClient::~WebUserMediaClient):

• public/WebUserMediaRequest.h: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::~WebUserMediaRequest):
(WebKit::WebUserMediaRequest::operator=):
(WebKit::WebUserMediaRequest::isNull):
(WebKit::operator==):

• public/WebViewClient.h:

(WebKit::WebViewClient::userMediaClient):

• src/UserMediaClientImpl.cpp: Added.

(WebKit::UserMediaClientImpl::UserMediaClientImpl):
(WebKit::UserMediaClientImpl::pageDestroyed):
(WebKit::UserMediaClientImpl::requestUserMedia):
(WebKit::UserMediaClientImpl::cancelUserMediaRequest):

• src/UserMediaClientImpl.h: Added.
• src/WebUserMediaRequest.cpp: Added.

(WebKit::WebUserMediaRequest::WebUserMediaRequest):
(WebKit::WebUserMediaRequest::reset):
(WebKit::WebUserMediaRequest::audio):
(WebKit::WebUserMediaRequest::video):
(WebKit::WebUserMediaRequest::cameraPreferenceUser):
(WebKit::WebUserMediaRequest::cameraPreferenceEnvironment):
(WebKit::WebUserMediaRequest::securityOrigin):
(WebKit::WebUserMediaRequest::requestSucceeded):
(WebKit::WebUserMediaRequest::requestFailed):
(WebKit::WebUserMediaRequest::equals):
(WebKit::WebUserMediaRequest::assign):
(WebKit::WebUserMediaRequest::operator PassRefPtr<UserMediaRequest>):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

• src/WebViewImpl.h:

5:01 PM Changeset in webkit [100969] by adamk@chromium.org

• 1 edit
  6 adds in trunk/LayoutTests

cr-linux rebaselines for r100949. Unreviewed gardening.

• platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
• platform/chromium-linux/css2.1/20110323/empty-inline-002-expected.png: Added.
• platform/chromium-linux/css2.1/20110323/empty-inline-003-expected.png: Added.
• platform/chromium-linux/fast/css/empty-inline-003-quirksmode-expected.png: Added.
• platform/chromium-linux/fast/css/empty-inline-line-height-first-line-expected.png: Added.
• platform/chromium-linux/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.

4:25 PM Changeset in webkit [100968] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Rebaseline after r100958. Unreviewed gardening.

• platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:

3:31 PM Changeset in webkit [100967] by adamk@chromium.org

• 3 edits
  1 add
  3 deletes in trunk/LayoutTests

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
​https://bugs.webkit.org/show_bug.cgi?id=72903

Reviewed by James Robinson.

Make this test dumpAsText(true) since what we really care about here is
pixel output.

• compositing/geometry/clipped-video-controller-expected.txt: Added.
• compositing/geometry/clipped-video-controller.html:
• platform/chromium-win/compositing/geometry/clipped-video-controller-expected.txt: Removed.
• platform/chromium/test_expectations.txt:
• platform/efl/compositing/geometry/clipped-video-controller-expected.txt: Removed.
• platform/mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.

3:27 PM Changeset in webkit [100966] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Optimistically remove expectations for a handful of no-longer-failing tests.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [100965] by commit-queue@webkit.org

• 10 edits
  8 adds in trunk

Need support for dirname attribute
​https://bugs.webkit.org/show_bug.cgi?id=65542

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-21
Reviewed by Eric Seidel.

Implemented 'dirname' form attribute.

Source/WebCore:

Tests: fast/forms/form-dirname-attribute.html

fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
fast/forms/submit-form-with-dirname-attribute.html

• html/HTMLAttributeNames.in:

Added "dirname" attribute.

• html/HTMLInputElement.idl:

Add "dirName" property to HTMLInputElement interface.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):
Append dirname form data.

• html/HTMLTextAreaElement.idl:

Add "dirName" property to HTMLTextAreaElement interface.

• html/HTMLTextFormControlElement.cpp:

(WebCore::parentHTMLElement):
Helper function which returns only HTML parent element.
(WebCore::HTMLTextFormControlElement::directionForFormData):
Helper function for finding directionality of the Element.

• html/HTMLTextFormControlElement.h:

Helper function for finding directionality of the Element.

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
Append dirname form data.

• html/TextFieldInputType.h:

Append dirname form data.

LayoutTests:

• fast/forms/form-dirname-attribute-expected.txt: Added.
• fast/forms/form-dirname-attribute.html: Added.
• fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.
• fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.
• fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.
• fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.
• fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.
• fast/forms/submit-form-with-dirname-attribute.html: Added.

3:11 PM Changeset in webkit [100964] by eae@chromium.org

• 27 edits in branches/subpixellayout/Source

Chromium/linux and qt platform fixes

3:09 PM Changeset in webkit [100963] by jamesr@google.com

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix tiler initialization in TiledLayerChromiumTest
​https://bugs.webkit.org/show_bug.cgi?id=72915

Reviewed by Kenneth Russell.

Setting the tile size or tiling option after the tiler is created invalidates it, and by default the newly
created tiler will have border texels so the test doesn't pass. Switch things around in the test so the tiler
is created only after all the options are set, which is closer to what the real code does.

• tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

3:06 PM Changeset in webkit [100962] by adamk@chromium.org

• 7 edits
  3 copies
  15 adds in trunk/LayoutTests

Chromium rebaselines after r100949. Unreviewed.

• platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
• platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
• platform/chromium-cg-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
• platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
• platform/chromium-mac-leopard/css2.1/20110323/empty-inline-002-expected.png: Added.
• platform/chromium-mac-leopard/css2.1/20110323/empty-inline-003-expected.png: Added.
• platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
• platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-001-expected.txt.
• platform/chromium-win/css2.1/20110323/empty-inline-002-expected.png: Added.
• platform/chromium-win/css2.1/20110323/empty-inline-002-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-002-expected.txt.
• platform/chromium-win/css2.1/20110323/empty-inline-003-expected.png: Added.
• platform/chromium-win/css2.1/20110323/empty-inline-003-expected.txt: Copied from LayoutTests/platform/chromium/css2.1/20110323/empty-inline-003-expected.txt.
• platform/chromium-win/fast/css/empty-inline-003-quirksmode-expected.png: Added.
• platform/chromium-win/fast/css/empty-inline-line-height-first-line-expected.png: Added.
• platform/chromium-win/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
• platform/chromium/css2.1/20110323/empty-inline-001-expected.png:
• platform/chromium/css2.1/20110323/empty-inline-001-expected.txt:
• platform/chromium/css2.1/20110323/empty-inline-002-expected.png:
• platform/chromium/css2.1/20110323/empty-inline-002-expected.txt:
• platform/chromium/css2.1/20110323/empty-inline-003-expected.png:
• platform/chromium/css2.1/20110323/empty-inline-003-expected.txt:
• platform/chromium/fast/css/empty-inline-003-quirksmode-expected.png: Added.
• platform/chromium/fast/css/empty-inline-line-height-first-line-expected.png: Added.
• platform/chromium/fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.

3:01 PM Changeset in webkit [100961] by rniwa@webkit.org

• 4 edits in trunk/Tools

ChangeLogEntry should be able to parse entries with multiple authors
​https://bugs.webkit.org/show_bug.cgi?id=72690

Reviewed by Eric Seidel.

Support multi-author change log entries in ChangeLogEntry. Split author names using
the same logic as splitting reviewer names. _authors now stores list of dictionaries
with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
accounts because some contributors are never listed in committers.py.

• Scripts/webkitpy/common/checkout/changelog.py:
• Scripts/webkitpy/common/checkout/changelog_unittest.py:
• Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}

throws an exception when the argument is None.

3:00 PM Changeset in webkit [100960] by jamesr@google.com

• 2 edits in trunk/Source/WebKit/chromium

Fix chromium compile bustage - base interface added a parameter so my fake wasn't actually implementing it.

• tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::prepareToUpdate):

2:34 PM Changeset in webkit [100959] by commit-queue@webkit.org

• 17 edits in trunk/Source/WebCore

IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
​https://bugs.webkit.org/show_bug.cgi?id=72066

Patch by Joshua Bell <​jsbell@chromium.org> on 2011-11-21
Reviewed by Tony Chang.

No new tests; addresses race conditions on document navigate/script context stop.

• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueEvent):

• dom/DocumentEventQueue.h:
• dom/EventQueue.h:
• storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::stop):

• storage/IDBDatabase.h:
• storage/IDBFactory.cpp:

(WebCore::IDBFactory::IDBFactory):
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

• storage/IDBFactory.h:
• storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):

• storage/IDBObjectStore.h:
• storage/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):

• storage/IDBRequest.h:
• storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):

• storage/IDBTransaction.h:
• storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

• workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

• workers/WorkerEventQueue.h:

2:22 PM Changeset in webkit [100958] by jamesr@google.com

• 7 edits
  1 add in trunk/Source

[chromium] Avoid pushing dirty tiles to the impl layer
​https://bugs.webkit.org/show_bug.cgi?id=72765

Reviewed by Kenneth Russell.

Source/WebCore:

If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
decide to update the contents for that tile we can use partial results if they are still valid.

Covered by new unit test in TiledLayerChromiumTest.cpp

• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::createTiler):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):

• platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setTextureFormat):

• platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::hasTileAt):
(WebCore::CCTiledLayerImpl::drawTiles):

• platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add unit test for TiledLayerChromium's tile pushing behavior. Requires a fair amount of fake classes. If these
fakes are useful in other tests, they should be moved to a shared location.

• WebKit.gypi:
• tests/TiledLayerChromiumTest.cpp: Added.

(::FakeTextureAllocator::createTexture):
(::FakeTextureAllocator::deleteTexture):
(::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(::FakeLayerTextureUpdater::orientation):
(::FakeLayerTextureUpdater::sampledTexelFormat):
(::FakeLayerTextureUpdater::prepareToUpdate):
(::FakeLayerTextureUpdater::updateTextureRect):
(::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(::FakeCCTiledLayerImpl::hasTileAt):
(::FakeTiledLayerChromium::FakeTiledLayerChromium):
(::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(::FakeTiledLayerChromium::invalidateRect):
(::FakeTiledLayerChromium::prepareToUpdate):
(::FakeTiledLayerChromium::textureManager):
(::FakeTiledLayerChromium::createTextureUpdater):
(::FakeTiledLayerChromium::textureUpdater):
(::TEST):

2:10 PM Changeset in webkit [100957] by robert@webkit.org

• 1 edit
  12 adds in trunk/LayoutTests

Platform-specific results for r100949

Unreviewed gardening.

• platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Added.
• platform/gtk/css2.1/20110323/empty-inline-002-expected.txt: Added.
• platform/gtk/css2.1/20110323/empty-inline-003-expected.txt: Added.
• platform/gtk/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
• platform/gtk/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
• platform/gtk/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
• platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
• platform/qt/css2.1/20110323/empty-inline-002-expected.txt: Added.
• platform/qt/css2.1/20110323/empty-inline-003-expected.txt: Added.
• platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
• platform/qt/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
• platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.

1:58 PM Changeset in webkit [100956] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/mac

Fix the SnowLeopard build.

• Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was

not yet declared in a public header.

1:45 PM Changeset in webkit [100955] by alexis.menard@openbossa.org

• 6 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
​https://bugs.webkit.org/show_bug.cgi?id=72612

Reviewed by Kenneth Rohde Christiansen.

Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.

• UIProcess/API/qt/qquickwebpage_p.h:
• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::isViewFocused):

1:40 PM Changeset in webkit [100954] by mrowe@apple.com

• 4 edits in trunk/Source/WebKit

<​http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name

Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
File Manager APIs.

Reviewed by Dan Bernstein.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Link against DiskArbitration.framework. It lives in the shared cache

so it should add only negligible launch time overhead.

Source/WebKit/mac:

• Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
the volume name from its description dictionary.

1:32 PM Changeset in webkit [100953] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed gardening, remove expectations for no-longer-flakey media tests.

• platform/chromium/test_expectations.txt:

1:19 PM Changeset in webkit [100952] by Simon Hausmann

• 12 edits
  1 add in trunk

[Qt] Speed up debug builds.
​https://bugs.webkit.org/show_bug.cgi?id=72882

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

• Target.pri: Make BUILDING_JavaScriptCore available earlier, so it can be

used by the build system.

Source/WebCore:

• Target.pri: Make BUILDING_WebCore available earlier, so it can be

used by the build system.

Source/WebKit2:

• Target.pri: Make BUILDING_WebKit2 available, so it can be

used by the build system.

Tools:

Introduce a special type of build that replaces the static jsc/wc/wk2
static libraries with shared libraries, that individually are much faster
to link and don't require relinking into the big library when changing just
one file in one module. It can be enabled with
--qmakearg="CONFIG+=force_static_libs_as_shared"

• qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,

disable symbol visibility, static linkage and enable rpath.

• qmake/mkspecs/features/functions.prf: Add a helper function to determine if

we need to link the convenience libraries together or not and renamed linkStaticLibrary
to just linkLibrary (because linkage is not necessarily static).

• qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also

link against jsc/wc/wk2 when linking app code against QtWebKit.

• qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper

function.

• qmake/mkspecs/features/webcore.prf: Ditto.
• qmake/mkspecs/features/webkit2.prf: Ditto.

1:15 PM Changeset in webkit [100951] by adamk@chromium.org

• 2 edits in trunk/Tools

Update flakiness dashboard linkification regexps for crbug.com/100000 and above
​https://bugs.webkit.org/show_bug.cgi?id=72898

Reviewed by Ojan Vafai.

Also removed a comment that was going to be more trouble to keep up to
date than seemed worthwhile (the code is now the documentation).

• TestResultServer/static-dashboards/flakiness_dashboard.html:

1:06 PM Changeset in webkit [100950] by alexis.menard@openbossa.org

• 3 edits in trunk/Source/WebKit2

[Qt] Remove unnecessary initialize method from QQuickWebView.
​https://bugs.webkit.org/show_bug.cgi?id=72905

Reviewed by Kenneth Rohde Christiansen.

We don't need this level of indirection.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

• UIProcess/API/qt/qquickwebview_p_p.h:

1:06 PM Changeset in webkit [100949] by robert@webkit.org

• 3 edits
  18 adds in trunk

CSS 2.1 failure: empty-inline-003.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=72638

Reviewed by Ryosuke Niwa.

Source/WebCore:

Empty inline elements need to share their inline height with siblings.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
going to affect the line-height.
(WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox

LayoutTests:

• css2.1/20110323/empty-inline-001.htm: Added.
• css2.1/20110323/empty-inline-002.htm: Added.
• css2.1/20110323/empty-inline-003.htm: Added.
• fast/css/empty-inline-003-quirksmode-expected.png: Result can cover all platforms as there is no text apart from the period.
• fast/css/empty-inline-003-quirksmode-expected.txt: ditto
• fast/css/empty-inline-003-quirksmode.htm: empty-inline-003.htm should only pass in strict mode, this ensures it 'fails' in quirks mode.
• fast/css/empty-inline-line-height-first-line-expected.png: Added.
• fast/css/empty-inline-line-height-first-line-expected.txt: Added.
• fast/css/empty-inline-line-height-first-line-quirksmode-expected.png: Added.
• fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Result can cover all platforms as there is no text apart from the period.
• fast/css/empty-inline-line-height-first-line-quirksmode.htm: Like empty-inline-003.htm, empty-inline-line-height-first-line.htm should also fail in quirks mode.
• fast/css/empty-inline-line-height-first-line.htm: Like empty-inline-003.htm but ensures first-line style is respected for line-height in empty elements.
• platform/chromium/css2.1/20110323/empty-inline-001-expected.png: Added.
• platform/chromium/css2.1/20110323/empty-inline-001-expected.txt: Added.
• platform/chromium/css2.1/20110323/empty-inline-002-expected.png: Added.
• platform/chromium/css2.1/20110323/empty-inline-002-expected.txt: Added.
• platform/chromium/css2.1/20110323/empty-inline-003-expected.png: Added.
• platform/chromium/css2.1/20110323/empty-inline-003-expected.txt: Added.

1:04 PM Changeset in webkit [100948] by dmazzoni@google.com

• 6 edits in trunk

[Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
​https://bugs.webkit.org/show_bug.cgi?id=72895

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

• public/WebAccessibilityNotification.h:
• src/AssertMatchingEnums.cpp:
• src/ChromeClientImpl.cpp:

(WebKit::toWebAccessibilityNotification):

Tools:

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

1:01 PM Changeset in webkit [100947] by enne@google.com

• 3 edits in trunk/Source/WebCore

[chromium] Remove incorrect render surface layer list asserts from compositor
​https://bugs.webkit.org/show_bug.cgi?id=72744

Reviewed by James Robinson.

These asserts are incorrect, because it's valid for the default render
surface to be created but to have a root layer that doesn't draw. It
won't get added to the single render surface and it'll have an empty
layer list.

Test: compositor_unittests

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

12:40 PM Changeset in webkit [100946] by andreas.kling@nokia.com

• 3 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r100874.

• WebCoreSupport/EditorClientWinCE.h:
• WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::respondToChangedSelection):

Add WebCore::Frame* parameter to respondToChangedSelection().

12:36 PM Changeset in webkit [100945] by adamk@chromium.org

• 1 edit
  1 move
  1 add in trunk/LayoutTests

Rebaseline font-face-opentype.html on cr-mac-leopard.

Unreviewed gardening.

• platform/chromium-mac-leopard/fast/css/font-face-opentype-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/font-face-opentype-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-opentype-expected.png.

12:34 PM Changeset in webkit [100944] by senorblanco@chromium.org

• 4 edits
  7 adds in trunk/LayoutTests

Unreviewed gardening.

Updated baselines for two SVG tests. These tests have been passing for a while, but the expectations were either stale or completely wrong.

• platform/chromium-cg-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
• platform/chromium-cg-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
• platform/chromium/test_expectations.txt:

12:24 PM Changeset in webkit [100943] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed gardening, broaden expecations for inspector test.

• platform/chromium/test_expectations.txt:

12:05 PM Changeset in webkit [100942] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
​https://bugs.webkit.org/show_bug.cgi?id=72904

Unreviewed gardening, marking test as PASS TEXT.

• platform/chromium/test_expectations.txt:

11:38 AM Changeset in webkit [100941] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Layout Test compositing/geometry/clipped-video-controller.html is flaky on Win/Linux
​https://bugs.webkit.org/show_bug.cgi?id=72903

Unreviewed gardening.

• platform/chromium/test_expectations.txt: Mark as PASS TEXT

11:22 AM Changeset in webkit [100940] by adamk@chromium.org

• 2 edits in trunk

Add GYP-generated WTF.xcodeproj to .gitignore after r100851.

• .gitignore:

11:16 AM Changeset in webkit [100939] by adamk@chromium.org

• 2 edits in trunk/LayoutTests

Layout Test perf/array-push-pop.html is slow
​https://bugs.webkit.org/show_bug.cgi?id=72901

Mark test as SLOW PASS.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

11:09 AM Changeset in webkit [100938] by Philippe Normand

• 2 edits in trunk/Tools

Unreviewed, run-gtk-tests temporary workaround after r98500.

• Scripts/run-gtk-tests: Try to find the build directory like in

build-gtkdoc, until webkit-build-directory --configuration gets fixed.

11:02 AM Changeset in webkit [100937] by steveblock@google.com

• 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
​https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for
inspector/styles/styles-disable-then-change.html.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

10:59 AM Changeset in webkit [100936] by vrk@chromium.org

• 5 edits in trunk/LayoutTests

Use canplay instead of canplaythrough in http/tests/media to prevent timeout
​https://bugs.webkit.org/show_bug.cgi?id=72758

Reviewed by Eric Carlson.

• http/tests/media/video-cookie-expected.txt:
• http/tests/media/video-cookie.html:
• http/tests/media/video-referer-expected.txt:
• http/tests/media/video-referer.html:

10:46 AM Changeset in webkit [100935] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

StyleSheet: Move completeURL() to CSSStyleSheet.
<​http://webkit.org/b/72888>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Since completeURL() is only used on CSSStyleSheets, move it there (and make
it non-virtual) to make StyleSheet a little leaner.

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::completeURL):

• css/CSSStyleSheet.h:
• css/StyleSheet.cpp:
• css/StyleSheet.h:

10:40 AM Changeset in webkit [100934] by kevino@webkit.org

• 2 edits in trunk/Source/WebCore

[wx] Fix image translation calculations.
​https://bugs.webkit.org/show_bug.cgi?id=72892

Reviewed by Kevin Ollivier.

10:35 AM Changeset in webkit [100933] by kevino@webkit.org

• 3 edits in trunk/Source/WebKit/wx

Add wxWebKit APIs for controlling WebKit caching behavior.
​https://bugs.webkit.org/show_bug.cgi?id=72891

Reviewed by Kevin Ollivier.

10:31 AM Changeset in webkit [100932] by kevino@webkit.org

• 6 edits in trunk/Source/WebKit/wx

Add wxWebKit API for retrieving frame and page URLs.
​https://bugs.webkit.org/show_bug.cgi?id=72890

Reviewed by Kevin Ollivier.

10:17 AM Changeset in webkit [100931] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

copyright comment style to C from C++ for gamepad module
​https://bugs.webkit.org/show_bug.cgi?id=72894

Patch by Scott Graham <​scottmg@chromium.org> on 2011-11-21
Reviewed by Sam Weinig.

Just changes comment format, no code/test changes.

• Modules/gamepad/Gamepad.cpp:
• Modules/gamepad/Gamepad.h:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadList.cpp:
• Modules/gamepad/GamepadList.h:
• Modules/gamepad/GamepadList.idl:

9:55 AM Changeset in webkit [100930] by commit-queue@webkit.org

• 23 edits
  2 moves
  5 deletes in trunk/LayoutTests

Consolidate the many copies of Ahem in our tests
​https://bugs.webkit.org/show_bug.cgi?id=72503

Patch by Philip Rogers <​pdr@google.com> on 2011-11-21
Reviewed by Andreas Kling.

• css3/flexbox/flex-align-vertical-writing-mode.html:
• css3/flexbox/flex-align.html:
• fast/css/custom-font-xheight.html:
• fast/css/font-face-download-error.html:
• fast/css/font-face-in-shadow-DOM.html-disabled:
• fast/css/font-face-multiple-faces.html:
• fast/css/font-face-multiple-families.html:
• fast/css/font-face-opentype.html:
• fast/css/font-face-remote.html:
• fast/css/font-face-repeated-url.html:
• fast/css/font-face-unicode-range.html:
• fast/css/font-face-unused-source-loaded.html:
• fast/css/font-face-woff.html:
• fast/css/font-face-zero-hash-key.html:
• fast/css/resources/Ahem.otf: Removed.
• fast/css/resources/Ahem.ttf: Removed.
• fast/css/resources/Ahem.woff: Removed.
• inspector/audits/resources/Ahem.ttf: Removed.
• inspector/extensions/extensions-network-expected.txt:
• inspector/extensions/extensions-network.html:
• inspector/extensions/resources/Ahem.ttf: Removed.
• platform/gtk/fonts/font-face-with-complex-text.html:
• platform/gtk/fonts/resources/Ahem.ttf: Removed.
• platform/gtk/fonts/synthetic-oblique-positioning.html:
• resources/Ahem.otf: Added.
• resources/Ahem.woff: Added.
• webarchive/resources/Ahem.ttf: Removed.
• webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
• webarchive/test-css-url-resources-in-stylesheets.html:
• webarchive/test-css-url-resources-inline-styles-expected.webarchive:
• webarchive/test-css-url-resources-inline-styles.html:

9:50 AM Changeset in webkit [100929] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <​pfeldman@google.com>

Not reviewed: unskip inspector test on chromium.
​https://bugs.webkit.org/show_bug.cgi?id=72887

• platform/chromium/test_expectations.txt:

9:43 AM Changeset in webkit [100928] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <​pfeldman@google.com>

Not reviewed: unskip inspector tests on Qt
​https://bugs.webkit.org/show_bug.cgi?id=70414
​https://bugs.webkit.org/show_bug.cgi?id=70905
​https://bugs.webkit.org/show_bug.cgi?id=72493

• platform/qt/Skipped:

9:40 AM Changeset in webkit [100927] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/chromium

Implement a setter for UnifiedTextCheckerEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=72872

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-21
Reviewed by Darin Fisher.

• public/WebSettings.h:
• src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setUnifiedTextCheckerEnabled): Added.

• src/WebSettingsImpl.h:

9:30 AM Changeset in webkit [100926] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

2011-11-21 Pavel Feldman <​pfeldman@google.com>

Not reviewed: unflake inspector test.

• inspector/extensions/extensions-events.html:

9:24 AM Changeset in webkit [100925] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

JSC/CSSOM: Merge root() for style declaration objects.
<​http://webkit.org/b/72881>

Patch by Andreas Kling <​kling@webkit.org> on 2011-11-21
Reviewed by Antti Koivisto.

Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
removing a duplicated chunk and making it a little easier on the eyes.

• bindings/js/JSDOMBinding.h:

(WebCore::root):

9:18 AM Changeset in webkit [100924] by steveblock@google.com

• 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
​https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectations for
inspector/styles/styles-change-node-while-editing.html and
inspector/styles/styles-disable-inherited.html.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

9:15 AM Changeset in webkit [100923] by jesus@webkit.org

• 6 edits
  2 adds in trunk/Source/WebKit2

[Qt][WK2] Implement loadHtml API for QQuickWebView
​https://bugs.webkit.org/show_bug.cgi?id=72161

Reviewed by Simon Hausmann.

Implement QQuickWebView::loadHtml that calls QtWebPageProxy::loadHTMLString.
This function will use WKPageLoadHTMLString in order to load HTML from a given string.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::loadHtml):

• UIProcess/API/qt/qquickwebview.h:
• UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Added.
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Added.
• UIProcess/API/qt/tests/qmltests/qmltests.pro:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loadHTMLString):

• UIProcess/qt/QtWebPageProxy.h:

9:03 AM Changeset in webkit [100922] by igor.oliveira@openbossa.org

• 11 edits in trunk/Source

[WK2][Qt] Move Accelerated Composite animations to UIProcess

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal

• platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimationsRecursively):

• platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal

• Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

• Shared/WebCoreArgumentCoders.h:
• Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

• Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerAnimation::WebLayerAnimation):

• UIProcess/LayerTreeHostProxy.h:
• UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::didFireViewportUpdateTimer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):

• WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

8:56 AM Changeset in webkit [100921] by andreas.kling@nokia.com

• 4 edits in trunk/LayoutTests

Unreviewed Mac gardening, rebaselining MediaController failures after r100159.

• fast/dom/constructed-objects-prototypes-expected.txt:
• platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

8:48 AM Changeset in webkit [100920] by Csaba Osztrogonác

• 2 edits in trunk

[Qt] [WK2] WebKitTestRunner doesn't build in debug
​https://bugs.webkit.org/show_bug.cgi?id=72827

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-11-21
Reviewed by Andreas Kling.

Add exports to fix WebKitTestRunner debug build.

• Source/qtwebkit-export.map:

8:21 AM Changeset in webkit [100919] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] Add a way to skip unit tests in the bots
​https://bugs.webkit.org/show_bug.cgi?id=72879

Reviewed by Philippe Normand.

Rewrite the script in python to make it easier for everybody to
change it and add support for skipping tests.

• Scripts/run-gtk-tests:

8:19 AM Changeset in webkit [100918] by steveblock@google.com

• 2 edits in trunk/LayoutTests

REGRESSION(r100906): Broke inspector/extensions/extensions-events.html (Requested by steveblock on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=72887

Add a TIMEOUT expectation

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

8:13 AM Changeset in webkit [100917] by caryclark@google.com

• 9 edits
  2 adds in trunk/LayoutTests

Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard.

• platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt:
• platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
• platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png:
• platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
• platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
• platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
• platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
• platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
• platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
• platform/chromium/test_expectations.txt:

7:47 AM Changeset in webkit [100916] by kbalazs@webkit.org

• 20 edits in trunk/Source

Unreviewed, rolling out r100913.
​http://trac.webkit.org/changeset/100913
​https://bugs.webkit.org/show_bug.cgi?id=72885

"Break Windows build" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-21

Source/JavaScriptCore:

• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• wtf/ParallelJobs.h:
• wtf/ParallelJobsGeneric.cpp:
• wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

• wtf/Platform.h:

Source/WebCore:

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/arm/FELightingNEON.cpp:
• platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

7:37 AM Changeset in webkit [100915] by commit-queue@webkit.org

• 7 edits in trunk

[EFL] Add more appcache functions to ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=72143

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Add a few more functions to make it possible to have more control over
the offline web application features.

• ewk/ewk_settings.cpp:

(ewk_settings_application_cache_max_quota_get):
(ewk_settings_application_cache_max_quota_set):
(ewk_settings_application_cache_clear):

• ewk/ewk_settings.h:

Tools:

• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setAppCacheMaximumSize): Use the right
function, this is not related to the memory cache, but rather to the
appcache.

LayoutTests:

LayoutTestController::clearAllApplicationCaches is implemented now.

• platform/efl/Skipped:

7:19 AM Changeset in webkit [100914] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebKit2

Web Inspector: [WebKit2] Do not access InspectorController from the "Develop" menu code.
​https://bugs.webkit.org/show_bug.cgi?id=63009

Reviewed by Yury Semikhatsky.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):

• WebProcess/WebPage/WebInspector.h:

7:16 AM Changeset in webkit [100913] by kbalazs@webkit.org

• 20 edits in trunk/Source

Enable ParallelJobs by default
​https://bugs.webkit.org/show_bug.cgi?id=70032

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard.
Fix build on Windows and Chromium.

• JavaScriptCore.gypi: Add the files to the build. It was

missing for the gyp build system.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Export symbols.

• wtf/ParallelJobs.h:
• wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
Deinline these to avoid exporting a lot of symbols.
These are non-trivial and called only once on a given object
so it doesn't seems to be worthwile to inline them.
Additionally fix a signed-unsigned comparison in the constructor.

• wtf/ParallelJobsGeneric.h:
• wtf/Platform.h:

Source/WebCore:

Covered by existing tests.

According to measurements on Mac and Linux it is a
considerable speedup for SVG on multicore.

Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
by qualifying ParallelJobs with the WTF namespace (otherwise
MSVC believes it belongs to WebCore which is likely a compiler bug).

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::FELighting::platformApplyNeonWorker):

• platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

7:15 AM Changeset in webkit [100912] by Adam Roben

• 3 edits in trunk/Tools

Make NRWT consider all lines of output from parse-malloc-history, not just the first

Fixes <​http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
found" even when there are more than 1 unique leaks

Reviewed by Darin Adler.

• Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
"^{" will be considered to match the beginning of any line, not only the beginning of the
string.}

• Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

(LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
fake output and updated expectations to match.

7:04 AM Changeset in webkit [100911] by pfeldman@chromium.org

• 2 edits
  1 delete in trunk/LayoutTests

2011-11-21 Pavel Feldman <​pfeldman@google.com>

Not reviewed: updating expectations for the inspector console test (Qt -> all).

• inspector/console/console-format-expected.txt:
• platform/qt/inspector/console/console-format-expected.txt: Removed.

6:59 AM Changeset in webkit [100910] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt] Clean up MiniBrowser project file after recent changes
​https://bugs.webkit.org/show_bug.cgi?id=72869

Reviewed by Simon Hausmann.

Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.

• MiniBrowser/qt/MiniBrowser.pro:

6:41 AM Changeset in webkit [100909] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Remove CSSStyleSelector::m_additionalAttributeStyleDecls field
​https://bugs.webkit.org/show_bug.cgi?id=72876

Reviewed by Andreas Kling.

There is no reason for this temporary to be a field.

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

• css/CSSStyleSelector.h:

6:37 AM Changeset in webkit [100908] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js
​https://bugs.webkit.org/show_bug.cgi?id=72877

Reviewed by Yury Semikhatsky.

• inspector/front-end/ScriptsPanel.js:

6:13 AM Changeset in webkit [100907] by steveblock@google.com

• 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
​https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/show-user-agent-styles.html

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

5:37 AM Changeset in webkit [100906] by pfeldman@chromium.org

• 19 edits in trunk/Source/WebCore

Web Inspector: get rid of Panel::reset in the front-end.
​https://bugs.webkit.org/show_bug.cgi?id=72587

I'm slowly getting rid of the Inspector protocol domain. It currently
contains methods that did not find their home in the meaningful domains.
This change removes reset protocol method.

Reviewed by Yury Semikhatsky.

• inspector/Inspector.json:
• inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad):

• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):

• inspector/InspectorDebuggerAgent.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

• inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

• inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerDispatcher.prototype.globalObjectCleared):

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._mainFrameNavigated):

• inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext.prototype.get frameId):

• inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):

• inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):

• inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._frameDetached):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):

• inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):
(WebInspector.WorkerManager.prototype._mainFrameNavigated):

• inspector/front-end/inspector.js:

5:28 AM Changeset in webkit [100905] by caio.oliveira@openbossa.org

• 8 edits in trunk

[Qt] Add WebView.view attached property support for dialogs in QML
​https://bugs.webkit.org/show_bug.cgi?id=72825

Reviewed by Simon Hausmann.

.:

Export QQuickWebViewAttached.

• Source/qtwebkit-export.map:

Source/WebKit2:

When creating new dialogs, fill their WebView.view attached property
with the WebView that's creating them. This follows the same pattern
as QtQuick's ListView, enabling the usage of the same dialog component
for different WebViews.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::setViewInAttachedProperties):
(QQuickWebViewAttached::QQuickWebViewAttached):
(QQuickWebViewAttached::setView):
(QQuickWebView::qmlAttachedProperties):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:
• UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
• UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner::dialog):

5:20 AM Changeset in webkit [100904] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebKit/win

2011-11-21 Pavel Feldman <​pfeldman@google.com>

Not reviewed: an attempt to fix windows build.

• WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): (WebInspector::setJavaScriptProfilingEnabled):

4:54 AM Changeset in webkit [100903] by pfeldman@chromium.org

• 26 edits
  1 add in trunk

Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
​https://bugs.webkit.org/show_bug.cgi?id=62985

Source/WebCore:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

• WebCore.exp.in:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

• inspector/InspectorFrontendClientLocal.h:
• inspector/front-end/InspectorFrontendAPI.js: Added.

(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):

• inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js:

Source/WebKit/mac:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

• WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView:]):

• WebInspector/WebInspector.mm:

(-showWindow):
(-show:):
(-showConsole:):
(-isDebuggingJavaScript):
(-toggleDebuggingJavaScript:):
(-startDebuggingJavaScript:):
(-stopDebuggingJavaScript:):
(-isProfilingJavaScript):
(-toggleProfilingJavaScript:):
(-startProfilingJavaScript:):
(-stopProfilingJavaScript:):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-isTimelineProfilingEnabled):
(-setTimelineProfilingEnabled:):
(-setFrontend:):
(-releaseFrontend):
(-showWindow:):

• WebInspector/WebInspectorFrontend.h:
• WebInspector/WebInspectorFrontend.mm:

(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):

• WebInspector/WebInspectorPrivate.h:

Source/WebKit/win:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

• WebInspector.cpp:

(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):

• WebInspector.h:
• WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

• WebView.h:

LayoutTests:

Reviewed by Yury Semikhatsky.

• http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

4:48 AM Changeset in webkit [100902] by commit-queue@webkit.org

• 1 edit
  1 add in trunk

Add .dir-locals.el file for better Emacs defaults
​https://bugs.webkit.org/show_bug.cgi?id=72483

Patch by Andy Wingo <​wingo@igalia.com> on 2011-11-21
Reviewed by Xan Lopez.

• .dir-locals.el: Set appropriate directory-local variables for Emacs.

4:46 AM Changeset in webkit [100901] by steveblock@google.com

• 2 edits in trunk/LayoutTests

Inspector tests flakily crashing on Linux dbg canary
​https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/styles-cancel-editing.html.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

4:19 AM Changeset in webkit [100900] by apavlov@chromium.org

• 13 edits in trunk

Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
​https://bugs.webkit.org/show_bug.cgi?id=72701

Reviewed by Pavel Feldman.

Source/WebCore:

• inspector/Inspector.json:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):

• inspector/InspectorCSSAgent.h:
• inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

• inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):

• inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._innerUpdate):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

• inspector/styles/get-set-stylesheet-text.html:
• inspector/styles/styles-formatting.html:
• inspector/styles/styles-new-API.html:
• inspector/styles/styles-source-offsets.html:

4:19 AM Changeset in webkit [100899] by noel.gordon@gmail.com

• 2 edits in trunk

Update .gitignore for latest WebKitLibraries
​https://bugs.webkit.org/show_bug.cgi?id=72851

Reviewed by Andreas Kling.

• .gitignore: updates to silence 'git status' about WebKitLibraries files.

4:14 AM Changeset in webkit [100898] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.2 release
​https://bugs.webkit.org/show_bug.cgi?id=72868

Reviewed by Xan Lopez.

.:

• configure.ac: Bumped version number.

Source/WebKit/gtk:

• NEWS: Added release notes for 1.7.2.

4:02 AM Changeset in webkit [100897] by steveblock@google.com

• 2 edits in trunk/LayoutTests

ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for jquery/offset.html.

Unreviewed gardening.

• platform/chromium/test_expectations.txt:

3:11 AM Changeset in webkit [100896] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r100856.
​http://trac.webkit.org/changeset/100856
​https://bugs.webkit.org/show_bug.cgi?id=72867

New test fast/css/style-tag-display-none.html fails on
Chromium (Requested by steveblock on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-21

Source/WebCore:

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

• fast/css/style-tag-display-none-expected.txt: Removed.
• fast/css/style-tag-display-none.html: Removed.

2:29 AM Changeset in webkit [100895] by jochen@chromium.org

• 26 edits
  25 adds in trunk

Implement Meta referrer
​https://bugs.webkit.org/show_bug.cgi?id=72674

Reviewed by Adam Barth.

Source/WebCore:

​http://wiki.whatwg.org/wiki/Meta_referrer

Tests: http/tests/security/referrer-policy-always.html

http/tests/security/referrer-policy-default.html
http/tests/security/referrer-policy-https-always.html
http/tests/security/referrer-policy-https-default.html
http/tests/security/referrer-policy-https-never.html
http/tests/security/referrer-policy-https-origin.html
http/tests/security/referrer-policy-never.html
http/tests/security/referrer-policy-origin.html
http/tests/security/referrer-policy-redirect.html
http/tests/security/referrer-policy-rel-noreferrer.html

• WebCore.exp.in: updated
• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):

• dom/Document.h:

(WebCore::Document::referrerPolicy):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):

• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader):

• page/SecurityPolicy.h:

Source/WebKit/chromium:

• WebKit.gyp:
• public/WebFrame.h:
• public/WebReferrerPolicy.h: Added.
• public/WebSecurityPolicy.h:
• src/AssertMatchingEnums.cpp:
• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::referrerPolicy):
(WebKit::WebFrameImpl::setReferrerForRequest):

• src/WebFrameImpl.h:
• src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::generateReferrerHeader):

Source/WebKit/mac:

• Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

• Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):

Source/WebKit2:

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

LayoutTests:

• http/tests/security/referrer-policy-always-expected.txt: Added.
• http/tests/security/referrer-policy-always.html: Added.
• http/tests/security/referrer-policy-default-expected.txt: Added.
• http/tests/security/referrer-policy-default.html: Added.
• http/tests/security/referrer-policy-https-always-expected.txt: Added.
• http/tests/security/referrer-policy-https-always.html: Added.
• http/tests/security/referrer-policy-https-default-expected.txt: Added.
• http/tests/security/referrer-policy-https-default.html: Added.
• http/tests/security/referrer-policy-https-never-expected.txt: Added.
• http/tests/security/referrer-policy-https-never.html: Added.
• http/tests/security/referrer-policy-https-origin-expected.txt: Added.
• http/tests/security/referrer-policy-https-origin.html: Added.
• http/tests/security/referrer-policy-never-expected.txt: Added.
• http/tests/security/referrer-policy-never.html: Added.
• http/tests/security/referrer-policy-origin-expected.txt: Added.
• http/tests/security/referrer-policy-origin.html: Added.
• http/tests/security/referrer-policy-redirect-expected.txt: Added.
• http/tests/security/referrer-policy-redirect.html: Added.
• http/tests/security/referrer-policy-rel-noreferrer-expected.txt: Added.
• http/tests/security/referrer-policy-rel-noreferrer.html: Added.
• http/tests/security/resources/referrer-policy-log.php: Added.
• http/tests/security/resources/referrer-policy-redirect.html: Added.
• http/tests/security/resources/referrer-policy-start.html: Added.
• http/tests/security/resources/rel-noreferrer.html: Added.

2:22 AM Changeset in webkit [100894] by vsevik@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: ApplicationCache view should show navigator.onLine indicator.
​https://bugs.webkit.org/show_bug.cgi?id=72618

Reviewed by Pavel Feldman.

• inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::enable):

• inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):

• inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.get onLine):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):

• inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):

1:55 AM Changeset in webkit [100893] by Carlos Garcia Campos

• 4 edits in trunk/Source

Unreviewed. Fix make distcheck build.

Source/WebCore:

• GNUmakefile.list.am:

Source/WebKit2:

• GNUmakefile.am:

1:50 AM Changeset in webkit [100892] by dmazzoni@google.com

• 16 edits
  2 adds in trunk

Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
​https://bugs.webkit.org/show_bug.cgi?id=72479

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/multiselect-list-reports-active-option.html

• accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelectedOptionActive):

• accessibility/AccessibilityListBoxOption.h:
• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSelectedOptionActive):

Source/WebKit/chromium:

Test: accessibility/multiselect-list-reports-active-option.html

• public/WebAccessibilityObject.h:
• src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isSelectedOptionActive):

Tools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(getIsSelectedOptionActiveCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/chromium/AccessibilityUIElement.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isSelectedOptionActiveGetterCallback):

• DumpRenderTree/chromium/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isSelectedOptionActive):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

• accessibility/multiselect-list-reports-active-option.html: Added.
• platform/chromium/accessibility/multiselect-list-reports-active-option-expected.txt: Added.

1:42 AM Changeset in webkit [100891] by yutak@chromium.org

• 4 edits in trunk

[Qt] WebSocket close tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=72865

Reviewed by Simon Hausmann.

Source/WebCore:

• platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::close):
Emit didCloseSocketStream() callback even before the connection is established.
Call m_socket->abort() to prevent "connected" signal from firing.

LayoutTests:

• platform/qt/Skipped:

Unskip five WebSocket tests. Remove "failing websocket tests" section,
as there are no tests in this section.

1:20 AM Changeset in webkit [100890] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
​https://bugs.webkit.org/show_bug.cgi?id=72847

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-11-21
Reviewed by Hajime Morita.

Covered by existing test.

• editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

Passes Range to requestCheckingFor instead of Node.

• editing/SpellChecker.cpp: Changed argument type from Node to Range. The corresponding changes are also done in dependent methods.

(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):

Changed argument type from Node to Range.

(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):

• editing/SpellChecker.h:

1:12 AM Changeset in webkit [100889] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
​https://bugs.webkit.org/show_bug.cgi?id=72859

Patch by Takashi Toyoshima <​toyoshim@chromium.org> on 2011-11-21
Reviewed by Eric Seidel.

• Scripts/new-run-webkit-websocketserver:

12:37 AM Changeset in webkit [100888] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Another attempt at a build fix.

• dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):