Timeline



Dec 3, 2011:

10:46 PM Changeset in webkit [101948] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix WebPImageDecoder decoder leak.
https://bugs.webkit.org/show_bug.cgi?id=73756

Reviewed by Andreas Kling.

Delete the m_decoder member in the destructor if needed with WebPIDelete.

No new tests, it's valgrind territory.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::~WEBPImageDecoder):

9:49 PM Changeset in webkit [101947] by scheib@chromium.org
  • 2 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Rebaselined /accessibility/aria-checkbox-sends-notification-expected.txt

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
  • platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium/test_expectations.txt:
9:20 PM Changeset in webkit [101946] by Darin Adler
  • 3 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for ScriptSampleRecordMap
https://bugs.webkit.org/show_bug.cgi?id=73758

Reviewed by Andreas Kling.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::notifyOfScope): Added adoptPtr.
(JSC::SamplingTool::dump): Added get.

  • bytecode/SamplingTool.h: Changed the value type of ScriptSampleRecordMap to be OwnPtr.
9:20 PM Changeset in webkit [101945] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Use HashMap<OwnPtr> for the opaqueJSClassData map
https://bugs.webkit.org/show_bug.cgi?id=73759

Reviewed by Andreas Kling.

  • API/JSClassRef.cpp:

(OpaqueJSClass::contextData): Update types.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData): Add an explicit clear of opaqueJSClassData to keep the
timing the same. If we didn't care about the order of operations, we could remove this, too.

  • runtime/JSGlobalData.h: Use OwnPtr instead of raw pointer for the mapped type in the

opaqueJSClassData map.

9:11 PM Changeset in webkit [101944] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Supressing more failures via test_expectations.txt

  • platform/chromium/test_expectations.txt:

editing/spelling/markers.html, new expectations fail
svg/animations/svginteger-animation-1.html, merging overlapping lines

7:51 PM Changeset in webkit [101943] by kling@webkit.org
  • 8 edits in trunk/Source/WebCore

CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
<http://webkit.org/b/73725>

Reviewed by Darin Adler.

Made StyleSheet::m_parentRule a CSSImportRule* rather than a CSSRule*
and updated getters, setters and constructors accordingly.

There is no change in behavior, this simply enforces the status quo.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::ownerRule):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):

  • css/StyleSheet.h:

(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):

7:45 PM Changeset in webkit [101942] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Change HashMap implementation to use the pass type and peek type from traits for the mapped value
https://bugs.webkit.org/show_bug.cgi?id=72474

Reviewed by Anders Carlsson.

  • wtf/HashMap.h: Added ReferenceTypeMaker struct template. Get PassInType, PassOutType,

and PeekType from the traits of the mapped value instead of hard-coding them here.
Changed inlineAdd to take a reference to the PassInType instead of the PassInType itself,
to accomodate a PassInType that can't be copied. Use the store, peek, and passOut
functions from the traits as well.

  • wtf/HashTraits.h: Updated GenericHashTraits and HashTraits for OwnPtr to include

PassInType, PassOutType, PeekType, store, passOut, and peek. Before this, the file had
an earlier version that was just PassType, PeekType, pass, and peek. Also commented
the HashTraits for RefPtr to foreshadow some work we can do there.

  • wtf/RefPtrHashMap.h: Same changes as HashMap.h.
7:25 PM Changeset in webkit [101941] by Darin Adler
  • 8 edits
    3 adds
    1 delete in trunk/LayoutTests

Update some layout test expected results
https://bugs.webkit.org/show_bug.cgi?id=73755

Reviewed by Sam Weinig.

  • editing/spelling/markers-expected.txt: Added. We just forgot to check this in when the

test was added, and the test is skipped on most platforms so that was not noticed.

  • fast/css/getComputedStyle/computed-style-without-renderer.html: Changed this test to

share the list of properties to skip and the list of hidden properties.

  • fast/css/getComputedStyle/computed-style.html: Ditt.
  • fast/css/getComputedStyle/resources/property-names.js: Added. Besides the structural

change the change is that CSS_GRID_LAYOUT properties are now in the list to skip.

  • platform/mac/accessibility/multiselect-list-reports-active-option-expected.txt: Added.

Shows this test is failing on Mac, even though it is passing on Chromium. That needs a bug report.

  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Updated these results now that we don't use relative positioning for placeholders any more.
The original patch r101742 updated other platforms, including mac-snowleopard, but missed this one.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed. The Mac platform can

share the platform-independent expected results as long as we skip the CSS_GRID_LAYOUT
properties.

  • svg/css/getComputedStyle-basic.xhtml: Updated to skip the same properties that the tests

in fast/css/getComputedStyle skip.

5:22 PM Changeset in webkit [101940] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, revert accidental change from r101932.

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

5:01 PM Changeset in webkit [101939] by mitz@apple.com
  • 4 edits
    1 add in trunk

Source/WebKit/mac: <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
Reviewed by Darin Adler.

  • WebView/WebView.mm:

(-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
a WebCFAutorelease(self). This prevents re-entry into this method due to
the WebView closing and canceling all subresource loads, including the
one we have just removed.

Tools: Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.

(TestWebKitAPI::TEST):

3:55 PM Changeset in webkit [101938] by Darin Adler
  • 1 edit
    11 deletes in trunk/LayoutTests

Removed some obsolete expected result files that should have been removed in r97308 and r101738.

  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.
3:32 PM Changeset in webkit [101937] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Revise ewk_view_fixed_layout_size_set
https://bugs.webkit.org/show_bug.cgi?id=73401

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-12-03
Reviewed by Eric Seidel.

Improve readability and replace forceLayout to setNeedsLayout,
since it sometimes causes double drawing.

  • ewk/ewk_view.cpp:

(ewk_view_fixed_layout_size_set):

3:11 PM Changeset in webkit [101936] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebCore

Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73614

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-03
Reviewed by Eric Seidel.

  • platform/blackberry/CursorBlackBerry.cpp: Added.

(WebCore::AllCursors::AllCursors):
(WebCore::getCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::aliasCursor):
(WebCore::cellCursor):
(WebCore::columnResizeCursor):
(WebCore::contextMenuCursor):
(WebCore::copyCursor):
(WebCore::crossCursor):
(WebCore::eastResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::grabbingCursor):
(WebCore::grabCursor):
(WebCore::handCursor):
(WebCore::helpCursor):
(WebCore::iBeamCursor):
(WebCore::moveCursor):
(WebCore::noDropCursor):
(WebCore::noneCursor):
(WebCore::northEastResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::notAllowedCursor):
(WebCore::pointerCursor):
(WebCore::progressCursor):
(WebCore::rowResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::waitCursor):
(WebCore::westResizeCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):

  • platform/blackberry/DragDataBlackBerry.cpp: Added.

(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsFiles):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asColor):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/blackberry/DragImageBlackBerry.cpp: Added.

(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImage):
(WebCore::deleteDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::scaleDragImage):
(WebCore::dragImageSize):

  • platform/blackberry/EventLoopBlackBerry.cpp: Added.

(WebCore::EventLoop::platformInit):
(WebCore::EventLoop::cycle):

1:53 PM Changeset in webkit [101935] by kling@webkit.org
  • 9 edits in trunk

Cache CSSInitialValue instances per-document.
<http://webkit.org/b/73745>

Reviewed by Oliver Hunt.

Source/WebCore:

Test: http/tests/security/cross-origin-css-primitive.html

Have CSSValuePool manage the caching of CSSInitialValue objects.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):

  • css/CSSValuePool.h:

LayoutTests:

Test that 'initial' and 'inherit' values are cached per-document.

  • http/tests/security/cross-origin-css-primitive-expected.txt:
  • http/tests/security/cross-origin-css-primitive.html:
  • http/tests/security/resources/cross-origin-css-primitive-iframe.html:
1:45 PM Changeset in webkit [101934] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Keep CSSInheritedValue in the CSS value pool.
<http://webkit.org/b/73747>

Reviewed by Antti Koivisto.

We only need one CSSInheritedValue instance per document, so cache it
in CSSValuePool and have the parser create it through there.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createInheritedValue):

  • css/CSSValuePool.h:
12:06 PM Changeset in webkit [101933] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Implement History API FrameLoaderClient methods
https://bugs.webkit.org/show_bug.cgi?id=59017

Patch by Xan Lopez <xlopez@igalia.com> on 2011-12-03
Reviewed by Gustavo Noronha Silva.

Fake the load process when the new HTML5 History APIs are
used. Otherwise the UA does not have a chance of updating the URL
entry, back/forward buttons, etc.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidNavigateWithinPage): fake a
load process.
(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage): call
dispatchDidNavigateWithinPage.
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
ditto.
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage): do
nothing, because push was already called, but note this in a
comment.

  • WebCoreSupport/FrameLoaderClientGtk.h: add the new method.
10:19 AM Changeset in webkit [101932] by kling@webkit.org
  • 14 edits
    2 adds
    2 deletes in trunk/Source/WebCore

Rename CSSPrimitiveValueCache to CSSValuePool.
<http://webkit.org/b/73742>

Reviewed by Antti Koivisto.

CSSPrimitiveValueCache -> CSSValuePool
Document::primitiveValueCache() -> Document::cssValuePool()

This is in preparation for sharing more than just primitive values.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackList):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColor):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):

  • css/CSSParser.h:

(WebCore::CSSParser::cssValuePool):

  • css/CSSValuePool.cpp: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.cpp.

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::~CSSValuePool):
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):

  • css/CSSValuePool.h: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.h.

(WebCore::CSSValuePool::create):
(WebCore::CSSValuePool::createValue):

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • dom/Document.cpp:

(WebCore::Document::cssValuePool):

  • dom/Document.h:
10:17 AM Changeset in webkit [101931] by Philippe Normand
  • 2 edits in trunk/Tools

Another GTK build fix after r101922.

Rubber-stamped by Martin James Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): return value needs to
be a URI.

9:23 AM BuildingGtk edited by mrobinson@webkit.org
(diff)
8:37 AM Changeset in webkit [101930] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Small fix for my previous patch. Do not try to delete a member
of a dictionary that does not exist.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild):

7:55 AM Changeset in webkit [101929] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Fix jhbuild installation for people who have unusual MAKE environment
variables such as 'make -j4' as the jhbuild build does not handle it.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-with-jhbuild:

(install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.

7:39 AM Changeset in webkit [101928] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
when run for the first time.

Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitgtk-libs: Fix first run.
6:07 AM Changeset in webkit [101927] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip new failing tests on GTK.

  • platform/gtk/Skipped: Skip 3 new

http/tests/security/mixedContent failing partly because of bug 73743.

5:55 AM Changeset in webkit [101926] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK build fix after r101922.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Added sentinel in
g_build_filename call.

5:02 AM Changeset in webkit [101925] by Philippe Normand
  • 2 edits in trunk/Tools

GTK API tests build fix. Run the tests inside jhbuild.

Rubber-stamped by Gustavo Noronha Silva.

  • Scripts/run-gtk-tests:

(TestRunner.init):
(TestRunner.run._error_handler):
(TestRunner):
(TestRunner.run):

4:20 AM Changeset in webkit [101924] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Shrink CSSValueList.
<http://webkit.org/b/73732>

Reviewed by Antti Koivisto.

Packed CSSValueList::m_isSpaceSeparated into the CSSValue bit field
and renamed it to m_isSpaceSeparatedValue, shrinking CSSValueList
by one CPU word.

Also renamed CSSValue::m_isImplicit to m_isImplicitInitialValue
for good measure.

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::CSSInitialValue):

  • css/CSSValue.h:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCssText):

  • css/CSSValueList.h:

(WebCore::CSSValueList::isSpaceSeparated):

4:12 AM Changeset in webkit [101923] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Small build fix. Properly specify the path to the locally installed jhbuild.

  • Scripts/update-webkitgtk-libs: Fix jhbuild path.
3:33 AM Changeset in webkit [101922] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67256

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-03
Reviewed by Philippe Normand.

Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
which points to the more generic top-level path of the WebKit checkout. This code is
duplicated between WK1 and WK2 harnesses because we do not currently have a way to
share code here.

If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
location. This will cause the fallback to fail if you build into a non-typical location
or even fake it with a symlink. In this case it's important to use the environment variable.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath): Added.
(initializeFonts): Use the new helper to get the font path.

  • DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource):Use the new helper to normalize
test paths.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):Pass the top-level path of the
checkout instead of passing the font path.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getTopLevelPath): Added this helper.
(WTR::inititializeFontConfigSetting): Use the helper to find the font path.

3:26 AM BuildingGtk edited by kov@webkit.org
(diff)
3:19 AM BuildingGtk edited by mrobinson@webkit.org
Reorganize things (diff)
3:06 AM Changeset in webkit [101921] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101858.

  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
2:39 AM BuildingGtk edited by kov@webkit.org
jhbuild update (diff)
2:29 AM WebKitGtkLayoutTests edited by kov@webkit.org
Document new jhbuild stuff (diff)
2:26 AM Changeset in webkit [101920] by Philippe Normand
  • 7 edits in trunk

[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=66968

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,

it wasn't suited for GTK in the first place anyway.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.

Source/WebKit/gtk:

If the element being fullscreened is a video use the native
fullscreen controls.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

  • platform/gtk/Skipped: Skip

fullscreen/video-controls-override.html now failing because of bug 73583.

1:44 AM Changeset in webkit [101919] by alex
  • 2 edits in trunk/Source/WebCore

2011-12-03 Alejandro G. Castro <alex@igalia.com>

[GTK] TextureMapperNode should not use Qt types and functions
https://bugs.webkit.org/show_bug.cgi?id=73713

Replace qreal with double and qMin with min.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction):
1:36 AM Changeset in webkit [101918] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/css/font-face-opentype-expected.png: Updated.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated.
1:22 AM Changeset in webkit [101917] by mrobinson@webkit.org
  • 6 edits in trunk

.: [GTK] Update required libsoup version
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • configure.ac: require libsoup 2.37.2.1 for SoupRequestHTTP API

changes

Source/WebCore: [GTK] Remove lots of code that is now unnecessary after
SoupRequestHTTP API changes.
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): remove
no-longer-needed fields.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::finishedCallback): remove this, and m_finished, which
we no longer need to explicitly track
(WebCore::statusWillBeHandledBySoup):
(WebCore::soupErrorShouldCauseLoadFailure): No longer needed;
SoupRequestHTTP's logic is now aligned with WebKit's.
(WebCore::gotChunkCallback): remove gotChunkCallback, which
is no longer needed
(WebCore::startHTTPRequest):
(WebCore::sendRequestCallback):
(WebCore::gotHeadersCallback):
(WebCore::contentSniffedCallback): merge the code from
gotHeadersCallback and contentSniffedCallback into
sendRequestCallback

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): move the
sniffing override logic here

1:19 AM Changeset in webkit [101916] by mrobinson@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

[GTK] [EFL] Update some cookie-related tests
https://bugs.webkit.org/show_bug.cgi?id=73673

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

  • platform/efl/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:
  • platform/gtk/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:

Copied from platform/chromium because libsoup also follows the RFC
6265 behavior.

  • platform/efl/Skipped:
  • platform/gtk/Skipped: Unskip that, and another cookie test that

has been fixed for a while.

1:06 AM Changeset in webkit [101915] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r101904.
http://trac.webkit.org/changeset/101904
https://bugs.webkit.org/show_bug.cgi?id=73739

It broke zillions of tests on all bot (Requested by
Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-03

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:

Dec 2, 2011:

11:22 PM Changeset in webkit [101914] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=73651

Reviewed by Darin Adler.

The code in CodeGenerator*.pm to build a method argument string is really dirty
and error-prone. It is building an argument string incrementally judging whether
", " is necessary or not, like this:

my $method = ... ? "func(" : "func(a";
if (...) {

$method .= $method =~ /\($/ ? "b" : ", b";

}
$method .= ")";

Alternatively, we can refactor the code as follows:

my $funcName = "func";
my @arguments;
push(@arguments, "a") if (...);
push(@arguments, "b") if (...);
my $method = $funcName . "(" . join(", ", @arguments) . ")";

This patch just refactors the code, and generated .h and .cpp files should be
exactly the same as the current .h and .cpp files.

Tests: bindings/scripts/test/*

  • bindings/scripts/CodeGenerator.pm:

(GetterExpression):
(SetterExpression):

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

():

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

11:06 PM Changeset in webkit [101913] by levin@chromium.org
  • 12 edits
    2 moves
    4 adds
    4 deletes in trunk

Rename WTF class from TemporarilyChange to TemporaryChange.
https://bugs.webkit.org/show_bug.cgi?id=73479

Reviewed by Eric Seidel.

Source/JavaScriptCore:

(WTF::TemporaryChange::TemporaryChange):
(WTF::TemporaryChange::~TemporaryChange):

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.
  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::autoSizeIfEnabled):

Source/WebKit/mac:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • ForwardingHeaders/wtf/TemporaryChange.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  • DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
10:56 PM Changeset in webkit [101912] by scheib@chromium.org
  • 2 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r101906.
http://trac.webkit.org/changeset/101906
https://bugs.webkit.org/show_bug.cgi?id=73736

Failing chromium webkit_unit_tests (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Removed.
  • tests/data/event_target.html: Removed.
10:47 PM Changeset in webkit [101911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT fails in updateState ACTION_DRAW case
https://bugs.webkit.org/show_bug.cgi?id=73351

Patch by Armand Navabi <armand.navabi@gmail.com> on 2011-12-02
Reviewed by James Robinson.

Changed ASSERT in CCSchedulerStateMachine to include (
!m_visible) as discussed in bug

report. m_commitState is set to COMMIT_STATE_WAITING_FOR_FIRST_DRAW if m_needsCommit or
!m_visible, so in ACTION_DRAW the assert should have both conditions.

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::updateState):

10:31 PM Changeset in webkit [101910] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

REGRESSION (r99754): All layout tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=72305

Reviewed by Geoffrey Garen.

Fixes a crash in release builds on Windows. Windows was optimizing the out-of-line virtual destructor in
JSFunction away, which left it with no virtual functions. Its vtable ptr was then identical to that of
a different class, therefore the optimization in the visitChildren helper function in MarkedStack.cpp was calling an
incorrect version of visitChildren on the object, which left its children unmarked, causing them to be
collected when they were still reachable.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::vtableAnchor): Add a virtual function to JSFunction that Visual Studio can't optimize away.

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs): Add checks to make sure that all virtual pointers that we rely on for optimization
purposes are distinct from one another.

10:21 PM Changeset in webkit [101909] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

remove a stale comment in flexbox code
https://bugs.webkit.org/show_bug.cgi?id=73720

Reviewed by Ojan Vafai.

This was fixed by Ojan in https://bugs.webkit.org/show_bug.cgi?id=70754.

  • css3/flexbox/flex-flow-padding.html:
10:14 PM Changeset in webkit [101908] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[chromium] Scissor rect optimization for chromium compositor
https://bugs.webkit.org/show_bug.cgi?id=67341

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Mostly covered by damage tracker tests. Currently this relies on
manually running layout tests, because this patch requires partial
swaps that are not supported by DumpRenderTree. The feature
automatically disables if partial swap is not supported.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::trackDamageForAllSurfaces):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):

  • platform/graphics/chromium/cc/CCRenderSurface.h:
10:06 PM Changeset in webkit [101907] by tony@chromium.org
  • 7 edits in trunk/Tools

[NRWT] reftest asserts intermittently on the Qt-WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=73453

Reviewed by Ryosuke Niwa.

We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
The verbose output will include the failure reason.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
  • Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated

(determine_result_type):
(FailureReftestNoImagesGenerated.init):
(FailureReftestNoImagesGenerated):
(FailureReftestNoImagesGenerated.message):

  • Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):

9:56 PM Changeset in webkit [101906] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

Add a unit test for creating, listening for, and dispatching events
via the chromium API.
https://bugs.webkit.org/show_bug.cgi?id=72988

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Added.

(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::TEST_F):

9:51 PM Changeset in webkit [101905] by Nate Chapin
  • 3 edits in trunk/Source/WebKit/chromium

Don't call FocusController:setActive() in
WebViewImpl::setFocus(), since being active and
being focused are different concepts and chromium
now properly sends setActive IPCs on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=73687

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/WebViewTest.cpp: Test how different combinations of

setIsActive() and setFocus() affect whether the document
has focus.

9:40 PM Changeset in webkit [101904] by dslomov@google.com
  • 4 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.

Reviewed by Geoffrey Garen.

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

LayoutTests:

  • fast/dom/Window/window-postmessage-args-expected.txt:
9:34 PM Changeset in webkit [101903] by commit-queue@webkit.org
  • 5 edits
    6 adds
    2 deletes in trunk

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch
9:26 PM Changeset in webkit [101902] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] MiniBrowser --touch asserts in debug build
https://bugs.webkit.org/show_bug.cgi?id=73697

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-02
Reviewed by Eric Seidel.

Add missing guard to QtViewportInteractionEngine::itemSizeChanged().

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

8:59 PM Changeset in webkit [101901] by rniwa@webkit.org
  • 6 edits in trunk/Tools

ChangeLog should be able to parse annotated changelogs
https://bugs.webkit.org/show_bug.cgi?id=72703

Reviewed by Eric Seidel.

Make parse_entries_from_file aware of svn blame annotation such as "100000 Csaba Osztrogonác ",
and extract the revision number for each entry.

Also add a support to extract "svn blame" result from svn/git checkout to scm classes.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
8:54 PM Changeset in webkit [101900] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] test_expectations typo fix for chunked-progress-event-expectedLength.html

  • platform/chromium/test_expectations.txt:
8:46 PM Changeset in webkit [101899] by mihnea@adobe.com
  • 21 edits in trunk

[CSSRegions]More renaming for region style rules.
https://bugs.webkit.org/show_bug.cgi?id=73526

Reviewed by Eric Seidel.

Source/WebCore:

Rename isRegionStyleRule() -> isRegionRule()
WEBKIT_REGION_STYLE_RULE -> WEBKIT_REGION_RULE.

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createRegionRule):

  • css/CSSParser.h:
  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):
(WebCore::CSSRule::destroy):

  • css/CSSRule.h:

(WebCore::CSSRule::isRegionRule):

  • css/CSSRule.idl:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):

  • css/tokenizer.flex:

LayoutTests:

Rename WEBKIT_REGION_STYLE_RULE -> WEBKIT_REGION_RULE.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/regions/parsing-region-style-rule.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
8:06 PM Changeset in webkit [101898] by tsepez@chromium.org
  • 5 edits in trunk

XSSAuditor includes more terminating characters when truncating
attribute values.
https://bugs.webkit.org/show_bug.cgi?id=73684

Reviewed by Daniel Bates.

Source/WebCore:

  • html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

LayoutTests:

  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment.html:
7:50 PM Changeset in webkit [101897] by tony@chromium.org
  • 18 edits in trunk

Need to implement flex-flow: column-reverse
https://bugs.webkit.org/show_bug.cgi?id=73504

Reviewed by David Hyatt.

Source/WebCore:

We can't just change the direction of the FlexOrderIterator because we want the overflow to be
on the top. We can't just position them in the reverse location since we don't know where the
bottom edge is until we've layed out the flex items. So we do an extra pass, but it should be
fast since we're not laying out, just moving.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareBorderEnd):
(WebCore::RenderFlexibleBox::flowAwarePaddingEnd):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse): Do an extra pass to reposition flexitems in the reverse order.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Enable testing of column-reverse.

  • css3/flexbox/flex-flow-expected.txt:
  • css3/flexbox/flex-flow.html: Added test cases to make sure start and end still apply to the text flow direction.
  • css3/flexbox/flex-flow-border-expected.txt:
  • css3/flexbox/flex-flow-border.html: Single flexitem, so reverse does nothing.
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt:
  • css3/flexbox/flex-flow-margins-auto-size.html: Ditto. The vertical tests cases (orthogonal directions) have always failed.
  • css3/flexbox/flex-flow-margins-expected.txt:
  • css3/flexbox/flex-flow-margins.html: Ditto.
  • css3/flexbox/flex-flow-orientations-expected.txt:
  • css3/flexbox/flex-flow-orientations.html: This test has 2 flexitems, the positions of which are now flipped.
  • css3/flexbox/flex-flow-overflow-expected.txt:
  • css3/flexbox/flex-flow-overflow.html: The overflow should go in the opposite direction vertically, but the same direction horizontally.
  • css3/flexbox/flex-flow-padding-expected.txt:
  • css3/flexbox/flex-flow-padding.html: Single flexitem, no change.
7:13 PM Changeset in webkit [101896] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit/chromium

Add WebArrayBuffer to chromium API
https://bugs.webkit.org/show_bug.cgi?id=73593

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebArrayBuffer.h: Added.

(WebKit::WebArrayBuffer::~WebArrayBuffer):
(WebKit::WebArrayBuffer::WebArrayBuffer):
(WebKit::WebArrayBuffer::operator=):
(WebKit::WebArrayBuffer::isNull):

  • public/WebBindings.h:
  • src/WebArrayBuffer.cpp: Added.

(WebKit::WebArrayBuffer::create):
(WebKit::WebArrayBuffer::reset):
(WebKit::WebArrayBuffer::assign):
(WebKit::WebArrayBuffer::data):
(WebKit::WebArrayBuffer::byteLength):
(WebKit::WebArrayBuffer::toV8Value):
(WebKit::WebArrayBuffer::WebArrayBuffer):
(WebKit::WebArrayBuffer::operator=):
(WebKit::WebArrayBuffer::operator WTF::PassRefPtr<WTF::ArrayBuffer>):

  • src/WebBindings.cpp:

(WebKit::getArrayBufferImpl):
(WebKit::WebBindings::getArrayBuffer):

7:12 PM Changeset in webkit [101895] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Divide by zero for zero-length arcs
https://bugs.webkit.org/show_bug.cgi?id=73021

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Nikolas Zimmermann.

A zero-length path produces divide by zero, resulting in nothing being
drawn. This change modifies the behavior to produce a zero-length line
which will generate correct linecaps.

Test: svg/stroke/zero-length-arc-linecaps-rendering.svg

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::parseArcToSegment): Catch the case of
zero-length arcs and convert them to lines (the same as would happen
for zero arc radii).

LayoutTests:

A zero-length path produces divide by zero, resulting in nothing being
drawn. This change modifies the behavior to produce a zero-length line
which will generate correct linecaps.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Nikolas Zimmermann.

  • platform/chromium/test_expectations.txt: Added flakiness for the new test until wehave expectations.
  • platform/mac/svg/stroke: Added.
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
  • svg/stroke/zero-length-arc-linecaps-rendering.svg: Added.
6:43 PM Changeset in webkit [101894] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

-Implement the SSE optimization for vsmul and vadd.
https://bugs.webkit.org/show_bug.cgi?id=73182

Patch by James Wei <james.wei@intel.com> & Xingnan Wang <xingnan.wang@intel.com> on 2011-12-02
Reviewed by Kenneth Russell.

  • platform/audio/VectorMath.cpp:

(WebCore:VectorMath):

6:34 PM Changeset in webkit [101893] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

6:29 PM Changeset in webkit [101892] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.4

New tag.

6:25 PM Changeset in webkit [101891] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

6:20 PM Changeset in webkit [101890] by dgrogan@chromium.org
  • 13 edits in trunk/Source

Grant workers experimental access to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=73609

Reviewed by Nate Chapin.

Source/WebCore:

No new tests - there will be chromium ui tests that depend on
webkit.org/b/73297.

  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::open): Call new function,
IDBFactoryBackendInterface::openFromWorker.

  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openFromWorker):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitIndexedDB): Stores
IDBFactoryBackendInterface, implemented by IDBFactoryBackendProxy in
chromium, in the WorkerContext. For the Document case it is stored in
the PageGroup. Storing it in the WorkerContext causes more memory
churn, but that should be trivial. I don't know of any better
alternatives.

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread): Return
true while behind a runtime flag, and while we figure out how to check
permission in a thread-safe manner.
(WebKit::IDBFactoryBackendProxy::openFromWorker): Using the webFrame
from the worker seems to satisfy the weak condition in chromium that
neither it nor it's associated RenderView is NULL.

  • src/IDBFactoryBackendProxy.h:
6:12 PM Changeset in webkit [101889] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

6:07 PM Changeset in webkit [101888] by Lucas Forschler
  • 1 copy in tags/Safari-535.11

New Tag.

5:59 PM Changeset in webkit [101887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove entry pointer before freeing it from matrix.
https://bugs.webkit.org/show_bug.cgi?id=73625

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-12-02
Reviewed by Ryosuke Niwa.

To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

5:47 PM Changeset in webkit [101886] by oliver@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Improve float array support in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73722

Reviewed by Gavin Barraclough.

Add basic support for float typed arrays in JSC. This is currently
less optimal than it could be in the following ways:

  • float32Array1[0] = float32Array2[0] (eg. an element by element copy) promotes float to double and then back to float.
  • float64Array[0] will always perform NaN tests in order to prevent signalling NaNs from entering the engine.

We also don't support Float32Array on ARMv7

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::loadDouble):
(JSC::MacroAssemblerX86Common::loadFloat):
(JSC::MacroAssemblerX86Common::storeDouble):
(JSC::MacroAssemblerX86Common::storeFloat):
(JSC::MacroAssemblerX86Common::convertDoubleToFloat):
(JSC::MacroAssemblerX86Common::convertFloatToDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::cvtsd2ss_rr):
(JSC::X86Assembler::cvtss2sd_rr):
(JSC::X86Assembler::movsd_rm):
(JSC::X86Assembler::movss_rm):
(JSC::X86Assembler::movsd_mr):
(JSC::X86Assembler::movss_mr):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateFloat32Array):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):

5:42 PM Changeset in webkit [101885] by jamesr@google.com
  • 17 edits
    7 copies in trunk/Source/WebKit/chromium

[chromium] Move WebLayer APIs to platform directory
https://bugs.webkit.org/show_bug.cgi?id=73610

Reviewed by Darin Fisher.

  • public/WebContentLayer.h:
  • public/WebContentLayerClient.h:
  • public/WebExternalTextureLayer.h:
  • public/WebLayer.h:
  • public/WebLayerClient.h:
  • public/WebLayerTreeView.h:
  • public/WebLayerTreeViewClient.h:
  • public/platform/WebContentLayer.h: Copied from Source/WebKit/chromium/public/WebContentLayer.h.

(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • public/platform/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/WebContentLayerClient.h.

(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • public/platform/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/WebExternalTextureLayer.h.

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

  • public/platform/WebLayer.h: Copied from Source/WebKit/chromium/public/WebLayer.h.

(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • public/platform/WebLayerClient.h: Copied from Source/WebKit/chromium/public/WebLayerClient.h.

(WebKit::WebLayerClient::~WebLayerClient):

  • public/platform/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/WebLayerTreeView.h.

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • public/platform/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/WebLayerTreeViewClient.h.

(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • public/platform/WebPrivatePtr.h:
  • src/WebContentLayer.cpp:
  • src/WebContentLayerImpl.cpp:
  • src/WebExternalTextureLayer.cpp:
  • src/WebExternalTextureLayerImpl.cpp:
  • src/WebLayer.cpp:
  • src/WebLayerImpl.cpp:
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.h:
5:42 PM Changeset in webkit [101884] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r90959.

5:38 PM Changeset in webkit [101883] by commit-queue@webkit.org
  • 8 edits
    11 adds in trunk

Source/WebCore: Fix mixed content handling for video in Chromium by having
CachedResourceLoader & SubresourceLoader use the
ResourceRequest::TargetType when determining if a RawResource can
be requested.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/insecure-video-in-iframe.html

http/tests/security/mixedContent/insecure-video-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::targetTypeToCachedResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

LayoutTests: Adding mixed content tests for video tag.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

  • http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-video-in-iframe.html: Added.
  • http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Added.
5:35 PM Changeset in webkit [101882] by scheib@chromium.org
  • 1 edit
    2 copies
    1 move
    3 adds in trunk/LayoutTests

[Chromium] Rebaselining svg/custom/svg-fonts-word-spacing.html

  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
  • platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
5:28 PM Changeset in webkit [101881] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for image+text

  • platform/chromium/test_expectations.txt:
5:04 PM Changeset in webkit [101880] by eric@webkit.org
  • 2 edits in trunk/Tools

Enable parallel testing for Win and Gtk bots
after confirming with Lucas and Martin the bots should be OK.

Unreviewed. (I ran the idea by Lucas and Martin.)

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

4:53 PM Changeset in webkit [101879] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] add setOpener method to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73379

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

  • public/WebFrame.h:

(WebKit::WebFrame::clearOpener): now an inline call to setOpener(0)

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setOpener): sets window.opener

  • src/WebFrameImpl.h:
4:41 PM Changeset in webkit [101878] by Lucas Forschler
  • 9 edits in branches/safari-534.53-branch/Source

Merge 93445.

4:21 PM Changeset in webkit [101877] by Lucas Forschler
  • 13 edits
    1 copy in branches/safari-534.53-branch/Source

Merge 93377.

4:13 PM Changeset in webkit [101876] by dcheng@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r101731.
http://trac.webkit.org/changeset/101731
https://bugs.webkit.org/show_bug.cgi?id=73706

Broke copy and paste in chromium. (Requested by dcheng on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

  • editing/spelling/spellcheck-queue-expected.txt: Removed.
  • editing/spelling/spellcheck-queue.html: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
4:04 PM Changeset in webkit [101875] by fsamuel@chromium.org
  • 15 edits
    9 adds in trunk

When page scaling is in use position:fixed has incorrect results
https://bugs.webkit.org/show_bug.cgi?id=68617

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Add the option for position:fixed elements to be fixed to the frame
instead of the layout rectangle of the document.

Tests: fast/repaint/fixed-in-page-scale.html

fast/repaint/fixed-right-bottom-in-page-scale.html
fast/repaint/fixed-right-in-page-scale.html

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

If position:fixed elements are relative to the frame, disregard the
drag factor.

(WebCore::FrameView::setShouldLayoutFixedElementsRelativeToFrame):

  • page/FrameView.h:

(WebCore::FrameView::shouldLayoutFixedElementsRelativeToFrame):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shouldLayoutFixedElementRelativeToFrame):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

If position:fixed elements are relative to the frame, their container
is the frame instead of the layout rect of the document.
This allows proper positioning of these elements to the right and
bottom.

  • rendering/RenderBox.h:
  • testing/Internals.cpp:

(WebCore::Internals::setShouldLayoutFixedElementsRelativeToFrame):

  • testing/Internals.h:
  • testing/Internals.idl: Allow enabling and disabling the new behavior in layout tests.

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/repaint/fixed-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-in-page-scale.html: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-right-bottom-in-page-scale.html: Added.
  • fast/repaint/fixed-right-in-page-scale-expected.png: Added.
  • fast/repaint/fixed-right-in-page-scale-expected.txt: Added.
  • fast/repaint/fixed-right-in-page-scale.html: Added.
3:55 PM Changeset in webkit [101874] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for SubresourceLoader when building with Core Foundation
https://bugs.webkit.org/show_bug.cgi?id=73709

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by David Kilzer.

The patch r100311 removed SubresourceClient and merged it in SubresourceLoader.
Consequently, m_client does not exist anymore and there is no need to do the check
before invoking didReceiveData().

  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):

3:54 PM Changeset in webkit [101873] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/10423627> Layers are flipped in WebKit1 views

Reviewed by Sam Weinig.

Host the compositing layers in an NSView which is flipped, which helps AppKit
get the geometry right in some situations.

  • WebView/WebHTMLView.mm:

(-[WebLayerHostingFlippedView isFlipped]):
(-[WebHTMLView attachRootLayer:]):

3:54 PM Changeset in webkit [101872] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merge 100809.

3:48 PM Changeset in webkit [101871] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixed a typo

3:48 PM Changeset in webkit [101870] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

StyledElement: Simplify addCSSColor().
<http://webkit.org/b/73703>

Reviewed by Darin Adler.

The Color(const String&) constructor handles both named and 3/6-digit
hex colors, so there's no need to handle those separately here.
Also tweaked some comments and minor things.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSColor):

3:45 PM Changeset in webkit [101869] by mrobinson@webkit.org
  • 2 edits in trunk

Try to fix the GTK+ debug bot. As discussed with other GTK+
hackers recently. It makes sense to just remove G_DISABLE_DEPRECATIONS
now in WebKit. The flag itself is now deprecated in GLib in favor of
the gcc attribute.

  • GNUmakefile.am: Remove G_DISABLE_DEPRECATED.
3:38 PM Changeset in webkit [101868] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for text

  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [101867] by benjamin@webkit.org
  • 5 edits
    3 adds
    1 delete in trunk/Source/WebCore

Update platform/iphone to platform/ios
https://bugs.webkit.org/show_bug.cgi?id=73708

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by Darin Adler.

The platform is now best known as iOS, update the platform layer accordingly.

  • Configurations/WebCore.xcconfig:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cocoa/KeyEventCocoa.mm:
  • platform/ios/KeyEventCodesIOS.h: Renamed from Source/WebCore/platform/iphone/KeyEventCodesIPhone.h.
  • platform/ios/KeyEventIOS.mm: Renamed from Source/WebCore/platform/iphone/KeyEventIPhone.mm.

(WebCore::keyIdentifierForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

3:31 PM Changeset in webkit [101866] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Adding test expectation that svg/animations/svginteger-animation-1.html crashes leopard cg

  • platform/chromium/test_expectations.txt:
3:18 PM Changeset in webkit [101865] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking http/tests/appcache/video.html TIMEOUT

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [101864] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Eliminate unnecessary state on previous CL
https://bugs.webkit.org/show_bug.cgi?id=73661

Patch by Jonathan Backer <backer@chromium.org> on 2011-12-02
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

3:02 PM Changeset in webkit [101863] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Suppressing failures in test_expectations for 101844

  • platform/chromium/test_expectations.txt:
2:59 PM Changeset in webkit [101862] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Try to fix the GTK+ build.

  • gtk/jhbuild.modules: Properly specify the glib-networking

dependency for soup.

2:58 PM Changeset in webkit [101861] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Fix a syntax error in the committers.py file.

  • Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2:56 PM Changeset in webkit [101860] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Update sandbox rules
https://bugs.webkit.org/show_bug.cgi?id=73675
<rdar://problem/9276430>

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb:
2:49 PM Changeset in webkit [101859] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Alan Stearns and Peter Linss to the contributors list.

  • Scripts/webkitpy/common/config/committers.py:
2:49 PM Changeset in webkit [101858] by mitz@apple.com
  • 21 edits in trunk

<rdar://problem/10520670> REGRESSION (r91738): didFinishLoad is called before custom fonts have finished loading
https://bugs.webkit.org/show_bug.cgi?id=73688

Reviewed by Darin Adler.

Source/WebCore:

The problem was that after CSSFontFaceSource::getFontData() had scheduled a 0-delay timer to
begin loading the font, but before that timer fired, the subresource loader appeared to have
had no resources waiting to be loaded, and therefore didFinishLoad could be called. This change
reworks the fix for <http://webkit.org/b/65123> so that while the load is still started on a
0-dealy timer, the subresource loader’s request count is incremented immediately, preventing
it from hitting 0 while the font load is scheduled to begin. The delayed load mechanism is
moved from CSSFontFaceSource into CSSFontSelector in order to safely handle the possibility of
the latter being decommissioned while waiting for font loading to begin.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource): Removed initializer for m_loadStartTimer.
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Removed stopping of m_loadStartTimer.
(WebCore::CSSFontFaceSource::getFontData): Replaced code to schedule loading on a timer with
a call to CSSFontSelector::beginLoadingFontSoon.

  • css/CSSFontFaceSource.h: Removed m_loadStartTimer and m_fontSelector member variables.
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector): Added initialized for m_beginLoadingTimer.
(WebCore::CSSFontSelector::~CSSFontSelector): Added call to clearDocument(), to deal with
anything remaining in m_fontsToBeginLoading at this time.
(WebCore::CSSFontSelector::clearDocument): Now stops m_beginLoadingTimer and balances
incrementRequestCount() calls for anything remaining in m_fontsToBeginLoading.
(WebCore::CSSFontSelector::beginLoadingFontSoon): Added. Schedules the actual call to
CachedFont::beginLoadingIfNeeded on a 0-delay timer, and meanwhile increments the request count
on the CachedResourceLoader, which ensures that didFinishLoad will not be called while waiting
for the timer to fire.
(WebCore::CSSFontSelector::beginLoadTimerFired): Added. Actually calls
CachedFont::beginLoadIfNeeded and balances the incrementRequestCount() made when the timer was
scheduled.

  • css/CSSFontSelector.h:

LayoutTests:

Reverted test chnages from r91738. These tests were made to wait for the fonts to finish loading
using a DOM. Now again they do not need to.

  • fast/css/color-leakage.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-remote-sources.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-woff.html:
  • fast/writing-mode/broken-ideograph-small-caps.html:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
  • svg/custom/svg-fonts-fallback.xhtml:
  • svg/custom/svg-fonts-in-html.html:
  • svg/custom/svg-fonts-segmented.xhtml:
  • svg/custom/svg-fonts-with-no-element-reference.html:
  • svg/custom/svg-fonts-without-missing-glyph.xhtml:
  • svg/text/text-overflow-ellipsis-svgfont.html:
2:42 PM Changeset in webkit [101857] by tkent@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Fix compilation warnings for ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=73623

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/ImageDiff.cpp:
    • Fix fprintf format: %s -> %d for LINE
    • Do nothing for ASSERT() if NDEBUG.
2:37 PM Changeset in webkit [101856] by eric@webkit.org
  • 2 edits in trunk/Tools

Enable parallel testing for all Mac bots.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

2:34 PM Changeset in webkit [101855] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Send an AXCheckedStateChanged notification when the aria-checked attribute changes.
https://bugs.webkit.org/show_bug.cgi?id=72754

Patch by David Tseng <dtseng@google.com> on 2011-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-checkbox-sends-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::checkedStateChanged):

  • accessibility/AXObjectCache.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

LayoutTests:

  • accessibility/aria-checkbox-sends-notification.html: Added.
  • platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
2:30 PM Changeset in webkit [101854] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Recycle tile-sized textures during commit to prevent reallocations
https://bugs.webkit.org/show_bug.cgi?id=70645

Patch by Grace Kloba <klobag@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Currently texture request is capped by the high limit while we reclaim the
textures in each commit. This triggers new tiles always allocated when scrolling.
The proposal is to recycle the texture during request if the total used memory
is about to exceed the reclaim limit.

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::reserve):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::setMemoryLimitBytes):
(WebCore::TextureManager::replaceTexture):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:
2:26 PM Changeset in webkit [101853] by eric@webkit.org
  • 2 edits in trunk/Tools

Enable parallel testing for run-webkit-tests on Mac Lion.
I plan to move all the machines to parallel testing shortly
but we're starting with Lion.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

2:17 PM Changeset in webkit [101852] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r101337.
http://trac.webkit.org/changeset/101337
https://bugs.webkit.org/show_bug.cgi?id=73189

It's a wrong way to fix the problem

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::popupOpened):

LayoutTests:

  • fast/forms/select-popup-crash-expected.txt: Removed.
  • fast/forms/select-popup-crash.html: Removed.
2:07 PM Changeset in webkit [101851] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

Added helper method to identify whether the page has custom page size style.
https://bugs.webkit.org/show_bug.cgi?id=73585

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::hasCustomPageSizeStyle):

  • src/WebFrameImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::hasCustomPageSizeStyle):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

  • platform/chromium/printing/custom-page-size-style-expected.txt: Added.
  • platform/chromium/printing/custom-page-size-style.html: Added.
2:02 PM Changeset in webkit [101850] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Adding flaky tests to test_expectations

inspector/extensions tests even flakier
newly flaky media/event-attributes.html

  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [101849] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi?id=73691
is fixed.

  • fast/dom/Window/window-postmessage-args-expected.txt:
1:55 PM Changeset in webkit [101848] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Show placeholder even if the element is focused
https://bugs.webkit.org/show_bug.cgi?id=73629

Reviewed by Hajime Morita.

No new tests. Need to update some existing placeholder tests.

  • rendering/RenderThemeChromiumMac.h: Add shouldShowPlaceholderWhenFocused().
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::shouldShowPlaceholderWhenFocused):
Returns true.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::shouldShowPlaceholderWhenFocused): ditto.

  • rendering/RenderThemeChromiumSkia.h: Add shouldShowPlaceholderWhenFocused().
1:49 PM Changeset in webkit [101847] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

[Lion][Windows] Both of placeholder and input text are shown in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=73615

Reviewed by Joseph Pecoraro.

Source/WebCore:

Placeholder visibility was checked by HTMLInputElement::value
emptiness. It should be innerTextValue emptiness because it is
possible that a number field has empty HTMLInputElement::value and
non-empty innerTextValue.

Tests: fast/forms/number/number-placeholder-with-unacceptable-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateInnerTextValue):
We should update placeholder visiblity when the innerTextValue is updated.
(WebCore::HTMLInputElement::subtreeHasChanged): ditto.
(WebCore::HTMLInputElement::setSuggestedValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.
(WebCore::HTMLInputElement::setValueFromRenderer):
We don't need to call updatePlaceholderVisibility() because subtreeHasChanged() calls it.

  • html/HTMLInputElement.h: Checks innerTextValue emptiness.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.

LayoutTests:

  • fast/forms/number/number-placeholder-with-unacceptable-value-expected.html: Added.
  • fast/forms/number/number-placeholder-with-unacceptable-value.html: Added.
1:49 PM Changeset in webkit [101846] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] GYP fix for Windows 2010 build
https://bugs.webkit.org/show_bug.cgi?id=73483

Reviewed by Adam Barth.

Patch by Carlos Pizano.

  • WebKit.gyp: Exclude the android directory and remove a file match that doesn't match anything.
1:42 PM Changeset in webkit [101845] by rniwa@webkit.org
  • 10 edits in trunk/Tools

[NRWT] reftest should support having multiple references per test
https://bugs.webkit.org/show_bug.cgi?id=73613

Reviewed by Dirk Pranke.

Add a support for having multiple reference files for a single test.

Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
at least one of expected mismatches, we compare expected mismatches first in order to minimize
the number of reference files to open on DRT.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures): Remove checks no longer applicable.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures): Ditto.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Remove a bunch of code and just call port.reference_files.
(SingleTestRunner._driver_input):
(SingleTestRunner.run):
(SingleTestRunner._run_reftest): Compare the output of the test to each reference file.

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init): Remove ref_file and is_mismatch_reftest because they are no longer used.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
(_parse_reftest_list): Now supports parsing multiple entries for a single test.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_parse_reftest_list):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs): Added.

1:08 PM Changeset in webkit [101844] by alokp@chromium.org
  • 6 edits
    1 add in trunk

Source/WebCore: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Added.

(WebCore::TEST):

LayoutTests: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [101843] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking slow test: http/tests/appcache/video.html

  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [101842] by adamk@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Relanding, depends on http://codereview.chromium.org/8748015/
to fix a sandboxing issue on Chromium/Linux.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium implementation of the new WebThread methods is in
http://codereview.chromium.org/8586038/.

  • public/platform/WebThread.h:

(WebKit::WebThread::TaskObserver::~TaskObserver):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

11:34 AM BuildBot edited by bfulgham@webkit.org
Some notes to prevent the "[executable] has crashed" dialog from … (diff)
11:31 AM Changeset in webkit [101841] by scheib@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r101833.
http://trac.webkit.org/changeset/101833
https://bugs.webkit.org/show_bug.cgi?id=73678

test_expectations file invalid: run Tools/Scripts/new-run-
webkit-tests --lint-test-files (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Removed.

LayoutTests:

  • platform/chromium/test_expectations.txt:
11:24 AM Changeset in webkit [101840] by kov@webkit.org
  • 2 edits in trunk/Tools

Build libsoup without gnome dependencies (like keyring).

  • gtk/jhbuild.modules:
11:21 AM Changeset in webkit [101839] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixe test_expectations.txt parse error

  • platform/chromium/test_expectations.txt:
11:21 AM Changeset in webkit [101838] by aestes@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed
https://bugs.webkit.org/show_bug.cgi?id=73641

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Do not
un-freeze the layer tree state if incremental rendering is suppressed.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerTreeStateIsFrozen): Add a getter for
m_layerTreeStateIsFrozen.

  • WebProcess/WebPage/DrawingAreaImpl.h:

(WebKit::DrawingAreaImpl::layerTreeStateIsFrozen): Ditto.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): WebFrameLoaderClient might have
tried to freeze the state of the layer tree before the layer tree host
was created. When creating the layer tree host, only schedule a layer
flush if the layer tree state isn't frozen.

11:19 AM Changeset in webkit [101837] by kov@webkit.org
  • 2 edits in trunk/Tools

Also build gcrypt and p11-kit, and make them dependencies of
gnutls.

  • gtk/jhbuild.modules:
11:19 AM Changeset in webkit [101836] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed test_expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02

  • platform/chromium/test_expectations.txt: Added flakey for svg/stroke/...
11:16 AM Changeset in webkit [101835] by kevino@webkit.org
  • 6 edits in trunk

[wx] Unreviewed build fixes for Windows build.

11:10 AM Changeset in webkit [101834] by eric@webkit.org
  • 12 edits
    1 copy in trunk/Tools

Reviewed by Adam Barth.

webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
https://bugs.webkit.org/show_bug.cgi?id=32006

I decided not to make it warn, and just have it re-open the bug.
That's not that different from today's behavior which will
just silently attach the patch.

This patch makes behavior between upload and land-safely consistent
(previously one would assign patches and the other would not)
as well as adds the ability for both to ensure that the bug is open.

To test this I had to add a few more methods to MockBugzilla which
(positively) affected a few other test results.

I also made AbstractStep keep a cached copy of the Bug object
and used the cached copy where appropriate (including for 'bug_title').
This should reduce the number of bug fetches we perform.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
11:08 AM Changeset in webkit [101833] by alokp@chromium.org
  • 6 edits
    1 add in trunk

[chromium] CCLayerQuad does not return FloatQuad in correct orientation
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Source/WebCore:

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

  • platform/graphics/chromium/cc/CCLayerQuad.cpp:

(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerQuadTest.cpp: Added.

(WebCore::TEST):

LayoutTests:

  • platform/chromium/test_expectations.txt:
11:05 AM Changeset in webkit [101832] by kov@webkit.org
  • 2 edits in trunk/Tools

Also pass --no-interact to jhbuild when updating dependencies.

  • Scripts/update-webkitgtk-libs:
11:00 AM Changeset in webkit [101831] by dslomov@google.com
  • 9 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=73589
[V8][Chromium] Adjust postMessage to the latest "implementation-ready" spec.

  • postMessage should support transfer of MessagePorts
  • the order of arguments to Window::postMessage and Window::webkitPostMessage should be (msg, targetOrigin [, transfer])

Reviewed by David Levin.

Source/WebCore:

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

LayoutTests:

  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:

(wrapSend):
(wrapFailSend):

  • fast/dom/Window/window-postmessage-args.html:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
10:57 AM Changeset in webkit [101830] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=73497
This is a followup to the patch submitted for the bug above.
Tha patch was landed in r101575 and I missed to make one of the changes
suggested by the reviewer that had pointed out that the code was still
making use of the deprecatedNode method.

Unreviewed.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Changed deprecatedNode to containerNode.

10:55 AM Changeset in webkit [101829] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

Content-security-policy script-src not enforced on workers.
https://bugs.webkit.org/show_bug.cgi?id=73240

Reviewed by Adam Barth.

Source/WebCore:

Add a CSP check in AbstractWorker.cpp as part of resolving URL.

Test: http/tests/security/contentSecurityPolicy/worker-script-src.html

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Added test to verify bug.

  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-script-src.html: Added.
10:52 AM Changeset in webkit [101828] by dcheng@chromium.org
  • 16 edits
    4 adds in trunk

[chromium] Add plumbing for supporting custom MIME types in DataTransfer.
https://bugs.webkit.org/show_bug.cgi?id=73594

Reviewed by David Levin.

Source/WebCore:

Tests: editing/pasteboard/clipboard-customData.html

fast/events/drag-customData.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::customData):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/platform/WebClipboard.h:

(WebKit::WebClipboard::readCustomData):

  • public/platform/WebDragData.h:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardReadCustomData):

  • src/WebDragData.cpp:

(WebKit::WebDragData::customData):
(WebKit::WebDragData::setCustomData):

LayoutTests:

  • editing/pasteboard/clipboard-customData-expected.txt: Added.
  • editing/pasteboard/clipboard-customData.html: Added.
  • fast/events/drag-customData-expected.txt: Added.
  • fast/events/drag-customData.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:47 AM Changeset in webkit [101827] by aboxhall@chromium.org
  • 2 edits in trunk/Tools

Make _build_path check more thoroughly that build paths exist.
https://bugs.webkit.org/show_bug.cgi?id=73601

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._build_path):

10:44 AM Changeset in webkit [101826] by kov@webkit.org
  • 2 edits in trunk/Tools

Add libffi to the jhbuild modules list as a glib dependency.

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules:
10:34 AM Changeset in webkit [101825] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Form stream data structures still not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=73674

Reviewed by Anders Carlsson.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::streamFieldsMapMutex): Added.
(WebCore::associateStreamWithResourceHandle): Use streamFieldsMapMutex.
(WebCore::formCreate): Ditto.
(WebCore::formFinalize): Ditto.
(WebCore::httpBodyFromStream): Ditto.

10:31 AM Changeset in webkit [101824] by commit-queue@webkit.org
  • 30 edits in trunk

IndexedDB: Rename "multientry" to "multiEntry" per spec change
https://bugs.webkit.org/show_bug.cgi?id=73578

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebCore:

  • storage/IDBIndex.h:

(WebCore::IDBIndex::multiEntry):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):

  • storage/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::multiEntry):

  • storage/IDBIndexBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • storage/IDBLevelDBCoding.cpp:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::multiEntry):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::multiEntry):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):

  • src/IDBObjectStoreBackendProxy.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::multiEntry):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):

  • src/WebIDBObjectStoreImpl.h:

LayoutTests:

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-multientry.html:
10:30 AM Changeset in webkit [101823] by kov@webkit.org
  • 4 edits in trunk/Tools

Build fix. Use internal pcre on glib, make gnutls a dependency of
glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
in non-interactive mode.

  • Scripts/update-webkitgtk-libs:
  • gtk/jhbuild.modules:
  • gtk/run-with-jhbuild:
10:26 AM Changeset in webkit [101822] by Adam Roben
  • 2 edits in trunk/Tools

Fix for Python 2.6

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
searching for "Tests that timed out:" etc. This makes our check less strict, but it
shouldn't matter given the kinds of content we parse.

10:19 AM Changeset in webkit [101821] by Adam Roben
  • 2 edits in trunk/Tools

Fix names of failed/timed out tests in run-api-tests output

Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
out tests

We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").

Reviewed by Simon Fraser.

  • Scripts/run-api-tests:

(runTest): Don't prepend the suite name to $test. It's already been prepended at the start
of this function.

10:17 AM Changeset in webkit [101820] by mrobinson@webkit.org
  • 3 edits in trunk/Tools

[GTK] generate-gtkdoc should respect build type
https://bugs.webkit.org/show_bug.cgi?id=73296

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.

  • gtk/common.py: If --build is passed give preference to the Debug build directory.
10:11 AM Changeset in webkit [101819] by tony@chromium.org
  • 3 edits in trunk/Tools

[nrwt] fix wdiff output
https://bugs.webkit.org/show_bug.cgi?id=73604

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.wdiff_text):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_wdiff_text):

10:01 AM Changeset in webkit [101818] by Adam Roben
  • 3 edits in trunk/Tools

Teach build.webkit.org to display how many unit tests failed or timed out

Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
build.webkit.org

We now display something like "5 unit tests failed or timed out". Eventually we might want
to split out how many failure vs. timeouts there were.

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestWithFailureCount): Moved this class up to the top of the file so it is before any other
classes that may want to subclass it.
(RunUnitTests): Changed to inherit from TestWithFailureCount.
(RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
timed out:" and "Tests that failed:" lines, if present.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(StubStdio):
(StubRemoteCommand):
Added these two stub classes to mimic buildbot's RemoteCommand and log classes.

(RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
the test run correctly.

(RunUnitTestsTest.test_no_failures_or_timeouts):
(RunUnitTestsTest.test_one_failure):
(RunUnitTestsTest.test_multiple_failures):
(RunUnitTestsTest.test_one_timeout):
(RunUnitTestsTest.test_multiple_timeouts):
(RunUnitTestsTest.test_multiple_failures_and_timeouts):
Test various cases.

10:00 AM Changeset in webkit [101817] by Adam Roben
  • 2 edits in trunk/Tools

Teach prepare-ChangeLog to treat master.cfg as a Python file

Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
in buildbot's master.cfg

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
master.cfg.

9:49 AM Changeset in webkit [101816] by Darin Adler
  • 5 edits
    2 adds
    14 deletes in trunk

Unreviewed, rolling out r101805.
http://trac.webkit.org/changeset/101805
https://bugs.webkit.org/show_bug.cgi?id=73670

Many canvas tests started failing due to the isEmpty change
(Requested by darin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::isEmpty):

LayoutTests:

  • platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.png: Removed.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • svg/custom/path-moveto-only-rendering.svg: Removed.
  • svg/custom/subpaths-moveto-only-rendering.svg: Removed.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt:
9:44 AM Changeset in webkit [101815] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add 'enable-dns-prefetching' property to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=73414

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-02
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set function.
(webKitSettingsGetProperty): Add new get function.
(webkit_settings_class_init): Register new property.
(webkit_settings_get_enable_dns_prefetching): API to get 'enable-dns-prefetching' property.
(webkit_settings_set_enable_dns_prefetching): API to set 'enable-dns-prefetching' property.

  • UIProcess/API/gtk/WebKitSettings.h: Expose new public API's.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new APIs to gtk-doc sections file.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

9:44 AM Changeset in webkit [101814] by mrobinson@webkit.org
  • 3 edits
    1 add in trunk/Tools

[GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
https://bugs.webkit.org/show_bug.cgi?id=73669

Reviewed by Gustavo Noronha Silva.

Add a wrapper script that knows how to install jhbuild and also to wrap commands
in the jhbuild shell.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProject): Use the new wrapper script.
(mustReRunAutogen): Ditto.
(buildAutotoolsProject): Ditto.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver.cmd_line): Ditto.

  • gtk/run-with-jhbuild: Added.
9:42 AM Changeset in webkit [101813] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Reference count threading violation in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=73627

Reviewed by Sam Weinig.

Shows up as a crash during existing layout test runs so no new tests are required.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::streamFieldsMap): Replaced getStreamFormDataMap with this.
Use an NSMapTable instead of a HashMap because we need to remove items from this
on a non-main thread.
(WebCore::associateStreamWithResourceHandle): Use NSMapGet instead of
HashMap::contains here.
(WebCore::formCreate): FormStreamFields now stores a RefPtr to the form data.
Added the code to fill that in. Did it in a more modern way to avoid the leakRef
and adoptRef that were used before. Replaced the code that set up the stream
form data map entry with code that sets an entry in the streamFieldsMap.
(WebCore::formFinishFinalizationOnMainThread): Added. Contains the work of
finalization that must be done on the main thread, specifically, destroying the
fields structure that contains objects with RefPtr in them. We can't touch these
reference counts on non-main threads.
(WebCore::formFinalize): Changed this to use NSMapRemove on the streamFieldsMap.
Added a callOnMainThread to finish the finalization.
(WebCore::setHTTPBody): Removed the leakRef, no longer needed, that used to be
balanced by an adoptRef in formCreate.
(WebCore::httpBodyFromStream): Changed to use NSMapGet.

9:42 AM Changeset in webkit [101812] by Antti Koivisto
  • 5 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=73520
REGRESSION(r101524): Article titles invisible until hover on blaze.com

Source/WebCore:

Reviewed by Darin Adler.

We need to invalidate the matched declaration cache when new web fonts are loaded.
Fonts in the cached RenderStyles may not be valid anymore.

Also renamed m_matchStyleDeclarationCache -> m_matchedStyleDeclarationCache.

Test reduction by the Reduction Fairy (aka kling).

Test: fast/css/font-face-cache-bug.html

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
(WebCore::CSSStyleSelector::invalidateMatchedDeclarationCache):

  • css/CSSStyleSelector.h:

LayoutTests:

Reviewed by Darin Adler.

Test reduction by the Reduction Fairy (aka kling).

  • fast/css/font-face-cache-bug-expected.txt: Added.
  • fast/css/font-face-cache-bug.html: Added.
9:41 AM Changeset in webkit [101811] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73664

Reviewed by Martin Robinson.

This patch adds our HTTP library and its main dependencies; this
should not affect layout or rendering.

  • gtk/jhbuild.modules:
9:35 AM Changeset in webkit [101810] by jer.noble@apple.com
  • 11 edits in trunk/Source/WebCore

MediaControls should use MediaController if present.
https://bugs.webkit.org/show_bug.cgi?id=71410

Reviewed by Eric Carlson.

No new tests; covered by existing tests.

Add support for individual media controls to control the MediaController of their associated
HTMLMediaElement, if present.

The video spec requires that UA provided media controls be implemented in terms of their
HTMLMediaElement's MediaController, if present. So for each of the media controls, modify
their constructor to take a Document* instead of an HTMLMediaElement, and add an setter
taking a MediaControllerInterface.

Now that MediaControls have an abstract interface instead of an HTMLMediaElement, use toParentMediaElement
to find the controllingVideoElement.

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControlsContainer::controllingVideoElement):

Pass the MediaController or the HTMLMediaElement when setting up the elements controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createMediaControls):
(WebCore::HTMLMediaElement::setMediaController):

The following functions have only constructor changes:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::create):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlTimelineContainerElement::create):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::create):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlStatusDisplayElement::create):
(WebCore::MediaControlInputElement::MediaControlInputElement):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
(WebCore::MediaControlTimeRemainingDisplayElement::create):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::create):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElement::create):

  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::MediaControls):

  • html/shadow/MediaControls.h:

The following functions now call MediaControllerInterface instead of HTMLMediaElement directly:

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
(WebCore::MediaControlPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
(WebCore::MediaControlSeekButtonElement::startTimer):
(WebCore::MediaControlSeekButtonElement::stopTimer):
(WebCore::MediaControlSeekButtonElement::nextRate):
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::playbackProgressed):
(WebCore::MediaControlRootElement::playbackStopped):
(WebCore::MediaControlRootElement::updateTimeDisplay):
(WebCore::MediaControlRootElement::loadedMetadata):
(WebCore::MediaControlRootElement::changedVolume):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::showVolumeSlider):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::playbackStarted):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::playbackStopped):
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
(WebCore::MediaControlRootElementChromium::changedVolume):
(WebCore::MediaControlRootElementChromium::showVolumeSlider):

  • html/shadow/MediaControlRootElementChromium.h:

The following functions set the current MediaControllerInterface.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::setMediaController):

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlElement::setMediaController):
(WebCore::MediaControlElement::mediaController):
(WebCore::MediaControlInputElement::setMediaController):
(WebCore::MediaControlInputElement::mediaController):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::setMediaController):

9:07 AM Changeset in webkit [101809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r101801.
http://trac.webkit.org/changeset/101801
https://bugs.webkit.org/show_bug.cgi?id=73667

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • assembler/SH4Assembler.h:
9:04 AM Changeset in webkit [101808] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Changes to localStorageDatabasePath don't have any effect on Windows
https://bugs.webkit.org/show_bug.cgi?id=73606
<rdar://problem/10491296>

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::notifyPreferencesChanged): Propagate local storage path change to m_page's settings.

9:01 AM Changeset in webkit [101807] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing websocket test on GTK.

  • platform/gtk/Skipped: Skip http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html
8:50 AM Changeset in webkit [101806] by Darin Adler
  • 6 edits in trunk/Source/JavaScriptCore

Prepare to deploy pass and peek types in the HashMap class
https://bugs.webkit.org/show_bug.cgi?id=73477

Reviewed by Adam Roben.

This patch adds private typedefs inside the HashMap class,
and uses them as appropriate. A future patch will actually
tie those typedefs to hash traits, which will allow us to
make HashMap work with OwnPtr mapped values and to optimize
how HashMap works with RefPtr mapped values.

Also changed the hash translator and adapter struct templates
to use template functions to simplify them and make them more
flexible.

Also removed some unused template arguments.

This goes out of its way to not change behavior. Future patches
will change the peek type to be a reference type, which will
reduce reference count churn a bit for hash tables with RefPtr
mapped values, and then do further optimizations for RefPtr
and OwnPtr by getting types from the hash traits.

  • wtf/HashMap.h: Added MappedPassInType, MappedPassOutType,

and MappedPeekType typedefs, and used them for the arguments
and return types of the get, set, add, take, and inlineAdd
functions.
(WTF::HashMapTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashMapTranslatorAdapter): Ditto.
(WTF::HashMap::find): Updated to use new HashMapTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

  • wtf/HashSet.h:

(WTF::IdentityExtractor): Changed this to be a struct rather than
a struct template, and replaced the extract function with a function
template. This allows the compiler to deduce the type.
(WTF::HashSetTranslatorAdapter): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashSet::find): Updated to use new HashSetTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashSet::contains): Ditto.
(WTF::HashSet::add): Ditto.

  • wtf/HashTable.h:

(WTF::IdentityHashTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashTable::add): Reduced arguments passed to the function template.
(WTF::HashTable::find): Ditto, also reversed the template arguments so the
translator comes first so the compiler can deduce the other type.
(WTF::HashTable::contains): Ditto.
(WTF::HashTable::lookup): Ditto.
(WTF::HashTable::lookupForWriting): Ditto.
(WTF::HashTable::checkKey): Ditto.
(WTF::HashTable::fullLookupForWriting): Ditto.
(WTF::HashTable::add): Ditto.
(WTF::HashTable::addPassingHashCode): Ditto.
(WTF::HashTable::find): Ditto.
(WTF::HashTable::contains): Ditto.

  • wtf/ListHashSet.h:

(WTF::ListHashSetNodeHashFunctions): Changed this struct template to take
fewer arguments, and changed its member functions to be function templates
instead. This allows the compiler to determine types more flexibly and
also simplifies use of it.
(WTF::ListHashSet::find): Reduced the arguments passed to the HashTable
functon template.
(WTF::ListHashSetTranslatorAdapter): Changed this struct template in the
same way we changed ListHashSetNodeHashFunctions above.
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::contains):
(WTF::::add):
(WTF::::insertBefore):

  • wtf/RefPtrHashMap.h: Updated comments. Removed the

RefPtrHashMapRawKeyTranslator struct template; we can use the
HashMapTranslator struct template from HashMap.h instead now that
it is more flexible. Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, inlineGet, set, add, take, and inlineAdd
functions. Changed the name of the RawKeyTranslator type to
Translator since it's now a class that can handle both raw keys
and conventional keys.
(WTF::HashMap::find): Changed to use Translator instead of RawKeyTranslator.
Reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

8:41 AM WebKitGtkLayoutTests edited by kov@webkit.org
(diff)
8:37 AM Changeset in webkit [101805] by commit-queue@webkit.org
  • 5 edits
    14 adds
    2 deletes in trunk

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch
8:36 AM Changeset in webkit [101804] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Set event timestamps on custom input events

Reviewed by Simon Hausmann.

Since r101791 WebEventFactoryQt uses input event timestamps for WebEvents,
thus set the timestamp on the custom events as well.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):

  • UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):

8:33 AM Changeset in webkit [101803] by Adam Roben
  • 3 edits
    2 adds in trunk/Tools

Teach check-webkit-style how to check the syntax of JSON files

Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors

I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
been removed, since its output differs by platform.

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checker.py:

(_all_categories): Added JSONChecker's categories to the set of all categories.
(FileType): Added a JSON type. Incremented other types.
(CheckerDispatcher._file_type): Use the JSON file type for .json files.
(CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
(CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",

which would have matched our other checkers, because I couldn't figure out how to call
"json.loads" without hitting namespace conflicts.)
(JSONChecker.init): Turn of line filtering so that we always check the whole file, not
just the modified lines from a patch.
(JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
exception.
(JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
try to extract a line number.

  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.

(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
Helper class. Copied from xml_unittest.py.

(JSONCheckerTest.test_line_number_from_json_exception): Test the
line_number_from_json_exception helper method.

(JSONCheckerTest.assert_no_error):
(JSONCheckerTest.assert_error):
Helper methods to assert that we did or didn't get an error.

(JSONCheckerTest.mock_handle_style_error): Helper method.

(JSONCheckerTest.test_conflict_marker):
(JSONCheckerTest.test_single_quote):
(JSONCheckerTest.test_init):
(JSONCheckerTest.test_no_error):
Test various cases.

8:30 AM Changeset in webkit [101802] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Also run DumpRenderTree under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73646

Reviewed by Martin Robinson.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver.cmd_line):

8:30 AM Changeset in webkit [101801] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-02
Reviewed by Csaba Osztrogonác.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::readCallTarget): Support for SH4.

8:17 AM Changeset in webkit [101800] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/forms/select/listbox-in-multi-column.html fails
https://bugs.webkit.org/show_bug.cgi?id=73660

  • platform/qt/Skipped: Skip fast/forms/select/listbox-in-multi-column.html until fix.
8:16 AM Changeset in webkit [101799] by alex
  • 3 edits in trunk

2011-12-02 Alejandro G. Castro <alex@igalia.com>

[GTK] Fix TextureMapperCairo compilation
https://bugs.webkit.org/show_bug.cgi?id=73655

Reviewed by Martin Robinson.

  • GNUmakefile.am: The variables need the USE part in the name.
  • configure.ac: We can not define the variable twice.
8:14 AM Changeset in webkit [101798] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed expectation fix after r101787.

  • platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
7:51 AM Changeset in webkit [101797] by vsevik@chromium.org
  • 14 edits in trunk/Source/WebCore

Unreviewed, rolling out r101794.
http://trac.webkit.org/changeset/101794
https://bugs.webkit.org/show_bug.cgi?id=73656

Broke win build (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • bindings/js/ScriptCallStackFactory.cpp:
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:
  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/WorkerInspectorController.h:
  • page/Console.cpp:

(WebCore::Console::shouldCaptureFullStackTrace):

  • page/Console.h:
7:32 AM Changeset in webkit [101796] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Unreviewed, revert r101347.
https://bugs.webkit.org/show_bug.cgi?id=73580

It breaks the linking of Tools/ targets due to missing functions.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-12-02

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • PlatformEfl.cmake:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Added.

(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::setNeedsDisplay):
(WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):

  • platform/graphics/efl/GraphicsLayerEfl.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):

7:27 AM Changeset in webkit [101795] by vsevik@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed, updated chromium test expectations.

  • platform/chromium/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/events/offsetX-offsetY-expected.txt.
7:24 AM Changeset in webkit [101794] by vsevik@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Extract default call stack creation and check for front-end from console.
https://bugs.webkit.org/show_bug.cgi?id=73566

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • bindings/v8/ScriptCallStackFactory.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):

  • inspector/WorkerInspectorController.h:

(WebCore::WorkerInspectorController::hasFrontend):

  • page/Console.cpp:
  • page/Console.h:
7:17 AM Changeset in webkit [101793] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip some new GTK multicol failures because of bug 73653.

  • platform/gtk/Skipped:
7:15 AM Changeset in webkit [101792] by gavinp@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove instrumentation tracking a fixed bug
https://bugs.webkit.org/show_bug.cgi?id=73471

The underlying bug is fixed (bug 72068), and this instrumentation was intrusive and using
memory, plus the conditional compilation made me sad.

Reviewed by Nate Chapin.

No new tests.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

6:45 AM Changeset in webkit [101791] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Use input event timestamps in WebEvents if available
https://bugs.webkit.org/show_bug.cgi?id=73647

Reviewed by Simon Hausmann.

Qt5 input events already have a native timestamp, use this timestamp
in WebEventFactory instead of WTF::currentTime if it is available.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::currentTimeForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
6:44 AM Changeset in webkit [101790] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
https://bugs.webkit.org/show_bug.cgi?id=73650

Reviewed by Pavel Feldman.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype._updateResizer):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype._restoreSidebarWidth):

6:15 AM Changeset in webkit [101789] by vsevik@chromium.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r101783.
http://trac.webkit.org/changeset/101783
https://bugs.webkit.org/show_bug.cgi?id=73652

Broke chromium win build. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
5:37 AM Changeset in webkit [101788] by jesus@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Split the QtWebPageProxy into PageClient and QtPageProxy
https://bugs.webkit.org/show_bug.cgi?id=66668

Reviewed by Simon Hausmann.

Split QtPageClient out of QtWebPageProxy.
This client will live in QQuickWebViewPrivate and communicate directly
with QtWebPageProxy and QtWebPageEventHandler. The functions that need
anything else than these entities will need to call the proper implementation
through QtWebPageProxy itself.
With this we have a clear separation between PageClient and PageProxy, having
two well defined and separated entities for hooking our clients with our API layer (QtWebPageProxy)
and for hooking the WebPageProxy with our client implementations (QtPageClient).
As a positive side-effect we have a cleaner QtWebPageProxy.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/qt/QtPageClient.cpp: Added.

(QtPageClient::QtPageClient):
(QtPageClient::~QtPageClient):
(QtPageClient::createDrawingAreaProxy):
(QtPageClient::setViewNeedsDisplay):
(QtPageClient::pageDidRequestScroll):
(QtPageClient::processDidCrash):
(QtPageClient::didRelaunchProcess):
(QtPageClient::didChangeContentsSize):
(QtPageClient::didChangeViewportProperties):
(QtPageClient::startDrag):
(QtPageClient::handleDownloadRequest):
(QtPageClient::setCursor):
(QtPageClient::setCursorHiddenUntilMouseMoves):
(QtPageClient::toolTipChanged):
(QtPageClient::registerEditCommand):
(QtPageClient::clearAllEditCommands):
(QtPageClient::canUndoRedo):
(QtPageClient::executeUndoRedo):
(QtPageClient::convertToDeviceSpace):
(QtPageClient::convertToUserSpace):
(QtPageClient::screenToWindow):
(QtPageClient::windowToScreen):
(QtPageClient::createPopupMenuProxy):
(QtPageClient::createContextMenuProxy):
(QtPageClient::flashBackingStoreUpdates):
(QtPageClient::didFindZoomableArea):
(QtPageClient::didReceiveMessageFromNavigatorQtObject):
(QtPageClient::doneWithTouchEvent):
(QtPageClient::displayView):
(QtPageClient::scrollView):
(QtPageClient::viewSize):
(QtPageClient::isViewWindowActive):
(QtPageClient::isViewFocused):
(QtPageClient::isViewVisible):
(QtPageClient::isViewInWindow):
(QtPageClient::enterAcceleratedCompositingMode):
(QtPageClient::exitAcceleratedCompositingMode):

  • UIProcess/qt/QtPageClient.h: Added.

(QtPageClient::pageClosed):
(QtPageClient::doneWithKeyEvent):
(QtPageClient::setFindIndicator):
(QtPageClient::didCommitLoadForMainFrame):
(QtPageClient::didFinishLoadingDataForCustomRepresentation):
(QtPageClient::customRepresentationZoomFactor):
(QtPageClient::setCustomRepresentationZoomFactor):
(QtPageClient::didChangeScrollbarsForMainFrame):
(QtPageClient::findStringInCustomRepresentation):
(QtPageClient::countStringMatchesInCustomRepresentation):
(QtPageClient::setEventHandler):
(QtPageClient::setPageProxy):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):

  • UIProcess/qt/QtWebPageProxy.h:
5:32 AM Changeset in webkit [101787] by apavlov@chromium.org
  • 7 edits in trunk

Inline non-replaced elements are reported to have zero width and height
https://bugs.webkit.org/show_bug.cgi?id=61117

Reviewed by Antti Koivisto.

Source/WebCore:

According to http://www.w3.org/TR/CSS21/visudet.html, the "width" and "height" properties
do not apply for inline non-replaced elements and should have their initial value of "auto"
as their computed values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • fast/dom/beforeload/image-object-before-load-innerHTML.html:
  • fast/dom/beforeload/image-object-before-load.html:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:58 AM Changeset in webkit [101786] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/Skipped: plugins/invalidate_rect.html was removed. Also skip one more SVG test.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
4:34 AM Changeset in webkit [101785] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Make CCInputHandler scrolling stateful
https://bugs.webkit.org/show_bug.cgi?id=73345

This change makes the scrolling part of CCInputHandler stateful by
replacing scrollRootLayer() with scrollBegin(), scrollBy() and
scrollEnd(). This is done in preparation for scrollable sublayers.
Specifically, scrollBegin() will allow CCLayerTreeHostImpl to perform
input event hit testing to find the layer to be scrolled.

Patch by Sami Kyostila <skyostil@chromium.org> on 2011-12-02
Reviewed by Steve Block.

Source/WebCore:

Tested in CCLayerTreeHostImplTest.

  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
(WebCore::findInnermostScrollableLayerAtPoint):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

4:34 AM Changeset in webkit [101784] by alex
  • 2 edits in trunk

2011-12-02 Alejandro G. Castro <alex@igalia.com>

[GTK] Improve C++0x compat warnings check
https://bugs.webkit.org/show_bug.cgi?id=73642

Reviewed by Martin Robinson.

  • configure.ac:
4:13 AM Changeset in webkit [101783] by haraken@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
4:10 AM Changeset in webkit [101782] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Network panel row highlighting does not work.
https://bugs.webkit.org/show_bug.cgi?id=73644

Reviewed by Pavel Feldman.

  • inspector/front-end/networkLogView.css:

(.network-log-grid tr.highlighted-row):
(from):
(to):

3:53 AM Changeset in webkit [101781] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Do not apply the transition state before we are unsuspended

Reviewed by Simon Hausmann.

Also remove an accessor in the private, which is unneeded as
everything in the private class is supposed to be public or
only used by the private itself.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qquickwebview_p_p.h:
3:52 AM Changeset in webkit [101780] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed buildfix, add missing include.

  • WebProcess/Notifications/WebNotificationManager.cpp:
3:50 AM Changeset in webkit [101779] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: remove console.timeStamp from the inspector backend dispatcher.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.sendMessageObjectToBackend):

3:41 AM Changeset in webkit [101778] by morrita@google.com
  • 27 edits
    6 deletes in trunk

Unreviewed, rolling out r101751 and r101775.
http://trac.webkit.org/changeset/101751
http://trac.webkit.org/changeset/101775
https://bugs.webkit.org/show_bug.cgi?id=73191

breaks Windows build

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • runtime/JSExportMacros.h: Removed.
  • wtf/ExportMacros.h:
  • wtf/Platform.h:
  • wtf/WTFThreadData.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringStatics.cpp:

Source/JavaScriptGlue:

  • ForwardingHeaders/runtime/JSExportMacros.h: Removed.
  • ForwardingHeaders/wtf/ExportMacros.h: Removed.
  • config.h:

Source/WebCore:

  • ForwardingHeaders/runtime/JSExportMacros.h: Removed.
  • ForwardingHeaders/wtf/ExportMacros.h: Removed.
  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/PlatformExportMacros.h: Removed.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

  • WebKitPrefix.h:

Source/WebKit/qt:

  • tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

  • config.h:

Tools:

  • DumpRenderTree/chromium/config.h:
  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
3:37 AM Changeset in webkit [101777] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: introduce backend stub generation from JSON for the standalone development / remote front-ends.
https://bugs.webkit.org/show_bug.cgi?id=73636

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendClass.prototype.runAfterPendingDispatches):
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):

  • inspector/front-end/TimelineManager.js:
  • inspector/front-end/inspector.js:
3:19 AM Changeset in webkit [101776] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated test expectations.

  • platform/chromium/test_expectations.txt:
3:14 AM Changeset in webkit [101775] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, another attempt to build fix for r101751:
Adding an include path to make PlatformExportMacros.h visibile from QTMovieWin.

Patch by MORITA Hajime <morrita@google.com> on 2011-12-02

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
3:09 AM Changeset in webkit [101774] by vsevik@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed test expectations.

  • platform/chromium-mac/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/gtk/fast/events/offsetX-offsetY-expected.txt.
3:08 AM Changeset in webkit [101773] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r101772.
http://trac.webkit.org/changeset/101772

It didn't fix the build failure

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
2:55 AM Changeset in webkit [101772] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-12-02 MORITA Hajime <morrita@google.com>

Unreviewed attempt to build fix for r101751:
Adding an include path to make PlatformExportMacros.h visibile from QTMovieWin.

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
2:52 AM Changeset in webkit [101771] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101723 and skipping another set
of svg tests show 1px differences.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
2:20 AM Changeset in webkit [101770] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r101750.

  • GNUmakefile.am: Add missing files.
2:17 AM Changeset in webkit [101769] by caseq@chromium.org
  • 13 edits in trunk

Web Inspector: [Extensions API] pass preferred resource line number to extension's open resource handler
https://bugs.webkit.org/show_bug.cgi?id=73084

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._handleOpenURL):

  • inspector/front-end/HandlerRegistry.js:

(get WebInspector.HandlerRegistry.prototype.set dispatch):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):

  • inspector/front-end/externs.js:

(WebInspector.populateResourceContextMenu):

  • inspector/front-end/inspector.js:

(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):

LayoutTests:

  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
2:14 AM Changeset in webkit [101768] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. GTK+ build fix.

  • GNUmakefile.am:
1:31 AM Changeset in webkit [101767] by haraken@chromium.org
  • 2 edits
    3 adds in trunk/Tools

Move run-bindings-tests implementation to webkitpy/bindings/main.py
https://bugs.webkit.org/show_bug.cgi?id=73619

Reviewed by Adam Barth.

As run-bindings-tests has been growing, this patch just moves its implementation
to webkitpy/bindings/main.py to integrate with the rest of webkitpy.

No change in behavior.

  • Scripts/run-bindings-tests:

(main):

  • Scripts/webkitpy/bindings/init.py: Added.
  • Scripts/webkitpy/bindings/main.py: Added.

(BindingsTests.init):
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
(BindingsTests.run_tests):

1:24 AM Changeset in webkit [101766] by vsevik@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, added custom chromium test expectations.

  • platform/chromium/fast/images/image-css3-content-data-expected.png: Added.
1:18 AM Changeset in webkit [101765] by Philippe Normand
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] scrollbars interfering with fullscreen (in-window) video rendering
https://bugs.webkit.org/show_bug.cgi?id=73577

Reviewed by Martin Robinson.

Disable scrollbars when switching to fullscreen.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::contentsSizeChanged): Ignore size changes
when an element is being displayed fullscreen.
(WebKit::ChromeClient::enterFullScreenForElement): Disable
scrollbars when entering fullscreen.

  • WebCoreSupport/GtkAdjustmentWatcher.cpp: Added 2 methods to

enable/disable scrollbars and one method to know whether they are
enabled or not.
(WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher):
(WebKit::updateAdjustmentFromScrollbar):
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars):
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
(WebKit::GtkAdjustmentWatcher::disableAllScrollbars):
(WebKit::GtkAdjustmentWatcher::enableAllScrollbars):

  • WebCoreSupport/GtkAdjustmentWatcher.h:

(WebKit::GtkAdjustmentWatcher::scrollbarsDisabled):

1:16 AM Changeset in webkit [101764] by mrobinson@webkit.org
  • 7 edits in trunk

[GTK] Add compilation options to enable/disable Accelerated Compositing and to choose texture mapper implementation.
https://bugs.webkit.org/show_bug.cgi?id=73458

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Export new compilation macros.
  • configure.ac: Provide option to choose accelerated compositing and texture mapper variations.

Source/WebCore:

No new tests added as this patch doesn't affect any functionality.

  • GNUmakefile.am: Guard the include files.
  • GNUmakefile.list.am: Guard the compilation of few files.
  • platform/graphics/GraphicsLayer.h: Guard the typedef of GraphicsLayer.
1:15 AM Changeset in webkit [101763] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views.
https://bugs.webkit.org/show_bug.cgi?id=73441

Do not assert on empty available size, but return default constrain values instead.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-12-02
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::computeViewportConstraints):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):

1:12 AM Changeset in webkit [101762] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Now that r101733 fixed fast/block/child-not-removed-from-parent-lineboxes-crash.html,
remove the failing expectation on Chromium and re-enable it on Qt.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
1:09 AM Changeset in webkit [101761] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector [chromium]: provisional fix for interactive ui tests
https://bugs.webkit.org/show_bug.cgi?id=73633

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.):
(.TestSuite.prototype._executeCodeWhenScriptsAreParsed):

1:06 AM Changeset in webkit [101760] by caseq@chromium.org
  • 13 edits in trunk

Web Inspector: use object properties, not element attributes to pass preferred panel/line/request id in linkified anchors
https://bugs.webkit.org/show_bug.cgi?id=73556

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.resourceLink):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._resourceByAnchor):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyResourceAsNode):
(WebInspector.linkifyRequestAsNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showAnchorLocation):

  • inspector/front-end/inspector.js:

(WebInspector._showAnchorLocation):

LayoutTests:

  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-audits.html:
12:58 AM Changeset in webkit [101759] by levin@chromium.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add WebKit API's to support the autosize algorithm in renderer process.
https://bugs.webkit.org/show_bug.cgi?id=73058

Reviewed by Darin Fisher.

  • public/WebView.h: Expose the auto-resize method.
  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::didAutoResize):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView): Set the auto-resize
state on the new view.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize): Extracted sendResizeEventAndRepaint, so
that it can be used by layoutUpdated.
(WebKit::WebViewImpl::queueBothResizeEventAndPaint): Ditto.
(WebKit::WebViewImpl::hasHorizontalScrollbar): Added for testing purposes.
(WebKit::WebViewImpl::hasVerticalScrollbar): Ditto.
(WebKit::WebViewImpl::enableAutoResizeMode): Set-up auto-resize.
(WebKit::WebViewImpl::layoutUpdated): Handle the auto-resize case by
sending events and invalidation.

  • src/WebViewImpl.h: Expose the aut-reosize information.

(WebKit::WebViewImpl::shouldAutoResize):
(WebKit::WebViewImpl::minAutoSize):
(WebKit::WebViewImpl::maxAutoSize):

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad): Added the ability to
specify the WebViewClient.

  • tests/FrameTestHelpers.h: Ditto.
  • tests/WebViewTest.cpp: Added a simple test for auto-resize.

(WebKit::TestData::setWebView):
(WebKit::TestData::setSize): Capture the new size.
(WebKit::TestData::hasHorizontalScrollbar):
(WebKit::TestData::hasVerticalScrollbar):
(WebKit::TestData::width):
(WebKit::TestData::height):
(WebKit::AutoResizeWebViewClient::didAutoResize): Handle the resize event.
(WebKit::AutoResizeWebViewClient::testData):
(WebKit::TEST_F): The actual test.

  • tests/data/specify_size.html: Added.
12:55 AM Changeset in webkit [101758] by commit-queue@webkit.org
  • 10 edits
    2 copies
    1 add in trunk/Source/WebKit/chromium

[Chromium] Support adding/removing page overlay to WebView
https://bugs.webkit.org/show_bug.cgi?id=73235

Patch by Xiyuan Xia <xiyuan@chromium.org> on 2011-12-02
Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebPageOverlay.h: Added.

(WebKit::WebPageOverlay::~WebPageOverlay):

  • public/WebView.h:
  • src/PageOverlay.cpp:

(WebKit::PageOverlay::create):
(WebKit::PageOverlay::PageOverlay):
(WebKit::OverlayGraphicsLayerClientImpl::create):
(WebKit::OverlayGraphicsLayerClientImpl::paintContents):
(WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl):
(WebKit::PageOverlay::update):
(WebKit::PageOverlay::paintWebFrame):
(WebKit::PageOverlay::invalidateWebFrame):

  • src/PageOverlay.h:

(WebKit::PageOverlay::overlay):
(WebKit::PageOverlay::setOverlay):
(WebKit::PageOverlay::zOrder):
(WebKit::PageOverlay::setZOrder):

  • src/PageOverlayList.cpp: Added.

(WebKit::PageOverlayList::create):
(WebKit::PageOverlayList::PageOverlayList):
(WebKit::PageOverlayList::~PageOverlayList):
(WebKit::PageOverlayList::add):
(WebKit::PageOverlayList::remove):
(WebKit::PageOverlayList::update):
(WebKit::PageOverlayList::paintWebFrame):
(WebKit::PageOverlayList::find):

  • src/PageOverlayList.h: Added.

(WebKit::PageOverlayList::empty):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::paintPageOverlay):
(WebKit::WebDevToolsAgentImpl::highlight):
(WebKit::WebDevToolsAgentImpl::hideHighlight):

  • src/WebDevToolsAgentImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::paintWithContext):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::pageOverlays):

12:49 AM BuildingGtk edited by mrobinson@webkit.org
(diff)
12:44 AM Changeset in webkit [101757] by loislo@chromium.org
  • 7 edits in trunk/Tools

Tools/Scripts: eliminate find_test_files from Port class.
https://bugs.webkit.org/show_bug.cgi?id=73553

rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
Also I'll move _is_test_file() and related functions close to Port.tests().

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests):
(Port.is_reference_html_file):
(Port._has_supported_extension):
(Port._is_test_file):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest.test_is_test_file):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):
(ChromiumGpuCgMacPort.tests):
(ChromiumGpuMacPort.tests):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.test_default_tests_paths.test_paths):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files.test_paths):
(ChromiumGpuTest):
(ChromiumGpuTest.test_test_files):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):

12:30 AM Changeset in webkit [101756] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: refactor InspectorBackendDispatcher so that it does not use JSON-serialized command templates.
https://bugs.webkit.org/show_bug.cgi?id=73569

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

  • inspector/Inspector.json:
  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype._wrap.callback):
(InspectorBackendClass.prototype._wrap):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype._invoke):
(InspectorBackendClass.prototype._sendMessageToBackend):
(InspectorBackendClass.prototype._wrapCallbackAndSendMessageObject):

LayoutTests:

  • inspector/report-API-errors-expected.txt:
12:26 AM Changeset in webkit [101755] by commit-queue@webkit.org
  • 14 edits
    8 adds in trunk

Range sliders and spin buttons don't work with multi-columns.
https://bugs.webkit.org/show_bug.cgi?id=70898

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-02
Reviewed by Dan Bernstein.

Source/WebCore:

This patch makes RenderBlock::hitTestColumns and
RenderBoxModelObject::mapAbsoluteToLocal to handle point
in multi-column same logic.

In multi-column, coordinate of box model rendering object is different
from absolute coordinate.. Columns in box model rendering object spans
vertically rather than horizontally.

When absolute point is represented in (column[i]+dx, column[0]+dy),
it is (column[0]+dx, column[0] + columnHeight + dy) in box model
rendering object coordinate.

Tests: fast/events/document-elementFromPoint.html

fast/events/offsetX-offsetY.html
fast/forms/number/spin-in-multi-column.html
fast/forms/range/slider-in-multi-column.html
fast/forms/select/listbox-in-multi-column.html

  • rendering/RenderBlock.cpp:

(WebCore::ColumnRectIterator::ColumnRectIterator): Added
(WebCore::ColumnRectIterator::advance): Added
(WebCore::ColumnRectIterator::columnRect): Added
(WebCore::ColumnRectIterator::hasMore): Added
(WebCore::ColumnRectIterator::adjust): Added
(WebCore::ColumnRectIterator::update): Added
(WebCore::RenderBlock::hitTestColumns): Use ColumnRectIterator.
(WebCore::RenderBlock::adjustForColumnRect): Added

  • rendering/RenderBlock.h: Add adjustForColumnRect.
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint): Call RenderBoxModelObject::mapAbsoluteToLocalPoint.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Move from RenderInline::mapAbsoluteToLocalPoint and call RenderBlock::adjustForColumnRect.

  • rendering/RenderBoxModelObject.h: add mapAbsoluteToLocalPoint.
  • rendering/RenderInline.cpp: Move mapAbsoluteToLocalPoint to RenderBoxModelObject.
  • rendering/RenderInline.h: remove mapAbsoluteToLocalPoint.

LayoutTests:

  • fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • fast/events/offsetX-offsetY.html: Change offset for "in-columns" test.
  • fast/forms/listbox/listbox-in-multi-column-expected.txt: Added.
  • fast/forms/listbox/listbox-in-multi-column.html: Added.
  • fast/forms/number/spin-in-multi-column-expected.txt: Added.
  • fast/forms/number/spin-in-multi-column.html: Added.
  • fast/forms/range/slider-in-multi-column-expected.txt: Added.
  • fast/forms/range/slider-in-multi-column.html: Added.
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • platform/efl/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt: Change offset for "in-columns" test.
12:21 AM Changeset in webkit [101754] by pfeldman@chromium.org
  • 9 edits in trunk

InspectorController destruction order leads to use-after-free
https://bugs.webkit.org/show_bug.cgi?id=73582

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorBaseAgent.h:

(WebCore::InspectorBaseAgentInterface::discardAgent):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::~InspectorCSSAgent):
(WebCore::InspectorCSSAgent::discardAgent):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::~InspectorController):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::discardAgent):

  • inspector/InspectorDOMDebuggerAgent.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:05 AM Changeset in webkit [101753] by leo.yang@torchmobile.com.cn
  • 6 edits
    3 adds in trunk

image element with src attribute can't be replaced by content: url() style
https://bugs.webkit.org/show_bug.cgi?id=42840

Source/WebCore:

ImageLoader were updating renderer even if the renderer's image is
style generated content. This was wrong because if an image element
with src attribute and style="content: url(...)" attribute the
src image might override content image. The correct behavior should
be showing content image.

This patch is differentiating style generated RenderImage from the
normal RenderImage and keeps the RenderImageSource untouched if the
renderer is generated content.

Reviewed by Darin Adler.

Test: fast/images/image-css3-content-data.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::renderImageResource):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):

  • rendering/RenderImage.h:

(WebCore::RenderImage::setIsGeneratedContent):
(WebCore::RenderImage::isGeneratedContent):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

LayoutTests:

Test case contains image element with src attribute and "content: url(...)"
style attribute.

Reviewed by Darin Adler.

  • fast/images/image-css3-content-data-expected.txt: Added.
  • fast/images/image-css3-content-data.html: Added.
  • fast/images/resources/green-24x24.jpg: Added.

Dec 1, 2011:

11:47 PM Changeset in webkit [101752] by levin@chromium.org
  • 3 edits in trunk/Source/WebCore

Add a way to automatically size a single frame to fit its content.
https://bugs.webkit.org/show_bug.cgi?id=73420

Reviewed by Dmitry Titov.

No new functionality exposed so no new tests. (There is a Chromium
specific test in https://bugs.webkit.org/show_bug.cgi?id=73058.)

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): Initialized the new variables.
(WebCore::FrameView::layout):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::enableAutoSizeMode):

  • page/FrameView.h:
11:33 PM Changeset in webkit [101751] by commit-queue@webkit.org
  • 26 edits
    2 copies
    4 adds in trunk

JS_INLINE and WTF_INLINE should be visible from WebCore
https://bugs.webkit.org/show_bug.cgi?id=73191

Source/JavaScriptCore:

  • Moved Export related macro definitions from config.h to ExportMacros.h and JSExportMacros.h.
  • Moved WTF_USE_JSC and WTF_USE_V8 from various config.h family to Platform.h.
  • Replaced JS_EXPORTDATA in wtf moudule with newly introduced WTF_EXPORTDATA.

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • runtime/JSExportMacros.h: Added.
  • wtf/ExportMacros.h:
  • wtf/Platform.h:
  • wtf/WTFThreadData.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringStatics.cpp:

Source/JavaScriptGlue:

  • Extracted export related macro definitions to ExportMacros.h and JSExportMacros.h
  • Added forwarding headers which used in config.h

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • ForwardingHeaders/runtime/JSExportMacros.h: Added.
  • ForwardingHeaders/wtf/ExportMacros.h: Added.
  • config.h:

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

  • Moved export related definitions from config.h to ExportMacros.h, JSExportMacros.h and PlatformExportMacros.h
  • Added forwarding headers which are referred from config.h

No new tests. Only build related changes.

  • ForwardingHeaders/runtime/JSExportMacros.h: Added.
  • ForwardingHeaders/wtf/ExportMacros.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/PlatformExportMacros.h: Copied from Source/JavaScriptCore/wtf/ExportMacros.h.

Source/WebKit/cf:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • WebKitPrefix.h:

Source/WebKit/qt:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Added a INCLUDEPATH to make JSExportMacros.h visible.

  • tests/MIMESniffing/MIMESniffing.pro

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • config.h:

Tools:

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-01
Reviewed by Kevin Ollivier.

Removed macro definitions which is now provided by Platform.h

  • DumpRenderTree/chromium/config.h:
  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
11:13 PM Changeset in webkit [101750] by jonlee@apple.com
  • 29 edits
    1 copy in trunk/Source

[WK2] Add further support for notifications
https://bugs.webkit.org/show_bug.cgi?id=73572
<rdar://problem/10472195>

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Export constructor and dispatch functions
  • dom/EventNames.h: Add show event.
  • notifications/Notification.cpp:

(WebCore::Notification::show): For the Mac platform, we just forward the show() call to the
notification client and update the state, because we cannot get synchronous acknowledgment that the
notification got delivered.
(WebCore::Notification::dispatchShowEvent): Create simple events and dispatch to the notification.
(WebCore::Notification::dispatchClickEvent): Ditto.
(WebCore::Notification::dispatchCloseEvent): Ditto.
(WebCore::Notification::dispatchErrorEvent): Ditto.

  • notifications/Notification.h: Add dispatch functions.
  • notifications/Notification.idl: Add onshow event listener. The ondisplay event listener should be

removed when implementations change the event listener to onshow.

Source/WebKit2:

  • WebProcess/Notifications/WebNotificationManager.messages.in: Added. Contains messages for callbacks

from the notification platform.

  • DerivedSources.make: Add WebNotificationManager.
  • DerivedSources.pri: Ditto.
  • Platform/CoreIPC/MessageID.h: Add message class.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Forward calls to WebNotificationManager when needed.

  • WebKit2.xcodeproj/project.pbxproj: Add new message files.
  • win/WebKit2.vcproj: Adding new files to project.
  • win/WebKit2Common.vsprops: Add Notifications to include paths
  • UIProcess/WebNotification.h: Add and expose internal ID of each notification sent to the platform.

(WebKit::WebNotification::create):
(WebKit::WebNotification::notificationID):
(WebKit::isNotificationIDValid): Checks that the ID is not a value that might trip up the HashMaps used
for mapping IDs to notifications.

  • UIProcess/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::encode):
(WebKit::WebNotification::decode):

  • UIProcess/API/C/WKNotification.h: Expose notification ID to WKAPI.
  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationGetNotificationID):

  • UIProcess/WebNotificationManagerProxy.h: Add callbacks for dispatching events back to the notification.
  • UIProcess/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::invalidate): Remove manager.
(WebKit::WebNotificationManagerProxy::show): Add manager prior to showing.
(WebKit::WebNotificationManagerProxy::cancel): Add manager prior to canceling.
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

  • UIProcess/API/C/WKNotificationManager.h:
  • UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerProviderDidShowNotification):
(WKNotificationManagerProviderDidClickNotification):
(WKNotificationManagerProviderDidCloseNotifications):

  • UIProcess/WebNotificationProvider.h:
  • UIProcess/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):
(WebKit::WebNotificationProvider::cancel):
(WebKit::WebNotificationProvider::didDestroyNotification):
(WebKit::WebNotificationProvider::addNotificationManager):
(WebKit::WebNotificationProvider::removeNotificationManager):

  • UIProcess/API/C/WKNotificationProvider.h: Expose add/removeNotificationManager calls
  • WebProcess/Notifications/WebNotificationManager.h: Add bookkeeping to keep track of notification IDs with

Notification instances.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::generateNotificationID):
(WebKit::WebNotificationManager::didReceiveMessage):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):

  • UIProcess/WebNotificationManagerProxy.messages.in: Add DidDestroyNotification message.
  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::notificationObjectDestroyed): Implemented.

11:12 PM Changeset in webkit [101749] by Csaba Osztrogonác
  • 10 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r101742, update Qt specific expected files.

  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/test_expectations.txt:
11:06 PM Changeset in webkit [101748] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r101723.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
11:04 PM Changeset in webkit [101747] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Changes proposed for 73457 slow down Kraken json-parse-financial
https://bugs.webkit.org/show_bug.cgi?id=73584

Restructured StringImpl::equal to take advantage of 8 or 4 bytes
at a time when possible.

This is worth ~3% on Kraken json-parse-financial. It provides
~2% on SunSpider string-unpack-code.

Reviewed by Sam Weinig.

  • wtf/text/StringImpl.cpp:

(WTF::equal):

11:01 PM Changeset in webkit [101746] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WEBKIT2] Fix for compilation warnings in WebContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=69080

Fix compilation warning in WebKit2 builds.

Patch by Goutham J <gouthamj@motorola.com> on 2011-12-01
Reviewed by Hajime Morita.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::startMemorySampler):

10:55 PM Changeset in webkit [101745] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r101742.

Remove tests from test_expectation.txt , because they are
in Skipped list too and NRWT can't handle this situation.
(See https://bugs.webkit.org/show_bug.cgi?id=69750 for details.)

  • platform/qt/test_expectations.txt:
10:39 PM Changeset in webkit [101744] by ryuan.choi@samsung.com
  • 18 edits in trunk/Source/WebKit

[EFL] Cleanup includes to reduce code complexity.
https://bugs.webkit.org/show_bug.cgi?id=73540

Reviewed by Gustavo Noronha Silva.

Source/WebKit:

  • CMakeLists.txt: Add loader/appcache to WebKit_INCLUDE_DIRECTORIES.

Source/WebKit/efl:

EWebKit.h is a list of public header files for application to use WebKit/Efl.
This patch removes EWebKit.h in internal files to reduce unnecessary includes.
In addition, reorders optional includes to fix style.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/EditorClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_auth_soup.cpp:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_history.cpp:
  • ewk/ewk_main.cpp:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_util.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
  • ewk/ewk_window_features.cpp:
10:32 PM Changeset in webkit [101743] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Focus ring of imagemap's area element does not scale when CSS zoom style is applied
https://bugs.webkit.org/show_bug.cgi?id=73595

Patch by Max Vujovic <mvujovic@adobe.com> on 2011-12-01
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/images/imagemap-focus-ring-zoom-style-expected.html

fast/images/imagemap-focus-ring-zoom-style.html

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::computePath):
The computePath method now uses the RenderObject's effectiveZoom
instead of the Frame's page zoom to compute the path for the area
element's focus ring.

LayoutTests:

  • fast/images/imagemap-focus-ring-zoom-style-expected.html: Added.
  • fast/images/imagemap-focus-ring-zoom-style.html: Added.
10:23 PM Changeset in webkit [101742] by tkent@chromium.org
  • 15 edits
    2 adds in trunk

REGRESSION(r90971): Placeholder text of input control is rendered
over positioned elements with z-index:0.
https://bugs.webkit.org/show_bug.cgi?id=67408

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by "position:relative" in the default style of
-webkit-input-placeholder. If there were other positioned elements
with z-index:0, a placeholder might be rendered over them.

"position:relative" is not needed because RenderTextControlSingleLine
and RenderTextControlMultipleLine lay out the placeholder renderer by
custom layout code.

Tests: fast/forms/placeholder-with-positioned-element.html

  • css/html.css:

(::-webkit-input-placeholder): Remove position:relative.

LayoutTests:

Need to update some placeholder-related tests because we don't use position:relative.

  • fast/forms/placeholder-with-positioned-element-expected.html: Added.
  • fast/forms/placeholder-with-positioned-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/test_expectations.txt:
9:39 PM Changeset in webkit [101741] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Removed unused multiLength argument in setLengthProperty().
<http://webkit.org/b/73602>

Reviewed by Darin Adler.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setLengthProperty):

  • css/CSSMutableStyleDeclaration.h:
8:51 PM Changeset in webkit [101740] by haraken@chromium.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r101737.
http://trac.webkit.org/changeset/101737
https://bugs.webkit.org/show_bug.cgi?id=73394

Chromium/Mac and Chromium/Win build are broken

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
8:32 PM Changeset in webkit [101739] by hayato@chromium.org
  • 7 edits
    1 add in trunk/Tools

Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
https://bugs.webkit.org/show_bug.cgi?id=73406

Reviewed by Ryosuke Niwa.

WebKitPort's image_diff uses tolerance='0.1' in default.
When reftests fail, we should use tolerace=0 when diff-ing images.

Since ImageDiff on chromium port doesn't use tolerance value as of now,
this change doesn't affect chromium port's behavior.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.diff_image):
(WebKitPort._start_image_diff_process):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

8:12 PM Changeset in webkit [101738] by commit-queue@webkit.org
  • 4 edits
    4 adds
    5 deletes in trunk/LayoutTests

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73581

Patch by Jacob Goldstein <jacobg@adobe.com> on 2011-12-01
Reviewed by David Hyatt.

  • fast/regions/content-flowed-into-regions-dynamically-added-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-added.html:
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.html: Added.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html:
  • fast/regions/content-flowed-into-regions-expected.html: Added.
  • fast/regions/content-flowed-into-regions-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions.html:
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
  • platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.
8:11 PM Changeset in webkit [101737] by haraken@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
7:39 PM Changeset in webkit [101736] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] StyleAttributeMutationScope shouldn't be implemented with static classes
https://bugs.webkit.org/show_bug.cgi?id=73596

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-01
Reviewed by Ojan Vafai.

No tests needed. This patch is a minor refactor.

  • css/CSSMutableStyleDeclaration.cpp:
7:31 PM Changeset in webkit [101735] by adamk@chromium.org
  • 4 edits in trunk/Tools

Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=73599

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:

():
(htmlForTestTypeSwitcher):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForTestTypeSwitcherGroup):

6:59 PM Changeset in webkit [101734] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Remove unused function setStringProperty().
<http://webkit.org/b/73597>

Reviewed by Darin Adler.

  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.h:
6:39 PM Changeset in webkit [101733] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r101268): Intermittent assertion failure in fast/block/child-not-removed-from-parent-lineboxes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=73250

Reviewed by Darin Adler.

Reset the position when exiting early in layoutRunsAndFloatsInRange.

No new tests because we don't have a reliable reproduction for this failure.
However, the failure is caught by the existing fast/block/child-not-removed-from-parent-lineboxes-crash.html
intermittently with about 30% probability.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

6:38 PM Changeset in webkit [101732] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking increased flakiness in test_expectations
inspector/debugger/script-formatter-breakpoints.html

  • platform/chromium/test_expectations.txt:
6:15 PM Changeset in webkit [101731] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-01
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request.

Test: editing/spelling/spellcheck-queue.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):

A structure to have spell check request.

(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

When timer is fired, queued request is processed if any.

(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):

When the spellchecker is processing another request, the latest request is queued.

(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):

Enqueues a request. If there is an older request whose root editable element is the same as the request,
it will be replaced.

(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

  • editing/spelling/spellcheck-queue-expected.txt: Added.
  • editing/spelling/spellcheck-queue.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
5:58 PM Changeset in webkit [101730] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

bufferedAmount calculation is wrong in CLOSING and CLOSED state.
https://bugs.webkit.org/show_bug.cgi?id=73404

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-01
Reviewed by Kent Tamura.

Source/WebCore:

WebSocket::bufferedAmount() must return buffered frame size including
disposed frames which are passed via send() calls after close().

Old implementation had a problem at CLOSING state. Buffered frame size
was added to m_bufferedAmountAfterClose at close(). But the function
returns the sum of m_bufferedAmountAfterClose and internally buffered
frame size, or m_channel->bufferedAmount(). So, buffered frames was
double counted.

In new implementation, m_bufferedAmount always represents buffered
frame size and m_bufferedAmountAfterClose does disposed frame size.
As a result, bufferedAmount() implementation become just to return the
sum of m_bufferedAmount and m_bufferedAmountAfterClose.

Test: http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html

  • websockets/WebSocket.cpp: Implement new bufferedAmount handling.

(WebCore::saturateAdd):
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didClose):

  • websockets/WebSocket.h:

LayoutTests:

Add a layout test to check the WebSocket bufferedAmount property.
This test close the socket channel when it is busy and buffer some
message frames, then check the property's value in CLOSING and CLOSED
state.

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt: Added.
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html: Added.
5:56 PM Changeset in webkit [101729] by oliver@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Support integer typed arrays in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73608

Reviewed by Filip Pizlo.

Add support for all the integral typed arrays in the DFG JIT.
Currently this loads the contents of Uint32 arrays as doubles,
which is clearly not as efficient as it could be, but this is
still in the order of 10-20x faster than the existing behaviour.

This needed us to add support for writing 16bit values to the
macroassembler, and also to support double<->unsigned conversion.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::strh):
(JSC::ARMv7Assembler::vcvt_floatingPointToUnsigned):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::store16):
(JSC::MacroAssemblerARMv7::truncateDoubleToUint32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store16):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movw_rm):
(JSC::X86Assembler::cvttsd2siq_rr):

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC::isInt8ArrayPrediction):
(JSC::isInt16ArrayPrediction):
(JSC::isInt32ArrayPrediction):
(JSC::isUint8ArrayPrediction):
(JSC::isUint16ArrayPrediction):
(JSC::isUint32ArrayPrediction):
(JSC::isFloat32ArrayPrediction):
(JSC::isFloat64ArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalData.h:
5:47 PM Changeset in webkit [101728] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking Flakey tests in test_expectations:

  • platform/chromium/test_expectations.txt:

inspector/styles/styles-computed-trace.html
fast/canvas/canvas-overloads-strokeText.html

5:46 PM Changeset in webkit [101727] by rniwa@webkit.org
  • 9 edits in trunk/Tools

Parse reftest.list and extract types of ref tests
https://bugs.webkit.org/show_bug.cgi?id=66837

Reviewed by Dirk Pranke.

Add support for reftest.list to base port.

  • Scripts/webkitpy/common/find_files.py:

(find):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init): Initialize self._reftest_list. It's a dictionary mapping from a test directory
to a dictionary of {test path: ("==" or "!=", reference file path)}
(Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
(Port._reference_file_for): Added; obtains the reference file name given a test name.
(Port.is_reftest): Added; Calls _reference_file_for.
(Port.reftest_expected_filename): Calls _reference_file_for.
(Port.reftest_expected_mismatch_filename): Ditto.
(Port.find_test_files):
(is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
-expected, -expected-mismach, -ref, or -notref as a reference file.
(_is_test_file):
(_parse_reftest_list): Added.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_is_test_file):
(PortTest.test_parse_reftest_list):

  • Scripts/webkitpy/layout_tests/port/dryrun.py:

(DryrunDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_filesystem.add_test_file):
(unit_test_filesystem.add_file):
(unit_test_filesystem):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):
(MainTest.test_unexpected_failures):
(MainTest.test_missing_and_unexpected_results):
(EndToEndTest.test_end_to_end):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(Rebaseliner._compile_rebaselining_tests):

5:32 PM Changeset in webkit [101726] by commit-queue@webkit.org
  • 7 edits
    4 deletes in trunk/Source/WebKit/efl

[EFL] Remove the ewk_protocol_handler-related code
https://bugs.webkit.org/show_bug.cgi?id=73018

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-12-01
Reviewed by Martin Robinson.

This functionality has been broken since r99364, which stopped setting
the "webkit-resource" property needed by
ewk_protocol_handler_soup.cpp.

After giving it some thought, it looks clear that this code should not
be in ewk at all: it is very backend-specific (even in the function
signatures it expects), and it only allows callers to register schemes
once and provide a single handler to all of them, which does not make
much sense.

Client code using WebKit-EFL with the soup backend should be
responsible for creating their own request handlers (ie. subclass
SoupRequest) instead.

For that to be possible, a function which returns the default
SoupSession used by WebKit has been added.

  • CMakeListsEfl.txt:
  • ewk/ewk_network.cpp:

(ewk_network_default_soup_session_get):

  • ewk/ewk_network.h:
  • ewk/ewk_private.h:
  • ewk/ewk_protocol_handler.cpp: Removed.
  • ewk/ewk_protocol_handler.h: Removed.
  • ewk/ewk_protocol_handler_soup.cpp: Removed.
  • ewk/ewk_protocol_handler_soup.h: Removed.
  • ewk/ewk_view.cpp:
  • ewk/ewk_view.h:
5:14 PM Changeset in webkit [101725] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk/Tools

Unreviewed, rolling out r101711.
http://trac.webkit.org/changeset/101711
https://bugs.webkit.org/show_bug.cgi?id=73605

Broke 3 webkitpy tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-01

  • Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_cpp):
(CheckerDispatcherDispatchTest.test_cpp_paths):

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
5:03 PM Changeset in webkit [101724] by haraken@chromium.org
  • 13 edits
    2 deletes in trunk

Replace a custom constructor of window.Option with the [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=73498

Reviewed by Adam Barth.

Removes JSOptionConstructor.{h,cpp} and generates the constructor of window.Option
by the [NamedConstructor] IDL.

Source/WebCore:

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • GNUmakefile.list.am: Removed JSOptionConstructor.{h,cpp}.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::option): Specifies the NamedConstructor.

  • bindings/js/JSOptionConstructor.cpp: Removed.
  • bindings/js/JSOptionConstructor.h: Removed.
  • page/DOMWindow.idl: Removed the [JSCustomConstructor] IDL.

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Updated the test result.
4:59 PM Changeset in webkit [101723] by haraken@chromium.org
  • 13 edits
    2 deletes in trunk

Replace a custom constructor of window.Audio with the [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=73496

Reviewed by Adam Barth.

Removes JSAudioConstructor.{h,cpp} and generates the constructor of window.Audio
by the [NamedConstructor] IDL.

Source/WebCore:

Tests: fast/js/custom-constructors.html

media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html

  • GNUmakefile.list.am: Removed JSAudioConstructor.{h,cpp}.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSAudioConstructor.cpp: Removed.
  • bindings/js/JSAudioConstructor.h: Removed.
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::audio): Specifies the NamedConstructor.

  • page/DOMWindow.idl: Removed the [JSCustomConstructor] IDL.

LayoutTests:

  • platform/mac/fast/dom/Window/window-properties-expected.txt: Updated the test result.
4:52 PM Changeset in webkit [101722] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking animations/play-state.html even flakier in test_expectations

  • platform/chromium/test_expectations.txt:
4:49 PM Changeset in webkit [101721] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[FileSystem API] resolveLocalFileSystemURL required arguments
https://bugs.webkit.org/show_bug.cgi?id=69649

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Darin Adler.

  • fast/filesystem/not-enough-arguments-expected.txt:
  • fast/filesystem/not-enough-arguments.html:
4:35 PM Changeset in webkit [101720] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing test_expectations error

  • platform/chromium/test_expectations.txt:
3:32 PM Changeset in webkit [101719] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=73592
REGRESSION (r100483): Can't drag out of background window
-and corresponding-
<rdar://problem/10508870>

Reviewed by Darin Adler.

If the mouse is pressed we need to do a full, normal hit test even if the window
is not active.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

3:17 PM Changeset in webkit [101718] by commit-queue@webkit.org
  • 5 edits in trunk

[FileSystem API] DirectoryEntry.removeRecursively successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69644

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

Source/WebCore:

  • fileapi/DirectoryEntry.idl: remove [Optional] flag from successCallback

LayoutTests:

  • fast/filesystem/not-enough-arguments-expected.txt: add removeRecursively test result
  • fast/filesystem/not-enough-arguments.html: add removeRecursively test
3:14 PM Changeset in webkit [101717] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[FileSystem API] DirectoryEntry.getDirectory path argument is required
https://bugs.webkit.org/show_bug.cgi?id=69643

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-getdirectory.html

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getDirectory): throw TypeError if not enough arguments

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback): throw TypeError if not enough arguments

LayoutTests:

  • fast/filesystem/resources/simple-required-arguments-getdirectory.js: Added.

(errorCallback):
(successCallback):

  • fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Added.
  • fast/filesystem/simple-required-arguments-getdirectory.html: Added.
3:06 PM Changeset in webkit [101716] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
https://bugs.webkit.org/show_bug.cgi?id=73576

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

No tests needed. This patch is just bindings hygiene.

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

3:00 PM Changeset in webkit [101715] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.

  • Scripts/webkitpy/common/config/watchlist:
2:56 PM Changeset in webkit [101714] by kov@webkit.org
  • 3 edits in trunk/Tools

Unreviewed. Fix bad file =(.

  • gtk/jhbuild.modules:
  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProject):

2:51 PM Changeset in webkit [101713] by benjamin@webkit.org
  • 16 edits
    2 adds in trunk

URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.

(WTF::equal):

  • wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Source/WebCore:

Previously, invalid URLs could have a string emanating from a
partial parsing of the input. The creation of the string was done
through the Latin1 codec regardless of the encoding of the char* url.

This caused two types of issues, URLs were evaluated as half-parsed,
and the coding and decoding of the string was not consistent.

This patch changes KURL::parse() to fallback on the original string
whenever the parsing of the URL fails.

Test: fast/url/invalid-urls-utf8.html

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):
Previously, originalString was only used as an optimization to avoid
the allocation of a string. Since this optimization depends on the
comparison of the incoming string and the encoded buffer.
This patches generalizes originalString to always be the original string
being parsed by KURL. The optimization is kept by comparing that string
and the final parsed result.

  • platform/KURL.h:

(WebCore::KURL::parse):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/invalid-urls-utf8-expected.txt: Added.
  • fast/url/invalid-urls-utf8.html: Added.

New test for invalid URL where the Unicode characters were mangled
by the parsing.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:

Two urls where expended by their base URL before found invalid. The partial
parsed result was saved as the new URL.

  • fast/url/host-expected.txt:

The host of two urls were invalid, and partially modified by the parsing.

  • fast/url/idna2003-expected.txt:

The first 'http://www.lookout.net⩴80/' encoded for parsing is http://www.lookout.net::=80/
and fails as invalid. The new result does not modify the original string.

The whitespace in 'http://www .lookout.net/' causes the parsing to fail when parsing
the username because a space is not a UserInfoChar.

  • fast/url/port-expected.txt:

The unicode characters used as the port number were transformed due to
the encoding UTF-8 -> Unicode through the Latin1 codec.

  • platform/chromium/test_expectations.txt: Skip the test on Chromium for now since Google URL

does not implement the extended version of parse().

2:45 PM Changeset in webkit [101712] by mrobinson@webkit.org
  • 6 edits in trunk

[GTK] Read fonts from the jhbuild root
https://bugs.webkit.org/show_bug.cgi?id=73487

Reviewed by Gustavo Noronha Silva.

Read fonts from the jhbuild root instead of from the system. This will ensure
that all testers use the same fonts instead of leaving this up to luck.

Source/JavaScriptCore:

  • wtf/gobject/GlibUtilities.h: Add Assertions.h which was required for the WebKit2TestRunner.

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeFonts): Load fonts from jhbuild root.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server): Pass an environment variable containing
the path to the jhbuild root.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.

2:37 PM Changeset in webkit [101711] by Adam Roben
  • 3 edits
    2 adds in trunk/Tools

Teach check-webkit-style how to check the syntax of JSON files

Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checker.py:

(_all_categories): Added JSONChecker's categories to the set of all categories.
(FileType): Added a JSON type. Incremented other types.
(CheckerDispatcher._file_type): Use the JSON file type for .json files.
(CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
(CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.

  • Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",

which would have matched our other checkers, because I couldn't figure out how to call
"json.loads" without hitting namespace conflicts.)
(JSONChecker.init): Turn of line filtering so that we always check the whole file, not
just the modified lines from a patch.
(JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
exception.
(JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
try to extract a line number.

  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.

(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
Helper class. Copied from xml_unittest.py.

(JSONCheckerTest.test_line_number_from_json_exception): Test the
line_number_from_json_exception helper method.

(JSONCheckerTest.assert_no_error):
(JSONCheckerTest.assert_error):
Helper methods to assert that we did or didn't get an error.

(JSONCheckerTest.mock_handle_style_error): Helper method.

(JSONCheckerTest.test_conflict_marker):
(JSONCheckerTest.test_single_quote):
(JSONCheckerTest.test_init):
(JSONCheckerTest.test_missing_closing_brace):
(JSONCheckerTest.test_no_error):
Test various cases.

2:31 PM Changeset in webkit [101710] by mrobinson@webkit.org
  • 10 edits
    2 adds in trunk

[GTK] Add a helper function to find the current executable's path
https://bugs.webkit.org/show_bug.cgi?id=73473

Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

Add a WTF helper which gets the binary path. This is currently only used
in WebKit2.

  • GNUmakefile.list.am: Add the new file to the source list.
  • wtf/gobject/GlibUtilities.cpp: Added.

(getCurrentExecutablePath):

  • wtf/gobject/GlibUtilities.h: Added.

Source/WebCore:

No new tests. This should not change behavior.

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::applicationDirectoryPath): Now use the new WTF function to get the
current executable's path.

Source/WebKit2:

Do a series of tests when looking for processes. First search the directory
specified by the environment variable, then the directory of the binary and
then the LIBEXECDIR.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::findWebKitProcess): Added.
(WebKit::ProcessLauncher::launchProcess): Call the new helper to get the
binary location.

Tools:

Update MiniBrowser to not pass the binary directory as an environment variable.
This means that you can move the binaries around without it breaking.

  • MiniBrowser/gtk/main.c:

(main): No longer set the environment variable.

  • WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
  • WebKitTestRunner/gtk/main.cpp: Ditto.
2:25 PM Changeset in webkit [101709] by jochen@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] add referrer policy to WebContextMenuData
https://bugs.webkit.org/show_bug.cgi?id=73567

Reviewed by Darin Fisher.

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

2:25 PM Changeset in webkit [101708] by kov@webkit.org
  • 3 edits in trunk/Tools

[GTK] Add freetype to our jhbuild setup
https://bugs.webkit.org/show_bug.cgi?id=73488

Reviewed by Martin Robinson.

This adds the first library to our jhbuild setup, and makes sure
build-webkit calls autogen.sh and make with jhbuild, so that the
environment is properly set.

  • Scripts/webkitdirs.pm:

(saveSum):
(hashFile):
(runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
call autogen under jhbuild run;
(mustRunAutogen): generalized the arguments change checking to also force
running autogen when jhbuild files change;
(buildAutotoolsProject): run make under jhbuild;

  • gtk/jhbuild.modules: add freetype.
2:22 PM Changeset in webkit [101707] by kling@webkit.org
  • 12 edits in trunk/Source/WebCore

StyledElement: Clean up inline style accessors.
<http://webkit.org/b/73568>

Reviewed by Antti Koivisto.

Renamed StyledElement's getInlineStyleDecl() to ensureInlineStyleDecl() to
make it clear that it will always return non-null as opposed to inlineStyleDecl().

Also updated call sites to store the return value in a CSSInlineStyleDeclaration*
rather than a CSSMutableStyleDeclaration*, and reduced scoping of temporaries
in some cases.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::parseMappedAttribute):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterValueElement::setWidthPercentage):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressValueElement::setWidthPercentage):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

2:16 PM Changeset in webkit [101706] by knorton@google.com
  • 4 edits in trunk/Source

More void functions eager to return values in RenderObject & WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=73571

Reviewed by Adam Barth.

Source/WebCore:

  • rendering/RenderObject.h:

(WebCore::RenderObject::computeAbsoluteRepaintRect):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::ChromePrintContext::computePageRects):

2:12 PM Changeset in webkit [101705] by scheib@chromium.org
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r101691.
http://trac.webkit.org/changeset/101691
https://bugs.webkit.org/show_bug.cgi?id=73588

Tests fail on Chromium bots, early warning system warned
committer, please adjust test_expectations in patch (Requested
by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-01

Source/JavaScriptCore:

Source/WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):

  • platform/KURL.h:
  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/host-expected.txt:
  • fast/url/idna2003-expected.txt:
  • fast/url/invalid-urls-utf8-expected.txt: Removed.
  • fast/url/invalid-urls-utf8.html: Removed.
  • fast/url/port-expected.txt:
2:08 PM Changeset in webkit [101704] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[Chromium] Add the FontCache implementation for Android
https://bugs.webkit.org/show_bug.cgi?id=73452

Add the FontCache implementation specific for the Chromium WebKit
port on Android, and include various font-related files intended for
Linux which can be re-used.

Patch by Peter Beverloo <peter@chromium.org> on 2011-12-01
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/FontCacheAndroid.cpp: Added.

(WebCore::getFallbackFontName):
(WebCore::isFallbackFamily):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):

1:51 PM Changeset in webkit [101703] by tony@chromium.org
  • 18 edits in trunk

Need to implement flex-flow: row-reverse
https://bugs.webkit.org/show_bug.cgi?id=70778

Reviewed by Ojan Vafai.

Source/WebCore:

We can't just change the direction of the FlexOrderIterator because we want the overflow to be
on the left side. Instead, we apply similar logic as when we're laying out RTL content. Putting
the check in isLeftToRightFlow() lets us flip the flexbox's border and padding and the flexitems'
margins. We then layout from right to left in layoutAndPlaceChildren.

Also remove 2 uncalled functions.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isReverseFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-flow-expected.txt:
  • css3/flexbox/flex-flow.html: Added test cases to make sure start and end still apply to the text flow direction.
  • css3/flexbox/flex-flow-border-expected.txt:
  • css3/flexbox/flex-flow-border.html: Single flexitem, so reverse does nothing
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt:
  • css3/flexbox/flex-flow-margins-auto-size.html: Ditto. The orthogonal tests fail, but they've always failed.
  • css3/flexbox/flex-flow-margins-expected.txt:
  • css3/flexbox/flex-flow-margins.html: Ditto.
  • css3/flexbox/flex-flow-orientations-expected.txt:
  • css3/flexbox/flex-flow-orientations.html: This test has 2 flexitems, the positions of which are now flipped.
  • css3/flexbox/flex-flow-overflow-expected.txt:
  • css3/flexbox/flex-flow-overflow.html: The overflow should go in the opposite direction. That is, the overflow

of rtl should be the same as row-reverse.

  • css3/flexbox/flex-flow-padding-expected.txt:
  • css3/flexbox/flex-flow-padding.html: Single flexitem, no change.
1:44 PM Changeset in webkit [101702] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Early returns in calculateDrawTransformsAndVisibilityInternal() are not respected by parent.
https://bugs.webkit.org/show_bug.cgi?id=73270

Non-drawing child trees should not be added to the parent render surface's layer list
and should neither extend the parent layer's drawable content rect.

This also fixes assertions from the content texture residency logic, which doesn't like it
if we try to use a render surface through a parent, while that surface itself was never 'used'
in the same frame.

Patch by Daniel Sievers <sievers@chromium.org> on 2011-12-01
Reviewed by James Robinson.

Source/WebCore:

Added unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

1:32 PM Changeset in webkit [101701] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Use contentBounds instead of bounds for invalidation.
https://bugs.webkit.org/show_bug.cgi?id=73525

Patch by David Reveman <reveman@chromium.org> on 2011-12-01
Reviewed by James Robinson.

Use setNeedsDisplay() instead of setNeedsDisplayRect() when possible.

Source/WebCore:

No new tests.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::repaint):

1:13 PM Changeset in webkit [101700] by dmazzoni@google.com
  • 4 edits in trunk/Tools

Fix WebKitTestRunner compile warnings with XCode 3.2
https://bugs.webkit.org/show_bug.cgi?id=73378

Reviewed by Chris Fleizach.

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:

(WTR::AccessibilityTextMarker::AccessibilityTextMarker):

  • WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:

(WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::verticalScrollbar):

12:36 PM Changeset in webkit [101699] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Add missing fields to constructor initializer list.
<http://webkit.org/b/73565>

Reviewed by Antti Koivisto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

12:19 PM Changeset in webkit [101698] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Get rid of the unused function nameForCursorType()
https://bugs.webkit.org/show_bug.cgi?id=73529

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-01
Reviewed by Joseph Pecoraro.

The function nameForCursorType was introduced in r63339 and has not been used anywhere
since that commit.

  • WebCore.exp.in:
  • platform/Cursor.cpp:
  • platform/Cursor.h:
12:04 PM Changeset in webkit [101697] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction.
<http://webkit.org/b/73564>

Reviewed by Antti Koivisto.

Use HashMap::find() instead of contains() followed by get() on
successful lookup.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

12:02 PM Changeset in webkit [101696] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Cleaning up comments and unused portions of a webgl test, as per review comments.
https://bugs.webkit.org/show_bug.cgi?id=73033

Patch by Jeff Timanus <twiz@chromium.org> on 2011-12-01
Reviewed by Stephen White.

  • fast/canvas/webgl/webgl-texture-binding-preserved.html:
11:58 AM Changeset in webkit [101695] by Adam Roben
  • 2 edits
    2 adds in trunk/Tools

Allow committers to use their Trac credentials to force builds on the buildbots

Fixes <http://webkit.org/b/73353>

A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
three files to do its job: a config file that contains a list of WebKit committer usernames,
an htdigest file that contains Trac credentials, and JSON file that gives the paths for
those two files.

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.

(Error): Basic wrapper around Exception that we use for cases where we couldn't even check
whether credentials were valid or not.
(CommitterAuth.init): Just store the path to auth.json.
(CommitterAuth.auth_json): Load, parse, and return auth.json.
(CommitterAuth.auth_json_filename): Return the path to auth.json.
(CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
credentials are valid Trac credentials. Return false otherwise or if an error occurred while
checking those conditions.
(CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
false otherwise or if an exception was thrown.
(CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
Trac credentials htdigest file. Return false otherwise or if an exception was thrown.

(CommitterAuth.open_auth_json_file):
(CommitterAuth.open_trac_credentials_file):
(CommitterAuth.open_webkit_committers_file):
Open the specified file. These are mostly useful for testing purposes.

(CommitterAuth.trac_credentials_filename):
(CommitterAuth.webkit_committers_filename):
Return the path to the specified file by retrieving it from auth.json.

(CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
of WebKit committers from it.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.

(CMStringIO.enter):
(CMStringIO.exit):
Helper class that makes it possible to use StringIO with the "with" statement.

(open_override): Helper context manager for overriding the global "open" function
temporarily.

(CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
tests.
(CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
"open" to test that the expected path was opened.
(CommitterAuthTest.test_authentication_success): Test that committers can authenticate
successfully.
(CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
somehow have no Trac account can't authenticate.

(CommitterAuthTest.test_fail_to_open_auth_json_file):
(CommitterAuthTest.test_fail_to_open_trac_credentials_file):
(CommitterAuthTest.test_fail_to_open_webkit_committers_file):
Test what happens when we can't open the three files we depend upon.

(CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
an authentication class.

(CommitterAuthTest.test_invalid_auth_json_file):
(CommitterAuthTest.test_invalid_committers_file):
(CommitterAuthTest.test_invalid_trac_credentials_file):
(CommitterAuthTest.test_missing_auth_json_keys):
Test what happens when the three files we depend upon are invalid in some way.

(CommitterAuthTest.test_open_auth_json_file):
(CommitterAuthTest.test_open_trac_credentials_file):
(CommitterAuthTest.test_open_webkit_committers_file):
Test that we open the expected paths.

(CommitterAuthTest.test_trac_credentials_filename):
(CommitterAuthTest.test_webkit_committers_filename):
Test that we extract filenames out of auth.json correctly.

(CommitterAuthTest.test_non_committer_fails):
(CommitterAuthTest.test_unknown_user_fails):
(CommitterAuthTest.test_username_is_prefix_of_valid_user):
(CommitterAuthTest.test_wrong_password_fails):
Test various failed authentication attempts.

(CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
committers out of the committers file correctly.

(CommitterAuthTest.fake_auth_json_file):
(CommitterAuthTest.invalid_auth_json_file):
(CommitterAuthTest.fake_committers_file):
(CommitterAuthTest.invalid_committers_file):
(CommitterAuthTest.fake_htdigest_file):
(CommitterAuthTest.invalid_htdigest_file):
Return various fake files for testing.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth

to be used for authentication in the web interface, and specify that only authenticated
users may force builds.

11:58 AM Changeset in webkit [101694] by Adam Roben
  • 1 edit
    2 adds in trunk/Tools

Add an HTDigestParser class to webkitpy

Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files

This class can be used to parse Apache's htdigest files and check whether a given
username/realm/password tuple is present in the file. Eventually this will be used for
authenticating users on build.webkit.org (<http://webkit.org/b/73353>).

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/htdigestparser.py: Added.

(HTDigestParser.init): Stores the parsed representation of the file.
(HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
password and returns whether the resulting tuple is present in the file.
(HTDigestParser.entries): Just returns the parsed representation of the file.
(HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
whole file as invalid and all authentication attempts will fail.

  • Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.

(HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
optionally appended with some extra data, generates the expected entries.
(HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
authenticate, and tuples not present cannot.
(HTDigestParserTest.test_entries): Tests that we get the expected entries from
fake_htdigest_file.

(HTDigestParserTest.test_empty_file):
(HTDigestParserTest.test_too_few_colons):
(HTDigestParserTest.test_too_many_colons):
(HTDigestParserTest.test_invalid_hash):
Test various forms of invalid files.

(HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.

11:45 AM Changeset in webkit [101693] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 only allows for one-shot patching of compact offsets, while the
JIT expects to be able to repatch
https://bugs.webkit.org/show_bug.cgi?id=73548

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::setUInt7ForLoad):

11:31 AM Changeset in webkit [101692] by loislo@chromium.org
  • 2 edits
    6 moves
    1 add
    2 deletes in trunk

Web Inspector: chromium: move and adapt Inspector's performance tests for running with run-inspector-perf-tests.py.
https://bugs.webkit.org/show_bug.cgi?id=72260

Reviewed by Pavel Feldman.

PerformanceTests:

  • inspector/first-open-elements.html: Renamed from LayoutTests/inspector/performance/resources/first-open-elements.html.
  • inspector/first-open-scripts.html: Renamed from LayoutTests/inspector/performance/resources/first-open-scripts.html.
  • inspector/inspector-startup-time.html: Renamed from LayoutTests/inspector/performance/resources/inspector-startup-time.html.
  • inspector/network-append-30-requests.html: Renamed from LayoutTests/inspector/performance/resources/network-append-30-requests.html.
  • inspector/performance-test.js: Renamed from LayoutTests/inspector/performance/resources/performance-test.js.

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._getJSHeapSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):

  • inspector/show-panel.html: Renamed from LayoutTests/inspector/performance/resources/show-panel.html.

LayoutTests:

  • inspector/performance/resources/console-append-100-lines.html: Removed.
  • inspector/performance/resources/first-open-resources.html: Removed.
11:11 AM Changeset in webkit [101691] by benjamin@webkit.org
  • 15 edits
    2 adds in trunk

URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add the operator == between a String and a Vector of char. The implementation
is the same as the comparison of String and char* but adds the length as a
parameter for comparing the strings.

(WTF::equal):

  • wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Source/WebCore:

Previously, invalid URLs could have a string emanating from a
partial parsing of the input. The creation of the string was done
through the Latin1 codec regardless of the encoding of the char* url.

This caused two types of issues, URLs were evaluated as half-parsed,
and the coding and decoding of the string was not consistent.

This patch changes KURL::parse() to fallback on the original string
whenever the parsing of the URL fails.

Test: fast/url/invalid-urls-utf8.html

  • platform/KURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::init):
(WebCore::KURL::parse):
Previously, originalString was only used as an optimization to avoid
the allocation of a string. Since this optimization depends on the
comparison of the incoming string and the encoded buffer.
This patches generalizes originalString to always be the original string
being parsed by KURL. The optimization is kept by comparing that string
and the final parsed result.

  • platform/KURL.h:

(WebCore::KURL::parse):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

LayoutTests:

  • fast/url/invalid-urls-utf8-expected.txt: Added.
  • fast/url/invalid-urls-utf8.html: Added.

New test for invalid URL where the Unicode characters were mangled
by the parsing.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:

Two urls where expended by their base URL before found invalid. The partial
parsed result was saved as the new URL.

  • fast/url/host-expected.txt:

The host of two urls were invalid, and partially modified by the parsing.

  • fast/url/idna2003-expected.txt:

The first 'http://www.lookout.net⩴80/' encoded for parsing is http://www.lookout.net::=80/
and fails as invalid. The new result does not modify the original string.

The whitespace in 'http://www .lookout.net/' causes the parsing to fail when parsing
the username because a space is not a UserInfoChar.

  • fast/url/port-expected.txt:

The unicode characters used as the port number were transformed due to
the encoding UTF-8 -> Unicode through the Latin1 codec.

11:02 AM Changeset in webkit [101690] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

webkit->chromium DEPS roll 111575->112463
https://bugs.webkit.org/show_bug.cgi?id=73231

Patch by Elliot Poger <epoger@google.com> on 2011-12-01
Reviewed by Yury Semikhatsky.

  • DEPS:
11:00 AM Changeset in webkit [101689] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebCore

[Blackberry] Upstream BlackBerry porting of plugin framework -- part 2
https://bugs.webkit.org/show_bug.cgi?id=73513

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-12-01
Reviewed by Antonio Gomes.

No new tests for now.

  • plugins/blackberry/NPCallbacksBlackBerry.cpp: Added.
  • plugins/blackberry/NPCallbacksBlackBerry.h: Added.
  • plugins/blackberry/PluginViewPrivateBlackBerry.cpp: Added.
  • plugins/blackberry/PluginViewPrivateBlackBerry.h: Added.
10:54 AM Changeset in webkit [101688] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

10:49 AM Changeset in webkit [101687] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

JSC/CSSOM: root(CSSElementStyleDeclaration) should never need to follow the element.
<http://webkit.org/b/73561>

Reviewed by Antti Koivisto.

A CSSElementStyleDeclaration should always either have a null element pointer,
or return a valid parentStyleSheet(), since having an element pointer implies
having an associated element sheet.

In light of this, replace the opaque-root-from-element path for style declarations
by an assertion.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

10:49 AM Changeset in webkit [101686] by Lucas Forschler
  • 1 copy in tags/Safari-535.10

New Tag.

10:30 AM Changeset in webkit [101685] by Patrick Gansterer
  • 7 edits in trunk

[CMake] Make the feature defines for DOM names explicit
https://bugs.webkit.org/show_bug.cgi?id=72812

Reviewed by Daniel Bates.

.:

Preprocessor defines used in WebCore/dom/make_names.pl are set via WEBKIT_FEATURE
for every port in the correspondig platform file. Pass an explicit list of defines
to the CMake macro, so we need to maintain the list only once.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

  • CMakeLists.txt:
10:24 AM Changeset in webkit [101684] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK] Make the new 64-bit Release bot part of the core set
https://bugs.webkit.org/show_bug.cgi?id=73570

Reviewed by Adam Roben.

The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
Debug bot which was already part of the core set. The GTK
gardeners are willing to actively maintain it.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_builder_name_regexps):

10:02 AM Changeset in webkit [101683] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] [WK2] QQuickWebView covers QML elements that should be rendered on top.
https://bugs.webkit.org/show_bug.cgi?id=73338

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-01
Reviewed by Noam Rosenthal.

Move painting of QQuickWebPage content from canvas afterrendering() to
QSGGeometryNode/QSGMaterial based paint node. Implementation uses QSGMaterialShader
updateState() method to draw TextureMapper graphics layers.
This is considered to be temporary until QSGNode::UserNodeType will be available.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(PageProxyMaterialShader::attributeNames):
(PageProxyMaterialShader::vertexShader):
(PageProxyMaterialShader::fragmentShader):
(PageProxyMaterial::PageProxyMaterial):
(PageProxyMaterial::type):
(PageProxyMaterial::createShader):
(PageProxyNode::PageProxyNode):
(PageProxyNode::~PageProxyNode):
(PageProxyMaterialShader::updateState):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::showWebView):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::didRenderFrame):

9:57 AM Changeset in webkit [101682] by dslomov@google.com
  • 15 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=73503
[Chromium][V8] Implement ArrayBuffer transfer in chromium.
Portions of this patch come from Luke Zarko.

Source/JavaScriptCore:

Reviewed by David Levin.

  • wtf/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer): Changed prototype from pointers to RefPtr.

  • wtf/ArrayBuffer.h:

(WTF::ArrayBufferContents::transfer): Changed prototype from pointers to RefPtr.
(WTF::ArrayBuffer::isNeutered):

  • wtf/TypedArrayBase.h:

(WTF::TypedArrayBase::neuter):

Source/WebCore:

Reviewed by David Levin.

Test: fast/canvas/webgl/arraybuffer-transfer-of-control.html

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeTransferredArrayBuffer):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
(WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
(WebCore::V8ObjectMap::Serializer::writeTransferredArrayBuffer):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readArrayBufferView):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::tryGetTransferredArrayBuffer):
(WebCore::SerializedScriptValue::create):
(WebCore::neuterBinding):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/SerializedScriptValue.h:

LayoutTests:

Reviewed by David Levin.

  • fast/canvas/webgl/arraybuffer-transfer-of-control-expected.txt: Added.
  • fast/canvas/webgl/arraybuffer-transfer-of-control.html: Added.
  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js: Added.

(isTypedArray):
(isDataView):
(isArrayBuffer):
(assertBufferClosed):
(createBuffer):
(checkBuffer):
(createView):
(createEveryView):
(checkView):
(checkEmptyArray):
(wrapSend):
(wrapFailSend):
(testList.name.send):
(testList.test):
(.name.send):
(.test):
(testList.testList.concat.):
(viewAndBuffer.return.name.bufferType.0.send):
(viewAndBuffer.return.test):
():
(squashUnrelatedViews.return.name.bufferType.0.send):
(squashUnrelatedViews.return.test):
(squashUnrelatedViews):
(testList):
(doneTest):
(windowHandleMessage):

  • fast/dom/Window/window-postmessage-args.html:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/gtk/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/mac/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/qt/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
  • platform/win/Skipped: Skipped arraybuffer-transfer-of-control.js on JSC platfroms.
9:55 AM Changeset in webkit [101681] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectations:
http/tests/appcache/fail-on-update-2.html timing out on all platforms
detailed-heapshots-dominators-expansion-preserved-when-sorting.html timing out

  • platform/chromium/test_expectations.txt:
9:49 AM Changeset in webkit [101680] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][GTK] Change default-font-size and default-monospace-font-size
https://bugs.webkit.org/show_bug.cgi?id=73468

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

Set 'default-font-size' property value to 16px and 'default-monospace-font-size'
value to 13px.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_class_init): Change the default font size settings.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Correct the test.

9:47 AM Changeset in webkit [101679] by rolandsteiner@chromium.org
  • 7 edits in trunk

Shadow ID pseudo-element selectors serialize incorrectly
https://bugs.webkit.org/show_bug.cgi?id=73542

Source/WebCore:

Avoid space for ShadowDescendant combinator.

Reviewed by Dimitri Glazkov.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

LayoutTests:

Add test cases for complex selectors with shadow ID pseudo-elements.

Reviewed by Dimitri Glazkov.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
9:39 AM Changeset in webkit [101678] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Popup menu can get stuck in closed state when GtkMenu can't grab mouse.
https://bugs.webkit.org/show_bug.cgi?id=56466

Add a check if popup menu is not visible due to no mouse grab,
Ensure WebCore is in sync with proper state.

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-12-01
Reviewed by Martin Robinson.

Source/WebCore:

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::show):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::failedToShowPopupMenu): Added Method to send message
to WebProcess.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::client): Added Method to get WebCore::PopupMenuClient.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::failedToShowPopupMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added Message to inform WebProcess ShowPopupMenu failed.
9:36 AM Changeset in webkit [101677] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] Buildslave switch from 32-bit Debug to 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73547

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Rename

the 32-bit Debug configuration to 64-bit Release. The new slave is
a 64-bit machine already. The 32-bit slave will be shut down.
bui# Source/WebCore/GNUmakefile.am.orig

9:23 AM Changeset in webkit [101676] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] build-jsc should not trigger gtkdoc generation
https://bugs.webkit.org/show_bug.cgi?id=73552

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-01
Reviewed by Philippe Normand.

Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
that build-jsc does not try to generate gtkdoc.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".

8:59 AM Changeset in webkit [101675] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

When playing audio in <video>, the poster is hidden on play
https://bugs.webkit.org/show_bug.cgi?id=73405

Reviewed by Darin Adler.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::hasAvailableVideoFrame): Don't return true if the file

doesn't have video.

8:53 AM Changeset in webkit [101674] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Add Settings for text track types
https://bugs.webkit.org/show_bug.cgi?id=73383

Reviewed by Darin Adler.

No new tests, settings are not used yet.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize new settings.

  • page/Settings.h:

(WebCore::Settings::setShouldDisplaySubtitles): New.
(WebCore::Settings::shouldDisplaySubtitles): Ditto.
(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::shouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
(WebCore::Settings::shouldDisplayTextDescriptions): Ditto.

8:42 AM Changeset in webkit [101673] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

HTMLTrackElement.readyState should return TextTrack "readiness state".
https://bugs.webkit.org/show_bug.cgi?id=73466

Reviewed by Darin Adler.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::HTMLTrackElement): Don't initialize m_readyState.
(WebCore::HTMLTrackElement::setReadyState): Return the TextTrack state.
(WebCore::HTMLTrackElement::readyState): Set the TextTrack state.

  • html/HTMLTrackElement.h: Remove m_readyState.
  • html/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialize m_readinessState.

  • html/TextTrack.h:

(WebCore::TextTrack::readinessState): New.
(WebCore::TextTrack::setReadinessState): New.

8:28 AM Changeset in webkit [101672] by haraken@chromium.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r101669.
http://trac.webkit.org/changeset/101669
https://bugs.webkit.org/show_bug.cgi?id=73394

Win build and Mac build are failing

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main):

  • WebCore.gypi:
  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl:
  • webaudio/DOMWindowWebAudio.idl: Removed.
8:22 AM Changeset in webkit [101671] by pfeldman@chromium.org
  • 18 edits in trunk/Source

Web Inspector: further align front-end configurations: get rid of saveAsAvailable preference, inline drag glass pane.
https://bugs.webkit.org/show_bug.cgi?id=73555

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSaveAs):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSaveAs):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.hasExtensions):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canSaveAs):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/UIUtils.js:

(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):

Source/WebKit/chromium:

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canSaveAs):

  • src/InspectorFrontendClientImpl.h:
  • src/js/DevTools.js:
8:20 AM Changeset in webkit [101670] by pfeldman@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: extract static part of the InspectorBackend from the generator.
https://bugs.webkit.org/show_bug.cgi?id=73562

Reviewed by Timothy Hatcher.

We should only generate the mapping between the command parameters and slots,
rest of the backend is static.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:

(Generator.go):
(Generator.process_event):
(Generator.process_command):

  • inspector/compile-front-end.sh:
  • inspector/front-end/InspectorBackend.js: Added.

(InspectorBackendClass):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendClass.prototype._invoke):
(InspectorBackendClass.prototype._sendMessageToBackend):
(InspectorBackendClass.prototype._wrapCallbackAndSendMessageObject):
(InspectorBackendClass.prototype.sendMessageObjectToBackend):
(InspectorBackendClass.prototype.registerDomainDispatcher):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.getDescription):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.toString):
(InspectorBackendClass.prototype.dispatch.messageObject.error.proto.getMessage):
(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype.reportProtocolError):
(InspectorBackendClass.prototype.runAfterPendingDispatches):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:07 AM Changeset in webkit [101669] by haraken@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

  • Overview: Using the [Supplemental] IDL, this patch moves the attribute

declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

  • This patch changes the build flow of WebCore.gyp as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;

}

  • This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL

will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

  • DerivedSources.make
  • DerivedSources.pri
  • GNUmakefile.am
  • PlatformBlackBerry.cmake
  • UseJSC.cmake
  • UseV8.cmake
  • WebCore.vcproj/MigrateScripts
  • WebCore.vcproj/WebCore.vcproj
  • bindings/gobject/GNUmakefile.am
  • WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

DOMWindowWebAudio.idl:

interface [

Supplemental=DOMWindow

] DOMWindowWebAudio {

attribute attr1;
attribute attr2;

};

DOMWindow.idl:

interface [
] DOMWindow {

attribute [Supplemented] attr1; This line will be removed after all build scripts support the [Su IDL
attribute [Supplemented] attr2;
This line will be removed after all build scripts support the [Su IDL.
attribute attr3;
attribute attr4;

};

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

  • If a given build script supports the [Supplemental] IDL, generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
  • Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL as normal attributes and instead ignores all attributes with the [Supplemental] IDL (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

  • WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:

(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file.

  • WebCore.gypi: Added DOMWindowWebAudio.idl.
  • bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
  • page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
  • webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
8:04 AM WebKit Team edited by jarred@sencha.com
(diff)
7:56 AM Changeset in webkit [101668] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream credential storage files of BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=73280

Patch by Jonathan Dong <Jonathan Dong> on 2011-12-01
Reviewed by Rob Buis.

Added the basic structure of class CredentialBackingStore
to persist the credential data, and generated
platform/network/blackberry/CredentialStorageBlackBerry.cpp,
to implement CredentialStorage::getFromPersistentStorage
for BlackBerry porting.
Contributed by Torch Team.

  • platform/network/blackberry/CredentialBackingStore.cpp: Added.

(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::clear):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):

  • platform/network/blackberry/CredentialBackingStore.h: Added.
  • platform/network/blackberry/CredentialStorageBlackBerry.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage):

7:44 AM Changeset in webkit [101667] by Csaba Osztrogonác
  • 6 edits in trunk/Tools

tests_run0.txt gets clobbered when re-running failing tests
https://bugs.webkit.org/show_bug.cgi?id=63844

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-12-01
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.results_directory):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.init):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_MultiProcessManager.start_worker):
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_MultiProcessWorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_retries_directory):

7:22 AM Changeset in webkit [101666] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/notifications tests make fast/notifications/notifications-click-event.html fail
https://bugs.webkit.org/show_bug.cgi?id=71693

  • platform/qt/Skipped: Skip one more test - http/tests/notifications/icon-exists-show-alert-during-load.html
7:19 AM Changeset in webkit [101665] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

StyledElement: Tidy up copyNonAttributeProperties().
<http://webkit.org/b/73501>

Reviewed by Antti Koivisto.

  • css/CSSStyleDeclaration.h:

Made CSSStyleDeclaration non-copyable.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::copyPropertiesFrom):

copyPropertiesAndStrictnessFrom() redone as copyPropertiesFrom()
since we can copy the strictness bit using existing accessors.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

Use copyPropertiesFrom() and copy the strictness bit to the new
inline style using the dedicated accessors. Also added some
assertions for good measure.

7:10 AM Changeset in webkit [101664] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

run-bindings-tests is failing on Gtk/Qt/SnowLeopard/Lion bots
https://bugs.webkit.org/show_bug.cgi?id=73558

Reviewed by Csaba Osztrogonác.

The cause of the bug:

foreach my $idlFile (keys %documents) {

$supplementals{$idlFile} = [];
foreach my $dataNode (...) {

if (...) {

...;
push(@{$supplementals{$targetIdlFile}}, $idlFile);
...;

}

}

}

Even if we did push(@{$supplementals{$targetIdlFile}}, $idlFile),
the $supplementals{$targetIdlFile} can be re-initialized by
$supplementals{$idlFile} = [] in subsequent loops.
This patch fixes the bug.

Tests: bindings/scripts/test/TestInterface.idl

  • bindings/scripts/resolve-supplemental.pl:
5:45 AM Changeset in webkit [101663] by Adam Roben
  • 2 edits in trunk/Tools

Buildbot fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of

BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
it possible for build steps to reference things like the buildbotURL property of the config.

5:36 AM Changeset in webkit [101662] by Adam Roben
  • 2 edits in trunk/Tools

Use curl for downloading builds to test slaves

Buildbot's built-in file transfer capabilities are transferring files much more slowly than
curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
overhead (courtesy of the Twisted framework).

Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
This should make the test slaves quite a bit faster, and should ease the CPU load on
build.webkit.org a bit.

Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory

to Test slaves. It's run just before DownloadBuiltProduct.
(DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
download.
(CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
FileDownload used to do this for us automatically.

5:33 AM Changeset in webkit [101661] by pfeldman@chromium.org
  • 7 edits in trunk/Source

Web Inspector: restore WebKit2 Safari menu items after capabilities refactoring regression.
https://bugs.webkit.org/show_bug.cgi?id=73554

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::showConsole):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):

  • inspector/front-end/inspector.js:

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::didClose):

5:30 AM Changeset in webkit [101660] by pfeldman@chromium.org
  • 11 edits
    2 deletes in trunk/Source/WebCore

Web Inspector: remove capabilities along with the MetaAgent
https://bugs.webkit.org/show_bug.cgi?id=73550

Reviewed by Yury Semikhatsky.

We are now using explicit query commands in order to find out about the capabilities.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.py:

(Generator.go):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMetaAgent.cpp: Removed.
  • inspector/InspectorMetaAgent.h: Removed.
  • inspector/generate-protocol-externs:
5:19 AM EFLWebKitCodingStyle edited by rakuco@FreeBSD.org
Removing formatting from plain text blocks (diff)
5:15 AM Changeset in webkit [101659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: front-end should open with elements panel selected upon Inspect Element action.
https://bugs.webkit.org/show_bug.cgi?id=73539

Patch by Pavel Feldman <pfeldman@google.com> on 2011-12-01
Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone.showInitialPanel):
(WebInspector.inspect):

4:42 AM Changeset in webkit [101658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

MacroAssemblerMIPS does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73432

Patch by Chao-ying Fu <fu@mips.com> on 2011-12-01
Reviewed by Zoltan Herczeg.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::readCallTarget):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::readCallTarget):

4:17 AM Changeset in webkit [101657] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.
Mark two tests flaky.

  • platform/chromium/test_expectations.txt:
4:10 AM Changeset in webkit [101656] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: totalOffsetLeft and totalOffsetTop should take scroll into account.
https://bugs.webkit.org/show_bug.cgi?id=73443

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.SuggestBox):

  • inspector/front-end/utilities.js:

(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.boxInWindow):

4:04 AM Changeset in webkit [101655] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:58 AM Changeset in webkit [101654] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.
Mark svn perftest PASS TIMEOUT on DEBUG.

  • platform/chromium/test_expectations.txt:
3:44 AM Changeset in webkit [101653] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.
Mark one inspector tests flaky.

  • platform/chromium/test_expectations.txt:
3:40 AM Changeset in webkit [101652] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations
Mark two inspector tests flaky.

  • platform/chromium/test_expectations.txt:
3:33 AM Changeset in webkit [101651] by pfeldman@chromium.org
  • 31 edits in trunk

Web Inspector: query backend for capabilities explicitly.
https://bugs.webkit.org/show_bug.cgi?id=73442

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change removes the hardcoded Capabilities values in favor of
explicit query commands issued against the backend. I'll remove the
Meta agent in a subsequent change.

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::causesRecompilation):
(WebCore::ScriptDebugServer::supportsNativeBreakpoints):

  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::causesRecompilation):
(WebCore::ScriptProfiler::isSampling):
(WebCore::ScriptProfiler::hasHeapProfiler):

  • bindings/v8/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::causesRecompilation):
(WebCore::ScriptDebugServer::supportsNativeBreakpoints):

  • bindings/v8/ScriptProfiler.h:

(WebCore::ScriptProfiler::causesRecompilation):
(WebCore::ScriptProfiler::isSampling):
(WebCore::ScriptProfiler::hasHeapProfiler):

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canClearBrowserCache):
(WebCore::InspectorClient::canClearBrowserCookies):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::causesRecompilation):
(WebCore::InspectorDebuggerAgent::canSetScriptSource):
(WebCore::InspectorDebuggerAgent::supportsNativeBreakpoints):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::causesRecompilation):
(WebCore::InspectorProfilerAgent::isSampling):
(WebCore::InspectorProfilerAgent::hasHeapProfiler):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::setFrontend):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::canClearBrowserCache):
(WebCore::InspectorResourceAgent::canClearBrowserCookies):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.canSetScriptSource):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.onCanClearBrowserCache):
(WebInspector.NetworkLogView.onCanClearBrowserCookies):
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

(WebInspector.get inspectedPageDomain):
(WebInspector._initializeCapability):
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canClearBrowserCache):
(WebKit::InspectorClientImpl::canClearBrowserCookies):

  • src/InspectorClientImpl.h:
  • src/js/DevTools.js:

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:
3:30 AM Changeset in webkit [101650] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations, marking flaky.

  • platform/chromium/test_expectations.txt:
3:23 AM Changeset in webkit [101649] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.
It might be safe to make this svg test flaky.

  • platform/chromium/test_expectations.txt:
3:20 AM Changeset in webkit [101648] by hans@chromium.org
  • 3 edits
    2 adds in trunk

IndexedDB: Fix reverse cursor with non-existent upper bound
https://bugs.webkit.org/show_bug.cgi?id=73220

Reviewed by Tony Chang.

Source/WebCore:

The code previously did not properly handle the case where the
specified upper bound for a reverse cursor did not exist.

Test: storage/indexeddb/cursor-reverse-bug.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):

LayoutTests:

Add test to check that opening a reverse cursor works even when the
key specified as the upper bound does not exist.

  • storage/indexeddb/cursor-reverse-bug-expected.txt: Added.
  • storage/indexeddb/cursor-reverse-bug.html: Added.
3:14 AM Changeset in webkit [101647] by hayato@chromium.org
  • 2 edits
    1 move
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed. Chromium rebaselines after r101638.

  • platformgausi/chromium-cg-mac-leopard/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-cg-mac/svg/filters/feGaussianBlur-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Removed.
  • platform/mac/svg/filters/feGaussianBlur-expected.txt: Removed.
  • platform/qt/svg/filters/feGaussianBlur-expected.txt: Removed.
  • svg/filters/feGaussianBlur-expected.txt: Renamed from LayoutTests/platform/gtk/svg/filters/feGaussianBlur-expected.txt.
3:08 AM Changeset in webkit [101646] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.
Yet another inspector test crash appeared. I really hope they could appear at once.
If I encounter another crash test, it might be better to mark all inspector tests SKIP for chromium for a while.

  • platform/chromium/test_expectations.txt:
2:54 AM Changeset in webkit [101645] by hans@chromium.org
  • 27 edits in trunk/Source

IndexedDB: Cursor pre-fetching
https://bugs.webkit.org/show_bug.cgi?id=73025

Reviewed by Darin Fisher.

Source/WebCore:

No new tests. This doesn't change any semantics.
Actual pre-fetching will not happen in DumpRenderTree.
Chromium will request pre-fetching and have tests for it.

  • storage/IDBBackingStore.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::postSuccessHandlerCallback):

Adds a callback that is called everytime the onsuccess handler has
executed on a cursor. This allows the cursor to see if a new call
to continue() was made in the onsuccess handler.

  • storage/IDBCursor.h:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):

This is the function that does actual pre-fetching. When called,
it will attempt to step the cursor up to n steps and send the
results back via the new onSuccessWithPrefetch() callback.

(WebCore::IDBCursorBackendImpl::prefetchReset):

This resets the cursor to the position it was at before the last
prefetch call.

  • storage/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::postSuccessHandlerCallback):

  • storage/IDBCursorBackendInterface.h:
  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::sizeEstimate):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
(WebCore::CursorOptions::ObjectStoreCursorImpl::clone):
(WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::CursorOptions::IndexKeyCursorImpl::clone):
(WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::CursorOptions::IndexCursorImpl::clone):
(WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Update dispatchEvent() to call the postSuccessHandlerCallback()

  • storage/IDBRequest.h:

(WebCore::IDBRequest::onSuccessWithPrefetch):

  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::addPendingEvents):

Allow for adding an arbitrary number of extra pending events.
When a cursor pre-fetches n elements, the transaction should
expect to see n extra onsuccess calls.

  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

Add plumbing for new pre-fetching related functions.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccessWithPrefetch):

  • public/WebIDBCursor.h:

(WebKit::WebIDBCursor::deleteFunction):
(WebKit::WebIDBCursor::prefetchContinue):
(WebKit::WebIDBCursor::prefetchReset):
(WebKit::WebIDBCursor::postSuccessHandlerCallback):

  • public/WebIDBTransaction.h:

(WebKit::WebIDBTransaction::addPendingEvents):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):

  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp:

(WebKit::IDBCursorBackendProxy::postSuccessHandlerCallback):

  • src/IDBCursorBackendProxy.h:

(WebKit::IDBCursorBackendProxy::prefetchContinue):
(WebKit::IDBCursorBackendProxy::prefetchReset):

  • src/IDBTransactionBackendProxy.h:

(WebKit::IDBTransactionBackendProxy::addPendingEvents):

  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::prefetchContinue):
(WebKit::WebIDBCursorImpl::prefetchReset):

  • src/WebIDBCursorImpl.h:
2:48 AM Changeset in webkit [101644] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GTK] WebAudio wav resources access and management
https://bugs.webkit.org/show_bug.cgi?id=73080

Reviewed by Martin Robinson.

For the uninstalled case we assume the user will set a
AUDIO_RESOURCES_PATH environment variable pointing to
WebCore/platform/audio/resources.

  • GNUmakefile.am: Install WAV resources.
  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Support for loading
uninstalled resources.

2:36 AM Changeset in webkit [101643] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Fix WebIDBObjectStore::createIndex() after r101602
https://bugs.webkit.org/show_bug.cgi?id=73543

Reviewed by Tony Gentilcore.

r101602 introduces a new signature for createIndex(). Until Chromium
has been updated to override that function, the default implementation
must call the old version.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

2:35 AM Changeset in webkit [101642] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations, fixing dups.

  • platform/chromium/test_expectations.txt:
2:32 AM Changeset in webkit [101641] by Philippe Normand
  • 6 edits in trunk

[GTK] enable-webaudio websetting
https://bugs.webkit.org/show_bug.cgi?id=69836

Reviewed by Martin Robinson.

WebKit/gtk:

  • webkit/webkitwebsettings.cpp: New enable-webaudio boolean

setting, set to FALSE by default.
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h: Ditto.
  • webkit/webkitwebview.cpp: Update WebCore settings when

enable-webaudio value changes.
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference): Update WebKitGTK
enable-webaudio setting when a layout test requests it.

1:47 AM Changeset in webkit [101640] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[chromium] Remove wtf/qt/ThreadingQt.cpp from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=73527

Reviewed by Simon Hausmann.

wtf/qt/ThreadingQt.cpp was removed in r101477

1:05 AM Changeset in webkit [101639] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Reviewed by Gavin Barraclough.

Switch back to using the high bit as the inline marker, to make
all of the bit indexing operations simpler. Computing the size in
words and in bytes of a bitvector, using the number of bits as
input is error-prone enough; and with the current approach to
solving the X86 bug we end up getting it wrong. Making it right
seems hard.

So instead, to solve the original problem (the high bit may be
meaningful on 32-bit systems), the out-of-line storage pointer is
right-shifted by 1. Compared to the original BitVector code, this
is a much smaller change (just three lines).

This solves a bug where the DFG was corrupting its call frame
because BitVector lost track of some bits.

  • wtf/BitVector.cpp:

(WTF::BitVector::setSlow):
(WTF::BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):
(WTF::BitVector::outOfLineBits):

1:02 AM Changeset in webkit [101638] by commit-queue@webkit.org
  • 4 edits in trunk

SVG Gaussian blur in 1-dimension is incorrect
https://bugs.webkit.org/show_bug.cgi?id=73029

Patch by Florin Malita <fmalita@google.com> on 2011-12-01
Reviewed by Simon Fraser.

Source/WebCore:

Ensure that the last blurBox result is stored when applying one-dimensional blurs.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):

LayoutTests:

  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png: Rebaseline.
12:47 AM Changeset in webkit [101637] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Elements Panel edit as html looks weird with an arrow inside edit box.
https://bugs.webkit.org/show_bug.cgi?id=73462

Reviewed by Pavel Feldman.

  • inspector/front-end/elementsPanel.css:

(#elements-content .editing):
(.elements-tree-editor):

  • inspector/front-end/inspector.css:
12:40 AM Changeset in webkit [101636] by hayato@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

  • platform/chromium-mac-snowleopard/fast/forms/select-listbox-multiple-no-focusring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png.
  • platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
12:34 AM Changeset in webkit [101635] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Exclamation mark hint ignores property case
https://bugs.webkit.org/show_bug.cgi?id=73535

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:
12:29 AM Changeset in webkit [101634] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for xmlhttprequest test.

  • platform/chromium/test_expectations.txt:
12:26 AM Changeset in webkit [101633] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix dedicated workers inspection (undefined is not an object).
https://bugs.webkit.org/show_bug.cgi?id=73537

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.resourceForURL):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.loadCompleted):

12:16 AM Changeset in webkit [101632] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for flaky svg test.

  • platform/chromium/test_expectations.txt:
12:10 AM Changeset in webkit [101631] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for yet another inspector crash.

  • platform/chromium/test_expectations.txt:
12:07 AM Changeset in webkit [101630] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r101591.

  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Updated.
12:05 AM Changeset in webkit [101629] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Fix typo in the tests added by r101575.

  • editing/deleting/delete-and-cleanup-expected.txt:
  • editing/pasteboard/paste-without-nesting-expected.txt:
12:03 AM Changeset in webkit [101628] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Chromium rebaselines for svg test.

  • platform/chromium-win/svg/custom/gradient-with-1d-boundingbox-expected.png:
12:00 AM Changeset in webkit [101627] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[JSC] When XXXX has a NamedConstructor, window.XXXX should be XXXXConstructor
https://bugs.webkit.org/show_bug.cgi?id=73521

Reviewed by Adam Barth.

This is a regression caused by a patch of bug 73307.
If we replaced a custom constructor of window.XXXX (e.g. XXXX is Audio or Option)
with the [NamedConstructor] IDL, fast/js/global-constructors.html,
fast/dom/Window/window-properties.html and fast/dom/call-a-constructor-as-a-function.html
start to fail in JSC.

Before a patch of bug 73007: (correct behavior)

window.Audio => AudioConstructor
window.Option => OptionConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

After a patch of bug 73007: (wrong behavior)

window.Audio => HTMLAudioElementConstructor
window.Option => HTMLOptionElementConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

This patch fixes the above behavior.

Tests: bindings/scripts/test/TestNamedConstructor.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLParser.pm:

(parseExtendedAttributes):
(ParseInterface):

  • bindings/scripts/test/TestNamedConstructor.idl: The test IDL was wrong. NamedConstructor=XXXX(arguments) is a correct format.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Updated a run-bindings-tests result.

Nov 30, 2011:

11:59 PM Changeset in webkit [101626] by dgrogan@chromium.org
  • 3 edits in trunk/Source/WebCore

Move data in IDBPendingTransactionMonitor from static to
ThreadSpecific.
https://bugs.webkit.org/show_bug.cgi?id=73389

IDBPendingTransactionMonitor previously stored transactions in
a static member variable so that they could be aborted if they were
had no work queued up when leaving script execution. That was fine when
IndexedDB could only be used on the main thread, but is insufficient
for IndexedDB on workers. In addition to not being thread-safe, this
caused pending transactions that were created from a worker thread to
abort when the main thread left script execution.

Reviewed by David Levin.

No new tests - IndexedDB worker tests forthcoming.

  • storage/IDBPendingTransactionMonitor.cpp:

(WebCore::transactions): Create the TLS. The other methods used to
manage the container's memory lifetime but now we just leak it until
the thread shuts down in the interest of simpler code.
(WebCore::IDBPendingTransactionMonitor::addPendingTransaction):
(WebCore::IDBPendingTransactionMonitor::removePendingTransaction):
(WebCore::IDBPendingTransactionMonitor::abortPendingTransactions):

  • storage/IDBPendingTransactionMonitor.h:
11:47 PM Changeset in webkit [101625] by leo.yang@torchmobile.com.cn
  • 1 edit
    1 add in trunk/Source/WebCore

Upstream platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=73522

Reviewed by Daniel Bates.

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp: Added.

(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::networkStateChange):

11:43 PM Changeset in webkit [101624] by hayato@chromium.org
  • 11 edits
    1 move
    2 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for svg tests.

  • platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/struct-group-01-t-expected.png.
11:40 PM Changeset in webkit [101623] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Source/WebCore: [Chromium] Improve tile invalidation
https://bugs.webkit.org/show_bug.cgi?id=71872

Patch by David Reveman <reveman@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Virtualize LayerChromium::setNeedsDisplay so that dirty rectangles can
be handled directly by the TiledLayerChromium class. Replace
LayerChromium::dirtyRect() with LayerChromium::needsDisplay() and
remove unnecessary union of dirty rectangles. By invalidating existing
tiles using the initial dirty rectangles instead of their union we
avoid a large amount of unnecessary tile updates.

Update LayerChromiumTest.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):
(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::setNeedsDisplayRect):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::needsDisplay):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setNeedsDisplayRect):
(WebCore::TiledLayerChromium::invalidateRect):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

Source/WebKit/chromium: [Chromium] Improve tile invalidation.
https://bugs.webkit.org/show_bug.cgi?id=71872

Patch by David Reveman <reveman@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Remove public API function WebContentLayer::invalidRect(). Add new
test case to
LayerChromiumTest.checkSetNeedsDisplayCausesCorrectBehavior that
verifies that calling setNeedsDisplay() on a LayerChromium with
empty bounds is handled correctly.

  • public/WebContentLayer.h:
  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::invalidateRect):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::repaint):

  • tests/LayerChromiumTest.cpp:
11:38 PM Changeset in webkit [101622] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Fix typo in the tests added by r101575.

  • editing/deleting/delete-and-cleanup.html:
  • editing/pasteboard/paste-without-nesting.html:
11:27 PM Changeset in webkit [101621] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

SocketStreamHandleCFNet doesn't check for proxy errors
https://bugs.webkit.org/show_bug.cgi?id=71965

Reviewed by Darin Adler.

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::getStoredCONNECTProxyCredentials): Added a FIXME about retrieving proxy credentials.
(WebCore::SocketStreamHandle::addCONNECTCredentials): Added human readable messages to errors,
they go to Web Inspector console.
(WebCore::SocketStreamHandle::readStreamCallback): Handle proxy response codes other than 200
and 407 by failing cleanly.

11:22 PM Changeset in webkit [101620] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for another inspector crash.

  • platform/chromium/test_expectations.txt:
11:20 PM Changeset in webkit [101619] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

When the mouse is dragged out of an :active element, it should lose :hover.
https://bugs.webkit.org/show_bug.cgi?id=57206

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-11-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/css/hover-active-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent): Don't mark mouse-drag hit tests read-only, since they no longer are.
(WebCore::EventHandler::dragSourceEndedAt): Send a hit test request when the mouse goes up after a drag, so
RenderLayer has a chance to update the hover/active status.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Only allow the :active state to change on mouse down or mouse up.

LayoutTests:

  • fast/css/hover-active-drag-expected.txt: Added.
  • fast/css/hover-active-drag.html: Added.
11:16 PM Changeset in webkit [101618] by loislo@chromium.org
  • 7 edits
    1 move
    6 adds
    1 delete in trunk/Tools

Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=73079

The idea is to have performance tests for WebInspector.
I was suggested to put these tests into PerformanceTests/inspector.
They produce output in a format that is suitable for chromium perf bot drawing scripts.

I'd like to reuse code for scanning folders for test files.
Because of the fact that original test_files.py has common and layout specific parts
I decided to extract the generic part and put it into webkitpy/common
I think the two packages with name test_files look strange but I have no idea about a better name.

Reviewed by Dirk Pranke.

  • Scripts/run-inspector-perf-tests.py: Added.
  • Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.

(find):
(_normalize):

  • Scripts/webkitpy/common/find_files_unittest.py: Added.

(MockWinFileSystem.join):
(MockWinFileSystem):
(MockWinFileSystem.normpath):
(TestWinNormalize.assert_filesystem_normalizes):
(TestWinNormalize.test_mocked_win):
(TestWinNormalize):
(TestWinNormalize.test_win):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests):
(Port.find_test_files):
(Port._driver_class):
(is_reference_html_file):
(_has_supported_extension):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_find_no_paths_specified):
(PortTest.test_find_one_test):
(PortTest.test_find_glob):
(PortTest.test_find_with_skipped_directories):
(PortTest.test_find_with_skipped_directories_2):
(PortTest):
(PortTest.test_is_test_file):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_tests):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/performance_tests/init.py: Added.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.

(PerfTestsRunner.init):
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests._is_test_file):
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.

(MainTest.TestPort):
(MainTest.TestPort.create_driver):
(MainTest.TestDriver.run_test):
(MainTest.TestDriver):
(MainTest.TestDriver.stop):
(MainTest.create_runner):
(MainTest.run_test):
(MainTest.test_run_passing_test):
(MainTest.test_run_silent_test):
(MainTest.test_run_failed_test):
(MainTest.test_run_tonguey_test):
(MainTest.test_run_timeout_test):
(MainTest.test_run_crash_test):
(MainTest.test_run_test_set):
(MainTest.test_collect_tests):
(MainTest):
(MainTest.test_parse_args):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(OptimizeBaselines.execute):
(AnalyzeBaselines.execute):

11:15 PM Changeset in webkit [101617] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for plugins/form-value.html.

  • platform/chromium/test_expectations.txt:
11:12 PM Changeset in webkit [101616] by hayato@chromium.org
  • 19 edits
    4 moves
    2 adds
    6 deletes in trunk/LayoutTests

Unreviewed. Chromium rebaselines for svg tests.

  • platform/chromium-cg-mac-snowleopard/svg/custom/marker-child-changes-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/marker-child-changes-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/marker-viewBox-changes-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/marker-viewBox-changes-expected.png.
  • platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/marker-child-changes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/marker-viewBox-changes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac/svg/custom/marker-child-changes-expected.png: Removed.
  • platform/chromium-mac/svg/custom/marker-viewBox-changes-expected.png: Removed.
  • platform/chromium-win/svg/batik/text/textLength-expected.png:
  • platform/chromium-win/svg/carto.net/button-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/marker-child-changes-expected.png:
  • platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.txt: Removed.
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt: Removed.
  • platform/qt/svg/custom/marker-child-changes-expected.txt: Removed.
  • platform/qt/svg/custom/marker-viewBox-changes-expected.txt: Removed.
  • svg/custom/marker-child-changes-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/marker-child-changes-expected.txt.
  • svg/custom/marker-viewBox-changes-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/marker-viewBox-changes-expected.txt.
11:11 PM Changeset in webkit [101615] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should make it easier to notice node boundaries in disassembly
https://bugs.webkit.org/show_bug.cgi?id=73509

Rubber-stamped by Gavin Barraclough

If you set XOR_DEBUG_AID to 1 in DFGCommon.h, a pair of xor's will
be emitted at node boundaries, where the immediate being xor'd is the
node index.

  • dfg/DFGCommon.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:01 PM Changeset in webkit [101614] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Add didUpdateBufferedAmount callback to WebSocketClient API
https://bugs.webkit.org/show_bug.cgi?id=73306

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-30
Reviewed by Darin Fisher.

  • public/WebSocketClient.h: Add didUpdateBufferedAmount and default implementations for all callbacks.

(WebKit::WebSocketClient::didConnect):
(WebKit::WebSocketClient::didReceiveMessage):
(WebKit::WebSocketClient::didReceiveBinaryData):
(WebKit::WebSocketClient::didReceiveMessageError):
(WebKit::WebSocketClient::didUpdateBufferedAmount):
(WebKit::WebSocketClient::didStartClosingHandshake):
(WebKit::WebSocketClient::didClose):

  • src/WebSocketImpl.cpp:

(WebKit::WebSocketImpl::didUpdateBufferedAmount):

  • src/WebSocketImpl.h:
10:54 PM Changeset in webkit [101613] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Expose WebLayerTreeView::setRootLayer as a call through
to same method on CCLayerTreeHost.
https://bugs.webkit.org/show_bug.cgi?id=73506

Patch by Scott Violet <sky@google.com> on 2011-11-30
Reviewed by James Robinson.

  • public/WebLayerTreeView.h: Adds setRootLayer.
  • src/WebLayerTreeView.cpp: Ditto.

(WebKit::WebLayerTreeView::setRootLayer):

10:38 PM Changeset in webkit [101612] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

XHR 'progress' event code assumes wrongly that expectedLength >= 0
https://bugs.webkit.org/show_bug.cgi?id=36156

Source/WebCore:

Patch by Hans Muller <hmuller@adobe.com> on 2011-11-30
Reviewed by Alexey Proskuryakov

Avoid passing a negative value as the dispatchProgressEvent's total parameter and always use 0 when lengthComputable is false.

Test: http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReceiveData):

LayoutTests:

Patch by Hans Muller <hmuller@adobe.com> on 2011-11-30
Reviewed by Alexey Proskuryakov

Verify that XMLHttpRequest ProgressEvent's total is zero when the expectedLength of the
(chunked transfer mode) response can't be computed.

  • http/tests/xmlhttprequest/chunked-progress-event-expectedLength-expected.txt: Added.
  • http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html: Added.
  • http/tests/xmlhttprequest/resources/chunked-transfer.php: Added.
10:30 PM Changeset in webkit [101611] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source

Unreviewed. Fix build error when NOTIFICATIONS feature is enabled.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:
10:26 PM WebKit Team edited by jarred@sencha.com
(diff)
10:20 PM Changeset in webkit [101610] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove ImageFrame::setSize() style nits
https://bugs.webkit.org/show_bug.cgi?id=73490

Reviewed by Andreas Kling.

Equality comparisons to 0 should be performed with the not operator, write
width() == 0 && height() == 0 as !width() && !height().

No new tests, style refactor.

  • platform/image-decoders/qt/ImageFrameQt.cpp:

(WebCore::ImageFrame::setSize):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::setSize):

10:15 PM Changeset in webkit [101609] by ap@apple.com
  • 41 edits in trunk/Source

Remove an unneeded argument from FrameLoaderClient::download
https://bugs.webkit.org/show_bug.cgi?id=73486

Reviewed by Andreas Kling.

Source/WebCore:

No change in functionality.

  • loader/FrameLoaderClient.h: Removed initialRequest argument.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):

We're already passing ResourceHandle, why also pass its data member?

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::download): Updated for the change.

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::download):

  • src/FrameLoaderClientImpl.h:

Updated for the change.

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::download):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Updated for the change.

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::download):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Updated for the change.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::download):
Updated for the change.

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::download):

  • WebCoreSupport/FrameLoaderClientQt.h:

Updated for the change.

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::download):

  • WebFrame.h:

Updated for the change.

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::download):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Updated for the change.

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::download):

  • WebKitSupport/FrameLoaderClientWx.h:

Updated for the change.

Source/WebKit2:

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::convertHandleToDownload):

  • WebProcess/Downloads/DownloadManager.h:
  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::startWithHandle):

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::startWithHandle):

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::startWithHandle):

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::startWithHandle):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::download):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertHandleToDownload):

  • WebProcess/WebPage/WebFrame.h:

Updated for the change. CF version is the only one worth seeing, as it was using the argument.

10:04 PM Changeset in webkit [101608] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations, adding one more inspector test crash.

  • platform/chromium/test_expectations.txt:
9:55 PM Changeset in webkit [101607] by ap@apple.com
  • 4 edits in trunk/Source

Original page URL is not set in quarantine information when downloading using context menu Save Linked File
https://bugs.webkit.org/show_bug.cgi?id=73475
<rdar://problem/10500337>

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in: Exported FrameLoader::setOriginalURLForDownloadRequest.

Source/WebKit2:

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::downloadRequest): Set main document URL

for the request, so that CFNetwork would know where te file was downloaded. Note that this
is an easier case than downloading due to clicks, since we don't really need to build a host
only URL, and could use full page URL. However, the same function is used for consistency.

9:44 PM Changeset in webkit [101606] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[FileSystem API] DirectoryEntry.getFile path argument is required
https://bugs.webkit.org/show_bug.cgi?id=69642

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-11-30
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-getfile.html

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile): check args length and throw TypeError if not enough arguments

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getFileCallback): check args length and throw TypeError if not enough arguments

LayoutTests:

  • fast/filesystem/resources/simple-required-arguments-getfile.js: Added.

(errorCallback):
(successCallback):

  • fast/filesystem/simple-required-arguments-getfile-expected.txt: Added.
  • fast/filesystem/simple-required-arguments-getfile.html: Added.
9:42 PM Changeset in webkit [101605] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[MutationObservers] Need layout tests asserting that non-event async callbacks deliver mutations after completion
https://bugs.webkit.org/show_bug.cgi?id=73480

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-30
Reviewed by Ryosuke Niwa.

  • fast/mutation/non-event-delivery-expected.txt: Added.
  • fast/mutation/non-event-delivery.html: Added.
9:38 PM Changeset in webkit [101604] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Removed ArgList iterators.

Reviewed by Gavin Barraclough.

Another step toward reversing the argument order.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct): Switched from iterator to int.

  • runtime/ArgList.h:

(JSC::ArgList::ArgList):
(JSC::ArgList::isEmpty): Removed iterators.

  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation): Switched from iterator to int.

9:24 PM Changeset in webkit [101603] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations for flaky inspector tests.

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [101602] by commit-queue@webkit.org
  • 28 edits
    2 adds in trunk

IndexedDB: Implement IDBIndex multientry feature
https://bugs.webkit.org/show_bug.cgi?id=73232

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-30
Reviewed by Tony Chang.

Source/WebCore:

The multientry flag is used when populating indexes, either when the index
is created on an existing store or as new values are added to the store.
Per the spec the semantics are: if the flag is set and the index key is
calculated to be an array, each member of the array is used as an index key
instead.

Test: storage/indexeddb/index-multientry.html

  • storage/IDBBackingStore.h:
  • storage/IDBIndex.h:

(WebCore::IDBIndex::multientry):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):

  • storage/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::multientry):

  • storage/IDBIndexBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::checkIndexAndMetaDataKey):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBLevelDBCoding.cpp:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Adds the multientry IDBIndex flag to the WebKit API. A version of the
createIndex() method without this flag is retained until all callers
are updated.

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::multientry):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::multientry):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):

  • src/IDBObjectStoreBackendProxy.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::multientry):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):

  • src/WebIDBObjectStoreImpl.h:

(WebKit::WebIDBObjectStoreImpl::createIndex):

LayoutTests:

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-multientry-expected.txt: Added.
  • storage/indexeddb/index-multientry.html: Added.
9:18 PM Changeset in webkit [101601] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt: fast/froms/selector-popup-pagekeys.html
9:17 PM Changeset in webkit [101600] by commit-queue@webkit.org
  • 11 edits
    6 copies
    2 adds
    2 deletes in trunk/Source

[Chromium] Add support for painting into an SkPicture and then rasterizing into tile-sized chunks.
https://bugs.webkit.org/show_bug.cgi?id=71388

Patch by David Reveman <reveman@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Source/WebCore:

Add UpdatableTexture class, which allows texture updater to
allocate tile specific resources and paint tiles separately.
Rename texture uploader classes and move them to separate files.

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Added.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::create):
(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::~BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore::CanvasLayerTextureUpdater::CanvasLayerTextureUpdater):
(WebCore::CanvasLayerTextureUpdater::~CanvasLayerTextureUpdater):
(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore::CanvasLayerTextureUpdater::contentRect):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Added.

(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::~Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::create):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::~FrameBufferSkPictureCanvasLayerTextureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h.

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::orientation):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::Texture::textureUpdater):
(WebCore::ImageLayerTextureUpdater::createTexture):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::Texture::~Texture):
(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::Texture::Texture):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::~SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::drawPicture):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

Source/WebKit/chromium:

Track changes to texture updater.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::Texture::Texture):
(WTF::FakeLayerTextureUpdater::Texture::~Texture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(WTF::FakeLayerTextureUpdater::createTexture):

9:05 PM Changeset in webkit [101599] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for inspector tests crash.

  • platform/chromium/test_expectations.txt:
9:00 PM Changeset in webkit [101598] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

32 bit DFG should handle logicalNot slow case instead of simply bailing out
https://bugs.webkit.org/show_bug.cgi?id=73515

Reviewed by Filip Pizlo.

This improves Kraken performance by 14%, mainly due to ~3X improvement
on imaging-desaturate.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):

9:00 PM Changeset in webkit [101597] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MutationObservers] Make WebKitMutationObserver::deliverAllMutations() tolerant of re-entrant calls
https://bugs.webkit.org/show_bug.cgi?id=73472

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-30
Reviewed by Ojan Vafai.

No new tests. This patch just adds a static guard which makes more explicit the current semantics.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::deliverAllMutations):

8:27 PM Changeset in webkit [101596] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations after r101576.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [101595] by igor.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[WK2][Qt] AC animation startTime is wrong

[WK2][Qt] AC animation startTime is wrong
https://bugs.webkit.org/show_bug.cgi?id=73467

When WebProcess sends animation information to UIProcess, It uses the
current time(WTF::currentTime) minus the timeOffset to set the start time
animation.

But there is a latency between the WebProcess and UIProcess communication
and sometimes the animation transition starts late.

This patch fixes the bug moving the startTime calculation to UIProcess.

Reviewed by Noam Rosenthal.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::syncLayerParameters):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::addAnimation):

7:44 PM Changeset in webkit [101594] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Add OVERRIDE to WebSocket related sources for safe inheritances.
https://bugs.webkit.org/show_bug.cgi?id=73308

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-30
Reviewed by Kent Tamura.

No new tests because this change contains no functional change.

  • platform/network/chromium/SocketStreamHandle.h:
  • websockets/CloseEvent.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.h:
7:43 PM Changeset in webkit [101593] by mihnea@adobe.com
  • 11 edits
    2 moves in trunk/Source/WebCore

[CSSRegions]Rename CSSRegionStyleRule to WebKitCSSRegionRule
https://bugs.webkit.org/show_bug.cgi?id=73450

Reviewed by Andreas Kling.

No functionality changed so no new tests. The new name has the webkit prefix as required for new api.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createRegionStylingRule):

  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):
(WebCore::CSSRule::destroy):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::addRegionStyleRule):
(WebCore::CSSStyleSelector::checkRegionStyle):
(WebCore::RuleSet::addRulesFromSheet):

  • css/CSSStyleSelector.h:
  • css/WebKitCSSRegionRule.cpp: Renamed from Source/WebCore/css/CSSRegionStyleRule.cpp.

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):

  • css/WebKitCSSRegionRule.h: Renamed from Source/WebCore/css/CSSRegionStyleRule.h.
7:25 PM Changeset in webkit [101592] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Alter an early return that was preventing HTMLCanvasElement::didDraw notifications
from being triggered when accelerated compositing was enabled. The notification is
necessary to make sure that any cached state is cleared in the HTMLCanvasElement object.
To prevent performance regressions, the cached state is explicitly cleared, as the didDraw
machinery is not necessary for accelerated canvases.
https://bugs.webkit.org/show_bug.cgi?id=73257

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-30
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/canvas-2d-webgl-texture.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::didDraw):
(WebCore::HTMLCanvasElement::setSurfaceSize):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

LayoutTests:

  • fast/canvas/webgl/canvas-2d-webgl-texture-expected.txt: Added.
  • fast/canvas/webgl/canvas-2d-webgl-texture.html: Added.
7:23 PM Changeset in webkit [101591] by haraken@chromium.org
  • 10 edits
    2 adds in trunk

Implement the StorageEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=71685

Reviewed by Adam Barth.

Source/WebCore:

This patch makes StorageEvent constractable.
The spec: http://www.whatwg.org/specs/web-apps/current-work/#storageevent

Test: fast/events/constructors/storage-event-constructor.html

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty):
(WebCore::JSDictionary::convertValue): Returns a Storage object corresponding to a given key.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetProperty):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get): Ditto.

  • bindings/v8/OptionsObject.h:
  • storage/StorageEvent.cpp: Added an implementation of the StorageEvent constructor.

(WebCore::StorageEventInit::StorageEventInit):
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):

  • storage/StorageEvent.h: Added a definition of StorageEventInit.

(WebCore::StorageEvent::key):
(WebCore::StorageEvent::oldValue):
(WebCore::StorageEvent::newValue):
(WebCore::StorageEvent::url):
(WebCore::StorageEvent::storageArea):

  • storage/StorageEvent.idl: Added [ConstructorTemplate=Event] IDL.

LayoutTests:

storage-event-constructor.html checks the behavior of the StorageEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added window.StorageEvent.
  • fast/events/constructors/storage-event-constructor-expected.txt: Added.
  • fast/events/constructors/storage-event-constructor.html: Added.
7:13 PM Changeset in webkit [101590] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for flaky svg test.

  • platform/chromium/test_expectations.txt:
7:10 PM Changeset in webkit [101589] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt] Buildfix for generating forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=73446

Reviewed by Noam Rosenthal.

  • DerivedSources.pri: Always create the parent directory before generating a forwarding header.
6:59 PM Changeset in webkit [101588] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for r101575.

  • platform/chromium/test_expectations.txt:
6:53 PM Changeset in webkit [101587] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

window.getMatchedCSSRules() not supporting pseudo element
https://bugs.webkit.org/show_bug.cgi?id=72930

Patch by Naveen Bobbili <qghc36@motorola.com> on 2011-11-30
Reviewed by Darin Adler.

Added functionality to retrieve CSS rules of psuedo elements using
getMatchedCSSRules.

Source/WebCore:

Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):
Retreiving CSS Rules of the appropriate pseudo element.

LayoutTests:

  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-expected.txt: Added.
  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements.html: Added.
6:48 PM Changeset in webkit [101586] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] TextureManager LRU list is not fully honor the order tiles are used
https://bugs.webkit.org/show_bug.cgi?id=73344

Patch by Grace Kloba <klobag@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Reorder the texture in the LRU list only when protectTexture() is called.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::hasTexture):
(WebCore::TextureManager::protectTexture):

6:40 PM Changeset in webkit [101585] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Apply alpha channel into ewk_tiled_backing_store's tile objects.
https://bugs.webkit.org/show_bug.cgi?id=73015

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-30
Reviewed by Chang Shu.

Add alpha_set API to tiled backing store to apply alpha channel on tile objects.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_tile_associate):
(ewk_tiled_backing_store_alpha_set):

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_bg_color_set):
(ewk_view_tiled_smart_set):

6:36 PM Changeset in webkit [101584] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from first letter text fragments having flows split
https://bugs.webkit.org/show_bug.cgi?id=72759

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-30
Reviewed by David Hyatt.

Source/WebCore:

When an inline flow is split that contains a first letter block
and its remaining text, it can prevent the remaining text fragment
from getting updated if the first letter block is replaced. This
patch enables the text fragment to be found and updated properly.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterBlock):

LayoutTests:

New test for fix to crash on bug 72759.

  • fast/css/first-letter-inline-flow-split-crash-expected.txt: Added
  • fast/css/first-letter-inline-flow-split-crash.html: Added
6:33 PM Changeset in webkit [101583] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Get rid of AllowCrossThreadAccess throughout ThreadableWebSocketChannelClientWrapper.
https://bugs.webkit.org/show_bug.cgi?id=73336

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-30
Reviewed by David Levin.

No new tests because it contains no functional change.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmountCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
6:15 PM Changeset in webkit [101582] by commit-queue@webkit.org
  • 5 edits in trunk

Some date values not handled consistently with IE/Firefox
https://bugs.webkit.org/show_bug.cgi?id=14176

Patch by Max Vujovic <mvujovic@adobe.com> on 2011-11-30
Reviewed by Gavin Barraclough.

Changed time zone offset parsing behavior to match IE/Firefox/Opera's in
implementation dependent cases like "GMT-4".

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

LayoutTests:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

6:10 PM Changeset in webkit [101581] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test for css escape sequences parser.
https://bugs.webkit.org/show_bug.cgi?id=72008

Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-11-30
Reviewed by Darin Adler.

  • fast/css/parsing-css-wrap-expected.txt: Added.
  • fast/css/parsing-css-wrap.html: Added.
5:55 PM Changeset in webkit [101580] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed, adding accessibility/multiselect-list-reports-active-option.html
to the Mac Skip list.

  • platform/mac/Skipped:
5:47 PM Changeset in webkit [101579] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add 2 cpp files to the BlackBerry build system
https://bugs.webkit.org/show_bug.cgi?id=73408

platform/network/blackberry/DeferredData.cpp and platform/network/blackberry/NetworkJob.cpp
will be added, change build system first.

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
5:37 PM Changeset in webkit [101578] by kbr@google.com
  • 22 edits
    3 adds in trunk/Source

Implement draft WEBGL_compressed_textures WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <gman@google.com> on 2011-11-30
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextures.cpp: Added.

(WebCore::WebGLCompressedTextures::WebGLCompressedTextures):
(WebCore::WebGLCompressedTextures::~WebGLCompressedTextures):
(WebCore::WebGLCompressedTextures::getName):
(WebCore::WebGLCompressedTextures::create):
(WebCore::WebGLCompressedTextures::supported):
(WebCore::WebGLCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLCompressedTextures::compressedTexImage2D):
(WebCore::WebGLCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLCompressedTextures::getCompressedTextureFormats):

  • html/canvas/WebGLCompressedTextures.h: Added.
  • html/canvas/WebGLCompressedTextures.idl: Added.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

5:24 PM Changeset in webkit [101577] by scheib@chromium.org
  • 83 edits
    2 copies
    35 moves
    15 adds
    575 deletes in trunk/LayoutTests

Rebasing many SVG text & pixel tests due to r101517 Add new renderer for SVGRectElement. Differences are primarily 1 pixel bounds differences

  • platform/chromium-cg-mac-leopard/svg/custom/percentage-rect-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/percentage-rect-expected.png.
  • platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/js-late-marker-and-object-creation-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-marker-and-object-creation-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/js-late-marker-creation-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-marker-creation-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/marker-child-changes-css-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/marker-child-changes-css-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/custom/marker-strokeWidth-changes-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/marker-strokeWidth-changes-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/chromium-linux-x86/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/carto.net/window-expected.png: Removed.
  • platform/chromium-linux-x86/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/js-late-marker-and-object-creation-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/pan-direction-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/filterRes-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/bidi-text-query-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-3-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-4-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-3-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/chromium-linux/svg/custom/js-late-marker-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/marker-child-changes-css-expected.png:
  • platform/chromium-linux/svg/custom/marker-default-width-height-expected.png:
  • platform/chromium-linux/svg/custom/marker-overflow-clip-expected.png:
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-linux/svg/custom/pan-direction-expected.png: Removed.
  • platform/chromium-linux/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/chromium-linux/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.txt: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/chromium-linux/svg/hixie/error/010-expected.png:
  • platform/chromium-linux/svg/hixie/error/011-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-leopard/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/marker-overflow-clip-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/chromium-mac-leopard/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-1-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-3-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-4-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.png.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/container-opacity-clip-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-stop-corner-cases-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-marker-creation-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/svg/custom/js-late-marker-and-object-creation-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-update-pattern-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/js-update-pattern-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/marker-child-changes-css-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/svg/custom/marker-strokeWidth-changes-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/marker-default-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/marker-overflow-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/svg/custom/pan-direction-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/pan-direction-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-size-bigger-than-target-size-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/svg/custom/object-sizing-width-50p-on-target-svg-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-in-defs-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/percentage-rect-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png.
  • platform/chromium-mac-snowleopard/svg/custom/text-dom-01-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png:
  • platform/chromium-mac-snowleopard/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/error/010-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/error/011-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Removed.
  • platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png: Removed.
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.png: Removed.
  • platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png: Removed.
  • platform/chromium-mac/svg/custom/container-opacity-clip-viewBox-expected.png: Removed.
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
  • platform/chromium-mac/svg/custom/js-late-marker-and-object-creation-expected.png: Removed.
  • platform/chromium-mac/svg/custom/js-late-marker-creation-expected.png: Removed.
  • platform/chromium-mac/svg/custom/js-update-pattern-child-expected.png: Removed.
  • platform/chromium-mac/svg/custom/js-update-pattern-expected.png: Removed.
  • platform/chromium-mac/svg/custom/marker-child-changes-css-expected.png: Removed.
  • platform/chromium-mac/svg/custom/marker-overflow-clip-expected.png: Removed.
  • platform/chromium-mac/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-mac/svg/custom/text-dom-01-f-expected.png: Removed.
  • platform/chromium-mac/svg/foreignObject/svg-document-in-html-document-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/error/010-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/error/011-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/chromium-win-vista/svg/carto.net/colourpicker-expected.png: Removed.
  • platform/chromium-win-vista/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/chromium-win-vista/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/chromium-win-vista/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-win-vista/svg/carto.net/window-expected.png: Removed.
  • platform/chromium-win-vista/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-marker-and-object-creation-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-vista/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/pan-direction-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-1-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-3-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-4-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-1-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-2-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-3-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Removed.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/window-expected.png: Removed.
  • platform/chromium-win-xp/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-marker-and-object-creation-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/pan-direction-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-3-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-4-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-3-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/js-update-pattern-child-expected.png:
  • platform/chromium-win/svg/custom/js-update-pattern-expected.png:
  • platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.png:
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png.
  • platform/chromium-win/svg/custom/pattern-rotate-gaps-expected.png:
  • platform/chromium-win/svg/custom/percentage-rect-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/chromium-win/svg/hixie/error/010-expected.png:
  • platform/chromium-win/svg/hixie/error/011-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium/svg/custom/pattern-size-bigger-than-target-size-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt: Removed.
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt: Removed.
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt: Removed.
  • platform/mac/svg/custom/js-update-pattern-child-expected.txt: Removed.
  • platform/mac/svg/custom/js-update-pattern-expected.txt: Removed.
  • platform/mac/svg/custom/marker-child-changes-css-expected.txt: Removed.
  • platform/mac/svg/custom/pattern-in-defs-expected.txt: Removed.
  • platform/mac/svg/custom/percentage-rect-expected.txt: Removed.
  • platform/qt/svg/custom/gradient-stop-corner-cases-expected.txt: Removed.
  • platform/qt/svg/custom/js-late-marker-and-object-creation-expected.txt: Removed.
  • platform/qt/svg/custom/js-late-marker-creation-expected.txt: Removed.
  • platform/qt/svg/custom/js-update-pattern-child-expected.txt: Removed.
  • platform/qt/svg/custom/js-update-pattern-expected.txt: Removed.
  • platform/qt/svg/custom/marker-child-changes-css-expected.txt: Removed.
  • platform/qt/svg/custom/pattern-in-defs-expected.txt: Removed.
  • platform/qt/svg/custom/percentage-rect-expected.txt: Removed.
  • svg/custom/gradient-stop-corner-cases-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/gradient-stop-corner-cases-expected.txt.
  • svg/custom/js-late-marker-and-object-creation-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/js-late-marker-and-object-creation-expected.txt.
  • svg/custom/js-late-marker-creation-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/js-late-marker-creation-expected.txt.
  • svg/custom/js-update-pattern-child-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/js-update-pattern-child-expected.txt.
  • svg/custom/js-update-pattern-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/js-update-pattern-expected.txt.
  • svg/custom/marker-child-changes-css-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/marker-child-changes-css-expected.txt.
  • svg/custom/pattern-in-defs-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-in-defs-expected.txt.
  • svg/custom/percentage-rect-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/percentage-rect-expected.txt.
5:24 PM Changeset in webkit [101576] by nduca@chromium.org
  • 32 edits
    4 copies
    1 move in trunk

[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Source/WebCore:

Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setMainThreadIsImplThread):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • public/WebCompositor.h:
  • public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::initialize):
(WebKit::WebCompositor::shutdown):
(WebKit::WebCompositor::fromIdentifier):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

Tools:

Patch by nduca@chromium.org <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2011-11-30
Reviewed by James Robinson.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::threadedCompositingEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost):
(WebViewHost::~WebViewHost):

5:16 PM Changeset in webkit [101575] by enrica@apple.com
  • 4 edits
    4 adds in trunk

Source/WebCore: Copy/paste of the same content produces increasingly nested markup
https://bugs.webkit.org/show_bug.cgi?id=73497
<rdar://problem/10208605>

When pasting a fragment over a selection, we perfom a DeleteSelection command
followed by a ReplaceSelection command. Delete selection preserves the style
of the selection start, leaving all the blocks containing the insertion point.
This patch eliminates all the nested divs that don't provide additional style,
avoiding the proliferation of nested divs.

Reviewed by Darin Adler.

Tests: editing/deleting/delete-and-cleanup.html

editing/pasteboard/paste-without-nesting.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/DeleteSelectionCommand.h:

LayoutTests: Copy/paste of the same content produces increasingly nested markup
https://bugs.webkit.org/show_bug.cgi?id=73497
<rdar://problem/10208605>

Reviewed by Darin Adler.

  • editing/deleting/delete-and-cleanup-expected.txt: Added.
  • editing/deleting/delete-and-cleanup.html: Added.
  • editing/pasteboard/paste-without-nesting-expected.txt: Added.
  • editing/pasteboard/paste-without-nesting.html: Added.
5:14 PM Changeset in webkit [101574] by mitz@apple.com
  • 22 edits in trunk/Source

Source/WebCore: WebCore part of: Allow the length of a page along the pagination axis to differ from the length of the view
https://bugs.webkit.org/show_bug.cgi?id=73476

Reviewed by Anders Carlsson.

  • page/Page.cpp:

(WebCore::Page::setPagination): Changed to use Pagination::operator==.

  • page/Page.h:

(WebCore::Page::Pagination::Pagination): Added initializer for the new pageLength member variable.
(WebCore::Page::Pagination::operator==): Added.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutColumns): Narrowed the scope of a local variable.

  • rendering/RenderBlock.h: Promoted setDesiredColumnCountAndWidth() from private to protected,

allowing its use from RenderView::calcColumnWidth(). Made calcColumnWidth() virtual.

  • rendering/RenderView.cpp:

(WebCore::RenderView::calcColumnWidth): Added. Uses the page length specified in the pagination
parameters to set the column width, if pages are to be laid out one next to the other.
(WebCore::RenderView::viewLogicalHeight): Added. Uses the page length specified in the pagination
parameters as the height, if pages are to be laid out one after the other.

  • rendering/RenderView.h:

Source/WebKit/mac: WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view
https://bugs.webkit.org/show_bug.cgi?id=73476

Reviewed by Anders Carlsson.

  • WebView/WebView.mm:

(-[WebView _setPageLength:]): Added this accessor.
(-[WebView _pageLength]): Ditto.

  • WebView/WebViewPrivate.h:

Source/WebKit2: WebKit2 part of: Allow the length of a page along the pagination axis to differ from the length of the view
https://bugs.webkit.org/show_bug.cgi?id=73476

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode pageLength.
(WebKit::WebPageCreationParameters::decode): Decode pageLength.

  • Shared/WebPageCreationParameters.h: Added pageLength.
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLength): Added this accessor.
(WKPageGetPageLength): Ditto.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added initializer for m_pageLength.
(WebKit::WebPageProxy::setPageLength): Added.
(WebKit::WebPageProxy::creationParameters): Initialize pageLength.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageLength): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set the page length based on the creation parameters.
(WebKit::WebPage::setPageLength): Added.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added SetPageLength.
5:08 PM Changeset in webkit [101573] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: Nodes are reporting that focus can be set when they really can't
https://bugs.webkit.org/show_bug.cgi?id=72791

Reviewed by Beth Dakin.

Source/WebCore:

Whether focus can be set on a node shouldn't rely only on the role.
It should depend on whether the node supports focus.

Test: platform/mac/accessibility/supports-focus-setting.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

Tools:

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isFocusable):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isFocusable):

LayoutTests:

  • platform/mac/accessibility/supports-focus-setting-expected.txt: Added.
  • platform/mac/accessibility/supports-focus-setting.html: Added.
5:05 PM Changeset in webkit [101572] by Chris Fleizach
  • 2 adds in trunk/LayoutTests/accessibility

WebKit does not send mouse down/up/click events to ARIA tabs
https://bugs.webkit.org/show_bug.cgi?id=72573

Reviewed by Darin Adler.

LayoutTests:
accessibility/press-works-on-control-types.html

5:03 PM Changeset in webkit [101571] by Chris Fleizach
  • 3 edits in trunk

WebKit does not send mouse down/up/click events to ARIA tabs
https://bugs.webkit.org/show_bug.cgi?id=72573

Reviewed by Darin Adler.

Source/WebCore:

There are a number of "control" type elements that should perform a click on the actual element.

Test: accessibility/press-works-on-control-types.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::actionElement):

LayoutTests:

  • accessibility/press-works-on-control-types-expected.txt: Added.
  • accessibility/press-works-on-control-types.html: Added.
4:58 PM Changeset in webkit [101570] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Searching mechanism is too slow when finding the element.
https://bugs.webkit.org/show_bug.cgi?id=72523

Reviewed by Beth Dakin.

This makes the element searching mechanism much faster. Previously, searching literally went
through every element, looking for the start element before "starting" the search.

Now we only go through the elements that need to be searched. This is done by going up the
start object parent chain. At each level, a DFS is done. As we go up the parent chain,
only the elements before/after the current element are examined.

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::findMatchingObjects):

4:36 PM Changeset in webkit [101569] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectations: svg/text/non-bmp-positioning-lists.svg BUGWK73494

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [101568] by scheib@chromium.org
  • 17 edits
    2 moves
    1 add
    3 deletes in trunk/LayoutTests

Rebasing many SVG text & pixel tests due to r101517 Add new renderer for SVGRectElement. Differences are primarily 1 pixel bounds differences and some images that moved by 1px.

  • platform/chromium-cg-mac-snowleopard/svg/custom/marker-changes-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/marker-changes-expected.png.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/marker-changes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/custom/marker-changes-expected.png: Removed.
  • platform/mac/svg/custom/marker-changes-expected.txt: Removed.
  • platform/qt/svg/custom/marker-changes-expected.txt: Removed.
  • svg/custom/marker-changes-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/marker-changes-expected.txt.
4:10 PM Changeset in webkit [101567] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj

Merged r94596.

4:09 PM Changeset in webkit [101566] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/LayoutTests

Merged r94595.

4:08 PM Changeset in webkit [101565] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 101272
BUG=104859
Review URL: http://codereview.chromium.org/8760017

4:04 PM Changeset in webkit [101564] by Lucas Forschler
  • 27 edits
    9 copies in branches/safari-534.53-branch

Merge 94593.

4:03 PM Changeset in webkit [101563] by jschuh@chromium.org
  • 6 edits in branches/chromium/912/Source/WebCore

Merge 100408
BUG=104151
Review URL: http://codereview.chromium.org/8758009

3:32 PM Changeset in webkit [101562] by scheib@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

[Chromium] Adding baseline variations for platform specific color differences

Tests were recently added in r101542 : feImage referencing a primitive draws incorrectly

  • platform/chromium-cg-mac-leopard/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
3:27 PM Changeset in webkit [101561] by rniwa@webkit.org
  • 5 edits in trunk

Cannot select RTL text inside LTR text from right to left by a mouse drag
https://bugs.webkit.org/show_bug.cgi?id=73056

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by positionAtRightBoundaryOfBiDiRun using current inline box's offset
even when creating a position with previous inline box. Fixed the bug by using the correct offset.

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun):
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun):

LayoutTests:

Added a test case to ensure WebKit can select "A" in "aCBAb" when selecting text by a mouse drag
from the position between "A" and "b" to the position between "B" and "A".

  • editing/selection/select-bidi-run-expected.txt:
  • editing/selection/select-bidi-run.html:
3:25 PM Changeset in webkit [101560] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Searching mechanism gets stuck when searching tables
https://bugs.webkit.org/show_bug.cgi?id=72519

Source/WebCore:

When searching through the elements within a data table, the children() method should not
be used, since that contains elements (like a table header column) which have the same children
as the table itself. Instead the cells() should be searched.

Reviewed by Beth Dakin.

Test: platform/mac/accessibility/search-when-element-starts-in-table.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::findMatchingObjects):

LayoutTests:

Reviewed by Beth Dakin.

  • platform/mac/accessibility/search-when-element-starts-in-table-expected.txt: Added.
  • platform/mac/accessibility/search-when-element-starts-in-table.html: Added.
3:15 PM Changeset in webkit [101559] by scheib@chromium.org
  • 322 edits
    5 moves
    553 adds
    5 deletes in trunk/LayoutTests

Rebasing many SVG text & pixel tests due to r101517 Add new renderer for SVGRectElement.

Differences are primarily 1 pixel bounds differences and some images that moved by 1px.

  • platform/chromium-cg-mac-leopard/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-linux-x86/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/chromium-linux-x86/svg/carto.net/window-expected.png: Added.
  • platform/chromium-linux-x86/svg/carto.net/window-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/carto.net/window-expected.png:
  • platform/chromium-linux/svg/carto.net/window-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.png:
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/bidi-text-query-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-win-vista/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/chromium-win-vista/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-win-vista/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/chromium-win-vista/svg/carto.net/window-expected.png: Added.
  • platform/chromium-win-vista/svg/carto.net/window-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-win-vista/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
  • platform/chromium-win-vista/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/chromium-win-xp/svg/carto.net/window-expected.png: Added.
  • platform/chromium-win-xp/svg/carto.net/window-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/js-late-marker-and-object-creation-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pan-direction-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
  • platform/chromium-win-xp/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/pan-direction-expected.png:
  • platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/chromium-win/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Renamed from LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt.
2:53 PM Changeset in webkit [101558] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

commit-review-policy.html should make clear committers shouldn't land patches without authors' consent
https://bugs.webkit.org/show_bug.cgi?id=73098

Reviewed by Antti Koivisto.

Revise the sentence about committers being allowed to land patches by others to explicitly state that
they can only land patches by others if asked by authors themselves.

  • coding/commit-review-policy.html:
2:38 PM Changeset in webkit [101557] by Lucas Forschler
  • 16 edits
    3 copies in branches/safari-534.53-branch

Merge 94420.

2:33 PM Changeset in webkit [101556] by rniwa@webkit.org
  • 6 edits
    4 adds in trunk

Assertion failure (m_nestedIsolateCount >= 1) in BidiResolver::exitIsolate()
https://bugs.webkit.org/show_bug.cgi?id=69267

Reviewed by Eric Seidel.

Source/WebCore:

The failure was caused by our updating bidi resolver's current position in layoutRunsAndFloatsInRange
without updating the number of nested isolated ancestors. Fixed the bug by computing the number of
isolated ancestors when setting a new position to the bidi resolver.

Also renamed the existing BidiResolver::setPosition to setPositionIgnoringNestedIsolates because this
version can be used only when we don't have to update the number of nested isolates.

Tests: fast/text/bidi-isolate-hang-with-neutral-expected.html

fast/text/bidi-isolate-hang-with-neutral.html
fast/text/bidi-isolate-nextlinebreak-failure.html

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawBidiText):

  • platform/text/BidiResolver.h:

(WebCore::BidiResolver::setPositionIgnoringNestedIsolates):
(WebCore::BidiResolver::setPosition):

  • rendering/InlineIterator.h:

(WebCore::numberOfIsolateAncestors): Takes InlineIterator instead of object and root.
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::determineStartPosition):

LayoutTests:

Add a regression test for the assertion failure. Also add a regression test for a hang
found by Levi Weintraub and Jeremy Moskovich.

This patch also fixes the assertion failure in fast/block/child-not-removed-from-parent-lineboxes-crash.html
introduced by r101268.

  • fast/text/bidi-isolate-hang-with-neutral-expected.html: Added.
  • fast/text/bidi-isolate-hang-with-neutral.html: Added.
  • fast/text/bidi-isolate-nextlinebreak-failure-expected.txt: Added.
  • fast/text/bidi-isolate-nextlinebreak-failure.html: Added.
2:18 PM WebKit Team edited by alex
(diff)
2:11 PM Changeset in webkit [101555] by alex
  • 2 edits in trunk/Tools

2011-11-30 Alejandro G. Castro <alex@igalia.com>

Moved myself to the reviewers list.

  • Scripts/webkitpy/common/config/committers.py:
2:01 PM Changeset in webkit [101554] by bfulgham@webkit.org
  • 5 edits in trunk/Source/WebCore

[WinCairo] Correct SimpleFontData implementation to match Apple results.
https://bugs.webkit.org/show_bug.cgi?id=73474

Reviewed by Adam Roben.

Tested by existing dom/xhtml/level3/core/nodegetbaseuri05.xhtml
and dom/xhtml/level3/core/nodegetbaseuri07.xhtml

  • platform/graphics/SimpleFontData.h: Add declaration for new 'ascentConsideringMacAscentHack' method.
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Remove implementation of 'platformCharWidthInit' (moved to SimpleFontDataWin.cpp). Also use new 'ascentConsideringMacAscentHack' method.
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Remove dummy implementation.

(WebCore::SimpleFontData::platformInit): Add logic to handle the

'shouldApplyMacAscentHack' case, as well as to identify system font
using the same criteria as the Apple port.

(WebCore::SimpleFontData::platformWidthForGlyph): Add check for

missing font data state.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::ascentConsideringMacAscentHack): New
(WebCore::SimpleFontData::platformCharWidthInit): Moved from the

CG implementation.

2:00 PM Changeset in webkit [101553] by levin@chromium.org
  • 9 edits in trunk

[chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=73415

Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebFrameClient.h: Move didUpdateLayout to WebViewClient.
  • public/WebViewClient.h:

(WebKit::WebViewClient::didUpdateLayout): Ditto.

  • src/ChromeClientImpl.cpp: Call WebViewImpl now.

(WebKit::ChromeClientImpl::layoutUpdated):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::layoutUpdated):

  • src/WebViewImpl.h: Added layoutUpdated.

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
it being moved to a new interface and having the parameter removed.

  • DumpRenderTree/chromium/WebViewHost.h: Ditto.
1:47 PM Changeset in webkit [101552] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r94304.

1:45 PM Changeset in webkit [101551] by Lucas Forschler
  • 27 edits
    5 copies in branches/safari-534.53-branch

Merge 94299.

1:39 PM Changeset in webkit [101550] by timothy_horton@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed new Snow Leopard baseline after 101537.

  • platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
1:37 PM Changeset in webkit [101549] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Make FrameView use TemporarilyChange in a few places.
https://bugs.webkit.org/show_bug.cgi?id=73403

Reviewed by Dmitry Titov.

No new functionality exposed so no new tests.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutParentViewIfNeeded): Since this function isn't
re-entrant, TemporarilyChange does the same thing but in a more robust manner
in case there would be a return added in the function.
(WebCore::FrameView::layout): This place is the key reason for the change.
layout is re-entrant, but layout will set m_layoutSchedulingEnabled to true when
leaving though the "layout" function higher in the stack would still have it set
to false (which works ok but is hit by another change I'm working on).
The majority of the change is due to indenting the code to make m_layoutSchedulingEnabled
and TemporarilyChange behave like they did before. A few variables were moved before
the scoping to allow them to be used after the scope is closed.
(WebCore::FrameView::setScrollPosition): TemporarilyChange does exactly what
this code did before (saving the old value and restoring it).

1:33 PM Changeset in webkit [101548] by alex
  • 11 edits
    2 adds in trunk/Source

2011-11-30 Alejandro G. Castro <alex@igalia.com>

[GTK] Add TextureMapperCairo boilerplate implementation
https://bugs.webkit.org/show_bug.cgi?id=73440

Add TextureMapperCairo class and TextureMapper classes compilation
for GTK+.

Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: (WebCore::GraphicsContext3D::platformLayer):
  • platform/graphics/cairo/TextureMapperCairo.cpp: Added. (WebCore::BitmapTextureCairo::destroy): (WebCore::BitmapTextureCairo::size): (WebCore::BitmapTextureCairo::reset): (WebCore::BitmapTextureCairo::beginPaint): (WebCore::BitmapTextureCairo::endPaint): (WebCore::BitmapTextureCairo::updateContents): (WebCore::BitmapTextureCairo::save): (WebCore::BitmapTextureCairo::setContentsToImage): (WebCore::TextureMapperCairo::beginClip): (WebCore::TextureMapperCairo::endClip): (WebCore::TextureMapperCairo::viewportSize): (WebCore::TextureMapperCairo::TextureMapperCairo): (WebCore::TextureMapperCairo::setGraphicsContext): (WebCore::TextureMapperCairo::graphicsContext): (WebCore::TextureMapperCairo::bindSurface): (WebCore::TextureMapperCairo::drawTexture): (WebCore::TextureMapper::create): (WebCore::TextureMapperCairo::createTexture): (WebCore::BitmapTextureCairo::BitmapTextureCairo): (WebCore::TextureMapperCairo::beginPainting): (WebCore::TextureMapperCairo::endPainting):
  • platform/graphics/cairo/TextureMapperCairo.h: Added. (WebCore::BitmapTextureCairo::~BitmapTextureCairo): (WebCore::BitmapTextureCairo::isValid): (WebCore::BitmapTextureCairo::sourceRect): (WebCore::BitmapTextureCairo::pack): (WebCore::BitmapTextureCairo::unpack): (WebCore::BitmapTextureCairo::isPacked): (WebCore::BitmapTextureCairo::cr): (WebCore::TextureMapperCairo::allowSurfaceForRoot): (WebCore::TextureMapperCairo::create):

2011-11-30 Alejandro G. Castro <alex@igalia.com>

[GTK] Add TextureMapperCairo boilerplate implementation
https://bugs.webkit.org/show_bug.cgi?id=73440

Add texture mapper glue to the widget and chrome client.

Reviewed by Martin Robinson.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::attachRootGraphicsLayer): (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): (WebKit::ChromeClient::scheduleCompositingLayerSync): (WebKit::ChromeClient::allowedCompositingTriggers):
  • webkit/webkitwebview.cpp: (webViewSetRootGraphicsLayer): (webViewMarkForSync):
  • webkit/webkitwebviewprivate.h:
1:22 PM Changeset in webkit [101547] by alex
  • 6 edits in trunk

2011-11-30 Alejandro G. Castro <alex@igalia.com>

[GTK] Add accelerated compositing compilation option
https://bugs.webkit.org/show_bug.cgi?id=73298

Compile whatever we have inside the USE(ACCELERATED_COMPOSITING)
define. Fix accelerated compositing compilation in WK2, update the
enter/exit functions.

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/gtk/PageClientImpl.h:

2011-11-30 Alejandro G. Castro <alex@igalia.com>

[GTK] Add accelerated compositing compilation option
https://bugs.webkit.org/show_bug.cgi?id=73298

Compile whatever we have inside the USE(ACCELERATED_COMPOSITING)
define. Add the build compilation option
--with-accelerated-compositing and use it in the makefile.

Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • configure.ac:
1:20 PM Changeset in webkit [101546] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Fix platform layering violation by moving CachedImage invalidation code into
CSSCrossfadeValue (instead of CrossfadeGeneratedImage).

No new tests.

  • css/CSSCrossfadeValue.cpp:

(WebCore::loadSubimage):
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::customCssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::loadSubimages):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::imageChanged):

  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::~CrossfadeSubimageObserverProxy):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::setReady):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:

(WebCore::CrossfadeGeneratedImage::create):

1:08 PM Changeset in webkit [101545] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: [Regression] Successfully loaded XHRs are shown as canceled.
https://bugs.webkit.org/show_bug.cgi?id=72873

Reviewed by Nate Chapin.

Source/WebCore:

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::cancelIfNotFinishing):

  • loader/SubresourceLoader.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::allClientsRemoved):

LayoutTests:

  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync.html:
12:34 PM Changeset in webkit [101544] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[V8] Make WebCoreTestingSupport::resetInternalsObject more robust
https://bugs.webkit.org/show_bug.cgi?id=73437

Reviewed by Adam Barth.

The Qt DRT may end up calling resetInternalsObject at a time when
there's no internals object yet. In that case the looking of the internals
object in the global object fails and returns undefined. V8Internals::toNative
doesn't handle that and causing failing assertions. This patch adds a simple
check to handle this case.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

12:19 PM Changeset in webkit [101543] by simonjam@chromium.org
  • 3 edits
    2 adds in trunk

Fix valgrind issue in SubresourceLoader::didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=72787

Hang on to CachedResource until finish() is called.

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/subresource-load-failed-crash.html (under asan)

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):

LayoutTests:

  • fast/loader/subresource-load-failed-crash-expected.txt: Added.
  • fast/loader/subresource-load-failed-crash.html: Added.
11:53 AM Changeset in webkit [101542] by timothy_horton@apple.com
  • 4 edits
    8 adds in trunk

feImage referencing a primitive draws incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71731
<rdar://problem/10408178>

Reviewed by Simon Fraser.

If the target of an <feImage> appears to be a local fragment identifier, but
it hasn't resolved yet, defer resolution instead of loading a bogus image.

Invalidate <feImage> if the xlink:href attribute changes.

Don't attempt to render an <feImage> if the referenced element is of size 0x0.

Tests: svg/filters/feImage-reference-invalidation.svg

svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-zero-size-crash.svg

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

Add a test (feImage-reference-svg-primitive) that ensures that having
an <feImage> referencing an SVG primitive which is declared after it
successfully paints the referenced object.

Add a test (feImage-zero-size-crash) to see if we crash when <feImage>
references an object with 0x0 size.

Add a test (feImage-reference-invalidation) that ensures that changing the
xlink:href on an <feImage> correctly invalidates the image.

  • svg/filters/feImage-reference-invalidation-expected.png: Added.
  • svg/filters/feImage-reference-invalidation-expected.txt: Added.
  • svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • svg/filters/feImage-reference-svg-primitive-expected.txt: Added.
  • svg/filters/feImage-reference-invalidation.svg: Added.
  • svg/filters/feImage-reference-svg-primitive.svg: Added.
  • svg/filters/feImage-zero-size-crash-expected.txt: Added.
  • svg/filters/feImage-zero-size-crash.svg: Added.
11:43 AM Changeset in webkit [101541] by Lucas Forschler
  • 11 edits
    3 copies in branches/safari-534.53-branch

Merged r94206.

11:42 AM Changeset in webkit [101540] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

Generate a more robust user agent string.
https://bugs.webkit.org/show_bug.cgi?id=73465

Reviewed by Kevin Ollivier.

11:36 AM Changeset in webkit [101539] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

toStringCallback and valueOfCallback do not check the entire prototype chain for convertToType callback
https://bugs.webkit.org/show_bug.cgi?id=73368

Reviewed by Darin Adler.

We need to search the entire prototype chain for the convertToType callback, rather than just calling whatever
happens to be in the first class of the chain, which potentially could be null.

<rdar://problem/10493218>

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):

11:34 AM Changeset in webkit [101538] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Ensure we always notify the popup client that the popup
was hidden, and fix handling of empty menu items.
https://bugs.webkit.org/show_bug.cgi?id=73464

Reviewed by Kevin Ollivier.

11:30 AM Changeset in webkit [101537] by timothy_horton@apple.com
  • 3 edits
    3 adds in trunk

dx causes non-BMP characters to fail to render
https://bugs.webkit.org/show_bug.cgi?id=18039
<rdar://problem/10422142>

Reviewed by Simon Fraser.

Don't split the surrogate pairs of non-BMP characters across
elements of <text> positioning lists.

Test: svg/text/non-bmp-positioning-lists.svg

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):

Add a test combining non-BMP characters and positioning lists.

  • platform/mac/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/mac/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • svg/text/non-bmp-positioning-lists.svg: Added.
11:27 AM Changeset in webkit [101536] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

Use the wxGCDC(wxGraphicsContext) constructor on Mac as well
to avoid issues with the wxGCDC(wxPrinterDC) constructor.
https://bugs.webkit.org/show_bug.cgi?id=73463

Reviewed by Kevin Ollivier.

11:25 AM Changeset in webkit [101535] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Add a scope for the raw bitmap access so that wx
will not make a copy when creating the wxMemoryDC.
https://bugs.webkit.org/show_bug.cgi?id=73461

Reviewed By Kevin Ollivier.

11:12 AM Changeset in webkit [101534] by Adam Roben
  • 5 edits in trunk/Tools

Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed

This will make it a lot easier to investigate build failures on the bots.

Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
seen in practice.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
The Printer was modifying the root logger in way that would cause my new tests in
WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
seem important to the functioning of this test, and passing False makes Printer not modify
the root logger.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
up when --verbose is passed but not otherwise.
(WebKitPort._build_driver): When an error occurs, log the error message and the script's
output at the ERROR level so it will always show up.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
cases. Test that the build scripts' output is logged when --verbose is passed or the build
fails.

11:12 AM Changeset in webkit [101533] by Adam Roben
  • 2 edits
    1 add in trunk/Tools

Add a way to set OutputCapture's log level

This will be used by some unit tests I'm planning to add.

Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.init): Initialize our internal logging level to INFO, which was the only
level we ever used before this patch.
(OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
being tested uses. Sets the log level for any current or future logging handlers.
(OutputCapture.capture_output): Use our internal logging level instead of always using INFO.

  • Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.

(OutputCaptureTest.setUp): Create an OutputCapture to test.
(OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
(OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
was logged.
(OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
(OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
level.

11:00 AM Changeset in webkit [101532] by Beth Dakin
  • 4 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=72751
WebKit2.MouseMoveAfterCrash API test is failing

Reviewed by Sam Weinig.

Source/WebKit2:

windowIsFocused() is too restrictive. All we need to know is that the page is
active.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

Tools:

Like DumpRenderTree, the NSWindow should act as an active window.

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(-[ActiveOffscreenWindow isKeyWindow]):
(TestWebKitAPI::PlatformWebView::PlatformWebView):

10:49 AM Changeset in webkit [101531] by vsevik@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Inspect element does not highlight element in elements panel when inspector is opened.
https://bugs.webkit.org/show_bug.cgi?id=73459

Reviewed by Pavel Feldman.

This regressed in r101503.

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::inspectImpl):

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::init):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::inspect):

  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):

10:44 AM Changeset in webkit [101530] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove dead flexible box code
https://bugs.webkit.org/show_bug.cgi?id=73377

Reviewed by Darin Adler.

We used to use these with an earlier version of the spec where margins
set to auto were treated as flex(1).

No new tests, just removing some uncalled methods.

  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
10:26 AM Changeset in webkit [101529] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Add move semantics to WKRetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73400

Reviewed by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
Add a move constructor and move enabled assignment operators
to WKRetainPtr if the compiler being used supports rvalue
references. If the compiler does not support it, we fallback
to the copy semantics we have always had.

10:25 AM Changeset in webkit [101528] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add adoptCF and adoptNS convenience functions to RetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=73399

Reviewed by Anders Carlsson.

  • wtf/RetainPtr.h:

(WTF::adoptCF):
(WTF::adoptNS):
These adoption functions match the pattern we use in other
smart pointer classes.

10:11 AM Changeset in webkit [101527] by kov@webkit.org
  • 2 edits in trunk/Tools

Add step to update gtk dependencies to the buildbot
https://bugs.webkit.org/show_bug.cgi?id=73455

Reviewed by Martin Robinson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
10:03 AM Changeset in webkit [101526] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] HTML5 Youtube video fullscreen button doesn't work
https://bugs.webkit.org/show_bug.cgi?id=73456

Reviewed by Martin Robinson.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement): Ignore
withKeyboard argument value, like Chrome's implementation.

9:35 AM Changeset in webkit [101525] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Tools

[Qt] Add a fullscreen option to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=73445

Reviewed by Noam Rosenthal.

This bypasses the compositor on the N9 to increase performances
and remove the huge useless gray bar part of the window frame
at the bottom.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::setStartFullScreen):
(WindowOptions::startFullScreen):

9:25 AM Changeset in webkit [101524] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Reuse cached style fully if the parent inherited styles are equal
https://bugs.webkit.org/show_bug.cgi?id=73421

Reviewed by Oliver Hunt.

The matched declaration cache currently restores the non-inherted properties from the cache
entry but still applies all inherited properties normally. In case the current parent
inherited style is equivalent to the cache entry's, also the inherited style can be reused
and no properties need to be applied. This is faster and saves memory (by sharing the
style substructures better).

The new optimized code path has a pretty good hit rate, >50% of all cases on many pages.

Loading the HTML5 spec this reduces style memory consumption by ~20% (5MB, ~2.5% of total) and
speeds up style applying by ~25% for ~0.4s (2-3%) gain in the spec loading benchmark.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

Remove the code that dynamically disables inherited only applying. We now don't allow
styles with explicitly inherited properties to be cached in the first place.


(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):

Return the full cache item.


(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):

Also the parent style is now needed for the check for full sharing.


(WebCore::isCacheableInMatchedDeclarationCache):

Don't allow styles with explicitly inherited properties to be cached at all.


(WebCore::CSSStyleSelector::applyMatchedDeclarations):

If the parent inherited styles are equal reuse the cache entry fully and return without
doing anything else.


  • css/CSSStyleSelector.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::inheritedDataShared):

  • rendering/style/RenderStyle.h:


Add fast check for equal inherited properties.

9:16 AM Changeset in webkit [101523] by mrobinson@webkit.org
  • 2 edits
    3 adds in trunk/Tools

[GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
https://bugs.webkit.org/show_bug.cgi?id=73425

Reviewed by Gustavo Noronha Silva.

Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
ensure that the jhbuild root is up-to-date. Currently the only module is
the font module.

  • Scripts/update-webkitgtk-libs: Added.
  • gtk/common.py: Added a helper to get the number of CPUs.
  • gtk/jhbuild.modules: Added.
  • gtk/jhbuildrc: Added.
8:57 AM Changeset in webkit [101522] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip the GTK tests failing since the font metrics change.

  • platform/gtk/Skipped:
8:41 AM BuildingQt5OnHarmattan edited by jocelyn.turcotte@nokia.com
Add the V8 snapshot build error workaround and remove obsolete information. (diff)
8:39 AM Changeset in webkit [101521] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Fix RetainPtr's move assignment operators

Fixes <http://webkit.org/b/73449> RetainPtr's move assignment operators don't modify the
pointer being assigned to

I didn't write a test for this because we don't have a way of unit testing C++11 code (see
<http://webkit.org/b/73448>).

Reviewed by Anders Carlsson.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::operator=): Adopt the passed-in RetainPtr's underlying pointer, not our own
pointer.

8:25 AM Changeset in webkit [101520] by reni@webkit.org
  • 2 edits in trunk/Source/WebCore

CG buildfix after r101517.

Rubber stamped by Zoltan Herczeg.

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::fillShape):

8:15 AM Changeset in webkit [101519] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

Missing RuntimeEnabled check for <track>
https://bugs.webkit.org/show_bug.cgi?id=73398

Reviewed by Eric Carlson.

No new tests. This fixes a problem when --enable-video-track is not used,
but the tests use this flag.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::trackWillBeRemoved):

8:02 AM Changeset in webkit [101518] by caseq@chromium.org
  • 5 edits in trunk

Web Inspector: [refactoring] do not clone nodes that contain linkified URLs
https://bugs.webkit.org/show_bug.cgi?id=73323

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):

  • inspector/front-end/elementsPanel.css:

(.styles-section a[data-uncopyable]):
(.styles-section a[data-uncopyable]::before):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

7:49 AM Changeset in webkit [101517] by reni@webkit.org
  • 43 edits
    8 adds in trunk

Add new renderer for SVGRectElement.
https://bugs.webkit.org/show_bug.cgi?id=65769

Source/WebCore:

Reviewed by Nikolas Zimmermann.

This patch introduces a new common base class called RenderSVGShape which
replaces the RenderSVGPath. This new base class has the same purpose
as the replaced class and has specialized descendants for common
shapes (like Rectangles and Circles), which allows faster painting
of these shapes when certain conditions are fulfilled. On some
benchmark programs we have seen 5% speedup.

The biggest motivation of this refactor is taking advantage
of faster primitive drawing in the most common and frequent
cases. However in some rare cases, like painting rounded
rects, we need to fallback to the original code path, which
is fully kept in the RenderSVGShape base class. Some other
cases, like dashed strokes, can be painted but mouse pointer
events cannot be handled by the descendant classes. A different
fallback mechanism is used in such cases which redirects
only the pointer event handling to the base class.

Tests: svg/custom/pointer-events-on-rounded-rect.xhtml

svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::contains):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::contains):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGRect):
(WebCore::RenderObject::isSVGShape):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::RenderSVGPath):
(WebCore::RenderSVGPath::inflateWithStrokeAndMarkerBounds): Unite the markerBounds with strokeBoundingBox.

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp: Added.

(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::~RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):

  • rendering/svg/RenderSVGRect.h: Added.

(WebCore::RenderSVGRect::isSVGRect):
(WebCore::RenderSVGRect::renderName):
(WebCore::RenderSVGRect::isEmpty):

  • rendering/svg/RenderSVGResource.h:

(WebCore::RenderSVGResource::postApplyResource): A new shape argument was added to allow shape specific faster painting.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::postApplyResource):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::postApplyResource):

  • rendering/svg/RenderSVGResourceSolidColor.h:
  • rendering/svg/RenderSVGShape.cpp: Copied from Source/WebCore/rendering/svg/RenderSVGPath.cpp.

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::~RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::shapeDependentFillContains):
The purpose of this virtual function allows decendants to use their own fast checks.
(WebCore::RenderSVGShape::fillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::setupSquareCapPath):
(WebCore::RenderSVGShape::setupNonScalingStrokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::addFocusRingRects):
(WebCore::RenderSVGShape::nodeAtFloatPoint):
(WebCore::RenderSVGShape::calculateMarkerBoundsIfNeeded):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::strokeWidth):

  • rendering/svg/RenderSVGShape.h: Copied from Source/WebCore/rendering/svg/RenderSVGPath.h.

(WebCore::BoundingRectStrokeStyleApplier::BoundingRectStrokeStyleApplier):
(WebCore::BoundingRectStrokeStyleApplier::strokeStyle):
(WebCore::RenderSVGShape::setNeedsShapeUpdate):
(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::isPaintingFallback):
(WebCore::RenderSVGShape::path):
(WebCore::RenderSVGShape::setIsPaintingFallback):
(WebCore::RenderSVGShape::setStrokeAndMarkerBoundingBox):
(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(WebCore::RenderSVGShape::renderName):
(WebCore::RenderSVGShape::isRoundedRect):
(WebCore::RenderSVGShape::inflateWithMarkerBounds):
(WebCore::toRenderSVGShape):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::releasePaintingResource):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::finishRenderSVGContent):
(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):
(WebCore::operator<<):
(WebCore::write):

  • rendering/svg/SVGRenderTreeAsText.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::createRenderer):

  • svg/SVGPathElement.h:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):
(WebCore::SVGRectElement::createRenderer):

  • svg/SVGRectElement.h:

LayoutTests:

Add new tests to check the new shape based rendering mechanism of SVGRectElement.

Reviewed by Nikolas Zimmermann.

  • svg/custom/pointer-events-on-rounded-rect-expected.txt: Added.
  • svg/custom/pointer-events-on-rounded-rect.xhtml: Added.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits-expected.txt: Added.
  • svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml: Added.
7:36 AM Changeset in webkit [101516] by Adam Roben
  • 1 edit in trunk/Source/WebCore/ChangeLog

Another Clang build fix after r101507

  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount): Removed unused parameter.

7:35 AM Changeset in webkit [101515] by reni@webkit.org
  • 6 edits in trunk/Source/WebCore

MAC build fix after r101507.

Rubber stamped by Csaba Osztrogonac.

  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didUpdateBufferedAmount):

  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didUpdateBufferedAmount):

  • websockets/WebSocketChannel.h:
7:32 AM Changeset in webkit [101514] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Gtk] Links should be Tab-focusable by default
https://bugs.webkit.org/show_bug.cgi?id=73427

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2011-11-30
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_class_init): Switch the default value for
'enable-tabs-to-links' property from FALSE to TRUE.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Updated unit test.

7:28 AM Changeset in webkit [101513] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary asserts in HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=73135

http://code.google.com/p/chromium/issues/detail?id=103228 shows
that sometimes we are hitting the following assert in
HTMLTextAreaElement::updateFocusAppearance:

ASSERT(!document()->childNeedsAndNotInStyleRecalc());

This assert was added by https://bugs.webkit.org/show_bug.cgi?id=27474
as part of a fix for a crash when the selection is set immediately
after setting display:none.

All the methods called by updateFocusAppearance already handle the
case of the document having the childNeedsStyleRecalc flag set, so
this assert is unnecessary. The ASSERT(renderer()) is similarly
redundant.

Reviewed by Kent Tamura.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

7:24 AM Changeset in webkit [101512] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Clang build fix after r101507

  • websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didUpdateBufferedAmount): Removed unused parameter.

7:18 AM Changeset in webkit [101511] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Preserve an indentation level when inserting a new line
https://bugs.webkit.org/show_bug.cgi?id=71625

Indent one level more when a line ends with either "{", "[" or "(".

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-11-30
Reviewed by Pavel Feldman.

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextRange.prototype.collapseToEnd):
(WebInspector.TextRange.prototype.normalize):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._getSelection):

7:14 AM Changeset in webkit [101510] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Display of data URIs cumbersome in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=73438

Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

7:00 AM Changeset in webkit [101509] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: TreeOutline elements should be formatted using margin-left instead of text-indent.
https://bugs.webkit.org/show_bug.cgi?id=73234

Reviewed by Pavel Feldman.

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView.prototype._refreshHeadersText):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):

  • inspector/front-end/auditsPanel.css:

(.audit-result-tree li):
(.audit-result-tree li.parent):
(.audit-result img):

  • inspector/front-end/inspector.css:

(.outline-disclosure li):
(.outline-disclosure li.parent):

  • inspector/front-end/networkPanel.css:
  • inspector/front-end/resourcesPanel.css:

(.resources.panel .sidebar-resizer-vertical):
(.resources.panel .sidebar li):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

6:55 AM Changeset in webkit [101508] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement the [NamedConstructor] IDL in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=73307

Reviewed by Adam Barth.

This patch implements the [NamedConstructor] IDL for JSC.
The spec: http://www.w3.org/TR/WebIDL/#NamedConstructor

Tests: bindings/scripts/test/JS/JSTestNamedConstructor.idl

  • bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Removed unnecessary conditions '$dataNode->extendedAttributes->{"JSCustomConstructor"}
$dataNode->extendedAttributes->{"CustomConstructor"}'.

(GenerateImplementation): Calls GenerateConstructorDefinition() to generate a NamedConstructor.
(GenerateConstructorDeclaration): Generates a header for a NamedConstructor.
(GenerateConstructorDefinition): Generates a NamedConstructor implementation and getConstructData() for the NamedConstructor.
(IsConstructable): Added a NamedConstructor condition.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Updated a run-bindings-tests result.

(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h: Ditto.

(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):

6:47 AM Changeset in webkit [101507] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Add didUpdateBufferedAmount() callback to SocketStreamHandleClient
and WebSocketChannelClient.
https://bugs.webkit.org/show_bug.cgi?id=73290

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-30
Reviewed by Kent Tamura.

No new tests because this callback is not used in WebCore.

  • platform/network/SocketStreamHandleBase.cpp: Invoke new callback.

(WebCore::SocketStreamHandleBase::send):
(WebCore::SocketStreamHandleBase::sendPendingData):

  • platform/network/SocketStreamHandleBase.h: Change returning value type.

(WebCore::SocketStreamHandleBase::bufferedAmount):

  • platform/network/SocketStreamHandleClient.h: Add new callback definition.

(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount):

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add new callback handling.

(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmountCallback):

  • websockets/ThreadableWebSocketChannelClientWrapper.h: Add new callback inheritance and its helper method.
  • websockets/WebSocket.cpp: Add new callback handling.

(WebCore::WebSocket::didUpdateBufferedAmount):

  • websockets/WebSocket.h: Add new callback inheritance.
  • websockets/WebSocketChannel.cpp: Add new callback handling.

(WebCore::WebSocketChannel::didUpdateBufferedAmount):

  • websockets/WebSocketChannel.h: Add new callback inheritacne.
  • websockets/WebSocketChannelClient.h: Add new callback definition.

(WebCore::WebSocketChannelClient::didUpdateBufferedAmount):

  • websockets/WorkerThreadableWebSocketChannel.cpp: Add new callback handling.

(WebCore::workerContextDidUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):

  • websockets/WorkerThreadableWebSocketChannel.h: Add new callback inheritance and its helper method.
6:33 AM Changeset in webkit [101506] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] In preprocessor.pm, remove double quotations from $defines
https://bugs.webkit.org/show_bug.cgi?id=73160

Reviewed by Adam Barth.

In preprocessor.pm, we need to extract gcc macros from $defines.
$defines can contain unnecessary double quotations.
For example, if $defines is ' "A=1" "B=1" C=1 "" D ',
then it should be converted into four macros, -DA=1, -DB=1, -DC=1 and -DD.
This patch refactors the logic in preprocessor.pm.

No new tests. No change in behavior.

  • bindings/scripts/generate-bindings.pl: Removed a code for $defines conversion, since it is now done in preprocessor.pm.
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

6:23 AM Changeset in webkit [101505] by Philippe Normand
  • 70 edits
    13 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline of some of the previously unskipped
tests that have same results on 32-bit and 64-bit.

  • platform/gtk/fast/css/text-rendering-expected.txt:
  • platform/gtk/fast/text/emphasis-expected.txt:
  • platform/gtk/fast/text/international/hindi-whitespace-expected.txt:
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt:
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/gtk/svg/css/composite-shadow-example-expected.txt:
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/gtk/svg/css/stars-with-shadow-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-1-expected.txt: Added.
  • platform/gtk/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/gtk/svg/custom/circular-marker-reference-4-expected.txt: Added.
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/custom/empty-merge-expected.txt:
  • platform/gtk/svg/custom/getSubStringLength-expected.txt: Added.
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/gtk/svg/custom/linking-uri-01-b-expected.txt:
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/gtk/svg/custom/stroke-width-click-expected.txt: Added.
  • platform/gtk/svg/custom/stroked-pattern-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-word-spacing-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/use-css-events-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt: Added.
  • platform/gtk/svg/custom/use-elementInstance-methods-expected.txt: Added.
  • platform/gtk/svg/dom/altGlyph-dom-expected.txt: Added.
  • platform/gtk/svg/dom/css-transforms-expected.txt: Added.
  • platform/gtk/svg/filters/feColorMatrix-default-type-expected.txt:
  • platform/gtk/svg/filters/feColorMatrix-saturate-expected.txt: Added.
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/filters/parent-children-with-same-filter-expected.txt:
  • platform/gtk/svg/filters/sourceAlpha-expected.txt:
  • platform/gtk/svg/hixie/links/001-expected.txt:
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/gtk/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-2-expected.txt:
  • platform/gtk/svg/text/text-align-04-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
6:15 AM Changeset in webkit [101504] by bashi@chromium.org
  • 3 edits
    2 adds in trunk

@font-face: unquoted local font names containing spaces don't work
https://bugs.webkit.org/show_bug.cgi?id=64783

Source/WebCore:

Allows local font names with spaces.
Rejects the src descriptor if there is invalid identifiers in local(), as the same as Firefox.

Reviewed by Ryosuke Niwa.

Tests: fast/css/font-face-unquoted-local-expected.html

fast/css/font-face-unquoted-local.html

  • css/CSSParser.cpp:

(WebCore::parseFontFaceSrcFunction): Added. Treats multiple identifiers in local() as a font name separated by spaces.
(WebCore::CSSParser::parseFontFaceSrc): Moved the code block which parses local() and format() to parseFontFaceSrcFunction().

LayoutTests:

Adds a test which makes sure that unquoted local font names contains spaces are allowed.

Reviewed by Ryosuke Niwa.

  • fast/css/font-face-unquoted-local-expected.html: Added.
  • fast/css/font-face-unquoted-local.html: Added.
6:08 AM Changeset in webkit [101503] by pfeldman@chromium.org
  • 8 edits in trunk/Source

Web Inspector: get rid of deferred backend->front-end commands processing.
https://bugs.webkit.org/show_bug.cgi?id=73439

Source/WebCore:

We should issue tests upon InspectorAgent::enable and should not do any deferred command processing.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):

  • inspector/InspectorAgent.h:
  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

  • src/WebDevToolsFrontendImpl.h:
6:07 AM Changeset in webkit [101502] by kling@webkit.org
  • 7 edits in trunk

REGRESSION(r101172): It made fast/dom/clone-node-style.html assert.
<http://webkit.org/b/73227>

Reviewed by Antti Koivisto.

Source/WebCore:

r101172 inadvertently introduced a default assignment operator for CSSElementStyleDeclaration
which caused StyledElement::copyNonAttributeProperties() to associate the element's inline
style declaration with the element being cloned.

Replace CSSMutableStyleDeclaration::operator= by copyPropertiesAndStrictnessFrom()
that matches the old behavior.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::copyPropertiesAndStrictnessFrom):

  • css/CSSMutableStyleDeclaration.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

LayoutTests:

Unskip fast/dom/clone-node-style.html.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
6:01 AM Changeset in webkit [101501] by commit-queue@webkit.org
  • 4 edits in trunk

remove buildinformation from BlackBerry porting build system
https://bugs.webkit.org/show_bug.cgi?id=73276

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-11-30
Reviewed by Daniel Bates.

.:

  • Source/cmake/OptionsBlackBerry.cmake: remove script file generate-buildinfo

Source/WebCore:

  • PlatformBlackBerry.cmake: remove generated files BuildInformation.cpp/.h
5:53 AM Changeset in webkit [101500] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Webkit gardening: chromium rebaseline for svg tests.
Unreviewed.

  • platform/chromium-cg-mac-snowleopard/svg/custom/visited-link-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/visited-link-color-expected.png: Added.
5:48 AM Changeset in webkit [101499] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement Zoom Property in CSSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72840

Reviewed by Andreas Kling.

Covered by fast/css/*zoom*.html

  • css/CSSStyleApplyProperty.cpp:

Add new handler for zoom property (based on existing code from CSSStyleSelector.cpp)
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyZoom::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Remove existing implementation.
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::document):
Add getter for Document.

5:46 AM Changeset in webkit [101498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Re-enable layer anti-aliasing on ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=73361

Patch by David Reveman <reveman@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Anti-aliasing should be enabled by default on ChromeOS.

No new tests.

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawLayer):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):

5:45 AM Changeset in webkit [101497] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for svg test.

  • platform/chromium/test_expectations.txt:
5:36 AM Changeset in webkit [101496] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

[WK2] Gardening - skip 2 crashers.

Unreviewed gardening.

[WK2] http/tests/security/local-image-from-remote-whitelisted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=73435

[Qt][WK2] fast/multicol/pagination-v-vertical-lr.html crashes
https://bugs.webkit.org/show_bug.cgi?id=73436

  • platform/wk2/Skipped:
  • platform/qt-wk2/Skipped:
5:34 AM Changeset in webkit [101495] by hayato@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Webkit gardening: chromium rebaseline for svg tests.
Unreviewed.

  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
5:24 AM Changeset in webkit [101494] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix crash when using Qt DRT with V8.

Reviewed by Csaba Osztrogonác.

Add missing handle scopes for the handles returned by mainWorldContext.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):

5:24 AM Changeset in webkit [101493] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] Remove dependency of Qt DRT on JavaScriptCore.

Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,

instead of one that pulls in JavaScriptCore headers.

  • DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers

with load(javascriptcore).

4:58 AM Changeset in webkit [101492] by michaeln@google.co
  • 16 edits in trunk/Source

Source/WebCore: [chromium] WebSQLDatabase could use some better error reporting.
Instruments the database classes to report errors to a DatabaseObserver.
https://bugs.webkit.org/show_bug.cgi?id=73258

Reviewed by David Levin.

No new tests, no content observable artifacts.

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::incrementalVacuumIfNeeded):
(WebCore::AbstractDatabase::reportOpenDatabaseResult):
(WebCore::AbstractDatabase::reportChangeVersionResult):
(WebCore::AbstractDatabase::reportStartTransactionResult):
(WebCore::AbstractDatabase::reportCommitTransactionResult):
(WebCore::AbstractDatabase::reportExecuteStatementResult):
(WebCore::AbstractDatabase::reportVacuumDatabaseResult):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::isSyncDatabase):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::Database):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::changeVersion):

  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):

  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::commit):

  • storage/chromium/DatabaseObserver.h:

Source/WebKit/chromium: [chromium] WebSQLDatabase could use some better error reporting.
Instruments the database classes to report errors a the DatabaseObserver.
https://bugs.webkit.org/show_bug.cgi?id=73258

Reviewed by David Levin.

  • public/WebDatabase.h:
  • public/WebDatabaseObserver.h:

(WebKit::WebDatabaseObserver::reportOpenDatabaseResult):
(WebKit::WebDatabaseObserver::reportChangeVersionResult):
(WebKit::WebDatabaseObserver::reportStartTransactionResult):
(WebKit::WebDatabaseObserver::reportCommitTransactionResult):
(WebKit::WebDatabaseObserver::reportExecuteStatementResult):
(WebKit::WebDatabaseObserver::reportVacuumDatabaseResult):

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::isSyncDatabase):

4:58 AM Changeset in webkit [101491] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix crashing layout tests

Reviewed by Kenneth Rohde Christiansen.

Fix ASSERTION FAILED: m_key != PTHREAD_KEYS_MAX in ThreadIdentifierDataPthreads.cpp(65)
static WTF::ThreadIdentifier WTF::ThreadIdentifierData::identifier()

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::initialize): Add missing WebCore::initializeWebCoreQt().

4:57 AM Changeset in webkit [101490] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[MutationObservers] V8 bindings don't properly wrap all calls into JS
https://bugs.webkit.org/show_bug.cgi?id=72063

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-30
Reviewed by Adam Barth.

This patch changes cleans up script invocation in V8Proxy. It removes callFunctionWithoutFrame
and changes callers to simply call instrumentedFunctionCall with a null Page. Also, it implements
the non-static callFunction to be implemented in terms of instrumentedFunctionCall.

No new tests.

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::call):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

4:52 AM Changeset in webkit [101489] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Rubber-stamped by Csaba Osztrogonác.

Skip the rest of plugin tests (from http directory).
It's not reliable to test plugins without NPAPI support.

  • platform/qt-5.0/Skipped:
4:31 AM Changeset in webkit [101488] by commit-queue@webkit.org
  • 31 edits
    1 move
    4 deletes in trunk

Unreviewed, rolling out r101440 and r101442.
http://trac.webkit.org/changeset/101440
http://trac.webkit.org/changeset/101442
https://bugs.webkit.org/show_bug.cgi?id=73429

multiple crashes on layout tests (Requested by hayato on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-30

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • public/WebCompositor.h:
  • public/WebCompositorClient.h:
  • public/WebCompositorInputHandler.h: Removed.
  • public/WebCompositorInputHandlerClient.h: Removed.
  • public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebCore::CCInputHandler::create):
(WebKit::WebCompositor::setThread):
(WebKit::WebCompositor::fromIdentifier):
(WebKit::WebCompositorImpl::fromIdentifier):
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
(WebKit::WebCompositorImpl::identifier):
(WebKit::WebCompositorImpl::willDraw):

  • src/WebCompositorImpl.h:

(WebKit::WebCompositorImpl::create):

  • src/WebCompositorInputHandlerImpl.cpp: Removed.
  • src/WebCompositorInputHandlerImpl.h: Removed.
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):
(WebKit::shutdown):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setUseThreadedCompositor):

  • src/WebSettingsImpl.h:

(WebKit::WebSettingsImpl::useThreadedCompositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived1::beginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):

  • tests/WebCompositorImplTest.cpp: Renamed from Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost):
(WebViewHost::~WebViewHost):

4:22 AM Changeset in webkit [101487] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed rolling out incorrect r101481.

  • assembler/MIPSAssembler.h:
  • assembler/MacroAssemblerMIPS.h:
4:13 AM Changeset in webkit [101486] by ap@apple.com
  • 10 edits in trunk/Source

Download page URL should be set by WebCore
https://bugs.webkit.org/show_bug.cgi?id=73358

Reviewed by Darin Adler.

Source/WebCore:

No change in behavior, just refactoring.

  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::originatingURLFromBackForwardList):
(WebCore::FrameLoader::setOriginalURLForDownloadRequest):
Moved implementations from WebKit, added a bunch of FIXMEs.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):

Set main document URL (incorrectly renamed to "first party for cookies" in WebCore), so that
CFNetwork would automatically use it.

  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy): Ditto

for requests that start as downloads (as opposed to being converted after reading first bits
of response).

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now

in WebCore.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::download): There is no need to set original URL post factum any more.
(WebFrameLoaderClient::startDownload): Ditto.

Source/WebKit2:

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start): There is no need to set original URL post factum any more.
(WebKit::Download::startWithHandle): Ditto.

4:09 AM Changeset in webkit [101485] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

Rename WebKit::ViewportUpdateGuard to *Deferrer and add some better comments to explain its purpose.

Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:
4:05 AM Changeset in webkit [101484] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation with MingW.

Reviewed by Csaba Osztrogonác.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal): MingW doesn't support MSVC exception handling, so for
the time being make the thread name setting unimplemented for MingW.

3:50 AM Changeset in webkit [101483] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed propective build fix for Qt/Windows part 2 after r101477.

  • wtf/ThreadSpecific.h: Fix the OS(WINDOWS) defines for the friend declaration for ThreadSpecific<T>::Data
3:43 AM Changeset in webkit [101482] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed propective build fix for Qt/Windows after r101477.

  • wtf/ThreadSpecific.h: Use OS(WINDOWS) for declaring "destructor", as it's

only referenced from within another OS(WINDOWS) section.

3:39 AM Changeset in webkit [101481] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed speculative buildfix after r101457.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::readCallTarget):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::readCallTarget):

3:30 AM Changeset in webkit [101480] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove unused isInlineCode from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=73341

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-30
Reviewed by Adam Barth.

No tests needed. This patch only removes unnecessary code.

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):

  • bindings/v8/V8Proxy.h:
3:28 AM Changeset in webkit [101479] by Csaba Osztrogonác
  • 2 edits
    19 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt5 specific expected results for passing tests and skip failing tests.

  • platform/qt-5.0/Skipped: Skip new failing tests.
  • platform/qt-5.0/css2.1/20110323/empty-inline-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/empty-inline-002-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/empty-inline-003-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-001-expected.txt: Added.
  • platform/qt-5.0/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
  • platform/qt-5.0/editing/execCommand/indent-nested-lists-3-expected.txt: Added.
  • platform/qt-5.0/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
  • platform/qt-5.0/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
  • platform/qt-5.0/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
  • platform/qt-5.0/fast/css/font-face-descending-unicode-range-expected.txt: Added.
  • platform/qt-5.0/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/qt-5.0/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/qt-5.0/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/qt-5.0/svg/transforms/svg-css-transforms-expected.txt: Added.
3:22 AM Changeset in webkit [101478] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66524

This patch combines tests from this bug, bug 66525, bug 66526, and bug 66528
and puts them in a single file under fast/forms/

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-11-30
Reviewed by Adam Barth.

  • fast/forms/setCustomValidity-arguments-expected.txt: Added.
  • fast/forms/setCustomValidity-arguments.html: Added.
3:17 AM Changeset in webkit [101477] by Simon Hausmann
  • 17 edits
    2 adds
    1 delete in trunk

.: Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-30
Reviewed by Simon Hausmann.

Add additional WebCoreSupport files for Qt.

  • Source/api.pri:

Source/JavaScriptCore: Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-30
Reviewed by Simon Hausmann.

Use ThreadingPthreads and ThreadingWin instead of ThreadingQt.

  • heap/MachineStackMarker.cpp:
  • wtf/MainThread.cpp:

(WTF::initializeMainThread):

  • wtf/Platform.h:
  • wtf/ThreadSpecific.h: Drop QThreadStorage related code.

(WTF::::destroy):

  • wtf/ThreadingPrimitives.h:
  • wtf/qt/MainThreadQt.cpp: Drop Qt specific isMainThread().

(WTF::initializeMainThreadPlatform): Initialize MainThreadInvoker on main thread to avoid infecting secondary thread with QAdoptedThread.
(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/qt/ThreadingQt.cpp: Removed.
  • wtf/wtf.pro:

Source/WebCore: Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-30
Reviewed by Simon Hausmann.

Need to include qglobal.h since ThreadingPrimitives.h no longer does.

  • platform/network/NetworkingContext.h:

Source/WebKit/qt: Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
https://bugs.webkit.org/show_bug.cgi?id=72155

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-11-30
Reviewed by Simon Hausmann.

Extract WebCore initialization out of QWebPagePrivate into a
separate initialization function. This also needs to be called
from public static QWebSettings methods that call into WebCore,
since those can be used before a QWebPage has been constructed.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • Api/qwebsettings.cpp:

(QWebSettings::globalSettings):
(QWebSettings::setIconDatabasePath):
(QWebSettings::iconDatabasePath):
(QWebSettings::clearIconDatabase):
(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):
(QWebSettings::clearMemoryCaches):
(QWebSettings::maximumPagesInCache):
(QWebSettings::setObjectCacheCapacities):
(QWebSettings::setOfflineStoragePath):
(QWebSettings::offlineStoragePath):
(QWebSettings::setOfflineWebApplicationCachePath):
(QWebSettings::offlineWebApplicationCachePath):
(QWebSettings::setOfflineWebApplicationCacheQuota):
(QWebSettings::offlineWebApplicationCacheQuota):
(QWebSettings::enablePersistentStorage):

  • WebCoreSupport/InitWebCoreQt.cpp: Added.

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/InitWebCoreQt.h: Added.

Source/WebKit2: Build fix. The removal of the Qt threading back-end also removed
an implicit QString inclusion/forward-declaration.

  • UIProcess/qt/QtWebContext.h:
3:12 AM Changeset in webkit [101476] by reed@google.com
  • 2 edits in trunk/LayoutTests

[skia] update expectations for mac-skia results
https://bugs.webkit.org/show_bug.cgi?id=73340

unreviewed, expectations updated.

  • platform/chromium/test_expectations.txt:
3:08 AM Changeset in webkit [101475] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip some of the SVG tests on GTK that might have
been fixed by r101342.

  • platform/gtk/Skipped:
3:07 AM Changeset in webkit [101474] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SOUP][WK2] Implement the functions to manager cookies in CookieJar for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72353

r79722 inserted the functions to manange cookies from web process.
(getHostnamesWithCookies,deleteCookiesForHostname,deleteAllCookies)
Implement the functions for soup network backend.

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-30
Reviewed by Martin Robinson.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

3:06 AM Changeset in webkit [101473] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

MacroAssemblerARM does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73413

Based on Filip Pizlo's patch.

Buildfix. Rubber-stamped by Gabor Loki.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::readCallTarget):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::readCallTarget):

3:00 AM Changeset in webkit [101472] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Avoid ASSERT_NOT_REACHED() from creating FBO with content texture of size 0
https://bugs.webkit.org/show_bug.cgi?id=73266

Source/WebCore:

Remove render surface layers with no children after clipping to
the parent layer.

Move the check for empty render surfaces after the piece of code
used to apply the parent's clip, as we might end up calling
renderSurface->clearLayerList().

Render surfaces with no children or visible content are unexpected
especially at draw time where we might try to create a content
texture and FBO with a size of zero, which will fail. This fixes
an ASSERT_NOT_REACHED() for checkFramebufferStatus() != COMPLETE

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-30
Reviewed by James Robinson.

Added unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-30
Reviewed by James Robinson.

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

2:56 AM Changeset in webkit [101471] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove duplicated UA information function.
https://bugs.webkit.org/show_bug.cgi?id=73104

Reviewed by Filip Pizlo.

Though ewk_setting already implemented an internal function for UA(user agent) information,
FrameLoaderClientEfl has used duplicated function for UA information. So, this patch removes
the UA information function of FrameLoaderClientEfl and uses an internal UA information function
of ewk_setting. In addition, UA infomation function is enhanced for other ports.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::composeUserAgent):

  • ewk/ewk_settings.cpp:

(ewk_settings_default_user_agent_get):

2:55 AM Changeset in webkit [101470] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Clean up the Qt viewport interaction engine

Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::reset):

Make sure reset is not called while suspended.

(WebKit::QtViewportInteractionEngine::applyConstraints):

We always need to apply the constrains due to initial-scale.

Now that we only apply the constrains when we are ready to
paint, it is impossible for the user to have interacted with
the content in the case the viewport meta tag was declared
in the <head> tag, and it is thus always applied.

(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):

Fix this method to actually do what it advertises, before
it would be true even if just animation a bounce back effect.

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

  • UIProcess/qt/QtViewportInteractionEngine.h:

General, get rid of the interaction flags as we only need to
know whether the user interacted (panned, pinched, double-tapped).
Before we would still apply initial-scale if the user had panned
the content which can be pretty confusing.

2:14 AM Changeset in webkit [101469] by pfeldman@chromium.org
  • 12 edits in trunk/Source

Web Inspector: do not report worker-related events unless inspector agent is enabled.
https://bugs.webkit.org/show_bug.cgi?id=73411

Source/WebCore:

Backend should not generate messages until the client requests that they are sent.

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
(WebCore::InspectorAgent::developerExtrasEnabled):

  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::enabled):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):

  • inspector/InspectorPageAgent.cpp:
  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::developerExtrasEnabled):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._workerInspectorClosing):
(WebInspector.WorkerManager.prototype._disconnectedFromWorker):
(WebInspector.DedicatedWorkerMessageForwarder.prototype.dispatchMessageFromWorker):
(WebInspector.DedicatedWorkerMessageForwarder.prototype.disconnectedFromWorker):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::disconnectEventAsText):

2:08 AM Changeset in webkit [101468] by Simon Hausmann
  • 1 edit in trunk/Source/WebKit2/Platform/mac/ModuleMac.mm

Build fix try 2. forgot the missing (void)unused; in the next line

2:01 AM Changeset in webkit [101467] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed prospective mac build fix after r101450.

  • Platform/mac/ModuleMac.mm:

(WebKit::Module::unload): leakRef is declared with attribute warn_unused_result.

1:50 AM Changeset in webkit [101466] by Philippe Normand
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, skip failing placeholder tests on GTK and baselines
for two other tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
  • platform/gtk/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Added.
1:41 AM Changeset in webkit [101465] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/WebCore

Upstream BlackBerry porting of WebCore/editing.
https://bugs.webkit.org/show_bug.cgi?id=73275

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-11-30
Reviewed by Daniel Bates.

Initial upstream, no new tests.

  • editing/blackberry/EditorBlackBerry.cpp: Added.

(WebCore::Editor::newGeneralClipboard):

  • editing/blackberry/SmartReplaceBlackBerry.cpp: Added.

(WebCore::isCharacterSmartReplaceExempt):

1:37 AM Changeset in webkit [101464] by fsamuel@chromium.org
  • 6 edits
    1 copy
    1 add
    1 delete in trunk

[Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:

Tools:

DRT now builds for Aura Linux. This, more or less, shares the same code as Android.

The following changes have been made:

  1. Renamed TestShellAndroid to TestShellLinux.
  2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
  3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown):

  • DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
  • DumpRenderTree/chromium/TestShellGtk.cpp:
  • DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.

(AlarmHandler):
(TestShell::waitTestFinished):
(setupFontconfig):
(platformInit):

  • DumpRenderTree/chromium/TestShellStub.cpp: Added.

(checkLayoutTestSystemDependencies):
(openStartupDialog):

1:27 AM Changeset in webkit [101463] by fsamuel@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=73328

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):

1:22 AM Changeset in webkit [101462] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Added DEFAULT_CACHE_SIZE define.
https://bugs.webkit.org/show_bug.cgi?id=73120

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-30
Reviewed by Filip Pizlo.

Remove form code 40960000 value used in code directly and replaced it by DEFAULT_CACHE_SIZE define. The code
looks cleaner now.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_new):

1:12 AM Changeset in webkit [101461] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

JPEGImageDecoder: Code input color space case entries in numerical order
https://bugs.webkit.org/show_bug.cgi?id=73287

Reviewed by Adam Barth.

No new tests. Covered by existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): JCS_YCbCr is one greater than JSC_RGB.

1:07 AM Changeset in webkit [101460] by dgrogan@chromium.org
  • 3 edits in trunk/LayoutTests

IndexedDB: fix transaction-basics layout test
https://bugs.webkit.org/show_bug.cgi?id=73302

Reviewed by Tony Chang.

  • removed commitAndContinue in favor of transaction complete event handlers
  • abort event handler no longer prints "complete event fired"
  • addIDBObjectsAndCommit no longer overrides addIDBObjects
  • removed starting a transaction from within a setversion transaction
  • removed layoutTestController call and idb-specific done() in favor of finishJSTest and js-test-post include
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
1:01 AM Changeset in webkit [101459] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip tests on GTK presenting 1px differences since r101342.

  • platform/gtk/Skipped: Skip svg and tables tests failing on

64-bits but passing on 32-bits bot.

12:57 AM Changeset in webkit [101458] by Alexandru Chiculita
  • 7 edits
    4 moves in trunk/Source/WebCore

FilterOperation* should stay in rendering/style, because it is directly referenced from RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=72539

Reviewed by Dean Jackson.

No new tests, just moving some files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/CustomFilterOperation.h: Renamed from Source/WebCore/platform/graphics/filters/CustomFilterOperation.h.
  • rendering/style/FilterOperation.h: Renamed from Source/WebCore/platform/graphics/filters/FilterOperation.h.
  • rendering/style/FilterOperations.cpp: Renamed from Source/WebCore/platform/graphics/filters/FilterOperations.cpp.
  • rendering/style/FilterOperations.h: Renamed from Source/WebCore/platform/graphics/filters/FilterOperations.h.
12:44 AM Changeset in webkit [101457] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Resetting a put_by_id inline cache should preserve the "isDirect" bit
https://bugs.webkit.org/show_bug.cgi?id=73375

Reviewed by Gavin Barraclough.

For the replace case, we can find out if it was direct by looking at the
slow call. For the transition case, we explicitly remember if it was
direct.

  • bytecode/CodeBlock.cpp:

(JSC::printStructureStubInfo):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdTransition):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::resetPatchPutById):
(JSC::JIT::isDirectPutById):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::resetPatchPutById):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):

12:41 AM Changeset in webkit [101456] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

[Qt][WK2] Implement permission API for Qt port
https://bugs.webkit.org/show_bug.cgi?id=59200

Permission API hookup for Geolocation, it allows to receive in WebView
a signal when a permission request is done (e.g. to grant permission
for accessing geolocation information) and set it accordingly.

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-11-30
Reviewed by Simon Hausmann.

.:

  • Source/qtwebkit-export.map:

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

  • Target.pri:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebpermissionrequest.cpp: Added.

(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequestPrivate::~QWebPermissionRequestPrivate):
(QWebPermissionRequest::create):
(QWebPermissionRequest::QWebPermissionRequest):
(QWebPermissionRequest::~QWebPermissionRequest):
(QWebPermissionRequest::type):
(QWebPermissionRequest::setAllow):
(QWebPermissionRequest::allow):
(QWebPermissionRequest::scheme):
(QWebPermissionRequest::host):
(QWebPermissionRequest::port):

  • UIProcess/API/qt/qwebpermissionrequest_p.h: Added.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/geolocation.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
  • UIProcess/qt/QtWebPageUIClient.cpp:

(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::permissionRequest):
(QtWebPageUIClient::policyForGeolocationPermissionRequest):

  • UIProcess/qt/QtWebPageUIClient.h:
12:17 AM Changeset in webkit [101455] by hayato@chromium.org
  • 2 edits in trunk/Tools

Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
https://bugs.webkit.org/show_bug.cgi?id=73381

Reviewed by Ryosuke Niwa.

This is a quick fix for the breakage of tests on non-chromium port.
We should implement diff_image later on non-chromium ports.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

12:11 AM Changeset in webkit [101454] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

-[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange when it's out of bounds
https://bugs.webkit.org/show_bug.cgi?id=67813

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView attributedSubstringForProposedRange:actualRange:]): Update actualRange to match
result length.
(-[WKView firstRectForCharacterRange:actualRange:]): Added a FIXME. This is harder to
implement, and it's unclear if clients care at this time.

12:07 AM Changeset in webkit [101453] by haraken@chromium.org
  • 9 edits in trunk

StorageEvent.key should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=73125

Reviewed by Adam Barth.

Currently, document.createEvent('StorageEvent').key is evaluated as null.
However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
says that StorageEvent.key is not a nullable type, and thus
document.createEvent('StorageEvent').key should be (an empty string).

Source/WebCore:

  • storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.

LayoutTests:

  • storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
  • storage/domstorage/events/basic-expected.txt: Ditto.
  • storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
  • storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.

(step6):

  • storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.

(step6):

  • storage/domstorage/events/script-tests/basic.js: Ditto.

(step6):

Nov 29, 2011:

11:56 PM Changeset in webkit [101452] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Fix for fill color not being applied inside visited links
https://bugs.webkit.org/show_bug.cgi?id=70434

Patch by Philip Rogers <pdr@google.com> on 2011-11-29
Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/custom/visited-link-color.svg

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):

LayoutTests:

  • svg/custom/visited-link-color-expected.png: Added.
  • svg/custom/visited-link-color-expected.txt: Added.
  • svg/custom/visited-link-color.svg: Added.
11:53 PM Changeset in webkit [101451] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2011-11-29
Reviewed by Eric Seidel.

Before the this fix always added "qt" option for the option list

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:
10:03 PM Changeset in webkit [101450] by weinig@apple.com
  • 4 edits in trunk/Source

Remove RetainPtr::releaseRef
https://bugs.webkit.org/show_bug.cgi?id=73396

Reviewed by Dan Bernstein.

../JavaScriptCore:

  • wtf/RetainPtr.h:

Be gone releaseRef! Long live leakRef!

../WebKit2:

  • Platform/mac/ModuleMac.mm:

(WebKit::Module::unload):
Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
its sexy replacement.

9:51 PM Changeset in webkit [101449] by hayato@chromium.org
  • 28 edits
    2 copies
    5 moves
    15 adds
    18 deletes in trunk/LayoutTests

Webkit gardening: chromium rebaseline for svg tests.
Unreviewed.

  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-cg-mac-leopard/svg/custom/animate-path-discrete-expected.png:
  • platform/chromium-cg-mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/linking-uri-01-b-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-detach-expected.png:
  • platform/chromium-cg-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/foreignObject/text-tref-02-b-expected.png.
  • platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/hixie/perf/007-expected.png:
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
  • platform/chromium-mac-leopard/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png.
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-win-vista/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/perf/007-expected.png:
  • platform/chromium/svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/composite-shadow-example-expected.txt.
  • platform/chromium/svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/composite-shadow-with-opacity-expected.txt.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/win/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/win/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/foreignObject/text-tref-02-b-expected.txt: Renamed from LayoutTests/platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt.
9:42 PM Changeset in webkit [101448] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add move semantics to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73393

Reviewed by Anders Carlsson.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
Add a move constructor and move enabled assignment operators
to RetainPtr if the compiler being used supports rvalue
references. If the compiler does not support it, we fallback
to the copy semantics we have always had.

9:39 PM Changeset in webkit [101447] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG local CSE may cause incorrect reference counting for a node
https://bugs.webkit.org/show_bug.cgi?id=73390

Reviewed by Filip Pizlo.

When performing a node substitution, the ref count of the replaced
child will be increased, no matter whether the user node is skipped in
code generation or not. This will cause the reference count of the
replaced child never get the chance to become zero and so the
registers occupied by it cannot be reused simply without spilling, if
it's used by a "skipped" node.
This is a 1% gain on V8 benchmark, tested on IA32 Linux.

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

9:36 PM Changeset in webkit [101446] by levin@chromium.org
  • 11 edits
    6 adds in trunk

Add a way to revert a variable to its previous value after leaving a scope.
https://bugs.webkit.org/show_bug.cgi?id=73371

Reviewed by Adam Barth.

Source/JavaScriptCore:

In case anyone from Chromium sees this, it is nearly identical to AutoReset
but if the same name were used, it causes unnecessary ambiguity.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/TemporarilyChange.h: Added.

(WTF::TemporarilyChange::TemporarilyChange):
(WTF::TemporarilyChange::~TemporarilyChange):

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebCore:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebKit/mac:

  • ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Tools:

  • DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
  • TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
  • TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.

(TestWebKitAPI::TEST): Added a test for TemporarilyChange.

9:17 PM EFLWebKitCodingStyle created by gyuyoung.kim@samsung.com
9:17 PM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
8:35 PM Changeset in webkit [101445] by haraken@chromium.org
  • 19 edits
    2 adds in trunk

Implement [Supplemental] IDL and support it in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73162

Reviewed by Adam Barth.

Source/WebCore:

  • Overview:
    • Implement the [Supplemental] IDL in resolve-supplemental.pl and generate-bindings.pl.
    • Support the [Supplemental] IDL in run-bindings-tests.
    • Add TestSupplemental.idl as a binding test and confirm that it works.
  • This patch affects run-bindings-tests results only and does not affect any real builds

since no [Supplemental] IDL has been written in real WebCore IDL files for now.

  • This patch makes a change on CodeGenerator*.pm to support the [Supplemental] IDL

for (custom) getters and setters.

  • Added perl scripts implement the [Supplemental] IDL as follows:

Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files which are implementing $idl;

}

Tests: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/generate-bindings.pl: The input is an IDL file |x| and the dependency file. generate-bindings.pl generates .h and .cpp files for the IDL file |x|, including all the attributes in the IDL files which are implementing the IDL file |x|. generate-bindings.pl addes the [ImplementedBy] IDL to the attributes with the [Supplemental] IDL in order to indicate what IDL is implementing the attributes.
  • bindings/scripts/resolve-supplemental.pl: Added. resolve-supplemental.pl reads all IDL files, resolves [Supplemental=XXX] dependencies, and then outputs the dependency file. See the comment in resolve-supplemental.pl for the format of the dependency file.
  • bindings/scripts/CodeGenerator.pm:

(GenerateConditionalStringFromAttributeValue): Avoids duplicated conditions.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): If an attribute is [ImplementedBy] another IDL, then we omit the declaration of the custom getter and setter.
(GenerateImplementation): If an attribute is [ImplementedBy] another IDL, then we call back the (custom) getter and setter of the IDL.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): If an attribute is [ImplementedBy] another IDL, then we omit the declaration of the custom getter and setter.
(GenerateNormalAttrGetter): If an attribute is [ImplementedBy] another IDL, then we call back the getter of the IDL.
(GenerateNormalAttrSetter): If an attribute is [ImplementedBy] another IDL, then we call back the setter of the IDL.
(GenerateSingleBatchedAttribute): If an attribute is [ImplementedBy] another IDL, then we call back the custom getter or setter of the IDL.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation): If an attribute is [ImplementedBy] another IDL, then we call back the getter and setter of the IDL. CodeGeneratorCPP.pm does not support a custom getter and setter.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty): Ditto.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation): Ditto.

  • bindings/scripts/test/TestSupplemental.idl: Added. A test case for the [Supplemental] IDL.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated a run-bindings-tests result.

(WebDOMTestInterface::str1):
(WebDOMTestInterface::str2):
(WebDOMTestInterface::setStr2):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.

(webkit_dom_test_interface_get_str1):
(webkit_dom_test_interface_get_str2):
(webkit_dom_test_interface_set_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore::jsTestInterfaceStr1):
(WebCore::jsTestInterfaceStr2):
(WebCore::jsTestInterfaceStr3):
(WebCore::JSTestInterface::put):
(WebCore::setJSTestInterfaceStr2):
(WebCore::setJSTestInterfaceStr3):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface str1]):
(-[DOMTestInterface str2]):
(-[DOMTestInterface setStr2:]):
(-[DOMTestInterface str3]):
(-[DOMTestInterface setStr3:]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceInternal::str1AttrGetter):
(WebCore::TestInterfaceInternal::str2AttrGetter):
(WebCore::TestInterfaceInternal::str2AttrSetter):
(WebCore::ConfigureV8TestInterfaceTemplate):

Tools:

run-bindings-tests supports the [Supplemental] IDL in the following way.

(1) It creates a file |x| listing all IDL files.
(2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
(3) For each IDL file |z|, it runs generate-bindings.pl with |y|.

Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
including all attributes in IDL files that are supplementing the IDL file |z|.

  • Scripts/run-bindings-tests:

(generate_from_idl):
(generate_supplemental_dependency):
(detect_changes):
(run_tests):
(main):

7:19 PM Changeset in webkit [101444] by leo.yang@torchmobile.com.cn
  • 1 edit
    1 add in trunk/Source/WebCore

Upstream platform/network/blackberry/ProxyServerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=73288

Reviewed by Antonio Gomes.

Initial upstream, can't be built yet, no new tests.

  • platform/network/blackberry/ProxyServerBlackBerry.cpp: Added.

(WebCore::proxyServersForURL):

7:05 PM Changeset in webkit [101443] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add COMPILER_SUPPORTS macro to allow for compiler feature testing
https://bugs.webkit.org/show_bug.cgi?id=73386

Reviewed by Anders Carlsson.

  • wtf/Compiler.h:

Add COMPILER_SUPPORTS and #defines for C++11 variadic templates and
rvalue references for Clang.

6:29 PM Changeset in webkit [101442] by nduca@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix clang build by using raw pointers instead of static OwnPtrs
for WebCompositor managment.

  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::initialize):
(WebKit::WebCompositorImpl::shutdown):

  • src/WebCompositorImpl.h:
6:29 PM Changeset in webkit [101441] by jberlin@webkit.org
  • 11 edits in trunk/Source

WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
the first time it is called.
https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)

Reviewed by Brady Eidson.

Source/WebCore:

Add a callback for when the Storage Tracker is done loading the list of origins with Local
Storage.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
Keep track of whether the import from disk has been completed.
(WebCore::StorageTracker::notifyFinishedImportingOriginIdentifiersOnMainThread):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
Set m_finishedImportingOriginIdentifiers to true and tell the client.
(WebCore::StorageTracker::syncImportOriginIdentifiers):
When finished, notify the shared StorageTracker on the main thread.

  • storage/StorageTracker.h:

(WebCore::StorageTracker::originsLoaded):

  • storage/StorageTrackerClient.h:

Add didFinishLoadingOrigins.

Source/WebKit/mac:

  • Storage/WebStorageTrackerClient.h:
  • Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::didFinishLoadingOrigins):

Source/WebKit2:

Queue any requests for the origins that have Local Storage until the StorageTracker is done
loading the list of those origins from disk.

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::keyValueStorageOriginIdentifiers):
Refactored here from getKeyValueStorageOrigins so it can be used by didFinishLoadingOrigins.
(WebKit::dispatchDidGetKeyValueStorageOrigins):
Ditto.
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
If the StorageTracker is not done loading the list of origins from disk, queue up the
request to be handled later.
(WebKit::WebKeyValueStorageManager::didFinishLoadingOrigins):
Dispatch the results for any requests that were make before the StorageTracker was done
loading the list of origins from disk.
(WebKit::WebKeyValueStorageManager::dispatchDidModifyOrigin):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Set the WebKeyValueStorageManager as the StorageTrackerClient.

6:16 PM EFLWebKit edited by ryuan.choi@samsung.com
update package dependency which added after r101347. (diff)
6:09 PM Changeset in webkit [101440] by nduca@chromium.org
  • 31 edits
    4 copies
    1 move in trunk

[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::layerRendererContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setMainThreadIsImplThread):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):

Source/WebKit/chromium:

  • public/WebCompositor.h:
  • public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::initialize):
(WebKit::WebCompositor::shutdown):
(WebKit::WebCompositor::fromIdentifier):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::threadedCompositingEnabled):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost):
(WebViewHost::~WebViewHost):

5:44 PM Changeset in webkit [101439] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Update Mac results after r101342.

  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
5:20 PM Changeset in webkit [101438] by zmo@google.com
  • 18 edits
    32 adds
    45 deletes in trunk/LayoutTests

Webkit gardening: chromium rebaseline.

5:05 PM Changeset in webkit [101437] by zmo@google.com
  • 13 edits
    17 adds
    9 deletes in trunk/LayoutTests

Webkit gardening: chromium rebaseline.

4:54 PM Changeset in webkit [101436] by zmo@google.com
  • 16 edits
    28 adds
    12 deletes in trunk/LayoutTests

Webkit gardening: chromium rebaseline.

4:46 PM Changeset in webkit [101435] by commit-queue@webkit.org
  • 18 edits in trunk/LayoutTests

Unreviewed, rolling out r101363.
http://trac.webkit.org/changeset/101363
https://bugs.webkit.org/show_bug.cgi?id=73373

checked in incorrect results (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-29

  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
4:45 PM Changeset in webkit [101434] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix for Leopard compilation.

4:38 PM Changeset in webkit [101433] by arv@chromium.org
  • 7 edits in trunk/Source/WebCore

WebIDL: Add support for static for JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=72998

Reviewed by Adam Barth.

WebIDL uses "static" for class methods. We used to use "[ClassMethod]". This change makes us use the WebIDL syntax instead.

No new tests: Covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionName): Use isStatic instead.
(GenerateOverloadedFunction): Ditto.
(GenerateImplementation): Ditto.
(GenerateParametersCheck): Ditto.
(GenerateImplementationFunctionCall): Ditto.
(GenerateConstructorDefinition): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback): Ditto.
(GenerateImplementation): Ditto.
(GenerateFunctionCallString): Ditto.

  • bindings/scripts/IDLParser.pm:

(ParseInterface): Set isStatic as needed.

  • bindings/scripts/IDLStructure.pm: Update regular expression to parse "static".
  • bindings/scripts/test/TestObj.idl: Use static instead of [ClassMethod].
  • storage/IDBKeyRange.idl: Ditto.
4:30 PM Changeset in webkit [101432] by zmo@google.com
  • 13 edits
    23 adds
    6 deletes in trunk/LayoutTests

Webkit gardening: rebaseline.

4:30 PM Changeset in webkit [101431] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rebaselined a run-bindings-tests result.

  • bindings/scripts/test/JS/JSFloat64Array.h:
4:23 PM Changeset in webkit [101430] by xji@chromium.org
  • 8 edits
    2 adds in trunk

--webkit-visual-word should be able to reach end of text, instead of end of line
https://bugs.webkit.org/show_bug.cgi?id=72048

Reviewed by Ryosuke Niwa.

Source/WebCore:

Revert r92223 -- webkit-visual-word should reach boundary of line.
When there is no more left or right words in the same editing boundary and
current position is an editable position, return start or end position in this
editable content.

Test: editing/selection/move-by-word-visually-textarea.html

  • editing/visible_units.cpp:

(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html:
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-multi-line.html:
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
  • editing/selection/move-by-word-visually-textarea-expected.txt: Added.
  • editing/selection/move-by-word-visually-textarea.html: Added.
4:19 PM Changeset in webkit [101429] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r101418.
http://trac.webkit.org/changeset/101418
https://bugs.webkit.org/show_bug.cgi?id=73372

Chromium renderer crashes with ENABLE(MUTATION_OBSERVERS)
(Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-29

  • public/platform/WebThread.h:
  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

4:19 PM Changeset in webkit [101428] by zmo@google.com
  • 13 edits
    16 adds
    7 deletes in trunk/LayoutTests/platform

Webkit gardening: rebaseline.

3:49 PM Changeset in webkit [101427] by zmo@google.com
  • 7 edits
    9 adds
    9 deletes in trunk/LayoutTests/platform

Webkit gardening: rebaseline.

3:36 PM Changeset in webkit [101426] by oliver@apple.com
  • 8 edits in trunk/Source

Allow WebCore to describe typed arrays to JSC
https://bugs.webkit.org/show_bug.cgi?id=73355

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Allow globaldata to track the structure of typed arrays.

  • runtime/JSGlobalData.h:

(JSC::TypedArrayDescriptor::TypedArrayDescriptor):

Source/WebCore:

Update bindings codegen to report the data layout to JSC.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::finishCreation):

  • bindings/scripts/test/JS/JSFloat64Array.h:
2:46 PM Changeset in webkit [101425] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

add webkit_user_agent to DRT and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=73362

Reviewed by Tony Chang.

In preparation for building webkit_glue as a separate component,
we need to explicitly declare DRT's and webkit_unit_tests'
dependencies on webkit_user_agent.

  • WebKit.gyp:
2:42 PM Changeset in webkit [101424] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename some flexbox functions to be less confusing
https://bugs.webkit.org/show_bug.cgi?id=73363

Reviewed by Ojan Vafai.

These methods no longer have anything to do with block/inline direction.

No new tests, just renaming some functions.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderFlexibleBox.h:
2:22 PM Changeset in webkit [101423] by zmo@google.com
  • 5 edits
    6 deletes in trunk/LayoutTests/platform

Webkit gardening: rebaseline.

2:08 PM Changeset in webkit [101422] by zmo@google.com
  • 72 edits
    41 adds
    44 deletes in trunk/LayoutTests/platform

Webkit gardening: rebaseline svg tests.

1:58 PM Changeset in webkit [101421] by arv@chromium.org
  • 4 edits in trunk/Source/WebCore

Add support for [ClassMethod] to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=73342

Reviewed by Adam Barth.

If a method is annotated with [ClassMethod] it will become a method on the JS constructor object and it will
call a static function on the C++ class.

This was previously only implemented in CodeGeneratorV8.pm so this brings JSC up to par.

No new tests: Covered by bindings/scripts/test/

  • bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionName): Refactor to reduce code duplication.
(GenerateHeader): Ditto.
(GenerateOverloadedFunction): This now handles both prototype functions and constructor functions.
(GenerateImplementation): Define class methods too.
(GenerateParametersCheck): Generate the right function access string.
(GenerateImplementationFunctionCall): SVG properties are not static methods.
(GenerateConstructorDefinition): For classes that have static methods we may now return function properties.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlot): Ditto.
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): Ditto.
(WebCore::jsTestObjConstructorFunctionClassMethod): Now calls a static function.
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Ditto.

  • bindings/scripts/test/JS/JSTestObj.h:
1:55 PM Changeset in webkit [101420] by zmo@google.com
  • 77 edits
    104 adds
    99 deletes in trunk/LayoutTests

Webkit gardening: rebaseline svg tests.

1:47 PM Changeset in webkit [101419] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused JSDOMWrapperOwner
https://bugs.webkit.org/show_bug.cgi?id=73357

Reviewed by Adam Barth.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::globalData):
Remove JSDOMWrapperOwner. It is unused.

1:33 PM Changeset in webkit [101418] by adamk@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium side of this patch is http://codereview.chromium.org/8586038/

  • public/platform/WebThread.h:

(WebKit::WebThread::TaskObserver::~TaskObserver):

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

1:31 PM Changeset in webkit [101417] by tony@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Clean up fast/regions/no-split-line-box.html test
https://bugs.webkit.org/show_bug.cgi?id=73343

Patch by Alan Stearns <stearns@adobe.com> on 2011-11-29
Reviewed by Tony Chang.

  • fast/regions/no-split-line-box.html:
  • platform/efl/fast/regions/no-split-line-box-expected.png: Removed.
  • platform/mac/fast/regions/no-split-line-box-expected.png: Removed.
1:29 PM Changeset in webkit [101416] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Use contentsToRootView when converting the mouse coordinates for the context menu key event
https://bugs.webkit.org/show_bug.cgi?id=73352

Reviewed by Adam Roben.

No new tests: Already covered by existing tests.

This is another step towards fixing https://bugs.webkit.org/show_bug.cgi?id=71945, by getting
rid of a call to ScrollView::contentsToWindow.

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

1:29 PM Changeset in webkit [101415] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Decorate adoptWK with WARN_UNUSED_RETURN
https://bugs.webkit.org/show_bug.cgi?id=73331

Reviewed by Sam Weinig.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::adoptWK):

1:29 PM Changeset in webkit [101414] by andersca@apple.com
  • 7 edits in trunk/Source

DragClient::dragSourceActionMaskForPoint should use root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72409

Reviewed by Sam Weinig.

Source/WebCore:

  • page/DragClient.h:

Rename parameter and remove obsolete comment.

  • page/DragController.cpp:

(WebCore::DragController::delegateDragSourceAction):

  • page/DragController.h:

Rename parameter.

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragSourceActionsAllowed):
Use contentsToRootView instead of contentsToWindow.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::dragSourceActionMaskForPoint):
Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.

1:29 PM Changeset in webkit [101413] by andersca@apple.com
  • 7 edits in trunk/Source

EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72408

Reviewed by Sam Weinig.

Source/WebCore:

Rename windowRectForRange to rootViewRectForRange and use contentsToRootView instead of contentsToWindow.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::show):
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::rootViewRectForRange):

  • editing/SpellingCorrectionController.h:

Source/WebKit/mac:

  • WebCoreSupport/CorrectionPanel.mm:

(CorrectionPanel::show):
Convert the bounding rect to web view coordinates.

  • WebView/WebView.mm:

(-[WebView _convertPointFromRootView:]):
(-[WebView _convertRectFromRootView:]):

  • WebView/WebViewInternal.h:

Add helper methods for converting from root view coordinates to web view coordinates.

1:22 PM Changeset in webkit [101412] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ WebKit2 build after r101312.

  • Scripts/generate-forwarding-headers.pl: Add blackberry to the

list of platforms.

1:22 PM Changeset in webkit [101411] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
https://bugs.webkit.org/show_bug.cgi?id=72668

Reviewed by David Hyatt.

Source/WebCore:

For new flexible boxes, we were setting childrenInline to true when
merging anonymous blocks, which we should never do. Do the same thing
we do for the deprecated flexboxes.

Test: css3/flexbox/anonymous-block-merge-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setChildrenInline):
The default value of true was never used. Better to keep it explicit.

LayoutTests:

  • css3/flexbox/anonymous-block-merge-crash-expected.txt: Added.
  • css3/flexbox/anonymous-block-merge-crash.html: Added.
1:12 PM Changeset in webkit [101410] by ojan@chromium.org
  • 3 edits in trunk/Tools

List of builders in the flakiness dashboard is out of date
https://bugs.webkit.org/show_bug.cgi?id=73347

Reviewed by Adam Barth.

The chromium gpu bots no longer run layout tests, so kill that
group entirely.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
1:07 PM Changeset in webkit [101409] by zmo@google.com
  • 46 edits
    50 adds
    52 deletes in trunk/LayoutTests

Webkit gardening: rebaseline svg tests.

12:47 PM Changeset in webkit [101408] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Don't hard-code the list of WebKit2 generated sources

The generated sources are... wait for it... generated. So
use the generator itself to figure out which sources we need
to compile.

Reviewed by Simon Hausmann.

12:47 PM Changeset in webkit [101407] by zmo@google.com
  • 28 edits
    53 adds
    76 deletes in trunk/LayoutTests

Webkit gardening: rebaseline svg tests.

12:37 PM Changeset in webkit [101406] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount >= 1)
in IsolateTracker::exitIsolate()
https://bugs.webkit.org/show_bug.cgi?id=69275

Reviewed by Eric Seidel.

Source/WebCore:

The crash was caused by our false assumption that at most one isolated container exists between the start
and the root when appending a new run. Fixed the crash by computing the actual number of isolated containers
between the start and the root.

Test: fast/text/nested-bidi-isolate-crash.html

  • rendering/InlineIterator.h:

(WebCore::numberOfIsolateAncestors):
(WebCore::IsolateTracker::IsolateTracker):
(WebCore::InlineBidiResolver::appendRun):

LayoutTests:

Add a regression test.

  • fast/text/nested-bidi-isolate-crash-expected.txt: Added.
  • fast/text/nested-bidi-isolate-crash.html: Added.
12:31 PM Changeset in webkit [101405] by zmo@google.com
  • 29 edits
    36 adds
    27 deletes in trunk/LayoutTests/platform

webkit gardening: rebaseline svg tests.

12:30 PM Changeset in webkit [101404] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/Tools

[GTK] Add a method to detect 'make dist' errors without running 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=73216

Reviewed by Philippe Normand.

Add a script that tries to sniff out 'make dist' problems without running
'make dist.' 'make distcheck' takes a very long time to run and this should
reduce the amount of times it needs to be run consecutively.

  • gtk/common.py:

(get_build_path.is_valid_build_directory): Guess the source directory
by the existence of the GNUmakefile instead of the .libs directory. This
allows one to run the script after running autogen.sh but before fully
building.

  • gtk/find-make-dist-errors: Added.
12:11 PM Changeset in webkit [101403] by zmo@google.com
  • 93 edits
    115 adds
    123 deletes in trunk/LayoutTests/platform

Webkit gardening: rebaseline svg tests.

12:08 PM Changeset in webkit [101402] by zmo@google.com
  • 30 edits
    53 adds
    55 deletes in trunk/LayoutTests

Webkit gardening: rebaseline svn tests.

11:44 AM Changeset in webkit [101401] by oliver@apple.com
  • 14 edits in trunk/Source/WebCore

Revert that last change, apparently it destroys everything in the world.

11:31 AM Changeset in webkit [101400] by xji@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Rebase after r100819.

  • platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Removed.
  • platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
  • platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:07 AM Changeset in webkit [101399] by tony@chromium.org
  • 5 edits
    2 adds in trunk

flex-align:stretch + max-height needs to clamp to max-height and position appropriately
https://bugs.webkit.org/show_bug.cgi?id=70780

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/flex-align-max.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): When laying out columns, if the flex item is stretching,
we don't need to shrink wrap.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isColumnFlow): Switch to RenderStyle helper method.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection): For columns, we don't need to do anything.
For rows, handle max logical height by setting the height and recomputing (which will take max-height
into consideration).

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isColumnFlexFlow): Helper method.

LayoutTests:

  • css3/flexbox/flex-align-max-expected.txt: Added.
  • css3/flexbox/flex-align-max.html: Added.
11:05 AM Changeset in webkit [101398] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove unused variable (gcc 4.6 complains about this)
https://bugs.webkit.org/show_bug.cgi?id=73335

../../third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:296:19:
error: variable 'oldReplicaMaskRect' set but not used [-Werror=unused-but-set-variable]

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

10:56 AM Changeset in webkit [101397] by Philippe Normand
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed, other round of GTK rebaseline.

  • platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Added.
  • platform/gtk/editing/execCommand/insertImage-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt: Added.
  • platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
  • platform/gtk/plugins/embed-attributes-style-expected.txt:
10:32 AM Changeset in webkit [101396] by oliver@apple.com
  • 14 edits in trunk/Source/WebCore

DOM wrapper cache doesn't need to use JSDOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=73333

Reviewed by Sam Weinig.

Make JSDOMWrapperCache use JSObject rather than JSDOMWrapper
and propagate the type change out.

  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::toJSArrayBufferView):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSDOMBinding.h:

(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::wrap):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::toJS):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

10:26 AM Changeset in webkit [101395] by Philippe Normand
  • 17 edits
    10 adds in trunk/LayoutTests

Unreviewed, another GTK svg rebaseline after r101342.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Added.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Added.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Added.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Added.
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/gtk/svg/custom/image-small-width-height-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-rotate-expected.txt: Added.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt: Added.
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt:
9:53 AM Changeset in webkit [101394] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r101392.

  • GNUmakefile.am: USE_WEBAUDIO_FFTW was removed, don't use it anymore.
9:36 AM Changeset in webkit [101393] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] SIGSEV when a WebKitDownload fails
https://bugs.webkit.org/show_bug.cgi?id=72883

Reviewed by Xan Lopez.

After r100769 http status codes >= 400 trigger download
failures. We must ensure that the download is properly cancelled
before clearing the ResourceHandle client to avoid crashes.

  • webkit/webkitdownload.cpp:

(DownloadClient::didReceiveResponse):

9:34 AM Changeset in webkit [101392] by Philippe Normand
  • 2 edits in trunk

[GTK] hide WebAudio build option until support for FFTW is removed
https://bugs.webkit.org/show_bug.cgi?id=73295

Reviewed by Martin Robinson.

  • configure.ac: Disable WebAudio until the FFTW dependency is removed.
9:28 AM Changeset in webkit [101391] by Philippe Normand
  • 17 edits in trunk/LayoutTests

Unreviewed, GTK svg/W3C-I18N rebaseline.

  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
9:21 AM Changeset in webkit [101390] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test_expectations update (added a bug ID).

  • platform/chromium/test_expectations.txt:
9:10 AM Changeset in webkit [101389] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed evening gardening.

9:02 AM Changeset in webkit [101388] by Philippe Normand
  • 16 edits in trunk/LayoutTests

Unreviewed, GTK fonts rebaseline after r101343.

  • platform/gtk/fonts/complex-text-shadows-expected.txt:
  • platform/gtk/fonts/cursive-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/default-expected.txt:
  • platform/gtk/fonts/fantasy-expected.txt:
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt:
  • platform/gtk/fonts/font-with-no-valid-encoding-expected.txt:
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
  • platform/gtk/fonts/monospace-expected.txt:
  • platform/gtk/fonts/sans-serif-expected.txt:
  • platform/gtk/fonts/serif-expected.txt:
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt:
8:58 AM Changeset in webkit [101387] by Philippe Normand
  • 16 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of animations and fast after
r101343. Also skip some failing fast/ ClientRect tests.

  • platform/gtk/Skipped:
  • platform/gtk/animations/additive-transform-animations-expected.txt:
  • platform/gtk/animations/missing-values-first-keyframe-expected.txt:
  • platform/gtk/animations/missing-values-last-keyframe-expected.txt:
  • platform/gtk/animations/state-at-end-event-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/gtk/fast/borders/rtl-border-05-expected.txt:
  • platform/gtk/fast/css/word-space-extra-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/dom/inner-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
  • platform/gtk/fast/table/multiple-captions-display-expected.txt:
8:34 AM Changeset in webkit [101386] by Philippe Normand
  • 16 edits in trunk/LayoutTests

Unreviewed, GTK media rebaseline after r101343.

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-frame-accurate-seek-expected.txt:
  • platform/gtk/media/video-layer-crash-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-transformed-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
8:24 AM Changeset in webkit [101385] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: TextPrompt should show suggest above or under so that it has maximal height.
https://bugs.webkit.org/show_bug.cgi?id=73239

Reviewed by Pavel Feldman.

Fixed suggest box vertical position / height calculation.
Added round corners when suggest box is positioned under text prompt.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):

  • inspector/front-end/inspector.css:

(.suggest-box.generic-suggest.under-anchor):

8:18 AM Changeset in webkit [101384] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Remove use of internal headers in the MiniBrowser

Reviewed by Simon Hausmann.

8:12 AM Changeset in webkit [101383] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix the GTK+ port build after r101307.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

  • GNUmakefile.am: Add missing files to compilation.
8:10 AM Changeset in webkit [101382] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Fix debug-shlib build without webkit2

Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
8:01 AM Changeset in webkit [101381] by pfeldman@chromium.org
  • 17 edits in trunk

Web Inspector: split Preferences into Preferences and Capabilities.
https://bugs.webkit.org/show_bug.cgi?id=73321

Source/WebCore:

Part of the Preferences defined in Settings.js are in fact backend capabilities.
Split them into two separate objects for further capabilities refactoring.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):