⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 5, 2011:

11:51 PM Changeset in webkit [102103] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

New test introduced in r102048 fails on Qt-WK1
https://bugs.webkit.org/show_bug.cgi?id=73366

  • platform/qt-wk1/Skipped: Skip fast/events/dont-loose-last-event.html
11:49 PM Changeset in webkit [102102] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[MutationObservers] Enable in Chromium trunk
https://bugs.webkit.org/show_bug.cgi?id=73851

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

  • features.gypi:
11:45 PM Changeset in webkit [102101] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

chromium build fix

  • src/WebLayerTreeView.cpp:
11:37 PM Changeset in webkit [102100] by commit-queue@webkit.org
  • 5 edits in trunk

[MutationObservers] Support 'attributes' mutation records for element.removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=73880

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-05
Reviewed by Ojan Vafai.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::removeAttribute):

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
11:24 PM Changeset in webkit [102099] by jamesr@google.com
  • 4 edits
    6 adds in trunk/Source/WebKit/chromium

Rollout http://trac.webkit.org/changeset/102019, dependent has not
landed in chromium

  • WebKit.gyp:
  • public/WebContentLayer.h: Added.
  • public/WebExternalTextureLayer.h: Added.
  • public/WebLayer.h: Added.
  • public/WebLayerClient.h: Added.
  • public/WebLayerTreeView.h: Added.
  • public/WebLayerTreeViewClient.h: Added.
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
10:56 PM Changeset in webkit [102098] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Set opaque flag for WebGLLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73876

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/WebGLLayerChromiumTest.cpp

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::platformLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/WebGLLayerChromiumTest.cpp: Added.

(WebKit::CompositorMockWebGraphicsContext3D::create):
(WebKit::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WebKit::CompositorMockWebGraphicsContext3D::createProgram):
(WebKit::CompositorMockWebGraphicsContext3D::createShader):
(WebKit::CompositorMockWebGraphicsContext3D::getShaderiv):
(WebKit::CompositorMockWebGraphicsContext3D::getProgramiv):
(WebKit::CompositorMockWebGraphicsContext3D::getContextAttributes):
(WebKit::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WebKit::createGraphicsContext):
(WebKit::TEST):

10:31 PM Changeset in webkit [102097] by benjamin@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Upstream the Cursor implementation of iOS
https://bugs.webkit.org/show_bug.cgi?id=73724

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

iOS does not need to support the Cursor of WebKit. For compatibility, Cursor
is implemented as an empty class on the platform.

  • Configurations/WebCore.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Cursor.h:

(WebCore::Cursor::Cursor):

  • platform/ios/CursorIOS.cpp: Added.

(WebCore::cursor):
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::moveCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::notAllowedCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
(WebCore::determineHotSpot):

10:20 PM Changeset in webkit [102096] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] GIF image test crashes on 32- and 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73812

Reviewed by Adam Barth.

Call resize() on the image pixel backing store after allocation to see if
that stops the GIF image decoder animation tests crashes on GTK.

No new tests, covered by exiting tests ...

fast/backgrounds/animated-gif-as-background.html
fast/images/dont-crash-with-null-gif-frames.html
fast/images/gif-loop-count.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

10:13 PM Changeset in webkit [102095] by arv@chromium.org
  • 4 edits in trunk/Source/WebCore

Could save a lot of memory in CharacterData by not always storing a String
https://bugs.webkit.org/show_bug.cgi?id=72404

Reviewed by Ojan Vafai.

When a Text node is created by the parser we check if the string is all whitespace
and if so we put it in the AtomicString table so that all future identical whitespace
strings can share the StringImpl.

No new tests. Covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLNames::isAllWhitespace):
(WebCore::HTMLConstructionSite::insertTextNode):

If we do not know whether the string is all whitespace this now checks the string
If the string is all whitespace we create an AtomicString for it.

  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingNonWhitespace): We never cared about the return value here.
(WebCore::HTMLTreeBuilder::processCharacterBuffer): Pass WhitespaceMode in the case we know whether the string is all whitespace or not.
(WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.

10:10 PM Changeset in webkit [102094] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update KURL's copy copyASCII to avoid String::characters()
https://bugs.webkit.org/show_bug.cgi?id=73794

Reviewed by Andreas Kling.

When the String is already on 8 bits, we can simply copy the
data. In the 16 bits case, everything remains the same.

  • platform/KURL.cpp:

(WebCore::copyASCII):
(WebCore::appendASCII):
(WebCore::KURL::init):
(WebCore::KURL::parse):
(WebCore::KURL::copyToBuffer):

9:55 PM Changeset in webkit [102093] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] MiniBrowser should default to touch behavior
https://bugs.webkit.org/show_bug.cgi?id=73863

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Chang Shu.

MiniBrowser currently defaults to the traditional desktop behaviour
instead of touch behaviour which is prefered.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setUseTraditionalDesktopBehavior):
(WindowOptions::useTraditionalDesktopBehavior):

9:30 PM Changeset in webkit [102092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=73683
Implement KeyframeValueList::operator=() and KeyframeValueList::swap().

Patch by Yong Li <yoli@rim.com> on 2011-12-05
Reviewed by Darin Adler.

No new tests as no functional change.

  • platform/graphics/GraphicsLayer.h:

(WebCore::KeyframeValueList::operator=): Added
(WebCore::KeyframeValueList::swap): Added

9:05 PM Changeset in webkit [102091] by enne@google.com
  • 8 edits in trunk/Source

[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::notifySyncRequired):

  • platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

  • tests/LayerChromiumTest.cpp:
8:59 PM Changeset in webkit [102090] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

small refactor of RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=73854

Reviewed by Darin Adler.

No new tests, just a refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
to mainAxisOffset. Rename logicalTop to crossAxisOffset. Get rid of
logicalLeft local variable since it's confusing. Move shouldFlipMainAxis
out of the for loop to avoid computing it each iteration.

  • rendering/RenderFlexibleBox.h:
8:46 PM Changeset in webkit [102089] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
https://bugs.webkit.org/show_bug.cgi?id=73765

Patch by Florin Malita <fmalita@google.com> on 2011-12-05
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/foreign-content-crash.html

Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • fast/parser/foreign-content-crash-expected.txt: Added.
  • fast/parser/foreign-content-crash.html: Added.
8:16 PM Changeset in webkit [102088] by senorblanco@chromium.org
  • 21 edits in trunk/Source

Allow the ImageBuffers used by SVG filters to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=73842

Reviewed by Kenneth Russell.

Source/WebCore:

Regressions covered by existing SVG tests; new functionality to be
tested by the API exposed on Internals.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setAcceleratedFiltersEnabled):
(WebCore::Settings::acceleratedFiltersEnabled):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::Filter):
(WebCore::Filter::renderingMode):
(WebCore::Filter::setRenderingMode):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::platformTransformColorSpace):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::createImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:
  • testing/Internals.cpp:

(WebCore::Internals::setAcceleratedFiltersEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedFiltersEnabled):

  • src/WebSettingsImpl.h:
8:07 PM Changeset in webkit [102087] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Frame is not being showed in the screen when frameLoadCompleted is called
https://bugs.webkit.org/show_bug.cgi?id=73850

WebKit2 has a mechanism to prevent the composited layer tree of the outgoing page
from being torn down or updated until the incoming page has layout. However, for simple
pages, when the frame is loaded the page is not rendered in the screen.

This patch fixes this bug calling LayerTreeHostQt::scheduleLayerFlush when m_layerFlushSchedulingEnabled
is true.

Reviewed by Noam Rosenthal.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):

7:48 PM Changeset in webkit [102086] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Upstream htmlSelectMultipleItems needed for <select multiple> by iOS
https://bugs.webkit.org/show_bug.cgi?id=73734

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

  • platform/DefaultLocalizationStrategy.h:
6:55 PM Changeset in webkit [102085] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=73785

Reviewed by Andreas Kling.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
instead of add, since it wants to replace existing entries. Also removed leakPtr
and removed the FIXME that documented the memory leak now fixed here.
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
std:: prefix here and also unneeded explicit delete call.
(WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
call here.

  • loader/CrossOriginPreflightResultCache.h: Make mapped value of the

CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.

6:17 PM Changeset in webkit [102084] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.

Reviewed by Darin Adler.

  • wtf/HashMap.h:
6:07 PM Changeset in webkit [102083] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
https://bugs.webkit.org/show_bug.cgi?id=73878

Reviewed by Tony Chang.

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
r98785 made webkit.py always use m_data16, which does not work when
the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python
code, so I just reproduced the implementation there.

  • gdb/webkit.py:

(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(WTFStringPrinter.to_string):
(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(JSCUStringPrinter.to_string):

6:06 PM Changeset in webkit [102082] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871

Reviewed by Oliver Hunt.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty): Changed to be an 8 bit string.

6:04 PM Changeset in webkit [102081] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Some small improvements to ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=73786

Reviewed by Alexey Proskuryakov.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
peculiar behavior of this function. Somehow the post-attach suspend state is both
global and specific to a certain Page object. That can't be right. If it was truly
global then this would be a static member function. If it was truly per-page, then
the related functions could not be static.

  • dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes

function up with the other basic getters. Put the other getters, childNodeCount and
childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
mutation functions so they can be used in a cleaner fashion in C++ code where we have
some reason to know an exception won't occur. Grouped all the overrides of functions
from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.

  • dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.
  • dom/Node.cpp:

(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
(WebCore::Node::isDescendantOf): Ditto.

5:51 PM Changeset in webkit [102080] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Get rid of KURL::KURL(ParsedURLStringTag, const char*);
https://bugs.webkit.org/show_bug.cgi?id=73792

Reviewed by Andreas Kling.

In all cases where the constructor is used, the constructor
taking a String is as effective because the string is valid and converted
to String for m_string.

This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
and change the call sites that were using that constructor to build
empty URLs.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/KURLGoogle.cpp:
5:41 PM Changeset in webkit [102079] by timothy_horton@apple.com
  • 9 edits
    9 adds in trunk/LayoutTests

Unreviewed extremely minor SVG filter pixel rebaselines for Lion.

Mostly text antialiasing differences, all only noticeable at tolerances very near 0.

  • platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
  • platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
  • platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
  • platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
  • platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png.
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feLighting-crash-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/sourceAlpha-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
5:35 PM Changeset in webkit [102078] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/chromium

[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=73881

This patch adds a forwarding header to fix the downstream Windows build:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio

  • public/WebContentLayerClient.h: Added.
5:35 PM Changeset in webkit [102077] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

5:34 PM Changeset in webkit [102076] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.6

New tag.

5:30 PM Changeset in webkit [102075] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed feGaussianBlur rebaseline for Mac after r101638.

  • platform/mac/svg/filters/feGaussianBlur-expected.png:
5:29 PM Changeset in webkit [102074] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/chromium

Add a shim to fix the downstream Chromium compile. The real fix should
be made downstream via http://codereview.chromium.org/8801036/, but the
Chromium tree is closed at the moment.

  • public/WebRect.h: Added.
5:10 PM Changeset in webkit [102073] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove methods declared but never implemented with GOOGLEURL
https://bugs.webkit.org/show_bug.cgi?id=73795

Reviewed by Adam Barth.

  • platform/KURL.h:
5:08 PM Changeset in webkit [102072] by eric@webkit.org
  • 3 edits in trunk/Tools

Up the "expected ram for each DRT instance" to 400MB instead of 300MB
in hopes of making the Snow Leopard bot stop timing out.

Unreviewed.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

5:03 PM Changeset in webkit [102071] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Change CSSFontSelector to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73781

Reviewed by Dan Bernstein.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.

  • css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts

be HashMap<OwnPtr>.

4:43 PM Changeset in webkit [102070] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r95053.

4:40 PM Changeset in webkit [102069] by Lucas Forschler
  • 1 edit in branches/safari-534.53-branch/Source/WebCore/ChangeLog

Merged r95051.

4:37 PM Changeset in webkit [102068] by Lucas Forschler
  • 2 edits in branches/safari-534.53-branch/Source/WebCore

Merged r95048.

4:33 PM Changeset in webkit [102067] by adamk@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
https://bugs.webkit.org/show_bug.cgi?id=73867

Reviewed by Adam Barth.

Moved V8RecursionScope into its own file, and moved
V8Proxy::didLeaveScriptContext into that file, along with a static
recursionLevel accessor, hiding the V8BindingPerIsolateData methods
from V8Proxy.

This will make it easy and less error-prone to use V8RecursionScope
properly. I plan to make use of it in V8LazyEventListener to fix
https://bugs.webkit.org/show_bug.cgi?id=73492.

No new tests, refactoring only.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.

  • bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.

(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.

  • bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
  • bindings/v8/V8RecursionScope.cpp: Added.

(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.

  • bindings/v8/V8RecursionScope.h: Added.

(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):

4:32 PM Changeset in webkit [102066] by Lucas Forschler
  • 4 edits in branches/safari-534.53-branch/Source/WebCore

Merged r94980.

4:17 PM Changeset in webkit [102065] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780

Reviewed by Andreas Kling.

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.

  • API/JSClassRef.h: Made the static values and static functions tables

use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.

4:17 PM Changeset in webkit [102064] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-05
Reviewed by David Kilzer.

When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.

  • page/SecurityOrigin.cpp:

(WebCore::shouldUseInnerURL):

4:15 PM Changeset in webkit [102063] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Change RuleSet to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73783

Reviewed by Andreas Kling.

  • css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.

(WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
map or find the old entry in the map.

4:10 PM Changeset in webkit [102062] by mario@webkit.org
  • 10 edits in trunk/Source

[GTK] Move emissions of AtkDocument signals down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=73750

Reviewed by Chris Fleizach.

Source/WebCore:

Implement the needed infrastructure to allow notifying
accessibility, in a cross-platform way, when a event related to
the load of a document happens. Added a generic method, which will
be called from the FrameLoader, and platform specific versions of
it so every port has a chance to decide what to do with those
notifications.

This patch doesn't include a new test because the one testing this
functionality is the GTK-specific unit test added along with patch
for bug 73746: testWebkitAtkDocumentLoadingEvents.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::frameLoadingEventNotification): New, called
from the FrameLoader to notify accessibility when an event happens.
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
platform specific function to let ports decide what to do.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::frameLoadingEventNotification): New.

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for chromium.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for the Mac.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for Windows.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart): Notify accessibility
by calling the new frameLoadingEventNotification() function.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.

Source/WebKit/gtk:

Removed code for emission of AtkDocument signals.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::notifyStatus): Removed no longer used code.

4:06 PM Changeset in webkit [102061] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Land uncommitted bit of float array support
https://bugs.webkit.org/show_bug.cgi?id=73873

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

3:57 PM Changeset in webkit [102060] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r101949): css3/bdi-element.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73859

Reviewed by Dan Bernstein.

The failure was caused by span that contains the text inside bdi in the reference file
was using display: inline-block. Because the width of an inline-block is always rounded up
like any other inline element, it causes the text in the reference file to be one pixel
longer than the one in the test file in certain cases.

Fixed the bug by using unicode-bidi: override instead of display: inline-block in
the reference file.

  • css3/bdi-element-expected.html:
3:56 PM Changeset in webkit [102059] by benjamin@webkit.org
  • 6 edits in trunk/Source

Update String::containsOnlyASCII() to handle 8 bits strings
https://bugs.webkit.org/show_bug.cgi?id=73799

Reviewed by Darin Adler.

Source/JavaScriptCore:

Implement String::containsOnlyASCII() so that it does not
call String::characters().

  • wtf/text/WTFString.h:

(WTF::String::containsOnlyASCII):

Source/WebCore:

When possible, change the call sites from charactersAreAllASCII()
to the optimized version String::containsOnlyASCII().

  • platform/KURL.cpp:

(WebCore::KURL::init):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeStringObject):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCodepage::if):

3:54 PM Changeset in webkit [102058] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark this test as flaky.
See https://bugs.webkit.org/show_bug.cgi?id=73872

  • platform/chromium/test_expectations.txt:
3:50 PM Changeset in webkit [102057] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-DFG platforms.

  • dfg/DFGRepatch.h:
3:48 PM Changeset in webkit [102056] by eric@webkit.org
  • 8 edits in trunk/Tools

NRWT creates too many workers on RAM-limited machines
https://bugs.webkit.org/show_bug.cgi?id=73847

Reviewed by Dirk Pranke.

Make NRWT restrict its number of workers when there isn't enough
RAM to support them.
Also re-enable parallel testing on the Mac bots which were
failing due to not enough ram.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

  • Scripts/webkitpy/common/host.py:

(Host.init):

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.cpu_count):

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.display_name):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.display_name):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_os_error):

3:43 PM Changeset in webkit [102055] by vangelis@chromium.org
  • 12 edits in trunk/Source

Source/WebCore: [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
https://bugs.webkit.org/show_bug.cgi?id=73621

When the extensions are available, compositor textures are allocated via
glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
is specified for all textures used by RenderSurfaces to eliminate the need for
a system memory bitmap allocation.

Reviewed by Kenneth Russell.

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp:

(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::textureToStorageFormat):
(WebCore::isTextureFormatSupportedForStorage):
(WebCore::TrackingTextureAllocator::createTexture):

  • platform/graphics/chromium/TrackingTextureAllocator.h:

(WebCore::TrackingTextureAllocator::setTextureUsageHint):
(WebCore::TrackingTextureAllocator::setUseTextureStorageExt):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium: Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures.
https://bugs.webkit.org/show_bug.cgi?id=73621

Add the necessary entry points and enums to GraphicsContext3D.

Reviewed by Kenneth Russell.

  • public/platform/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::texStorage2DEXT):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DPrivate.h:
  • tests/MockWebGraphicsContext3D.h:

(WebKit::MockWebGraphicsContext3D::texStorage2DEXT):

3:39 PM Changeset in webkit [102054] by Lucas Forschler
  • 30 edits
    24 copies in branches/safari-534.53-branch

Merge 94912.

3:34 PM Changeset in webkit [102053] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WK2: AX hierarchy is not restored after web process crash
https://bugs.webkit.org/show_bug.cgi?id=73870

The accessibility tokens that need to be sent between UI and Web process
were not being sent by the UI process -> the web process when the web
process crashed.

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _accessibilityRegisterUIProcessTokens]):
(-[WKView _didRelaunchProcess]):

3:02 PM Changeset in webkit [102052] by jchaffraix@webkit.org
  • 6 edits
    3 adds
    4 deletes in trunk/LayoutTests

TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Unreviewed rebaselining on Chromium after r102040.

  • platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png: Removed.
  • platform/chromium-win/fast/table/027-expected.png:
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium/tables/mozilla/bugs/bug14929-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:58 PM TestExpectations edited by jchaffraix@webkit.org
rebaseline-chromium-webkit-tests is deprecated, replace it by … (diff)
2:44 PM Changeset in webkit [102051] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: aria-hidden doesn't work on iframe elements
https://bugs.webkit.org/show_bug.cgi?id=73857

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/iframe-aria-hidden.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addAttachmentChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::addChildren):

  • accessibility/AccessibilityScrollView.h:

LayoutTests:

  • platform/mac/accessibility/iframe-aria-hidden-expected.txt: Added.
  • platform/mac/accessibility/iframe-aria-hidden.html: Added.
2:43 PM Changeset in webkit [102050] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Another attempted build fix.

  • src/linux/WebFontInfo.cpp:
2:41 PM Changeset in webkit [102049] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: web search mechanism does not work with frames
https://bugs.webkit.org/show_bug.cgi?id=73836

Reviewed by Beth Dakin.

Source/WebCore:

This allows searching for, and within, frames for elements using the accessibility
search mechanism.

Test: platform/mac/accessibility/search-with-frames.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::appendAccessibilityObject):
(WebCore::appendChildrenToArray):

LayoutTests:

  • platform/mac/accessibility/search-with-frames-expected.txt: Added.
  • platform/mac/accessibility/search-with-frames.html: Added.
2:33 PM Changeset in webkit [102048] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Last mouse event could be lost if a JS call to eventSender.leapForward is made
https://bugs.webkit.org/show_bug.cgi?id=73366

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

LayoutTests:

Add test to check if the test driver doesn't eat mouse events when
a JS call to eventSender.leapForward was made. This bug happened at
least on Qt version of WebKitTestRunner.

  • fast/events/dont-loose-last-event-expected.txt: Added.
  • fast/events/dont-loose-last-event.html: Added.
2:27 PM Changeset in webkit [102047] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix Linux build.

  • public/linux/WebFontInfo.h:
2:16 PM Changeset in webkit [102046] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION: Full keyboard access doesn't work if enabled before Safari started
https://bugs.webkit.org/show_bug.cgi?id=73864

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Actually use the parameter passed at process creation.
2:13 PM Changeset in webkit [102045] by andersca@apple.com
  • 10 edits in trunk/Source

Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
https://bugs.webkit.org/show_bug.cgi?id=73862

Reviewed by Andy Estes.

Source/WebCore:

Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
successful and the run loop observer will be invalidated.

  • platform/graphics/ca/LayerFlushScheduler.h:
  • platform/graphics/ca/LayerFlushSchedulerClient.h:
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::runLoopObserverCallback):

Source/WebKit/mac:

Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
where we don't want the layer flush scheduler to be invalidated.

  • WebView/WebView.mm:

(LayerFlushController::flushLayers):

  • WebView/WebViewData.h:

Source/WebKit2:

Change LayerTreeHostCAMac::flushLayers to always return true and remove the call to LayerFlushScheduler::invalidate.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::flushLayers):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):

2:07 PM Changeset in webkit [102044] by abarth@webkit.org
  • 210 edits
    58 deletes in trunk

[Chromium] Remove no-longer-used forwarding headers in the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=73845

Reviewed by Darin Fisher.

Source/WebKit/chromium:

Delete unused forwarding headers and update includes to the new header
locations.

  • WebKit.gyp:
  • bridge/PeerConnectionHandlerInternal.cpp:
  • bridge/PeerConnectionHandlerInternal.h:
  • public/WebArrayBuffer.h:
  • public/WebArrayBufferView.h: Removed.
  • public/WebAudioBus.h: Removed.
  • public/WebAudioDevice.h: Removed.
  • public/WebBlobData.h: Removed.
  • public/WebBlobRegistry.h: Removed.
  • public/WebCString.h: Removed.
  • public/WebCanvas.h: Removed.
  • public/WebClipboard.h: Removed.
  • public/WebColor.h: Removed.
  • public/WebColorName.h: Removed.
  • public/WebCommon.h: Removed.
  • public/WebCompositorInputHandler.h:
  • public/WebCookie.h: Removed.
  • public/WebCookieJar.h: Removed.
  • public/WebData.h: Removed.
  • public/WebDragData.h: Removed.
  • public/WebFileSystem.h: Removed.
  • public/WebFloatPoint.h: Removed.
  • public/WebFloatQuad.h: Removed.
  • public/WebFloatRect.h: Removed.
  • public/WebGamepad.h: Removed.
  • public/WebGamepads.h: Removed.
  • public/WebGraphicsContext3D.h: Removed.
  • public/WebHTTPBody.h: Removed.
  • public/WebHTTPHeaderVisitor.h: Removed.
  • public/WebHTTPLoadInfo.h: Removed.
  • public/WebIDBCallbacks.h:
  • public/WebImage.h: Removed.
  • public/WebIntent.h:
  • public/WebIntentServiceInfo.h:
  • public/WebKitPlatformSupport.h: Removed.
  • public/WebLocalizedString.h: Removed.
  • public/WebMediaStreamDescriptor.h: Removed.
  • public/WebMimeRegistry.h: Removed.
  • public/WebNonCopyable.h: Removed.
  • public/WebPageOverlay.h:
  • public/WebPeerConnectionHandler.h: Removed.
  • public/WebPeerConnectionHandlerClient.h: Removed.
  • public/WebPoint.h: Removed.
  • public/WebPrivateOwnPtr.h: Removed.
  • public/WebPrivatePtr.h: Removed.
  • public/WebRect.h: Removed.
  • public/WebSerializedScriptValue.h: Removed.
  • public/WebSize.h: Removed.
  • public/WebSocketStreamError.h: Removed.
  • public/WebSocketStreamHandle.h: Removed.
  • public/WebSocketStreamHandleClient.h: Removed.
  • public/WebString.h: Removed.
  • public/WebThread.h: Removed.
  • public/WebThreadSafeData.h: Removed.
  • public/WebURL.h: Removed.
  • public/WebURLError.h: Removed.
  • public/WebURLLoadTiming.h: Removed.
  • public/WebURLLoader.h: Removed.
  • public/WebURLLoaderClient.h: Removed.
  • public/WebURLRequest.h: Removed.
  • public/WebURLResponse.h: Removed.
  • public/WebVector.h: Removed.
  • public/WebWorkerRunLoop.h:
  • public/android/WebThemeEngine.h: Removed.
  • public/linux/WebFontFamily.h: Removed.
  • public/linux/WebThemeEngine.h: Removed.
  • public/mac/WebThemeEngine.h: Removed.
  • public/win/WebThemeEngine.h: Removed.
  • src/ApplicationCacheHost.cpp:
  • src/ApplicationCacheHostInternal.h:
  • src/AssertMatchingEnums.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/AssociatedURLLoader.h:
  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileWriterChromium.cpp:
  • src/AudioDestinationChromium.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/BlobRegistryProxy.cpp:
  • src/CCThreadImpl.cpp:
  • src/ChromeClientImpl.cpp:
  • src/ChromiumCurrentTime.cpp:
  • src/ChromiumOSRandomSource.cpp:
  • src/ChromiumThreading.cpp:
  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/ContextMenuClientImpl.cpp:
  • src/DragClientImpl.cpp:
  • src/DragScrollTimer.h:
  • src/ExternalPopupMenu.cpp:
  • src/FrameLoaderClientImpl.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBCursorBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.cpp:
  • src/InspectorClientImpl.cpp:
  • src/InspectorFrontendClientImpl.cpp:
  • src/LocalFileSystemChromium.cpp:
  • src/LocalizedStrings.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/PlatformMessagePortChannel.cpp:
  • src/PlatformSupport.cpp:
  • src/ResourceHandle.cpp:
  • src/ResourceHandleInternal.h:
  • src/ScrollbarGroup.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/SocketStreamHandle.cpp:
  • src/SpeechInputClientImpl.cpp:
  • src/StorageAreaProxy.cpp:
  • src/StorageEventDispatcherChromium.cpp:
  • src/StorageNamespaceProxy.cpp:
  • src/WebAccessibilityObject.cpp:
  • src/WebAnimationControllerImpl.cpp:
  • src/WebArrayBufferView.cpp:
  • src/WebAttribute.cpp:
  • src/WebAudioBus.cpp:
  • src/WebBindings.cpp:
  • src/WebBlobData.cpp:
  • src/WebCString.cpp:
  • src/WebColor.cpp:
  • src/WebCommon.cpp:
  • src/WebCompositorImpl.cpp:
  • src/WebCompositorInputHandlerImpl.cpp:
  • src/WebContentLayerImpl.cpp:
  • src/WebDOMEventListenerPrivate.h:
  • src/WebDOMMessageEvent.cpp:
  • src/WebDOMStringList.cpp:
  • src/WebData.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDatabase.cpp:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDocument.cpp:
  • src/WebDocumentType.cpp:
  • src/WebDragData.cpp:
  • src/WebEntities.cpp:
  • src/WebExternalTextureLayerImpl.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFloatQuad.cpp:
  • src/WebFontImpl.cpp:
  • src/WebFormElement.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebGeolocationError.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
  • src/WebGraphicsContext3D.cpp:
  • src/WebHTTPBody.cpp:
  • src/WebHTTPLoadInfo.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp:
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp:
  • src/WebIDBKeyPath.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionImpl.h:
  • src/WebIconLoadingCompletionImpl.h:
  • src/WebImageCG.cpp:
  • src/WebImageDecoder.cpp:
  • src/WebImageSkia.cpp:
  • src/WebInputElement.cpp:
  • src/WebKit.cpp:
  • src/WebLabelElement.cpp:
  • src/WebLayer.cpp:
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
  • src/WebMediaPlayerClientImpl.cpp:
  • src/WebMediaStreamDescriptor.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebMediaStreamSource.cpp:
  • src/WebNode.cpp:
  • src/WebNotification.cpp:
  • src/WebOptionElement.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebPageSerializerImpl.h:
  • src/WebPluginContainerImpl.cpp:
  • src/WebPluginListBuilderImpl.cpp:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebRange.cpp:
  • src/WebRegularExpression.cpp:
  • src/WebScriptController.cpp:
  • src/WebScrollbarImpl.cpp:
  • src/WebSecurityOrigin.cpp:
  • src/WebSecurityPolicy.cpp:
  • src/WebSelectElement.cpp:
  • src/WebSerializedScriptValue.cpp:
  • src/WebSettingsImpl.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebSocketImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp:
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebStorageAreaImpl.cpp:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebStorageNamespaceImpl.cpp:
  • src/WebString.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/WebThreadSafeData.cpp:
  • src/WebURL.cpp:
  • src/WebURLError.cpp:
  • src/WebURLLoadTiming.cpp:
  • src/WebURLRequest.cpp:
  • src/WebURLResponse.cpp:
  • src/WebURLResponsePrivate.h:
  • src/WebUserMediaRequest.cpp:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WrappedResourceRequest.h:
  • src/WrappedResourceResponse.h:
  • src/mac/WebSubstringUtil.mm:
  • tests/AssociatedURLLoaderTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/FrameTestHelpers.cpp:
  • tests/MockWebGraphicsContext3D.h:
  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/WebLayerTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebURLRequestTest.cpp:
  • tests/WebUnitTests.h:
  • tests/WebViewTest.cpp:

Tools:

Update includes to point to the new header locations.

  • DumpRenderTree/chromium/AccessibilityController.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp:
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/GamepadController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/PlainTextController.cpp:
  • DumpRenderTree/chromium/Task.cpp:
  • DumpRenderTree/chromium/TestNavigationController.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestWebPlugin.cpp:
  • DumpRenderTree/chromium/TestWebPlugin.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
1:55 PM Changeset in webkit [102043] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens <danakj@chromium.org> on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/ImageLayerChromiumTest.cpp.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ImageLayerChromiumTest.cpp: Added.

(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::~TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

1:45 PM Changeset in webkit [102042] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
were compact offsets
https://bugs.webkit.org/show_bug.cgi?id=73861

Reviewed by Gavin Barraclough.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::resetPatchPutById):

1:44 PM Changeset in webkit [102041] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Aharon Lanin to the contributors list.

  • Scripts/webkitpy/common/config/committers.py:
1:38 PM Changeset in webkit [102040] by jchaffraix@webkit.org
  • 26 edits
    3 adds in trunk

TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/colspan-with-all-percent-cells.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
In the case where all our columns have percent lengths, split the colspan
logical width using the percentages from the lengths. This should be properly
handled by the massive 'else' case but it is not and I did not feel like refactor
that due to massive compatibility issues that would arise.

LayoutTests:

  • fast/table/colspan-with-all-percent-cells-expected.png: Added.
  • fast/table/colspan-with-all-percent-cells-expected.txt: Added.
  • fast/table/colspan-with-all-percent-cells.html: Added.
  • platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/fast/table/027-expected.png:
  • platform/chromium-linux/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/fast/table/027-vertical-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-win/fast/table/027-expected.txt:
  • platform/chromium-win/fast/table/027-vertical-expected.txt:
  • platform/mac/fast/table/027-expected.png:
  • platform/mac/fast/table/027-expected.txt:
  • platform/mac/fast/table/027-vertical-expected.png:
  • platform/mac/fast/table/027-vertical-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2947-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2947-expected.txt:

Those changes are just rebaselines which now matches Firefox Nighly
more closely (thus progressions).

  • platform/chromium/test_expectations.txt: Skipped Windows that needs a new baseline.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

Skipped the previous tests as they need a rebaseline on those platforms.

1:27 PM Changeset in webkit [102039] by alokp@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium/compositing/scaling: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
1:25 PM Changeset in webkit [102038] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, build fixes for ARM.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::unreachableForPlatform):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

1:23 PM Changeset in webkit [102037] by jarred@sencha.com
  • 2 edits in trunk/Tools

Moving myself from contributors to committers.

  • Scripts/webkitpy/common/config/committers.py:
1:22 PM Changeset in webkit [102036] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Add myself as a committer.

1:16 PM Changeset in webkit [102035] by commit-queue@webkit.org
  • 8 edits in trunk

[Qt] Rename QQuickWebView::canStop property to just loading
https://bugs.webkit.org/show_bug.cgi?id=73813

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed canStop property of QQuickWebView and QtWebPageProxy
to loading and updated tests.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::loading):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::loading):

  • UIProcess/qt/QtWebPageProxy.h:

Tools:

Replaced references to WebView.canStop with WebView.loading.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
1:13 PM Changeset in webkit [102034] by alokp@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Unreviewed chromium rebaseline.

  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium/test_expectations.txt:
1:07 PM Changeset in webkit [102033] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Merged r94901.

1:03 PM Changeset in webkit [102032] by Lucas Forschler
  • 11 edits
    5 copies in branches/safari-534.53-branch/Source/WebCore

Merged r94900.

12:59 PM Changeset in webkit [102031] by Chris Fleizach
  • 6 edits in trunk

platform/mac/accessibility/search-when-element-starts-in-table.html is failing
https://bugs.webkit.org/show_bug.cgi?id=73751

Source/WebCore:

When encountering a table, the rows() and not the cells() should be queried (otherwise
we can end up finding the element we started with).

When searching in reverse, we also need to account for searching elements within the
parent hierarchy. because technically it is "behind" the start element.

Reviewed by Darin Adler.

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit):
(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityObject.h:

LayoutTests:

Updated tests to be more comprehensive.

Reviewed by Darin Adler.

  • platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
  • platform/mac/accessibility/search-when-element-starts-in-table.html:
12:47 PM Changeset in webkit [102030] by dpranke@chromium.org
  • 2 edits in trunk/Tools

run-webkit-tests: limit --child-processes properly on apple mac
https://bugs.webkit.org/show_bug.cgi?id=73856

Reviewed by Adam Roben.

Fix typos in r102013 so that we correctly pass --child-processes=1 on
the apple mac bots temporarily.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

12:37 PM Changeset in webkit [102029] by Lucas Forschler
  • 14 edits in branches/safari-534.53-branch

Merge 94597.

12:27 PM Changeset in webkit [102028] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update String::containsOnlyLatin1() to avoid converting to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=73797

Reviewed by Andreas Kling.

When the String use 8bits StringImpl, there is no need to iterate
over the string.

The function charactersAreAllLatin1() is removed because it is not
used anywhere.

  • wtf/text/WTFString.h:

(WTF::String::containsOnlyLatin1):

12:18 PM WebKit Team edited by tomz@codeaurora.org
(diff)
12:08 PM Changeset in webkit [102027] by Lucas Forschler
  • 5 edits in branches/safari-534.53-branch/Source

Versioning.

12:07 PM Changeset in webkit [102026] by Lucas Forschler
  • 3 edits in branches/safari-534.53-branch/Source/WebCore

Fixes to the branch made by Simon to get us building again.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
(WebCore::CSSStyleSelector::loadPendingImages):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

12:03 PM Changeset in webkit [102025] by alokp@chromium.org
  • 49 edits
    71 adds
    30 deletes in trunk/LayoutTests

Rebaseline tests after the patch for BUGWK73247
https://bugs.webkit.org/show_bug.cgi?id=73848

Unreviewed chromium rebaseline.

  • platform/chromium-cg-mac-leopard/compositing/color-matching: Added.
  • platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/iframes: Added.
  • platform/chromium-cg-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac-leopard/compositing/scaling: Removed.
  • platform/chromium-cg-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/compositing/shadows: Added.
  • platform/chromium-cg-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-cg-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/iframes: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/scaling: Removed.
  • platform/chromium-cg-mac-snowleopard/compositing/shadows: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-layer-crash-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-cg-mac/compositing/color-matching: Removed.
  • platform/chromium-cg-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/direct-image-compositing-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
  • platform/chromium-cg-mac/compositing/shadows: Removed.
  • platform/chromium-cg-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-cg-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-cg-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Added.
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-mac-leopard/compositing/color-matching: Added.
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/iframes: Added.
  • platform/chromium-mac-leopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/shadows: Added.
  • platform/chromium-mac-leopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/color-matching: Added.
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/iframes: Added.
  • platform/chromium-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/shadows: Added.
  • platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png: Removed.
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
  • platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Removed.
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/shadows: Removed.
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-mac/compositing/visibility: Removed.
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png: Added.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Replaced.
  • platform/chromium/test_expectations.txt:
11:47 AM Changeset in webkit [102024] by jer.noble@apple.com
  • 5 edits in trunk/Source

<video> elements should disable the system and display sleep when playing on OS X.
https://bugs.webkit.org/show_bug.cgi?id=73730
<rdar://problem/9502155>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests; platform specific system behavior only.

Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
that object when the playback rate drops back to zero.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

  • html/HTMLMediaElement.h:

Source/WebKit2:

Allow the WebProcess to make connections to the PowerManagement control mach server.

  • WebProcess/com.apple.WebProcess.sb:
11:33 AM Changeset in webkit [102023] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline of test added in r101537 for Lion.

  • platform/mac/svg/text/non-bmp-positioning-lists-expected.png:
  • platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:
11:22 AM Changeset in webkit [102022] by Lucas Forschler
  • 1 copy in tags/Safari-534.53.5

New Tag.

11:22 AM Changeset in webkit [102021] by Lucas Forschler
  • 1 delete in tags/Safari-535.53.5

Remove incorrect tag.

11:17 AM Changeset in webkit [102020] by Lucas Forschler
  • 1 copy in tags/Safari-535.53.5

New Tag.

11:12 AM Changeset in webkit [102019] by jamesr@google.com
  • 5 edits
    7 deletes in trunk/Source/WebKit/chromium

[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

  • WebKit.gyp:
  • public/WebContentLayer.h: Removed.
  • public/WebContentLayerClient.h: Removed.
  • public/WebExternalTextureLayer.h: Removed.
  • public/WebLayer.h: Removed.
  • public/WebLayerClient.h: Removed.
  • public/WebLayerTreeView.h: Removed.
  • public/WebLayerTreeViewClient.h: Removed.
  • src/WebLayerTreeView.cpp:
  • src/WebLayerTreeViewImpl.cpp:
  • tests/WebLayerTest.cpp:
11:10 AM Changeset in webkit [102018] by peter@chromium.org
  • 3 edits
    2 adds in trunk/Source/WebCore

[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
https://bugs.webkit.org/show_bug.cgi?id=73672

Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
of an older file from the Android port:
http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704

Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
file upload boxes, which is not something we want to support now. Also
include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
as their functionality can be re-used for Android.

Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/KeyCodeConversionAndroid.cpp: Added.

(WebCore::windowsKeyCodeForKeyEvent):

  • platform/graphics/chromium/IconChromiumAndroid.cpp: Added.

(WebCore::Icon::Icon):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):

11:08 AM Changeset in webkit [102017] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

8 bit string work slows down Kraken json-stringify-tinderbox
https://bugs.webkit.org/show_bug.cgi?id=73457

Added 8 bit path to StringBuilder. StringBuilder starts
assuming 8 bit contents and gets converted to 16 bit upon
seeing the first 16 bit character or string. Split
appendUninitialiezed into an inlined fast and function call
slow case.

Factored out the processing of the UString argument from
Stringifier::appendQuotedString() to a static templated function
based on character size.

This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
This change introduces a 4.8% slowdown to json-parse-financial.
This slowdown will be addressed in a subsequent patch to StringImpl::equal.

Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::appendStringToUStringBuilder):
(JSC::Stringifier::appendQuotedString):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::LChar):
(WTF::UChar):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters8):
(WTF::StringBuilder::characters16):
(WTF::StringBuilder::charactersBlah):
(WTF::LChar):
(WTF::UChar):

10:46 AM Changeset in webkit [102016] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-12-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Sam Weinig.

On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
https://bugs.webkit.org/show_bug.cgi?id=73841
<rdar://problem/10521879>

No test since repro case involves dropping a file onto the WebView.


Calling characters() explicitly causes a non-terminated string buffer to get passed back
to the String() constructor that expects a terminated buffer. The characters() call isn't
necessary at all, since we have a String and the method we're calling expects a String.

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
10:45 AM Changeset in webkit [102015] by mihnea@adobe.com
  • 4 edits
    6 adds
    6 deletes in trunk/LayoutTests

[regions] Need to verify the correctness of Win/Linux on overflow break tests
https://bugs.webkit.org/show_bug.cgi?id=73332

Reviewed by Tony Chang.

Using a monospace font (instead of Times) provides closer rendering results on several platforms
when used with text-align:justify.

  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • fast/regions/region-overflow-break.html:
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
10:41 AM Changeset in webkit [102014] by weinig@apple.com
  • 11 edits
    5 adds in trunk/Source/WebKit2

Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
https://bugs.webkit.org/show_bug.cgi?id=73779

Reviewed by Anders Carlsson.

To allow for API objects representing the connection going to/from the UIProcess/WebProcess,
this patch separates out the connections into WebConnection subclasses. It does not yet
expose a way to access these connections, and is therefore not yet testable.

  • GNUmakefile.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • Platform/CoreIPC/MessageID.h:
  • Shared/CoreIPCSupport/WebConnectionMessageKinds.h: Added.

Add a new message type for communicating between WebConnections.

  • Shared/ChildProcess.h:

Make helper public so that WebConnectionToWebProcess can use it.

  • UIProcess/WebConnectionToWebProcess.cpp: Added.

(WebKit::WebConnectionToWebProcess::create):
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
(WebKit::WebConnectionToWebProcess::invalidate):
(WebKit::WebConnectionToWebProcess::postMessage):
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
(WebKit::WebConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToWebProcess::didClose):
(WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToWebProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToWebProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):

  • UIProcess/WebConnectionToWebProcess.h: Added.

(WebKit::WebConnectionToWebProcess::connection):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendMessage):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::connection):
(WebKit::WebProcessProxy::webConnection):
(WebKit::WebProcessProxy::sendSync):
Thread connection code through WebConnectionToWebProcess.

  • WebProcess/WebConnectionToUIProcess.cpp: Added.

(WebKit::WebConnectionToUIProcess::create):
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
(WebKit::WebConnectionToUIProcess::invalidate):
(WebKit::WebConnectionToUIProcess::postMessage):
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
(WebKit::WebConnectionToUIProcess::didReceiveSyncMessage):
(WebKit::WebConnectionToUIProcess::didClose):
(WebKit::WebConnectionToUIProcess::didReceiveInvalidMessage):
(WebKit::WebConnectionToUIProcess::syncMessageSendTimedOut):
(WebKit::WebConnectionToUIProcess::windowsToReceiveSentMessagesWhileWaitingForSyncReply):
(WebKit::WebConnectionToUIProcess::willProcessMessageOnClientRunLoop):

  • WebProcess/WebConnectionToUIProcess.h: Added.

(WebKit::WebConnectionToUIProcess::connection):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initialize):
(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::removeWebFrame):
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
(WebKit::WebProcess::getWebCoreStatistics):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::connection):
Thread connection code through WebConnectionToUIProcess.

10:40 AM Changeset in webkit [102013] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Temporarily set --child-process=1 on Mac because 20+ tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=73840

Reviewed by Simon Fraser.

Temporarily go back to single process mode on Mac.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

10:40 AM Changeset in webkit [102012] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
they have been combined into inspector.js.

The InspectorBackend.js file split out of the generated InspectorBackendStub.js
in r101670, and both files are needed to be useful.

https://webkit.org/b/73839

Reviewed by Joseph Pecoraro and Brian Weinstein.

  • WebCore.xcodeproj/project.pbxproj: Pass -not -name "InspectorBackend*.js" to find

instead of -not -name InspectorBackendStub.js.

10:25 AM Changeset in webkit [102011] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=73624
JIT + INTERPRETER builds are broken

Reviewed by Geoff Garen, Sam Weinig.

These don't fallback to the interpreter correctly.
Thunk creation assumes that is the JIT is compiled in, then it is enabled.

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

10:13 AM Changeset in webkit [102010] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations

  • platform/chromium/test_expectations.txt:
9:59 AM Changeset in webkit [102009] by scheib@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Rebaselining aria-checkbox-sends-notification-expected

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
9:47 AM Changeset in webkit [102008] by scheib@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

  • platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke: Added.
  • platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:42 AM Changeset in webkit [102007] by scheib@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] Expected flakey tests after fix for 65796 is committed
https://bugs.webkit.org/show_bug.cgi?id=73587

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-05

  • platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt: Removed redundant flakey
9:29 AM Changeset in webkit [102006] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Heap profiler should designate weak references.
https://bugs.webkit.org/show_bug.cgi?id=69948

Weak references are now ignored when tracing paths to GC roots.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdge.prototype.get isWeak):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):

9:07 AM Changeset in webkit [102005] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r102004.
http://trac.webkit.org/changeset/102004
https://bugs.webkit.org/show_bug.cgi?id=73835

Breaks qt minimal release compilation (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

  • inspector/CodeGeneratorInspector.py:

(Capitalizer.upper_camel_case_to_lower):
(RawTypes.get):
(RawTypes.String.get_c_param_type):
(RawTypes.Object.get_c_param_type):
(RawTypes.Object):
(ParamType):
(TypeData.init):
(TypeData.get_raw_type):
(TypeMap.init):
(InspectorFrontend_h):
(InspectorArray):
(InspectorObject):
(String):
(InspectorBackendDispatcher_h):
(Generator.process_command):

  • inspector/InspectorValues.h:
8:56 AM Changeset in webkit [102004] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-05
Reviewed by Yury Semikhatsky.

Extends python generator functionality.
Makes constructor in InspectorObject public.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InspectorValues.h:
8:24 AM Changeset in webkit [102003] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=73831

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMappingPayload):

8:17 AM Changeset in webkit [102002] by Laszlo Gombos
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove viewModeChanged() from QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=73828

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview_p.h: viewModeChanged is not used

and we should not expose it.

7:53 AM Changeset in webkit [102001] by commit-queue@webkit.org
  • 2 edits in trunk

[Qt] Add Source/qtwebkitversion.h to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=73823

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Tor Arne Vestbø.

  • .gitignore:
7:52 AM Changeset in webkit [102000] by Adam Roben
  • 2 edits in trunk/Tools

Redeploy apple-macpro-7 and apple-xserve-1

These slaves have been sitting idle since we removed our Leopard builders in r97496.

Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
sitting idle

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and

apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
(WebKit2 Tests)".

7:38 AM Changeset in webkit [101999] by eric.carlson@apple.com
  • 15 edits
    4 adds in trunk

Out-of-band text tracks may only load from same origin as the media element's Document's origin
https://bugs.webkit.org/show_bug.cgi?id=73184

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/text-track-crossorigin.html

  • html/HTMLTrackElement.cpp:

(WebCore::urlForLogging): Debug-only function for logging urls.
(WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to

the Track.

(WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the

requirements for <track> are different from <video>.

(WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin'

attribute value.

  • html/HTMLTrackElement.h:
  • html/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
(WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know

if the loader refuses the url immediately.

(WebCore::LoadableTextTrack::cueLoadingStarted): The <track> deals with readyState.
(WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes

an enum, not a bool.

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
(WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
(WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we

can make the correct checks.

  • loader/TextTrackLoader.h:

LayoutTests:

  • http/tests/security/resources/captions-with-access-control-headers.php: Added
  • http/tests/security/resources/captions.vtt: Added.
  • http/tests/security/text-track-crossorigin-expected.txt: Added.
  • http/tests/security/text-track-crossorigin.html: Added.
  • media/track/track-add-track-expected.txt: Updated results.
  • media/track/track-add-track.html: readyState changes as soon as the track url is set.
  • platform/efl/Skipped: Skip new test.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
7:30 AM Changeset in webkit [101998] by rolandsteiner@chromium.org
  • 9 edits in trunk

"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Source/WebCore:

Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.

Reviewed by Antti Koivisto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):

LayoutTests:

Add tests cases for "raw" shadow pseudo-element selectors with various combinators.
Also add cases with explicit universal '*' selector.

Reviewed by Antti Koivisto.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/unknown-pseudo-element-matching-expected.txt:
  • fast/css/unknown-pseudo-element-matching.html:
7:21 AM Changeset in webkit [101997] by vsevik@chromium.org
  • 1 edit
    2 copies
    2 moves
    3 adds
    4 deletes in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
  • platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
  • platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
  • platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
6:47 AM Changeset in webkit [101996] by kenneth@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make the UI of the MiniBrowser slightly nicer

Rubberstamped by Simon Hausmann.

  • Add proper padding
  • Show feedback when pressing on the toolbar icons
  • Make the text entry better looking
  • MiniBrowser/qt/qml/BrowserWindow.qml:
6:46 AM Changeset in webkit [101995] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::inDocument):

6:32 AM Changeset in webkit [101994] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium tests expectations update.

  • platform/chromium/test_expectations.txt:
6:16 AM Changeset in webkit [101993] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, fixed chromium DEPS syntax.

  • DEPS:
5:50 AM Changeset in webkit [101992] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
5:44 AM Changeset in webkit [101991] by vsevik@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.
5:35 AM Changeset in webkit [101990] by vsevik@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed chrmoium tests rebaseline.

  • platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
4:24 AM Changeset in webkit [101989] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium tests expectations update.

  • platform/chromium/test_expectations.txt:
3:54 AM Changeset in webkit [101988] by vsevik@chromium.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.
3:48 AM Changeset in webkit [101987] by rolandsteiner@chromium.org
  • 13 edits
    2 adds in trunk

<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/basic-attribute.html

  • html/HTMLAttributeNames.in:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):

  • html/HTMLStyleElement.h:
  • html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.
Disable test directory, since STYLE_SCOPED is not enabled by default.

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/basic-attribute-expected.txt: Added.
  • fast/css/style-scoped/basic-attribute.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
3:38 AM Changeset in webkit [101986] by vsevik@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed chromium tests rebaseline.

  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
3:26 AM Changeset in webkit [101985] by tkent@chromium.org
  • 1 edit
    1 add
    13 deletes in trunk/LayoutTests

Convert input-appearance-spinbutton-visibility.html to a reftest
https://bugs.webkit.org/show_bug.cgi?id=73807

Reviewed by Hajime Morita.

  • fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
  • platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
3:20 AM Changeset in webkit [101984] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
3:15 AM Changeset in webkit [101983] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::inDocument):

2:00 AM Changeset in webkit [101982] by Csaba Osztrogonác
  • 1 edit
    9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific results.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-12-05

  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: Added.
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
1:50 AM Changeset in webkit [101981] by vsevik@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
1:41 AM Changeset in webkit [101980] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-05
Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerSH4.h: Support for SH4.

(JSC::MacroAssemblerSH4::readCallTarget):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::readCallTarget):

1:28 AM Changeset in webkit [101979] by kkristof@inf.u-szeged.hu
  • 6 edits in trunk/Tools

NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

12:47 AM Changeset in webkit [101978] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-05
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request

Test: editing/spelling/spellcheck-queue.html

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):

A structure to have spell check request.

(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):

When timer is fired, queued request is processed if any.

(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):

When the spellchecker is processing another request, the latest request is queued.

(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):

Enqueues a request. If there is an older request whose root editable element is the same as the request,
it will be replaced.

(WebCore::SpellChecker::didCheck):

  • editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

  • editing/spelling/spellcheck-queue-expected.txt: Added.
  • editing/spelling/spellcheck-queue.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
12:42 AM Changeset in webkit [101977] by eric.carlson@apple.com
  • 22 edits in trunk/Source

Source/WebCore: WebCore part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

No new tests yet, still nothing to test.

  • page/Settings.cpp:

(WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they

aren't inlined.

(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.

  • page/Settings.h:

Source/WebKit/chromium: WebKit/chromium part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::shouldDisplaySubtitles): Added.
(WebKit::WebSettingsImpl::shouldDisplayCaptions): Ditto.
(WebKit::WebSettingsImpl::shouldDisplayTextDescriptions): Ditto.

  • src/WebSettingsImpl.h:

Source/WebKit/mac: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,

and shouldDisplayTextDescriptions properties.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Initialize new preferences to NO.
(-[WebPreferences setShouldDisplaySubtitles:]): Added.
(-[WebPreferences shouldDisplaySubtitles]): Ditto.
(-[WebPreferences setShouldDisplayCaptions:]): Ditto.
(-[WebPreferences shouldDisplayCaptions]): Ditto.
(-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
(-[WebPreferences shouldDisplayTextDescriptions]): Ditto.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.

Source/WebKit/win: WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.
  • WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,

and shouldDisplayTextDescriptions properties.

  • WebPreferences.cpp:

(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.

  • WebPreferences.h: Declare new methods.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h: Declared shouldDisplaySubtitles, shouldDisplayCaptions, and

shouldDisplayTextDescriptions properties with macros. All default to false.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShouldDisplaySubtitles): Added.
(WKPreferencesGetShouldDisplaySubtitles): Ditto.
(WKPreferencesSetShouldDisplayCaptions): Ditto.
(WKPreferencesGetShouldDisplayCaptions): Ditto.
(WKPreferencesSetShouldDisplayTextDescriptions): Ditto.
(WKPreferencesGetShouldDisplayTextDescriptions): Ditto.

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Updates WebCore settings from WebKit2 prefs.

12:19 AM Changeset in webkit [101976] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

  • platform/qt/Skipped: Skip the failing test.

Dec 4, 2011:

11:58 PM Changeset in webkit [101975] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

ImageDecoder setSize() should check for backing store allocation failure
https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

11:42 PM Changeset in webkit [101974] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Add binary support in WebSocket test server's echo handler.
https://bugs.webkit.org/show_bug.cgi?id=73649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-04
Reviewed by Eric Seidel.

  • http/tests/websocket/tests/hybi/echo_wsh.py: Support binary frames.
10:52 PM Changeset in webkit [101973] by eric@webkit.org
  • 2 edits in trunk/Tools

After success with Mac, Win and Gtk, turning on parallel testing
by default for all platforms (except Qt).

We'll add more platforms to the blacklist if we see problems.

Unreviewed.

  • Scripts/run-webkit-tests:

(platformIsReadyForParallelTesting):

9:44 PM Changeset in webkit [101972] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

CSSStyleSheet can't be reparented, enforce this at compile time.
<http://webkit.org/b/73793>

Reviewed by Benjamin Poulain.

  • css/StyleSheet.h:

(WebCore::StyleSheet::clearOwnerRule):

Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
enforce the fact that style sheets should never be reparented after creation.

(WebCore::StyleSheet::ownerRule):

Renamed parentRule() to ownerRule() to match the CSSOM name.

(WebCore::StyleSheet::ownerNode):
(WebCore::StyleSheet::clearOwnerNode):

Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.

  • css/CSSStyleSheet.h:

Removed ownerRule() as we now inherit it from StyleSheet.

  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):

Update call sites to use the new names.

9:24 PM Changeset in webkit [101971] by tkent@chromium.org
  • 24 edits
    5 moves
    12 adds
    8 deletes in trunk/LayoutTests

[Chromium] Rebaseline of placeholder tests for r101742 and r101848.

  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-position-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/search-styled-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
6:29 PM Changeset in webkit [101970] by kling@webkit.org
  • 4 edits
    2 adds in trunk

border-width: initial and border-color: initial cannot be removed via CSSOM.
<http://webkit.org/b/68551>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/cssom-remove-shorthand-property.html

When asked to remove a shorthand property, we should toss out both the
sub-properties of that shorthand as well as the shorthand itself, should the
declaration contain it. The latter part was missing in our implementation.

  • css/CSSMutableStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):

Changed to return true only if something was actually removed.

LayoutTests:

Add a test verifying that shorthand properties can be added/removed
via CSSOM'S CSSStyleDeclaration interface.

  • fast/css/cssom-remove-shorthand-property-expected.txt: Added.
  • fast/css/cssom-remove-shorthand-property.html: Added.
3:09 PM Changeset in webkit [101969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-04

  • DEPS:
2:10 PM Changeset in webkit [101968] by Darin Adler
  • 1 edit
    12 deletes in trunk/LayoutTests

Removed obsolete expected results that should have been removed when converting to a ref test.

  • platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/efl/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
  • platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
1:52 PM Changeset in webkit [101967] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild without children
https://bugs.webkit.org/show_bug.cgi?id=73737

Reviewed by Darin Adler.

It turned out that 50-70% of nodes inserted by DOM APIs such as insertBefore and appendChild
don't have any descendent nodes. Optimize isDescendantOf which is used by checkAcceptChild for this case.
On a test case attached on the bug, we see a 40% improvement.

Also optimize for cases where either new child or new parent but not both are in document as suggested
by Erik Arvidsson. This appears to happen about 40-70% of the time, and the symmetric difference between
the two cases is about 50% so it's worth implementing both optimizations.

Unfortunately no tests because we still have a O(n) algorithm somewhere.

  • dom/Node.cpp:

(WebCore::Node::isDescendantOf):
(WebCore::Node::contains):

1:50 PM Changeset in webkit [101966] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

Oops, landed the wrong versions of these yesterday. These are the right ones.

1:25 PM Changeset in webkit [101965] by weinig@apple.com
  • 3 edits
    3 adds in trunk/Tools

Add tests for RetainPtr::adoptNS/adoptCF
https://bugs.webkit.org/show_bug.cgi?id=73470

Reviewed by Adam Roben and Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptCF creates a RetainPtr with a
value whose retain count is 1.

  • TestWebKitAPI/Tests/WTF/ns: Added.
  • TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.

(TestWebKitAPI::TEST):
Test that adopting using adoptNS creates a RetainPtr with a
value whose retain count is 1.

1:16 PM Changeset in webkit [101964] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should optimize strict equality
https://bugs.webkit.org/show_bug.cgi?id=73764

Reviewed by Oliver Hunt.

1% speed-up on V8.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

12:42 PM Changeset in webkit [101963] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] cleanup qmltests.pro
https://bugs.webkit.org/show_bug.cgi?id=73718

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-12-04
Reviewed by Simon Hausmann.

Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:
11:09 AM Changeset in webkit [101962] by Philippe Normand
  • 5 edits in trunk/Source/WebKit2

[WK2][GTK] enable-fullscreen WebSettings
https://bugs.webkit.org/show_bug.cgi?id=73774

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_fullscreen):
(webkit_settings_get_enable_fullscreen):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

10:46 AM Changeset in webkit [101961] by Martin Robinson
  • 2 edits in trunk/Tools

[GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=73748

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
8:58 AM Changeset in webkit [101960] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Check for the load-complete event only in the unit tests.

There is currently a known issue happening in debug builds when
reloading the webview if it was loaded before through the function
webkit_web_view_load_string, resulting in a ASSERT failing (see
bug 50331) so we can't check for the reload event here, since it
makes the test to fail. Fortunately, checking for load-complete
event is a good enough test, so this small patch is about that.

Rubber-stamped by Philippe Normand.

  • tests/testatk.c:

(testWebkitAtkDocumentLoadingEvents): Don't load and then reload
to check events, just load once and check whether the
'load-complete' event has happened.

8:31 AM Changeset in webkit [101959] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSValuePool: Inline trivial getters.
<http://webkit.org/b/73763>

Reviewed by Anders Carlsson.

  • css/CSSValuePool.cpp:
  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createInheritedValue): Inlined.
(WebCore::CSSValuePool::createImplicitInitialValue): Ditto.
(WebCore::CSSValuePool::createExplicitInitialValue): Ditto.

7:48 AM Changeset in webkit [101958] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip two more tests.

  • platform/gtk/Skipped: Skip

platform/gtk/fonts/custom-font-missing-glyphs.html failing on
64-bit Debug.

  • platform/gtk/test_expectations.txt:

fast/table/multiple-captions-display.xhtml is flaky.

7:32 AM Changeset in webkit [101957] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, moving flaky ref test to Skipped list.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
5:59 AM Changeset in webkit [101956] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip two flaky tests and one SVG test timing out on GTK.

  • platform/gtk/test_expectations.txt: Skip two fast/ tests.
  • platform/gtk/Skipped: Skip svg/text/text-style-recalc-crash.html
5:10 AM Changeset in webkit [101955] by Philippe Normand
  • 2 edits in trunk/Tools

Another GTK build fix after r101922.

Rubber-stamped by Martin Robinson.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::pathToLocalResource): Plug possible String ref leak.

4:42 AM Changeset in webkit [101954] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-12-04 Xan Lopez <xlopez@igalia.com>

Fix compiler warning in LayoutTestController

Reviewed by Philippe Normand.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): fix warning.
3:56 AM Changeset in webkit [101953] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Add missing methods used by fast/notifications tests to LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63616

Patch by Alexandre Mazari <scaroo@gmail.com> on 2011-12-04
Reviewed by Martin Robinson.

Add missing simulateDesktopNotificationClick method used by
fast/notifications. Provide a default implementation for
areDesktopNotificationPermissionRequestsIgnored and
ignoreDesktopNotificationPermissionRequests.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): call into the port implementation.
(simulateDesktopNotificationClickCallback): ditto.
(ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
(LayoutTestController::staticFunctions): declare new methods.
(LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::simulateDesktopNotificationClick): dummy implementation.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::simulateDesktopNotificationClick): ditto.

3:32 AM Changeset in webkit [101952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix broken UTF-8 characters issue on editor command.
https://bugs.webkit.org/show_bug.cgi?id=73516

Patch by Kangil Han <kangil.han@samsung.com> on 2011-12-04
Reviewed by Ryosuke Niwa.

The issue has been described that Korean character is broken on pasting copied text.
In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
Therefore, this patch will convert types to resolve the problem.

  • ewk/ewk_view.cpp:

(_ewk_view_editor_command):

1:39 AM Changeset in webkit [101951] by mario@webkit.org
  • 8 edits
    2 deletes in trunk

Source/WebKit/gtk: Removing document related events from DRT

[GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

New unit test to check events when reloading a document. This
replaces the former document-reload-events.html layout test.

  • tests/testatk.c:

(updateLoadingEventsResult): New, updates a global variable to
allow checking later on that the right signals were emmitted.
(documentLoadingEventCallback): New, global listener for load-complete
and reload signals over the document object (the web area).
(testWebkitAtkDocumentLoadingEvents): New unit test, globally
connects to document-related signals and check they are properly
emitted when reloading the web view.
(main): Added new test.

Tools: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Stop connecting globally to document-related events.

  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp:

(connectAccessibilityCallbacks): Removed connections.
(disconnectAccessibilityCallbacks): Removed disconnections.

LayoutTests: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Unskip passing test, remove other transformed into a unit test and
rebaseline expectations now we stopped logging document events.

  • platform/gtk/Skipped: Removed two skipped tests.
  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Rebaselined
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Ditto.
  • platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
  • platform/gtk/accessibility/document-reload-events.html: Removed.
12:55 AM Changeset in webkit [101950] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Add failing expectation to css3/unicode-bidi-isolate-aharon-failing.html as it was split from
css3/unicode-bidi-isolate-aharon.html in r101949.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
12:28 AM Changeset in webkit [101949] by rniwa@webkit.org
  • 3 edits
    3 copies
    2 adds
    32 deletes in trunk/LayoutTests

Convert isolate and plaintext tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73680

Reviewed by Darin Adler.

Convert bdi-element-expected.html, unicode-bidi-isolate-aharon.html, and unicode-bidi-plaintext.html to reftests.
In addition, isolate the failing test case in unicode-bidi-plaintext.html as unicode-bidi-isolate-aharon-failing.html.

  • css3/bdi-element-expected.html: Copied from LayoutTests/css3/bdi-element.html.
  • css3/unicode-bidi-isolate-aharon-expected.html: Copied from LayoutTests/css3/unicode-bidi-isolate-aharon.html.
  • css3/unicode-bidi-isolate-aharon-failing-expected.html: Added.
  • css3/unicode-bidi-isolate-aharon-failing.html: Added.
  • css3/unicode-bidi-isolate-aharon.html:
  • fast/text/international/unicode-bidi-plaintext.html:
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-cg-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/css3/bdi-element-expected.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-mac/css3/bdi-element-expected.png: Removed.
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.png: Removed.
  • platform/chromium-win/css3/bdi-element-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/chromium/css3/bdi-element-expected.txt: Removed.
  • platform/efl/css3/bdi-element-expected.png: Removed.
  • platform/efl/css3/bdi-element-expected.txt: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/efl/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/gtk/css3/bdi-element-expected.png: Removed.
  • platform/gtk/css3/bdi-element-expected.txt: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/mac/css3/bdi-element-expected.png: Removed.
  • platform/mac/css3/bdi-element-expected.txt: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
  • platform/qt/css3/bdi-element-expected.png: Removed.
  • platform/qt/css3/bdi-element-expected.txt: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.