Timeline



Dec 31, 2011:

9:54 PM Changeset in webkit [103873] by kling@webkit.org
  • 16 edits
    2 adds in trunk

Make HTMLCollections play nice after their base node is gone.
<​http://webkit.org/b/75410>

Reviewed by Anders Carlsson.

Source/WebCore:

Added HTMLCollection::detachFromNode() and call that from destructors of nodes
with cached collections.

Sprinkled checks/assertions where applicable to make sure HTMLCollections are
empty after their associated node has been destroyed.

This is a slight change in behavior, as collections would previously keep
their nodes alive indefinitely. Added a test to document this.

Test: fast/dom/htmlcollection-zombies.html

  • dom/Document.cpp:

(WebCore::Document::~Document):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::detachFromNode):
(WebCore::HTMLCollection::resetCollectionInfo):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::~HTMLSelectElement):

  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::~HTMLTableElement):

  • html/HTMLTableElement.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::itemAfter):

LayoutTests:

  • fast/dom/htmlcollection-zombies-expected.txt: Added.
  • fast/dom/htmlcollection-zombies.html: Added.
8:34 PM Changeset in webkit [103872] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

HTMLCollection: Remove the constructor's custom CollectionCache* argument.
<​http://webkit.org/b/75414>

Reviewed by Anders Carlsson.

We no longer need to initialize HTMLCollections with a custom CollectionCache,
so remove the argument from the constructor.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLCollection.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):

6:19 PM Changeset in webkit [103871] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Continue trying to fix the ASSERT-enabled Windows build after r103858.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):

6:07 PM Changeset in webkit [103870] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Continue trying to fix the Windows build after r103823.

5:59 PM Changeset in webkit [103869] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Start trying to fix the Windows build after r103858.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::drawPDFPage):

5:23 PM Changeset in webkit [103868] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Start trying to fix the Windows build after r103823.

5:04 PM Changeset in webkit [103867] by mitz@apple.com
  • 5 edits
    1 copy
    1 add in trunk

Source/WebCore: WebCore changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
​https://bugs.webkit.org/show_bug.cgi?id=75405

Reviewed by Anders Carlsson.

Test: fast/events/frame-scroll-fake-mouse-move.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged): Added a call to
EventHandler::dispatchFakeMouseMoveEventSoon().

Source/WebKit/mac: WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
​https://bugs.webkit.org/show_bug.cgi?id=75405

Reviewed by Anders Carlsson.

Removed the WebKit/mac mechanism for dispatching fake mouse moved events
when an HTML frame scrolls, since FrameView now does this.

  • WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar.
(-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to
-_cancelUpdateMouseoverTimer.
(-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer
for dispatching a mouse moved event on scroll.
(-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer.
(-[WebHTMLView viewWillMoveToWindow:]): Ditto.
(-[WebHTMLView mouseDown:]): Ditto.

LayoutTests: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
​https://bugs.webkit.org/show_bug.cgi?id=75405

Reviewed by Anders Carlsson.

  • fast/events/frame-scroll-fake-mouse-move-expected.txt: Added.
  • fast/events/frame-scroll-fake-mouse-move.html: Copied from

LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html and adapted to page scrolling.

4:58 PM Changeset in webkit [103866] by mitz@apple.com
  • 3 edits
    1 delete in trunk/Tools

MiniBrowser sets the WKView’s frame incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=75393

Reviewed by Anders Carlsson.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,

which is not needed since the binray is linked with the frameworks search path set to the
built products directory.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
container’s bounds rather than its frame.

  • MiniBrowser/mac/make-launchable.sh: Removed.
4:56 PM Changeset in webkit [103865] by kling@webkit.org
  • 8 edits in trunk/Source/WebCore

Cache named item collections on Document, not just their caches.
<​http://webkit.org/b/75403>

Reviewed by Anders Carlsson.

Keep two maps of name -> RefPtr<HTMLNameCollection> on Document. We already
had maps for the CollectionCaches and were creating the HTMLNameCollections
every time they were accessed. We now let the collections create and manage
the CollectionCaches instead of Document.

No new tests since these collections are not exposed to the web.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

Replace the name/CollectionCache maps by name/HTMLNameCollection maps.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

Pass names as AtomicStrings to Document's collection getters.

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):

Store the name in an AtomicString instead of a String, incidentally
making traversal of HTMLNameCollections more efficient.

  • html/CollectionType.h:

Remove two now-unneeded constants.

4:50 PM Changeset in webkit [103864] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove Document::collectionInfo() and let collections manage their caches.
<​http://webkit.org/b/75401>

Reviewed by Anders Carlsson.

Remove the CollectionCaches from Document and have the document's collections
create and manage the caches on-demand instead. This is a step towards merging
CollectionCache into HTMLCollection.

  • dom/Document.h:
  • dom/Document.cpp:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):

  • html/HTMLOptionsCollection.cpp:
3:41 PM Changeset in webkit [103863] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderThemeMac: Avoid double hash lookup in systemColor().
<​http://webkit.org/b/75409>

Reviewed by Anders Carlsson.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

3:39 PM Changeset in webkit [103862] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Avoid double hash lookup in keyframeStylesForAnimation().
<​http://webkit.org/b/75408>

Reviewed by Anders Carlsson.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::keyframeStylesForAnimation):

3:36 PM Changeset in webkit [103861] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

KeyframeAnimation: Use hash lookups to determine if property is animated.
<​http://webkit.org/b/75407>

Reviewed by Anders Carlsson.

Clean out an old FIXME about using hash lookups instead of iterating over
the properties.

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::affectsProperty):

12:58 PM Changeset in webkit [103860] by mitz@apple.com
  • 8 edits in trunk/Source

Source/WebCore: WebCore change for <rdar://problem/10463059> Cannot print USPS shipping labels
​http://webkit.org/b/72801

Reviewed by Anders Carlsson and Alexey Proskuryakov.

  • WebCore.exp.in: Exported Chrome::print().

Source/WebKit2: <rdar://problem/10463059> Cannot print USPS shipping labels
​http://webkit.org/b/72801

Reviewed by Anders Carlsson and Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(appendValuesInPDFNameSubtreeToVector): Copied from WebKit/mac/WebView/WebPDFDocumentExtras.mm.
(getAllValuesInPDFNameTree): Ditto.
(getAllScriptsInPDFDocument): Copied allScriptsInPDFDocument() from WebPDFDocumentExtras.mm
and changed it to append to a Vector<RetainPtr<CFStringRef> >.
(WebKit::BuiltInPDFView::create): Changed to take a WebFrame* rather than a Page*.
(WebKit::BuiltInPDFView::BuiltInPDFView): Ditto. Updated initializer accordingly.
(WebKit::BuiltInPDFView::pdfDocumentDidLoad): Copied and adapted code from
-[WebPDFRepresentation finishedLoadingWithDataSource:] to run scripts from the PDF with a
Doc object as the this object.
(WebKit::BuiltInPDFView::initialize): Adapted for the change from having a Page* to having
a WebFrame*.
(WebKit::BuiltInPDFView::destroy): Ditto.
(WebKit::BuiltInPDFView::isActive): Ditto.
(WebKit::jsPDFDocInitialize): Added. Refs the BuiltInPDFView which is the private object for
this Doc.
(WebKit::jsPDFDocFinalize): Added. Derefs the BuiltInPDFView for this Doc.
(WebKit::BuiltInPDFView::jsPDFDocPrint): Added. Calls WebCore::Chrome::print().
(WebKit::BuiltInPDFView::makeJSPDFDoc): Copied from WebKit/mac/WebView/WebJSPDFDoc.mm and
modified to use this BuiltInPDFView as the private object of the Doc being made.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(WebKit::BuiltInPDFView::disconnectFromPage): Adapted for the change from having a Page* to
having a WebFrame*.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin): Pass the WebFrame to WebPage::createPlugin().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Added a WebFrame* parameter, which is used when creating
a BuiltInPDFView.

  • WebProcess/WebPage/WebPage.h:
12:44 PM Changeset in webkit [103859] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8553040> REGRESSION (WebKit2): Safari status text doesn't change when you change the modifier keys without moving the mouse
​https://bugs.webkit.org/show_bug.cgi?id=75404

Reviewed by Jon Honeycutt.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Remove the flags changed event monitor.
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]): Added. Similarly to
-[WebHTMLView _postFlagsChangedEvent:], creates a mouse moved event and passes it to
-mouseMoved:.
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Create a local event monitor for flags
changed events.

12:29 PM Changeset in webkit [103858] by mitz@apple.com
  • 19 edits in trunk/Source

Source/WebCore: WebCore changes for <rdar://problem/8750356> REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document
<​http://webkit.org/b/75232>

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in: Exported PluginDocument::pluginWidget().
  • WebCore.xcodeproj/project.pbxproj: Promoted PluginDocument.h to private.
  • html/PluginDocument.h: Fixed a typo in a comment.

Source/WebKit2: <rdar://problem/8750356> REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document
<​http://webkit.org/b/75232>

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/C/WKPage.cpp:

(WKPageDrawPagesToPDF): Added WKPrintInfo parameter, which is passed through as a PrintInfo
to the WebPageProxy.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Changed to pass the PrintInfo
down to WebPageProxy::drawPagesToPDF.
(-[WKPrintingView _drawPreview:]): Changed to pass the PrintInfo down to
WebPageProxy::drawRectToPDF.

  • UIProcess/API/mac/WKView.mm:

(-[WKView canChangeFrameLayout:]): Changed to use WebFrameProxy::isDisplayingPDFDocument, which
works for subframes as well.
(-[WKView printOperationWithPrintInfo:forFrame:]): Added a FIXME.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::isDisplayingPDFDocument): Added.

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawRectToPDF): Added a PrintInfo parameter, which is passed through to
the Web process.
(WebKit::WebPageProxy::drawPagesToPDF): Ditto.

  • UIProcess/WebPageProxy.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Added an override of pdfDocumentForPrinting() which returns the PDFDocument.

  • WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::pdfDocumentForPrinting): Added. This base class implementation returns 0.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::pdfDocumentForPrinting): Added. Calls through to the Plugin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::pdfDocumentForPrintingFrame): Added this helper function. If the frame is displaying
a plug-in document, allows the plug-in to provide a PDF document for printing.
(WebKit::WebPage::beginPrinting): Added an early return if the frame provides a PDF document
for printing.
(WebKit::WebPage::computePagesForPrinting): If the frame provides a PDF document for printing,
create for each page in the PDF document a page rect with the size available for printing.
(WebKit::drawPDFPage): Added this helper function, which draws a page from the PDF document
into one of the aforementioned page rects. It rotates the PDF page 90 degrees if necessary to
better match the aspect ratio of the paper, then it centers it on the paper. This matches the
behavior of a PDFView when printed with default settings.
(WebKit::WebPage::drawRectToPDF): If the frame provides a PDF document for printing, draw the
PDF pages falling within the requested rect.
(WebKit::WebPage::drawPagesToPDF): If the frame provides a PDF document for printing, draw
the requested pages.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added a PrintInfo parameter to DrawRectToPDF and

DrawPagesToPDF.

Dec 30, 2011:

10:02 PM Changeset in webkit [103857] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Allow disabling accelerated compositing in WebMediaPlayerClient (so audio-only <video> isn't accelerated).
​https://bugs.webkit.org/show_bug.cgi?id=75261

Patch by Ami Fischman <​fischman@chromium.org> on 2011-12-30
Reviewed by Darin Fisher.

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):

  • src/WebMediaPlayerClientImpl.h:
6:56 PM Changeset in webkit [103856] by kling@webkit.org
  • 8 edits
    2 adds in trunk

Cache and reuse the HTMLTableElement.rows collection.
<​http://webkit.org/b/75398>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLTableElement::rows() cache the returned collection and tie it to the
lifetime of the form.

Test: fast/dom/table-rows-collection-idempotence.html

fast/dom/gc-9.html

  • html/HTMLTableElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):

Cache the HTMLTableRowsCollection returned by rows() on the HTMLTableElement.
Remove the per-table CollectionCache and let the collection manage that.

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):

Tell the base class constructor to not retain the back-pointer to the table.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLTableElement.rows.
  • Add a test to verify that HTMLTableElement.rows returns the same object when called repeatedly.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/table-rows-collection-idempotence-expected.txt: Added.
  • fast/dom/table-rows-collection-idempotence.html: Added.
6:43 PM Changeset in webkit [103855] by kling@webkit.org
  • 8 edits
    2 adds in trunk

Cache and reuse the HTMLSelectElement.options collection.
<​http://webkit.org/b/75399>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLSelectElement::options() cache the returned collection and tie it to the
lifetime of the form. This shrinks HTMLSelectElement by sizeof(CollectionCache)
minus one pointer.

Test: fast/dom/select-options-collection-idempotence.html

fast/gc-9.html

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::options):

Cache the HTMLOptionsCollection returned by options() on the HTMLSelectElement.
Remove the per-select CollectionCache and let the collection manage that.

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

Tell the base class constructor to not retain the back-pointer to the element.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::invalidateCache):

Added so HTMLSelectElement can invalidate the collection without triggering
unnecessary instantiation of a CollectionCache.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLSelectElement.options.
  • Add a test to verify that HTMLSelectElement.options returns the same object when called repeatedly.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/select-options-collection-idempotence-expected.txt: Added.
  • fast/dom/select-options-collection-idempotence.html: Added.
5:10 PM Changeset in webkit [103854] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on CMake
​https://bugs.webkit.org/show_bug.cgi?id=75345

Reviewed by Daniel Bates.

This patch enables the [Supplemental] IDL on CMake by changing the build
flow of CMake as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • CMakeLists.txt:
  • UseJSC.cmake: Modified to reflect the new build flow as described above.
  • UseV8.cmake: Ditto.
4:20 PM Changeset in webkit [103853] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/css/absolute-inline-alignment.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75400

Unreviewed, skipping 2 new tests on Qt after r103851.

  • platform/qt/Skipped:
1:27 PM Changeset in webkit [103852] by eric.carlson@apple.com
  • 6 edits in trunk/LayoutTests

[chromium] media/track/track-cue-rendering.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75098

Reviewed by Dan Bernstein.

  • media/media-controls.js:

(textTrackDisplayElement): Don't assume there is only one shadow DOM element used to

display captions.

  • media/track/track-cue-nothing-to-render-expected.txt: Updated.
  • media/track/track-cue-nothing-to-render.html: Fix the test so it checks the track

container and cue text pseudo element properties separately.

  • media/track/track-cue-rendering-expected.txt: Updated for textTrackDisplayElement change.
  • media/track/track-cue-rendering.html: Ditto.
12:58 PM Changeset in webkit [103851] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
​https://bugs.webkit.org/show_bug.cgi?id=74723

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/css/absolute-inline-alignment-2.html

fast/css/absolute-inline-alignment.html

Inline positioned elements in the leading spaces of an inline run need to align to
adjacent text, so add them to the run as they're encountered.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineInfo::LineInfo): Keep a count of positioned objects encountered when

skipping leading whitespace.

(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::RenderBlock::constructLine): Leading positioned objects should not be considered

when deciding the number of runs in a line. Otherwise they would contribute towards line
height themselves and prevent a free-standing BR following the positioned object from providing a full
20px of height.

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Since a run containing line-breaks will enter

skipLeadingWhitespace for each new line we reset the count every time so that the count of positioned
objects we encounter only affects the line they appear on. This case is covered by
fast/inline/styledEmptyInlinesWithBRs.html

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Add a run for each inline positioned object

encountered in leading white space. Keep a count of them so that they can be excluded from
the total number of runs in constructLine.

LayoutTests:

  • fast/css/absolute-inline-alignment-2-expected.html: Added.
  • fast/css/absolute-inline-alignment-2.html: Added.
  • fast/css/absolute-inline-alignment-expected.html: Added.
  • fast/css/absolute-inline-alignment.html: Added.
12:53 PM Changeset in webkit [103850] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

media/video-scales-in-media-document.html is Chromium specific
​https://bugs.webkit.org/show_bug.cgi?id=75079

Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-30
Reviewed by Eric Carlson.

  • platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
  • platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
12:40 PM Changeset in webkit [103849] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=75376

Patch by Raymond Liu <​raymond.liu@intel.com> on 2011-12-30
Reviewed by Adam Barth.

No new tests required.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
12:15 PM Changeset in webkit [103848] by kling@webkit.org
  • 10 edits
    2 adds in trunk

Cache and reuse the HTMLFormElement.elements collection.
<​http://webkit.org/b/75375>

Reviewed by Anders Carlsson.

Source/WebCore:

Let HTMLFormElement::elements() cache the returned collection and tie it to the
lifetime of the form. This reduces memory consumption by ~70 kB (on 64-bit) when
viewing your average popular post on reddit.com.

Test: fast/dom/form-elements-collection-idempotence.html

fast/dom/gc-9.html

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

Cache the HTMLFormCollection returned by elements() on the HTMLFormElement.
Remove the per-form CollectionCache and let the collection manage that.

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):

Have the HTMLCollection constructor take a bool argument that decides whether
we retain the base node pointer or not. This mechanism is a temporary measure
until all collection types are owned by their respective base nodes.

  • html/HTMLFormCollection.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):

Tell the base class constructor to not retain the back-pointer to the form.

LayoutTests:

  • Update gc-9.html to document the new lifetime characteristics of HTMLFormElement.elements.
  • Add a test to verify that HTMLFormElement.elements returns the same object when called repeatedly.
  • fast/dom/form-elements-collection-idempotence-expected.txt: Added.
  • fast/dom/form-elements-collection-idempotence.html: Added.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
11:08 AM Changeset in webkit [103847] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a ParamStorageTraits specialization for RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=75392

Reviewed by Daniel Bates.

  • wtf/Functional.h:

Add a partial specialization of ParamStorageTraits for RetainPtr<T>.

  • wtf/RetainPtr.h:

Bring in the retainPtr function template from WTF.

11:07 AM Changeset in webkit [103846] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r103841.

  • inspector/InspectorMemoryAgent.cpp:
10:35 AM Changeset in webkit [103845] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

CSSStyleDeclaration: Only allow setting parent rule at construction.
<​http://webkit.org/b/75391>

Reviewed by Dan Bernstein.

A CSSStyleDeclaration should only ever belong to one CSSRule. Enforce this
at compile-time by replacing setParentRule(CSSRule*) with clearParentRule().

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule):

  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::clearParentRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::~CSSStyleRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):

9:32 AM Changeset in webkit [103844] by kling@webkit.org
  • 5 edits
    2 adds in trunk

WebKitCSSKeyframeRule.style.parentRule should point to the keyframe rule.
<​http://webkit.org/b/75336>

Reviewed by Antti Koivisto.

Source/WebCore:

Let CSS animation keyframe rules .style.parentRule point back to the keyframe
board, rather than the keyframes rule containing it.

Test: fast/css/css-keyframe-style-parentRule.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::createKeyframeRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

Set the CSSMutableStyleDeclaration's parent rule when creating it instead
of in WebKitCSSKeyframeRule::setDeclaration(). Add assertion to make sure
it's only called with declarations already parented to the keyframe rule.

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):

Stop reparenting keyframe rules' style declarations to the keyframes rule.

LayoutTests:

  • fast/css/css-keyframe-style-parentRule-expected.txt: Added.
  • fast/css/css-keyframe-style-parentRule.html: Added.
9:01 AM Changeset in webkit [103843] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

EnvironmentUtilities::stripValuesEndingWithString fails when the variable ends with the search value
​https://bugs.webkit.org/show_bug.cgi?id=75389

Reviewed by Anders Carlsson.

  • Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString): Fixed an off-by-1 error when
examining the character after the match.

5:11 AM Changeset in webkit [103842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-30

  • DEPS:
2:30 AM Changeset in webkit [103841] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use typed front-end API in the memory agent
​https://bugs.webkit.org/show_bug.cgi?id=75382

Memory agent now uses generate C++ API for communicating to the front-end.

Reviewed by Pavel Feldman.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::DOMTreeStatistics::CounterVisitor::CounterVisitor):
(WebCore::DOMTreeStatistics::CounterVisitor::counters):
(WebCore::DOMTreeStatistics::CounterVisitor::visitNode):

2:29 AM Changeset in webkit [103840] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations change for nested-reflection tests.

  • platform/chromium/test_expectations.txt:
2:17 AM Changeset in webkit [103839] by pfeldman@chromium.org
  • 9 edits in trunk/Source

Web Inspector: migrate from "attached" to "compact" styles.
​https://bugs.webkit.org/show_bug.cgi?id=75381

Source/WebCore:

When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.updateSearchLabel):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype.set compact):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):

  • inspector/front-end/helpScreen.css:

(body.compact .help-window-outer):
(body.compact .help-window-main):
(body.compact .help-window-caption):
(body.compact .help-close-button):
(body.compact .help-content):

  • inspector/front-end/inspector.css:

(body.compact #toolbar):
(body.compact.port-qt #toolbar):
(body.compact.inactive #toolbar):
(body.compact #search-toolbar-label):
(body.compact #toolbar-dropdown-arrow):
(body.compact #search):
(body.compact.port-qt .toolbar-item.close-left, body.compact.port-qt .toolbar-item.close-right):
(body.compact #main):

  • inspector/front-end/inspector.js:

(WebInspector.set attached):
(WebInspector.get isCompactMode):
(WebInspector.get _setCompactMode):
(WebInspector._installDockToRight.listener.get if):
(WebInspector._installDockToRight.listener):

  • inspector/front-end/inspectorCommon.css:

(body.dock-to-right):
(body.dock-to-right.inactive):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.

  • src/js/devTools.css:

(body.compact #toolbar):

1:20 AM Changeset in webkit [103838] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r103794.
​http://trac.webkit.org/changeset/103794
​https://bugs.webkit.org/show_bug.cgi?id=75379

the ASSERT is triggered by several tests (Requested by
jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-30

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):

  • rendering/RenderTable.h:

(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):

12:43 AM Changeset in webkit [103837] by dslomov@google.com
  • 6 edits
    1 delete in trunk/Source/WebKit/chromium

​https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Removed.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:

Dec 29, 2011:

10:24 PM Changeset in webkit [103836] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk/Source/WebKit/chromium

Unreviewed, rolling out r103831.
​http://trac.webkit.org/changeset/103831
​https://bugs.webkit.org/show_bug.cgi?id=75377

broke chromium build (Requested by dslomov_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:
10:01 PM Changeset in webkit [103835] by pfeldman@chromium.org
  • 7 edits in trunk/Source

Web Inspector: enable dock-to-right view (still need embedders to support it).
​https://bugs.webkit.org/show_bug.cgi?id=75360

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-12-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/inspector.js:

(WebInspector.set attached):
(WebInspector._renderAsAttached.get return):
(WebInspector._renderAsAttached):
(WebInspector._installDockToRight.updateToolbar):

Source/WebKit/chromium:

  • src/js/DevTools.js:
8:59 PM Changeset in webkit [103834] by mitz@apple.com
  • 2 edits in trunk/Tools

debug-safari --no-saved-state fails to start the debugger
​https://bugs.webkit.org/show_bug.cgi?id=75374

Reviewed by Sam Weinig.

  • Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
the executable being debugged.

8:50 PM Changeset in webkit [103833] by weinig@apple.com
  • 6 edits
    1 add in trunk

It should be easier to iterate a Vector backwards
​https://bugs.webkit.org/show_bug.cgi?id=75359

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Adds Vector::rbegin(), Vector::rend(), and Vector::reversed(),
a new proxy driven way to access a vector backwards. One can use
reversed() in a range-based for loop like so:

for (auto val: myVector.reversed())

doSomething(val)

  • wtf/Vector.h:

(WTF::Vector::~Vector):
Fix style.

(WTF::Vector::rbegin):
(WTF::Vector::rend):
Added using standard adaptor std::reverse_iterator.

(WTF::Vector::reversed):
(WTF::Vector::VectorReverseProxy::begin):
(WTF::Vector::VectorReverseProxy::end):
Add proxy similar to one used in HashMap for keys() and values()
which allows access to a Vector backwards for use in range-based
for loops.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add new Vector test.

  • TestWebKitAPI/Tests/Vector.cpp: Added.

(TestWebKitAPI::TEST):
Test Vector iterators, reverse_iterators and new reversed proxy.

6:28 PM Changeset in webkit [103832] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Use IDL overloads in AudioContext.idl for createBuffer
​https://bugs.webkit.org/show_bug.cgi?id=75293

Patch by Raymond Liu <​raymond.liu@intel.com> on 2011-12-29
Reviewed by Adam Barth.

No new tests required.

  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/v8/custom/V8AudioContextCustom.cpp:
  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBuffer):

  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
6:13 PM Changeset in webkit [103831] by dslomov@google.com
  • 6 edits
    1 delete in trunk/Source/WebKit/chromium

​https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebFrameClient.h:
  • public/WebWorkerClient.h: Removed.
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.h:
3:49 PM Changeset in webkit [103830] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, add a bug number to a failing test.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [103829] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectation changes to skip array-splice.html.

  • platform/chromium/test_expectations.txt:
3:30 PM Changeset in webkit [103828] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLDivElement: Remove unnecessary variable in parseMappedAttribute().
<​http://webkit.org/b/75363>

Reviewed by Daniel Bates.

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::parseMappedAttribute):

3:27 PM Changeset in webkit [103827] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLParagraphElement: Remove unnecessary variable in parseMappedAttribute().
<​http://webkit.org/b/75362>

Reviewed by Daniel Bates.

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::parseMappedAttribute):

3:25 PM Changeset in webkit [103826] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for Document's named item collection caches.
<​http://webkit.org/b/75335>

Reviewed by Daniel Bates.

  • dom/Document.cpp:

(WebCore::Document::~Document):

Remove now-unneeded deleteAllValues() loop.

(WebCore::Document::nameCollectionInfo):

Use add() instead of find()/add() to avoid one extra hash lookup.

  • dom/Document.h:

Switch the value type of m_nameCollectionInfo to use OwnPtr.

3:22 PM Changeset in webkit [103825] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/AppUnit.h

Fixing round and ceil for negative numbers and removing an incorrect optimization from round due to the results of Emil's microbenchmark

2:49 PM Changeset in webkit [103824] by commit-queue@webkit.org
  • 6 edits in trunk

mfenced skips the first separator if the separators attribute contains multiple separators
​https://bugs.webkit.org/show_bug.cgi?id=57697

Patch by David Barton <Dave Barton> on 2011-12-29
Reviewed by Dan Bernstein.

Source/WebCore:

Added 2 test cases.

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):

LayoutTests:

  • mathml/presentation/fenced-mi.xhtml:
    • Added 2 test cases.
  • platform/mac/mathml/presentation/fenced-mi-expected.png:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
2:40 PM Changeset in webkit [103823] by barraclough@apple.com
  • 11 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Start cleaning up JSArray construction. JSArray has a set of create methods,
one of which (currently) takes a 'creation mode' enum parameter. Based on that
parameter, the constructor does one of two completely different things. If the
parameter is 'CreateInitialized' it creates an array, setting the length, but
does not eagerly allocate a storage vector of the specified length. A small
(BASE_VECTOR_LEN sized) initial vector will be allocated, and cleared, property
access to the vector will read the hole value (return undefined). The alternate
usage of this method ('CreateCompact') does something very different. It tries
to create an array of the requested length, and also allocates a storage vector
large enough to hold all properties. It does not clear the storage vector,
leaving the memory uninitialized and requiring the user to call a method
'uncheckedSetIndex' to initialize values in the vector.

This patch factors out these two behaviours, moving the 'CreateCompact' mode
into its own method, 'tryCreateUninitialized' (matching the naming for this
functionality in the string classes). 'tryCreateUninitialized' may return 0 if
memory allocation fails during construction of the object. The construction
pattern changes such that values added during initialization will be marked if
a GC is triggered during array allocation. 'CreateInitialized' no longer need
be passed to create a normal, fully constructed array with a length, and this
method is merged with the version of 'create' that does not take an initial
length (length parameter defaults to 0).

(JSC::constructArrayWithSizeQuirk):

  • removed 'CreateInitialized' argument
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):

  • changed to call 'tryCreateUninitialized'
  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • changed to call 'tryCreateUninitialized'
  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • initialize m_storage to null; if construction fails, make destruction safe

(JSC::JSArray::finishCreation):

  • merge versions of this method, takes an initialLength parameter defaulting to zero

(JSC::JSArray::tryFinishCreationUninitialized):

  • version of 'finishCreation' that tries to eagerly allocate storage; may fail & return 0

(JSC::JSArray::~JSArray):

  • check for null m_storage, in case array construction failed.

(JSC::JSArray::increaseVectorPrefixLength):

  • runtime/JSArray.h:

(JSC::JSArray::create):

  • merge versions of this method, takes an initialLength parameter defaulting to zero

(JSC::JSArray::tryCreateUninitialized):

  • version of 'create' that tries to eagerly allocate storage; may fail & return 0

(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):

  • used in conjunction with 'tryCreateUninitialized' to initialize the array
  • runtime/JSGlobalObject.h:

(JSC::constructEmptyArray):

  • removed 'CreateInitialized' argument
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::finishCreation):

  • removed 'CreateInitialized' argument

LayoutTests:

Added test case.

  • fast/js/script-tests/array-splice.js:
2:29 PM Changeset in webkit [103822] by tony@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

[chromium] Unreviewed, unskip http/tests/plugins/geturlnotify-from-npp-destroystream.html
since it passes on my Mac Chromium build. Move plugins/inner-html-display-none-expected.txt
from chromium-win to chromium-- it's a V8 specific result.

  • platform/chromium/plugins/inner-html-display-none-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/inner-html-display-none-expected.txt.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [103821] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

Unreviewed, rolling out r103808.
​http://trac.webkit.org/changeset/103808
​https://bugs.webkit.org/show_bug.cgi?id=75370

Tests failed on Chrome Canary bots. (Requested by atwilson on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

  • media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt.
  • media/video-scales-in-media-document.html: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
2:02 PM Changeset in webkit [103820] by tony@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline new flexbox repaint tests on chromium mac
and remove http/tests/plugins/geturlnotify-from-npp-destroystream.html
from test_expectations.txt since it's passing on Win/Linux.

  • platform/chromium-cg-mac-leopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-mac-leopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [103819] by tony@chromium.org
  • 2 edits
    1 copy
    2 moves
    4 deletes in trunk/LayoutTests

[chromium] Unreviewed, add a png baseline for
mouse-click-plugin-clears-selection on chromium-win and re-add 2 flaky svg tests.

  • platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png.
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt.
  • platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.png.
  • platform/chromium/test_expectations.txt:
1:27 PM Changeset in webkit [103818] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a retainPtr function template
​https://bugs.webkit.org/show_bug.cgi?id=75365

Reviewed by Dan Bernstein.

This makes it easier to make a RetainPtr using template argument deduction, which
is useful when passing RetainPtr objects as function arguments.

  • wtf/RetainPtr.h:

(WTF::retainPtr):

12:34 PM Changeset in webkit [103817] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=75274

Reviewed by Andreas Kling.

​http://trac.webkit.org/changeset/103783 broke the Qt SL bot.
This patch fixes the problem by using 'tr' rather than 'sed' which
seems to be more consistent between Mac and Linux.

  • DerivedSources.pri:
12:18 PM Changeset in webkit [103816] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

animation-drt-api-multiple-keyframes.html cannot possibly fail
​https://bugs.webkit.org/show_bug.cgi?id=73112

Reviewed by Simon Fraser.

Output a FAIL message when we fail to pause the animation. This matches the
failure mode before <​https://trac.webkit.org/changeset/84873> (bug #59389).

Additionally, fixes an issue where we paused at a time after cessation of the
animation following <​https://trac.webkit.org/changeset/84873>. Instead, we
should pause at a time before cessation of the animation.

  • animations/animation-drt-api-multiple-keyframes.html:
11:41 AM Changeset in webkit [103815] by leviw@chromium.org
  • 132 edits in branches/subpixellayout/LayoutTests

More updated LayoutTest expectations for Mac

11:35 AM Changeset in webkit [103814] by leviw@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing two painting issues with composited widgets: properly aligning the GraphicsLayer to the renderer's pixel boundaries (when desireable) and using pixelSnappedIntRect instead of enclosingIntRect when setting the RenderWidget's frameRect.

11:08 AM Changeset in webkit [103813] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Scripts navigator should support incremental search by typing.
​https://bugs.webkit.org/show_bug.cgi?id=75349

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype._reset):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):

  • inspector/front-end/inspector.css:

(.outline-disclosure ol.search-match-not-found li.selected .selection):
(.outline-disclosure ol.search-match-found li.selected):
(.outline-disclosure ol.search-match-found li.selected *):
(.outline-disclosure ol.search-match-found li.parent.selected::before):
(.outline-disclosure ol.search-match-found li.parent.expanded.selected::before):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tree-search-box):
(#scripts-navigator-tree-search-box.visible):
(#scripts-navigator-tree-search-box > input):
(.scripts.panel .navigator .search-match-found li.selected .selection):
(.scripts.panel .navigator .search-match-not-found li.selected .selection):
(.scripts.panel .navigator .searching li.selected .selection):

  • inspector/front-end/treeoutline.js:

(TreeOutline):
(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._startSearch.focusSearchInput):
(TreeOutline.prototype._startSearch):
(TreeOutline.prototype._searchTextChanged):
(TreeOutline.prototype._showSearchMatchElement):
(TreeOutline.prototype._searchInputKeyDown):
(TreeOutline.prototype._nextSearchMatch):
(TreeOutline.prototype._previousSearchMatch):
(TreeOutline.prototype._searchInputBlur):
(TreeOutline.prototype._searchFinished):
(TreeOutline.prototype.stopSearch):

10:56 AM Changeset in webkit [103812] by vsevik@chromium.org
  • 10 edits
    2 adds in trunk

Web Inspector: Scripts navigator should trim long file names and show full url in tooltip.
​https://bugs.webkit.org/show_bug.cgi?id=75343

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/ui-source-code-display-name.html

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._appendSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab.get if):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype.get replaceSourceFrames):
(WebInspector.TabbedEditorContainer.prototype.reset):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.changeTabTooltip):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get tooltip):
(WebInspector.TabbedPaneTab.prototype.set tooltip):
(WebInspector.TabbedPaneTab.prototype._createTabElement):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._parseURL):

  • inspector/front-end/utilities.js:

():

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/ui-source-code-display-name-expected.txt: Added.
  • inspector/debugger/ui-source-code-display-name.html: Added.
10:52 AM Changeset in webkit [103811] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for margin is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75358

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for margin.

Test: fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html: Added.
10:44 AM Changeset in webkit [103810] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in RenderSVGResourcePattern
​https://bugs.webkit.org/show_bug.cgi?id=75361

Reviewed by Andreas Kling.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::removeAllClientsFromCache):
(WebCore::RenderSVGResourcePattern::removeClientFromCache):
(WebCore::RenderSVGResourcePattern::applyResource): use HashMap::add() to avoid
looking up the hash twice.

  • rendering/svg/RenderSVGResourcePattern.h: rename m_pattern to m_patternMap to

improve readability a little bit.

10:36 AM Changeset in webkit [103809] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for padding is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75352

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for padding shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html: Added.
10:21 AM Changeset in webkit [103808] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

[GTK] media/video-scales-in-media-document.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75079

Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2011-12-29
Reviewed by Eric Carlson.

  • platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
  • platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
  • platform/gtk/Skipped:
9:52 AM Changeset in webkit [103807] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in OriginAccessMap
​https://bugs.webkit.org/show_bug.cgi?id=75327

Reviewed by Andreas Kling.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

9:22 AM Changeset in webkit [103806] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove unused m_signalListeners from WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=75354

Reviewed by Andreas Kling.

This is unused since r76507.

  • Platform/WorkQueue.h:
  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::platformInvalidate):

9:12 AM Changeset in webkit [103805] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: support sourceMappingURL magic comment.
​https://bugs.webkit.org/show_bug.cgi?id=75356

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findSourceMapURL):

  • inspector/ContentSearchUtils.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug.html:
  • http/tests/inspector/resources/compiled.js:
9:08 AM Changeset in webkit [103804] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Suggest pop-over doesn't hide on tab switch
​https://bugs.webkit.org/show_bug.cgi?id=73611

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.willHide):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.hideSuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

9:02 AM Changeset in webkit [103803] by apavlov@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: Implement CSS selector profiler
​https://bugs.webkit.org/show_bug.cgi?id=74004

Reviewed by Pavel Feldman.

Source/WebCore:

This implementation of CSS selector profiler measures the total time required to match a certain selector
against DOM nodes and apply the style declaration properties to the particular element,
as well as the number of selector matches (i.e. the number of nodes that matched the selector.)
The results are approximate due to internal matching algorithm optimizations (shared styles et al.)
Multiple selectors with the same selectorText are coalesced into a single record.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/CSSSelectorProfileView.js: Added.

(WebInspector.CSSSelectorDataGridNode):
(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.get statusBarItems):
(WebInspector.CSSSelectorProfileView.prototype.get profile):
(WebInspector.CSSSelectorProfileView.prototype.set profile):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
(WebInspector.CSSSelectorProfileView.prototype.refreshShowAsPercents):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.get selectorComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.timeComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.matchesComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):
(WebInspector.CSSSelectorProfileType):
(WebInspector.CSSSelectorProfileType.prototype.get buttonTooltip):
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype.get treeItemTitle):
(WebInspector.CSSSelectorProfileType.prototype.get description):
(WebInspector.CSSSelectorProfileType.prototype.reset):
(WebInspector.CSSSelectorProfileType.prototype.isRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.setRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CSSSelectorProfileType.prototype.createView):

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.reset):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/profilesPanel.css:

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest):

  • inspector/profiler/profiler-test.js:

(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):

8:39 AM Changeset in webkit [103802] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Context menu is hidden right after showing it when first menu item is not disabled
​https://bugs.webkit.org/show_bug.cgi?id=75357

Reviewed by Martin Robinson.

The problem is that we are passing GDK_CURRENT_TIME (which is 0)
to gtk_popup_menu, because the events are async and
gtk_get_current_event is NULL when calling gtk_menu_popup. GtkMenu
has a timeout to decide whether the press-release was fast enough
and ignore the button release event in that case. That way, a
normal right click shows the menu while a long press hides the
menu when the button is released. So, we need to know the real time
when the right button was pressed and pass it to gtk_popup_menu.

  • UIProcess/WebPageProxy.h: Make

currentlyProcessedMouseDownEvent() public.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::showContextMenu): Use
WebPageProxy::currentlyProcessedMouseDownEvent() to get the
current mouse event and pass its button number and time to
gtk_popup_menu.

8:33 AM Changeset in webkit [103801] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Fix several conding style issues in WebKit2 GTK+ code
​https://bugs.webkit.org/show_bug.cgi?id=75339

Reviewed by Martin Robinson.

In addition to the WebKit coding style, code in UIProcess/API/gtk
should follow style and conventions described here
​http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

  • UIProcess/API/gtk/WebKitSettings.cpp: Remove trailing whitespaces.

(webkit_settings_class_init): Remove trailing whitespaces, fix
indentation issues in API doc comments, add missing trailing to
some properties.
(webkit_settings_set_enable_fullscreen): Move the code after
get_enable_fullscreen() for consistency.

  • UIProcess/API/gtk/WebKitSettings.h: Remove trailing

whitespaces. Fix * placement and line up parameters.

  • UIProcess/API/gtk/WebKitWebView.cpp: Remove several empty lines.

(webkit_web_view_class_init): Mark property nicks and blurbs for translation.
(webkitWebViewSetTitle): Remove trailing whitespaces.

  • UIProcess/API/gtk/WebKitWebView.h: Line up parameters.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Use the angle-bracket

form for including file from WebCore and wtf. Use GRefPtr for
GtkIMContext and bool instead of gboolean. Use the placement new
syntax for private struct instead of new/delete.
(webkitWebViewBaseRealize):
(webkitWebViewBaseFinalize):
(webkit_web_view_base_init):
(webkitWebViewBaseFocusInEvent):
(webkitWebViewBaseFocusOutEvent):
(webkitWebViewBaseKeyPressEvent): Remove trailing whitespaces.
(webkitWebViewBaseKeyReleaseEvent):
(webkit_web_view_base_class_init):
(webkitWebViewBaseGetIMContext):

7:08 AM Changeset in webkit [103800] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r103798.
​http://trac.webkit.org/changeset/103798
​https://bugs.webkit.org/show_bug.cgi?id=75353

some small scrollbar differences are making the tests fail on
several platforms (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-29

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

LayoutTests:

  • fast/layers/scroll-with-transform-composited-layer-expected.html: Removed.
  • fast/layers/scroll-with-transform-composited-layer.html: Removed.
  • fast/layers/scroll-with-transform-layer-expected.html: Removed.
  • fast/layers/scroll-with-transform-layer.html: Removed.
6:58 AM Changeset in webkit [103799] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Focus of the DOM tree is not restored when switching to the Elements panel
​https://bugs.webkit.org/show_bug.cgi?id=75351

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.wasShown):

6:06 AM Changeset in webkit [103798] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer-expected.html

fast/layers/scroll-with-transform-composited-layer.html
fast/layers/scroll-with-transform-layer-expected.html
fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 ref tests for scrolling inside a transformed layers (either composited
or not).

  • fast/layers/scroll-with-transform-composited-layer-expected.html: Added.
  • fast/layers/scroll-with-transform-composited-layer.html: Added.
  • fast/layers/scroll-with-transform-layer-expected.html: Added.
  • fast/layers/scroll-with-transform-layer.html: Added.
5:28 AM Changeset in webkit [103797] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Tree views can be collapsed/hidden using the keyboard arrows
​https://bugs.webkit.org/show_bug.cgi?id=46272

Reviewed by Yury Semikhatsky.

WebInspector.SidebarSectionTreeElement which is not selectable has also been made non-collapsible
and expanded by default.

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):

  • inspector/front-end/SidebarTreeElement.js:

(WebInspector.SidebarSectionTreeElement):
(WebInspector.SidebarSectionTreeElement.prototype.selectable.false.collapse):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

5:10 AM Changeset in webkit [103796] by pfeldman@chromium.org
  • 11 edits in trunk/Source

Web Inspector: [chromium] pass dock to side request to the embedder.
​https://bugs.webkit.org/show_bug.cgi?id=75344

Reviewed by Yury Semikhatsky.

Source/WebCore:

I'd like to enable dock-to-right for the front-end window. This is a background work
to pass control flow from the front-end to the front-end host.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::requestSetDockSide):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:
4:16 AM Changeset in webkit [103795] by podivilov@chromium.org
  • 13 edits in trunk

Web Inspector: add "enable source maps" checkbox setting.
​https://bugs.webkit.org/show_bug.cgi?id=75311

Reviewed by Pavel Feldman.

Source/WebCore:

When "enable source maps" is on, all auto detected source maps are silently applied.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

  • inspector/front-end/inspector.js:

(WebInspector._toolbarItemClicked):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-debug-expected.txt:
  • http/tests/inspector/compiler-source-mapping-debug.html:
  • inspector/debugger/raw-source-code.html:
3:21 AM Changeset in webkit [103794] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Tighten our checks for needsSectionRecalc in RenderTable
​https://bugs.webkit.org/show_bug.cgi?id=73972

Reviewed by Adam Barth.

Refactoring covered under the new tests.

Now most of the functions use the header, first body and footer's
getters that checks if we need a section recalculation. The only
exceptions are addChild and recalcSections as they can be called
with the bit set.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
Updated the previous functions to use the sections' getters.

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::recalcSections):
Update the previous functions after the 2 renames
(see below).

  • rendering/RenderTable.h:

(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
Added some ASSERT here. Also renamed m_head to m_header
and m_foot to m_footer to match the getter and to avoid
unneeded abbreviation.

(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):
Updated the previous functions to use the section getters.

2:50 AM Changeset in webkit [103793] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for UserScriptMap and UserStyleSheetMap
​https://bugs.webkit.org/show_bug.cgi?id=75323

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld): fix a small mistake in
previous code. Now the entry for world is removed (and deleted) only if its
stylesheet vector is empty.
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

  • page/UserScriptTypes.h:
  • page/UserStyleSheetTypes.h:

Dec 28, 2011:

8:33 PM Changeset in webkit [103792] by yuqiang.xian@intel.com
  • 7 edits in trunk/Source/JavaScriptCore

spill unboxed values in DFG 32_64
​https://bugs.webkit.org/show_bug.cgi?id=75291

Reviewed by Filip Pizlo.

Currently all the values are spilled as boxed in DFG 32_64, which is
not necessary and introduces additional stores/loads. Instead we
can spill them as unboxed if feasible. It can be applied to the
Integers, Cells and Booleans in DFG 32_64. Doubles are left as is
because they don't need to be boxed at all. The modifications to the
spill/fill and the OSR exit are required, as well as a bug fix to the
"isUnknownJS" logic.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::isUnknownJS):
(JSC::DFG::GenerationInfo::spill):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::isKnownNotBoolean):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::spill):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):

7:56 PM Changeset in webkit [103791] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Reduce memory used by NamedNodeMap.
<​http://webkit.org/b/75333>

Reviewed by Sam Weinig.

Give NamedNodeMap's attribute vector an inline capacity of 4. The vast majority
of elements have <= 4 attributes, and if they don't have any we normally don't
allocate an attribute map at all.

This reduces memory consumption by 1.2MB (on 64-bit) when loading the full HTML5
spec at <​http://whatwg.org/c>.

  • dom/NamedNodeMap.h:
7:54 PM Changeset in webkit [103790] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Reduce memory used by SpaceSplitString.
<​http://webkit.org/b/75315>

Reviewed by Sam Weinig.

Split the string upon creation instead of waiting until it's accessed.
This allows us to get rid of all data members except the substring vector.
Since we're storing AtomicStrings, this is way more memory-efficient than
the previous implementation in the majority of cases.

Also reduced the inline capcity of the vector to 2 (from 8), after testing
showed this to cover 90% of the cases on the Alexa top sites.

All in all this reduces memory consumption by 1.1MB (on 64-bit) when
loading the full HTML5 spec at <​http://whatwg.org/c>. On that same page,
less than 2ms is spent (on my MBP) splitting the ~20000 strings.

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::createVector):
(WebCore::SpaceSplitStringData::containsAll):
(WebCore::SpaceSplitStringData::remove):

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitStringData::contains):
(WebCore::SpaceSplitStringData::size):
(WebCore::SpaceSplitStringData::operator[]):

6:03 PM Changeset in webkit [103789] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
5:25 PM Changeset in webkit [103788] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[GTK] Fix compilation issue when selecting opengl for Accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=75309

Patch by ChangSeok Oh <ChangSeok Oh> on 2011-12-28
Reviewed by Martin Robinson.

.:

Replace WTF_USE_TEXTURE_MAPPER_OPENGL to WTF_USE_TEXTURE_MAPPER_GL

  • GNUmakefile.am:

Source/WebCore:

Add TextureMapperGL and TextureMapperGLCairo files.
They define new classes required to implement TextureMapperGL for GTK port.

No new tests required.

  • GNUmakefile.list.am:
  • platform/graphics/cairo/TextureMapperGLCairo.cpp: Added.

(WebCore::BGRA32PremultimpliedBufferCairo::BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::~BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::beginPaint):
(WebCore::BGRA32PremultimpliedBufferCairo::data):
(WebCore::BGRA32PremultimpliedBufferCairo::endPaint):
(WebCore::uidForImage):
(WebCore::BGRA32PremultimpliedBuffer::create):

  • platform/graphics/cairo/TextureMapperGLCairo.h: Added.
5:14 PM Changeset in webkit [103787] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103785.
​http://trac.webkit.org/changeset/103785
​https://bugs.webkit.org/show_bug.cgi?id=75332

Broke builders; looks like clobbering didnt help (Requested by
dslomov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-28

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::createWorker):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
4:09 PM Changeset in webkit [103786] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add an implicit block conversion operator to WTF::Function
​https://bugs.webkit.org/show_bug.cgi?id=75325

Reviewed by Dan Bernstein.

  • wtf/Compiler.h:

Add a define for COMPILER_SUPPORTS(BLOCKS). It's only defined for clang, since the gcc blocks implementation
is buggy, especially when it comes to C++.

  • wtf/Functional.h:

Add a block conversion operator that creates and returns an autoreleased block that will call the function when executed.

4:00 PM Changeset in webkit [103785] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
3:42 PM Changeset in webkit [103784] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103782.
​http://trac.webkit.org/changeset/103782
​https://bugs.webkit.org/show_bug.cgi?id=75328

broke origin-whitelisting-removal.html (Requested by kling on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-28

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

3:30 PM Changeset in webkit [103783] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on Qt
​https://bugs.webkit.org/show_bug.cgi?id=75274

Reviewed by Adam Barth.

This patch enables the [Supplemental] IDL on Qt by changing the build
flow of Qt as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • DerivedSources.pri: Described the above build flow.
2:43 PM Changeset in webkit [103782] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in OriginAccessMap
​https://bugs.webkit.org/show_bug.cgi?id=75327

Reviewed by Andreas Kling.

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):

2:08 PM Changeset in webkit [103781] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> for ProgressTracker's items
​https://bugs.webkit.org/show_bug.cgi?id=75326

Reviewed by Andreas Kling.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::~ProgressTracker): although is empty, the destructor was
kept so in the header file we can forward declare ProgressItem and use in an OwnPtr.
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress): removed a useless assignment to item
member just before it is deleted.

  • loader/ProgressTracker.h:
1:26 PM Changeset in webkit [103780] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-color is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75324

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for border-color.

Test: fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html: Added.
1:12 PM Changeset in webkit [103779] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Use OwnPtr to handle lifetime and deletion of FontFace objects
​https://bugs.webkit.org/show_bug.cgi?id=75221

Reviewed by Daniel Bates.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Use add instead of get/set to read and
then later fill a cache. Use new version of registerCustomFont that takes PassOwnPtr.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

  • dom/Document.cpp:

(WebCore::Document::registerCustomFont): Take a PassOwnPtr instead of raw pointer.

  • dom/Document.h: Ditto.
1:10 PM Changeset in webkit [103778] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

"Fake" insertion mode in HTMLTreeBuilder doesn't do anything
​https://bugs.webkit.org/show_bug.cgi?id=75322

Reviewed by Darin Adler.

This machinery isn't needed anymore now that we're using the new
foreign content hotness.

  • html/parser/HTMLTreeBuilder.cpp:
  • html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::setInsertionMode):

1:04 PM Changeset in webkit [103777] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fails fast/inline/nested-text-descendants.html
​https://bugs.webkit.org/show_bug.cgi?id=75321

Unreviewed, skip reference test fast/inline/nested-text-descendants.html
on Qt for now. It is the only platform that fails it.

  • platform/qt/Skipped:
12:36 PM Changeset in webkit [103776] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

<math><option><option></html><option></option> used to crash the parser
​https://bugs.webkit.org/show_bug.cgi?id=75317

Reviewed by Eric Seidel.

Add a test so that this case continues to not crash.

  • fast/parser/math-options-crash-expected.txt: Added.
  • fast/parser/math-options-crash.html: Added.
12:18 PM Changeset in webkit [103775] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for border-style is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75312

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for border-style.

Test: fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html: Added.
12:13 PM Changeset in webkit [103774] by alexis.menard@openbossa.org
  • 4 edits
    2 adds in trunk

getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=74743

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-top, border-bottom, border-right, border-left.

Test: fast/css/getComputedStyle/getComputedStyle-border-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):

  • css/CSSComputedStyleDeclaration.h:

LayoutTests:

Add test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-shorthand.html: Added.
11:47 AM Changeset in webkit [103773] by mitz@apple.com
  • 3 edits in trunk

Entering "make" in Source builds only JavaScriptGlue and ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=75318

Reviewed by Anders Carlsson.

  • Makefile: Changed to make Source and Tools.
  • Source/Makefile: Changed to make all projects in Source.
11:18 AM Changeset in webkit [103772] by robert@webkit.org
  • 4 edits
    2 adds in trunk

Inline flow not learning height of all text descendants
​https://bugs.webkit.org/show_bug.cgi?id=75305

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/inline/nested-text-descendants-expected.html

fast/inline/nested-text-descendants.html

The root inline box would only learn it had text descendants if its first grandchild
was text. It wasn't informed of subsequent text grandchildren so could not factor them
into its calculation of the line height.
To fix this, propagate the existence of a text descendant to the root inline box
by walking up through the text child's ancestors.

  • rendering/InlineFlowBox.cpp:

(WebCore::setHasTextDescendantsOnAncestors):
(WebCore::InlineFlowBox::addToLine):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setHasTextDescendants):

LayoutTests:

  • fast/inline/nested-text-descendants-expected.html: Added.
  • fast/inline/nested-text-descendants.html: Added.
11:16 AM Changeset in webkit [103771] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add a new WTF::bind overload that takes 6 parameters
​https://bugs.webkit.org/show_bug.cgi?id=75287

Reviewed by Sam Weinig.

  • wtf/Functional.h:
10:21 AM Changeset in webkit [103770] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk

Unreviewed, rolling out r103620.
​http://trac.webkit.org/changeset/103620
​https://bugs.webkit.org/show_bug.cgi?id=75316

Causes many crashes (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-28

Source/WebCore:

  • loader/FrameLoaderClient.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

Source/WebKit/chromium:

  • public/WebDOMMessageEvent.h:
  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • platform/chromium/fast/events/intercept-postmessage-expected.txt: Removed.
  • platform/chromium/fast/events/intercept-postmessage.html: Removed.
10:08 AM Changeset in webkit [103769] by apavlov@chromium.org
  • 5 edits in trunk

[V8][Chromium] 'randomString' in document.body.style always returns true
​https://bugs.webkit.org/show_bug.cgi?id=75313

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):

LayoutTests:

  • fast/css/style-enumerate-properties-expected.txt:
  • fast/css/style-enumerate-properties.html:
8:06 AM Changeset in webkit [103768] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Add domain.png to WebCore.gypi / WebKit.qrc.
​https://bugs.webkit.org/show_bug.cgi?id=75310

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • inspector/front-end/WebKit.qrc:
8:02 AM Changeset in webkit [103767] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ExperimentsSettings causes warning on chromium when reading localizedStrings.
​https://bugs.webkit.org/show_bug.cgi?id=75299

Reviewed by Pavel Feldman.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):

7:59 AM Changeset in webkit [103766] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel: add debug sidebar resizer to TabbedEditorContainer.
​https://bugs.webkit.org/show_bug.cgi?id=75300

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-sidebar-resizer-widget):

7:25 AM Changeset in webkit [103765] by apavlov@chromium.org
  • 16 edits
    1 add
    1 delete in trunk

Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel
​https://bugs.webkit.org/show_bug.cgi?id=75228

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.get treeItemTitle):
(WebInspector.DetailedHeapshotProfileType.prototype.get description):

  • inspector/front-end/ProfileLauncherView.js: Added.

(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.setUpEventListeners):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.ProfileLauncherView.prototype._onProfileStarted):
(WebInspector.ProfileLauncherView.prototype._onProfileFinished):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.get treeItemTitle):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._showLauncherView):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfileTypeTreeElement):
(WebInspector.ProfileTypeTreeElement.prototype.collapse):
(WebInspector.ProfilesSidebarTreeElement):
(WebInspector.ProfilesSidebarTreeElement.prototype.onattach):
(WebInspector.ProfilesSidebarTreeElement.prototype.onselect):
(WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
(WebInspector.ProfilesSidebarTreeElement.prototype.refresh):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WelcomeView.js: Removed.
  • inspector/front-end/auditsPanel.css:

(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.panel-enabler-view.audit-launcher-view label):
(.panel-enabler-view.audit-launcher-view label.disabled):

  • inspector/front-end/inspector.html:
  • inspector/front-end/panelEnablerView.css:

(.panel-enabler-view img):
(.panel-enabler-view .flexible-space):
(.panel-enabler-view button:not(.status-bar-item)):
(body.inactive .panel-enabler-view button, .panel-enabler-view button:disabled):
(.panel-enabler-view input[type="radio"]):
(.panel-enabler-view input[type="radio"]:active:not(:disabled)):
(.panel-enabler-view input[type="radio"]:checked):
(.panel-enabler-view input[type="radio"]:checked:active):

  • inspector/front-end/profilesPanel.css:

(.profile-launcher-view-tree-item > .icon):
(.profile-launcher-view-content):
(.profile-launcher-view-content h1):
(.panel-enabler-view.profile-launcher-view form):
(.panel-enabler-view.profile-launcher-view label):
(.profile-launcher-view-content p):
(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
(.profile-launcher-view-content button.running:not(.status-bar-item)):
(body.inactive .profile-launcher-view-content button.running:not(.status-bar-item)):

LayoutTests:

  • inspector/profiler/profiler-test.js:

(initialize_ProfilerTest):

5:41 AM Changeset in webkit [103764] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r103763.
​http://trac.webkit.org/changeset/103763
​https://bugs.webkit.org/show_bug.cgi?id=75307

"Compilation fails on Snow Leopard" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-28

  • inspector/CodeGeneratorInspector.py:

(Helper):
(create_ad_hoc_type_declaration.Helper):
(CodeGenerator.generate_type_builder):
(get_in_c_type_text):

5:29 AM Changeset in webkit [103763] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate enum types.
​https://bugs.webkit.org/show_bug.cgi?id=74954

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2011-12-28
Reviewed by Yury Semikhatsky.

Internal map of string contants is created. C enums are created for
each JSON enum.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):

4:58 AM Changeset in webkit [103762] by hans@chromium.org
  • 13 edits in trunk

IndexedDB: IDBKeyRange constructor should throw when lower > upper
​https://bugs.webkit.org/show_bug.cgi?id=74705

Reviewed by Tony Chang.

Source/WebCore:

Make IDBKeyRange throw an exception when lower > upper,
or lower == upper and one or both of the bounds is open.

Tested in storage/indexeddb/keyrange.html.

  • storage/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::bound):

LayoutTests:

Update tests to check that the IDBKeyRange constructor throws when
trying to specify illegal key ranges, and update tests that were
doing that.

  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
4:28 AM Changeset in webkit [103761] by apavlov@chromium.org
  • 9 edits in trunk

Web Inspector: [protocol] empty enum constant should be replaced with identifier
​https://bugs.webkit.org/show_bug.cgi?id=75273

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForRule):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.get isRegular):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-source-offsets.html:
4:04 AM Changeset in webkit [103760] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Crash in ~WebGraphicsLayer when running fast/multicol/pagination-* tests
​https://bugs.webkit.org/show_bug.cgi?id=75000

Reviewed by Noam Rosenthal.

Don't adopt a tile client that belongs to a parent layer.
This is unnecessary and also unsafe because we can live
through that client.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

1:31 AM Changeset in webkit [103759] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: complete annotating SDK component.
​https://bugs.webkit.org/show_bug.cgi?id=75259

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._addScript):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkDispatcher.prototype._isNull):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeFrame.prototype.get name):

  • inspector/front-end/TabbedEditorContainer.js:

Dec 27, 2011:

10:07 PM Changeset in webkit [103758] by weinig@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Continue moving compiler feature checks to use the COMPILER_SUPPORTS() macro
​https://bugs.webkit.org/show_bug.cgi?id=75268

Reviewed by Anders Carlsson.

  • wtf/Compiler.h:

Add support for COMPILER_SUPPORTS(CXX_NULLPTR) and COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/Noncopyable.h:

Use COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS).

  • wtf/NullPtr.cpp:
  • wtf/NullPtr.h:

Use COMPILER_SUPPORTS(CXX_NULLPTR). Remove support for HAVE(NULLPTR).

  • wtf/RefPtr.h:
  • wtf/RetainPtr.h:

Switch from HAVE(NULLPTR) to COMPILER_SUPPORTS(CXX_NULLPTR).

9:29 PM Changeset in webkit [103757] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
​https://bugs.webkit.org/show_bug.cgi?id=75279

Patch by Anantanarayanan G Iyengar <​ananta@chromium.org> on 2011-12-27
Reviewed by Ryosuke Niwa.

Fix a crash in the the WebKit accessibility code which occurs while retrieving
the title UI clement. The fix is to NULL check the RenderObject::node return value.

No test added as there is no reduction.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):

9:13 PM Changeset in webkit [103756] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove duplicate code and remove entry after freeing the matrix.
​https://bugs.webkit.org/show_bug.cgi?id=75073

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-12-27
Reviewed by Ryosuke Niwa.

Remove duplicate ewk_tile_unused_cache_freeze code.
Entry matrix should free first before removing entry in inlist,
because in eina_matrixsparce_free callback entry pointer is referenced to decrease the reference count.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

8:08 PM Changeset in webkit [103755] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[mac] Stop using bootstrap_look_up2
​https://bugs.webkit.org/show_bug.cgi?id=75280

Reviewed by Mark Rowe.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Changed to use bootstrap_look_up() instead of
bootstrap_look_up2().

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

7:27 PM Changeset in webkit [103754] by eae@chromium.org
  • 16182 edits
    1921 copies
    1612 deletes in branches/subpixellayout

Merging trunk changes up until 103725 into subpixel branch.

7:16 PM Changeset in webkit [103753] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make the inputMethodEvent set or confirm the composition
​https://bugs.webkit.org/show_bug.cgi?id=75256

Reviewed by Chang Shu.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::inputMethodEvent):

6:54 PM Changeset in webkit [103752] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add pass/crash expectation for svg/W3C-SVG-1.1/animate-elem-52-t.svg
on Chromium Mac and Linux debug bots per the WebKit bug 74788.

  • platform/chromium/test_expectations.txt:
6:47 PM Changeset in webkit [103751] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitAnimationEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71698

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitAnimationEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
tracking the change to the CSS Animations spec.

  • dom/WebKitAnimationEvent.cpp:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitAnimationEvent.idl:

LayoutTests:

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
6:43 PM Changeset in webkit [103750] by rniwa@webkit.org
  • 20 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for ​http://crbug.com/9768. It's hard to make sense of these failures at this point
but actual results appear to be correct.

  • platform/chromium-linux/fast/forms/select-initial-position-expected.png:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/international/001-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/002-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Added.
  • platform/chromium-win/fast/forms/select-initial-position-expected.png:
  • platform/chromium-win/fast/forms/select-initial-position-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.png:
  • platform/chromium-win/fast/text/cg-fallback-bolding-expected.txt:
  • platform/chromium-win/fast/text/international/001-expected.png:
  • platform/chromium-win/fast/text/international/001-expected.txt:
  • platform/chromium-win/fast/text/international/002-expected.png:
  • platform/chromium-win/fast/text/international/002-expected.txt:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.png:
  • platform/chromium-win/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [103749] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Chromium Linux rebaseline. The difference is negligible for the purpose of this test.

  • platform/chromium-linux/fast/forms/textarea-width-expected.png:
  • platform/chromium-linux/fast/forms/textarea-width-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:27 PM Changeset in webkit [103748] by rniwa@webkit.org
  • 7 edits
    2 adds
    1 delete in trunk/LayoutTests

Chromium Linux rebsaeline for ​http://crbug.com/10430. Glyphs look correct.

  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
6:16 PM Changeset in webkit [103747] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

Chromium rebaseline after Skia revision 105271.
fast/css/shadow-multiple.html appears to have regressed; the failure is tracked by ​http://crbug.com/105271.

  • platform/chromium-win-xp/fast/multicol: Removed.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
6:07 PM Changeset in webkit [103746] by dominicc@chromium.org
  • 7 edits in trunk

Remove initWebKitTransitionEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71701

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitTransitionEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
tracking the change to the CSS Transitions spec.

  • dom/WebKitTransitionEvent.cpp:
  • dom/WebKitTransitionEvent.h:
  • dom/WebKitTransitionEvent.idl:

LayoutTests:

Now that WebKitTransitionEvent has a constructor, we don't need
this method.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
5:31 PM Changeset in webkit [103745] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Misc fixes and cleanups in Functional.h
​https://bugs.webkit.org/show_bug.cgi?id=75281

Reviewed by Andreas Kling.

  • Reformat template declarations so that the class begins on a new line.
  • Change the parameter template parameters to start at P1 instead of P0.
  • Add function wrappers and bind overloads for 4 and 5 parameter functions.
  • Change the Function call operator to be const so const functions can be called.
  • wtf/Functional.h:
5:13 PM Changeset in webkit [103744] by rniwa@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Chromium Linux CPU rebaseline after r103723.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:57 PM Changeset in webkit [103743] by rniwa@webkit.org
  • 34 edits
    37 adds
    67 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 6.

  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-cg-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path: Removed.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-g-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-expected.txt: Added.
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-g-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • svg/clip-path/clip-path-transform-2-expected.txt: Added.
  • svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
4:49 PM Changeset in webkit [103742] by tony@chromium.org
  • 6 edits
    9 moves
    1 add in trunk/Source/WebCore

Move HarfBuzz files into their own directory
​https://bugs.webkit.org/show_bug.cgi?id=72780

Reviewed by Daniel Bates.

FontCacheLinux.cpp got moved to platform/graphics/skia/FontCacheSkia.cpp since it wasn't HarfBuzz specific.

I used HarfBuzz in filenames since that seems to be how the name is capitalized on the project home page.

Fixed some style errors caught by the style checker.

  • PlatformBlackBerry.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp.
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h.
  • platform/graphics/harfbuzz/FontHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp.
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h.
  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp.
  • platform/graphics/harfbuzz/HarfBuzzSkia.h: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h.
  • platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp.
  • platform/graphics/skia/FontCacheSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
4:33 PM Changeset in webkit [103741] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add
    1 delete in trunk

Unreviewed, rolling out r103734.
​http://trac.webkit.org/changeset/103734
​https://bugs.webkit.org/show_bug.cgi?id=75278

Broke cr-mac (Requested by dslomov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-12-27

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::createWorker):

  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Removed.
  • public/WebWorkerClient.h:

(WebKit::WebWorkerClient::~WebWorkerClient):

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):

  • src/WebWorkerBase.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):

  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):

  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::newCommonClient):

  • src/WebWorkerImpl.cpp: Added.

(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):

  • src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.

(WebKit::WebWorkerImpl::client):

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools:

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
4:26 PM Changeset in webkit [103740] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. According to the flakiness dashboard,
fast/forms/input-text-paste-maxlength.html,
fast/filesystem/filesystem-reference.html,
fast/filesystem/filesystem-uri-origin.html, and
fast/canvas/canvas-putImageData.html are no longer flaky.

  • platform/chromium/test_expectations.txt:
4:12 PM Changeset in webkit [103739] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, clean up some obsolete expecatations.

  • platform/chromium/test_expectations.txt:

svg/dom/SVGRectElement/rect-modify-rx.svg is passing according to the flakiness dashboard
and storage/close-during-stress-test.html is flaky in non-debug (very rare, less than 1% of the time).

4:11 PM Changeset in webkit [103738] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing incorrectly overloaded layoutBlock method in RenderFlexibleBox

4:03 PM Changeset in webkit [103737] by rniwa@webkit.org
  • 28 edits
    13 adds
    16 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 5.

  • platform/chromium-cg-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-cg-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-cg-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-cg-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-cg-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-linux-x86/fast/transforms: Removed.
  • platform/chromium-linux-x86/fullscreen: Removed.
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Removed.
  • platform/chromium-win-vista/fullscreen: Removed.
  • platform/chromium-win-xp/fast/transforms: Removed.
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-win/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
3:46 PM Changeset in webkit [103736] by rniwa@webkit.org
  • 34 edits
    25 adds
    18 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 4.

  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip: Added.
  • platform/chromium-cg-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-cg-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-cg-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/box-shadow: Removed.
  • platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/border-radius-big-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Removed.
  • platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Removed.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [103735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision
qualifier.
​https://bugs.webkit.org/show_bug.cgi?id=75168

Patch by Huang Dongsung <​luxtella@company100.net> on 2011-12-27
Reviewed by Noam Rosenthal.

No new functionality so no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::initializeShaders):

3:34 PM Changeset in webkit [103734] by dslomov@google.com
  • 21 edits
    1 copy
    2 deletes in trunk

Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

  • WebKit.gyp:
  • public/WebCommonWorkerClient.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):

  • public/WebWorkerClient.h:
  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):

  • src/WebSharedWorkerImpl.h:

(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):

  • src/WebWorkerBase.cpp:

(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):

  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerClientImpl.h:

(WebKit::WebWorkerClientImpl::commonClient):

  • src/WebWorkerImpl.cpp: Removed.
  • src/WebWorkerImpl.h: Removed.
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
​https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:

  • WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  • NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  • WebWorkerBase merged into WebSharedWorkerImpl
  • NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

  • DumpRenderTree/chromium/TestWebWorker.h:

(TestWebWorker::createWorker):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createWorker):

  • DumpRenderTree/chromium/WebViewHost.h:
3:32 PM Changeset in webkit [103733] by rniwa@webkit.org
  • 42 edits
    37 adds
    41 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 3.

  • fast/borders/borderRadiusGroove01-expected.txt: Removed.
  • fast/borders/borderRadiusGroove02-expected.txt: Removed.
  • fast/borders/borderRadiusInset01-expected.txt: Removed.
  • fast/borders/borderRadiusOutset01-expected.txt: Removed.
  • fast/borders/borderRadiusRidge01-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/different-color-borders-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/different-color-borders-expected.png: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-radius-groove-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [103732] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] Minor cleanup of gyp files.
​https://bugs.webkit.org/show_bug.cgi?id=75269

Reviewed by Adam Barth.

Source/JavaScriptCore:

and vim/emacs specific hooks should be added by the user.

Source/WebKit/chromium:

  • WebKit.gyp: msvs_guid is no longer needed.
3:04 PM Changeset in webkit [103731] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add an expected result meant to be added in r103723.

  • platform/chromium/compositing/scaling: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
2:49 PM Changeset in webkit [103730] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
​https://bugs.webkit.org/show_bug.cgi?id=75263

Reviewed by Tony Chang.

The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.

But we should really fix this function for Linux. Not recognizing any modifier isn't great.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

2:31 PM Changeset in webkit [103729] by haraken@chromium.org
  • 5 edits in trunk

WIP: Enable the [Supplemental] IDL on Gtk
​https://bugs.webkit.org/show_bug.cgi?id=74972

Reviewed by Adam Barth.

.:

This patch adds dom_binding_idls, which is used in Source/WebCore/GNUmakefile.list.am.

  • GNUmakefile.am:

Source/WebCore:

This patch enables the [Supplemental] IDL on Gtk by changing the build
flow of Gtk as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.am: Described the above build flow.
  • GNUmakefile.list.am: Added a list of IDL files. Instead, removed a list of JS*.h and JS*.cpp

that are generated by the IDL files.

2:09 PM Changeset in webkit [103728] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75260
Null name for host function can result in dereference of uninitialize memory

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This is a recent regression in ToT, if the name passed to finishCreation of a host function is null,
we are currently skipping the putDirect, which leaves memory uninitialized. This patch reverts the
aspect of the change that introduced the issue. It might be better if functions that don't have a
name don't have this property at all, but that's change should be separate from fixing the bug.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

  • Always initialize the name property.

LayoutTests:

Added a test for String applies to the ThrowTypeError function object -
if this does not crash, it passes!

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
2:04 PM Changeset in webkit [103727] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] When building with clang, enable -Wglobal-constructors
​https://bugs.webkit.org/show_bug.cgi?id=74365

Reviewed by Adam Barth.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp: Only add it to the webkit target. I got errors when

trying to compile webkit_unit_tests.

1:39 PM Changeset in webkit [103726] by andersca@apple.com
  • 4 edits in trunk

Function should handle wrapping/unwrapping RefPtr and PassRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=75266

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add ParamStorageTraits that can be used for deciding how bound parameters should be stored
and peeked at. For RefPtr we want to use the raw pointer when "peeking" to avoid ref-churn.
For PassRefPtr, we want to use RefPtr for storage but still use the raw pointer when peeking.

  • wtf/Functional.h:

(WTF::ParamStorageTraits::wrap):
(WTF::ParamStorageTraits::unwrap):

Tools:

  • TestWebKitAPI/Tests/WTF/Functional.cpp:

(TestWebKitAPI::Number::create):
(TestWebKitAPI::Number::~Number):
(TestWebKitAPI::Number::value):
(TestWebKitAPI::Number::Number):
(TestWebKitAPI::multiplyNumberByTwo):
(TestWebKitAPI::TEST):

1:04 PM Changeset in webkit [103725] by rniwa@webkit.org
  • 32 edits
    32 adds
    35 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 2.

  • fast/borders/borderRadiusDotted02-expected.txt: Added.
  • fast/borders/borderRadiusDotted03-expected.txt: Added.
  • fast/borders/borderRadiusDouble01-expected.txt: Removed.
  • fast/borders/borderRadiusDouble02-expected.txt: Removed.
  • fast/borders/borderRadiusDouble03-expected.txt: Removed.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble06-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble07-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble08-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble09-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/borders/borderRadiusDotted02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDotted03-expected.txt: Removed.
12:49 PM Changeset in webkit [103724] by rniwa@webkit.org
  • 29 edits
    23 adds
    30 deletes in trunk/LayoutTests

Chromium rebaseline after r98596 part 1.

  • fast/borders/border-radius-complex-inner-expected.txt: Added.
  • fast/borders/borderRadiusArcs01-expected.txt: Removed.
  • fast/borders/borderRadiusDashed01-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-cg-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-cg-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-cg-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds: Removed.
  • platform/chromium-linux-x86/fast/borders: Removed.
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
  • platform/chromium-mac-leopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Removed.
  • platform/chromium-win-vista/fast/borders: Removed.
  • platform/chromium-win-xp/fast/borders: Removed.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed05-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/border-radius-complex-inner-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusDashed01-expected.txt: Removed.
12:27 PM Changeset in webkit [103723] by rniwa@webkit.org
  • 15 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium] media/video-layer-crash.html media/video-transformed.html media/video-zoom-controls.html are failing on linux and win gpu.
​https://bugs.webkit.org/show_bug.cgi?id=73905

Unreviewed rebaseline.

Also rebaselined compositing/color-matching/image-color-matching.html, compositing/geometry/vertical-scroll-composited.html
and compositing/scaling/tiled-layer-recursion.html.

  • platform/chromium-cg-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-cg-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.txt: Added.
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Replaced.
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [103722] by tony@chromium.org
  • 4 edits in trunk/Source

[chromium] really enable wpo for WebCore libs and for WTF
​https://bugs.webkit.org/show_bug.cgi?id=75264

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the

value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.

11:53 AM Changeset in webkit [103721] by rniwa@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=74688

Chromium rebaseline after r103719.

  • platform/chromium-cg-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:43 AM Changeset in webkit [103720] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] remove references to files no longer in the tree
​https://bugs.webkit.org/show_bug.cgi?id=75262

Reviewed by Adam Barth.

  • WebCore.gypi: platform/mac/PlatformMouseEventMac.mm and platform/mac/WheelEventMac.mm

were removed in r103652.

11:36 AM Changeset in webkit [103719] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

bidi-override-in-anonymous-block.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=74688

Unreviewed.

This test just needs an updated expectation. The case that changed is
the last (in the HTML) Ruby case. That tests an <rt> element nested
inside an <rb> element. Previously, the <rt> element closed the <rb>
element, but the HTML5 spec changed the parser so that the <rt> does
not close the <rb>. I don't fully understand the issues, but the
discussion on the mailing list makes it sound like this is the better
way to parse Ruby.

In any case, the change in parsing behavior changed how we render this
test case. The bidi aspect are still functioning correctly.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/test_expectations.txt:
11:12 AM Changeset in webkit [103718] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed web inspector localizedStrings.js fix.

  • English.lproj/localizedStrings.js:
11:07 AM Changeset in webkit [103717] by leviw@chromium.org
  • 521 edits in branches/subpixellayout/LayoutTests

Adding updated test expectations for Mac for numerous LayoutTests.

11:01 AM Changeset in webkit [103716] by leviw@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Adding an AppUnit calcValue to length, and propagating LayoutUnits to various methods still on ints.

10:35 AM Changeset in webkit [103715] by rniwa@webkit.org
  • 102 edits
    110 adds
    22 deletes in trunk/LayoutTests

Chromium rebaseline after r103251.

Also remove failing expectations from tables/mozilla/bugs/bug9024.html on Snow Leopard
and svg/clip-path/clip-path-text-and-stroke.svg on all but Leopard.

  • platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-06-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-16-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-53-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-61-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-62-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-63-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-64-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-65-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-66-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-67-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-68-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-69-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-73-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-74-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-76-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-83-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-84-d-expected.png: Removed.
  • platform/chromium-mac/css2.1/t170602-bdr-conflct-w-86-d-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323: Removed.
  • platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/chromium-win/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/chromium/css2.1/t170602-bdr-conflct-w-05-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-07-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-08-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-15-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-17-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-18-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-51-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-52-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-71-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-72-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-75-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-77-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-78-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-79-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-81-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-82-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-85-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-87-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-88-d-expected.png: Added.
  • platform/chromium/css2.1/t170602-bdr-conflct-w-89-d-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [103714] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Introduce support for experimental settings.
​https://bugs.webkit.org/show_bug.cgi?id=75250

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):
(WebInspector.ExperimentsSettings.prototype.get experiments):
(WebInspector.ExperimentsSettings.prototype.get experimentsEnabled):
(WebInspector.ExperimentsSettings.prototype._createExperiment):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting.get var):
(WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting):
(set WebInspector.Experiment):
(WebInspector.Experiment.prototype.get name):
(WebInspector.Experiment.prototype.get title):
(WebInspector.Experiment.prototype.isEnabled):
(WebInspector.Experiment.prototype.setEnabled):
(set WebInspector):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createExperimentsWarningSubsection):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox.listener):
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):

  • inspector/front-end/helpScreen.css:

(.settings-experiments-warning-subsection-warning):
(.settings-experiments-warning-subsection-message):

9:47 AM Changeset in webkit [103713] by yurys@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Web Inspector: inspector/dom-statistics.html test fails on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=75258

Disable inspector/dom-statistics.html for now until we finalize MemoryAgent functionality.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics.html-disabled: Renamed from LayoutTests/inspector/dom-statistics.html.
9:46 AM Changeset in webkit [103712] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception when scrolling in JavaScriptOutline dialog with empty query
​https://bugs.webkit.org/show_bug.cgi?id=75255

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog.prototype._onScroll):

9:03 AM EFLWebKit edited by kubo@profusion.mobi
gtk is not needed to build the port (diff)
8:26 AM Changeset in webkit [103711] by pfeldman@chromium.org
  • 31 edits in trunk

Web Inspector: add more annotations on SDK classes.
​https://bugs.webkit.org/show_bug.cgi?id=75247

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._breakpoint):

  • inspector/front-end/Color.js:

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._rgbStringsToHex):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):

  • inspector/front-end/CompilerSourceMapping.js:
  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.StaticContentProvider):

  • inspector/front-end/CookieParser.js:

(WebInspector.CookieParser.KeyValue):
(WebInspector.CookieParser.prototype.parseCookie):
(WebInspector.CookieParser.prototype.parseSetCookie):
(WebInspector.CookieParser.prototype._extractKeyValue):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:

(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/HAREntry.js:
  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._mainFrameNavigated):

  • inspector/front-end/Placard.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.LocalJSONObject.prototype.get hasChildren):
(WebInspector.LocalJSONObject.prototype._children):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.restoreRevisions):
(WebInspector.Resource.prototype.get queryParameters):
(WebInspector.Resource.prototype.get formParameters):
(WebInspector.Resource.prototype.isHttpFamily):

  • inspector/front-end/ResourceCategory.js:
  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isInlineScript):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.positionToLocation):

  • inspector/front-end/WelcomeView.js:

(WebInspector.WelcomeView.prototype.addMessage):

  • inspector/front-end/externs.js:

(Array.prototype.upperBound):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt:
  • inspector/runtime/runtime-setPropertyValue.html:
8:23 AM Changeset in webkit [103710] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
​https://bugs.webkit.org/show_bug.cgi?id=75245

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.selectTab):

8:21 AM Changeset in webkit [103709] by yurys@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: report per document JS event listener count
​https://bugs.webkit.org/show_bug.cgi?id=74298

Source/WebCore:

This patch adds JS event listener count to the memory agent
report.

Reviewed by Pavel Feldman.

Test: inspector/dom-statistics.html

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Added a test for basic functionality of MemoryAgent.

Reviewed by Pavel Feldman.

  • inspector/dom-statistics-expected.txt: Added.
  • inspector/dom-statistics.html: Added.
  • platform/chromium/inspector/dom-statistics-expected.txt: Added.
7:29 AM Changeset in webkit [103708] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Go to Function dialog always has a minimal height
​https://bugs.webkit.org/show_bug.cgi?id=75254

Reviewed by Yury Semikhatsky.

  • inspector/front-end/scriptsPanel.css:

(.script-view):

2:26 AM Changeset in webkit [103707] by vsevik@chromium.org
  • 10 edits
    1 add in trunk/Source/WebCore

Web Inspector: Create tabbed editor for scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=75230

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes.get if):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TabbedEditorContainer.js: Added.
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.get visibleView):
(WebInspector.TabbedPane.prototype.get selectedTabId):
(WebInspector.TabbedPane.prototype.closeAllTabs):
(WebInspector.TabbedPane.prototype.changeTabTitle):
(WebInspector.TabbedPane.prototype.changeTabView):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get title):
(WebInspector.TabbedPaneTab.prototype.set title):
(WebInspector.TabbedPaneTab.prototype.get view):
(WebInspector.TabbedPaneTab.prototype.set view):
(WebInspector.TabbedPaneTab.prototype._createTabElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:

(.scripts-views-container):
(.script-view):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header):
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(#scripts-editor-container-tabbed-pane .tabbed-pane-content):

2:21 AM Changeset in webkit [103706] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: Rolling out r103703 for breaking Canvas2DLayerChromiumTest.testFullLifecycle.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
2:16 AM Changeset in webkit [103705] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed Xmas gardening after r103617, add additional console message:
CONSOLE MESSAGE: line 2: <html xmlns='​http://www.w3.org/1999/xhtml/'><body><p>Running an XSL-T 1.0 stylesheet with a 2.0 processor.</p></body></html>

  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Added.
1:01 AM Changeset in webkit [103704] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

WK2: AX: platform/mac/accessibility/search-predicate.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=75039

Patch by Sam White <​samuel.white@rochester.edu> on 2011-12-27
Reviewed by Chris Fleizach.

This test is failing in WK2 because WK2 isn't correctly reporting
visited links as visited. This issue has been reported before as
bug ​https://bugs.webkit.org/show_bug.cgi?id=58334.

I think the most appropriate first action is to add this test to
platform/wk2/Skipped under the existing bug and note the addition
in the existing bugs comments.

WebKitTestRunner has several known bugs

  • platform/wk2/Skipped:
12:25 AM Changeset in webkit [103703] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Bypass the shadow texture copy for accelerated
canvas when running the compositor in single threaded mode.
​https://bugs.webkit.org/show_bug.cgi?id=75146

The texture copy fails on Windows as glCopyTexImage2D() doesn't
support BGRA source textures.
This change also modified Canvas2DLayerChromium::updateCompositorResources
to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
the copy can work with texture allocated via the glTexStorage2D
extension.

Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:
Note: See TracTimeline for information about the timeline view.