Timeline



Jan 5, 2012:

10:41 PM Changeset in webkit [104269] by mitz@apple.com
  • 14 edits in trunk

<rdar://problem/10633760> Update copyright strings

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Info.plist:

Source/JavaScriptGlue:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • Info.plist:
  • PluginProcess/Info.plist:
  • WebProcess/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
9:36 PM Changeset in webkit [104268] by alexis.menard@openbossa.org
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Move HTMLFormControlElementWithState class in its own header file.
​https://bugs.webkit.org/show_bug.cgi?id=75482

Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextFormControlElement.h:
9:29 PM Changeset in webkit [104267] by barraclough@apple.com
  • 5 edits in trunk

Date constructor handles infinite values incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=70998

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • should be checking !finite rather then isnan.

LayoutTests:

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js:
    • Added test cases.
8:48 PM Changeset in webkit [104266] by barraclough@apple.com
  • 5 edits in trunk

date.toISOString produces incorrect results for dates with ms prior to 1970
​https://bugs.webkit.org/show_bug.cgi?id=75684

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

LayoutTests:

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:
    • Added test case
8:01 PM Changeset in webkit [104265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
​https://bugs.webkit.org/show_bug.cgi?id=74693

Patch by Wei James <​james.wei@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):

7:20 PM Changeset in webkit [104264] by jochen@chromium.org
  • 3 edits in trunk/Tools

Don't hardcode expected file URIs in as they depend on the platform
​https://bugs.webkit.org/show_bug.cgi?id=75666

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

7:14 PM Changeset in webkit [104263] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r104210): Dromaeo DOM test score is lower
​https://bugs.webkit.org/show_bug.cgi?id=75679

Reviewed by Andreas Kling.

The regression was caused by isDomVersionConsistent not being able to obtain the tree version
inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
m_cachedItem to some node when caching the length so that we can obtain the tree version later.

Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
m_isItemCacheValid all in 32-bit.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):

7:10 PM Changeset in webkit [104262] by ojan@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

More chromium expected results after r104208.

  • platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png:
  • platform/chromium-win-xp/fast/table/032-expected.txt: Removed.
6:46 PM Changeset in webkit [104261] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed bad merge fix for r104259 which dropped a line from r104210.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

6:13 PM Changeset in webkit [104260] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=75593
Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2012-01-05
Reviewed by Alexey Proskuryakov.

Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
throughout the rest of FrameView.cpp.

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

5:58 PM Changeset in webkit [104259] by morrita@google.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Moving between TreeScopes should be done by its own class.
​https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: Followed the renaming.

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: Followed te renaming.

(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):

  • dom/Element.cpp: Followed te renaming.

(WebCore::Element::removeShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):

  • dom/Node.h:
  • dom/TreeScope.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()

  • dom/TreeScopeAdopter.cpp: Added.

(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • dom/TreeScopeAdopter.h: Added.

(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

5:37 PM Changeset in webkit [104258] by barraclough@apple.com
  • 4 edits in trunk

Array.prototype.lastIndexOf ignores undefined fromIndex.
​https://bugs.webkit.org/show_bug.cgi?id=75678

Reviewed by Sam Weinig.

Source/JavaScriptCore:

array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncLastIndexOf):

  • should check argumnet count, rather than checking agument value for undefined.

LayoutTests:

  • ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
    • check in passing result
5:32 PM Changeset in webkit [104257] by jochen@chromium.org
  • 8 edits in trunk

Source/WebCore: Disallow access to DOM storage from detached frames.
​https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):

Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
​https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
​https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

  • fast/storage/storage-detached-iframe-expected.txt:
  • fast/storage/storage-detached-iframe.html:
  • platform/chromium/test_expectations.txt:
5:32 PM Changeset in webkit [104256] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

5:29 PM Changeset in webkit [104255] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
​https://bugs.webkit.org/show_bug.cgi?id=75598

Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
declaring shaders in TextureMapperGL.

We need two macros to account for the differences between OpenGL and OpenGL ES2.

Reviewed by Martin Robinson.

5:19 PM Changeset in webkit [104254] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

sizeof(CSSRule) is 20 instead of 12 on Windows
​https://bugs.webkit.org/show_bug.cgi?id=75665

Reviewed by Darin Fisher.

Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
in bitfields. e.g. if you have:

sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}

then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
only allocate sizeof(unsigned) * 1 for AB.

Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(WebCore::CSSRule::sourceLine):
(WebCore::CSSRule::setSourceLine):
(WebCore::CSSRule::hasCachedSelectorText):
(WebCore::CSSRule::setHasCachedSelectorText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::cleanup):
(WebCore::CSSStyleRule::selectorText):
(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleRule.h:
5:17 PM Changeset in webkit [104253] by Lucas Forschler
  • 1 copy in tags/Safari-535.15

New Tag.

5:15 PM Changeset in webkit [104252] by dgrogan@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: IndexedDB: fix cursor prefetch crash
​http://crbug.com/108071
​https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: ​http://codereview.chromium.org/9108004

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.

  • storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
​https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

  • storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
  • storage/indexeddb/prefetch-bugfix-108071.html: Added.
5:08 PM Changeset in webkit [104251] by barraclough@apple.com
  • 5 edits in trunk

Date parsing is too restrictive.
​https://bugs.webkit.org/show_bug.cgi?id=75671

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.

The date portion on the should match: (pseudocode!:)

[(+)YY]YYYY[-MM[-DD]]

though we are slightly more liberal (permitted by the spec), allowing:

[+]Y+[-MM[-DD]]

The time portion should match:

THH:mm[:ss[.sss]][Z|(+|-)HH:mm]

again we're slightly more liberal, allowing:

THH:mm[:ss[.s+]][Z|(+|-)HH:mm]

  • wtf/DateMath.cpp:

(WTF::parseES5DatePortion):

  • Month/day fields are optional, default to 01.

(WTF::parseES5TimePortion):

  • Hours/Minutes are requires, seconds/timezone are optional.

(WTF::parseES5DateFromNullTerminatedCharacters):

  • Dates may be date only, or date + time.

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
    • Add more test cases for Date.parse.
5:05 PM Changeset in webkit [104250] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r100203.

5:02 PM Changeset in webkit [104249] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r99999.

5:01 PM Changeset in webkit [104248] by jamesr@google.com
  • 13 edits in trunk/Source

[chromium] Route all animate calls through CCLayerTreeHost in composited mode to simplify rate limiting logic
​https://bugs.webkit.org/show_bug.cgi?id=75577

Reviewed by Darin Fisher.

Source/WebCore:

This internalizes the animation rate limiting logic to CCLayerTreeHost and removes the setters/getters for the
m_animating flag. This requires that all animation updates have to go through CCLayerTreeHost to get the right
rate limiting behavior, regardless of which proxy is being used.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::layout):
(WebCore::CCLayerTreeHost::startRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

Routes WebWidget-initiated animate() calls through the CCLayerTreeHost in composited mode. CCLayerTreeHost's
rate limiting logic needs to be aware of when requestAnimationFrame callbacks are run. In threaded mode, the
animate calls are driven from CCThreadProxy and so the CCLayerTreeHost can set whatever state it needs. This
makes the single-threaded mode where the animate calls are driven through the WebWidget interface outside of the
CCProxy's control.

This is a small step towards inverting the scheduling control from the WebWidget to the compositor.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

  • src/WebViewImpl.h:
4:54 PM Changeset in webkit [104247] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/dom/Element.cpp

Fix rounding for adjustForLocalZoom

4:44 PM Changeset in webkit [104246] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] NativeImageSkia should mark SkBitmaps as immutable
​https://bugs.webkit.org/show_bug.cgi?id=74962

Removed m_isDataComplete from class NativeImageSkia. Instead, data
completeness will be tracked through SkBitmap::setImmutable/
isImmutable. The immutable state signifies that the pixel data
will no longer change for the lifetime of the bitmap, which corresponds
to the semantic of the old m_isDataComplete member. setImmutable is
also called on the cached resized bitmap, since it too is invariant for
its life time. Temporary resized bitmaps are also marked as immutable
since they technically are.

Patch by Justin Novosad <​junov@chromium.org> on 2012-01-05
Reviewed by Stephen White.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore::NativeImageSkia::setDataComplete):
(WebCore::NativeImageSkia::isDataComplete):

4:42 PM Changeset in webkit [104245] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark flaky test as flaky. Filed
​https://bugs.webkit.org/show_bug.cgi?id=75647 about making it not
flaky.

  • platform/chromium/test_expectations.txt:
4:39 PM Changeset in webkit [104244] by abarth@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r104231.
​http://trac.webkit.org/changeset/104231
​https://bugs.webkit.org/show_bug.cgi?id=75668

Breaks the Qt build (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-05

Source/WebCore:

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

4:36 PM Changeset in webkit [104243] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch

Merged r99756.

4:33 PM Changeset in webkit [104242] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r99731.

4:32 PM Changeset in webkit [104241] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Resize requests at the view level should be ignored when in autoresize mode.
​https://bugs.webkit.org/show_bug.cgi?id=75651

Reviewed by Dmitry Titov.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize): The assert was here to catch a view that
tried to do a resize after setting autoresize. However, we found that generic
code tries to do resizes as well. Rather than special case each caller,
we'll just make this code ignore the resize call.

4:30 PM Changeset in webkit [104240] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=75654
Text fields should draw using NSTextFieldCell instead of WebKitSystemInterface

Reviewed by John Sullivan.

This change should not have any affect on tests or real web sites. It just changed
the implementation under the hood to the more modern NSCell approach.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

4:29 PM Changeset in webkit [104239] by andersca@apple.com
  • 7 edits
    2 adds in trunk

Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
​https://bugs.webkit.org/show_bug.cgi?id=75667
<rdar://problem/10389454>

Reviewed by Kevin Decker.

Source/WebKit2:

NPRuntimeObjectMap::invalidate is called whenever a plug-in view is destroyed. If invalidate is called for an object map
whose plug-in has a null frame, we'd crash.

The plug-in will have a null frame if the plug-in view is destroyed because its containing frame has been removed from the document,
and if the plug-in view is being destroyed asynchronously due to the plug-in itself calling JavaScript that will remove the frame
(see PluginView::unprotectPluginFromDestruction).

The reason NPRuntimeObjectMap::invalidate will crash when the frame is null is because we were trying to access the frame's global
object, causing a null dereference. The reason we were trying to get at the frame's global object was to create a Strong handle to
a JSNPObject so we could stick the object in a vector so we could later iterate over the vector elements and call invalidate() on
each JSNPObject which will end up releasing the underlying NPObject.

However, it turns out that we don't need to stick the JSNPObject in a vector; we can just get the underlying NPObject directly and
stick that in a vector and then iterate over the NPObjects, releasing them.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

Tools:

Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::executeScript):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:

(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):

LayoutTests:

  • plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
  • plugins/npruntime/object-from-destroyed-plugin-in-subframe.html: Added.
4:15 PM Changeset in webkit [104238] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r99579.

4:12 PM Changeset in webkit [104237] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r99462.

4:01 PM Changeset in webkit [104236] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Add a compile-time assertion for the size of CSSValue
​https://bugs.webkit.org/show_bug.cgi?id=75635

Reviewed by Tony Chang.

Tightened the compile-time assertion.

  • css/CSSValue.cpp:
3:59 PM Changeset in webkit [104235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Undefined references to ICU_I18N symbols on WTF
​https://bugs.webkit.org/show_bug.cgi?id=75642

Unreviewed build fix.

Add ${ICU_I18N_LIBRARIES} to WTF_LIBRARIES on wtf efl platform cmake.
Some undefined references were ucol_setAttribute_44, ucol_close_44,
ucol_getAttribute_44...

Patch by Bruno Dilly <​bdilly@profusion.mobi> on 2012-01-05

  • wtf/PlatformEfl.cmake:
3:57 PM Changeset in webkit [104234] by eae@chromium.org
  • 6 edits in branches/subpixellayout/LayoutTests/platform/mac/fast/forms

Update mac test expectations for a couple of form tests.

3:57 PM Changeset in webkit [104233] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

[V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor]
​https://bugs.webkit.org/show_bug.cgi?id=75641

Reviewed by David Levin.

Rather than generate getters for SerializedScriptValues, we eagerly
deserialize them into JavaScript objects. However, previously, we were
only doing that for DOM wrappers created by taking an existing C++
object and wrapping it. For objects created with Constructors (e.g.,
those with the [Constructor] attribute), we need to do this eager
deserialization during the constructor as well.

This bug isn't observable yet, but it is causing the WebIntent test
being added in Bug 73051 to fail.

Test: TestSerializedScriptValueInterface.idl

webintents/web-intents-api.html (after Bug 73051 lands)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEagerDeserialization):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
3:45 PM Changeset in webkit [104232] by ojan@chromium.org
  • 7 edits
    1 move
    4 adds
    2 deletes in trunk/LayoutTests

New chromium expected results after r104208.

  • platform/chromium-linux/fast/table/032-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.png:
  • platform/chromium-mac-leopard/fast/table/032-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55694-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug55694-expected.png: Removed.
  • platform/chromium-win-xp/fast/table/032-expected.png: Added.
  • platform/chromium-win-xp/fast/table/032-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/table/032-expected.txt.
  • platform/chromium-win/fast/table/032-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55694-expected.txt:
3:11 PM Changeset in webkit [104231] by abarth@webkit.org
  • 5 edits in trunk/Source

Introduce Platform namespace for WebCore/platform
​https://bugs.webkit.org/show_bug.cgi?id=75653

Reviewed by Eric Seidel.

Source/WebCore:

This patch introduces the Platform namespace for WebCore/platform.
Introducing this namespace will help us find and fix layering
violations in preparation for moving WebCore/platform to Platform.

  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::acceptNavigationRequest):

3:07 PM Changeset in webkit [104230] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
​https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

3:04 PM Changeset in webkit [104229] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r98912-r99538): Crash in WebKit::WebFrameLoaderClient::didDetectXSS
​https://bugs.webkit.org/show_bug.cgi?id=75578

Reviewed by Daniel Bates.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
Check for a correct struct member existence.

2:58 PM Changeset in webkit [104228] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/WebKit/win

Merged r103479.

2:55 PM Changeset in webkit [104227] by Lucas Forschler
  • 14 edits in branches/safari-534.54-branch/Source

Merged r99439.

2:42 PM Changeset in webkit [104226] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit/mac

Merged r98970.

2:39 PM Changeset in webkit [104225] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98796.

2:37 PM Changeset in webkit [104224] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98781.

2:35 PM Changeset in webkit [104223] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98763.

2:35 PM Changeset in webkit [104222] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Remove unused pixelSnapped methods from RenderBox.

2:33 PM Changeset in webkit [104221] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch

Merged r98561.

2:30 PM Changeset in webkit [104220] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r96294.

2:30 PM Changeset in webkit [104219] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refined the fast path for StringImpl::hash()
​https://bugs.webkit.org/show_bug.cgi?id=75178

Reviewed by Darin Adler.

Moved the hash calculation code into an out-of-line function to clean up
the hot path.

No measurable benchmark change, but this knocks some samples off in
Instruments, and I think this is a step toward removing -fomit-frame-pointer.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::hashSlowCase):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::hash): The patch.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashSlowCase): Abide by the cockamamie Windows build
scheme, which requires all out-of-line StringImpl functions used by
WebCore be defined in this file instead of StringImpl.cpp. (See ​http://trac.webkit.org/changeset/59187.)

2:29 PM Changeset in webkit [104218] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Updating expecxtations for fast/media/viewport-media-query.
My understanding of the semantics was a bit off.

  • platform/chromium/test_expectations.txt:
2:04 PM Changeset in webkit [104217] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98513.

2:03 PM Changeset in webkit [104216] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r98374.

2:01 PM Changeset in webkit [104215] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98362.

2:00 PM Changeset in webkit [104214] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r98344.

1:58 PM Changeset in webkit [104213] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r98186.

1:56 PM Changeset in webkit [104212] by barraclough@apple.com
  • 5 edits in trunk

Literal tab in JSONString fails
​https://bugs.webkit.org/show_bug.cgi?id=71772

Reviewed by Oliver Hunt.

rfc4627 does not allow literal tab characters in JSON source.

Source/JavaScriptCore:

  • runtime/LiteralParser.cpp:

(JSC::isSafeStringCharacter):

  • do not allow literal tab in StrictJSON mode.

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • fast/js/resources/JSON-parse.js:

(createTests.result):

  • Updated expected results.
1:56 PM Changeset in webkit [104211] by Lucas Forschler
  • 7 edits
    5 copies in branches/safari-534.54-branch

Merge 98033.

1:48 PM Changeset in webkit [104210] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
​https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
1:41 PM Changeset in webkit [104209] by wjmaclean@chromium.org
  • 3 edits
    1 copy in trunk/Source/WebKit/chromium

[chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value, causing accelerated content to not display in Aura desktop
​https://bugs.webkit.org/show_bug.cgi?id=75551

Reviewed by James Robinson.

  • WebKit.gypi:
  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):

  • tests/WebExternalTextureLayerImplTest.cpp: Copied from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
1:39 PM Changeset in webkit [104208] by ojan@chromium.org
  • 8 edits
    3 adds in trunk

IE quirk for percentage size on a table element doesn't work with orthogonal writing modes
​https://bugs.webkit.org/show_bug.cgi?id=70195

Reviewed by Eric Seidel.

Source/WebCore:

Remove this quirk entirely. Mozilla and Opera don't implement it and IE
doesn't restrict the quirk to standards mode. As it's unlikely for
webkit-only content to hit this quirk (e.g. use tables for layout),
it should be relatively safe to match Mozilla/Opera here.

Test: fast/writing-mode/table-percent-width-quirk.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

  • fast/table/032.html:
  • fast/writing-mode/table-percent-width-quirk-expected.png: Added.
  • fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
  • fast/writing-mode/table-percent-width-quirk.html: Added.
  • platform/mac/fast/table/032-expected.png:
  • platform/mac/fast/table/032-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.png:
  • platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
1:37 PM Changeset in webkit [104207] by eae@chromium.org
  • 11 edits in branches/subpixellayout/Source

Change IntrinsicSize back to an IntSize and get rid of extraneous rounding.

1:25 PM Changeset in webkit [104206] by jochen@chromium.org
  • 6 edits in trunk/Tools

Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
​https://bugs.webkit.org/show_bug.cgi?id=75617

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.exists):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(GenericFileSystemTests.teardown_generic_test_dir):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_results_directory_absolute):

1:22 PM Changeset in webkit [104205] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r98010.

1:19 PM Changeset in webkit [104204] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97927.

1:11 PM Changeset in webkit [104203] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r97786.

1:04 PM Changeset in webkit [104202] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r97524.

1:01 PM Changeset in webkit [104201] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97502.

12:57 PM Changeset in webkit [104200] by Lucas Forschler
  • 10 edits in branches/safari-534.54-branch

Merged r97402.

12:53 PM Changeset in webkit [104199] by nduca@chromium.org
  • 4 edits
    3 adds in trunk/Source

[chromium] Add CCTimer class for the compositor
​https://bugs.webkit.org/show_bug.cgi?id=74769

Patch by Tien Ren Chen <​trchen@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Add a simple timer class for CCThread that the timered task can be
manually cancelled.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCTimer.cpp: Added.

(WebCore::CCTimerTask::CCTimerTask):
(WebCore::CCTimerTask::~CCTimerTask):
(WebCore::CCTimerTask::performTask):
(WebCore::CCTimer::CCTimer):
(WebCore::CCTimer::~CCTimer):
(WebCore::CCTimer::startOneShot):
(WebCore::CCTimer::stop):

  • platform/graphics/chromium/cc/CCTimer.h: Added.

(WebCore::CCTimerClient::~CCTimerClient):
(WebCore::CCTimer::isActive):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCTimerTest.cpp: Added.

(WebKitTests::CCTimerTest::CCTimerTest):
(WebKitTests::CCTimerTest::onTimerFired):
(WebKitTests::TEST_F):

12:48 PM Changeset in webkit [104198] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WK2: Safari fails to open a PostScript file in Preview from context menu
​https://bugs.webkit.org/show_bug.cgi?id=75643
<rdar://problem/9823430>

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData): Append ".pdf" to file name when converting data, as suggested file name is created for original MIME type.
12:44 PM Changeset in webkit [104197] by eric.carlson@apple.com
  • 10 edits
    24 adds in trunk

Implement temporal dimension portion of Media Fragments URI specification for video/audio
​https://bugs.webkit.org/show_bug.cgi?id=65838

Reviewed by Sam Weinig.

Source/WebCore:

Tests: media/media-fragments/TC0001-TC0009.html

media/media-fragments/TC0010-TC0019.html
media/media-fragments/TC0020-TC0029.html
media/media-fragments/TC0030-TC0039.html
media/media-fragments/TC0040-TC0049.html
media/media-fragments/TC0050-TC0059.html
media/media-fragments/TC0060-TC0069.html
media/media-fragments/TC0070-TC0079.html
media/media-fragments/TC0080-TC0089.html
media/media-fragments/TC0090-TC0099.html

  • CMakeLists.txt: Add fragment parser files.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_fragmentStartTime and m_fragmentEndTime.
(WebCore::HTMLMediaElement::setReadyState): Check for and parse a media fragment once readyState

reaches HAVE_METADATA, apply it once it reaches HAVE_CURRENT_DATA.

(WebCore::HTMLMediaElement::initialTime): Return the fragment start time if possible.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Pause if the time is >= the fragment

end time.

(WebCore::HTMLMediaElement::prepareMediaFragmentURI): Look for a temporal fragment.
(WebCore::HTMLMediaElement::applyMediaFragmentURI): Apply the fragment, if any.

  • html/HTMLMediaElement.h:
  • html/MediaFragmentURIParser.cpp: Added.

(WebCore::skipWhiteSpace):
(WebCore::collectDigits):
(WebCore::collectFraction):
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseFragments):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
(WebCore::MediaFragmentURIParser::parseNPTFragment):
(WebCore::MediaFragmentURIParser::parseNPTTime):

  • html/MediaFragmentURIParser.h: Added.

(WebCore::MediaFragmentURIParser::~MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::create):

LayoutTests:

  • media/media-fragments: Added.
  • media/media-fragments/TC0001-TC0009-expected.txt: Added.
  • media/media-fragments/TC0001-TC0009.html: Added.
  • media/media-fragments/TC0010-TC0019-expected.txt: Added.
  • media/media-fragments/TC0010-TC0019.html: Added.
  • media/media-fragments/TC0020-TC0029-expected.txt: Added.
  • media/media-fragments/TC0020-TC0029.html: Added.
  • media/media-fragments/TC0030-TC0039-expected.txt: Added.
  • media/media-fragments/TC0030-TC0039.html: Added.
  • media/media-fragments/TC0040-TC0049-expected.txt: Added.
  • media/media-fragments/TC0040-TC0049.html: Added.
  • media/media-fragments/TC0050-TC0059-expected.txt: Added.
  • media/media-fragments/TC0050-TC0059.html: Added.
  • media/media-fragments/TC0060-TC0069-expected.txt: Added.
  • media/media-fragments/TC0060-TC0069.html: Added.
  • media/media-fragments/TC0070-TC0079-expected.txt: Added.
  • media/media-fragments/TC0070-TC0079.html: Added.
  • media/media-fragments/TC0080-TC0089-expected.txt: Added.
  • media/media-fragments/TC0080-TC0089.html: Added.
  • media/media-fragments/TC0090-TC0099-expected.txt: Added.
  • media/media-fragments/TC0090-TC0099.html: Added.
  • media/media-fragments/media-fragments.js: Added.

(canplaythrough):
(setupNextTest):
(nextTestName):
(start):

12:44 PM WebKit Team edited by aestes@apple.com
(diff)
12:41 PM Changeset in webkit [104196] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[v8] Null pointer exception if a typed array constructor set to a primitive value.
​https://bugs.webkit.org/show_bug.cgi?id=75532

Make sure that V8ArrayBufferViewCustomScript.js does not throw exception.

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2012-01-05
Reviewed by Kenneth Russell.

  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned-expected.txt: Added.
  • LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned.html: Added.
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
12:28 PM Changeset in webkit [104195] by Adam Roben
  • 2 edits in trunk/Tools

Remove some unnecessary code from old-run-webkit-tests

Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
WebKitTestRunner.

Fixes <​http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
Windows

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:

(top level):
(openDumpTool):
Removed calls to setPathForRunningWebKitApp.

12:18 PM Changeset in webkit [104194] by Martin Robinson
  • 5 edits
    2 adds in trunk/Source/WebKit/gtk

[GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations
​https://bugs.webkit.org/show_bug.cgi?id=75519

Reviewed by Alejandro G. Castro.

Add an AcceleratedCompositingContext which will isolate all the different accelerated compositing
implementations from one another. For right now this just includes the Clutter version.

  • GNUmakefile.am: Add the new files to the source list.
  • WebCoreSupport/AcceleratedCompositingContext.h: Added.
  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added. Existing

clutter AC code has moved here.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::attachRootGraphicsLayer): Use the new AccleratedCompositingContext now
instead of calling into the WebView.
(WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization):Ditto.
(WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.

  • webkit/webkitwebview.cpp:

(webkit_web_view_size_allocate): Call in the ACContext.
(webkit_web_view_init): Initialize the ACContext.

  • webkit/webkitwebviewprivate.h: Add the ACContext as a private member.
12:04 PM Changeset in webkit [104193] by zeno.albisser@nokia.com
  • 22 edits
    13 adds in trunk

[Qt][WK2] Implement custom URL schemes defined in QML.
​https://bugs.webkit.org/show_bug.cgi?id=74931

.:

Add new classes to the export map.

Reviewed by Kenneth Rohde Christiansen.

  • Source/qtwebkit-export.map:

Source/WebKit/qt:

Make classes QQuickUrlSchemeDelegate, QQuickNetworkRequest
and QQuickNetworkReply accessible from QML.

Reviewed by Kenneth Rohde Christiansen.

  • declarative/experimental/experimental.pri:
  • declarative/experimental/plugin.cpp:
  • declarative/public.pri:

Source/WebKit2:

Allow creation of custom UrlSchemeDelegates from QML.
A UrlSchemeDelegate contains a handler signal that is triggered
when a url matching the defined scheme is requested.
To allow for this a derivation of QNetworkAccessManager
is necessary.
The request is then handled in QML/JS and a reply
is sent back from the UIProcess to the WebProcess.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/qt/QtNetworkReplyData.cpp: Added.

(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h: Added.
  • Shared/qt/QtNetworkRequestData.cpp: Added.

(WebKit::QtNetworkRequestData::QtNetworkRequestData):
(WebKit::QtNetworkRequestData::encode):
(WebKit::QtNetworkRequestData::decode):

  • Shared/qt/QtNetworkRequestData.h: Added.
  • Target.pri:
  • UIProcess/API/qt/qquicknetworkreply.cpp: Added.

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):

  • UIProcess/API/qt/qquicknetworkreply_p.h: Added.
  • UIProcess/API/qt/qquicknetworkrequest_p.h: Added.
  • UIProcess/API/qt/qquickurlschemedelegate.cpp: Added.

(QQuickUrlSchemeDelegate::QQuickUrlSchemeDelegate):
(QQuickUrlSchemeDelegate::scheme):
(QQuickUrlSchemeDelegate::setScheme):
(QQuickUrlSchemeDelegate::request):
(QQuickUrlSchemeDelegate::reply):

  • UIProcess/API/qt/qquickurlschemedelegate_p.h: Added.
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
(QQuickWebViewExperimental::invokeApplicationSchemeHandler):
(QQuickWebViewExperimental::sendApplicationSchemeReply):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleApplicationSchemeRequest):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::registerApplicationScheme):
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::registerApplicationScheme):
(WebKit::WebPage::receivedApplicationSchemeRequest):
(WebKit::WebPage::applicationSchemeReply):

  • WebProcess/qt/QtNetworkAccessManager.cpp: Added.

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
(WebKit::QtNetworkAccessManager::createRequest):
(WebKit::QtNetworkAccessManager::registerApplicationScheme):

  • WebProcess/qt/QtNetworkAccessManager.h: Added.
  • WebProcess/qt/QtNetworkReply.cpp: Added.

(WebKit::QtNetworkReply::QtNetworkReply):
(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::setReplyData):
(WebKit::QtNetworkReply::readData):
(WebKit::QtNetworkReply::bytesAvailable):
(WebKit::QtNetworkReply::setHeader):
(WebKit::QtNetworkReply::abort):
(WebKit::QtNetworkReply::close):
(WebKit::QtNetworkReply::setReadBufferSize):
(WebKit::QtNetworkReply::canReadLine):
(WebKit::QtNetworkReply::finalize):

  • WebProcess/qt/QtNetworkReply.h: Added.
  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

12:02 PM Changeset in webkit [104192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove style warning in GraphicsContext3DOpenGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=75466

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-05
Reviewed by Kenneth Russell.

Relocated some headers according to alphabetical order & modified indentation.
And used OwnArrayPtr to deal with character array.

No new tests required.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

11:55 AM Changeset in webkit [104191] by Adam Roben
  • 3 edits in trunk/Tools

Teach NRWT to use run-safari to open results.html on Apple's Windows port

NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
better, since we always want to open results.html using the user's build of WebKit, not
whatever their default browser is.

Fixes <​http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
for Apple's Windows port

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
an obsolete comment.

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_show_results_html_file): Updated expected results.

11:55 AM Changeset in webkit [104190] by Adam Roben
  • 2 edits in trunk/Tools

Prepend Safari.exe's path to the command-line passed to CreateProcess

Safari expects the first argument in the command-line to be the path to Safari.exe itself.
This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
was not including the path to Safari.exe in the command-line, so Safari was ignoring the
first argument that WebKitLauncherWin was trying to pass to it.

Fixes <​http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.

11:55 AM Changeset in webkit [104189] by Adam Roben
  • 2 edits in trunk/Tools

Stop using explicit memory management in WebKitLauncherWin

We now use stack-allocated STL objects instead.

Prep work for <​http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
Safari

Reviewed by Steve Falkenburg.

  • WebKitLauncherWin/WebKitLauncherWin.cpp:

(getStringValue):
(applePathFromRegistry):
(safariInstallDir):
(safariBrowserExe):
(_tWinMain):
Changed to use stack-allocated STL objects instead of malloc/free.

11:54 AM Changeset in webkit [104188] by Adam Roben
  • 7 edits
    1 copy
    7 adds in trunk

Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Fixes <​http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and

ImageDiffLauncher, which I forgot to add to this .sln when that project was created.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.

  • WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from

Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
the stub launcher.

  • WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
  • WebKitTestRunner/win/main.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

Source/WebKit/win:

Add WebKitTestRunnerLauncher to WebKit.sln.

It builds just after WebKitTestRunner.

  • WebKit.vcproj/WebKit.sln:
11:53 AM Changeset in webkit [104187] by Adam Roben
  • 8 edits
    8 adds in trunk

Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Safari and Apple Application Support directories to PATH before
trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.

Part of <​http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner

Reviewed by Steve Falkenburg.

Tools:

  • DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,

which I forgot to add to this .sln when that project was created.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:

Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.

  • DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp:

(modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
Safari's directory to PATH so that SafariTheme.dll can be found.

(main):
(wWinMain):
Changed to use the new modifyPath function.

Source/WebKit/win:

Add DumpRenderTreeLauncher to WebKit.sln.

It builds just after DumpRenderTree.

  • WebKit.vcproj/WebKit.sln:
11:46 AM Changeset in webkit [104186] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Fix debug build.

Reviewed by Oliver Hunt.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:35 AM Changeset in webkit [104185] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip file-reader-event-listener.html on qt and efl.

  • platform/efl/Skipped:
  • platform/qt/Skipped:
11:32 AM Changeset in webkit [104184] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

push/shift fifo may consume excessive memory
​https://bugs.webkit.org/show_bug.cgi?id=75610

Reviewed by Sam Weinig.

Array object commonly store data in a vector, consisting of a portion that is
in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to shift with grow the pre-capacity, and
the current algorithm for increaseVectorLength (used by push, or Put) will
never shrink the pre-capacity, so a push/shift fifo may consume an inordinate
amount of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::JSArray::increaseVectorLength):

  • If m_indexBias is non-zero, decay it over time.
11:24 AM Changeset in webkit [104183] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Crash due to reparenting of relpositioned object under anonymous block
​https://bugs.webkit.org/show_bug.cgi?id=70848

The associated test case creates a condition where a relative
positioned renderer is a descendant of an anonymous block for a
table column. The anonymous block is the containingBlock() for the
relpositioned renderer. Removal of a div causes the anonymous blocks to
be merged, and the renderer becomes a descendant of a different block.
Since the new containingBlock() has an empty positionedObject list,
the relpositioned renderer does not get layout after being dirtied.

This patch changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous
block itself. It also adds an ASSERT to insertPositionedObject()
to flag any other cases where something is trying to create a
positioned object list on an anonymous block.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

LayoutTests: Crash due to reparenting of relpositioned object in table
​https://bugs.webkit.org/show_bug.cgi?id=70848

Adding test that exercises the crash condition in bug 70848.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added
  • fast/css/relative-position-replaced-in-table-display-crash.html: Added
11:15 AM Changeset in webkit [104182] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed WK75633 and updated expectations

  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [104181] by psolanki@apple.com
  • 4 edits in trunk/Source/WebKit/mac

WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions
​https://bugs.webkit.org/show_bug.cgi?id=75586

Reviewed by Alexey Proskuryakov.

We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView
userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function,
_userAgentString that returns a WTF::String to make this call faster.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

  • WebView/WebView.mm:

(-[WebView _userAgentString]):
(-[WebView userAgentForURL:]):

  • WebView/WebViewInternal.h:
10:59 AM Changeset in webkit [104180] by jianli@chromium.org
  • 3 edits
    2 adds in trunk

FileReader needs addEventListener
​https://bugs.webkit.org/show_bug.cgi?id=42723

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/file-reader-event-listener.html

  • fileapi/FileReader.idl:

LayoutTests:

  • fast/files/file-reader-event-listener-expected.txt: Added.
  • fast/files/file-reader-event-listener.html: Added.
10:50 AM WebKit Team edited by adele@apple.com
(diff)
10:38 AM Changeset in webkit [104179] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove deprecated calls from CookieJarCFNet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=68958

Reviewed by Sam Weinig.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):

10:36 AM Changeset in webkit [104178] by Dimitri Glazkov
  • 5 edits
    1 delete in branches/chromium/912

Revert 91125 - 2011-07-15 Rob Buis <​rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
​https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:

TBR=​rwlbuis@webkit.org
Review URL: ​http://codereview.chromium.org/9116011

10:28 AM Changeset in webkit [104177] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, tighted up the expectations for some perf tests.

  • platform/chromium/test_expectations.txt:
10:26 AM Changeset in webkit [104176] by enne@google.com
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Create unit tests for CCTiledLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=75557

Reviewed by James Robinson.

Add some quad generation tests for tiled layers.

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Added.

(WebCore::createLayer):
(WebCore::TEST):
(WebCore::completelyContains):
(WebCore::getQuads):
(WebCore::verifyQuadsExactlyCoverRect):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):

10:19 AM WebKit Team edited by dgrogan@chromium.org
(diff)
10:18 AM Changeset in webkit [104175] by Dimitri Glazkov
  • 5 edits
    6 copies
    2 deletes in branches/chromium/963

Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken
​https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg

svg/custom/subpaths-moveto-only-rendering.svg

  • platform/graphics/cg/PathCG.cpp:

(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <​schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
  • svg/custom/path-moveto-only-rendering.svg: Added.
  • svg/custom/subpaths-moveto-only-rendering.svg: Added.
  • svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
  • platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/9111020

10:16 AM Changeset in webkit [104174] by fsamuel@chromium.org
  • 35 edits in trunk

Move scalePageBy from eventSender to window.internals
​https://bugs.webkit.org/show_bug.cgi?id=64512

Reviewed by Simon Fraser.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Added setPageScaleFactor to window.internals.
Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
to match the webkit style.

  • testing/Internals.cpp:

(WebCore::Internals::pageScaleFactor):
(WebCore::Internals::setPageScaleFactor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Updated layout tests to use window.internals.setPageScaleFactor.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/scaling/tiled-layer-recursion.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
10:08 AM Changeset in webkit [104173] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

[Skia Mac] Rounded bezel style button needs one more local graphics context to scale
​https://bugs.webkit.org/show_bug.cgi?id=75623
​http://code.google.com/p/chromium/issues/detail?id=108749

In paintButton(), the local context is set up first, and later the context is
scaled if there's a zoomFactor. Skia creates the CoreGraphics context to draw the
button into without that scale factor. To fix this, another local context is added
after the parameter context scale, before the button draw. The first local context
is still required to restore the parameter context state.

Reviewed by Stephen White.

  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::paintButton):

9:52 AM Changeset in webkit [104172] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: Chromium expectations update.
Filed ​http://crbug.com/109276 and ignored appcache failure on Linux.
Failures seem intermittent in appcache so might need to ignore more tests.

  • platform/chromium/test_expectations.txt:
9:49 AM Changeset in webkit [104171] by mitz@apple.com
  • 4 edits in trunk/Source/ThirdParty

Made Debug/Release builds of gtest build only for the active architecture.

Reviewed by Dave Kilzer.

  • gtest/xcode/Config/DebugProject.xcconfig:
  • gtest/xcode/Config/ProductionProject.xcconfig:
  • gtest/xcode/Config/ReleaseProject.xcconfig:
9:31 AM Changeset in webkit [104170] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expectations for svg/carto.net/button.svg can be updated
​https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed Chromium test expectations update.

Patch by Stephen Chenney <​schenney@chromium.org> on 2012-01-05

  • platform/chromium-linux-x86/svg/carto.net: Removed.
  • platform/chromium/test_expectations.txt:
9:29 AM Changeset in webkit [104169] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for background is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75539

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for background.

Test: fast/css/getComputedStyle/getComputedStyle-background-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.
9:02 AM Changeset in webkit [104168] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Pass WebFrame instead of WebCore::Frame to the WebKit2 specific FrameNetworkingContext
​https://bugs.webkit.org/show_bug.cgi?id=75550

Make the WebKit2 FrameNetworkingContext implementation store the
WebFrame instead of the WebCore::Frame as this is needed for the Qt
port to implement a.o. HTTP autentication and SSL support.

As the WebFrameNetworkingContext is partly shared across all WebKit2 ports,
all port specific files have been modified.

For the Qt implementation of FrameNetworkingContext, we also set a
property to the originatingObject for the page ID. We also switch to
using an OwnPtr instead of a raw C++ pointer for the
m_originatingObject member.

Based on original patch by Peter Hartmann.

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

8:45 AM Changeset in webkit [104167] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Never enable FontConfig on Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=75616

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-05
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
8:39 AM Changeset in webkit [104166] by hclam@chromium.org
  • 7 edits in trunk/Tools

Unreviewed, rolling out r104159.
​http://trac.webkit.org/changeset/104159
​https://bugs.webkit.org/show_bug.cgi?id=75590

Chromium port GPU tests cannot be executed.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(get):
(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.assert_port_works):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._port_name_from_arguments_and_options):
(PortFactory):
(PortFactory._get_kwargs):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_google_chrome.names):
(FactoryTest.test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GetGoogleChromePort):
(GetGoogleChromePort.GoogleChromeLinux32Port):
(GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
(GetGoogleChromePort.GoogleChromeLinux64Port):
(GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
(GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
(GetGoogleChromePort.GoogleChromeMacPort):
(GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
(GetGoogleChromePort.GoogleChromeWinPort):
(GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
(GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(GetGoogleChromePortTest._verify_baseline_path):
(GetGoogleChromePortTest._verify_expectations_overrides):

8:00 AM Changeset in webkit [104165] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

DOM Attribute tests on Dromaeo spends 2.7% of time in hasSelectorForAttribute
​https://bugs.webkit.org/show_bug.cgi?id=75569

Reviewed by Andreas Kling.

Check needsStyleRecalc() first to avoid unnecessary hash lookups.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

7:59 AM Changeset in webkit [104164] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Give

media/media-blocked-by-beforeload.html another chance on the bot
after its update in r103509.

7:47 AM Changeset in webkit [104163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Replace alloca to C++ new placement.
​https://bugs.webkit.org/show_bug.cgi?id=72017

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2012-01-05
Reviewed by Andreas Kling.

Replaces alloca to C++ new placement as it is not very portable.
It allows to skip checking of memory allocation as new never returns NULL.
According to Edje's documentation type of val (member of Edje_Message_Float_Set)
is double so I changed it to avoid undefined behaviour.

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::updateThumbPositionAndProportion):

7:37 AM Changeset in webkit [104162] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html made the next test fail

Unreviewed gardening. One more attempt to paint the Qt-WK2 bot green.

  • platform/qt-wk2/Skipped:
7:22 AM Changeset in webkit [104161] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium/test_expectations.txt:
7:01 AM Changeset in webkit [104160] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Invalidation request for ewk_view can be discarded without rendering.
​https://bugs.webkit.org/show_bug.cgi?id=71564

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

As ewk_view discards a queue for invalidation requests
as soon as it proceeds the repaint step, the newly produced invalidation requests
from ewk_view_layout_if_needed_recursive API can be discarded
and unpainted dirty area can occur.
As this issue is just caused by use of flush API in repaint step,
(internal API) ewk_view_repaints_get is replaced with ewk_view_repaints_pop
in order to make sure that old invalidation requests are removed from queue.
And in addition to that, ewk_view_repaint_add is modified
in order to let queue of invalidation requests keep a proper size.
As a result flush API won't be used for the repaint step.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_repaint_add):
(_ewk_view_smart_calculate):
(ewk_view_repaints_pop):

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_repaints_process):

7:01 AM Changeset in webkit [104159] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up port factory methods
​https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(_port_name_from_arguments_and_options):
(get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(test_google_chrome):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(_verify_baseline_path):

6:59 AM Changeset in webkit [104158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove duplicate file references from WebCore.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=75581

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-05
Reviewed by Andreas Kling.

Many generated DOMSVG files had two references.

In platform/graphics, there was two arm directory
with the same files related to ARM Neon.

  • WebCore.xcodeproj/project.pbxproj:
6:59 AM Changeset in webkit [104157] by Adam Roben
  • 6 edits
    1 copy
    8 adds in trunk

Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <​http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffCommon.vsprops:

Changed to build ImageDiff.dll instead of ImageDiff.exe.

  • DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from

Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.

  • DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
  • DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
  • DumpRenderTree/win/ImageDiffWin.cpp: Added.

(dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
to main.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(main):
(wWinMain):
Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
stub launcher acts as a console program and calls a console version of
dllLauncherEntryPoint.

Source/WebKit/win:

Add ImageDiffLauncher to WebKit.sln

It builds just after ImageDiff.

  • WebKit.vcproj/WebKit.sln:
6:58 AM Changeset in webkit [104156] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Implement QQuickWebView::inputMethodQuery

Reviewed by Simon Hausmann.

Implement the current Qt5 queries of inputMethodQuery.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • UIProcess/API/qt/qquickwebview_p.h:
6:57 AM Changeset in webkit [104155] by Adam Roben
  • 7 edits
    1 copy
    7 adds in trunk

Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found.

Fixes <​http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • MiniBrowser/MiniBrowser.vcproj:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:

Changed to build MiniBrowser.dll instead of MiniBrowser.exe.

  • MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
  • MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj

but changed to build the stub launcher.

  • MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since

it needs to be compiled into the .exe instead of the .dll.
(DllMain): Added. We use this to store the DLL's HINSTANCE.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
DLLLauncherMain code.

  • win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser

to here.

Source/WebKit/win:

Add MiniBrowserLauncher to WebKit.sln

It builds just after MiniBrowser.

  • WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
6:56 AM Changeset in webkit [104154] by Adam Roben
  • 2 edits in trunk/Tools

Make WinLauncher's window frame respond to clicks/drags again

Fixes <​http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
bar when Aero is disabled

Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp:

(WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
Also removed an unnecessary "break" keyword.

6:52 AM Changeset in webkit [104153] by Adam Roben
  • 6 edits
    1 copy
    12 adds in trunk

Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code

This allows us to add the Apple Application Support directory to PATH before trying to load
WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
should use this mechanism.

Fixes <​http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
double-clicked

Reviewed by Anders Carlsson.

Tools:

  • WinLauncher/WinLauncher.cpp: Removed InitInstance.

(DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
done by the now-removed InitInstance function.
(dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
calls. Merged code from InitInstance into this function, and change to use the global hInst
variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
function, which corresponds to WinLauncher.exe.

  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherCommon.vsprops:

Changed to build WinLauncher.dll instead of WinLauncher.exe.

  • WinLauncher/WinLauncherLauncher.rc: Added.
  • WinLauncher/WinLauncherLauncherResource.h: Added.

This just references the WinLauncher.ico file to set the application icon (though it looks
like that's a default icon).

  • WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj

but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.

  • WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
  • WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
  • WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
  • WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
  • WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
  • win/DLLLauncher/DLLLauncherMain.cpp: Added.

(enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
program if it detects heap corruption.
(getStringValue): Helper function to read a string value from the registry.
(applePathFromRegistry): Helper function to read the InstallDir for a given Apple
application from the registry.
(appleApplicationSupportDirectory): Helper function to return the path to the Apple
Application Support directory.
(copyEnvironmentVariable): Helper function to copy an environment variable's value.
(prependPath): Helper function to prepend a directory to the PATH.
(fatalError): Helper function to display an error to the user.
(wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
dllLauncherEntryPoint function.

Source/WebKit/win:

Add WinLauncherLauncher to WebKit.sln

It builds just after WinLauncher.

  • WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
6:40 AM Changeset in webkit [104152] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Improve SelectorChecker::determineSelectorScopes
​https://bugs.webkit.org/show_bug.cgi?id=75619

Reviewed by Andreas Kling.

SelectorChecker::determineSelectorScopes currently searches to the end of the selector chain and
then sees if the last one is suitable to be a scope. A better algorithm will find a scope from
anywhere in the chain.

With this patch we search the whole chain for potential scopes. We now prefer id scopes
over class scopes. Scopes can be found for rules using sibling selectors too.

On both engadget.com and nytimes.com, we can now skip one more full style recalc due to
the improved stylesheet analysis.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineSelectorScopes):

6:38 AM Changeset in webkit [104151] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Use the default screen in PlatformScreenGtk methods when they are called with a NULL widget
​https://bugs.webkit.org/show_bug.cgi?id=75620

Reviewed by Philippe Normand.

We are currently retuning an empty rectangle for
screenRect/screenAvailableRect and 0 for getVisual.

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

6:12 AM Changeset in webkit [104150] by hclam@chromium.org
  • 2 edits
    6 deletes in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:02 AM Changeset in webkit [104149] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebSettings::setAcceleratedDrawingEnabled from public API.
​https://bugs.webkit.org/show_bug.cgi?id=74125

Patch by David Reveman <​reveman@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Remove setAcceleratedDrawingEnabled method from WebSettings class.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
6:02 AM Changeset in webkit [104148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Expected test failures after Skia is rolled to 2918
​https://bugs.webkit.org/show_bug.cgi?id=75019

Fixed now that Skia has rolled past r2936.

Unreviewed Chromium port test expectations update.

Patch by Stephen Chenney <​schenney@chromium.org> on 2012-01-05

  • platform/chromium/test_expectations.txt:
5:38 AM Changeset in webkit [104147] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix.

Adding missing const_cast<> to fix compilation failures due to r104143.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

5:27 AM Changeset in webkit [104146] by abarth@webkit.org
  • 5 edits
    3 adds in trunk/Source/WebCore

Move Gamepad declarations from Navigator.idl into Modules/gamepad
​https://bugs.webkit.org/show_bug.cgi?id=75559

Reviewed by Eric Seidel.

This patch moves the gamepad-related declarations in Navigator.idl into
Modules/gamepad. The next step is to move the state into
Modules/gamepad as well.

  • Modules/gamepad/NavigatorGamepad.cpp: Added.

(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::~NavigatorGamepad):
(WebCore::NavigatorGamepad::webkitGamepads):

  • Modules/gamepad/NavigatorGamepad.h: Added.
  • Modules/gamepad/NavigatorGamepad.idl: Added.
  • WebCore.gypi:
  • page/Navigator.cpp:

(WebCore::Navigator::gamepads):

  • page/Navigator.h:
  • page/Navigator.idl:
5:04 AM Changeset in webkit [104145] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=75248

Reviewed by Gustavo Noronha Silva.

It uses the page zoom factor unconditionally for now.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init): Add WebKitWebView:zoom-level
property.
(webkit_web_view_set_zoom_level): Set current zoom level.
(webkit_web_view_get_zoom_level): Get current zoom level.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewZoomLevel):
(beforeAll):

4:55 AM Changeset in webkit [104144] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle for border-image is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75347

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-color.

fast/css/getComputedStyle/computed-style-border-image.html was extended to cover the
new feature.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values for border-image.

  • fast/css/getComputedStyle/computed-style-border-image-expected.txt:
  • fast/css/getComputedStyle/computed-style-border-image.html:
4:54 AM Changeset in webkit [104143] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add a SSE2 optimized function zvmul in VectorMatch
​https://bugs.webkit.org/show_bug.cgi?id=74842

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

Use zvmul in FFTFrameFFMPEG.cpp::multiply() and FFTFrameMac.cpp::multiply().

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

  • platform/audio/VectorMath.h:
  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:

(WebCore::FFTFrame::multiply):

  • platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::multiply):

4:51 AM Changeset in webkit [104142] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Build fix for Chromium Mac Clang build.

Push using namespace WTF to .cpp file from .h file.

  • platform/text/TextCodecASCIIFastPath.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF8.cpp:
4:50 AM Changeset in webkit [104141] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2]REGRESSION(r104068): It made editing/pasteboard/copy-in-password-field.html fail
​https://bugs.webkit.org/show_bug.cgi?id=75615

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip editing/pasteboard/copy-in-password-field.html to paint the bot green.
4:42 AM WebKit Team edited by kubo@profusion.mobi
Add myself to the list of committers (diff)
4:23 AM Changeset in webkit [104140] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebKit adds vertical paddings and borders to the fixed width of CSS tables
​https://bugs.webkit.org/show_bug.cgi?id=74955

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-01-05
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/css-table-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

Changed the width calculation for CSS tables to take into account horizontal
paddings and borders instead of vertical paddings and borders.

LayoutTests:

Added tests to check that the fixed width style is applied correctly to
CSS tables with respect to table paddings and borders.

  • fast/table/css-table-width-expected.txt: Added.
  • fast/table/css-table-width.html: Added.
  • fast/table/script-tests/css-table-width.js: Added.

(computeCSSTableOffsetWidth):
(computeCSSTableOffsetHeight):
(computeCSSTableProperty):

4:22 AM Changeset in webkit [104139] by peter@chromium.org
  • 7 edits
    4 adds in trunk/Source

[Chromium] Upstream the RenderTheme and ScrollbarTheme for Android
​https://bugs.webkit.org/show_bug.cgi?id=74614

Reviewed by Adam Barth.

Source/WebCore:

Upstream the RenderTheme and ScrollbarTheme for Android. These are
mostly derived from their Linux variants.

RenderThemeChromiumAndroid inherits from RenderThemeChromiumLinux and
only overrides the three methods which have different behavior.
Scrollbars will be drawn in the threaded compositor for Android (which
will be upstreamed later), but for increased layout test parity we'll
match Chromium-Linux.

No new tests. This code will be exercised by existing layout tests, and
by manually verifying that theme parts render as expected.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Added.

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumAndroid.cpp: Added.

(WebCore::RenderThemeChromiumAndroid::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumAndroid::~RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumAndroid.h: Added.
  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

4:09 AM Changeset in webkit [104138] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new failing test.

  • platform/qt/Skipped:
3:40 AM Changeset in webkit [104137] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose Fixed Position Layout to WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=75556

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::shouldLayoutFixedElementsRelativeToFrame):
(WebKit::WebViewImpl::setShouldLayoutFixedElementsRelativeToFrame):

  • src/WebViewImpl.h:
3:33 AM Changeset in webkit [104136] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
​https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Zoltan Herczeg.

Buildfix after r104120.

  • runtime/JSArray.cpp: Remove useless asserts, baecause unsigned expression >= 0 is always true

(JSC::JSArray::unshiftCount):

3:24 AM Changeset in webkit [104135] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r104134.

  • wtf/Assertions.cpp:
3:06 AM Changeset in webkit [104134] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed gardening after r75605.

Rubber stamped by NOBODY Csaba Osztrogonác.

  • wtf/Assertions.cpp:
2:57 AM Changeset in webkit [104133] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Source/WebCore: Fix potential superlinear runtime of multiple indirect adjenceny combinators.
​https://bugs.webkit.org/show_bug.cgi?id=75083

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-01-05
Reviewed by Antti Koivisto.

A sequence of indirect adjencency combinator such as "li ~ li ~ la" could with the
former algorithm potentially do an quadratic number of element matches.
The recursive matching algorithm now detects cases where all siblings have
failed one indirect sibling match and fails the entire selector.

Test: perf/nested-combined-selectors.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Return SelectorFailsAllSiblings when
all siblings have failed a selector component.

  • css/SelectorChecker.h: Add SelectorFailsAllSiblings enum value

LayoutTests: Test of styling performance of selectors with multiple indirect combinators

​https://bugs.webkit.org/show_bug.cgi?id=75083

Reviewed by Antti Koivisto.

  • perf/nested-combined-selectors.html: Added.

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-01-05

2:56 AM Changeset in webkit [104132] by haraken@chromium.org
  • 4 edits in trunk/Tools

prepare-ChangeLog cannot parse python code that nests classes and defs
​https://bugs.webkit.org/show_bug.cgi?id=75524

Reviewed by Ryosuke Niwa.

This patch fixes the python parser of prepare-ChangeLog so that it can parse
python code that nests classes and defs, like this:

class C:

pass
def f():

pass

pass

Also, this patch fixes the python parser so that it inserts a dummy line
at the end of the file to pop out all popped scopes.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_python):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:

Added test cases that nest classes and defs.
(func7):
(func7.func8):
(func7.func8.func9):
(Class2):
(Class2.Class3):
(Class2.Class3.Class4):
(Class5):
(Class5.func10):
(Class5.func11):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2:20 AM Changeset in webkit [104131] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

InspectorStyleSheet: Avoid cloning CSSRuleLists.
<​http://webkit.org/b/75603>

Reviewed by Ryosuke Niwa.

Don't filter out @charset rules from CSSRuleLists. This was forcing us to clone
the stylesheet rule list, and is unnecessary since InspectorStyleSheet disregards
any rule that isn't either a style rule or a rule with an internal rule list.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

Don't pass omitCharsetRules=true to the CSSRuleList constructor.

2:18 AM Changeset in webkit [104130] by kling@webkit.org
  • 13 edits in trunk/Source/WebCore

Make elements with attributes smaller by eliminating the ref count in NamedNodeMap.
<​http://webkit.org/b/75068>

Reviewed by Antti Koivisto.

Remove NamedNodeMap's inheritance from RefCounted and forward the ref()/deref()
calls to its owner Element, effectively reducing the size of an element that has
attributes by 4 bytes.

This reduces memory consumption by 311 kB when viewing the full HTML5 spec.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):

Added. Forwards the operation to m_element. Only ever used by the DOM wrappers.

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):

  • dom/DocumentType.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributeMap):

  • dom/Element.h:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::takeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

Store NamedNodeMap in OwnPtr/PassOwnPtr, rather than RefPtr/PassRefPtr.

2:08 AM Changeset in webkit [104129] by Carlos Garcia Campos
  • 10 edits in trunk

[GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=75433

Reviewed by Martin Robinson.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail): Use webkit_web_view_replace_content().
(webkitWebViewLoadChanged): Do not emit load-changed signal when
replacing content.
(webkitWebViewLoadFailed): Do not emit load-failed signal when
replacing content.
(webkitWebViewSetEstimatedLoadProgress): Do not emit
notify::estimated-load-progress signal when replacing content.
(webkit_web_view_replace_content):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(beforeAll):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(replaceContentTitleChangedCallback):
(replaceContentLoadCallback):
(testWebViewReplaceContent):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::replaceContent):

  • UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewLoadFailed): Reset the progress bar when load fails.
(browserWindowConstructed): Connect to load-failed signal.

2:03 AM Changeset in webkit [104128] by noel.gordon@gmail.com
  • 2 edits
    3 moves
    4 adds in trunk/LayoutTests

[chromium] MAC: update expectations for CSS3 linear gradient tests
​https://bugs.webkit.org/show_bug.cgi?id=55745

Reviewed by Stephen White.

  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stop-units-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-color-stops-expected.png.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png.
  • platform/chromium/test_expectations.txt:
1:38 AM Changeset in webkit [104127] by benjamin@webkit.org
  • 12 edits
    3 adds in trunk/Source

Improve charactersAreAllASCII() to compare multiple characters at a time
​https://bugs.webkit.org/show_bug.cgi?id=74063

Reviewed by Darin Adler.

Source/JavaScriptCore:

A new header ASCIIFastPath.h contains the functions related to
the detection of ASCII by using machine words. Part of it comes from
WebCore's TextCodecASCIIFastPath.h.

The function charactersAreAllASCII() is moved to TextCodecASCIIFastPath.h
and is implemented with computer word comparison.
The gain over the previous implementation of charactersAreAllASCII() is of
the order of how many comparison are avoided (4x, 8x, 16x depending on the
format and the CPU type).

(WTF::isAlignedToMachineWord):
(WTF::alignToMachineWord):
(WTF::isAllASCII):
(WTF::charactersAreAllASCII):

  • wtf/text/WTFString.h:
  • wtf/wtf.pro:

Source/JavaScriptGlue:

Add forwarding header for ASCIIFastPath.h.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.

Source/WebCore:

Move some part of TextCodecASCIIFastPath.h to WTF in ASCIIFastPath.h.
The function isAllASCII() is changed to the template version which now works
with both LChar and UChar.

  • ForwardingHeaders/wtf/text/ASCIIFastPath.h: Added.
  • platform/text/TextCodecASCIIFastPath.h:

(WebCore::copyASCIIMachineWord):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

1:29 AM Changeset in webkit [104126] by ericu@chromium.org
  • 19 edits
    1 delete in trunk

[fileapi] WebKitFlags should not be constructable per Directories & System spec
​https://bugs.webkit.org/show_bug.cgi?id=68916

Reviewed by Eric Seidel.

Source/WebCore:

Remove IDL for the object and all DOM references to it.

  • fileapi/WebKitFlags.idl: Removed.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl: Remove references to the JSC/V8 objects compiled from the IDL.
  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: (WebCore::getFlags):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: (WebCore::getFlags): Fix up build files.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore/CMakeLists.txt:
  • WebCore/CodeGenerators.pri:
  • WebCore/DerivedSources.cpp:
  • WebCore/DerivedSources.make:
  • WebCore/GNUmakefile.list.am:

LayoutTests:

Remove a test that constructed the object; add one that tests error-handling for non-object parameters while I'm in there.

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:

Remove a special case reference to the global WebKitFlags constructor.

  • fast/dom/script-tests/prototype-inheritance.js:
1:16 AM Changeset in webkit [104125] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<​http://webkit.org/b/75606> [Mac] WTF logging functions should output to both stderr and ASL

We should always log to both ASL and stderr on platforms where this won't result in launchd
duplicating the messages.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_common):

1:16 AM Changeset in webkit [104124] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<​http://webkit.org/b/75605> WTF logging functions should call vprintf_stderr_common only once per line

Several of the WTF logging functions make multiple calls to vprintf_stderr_common to output a
single line of text. This results in strangely formatted output if vprintf_stderr_common is
retargeted to an output device that is message-oriented (such as ASL) rather than stream-oriented
like stderr.

Reviewed by Dan Bernstein.

  • wtf/Assertions.cpp:

(vprintf_stderr_with_prefix): Helper function to prepend a given prefix on to the given format
string before handing it off to vprintf_stderr_common. This requires disabling warnings about
calling a printf-like function with a non-literal format string for this piece of code. It's
safe in this particular case as vprintf_stderr_with_prefix is only ever given a literal prefix.
(vprintf_stderr_with_trailing_newline): Helper function to append a trailling newline on to the
given format string if one does not already exist. It requires the same treatment with regards
to the non-literal format string warning.
(WTFReportAssertionFailureWithMessage): Switch to using vprintf_stderr_with_prefix.
(WTFReportBacktrace): Switch from calling fprintf directly to using fprintf_stderr_common.
(WTFReportFatalError): Switch to using vprintf_stderr_with_prefix.
(WTFReportError): Ditto.
(WTFLog): Switch to using vprintf_stderr_with_trailing_newline.
(WTFLogVerbose): Ditto.

12:54 AM WebKit Team edited by pfeldman@chromium.org
(diff)
12:53 AM WebKit Team edited by pfeldman@chromium.org
(diff)
12:51 AM Changeset in webkit [104123] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash due to first-letter block processing
​https://bugs.webkit.org/show_bug.cgi?id=74009

Source/WebCore:

Fixing the way updateFirstLetter() finds the remaining text fragment
for a given first-letter. Previously this was unreliable in some
circumstances.

This patch provides a reliable mechanism to identify the remaining
text by storing first-letter to remaining text associations in a
hash map, managed by methods in RenderBoxModelObject.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter)

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::setFirstLetterRemainingText): Added
(WebCore::RenderBoxModelObject::firstLetterRemainingText): Added

LayoutTests:

Test for crashing condition in 74009.

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-01-05
Reviewed by David Hyatt.

  • fast/css/first-letter-inline-flow-split-table-crash-expected.txt: Added
  • fast/css/first-letter-inline-flow-split-table-crash.html: Added
12:51 AM Changeset in webkit [104122] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[WK2][EFL] creating dummy functions for Download class on Efl port.
​https://bugs.webkit.org/show_bug.cgi?id=75246

dummy functions for Download class on Efl port

Patch by Keunsoon Lee <​keunsoon.lee@samsung.com> on 2012-01-05
Reviewed by Hajime Morita.

  • PlatformEfl.cmake: add new file to compile
  • WebProcess/Downloads/efl: Added.
  • WebProcess/Downloads/efl/DownloadEfl.cpp: Added.

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
(WebKit::Download::useCredential):
(WebKit::Download::continueWithoutCredential):
(WebKit::Download::cancelAuthenticationChallenge):

12:41 AM WebKit Team edited by ryuan.choi@samsung.com
(diff)
12:34 AM Changeset in webkit [104121] by mihnea@adobe.com
  • 6 edits
    2 adds in trunk

Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
​https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

Test: fast/regions/region-range-for-box-crash.html

This patch fixes 2 issues:

  1. When removing a region from a flow thread, we clear the region range information for boxes since

this information is accurate only after the regions are laid out.

  1. While the regions are invalidated (content of flow thread is not yet laid out in regions), the

functions that ask for properties of content in regions should bail out early.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::logicalWidthChangedInRegions):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderFlowThread.h:

LayoutTests: Crash in RenderFlowThread::getRegionRangeForBox.
​https://bugs.webkit.org/show_bug.cgi?id=74781

Reviewed by David Hyatt.

  • fast/regions/region-range-for-box-crash-expected.txt: Added.
  • fast/regions/region-range-for-box-crash.html: Added.
12:00 AM Changeset in webkit [104120] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

unshift/pop fifo may consume excessive memory
​https://bugs.webkit.org/show_bug.cgi?id=75588

Reviewed by Sam Weinig.

The Array object commonly store data in a vector, consisting of a portion that
is in use, a pre-capacity (m_indexBias) and a post-capacity (the delta between
m_length and m_vectorLength). Calls to pop with grow the post-capacity, and the
current algorithm for increasePrefixVectorLength (used by unshift) will never
stink the post-capacity, so a unshift/pop fifo may consume an inordinate amount
of memory, whilst having a relatively small active length.

  • runtime/JSArray.cpp:

(JSC::storageSize):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::SparseArrayValueMap::put):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::increaseVectorLength):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>)

(JSC::JSArray::unshiftCountSlowCase):

  • renamed from increaseVectorPrefixLength (this was a bad name, since it also moved the ArrayStorage header), rewritten.

(JSC::JSArray::shiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned

(JSC::JSArray::unshiftCount):

  • sizeof(JSValue) should be sizeof(WriteBarrier<Unknown>), count should be unsigned, increaseVectorPrefixLength renamed to unshiftCountSlowCase

(JSC::JSArray::sortNumeric):

  • runtime/JSArray.h:
    • Updated function declarations, m_indexBias should be unsigned.

Jan 4, 2012:

11:39 PM Changeset in webkit [104119] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<​http://webkit.org/b/75604> All instances of JSC::ArgumentsData appear to be leaked by JSC::Arguments

Since JSC::Arguments has an OwnPtr for a member it needs to override destroy
to ensure that the correct destructor is invoked. This is necessary because
JSCell subclasses all intentionally have non-virtual destructors.

Reviewed by Filip Pizlo.

  • runtime/Arguments.cpp:

(JSC::Arguments::destroy):

  • runtime/Arguments.h:
11:12 PM Changeset in webkit [104118] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty

Remove HEADER_SEARCH_PATHS from Production configurations for gtest

Reviewed by Mark Rowe.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Remove

HEADER_SEARCH_PATHS from Production configurations to match
changes made for Debug and Release configurations in r104091.

10:49 PM Changeset in webkit [104117] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 116031 to 116459.

  • DEPS:
8:59 PM Changeset in webkit [104116] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r104084.
​http://trac.webkit.org/changeset/104084
​https://bugs.webkit.org/show_bug.cgi?id=75600

Likely kills dom-perf benchmark in chromium
​http://build.chromium.org/f/chromium/perf/linux-
release/dom_perf/report.html?history=150&rev=116444 (Requested
by dslomov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-04

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicSubtreeNodeList::Caches::create):
(WebCore::DynamicSubtreeNodeList::Caches::reset):

  • dom/DynamicNodeList.h:
  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::itemTypeAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::parseMappedAttribute):

  • html/HTMLLabelElement.h:
8:19 PM Changeset in webkit [104115] by mitz@apple.com
  • 8 edits in trunk

Source/WebKit2: Allow WebProcess to launch a client process and become its first WebProcess.

This is the WebKit2 part of fixing <​http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach

Reviewed by Anders Carlsson.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Added a newline to stderr output.

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp:

(WebKit::EnvironmentVariables::preexistingProcessServiceNameKey): Added. Returns the name
of the environment variable that optionally tells a UI processs to look for a preexisting
web process instead of launching a new one.
(WebKit::EnvironmentVariables::preexistingProcessTypeKey): Added. Returns the name of the
environment variable that tells a UI process the type of the preexisting web process
indicated by the other variable.

  • UIProcess/Launcher/mac/EnvironmentVariables.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Changed to look for a preexisting web process if
the aforementioned environment variables are set and the preexisting process has not been
used yet.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Changed to look for the -client-executable command-line option,
and if present, launch the specified executable, setting variables in its environment that
tell it to use this preexisting web process, then wait for it to send a send right to its
listening port.

Tools: Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
start WebProcess under gdb and WebProcess will then run the client executable.

This is the Tools part of fixing <​http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(shouldTargetWebProcess): Added.
(determineShouldTargetWebProcess): Added. Checks for --target-web-process.
(execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
app using the -client-executable option if targeting the web process.

7:20 PM Changeset in webkit [104114] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Attempt Chromium build fix.

  • src/WorkerFileSystemCallbacksBridge.h:
7:08 PM Changeset in webkit [104113] by levin@chromium.org
  • 2 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

[chromium] FileSystem bridge needs threadsafe fixes and other clean-up.
​https://bugs.webkit.org/show_bug.cgi?id=74666

Reviewed by Dmitry Titov.

Tests for all of the fixes done in bugs related to 74666.

  • http/tests/workers/resources/open-database-sync.js: Removed.
  • http/tests/workers/resources/sync-operations.js: Added.

(removeAllInDirectorySync):
(onmessage):

  • http/tests/workers/terminate-during-sync-operation-expected.txt: Added.
  • http/tests/workers/terminate-during-sync-operation.html: Renamed from LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html-skipped.
  • platform/chromium/test_expectations.txt:
7:08 PM Changeset in webkit [104112] by levin@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Remove AllowCrossThreadAccess in WorkerFileSystemCallbacksBridge.
​https://bugs.webkit.org/show_bug.cgi?id=75579

Reviewed by Dmitry Titov.

This code doesn't have lifetime issues, but this change is
about getting rid of AllowCrossThreadAccess and getting rid of a leakRef.
This allows the code to follow a more common pattern and be more easily
verified as being correct.

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::MainThreadFileSystemCallbacks::createLeakedPtr):
(WebKit::MainThreadFileSystemCallbacks::MainThreadFileSystemCallbacks):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread):
(WebKit::WorkerFileSystemCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h:
7:08 PM Changeset in webkit [104111] by levin@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Make it safe to delete WorkerFileSystemContextObserver on any thread.
​https://bugs.webkit.org/show_bug.cgi?id=75573

Reviewed by Dmitry Titov.

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemContextObserver): Move the WorkerContextObserver
out of the WorkerFileSystemCallbacksBridge since an observer should be
destroyed on the WorkerContext thread. (Actually, it could be destroyed on either
thread if you are careful to make a certain method call on it while on the WorkerContext
thread but trying that is a more fragile pattern.)
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::stop): Factor out the clean up and make it
clear what the mutex is guarding.
(WebKit::WorkerFileSystemCallbacksBridge::cleanUpAfterCallback): Delete
the observer. Due to where this is called from, it is always called on the WorkerContext thread.
(WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread): Replace some code with
the cleanUpAfterCallback call.
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h: In addition to some comment clean ups and code factoring,

I made the desctructor private since no one should call it directly.

5:50 PM Changeset in webkit [104110] by eae@chromium.org
  • 1 edit
    2 deletes in branches/subpixellayout/Source/WebCore

Manual merge of GNUmakefile.list.am and a couple of files deleted on trunk.

5:50 PM Changeset in webkit [104109] by oliver@apple.com
  • 16 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Rollout r102743

5:36 PM Changeset in webkit [104108] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r97353.

5:22 PM Changeset in webkit [104107] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, accidentally turned off the JIT in previous commit. Turning
it back on.

  • wtf/Platform.h:
5:19 PM Changeset in webkit [104106] by jamesr@google.com
  • 12 edits in trunk/Source

[chromium] Remove chromium compositor support for unused zoomAnimatorTransform
​https://bugs.webkit.org/show_bug.cgi?id=75585

Reviewed by Kenneth Russell.

Source/WebCore:

Removes compositor support for zoomAnimatorTransform property. This code is unused and never was used.
Zoom animations are handled by adjusting the page scale factor and scroll offsets.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

5:18 PM Changeset in webkit [104105] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Changed "return" to "break" in some macrology I introduced in
​http://trac.webkit.org/changeset/104086. This is a benign change, as
"return" was technically correct for all uses of the macro.

Reviewed by Oliver Hunt.

  • dfg/DFGGraph.cpp:
  • wtf/Platform.h:
5:17 PM Changeset in webkit [104104] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch/Source/WebCore

Merged r97270.

5:13 PM Changeset in webkit [104103] by Lucas Forschler
  • 1 edit in branches/safari-534.54-branch/LayoutTests/ChangeLog

Merged r97181.

5:12 PM Changeset in webkit [104102] by kbr@google.com
  • 10 edits in trunk

Fix semantics of WEBKIT_WEBGL_lose_context
​https://bugs.webkit.org/show_bug.cgi?id=75053

Reviewed by James Robinson.

Source/WebCore:

Updated WEBGL_lose_context extension to match WebGL spec's
behavior:

  • loseContext() causes the context to be lost immediately, but the webglcontextlost event isn't dispatched until JavaScript returns.
  • restoreContext() may only be called once dispatch of the webglcontextlost event has completed, *and* if that event handler prevented the default behavior of the event.
  • restoreContext() performs its work asynchronously. The context is not restored until just before the webglcontextrestored event is dispatched.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::forceRestoreContext):
(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated context-lost and context-lost-restored tests to latest
versions in Khronos repository. Updated WebGLContextEvent.html to
match new semantics.

  • fast/canvas/webgl/WebGLContextEvent-expected.txt:
  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
5:11 PM Changeset in webkit [104101] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r97180.

5:04 PM Changeset in webkit [104100] by oliver@apple.com
  • 11 edits
    2 adds in branches/safari-534.54-branch

Merge r94457

5:01 PM Changeset in webkit [104099] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r97124.

5:00 PM Changeset in webkit [104098] by eae@chromium.org
  • 1985 edits
    835 copies
    200 deletes in branches/subpixellayout

Merging trunk changes up until 104084 into subpixel branch.

4:54 PM Changeset in webkit [104097] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r97114.

4:40 PM Changeset in webkit [104096] by Lucas Forschler
  • 6 edits
    12 copies in branches/safari-534.54-branch

Merged r97075.

4:39 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Update type casting. (diff)
4:35 PM Changeset in webkit [104095] by Lucas Forschler
  • 5 edits
    3 copies in branches/safari-534.54-branch

Merged r97074.

4:31 PM Changeset in webkit [104094] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

StructureStubInfo not reset when corresponding MethodCallLinkInfo is reset
​https://bugs.webkit.org/show_bug.cgi?id=75583

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally): Find the corresponding
StructureStubInfo and reset the appropriate JIT and
the StructureStubInfo itself when reseting a MethodCallLinkInfo.

4:29 PM Changeset in webkit [104093] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r96999.

4:19 PM Changeset in webkit [104092] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96984.

4:15 PM Changeset in webkit [104091] by ddkilzer@apple.com
  • 9 edits in trunk/Source/ThirdParty

TestWebKitAPI has issues due to FastMalloc incompatibility
<​http://webkit.org/b/66521>
<rdar://problem/10607911>

Reviewed by David Levin.

Original patch by Dmitry Lomov <​dslomov@google.com>.

This patch ensures that gtest uses the FastMalloc new and delete
operators that are defined in JavaScriptCore.

  • gtest/README.WebKit: Update with project changes.
  • gtest/include/gtest/internal/gtest-port.h: Import necessary

headers to use FastMalloc in gtest.

  • gtest/msvc/gtest-md.vcproj: Add include directories to find

WTF headers.

  • gtest/xcode/Config/DebugProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Debug builds.

  • gtest/xcode/Config/General.xcconfig: Define

HEADER_SEARCH_PATHS in terms of WEBCORE_PRIVATE_HEADERS_DIR.

  • gtest/xcode/Config/ProductionProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Production builds. This
overrides the value in ReleaseProject.xcconfig.

  • gtest/xcode/Config/ReleaseProject.xcconfig: Define

WEBCORE_PRIVATE_HEADERS_DIR for Release builds.

  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
  • Remove local HEADER_SEARCH_PATHS definitions.
  • Link to JavaScriptCore.framework when building gtest.framework.
4:10 PM Changeset in webkit [104090] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Invalid ASSERT() in DFGRepatch.cpp near line 385
​https://bugs.webkit.org/show_bug.cgi?id=75584

Reviewed by Filip Pizlo.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDProtoList): Fixed ASSERT to use ==.

3:55 PM Changeset in webkit [104089] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Remove a line for a test that no longer fails on the bots.

  • platform/chromium/test_expectations.txt:
3:45 PM Changeset in webkit [104088] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96868.

3:33 PM Changeset in webkit [104087] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96834.

3:13 PM Changeset in webkit [104086] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Incorrect use of DFG node reference counts when mutating the graph
​https://bugs.webkit.org/show_bug.cgi?id=75580
<rdar://problem/10644607>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Made deref(node) follow the pattern of ref(node), which it should have
to begin with.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGNode.h:

(JSC::DFG::Node::deref):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixupNode):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-array-length-dead-expected.txt: Added.
  • fast/js/dfg-array-length-dead.html: Added.
  • fast/js/script-tests/dfg-array-length-dead.js: Added.

(foo):

3:11 PM Changeset in webkit [104085] by eae@chromium.org
  • 18 edits in branches/subpixellayout/LayoutTests/platform/mac/editing/selection

Update selection expectations for mac to account for pixelSnapped later sizes.

3:08 PM Changeset in webkit [104084] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
​https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):

  • dom/DynamicNodeList.h:

(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.

  • dom/Node.h:
  • dom/NodeRareData.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLLabelElement.cpp:
  • html/HTMLLabelElement.h:
3:06 PM Changeset in webkit [104083] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96826.

2:59 PM Changeset in webkit [104082] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r96632.

2:56 PM Changeset in webkit [104081] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Revert unintentional changes to Element.cpp in r104068.

  • dom/Element.cpp:

(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):

2:55 PM Changeset in webkit [104080] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r96427.

2:47 PM Changeset in webkit [104079] by Lucas Forschler
  • 5 edits
    3 copies in branches/safari-534.54-branch

Merged r96260.

2:40 PM Changeset in webkit [104078] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95985.

2:37 PM Changeset in webkit [104077] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95959.

2:34 PM Changeset in webkit [104076] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95926.

2:30 PM Changeset in webkit [104075] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95924.

2:26 PM Changeset in webkit [104074] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Compile fix, rename libplatform.a to libwebkit_platform.a to avoid collision with nacl

Source/Platform:

  • Platform.gyp/Platform.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
2:24 PM Changeset in webkit [104073] by enne@google.com
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r104052.
​http://trac.webkit.org/changeset/104052
​https://bugs.webkit.org/show_bug.cgi?id=75574

Breaks win builder (Requested by enne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-04

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Removed.
2:22 PM Changeset in webkit [104072] by eae@chromium.org
  • 53 edits in branches/subpixellayout

Add pixelSnappedIntSize function and change layer size calculation to use it instead of expandedIntSize.

2:16 PM Changeset in webkit [104071] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r95857.

2:13 PM Changeset in webkit [104070] by Lucas Forschler
  • 8 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r95747.

2:09 PM Changeset in webkit [104069] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r95728.

2:05 PM Changeset in webkit [104068] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r92823): Background color not preserved when copying and pasting a table row
​https://bugs.webkit.org/show_bug.cgi?id=75330

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by the background color of the wrapping style overriding the background color
in a matched rule of a highest element to be serialized. Fixed the bug by removing the conflicting
background color prior to the merge.

Tests: editing/pasteboard/copy-element-with-conflicting-background-color-from-rule-expected.html

editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html

  • editing/EditingStyle.cpp:

(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):

LayoutTests:

Add a regression test.

  • editing/pasteboard/copy-element-with-conflicting-background-color-from-rule-expected.html: Added.
  • editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html: Added.
2:05 PM Changeset in webkit [104067] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Tools

Adding myself to committers list.

Unreviewed.

2:02 PM Changeset in webkit [104066] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm
​https://bugs.webkit.org/show_bug.cgi?id=75447

Reviewed by Brian Weinstein.

Resolve the ambiguity.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):

2:01 PM Changeset in webkit [104065] by Lucas Forschler
  • 1 edit in branches/safari-534.54-branch/Source/WebCore/svg/SVGDocumentExtensions.h

Remove executable bit from SVGDocumentExtensions.h

1:40 PM Changeset in webkit [104064] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed:[Chromium]Disable WebPageNewSerializeTest.CSSResources and WebPageNewSerializeTest.TestMHTMLEncoding.
​https://bugs.webkit.org/show_bug.cgi?id=75567

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::TEST_F):

12:43 PM Changeset in webkit [104063] by Lucas Forschler
  • 16 edits
    3 copies in branches/safari-534.54-branch

Merged r95671.

12:10 PM Changeset in webkit [104062] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r95497.

12:06 PM Changeset in webkit [104061] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-534.54-branch

Merged r95462.

12:03 PM Changeset in webkit [104060] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Analyze stylesheet scope to minimize style recalcs
​https://bugs.webkit.org/show_bug.cgi?id=75508

Reviewed by Dave Hyatt.

It is a relatively common pattern to use inline stylesheets in document body where all rules are scoped using descendant selector

<style>
#foo {...}
#foo div {...}
#foo .bar {...}
</style>

When this pattern is used it is also common that the rules only apply to elements that come after the style element.

When the set of active stylesheets changes we invalidate and recompute the entire document style. This is very expensive. We can
detect the case above and avoid the style recalc.

On engadget.com, this patch cuts the time spent in style recalcs to roughly half. There are further savings from reduced
relayouts. In total the engine CPU time used over the page load is reduced by ~10%.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectFeatures):

Refactor feature collection from constructor to a separate function.


(WebCore::CSSStyleSelector::appendAuthorStylesheets):

New function for non-destructively updating the style selector.


(WebCore::CSSStyleSelector::Features::clear):

Clear the features for another collection.


(WebCore::CSSStyleSelector::determineStylesheetSelectorScopes):

Find if all rules on a stylesheetare scoped to some set of ids and classes.


(WebCore::CSSStyleSelector::styleForDocument):

Add optional font selector argument. We updated the correct base style font on style selector construction but that is no longer sufficient
as font selector may be updated without reconstructing the style selector.


(WebCore::RuleSet::addRulesFromSheet):

Invalidate the matched declaration cache in case of new font-face rules.


  • css/CSSStyleSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineSelectorScopes):

Find if all rules on a selector list are scoped to some set of ids and classes.


  • css/SelectorChecker.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):

Pass the font selector, if exists, to styleForDocument so we always have the base font up to date.


(WebCore::Document::combineCSSFeatureFlags):
(WebCore::Document::resetCSSFeatureFlags):
(WebCore::Document::createStyleSelector):

Refactor css feature flag resetting to functions.


(WebCore::Document::removePendingSheet):

Use new PendingStylesheetCompleted flag when new stylesheets arrive.

(WebCore::Document::styleSelectorChanged):

Skip style recalc if it is not needed.

(WebCore::Document::collectActiveStylesheets):

Refactor collecting stylesheets to a separate function.


(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):

Determine the scopes and use hasElementWithId/getElementsByClassName to figure out if any scoped elements currently exist in the tree.


(WebCore::Document::analyzeStylesheetChange):

Figure out if we can update the style selector incrementally and if we can skip the style recalc.


(WebCore::Document::updateActiveStylesheets):

Renamed from recalcStyleSelector.
Invoke the new analysis functions.


  • dom/Document.h:
12:02 PM Changeset in webkit [104059] by Lucas Forschler
  • 8 edits
    15 copies in branches/safari-534.54-branch

Merged r95461.

11:58 AM Changeset in webkit [104058] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-534.54-branch

Merged r95440.

11:51 AM Changeset in webkit [104057] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch

Merged r95306.

11:47 AM Changeset in webkit [104056] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r95301.

11:44 AM Changeset in webkit [104055] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/LayoutTests

Merged r95126.

11:42 AM Changeset in webkit [104054] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95074.

11:38 AM Changeset in webkit [104053] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95071.

11:36 AM Changeset in webkit [104052] by enne@google.com
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Create unit tests for CCTiledLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=75557

Reviewed by James Robinson.

Add some quad generation tests for tiled layers.

  • WebKit.gypi:
  • tests/CCTiledLayerImplTest.cpp: Added.

(WebCore::createLayer):
(WebCore::TEST):
(WebCore::completelyContains):
(WebCore::getQuads):
(WebCore::verifyQuadsExactlyCoverRect):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):

11:35 AM Changeset in webkit [104051] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r95059.

11:25 AM Changeset in webkit [104050] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests

This reverts commit r103546.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):

11:24 AM Changeset in webkit [104049] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

First sentence is missing or clipped when printing a inline PDF
​https://bugs.webkit.org/show_bug.cgi?id=75514
<rdar://problem/10640680>

Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::headerHeight): (WebKit::WebPageProxy::footerHeight): (WebKit::WebPageProxy::drawHeader): (WebKit::WebPageProxy::drawFooter): Do not ask the client about headers and footers when printing a PDF.
11:08 AM Changeset in webkit [104048] by jamesr@google.com
  • 11 edits
    4 copies
    2 moves
    6 adds in trunk

[chromium] Move WebMimeRegistry and dependencies to Source/Platform
​https://bugs.webkit.org/show_bug.cgi?id=74583

Reviewed by Darin Fisher.

.:

Update .gitignore for Source/Platform/Platform.gyp/ generated project files.

  • .gitignore:

Source/Platform:

This creates a skeleton directory structure for the chromium WebKit platform API and moves WebMimeRegistry.h
along with its dependencies (WebString and WebCString) to their final location.

  • Platform.gyp/Platform.gyp: Added.
  • Platform.gypi: Added.
  • chromium/platform/WebCString.h: Copied from Source/WebKit/chromium/public/platform/WebCString.h.

(WebKit::WebCString::~WebCString):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::isEmpty):
(WebKit::WebCString::isNull):
(WebKit::WebCString::operator std::string):
(WebKit::WebCString::fromUTF16):
(WebKit::operator<):

  • chromium/platform/WebCommon.h: Copied from Source/WebKit/chromium/public/platform/WebCommon.h.
  • chromium/platform/WebMimeRegistry.h: Copied from Source/WebKit/chromium/public/platform/WebMimeRegistry.h.

(WebKit::WebMimeRegistry::~WebMimeRegistry):

  • chromium/platform/WebString.h: Copied from Source/WebKit/chromium/public/platform/WebString.h.

(WebKit::WebString::~WebString):
(WebKit::WebString::WebString):
(WebKit::WebString::operator=):
(WebKit::WebString::isEmpty):
(WebKit::WebString::isNull):
(WebKit::WebString::operator string16):
(WebKit::WebString::operator NullableString16):
(WebKit::WebString::fromUTF8):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/src/WebCString.cpp: Renamed from Source/WebKit/chromium/src/WebCString.cpp.

(WebKit::WebCString::compare):
(WebKit::WebCString::reset):
(WebKit::WebCString::assign):
(WebKit::WebCString::length):
(WebKit::WebCString::data):
(WebKit::WebCString::utf16):
(WebKit::WebCString::fromUTF16):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::operator WTF::CString):

  • chromium/src/WebString.cpp: Renamed from Source/WebKit/chromium/src/WebString.cpp.

(WebKit::WebString::reset):
(WebKit::WebString::assign):
(WebKit::WebString::length):
(WebKit::WebString::data):
(WebKit::WebString::utf8):
(WebKit::WebString::fromUTF8):
(WebKit::WebString::equals):
(WebKit::WebString::WebString):
(WebKit::WebString::operator=):
(WebKit::WebString::operator WTF::String):
(WebKit::WebString::operator WTF::AtomicString):

Source/WebKit/chromium:

public/platform/WebMimeRegistry.h is a temporary forwarding header to ease the transition. Once downstream
callers are updated to the new location this header can be removed.

WebString, WebCString, and WebCommon.h will remain in place as forwarding headers for users of the WebKit client
API.

  • WebKit.gyp:
  • public/platform/WebCString.h:
  • public/platform/WebCommon.h:
  • public/platform/WebMimeRegistry.h:
  • public/platform/WebString.h:

Tools:

Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

10:21 AM Changeset in webkit [104047] by igor.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Share fractional time code between AnimationBase and KeyframeAnimation
​https://bugs.webkit.org/show_bug.cgi?id=75549

Remove left over from changeset 104045.

Unreviewed trivial fix.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):

9:51 AM Changeset in webkit [104046] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-linux/svg/custom/glyph-selection-lang-attribute-expected.txt: Added.
9:50 AM Changeset in webkit [104045] by igor.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

Share fractional time code between AnimationBase and KeyframeAnimation
​https://bugs.webkit.org/show_bug.cgi?id=75549

Share fractional time calculation between AnimationBase and KeyframeAnimation.

Reviewed by Simon Fraser.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):

  • page/animation/AnimationBase.h:
  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

9:17 AM Changeset in webkit [104044] by vangelis@chromium.org
  • 6 edits in trunk/Source

[chromium] Bypass the shadow texture copy for accelerated
canvas when running the compositor in single threaded mode.
​https://bugs.webkit.org/show_bug.cgi?id=75146

Source/WebCore:

The texture copy fails on Windows as glCopyTexImage2D() doesn't
support BGRA source textures.
This change also modifies Canvas2DLayerChromium::updateCompositorResources
to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
the copy can work with texture allocated via the glTexStorage2D
extension.

Reviewed by James Robinson.

Tests: Canvas2DLayerChromiumTest.cpp

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore::Canvas2DLayerChromium::setTextureManager):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
(WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
(WebCore::Canvas2DLayerChromium::cleanupResources):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

Source/WebKit/chromium:

Modified Canvas2DLayerChromium unit test to test canvas with
both threaded and non-threaded compositing.

Reviewed by James Robinson.

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCThread::threadID):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::setTextureManager):
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
(WebCore::TEST_F):

9:08 AM Changeset in webkit [104043] by hclam@chromium.org
  • 10 edits
    4 adds
    1 delete in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-linux/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-lang-attribute-expected.png: Added.
  • platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/glyph-selection-lang-attribute-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/chromium-win/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/chromium-win/svg/custom/glyph-selection-lang-attribute-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:12 AM Changeset in webkit [104042] by vestbo@webkit.org
  • 1 edit in trunk/Tools/qmake/mkspecs/features/wtf.prf

[Qt] Fix windows build. WTF depends on timeEndPeriod from winmm

8:12 AM Changeset in webkit [104041] by hclam@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
7:55 AM Changeset in webkit [104040] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix test regressions after r104025
​https://bugs.webkit.org/show_bug.cgi?id=75545

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-04
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

7:41 AM Changeset in webkit [104039] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix link order of static libraries and unbreak QtWin32

We were keeping the correct static link order between the intermediate
WebKit libraries, but not the internal dependencies for each of those
libraries. The load() will in some instances mess with LIBS, so we need
to ensure that the dependent libraries are added after the library we
are linking against.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_post.prf:
7:33 AM Changeset in webkit [104038] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Use one big printf command instead of many chained echo commands to generate idl_files.tmp

This works around a bug in Cygwin where sh.exe will crash if given a too-long sequence of
&&-chained commands.

Fixes <​http://webkit.org/b/75546> <rdar://problem/10622193> REGRESSION (r103519): WebCore's
DerivedSources.make crashes sh.exe if path to WebKit source tree is long enough

Reviewed by Antti Koivisto.

  • DerivedSources.make: Change the '(echo foo && echo bar && echo baz && echo -n) >

./idl_files.tmp' command to 'printf "foo\nbar\nbaz\n" > ./idl_files.tmp'. We use the
patsubst function to append "\n" to each IDL filename, then use the subst function to remove
the spaces between the filenames.

7:26 AM Changeset in webkit [104037] by hclam@chromium.org
  • 63 edits
    3 copies
    4 moves
    5 adds
    8 deletes in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations after Skia roll.

  • platform/chromium-cg-mac-snowleopard/svg/custom/fractional-rects-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/fractional-rects-expected.png.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-linux/svg/carto.net/button-expected.png: Added.
  • platform/chromium-linux/svg/carto.net/button-expected.txt: Removed.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/fractional-rects-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/button-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/fractional-rects-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png.
  • platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fractional-rects-expected.png: Removed.
  • platform/chromium-win-xp/fast/backgrounds/animated-svg-as-mask-expected.png: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png.
  • platform/chromium-win-xp/svg/as-background-image/animated-svg-as-background-expected.png: Copied from LayoutTests/platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png.
  • platform/chromium-win-xp/svg/text/text-align-01-b-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-path-01-b-expected.png: Copied from LayoutTests/platform/chromium-win/svg/text/text-path-01-b-expected.png.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-win/svg/carto.net/button-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/fractional-rects-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/fractional-rects-expected.txt: Removed.
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
  • platform/qt/svg/custom/fractional-rects-expected.txt: Removed.
  • platform/qt/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
  • svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
  • svg/custom/fractional-rects-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/fractional-rects-expected.txt.
  • svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt.
6:51 AM Changeset in webkit [104036] by mihnea@adobe.com
  • 14 edits in trunk/Source/WebCore

[CSSRegions]Rollout support for background-color region styling
​https://bugs.webkit.org/show_bug.cgi?id=75007

Reviewed by Tony Chang.

Removed functionality, therefore no new tests. Since this is a temporary rollout,
the tests for region-style with background-color are not removed in this patch, just skipped.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:
6:34 AM Changeset in webkit [104035] by abecsi@webkit.org
  • 22 edits in trunk/Source/WebKit2

REGRESSION(r104028): Broke editing tests and event coordinates in desktop behaviour
​https://bugs.webkit.org/show_bug.cgi?id=75542

[Qt][WK2] Pinch zoom should affect the page size
​https://bugs.webkit.org/show_bug.cgi?id=74601

Unreviewed roll-out.

Patch by Andras Becsi <​andras.becsi@nokia.com> on 2012-01-04

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::geometryChanged):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
6:21 AM Changeset in webkit [104034] by vestbo@webkit.org
  • 27 edits in trunk

[Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies

The custom qmake variable 'WEBKIT' is used for signaling that a
target depends in some way on other subproject of the WebKit
project. For now this is limited to the set of intermediate
libraries: wtf, javascriptcore, webcore, and webkit2.

This replaces the previous convension of using load(foo) for
just include paths, and CONFIG += foo to also link against foo.

Adding a dependency results in additional include paths being
available, and potentially linking to the library. This is
decided by the build system based on conditions such as what
kind of target is being built and the general build config.

An advantage to his approach is that it simplifies the individual
foo.prf files, for example by allowing us to use INCLUDEPATH +=
and LIBS += as normal instead of prepending.

Reviewed by Simon Hausmann.

6:19 AM Changeset in webkit [104033] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-use TestShellLinux.cpp for Android
​https://bugs.webkit.org/show_bug.cgi?id=75169

Reviewed by Tony Chang.

TestShellLinux.cpp can be re-used for the test-shell on the WebKit
Chromium port for Android. Most custom inclusions for the DumpRenderTree
target are done in Tools/DumpRenderTree.gypi, but since *Linux.cpp files
are being excluded by a global rule on sources it has to be later in
the project generation process.

  • WebKit.gyp:
6:04 AM Changeset in webkit [104032] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk/Tools

[Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=75488

Patch by Alexander Færøy <​ahf@0x90.dk> on 2012-01-04
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/Dialog.qml:
  • MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
  • MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
5:45 AM Changeset in webkit [104031] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

http/tests/appcache/interrupted-update.html is crashing on Win7, mark it so.

  • platform/chromium/test_expectations.txt:
5:36 AM Changeset in webkit [104030] by hclam@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

Not reviewed. Update Chromium port test expectations.

  • platform/chromium-cg-mac-leopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:27 AM Changeset in webkit [104029] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip a failing test.
5:26 AM Changeset in webkit [104028] by abecsi@webkit.org
  • 22 edits in trunk/Source/WebKit2

[Qt][WK2] Pinch zoom should affect the page size
​https://bugs.webkit.org/show_bug.cgi?id=74601

Patch by Andras Becsi <​andras.becsi@nokia.com> on 2012-01-03
Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.

  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/qt/NativeWebMouseEventQt.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

  • Shared/qt/NativeWebTouchEventQt.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/qt/NativeWebWheelEventQt.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
5:09 AM EFLWebKit edited by caio.oliveira@openbossa.org
reordering EFL specific packages so that dependencies come first (diff)
4:55 AM Changeset in webkit [104027] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit

It wasn't really a problem at runtime since the right QtWebKit was
already loaded as a dependency of the web process, but the ldd output
would still be busted.

Reviewed by Simon Hausmann.

4:55 AM Changeset in webkit [104026] by vestbo@webkit.org
  • 11 edits in trunk

[Qt] Move use of $$qtLibraryTarget() to a single place

Reviewed by Kenneth Rohde Christiansen.

3:31 AM Changeset in webkit [104025] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Clean up Qt specific part of editorState()

Reviewed by Simon Hausmann.

Use unsigned instead of int.
No need to clone the range as we don't modify it.
Support selections which include a composition.
If we are not in editable content make sure to use the document element
as the scope for calculating the positions and lengths.
Remove compositionStart/Length as there cannot be a selection and
composition at the same time.

Only tested manually as we don't have everything in place yet
to properly test this.

  • Shared/EditorState.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

3:24 AM Changeset in webkit [104024] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/xmlhttprequest/workers/abort-exception-assert.html makes 6 fast/workers test fail
​https://bugs.webkit.org/show_bug.cgi?id=71695

  • platform/qt/Skipped: Unskip http/tests/xmlhttprequest/workers/abort-exception-assert.html,

because the bug was fixed long long time ago by ​http://trac.webkit.org/changeset/102473.

2:23 AM Changeset in webkit [104023] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.
1:36 AM Changeset in webkit [104022] by mihnea@adobe.com
  • 7 edits in trunk/Source

[Mac]Fix build after changeset 103997
​https://bugs.webkit.org/show_bug.cgi?id=75530

Reviewed by Andreas Kling.

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebView.mm:

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:
1:26 AM Changeset in webkit [104021] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Refactor the way using cairo in ewk_tiled_backing_store.
​https://bugs.webkit.org/show_bug.cgi?id=74993

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-04
Reviewed by Nikolas Zimmermann.

For now there are cairo related code scattered around the ewk_tiled_backing_store.
From the point of code complexity view, it doesn't look good and I couldn't notice any benefit of it.
So, this patch will let cairo related code be used only for painting operation.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_tile_new):

  • ewk/ewk_tiled_model.cpp:

(ewk_tile_new):
(ewk_tile_free):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb):

1:17 AM Changeset in webkit [104020] by commit-queue@webkit.org
  • 4 edits in trunk

Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
​https://bugs.webkit.org/show_bug.cgi?id=75238

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2012-01-04
Reviewed by Antonio Gomes.

.:

  • Source/cmakeconfig.h.cmake: Modified to add a new cmakedefine ENABLE_DOWNLOAD_ATTRIBUTE.

Tools:

Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that
it could initiate download directly if it has the download attribute in the link
and doesn't need to open new blank page for the target="_blank". Enabling this
feature in the BlackBerry porting also prepares for later blob feature implementation.

  • Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on

for the BlackBerry porting.

12:53 AM EFLWebKitCodingStyle edited by t.morawski@samsung.com
(diff)
12:48 AM Changeset in webkit [104019] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=75376

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-01-04
Reviewed by Adam Barth.

  • canvas/philip/tests/2d.pattern.image.string-expected.txt:
  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
  • platform/qt/Skipped:

Jan 3, 2012:

11:37 PM Changeset in webkit [104018] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
​https://bugs.webkit.org/show_bug.cgi?id=75475

Reviewed by Martin Robinson.

The problem is that the property blurb contains <a ping> and tree
view uses gtk_tooltip_set_markup() internally, so we need to
escape the text.

  • MiniBrowser/gtk/BrowserSettingsDialog.c:

(browserSettingsDialogConstructed): Escape property blurb before
storing it in the GtkTreeModel.

11:35 PM Changeset in webkit [104017] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Scrollbars are drawn behind the window resize grip
​https://bugs.webkit.org/show_bug.cgi?id=75384

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseNotifyResizerSizeForWindow): Get the size of the
main window resize grip and send it to the page proxy if it
overlaps with the view.
(toplevelWindowResizeGripVisibilityChanged): Call
webkitWebViewBaseNotifyResizerSizeForWindow().
(webkitWebViewBaseRealize): Get the toplevel window and connect to
notify::resize-grip-visible signal.
(webkitWebViewBaseSizeAllocate): Call
webkitWebViewBaseNotifyResizerSizeForWindow().

11:26 PM Changeset in webkit [104016] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG: The assertion that a double-voted variable cannot become double-unvoted is wrong
​https://bugs.webkit.org/show_bug.cgi?id=75516
<rdar://problem/10640266>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Removed the offending assertion, since it was wrong. Also hardened the code to make
this case less likely by first having the propagator fixpoint converge, and then doing
double voting combined with a second fixpoint. This is neutral on benchmarks and
fixes the assertion in a fairly low-risk way (i.e. we won't vote a variable double
until we've converged to the conclusion that it really is double).

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagatePredictions):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):

LayoutTests:

Reviewed by Andy Estes.

Created a fuzzer that produces sufficiently awkward data flow that includes variables
that become either double, or integer, or mix of double and integer only after multiple
iterations of a fixpoint. This crashes the compiler prior to this patch, but works with
this patch.

  • fast/js/dfg-double-vote-fuzz-expected.txt: Added.
  • fast/js/dfg-double-vote-fuzz.html: Added.
  • fast/js/script-tests/dfg-double-vote-fuzz.js: Added.
11:05 PM Changeset in webkit [104015] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLConstructionSite::attach shouldn't return a value
​https://bugs.webkit.org/show_bug.cgi?id=75520

Reviewed by Eric Seidel.

We used to return a value to avoid some refchurn, but now that we're
using tasks, we always need to take that reference. Removing the
return value lets us remove the template parameter, which is a boon.
This patch has no impact on the html-parser.html benchmark.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
(WebCore::HTMLConstructionSite::fosterParent):

  • html/parser/HTMLConstructionSite.h:
11:03 PM Changeset in webkit [104014] by abarth@webkit.org
  • 4 edits in trunk

Fix assert when foster parenting self-closing elements
​https://bugs.webkit.org/show_bug.cgi?id=75527

Unreviewed.

Source/WebCore:

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::fosterParent):

  • We can't execute this task immediately because the code for self-closing elements wants to set the self-closing flag. Instead, we queue the task.

LayoutTests:

Add a test case that used to case an assert.

  • html5lib/resources/webkit02.dat:
10:43 PM Changeset in webkit [104013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Need to support credentials in the URL
​https://bugs.webkit.org/show_bug.cgi?id=75341

Patch by Charles Wei <​charles.wei@torchmobile.com.cn> on 2012-01-03
Reviewed by George Staikos.

No new tests required.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

10:24 PM Changeset in webkit [104012] by jochen@chromium.org
  • 10 edits
    1 delete in trunk/LayoutTests

Replace clearLocalStorage.js with localStorage.clear() now that it's implemented
​https://bugs.webkit.org/show_bug.cgi?id=75484

Reviewed by Daniel Bates.

  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/missing-arguments.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/clearLocalStorage.js: Removed.
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
10:22 PM Changeset in webkit [104011] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog

10:09 PM Changeset in webkit [104010] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Use data decoding swizzle for turbo JPEG grayscale images
​https://bugs.webkit.org/show_bug.cgi?id=75189

Reviewed by Adam Barth.

No new tests. Covered by exiting tests, in particular for grayscale
images that were corrupted by earlier versions on libjpeg-turbo:

tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
tables/mozilla/bugs/bug12908-1.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): Use a data decoding swizzle for
JCS_GRAYSCALE images.

9:51 PM Changeset in webkit [104009] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Minor speed improvement in HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=75517

Reviewed by Eric Seidel.

This improves the html-parser.html benchmark by 0.3%. I don't think
that's actually anything to write home about, but this patch makes me
feel better about my life.

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):

9:40 PM Changeset in webkit [104008] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove temporary code that we've inserted to implement the [Supplemental] IDL incrementally
​https://bugs.webkit.org/show_bug.cgi?id=75510

Reviewed by Adam Barth.

Now all build systems support the [Supplemental] IDL. This patch removes all
temporary code that we've inserted to implement the [Supplemental] IDL.

No tests. No change in behavior. Confirm that all builds pass.

  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/generate-bindings.pl:
  • page/DOMWindow.idl: Removed all attributes with a temporal [Supplemented] IDL.
9:28 PM Changeset in webkit [104007] by noel.gordon@gmail.com
  • 3 edits
    1 add
    6 deletes in trunk/LayoutTests

Make fast/multicol/huge-column-count.html dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=75513

Reviewed by Adam Barth.

Test added in r83470: convert it to dumpAsText, update expectations.

  • fast/multicol/huge-column-count-expected.txt: Added.
  • fast/multicol/huge-column-count.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/multicol/huge-column-count-expected.png: Removed.
  • platform/efl/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/gtk/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/mac/fast/multicol/huge-column-count-expected.txt: Removed.
  • platform/qt/fast/multicol/huge-column-count-expected.png: Removed.
  • platform/qt/fast/multicol/huge-column-count-expected.txt: Removed.
8:39 PM Changeset in webkit [104006] by abarth@webkit.org
  • 2 edits in trunk/PerformanceTests

html-parser.html takes too long to run
​https://bugs.webkit.org/show_bug.cgi?id=75515

Reviewed by Eric Seidel.

In working on runner.js, we introduced a factor of 10 increase to the
running time of this benchmark. This patch dials down the number of
iterations to something more user-friendly.

  • Parser/html-parser.html:
8:38 PM Changeset in webkit [104005] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Give embedders a chance to handle postMessage calls
​https://bugs.webkit.org/show_bug.cgi?id=73883

Source/WebCore:

To support cross-process postMessage calls in Chromium (bug 73337), we need to intercept
postMessage calls to proxy windows. Originally we were just going to add a native event
listener on the Chromium side, but that required more changes to WebKit and was a bit of
a hack. See bug 73359 for a discuss about moving to this approach.

Patch by Karl Koscher <​supersat@chromium.org> on 2012-01-03
Reviewed by Adam Barth.

Test: platform/chromium/fast/events/intercept-postmessage.html

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::willCheckAndDispatchPostMessage): new method to allow the

embedder to intercept postMessage calls

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired): add a call to

FrameLoaderClient::willCheckAndDispatchPostMessage

Source/WebKit/chromium:

Patch by Karl Koscher <​supersat@chromium.org> on 2012-01-03
Reviewed by Adam Barth.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):

interface to give the embedder a chance to handle this postMessage call

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): Call

willCheckAndDispatchMessageEvent on WebFrameClient

  • src/FrameLoaderClientImpl.h:
7:54 PM Changeset in webkit [104004] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

script-in-svg-in-HTML doesn't run
​https://bugs.webkit.org/show_bug.cgi?id=75233

Reviewed by Daniel Bates.

Add a test to make sure that we run scripts in SVG.

  • fast/parser/script-in-svg-runs-expected.txt: Added.
  • fast/parser/script-in-svg-runs.html: Added.
7:39 PM Changeset in webkit [104003] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Prevent crashing due to NULL texture updater.
​https://bugs.webkit.org/show_bug.cgi?id=75288

Patch by Eric Penner <​epenner@google.com> on 2012-01-03
Reviewed by James Robinson.

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/ImageLayerChromium.h:
7:36 PM Changeset in webkit [104002] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] CCLayerSorter accidentally reverses order of some layers.
​https://bugs.webkit.org/show_bug.cgi?id=75046

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCLayerSorterTest.cpp

Fixes two related bugs that were causing z-ordering problems in
layers when preserves3D triggers the need for layer sorting.

The first problem was that CCLayerSorter accidentally reversed the
order of layers when there was no sorting dependency between them.

The second problem was that zDiff had numerical precision problems
that forced sorting dependencies that were sometimes incorrect,
when the dependencies should not have existed.

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::sort):

Source/WebKit/chromium:

  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):

7:34 PM Changeset in webkit [104001] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add support of blob form data to the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=75218

Pass FormDataElement::encodedBlob type of form data to the BlackBerry
platform request to support blob data and blob file range.

Reviewed by George Staikos.

The port can't be built now, no new tests so far.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

6:57 PM Changeset in webkit [104000] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Two null crashes in Treebuilder
​https://bugs.webkit.org/show_bug.cgi?id=66101

Reviewed by Eric Seidel.

Source/WebCore:

The underly issue with causing the crash is that we're re-entering the
tree builder. We've done a bunch of point fixes around tree builder
re-entrancy, but neither the implementation nor the specification are
really designed to handle re-entrancy.

Firefox avoids this problem by putting the parser on its own thread. I
don't think we're quite ready to do that yet (although we will
eventually, presumably, as computers become ever more parallel). The
approach in this patch is to queue up the DOM mutations and actually
perform them on a shallower stack. That's essentially the approach
we've used for executing <scripts>.

This patch queues up DOM modifications and executes them from a clean
call stack, stopping us from re-entering the tree builder. We might
need to experiment with exactly where to kick off the queue, but this
location seems reasonable and fixes the crash.

Test: fast/parser/re-enter-and-crash.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeTask):

  • Add a helper function for actually executing a queue DOM mutation.

(WebCore::HTMLConstructionSite::attach):

  • Instead of actually attaching the element to the DOM, this function now queues the element for attachment. In a follow-up patch, I plan to change this function to return void (and I'll probably rename it to something that makes it clear that it only queues the attachment).

(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::insertDoctype):

  • Setting the compatmode from the Doctype requires the doctype to actually be in the DOM, so we need to execute our queued tasks synchronously. We can likely improve this function by passing the Doctype element explicitly in a follow-up patch.

(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::fosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSiteTask::HTMLConstructionSiteTask):

  • Add a task object that holds on to the relevant elements. We define some vector traits for this object to match the traits on RefPtr (which make Vector operations faster by explaining that this type is moveable without having to churn reference counts).
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::pushCommon):

  • We delay the "begin parsing" call until we actually attach the element to the DOM. That splits the responsibility for calling begin/finished, which is less than ideal, but I didn't see another solution.
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):

  • Kick off the queued mutations.

LayoutTests:

Test that we no longer crash on this test case.

  • fast/parser/re-enter-and-crash-expected.txt: Added.
  • fast/parser/re-enter-and-crash.html: Added.
6:41 PM Changeset in webkit [103999] by abarth@webkit.org
  • 10 edits in trunk

view-source doesn't colorize </script> correctly
​https://bugs.webkit.org/show_bug.cgi?id=62971

Reviewed by Eric Seidel.

Source/WebCore:

The reason these tags weren't colorized correctly was because the
characters for the end tags where consumed by the tokenizer at the same
time as it consumed the text of the script tag. These characters are
buffered internally by the tokenizer because the tokenizer is searching
for "an appropriate end tag", which is "</script>" in this case.

I tried a number of different approaches to fixing this bug. The
approach in this patch adds an accessor to the tokenizer to read out
the buffered characters. This approach makes it easier for the
HTMLSourceTracker to get exactly the right value for these buffered
characters without having to do a complicated simulation of the
buffering itself.

Tests: fast/frames/viewsource-plain-text-tags.html:

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • Give the HTMLSourceTracker a pointer to the tokenizer so it can ask for the buffered characters.
  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):

  • The idea here is to treat characters buffered internally by the tokenizer the same way we treat characters that were contained in a previous segment of source. We copy them into our accumulation buffer and adjust the token base offset to account for the extra characters.

(WebCore::HTMLSourceTracker::end):

  • Don't consier the character buffered by the tokenizer to be part of the token we've just finished.

(WebCore::HTMLSourceTracker::sourceForToken):

  • Remove the assumption that all of the m_previousSource is contained in the source for the current token. Because we now understand that the tokenizer can buffer some characters internally, we might not exhaust the m_previousSource.
  • html/parser/HTMLSourceTracker.h:
    • Rename m_sourceFromPreviousSegments to m_previousSource and changed to a SegementedString to avoid extra mallocs we keep appending tiny segments.
    • Rename m_source to m_currentSource to contrast nicely with m_previousSource.
  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):

  • Previously, we cleared the temporary buffer lazily when we needed to add new characters to it. Now we clear it eagerly so that it's length tells us whether we're currently using it to store characters.
  • Previously, we weren't storing the character that we used to terminate the appropriate end tag (e.g., the > in </script>) because we didn't need to "unbuffer" that character into the HTMLToken::appendToCharacter. Now, we do store that character in the temporary buffer so that the HTMLSourceTracker can see that character.

(WebCore::HTMLTokenizer::bufferedCharacters):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::numberOfBufferedCharacters):

  • Add accessor methods to copy out the buffered characters.
  • Also, unrelated to the rest of this patch, I made the constructor for HTMLTokenizer explicit because it takes only a single paramater, per the style guide.
  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::clear):

  • SegmentedString::clear wasn't clearing all of its state. I don't think this issue was actually observable, but I noticed it when working on this patch, so I fixed it.

LayoutTests:

  • fast/frames/viewsource-plain-text-tags.html:
6:28 PM Changeset in webkit [103998] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: fast/filesystem/workers/file-writer-events.html crash suppressed on Linux
due to BUGCR108798.

  • platform/chromium/test_expectations.txt:
6:26 PM Changeset in webkit [103997] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebCore

Exclude Mac's PlatformEventFactory from iOS
​https://bugs.webkit.org/show_bug.cgi?id=75493

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-03
Reviewed by Sam Weinig.

Move PlatformEventFactory.(h|cpp) to PlatformEventFactoryMac(h|cpp) and exclude the file
from iOS build.

  • Configurations/WebCore.xcconfig: Also exclude EventHandlerMac for consistency.
  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/PlatformEventFactoryMac.h: Renamed from Source/WebCore/platform/mac/PlatformEventFactory.h.
  • platform/mac/PlatformEventFactoryMac.mm: Renamed from Source/WebCore/platform/mac/PlatformEventFactory.mm.

(WebCore::globalPoint):
(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::mouseEventTypeForEvent):
(WebCore::clickCountForEvent):
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::gestureEventTypeForEvent):
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):
(WebCore::isKeypadEvent):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::isKeyUpEvent):
(WebCore::modifiersForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformEventFactory::createPlatformMouseEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformEventFactory::createPlatformWheelEvent):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformEventFactory::createPlatformKeyboardEvent):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebCore::PlatformEventFactory::createPlatformGestureEvent):

6:25 PM Changeset in webkit [103996] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] LocalFileSystemChromium needs some thread safety fixes.
​https://bugs.webkit.org/show_bug.cgi?id=75494

Reviewed by Dmitry Titov.

This is essentially the same fix as r102894 except in slightly different code.

The important part of this fix is the removal of AllowCrossThreadAccess so
that ref counting happens appropriately.

Minor clean up throughout: Removed unnecessary WTF prefix in many
of these places and unnecessary String().

  • src/LocalFileSystemChromium.cpp: See r102894 since this

is basically the same thing.

5:45 PM Changeset in webkit [103995] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: filed CR109077 and updated expectations for http/tests/inspector/appcache/appcache-swap.html.

  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [103994] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize AudioBufferSourceNode process by avoiding interpolation when pitchRate==1
​https://bugs.webkit.org/show_bug.cgi?id=74592

Patch by Wei James <​james.wei@intel.com> on 2012-01-03
Reviewed by Kenneth Russell.

Covered by existing webaudio layout tests, especially webaudio/audiobuffersource-playbackrate.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

  • webaudio/AudioBufferSourceNode.h:
5:20 PM Changeset in webkit [103993] by leviw@chromium.org
  • 135 edits in branches/subpixellayout/LayoutTests/platform

Updating test expectations for SVG and tables.

5:18 PM Changeset in webkit [103992] by Joseph Pecoraro
  • 8 edits in trunk/Source/WebCore

<​http://webkit.org/b/75504> Web Inspector: Access to Node Highlighting info without drawing

Provide a "getHighlight" method alongside "drawHighlight" that
gets most of the important node highlighting information. This
can be used by a port to do its own node highlighting or provide
extra content without interfering with the highlight rects.

Reviewed by Timothy Hatcher.

  • WebCore.xcodeproj/project.pbxproj:

Privately expose the Highlight struct in DOMNodeHighlighter.h.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawHighlight):
(WebCore::DOMNodeHighlighter::getHighlight):

  • inspector/DOMNodeHighlighter.h:

Reuse the existing draw code to instead populate
the Highlight struct with the information it is
about to draw, and only draw if there is a context.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::getHighlight):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getHighlight):

  • inspector/InspectorDOMAgent.h:

Get highlight information by going through getHighlight
in InspectorController. This is alongside drawHighlight.

5:10 PM Changeset in webkit [103991] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Clear localStorage before making assumption about its contents
​https://bugs.webkit.org/show_bug.cgi?id=75469

Reviewed by Daniel Bates.

  • platform/chromium/permissionclient/storage-permission.html:
4:53 PM Changeset in webkit [103990] by commit-queue@webkit.org
  • 26 edits
    1 move
    9 adds
    2 deletes in trunk

[chromium] Push drawsContent and contentsVisible into accelerated compositor
​https://bugs.webkit.org/show_bug.cgi?id=71209

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Tests: compositing/visibility/visibility-simple-canvas2d-layer.html

compositing/visibility/visibility-simple-video-layer.html
compositing/visibility/visibility-simple-webgl-layer.html

Rebaselined compositing/visibility/visibility-image-layers.html

The CSS visibility property was not being properly obeyed by many
specialized layer types in the accelerated compositor. The root of
the problem was that drawsContent and contentsVisible flags were
not properly propagated into the compositor. This patch removes
the drawsContent() callback, and instead makes sure that
drawsContent and contentsVisible are "pushed" through the
accelerated compositor.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setDrawsContent):
(WebCore::GraphicsLayerChromium::setContentsVisible):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setIsDrawable):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::drawsContent):

  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::drawsContent):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::dumpLayerProperties):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):

  • src/WebContentLayerImpl.h:
  • src/WebExternalTextureLayerImpl.cpp:

(WebKit::WebExternalTextureLayerImpl::drawsContent):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::WebLayerImpl):

  • src/WebLayerImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

LayoutTests:

  • compositing/visibility/visibility-image-layers-expected.png:
  • compositing/visibility/visibility-image-layers-expected.txt: Renamed from LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-expected.txt.
  • compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-canvas2d-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-canvas2d-layer.html: Added.
  • compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-video-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-video-layer.html: Added.
  • compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
  • compositing/visibility/visibility-simple-webgl-layer-expected.txt: Added.
  • compositing/visibility/visibility-simple-webgl-layer.html: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
4:44 PM Changeset in webkit [103989] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 102392 - Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
​https://bugs.webkit.org/show_bug.cgi?id=74126

Reviewed by Tony Chang.

The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.

Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
whole pre-rendering trick.

  • editing/markup.cpp:

(WebCore::createFragmentFromText):
Review URL: ​http://codereview.chromium.org/9008054

4:34 PM Changeset in webkit [103988] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Make sure root damage rect gets passed to renderer
​https://bugs.webkit.org/show_bug.cgi?id=74893

Patch by Shawn Singh <​shawnsingh@chromium.org> on 2012-01-03
Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCLayerTreeHostImplTest.cpp

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
(WebKit::PartialSwapTrackerContext::initialize):
(WebKit::PartialSwapTrackerContext::postSubBufferCHROMIUM):
(WebKit::PartialSwapTrackerContext::getString):
(WebKit::PartialSwapTrackerContext::partialSwapRect):

4:29 PM Changeset in webkit [103987] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, svg/carto.net/selectionlist.svg appears to
just need a rebaseline on Linux.

  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium/test_expectations.txt:
4:25 PM Changeset in webkit [103986] by dslomov@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed: files bug CR109068 for appcache/interrupted-update.html crash.

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [103985] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Increment the code-review.js version number to bust browser
caches.

  • PrettyPatch/PrettyPatch.rb:
4:18 PM Changeset in webkit [103984] by jochen@chromium.org
  • 7 edits in trunk/Tools

When showing results.html pass a correct URL to webbrowser.open
​https://bugs.webkit.org/show_bug.cgi?id=75438

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/system/filesystem.py:

(file_path_as_url):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(file_path_as_url):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(test_file_path_as_url):

  • Scripts/webkitpy/layout_tests/port/base.py:

(show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(test_show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(test_results_directory_relative):

4:16 PM Changeset in webkit [103983] by ojan@chromium.org
  • 2 edits in trunk/Tools

shrink the header on the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=65153

Reviewed by Adam Roben.

Move some of the "show" links to be to the right of the header
instead of below the header when they content they're showing
is hidden. That way we don't waste vertical space on them.

No new tests. This code is covered by existing tests.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
4:10 PM Changeset in webkit [103982] by leviw@chromium.org
  • 115 edits in branches/subpixellayout

Fixing/simplifying FixedRect's TransformationMatrix::mapRect implementation. Changing clampedBoundsOfProjectedQuad to clamp to LayoutUnits. This fixes transformed hit testing and clip rects. Adding a clampToLayoutUnit method. Rebaselining more tests.

4:06 PM Changeset in webkit [103981] by fpizlo@apple.com
  • 3 edits
    12 adds in trunk

REGRESSION (r98196-98236): Incorrect layout of iGoogle with RSS feeds
​https://bugs.webkit.org/show_bug.cgi?id=75303
<rdar://problem/10633533>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

The this argument was not being kept alive in some cases during inlining and intrinsic
optimizations.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionCheck):
(JSC::DFG::ByteCodeParser::handleInlining):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-unused-this-expected.txt: Added.
  • fast/js/dfg-inline-unused-this-method-check-expected.txt: Added.
  • fast/js/dfg-inline-unused-this-method-check.html: Added.
  • fast/js/dfg-inline-unused-this.html: Added.
  • fast/js/dfg-intrinsic-unused-this-expected.txt: Added.
  • fast/js/dfg-intrinsic-unused-this-method-check-expected.txt: Added.
  • fast/js/dfg-intrinsic-unused-this-method-check.html: Added.
  • fast/js/dfg-intrinsic-unused-this.html: Added.
  • fast/js/script-tests/dfg-inline-unused-this-method-check.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-inline-unused-this.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-intrinsic-unused-this-method-check.js: Added.

(bar):
(baz):

  • fast/js/script-tests/dfg-intrinsic-unused-this.js: Added.

(bar):
(baz):

3:59 PM Changeset in webkit [103980] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix compilation with clang and the shared build
​https://bugs.webkit.org/show_bug.cgi?id=75492

Reviewed by Ojan Vafai.

  • WebKit.gyp: Turn off -Wglobal-constructors because test files using

GTEST have global constructors.

  • tests/InnerGestureRecognizerTest.cpp:

(TEST_F): Move global into test function.

3:40 PM Changeset in webkit [103979] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

v8 binding: npCreateV8ScriptObject() should not returned an existing V8NPObject if the rootObject doesn't match
​https://bugs.webkit.org/show_bug.cgi?id=74515

Patch by Yuzhu Shen <​yzshen@chromium.org> on 2012-01-03
Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/plugins/create-v8-script-objects.html

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

LayoutTests:

  • http/tests/plugins/create-v8-script-objects-expected.txt: Added.
  • http/tests/plugins/create-v8-script-objects.html: Added.
  • http/tests/plugins/resources/create-v8-script-objects-iframe.html: Added.
3:39 PM Changeset in webkit [103978] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Revert accidentally removed chrome client compositing check
​https://bugs.webkit.org/show_bug.cgi?id=75500

Reviewed by James Robinson.

This check was overzealously removed in r103968 as a part of
re-enabling compositing for RTL pages. Add it back.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::allowedCompositingTriggers):

3:31 PM Changeset in webkit [103977] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

3:28 PM Changeset in webkit [103976] by kerz@chromium.org
  • 1 copy in branches/chromium/wpotest

Branch at same point as M17 for WPO testing.

3:27 PM Changeset in webkit [103975] by jonlee@apple.com
  • 21 edits in trunk/Source

Leak of WebNotificationClient when page is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=74980
<rdar://problem/10611231>

Reviewed by Mark Rowe.

Source/WebCore:

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::~NotificationController): Notify the client
that the controller has been destroyed.

  • notifications/NotificationPresenter.h: Add notificationControllerDestroyed()

callback to the client interface.

Source/WebKit:

  • blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation, because ownership
model differs.

  • blackberry/WebCoreSupport/NotificationPresenterImpl.h:

Source/WebKit/chromium:

  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation because ownership
model differs.

  • src/NotificationPresenterImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): Stub implementation, because
the notification presenter is unimplemented.

  • WebCoreSupport/NotificationPresenterClientEfl.h:

Source/WebKit/mac:

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::notificationControllerDestroyed): Remove the instance.

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::notificationControllerDestroyed): Empty implementation, because
ownership model differs.

  • WebCoreSupport/NotificationPresenterClientQt.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::notificationControllerDestroyed): Delete the instance.

  • WebProcess/WebCoreSupport/WebNotificationClient.h:
3:20 PM Changeset in webkit [103974] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for list-style is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75443

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for list-style.

Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
3:13 PM Changeset in webkit [103973] by tony@chromium.org
  • 2 edits
    6 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, rebaseline of svg/hixie/text/003.html. It
doesn't look flaky on the flakiness dashboard.

  • platform/chromium-linux/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-mac/svg/hixie/text/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/text/003-expected.png: Added.
  • platform/chromium-win/svg/hixie/text/003-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:07 PM Changeset in webkit [103972] by enne@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Remove unneeded content vs. layer space distinction in tiled layers
​https://bugs.webkit.org/show_bug.cgi?id=75498

Reviewed by James Robinson.

Long ago, before scrollbars became their own layers, tiled layers had
a distinction between content space (what's mostly called layer space
elsewhere) and layer space (the transformed content space). It seemed
like this transform could get reused for supporting RTL pages, but as
that's not the case, it should be eradicated.

Tiled layers now deal with everything in "layer space", which is a 2d
rectangle starting at (0, 0) in the top left of the layer and
extending to contentBounds() in the bottom right.

As no code actually set the tiler position, this change should be a
no-op.

Test: LayoutTests/compositing/

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::layerRectToTileIndices):
(WebCore::CCLayerTilingData::tileRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

2:54 PM UsingGitWithWebKit edited by jamesr@google.com
(diff)
2:47 PM Changeset in webkit [103971] by eae@chromium.org
  • 10 edits in branches/subpixellayout

Fixed rounding discrepancies between clientWidth, scrollWidth and foregroundClipWidth by using representing all by app units internally and rounding using pixelSnapped at use (as opposed to compute) time.

2:33 PM Changeset in webkit [103970] by jamesr@google.com
  • 8 edits
    1 delete in trunk/Source/WebKit/chromium

[chromium] Remove WebLayerClient
​https://bugs.webkit.org/show_bug.cgi?id=75481

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/platform/WebContentLayer.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerClient.h: Removed.
  • src/WebContentLayer.cpp:
  • src/WebExternalTextureLayer.cpp:
  • src/WebLayer.cpp:
2:33 PM Changeset in webkit [103969] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

2:13 PM Changeset in webkit [103968] by enne@google.com
  • 7 edits in trunk

[chromium] Support RTL pages and elements in the compositor
​https://bugs.webkit.org/show_bug.cgi?id=56591

Reviewed by James Robinson.

Source/WebKit/chromium:

As the noncomposited content host layer is created and managed by the
Chromium compositor, adjust its transform appropriately in the layer
tree and at paint time to handle the offset required due to the
initial containing block of RTL pages.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::allowedCompositingTriggers):

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

LayoutTests:

Re-enable RTL tests for Chromium.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [103967] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 102089 - Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
BUG=106316
Review URL: ​http://codereview.chromium.org/9072017

1:56 PM Changeset in webkit [103966] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/963

Merge 102875 - Crash due to incorrect parsing of isolates
BUG=106200
Review URL: ​http://codereview.chromium.org/9071024

1:50 PM Changeset in webkit [103965] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 103318 - Crash in RenderTable::outerBorderAfter
BUG=106340
Review URL: ​http://codereview.chromium.org/9073008

1:45 PM Changeset in webkit [103964] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Sam Weinig.

Rewrite JSArray::putSlowCase to be much cleaner & simpler.

This rewrite only significantly changes behaviour for sparse array, specifically
in how sparse arrays are reified back to vector form. This does not affect arrays
with less than 10000 entries (since these always use a vector). The more common
cases of sparse array behavior (though large sparse arrays are rare) - arrays that
always remain sparse, and arrays that are filled in reverse sequential order -
should be just as fast or faster (since reification is simpler & no longer
requires map lookups) after these changes.

Simplifying this code allows all cases of putByIndex that need to grow the vector
to do so via increaseVectorLength, which means that this method can encapsulate
the policy of determining how the vector should be grown.

No performance impact.

  • runtime/JSArray.cpp:

(JSC::isDenseEnoughForVector):

  • any array of length <= MIN_SPARSE_ARRAY_INDEX is dense enough for a vector.

(JSC::JSArray::putByIndex):

  • simplify & comment.

(JSC::JSArray::putByIndexBeyondVectorLength):

  • Re-written to be much clearer & simpler.

(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):

  • add explicit checks against MAX_STORAGE_VECTOR_LENGTH, so clients do not need do so.

(JSC::JSArray::push):

  • simplify & comment.
  • runtime/JSArray.h:
    • removed SparseArrayValueMap::take.
1:41 PM Changeset in webkit [103963] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 102263 - Crash from multicol spans with layers
BUG=96499
Review URL: ​http://codereview.chromium.org/9071019

1:40 PM Changeset in webkit [103962] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/912

Merge 101584 - Crash from first letter text fragments having flows split
BUG=96499
Review URL: ​http://codereview.chromium.org/9014025

1:37 PM Changeset in webkit [103961] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

1:33 PM Changeset in webkit [103960] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=75140

Reviewed by Sam Weinig.

Simplify JSArray creation - remove ArgsList/JSValue* create methods
(this functionality can be implemented in terms of tryCreateUninitialized).

  • JavaScriptCore.exp:
  • runtime/ArrayConstructor.cpp:
    • use constructArray/constructEmptyArray instead of calling JSArray::create directly

(JSC::constructArrayWithSizeQuirk):

  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
    • removed ArgsList/JSValue* create methods
  • runtime/JSGlobalObject.h:

(JSC::constructEmptyArray):
(JSC::constructArray):

  • changed to be implemented in terms of JSArray::tryCreateUninitialized
1:24 PM Changeset in webkit [103959] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk/Tools

Add a tool to analyze change logs
​https://bugs.webkit.org/show_bug.cgi?id=72243

Reviewed by Eric Seidel.

Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
for visualizing json files.

Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
generates json files, and N is the number of changelogs to parse.

  • Scripts/webkitpy/common/config/contributionareas.py: Added names().
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
  • Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/data/summary.html: Added.
  • Scripts/webkitpy/tool/steps/options.py:
1:05 PM Changeset in webkit [103958] by barraclough@apple.com
  • 13 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75429
ThrowTypeError should be a singleton object

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Per section 13.2.3 of the spec.
We could change setAccessorDescriptor to be able to share the global
GetterSetter object, rather than storing the accessor functions and
creating a new GetterSetter in defineProperty - but this won't be a
small change to PropertyDescriptors (and would probably mean making
GetterSetter objects immutable?) - so I'll leave that for another
patch.

  • JavaScriptCore.exp:
    • don't export setAccessorDescriptor
  • runtime/Arguments.cpp:

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

  • call throwTypeErrorGetterSetter instead of createTypeErrorFunction
  • runtime/Error.cpp:
  • runtime/Error.h:
    • remove createTypeErrorFunction
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
    • remove unused createDescriptorForThrowingProperty
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • removed m_strictModeTypeErrorFunctionStructure.
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::internalFunctionStructure):

  • removed m_strictModeTypeErrorFunctionStructure.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setAccessorDescriptor):

  • changed to take a GetterSetter
  • runtime/PropertyDescriptor.h:
    • changed to take a GetterSetter

LayoutTests:

Per section 13.2.3 of the spec.

  • fast/js/basic-strict-mode-expected.txt:
    • ThrowTypeError is a singleton, so cannot generate property-specific error messages.
  • fast/js/script-tests/strict-throw-type-error.js: Added.
  • fast/js/strict-throw-type-error-expected.txt: Added.
  • fast/js/strict-throw-type-error.html: Added.
    • added test case that ThrowTypeError is a singleton
12:21 PM Changeset in webkit [103957] by Joseph Pecoraro
  • 40 edits in trunk

<​http://webkit.org/b/59951> Implement Date and Time Input Value Sanitization

Source/WebCore:

Sanitize non-parsable incoming strings to the empty string.

Reviewed by Kent Tamura.

Covered by existing tests.

  • html/BaseDateAndTimeInputType.h:
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::sanitizeValue): check if the
incoming string is valid. If not just return the empty string.

LayoutTests:

Update ValidityState typeMismatch tests for date types, since
setting an invalid value now sanitized to the empty string.
So, what used to be an invalid value with a typeMismatch is
now a valid empty string and there is never a typeMismatch.

  • for rangeOverflow / rangeUnderflow tests update the test to point out when a value was sanitized.
  • for typeMismatch tests, typeMismatch can no longer happen for sanitized values. Change the test to output if the value was sanitized or not and ensure that we are never in a typeMismatch state. Disabled inputs are also sanitized when their value changes.

Reviewed by Kent Tamura.

  • fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
  • fast/forms/date/ValidityState-rangeOverflow-date.html:
  • fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
  • fast/forms/date/ValidityState-rangeUnderflow-date.html:
  • fast/forms/date/ValidityState-typeMismatch-date-expected.txt:
  • fast/forms/date/ValidityState-typeMismatch-date.html:
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime.html:
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html:
  • fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-typeMismatch-datetime.html:
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html:
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html:
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt:
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html:
  • fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
  • fast/forms/month/ValidityState-rangeOverflow-month.html:
  • fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
  • fast/forms/month/ValidityState-rangeUnderflow-month.html:
  • fast/forms/month/ValidityState-typeMismatch-month-expected.txt:
  • fast/forms/month/ValidityState-typeMismatch-month.html:
  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt:
  • fast/forms/time/ValidityState-rangeOverflow-time.html:
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt:
  • fast/forms/time/ValidityState-rangeUnderflow-time.html:
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt:
  • fast/forms/time/ValidityState-typeMismatch-time.html:
  • fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
  • fast/forms/week/ValidityState-rangeOverflow-week.html:
  • fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
  • fast/forms/week/ValidityState-rangeUnderflow-week.html:
  • fast/forms/week/ValidityState-typeMismatch-week-expected.txt:
  • fast/forms/week/ValidityState-typeMismatch-week.html:
12:19 PM Changeset in webkit [103956] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary forward declaration of Function
​https://bugs.webkit.org/show_bug.cgi?id=75485

Reviewed by Dan Bernstein.

  • Platform/WorkQueue.h:
12:08 PM Changeset in webkit [103955] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderLayer::backgroundClipRect should not check parent()
​https://bugs.webkit.org/show_bug.cgi?id=73731

Reviewed by Simon Fraser.

Clean-up only, no expected change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::backgroundClipRectForPosition): Changed RenderObject::isPositioned() to
a check for AbsolutePosition for consistency but also as this is equivalent due to:

  • the previous check for FixedPosition.
  • RenderView, which is positioned, will never goes to this code as it has no parent().

(WebCore::RenderLayer::backgroundClipRect): Removed the parent() check. While at
it, also moved the inline initialization of |backgroundClipRect| to its own function
and removed a |view| check as the associated ASSERT seems to never have been reached.

12:02 PM Changeset in webkit [103954] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/10637779> REGRESSION (r102247): Focus ring is not drawn around a button

Rubber-stamped by Dan Bernstein.

  • platform/mac/ThemeMac.mm: (WebCore::updateStates): Flip an incorrect conditional, this code should run on Snow Leopard and Lion.
11:56 AM Changeset in webkit [103953] by alexis.menard@openbossa.org
  • 10 edits in trunk

Source/WebCore: getComputedStyle should return shorthands property with the minimum number of sides possible.
​https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in ​http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

Existing tests have been updated accordingly.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):

  • css/CSSComputedStyleDeclaration.h:

LayoutTests: getComputedStyle should return shorthands properties with the minimum number of sides possible.
​https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in ​http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
  • fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-width.html:
11:53 AM Changeset in webkit [103952] by Adam Roben
  • 17 edits in trunk/Tools

Make Port subclasses override the operating_system method rather than setting an attribute

Without this patch, any use of Port.operating_system() within a port's init method would
return the default value ("mac"). This was confusing the version-checking logic inside
ApplePort.init on Windows.

Fixes <​http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
crashes on launch on Windows 7 SP1

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.init): Replaced uses of self._operating_system with self.operating_system().

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init): Removed code that set the self._operating_system attribute. Subclasses
should now override the operating_system method instead.
(Port.operating_system): Changed to always return "mac". Subclasses should override to
return something else.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):
(ChromiumLinuxPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):
(ChromiumMacPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.init):
(ChromiumWinPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.init):
(MacPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.init):
(WinPort.operating_system):
Changed to override the operating_system method rather than setting the _operating_system
attribute, since setting the attribute isn't sufficient for code inside init methods.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.init):
(QtPort._path_to_webcore_library):
Changed to use self.operating_system() instead of self._operating_system, for consistency
with other Port-related code.

(QtPort.operating_system): Added this override of Port.operating_system that returns the
value we determined in our init method.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.operating_system): Added this override of Port.operating_system that returns the
value we determined in our init method.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
Test that all ports return the expected operating system string.

11:51 AM Changeset in webkit [103951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] GTK+ 3 theming code does not use the GtkOrientable style class
​https://bugs.webkit.org/show_bug.cgi?id=72789

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-01-03
Reviewed by Philippe Normand.

No new tests. Testing GTK+ theming is quite difficult
because no two distributions have the same set of themes.
Current tests prevent regressions.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::applySliderStyleContextClasses): Added this helper that
properly handles the orientable style class.
(WebCore::RenderThemeGtk::paintSliderTrack): Use the new helper.
(WebCore::RenderThemeGtk::paintSliderThumb): Ditto.

  • platform/gtk/ScrollbarThemeGtk3.cpp:

(WebCore::applyScrollbarStyleContextClasses): Added this helper that
properly handles the orientable style class.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Use the new helper.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
(WebCore::ScrollbarThemeGtk::paintButton): Ditto.

11:33 AM Changeset in webkit [103950] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform
​https://bugs.webkit.org/show_bug.cgi?id=75227

Patch by Florin Malita <​fmalita@google.com> on 2012-01-03
Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/custom/webkit-transform-crash.html

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
Add a null-renderer check.

LayoutTests:

  • svg/custom/webkit-transform-crash-expected.txt: Added.
  • svg/custom/webkit-transform-crash.html: Added.
11:29 AM Changeset in webkit [103949] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixed a typo in the change log

11:13 AM Changeset in webkit [103948] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle for border is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75319

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border.

fast/css/getComputedStyle/getComputedStyle-border-shorthand.html was extented.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values.

  • fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:
11:03 AM Changeset in webkit [103947] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Sort the WebCore XCode project file

Reviewed by Dimitri Glazkov.

  • WebCore.xcodeproj/project.pbxproj:
10:59 AM Changeset in webkit [103946] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] Set tiler bounds explicitly rather than growing them
​https://bugs.webkit.org/show_bug.cgi?id=75331

Reviewed by James Robinson.

Rather than only growing bounds, make the bounds on the tiler be set
explicitly by TiledLayerChromium. This patch now properly invalidates
regions when the bounds change.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):
(WebCore::CCLayerTilingData::bounds):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
10:55 AM Changeset in webkit [103945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Slider thumb is not centered on the track with the unico theme
​https://bugs.webkit.org/show_bug.cgi?id=72802

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-01-03
Reviewed by Philippe Normand.

No new tests. This only applies to certain GTK+ themes.
Existing tests cover the default GTK+ theme.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::paintSliderThumb): Do not resize the
slider thumb by the trough border.

10:48 AM Changeset in webkit [103944] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Make tiled layer's tiler always exist
​https://bugs.webkit.org/show_bug.cgi?id=75329

Reviewed by James Robinson.

Source/WebCore:

TiledLayerChromium has some awkward code to handle lazily creating the
tiler, including lots of null checks and shadowing the tile size.
Instead, always create the tiler up front. As values change that
invalidate all tiles, reset it rather than clear the pointer.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setIsNonCompositedContent):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::setTileSize):
(WebCore::TiledLayerChromium::setBorderTexelOption):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::setTilingOption):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setIsNonCompositedContent):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBorderTexelOption):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::setHasBorderTexels):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium:

Update test due to changing API. Add a test for changing border
texel option on TilingData.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

9:00 AM Changeset in webkit [103943] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
​https://bugs.webkit.org/show_bug.cgi?id=75474

Reviewed by Philippe Normand.

  • Scripts/run-gtk-tests: Ignore files whose name does not start

with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).

8:52 AM Changeset in webkit [103942] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Tools

[Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=75472

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-03
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
8:25 AM Changeset in webkit [103941] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Source/ThirdParty

Add Production configuration to gtest Xcode project
<​http://webkit.org/b/75153>

Reviewed by Adam Roben.

  • gtest/README.WebKit: Updated.
  • gtest/xcode/Config/ProductionProject.xcconfig: Added.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:
  • Added Production configuration based on Release configuration.
  • Made Production the default configuration.
8:20 AM Changeset in webkit [103940] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Tools

[Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=75471

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-03
Reviewed by Tor Arne Vestbø.

Add simple UI for JavaScript Alert dialogs. This patch also adds a
simple DialogButton QML type and a Dialog QML type which will be
reusable for other JavaScript dialogs.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/AlertDialog.qml: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/Dialog.qml: Added.
  • MiniBrowser/qt/qml/DialogButton.qml: Added.
8:06 AM Changeset in webkit [103939] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] MiniBrowser doesn't show url bar
​https://bugs.webkit.org/show_bug.cgi?id=75470

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-01-03
Reviewed by Tor Arne Vestbø.

  • MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed

on QtDeclarative (QTBUG-23422).

8:04 AM Changeset in webkit [103938] by Carlos Garcia Campos
  • 19 edits
    1 delete in trunk

[GTK] Simplify loader client WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=74605

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Remove WebKitWebLoaderClient from public API keeping it as a
private object. Loading API has been reduced to two signals in
WebKitWebView.

  • GNUmakefile.am: Remove WebKitWebLoaderClientPrivate.h.
  • UIProcess/API/gtk/WebKitDefines.h: Remove forward delcarations

that are no longer needed.

  • UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(didStartProvisionalLoadForFrame): Emit
WebKitWebView::load-changed signal with Started event.
(didReceiveServerRedirectForProvisionalLoadForFrame): Emit
WebKitWebView::load-changed signal with Redirected event.
(didFailProvisionalLoadWithErrorForFrame): Emit
WebKitWebView::load-failed signal with Started event.
(didCommitLoadForFrame): Emit WebKitWebView::load-changed signal
with Committed event.
(didFinishLoadForFrame): Emit WebKitWebView::load-changed signal
with Finished event.
(didFailLoadWithErrorForFrame): Emit WebKitWebView::load-failed
signal with Committed event.
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):

  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Remove public API and

move private API here.

  • UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h: Removed.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail): Default implementation of
WebKitWebView::load-failed signal to show a custom error page.
(webkit_web_view_class_init): Add load-changed and load-failed
signals.
(webkitWebViewLoadChanged): Emit WebKitWebView::load-changed with
the given event.
(webkitWebViewLoadFailed): Emit WebKitWebView::load-failed signal
with the given event, failing uri and error.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Remove loader

client section.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Remove loader

client symbols.

  • UIProcess/API/gtk/docs/webkit2gtk.types: Remove

webkit_web_loader_client_get_type.

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(loadChangedCallback):
(loadFailedCallback):
(LoadTrackingTest::LoadTrackingTest):
(LoadTrackingTest::~LoadTrackingTest):
(LoadTrackingTest::provisionalLoadStarted):
(LoadTrackingTest::provisionalLoadReceivedServerRedirect):
(LoadTrackingTest::provisionalLoadFailed):
(LoadTrackingTest::loadCommitted):
(LoadTrackingTest::loadFinished):
(LoadTrackingTest::loadFailed):

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testLoadingError):
(LoadStopTrackingTest::loadCommitted):
(LoadStopTrackingTest::loadFailed):
(testLoadCancelled):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(beforeAll):

  • UIProcess/API/gtk/webkit2.h: Remove loader client header.
  • UIProcess/API/gtk/webkit2marshal.list:

Tools:

  • gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now

private API.

7:46 AM Changeset in webkit [103937] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::destroy):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::destroy):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::destroy):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::destroy):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::destroy):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::destroy):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):

6:15 AM Changeset in webkit [103936] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Fix scrollbars size with GTK+ 3.x
​https://bugs.webkit.org/show_bug.cgi?id=75467

Reviewed by Xan Lopez.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStyleContext): Add the style class for the given
widget type to the GtkWidgetPath when creating GtkStyleContext
objects.

4:45 AM Changeset in webkit [103935] by vestbo@webkit.org
  • 7 edits in trunk

[Qt] Clean up detection of fontconfig

We decide in features.prf whether or not fontconfig is available, and
set the HAVE_FONTCONFIG define accordingly. All leaf project files
should use this define to decide whether or not to link against
fontconfig, not do their own detection.

We don't need to add link_pkgconfig to CONFIG in each project file,
as we selectivly enable that configuration in defaults_post when
needed.

Reviewed by Ossy.

4:41 AM WebKit Team edited by hclam@chromium.org
(diff)
4:39 AM Changeset in webkit [103934] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

getComputedStyle for outline is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=75441

Reviewed by Antonio Gomes.

Source/WebCore:

Implement getComputedStyle for outline.

Test: fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html: Added.
4:37 AM Changeset in webkit [103933] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=75468
Suppress layout test failure due to a new test.

Unreviewed, build fix.

  • platform/chromium/test_expectations.txt:
3:41 AM Changeset in webkit [103932] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Introduce qmake replace function for the active build config

Reviewed by Ossy.

2:03 AM Changeset in webkit [103931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] tst_favIconLoad.qml crashes on debug mode
​https://bugs.webkit.org/show_bug.cgi?id=75448

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-01-03
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Loads

"about:blank" instead of an empty url between tests to clean favicon.

2:02 AM Changeset in webkit [103930] by jchaffraix@webkit.org
  • 1 edit
    12 copies in branches/chromium/912

Merge 100661 - CSS table with 100% width can overflow their containing block
​https://bugs.webkit.org/show_bug.cgi?id=72180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html

fast/table/table-in-table-percent-width-collapsing-border.html
fast/table/table-in-table-percent-width-quirks-mode.html
fast/table/table-in-table-percent-width.html

After r97555, we would include the borders in a CSS table's logical width even if the 'width'
property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
this behavior to percent 'width'.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

Several tests to check that we don't overflow our containing block with width: 100%.

  • fast/table/table-in-table-percent-width-collapsing-border-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width-collapsing-border.html: Added.
  • fast/table/table-in-table-percent-width-expected.png: Added.
  • fast/table/table-in-table-percent-width-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.png: Added.
  • fast/table/table-in-table-percent-width-quirks-mode-expected.txt: Added.
  • fast/table/table-in-table-percent-width-quirks-mode.html: Added.
  • fast/table/table-in-table-percent-width.html: Added.

TBR=​jchaffraix@webkit.org
Review URL: ​http://codereview.chromium.org/9014010

1:17 AM Changeset in webkit [103929] by Carlos Garcia Campos
  • 9 edits in trunk

[GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
​https://bugs.webkit.org/show_bug.cgi?id=75435

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/gtk/GtkVersioning.c:

(getScreenCurrentDesktop):
(getScreenWorkArea):
(gdk_screen_get_monitor_workarea): Implement it when GTK+ < 3.3.6.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenAvailableRect): Use
gdk_screen_get_monitor_workarea() instead of our own
implementation.

Source/WebKit/gtk:

  • GNUmakefile.am: Make sure unit tests link to X11.

Tools:

  • GNUmakefile.am: Make sure DRT links to X11.
  • WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
12:10 AM Changeset in webkit [103928] by Philippe Normand
  • 2 edits in trunk/Tools

[WK2][GTK] WebSettings support in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=73773

Reviewed by Martin Robinson.

Patch heavily inspired from the WebKit GtkLauncher to support
command-line WebSettings. Example: --enable-fullscreen=TRUE.
The full list of options can be consulted with --help-websettings.

  • MiniBrowser/gtk/main.c:

(loadURI):
(parseOptionEntryCallback):
(isValidParameterType):
(getOptionEntriesFromWebKitSettings):
(addSettingsGroupToContext):
(main):

12:04 AM Changeset in webkit [103927] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] GtkLauncher settings improvements
​https://bugs.webkit.org/show_bug.cgi?id=75439

Reviewed by Martin Robinson.

  • GtkLauncher/main.c:

(filenameToURL): We can use NULL in C.
(isValidParameterType): Utility function to filter GParamTypes
that can be edited.
(getOptionEntriesFromWebKitWebSettings): Avoid handling
construct-only properties and use the isValidParameterType
function. Makes the code a bit cleaner.

Jan 2, 2012:

11:00 PM Changeset in webkit [103926] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Check in fixes for jsc tests following bug #75455.

  • tests/mozilla/ecma/GlobalObject/15.1.2.2-1.js:
  • tests/mozilla/ecma/GlobalObject/15.1.2.2-2.js:
10:56 PM Changeset in webkit [103925] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a typo I made in r103871.

Fixes <​http://webkit.org/b/75450> Inline PDF doesn't preview correctly when attempting to print its frame

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToPDF): Changed USE(GC) to USE(CG).

10:56 PM Changeset in webkit [103924] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=75452
If argument to Error is undefined, message is not set

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Per section 15.11.1.1 of the spec.

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create):
(JSC::ErrorInstance::finishCreation):

LayoutTests:

Added test case.

  • fast/js/native-error-prototype-expected.txt:
  • fast/js/script-tests/native-error-prototype.js:
9:45 PM Changeset in webkit [103923] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r103919): Remove resolve-supplemental.pl from the WebCore target in Xcode
​https://bugs.webkit.org/show_bug.cgi?id=75458

Reviewed by Adam Barth.

At r103919, we added resolve-supplemental.pl to WebCore.framework/Resources,
but we should have added it to the project without adding it to any target.
This patch fixes it.

No tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
8:32 PM Changeset in webkit [103922] by barraclough@apple.com
  • 7 edits in trunk

ES5 prohibits parseInt from supporting octal
​https://bugs.webkit.org/show_bug.cgi?id=75455

Reviewed by Sam Weinig.

See sections 15.1.2.2 and annex E.

Source/JavaScriptCore:

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):

LayoutTests:

  • fast/js/kde/GlobalObject-expected.txt:
  • fast/js/kde/script-tests/GlobalObject.js:
    • Change test to check for correct result.
  • sputnik/Implementation_Diagnostics/S15.1.2.2_D1.1-expected.txt:
  • sputnik/Implementation_Diagnostics/S15.1.2.2_D1.2-expected.txt:
    • One test asserts parseInt handles octal, one asserts it does not! This patch switches which one passes & which fails.
6:36 PM Changeset in webkit [103921] by barraclough@apple.com
  • 4 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=55343
Global JSON should be configurable but isn't

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • make JSON configurable

LayoutTests:

  • ietestcenter/Javascript/11.4.1-4.a-8-expected.txt:
    • check in passing result
5:24 PM Changeset in webkit [103920] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on GTK/GObject
​https://bugs.webkit.org/show_bug.cgi?id=75411

Reviewed by Adam Barth.

This patch enables the [Supplemental] IDL on GObject bindings of GTK
by changing the build flow of bindings/gobject/GNUmakefile.am as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
4:57 PM Changeset in webkit [103919] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Add resolve-supplemental.pl to project.pbxproj
​https://bugs.webkit.org/show_bug.cgi?id=75426

Reviewed by Adam Barth.

We should have added "resolve-supplemental.pl" to build scripts of AppleWebKit
when we enabled the [Supplemental] IDL on AppleWebKit at r103519.
This is a follow-up patch for it.

No tests. Just confirm that the AppleWebKit build passes.

  • WebCore.xcodeproj/project.pbxproj:
4:44 PM Changeset in webkit [103918] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Add resolve-supplemental.pl to build scripts of AppleWin
​https://bugs.webkit.org/show_bug.cgi?id=75412

Reviewed by Adam Barth.

We should have added "resolve-supplemental.pl" to build scripts of AppleWin
when we enabled the [Supplemental] IDL on AppleWin at r103519.
This is a follow-up patch for it.

No tests. Just confirm that the AppleWin build passes.

  • WebCore.vcproj/MigrateScripts:
  • WebCore.vcproj/WebCore.vcproj:
4:39 PM Changeset in webkit [103917] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Windows build (again).

  • Platform/CoreIPC/Connection.h:
3:59 PM Changeset in webkit [103916] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix windows build.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp:
  • Platform/RunLoop.h:

Missing declarations/includes of BinarySemaphore.

3:55 PM Changeset in webkit [103915] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • bindings/scripts/CodeGeneratorJS.pm:
3:41 PM Changeset in webkit [103914] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after r103888.

  • WebCore.vcproj/WebCore.vcproj: Remove CollectionCache.{cpp, h} from

the WebCore vcproj.

3:31 PM Changeset in webkit [103913] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r100517): We're leaking many, many DOM objects!
​https://bugs.webkit.org/show_bug.cgi?id=75451

Reviewed by Mark Rowe.

  • bindings/scripts/CodeGeneratorJS.pm:

Add a temporary workaround to the problem of handle finalizers
not getting called by adding back the destructors (or rather
their replacement, destroy() functions).

3:08 PM Changeset in webkit [103912] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

Move dispatchSentMessagesUntil out of the RunLoop class.
​https://bugs.webkit.org/show_bug.cgi?id=75320

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::waitWhileDispatchingSentWin32Messages):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::dispatchSentMessagesUntil):

  • Platform/win/RunLoopWin.cpp:
1:09 PM Changeset in webkit [103911] by gyuyoung.kim@samsung.com
  • 6 edits in trunk

[EFL] Remove whitespace/declaration style exception
​https://bugs.webkit.org/show_bug.cgi?id=75424

Reviewed by David Levin.

Source/WebKit/efl:

EFL port doesn't need to avoid *whitespace/declaration* exception because of coding
style change. However, EWebLauncher and MiniBrowser need to use EFL coding style because
they are EFL application.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_invalidate):

  • ewk/ewk_view.cpp:

Tools:

Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
application. So, they still need to use EFL coding style.

  • Scripts/webkitpy/style/checker.py:
11:18 AM Changeset in webkit [103910] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit/mac

[mac] Remove -[WebView setHoverFeedbackSuspended:]
​https://bugs.webkit.org/show_bug.cgi?id=75406

Reviewed by Tim Hatcher.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.

  • WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
  • WebView/WebView.mm:

(-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
Safari that call this.
(-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
versions of Safari that call this.

  • WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
  • WebView/WebViewPrivate.h: Removed method definitions.
11:06 AM BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
Add extra file to remove linux-g++-maemo from. Enables Maliit keyboard. (diff)
10:04 AM Changeset in webkit [103909] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • Platform/mac/SharedMemoryMac.cpp:
8:26 AM Changeset in webkit [103908] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebKit2

2012-01-02 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix build on Lion, by including mach_error.h in two places that need it.

  • PluginProcess/mac/PluginProcessMainMac.mm:
  • WebProcess/mac/WebProcessMainMac.mm:
7:39 AM Changeset in webkit [103907] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix chromium mac build after r103905
​https://bugs.webkit.org/show_bug.cgi?id=75436

Reviewed by Csaba Osztrogonác.

Adding parenthesis to disambiguate because clang gives error
"expression is not assignable".

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

6:56 AM Changeset in webkit [103906] by Carlos Garcia Campos
  • 5 edits
    5 adds in trunk

[GTK] Add a way to change web view settings in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71568

Reviewed by Philippe Normand.

.:

  • GNUmakefile.am: Initialize minibrowser_built_sources.

Tools:

Add a preferences button to the toolbar that shows a dialog to
change settings of the current web view. It uses a GtkTreeView
with a custom cell renderer to support multiple types of values.

  • MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.

(browserCellRendererVariantFinalize):
(browserCellRendererVariantGetProperty):
(browserCellRendererVariantSetModeForValue):
(browserCellRendererVariantSetProperty):
(browserCellRendererVariantGetRendererForValue):
(browserCellRendererVariantCellRendererTextEdited):
(browserCellRendererVariantCellRendererSpinEdited):
(browserCellRendererVariantCellRendererActivate):
(browserCellRendererVariantCellRendererRender):
(browserCellRendererVariantCellRendererStartEditing):
(browserCellRendererVariantCellRendererGetPreferredWidth):
(browserCellRendererVariantCellRendererGetPreferredHeight):
(browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
(browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
(browserCellRendererVariantCellRendererGetAlignedArea):
(browser_cell_renderer_variant_init):
(browser_cell_renderer_variant_class_init):
(browser_cell_renderer_variant_new):

  • MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
  • MiniBrowser/gtk/BrowserSettingsDialog.c: Added.

(cellRendererChanged):
(browserSettingsDialogSetProperty):
(browser_settings_dialog_init):
(browserSettingsDialogConstructed):
(browser_settings_dialog_class_init):
(browser_settings_dialog_new):

  • MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
  • MiniBrowser/gtk/BrowserWindow.c:

(settingsCallback):
(browser_window_init):

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/browser-marshal.list: Added.
6:07 AM Changeset in webkit [103905] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

Use HashMap<OwnPtr> in RenderSVGResourceGradient
​https://bugs.webkit.org/show_bug.cgi?id=75364

Reviewed by Daniel Bates.

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::removeAllClientsFromCache):
(WebCore::RenderSVGResourceGradient::removeClientFromCache):
(WebCore::RenderSVGResourceGradient::applyResource): avoid looking
up the hash twice by using HashMap::add().

  • rendering/svg/RenderSVGResourceGradient.h: rename m_gradient to m_gradientMap.
5:39 AM Changeset in webkit [103904] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Implement create/ready-to-show/close signals in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=74711

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewClose): Destroy the window.
(webViewReadyToShow): Use WindowProperties of the new view to
setup and show the window.
(webViewCreate): Create a new view and add it to a browser window.
(browser_window_init):
(browserWindowConstructed): Connect to WebKitWebView::create signal.

5:23 AM Changeset in webkit [103903] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix qmake warning about unescaped backslashes

Reviewed by Ossy.

4:30 AM Changeset in webkit [103902] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt-WK2 gardening.

Unskip table tests for wk2 after platform results
have been added in r103898.

  • platform/qt-wk2/Skipped:
3:22 AM Changeset in webkit [103901] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] fast/dom/constructed-objects-prototypes.html fails
​https://bugs.webkit.org/show_bug.cgi?id=75432

Unreviewed, mark fast/dom/constructed-objects-prototypes.html as
failing in GTK test_expectations.

  • platform/gtk/test_expectations.txt:
3:09 AM Changeset in webkit [103900] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck issue.

  • GNUmakefile.am: Add resolve-supplemental.pl script to

EXTRA_DIST.

2:49 AM Changeset in webkit [103899] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

fast/dom/htmlcollection-zombies.html fails on GTK and on Qt
​https://bugs.webkit.org/show_bug.cgi?id=75431

Unreviewed gardening. Skip fast/dom/htmlcollection-zombies.html until fix.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:07 AM Changeset in webkit [103898] by Csaba Osztrogonác
  • 188 edits
    13 adds in trunk/LayoutTests

Rebaseline table tests to reflect new width of table captions after r103875
​https://bugs.webkit.org/show_bug.cgi?id=74888

Unreviewed gardening.

  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-absolute-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • platform/qt/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-fixed-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • platform/qt/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/qt/fast/css/caption-width-relative-position-expected.txt: Added.
  • platform/qt/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/qt/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/qt/fast/repaint/table-section-repaint-expected.png: Added.
  • platform/qt/fast/repaint/table-section-repaint-expected.txt:
  • platform/qt/fast/table/frame-and-rules-expected.png:
  • platform/qt/fast/table/frame-and-rules-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.png:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.png:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/qt/tables/mozilla/core/captions-expected.png:
  • platform/qt/tables/mozilla/core/captions-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/test_expectations.txt:
2:01 AM Changeset in webkit [103897] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip two canvas tests failing in GTK after r103849.

  • platform/gtk/Skipped: Skip canvas/philip/tests/2d.pattern.image.string.html

and canvas/philip/tests/2d.pattern.image.undefined.html that need
to be updated.

1:59 AM Changeset in webkit [103896] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
​https://bugs.webkit.org/show_bug.cgi?id=75430

  • platform/chromium/test_expectations.txt:
1:52 AM Changeset in webkit [103895] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=75376

Unreviewed gardening after r103849 to paint the bot green.

  • platform/qt/Skipped: Skip canvas/philip/tests/2d.pattern.image.string.html

and canvas/philip/tests/2d.pattern.image.undefined.html until proper fix.

1:07 AM Changeset in webkit [103894] by Philippe Normand
  • 102 edits
    6 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r103251 and r103875.

  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-relative-position-expected.txt: Added.
  • platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/gtk/fast/repaint/table-section-repaint-expected.txt:
  • platform/gtk/fast/table/frame-and-rules-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/gtk/tables/mozilla/core/captions-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
12:42 AM Changeset in webkit [103893] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Clear HTMLCollection's internal cache on construction.
<​http://webkit.org/b/75423>

Reviewed by Antti Koivisto.

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):

12:40 AM Changeset in webkit [103892] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping tests needing a GTK rebaseline.

  • platform/gtk/test_expectations.txt:

Jan 1, 2012:

10:46 PM Changeset in webkit [103891] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source

[EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=75292

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2012-01-01
Reviewed by Andreas Kling.

Move ewk_util_dpi_get() function in the ewk_util.cpp to the
WebCore/platform/efl/EflScreenUtilities.cpp in order to use it in the WebKit2.
The function's name is changed to getDPI().

Source/WebCore:

  • PlatformEfl.cmake:
  • platform/efl/EflScreenUtilities.cpp: Added.

(WebCore::getDPI):

  • platform/efl/EflScreenUtilities.h: Added.

Source/WebKit/efl:

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp:

(ewk_util_image_from_cairo_surface_add):

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):

10:33 PM Changeset in webkit [103890] by thakis@chromium.org
  • 2 edits
    3 moves
    1 add in trunk/LayoutTests

[chromium] need win/linux baselines for patch from issue 69694
​https://bugs.webkit.org/show_bug.cgi?id=69791

Unreviewed, expectations update.

  • platform/chromium-win/plugins/iframe-plugin-bgcolor-expected.txt: Renamed from LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt.
  • platform/chromium/plugins/iframe-plugin-bgcolor-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/plugins/iframe-plugin-bgcolor-expected.png: Renamed from LayoutTests/plugins/iframe-plugin-bgcolor-expected.png.
  • plugins/iframe-plugin-bgcolor-expected.txt: Renamed from LayoutTests/platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt.
5:01 PM Changeset in webkit [103889] by atwilson@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed test expectations change for chromium.

  • platform/chromium-linux/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-linux/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-linux/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-linux/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-linux/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-linux/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
4:37 PM Changeset in webkit [103888] by kling@webkit.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

Merge CollectionCache into HTMLCollection.
<​http://webkit.org/b/75423>

Reviewed by Anders Carlsson.

  • Move the members of CollectionCache into HTMLCollection.
  • Renamed resetCollectionInfo() to invalidateCacheIfNeeded().
  • Removed a bunch of overkill HashMap::checkConsistency() calls.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CollectionCache.cpp: Removed.
  • html/CollectionCache.h: Removed.

Remove CollectionCache.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::append):

  • html/HTMLCollection.h:
  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::nextItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):

HTMLCollection's m_info and info() become "struct m_cache" (protected.)

  • html/HTMLOptionsCollection.cpp:
  • html/HTMLOptionsCollection.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setRecalcListItems):

Expose HTMLCollection::invalidateCacheIfNeeded() so we can call it from
HTMLSelectElement::setRecalcListItems().

  • html/HTMLFormCollection.h:

Remove stale declaration of formCollectionInfo() which no longer exists.

4:33 PM Changeset in webkit [103887] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Call instructions should leave room for linking information
​https://bugs.webkit.org/show_bug.cgi?id=75422
<rdar://problem/10633985>

Reviewed by Oliver Hunt.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

3:40 PM Changeset in webkit [103886] by kling@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, checking in missing update to gc-9.html from r103883.

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
1:41 PM Changeset in webkit [103885] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r103877.
​https://bugs.webkit.org/show_bug.cgi?id=75418

  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [103884] by mnaganov@chromium.org
  • 383 edits
    488 adds in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r103875.
​https://bugs.webkit.org/show_bug.cgi?id=74888

  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/captions-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:
1:05 PM Changeset in webkit [103883] by kling@webkit.org
  • 19 edits
    2 adds
    8 deletes in trunk

Move the remaining collections to caching on their respective base nodes.
<​http://webkit.org/b/75416>

Reviewed by Anders Carlsson.

Source/WebCore:

Add a (lazily-allocated) array of HTMLCollections to ElementRareData and cache
the various collections on their base node rather than recreating them every time.

Test: fast/dom/collection-idempotence.html

fast/dom/gc-9.html

  • html/CollectionType.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::hasCachedHTMLCollections):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):

Plumbing to cache HTMLCollections on ElementRareData.

(WebCore::Element::~Element):

Detach any cached collections from an element when it's destroyed.

  • html/HTMLCollection.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::detachFromNode):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):

  • dom/Document.cpp:

(WebCore::Document::cachedCollection):

Consolidate the HTMLCollection constructors and get rid of the hacks to
optionally retain the base node.

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::areas):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::rows):

Cached collections!

LayoutTests:

  • Updated gc-9.html to document the new lifetime behavior of HTMLCollections.
  • Merged all the *collection-idempotence.html tests into a big one and added tests for the newly changed collections.
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/collection-idempotence-expected.txt: Added.
  • fast/dom/collection-idempotence.html: Added.
  • fast/dom/document-collection-idempotence-expected.txt: Removed.
  • fast/dom/document-collection-idempotence.html: Removed.
  • fast/dom/form-elements-collection-idempotence-expected.txt: Removed.
  • fast/dom/form-elements-collection-idempotence.html: Removed.
  • fast/dom/select-options-collection-idempotence-expected.txt: Removed.
  • fast/dom/select-options-collection-idempotence.html: Removed.
  • fast/dom/table-rows-collection-idempotence-expected.txt: Removed.
  • fast/dom/table-rows-collection-idempotence.html: Removed.
12:56 PM Changeset in webkit [103882] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/WebCore

Use overload methods to implement [Optional] parameters in AudioNode.idl
​https://bugs.webkit.org/show_bug.cgi?id=75402

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-01-01
Reviewed by Adam Barth.

No new tests required.

  • GNUmakefile.list.am:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioNodeCustom.cpp: Removed.
  • bindings/v8/custom/V8AudioNodeCustom.cpp: Removed.
  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):

  • webaudio/AudioNode.h:
  • webaudio/AudioNode.idl:
12:12 PM Changeset in webkit [103881] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Layout divergence between WK1/2 in table tests
​https://bugs.webkit.org/show_bug.cgi?id=75417

Unreviewed new year gardening.
Skip failing tests for now.

  • platform/qt-wk2/Skipped:
11:44 AM Changeset in webkit [103880] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

EnvironmentUtilities::stripValuesEndingWithString enters an infinite loop if the search value
occurs a component other than the first.

Reviewed by Anders Carlsson.

  • Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString): Changed to start the search for
the next colon after the current colon.

11:24 AM Changeset in webkit [103879] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Improved reproting of kernel return codes.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::exceptionSourceEventHandler): Added the error string to the log message.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create): Ditto.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Ditto. Also changed to log to stderr.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

11:03 AM Changeset in webkit [103878] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Final update to Chromium expectations for Mac and Win following r103875.
The failures are IMAGE only, rather than IMAGE+TEXT.

Unreviewed.

  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [103877] by robert@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

Update to expectations from r103875

Unreviewed, expectations update.

Remove the reference result for border-collapse-offset-002.htm since
it does not work on two platforms. Fix the chromium expectations file
for Mac and Win builds.

  • css2.1/20110323/border-collapse-offset-002-expected.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
8:59 AM Changeset in webkit [103876] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

Update test expectations after r103875

Unreviewed.

Skip tests on Apple Win that need to be rebaselined as the bot is not using
new-run-webkit-tests.
Rendering of ahem font seems to differ between ports so mark new tests added
om r103875 for rebaselining.
I missed fast/table/frame-and-rules.html as requiring rebaseline as it was
already marked as failing in Chromium Linux.
Mac and GTK render the reference result for border-collapse-offset-002.htm
differently from other ports, so mark it as requiring rebaseline for those
ports.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
7:12 AM Changeset in webkit [103875] by robert@webkit.org
  • 19 edits
    22 adds in trunk

CSS 2.1 failure: border-collapse-offset-002.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=71705

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: css2.1/20110323/border-collapse-offset-002-expected.html

fast/css/caption-width-absolute-position-offset-top.htm
fast/css/caption-width-absolute-position.htm
fast/css/caption-width-fixed-position-offset-top.htm
fast/css/caption-width-fixed-position.htm
fast/css/caption-width-relative-position-offset-top.htm
fast/css/caption-width-relative-position.htm

Table captions are implemented as children of the table but have a special
requirement to expand to the full width of the table rather than just the 'available'
width, i.e. the full width minus padding and borders.

To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
to return the full width of the containing block (i.e. the table) rather than the available width.

  • CMakeLists.txt: Add RenderTableCaption.[cpp|h]
  • GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
  • Target.pri: Add RenderTableCaption.[cpp|h]
  • WebCore.gypi: Add RenderTableCaption.[cpp|h]
  • WebCore.vcproj/WebCore.vcproj: Add RenderTableCaption.[cpp|h]
  • WebCore.xcodeproj/project.pbxproj: Add RenderTableCaption.[cpp|h]
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
(WebCore::RenderObject::addChild): ditto

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp: Added.

(WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
(WebCore::RenderTableCaption::~RenderTableCaption):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.

  • rendering/RenderTableCaption.h: Added.

(WebCore::RenderTableCaption::isTableCaption):
(WebCore::toRenderTableCaption):

  • rendering/RenderingAllInOne.cpp:

LayoutTests:

Table captions now use the width of the table rather than the width of the table minus
the borders. This allows captions to center accurately but unfortunately a lot of mozilla
table tests need to be rebaselined as many of them use captions for explaining the purpose
of individual test files!

Add border-collapse-offset-002.htm which now renders correctly.

  • css2.1/20110323/border-collapse-offset-002-expected.html: Added.
  • css2.1/20110323/border-collapse-offset-002.htm: Added.
  • fast/css/caption-width-absolute-position-expected.png: Added.
  • fast/css/caption-width-absolute-position-expected.txt: Added.
  • fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • fast/css/caption-width-absolute-position-offset-top.htm: Added.
  • fast/css/caption-width-absolute-position.htm: Added.
  • fast/css/caption-width-fixed-position-expected.png: Added.
  • fast/css/caption-width-fixed-position-expected.txt: Added.
  • fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • fast/css/caption-width-fixed-position-offset-top.htm: Added.
  • fast/css/caption-width-fixed-position.htm: Added.
  • fast/css/caption-width-relative-position-expected.png: Added.
  • fast/css/caption-width-relative-position-expected.txt: Added.
  • fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • fast/css/caption-width-relative-position-offset-top.htm: Added.
  • fast/css/caption-width-relative-position.htm: Added.
  • platform/chromium/test_expectations.txt: Suppress affected table tests until rebaselined.
  • platform/gtk/test_expectations.txt: ditto
  • platform/mac/test_expectations.txt: ditto
  • platform/qt/test_expectations.txt: ditto
  • platform/win/test_expectations.txt: ditto
1:43 AM Changeset in webkit [103874] by haraken@chromium.org
  • 1 edit
    6 adds in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMTestSupplemental.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestSupplemental.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestSupplemental.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestSupplemental.h: Added.
  • bindings/scripts/test/ObjC/DOMTestSupplemental.cpp: Added.
  • bindings/scripts/test/ObjC/DOMTestSupplemental.h: Added.
Note: See TracTimeline for information about the timeline view.