Timeline
Jan 10, 2012:
- 11:53 PM Changeset in webkit [104676] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Merge 104563 - Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
TBR=pfeldman@chromium.org
BUG=109730
Review URL: http://codereview.chromium.org/9187001
- 11:14 PM Changeset in webkit [104675] by
-
- 2 edits in trunk/Source/WebCore
Build fix. Forgot to revert Node.h.
- dom/Node.h:
- 11:03 PM Changeset in webkit [104674] by
-
- 10 edits in trunk/Source/WebCore
Revert r104210. It turned out that this patch makes improving the node list caches harder.
- dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicSubtreeNodeList::Caches::create):
(WebCore::DynamicSubtreeNodeList::Caches::reset):
- dom/DynamicNodeList.h:
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::itemTypeAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
- dom/NodeRareData.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::parseMappedAttribute):
- html/HTMLLabelElement.h:
- 10:57 PM Changeset in webkit [104673] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r104263 and r104381.
http://trac.webkit.org/changeset/104263
http://trac.webkit.org/changeset/104381
https://bugs.webkit.org/show_bug.cgi?id=76029
Preparation to rollout r104210 (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10
Source/WebCore:
- dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):
- dom/DynamicNodeList.h:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):
LayoutTests:
- fast/dom/node-list-length-after-removing-node-expected.txt: Removed.
- fast/dom/node-list-length-after-removing-node.html: Removed.
- 10:20 PM Changeset in webkit [104672] by
-
- 2 edits in trunk/Websites/webkit.org
[Website] i-Bench is no longer available.
https://bugs.webkit.org/show_bug.cgi?id=76027
Reviewed by Ryosuke Niwa.
Updated the availability information of i-Bench.
- projects/performance/index.html:
- 10:07 PM Changeset in webkit [104671] by
-
- 4 edits2 adds in trunk
Add TestWebKitAPI tests for KURL
<http://webkit.org/b/75774>
Reviewed by Adam Barth.
Source/WebCore:
- WebCore.exp.in: Export additional KURL methods used in
testing.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
WebCore folder and KURL.cpp source file to the project.
- TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
(TestWebKitAPI::WebCore::SetUp): Initialize the main thread
during setup since this test doesn't go through WebKit or
WebKit2.
(TestWebKitAPI::TEST_F): Add two basic tests.
- 10:07 PM Changeset in webkit [104670] by
-
- 3 edits1 add in trunk/Tools
Extract common code for comparing WTF::String objects into WTFStringUtilities.h
Reviewed by Adam Barth.
Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
WTFStringUtilities.h to the project.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
WTFStringUtilities.h.
- TestWebKitAPI/WTFStringUtilities.h: Added.
(WTF::operator<<):
- 9:34 PM Changeset in webkit [104669] by
-
- 2 edits in trunk/Source/WebCore
Crash in HTMLMediaElement::shouldDisableSleep()
https://bugs.webkit.org/show_bug.cgi?id=76025
Reviewed by Dan Bernstein.
Check nullity of m_player before dereferencing.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldDisableSleep):
- 9:03 PM Changeset in webkit [104668] by
-
- 11 edits3 adds in trunk
Source/WebCore: A radio button not in a document should not join a radio button group
https://bugs.webkit.org/show_bug.cgi?id=45719
Reviewed by Darin Adler.
As per the standard and other browser behaviors, we should not add a
radio button not in a document to a radio button group.
So, CheckedRadioButton member functions should be called in
insertedIntoDocument() and removedFromDocument(), and they should do
nothing if the specified radio button is not in a document.
This change also fixes a bug that form owner change by 'form' attribute
didn't update radio button groups correctly.
Test: fast/forms/radio/radio-group.html
- dom/CheckedRadioButtons.cpp:
(WebCore::shouldMakeRadioGroup): A helper function to check <input> state.
(WebCore::CheckedRadioButtons::addButton):
- Change the argument type: HTMLFormControlElement* -> HTMLInputElement*.
- Use shouldMakeRadioGroup().
(WebCore::CheckedRadioButtons::removeButton): ditto.
- dom/CheckedRadioButtons.h: Change the argument types of addButton() and removeButton(): HTMLFormControlElement* -> HTMLInputElement*.
- html/FormAssociatedElement.cpp: Do not update m_form except in setForm() and formWillBeDestroyed(). This helps us to call registerFormElement() and removeFromElement() correctly, and call willChangeForm()/didChangeForm() hooks correctly.
(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::~FormAssociatedElement):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::removedFromTree):
(WebCore::FormAssociatedElement::setForm):
(WebCore::FormAssociatedElement::willChangeForm):
This virtual function is called before the owner form is updated.
(WebCore::FormAssociatedElement::didChangeForm):
This virtual function is called after the owner form was updated.
(WebCore::FormAssociatedElement::formWillBeDestroyed):
- Renamaed from formDestroyed()
- Add calls to willChangeForm() and didChangeForm().
(WebCore::FormAssociatedElement::resetFormOwner): Use setForm().
(WebCore::FormAssociatedElement::formAttributeChanged): ditto.
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement): Use setForm().
(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
removeFormElement() is not needed. ~FormAssociatedElement() treats it.
(WebCore::HTMLFormControlElement::parseMappedAttribute):
No need to handle CheckedRadioButtons here. It is handled by HTMLInputElement.
(WebCore::HTMLFormControlElement::insertedIntoTree): ditto.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
Rename formDestroyed() with willDestroyForm().
(WebCore::HTMLFormElement::registerFormElement):
We don't need to handle radio button groups here.
(WebCore::HTMLFormElement::removeFormElement): ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
Calls setForm(0) so that it calls correct virtual functions of
HTMLInputElement.
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
Checking attached() was wrong.
(WebCore::HTMLInputElement::willChangeForm):
Remove this radio button from a radio button group for the old form.
(WebCore::HTMLInputElement::didChangeForm):
Add this radio button to a radio button group for the new form.
(WebCore::HTMLInputElement::insertedIntoDocument):
Add CheckedRadioButtons::addButton() call.
(WebCore::HTMLInputElement::removedFromDocument):
Add CheckedRadioButtons::removeButton() call.
(WebCore::HTMLInputElement::didMoveToNewDocument):
We don't need to handle CheckedRadioButton() here because
removedFromDocument() handles it.
- html/HTMLInputElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement): Use setForm().
(WebCore::HTMLObjectElement::~HTMLObjectElement):
removeFormElement() is not needed. ~FormAssociatedElement() treats it.
LayoutTests: A radio button not in a Document should not join a radio button group
https://bugs.webkit.org/show_bug.cgi?id=45719
Reviewed by Darin Adler.
- fast/forms/radio/radio-group-expected.txt: Added.
- fast/forms/radio/radio-group.html: Added.
- 9:02 PM Changeset in webkit [104667] by
-
- 2 edits in tags/Safari-535.15.2/Source/JavaScriptCore
Merge r104664.
- 9:02 PM Changeset in webkit [104666] by
-
- 5 edits in tags/Safari-535.15.2/Source
Versioning.
- 8:51 PM Changeset in webkit [104665] by
-
- 1 copy in tags/Safari-535.15.2
New tag.
- 8:50 PM Changeset in webkit [104664] by
-
- 2 edits in trunk/Source/JavaScriptCore
<rdar://problem/10673792> jsc should install directly in to versioned Resources subfolder
This ensures that jsc ends up in a consistent location whether built in to the same DSTROOT
as JavaScriptCore.framework or in to a different one.
Rubber-stamped by Dan Bernstein.
- Configurations/JSC.xcconfig: Update INSTALL_PATH.
- 8:50 PM Changeset in webkit [104663] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r104377): All pages print blank on Snow Leopard
<http://webkit.org/b/75879> / <rdar://problem/10674335>
We need to explicitly load PDFKit.framework before using PDFDocument and friends.
On SnowLeopard the framework is not necessarily loaded by anything else before we
print, which would lead to us failing to allocate the PDFDocument that we use for
drawing the content from the web process.
Reviewed by Dan Bernstein.
- UIProcess/API/mac/WKPrintingView.mm:
(pdfKitFrameworkPath): Construct the path to the PDFKit framework.
(classFromPDFKit): Ensure that the PDFKit framework is loaded, and then retrieve the
given class from it.
(pdfAnnotationLinkClass): ASSERT that we found the class.
(pdfDocumentClass): Ditto.
- 7:52 PM Changeset in webkit [104662] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskiping more passing tests
https://bugs.webkit.org/show_bug.cgi?id=46249
Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2012-01-10
Reviewed by Eric Seidel.
- platform/qt/Skipped:
- 7:36 PM Changeset in webkit [104661] by
-
- 2 edits in trunk/Source/WebKit/mac
Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver.
Reviewed by Mark Rowe.
- History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
- 6:54 PM Changeset in webkit [104660] by
-
- 3 edits3 adds in trunk
DFG inlining block linking compares BlockIndex against bytecode index
https://bugs.webkit.org/show_bug.cgi?id=76018
<rdar://problem/10671979>
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
LayoutTests:
- fast/js/dfg-inline-many-blocks-expected.txt: Added.
- fast/js/dfg-inline-many-blocks.html: Added.
- fast/js/script-tests/dfg-inline-many-blocks.js: Added.
(stuff):
(foo):
(fuzz):
(baz):
(bar):
- 6:04 PM Changeset in webkit [104659] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant code from DOMWindowSQLDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=76010
Reviewed by Adam Barth.
This patch removes redundant code from DOMWindowSQLDatabase.cpp.
- Remove window->frame() check, since window->frame() is always true when window->isCurrentlyDisplayedInFrame() is true.
- window->frame()->document() can just be window->document()
Tests: storage/open-database-creation-callback-isolated-world.html
storage/open-database-creation-callback.html
storage/open-database-empty-version.html
storage/open-database-over-quota.html
storage/open-database-set-empty-version.html
storage/open-database-while-transaction-in-progress.html
- storage/DOMWindowSQLDatabase.cpp:
(WebCore::DOMWindowSQLDatabase::openDatabase):
- 5:51 PM Changeset in webkit [104658] by
-
- 12 edits3 adds in trunk
Repaint video controls when buffering during pause.
https://bugs.webkit.org/show_bug.cgi?id=73957
Source/WebCore:
Pipes support for a new bufferingProgressed() method on MediaControls
elements. Allows controls to be repainted as data buffers when paused.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.
Test: http/tests/media/video-buffering-repaints-controls.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::bufferingProgressed):
- html/shadow/MediaControlRootElement.h:
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::bufferingProgressed):
- html/shadow/MediaControlRootElementChromium.h:
- html/shadow/MediaControls.h:
LayoutTests:
Adds video-buffering-repaints-controls test to verify the progress bar
repaints as new data is buffered when paused.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-10
Reviewed by Hajime Morita.
- http/tests/media/video-buffering-repaints-controls.html: Added.
- platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
- platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/win/test_expectations.txt:
- 5:35 PM Changeset in webkit [104657] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed, rolling out r104543.
http://trac.webkit.org/changeset/104543
https://bugs.webkit.org/show_bug.cgi?id=76013
Asserts on Mac 10.6 dbg bots (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10
- css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Removed.
- css3/calc/block-mask-overlay-image-outset.html: Removed.
- css3/calc/resources/mask.png: Removed.
- 5:19 PM Changeset in webkit [104656] by
-
- 4 edits in trunk/Source
2012-01-10 Chris Marrin <cmarrin@apple.com>
Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
Unreviewed.
- 5:19 PM Changeset in webkit [104655] by
-
- 3 edits2 adds in trunk
[chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text
https://bugs.webkit.org/show_bug.cgi?id=75923
Reviewed by Tony Chang.
Source/WebCore:
Test: editing/pasteboard/pasting-empty-html-falls-back-to-text.html
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
LayoutTests:
- editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt: Added.
- editing/pasteboard/pasting-empty-html-falls-back-to-text.html: Added.
- 5:12 PM Changeset in webkit [104654] by
-
- 12 edits3 adds in trunk/Source/WebCore
Use the [Supplemental] IDL in SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=76004
Reviewed by Adam Barth.
We've been working on WebKit modularization. By using the [Supplemental] IDL,
we can move SQLDatabase related code from WebCore/page/DOMWindow.{h,cpp,idl}
to WebCore/storage/DOMWindowSQLDatabase.{h,cpp,idl}.
Tests: storage/open-database-creation-callback-isolated-world.html
storage/open-database-creation-callback.html
storage/open-database-empty-version.html
storage/open-database-over-quota.html
storage/open-database-set-empty-version.html
storage/open-database-while-transaction-in-progress.html
- CMakeLists.txt: Added DOMWindowSQLDatabase.{idl,h,cpp} to the build script.
- DerivedSources.make: Ditto.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/DOMWindow.cpp: Removed SQLDatabase related code.
- page/DOMWindow.idl: Ditto.
- page/DOMWindow.h: Ditto. Moved isCurrentlyDisplayedInFrame() from private: to public:
so that DOMWindowSQLDatabase::openDatabase() can access it.
- storage/DOMWindowSQLDatabase.cpp: Added. Moved openDatabase() from DOMWindow.cpp to here.
(WebCore::DOMWindowSQLDatabase::openDatabase):
- storage/DOMWindowSQLDatabase.h: Added. Moved openDatabase() from DOMWindow.h to here.
- storage/DOMWindowSQLDatabase.idl: Added. Using the [Supplemental] IDL, moved openDatabase()
and SQLException from DOMWindow.idl to here.
- 5:10 PM Changeset in webkit [104653] by
-
- 1 edit2 adds in trunk/LayoutTests
padding test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76005
Reviewed by Darin Adler.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/padding-expected.txt: Added.
- css3/calc/padding.html: Added.
- 5:07 PM Changeset in webkit [104652] by
-
- 5 edits in trunk
CIFilter version of Sepia Tone filter doesn't match software
https://bugs.webkit.org/show_bug.cgi?id=75129
Reviewed by Simon Fraser.
Source/WebCore:
Changed sepia tone filter to use a CIColorMatrix filter with
values that match sw filter.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(interp):
(PlatformCALayer::setFilters):
LayoutTests:
Updated sepia tone results for core image filters on CA layers to match changes. Updated sw results because
they had the wrong color space
- css3/filters/effect-sepia-expected.png:
- css3/filters/effect-sepia-hw-expected.png:
- 4:42 PM Changeset in webkit [104651] by
-
- 6 edits in trunk/Source
[Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash
https://bugs.webkit.org/show_bug.cgi?id=74176
Reviewed by Noam Rosenthal.
Source/WebCore:
Replaces static global GL resource holder with holder shared between
TextureMapperGL instances created on the same GL context. Also adds
deallocation of GL resources when last TextureMapperGL instance on the
current GL context gets deleted.
Tested by multipleWebViewWindows and multipleWebViews Qt WK2 API tests.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):
(WebCore::TextureMapperGLData::SharedGLData::glContextDataMap):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::ProgramInfo::ProgramInfo):
(WebCore::TextureMapperGLData::SharedGLData::createShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::deleteShaderProgram):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(WebCore::TextureMapperGLData::SharedGLData::initializeShaders):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
- platform/graphics/opengl/TextureMapperGL.h:
Source/WebKit2:
Check texture mapper exists already in ensureRootLayer to avoid recrecation.
Check if root layer was deleted already in purgeGLResources.
Added multipleWebViewWindows and multipleWebViews API tests.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- 4:39 PM Changeset in webkit [104650] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed, roll Chromium DEPS to r117121.
- DEPS:
- 4:32 PM Changeset in webkit [104649] by
-
- 2 edits in trunk/Tools
Clarify run-webkit-tests options reset-results and new-baseline
https://bugs.webkit.org/show_bug.cgi?id=75993
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 4:23 PM Changeset in webkit [104648] by
-
- 15 edits in branches/subpixellayout
Using pixel snapped values in line width calculation in RenderBlockLineLayout. Fixing a couple ints to LayoutUnits. Fixing a bug in showLineTreeForThis that causes it to short circuit nested RenderBlocks.
- 4:19 PM Changeset in webkit [104647] by
-
- 4 edits in trunk
Disabled mock scrollbars should draw differently
https://bugs.webkit.org/show_bug.cgi?id=75995
Source/WebCore:
Reviewed by James Robinson.
When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.
No tests, since mock scrollbars aren't enabled by default on Mac yet.
- platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
Tools:
Reviewed by James Robinson.
When the scrollbar is disabled, paint the entire track of
mock scrollbars with a lighter gray, and hide the thumb.
- DumpRenderTree/mac/DumpRenderTree.mm:
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
- 4:18 PM Changeset in webkit [104646] by
-
- 10 edits10 adds in trunk/Source/JavaScriptCore
CodeBlock.h declares too many things
https://bugs.webkit.org/show_bug.cgi?id=76001
Rubber stamped by Gavin Barraclough.
Removed all non-CodeBlock type declarations from CodeBlock.h, and put them
into separate header files. Also removed all non-CodeBlock method implementations
from CodeBlock.cpp and put them into corresponding cpp files.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/RepatchBuffer.h:
- bytecode/CallLinkInfo.cpp: Added.
(JSC::CallLinkInfo::unlink):
- bytecode/CallLinkInfo.h: Added.
(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::getCallLinkInfoReturnLocation):
(JSC::getCallLinkInfoBytecodeIndex):
- bytecode/CallReturnOffsetToBytecodeOffset.h: Added.
(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/CodeType.h: Added.
- bytecode/ExpressionRangeInfo.h: Added.
- bytecode/GlobalResolveInfo.h: Added.
(JSC::GlobalResolveInfo::GlobalResolveInfo):
- bytecode/HandlerInfo.h: Added.
- bytecode/LineInfo.h: Added.
- bytecode/MethodCallLinkInfo.cpp: Added.
(JSC::MethodCallLinkInfo::reset):
- bytecode/MethodCallLinkInfo.h: Added.
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
(JSC::getMethodCallLinkInfoReturnLocation):
(JSC::getMethodCallLinkInfoBytecodeIndex):
- bytecode/StructureStubInfo.h:
(JSC::getStructureStubInfoReturnLocation):
(JSC::getStructureStubInfoBytecodeIndex):
- 3:52 PM Changeset in webkit [104645] by
-
- 4 edits4 adds in trunk
Need to handle absolutely positioned elements inside flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70793
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/insert-text-crash.html
css3/flexbox/position-absolute-child.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Skip the size of positioned elements.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Add placeholders for positioned elements.
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout): Positions the layer for the positioned child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Handle positioned elements.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Adjust the main axis offset of the layer for positioned elements.
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/insert-text-crash-expected.txt: Added.
- css3/flexbox/insert-text-crash.html: Added.
- css3/flexbox/position-absolute-child-expected.txt: Added.
- css3/flexbox/position-absolute-child.html: Added.
- 3:50 PM Changeset in webkit [104644] by
-
- 5 edits in trunk/Source
[chromium] Reuse old timebase when activating CCDelayBasedTimeSource
https://bugs.webkit.org/show_bug.cgi?id=75938
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
Source/WebKit/chromium:
- tests/CCDelayBasedTimeSourceTest.cpp:
(WebKitTests::TEST):
- 3:48 PM Changeset in webkit [104643] by
-
- 17 edits in trunk/Source/WebCore
Support the [Supplemental] IDL on methods
https://bugs.webkit.org/show_bug.cgi?id=75944
Reviewed by Adam Barth.
The spec for the [Supplemental] IDL:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-supplemental-interface
Currently the [Supplemental] IDL is supported on attributes but not supported
on methods. This patch makes a change to support it.
Specifically, assume the following IDL:
interface [Supplemental=X] Y {
void func();
}
Then the code generator generates the following V8X.cpp.
void funcCallback(Arguments& args) {
X* imp = V8X::toNative(args.Holder());
Y::func(imp);
}
Similar code is also generated for JS, ObjC, GObject and CPP bindings.
Test: bindings/scripts/test/TestSupplemental.idl
- bindings/scripts/CodeGeneratorCPP.pm: Modified as described above.
(GenerateImplementation):
- bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(GenerateFunction):
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateFunctionCallString):
- bindings/scripts/generate-bindings.pl: Ditto.
- bindings/scripts/test/TestSupplemental.idl: Added test cases for [Supplemental] methods.
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
(WebDOMTestInterface::supplementalMethod1):
(WebDOMTestInterface::supplementalMethod2):
- bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
- bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestInterface.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalMethod1]):
(-[DOMTestInterface supplementalMethod2:objArg:]):
- bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalMethod1Callback):
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):
- 3:44 PM Changeset in webkit [104642] by
-
- 4 edits in trunk/LayoutTests
Chromium rebaseline after r104625.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 3:37 PM Changeset in webkit [104641] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed, roll Chromium DEPS to r117109.
- DEPS:
- 3:37 PM Changeset in webkit [104640] by
-
- 2 edits in trunk/LayoutTests
Qt rebaseline after r104625.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 3:35 PM Changeset in webkit [104639] by
-
- 11 edits in trunk/Source/WebCore
[Refactoring] Rename attributes in TestSupplemental.idl to clarify
that they are supplemental attributes
https://bugs.webkit.org/show_bug.cgi?id=75942
Reviewed by Adam Barth.
This patch just renames attributes in TestSupplemental.idl
to make it easy to find in {JS,V8,WebKitDOM,DOM,WebDOM}TestInterface.cpp
which attributes originate from TestSupplemental.idl.
- bindings/scripts/test/TestSupplemental.idl: Just renamed three attributes.
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated the test result.
(WebDOMTestInterface::supplementalStr1):
(WebDOMTestInterface::supplementalStr2):
(WebDOMTestInterface::setSupplementalStr2):
- bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
- bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterface):
- bindings/scripts/test/JS/JSTestInterface.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface ]):
(-[DOMTestInterface set:]):
- bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrGetter):
(WebCore::TestInterfaceInternal::supplementalStr2AttrSetter):
- 3:35 PM Changeset in webkit [104638] by
-
- 6 edits in trunk/Tools
[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
https://bugs.webkit.org/show_bug.cgi?id=75988
Patch by James Robinson <jamesr@chromium.org> on 2012-01-10
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/ports.py:
(WebKitPort.run_webkit_unit_tests_command):
(WebKitPort):
(ChromiumPort.run_webkit_unit_tests_command):
(ChromiumPort):
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_webkit_unit_tests_command):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(DownloadCommandsTest.test_build_and_test):
(test_land):
(test_land_red_builders):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 3:33 PM Changeset in webkit [104637] by
-
- 8 edits1 add in trunk/Tools
webkitpy: add os_name, os_version to platforminfo
https://bugs.webkit.org/show_bug.cgi?id=75931
Reviewed by Eric Siedel.
As a first step in cleaning up the version parsing logic in
webkitpy.layout_tests.port, this adds common routines for
getting the os_name and os_version fields to the PlatformInfo
class. Nothing uses them yet but I've added FIXME's to some of
the code that needs to be deleted in the port files.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.init):
(PlatformInfo):
(PlatformInfo._determine_os_name):
(PlatformInfo._determine_mac_version):
(PlatformInfo._determine_linux_version):
(PlatformInfo._determine_win_version):
(PlatformInfo.display_name):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._compute_bytes_from_vm_stat_output):
(PlatformInfo.free_bytes_memory):
- Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
(TestPlatformInfo):
(TestPlatformInfo.make_info):
(TestPlatformInfo.make_info.mock_run_command):
(TestPlatformInfo.setUp):
(TestPlatformInfo.tearDown):
(TestPlatformInfo.test_basic):
(TestPlatformInfo.integration_test_basic):
(TestPlatformInfo.test_display_name_mac):
(TestPlatformInfo.test_display_name_win32):
(TestPlatformInfo.test_memory_mac):
(TestPlatformInfo.test_memory_win32):
(TestPlatformInfo.test_determine_os_name):
(TestPlatformInfo.test_determine_mac_version):
(TestPlatformInfo.test_determine_linux_version):
(TestPlatformInfo.test_determine_win_version_from_tuple):
(TestPlatformInfo.test_determine_win_version_from_cmd):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.init):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.init):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
- 3:19 PM Changeset in webkit [104636] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Correctly recreate DrawingBuffer on lost device
https://bugs.webkit.org/show_bug.cgi?id=75912
Patch by John Bauman <jbauman@chromium.org> on 2012-01-10
Reviewed by Kenneth Russell.
Create new drawing buffer on new context, not old lost context. Also,
make sure to bind new drawing buffer.
No new tests.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- 3:17 PM Changeset in webkit [104635] by
-
- 3 edits in trunk/Source/WebKit2
Snow Leopard build fix.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- 3:01 PM Changeset in webkit [104634] by
-
- 8 edits1 add in trunk/Source/WebKit/chromium
Allow plugins to add rotate items to browser's context menu. Adds a new
WebPluginAction struct, with rotate types.
https://bugs.webkit.org/show_bug.cgi?id=75645
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebContextMenuData.h:
- public/WebPlugin.h:
(WebKit::WebPlugin::canRotateView):
(WebKit::WebPlugin::rotateView):
- public/WebPluginAction.h: Added.
(WebKit::WebPluginAction::WebPluginAction):
- public/WebView.h:
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::performMediaPlayerAction):
(WebKit::WebViewImpl::performPluginAction):
- src/WebViewImpl.h:
- 2:50 PM Changeset in webkit [104633] by
-
- 21 edits1 copy2 deletes in trunk/Source
Source/JavaScriptCore: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989
<rdar://problem/9601915>
Reviewed by Sam Weinig.
- wtf/Functional.h:
Add function wrapper for a function that takes three parameters.
Source/WebKit2: Hang opening movie that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=75989
Reviewed by Sam Weinig.
Change the way the keychain calls are processed to avoid deadlocks:
- When a keychain call is made, the web process sends an asynchronous request message to the UI process, avoiding the need to bounce calls to the main thread (since CoreIPC only allows sending synchronous messages from the main thread). Incidentally, this fixes <rdar://problem/9428041>.
- The Web Process now waits on the calling thread, (for a condition variable to be signalled) for a reply message.
- The UI process handles the incoming message request message on the connection work queue and uses dispatch_async to a global dispatch queue where the keychain call is made. We use a global queue to prevent the connection work queue from blocking on the call.
- The UI process then sends an asynchronous reply message back to the web process. This message is sent from the global dispatch queue.
- The Web Process handles the reply message on the connection queue, adds the reply to a map and signals the condition variable that the web process is waiting on and the thread that made the keychain call can resume execution.
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):
- Shared/mac/SecItemRequestData.h:
(WebKit::SecItemRequestData::type):
Add a type to SecItemRequestData and encode/decode it.
- Shared/mac/SecItemResponseData.h:
(WebKit::SecItemResponseData::resultObject):
Make this return a reference so we can call leakRef() on it.
- Shared/mac/SecKeychainItemRequestData.cpp:
(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):
- Shared/mac/SecKeychainItemRequestData.h:
(WebKit::SecKeychainItemRequestData::type):
Add a type, and put the OwnPtr and OwnArrayPtr in a RefCounted struct so we can
correctly copy this object.
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
Don't open the connection here, the WebProcessProxy object needs to add itself as a queue client before opening.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
Remove the WebProcessProxy object from the list of connection queue clients.
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
Call didReceiveWebProcessProxyMessageOnConnectionWorkQueue.
(WebKit::WebProcessProxy::didFinishLaunching):
Add the WebProcessProxy as a queue client and open the connection.
- UIProcess/WebProcessProxy.h:
WebProcessProxy should inherit from CoreIPC::Connection::QueueClient. Replace all individual keychain
handler functions with two generic functions, secItemRequest and secKeychainItemRequest.
- UIProcess/WebProcessProxy.messages.in:
Replace individual keychain messages with SecItemRequest and SecKeychainItemRequest messages.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::handleSecItemRequest):
Call the right SecItem function depending on the request type and send back the result.
(WebKit::WebProcessProxy::secItemRequest):
Dispatch handleSecItemRequest on a global dispatch queue.
(WebKit::handleSecKeychainItemRequest):
Call the right SecKeychainItem function depending on the request type and send back the result.
(WebKit::WebProcessProxy::secKeychainItemRequest):
Dispatch handleSecKeychainItemRequest on a global dispatch queue.
- WebKit2.xcodeproj/project.pbxproj:
Update for added/removed files.
- WebProcess/WebProcess.h:
Add secItemResponse and secKeychainItemResponse message handlers.
- WebProcess/WebProcess.messages.in:
Add SecItemResponse and SecKeychainItemResponse messages.
- WebProcess/mac/CoreIPCClientRunLoop.h:
- WebProcess/mac/CoreIPCClientRunLoop.mm:
This is no longer needed.
- WebProcess/mac/KeychainItemShimMethods.h:
- WebProcess/mac/KeychainItemShimMethods.mm:
(WebKit::managedAttributeLists):
Make this an atomically initialized static.
(WebKit::managedAttributeListsMutex):
Add an atomically initialized mutex.
(WebKit::allocateAttributeListContents):
Use the managedAttributeListsMutex to make this function callable from any thread.
(WebKit::managedKeychainItemContents):
Make this an atomically initialized static.
(WebKit::managedKeychainItemContentsMutex):
Add an atomically initialized mutex.
(WebKit::allocateKeychainItemContentData):
Use the managedAttributeListsMutex to make this function callable from any thread.
(WebKit::webFreeAttributeListContent):
Use locking so this can be called from any thread.
(WebKit::webFreeKeychainItemContent):
Ditto.
(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.
(WebKit::generateSecKeychainItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.
(WebKit::didReceiveSecKeychainItemResponse):
Pass the response over the response map.
(WebKit::sendSeqKeychainItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.
(WebKit::webSecKeychainItemCopyContent):
Send a request using sendSeqKeychainItemRequest.
(WebKit::webSecKeychainItemCreateFromContent):
Ditto.
(WebKit::webSecKeychainItemModifyContent):
Ditto.
- WebProcess/mac/KeychainShimResponseMap.h:
New thread-safe helper class that stores a map of responses and lets client wait for a response
with a given ID.
(KeychainShimResponseMap::waitForResponse):
Wait until the response is available in the hash map, then return it.
(KeychainShimResponseMap::didReceiveResponse):
Add the response to the hash map and signal the condition variable.
- WebProcess/mac/SecItemShimMethods.h:
- WebProcess/mac/SecItemShimMethods.mm:
(WebKit::responseMap):
Add responseMap thread-safe singleton for holding incoming responses.
(WebKit::generateSecItemRequestID):
Return a unique item request id, using OSAtomicIncrement64Barrier for atomicity.
(WebKit::didReceiveSecItemResponse):
Pass the response over the response map.
(WebKit::sendSeqItemRequest):
Send a request message and wait for a response using ResponseMap::waitForResponse.
(WebKit::webSecItemCopyMatching):
Send a request using sendSeqItemRequest.
(WebKit::webSecItemAdd):
Ditto.
(WebKit::webSecItemUpdate):
Ditto.
(WebKit::webSecItemDelete):
Ditto.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::secItemResponse):
Call didReceiveSecItemResponse.
(WebKit::WebProcess::secKeychainItemResponse):
Call didReceiveSecKeychainItemResponse.
- 2:34 PM Changeset in webkit [104632] by
-
- 5 edits in trunk
Source/WebCore: [Chromium] Partial revert of r104566, since it breaks the shared
library build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75994
Reviewed by Dmitry Titov.
Covered by SVG feColorMatrix tests (see LayoutTests/ChangeLog).
- WebCore.gypi:
- platform/graphics/filters/FEColorMatrix.h:
LayoutTests: Suppress failures caused by partial revert of r104566.
https://bugs.webkit.org/show_bug.cgi?id=75994
Reviewed by Dmitry Titov.
- platform/chromium/test_expectations.txt:
- 2:09 PM Changeset in webkit [104631] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Unreviewed, rebaseline tests after r104575 and r104588.
- platform/chromium-mac-leopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/chromium-mac-leopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
- 2:08 PM Changeset in webkit [104630] by
-
- 15 edits in trunk/Source/JavaScriptCore
CodeBlock::m_numParameters should be encapsulated
https://bugs.webkit.org/show_bug.cgi?id=75985
<rdar://problem/10671020>
Reviewed by Oliver Hunt.
Encapsulated CodeBlock::m_numParameters and hooked argument profile creation
into it. This appears to be performance neutral.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::addParameter):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numParameters):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::numberOfArgumentValueProfiles):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitReturn):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::arityCheckFor):
(JSC::lazyLinkFor):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 2:03 PM Changeset in webkit [104629] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed test expectations update. This test needs a new baseline for Vista.
- platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Added.
- 1:38 PM Changeset in webkit [104628] by
-
- 7 edits6 adds in trunk
Clean up RenderLayerBacking code that looks for the body
https://bugs.webkit.org/show_bug.cgi?id=39502
Source/WebCore:
Reviewed by Dave Hyatt.
Consolidate code that propagates the <body> background to the
root, adding a utility method on RenderObject that is called
by RenderBox and RenderLayerBacking.
Removed an unused method in RenderLayerBacking.
The compositiong changes are not testable, since rendererBackgroundColor()
is only used by fullscreen at present.
Tests: fast/backgrounds/root-background-propagation.html
fast/backgrounds/root-background-propagation2.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
- rendering/RenderLayerBacking.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::rendererForRootBackground):
- rendering/RenderObject.h:
LayoutTests:
Reviewed by Dave Hyatt.
Tests for propagation of the <body> background to the root.
- fast/backgrounds/root-background-propagation-expected.png: Added.
- fast/backgrounds/root-background-propagation-expected.txt: Added.
- fast/backgrounds/root-background-propagation.html: Added.
- fast/backgrounds/root-background-propagation2-expected.png: Added.
- fast/backgrounds/root-background-propagation2-expected.txt: Added.
- fast/backgrounds/root-background-propagation2.html: Added.
- 1:30 PM Changeset in webkit [104627] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Layout test rebaselines after r104606.
- platform/chromium-win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/chromium/fast/harness/results-expected.txt.
- 1:24 PM Changeset in webkit [104626] by
-
- 8 edits4 adds in trunk/Source
[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-10
Reviewed by James Robinson.
Source/WebCore:
New unit tests: CCLayerIteratorTest.cpp
- WebCore.gypi:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
- platform/graphics/chromium/cc/CCLayerIterator.h: Added.
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
- platform/graphics/chromium/cc/CCRenderSurface.h:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerIteratorTest.cpp: Added.
- 1:19 PM Changeset in webkit [104625] by
-
- 25 edits in trunk
Rename flex-align to flex-item-align.
https://bugs.webkit.org/show_bug.cgi?id=75929
Reviewed by Darin Adler.
Source/WebCore:
The spec has changed and now flex-align will be set on
the flexbox itself.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexItemAlign):
(WebCore::RenderStyleBitfields::setFlexItemAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/flex-align-column.html:
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- css3/flexbox/line-wrapping.html:
- css3/flexbox/orthogonal-flex-directions.html:
- css3/flexbox/script-tests/css-properties.js:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 1:14 PM Changeset in webkit [104624] by
-
- 37 edits2 adds in trunk
Replace TextTrackCue "getCueAsSource" method with "text" attribute
https://bugs.webkit.org/show_bug.cgi?id=75646
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-cue-mutable-text.html
- html/HTMLMediaElement.h: getCueAsSource() -> text().
- html/TextTrackCue.cpp:
(WebCore::TextTrackCue::setText): New. Set cue text and clear the document fragment.
(WebCore::TextTrackCue::getCueAsHTML): Allocate the document fragment if it doesn't exist.
- html/TextTrackCue.h:
(WebCore::TextTrackCue::text):
- html/TextTrackCue.idl: getCueAsSource() -> text().
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::updateTextTrackDisplay): getCueAsSource() -> text().
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay): getCueAsSource() -> text().
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectCueText): processCueText is dead, long live createNewCue.
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): New, split out of processCueText.
Create a document fragment from the String argument.
(WebCore::WebVTTParser::createNewCue): Split out of processCueText.
(WebCore::WebVTTParser::constructTreeFromToken): Add a comment pointing to the spec section
with the rules for DOM construction.
- html/track/WebVTTParser.h:
LayoutTests:
- media/track/track-cue-mutable-text-expected.txt: Added.
- media/track/track-cue-mutable-text.html: Added. New test for mutable cue text.
- media/track/track-cue-nothing-to-render-expected.txt: getCueAsSource() -> text.
- media/track/track-cue-nothing-to-render.html: Ditto.
- media/track/track-cue-rendering-expected.txt: Ditto.
- media/track/track-cue-rendering.html: Ditto.
- media/track/track-webvtt-tc001-utf8-expected.txt: Ditto.
- media/track/track-webvtt-tc001-utf8.html: Ditto.
- media/track/track-webvtt-tc002-bom-expected.txt: Ditto.
- media/track/track-webvtt-tc002-bom.html: Ditto.
- media/track/track-webvtt-tc003-newlines-expected.txt: Ditto.
- media/track/track-webvtt-tc003-newlines.html: Ditto.
- media/track/track-webvtt-tc004-magic-header-expected.txt: Ditto.
- media/track/track-webvtt-tc004-magic-header.html: Ditto.
- media/track/track-webvtt-tc005-header-comment-expected.txt: Ditto.
- media/track/track-webvtt-tc005-header-comment.html: Ditto.
- media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Ditto.
- media/track/track-webvtt-tc006-cue-identifiers.html: Ditto.
- media/track/track-webvtt-tc007-cue-no-id-expected.txt: Ditto.
- media/track/track-webvtt-tc007-cue-no-id.html: Ditto.
- media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Ditto.
- media/track/track-webvtt-tc008-timings-no-hours.html: Ditto.
- media/track/track-webvtt-tc009-timings-hour-expected.txt: Ditto.
- media/track/track-webvtt-tc009-timings-hour.html: Ditto.
- media/track/track-webvtt-tc011-blank-lines-expected.txt: Ditto.
- media/track/track-webvtt-tc011-blank-lines.html: Ditto.
- media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Ditto.
- media/track/track-webvtt-tc028-unsupported-markup.html: Ditto.
- platform/mac/fast/dom/Window/window-properties-expected.txt: Remove getCueAsSource.
- 1:14 PM Changeset in webkit [104623] by
-
- 8 edits in trunk/Source/WebKit2
DispatchOnConnectionQueue messages should have a Connection parameter
https://bugs.webkit.org/show_bug.cgi?id=75986
Reviewed by Adam Roben.
Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
parameter, making it easier to send messages back over that connection.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageOnConnectionQueue):
- Scripts/webkit2/messages.py:
(async_case_statement):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
- WebProcess/WebProcess.h:
- 1:12 PM Changeset in webkit [104622] by
-
- 5 edits2 adds in trunk
Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914
Reviewed by Simon Fraser.
Source/WebKit/mac:
Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::allowedCompositingTriggers):
Source/WebKit2:
Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::allowedCompositingTriggers):
LayoutTests:
Test to make sure compositing layers are off for filters
- css3/filters/should-not-have-compositing-layer-expected.txt: Added.
- css3/filters/should-not-have-compositing-layer.html: Added.
- 1:09 PM Coding Style Guidelines edited by
- Two copies of the standards exist. Removing this one, and sending … (diff)
- 1:05 PM Changeset in webkit [104621] by
-
- 2 edits in trunk/Tools
Make it possible to type data: URLs into MiniBrowser on Windows
Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
MiniBrowser on Windows
Reviewed by Darin Adler.
- MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
whether to prepend "http://", just look for whether the typed URL contains a colon. If it
does, we assume it already has a scheme and don't modify it.
- 1:01 PM Changeset in webkit [104620] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935
Fix 32-bit builds.
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
- 12:43 PM Changeset in webkit [104619] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
https://bugs.webkit.org/show_bug.cgi?id=75972
Reviewed by Oliver Hunt.
No new tests; no testing infrastructure exists to test display sleep assertions.
Only disable idle and display sleep when a video element is not paused, not looping, and
has both a video and audio track.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and
shouldDisplaySleep().
(WebCore::HTMLMediaElement::setLoop): Ditto.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::updateDisableSleep):
(WebCore::HTMLMediaElement::shouldDisableSleep):
- html/HTMLMediaElement.h:
- 12:42 PM Changeset in webkit [104618] by
-
- 11 edits in trunk/LayoutTests
[Chromium] Rebaseline after r104585
https://bugs.webkit.org/show_bug.cgi?id=75981
Unreviewed Chromium expectations update.
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium/test_expectations.txt:
- 12:39 PM Changeset in webkit [104617] by
-
- 2 edits in trunk/LayoutTests
[chromium] Move inspector tests into the inspector test group
https://bugs.webkit.org/show_bug.cgi?id=75926
Reviewed by Adam Barth.
And mark http/tests/inspector/resource-tree/resource-tree-document-url.html as flaky.
- platform/chromium/test_expectations.txt:
- 12:30 PM Changeset in webkit [104616] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
https://bugs.webkit.org/show_bug.cgi?id=75921
Reviewed by Simon Fraser.
No new tests. Does not affect detectable behavior.
- rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking
uninitialized canvas's if they're accelerated or not.
(WebCore::RenderLayerCompositor::updateBacking):
- 12:23 PM Changeset in webkit [104615] by
-
- 2 edits in trunk/Tools
Make MiniBrowser automatically escape invalid URL characters typed in its URL field
Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
MiniBrowser on Windows
Reviewed by Darin Adler.
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL): Pass the typed string through
CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
- 12:08 PM Changeset in webkit [104614] by
-
- 2 edits in trunk/Tools
Adding myself (benwells) to committers.py
https://bugs.webkit.org/show_bug.cgi?id=75971
Reviewed by Ojan Vafai.
- Scripts/webkitpy/common/config/committers.py:
- 12:01 PM Changeset in webkit [104613] by
-
- 2 edits in trunk/Source/WebKit/mac
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
https://bugs.webkit.org/show_bug.cgi?id=75980
Reviewed by Mark Rowe.
- History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
-alloc, -initWithWebCoreHistoryItem:.
- 11:57 AM Changeset in webkit [104612] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 11:56 AM Changeset in webkit [104611] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:52 AM Changeset in webkit [104610] by
-
- 3 edits3 adds in trunk
[Chromium] Do not recreate texture updater for image layer if one exists.
https://bugs.webkit.org/show_bug.cgi?id=75589
Patch by Daniel Sievers <sievers@chromium.org> on 2012-01-10
Reviewed by James Robinson.
Source/WebCore:
Test: platform/chromium/compositing/img-layer-grow.html
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):
LayoutTests:
- platform/chromium/compositing/img-layer-grow-expected.png: Added.
- platform/chromium/compositing/img-layer-grow-expected.txt: Added.
- platform/chromium/compositing/img-layer-grow.html: Added.
- platform/chromium/compositing/resources/apple.jpg: Added.
- 11:50 AM Changeset in webkit [104609] by
-
- 2 edits in trunk/Source/WebCore
[skia] not all convex paths are convex, so recompute convexity for the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960
Reviewed by Stephen White.
No new tests.
See related chrome issue
http://code.google.com/p/chromium/issues/detail?id=108605
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::setPathFromConvexPoints):
- 11:47 AM Changeset in webkit [104608] by
-
- 16 edits11 adds6 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening.
New baselines for SVG feColorMatrix tests after r104571.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/filters/feColorMatrix-saturate-expected.txt: Added.
- svg/filters/feColorMatrix-saturate-expected.txt: Removed.
- 11:45 AM Changeset in webkit [104607] by
-
- 5 edits1 delete in trunk/Source/WebKit/chromium
[chromium] Remove old WebMimeRegistry.h forwarding header
https://bugs.webkit.org/show_bug.cgi?id=75979
Reviewed by Ryosuke Niwa.
This isn't needed any more.
- WebKit.gyp:
- public/platform/WebMimeRegistry.h: Removed.
- src/FrameLoaderClientImpl.cpp:
- src/PlatformSupport.cpp:
- src/WebMediaPlayerClientImpl.cpp:
- 11:43 AM Changeset in webkit [104606] by
-
- 4 edits in trunk/LayoutTests
Improve keyboard navigation in layout test results
https://bugs.webkit.org/show_bug.cgi?id=75901
Reviewed by Ojan Vafai.
Add support for keyboard shortcuts for navigating the list of tests,
and for flagging tests.
'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
the current test with a red expand indicator.
'e', 'c' and 't' expand, collapse and toggle the current test.
'f' toggled a test as "flagged", which adds it to a copyable list
at the bottom of the document. The user can use flagging for whatever they want.
- fast/harness/resources/results-test.js:
(runTests):
(runTests.isCollapsed):
():
- fast/harness/results-expected.txt:
- fast/harness/results.html:
- 11:38 AM Changeset in webkit [104605] by
-
- 2 edits in trunk/Source/WebKit
[BlackBerry] Fix assertion failure in BackingStore::blitContents
https://bugs.webkit.org/show_bug.cgi?id=75976
Prevent an assertion failure in BackingStore::blitContents by
checking that the srcRect of the transformation matrix is non empty.
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-01-10
Reviewed by Adam Treat.
Upstream BlackBerry port is not yet building and testable.
- blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
- 11:27 AM Changeset in webkit [104604] by
-
- 11 edits in trunk
Source/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935
Reviewed by Sam Weinig.
Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.
- JavaScriptCore.exp:
- Removed export for setLength.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
- JSArray::setLength now takes an ExecState*
(JSC::arrayProtoFuncSlice):
- JSArray::setLength now takes an ExecState*
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- JSArray::setLength now takes an ExecState*
(JSC::JSArray::put):
- JSArray::setLength now takes an ExecState*
(JSC::compareKeysForQSort):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::getOwnPropertyNames):
- Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::setLength):
- Check lengthIsReadOnly(), rather than copying the entire map to iterate over to determine which keys to remove, instead just copy the keys from the map to a Vector. When inSparseMode sort the keys in the Vector so that we can remove properties in reverse order.
- runtime/JSArray.h:
- JSArray::setLength now takes an ExecState*
Source/WebCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935
Reviewed by Sam Weinig.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize):
- remove unnecessary call to JSArray::setLength.
LayoutTests: rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552
Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.
- platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:27 AM Changeset in webkit [104603] by
-
- 6 edits6 adds in trunk/LayoutTests
rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552
Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.
- platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
- platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:22 AM Changeset in webkit [104602] by
-
- 8 edits in trunk
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Rather than strictEqual.
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnNumericProperty):
- Missing configurablePresent() check.
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- call sameValue.
- runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
- Moved from JSArray.cpp, fix NaN comparison.
(JSC::PropertyDescriptor::equalTo):
- call sameValue.
- runtime/PropertyDescriptor.h:
- Added declaration for sameValue.
LayoutTests:
- fast/js/array-defineOwnProperty-expected.txt:
- fast/js/script-tests/array-defineOwnProperty.js:
- Add new test cases.
- 11:21 AM Changeset in webkit [104601] by
-
- 2 edits1 delete in trunk/LayoutTests
[chromium] Fix expectations for worker-script-error.html on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=75758
Reviewed by David Levin.
The Win results appear to apply to Mac and Linux as well.
- platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed.
- platform/chromium/fast/workers/worker-script-error-expected.txt:
- 10:59 AM Changeset in webkit [104600] by
-
- 10 edits in trunk/Source
[chromium] Draw debug tile borders on composited layers
https://bugs.webkit.org/show_bug.cgi?id=75680
Reviewed by James Robinson.
Source/WebCore:
On tiled layers, draw debug borders on the tiles themselves. By
default, these are one pixel wide and transparent, so should be
unobtrusive but informative. They are triggered when the layer itself
would have a debug border via the existing flags.
Also, fix the drawDebugBorderQuad function to handle arbitrarily
positioned quads, not just full layer quads. Also, fix alpha issue
with debug borders.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::hasDebugBorders):
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
Source/WebKit/chromium:
As debug borders are not a CCSetting and are instead grabbed directly
from each graphics layer, modify the NonCompositedContentHost to say
that its graphics layer has debug borders if the page settings demand
it.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setShowDebugBorders):
(WebKit::NonCompositedContentHost::showDebugBorders):
- src/NonCompositedContentHost.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 10:53 AM Changeset in webkit [104599] by
-
- 1 copy in tags/Safari-534.54.4
New tag.
- 10:49 AM Changeset in webkit [104598] by
-
- 3 edits in trunk/LayoutTests
http/tests/inspector/network-preflight-options.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=75917
Reviewed by Yury Semikhatsky.
- http/tests/inspector/network-preflight-options-expected.txt:
- http/tests/inspector/network-preflight-options.html:
- 10:46 AM Changeset in webkit [104597] by
-
- 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/elementsPanel.css
Merge 104577 - Unreviewed, inspector style fix.
Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609
- inspector/front-end/elementsPanel.css:
(#elements-content):
TBR=vsevik@chromium.org
BUG=109744
Review URL: http://codereview.chromium.org/9114043
- 10:44 AM Changeset in webkit [104596] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759
Follow-up: Remove the unused method. Keep the setter private.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-01-10
Reviewed by Pavel Feldman.
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- 10:23 AM Changeset in webkit [104595] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed, follow up to r104586: fix assertion within the loop.
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):
- 10:05 AM Changeset in webkit [104594] by
-
- 1 edit1 delete in trunk/LayoutTests
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193
Unreviewed. Remove no longer needed GTK-specific expectation.
- platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed.
- 9:57 AM Changeset in webkit [104593] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
Reviewed by Maciej Stachowiak.
This is a non-reproducible high volume crash, so no test :(.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): Don't re-run actual "stop loading" logic if the document loader is already
stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
were being stopped.
(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.
- 9:49 AM Changeset in webkit [104592] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: fixing the Mac build.
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):
- 9:44 AM Changeset in webkit [104591] by
-
- 7 edits1 move in trunk
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193
Reviewed by Chris Fleizach.
Source/WebKit/gtk:
Add support for retrieving WebCore's AccessibilityObject's
helpText from the GTK DumpRenderTree.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::accessibilityHelpText): Returns result
of calling to helpText() over the core accessibility object's.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::helpText): Implemented.
LayoutTests:
Unskip tests now passing.
- accessibility/aria-describedby-on-input-expected.txt: Moved from
LayoutTests/platform/mac/accessibility.
- platform/gtk/Skipped: Unskip tests.
- 9:41 AM Changeset in webkit [104590] by
-
- 2 edits in trunk/LayoutTests
[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74493
Unreviewed. Unskipping passing test.
- platform/gtk/test_expectations.txt: Unskip test.
- 9:38 AM Changeset in webkit [104589] by
-
- 4 edits in trunk
Elements can appear over fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=75913
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.
RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
context to be created. Instead of making the placeholder the parent of the RenderFullScreen
object, make the two renderers siblings. Then the stacking context created by the placeholder
will not affect the z-ordering of the RenderFullScreen.
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):
LayoutTests:
Update the test to trigger the error condition in the linked bug.
- fullscreen/full-screen-zIndex.html:
- 9:34 AM Changeset in webkit [104588] by
-
- 1 edit6 adds in trunk/LayoutTests
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100
Unreviewed, chromium rebaselining after r104575.
The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969).
- platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added.
- 9:19 AM Changeset in webkit [104587] by
-
- 1 edit10 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.
- platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
- platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
- platform/qt/fast/writing-mode/margins-expected.png: Removed.
- platform/qt/fast/writing-mode/margins-expected.txt: Removed.
- 9:01 AM Changeset in webkit [104586] by
-
- 11 edits2 adds in trunk/Source/WebCore
Web Inspector: add "free flow DOM editing" experiment.
https://bugs.webkit.org/show_bug.cgi?id=75955
This change enables HTML editing from Resources panel experiment.
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- English.lproj/localizedStrings.js:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/DOMEditor.cpp: Added.
(WebCore::DOMEditor::DOMEditor):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::patch):
(WebCore::DOMEditor::NodeDigest::NodeDigest):
(WebCore::DOMEditor::patchElement):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::patchChildren):
(WebCore::addStringToSHA1):
(WebCore::DOMEditor::createNodeDigest):
- inspector/DOMEditor.h: Added.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMModelResourceBinding):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.canSetContent):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- 8:54 AM Changeset in webkit [104585] by
-
- 5 edits in trunk
[Chromium] Shift PathSkia to use Skia's new RawIter
https://bugs.webkit.org/show_bug.cgi?id=75703
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10
Reviewed by Nikolas Zimmermann.
Source/WebCore:
No new tests required - covered by existing tests.
- platform/graphics/Path.h: Added comments ont he return values from iteration.
- platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::apply): Switched to SkPath::RawIter
LayoutTests:
- platform/chromium/test_expectations.txt: Updated epxectation for tests that may change after this modification.
- 8:47 AM Changeset in webkit [104584] by
-
- 5 edits in trunk
Unreviewed, rolling out r104572.
http://trac.webkit.org/changeset/104572
https://bugs.webkit.org/show_bug.cgi?id=75967
It broke zillion tests (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10
Tools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
(EventSender::eventFilter):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt-wk1/Skipped:
- 8:45 AM Changeset in webkit [104583] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Clean up test expectations for mac.
https://bugs.webkit.org/show_bug.cgi?id=75966
Unreviewed.
- platform/chromium/test_expectations.txt:
- 8:44 AM Changeset in webkit [104582] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed potential Mac WK2 build fix.
- UIProcess/PageClient.h: forward declare WebGestureEvent.
- 8:39 AM Changeset in webkit [104581] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed. WebInspector: Remove unnecessary logging from the test.
- inspector/first-open-resources.html:
- 8:31 AM Changeset in webkit [104580] by
-
- 1 edit1 add in trunk/PerformanceTests
Unreviewed. Restore test that was removed during migration from LayoutTests folder.
- inspector/first-open-resources.html: Added.
- 8:23 AM Changeset in webkit [104579] by
-
- 2 edits1 delete in trunk/LayoutTests
Rebaseline fast/text/unicode-variation-selector.html following r104545.
- platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
- platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.
- 8:03 AM Changeset in webkit [104578] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
metrics for Android in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=75702
Reviewed by Stephen White.
Since Skia for Android doesn't implement advanced type metric routines,
use an alternative method to calculate the number of font units for an
em size. This will be exercized by existing layout tests, as it's being
used by the ComplexTextController.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
- 7:59 AM Changeset in webkit [104577] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, inspector style fix.
Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609
- inspector/front-end/elementsPanel.css:
(#elements-content):
- 7:58 AM Changeset in webkit [104576] by
-
- 2 edits in trunk/Source/WebCore
Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854
Reviewed by Nikolas Zimmermann.
Minor style fixes.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::filterInfoForName):
- 7:48 AM Changeset in webkit [104575] by
-
- 3 edits7 adds in trunk
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/layers/scroll-with-transform-composited-layer.html
fast/layers/scroll-with-transform-layer.html
The regression came from a previous optimization that was wrongly kept after r93614.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.
LayoutTests:
Added 2 tests for scrolling inside a transformed layer (either composited
or not). Unfortunately due to some platform-specifics differences, they are
not ref-tests.
- fast/layers/scroll-with-transform-composited-layer-expected.txt: Added.
- fast/layers/scroll-with-transform-composited-layer.html: Added.
- fast/layers/scroll-with-transform-layer-expected.txt: Added.
- fast/layers/scroll-with-transform-layer.html: Added.
- platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
- 7:47 AM Changeset in webkit [104574] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
https://bugs.webkit.org/show_bug.cgi?id=75957
Reviewed by Tony Gentilcore.
Revision 104502 broke Chromium compilation for platforms which disable
the Web Audio API. All references to m_audioSourceProvider should be
guarded with the ENABLE(WEB_AUDIO) conditional.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
- 7:35 AM Changeset in webkit [104573] by
-
- 6 edits in trunk/Source/WebKit2
Unreviewed, rolling out an accidental commit r104569.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- 7:32 AM Changeset in webkit [104572] by
-
- 5 edits in trunk
[Qt] fast/events/dont-loose-last-event test fails on WK1
https://bugs.webkit.org/show_bug.cgi?id=73894
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-01-10
Reviewed by Simon Hausmann.
Tools:
Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.
This commit also removes not working DRT code to handle drag and drop,
for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
Remove fast/events/dont-loose-last-event from qt-wk1 skip list.
- platform/qt-wk1/Skipped:
- 7:32 AM Changeset in webkit [104571] by
-
- 2 edits in trunk/Source/WebCore
Fix Chrome/Mac build.
Build fix; unreviewed.
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::luminanceToAlphaMatrix):
- 7:25 AM Changeset in webkit [104570] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed potential Mac WK2 build fix.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithGestureEvent):
- 7:20 AM Changeset in webkit [104569] by
-
- 5 edits in trunk/Source/WebKit2
WIP
- 7:17 AM Changeset in webkit [104568] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-10
Reviewed by Ryosuke Niwa.
Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.
- ewk/ewk_view.cpp:
(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
- 7:14 AM Changeset in webkit [104567] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-10
Reviewed by Zoltan Herczeg.
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
- UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.
- 7:01 AM Changeset in webkit [104566] by
-
- 10 edits1 add in trunk
Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA). This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582
Reviewed by Dirk Schulze.
Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).
- WebCore.gypi:
Add FEColorMatrixSkia.cpp to the build.
- platform/graphics/filters/FEColorMatrix.h:
Add platformApplySkia().
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().
- platform/graphics/filters/FEGaussianBlur.h:
Make platformApplySkia() virtual, and put it behind #if USE(SKIA).
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().
- platform/graphics/filters/FilterEffect.h:
Add platformApplySkia().
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.
(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.
LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582
Reviewed by Dirk Schulze.
- platform/chromium/test_expectations.txt:
- 6:18 AM Changeset in webkit [104565] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix failing WK2 layout tests after r104557
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not
handle mouseDown as gesture event.
- 6:13 AM Changeset in webkit [104564] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix.
- UIProcess/WebPageProxy.h:
- 5:49 AM Changeset in webkit [104563] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- 5:46 AM Changeset in webkit [104562] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868
Reviewed by Andreas Kling.
So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.
- ewk/ewk_js.cpp:
(ewk_js_object_view_get):
- ewk/ewk_js.h:
- 5:44 AM Changeset in webkit [104561] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
- platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently.
- platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
- 5:44 AM Changeset in webkit [104560] by
-
- 12 edits54 adds in trunk
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777
Source/WebCore:
Enable CSS_FILTERS and unskip the tests.
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.
Filter tests are now unskipped for Qt.
- Target.pri: add missing files to build.
Source/WebKit/qt:
For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):
Tools:
Add the CSS_FILTERS feature flag to Qt.
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.
- qmake/mkspecs/features/features.prf:
LayoutTests:
Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.
Platform specific expected results tweaked by Csaba Osztrogonác.
- platform/qt/Skipped: Unskip filter tests that work.
- platform/qt/css3/filters/*: Added Qt specific results.
- platform/qt/fast/dom/Window/window-properties.html: Updated.
- platform/qt/fast/dom/Window/window-property-descriptors.html: Updated.
- platform/qt/fast/dom/prototype-inheritance-2.html: Updated.
- platform/qt/fast/js/global-constructors.html: Updated.
- 5:36 AM Changeset in webkit [104559] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed -Werror build fix.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.
- 5:34 AM Changeset in webkit [104558] by
-
- 7 edits1 delete in trunk/Tools
[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952
Reviewed by Tor Arne Vestbø.
QUiLoader is used for creating QLabel/QProgressBar widgets for
a layout test, to verify some widget embedding feature. Unfortunately
in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
depends on qttools. Since we don't really _need_ QUiLoader for our tests,
let's break the circular dependency.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::createPlugin):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/webpage.cpp:
(WebPage::createPlugin):
- qmake/mkspecs/features/minimal_qt.prf:
- qmake/mkspecs/features/uitools.prf: Removed.
- 5:25 AM Changeset in webkit [104557] by
-
- 8 edits in trunk/Source/WebKit2
Implement the input panel request/close handling
Reviewed by Simon Hausmann.
With the current patch we only request the input panel as a
response to a user tap. Close requests, on the other hand,
is always respected.
As multiple show/hide requests can happen while processing
the tap gesture, input panel visibility changes are postponed
until the tap gesture ends.
The input panel will become visible if the WebCore editor is
in canEdit mode and thus work for content-editable, meaning
that it won't close the input panel if you click on a link
(eg. editCommand) while in content-editable mode.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::didReceiveEvent):
Add a new doneWithGestureEvent method to the PageClient
as well as add a updateTextInputState similar to that of mac.
- UIProcess/WebPageProxy.h:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::updateTextInputState):
(QtPageClient::doneWithGestureEvent):
Propagate the new events to the Qt EventHandler.
- UIProcess/qt/QtPageClient.h:
- UIProcess/qt/QtWebPageEventHandler.cpp:
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleSingleTapEvent):
(setInputPanelVisible):
(QtWebPageEventHandler::updateTextInputState):
(QtWebPageEventHandler::doneWithGestureEvent):
Handle postponing of the input method visibility change
and the actual showing/hiding.
- 5:24 AM Changeset in webkit [104556] by
-
- 3 edits in trunk/Tools
[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
https://bugs.webkit.org/show_bug.cgi?id=75894
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-10
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication::windowOptions):
- MiniBrowser/qt/main.cpp:
(main):
- 5:06 AM Changeset in webkit [104555] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 5:00 AM Changeset in webkit [104554] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowserCookies.
https://bugs.webkit.org/show_bug.cgi?id=75949
Reviewed by Andreas Kling.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
- 4:57 AM Changeset in webkit [104553] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: restore front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=75625
Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Yury Semikhatsky.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
- inspector/front-end/TabbedPane.js:
- inspector/front-end/externs.js:
(WebInspector.isCompactMode):
- inspector/front-end/treeoutline.js:
- 4:19 AM Changeset in webkit [104552] by
-
- 12 edits in trunk/Source/WebCore
Add NULL checks to setting access obtained on frame and document.
https://bugs.webkit.org/show_bug.cgi?id=72002
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.
Adds NULL checks to setting object where it's required.
Generally WebCore checks NULL which may be returned from setting object obtained
on frame or document but in some cases these are skipped. These checks are not
needed to setting's access on page object.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
- page/DragController.cpp:
(WebCore::DragController::draggableNode):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::flattenFrameSet):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
- rendering/RenderText.cpp:
(WebCore::SecureTextTimer::restartWithNewText):
- 4:12 AM WebKit Team edited by
- Added myself to committers list (diff)
- 4:11 AM Changeset in webkit [104551] by
-
- 2 edits in trunk/Tools
[Qt] DRT crashes with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=75951
Reviewed by Ossy.
- DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
Qt relies on font-config to define the default font family.
- 3:35 AM Changeset in webkit [104550] by
-
- 3 edits in trunk/Source/WebCore
Matched declaration cache should support mapped attribute declarations.
<http://webkit.org/b/75948>
Reviewed by Antti Koivisto.
Support caching of matches that include mapped attribute declarations.
To make this possible, let the cache hold references to the matched style declarations.
Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
be the case for CSSMappedAttributeDeclaration.
To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
every 100 additions and garbage collect any entries containing a declaration that is
only referenced by the cache.
This increases cache hit rate by up to ~10% on the Alexa top sites.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
- css/CSSStyleSelector.h:
- 3:33 AM Changeset in webkit [104549] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Remove codes to move and resize the clip.
https://bugs.webkit.org/show_bug.cgi?id=75428
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.
Remove codes to move and resize the clip because clip is not used now.
We have to show whole area of evas_object_image so we don't have to
clip any area.
In the WebKit1 Efl, the clip is used to clip the area to show during
weak zoom, so we can use codes to manipulate the clip when we want to
implement weak zoom for WebKit2 Efl.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
- 3:30 AM Changeset in webkit [104548] by
-
- 2 edits in trunk/Tools
[Qt] REGRESSION(r100130): Clean build feature is broken.
https://bugs.webkit.org/show_bug.cgi?id=75863
Reviewed by Tor Arne Vestbø.
- Scripts/webkitdirs.pm:
(buildQMakeProject):
- 3:20 AM Changeset in webkit [104547] by
-
- 1 edit1 add in trunk/LayoutTests
Add initial test_expectations.txt for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75940
Reviewed by Andreas Kling.
This file only has skip list for now. But, EFL patches will update
this file from now on.
- platform/efl/test_expectations.txt: Added.
- 3:06 AM Changeset in webkit [104546] by
-
- 5 edits in trunk/Tools
[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885
In QML events are propagated through parents. But since the
WebView may consume key events, a shortcut might never reach
the top QtQuickItem.
Therefore an application wide event handling function in C++
needs to take care of shortcuts for MiniBrowser.
Reviewed by Kenneth Rohde Christiansen.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::reload):
(BrowserWindow::focusAddressBar):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- MiniBrowser/qt/qml/BrowserWindow.qml:
- 2:46 AM Changeset in webkit [104545] by
-
- 17 edits in trunk
Complex path should be used when UVS exists in text run
https://bugs.webkit.org/show_bug.cgi?id=75289
Source/WebCore:
Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path.
Removes unnecessary functions that were added by r102915.
Reviewed by Dan Bernstein.
No new tests. fast/text/unicode-variation-selector.html should take care of this change.
- platform/graphics/Font.cpp:
(WebCore::Font::codePath): Use Complex path when the text run contains UVS.
- platform/graphics/SimpleFontData.h: Removed updateGlyphWithVariationSelector().
- platform/graphics/SurrogatePairAwareTextIterator.cpp: Removed unnecessary static functions.
- platform/graphics/SurrogatePairAwareTextIterator.h: Removed hasTrailingVariationSelector().
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): Removed UVS detection code.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed updateGlyphWithVariationSelector().
- platform/graphics/freetype/SimpleFontDataFreeType.cpp: Ditto.
- platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
- platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
- platform/graphics/qt/SimpleFontDataQt.cpp: Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
- platform/graphics/wince/SimpleFontDataWinCE.cpp: Ditto.
- platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.
LayoutTests:
Reviewed by Dan Bernstein.
- platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines.
- 2:34 AM Changeset in webkit [104544] by
-
- 3 edits in trunk/Tools
Add --efl alias for --platform=efl to run-webkit-test
https://bugs.webkit.org/show_bug.cgi?id=75937
Reviewed by Andreas Kling.
- Scripts/run-webkit-tests: Add --efl alias.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
(parse_args):
- 2:21 AM Changeset in webkit [104543] by
-
- 1 edit3 adds in trunk/LayoutTests
block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896
Reviewed by Ryosuke Niwa.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
- css3/calc/block-mask-overlay-image-outset.html: Added.
- css3/calc/resources/mask.png: Added.
- 2:13 AM Changeset in webkit [104542] by
-
- 5 edits3 adds in trunk
WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
https://bugs.webkit.org/show_bug.cgi?id=73419
Source/WebCore:
Holds the CachedFont handle in CSSFontFaceSrcValue so that avoiding re-validation during style recalculation.
Reviewed by Dan Bernstein.
Test: http/tests/css/font-face-src-loading.html
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont): Added.
- css/CSSFontFaceSrcValue.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Gets the CachedFont from CSSFontFaceSrcValue object. The object will request the resource if it doesn't exist.
LayoutTests:
Reviewed by Dan Bernstein.
Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.
- http/tests/css/font-face-src-loading-expected.txt: Added.
- http/tests/css/font-face-src-loading.html: Added.
- http/tests/css/resources/webfont-request.php: Added.
- 1:58 AM Changeset in webkit [104541] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: introduce experimental setting that makes source files always editable
https://bugs.webkit.org/show_bug.cgi?id=75626
Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Timothy Hatcher.
- English.lproj/localizedStrings.js:
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype.setReadOnly):
- inspector/front-end/inspector.js:
(WebInspector.loaded):
- 1:08 AM Changeset in webkit [104540] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 116979 to 117006.
- DEPS:
- 1:08 AM Changeset in webkit [104539] by
-
- 3 edits in trunk/PerformanceTests
Unreviewed test fix after r103683.
- inspector/first-open-scripts.html:
- inspector/show-panel.html:
Jan 9, 2012:
- 11:04 PM EFLWebKit edited by
- (diff)
- 9:42 PM Changeset in webkit [104538] by
-
- 8 edits4 deletes in trunk/Source
Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936
Broke webkit_unit_tests (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
- platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
- platform/graphics/chromium/cc/CCRenderSurface.h:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerIteratorTest.cpp: Removed.
- 9:39 PM Changeset in webkit [104537] by
-
- 2 edits in trunk/Source/WebKit/chromium
Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.
- public/WebView.h:
- 8:44 PM Changeset in webkit [104536] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.
- platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:
- 8:12 PM Changeset in webkit [104535] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update for test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 8:10 PM Changeset in webkit [104534] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from 116459 to 116979.
- DEPS:
- 7:00 PM Changeset in webkit [104533] by
-
- 216 edits3 copies11 moves3 adds9 deletes in trunk/LayoutTests
[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924
Unreviewed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
- platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-leopard/fast/css/line-height-expected.png:
- platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
- platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
- platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
- platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
- platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-leopard/fast/table/003-expected.png:
- platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
- platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
- platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
- platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-snowleopard/fast/table/003-expected.png:
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
- platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
- platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
- platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
- platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
- platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.
- 6:40 PM Changeset in webkit [104532] by
-
- 2 edits in trunk/Source/WebCore
2012-01-09 Rob Buis <rbuis@rim.com>
Upstream change to disable input[color] css rules for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=75719
Reviewed by Antonio Gomes.
Do not enable default css color rules for inputcolor for BlackBerry port.
- CMakeLists.txt:
- 6:29 PM Changeset in webkit [104531] by
-
- 7 edits7 adds in trunk
Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756
Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.
Test: webintents/web-intents-api.html
- Modules/intents/Intent.cpp: Added.
(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):
- Modules/intents/Intent.h: Added.
- Modules/intents/Intent.idl: Added.
- Modules/intents/IntentResultCallback.h: Added.
(WebCore::IntentResultCallback::~IntentResultCallback):
- Modules/intents/IntentResultCallback.idl: Added.
- Modules/intents/IntentsRequest.cpp: Added.
- Modules/intents/IntentsRequest.h: Added.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeForCallbacks):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchIntent):
LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756
Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.
- webintents/web-intents-api-expected.txt: Added.
- webintents/web-intents-api.html: Added.
- 6:14 PM Changeset in webkit [104530] by
-
- 4 edits in trunk
-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920
Reviewed by Darin Adler.
Source/WebCore:
Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm
- page/mac/FrameMac.mm:
(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.
Tools:
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.
- 6:12 PM Changeset in webkit [104529] by
-
- 2 edits in branches/subpixellayout/Source
Get chromium/linux building again.
- 6:11 PM Changeset in webkit [104528] by
-
- 15 edits2 adds in trunk/Source/WebCore
[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290
Reviewed by Ryosuke Niwa.
This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.
Note that this change is a preparation for Bug 59816.
No new tests. No behavioral change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: Followed the renaming.
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
- dom/DOMAllInOne.cpp:
- dom/Document.cpp: Followed te renaming.
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
- dom/Element.cpp: Followed te renaming.
(WebCore::Element::removeShadowRoot):
- dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):
- dom/Node.h:
- dom/TreeScope.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()
- dom/TreeScopeAdopter.cpp: Added.
(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- dom/TreeScopeAdopter.h: Added.
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):
- 6:03 PM Changeset in webkit [104527] by
-
- 5 edits in trunk
Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
- need to increment the string position.
LayoutTests:
- fast/js/date-parse-test-expected.txt:
- fast/js/script-tests/date-parse-test.js:
- added test cases.
- 5:56 PM Changeset in webkit [104526] by
-
- 18 edits9 copies30 adds in trunk/Source/WebCore
run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900
Reviewed by Eric Seidel.
I just grepped through the code generator script for IDL attributes and
wrote tests for them.
- bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
- bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
- bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
- bindings/scripts/test/JS/JSTestEventTarget.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
- bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
- bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
- bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
- bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
- bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
- bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
- bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
- bindings/scripts/test/TestDomainSecurity.idl: Added.
- bindings/scripts/test/TestEventConstructor.idl:
- bindings/scripts/test/TestEventTarget.idl: Added.
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestOverridingNameGetter.idl: Added.
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
- bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
- bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
- bindings/scripts/test/V8/V8TestEventTarget.h: Added.
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestObj.cpp:
- bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
- bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.
- 5:54 PM Changeset in webkit [104525] by
-
- 1 edit4 adds in trunk/LayoutTests
background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823
Reviewed by Daniel Bates.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/background-position-parsing-expected-mismatch.html: Added.
- css3/calc/background-position-parsing.html: Added.
- css3/calc/resources/diamond.png: Added.
- css3/calc/resources/ring.png: Added.
- 5:32 PM Changeset in webkit [104524] by
-
- 6 edits in trunk/Tools
webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884
Reviewed by Ryosuke Niwa.
Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):
- 5:24 PM Changeset in webkit [104523] by
-
- 2 edits in trunk/LayoutTests
http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186
Reviewed by Adam Barth.
- platform/chromium/test_expectations.txt:
- 5:21 PM Changeset in webkit [104522] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866
Reviewed by James Robinson.
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
- 5:14 PM Changeset in webkit [104521] by
-
- 5 edits1 copy3 adds in trunk/LayoutTests
New pixel test results with r104351.
Unreviewed.
Moved from mac to mac-snowleopard:
- platform/mac-snowleopard/fast/block/margin-collapse/103
New pixel test results:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/table/003-expected.png:
- platform/mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/mac/tables/mozilla/bugs/bug30692-expected.png:
- 5:12 PM Changeset in webkit [104520] by
-
- 1 edit4 adds in trunk/LayoutTests
img size test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75893
Reviewed by Daniel Bates.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/img-size-expected-mismatch.html: Added.
- css3/calc/img-size.html: Added.
- css3/calc/resources/colorsquare.png: Added.
- 5:08 PM Changeset in webkit [104519] by
-
- 2 edits in tags/Safari-535.15.1/Source/JavaScriptCore
Merge r104510.
- 5:07 PM Changeset in webkit [104518] by
-
- 5 edits in tags/Safari-535.15.1/Source
Versioning.
- 5:07 PM Changeset in webkit [104517] by
-
- 2 edits3 copies in branches/safari-534.54-branch
Merged r102509.
- 5:05 PM Changeset in webkit [104516] by
-
- 1 copy in tags/Safari-535.15.1
New tag.
- 5:02 PM Changeset in webkit [104515] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit2
Merged r102377.
- 5:00 PM Changeset in webkit [104514] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r102263.
- 4:55 PM Changeset in webkit [104513] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merged r102016.
- 4:50 PM Changeset in webkit [104512] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r101584.
- 4:42 PM Changeset in webkit [104511] by
-
- 2 edits in trunk/Source/WebCore
Remove unused variable from CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=75895
Reviewed by Eric Seidel.
Unused variables aren't worth keeping around.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
- 4:41 PM Changeset in webkit [104510] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore executable targets shouldn't explicitly depend on the JavaScriptCore framework target <http://webkit.org/b/75907> / <rdar://problem/10659862>
We'd like for it to be possible to build jsc without building JavaScriptCore.framework and the explicit
dependencies prevent this.
Reviewed by Dan Bernstein.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 4:39 PM Changeset in webkit [104509] by
-
- 1 edit2 adds in trunk/LayoutTests
Temporary fix for pixel result diffs from focus ring (darker color on WK2).
These results should be removed once the cause is found-- filed as bug:
https://bugs.webkit.org/show_bug.cgi?id=75909
Unreviewed.
- platform/mac-wk2/fast/forms/plaintext-mode-2-expected.png: Added.
- platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt: Added.
- 4:33 PM Changeset in webkit [104508] by
-
- 72 edits21 copies21 adds in trunk/LayoutTests
Some gardening with fix for r104351.
Moving pixel test results from mac to mac-snowleopard (because of theme changes):
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01
- platform/mac-snowleopard/fast/forms/button-cannot-be-nested
- platform/mac-snowleopard/fast/forms/button-inner-block-reuse
- platform/mac-snowleopard/fast/forms/control-clip-overflow
- platform/mac-snowleopard/fast/forms/file/input-file-re-render
- platform/mac-snowleopard/fast/forms/formmove
- platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur
- platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed
- platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load
- platform/mac-snowleopard/fast/forms/menulist-width-change
- platform/mac-snowleopard/fast/forms/option-text-clip
- platform/mac-snowleopard/fast/forms/plaintext-mode-2
- platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style
- platform/mac-snowleopard/fast/forms/search-vertical-alignment
- platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup
- platform/mac-snowleopard/fast/forms/select-item-background-clip
- platform/mac-snowleopard/fast/forms/select-selected
- platform/mac-snowleopard/fast/forms/select-size
- platform/mac-snowleopard/fast/forms/select-visual-hebrew
- platform/mac-snowleopard/fast/forms/textarea-scrollbar
- platform/mac-snowleopard/fast/forms/textarea-scrolled
New pixel test results:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/006-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/mac/fast/forms/basic-buttons-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-selects-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/button-align-expected.png:
- platform/mac/fast/forms/button-cannot-be-nested-expected.png:
- platform/mac/fast/forms/button-default-title-expected.png:
- platform/mac/fast/forms/button-generated-content-expected.png:
- platform/mac/fast/forms/button-inner-block-reuse-expected.png:
- platform/mac/fast/forms/button-sizes-expected.png:
- platform/mac/fast/forms/button-style-color-expected.png:
- platform/mac/fast/forms/button-table-styles-expected.png:
- platform/mac/fast/forms/button-text-transform-expected.png:
- platform/mac/fast/forms/button-white-space-expected.png:
- platform/mac/fast/forms/control-clip-overflow-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/disabled-select-change-index-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/file/file-input-direction-expected.png:
- platform/mac/fast/forms/file/input-file-re-render-expected.png:
- platform/mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-hides-table-expected.png:
- platform/mac/fast/forms/formmove-expected.png:
- platform/mac/fast/forms/input-align-expected.png:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-width-expected.png:
- platform/mac/fast/forms/input-baseline-expected.png:
- platform/mac/fast/forms/input-button-sizes-expected.png:
- platform/mac/fast/forms/input-table-expected.png:
- platform/mac/fast/forms/input-text-click-outside-expected.png:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/mac/fast/forms/listbox-bidi-align-expected.png:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
- platform/mac/fast/forms/menulist-width-change-expected.png:
- platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/mac/fast/forms/option-strip-whitespace-expected.png:
- platform/mac/fast/forms/option-text-clip-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/mac/fast/forms/plaintext-mode-2-expected.png:
- platform/mac/fast/forms/radio_checked_dynamic-expected.png:
- platform/mac/fast/forms/range/input-appearance-range-expected.png:
- platform/mac/fast/forms/range/slider-padding-expected.png:
- platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/select-align-expected.png:
- platform/mac/fast/forms/select-change-listbox-size-expected.png:
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/mac/fast/forms/select-initial-position-expected.png:
- platform/mac/fast/forms/select-item-background-clip-expected.png:
- platform/mac/fast/forms/select-selected-expected.png:
- platform/mac/fast/forms/select-size-expected.png:
- platform/mac/fast/forms/select-style-expected.png:
- platform/mac/fast/forms/select-visual-hebrew-expected.png:
- platform/mac/fast/forms/select-writing-direction-natural-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-scrollbar-expected.png:
- platform/mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/mac/fast/forms/textarea-width-expected.png:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
- 4:31 PM Changeset in webkit [104507] by
-
- 8 edits4 adds in trunk/Source
[chromium] Create iterators for the RenderSurface-Layer tree
https://bugs.webkit.org/show_bug.cgi?id=74203
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-09
Reviewed by James Robinson.
Source/WebCore:
New unit tests: CCLayerIteratorTest.cpp
- WebCore.gypi:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/cc/CCLayerIterator.cpp: Added.
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
- platform/graphics/chromium/cc/CCLayerIterator.h: Added.
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator!=):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::representsItself):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
- platform/graphics/chromium/cc/CCRenderSurface.h:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerIteratorTest.cpp: Added.
- 4:13 PM Changeset in webkit [104506] by
-
- 5 edits in trunk
IndexedDB: Throw exception if IDBCursor.continue() called with lower key than current
https://bugs.webkit.org/show_bug.cgi?id=74213
Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.
Source/WebCore:
- storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunction):
LayoutTests:
- storage/indexeddb/cursor-continue-expected.txt:
- storage/indexeddb/cursor-continue.html:
- 4:12 PM Changeset in webkit [104505] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] REGRESSION(r104368): Broke CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
https://bugs.webkit.org/show_bug.cgi?id=75783
Updated unit test to reflect desired behaviour now that tile/quad culling
is implemented.
Reviewed by James Robinson.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
- 4:03 PM Changeset in webkit [104504] by
-
- 1 edit2 adds in trunk/LayoutTests
Tests for nested flexboxes
https://bugs.webkit.org/show_bug.cgi?id=70776
Reviewed by Tony Chang.
- css3/flexbox/orthogonal-flex-directions-expected.txt: Added.
- css3/flexbox/orthogonal-flex-directions.html: Added.
- 4:01 PM Changeset in webkit [104503] by
-
- 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Windows Build Fix
- 3:56 PM Changeset in webkit [104502] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix potential issue in WebMediaPlayerClientImpl
https://bugs.webkit.org/show_bug.cgi?id=75899
Reviewed by Kenneth Russell.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
- 3:53 PM Changeset in webkit [104501] by
-
- 4 edits in trunk/Source/WebCore
[chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420
When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.
Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.
No new tests: Relying on existing canvas layout tests.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- platform/graphics/ImageBuffer.h:
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):
- 3:43 PM Changeset in webkit [104500] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r101091.
- 3:32 PM Changeset in webkit [104499] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merge 100809.
- 3:23 PM Changeset in webkit [104498] by
-
- 3 edits2 copies in branches/safari-534.54-branch
Merged r100677.
- 3:16 PM Changeset in webkit [104497] by
-
- 9 edits5 copies in branches/safari-534.54-branch
Merged r100630.
- 3:14 PM Changeset in webkit [104496] by
-
- 37 edits in branches/subpixellayout/LayoutTests/platform
Updated svg expectations
- 3:14 PM Changeset in webkit [104495] by
-
- 2 edits in trunk/Tools
Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
Unreviewed, build fix.
test-webkitpy had a built-in self-test routine to verify that
deleting the .pyc files worked correctly. When I removed the
python24 directory in r104482, I broke the self-test.
I have deleted the self-test for now. Since I am reworking
test-webkitpy I will make sure the new version is adequately
tested.
- Scripts/test-webkitpy:
(configure_logging):
(_clean_pyc_files):
(_clean_packages):
(init):
- 3:13 PM Changeset in webkit [104494] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements
Patch by Avi Drissman <avi@chromium.org> on 2012-01-09
Reviewed by Dimitri Glazkov.
Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintTextField):
- 3:05 PM Changeset in webkit [104493] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGText.cpp
Fix rounding problem in RenderSVGText::nodeAtFloatPoint
- 2:43 PM Changeset in webkit [104492] by
-
- 3 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=75692
Roll out possibly bad new test case.
Rubber stamped by Sam Weinig.
- fast/js/date-constructor-expected.txt:
- fast/js/script-tests/date-constructor.js:
- 2:06 PM Changeset in webkit [104491] by
-
- 2 edits in trunk/Source/JavaScriptCore
Log is a little to verbose for blackberry port
https://bugs.webkit.org/show_bug.cgi?id=75728
The BlackBerry::Platform::Log* functions take care of the call to vfprintf
which is resulting in unintentional noise in our logs. Add a conditional
directive to fix.
Change to using BlackBerry::Platform::logStreamV which does not insert
threading info and newlines unlike BlackBerry::Platform::log.
Finally, add log locking and unlocking which the BlackBerry platform
uses to ensure that N threads do not trample on each other's logs.
Patch by Adam Treat <atreat@rim.com> on 2012-01-09
Reviewed by Rob Buis.
- wtf/Assertions.cpp:
(WTFLogLocker::WTFReportAssertionFailure):
(WTFLogLocker::WTFReportAssertionFailureWithMessage):
(WTFLogLocker::WTFReportArgumentAssertionFailure):
(WTFLogLocker::WTFReportFatalError):
(WTFLogLocker::WTFReportError):
(WTFLogLocker::WTFLog):
(WTFLogLocker::WTFLogVerbose):
- 2:02 PM Changeset in webkit [104490] by
-
- 2 edits in trunk/Source/WebCore
Compilation error on build-webkit --debug --no-3d-canvas on mac.
https://bugs.webkit.org/show_bug.cgi?id=75878
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-09
Reviewed by Alexey Proskuryakov.
- html/canvas/WebGLContextEvent.cpp:
- 2:00 PM Changeset in webkit [104489] by
-
- 1 edit1 move1 add4 deletes in trunk/LayoutTests
[Chromium] Rebaseline media/media-document-audio-repaint.html for gpu tests.
https://bugs.webkit.org/show_bug.cgi?id=75888
Unreviewed.
- platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-gpu/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/media-document-audio-repaint-expected.txt.
- 1:56 PM Changeset in webkit [104488] by
-
- 14 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=75789
defineOwnProperty not implemented for Array objects
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Implements support for getter/setter & non-default attribute properties on arrays,
by forcing them into a dictionary-like 'SparseMode'. This fixes ~300 test-262
test failures.
- JavaScriptCore.exp:
- Updated exports.
- dfg/DFGOperations.cpp:
- JSArray::pop now requires an exec state.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
- JSArray::pop now requires an exec state.
- runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::add):
- Add a potentially empty entry into the map.
(JSC::SparseArrayValueMap::put):
- Changed to call setter.
(JSC::SparseArrayEntry::get):
- calls getters.
(JSC::SparseArrayEntry::getNonSparseMode):
- does not call getters.
(JSC::JSArray::enterSparseMode):
- Convert into 'SparseMode' - removes the vectors, don't allow it to be recreated.
(JSC::JSArray::putDescriptor):
- Create a numeric property based on a descriptor.
(JSC::sameValue):
- See ES5.1 9.12.
(JSC::reject):
- Helper for the DefineOwnProperty algorithm.
(JSC::JSArray::defineOwnNumericProperty):
- Define an indexed property on an array object.
(JSC::JSArray::setLengthWritable):
- Marks the length read-only, enters SparseMode as necessary.
(JSC::JSArray::defineOwnProperty):
- Defines either an indexed property or 'length' on an array object.
(JSC::JSArray::getOwnPropertySlotByIndex):
- Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::getOwnPropertyDescriptor):
- Updated to correctly handle accessor descriptors & attributes.
(JSC::JSArray::put):
- Pass strict mode flag to setLength.
(JSC::JSArray::putByIndex):
- putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::putByIndexBeyondVectorLength):
- Pass exec to SparseArrayValueMap::put.
(JSC::JSArray::deletePropertyByIndex):
- Do not allow deletion of non-configurable properties.
(JSC::compareKeysForQSort):
- used in implementation of getOwnPropertyNames.
(JSC::JSArray::getOwnPropertyNames):
- Properties in the sparse map should be iterated in order.
(JSC::JSArray::setLength):
- Updated to take a 'shouldThrow' flag, return a result indicating error.
(JSC::JSArray::pop):
- pop should throw an error if length is not writable, even if the array is empty.
(JSC::JSArray::push):
- putByIndexBeyondVectorLength requires an ExecState* rather than a JSGloablData&.
(JSC::JSArray::sort):
- Changed 'get' to 'getNonSparseMode' (can't be getters to call).
(JSC::JSArray::compactForSorting):
- Changed 'get' to 'getNonSparseMode' (can't be getters to call).
- runtime/JSArray.h:
(JSC::SparseArrayValueMap::lengthIsReadOnly):
- Check if the length is read only.
(JSC::SparseArrayValueMap::setLengthIsReadOnly):
- Mark the length as read only.
(JSC::SparseArrayValueMap::find):
- Moved into header.
(JSC::JSArray::isLengthWritable):
- Wraps SparseArrayValueMap::lengthIsReadOnly.
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- Should be returning the result of putDescriptor.
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesOverridingCurrent):
- Added attributesOverridingCurrent - this should probably be merged with attributesWithOverride.
- runtime/PropertyDescriptor.h:
- Added attributesOverridingCurrent.
LayoutTests:
- fast/js/array-defineOwnProperty-expected.txt: Added.
- fast/js/array-defineOwnProperty.html: Added.
- fast/js/script-tests/array-defineOwnProperty.js: Added.
- Added tests for array properties with accessors & non-defulat attributes.
- fast/js/mozilla/strict/15.4.4.6-expected.txt:
- fast/js/mozilla/strict/8.12.5-expected.txt:
- ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt:
- ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt:
- Check in passing results.
- 1:50 PM Changeset in webkit [104487] by
-
- 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp
Fix M17 build.
- 1:32 PM Changeset in webkit [104486] by
-
- 3 edits4 adds in trunk
Treat code="" attribute in embed tags similarly to applet tags.
https://bugs.webkit.org/show_bug.cgi?id=75871
Reviewed by Daniel Bates.
Source/WebCore:
Tests: http/tests/security/xssAuditor/embed-tag-code-attribute-2.html
http/tests/security/xssAuditor/embed-tag-code-attribute.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterEmbedToken):
LayoutTests:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-code-attribute-2.html: Added.
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-code-attribute.html: Added.
- 1:25 PM Changeset in webkit [104485] by
-
- 13 edits in trunk
[Chromium] remove all references to the legacy accelerated 2d Canvas
implementation
https://bugs.webkit.org/show_bug.cgi?id=75108
Purging an old settings flag that is no longer referenced
Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Darin Fisher.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
Tools:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setAccelerated2dCanvasEnabled):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
- 1:16 PM Changeset in webkit [104484] by
-
- 5 edits in branches/subpixellayout/Source/WebCore
Fixing SVG's initial transform to local coordinates to pixel snap. Also fixing widget alignment corner cases.
- 1:16 PM Changeset in webkit [104483] by
-
- 2 edits in trunk/Tools
Convert Cygwin paths to Windows paths before passing them to DRT
Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT
I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.
- 1:10 PM Changeset in webkit [104482] by
-
- 9 edits1 copy3 deletes in trunk/Tools
webkitpy: revamp version checking
https://bugs.webkit.org/show_bug.cgi?id=75765
Reviewed by Adam Barth.
The version-checking code in webkitpy/python24/versioning seems really
awkward and overdesigned, especially since we don't support python 2.4
any more.
In addition, I am tired of getting warnings about Python 2.6 being "a
newer release than what is supported" :).
I'm taking a page from the depot_tools python code and just creating a
new webkitpy.common.version_check module that will print a message on
stderr and call sys.exit() if we're running an unsupported version.
- Scripts/check-webkit-style:
- Scripts/new-run-webkit-httpd:
- Scripts/new-run-webkit-tests:
- Scripts/rebaseline-chromium-webkit-tests:
- Scripts/test-webkitpy:
(configure_logging):
(init):
- Scripts/webkit-patch:
(main):
- Scripts/webkitpy/common/system/executive.py:
(Executive._child_process_encoding):
(Executive._should_encode_child_process_arguments):
- Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/python24/init.py: Removed.
- Scripts/webkitpy/python24/versioning.py: Removed.
- Scripts/webkitpy/python24/versioning_unittest.py: Removed.
- 1:08 PM Changeset in webkit [104481] by
-
- 5 edits in trunk
IndexedDB: Make WebIDBDatabase::close() idempotent
https://bugs.webkit.org/show_bug.cgi?id=75751
Source/WebKit/chromium:
Allow Chromium's back-end to safely trigger the cleanup that occurs
when a database connection is closed, without tracking whether or not
the connection was previous closed by script.
Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::close):
LayoutTests:
Verify that calling IDBDatabase.close() twice from script is harmless.
Note that the tests pass without the related code change in the bug,
which is just for non-script use by the chromium port.
Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-09
Reviewed by Tony Chang.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- 12:58 PM Changeset in webkit [104480] by
-
- 2 edits in trunk/LayoutTests
remove reference to cg-specific test
https://bugs.webkit.org/show_bug.cgi?id=75881
Patch by Elliot Poger <epoger@google.com> on 2012-01-09
Reviewed by Ojan Vafai.
- platform/chromium/test_expectations.txt:
- 12:53 PM Changeset in webkit [104479] by
-
- 4 edits in trunk
Source/WebCore: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html
intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817
Unreviewed, fix a problem introduced in r104327.
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_ignoreTrackDisplayUpdate.
LayoutTests: REGRESSION(r104327?): media/track/track-cues-cuechange.html and track-cues-enter-exit.html intermittently time out, media/track/track-cues-seeking and fails
https://bugs.webkit.org/show_bug.cgi?id=75817
Unreviewed, fix a problem introduced in r104327.
Re-enable <track> tests disabled after r104327.
- platform/chromium/test_expectations.txt:
- 12:47 PM Changeset in webkit [104478] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merged r100343.
- 12:38 PM Changeset in webkit [104477] by
-
- 4 edits in trunk/Tools
Remove Chromium Mac CG from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=75873
Reviewed by Ojan Vafai.
This configuration no longer exists.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testOverrideJustBuildType):
(testPlatformAndBuildType):
- 12:22 PM Changeset in webkit [104476] by
-
- 6 edits3 adds in trunk
Add normalize attribute to ConvolverNode to disable normalization.
https://bugs.webkit.org/show_bug.cgi?id=75126
Patch by Raymond Toy <Raymond Toy> on 2012-01-09
Reviewed by Kenneth Russell.
Tests added in convolution-mono-mono.html.
- platform/audio/Reverb.cpp:
(WebCore::Reverb::Reverb): Add extra arg to indicate whether
normalization is enabled or not, and do it.
- platform/audio/Reverb.h: Update declaration.
- webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode): Initialize attribute (to
true).
(WebCore::ConvolverNode::setBuffer): Call Reverb with
normalization argument.
- webaudio/ConvolverNode.h:
(WebCore::ConvolverNode::normalize): New method to return
normalization.
(WebCore::ConvolverNode::setNormalize): New method to set
normalization.
- webaudio/ConvolverNode.idl: Add normalize attribute.
- LayoutTests/webaudio/convolution-mono-mono.html:
- LayoutTests/webaudio/convolution-mono-mono-expected.txt:
- LayoutTests/webaudio/resources/convolution-testing.js:
Test for convolution. Tests only work when normalization is
disabled.
- 12:17 PM Changeset in webkit [104475] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224
Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.
Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.
Fixing memory leaks. So, no new test case is introduced.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
- 12:15 PM Changeset in webkit [104474] by
-
- 14 edits1 add in trunk/Source
Avoid unnecessary TextureManager::reduceMemoryToLimit().
https://bugs.webkit.org/show_bug.cgi?id=75632
Source/WebCore:
Unnecessary TextureManager::reduceMemoryToLimit() will cause some tile
textures that are required soon to be unnecessarily removed/replaced,
and degrade performance, sometimes significantly.
For example, CCLayerTreeHost::setViewport will be called during
scrolling. The original code would call TextureManager::reduceMemoryToLimit(),
causing some textures unnecessarily discarded and then recreated
repeatedly during scrolling.
It's also unnecessary to call TextureManager::reduceMemoryToLimit()
from TextureManager::setPreferredMemoryLimitBytes() because the limit
is not a hard limit. The callers should call reduceMemoryToLimit()
explicitly if it wants it when setting the preferred memory limit.
Reviewed by James Robinson.
Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame): Call reduceMemoryToLimit() explicitly
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::setPreferredMemoryLimitBytes): Removed call to reduceMemoryToLimit().
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize): Changed name from setViewport(). Check change of viewportSize.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setViewportSize): Changed name from setViewport()
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
Source/WebKit/chromium:
Main part of the change is in Source/WebCore.
Reviewed by James Robinson.
Tests: webkit_unit_tests --gtest_filter=TextureManagerTest.*:CCLayerTreeHostTestSetViewportSize.*
- WebKit.gypi:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setViewportSize):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestOpacityChange::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::CCLayerTreeHostTestSetViewportSize):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestSetViewportSize::afterTest):
(WTF::TEST_F):
- tests/TextureManagerTest.cpp: Added.
(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeTextureAllocator::deleteTexture):
(WTF::texturesMemorySize):
(WTF::createTextureManager):
(WTF::requestTexture):
(WTF::TEST):
- 12:02 PM Changeset in webkit [104473] by
-
- 2 edits in trunk/Source/JavaScriptCore
There is no support for fastcall in Solaris Studio.
Fixes build on Solaris.
https://bugs.webkit.org/show_bug.cgi?id=75736
Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.
- jit/JITStubs.h:
- 11:46 AM Changeset in webkit [104472] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] JPEG RGB swizzling order should match platform pixel format
https://bugs.webkit.org/show_bug.cgi?id=75861
Choose between JCS_EXT_BGRX and JCS_EXT_RGBX channel swizzling
based on the configured Skia 32-bit pixel format.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-09
Reviewed by Kenneth Russell.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(rgbOutputColorSpace):
- 11:44 AM Changeset in webkit [104471] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build failure on Solaris
https://bugs.webkit.org/show_bug.cgi?id=75733
Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-09
Reviewed by Gavin Barraclough.
- wtf/ByteArray.h:
- 11:41 AM Changeset in webkit [104470] by
-
- 1 edit in branches/chromium/963/Source/WebKit/chromium/src/WebFrameImpl.cpp
Merge 104419 - [chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806
Reviewed by Adam Barth.
Source/WebKit/chromium:
TEST: fast/autoresize/autoresize-with-iframe.html
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.
LayoutTests:
- fast/autoresize/autoresize-with-iframe-expected.txt: Added.
- fast/autoresize/autoresize-with-iframe.html: Added.
- fast/autoresize/basic.html: Pulled out autoresize-util.js
- fast/autoresize/resources/autoresize-util.js: Added.
(log):
(shouldBe):
- fast/autoresize/resources/iframe.html: Added.
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/9151009
- 11:26 AM Changeset in webkit [104469] by
-
- 3 edits2 adds in trunk
getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630
Reviewed by Tony Chang.
Source/WebCore:
Implement getComputedStyle for border-radius shorthand property.
Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add new tests to make sure we return the correct values.
- fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.
- 11:17 AM Changeset in webkit [104468] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Clean up some cruft from WTF's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420
Reviewed by Daniel Bates.
- wtf/CMakeLists.txt: Remove the unused WTF_PORT_FLAGS variable; add
all needed paths to WTF_INCLUDE_DIRECTORIES in a single place.
- 11:16 AM Changeset in webkit [104467] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-gpu-cg-mac
Remove expected results for Chromium Mac CG. This configuration is no longer supported.
- 11:15 AM Changeset in webkit [104466] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-snowleopard
Remove expected results for Chromium Mac CG. This configuration is no longer supported.
- 11:15 AM Changeset in webkit [104465] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-cg-mac-leopard
Remove expected results for Chromium Mac CG. This configuration is no longer supported.
- 11:15 AM Changeset in webkit [104464] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-cg-mac
Remove expected results for Chromium Mac CG. This configuration is no longer supported.
- 10:38 AM Changeset in webkit [104463] by
-
- 3 edits in trunk/Tools
Print an error message when NRWT can't run Apache
Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.check_httpd): Print an error message when Apache returns an error code instead of
failing silently.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
run Apache.
(PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
fails.
- 7:34 AM Changeset in webkit [104462] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75856
media/track/track-webvtt-tc026-voice.html is crashing on Chromium
Debug Mac after http://trac.webkit.org/changeset/104327/
Tracking in bug 75817.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:32 AM Changeset in webkit [104461] by
-
- 2 edits in trunk/Tools
[Gtk][ARM] Cross compiler buildbot is failing after r103040
https://bugs.webkit.org/show_bug.cgi?id=75846
Reviewed by Philippe Normand.
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
- 7:19 AM Changeset in webkit [104460] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r104418.
http://trac.webkit.org/changeset/104418
https://bugs.webkit.org/show_bug.cgi?id=75855
we still need to build against CG on Mac sometimes (Requested
by epoger on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- 7:08 AM Changeset in webkit [104459] by
-
- 6 edits in trunk
[GTK] [AC] Simplify accelerated compositing build options
https://bugs.webkit.org/show_bug.cgi?id=75518
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-09
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: Remove the --enable-3d-rendering option. It's enabled by
default now when accelerated compositing is enabled.
- GNUmakefile.am: Automatically enable 3D rendering when accelerated compositing
is turned on.
Source/WebCore:
- GNUmakefile.am: Automatically enable 3D rendering when AC is available.
- GNUmakefile.list.am: Clean up a comment.
- 6:59 AM Changeset in webkit [104458] by
-
- 3 edits in trunk/Source/WebCore
possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676
Reviewed by Andreas Kling.
Based on the stacks, CSSStyleSelector may be getting deleted from under the
CSSStyleSelector::appendAuthorStylesheets call. Protect by temporarily detaching
from the document. Also add assertions to catch the case.
No test, there is no known repro and the fix is speculative.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
- 6:30 AM Changeset in webkit [104457] by
-
- 3 edits in trunk/Source/WebCore
Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=75723
Reviewed by Andreas Kling.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):
- css/CSSStyleSelector.h:
- 6:28 AM Changeset in webkit [104456] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75852
http/tests/inspector/network/download.html is timing out on mac, and
occasionally on other platforms too.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:14 AM Changeset in webkit [104455] by
-
- 5 edits1 add in trunk/Tools
[Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75807
This patch adds a new icon to navigationbar of the Qt MiniBrowser
which allows you to dynamically toggle whether touch mocking is
enabled or disabled.
Patch by Alexander Færøy <ahf@0x90.dk> on 2012-01-09
Reviewed by Tor Arne Vestbø.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
(WindowOptions::touchMockingEnabled):
(WindowOptions::setTouchMockingEnabled):
- MiniBrowser/qt/icons/touch.png: Added.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- 6:05 AM Changeset in webkit [104454] by
-
- 2 edits1 copy in trunk/LayoutTests
Fix expected files for new test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
https://bugs.webkit.org/show_bug.cgi?id=75847
Reviewed by Philippe Normand.
- fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add JSC specifix expected file as generic expected file.
- platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Add V8 specifix expected file.
- 6:00 AM Changeset in webkit [104453] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75849
We need to prevent TextTrack and TextTrackCue from being
garbage collected when the parent/owner is still reachable.
This is tracked in bug 73865.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 5:48 AM Changeset in webkit [104452] by
-
- 8 edits in trunk/Source/WebCore
Extend CSSValueList to allow slash separated lists.
https://bugs.webkit.org/show_bug.cgi?id=75841
Reviewed by Andreas Kling.
Multiple CSS properties are using slash to separate
various parts (e.g. border-radius) so having this
feature available in CSSValueList will make it easier
in the future to support these properties.
No new tests : existing ones should cover the refactor.
- css/CSSInitialValue.h:
(WebCore::CSSInitialValue::isImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):
- css/CSSValue.cpp:
(WebCore::CSSValue::isImplicitInitialValue):
- css/CSSValue.h:
In order for CSSValue to not grow I moved m_isImplicitInitialValue
back to CSSInitialValue as this object is used only in CSSValuePool
and is allocated only twice.
(WebCore::CSSValue::CSSValue):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
Fix also usage of PassRefPtr.
(WebCore::CSSValueList::customCssText):
Refactor to use StringBuilder.
- css/CSSValueList.h:
(WebCore::CSSValueList::createCommaSeparated):
(WebCore::CSSValueList::createSpaceSeparated):
(WebCore::CSSValueList::createSlashSeparated):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
- css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
- 5:22 AM Changeset in webkit [104451] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75844
media/track/track-cues-cuechange.html is failing after
http://trac.webkit.org/changeset/104327/
Tracking in bug 75817.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:35 AM Changeset in webkit [104450] by
-
- 23 edits in trunk
[Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601
Reviewed by Kenneth Rohde Christiansen.
The current implementation uses the scale property of the QQuickWebPage
to scale the page in response to pinch gestures.
However for layout and anchoring to work correctly in QML, pinching needs
to change the page size.
This patch applies the pinch scale to the page size and to the transformation
matrix of the drawing area.
Thus the page item's coordinate system is no longer a direct representation
of the WebCore::Page coordinate system and it is no longer suitable as
an inertial frame of reference for input events. The event propagation had
to be moved to the QQuickWebView and the positions translated to content
coordinates when NativeWebEvents are created.
Re-landing with fixed event delivery for the test infrastructure.
- Shared/NativeWebMouseEvent.h:
- Shared/NativeWebTouchEvent.h:
- Shared/NativeWebWheelEvent.h:
- Shared/qt/NativeWebMouseEventQt.cpp:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- Shared/qt/NativeWebTouchEventQt.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- Shared/qt/NativeWebWheelEventQt.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
- Shared/qt/WebEventFactoryQt.h:
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::geometryChanged):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::usesTraditionalDesktopBehaviour):
(QQuickWebPage::setUsesTraditionalDesktopBehaviour):
(QQuickWebPage::eventHandler):
(QQuickWebPage::setContentSize):
(QQuickWebPage::contentSize):
(QQuickWebPage::setContentScale):
(QQuickWebPage::contentScale):
(QQuickWebPage::transformFromItem):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::setUseTraditionalDesktopBehaviour):
(QQuickWebViewExperimental::useTraditionalDesktopBehaviour):
(QQuickWebView::mapToWebContent):
(QQuickWebView::mapRectToWebContent):
(QQuickWebView::mapFromWebContent):
(QQuickWebView::mapRectFromWebContent):
(QQuickWebView::geometryChanged):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::contentsSize):
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
- UIProcess/qt/QtViewportInteractionEngine.h:
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleSingleTapEvent):
(QtWebPageEventHandler::handleDoubleTapEvent):
(QtWebPageEventHandler::touchEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
- 4:13 AM Changeset in webkit [104449] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Set color_set function to the clipped smart class.
https://bugs.webkit.org/show_bug.cgi?id=75286
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-09
Reviewed by Andreas Kling.
Set _ewk_view_smart_color_set() function to the clipped smart class's color_set,
so application can set webpage's background color using evas_object_color_set() API.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_color_set):
(ewk_view_smart_class_init):
- 4:06 AM Changeset in webkit [104448] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75840
Unreviewed.
fast/filesystem/file-writer-abort.html is occasionally crashing
also on Windows.
- platform/chromium/test_expectations.txt:
- 3:54 AM Changeset in webkit [104447] by
-
- 7 edits1 add in trunk/Source/WebCore
[Texmap] Move surface management from TextureMapperNode to TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=75779
Instead of a TextureMapperSurfaceManager class inside of TextureMapperNode.cpp, we now
maintain that surface pool inside of the TextureMapper class. This will later allow us to
allocate intermediate surface from within TextureMapperGL, a functionality we need for
filters.
Also, surfaces are not automatically created with the viewport size, but rather with the
size passed as a parameter. The surface from the pool is the smallest texture that is
larger than the required size, or any texture if such texture is not yet allocated.
Reviewed by Kenneth Rohde Christiansen.
Tests in LayoutTests/compositing already cover this.
- GNUmakefile.list.am: Added TextureMapper.cpp to the build.
- Target.pri: Added TextureMapper.cpp to the build.
- WebCore.gypi: Added TextureMapper.cpp to the build.
- platform/graphics/texmap/TextureMapper.cpp: Added.
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::paintRecursive):
- platform/graphics/texmap/TextureMapperNode.h:
(WebCore::TextureMapperNode::TextureMapperNode):
- 2:16 AM Changeset in webkit [104446] by
-
- 6 edits in trunk/Source
[Gtk] Regression: text-inserted events lack text inserted and current line
https://bugs.webkit.org/show_bug.cgi?id=72830
Reviewed by Martin Robinson.
Source/WebCore:
Fix issue getting the exposed text for an accessibility object at,
before of after a given offset, after changing it at least once.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_class_init): Don't initialize
gailTextUtilQuark, it won't be used anymore.
(getGailTextUtilForAtk): Don't cache the GailTextUtil as object
data, but create a new one each time this function is called.
(webkit_accessible_text_get_caret_offset): Simplified code by
using the new focusedObjectAndCaretOffsetUnignored function,
instead of the old objectAndOffsetUnignored function.
(focusedObjectAndCaretOffsetUnignored): Rewrite of the old
objectAndOffsetUnignored function so it now needs less
parameters than before and takes care of carefully selecting the
start and end visible positions to calculate the position of the
caret from the point of view of the accessibility object of
reference passed as the only input parameter now. Updated callers.
- accessibility/gtk/AccessibilityObjectWrapperAtk.h:
- editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Simplified code by calling to focusedObjectAndCaretOffsetUnignored
function, instead of the old objectAndOffsetUnignored function.
Source/WebKit/gtk:
Updated unit tests to check that both getting the current position
for the caret and the exposed text at, before or after a given
offset for an accessible object works as expected.
- tests/testatk.c:
(runGetTextTests): For objects implementing AtkEditableText, try
to change the exposed text and retrieve it again as a full line.
(testWebkitAtkCaretOffsets): For a text control (a text entry),
set the caret offset to a value greater than 1 and retrieve it.
- 2:00 AM Changeset in webkit [104445] by
-
- 4 edits2 adds in trunk
Subtree invalidation on stylesheet change
https://bugs.webkit.org/show_bug.cgi?id=75834
Source/WebCore:
Reviewed by Andreas Kling.
Currently if we add a stylesheet with scoped selectors and matching scope elements exist,
we recalculate the entire document style. It is sufficient to invalidate the subtrees
matching the scope only.
This allows us to do less full style recalcs on many popular web sites (nytimes.com for example).
Subtree recalcs are typically much cheaper.
Test: fast/css/id-or-class-before-stylesheet.html
- dom/Document.cpp:
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
LayoutTests:
Reviewed by Andreas Kling.
- fast/css/id-or-class-before-stylesheet-expected.txt: Added.
- fast/css/id-or-class-before-stylesheet.html: Added.
- 1:53 AM Changeset in webkit [104444] by
-
- 4 edits in trunk
Unreviewed. Fix make distcheck issues.
Source/WebCore:
- GNUmakefile.list.am: Add missing header.
Tools:
- MiniBrowser/gtk/GNUmakefile.am:
- 1:38 AM Changeset in webkit [104443] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Use join(", ", @arguments) to build a method argument string
in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=75830
Reviewed by Adam Barth.
The code in CodeGeneratorJS.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).
Test: bindings/scripts/test/*
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
- 1:09 AM Changeset in webkit [104442] by
-
- 3 edits in trunk/Source/WebCore
CSSMutableStyleDeclaration: Remove propertiesEqual().
<http://webkit.org/b/75829>
Reviewed by Antti Koivisto.
Remove propertiesEqual() since it was wrong (it only compared CSSValue pointers,
not the actual values.)
Skip comparing the style declarations in NamedNodeMap::mappedMapsEquivalent()
and just compare pointers instead. This is possible because the declarations
all come from the mapped attribute/declaration table.
- css/CSSMutableStyleDeclaration.h:
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mappedMapsEquivalent):
- 12:53 AM Changeset in webkit [104441] by
-
- 3 edits2 adds in trunk
insertAdjacentHTML doesn't play nice with DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=75826
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html
Document nodes aren't the only non-Element ContainerNodes.
- html/HTMLElement.cpp:
(WebCore::contextElementForInsertion):
LayoutTests:
- fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: Added.
- fast/dom/insertAdjacentHTML-DocumentFragment-crash.html: Added.
- 12:42 AM Changeset in webkit [104440] by
-
- 2 edits in trunk/Source/WebCore
CSSStyleSelector: Any attribute with a decl() can be assumed to be mapped.
<http://webkit.org/b/75832>
Reviewed by Antti Koivisto.
Replace isMappedAttribute() check with an assertion. Only a mapped attribute
will have an associated style declaration.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
- 12:32 AM Changeset in webkit [104439] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline after r104412.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
- platform/gtk/Skipped: Skip fast/text/international/spaces-combined-in-vertical-text.html
- 12:26 AM Changeset in webkit [104438] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Use join(", ", @arguments) to build a method argument
string in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=75828
Reviewed by Darin Adler.
The code in CodeGeneratorV8.pm to build a method argument string is dirty
and error-prone. It is concatenating arguments one by one judging whether
", " is necessary or not. This patch refactors the code so that it pushes
all arguments into @arguments and then builds a method string by
join(", ", @arguments).
Test: bindings/scripts/test/*
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString):
- 12:06 AM Changeset in webkit [104437] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r104412.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
Jan 8, 2012:
- 11:18 PM Changeset in webkit [104436] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix compilation error about ListHashSetReverseIterator
https://bugs.webkit.org/show_bug.cgi?id=75372
Reviewed by Darin Adler.
There is a typo in class ListHashSetReverseIterator:
typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
Should be
typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator;
- wtf/ListHashSet.h:
- 11:15 PM Changeset in webkit [104435] by
-
- 2 edits in trunk/Source/WebCore
Build fix: ScrollAnimatorMac has missing initializer in systemUptime()
https://bugs.webkit.org/show_bug.cgi?id=75827
Reviewed by Darin Adler.
Explicitly initialize the struct timeval to avoid compiler warnings.
- platform/mac/ScrollAnimatorMac.mm:
(systemUptime):
- 11:09 PM Changeset in webkit [104434] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 11:01 PM Changeset in webkit [104433] by
-
- 1 copy in tags/Safari-534.54.3
New tag.
- 10:56 PM Changeset in webkit [104432] by
-
- 1 edit4 adds in trunk/LayoutTests
color tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75819
Reviewed by Eric Seidel.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/color-hsl-expected.txt: Added.
- css3/calc/color-hsl.html: Added.
- css3/calc/color-rgb-expected.txt: Added.
- css3/calc/color-rgb.html: Added.
- 10:14 PM Changeset in webkit [104431] by
-
- 1 edit8 adds in trunk/LayoutTests
font tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75818
Reviewed by Eric Seidel.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/font-expected.txt: Added.
- css3/calc/font-monospace-expected.txt: Added.
- css3/calc/font-monospace.html: Added.
- css3/calc/font-size-expected.txt: Added.
- css3/calc/font-size-fractional-expected.txt: Added.
- css3/calc/font-size-fractional.html: Added.
- css3/calc/font-size.html: Added.
- css3/calc/font.html: Added.
- 10:01 PM Changeset in webkit [104430] by
-
- 2 edits in trunk/Source/WebCore
Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75820
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-08
Reviewed by Darin Adler.
Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.
No new tests required.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getShaderInfoLog):
- 8:27 PM Changeset in webkit [104429] by
-
- 3 edits in trunk/Source/JavaScriptCore
WinCE build fix after r104415.
- jit/JITExceptions.cpp:
- jit/JITExceptions.h:
- 6:57 PM Changeset in webkit [104428] by
-
- 1 edit4 adds in trunk/LayoutTests
border tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75815
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
Reviewed by Adam Barth.
- css3/calc/border-expected.txt: Added.
- css3/calc/border-radius-expected-mismatch.html: Added.
- css3/calc/border-radius.html: Added.
- css3/calc/border.html: Added.
- 6:50 PM Changeset in webkit [104427] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame
https://bugs.webkit.org/show_bug.cgi?id=75611
Reviewed by Antonio Gomes.
In platform/network/blackberry/ResourceHandleBlackBerry.cpp, we were using
NetworkingContext::wrappedFrame() to access the frame associated with the
networking context. NetworkingContext::wrappedFrame() was added as a virtual
function by the BlackBerry porting internally. It's unnecessary because
FrameNetworkingContextBlackBerry inherits from FrameNetworkingContext which
has a protected frame() member which is exported as public in
FrameNetworkingContextBlackBerry. We don't want to upstream wrappedFrame()
as a specific change of the BlackBerry porting in
platform/network/NetworkingContext.h, so use the concrete networking context
FrameNetworkingContextBlackBerry to access the associated frame.
No functionalities changed, no new tests.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- 6:41 PM Changeset in webkit [104426] by
-
- 2 edits in trunk/LayoutTests
Add intermittent timeout expectations to media/track/track-cues-cuechange.html and
media/track/track-cues-enter-exit.html. The failure is tracked by the bug 75817.
- platform/chromium/test_expectations.txt:
- 6:33 PM Changeset in webkit [104425] by
-
- 8 edits54 deletes in trunk
Unreviewed, rolling out r104421.
http://trac.webkit.org/changeset/104421
https://bugs.webkit.org/show_bug.cgi?id=75816
Need to rebaseline some tests on Linux (Requested by noamr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08
Source/WebCore:
- Target.pri:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):
Tools:
- qmake/mkspecs/features/features.prf:
LayoutTests:
- platform/qt/Skipped:
- platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
- platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
- platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
- platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
- platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
- platform/qt/css3/filters/effect-blur-expected.png: Removed.
- platform/qt/css3/filters/effect-blur-expected.txt: Removed.
- platform/qt/css3/filters/effect-brightness-expected.png: Removed.
- platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
- platform/qt/css3/filters/effect-contrast-expected.png: Removed.
- platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
- platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
- platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
- platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
- platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
- platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
- platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
- platform/qt/css3/filters/effect-invert-expected.png: Removed.
- platform/qt/css3/filters/effect-invert-expected.txt: Removed.
- platform/qt/css3/filters/effect-opacity-expected.png: Removed.
- platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
- platform/qt/css3/filters/effect-saturate-expected.png: Removed.
- platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
- platform/qt/css3/filters/effect-sepia-expected.png: Removed.
- platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
- platform/qt/css3/filters/filter-animation-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-expected.txt: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-expected.png: Removed.
- platform/qt/css3/filters/filter-property-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
- platform/qt/css3/filters/filter-region-expected.png: Removed.
- platform/qt/css3/filters/filter-region-expected.txt: Removed.
- platform/qt/css3/filters/filter-repaint-expected.png: Removed.
- platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
- platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
- platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
- platform/qt/css3/filters/filtered-inline-expected.png: Removed.
- platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
- platform/qt/css3/filters/nested-filter-expected.png: Removed.
- platform/qt/css3/filters/nested-filter-expected.txt: Removed.
- platform/qt/css3/filters/nested-filters-expected.png: Removed.
- platform/qt/css3/filters/nested-filters-expected.txt: Removed.
- platform/qt/css3/filters/regions-expanding-expected.png: Removed.
- platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
- platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
- platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
- 6:14 PM Changeset in webkit [104424] by
-
- 4 edits2 adds in trunk/LayoutTests
Another Chromium Windows and Chromium Linux rebaseline after r104240.
The expected result committed in r104361 was clearly wrong.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
- 5:01 PM Changeset in webkit [104423] by
-
- 6 edits in trunk/Tools
Remove support for Chromium Mac CG from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=75814
Reviewed by Eric Seidel.
This configuration no longer exists. This patch is mostly a matter of
updating config.js and removing the examples from the unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 4:49 PM Changeset in webkit [104422] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove Mac CG specific expectations in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=75813
Unreviewed.
This configuration no longer exists and this change is needed to stop
the bots from erroring out.
- platform/chromium/test_expectations.txt:
- 4:46 PM Changeset in webkit [104421] by
-
- 8 edits54 adds in trunk
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777
Source/WebCore:
Enable CSS_FILTERS and unskip the tests.
Reviewed by Kenneth Rohde Christiansen.
Filter tests are now unskipped for Qt.
- Target.pri: add missing files to build.
Source/WebKit/qt:
For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):
Tools:
Add the CSS_FILTERS feature flag to Qt.
Reviewed by Kenneth Rohde Christiansen.
- qmake/mkspecs/features/features.prf:
LayoutTests:
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/Skipped: Unskip filter tests that work.
- platform/qt/css3/filters/*: Added Qt specific results.
- 4:32 PM Changeset in webkit [104420] by
-
- 3 edits in trunk/Tools
Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766
Reviewed by Eric Seidel.
Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
(Chromium still comes before GTK and Qt).
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 4:29 PM Changeset in webkit [104419] by
-
- 4 edits5 adds in trunk
[chromium] iframes in an autoresized window get sized incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=75806
Reviewed by Adam Barth.
Source/WebKit/chromium:
TEST: fast/autoresize/autoresize-with-iframe.html
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView): Only do autoresizing
for the main frame not child frames.
LayoutTests:
- fast/autoresize/autoresize-with-iframe-expected.txt: Added.
- fast/autoresize/autoresize-with-iframe.html: Added.
- fast/autoresize/basic.html: Pulled out autoresize-util.js
- fast/autoresize/resources/autoresize-util.js: Added.
(log):
(shouldBe):
- fast/autoresize/resources/iframe.html: Added.
- 4:27 PM Changeset in webkit [104418] by
-
- 5 edits in trunk/Source
[Chromium] Remove use_skia option from GYP
https://bugs.webkit.org/show_bug.cgi?id=75811
Reviewed by Ryosuke Niwa.
The CG configuration of Chromium Mac is no longer supported.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- 4:12 PM Changeset in webkit [104417] by
-
- 4 edits in trunk/Tools
Remove the concept of core builders from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75809
Reviewed by Ryosuke Niwa.
Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
and remove the relevant code.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot.init):
(BuildBot._matches_regexps):
(BuildBot._builder_statuses_with_names_matching_regexps):
(BuildBot.builder_statuses):
(BuildBot.failure_map):
(BuildBot._latest_builds_from_builders):
(BuildBot.last_green_revision):
- Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuildBot.builder_statuses):
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_status_parsing):
(test_last_green_revision):
(test_last_green_revision.mock_builds_from_builders):
- 4:04 PM Changeset in webkit [104416] by
-
- 19 edits in trunk/Tools
Remove Chromium Mac CG concept from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=75810
Reviewed by Ryosuke Niwa.
This configuration no longer exists. We can remove all the supporting
code from webkitpy.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
(BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
- Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(_default_tests_paths):
(ChromiumGpuLinuxPort.tests):
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
(ChromiumGpuTest.integration_test_chromium_gpu_mac):
(ChromiumGpuTest.assert_port_works):
(ChromiumGpuTest.test_baseline_paths):
(ChromiumGpuTest.test_graphics_type):
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
(ChromiumMacPort.init):
(ChromiumMacPort.baseline_search_path):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_graphics_type):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._port_name_from_arguments_and_options):
(PortFactory.get):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_chromium_gpu_mac):
(FactoryTest.test_chromium_mac):
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
(GetGoogleChromePortTest._verify_expectations_overrides):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockChromiumDRTTest.test_chromium_parse_options):
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
(test_url_fetcher):
(test_zip_factory):
(test_archive):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_expectations):
- 3:46 PM Changeset in webkit [104415] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
The JIT's protocol for exception handling should be available to other parts of the system
https://bugs.webkit.org/show_bug.cgi?id=75808
<rdar://problem/10661025>
Reviewed by Oliver Hunt.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- jit/JITExceptions.cpp: Added.
(JSC::genericThrow):
(JSC::jitThrow):
- jit/JITExceptions.h: Added.
- jit/JITStubs.cpp:
- runtime/JSGlobalData.h:
- 3:44 PM Changeset in webkit [104414] by
-
- 10 edits6 adds in trunk
Valid canonical URLs should have a lowercase hostname
https://bugs.webkit.org/show_bug.cgi?id=75771
Reviewed by Adam Barth.
Source/WebCore:
According to the RFC 3986 (and other browsers implementation), the hostname
of valid canonical URLs should be lowercase.
This patch lowercase the hostname in KURL::parse() similarily to what we
do for the scheme.
Tests: fast/url/host-lowercase-per-scheme.html
fast/url/safari-extension.html
- platform/KURL.cpp:
(WebCore::isCanonicalHostnameLowercaseForScheme):
(WebCore::KURL::parse):
LayoutTests:
Update the test results for existing tests validating the hostname.
Added the test safari-extension.html for checking regressions of
the safari-extension:// protocol.
Added host-lowercase-per-scheme.html for testing the hostname is
set to lowercase for regognized Internet protocols.
- fast/url/host-expected.txt:
- fast/url/host-lowercase-per-scheme-expected.txt: Added.
- fast/url/host-lowercase-per-scheme.html: Added.
- fast/url/idna2008-expected.txt:
- fast/url/ipv4-expected.txt:
- fast/url/ipv6-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/safari-extension-expected.txt: Added.
- fast/url/safari-extension.html: Added.
- fast/url/standard-url-expected.txt:
- platform/chromium/fast/url/host-lowercase-per-scheme-expected.txt: Added.
- platform/chromium/fast/url/safari-extension-expected.txt: Added.
- 3:28 PM Changeset in webkit [104413] by
-
- 3 edits in trunk/Tools
Categorize bots by ports instead of core/non-core separation
https://bugs.webkit.org/show_bug.cgi?id=75766
Reviewed by Adam Barth.
Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 3:15 PM Changeset in webkit [104412] by
-
- 10 edits in trunk/Source/WebCore
Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796
Reviewed by Sam Weinig.
This patch contains only renames and FIXME comments. No behavior change.
- bindings/js/JSDOMBinding.cpp:
(WebCore::allowAccessToNode):
(WebCore::allowAccessToFrame):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::allowSettingJavascriptURL):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
- 2:48 PM Changeset in webkit [104411] by
-
- 15 edits in trunk/Source/WebCore
Remove deprecated toDynamicFrame and unused [CallWith=DynamicFrame]
https://bugs.webkit.org/show_bug.cgi?id=75795
Reviewed by Eric Seidel.
We've succeeded in removing all the callers fo this function, including
all the uses of CallWith=DynamicFrame in IDL files.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
- 1:59 PM Changeset in webkit [104410] by
-
- 14 edits in trunk/Source/WebCore
NeedsUserGestureCheck IDL attribute is no longer used
https://bugs.webkit.org/show_bug.cgi?id=75794
Reviewed by Eric Seidel.
This IDL attribute is no longer used because we use static state to
keep track of the user gesture state. We can delete the code that
supports it.
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/TestObj.idl:
- 1:44 PM Changeset in webkit [104409] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r103859): WKViews leak
https://bugs.webkit.org/show_bug.cgi?id=75805
The flags changed event monitor added in r103859 was retaining the WKView (as it references
self in the handler block), causing it to leak.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): Moved call to remove the flags changed event monitor from here...
(-[WKView viewDidMoveToWindow]): ...to here. Moved call to add the flags changed event
monitor to here from...
(-[WKView initWithFrame:contextRef:pageGroupRef:]): ...here.
- 1:33 PM Changeset in webkit [104408] by
-
- 5 edits in trunk/Source/WebCore
Remove unused security functions from V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=75797
Reviewed by Eric Seidel.
This functions have no callers. They can be removed.
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/specialization/V8BindingState.cpp:
- bindings/v8/specialization/V8BindingState.h:
- 1:31 PM Changeset in webkit [104407] by
-
- 4 edits in trunk/Source/WebCore
Assertion failure under SharedBuffer::append() when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=75656
Reviewed by Darin Adler.
Update the implementation of SubresourceLoader::didReceiveDataArray() to conform to the
refactoring done as part of bug 71149 in r100311.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::errorLoadingResource):
- loader/SubresourceLoader.h:
- loader/cf/SubresourceLoaderCF.cpp:
(WebCore::SubresourceLoader::didReceiveDataArray):
- 1:03 PM Changeset in webkit [104406] by
-
- 6 edits9 deletes in trunk/Source/WebCore
Remove V8-specific Java Bridge code
https://bugs.webkit.org/show_bug.cgi?id=75801
Reviewed by Darin Adler.
Also remove superfluous JSC and V8 guards, as the code is now used only
with JSC.
No new tests, removing dead code only.
- WebCore.gypi:
- bridge/jni/JNIUtility.cpp:
(JSC::Bindings::javaTypeFromClassName):
(JSC::Bindings::signatureFromJavaType):
(JSC::Bindings::getJNIField):
(JSC::Bindings::callJNIMethod):
- bridge/jni/JavaType.h:
- bridge/jni/jsc/JavaMethodJSC.cpp:
(appendClassName):
(JavaMethod::signature):
- bridge/jni/v8/JNIUtilityPrivate.cpp: Removed.
- bridge/jni/v8/JNIUtilityPrivate.h: Removed.
- bridge/jni/v8/JavaClassV8.h: Removed.
- bridge/jni/v8/JavaFieldV8.h: Removed.
- bridge/jni/v8/JavaInstanceV8.h: Removed.
- bridge/jni/v8/JavaMethodV8.h: Removed.
- bridge/jni/v8/JavaNPObjectV8.cpp: Removed.
- bridge/jni/v8/JavaNPObjectV8.h: Removed.
- bridge/jni/v8/JavaValueV8.h: Removed.
- bridge/jsc/BridgeJSC.h:
- 11:35 AM Changeset in webkit [104405] by
-
- 8 edits54 deletes in trunk
Unreviewed, rolling out r104403.
http://trac.webkit.org/changeset/104403
https://bugs.webkit.org/show_bug.cgi?id=75803
It broke all tests on Qt5 (Requested by Ossy_weekend on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-08
Source/WebCore:
- Target.pri:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):
Tools:
- qmake/mkspecs/features/features.prf:
LayoutTests:
- platform/qt/Skipped:
- platform/qt/css3/filters/add-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
- platform/qt/css3/filters/crash-filter-change-expected.png: Removed.
- platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
- platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/qt/css3/filters/custom-filter-property-parsing-expected.txt: Removed.
- platform/qt/css3/filters/custom-filter-property-parsing-invalid-expected.txt: Removed.
- platform/qt/css3/filters/effect-blur-expected.png: Removed.
- platform/qt/css3/filters/effect-blur-expected.txt: Removed.
- platform/qt/css3/filters/effect-brightness-expected.png: Removed.
- platform/qt/css3/filters/effect-brightness-expected.txt: Removed.
- platform/qt/css3/filters/effect-contrast-expected.png: Removed.
- platform/qt/css3/filters/effect-contrast-expected.txt: Removed.
- platform/qt/css3/filters/effect-drop-shadow-expected.png: Removed.
- platform/qt/css3/filters/effect-drop-shadow-expected.txt: Removed.
- platform/qt/css3/filters/effect-grayscale-expected.png: Removed.
- platform/qt/css3/filters/effect-grayscale-expected.txt: Removed.
- platform/qt/css3/filters/effect-hue-rotate-expected.png: Removed.
- platform/qt/css3/filters/effect-hue-rotate-expected.txt: Removed.
- platform/qt/css3/filters/effect-invert-expected.png: Removed.
- platform/qt/css3/filters/effect-invert-expected.txt: Removed.
- platform/qt/css3/filters/effect-opacity-expected.png: Removed.
- platform/qt/css3/filters/effect-opacity-expected.txt: Removed.
- platform/qt/css3/filters/effect-saturate-expected.png: Removed.
- platform/qt/css3/filters/effect-saturate-expected.txt: Removed.
- platform/qt/css3/filters/effect-sepia-expected.png: Removed.
- platform/qt/css3/filters/effect-sepia-expected.txt: Removed.
- platform/qt/css3/filters/filter-animation-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-expected.txt: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-expected.png: Removed.
- platform/qt/css3/filters/filter-property-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
- platform/qt/css3/filters/filter-region-expected.png: Removed.
- platform/qt/css3/filters/filter-region-expected.txt: Removed.
- platform/qt/css3/filters/filter-repaint-expected.png: Removed.
- platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
- platform/qt/css3/filters/filter-with-transform-expected.png: Removed.
- platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
- platform/qt/css3/filters/filtered-inline-expected.png: Removed.
- platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
- platform/qt/css3/filters/nested-filter-expected.png: Removed.
- platform/qt/css3/filters/nested-filter-expected.txt: Removed.
- platform/qt/css3/filters/nested-filters-expected.png: Removed.
- platform/qt/css3/filters/nested-filters-expected.txt: Removed.
- platform/qt/css3/filters/regions-expanding-expected.png: Removed.
- platform/qt/css3/filters/regions-expanding-expected.txt: Removed.
- platform/qt/css3/filters/remove-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
- platform/qt/css3/filters/simple-filter-rendering-expected.png: Removed.
- platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
- 11:22 AM Changeset in webkit [104404] by
-
- 2 edits in trunk/Source/WebCore
Don't create style selector in Element::recalcStyleIfNeededAfterAttributeChanged if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=75802
Rubber-stamped by Andreas Kling.
Element::recalcStyleIfNeededAfterAttributeChanged shouldn't create style selector for attribute
check if it doesn't already exist. We are going to need a full style recalc anyway in that case
and the constructed style selector may get throw out again.
- dom/Element.cpp:
(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
- 10:05 AM Changeset in webkit [104403] by
-
- 8 edits55 adds in trunk
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777
Source/WebCore:
Enable CSS_FILTERS and unskip the tests.
Reviewed by Kenneth Rohde Christiansen.
Filter tests are now unskipped for Qt.
- Target.pri: add missing files to build.
Source/WebKit/qt:
For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):
Tools:
Add the CSS_FILTERS feature flag to Qt.
Reviewed by Kenneth Rohde Christiansen.
- qmake/mkspecs/features/features.prf:
LayoutTests:
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/Skipped: Unskip filter tests that work.
- platform/qt/css3/filters/*: Added Qt specific results.
- 8:46 AM Changeset in webkit [104402] by
-
- 3 edits2 adds in trunk/Tools
Rewrite the CSS parser of prepare-ChangeLog with unittests.
https://bugs.webkit.org/show_bug.cgi?id=75202
Reviewed by David Kilzer.
The current CSS parser can just parse simple CSSes like
foo bar baz {
property1: value;
property2: value;
}
, and cannot parse comments nor a CSS in which a selector and {
appears in different lines. This patch rewrites the CSS parser
(i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
shown in css_unittests.css.
Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
- Scripts/prepare-ChangeLog:
(get_selector_line_ranges_for_css):
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
(element1):
(element2):
(element3):
(element4.p):
(element5.p.q.r.s):
(element6#p):
(element7 element8):
(element9.p element10.q):
(element11#p element12#q):
(element13, element14):
(.p):
(#p):
(.p element15 #q element16.r element17#s):
(element18:target):
(element19):
(element20):
(element21):
(element22):
- 8:21 AM Changeset in webkit [104401] by
-
- 4 edits in trunk/Tools
The Perl parser of prepare-ChangeLog can parse here-documents
https://bugs.webkit.org/show_bug.cgi?id=73208
Reviewed by David Kilzer.
Currently prepare-ChangeLog cannot recognize here-documents in Perl,
which results in wrong subroutine names in ChangeLogs.
With this patch, prepare-ChangeLog can judge whether the line of "}"
is the end of a subroutine or a line inside a here-document.
Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_perl):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
Added test cases for here-documents.
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(func13):
(func14):
(func15):
(func16):
- 8:15 AM Changeset in webkit [104400] by
-
- 3 edits2 adds in trunk/Tools
Add unittests for the JavaScript parser of prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=75201
Reviewed by David Kilzer.
javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
of prepare-ChangeLog.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_javascript): Before this patch, a string found was just
omitted from parsing. Thus,
str = "foo"
function func() {
}
was recognized as equivalent to
str = function func() {
}
This patch replaces a string with a dummy identifier 'string_appeared_here'
to tell the parser that a string appeared there.
- Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
(func1):
(func2):
(func3):
(func4):
(func5):
(func6):
(func7):
(func8):
(func9):
(func10):
(func11):
(func12):
(funcOverloaded):
(Func1.prototype.get x1):
(Func1.prototype.get x2):
(Func1.prototype.set x1):
(Func1.prototype.set x3):
(Func2.prototype.func13):
(Func2.prototype.func14):
(Func2.prototype.func15):
(func16.func17):
(func16.func18):
(func16.func19):
(func16):
- 3:45 AM Changeset in webkit [104399] by
-
- 5 edits2 adds in trunk
Source/WebCore: REGRESSION (r104060): Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633
Reviewed by Andreas Kling.
If something triggers CSSStyleSelector construction very early, before documentElement is known,
it won't be able to resolve viewport-related media queries. In the included test case
the attribute on <html> element triggers the style selector creation. I can't repro
the fast/media/viewport-media-query.html failure but I suspect it is the same issue with
a different mechanism for early CSSStyleSelector construction.
- Reset style selector on documentElement change.
- Remove the code for lazy documentElement initialization. It is not an useful optimization, the children of Document rarely change.
Test: fast/media/viewport-media-query-synchronous.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::childrenChanged):
- dom/Document.h:
(WebCore::Document::documentElement):
LayoutTests: Layout Test fast/media/viewport-media-query.html is occasionally failing
https://bugs.webkit.org/show_bug.cgi?id=75633
Reviewed by Andreas Kling.
- fast/media/viewport-media-query-synchronous-expected.txt: Added.
- fast/media/viewport-media-query-synchronous.html: Added.
- 12:06 AM Changeset in webkit [104398] by
-
- 12 edits3 adds in trunk
[chromium] Add layout test support for autosize code in FrameView.
https://bugs.webkit.org/show_bug.cgi?id=73631
Reviewed by Dmitry Titov.
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Expose the new autoresize method.
(LayoutTestController::reset): Set the autoresize mode back to false.
(LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
- DumpRenderTree/chromium/WebViewHost.h:
LayoutTests:
- fast/autoresize/basic-expected.txt: Added.
- fast/autoresize/basic.html: Added. Simple test to verify that autoresizing happens.
- platform/efl/Skipped: Skipped the new directory since the layout test controller on this platform, doesn't support enableAutoResizeMode.
- platform/gtk/Skipped: Ditto.
- platform/mac/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- platform/wincairo/Skipped: Ditto.
Jan 7, 2012:
- 7:59 PM Changeset in webkit [104397] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix.
- DOMHTMLClasses.cpp:
(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):
- 7:47 PM Changeset in webkit [104396] by
-
- 2 edits in trunk/Source/WebCore
Attempt to regenerate bindings on the Windows bot.
- html/HTMLCollection.h:
- 7:41 PM Changeset in webkit [104395] by
-
- 2 edits in trunk/Source/WebCore
Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()
Rubber-stamped by Adam Barth.
Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[]
and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice,
OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled,
it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(),
respectively. Hence, there may be a mismatch between the allocation and deallocation
routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using
operator new[].
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getProgramInfoLog):
- 4:45 PM Changeset in webkit [104394] by
-
- 11 edits2 moves4 adds4 deletes in trunk/LayoutTests
Unreviewed; chromium tests rebaselined after r104240.
- platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed.
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed.
- 4:09 PM Changeset in webkit [104393] by
-
- 4 edits2 adds2 deletes in trunk/LayoutTests
Unreviewed: updating expectations and rebaselining.
svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/.
- platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
- platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 3:51 PM Changeset in webkit [104392] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed: updating expectations and rebaslining.
svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/.
- platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
- platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 2:39 PM Changeset in webkit [104391] by
-
- 6 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline after r104386 and r104208.
- platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/table/032-expected.txt:
- platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
- platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
- 2:12 PM Changeset in webkit [104390] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: test expectations and filed WK75784.
- platform/chromium/test_expectations.txt:
- 1:50 PM Changeset in webkit [104389] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed https://bugs.webkit.org/show_bug.cgi?id=75783.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
- 10:43 AM Changeset in webkit [104388] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
2012-01-07 Chris Marrin <cmarrin@apple.com>
Fixed a warning in GTK build of ANGLE
Unreviewed.
- src/compiler/DetectRecursion.cpp: (DetectRecursion::~DetectRecursion):
- 9:46 AM Changeset in webkit [104387] by
-
- 2 edits in trunk/Tools
[WK2][GTK] Each test takes roughly half a second to load
https://bugs.webkit.org/show_bug.cgi?id=70699
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.
Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.
This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
- 9:18 AM Changeset in webkit [104386] by
-
- 4 edits in trunk
[GTK] Enable requestAnimationFrame in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=75773
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-07
Reviewed by Martin Robinson.
Tools:
Enable requestAnimationFrame for the Gtk port.
- Scripts/build-webkit:
LayoutTests:
Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.
- platform/gtk/Skipped:
- 7:22 AM Changeset in webkit [104385] by
-
- 3 edits in trunk/Source/WebCore
2012-01-07 Chris Marrin <cmarrin@apple.com>
Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363
Unreviewed.
- GNUmakefile.list.am:
- Target.pri:
- 2:08 AM Changeset in webkit [104384] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed C++ bindings build fix after r104383.
Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::impl):
- bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
(WebDOMTestEventConstructor::impl):
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::impl):
- bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
(WebDOMTestMediaQueryListListener::impl):
- bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
(WebDOMTestNamedConstructor::impl):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::impl):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::impl):
- 1:35 AM Changeset in webkit [104383] by
-
- 43 edits2 adds2 deletes in trunk
Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>
Reviewed by Sam Weinig.
Source/WebCore:
Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.
This is a behavior change, HTMLCollection wrappers now keep the base node alive.
Test: fast/dom/htmlcollection-protects-base.html
- html/HTMLCollection.h:
(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):
Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.
- dom/Element.cpp:
(WebCore::Element::~Element):
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::~Document):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
- html/HTMLSelectElement.h:
- html/HTMLSelectElement.cpp:
Remove HTMLCollection::detachFromNode() and call sites.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::namedItemWithIndex):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):
Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
- dom/ElementRareData.h:
(WebCore::ElementRareData::ensureCachedHTMLCollection):
- dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
- html/HTMLAllCollection.h:
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
- html/HTMLCollection.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):
- html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
- html/HTMLElement.h:
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::options):
- html/HTMLFormCollection.h:
- html/HTMLFormElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
- html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::create):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::create):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):
- html/HTMLMapElement.h:
- html/HTMLPropertiesCollection.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
- html/HTMLTableRowElement.h:
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):
- html/HTMLTableRowsCollection.h:
- html/HTMLTableSectionElement.h:
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::selectedOption):
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
- Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.
LayoutTests:
- Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
- Added a test to verify that HTMLCollection protects its base node from GC.
- fast/dom/htmlcollection-protects-base-expected.txt: Added.
- fast/dom/htmlcollection-protects-base.html: Added.
- fast/dom/htmlcollection-zombies-expected.txt: Removed.
- fast/dom/htmlcollection-zombies.html: Removed.
- 1:14 AM Changeset in webkit [104382] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix Qt build.
- page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
- 1:12 AM Changeset in webkit [104381] by
-
- 4 edits2 adds in trunk
REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
https://bugs.webkit.org/show_bug.cgi?id=75731
Reviewed by Andreas Kling.
Source/WebCore:
The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.
Test: fast/dom/node-list-length-after-removing-node.html
- dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):
- dom/DynamicNodeList.h:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):
LayoutTests:
Add a regression test. It reproduces the crash with a very high probability.
- fast/dom/node-list-length-after-removing-node-expected.txt: Added.
- fast/dom/node-list-length-after-removing-node.html: Added.
- 12:46 AM Changeset in webkit [104380] by
-
- 41 edits2 copies in trunk/Source/WebCore
Disconnecting DOMWindow properties is fragile and overly complicated
https://bugs.webkit.org/show_bug.cgi?id=75699
Reviewed by Alexey Proskuryakov.
Previously, we had to carefully check every object tree hanging off of
DOMWindow to make sure that every property correctly disconnected
itself and all its subobjects from the Frame when the DOMWindow
disconnected from the Frame.
This patch introduces DOMWindowProperty, which is a base class that
handles this work automagically, ensuring that we won't have any
dangling Frame pointers and removing a bunch of boilerplate code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- css/StyleMedia.cpp:
(WebCore::StyleMedia::StyleMedia):
- css/StyleMedia.h:
(WebCore::StyleMedia::create):
- loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::DOMApplicationCache):
(WebCore::DOMApplicationCache::disconnectFrame):
- loader/appcache/DOMApplicationCache.h:
- page/BarInfo.cpp:
(WebCore::BarInfo::BarInfo):
- page/BarInfo.h:
- page/Console.cpp:
(WebCore::Console::Console):
(WebCore::Console::memory):
- page/Console.h:
- page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
- page/DOMSelection.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::registerProperty):
(WebCore::DOMWindow::unregisterProperty):
(WebCore::DOMWindow::clear):
- page/DOMWindow.h:
- page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):
- page/Geolocation.h:
- page/History.cpp:
(WebCore::History::History):
- page/History.h:
- page/Location.cpp:
(WebCore::Location::Location):
- page/Location.h:
- page/Navigator.cpp:
(WebCore::Navigator::Navigator):
(WebCore::Navigator::~Navigator):
- page/Navigator.h:
- page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::memory):
- page/Performance.h:
- page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::PerformanceNavigation):
- page/PerformanceNavigation.h:
- page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::PerformanceTiming):
- page/PerformanceTiming.h:
- page/Screen.cpp:
(WebCore::Screen::Screen):
- page/Screen.h:
- plugins/DOMMimeTypeArray.cpp:
(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):
- plugins/DOMMimeTypeArray.h:
- plugins/DOMPluginArray.cpp:
(WebCore::DOMPluginArray::DOMPluginArray):
- plugins/DOMPluginArray.h:
- storage/Storage.cpp:
(WebCore::Storage::Storage):
- storage/Storage.h:
Jan 6, 2012:
- 11:33 PM Changeset in webkit [104379] by
-
- 5 edits in trunk/Source/ThirdParty/ANGLE
Regenerate a few files with a more appropriate version of bison.
Rubber-stamped by Dan Bernstein.
- src/compiler/glslang.l: Tweak the input so that it generates code that compiles without warnings.
- src/compiler/glslang_lex.cpp:
- src/compiler/glslang_tab.cpp:
- src/compiler/glslang_tab.h:
- 10:57 PM Changeset in webkit [104378] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r83075): Save as PDF does not generate any links for webkit.org and others
<http://webkit.org/b/75768> <rdar://problem/10659258>
Use RenderObject::hasOutline when determining whether to always create line boxes so that
we take in to consideration whether we'll be creating PDF link rects.
Reviewed by Dan Bernstein.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- 10:57 PM Changeset in webkit [104377] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (WebKit2): Save as PDF no longer generates links to URLs
<http://webkit.org/b/65076> / <rdar://problem/9606246>
WebKit2 printing works by having the web process render the page content to a PDF. The PDF
data is then shipped to the UI process which will render it in to the printing graphics context.
Links were being lost because the API used to do the rendering of the PDF in to the printing
graphics context, CGContextDrawPDFPage, did not preserve the links that were present in the
PDF content received from the web process.
To fix this we switch to using PDFKit for drawing the PDF in to the printing graphics context.
PDFKit provides the ability for us to iterate over the links in the PDF content ourselves and
add links in to the printing graphics context.
Reviewed by Alexey Proskuryakov.
- UIProcess/API/mac/WKPrintingView.h:
- UIProcess/API/mac/WKPrintingView.mm:
(pdfAnnotationLinkClass): Look up the PDFAnnotationLink class from PDFKit as WebKit2 loads PDFKit lazily.
(pdfDocumentClass): Ditto.
(-[WKPrintingView _drawPDFDocument:page:atPoint:]): Switch to using the PDFKit equivalents of several types.
Iterate over the annotations present in the PDFPage, calling CGPDFContextSetURLForRect for each PDFAnnotationLink
that we find.
(-[WKPrintingView _drawPreview:]): Create an NSData to feed to PDFDocument.
(-[WKPrintingView drawRect:]): Ditto.
- WebKit2Prefix.h: Add the usual workaround to make Objective-C exceptions compile when C++ exception handling is disabled.
- 10:46 PM Changeset in webkit [104376] by
-
- 35 edits2 adds2 deletes in trunk
Unreviewed, rolling out r104373 and r104374.
http://trac.webkit.org/changeset/104373
http://trac.webkit.org/changeset/104374
https://bugs.webkit.org/show_bug.cgi?id=75769
Too many assertion failures. (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::~Element):
- dom/ElementRareData.h:
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):
- dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::namedItemWithIndex):
- html/HTMLAllCollection.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::detachFromNode):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):
- html/HTMLCollection.h:
- html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
- html/HTMLElement.h:
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::create):
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFormCollection.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::elements):
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::selectedOption):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):
- html/HTMLMapElement.h:
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::create):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):
- html/HTMLOptionsCollection.h:
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):
- html/HTMLPropertiesCollection.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::~HTMLSelectElement):
(WebCore::HTMLSelectElement::options):
- html/HTMLSelectElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::~HTMLTableElement):
LayoutTests:
- fast/dom/htmlcollection-protects-base-expected.txt: Removed.
- fast/dom/htmlcollection-protects-base.html: Removed.
- fast/dom/htmlcollection-zombies-expected.txt: Added.
- fast/dom/htmlcollection-zombies.html: Added.
- 8:20 PM Changeset in webkit [104375] by
-
- 2 edits in trunk/Tools
Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
- Scripts/webkitdirs.pm:
(buildChromium):
Missing parentheses.
- 7:58 PM Changeset in webkit [104374] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r104373.
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::~HTMLTableElement):
- 7:30 PM Changeset in webkit [104373] by
-
- 34 edits2 adds2 deletes in trunk
Simplify HTMLCollection ownership model.
<http://webkit.org/b/75437>
Reviewed by Sam Weinig.
Source/WebCore:
Remove HTMLCollection's inheritance from RefCounted and use OwnPtr to store it.
Added ref()/deref() methods that forward to the collection's base node, these
are only ever used by DOM wrappers.
This is a behavior change, HTMLCollection wrappers now keep the base node alive.
Test: fast/dom/htmlcollection-protects-base.html
- html/HTMLCollection.h:
(WebCore::HTMLCollection::ref):
(WebCore::HTMLCollection::deref):
Removed inheritance from RefCounted. Added ref/deref that forward the refs
to the collection's base Node.
- dom/Element.cpp:
(WebCore::Element::~Element):
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::~Document):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
- html/HTMLSelectElement.h:
- html/HTMLSelectElement.cpp:
Remove HTMLCollection::detachFromNode() and call sites.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::namedItemWithIndex):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::calcLength):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::nextItem):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollection::tags):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::calcLength):
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::getNamedItem):
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::names):
Removed base node null-checks and assertions. Added one assertion to
the HTMLCollection constructor (that m_base is non-null.)
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::cachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
- dom/ElementRareData.h:
(WebCore::ElementRareData::ensureCachedHTMLCollection):
- dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
- html/HTMLAllCollection.h:
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
- html/HTMLCollection.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::HTMLCollection):
- html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
- html/HTMLElement.h:
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::options):
- html/HTMLFormCollection.h:
- html/HTMLFormElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
- html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::create):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::create):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):
- html/HTMLMapElement.h:
- html/HTMLPropertiesCollection.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
- html/HTMLTableRowElement.h:
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::create):
(WebCore::HTMLTableRowsCollection::itemAfter):
- html/HTMLTableRowsCollection.h:
- html/HTMLTableSectionElement.h:
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::selectedOption):
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
Store cached HTMLCollections in OwnPtrs. Methods that used to return
PassRefPtr<HTMLCollection> now simply return HTMLCollection*.
Updated call sites as appropriate.
LayoutTests:
- Removed fast/dom/htmlcollection-zombies.html since it was testing bogus behavior.
- Added a test to verify that HTMLCollection protects its base node from GC.
- fast/dom/htmlcollection-protects-base-expected.txt: Added.
- fast/dom/htmlcollection-protects-base.html: Added.
- fast/dom/htmlcollection-zombies-expected.txt: Removed.
- fast/dom/htmlcollection-zombies.html: Removed.
- 7:12 PM Changeset in webkit [104372] by
-
- 5 edits in trunk/Source/WebCore
DOMWindow should be a FrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=75697
Reviewed by Alexey Proskuryakov.
DOMWindow plays exactly the role of a FrameDestructionObserver, just
with special-case code. It should just use the general-case code.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):
- page/DOMWindow.h:
- page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::clearDOMWindow):
(WebCore::Frame::setDOMWindow):
- page/Frame.h:
- 7:10 PM Changeset in webkit [104371] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759
Implement missing accessor and make setter public.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-01-06
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::searchingForNodeInPage):
- inspector/InspectorDOMAgent.h:
- 6:50 PM Changeset in webkit [104370] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] [WK2] Minibrowser leaks memory ~6-7Mb per reload
https://bugs.webkit.org/show_bug.cgi?id=75746
Reset WebGraphicsLayer::m_layerTreeTileClient of all dependent
layers from ~LayerTreeHostQt(). This replaces r103760 which
causes leaks of GraphicsLayerTextureMapper objects on UI side.
Reviewed by Noam Rosenthal.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
- 6:43 PM Changeset in webkit [104369] by
-
- 3 edits in trunk/Source/WebCore
Roll out r104362 since it broke the build.
- 6:39 PM Changeset in webkit [104368] by
-
- 9 edits1 copy2 adds in trunk/Source
[Chromium] Cull occluded tiles in tiled layers
https://bugs.webkit.org/show_bug.cgi?id=70533
Reviewed by James Robinson.
Source/WebCore:
Unit test provided, must pass all existing GPU layout tests.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::quadTransform):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCQuadCuller.cpp: Added.
(std::swap):
(WebCore::regionContainsRect):
(WebCore::CCQuadCuller::cullOccludedQuads):
- platform/graphics/chromium/cc/CCQuadCuller.h: Added.
(WebCore::CCQuadCuller::CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::optimizeQuads):
- platform/graphics/chromium/cc/CCRenderPass.h:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCQuadCullerTest.cpp: Added.
(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):
- 5:59 PM Changeset in webkit [104367] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit/win
rollout uneeded windows build fix.
- 5:56 PM Changeset in webkit [104366] by
-
- 3 edits in trunk/Source/WebCore
Move more rubberbanding code into ScrollAnimatorMac::smoothScrollWithEvent
https://bugs.webkit.org/show_bug.cgi?id=75750
Reviewed by Sam Weinig.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Move rubberbanding related code into smoothScrollWithEvent.
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
Move code here from handleWheelEvent and made the function return a boolean.
(WebCore::ScrollAnimatorMac::snapRubberBand):
Call the client.
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Ditto.
- 5:55 PM Changeset in webkit [104365] by
-
- 10 edits8 deletes in branches/chromium/963
Revert 98735 - Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property (http://crbug.com/107283)
https://bugs.webkit.org/show_bug.cgi?id=38829
Reviewed by James Robinson.
Make compositing and CSS visibility play nicely together.
The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.
With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.
Tests: compositing/visibility/visibility-composited-transforms.html
compositing/visibility/visibility-composited.html
compositing/visibility/visibility-image-layers-dynamic.html
compositing/visibility/visibility-image-layers.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.
- platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,
added ContentsVisibilityChanged flag.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.
- rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().
LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829
Test various configurations of compositing layers and visibility.
Reviewed by James Robinson.
- compositing/visibility/visibility-composited-expected.png: Added.
- compositing/visibility/visibility-composited-transforms-expected.png: Added.
- compositing/visibility/visibility-composited-transforms.html: Added.
- compositing/visibility/visibility-composited.html: Added.
- compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- compositing/visibility/visibility-image-layers-dynamic.html: Added.
- compositing/visibility/visibility-image-layers-expected.png: Added.
- compositing/visibility/visibility-image-layers.html: Added.
TBR=Simon Fraser
Review URL: http://codereview.chromium.org/9120020
- 5:40 PM Changeset in webkit [104364] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit/win
Merged r91145.
- 5:40 PM Changeset in webkit [104363] by
-
- 77 edits6 adds7 deletes in trunk/Source/ThirdParty/ANGLE
Update ANGLE in WebKit tree
https://bugs.webkit.org/show_bug.cgi?id=75753
Reviewed by Simon Fraser.
Updated ANGLE to r939. Fixed a compiler error (missing case in switch statement)
and added 5 new files to xcodeproj. Other than that it is a straight copy of
the files from the ANGLE repository.
- ANGLE.xcodeproj/project.pbxproj:
- include/EGL/eglext.h:
- include/EGL/eglplatform.h:
- include/GLES2/gl2ext.h:
- include/GLSLANG/ShaderLang.h:
- src/common/debug.cpp:
(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):
- src/common/version.h:
- src/compiler/BaseTypes.h:
(getBasicString):
- src/compiler/BuiltInFunctionEmulator.cpp: Added.
(BuiltInFunctionEmulator::BuiltInFunctionEmulator):
(BuiltInFunctionEmulator::SetFunctionCalled):
(BuiltInFunctionEmulator::OutputEmulatedFunctionDefinition):
(BuiltInFunctionEmulator::IdentifyFunction):
(BuiltInFunctionEmulator::MarkBuiltInFunctionsForEmulation):
(BuiltInFunctionEmulator::Cleanup):
(BuiltInFunctionEmulator::GetEmulatedFunctionName):
- src/compiler/BuiltInFunctionEmulator.h: Added.
- src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::detectRecursion):
(TCompiler::getMappedNameMaxLength):
(TCompiler::getBuiltInFunctionEmulator):
- src/compiler/DetectRecursion.cpp: Added.
(DetectRecursion::FunctionNode::FunctionNode):
(DetectRecursion::FunctionNode::getName):
(DetectRecursion::FunctionNode::addCallee):
(DetectRecursion::FunctionNode::detectRecursion):
(DetectRecursion::DetectRecursion):
(DetectRecursion::~DetectRecursion):
(DetectRecursion::visitAggregate):
(DetectRecursion::detectRecursion):
(DetectRecursion::findFunctionByName):
- src/compiler/DetectRecursion.h: Added.
- src/compiler/ExtensionBehavior.h:
- src/compiler/ForLoopUnroll.cpp:
(ForLoopUnroll::MarkForLoopsWithIntegerIndicesForUnrolling):
- src/compiler/ForLoopUnroll.h:
- src/compiler/Initialize.cpp:
(BuiltInFunctionsCommon):
(BuiltInFunctionsVertex):
(BuiltInFunctionsFragment):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):
- src/compiler/MapLongVariableNames.cpp:
(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapVaryingLongName):
- src/compiler/MapLongVariableNames.h:
- src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::visitUnary):
(TOutputGLSLBase::visitAggregate):
- src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorate):
(sh::OutputHLSL::decorateUniform):
- src/compiler/OutputHLSL.h:
- src/compiler/ParseHelper.cpp:
(TParseContext::recover):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):
- src/compiler/ParseHelper.h:
(TParseContext::TParseContext):
- src/compiler/PoolAlloc.h:
(pool_allocator::pool_allocator):
(pool_allocator::operator=):
(pool_allocator::setAllocator):
(pool_allocator::getAllocator):
- src/compiler/ShHandle.h:
- src/compiler/ShaderLang.cpp:
(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShGetInfo):
- src/compiler/SymbolTable.cpp:
(TType::computeDeepestStructNesting):
- src/compiler/TranslatorESSL.cpp:
(TranslatorESSL::translate):
(TranslatorESSL::writeExtensionBehavior):
- src/compiler/TranslatorGLSL.cpp:
(TranslatorGLSL::translate):
- src/compiler/Types.h:
(TType::TType):
(TType::copyType):
(TType::setStruct):
(TType::getDeepestStructNesting):
- src/compiler/UnfoldSelect.cpp:
(sh::UnfoldSelect::traverse):
(sh::UnfoldSelect::visitSelection):
(sh::UnfoldSelect::visitLoop):
(sh::UnfoldSelect::getNextTemporaryIndex):
- src/compiler/UnfoldSelect.h:
- src/compiler/ValidateLimitations.cpp:
- src/compiler/ValidateLimitations.h:
- src/compiler/VariableInfo.cpp:
(getVariableDataType):
- src/compiler/generate_glslang_lexer.sh: Removed.
- src/compiler/generate_glslang_parser.sh: Removed.
- src/compiler/generate_parser.sh: Added.
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(yy_get_previous_state):
(yy_try_NUL_trans):
- src/compiler/glslang_tab.cpp:
- src/compiler/glslang_tab.h:
- src/compiler/intermOut.cpp:
(TOutputTraverser::visitAggregate):
- src/compiler/intermediate.h:
(TIntermUnary::TIntermUnary):
(TIntermUnary::setUseEmulatedFunction):
(TIntermUnary::getUseEmulatedFunction):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setUseEmulatedFunction):
(TIntermAggregate::getUseEmulatedFunction):
- src/compiler/osinclude.h:
- src/compiler/ossource_posix.cpp:
(OS_AllocTLSIndex):
(OS_SetTLSValue):
(OS_FreeTLSIndex):
- src/compiler/preprocessor/atom.c:
(GrowAtomTable):
- src/compiler/preprocessor/length_limits.h: Added.
- src/compiler/preprocessor/scanner.h:
- src/libEGL/Display.cpp:
(egl::Display::getDisplay):
(egl::Display::Display):
(egl::Display::~Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::startScene):
(egl::Display::endScene):
(egl::Display::createDevice):
(egl::Display::initializeDevice):
(egl::Display::resetDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::restoreLostDevice):
(egl::Display::notifyDeviceLost):
(egl::Display::isDeviceLost):
(egl::Display::testDeviceLost):
(egl::Display::testDeviceResettable):
(egl::Display::getDXT1TextureSupport):
(egl::Display::getDXT3TextureSupport):
(egl::Display::getDXT5TextureSupport):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getTexturePool):
(egl::Display::initExtensionString):
- src/libEGL/Display.h:
- src/libEGL/Surface.cpp:
(egl::Surface::Surface):
(egl::Surface::initialize):
(egl::Surface::resetSwapChain):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
(egl::Surface::isPostSubBufferSupported):
- src/libEGL/Surface.h:
- src/libEGL/libEGL.cpp:
- src/libEGL/libEGL.rc:
- src/libEGL/libEGL.vcproj:
- src/libGLESv2/Buffer.cpp:
(gl::Buffer::bufferSubData):
- src/libGLESv2/Context.cpp:
(gl::Context::Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::markContextLost):
(gl::Context::isContextLost):
(gl::Context::setPackReverseRowOrder):
(gl::Context::getPackReverseRowOrder):
(gl::Context::deleteProgram):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::useProgram):
(gl::Context::setFramebufferZero):
(gl::Context::getCurrentProgram):
(gl::Context::getBooleanv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawClosingLine):
(gl::Context::getResetStatus):
(gl::Context::isResetNotificationEnabled):
(gl::Context::supportsDXT1Textures):
(gl::Context::supportsDXT3Textures):
(gl::Context::supportsDXT5Textures):
(gl::Context::supportsFloat32Textures):
(gl::Context::supportsFloat32LinearFilter):
(gl::Context::supportsFloat32RenderableTextures):
(gl::Context::supportsFloat16Textures):
(gl::Context::supportsFloat16LinearFilter):
(gl::Context::supportsFloat16RenderableTextures):
(gl::Context::initExtensionString):
(gl::Context::initRendererString):
(gl::Context::getRendererString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):
- src/libGLESv2/Context.h:
- src/libGLESv2/Fence.cpp:
(gl::Fence::testFence):
(gl::Fence::getFenceiv):
- src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):
- src/libGLESv2/Framebuffer.h:
- src/libGLESv2/IndexDataManager.cpp:
(gl::IndexDataManager::prepareIndexData):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::getSerial):
(gl::IndexBuffer::issueSerial):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):
- src/libGLESv2/IndexDataManager.h:
(gl::StaticIndexBuffer::IndexRange::operator<):
- src/libGLESv2/Program.cpp:
(gl::Uniform::Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::Program::Program):
(gl::Program::detachShader):
(gl::Program::getUsedSamplerRange):
(gl::Program::getSamplerMapping):
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::transposeMatrix):
(gl::Program::setUniformMatrix2fv):
(gl::Program::setUniformMatrix3fv):
(gl::Program::setUniformMatrix4fv):
(gl::Program::getUniformfv):
(gl::Program::getUniformiv):
(gl::Program::applyUniforms):
(gl::Program::compileToBinary):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::decorateAttribute):
(gl::Program::undecorateUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniformnfv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::applyUniformniv):
(gl::Program::appendToInfoLogSanitized):
(gl::Program::unlink):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validateSamplers):
(gl::Program::initializeConstantHandles):
(gl::Program::getDxCoordLocation):
- src/libGLESv2/Program.h:
- src/libGLESv2/Renderbuffer.cpp:
(gl::RenderbufferInterface::RenderbufferInterface):
(gl::RenderbufferInterface::getRedSize):
(gl::RenderbufferInterface::getGreenSize):
(gl::RenderbufferInterface::getBlueSize):
(gl::RenderbufferInterface::getAlphaSize):
(gl::RenderbufferInterface::getDepthSize):
(gl::RenderbufferInterface::getStencilSize):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::getRenderTarget):
(gl::RenderbufferTexture::getDepthStencil):
(gl::RenderbufferTexture::getWidth):
(gl::RenderbufferTexture::getHeight):
(gl::RenderbufferTexture::getInternalFormat):
(gl::RenderbufferTexture::getD3DFormat):
(gl::RenderbufferTexture::getSamples):
(gl::RenderbufferTexture::getSerial):
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::issueCubeSerials):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::Depthbuffer::Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):
- src/libGLESv2/Renderbuffer.h:
(gl::RenderbufferInterface::~RenderbufferInterface):
- src/libGLESv2/Shader.cpp:
(gl::Shader::getTranslatedSourceLength):
(gl::Shader::getSourceImpl):
(gl::Shader::getSource):
(gl::Shader::getTranslatedSource):
- src/libGLESv2/Shader.h:
- src/libGLESv2/Texture.cpp:
(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::Image::Image):
(gl::Image::~Image):
(gl::Image::redefine):
(gl::Image::createSurface):
(gl::Image::lock):
(gl::Image::unlock):
(gl::Image::isRenderableFormat):
(gl::Image::getD3DFormat):
(gl::Image::getSurface):
(gl::Image::setManagedSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::FlipCopyDXT1BlockFull):
(gl::FlipCopyDXT1BlockHalf):
(gl::FlipCopyDXT3BlockFull):
(gl::FlipCopyDXT3BlockHalf):
(gl::FlipCopyDXT5BlockFull):
(gl::FlipCopyDXT5BlockHalf):
(gl::Image::loadDXT1Data):
(gl::Image::loadDXT3Data):
(gl::Image::loadDXT5Data):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::~TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::isManaged):
(gl::TextureStorage::getPool):
(gl::TextureStorage::getTextureSerial):
(gl::TextureStorage::issueTextureSerial):
(gl::Texture::Texture):
(gl::Texture::~Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::setUsage):
(gl::Texture::getMinFilter):
(gl::Texture::getMagFilter):
(gl::Texture::getWrapS):
(gl::Texture::getWrapT):
(gl::Texture::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::getTexture):
(gl::Texture::hasDirtyParameters):
(gl::Texture::hasDirtyImages):
(gl::Texture::resetDirty):
(gl::Texture::getTextureSerial):
(gl::Texture::getRenderTargetSerial):
(gl::Texture::isImmutable):
(gl::Texture::creationLevels):
(gl::Texture::getBlitter):
(gl::Texture::copyToRenderTarget):
(gl::TextureStorage2D::TextureStorage2D):
(gl::TextureStorage2D::~TextureStorage2D):
(gl::TextureStorage2D::getSurfaceLevel):
(gl::TextureStorage2D::getBaseTexture):
(gl::TextureStorage2D::getRenderTargetSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getType):
(gl::Texture2D::redefineImage):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isMipmapComplete):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getStorage):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureStorageCubeMap::~TextureStorageCubeMap):
(gl::TextureStorageCubeMap::getCubeMapSurface):
(gl::TextureStorageCubeMap::getBaseTexture):
(gl::TextureStorageCubeMap::getRenderTargetSerial):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getType):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCubeComplete):
(gl::TextureCubeMap::isMipmapCubeComplete):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::redefineImage):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
(gl::TextureCubeMap::getStorage):
- src/libGLESv2/Texture.h:
(gl::Image::markDirty):
(gl::Image::markClean):
(gl::Image::getWidth):
(gl::Image::getHeight):
(gl::Image::getFormat):
(gl::Image::getType):
(gl::Image::isDirty):
- src/libGLESv2/VertexDataManager.cpp:
(gl::elementsInBuffer):
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::getSerial):
(gl::VertexBuffer::issueSerial):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):
- src/libGLESv2/VertexDataManager.h:
(gl::ArrayVertexBuffer::size):
- src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
- src/libGLESv2/geometry/IndexDataManager.h: Removed.
- src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
- src/libGLESv2/geometry/VertexDataManager.h: Removed.
- src/libGLESv2/geometry/vertexconversion.h: Removed.
- src/libGLESv2/libGLESv2.cpp:
(validateSubImageParams):
(validReadFormatType):
(Extension::glBindTexImage):
- src/libGLESv2/libGLESv2.def:
- src/libGLESv2/libGLESv2.rc:
- src/libGLESv2/libGLESv2.vcproj:
- src/libGLESv2/main.cpp:
(gl::getNonLostContext):
(gl::checkDeviceLost):
- src/libGLESv2/main.h:
- src/libGLESv2/utilities.cpp:
(gl::UniformExternalComponentCount):
(gl::UniformInternalComponentCount):
(gl::UniformComponentSize):
(gl::UniformInternalSize):
(gl::UniformExternalSize):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::ExtractFormat):
(gl::ExtractType):
(dx2es::IsFloat32Format):
(dx2es::IsFloat16Format):
- src/libGLESv2/utilities.h:
(isDeviceLostError):
- 5:23 PM Changeset in webkit [104362] by
-
- 3 edits in trunk/Source/WebCore
Use HashMap<OwnPtr> in SVGAttributeToPropertyMap
https://bugs.webkit.org/show_bug.cgi?id=75734
Reviewed by Daniel Bates.
- svg/properties/SVGAttributeToPropertyMap.cpp:
(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::addProperty): use HashMap::add() to avoid an
extra hash lookup to set a new PropertiesVector.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):
- svg/properties/SVGAttributeToPropertyMap.h:
- 5:22 PM Changeset in webkit [104361] by
-
- 112 edits4 copies13 moves97 adds83 deletes in trunk/LayoutTests
Unreviewed: more rebaselines in chromium after r104240.
- platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Removed.
- platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png: Removed.
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-text-click-inside-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug24200-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4382-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug59354-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug99948-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
- platform/chromium-cg-mac/editing/selection/3690703-2-expected.png: Removed.
- platform/chromium-cg-mac/editing/selection/3690703-expected.png: Removed.
- platform/chromium-cg-mac/editing/selection/3690719-expected.png: Removed.
- platform/chromium-cg-mac/editing/selection/4975120-expected.png: Removed.
- platform/chromium-cg-mac/fast/block/margin-collapse/103-expected.png: Removed.
- platform/chromium-cg-mac/fast/dom/isindex-001-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/input-appearance-focus-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
- platform/chromium-cg-mac/fast/forms/minWidthPercent-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
- platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-leopard/fast/css/line-height-expected.png:
- platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
- platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
- platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
- platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
- platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/line-height-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/minWidthPercent-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png.
- platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/4806874-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png: Removed.
- platform/chromium-mac/editing/selection/3690703-2-expected.png: Removed.
- platform/chromium-mac/editing/selection/3690703-expected.png: Removed.
- platform/chromium-mac/editing/selection/3690719-expected.png: Removed.
- platform/chromium-mac/editing/selection/4895428-3-expected.png: Removed.
- platform/chromium-mac/editing/selection/4975120-expected.png: Removed.
- platform/chromium-mac/editing/selection/drag-select-1-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png: Removed.
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Removed.
- platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
- platform/chromium-mac/fast/css/line-height-expected.png: Removed.
- platform/chromium-mac/fast/dom/isindex-001-expected.png: Removed.
- platform/chromium-mac/fast/dom/isindex-002-expected.png: Removed.
- platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-mac/fast/events/context-no-deselect-expected.png: Removed.
- platform/chromium-mac/fast/forms/encoding-test-expected.png: Removed.
- platform/chromium-mac/fast/forms/fieldset-align-expected.png: Removed.
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Removed.
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-baseline-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-spaces-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-table-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png: Removed.
- platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Removed.
- platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Removed.
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png: Removed.
- platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png: Removed.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium/fast/block/float/032-expected.png: Added.
- platform/chromium/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/input-appearance-height-expected.txt.
- platform/chromium/fast/forms/input-width-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png.
- platform/chromium/fast/forms/minWidthPercent-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png.
- platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/fieldset-align-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/input-table-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/placeholder-position-expected.txt: Removed.
- platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt: Renamed from LayoutTests/editing/input/caret-at-the-edge-of-input-expected.txt.
- 5:02 PM Changeset in webkit [104360] by
-
- 2 edits in trunk/Tools
Fix DRT build on case-sensitive file systems.
Fix case of include of WebDynamicScrollBarsView.h
- DumpRenderTree/mac/DumpRenderTree.mm:
- 4:54 PM Changeset in webkit [104359] by
-
- 3 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.
- runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added missing symbols which were hidden by JS_EXPORTCLASS.
- 4:53 PM Changeset in webkit [104358] by
-
- 13 edits7 adds in trunk
Source/WebCore: WebCore implementation of the Intent object
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
for draft spec.
https://bugs.webkit.org/show_bug.cgi?id=73051
Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.
Test: web-intents/web-intents-api.html
- WebCore.gypi:
- page/DOMWindow.idl:
- Modules/intents/Intent.cpp: Added.
(WebCore::Intent::Intent):
(WebCore::Intent::action):
(WebCore::Intent::setAction):
(WebCore::Intent::type):
(WebCore::Intent::setType):
(WebCore::Intent::data):
(WebCore::Intent::setData):
(WebCore::Intent::create):
- Modules/intents/Intent.h: Added.
- Modules/intents/Intent.idl: Added.
Source/WebKit/chromium: [Web Intents] Flagged-off WebCore implementation of navigator.startActivity
https://bugs.webkit.org/show_bug.cgi?id=73051
Patch by Greg Billock <gbillock@google.com> on 2012-01-06
Reviewed by Adam Barth.
- features.gypi:
- 4:49 PM Changeset in webkit [104357] by
-
- 4 edits in branches/subpixellayout
Fix overflow in SpatialNavigation::distanceDataForNode.
- 4:29 PM Changeset in webkit [104356] by
-
- 5 edits3 adds in trunk
[cg] userSpaceOnUse SVG Patterns have the wrong origin
https://bugs.webkit.org/show_bug.cgi?id=75741
<rdar://problem/9383222>
Reviewed by Simon Fraser.
The transformation from pattern space to user space should use the userToBase CTM,
not the current CTM.
Test: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::getCTM):
- platform/graphics/cg/TransformationMatrixCG.cpp:
(WebCore::AffineTransform::AffineTransform): Add a AffineTransform(CGAffineTransform) constructor
- platform/graphics/transforms/AffineTransform.h:
Add a test that ensures that userSpaceOnUse patterns are rendered in the
correct orientation and location in both the accelerated compositing and
regular cases, as well as with SVG translation.
- platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
- svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml: Added.
- 4:27 PM Changeset in webkit [104355] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
https://bugs.webkit.org/show_bug.cgi?id=75757
Reviewed by Gavin Barraclough.
- runtime/JSArray.cpp:
(JSC::JSArray::pop): Changed map->end() to map->notFound().
- 4:14 PM Changeset in webkit [104354] by
-
- 10 edits in trunk/LayoutTests
[chromium] Rebaseline media/media-document-audio-repaint after 74123 goes in.
https://bugs.webkit.org/show_bug.cgi?id=75505
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Dimitri Glazkov.
- platform/chromium-cg-mac-leopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-cg-mac-snowleopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium/test_expectations.txt:
- 3:41 PM Changeset in webkit [104353] by
-
- 3 edits in trunk/LayoutTests
LayoutTests/platform/chromium/fast/events/intercept-postmessage.html failing
https://bugs.webkit.org/show_bug.cgi?id=75718
Patch by Charlie Reis <creis@chromium.org> on 2012-01-06
Reviewed by Adam Barth.
Removing unnecessary log messages.
- platform/chromium/fast/events/intercept-postmessage-expected.txt:
- platform/chromium/fast/events/intercept-postmessage.html:
- 3:39 PM Changeset in webkit [104352] by
-
- 3 edits2 adds in trunk
Avoid falling into tiled layers more often when the device scale factor is > 1
<rdar://problem/10588725>
Source/WebCore:
Reviewed by John Sullivan.
Stop taking the device scale factor into account when deciding to make
tiled layers.
Test: compositing/tiled-layers-hidpi.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer):
LayoutTests:
Reviewed by John Sullivan.
Tests that a large layer with a device scale factor of 2 is not tiled.
- compositing/tiled-layers-hidpi-expected.txt: Added.
- compositing/tiled-layers-hidpi.html: Added.
- 3:34 PM Changeset in webkit [104351] by
-
- 6 edits in trunk/Tools
Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=75662
Reviewed by Dan Bernstein.
The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
of color profile issues. Fix by keeping everything in device RGB and ensuring that the
test window uses the main display's color space, so that the pixel values in the bitmap
that gets checksummed are identical to the CSS colors.
Removed the code that switches the display profile in DRT, since that is no longer required.
- DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
- DumpRenderTree/mac/DumpRenderTree.mm:
(crashHandler): Remove code that switches display profiles.
(prepareConsistentTestingEnvironment): Ditto.
(dumpRenderTree): Ditto.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
(createBitmapContext): Use DeviceRGB for the bitmap colorspace.
(createBitmapContextFromWebView): Add comment about the colorspace handling.
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage): Use a RetainPtr, add comment.
(WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
(WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
- 3:28 PM Changeset in webkit [104350] by
-
- 4 edits in trunk/Source/WebCore
Touch a bunch of files in an attempt to fix Mac release builds.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
- accessibility/AccessibilityAllInOne.cpp:
- editing/visible_units.cpp:
(WebCore::previousBoundary):
- 3:20 PM Changeset in webkit [104349] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
JIT stub slow paths that would be identical to that of an interpreter should be factored out
https://bugs.webkit.org/show_bug.cgi?id=75743
<rdar://problem/10657024>
Reviewed by Geoff Garen.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/CommonSlowPaths.h: Added.
(JSC::CommonSlowPaths::opInstanceOfSlow):
(JSC::CommonSlowPaths::opIn):
(JSC::CommonSlowPaths::opResolve):
(JSC::CommonSlowPaths::opResolveSkip):
(JSC::CommonSlowPaths::opResolveWithBase):
(JSC::CommonSlowPaths::opResolveWithThis):
- 3:16 PM Changeset in webkit [104348] by
-
- 21 edits in branches/subpixellayout
Fix scrollbar toggling to compare pixel snapped values and update relevant test expectations.
- 3:13 PM Changeset in webkit [104347] by
-
- 4 edits in trunk/Source/WebCore
Enable a compositing trigger for filters
https://bugs.webkit.org/show_bug.cgi?id=75658
This will enable forcing the compositing code path when filters exist for a RenderObject.
Reviewed by Simon Fraser.
No new functionality so no new tests.
- page/ChromeClient.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
- rendering/RenderLayerCompositor.h:
- 3:01 PM Changeset in webkit [104346] by
-
- 3 edits in trunk/LayoutTests
Rebaseline editing/input/caret-at-the-edge-of-input.html.
- platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- 2:58 PM Changeset in webkit [104345] by
-
- 4 edits in trunk/Source/WebCore
Add and use ScrollElasticityControllerClient::absoluteScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=75744
Reviewed by Dan Bernstein.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::absoluteScrollPosition):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
- platform/mac/ScrollElasticityController.h:
- 2:54 PM Changeset in webkit [104344] by
-
- 11 edits2 adds in trunk/Source/WebCore
Move FrameDestructionObserver to its own file
https://bugs.webkit.org/show_bug.cgi?id=75693
Reviewed by Eric Seidel.
We should have one class per file, on general principles. Also, this
make it possible to use this class in DOMWindow without introducing a
circular include dependency.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- page/Frame.cpp:
- page/Frame.h:
- page/FrameDestructionObserver.cpp: Added.
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):
- page/FrameDestructionObserver.h: Added.
(WebCore::FrameDestructionObserver::frame):
- plugins/DOMMimeType.h:
- plugins/DOMPlugin.h:
- 2:46 PM Changeset in webkit [104343] by
-
- 2 edits in trunk/Tools
run-api-tests: specify individual suites and tests on the command-line
Reviewed by Adam Roben.
Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
The run-api-tests script will now accept a list of arguments on
the command-line that are used as prefix filters. To run all
tests in a suite that starts with "WTF" (WTF and WTF_Vector)
use:
$ run-api-tests WTF
To run only the tests in the "WTF" suite, not the "WTF_Vector"
suite, use:
$ run-api-tests WTF.
- Scripts/run-api-tests: Filter tests if any prefix arguments
are passed on the command-line.
- 2:46 PM Changeset in webkit [104342] by
-
- 2 edits in trunk/Tools
run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
Reviewed by Adam Roben.
Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
- Scripts/run-api-tests:
(dumpTestsBySuite): Update to accept array of tests instead of
hash data structure.
(runTestsBySuite): Ditto.
(listAllTests): Rename from populateTests(). Update to return
an array of tests instad of the hash data structure.
- 2:27 PM Changeset in webkit [104341] by
-
- 2 edits in trunk/Source/WebCore
Fix Snow Leopard build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollBy):
Move the function definition inside #if ENABLE(RUBBER_BANDING).
- 2:27 PM Changeset in webkit [104340] by
-
- 10 edits1 add in trunk/Tools
webkitpy: clean up test/uri conversion routines
https://bugs.webkit.org/show_bug.cgi?id=75648
Reviewed by Eric Seidel.
This change moves test_to_uri and uri_to_test from the Port
class to the Driver class (the routines were only being
called by the drivers), and removes a bunch of stale and/or
busted logic.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/driver.py:
(is_http_test):
(test_to_uri):
(uri_to_test):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(run_one_test):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.input_line):
(input_line):
(expected_output):
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
(_command_from_driver_input):
- 2:22 PM Changeset in webkit [104339] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix windows build.
- wtf/TypeTraits.cpp:
- 2:15 PM Changeset in webkit [104338] by
-
- 3 edits in trunk/Source/JavaScriptCore
Default HashTraits for Opcode don't work for Opcode = 0
https://bugs.webkit.org/show_bug.cgi?id=75595
Reviewed by Oliver Hunt.
Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
- interpreter/Interpreter.h:
(JSC::Interpreter::getOpcodeID):
- 2:14 PM Changeset in webkit [104337] by
-
- 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r104330.
- 2:13 PM Changeset in webkit [104336] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: filed https://bugs.webkit.org/show_bug.cgi?id=75742
and updated chromium-mac expectations for fast/forms/input-disabled-color.html.
- platform/chromium/test_expectations.txt:
- 2:08 PM Changeset in webkit [104335] by
-
- 2 edits in trunk/Source/ThirdParty
Make JavaScriptCore.framework a reference and put it in a Frameworks group
https://bugs.webkit.org/show_bug.cgi?id=75740
Reviewed by Mark Rowe.
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
- 2:01 PM Changeset in webkit [104334] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Thread verifier assertions when printing
https://bugs.webkit.org/show_bug.cgi?id=75738
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView dealloc]): Dealloc in main thread, so that WebFrameProxy doesn't get deref'ed from a secondary one. (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): This method calls out to client, which only expects that on main thread. (-[WKPrintingView knowsPageRange:]): Call _adjustPrintingMarginsForHeaderAndFooter on main thread.
- 1:57 PM Changeset in webkit [104333] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add a DecayArray type trait as a first step towards merging OwnPtr and OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=75737
Reviewed by Anders Carlsson.
- wtf/TypeTraits.cpp:
- wtf/TypeTraits.h:
Added a DecayArray trait, that can convert T[] and T[3] -> T*. DecayArray
is composed of some helpers which are also exposed, Conditional<>, which
can provide one type or another based on a boolean predicate, IsArray<>
which can deduce array types, and RemoveExtent<>, which removes the extent
from an array type.
- 1:55 PM Changeset in webkit [104332] by
-
- 3 edits1 add in trunk
Clicking on the cancel button on readonly and disabled search fields darkens as if the search field was editable
https://bugs.webkit.org/show_bug.cgi?id=69886
<rdar://problem/10070187>
Reviewed by Adele Peterson.
.:
- ManualTests/search-cancel-button.html: Added.
Source/WebCore:
Tests: ManualTests/search-cancel-button.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton): If the input is readonly and/or disabled, force the cell to
render without highlight.
- 1:44 PM Changeset in webkit [104331] by
-
- 8 edits in trunk
Mitigate scrollbar differences when running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=67217
Source/WebCore:
Reviewed by Dan Bernstein.
Export WebCore::Settings::mockScrollbarsEnabled() for DRT.
- WebCore.exp.in:
Source/WebKit/mac:
Reviewed by Dan Bernstein.
Make it possible to register a custom NSScroller class, which
the WebDynamicScrollBarsView will use when mock scrollbars are enabled.
Also ensure that the WebPreferences mock scrollbars preference is
migrated into Settings.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(+[WebDynamicScrollBarsView _horizontalScrollerClass]):
(+[WebDynamicScrollBarsView _verticalScrollerClass]):
(+[WebDynamicScrollBarsView setCustomScrollerClass:]):
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
Reviewed by Dan Bernstein.
Add an NSScroller subclass that draws mock scrollbars identically
to the WebCore mock scrollbar theme, and register it with the
WebDynamicScrollbarsView.
- DumpRenderTree/mac/DumpRenderTree.mm:
(-[DRTMockScroller rectForPart:]):
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
(registerMockScrollbars):
(prepareConsistentTestingEnvironment):
- 1:19 PM Changeset in webkit [104330] by
-
- 3 edits in trunk/Source/JavaScriptCore
GetByteArrayLength is incorrect
https://bugs.webkit.org/show_bug.cgi?id=75735
Reviewed by Filip Pizlo.
Load the byte array length from the correct location.
This stops an existing test from hanging.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:18 PM Changeset in webkit [104329] by
-
- 22 edits10 adds in trunk
Source/WebCore: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242
Reviewed by David Levin.
Tests: http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html
http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html
http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html
http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html
- page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::policy):
(WebCore::ContentSecurityPolicy::headerType):
- workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
- workers/DedicatedWorkerContext.h:
(WebCore::DedicatedWorkerContext::create):
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):
- workers/DedicatedWorkerThread.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::SharedWorkerContext):
- workers/SharedWorkerContext.h:
(WebCore::SharedWorkerContext::create):
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):
- workers/SharedWorkerThread.h:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
Source/WebKit/chromium: Pass Content-security-policy directive to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242
Reviewed by David Levin.
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
LayoutTests: Pass Content-Security-Policy directives to worker threads.
https://bugs.webkit.org/show_bug.cgi?id=73242
Reviewed by David Levin.
- http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Added.
(onconnect):
- http/tests/security/contentSecurityPolicy/resources/worker-make-xhr.js: Added.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html: Added.
- platform/chromium/test_expectations.txt:
- 1:15 PM Changeset in webkit [104328] by
-
- 4 edits6 adds in trunk
[CSSRegions]Crash while collecting svg elements in render flow thread.
https://bugs.webkit.org/show_bug.cgi?id=73735
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/svg-doc-fragment-not-collected-expected.html
fast/regions/svg-doc-fragment-not-collected.html
fast/regions/svg-element-not-collected-expected.html
fast/regions/svg-element-not-collected.html
fast/regions/svg-root-element-collected.html
By allowing only svg root elements to be collected in a render flow thread,
the svg render tree is properly constructed, thus prevented a possible further crash.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
LayoutTests:
- fast/regions/resources/region-style.css:
- fast/regions/svg-doc-fragment-not-collected-expected.html: Added.
- fast/regions/svg-doc-fragment-not-collected.html: Added.
- fast/regions/svg-element-not-collected-expected.html: Added.
- fast/regions/svg-element-not-collected.html: Added.
- fast/regions/svg-root-element-collected-expected.txt: Added.
- fast/regions/svg-root-element-collected.html: Added.
- 1:12 PM Changeset in webkit [104327] by
-
- 9 edits2 adds in trunk
Make TextTrackCue more mutable
https://bugs.webkit.org/show_bug.cgi?id=72555
Reviewed by Anders Carlsson.
Source/WebCore:
Test: media/track/track-cue-mutable.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"
flag is set
(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have
been added, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have
been removed, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):
- html/TextTrack.cpp:
(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its
position in the interval tree is based on start and end times.
(WebCore::TextTrack::cueDidChange): Add the cue to the media element.
- html/TextTrack.h:
- html/TextTrackCue.cpp:
(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.
- html/TextTrackCue.h:
(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):
- html/TextTrackCue.idl:
LayoutTests:
- media/track/track-cue-mutable-expected.txt: Added.
- media/track/track-cue-mutable.html: Added.
- 12:44 PM Changeset in webkit [104326] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:44 PM Changeset in webkit [104325] by
-
- 23 edits in branches/subpixellayout/LayoutTests/platform/mac/tables
Update mac test expectations for table tests
- 12:38 PM Changeset in webkit [104324] by
-
- 4 edits in trunk/Source
DFG no longer optimises CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=75729
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.
- runtime/JSByteArray.cpp:
Source/WebCore:
Remove the custom ClassInfo for CanvasPixelArray as that is
defeating ByteArray optimisation, and is no longer needed
anyway as it was only there to change the visible name.
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- 12:31 PM Changeset in webkit [104323] by
-
- 2 edits in trunk/Source/WTF
[Mac] Sort the resources of WTF.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75639
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.
- WTF.xcodeproj/project.pbxproj:
- 12:30 PM Changeset in webkit [104322] by
-
- 3 edits2 adds in trunk
ASSERT failure due to combine-text with preceding spaces
https://bugs.webkit.org/show_bug.cgi?id=65147
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.
Source/WebCore:
A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.
This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
LayoutTests:
New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.
- fast/text/international/spaces-combined-in-vertical-text.html: Added
- fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added
- 12:25 PM Changeset in webkit [104321] by
-
- 4 edits in trunk/Source/WebCore
Make ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController in more places
https://bugs.webkit.org/show_bug.cgi?id=75726
Reviewed by Sam Weinig.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::canScrollHorizontally):
(WebCore::ScrollAnimatorMac::canScrollVertically):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
- platform/mac/ScrollElasticityController.h:
- 12:22 PM Changeset in webkit [104320] by
-
- 2 edits in trunk/Source/WebCore
WebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=75675
Reviewed by Oliver Hunt.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse):
- 12:21 PM Changeset in webkit [104319] by
-
- 2 edits in trunk/Source/WebKit2
Need to allow SCNetworkReachability service in sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=75724
<rdar://problem/10652415>
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb:
- 12:20 PM Changeset in webkit [104318] by
-
- 4 edits in trunk/Source/JavaScriptCore
Use HashMap<OwnPtr> for SourceProviderCache items
https://bugs.webkit.org/show_bug.cgi?id=75346
Reviewed by Daniel Bates.
- parser/Parser.cpp:
- parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
- 12:15 PM Changeset in webkit [104317] by
-
- 3 edits2 adds in trunk
Crash with range selection across different documents.
https://bugs.webkit.org/show_bug.cgi?id=74285
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/Range/range-selection-across-documents-crash.html
- page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):
LayoutTests:
- fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
- fast/dom/Range/range-selection-across-documents-crash.html: Added.
- 12:12 PM Changeset in webkit [104316] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; fixing expectation error.
- platform/chromium/test_expectations.txt:
- 12:09 PM Changeset in webkit [104315] by
-
- 11 edits3 deletes in trunk/Source
Remove unused OwnFastMallocPtr class.
https://bugs.webkit.org/show_bug.cgi?id=75722
Reviewed by Geoffrey Garen.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/OwnFastMallocPtr.h: Removed.
- wtf/text/StringImpl.h:
- wtf/wtf.pro:
../JavaScriptGlue:
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
../WebCore:
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- 12:07 PM Changeset in webkit [104314] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
Convert overflow-in-uniform-regions to a reftest
https://bugs.webkit.org/show_bug.cgi?id=74765
Replaced the bitmap version of the test with a "reftest" version. Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.
Patch by Hans Muller <hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.
- fast/regions/overflow-in-uniform-regions-expected.html: Added.
- fast/regions/overflow-in-uniform-regions.html:
- platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
- platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
- platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
- platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
- 12:05 PM Changeset in webkit [104313] by
-
- 3 edits2 adds in trunk
Need to relayout when stretching the height of a flex item
https://bugs.webkit.org/show_bug.cgi?id=75661
Reviewed by Ojan Vafai.
Source/WebCore:
Test: css3/flexbox/flex-align-stretch.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.
LayoutTests:
- css3/flexbox/flex-align-stretch-expected.txt: Added.
- css3/flexbox/flex-align-stretch.html: Added.
- 12:01 PM Changeset in webkit [104312] by
-
- 4 edits in trunk/Source/WebCore
Add ScrollElasticityControllerClient::immediateScrollBy
https://bugs.webkit.org/show_bug.cgi?id=75720
Reviewed by Andreas Kling.
Add a new ScrollElasticityControllerClient::immediateScrollBy client member function.
Also, make ScrollAnimatorMac::smoothScrollWithEvent calls go through the ScrollElasticityController
in preparation for moving that function to ScrollElasticityController.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
- platform/mac/ScrollElasticityController.h:
- 12:00 PM Changeset in webkit [104311] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Sort the resources of WebKit2.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75636
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.
- WebKit2.xcodeproj/project.pbxproj:
- 11:53 AM Changeset in webkit [104310] by
-
- 2 edits2 copies in branches/chromium/963
Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596
Reviewed by Tony Chang.
Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004
- storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.
- storage/IDBCursorBackendImpl.h:
LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596
Reviewed by Tony Chang.
- storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
- storage/indexeddb/prefetch-bugfix-108071.html: Added.
TBR=dgrogan@chromium.org
Review URL: http://codereview.chromium.org/9121008
- 11:52 AM Changeset in webkit [104309] by
-
- 51 edits3 copies82 adds in trunk/LayoutTests
2012-01-06 Dmitry Lomov <dslomov@google.com>
Unreviewed: [Chromium] rebaselining IMAGE expectations after http://trac.webkit.org/changeset/104240/
- platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
- platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
- platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
- platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
- platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
- platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
- platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
- platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.
- 11:51 AM Changeset in webkit [104308] by
-
- 2 edits in trunk/Source/WebCore
Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
https://bugs.webkit.org/show_bug.cgi?id=75334
Patch by Wei James <james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo):
- 11:47 AM Changeset in webkit [104307] by
-
- 2 edits in trunk/Source/WebKit
[Mac] Sort the resources of WebKit.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75634
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.
- WebKit.xcodeproj/project.pbxproj:
- 11:38 AM Changeset in webkit [104306] by
-
- 4 edits in trunk
Fullscreen video controller can't be dragged the first time I enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=75709
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; updated video-controls-drag.html.
When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):
LayoutTests:
Update the test to cover the case where the controls do not yet exist when entering
fullscreen.
- fullscreen/video-controls-drag.html:
- 11:30 AM Changeset in webkit [104305] by
-
- 2 edits in trunk/LayoutTests
Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.
Unreviewed.
- platform/mac/test_expectations.txt:
- 11:21 AM Changeset in webkit [104304] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
https://bugs.webkit.org/show_bug.cgi?id=75631
Patch by Benjamin Poulain <bpoulain@webkit.org> on 2012-01-06
Reviewed by Andreas Kling.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:13 AM Changeset in webkit [104303] by
-
- 3 edits2 adds in trunk
Media Element: scrubbing in full-screen mode breaks playback.
https://bugs.webkit.org/show_bug.cgi?id=75650
Reviewed by John Sullivan.
Source/WebCore:
Test: fullscreen/video-controls-timeline.html
Only begin scrubbing if the panel itself is the mousedown event target.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::defaultEventHandler):
LayoutTests:
- fullscreen/video-controls-timeline-expected.txt: Added.
- fullscreen/video-controls-timeline.html: Added.
- 11:03 AM Changeset in webkit [104302] by
-
- 2 edits in trunk/LayoutTests
Add new (failing) test to Chromium test_expectations. Fix tracked by
https://bugs.webkit.org/show_bug.cgi?id=75716
Unreviewed; test expectations update.
- platform/chromium/test_expectations.txt:
- 10:28 AM Changeset in webkit [104301] by
-
- 4 edits2 adds in trunk
REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
https://bugs.webkit.org/show_bug.cgi?id=75200
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/video-controls-drag.html
The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp. Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.
- css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
LayoutTests:
- fullscreen/video-controls-drag-expected.txt: Added.
- fullscreen/video-controls-drag.html: Added.
- 10:06 AM Changeset in webkit [104300] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
from test_expectations (no longer crashing).
Unreviewed; test expectations update.
- platform/chromium/test_expectations.txt:
- 9:50 AM Changeset in webkit [104299] by
-
- 54 edits45 copies47 adds in trunk
Tools: Update DRT on Mac to draw resize handles on text areas.
Reviewed by John Sullivan.
Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.
Reviewed by John Sullivan.
Moved from mac to mac-snowleopard:
- platform/mac-snowleopard/fast/forms/001
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
- platform/mac-snowleopard/fast/forms/basic-buttons-expected
- platform/mac-snowleopard/fast/forms/basic-inputs-expected
- platform/mac-snowleopard/fast/forms/basic-selects-expected
- platform/mac-snowleopard/fast/forms/basic-textareas-expected
- platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
- platform/mac-snowleopard/fast/forms/box-shadow-override
- platform/mac-snowleopard/fast/forms/button-align
- platform/mac-snowleopard/fast/forms/button-generated-content
- platform/mac-snowleopard/fast/forms/button-sizes
- platform/mac-snowleopard/fast/forms/button-style-color
- platform/mac-snowleopard/fast/forms/button-table-styles
- platform/mac-snowleopard/fast/forms/button-text-transform
- platform/mac-snowleopard/fast/forms/button-white-space
- platform/mac-snowleopard/fast/forms/control-restrict-line-height
- platform/mac-snowleopard/fast/forms/disabled-select-change-index
- platform/mac-snowleopard/fast/forms/fieldset-align
- platform/mac-snowleopard/fast/forms/file/file-input-direction
- platform/mac-snowleopard/fast/forms/form-element-geometry
- platform/mac-snowleopard/fast/forms/form-hides-table
- platform/mac-snowleopard/fast/forms/input-appearance-height
- platform/mac-snowleopard/fast/forms/input-button-sizes
- platform/mac-snowleopard/fast/forms/input-table
- platform/mac-snowleopard/fast/forms/input-value
- platform/mac-snowleopard/fast/forms/menulist-style-color
- platform/mac-snowleopard/fast/forms/option-strip-whitespace
- platform/mac-snowleopard/fast/forms/placeholder-position
- platform/mac-snowleopard/fast/forms/radio_checked
- platform/mac-snowleopard/fast/forms/radio_checked_dynamic
- platform/mac-snowleopard/fast/forms/range/slider-padding
- platform/mac-snowleopard/fast/forms/select-align
- platform/mac-snowleopard/fast/forms/select-baseline-expected
- platform/mac-snowleopard/fast/forms/select-disabled-appearance
- platform/mac-snowleopard/fast/forms/select-initial-position
- platform/mac-snowleopard/fast/forms/select-style
- platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
- platform/mac-snowleopard/fast/forms/textAreaLineHeight
- platform/mac-snowleopard/fast/forms/textarea-align
- platform/mac-snowleopard/fast/forms/textarea-scroll-height
- platform/mac-snowleopard/fast/forms/textarea-width
- platform/mac-snowleopard/fast/overflow/overflow-x-y
New pixel test results:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/mac/fast/forms/basic-buttons-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-selects-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/button-align-expected.png:
- platform/mac/fast/forms/button-generated-content-expected.png:
- platform/mac/fast/forms/button-sizes-expected.png:
- platform/mac/fast/forms/button-style-color-expected.png:
- platform/mac/fast/forms/button-table-styles-expected.png:
- platform/mac/fast/forms/button-text-transform-expected.png:
- platform/mac/fast/forms/button-white-space-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/disabled-select-change-index-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/file/file-input-direction-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-hides-table-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-button-sizes-expected.png:
- platform/mac/fast/forms/input-table-expected.png:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/menulist-style-color-expected.png:
- platform/mac/fast/forms/option-strip-whitespace-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/forms/radio_checked-expected.png:
- platform/mac/fast/forms/radio_checked_dynamic-expected.png:
- platform/mac/fast/forms/range/slider-padding-expected.png:
- platform/mac/fast/forms/select-align-expected.png:
- platform/mac/fast/forms/select-baseline-expected.png:
- platform/mac/fast/forms/select-disabled-appearance-expected.png:
- platform/mac/fast/forms/select-initial-position-expected.png:
- platform/mac/fast/forms/select-style-expected.png:
- platform/mac/fast/forms/select-writing-direction-natural-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/forms/textarea-width-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
Added new results:
- platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
- platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
- platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed
brand new baseline, and so does Snow Leopard.
- platform/mac/fast/forms/listbox-clip-expected.txt:
- platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.
New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.
- platform/mac/fast/table/003-expected.png:
- platform/mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/mac/tables/mozilla/bugs/bug30692-expected.png:
- 9:34 AM Changeset in webkit [104298] by
-
- 4 edits in branches/chromium/wpotest/Source
Merge 103722 - [chromium] really enable wpo for WebCore libs and for WTF
https://bugs.webkit.org/show_bug.cgi?id=75264
Reviewed by Adam Barth.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp: Enable WPO for wtf and yarr.
Source/WebCore:
- WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the
value set in common.gypi. Use a target_defaults instead to set the
variable. I tested manually on my Windows machine and
WholeProgramOptimization is getting set when buildtype is Official.
- 9:33 AM Changeset in webkit [104297] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit/win
Merged r104296.
- 9:19 AM Changeset in webkit [104296] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix.
- Interfaces/IWebViewPrivate.idl:
- 9:13 AM Changeset in webkit [104295] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621
Unreviewed update to Chromium test_expectations
Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-06
- platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg
- 9:03 AM Changeset in webkit [104294] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
https://bugs.webkit.org/show_bug.cgi?id=75706
Unreviewed.
- platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
- 7:42 AM Changeset in webkit [104293] by
-
- 2 edits in trunk/LayoutTests
make canvas-lineWidth test pass even if pixel values vary a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=75627
Patch by Elliot Poger <epoger@google.com> on 2012-01-06
Reviewed by Stephen White.
- fast/canvas/canvas-lineWidth.js:
(compareRows):
- 7:37 AM Changeset in webkit [104292] by
-
- 38 edits3 copies6 moves43 adds17 deletes in trunk/LayoutTests
Rebaseline mac results after r104240.
https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.
Unreviewed.
- platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
- platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
- platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
- platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
- platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
- platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
- platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
- platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-leopard/fast/table/003-expected.png:
- platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
- platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
- platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
- platform/chromium-mac/fast/table/003-expected.png: Removed.
- platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
- platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
- platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
- platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
- platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
- platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
- platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
- platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.
- 7:28 AM Changeset in webkit [104291] by
-
- 2 edits in trunk
[Qt] Fix compilation of app code against QtWebKit master header file
Unreviewed trivial build fix.
- Source/sync.profile: Exclude util.h and testwindow.h from the master header
file, because it cannot be used outside of the WebKit source tree.
- 6:48 AM Changeset in webkit [104290] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r104060): fast/forms/textarea-metrics.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75644
Reviewed by Alexey Proskuryakov.
We need to clear the style selector on doc type change as the doc type
may affect interpretation of the stylesheets. r104060 extended the life
of the style selector in some cases, exposing this problem.
- dom/Document.cpp:
(WebCore::Document::setDocType):
- 6:25 AM Changeset in webkit [104289] by
-
- 4 edits2 adds in trunk
Make the new WTF module build on Gtk
https://bugs.webkit.org/show_bug.cgi?id=75669
Patch by Eric Seidel <eric@webkit.org> and Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-06
Source/JavaScriptCore:
- GNUmakefile.am:
Source/WTF:
- GNUmakefile.am: Added.
- GNUmakefile.list.am: Added.
- 6:21 AM Changeset in webkit [104288] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
https://bugs.webkit.org/show_bug.cgi?id=75649
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-06
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/CacheClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/CacheClientBlackBerry.h: Added.
- 5:34 AM Changeset in webkit [104287] by
-
- 3 edits1 add in trunk/Source/WebKit2
[Qt][WK2] QQuickWebView breaks when an empty url is loaded
https://bugs.webkit.org/show_bug.cgi?id=75445
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-06
Reviewed by Tor Arne Vestbø.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::load):
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Check if a request to load
an empty url is ignored. 'about:blank' should be used instead to load an empty page.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 5:18 AM Changeset in webkit [104286] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Qt] Remove un-needed VPATHs from project includes
Reviewed by Simon Hausmann.
- 4:53 AM Changeset in webkit [104285] by
-
- 11 edits4 moves4 adds in trunk
[Qt] Move listing of include paths and libs to pri files in sources
Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.
Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().
Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.
Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.
Reviewed by Simon Hausmann.
Reviewed by Ossy.
- 4:44 AM Changeset in webkit [104284] by
-
- 2 edits in trunk
[Qt] Add a few more files ot OTHER_FILES
Rubber-stamped by Simon Hausmann.
- 4:27 AM Changeset in webkit [104283] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a new failing test.
- platform/qt/Skipped:
- 3:25 AM Changeset in webkit [104282] by
-
- 9 edits in trunk
Source/WebKit/efl: [EFL] Add new pre-rendering code.
https://bugs.webkit.org/show_bug.cgi?id=73430
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.
Add new pre-rendering code to pre-render the view area more efficiently.
At first find centered view position where backing store starts to queuing the render request from.
And append the request into the tiled backing store in spiral order.
- ewk/ewk_private.h:
- ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
- ewk/ewk_tiled_backing_store.h:
- ewk/ewk_view.cpp:
(_ewk_view_smart_pre_render_start):
(ewk_view_base_smart_set):
(ewk_view_pre_render_start):
- ewk/ewk_view.h:
- ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_rect_collision_check):
(_ewk_view_tiled_rect_collision_resolve):
(_ewk_view_tiled_smart_pre_render_start):
(ewk_view_tiled_smart_set):
Tools: [EFL] Add pre-render handling code in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=73430
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.
Add pre-render handling code by pressing Insert key.
- EWebLauncher/main.c:
(on_key_down):
- 2:55 AM Changeset in webkit [104281] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75698
Unreviewed.
- platform/chromium/test_expectations.txt:
- 2:31 AM Changeset in webkit [104280] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 2:28 AM Changeset in webkit [104279] by
-
- 7 edits in trunk/Source/WebCore
FrameDestructionObserver should be more full-service
https://bugs.webkit.org/show_bug.cgi?id=75690
Reviewed by Eric Seidel.
This patch moves code common to both subclasses of
FrameDestructionObserver into FrameDestructionObserver itself. As we
add more subclasses, we don't want to keep copy/pasting this code.
- page/Frame.cpp:
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):
- page/Frame.h:
(WebCore::FrameDestructionObserver::frame):
- plugins/DOMMimeType.cpp:
(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):
- plugins/DOMMimeType.h:
- plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):
- plugins/DOMPlugin.h:
- 1:43 AM Changeset in webkit [104278] by
-
- 10 edits2 adds in trunk
Move MediaDocument styles into CSS. Set black background for chromium.
https://bugs.webkit.org/show_bug.cgi?id=74123
Source/WebCore:
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.
Test: platform/chromium/media/video-black-bg-in-media-document.html
- css/mediaControls.css:
(body:-webkit-full-page-media):
(video:-webkit-full-page-media):
- css/mediaControlsChromium.css:
(body:-webkit-full-page-media):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
LayoutTests:
Adds a new chromium specific test for ensuring the background is set
properly.
Rebaselines the text portions of media-document-audio-repaint.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium/media/media-document-audio-repaint-expected.txt:
- platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
- platform/chromium/media/video-black-bg-in-media-document.html: Added.
- platform/chromium/test_expectations.txt:
- 1:03 AM Changeset in webkit [104277] by
-
- 5 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.
- platform/qt/fast/table/032-expected.png:
- platform/qt/fast/table/032-expected.txt:
- platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
- platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
- platform/qt/tables/mozilla/bugs/bug55694-expected.png:
- platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
- 12:53 AM Changeset in webkit [104276] by
-
- 13 edits2 adds in trunk
Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263
Reviewed by Ryosuke Niwa.
Source/WebCore:
A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.
This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.
This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.
Test: accessibility/textbox-role-reports-line-number.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.
- dom/Node.cpp:
(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
- dom/Node.h:
(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable): Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.
- editing/EditingBoundary.h:
- editing/htmlediting.cpp:
(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.
- editing/htmlediting.h:
- editing/visible_units.cpp:
(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.
- editing/visible_units.h:
LayoutTests:
- accessibility/textbox-role-reports-line-number-expected.txt: Added.
- accessibility/textbox-role-reports-line-number.html: Added.
- 12:47 AM Changeset in webkit [104275] by
-
- 3 edits2 adds in trunk
Fix a crash by importing an element of which local name ends with ":input".
https://bugs.webkit.org/show_bug.cgi?id=75103
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/importNode-confusing-localName.html
- dom/Document.cpp:
(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name
LayoutTests:
- fast/dom/importNode-confusing-localName-expected.txt: Added.
- fast/dom/importNode-confusing-localName.html: Added.
- 12:33 AM Changeset in webkit [104274] by
-
- 13 edits1 copy1 add in trunk/Source/WebCore
Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-06
Reviewed by Kent Tamura.
Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.
No new tests : the existing ones should cover the refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextFormControlElement.h:
- 12:14 AM Changeset in webkit [104273] by
-
- 3 edits in trunk/Tools
NRWT should use test_expectation.txt on wk2 platforms
https://bugs.webkit.org/show_bug.cgi?id=75417
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(path_to_test_expectations_file):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_path_to_test_expectations_file):
- 12:09 AM Changeset in webkit [104272] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r104268.
http://trac.webkit.org/changeset/104268
https://bugs.webkit.org/show_bug.cgi?id=75689
It broke the mac build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::shouldAutocomplete):
(WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint):
(WebCore::HTMLFormControlElementWithState::saveFormControlState):
(WebCore::HTMLFormControlElementWithState::restoreFormControlState):
- html/HTMLFormControlElementWithState.cpp: Removed.
- html/HTMLFormControlElementWithState.h: Removed.
- html/HTMLKeygenElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextFormControlElement.h:
- 12:07 AM Changeset in webkit [104271] by
-
- 15 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r104259 and r104261.
http://trac.webkit.org/changeset/104259
http://trac.webkit.org/changeset/104261
https://bugs.webkit.org/show_bug.cgi?id=75688
Caused assertion failures (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
- dom/DOMAllInOne.cpp:
- dom/Document.cpp:
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
- dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
- dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
(WebCore::Node::didMoveToNewDocument):
- dom/Node.h:
- dom/TreeScope.cpp:
- dom/TreeScope.h:
- dom/TreeScopeAdopter.cpp: Removed.
- dom/TreeScopeAdopter.h: Removed.
- 12:04 AM Changeset in webkit [104270] by
-
- 2 edits in trunk/Source/JavaScriptCore
WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=75612
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.
- wtf/text/WTFString.h:
(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):
