Timeline



Jan 16, 2012:

11:08 PM Changeset in webkit [105127] by rolandsteiner@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

Unreviewed:more Chromium Linux rebaselining

  • platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
10:44 PM Changeset in webkit [105126] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Internals] member varaibles should follow naming convention.
​https://bugs.webkit.org/show_bug.cgi?id=76426

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-16
Reviewed by Kent Tamura.

No new tests. Just a rename.

  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

  • testing/Internals.h:
10:02 PM Changeset in webkit [105125] by rolandsteiner@chromium.org
  • 8 edits
    6 deletes in trunk/LayoutTests

Unreviewed: updated baselines for Chromium Linux

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Removed.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
9:28 PM WebKit Team edited by sh4.seo@samsung.com
(diff)
9:24 PM Changeset in webkit [105124] by rolandsteiner@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed: rebaselining fast/backgrounds/mask-box-image

  • platform/chromium-mac-snowleopard/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/mask-box-image-expected.txt: Added.
7:56 PM Changeset in webkit [105123] by hayato@chromium.org
  • 5 edits in trunk

Implement multiple AT_TARGET event dispatching in regard to shadow tree.
​https://bugs.webkit.org/show_bug.cgi?id=76217

Reviewed by Dimitri Glazkov.

The original motivation is to fix the regression: Event.eventPhase is not set to 2
(at target) when handling dblclick event in <input> element.
Since the issue is not specific to <input> element, but general one, this patch fixes
the regression by adapting a living draft spec of shadow DOM.
This won't break a compatibility if there is no shadow boundaries in event dispatching.
See the following shadow dom spec how multiple AT_TARGET events work.
​http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

Source/WebCore:

  • dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
7:47 PM Changeset in webkit [105122] by toyoshim@chromium.org
  • 2 edits in trunk/Tools

Add toyoshim as a committer.
​https://bugs.webkit.org/show_bug.cgi?id=76390

Reviewed by Hajime Morita.

  • Scripts/webkitpy/common/config/committers.py:
7:35 PM Changeset in webkit [105121] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

platformRequest(QNX) need to get the conditional information from ResourceRequest.
​https://bugs.webkit.org/show_bug.cgi?id=75216

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-01-16
Reviewed by George Staikos.

Pass the isConditional() flag in ResourceRequest to the QNX platform's network request.
QNX platform's network needs this flag to determine whether to use disk-cache.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(ResourceRequest::initializePlatformRequest):

6:25 PM Changeset in webkit [105120] by robert@webkit.org
  • 5 edits
    6 adds in trunk

Heap-use-after-free in WebCore::RenderBlock::selectionGaps
​https://bugs.webkit.org/show_bug.cgi?id=75013

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/multiple-captions-crash3.html

fast/table/multiple-captions-crash4.html
fast/table/multiple-captions-crash5.html

When a child float is removed, the parent needs to ensure any reference to the
child is also removed from the floating objects list in any sibling block that
it intruded into.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

In multiple-captions-crash3.html a floating object is added as a child to a caption element, then removed and
added as a child to another caption element. When added to the first caption element it is added
to the floating objects list of both the parent tbody element and the keygen element, as it intrudes
into the latter. When removed, a stale reference to the floating object remains in the keygen element.
When the keygen element is in layout it attempts to access the stale reference to the floating object and
crashes. The fix is to ensure that any floats added as intruding floats to sibling blocks are removed
when the child is removed from the tree.

multiple-captions-crash4.html and multiple-captions-crash5.html are variants of this scenario.

  • fast/table/multiple-captions-crash3-expected.html: Added.
  • fast/table/multiple-captions-crash3.html: Added.
  • fast/table/multiple-captions-crash4-expected.html: Added.
  • fast/table/multiple-captions-crash4.html: Added.
  • fast/table/multiple-captions-crash5-expected.html: Added.
  • fast/table/multiple-captions-crash5.html: Added.
6:00 PM Changeset in webkit [105119] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge r99591.

5:49 PM Changeset in webkit [105118] by mrowe@apple.com
  • 8 edits in branches/safari-534.54-branch/Source

Merge r103860.

5:33 PM Changeset in webkit [105117] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104049.

5:21 PM Changeset in webkit [105116] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103925.

5:21 PM Changeset in webkit [105115] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103871.

5:21 PM Changeset in webkit [105114] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r103869.

5:21 PM Changeset in webkit [105113] by mrowe@apple.com
  • 19 edits in branches/safari-534.54-branch/Source

Merge r103858.

5:17 PM Changeset in webkit [105112] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10702758> REGRESSION: Every Safari Reader WKView leaks

Reviewed by John Sullivan and Ada Chan.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]): Since this method can be called multiple times in a row
while [self window] is non-nil, check if there isn’t already an event monitor before adding
a new one.

5:12 PM Changeset in webkit [105111] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION: r102553 Autocorrection bubble doesn't show up
​https://bugs.webkit.org/show_bug.cgi?id=76408
<rdar://problem/10644746>

Prior to r102553 Editor::markAllMisspellingsAndBadGrammarInRanges() used to pass its
textCheckingOptions directly to markAndReplaceFor(). Now a request object is used,
but, when the object is created, the TextCheckingTypeShowCorrectionPanel flag is dropped.

Reviewed by Darin Adler.

  • editing/Editor.cpp:

(WebCore::Editor::resolveTextCheckingTypeMask): Add TextCheckingTypeShowCorrectionPanel to
the returned checkingTypes when appropriate.

5:10 PM Changeset in webkit [105110] by Lucas Forschler
  • 1 edit
    2 copies in branches/safari-534.54-branch/LayoutTests

Merged r100471.

5:06 PM Changeset in webkit [105109] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r104660.

5:04 PM Changeset in webkit [105108] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r104762.

4:53 PM Changeset in webkit [105107] by fpizlo@apple.com
  • 18 edits
    15 adds in trunk

DFG should be able to do JS and custom getter caching
​https://bugs.webkit.org/show_bug.cgi?id=76361
<rdar://problem/10698060>

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added the ability to cache JS getter calls and custom getter calls in the DFG.
Most of this is pretty mundane, since the old JIT supported this functionality
as well. But a couple interesting things had to happen:

  • There are now two variants of GetById: GetById, which works as before, and GetByIdFlush, which flushes registers prior to doing the GetById. Only GetByIdFlush can be used for caching getters. We detect which GetById style to use by looking at the inline caches of the old JIT.


  • Exception handling for getter calls planted in stubs uses a separate lookup handler routine, which uses the CodeOrigin stored in the StructureStubInfo.


This is a 40% speed-up in the Dromaeo DOM Traversal average. It removes all of
the DFG regressions we saw in Dromaeo. This is neutral on SunSpider, V8, and
Kraken.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitExceptionCheck):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::willNeedFlush):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupResults):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::JITCompiler::addExceptionCheck):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/dfg-custom-getter-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined-expected.txt: Added.
  • fast/js/dfg-custom-getter-throw-inlined.html: Added.
  • fast/js/dfg-custom-getter-throw.html: Added.
  • fast/js/dfg-custom-getter.html: Added.
  • fast/js/dfg-getter-expected.txt: Added.
  • fast/js/dfg-getter-throw-expected.txt: Added.
  • fast/js/dfg-getter-throw.html: Added.
  • fast/js/dfg-getter.html: Added.
  • fast/js/script-tests/dfg-custom-getter-throw-inlined.js: Added.

(foo):
(baz):
(bar):

  • fast/js/script-tests/dfg-custom-getter-throw.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-custom-getter.js: Added.

(foo):

  • fast/js/script-tests/dfg-getter-throw.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-getter.js: Added.

(foo):

4:36 PM Changeset in webkit [105106] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Fix <rdar://problem/10678175>.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notityPositionChanged):

4:25 PM Changeset in webkit [105105] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling SecItemAdd with a null result pointer
​https://bugs.webkit.org/show_bug.cgi?id=76407
<rdar://problem/10696087>

Reviewed by Brady Eidson.

Add null check.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::webSecItemAdd):

4:19 PM Changeset in webkit [105104] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-534.54-branch

Merge r102540.

4:16 PM Changeset in webkit [105103] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Build correction. Switch to Apple style builds without
the _debug postfix so that launching tools, etc., will work properly.

  • win/tools/vsprops/debug_wincairo.vsprops: Remove use of _debug in

output files to be consistent with WebKit build/test tools.

4:08 PM Changeset in webkit [105102] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge fix for 9593456.

4:04 PM Changeset in webkit [105101] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

A follow-up fix for:
A warning is logged to console when typing a bare "/" in Safari address bar
​https://bugs.webkit.org/show_bug.cgi?id=76236

<rdar://problem/10702986>

Reviewed by John Sullivan.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a path when there is a base URL.
3:55 PM Changeset in webkit [105100] by mrowe@apple.com
  • 9 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r96014.

3:46 PM Changeset in webkit [105099] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merge r104378.

3:46 PM Changeset in webkit [105098] by jonlee@apple.com
  • 10 edits in trunk/Source

Build fix for r105086.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • notifications/NotificationCenter.idl: change to use ENABLE_TEXT_NOTIFICATIONS_ONLY, which is only defined on Mac platform.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:38 PM Changeset in webkit [105097] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104663.

3:38 PM Changeset in webkit [105096] by mrowe@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r104377.

3:38 PM Changeset in webkit [105095] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in StyledElement::mappedAttributeCount().
<​http://webkit.org/b/76393>

Rubber-stamped by Antti Koivisto.

  • dom/StyledElement.h:

(WebCore::StyledElement::mappedAttributeCount): Less &&, more ?:

2:49 PM Changeset in webkit [105094] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for r105086.

  • notifications/NotificationCenter.idl: expand ENABLE macro for .idl.
2:39 PM Changeset in webkit [105093] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Cache CSSStyleSelector::Features in RuleSets
​https://bugs.webkit.org/show_bug.cgi?id=76337

Reviewed by Andreas Kling.

Currently whenever the style selector is updated we go through all the applicable rules and
collect the used features again. We should keep the features around as part of the RuleSets
and update them incrementally. Collecting the features will then be just a matter of taking
the union of all features used by the RuleSets.

This is 1-2% CPU time reduction (engadget, nytimes) due less time spent in feature collection.

This also simplifies the code by removing the need to cache the default style sheet features
separately.

  • css/CSSStyleSelector.cpp:


Remove the global siblingRulesInDefaultStyle and uncommonAttributeRulesInDefaultStyle RuleSets.
These are now part of the cached features of the defaultStyle.


(WebCore::RuleSet::features):

Add a field for caching the features.


(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectFeatures):

Unify the features of all RuleSets.
Create RuleSets for sibling and uncommon attribute lookups at the end.


(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::Features::add):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):

Collect the features when adding the rules rather than as a separate pass through all the rules.


  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::RuleSelectorPair::RuleSelectorPair):

Use Vector instead of a RuleSet for sibling and uncommon attribute selectors so unifying
Features is simpler.

2:37 PM Changeset in webkit [105092] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Huge filter area cause hangs and malloc failures
​https://bugs.webkit.org/show_bug.cgi?id=75711

Reviewed by Dean Jackson.

Filtering an element with a child that had a huge negative text-indent
was extremely slow, because transparencyClipBox() returned a huge rect.

Add a method, paintingExtent(), that wraps transparencyClipBox()
and intersects it with the paintDirtyRect to constrain the size
of the rect used for filters and transparency layers.

Transparency layer extent is not testable in layout tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintingExtent):
(WebCore::RenderLayer::beginTransparencyLayers): Floating point literals are required
to avoid ambiguous constructor call.
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):

  • rendering/RenderLayer.h:
2:21 PM Changeset in webkit [105091] by Simon Fraser
  • 3 edits
    4 adds in trunk

Borders and box masks behave incorrectly with overlapping offsets
​https://bugs.webkit.org/show_bug.cgi?id=76137

Source/WebCore:

Reviewed by Dean Jackson.

There are some correct behaviors for -webkit-mask-box-image where
parts of the mask are missing (when the sum of the slice sizes is
greater than one dimension of the image). To render correctly
in these cases, always use a transparency layer when rendering
the mask.

Test: fast/backgrounds/mask-box-image.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages):

LayoutTests:

Reviewed by Dean Jackson.

Test -webkit-mask-box-image with large slice sizes, with and
without a transform.

  • fast/backgrounds/mask-box-image.html: Added.
  • fast/backgrounds/resources/dot.png: Added.
  • platform/mac/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/mac/fast/backgrounds/mask-box-image-expected.txt: Added.
2:19 PM Changeset in webkit [105090] by Simon Fraser
  • 3 edits
    3 adds in trunk

Filtered element with composited content beneath it must be composited
​https://bugs.webkit.org/show_bug.cgi?id=76322

Source/WebCore:

Reviewed by Dean Jackson.

If a RenderLayer has a filter effect, and a composited descendant, then
that layer must also be composited so that the filter is applied via
the compositing system, rather than via painting (otherwise the filter
will not affect the descendant).

Test: css3/filters/filtered-compositing-descendant.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):

LayoutTests:

Reviewed by Dean Jackson.

Testcase with a filtered element having a composited child.

  • css3/filters/filtered-compositing-descendant-expected.png: Added.
  • css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • css3/filters/filtered-compositing-descendant.html: Added.
1:53 PM Changeset in webkit [105089] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix assertion failure in mappedAttributesEquivalent().
<​http://webkit.org/b/76393>

Rubber-stamped by Antti Koivisto.

The assertion that two mapped attributes with matching name/value will always
have the exact same decl() was wrong, so make it a proper check once again.

  • css/CSSStyleSelector.cpp:

(WebCore::mappedAttributesEquivalent):

1:31 PM Changeset in webkit [105088] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

[WinCairo] Build fix after r104155. Several debug targets were not
properly including the '*Common' property sheets.

  • DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
  • DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
  • MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
  • WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1:18 PM Changeset in webkit [105087] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Changes AssociatedURLLoader to remove non-whitelisted HTTP response headers for CORS requests,
and Set-Cookie and Set-Cookie2 response headers for all requests.
​https://bugs.webkit.org/show_bug.cgi?id=76228

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::create):
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
(WebKit::AssociatedURLLoader::loadAsynchronously):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::didReceiveResponse):
(WebKit::TEST_F):

1:11 PM Changeset in webkit [105086] by jonlee@apple.com
  • 4 edits in trunk/Source

Remove HTML notifications support on Mac
​https://bugs.webkit.org/show_bug.cgi?id=76401
<rdar://problem/10589881>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • wtf/Platform.h: Define ENABLE_HTML_NOTIFICATIONS macro.

Source/WebCore:

  • notifications/NotificationCenter.idl:
12:50 PM Changeset in webkit [105085] by commit-queue@webkit.org
  • 12 edits
    25 adds in trunk

Add offline web applications API applicationCache.abort.
​https://bugs.webkit.org/show_bug.cgi?id=76270

Patch by xueqing huang <​huangxueqing@baidu.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests:
http/tests/appcache/abort-cache-onchecking.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
http/tests/appcache/abort-cache-ondownloading.html
http/tests/appcache/abort-cache-ondownloading-manifest-404.html
http/tests/appcache/abort-cache-ondownloading-resource-404.html
http/tests/appcache/abort-cache-onprogress.html

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):

  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::abort):

  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::abort):

  • loader/appcache/DOMApplicationCache.h:
  • loader/appcache/DOMApplicationCache.idl:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::abort):

LayoutTests:

  • http/tests/appcache/abort-cache-onchecking-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-manifest-404.html: Added.
  • http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-onchecking-resource-404.html: Added.
  • http/tests/appcache/abort-cache-onchecking.html: Added.
  • http/tests/appcache/abort-cache-ondownloading-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-manifest-404.html: Added.
  • http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt: Added.
  • http/tests/appcache/abort-cache-ondownloading-resource-404.html: Added.
  • http/tests/appcache/abort-cache-ondownloading.html: Added.
  • http/tests/appcache/abort-cache-onprogress-expected.txt: Added.
  • http/tests/appcache/abort-cache-onprogress.html: Added.
  • http/tests/appcache/resources/abort-cache-onchecking-resource-404.manifest: Added.
  • http/tests/appcache/resources/abort-cache-onchecking.manifest: Added.
  • http/tests/appcache/resources/abort-cache-onchecking.text: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading-resource-404.manifest: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading.manifest: Added.
  • http/tests/appcache/resources/abort-cache-ondownloading.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-1.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-2.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-3.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress-4.text: Added.
  • http/tests/appcache/resources/abort-cache-onprogress.manifest: Added.
  • platform/chromium/test_expectations.txt:
12:28 PM Changeset in webkit [105084] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove caching of mapped attribute count on NamedNodeMap.
<​http://webkit.org/b/76393>

Reviewed by Antti Koivisto.

Stop caching the mapped attribute count on Element's attribute map, effectively
shrinking NamedNodeMap by one CPU word. The price we pay is always walking over
the map in matchAllRules(), even if it has no mapped attribute styles.

This reduces memory consumption by 605 kB (on 64-bit) when viewing the full
HTML5 spec at <​http://whatwg.org/c>

  • css/CSSStyleSelector.cpp:

(WebCore::mappedAttributesEquivalent):

Moved here from NamedNodeMap::mappedMapsEquivalent() to accomodate the only
user under the added assumption that the two attribute maps have the same
number of mapped attributes.

(WebCore::CSSStyleSelector::matchAllRules):

We don't have NamedNodeMap::hasMappedAttributes() at our convenience any
more so walk the attribute map (if there is one) looking for styles to add.

(WebCore::CSSStyleSelector::canShareStyleWithElement):

Compare the elements' mapped attribute counts at an earlier time. This is
slightly more expensive but we used to do it near the end anyway and this
ends up rejecting elements that can't share style before doing a lot of
semi-expensive checks.

  • dom/StyledElement.h:

(WebCore::StyledElement::mappedAttributeCount):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::mappedAttributeCount):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::clearAttributes):

Remove NamedNodeMap::m_mappedAttributeCount and add a function that walks
the attribute map counting the attributes that have a decl().

  • dom/NamedNodeMap.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

Remove declAdded()/declRemoved() callbacks.

12:22 PM Changeset in webkit [105083] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

12:02 PM Changeset in webkit [105082] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

REGRESSION(r105072): It broke committers_unittest.py
​https://bugs.webkit.org/show_bug.cgi?id=76396

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers_unittest.py:

(CommittersTest._assert_fuzz_match): It should handle more names.
(CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.

12:01 PM Changeset in webkit [105081] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.6

New tag.

11:50 AM Changeset in webkit [105080] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r91324.

11:28 AM Changeset in webkit [105079] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Added necessary header files to VectorMath.cpp to fix Chromium compile error.

  • platform/audio/VectorMath.cpp:
10:53 AM Changeset in webkit [105078] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

WebAudio: Optimize AudioChannel::maxAbsValue().
​https://bugs.webkit.org/show_bug.cgi?id=74359

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::maxAbsValue): Replace implementation with optimized vector math

operation.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vmaxmgv): Vector math operation for determining maximum

magnitude in a vector.

  • platform/audio/VectorMath.h:
10:46 AM Changeset in webkit [105077] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

A warning is logged to console when typing a bare "/" in Safari address bar
​https://bugs.webkit.org/show_bug.cgi?id=76236

Reviewed by John Sullivan.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths.
10:42 AM Changeset in webkit [105076] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=41210
Cross Origin XMLHttpRequest can not expose headers indicated in Access-Control-Expose-Headers HTTP Response Header

Source/WebCore:

Parsing the "Access-Control-Expose-Headers" in the XMLHTTPRequest response header.
If the custom response-header is part of Access-Control-Expose-Headers, then consider that custom response-header as a valid one.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/access-control-response-with-expose-headers.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::parseAccessControlExposeHeadersAllowList): parsing logic of Access-Control-Expose-Headers

  • loader/CrossOriginAccessControl.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders): checking whether the custom response-header is part of "Access-Control-Expose-Headers"
(WebCore::XMLHttpRequest::getResponseHeader): checking whether the custom response-header is part of "Access-Control-Expose-Headers"

LayoutTests:

Added test cases for Access-Control-Expose-Headers

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-16
Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/access-control-response-with-expose-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-response-with-expose-headers.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-response-with-expose-headers.php: Added.
10:40 AM Changeset in webkit [105075] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Include gtk+3 in the jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-01-16
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
10:17 AM Changeset in webkit [105074] by zeno.albisser@nokia.com
  • 8 edits in trunk/Source

[Qt] Fix QT_VERSION related warnings when building on Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=76340

Source/JavaScriptCore:

This bug was caused by r104826.
As already mentioned for ​https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.

Reviewed by Tor Arne Vestbø.

  • wtf/Platform.h:

Source/WebKit2:

This bug was caused by r104826.
As was already mentioned for ​https://bugs.webkit.org/show_bug.cgi?id=57239
we should not use "using namespace WebCore" in header files,
because it might cause ambiguous references.
This patch reverts the changes from r104826 and r104981
and removes the "using namespace WebCore" statement from
two header files.

Reviewed by Tor Arne Vestbø.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerUpdateInfo::WebLayerUpdateInfo):
(WebKit::WebLayerAnimation::WebLayerAnimation):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h:
10:05 AM Changeset in webkit [105073] by apavlov@chromium.org
  • 55 edits
    2 copies
    1 move
    8 adds
    14 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline SVG tests after r105061.

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/tref-update-expected.txt:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.txt:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.txt:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/svg/text/bidi-text-anchor-direction-expected.png: Removed.
10:03 AM Changeset in webkit [105072] by danw@gnome.org
  • 2 edits in trunk/Tools

Add myself as a committer

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
9:31 AM Changeset in webkit [105071] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: timeline record bars may overlap with the records column
​https://bugs.webkit.org/show_bug.cgi?id=76387

Reviewed by Yury Semikhatsky.

  • inspector/front-end/timelinePanel.css:

(#timeline-container .split-view-sidebar-left):

9:24 AM Changeset in webkit [105070] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: styles sidebar rendering is broken
​https://bugs.webkit.org/show_bug.cgi?id=76065

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):

  • inspector/front-end/elementsPanel.css:

(.styles-section .header .subtitle):
(.styles-section .properties):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.

9:18 AM Changeset in webkit [105069] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.

Some recent versions of a few Linux distributions have started passing
--as-needed and --no-copy-dt-needed-entries by default to the linker,
which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
needed a few symbols from libjavascriptcore_efl.so.

  • DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME

before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
libraries are searched in the right order by the linker.

9:17 AM Changeset in webkit [105068] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Inremental build problem revealed by ​https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri: supplemental_dependency.tmp must depends on idl files too.
8:56 AM Changeset in webkit [105067] by pfeldman@chromium.org
  • 13 edits in trunk

Web Inspector: do not merge iframes into a single DOM hierarchy.
​https://bugs.webkit.org/show_bug.cgi?id=76383

Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/DOMEditor.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerFirstChild):
(WebCore::InspectorDOMAgent::innerParentNode):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._ownerDocumentId):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.findNode.processChildren):

  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-tests-expected.txt:
  • inspector/elements/set-outer-html-body.html:
  • inspector/styles/styles-iframe.html:
8:47 AM Changeset in webkit [105066] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: setCurrentFocusElement should not update selection when focus is moved to text field or text area.
​https://bugs.webkit.org/show_bug.cgi?id=76384

Reviewed by Timothy Hatcher.

  • inspector/front-end/JavaScriptOutlineDialog.js:

(WebInspector.JavaScriptOutlineDialog):

  • inspector/front-end/UIUtils.js:

(WebInspector._isTextEditingElement):
(WebInspector.setCurrentFocusElement):

8:13 AM Changeset in webkit [105065] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] set audio resources path in NRTW
​https://bugs.webkit.org/show_bug.cgi?id=76380

Reviewed by Martin Robinson.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
the uninstalled audio resources are used during webaudio tests.

8:08 AM Changeset in webkit [105064] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r105061.

  • platform/gtk/svg/carto.net/colourpicker-expected.txt:
  • platform/gtk/svg/carto.net/combobox-expected.txt:
  • platform/gtk/svg/carto.net/slider-expected.txt:
  • platform/gtk/svg/carto.net/textbox-expected.txt:
8:00 AM Changeset in webkit [105063] by Philippe Normand
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-slice-constrained-expected.txt: Added.
  • platform/gtk/fast/text/unicode-variation-selector-expected.txt: Added.
  • platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/gtk/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/gtk/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
  • platform/gtk/svg/filters/filter-refresh-expected.txt: Added.
6:28 AM Changeset in webkit [105062] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Remove references to PagePointer in the FrameNetworkingContext
​https://bugs.webkit.org/show_bug.cgi?id=76342

Patch by Alexander Færøy <​alexander.faeroy@nokia.com> on 2012-01-16
Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):

  • WebProcess/qt/QtNetworkAccessManager.h:
6:04 AM Changeset in webkit [105061] by Nikolas Zimmermann
  • 38 edits in trunk

Large SVG text layout performance regression in r81168
​https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable simple code path in SVGTextMetricsBuilder, allowing fast-measurement of simple text.
This affects the geometry of several <text> elements, thus several tests need rebaselining.

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):

LayoutTests:

Update some test results after enabling the simple code path to measure SVG text.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
5:44 AM Changeset in webkit [105060] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate array types.
​https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-01-16
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance. Some includes
and ifdefs are fixed.

  • inspector/CodeGeneratorInspector.py:

(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.init):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.init):
(TypeData.get_binding):

  • inspector/ConsoleMessage.cpp:
  • inspector/InspectorValues.h:
5:40 AM Changeset in webkit [105059] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.4 release
​https://bugs.webkit.org/show_bug.cgi?id=76375

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.4.
5:35 AM Changeset in webkit [105058] by pfeldman@chromium.org
  • 5 edits
    3 adds in trunk

Web Inspector: editing body multiplies head
​https://bugs.webkit.org/show_bug.cgi?id=62272

Patch by Pavel Feldman <​pfeldman@chromium.org> on 2012-01-15
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-body.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::insertBefore):

  • inspector/DOMEditor.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

  • inspector/elements/resources/set-outer-html-body-iframe.html: Added.
  • inspector/elements/set-outer-html-body-expected.txt: Added.
  • inspector/elements/set-outer-html-body.html: Added.
5:08 AM Changeset in webkit [105057] by Nikolas Zimmermann
  • 15 edits in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
​https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Change the way we store x/y/dx/dy/rotate values for a <text> element and its ancestors.

SVGTextLayoutAttributesBuilder used to hold a Vector<float> for x/y/dx/dy/rotate, each as big
as the whole text subtree length. For each character, that has an absolute position, or rotation
the value was stored in this list. For all other characters a special empty value marker was stored.

This is highly inefficient, and is now replaced with a HashMap<unsigned, SVGCharacterData> where
SVGCharacterData is a struct, holding float x/y/dx/dy/rotate. The code is now optimized for the
common case, where only a few characters actually specify such values, eg:
<text x="50" y="90">looooong text<tspan x="50" y="30">abc</tspan></text>.

NOTE: There are still some inefficiencies in this patch (especially the copying of SVGTextLayoutAttributes).
To keep the patch size smaller, I decided to fix this in another patch, and only fix the memory issue with this patch.

This reduces the memory consumption from 35MB to 10MB on the attached testcase in bug 65711.

Doesn't affect any test, yet. A follow-up commit will enable the usage of the simple code path, using WidthIterator,
in SVGTextMetricsBuilder, which will result in several layout test changes, because of geometry changes.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::RenderSVGInlineText):
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGInlineText.h:

(WebCore::RenderSVGInlineText::layoutAttributes):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::swapItemsInLayoutAttributes):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::dumpSVGCharacterDataMapValue):
(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributes.h:

(WebCore::SVGTextLayoutAttributes::characterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
(WebCore::updateCharacterData):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.h:

(WebCore::SVGTextLayoutAttributesBuilder::clearTextPositioningElements):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h:

(WebCore::SVGTextLayoutEngine::layoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):

5:00 AM Changeset in webkit [105056] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSCanvasValue can't be renamed, enforce this at compile-time.
<​http://webkit.org/b/76352>

Reviewed by Antti Koivisto.

Have the CSSCanvasValue constructor take the name as an argument instead of
having a setName() that's only called from one place in CSSParser.

  • css/CSSCanvasValue.h:

(WebCore::CSSCanvasValue::create):
(WebCore::CSSCanvasValue::CSSCanvasValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCanvas):

4:57 AM Changeset in webkit [105055] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
<​http://webkit.org/b/76374>

Reviewed by Antti Koivisto.

Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

4:25 AM Changeset in webkit [105054] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Fix typo.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
4:19 AM Changeset in webkit [105053] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
​https://bugs.webkit.org/show_bug.cgi?id=76369

Reviewed by Xan Lopez.

If there's an installed version of webkit and there are new
symbols in the build tree, gtkdoc-scanobj fails due to undefined
references, because the env ldflags are given before the local
ones.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

4:05 AM Changeset in webkit [105052] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code
​https://bugs.webkit.org/show_bug.cgi?id=76043

Re-use appendAuthorStylesheets() from within CSSStyleSelector constructor.

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • css/StyleSheetList.h:

(WebCore::StyleSheetList::vector):

3:40 AM UsingGitWithWebKit edited by peter@chromium.org
Revert spam-change (diff)
3:39 AM BuildBot edited by peter@chromium.org
Revert spam-change (diff)
3:32 AM Changeset in webkit [105051] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r105040.
​http://trac.webkit.org/changeset/105040
​https://bugs.webkit.org/show_bug.cgi?id=76373

Breaks Win (dbg) canary builder (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-16

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Removed.
  • tests/data/event_target.html: Removed.
3:31 AM Changeset in webkit [105050] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[crash] Renderer crashes when spell checking a disabled input field.
​https://bugs.webkit.org/show_bug.cgi?id=75941

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-01-16
Reviewed by Hajime Morita.

.:

  • ManualTests/editing-disabled-node-replace-crash.html: Added.

Source/WebCore:

We confirm the selection is editable before replacing text.

Tests: ManualTests/editing-disabled-node-replace-crash.html

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

3:28 AM Changeset in webkit [105049] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
​https://bugs.webkit.org/show_bug.cgi?id=75865

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

Source/WebCore:

  • WebCore.exp.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyDisplay::isValidDisplayValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

  • rendering/FilterEffectRenderer.cpp:
  • svg/SVGElementInstance.idl:

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):

3:09 AM Changeset in webkit [105048] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compilation error on build-webkit --debug --no-request-animation-frame on mac.
​https://bugs.webkit.org/show_bug.cgi?id=75875

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

  • dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):

3:04 AM Changeset in webkit [105047] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark two inspector/debugger tests as SLOW on Linux Debug.

  • platform/chromium/test_expectations.txt:
2:55 AM Changeset in webkit [105046] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppres webaudio/gain.html failures on Windows.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [105045] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
​https://bugs.webkit.org/show_bug.cgi?id=69341

Unreviewed trivial buildfix/typo fix after r105043.

  • inspector/front-end/WebKit.qrc:
2:23 AM Changeset in webkit [105044] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Solaris Studio supports alignment macros too
​https://bugs.webkit.org/show_bug.cgi?id=75453

Patch by Pavel Heimlich <​tropikhajma@gmail.com> on 2012-01-16
Reviewed by Hajime Morita.

  • wtf/Alignment.h:
1:56 AM Changeset in webkit [105043] by vsevik@chromium.org
  • 7 edits
    1 move
    1 add in trunk/Source/WebCore

Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
​https://bugs.webkit.org/show_bug.cgi?id=69341

Fixed dialog: in old implementation dialog never hides if you press mouse button
on Go button and release it somewhere else.
Dialog functionality extracted to be used for search dialog.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Dialog.js: Added.

(WebInspector.Dialog):
(WebInspector.Dialog.show):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._doFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.Dialog.prototype._onClick):
(WebInspector.DialogDelegate):
(WebInspector.DialogDelegate.prototype.get defaultFocusedElement):
(WebInspector.DialogDelegate.prototype.get okButton):
(WebInspector.DialogDelegate.prototype.onAction):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog._show):
(WebInspector.GoToLineDialog.prototype.get defaultFocusedElement):
(WebInspector.GoToLineDialog.prototype.get okButton):
(WebInspector.GoToLineDialog.prototype.onAction):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/dialog.css: Renamed from Source/WebCore/inspector/front-end/goToLineDialog.css.

(.dialog-glass-pane):
(.dialog):
(.dialog-contents):
(.go-to-line-dialog input):
(.go-to-line-dialog button):
(.go-to-line-dialog button:active):

  • inspector/front-end/inspector.html:
1:41 AM Changeset in webkit [105042] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Build fix when using pango as font backends.
​https://bugs.webkit.org/show_bug.cgi?id=76368

Unreviewed build fix.

  • ewk/ewk_view.cpp: include RefPtrCairo.h
1:37 AM Changeset in webkit [105041] by jochen@chromium.org
  • 7 edits in trunk

ScriptRunner should also keep references to pending async scripts
​https://bugs.webkit.org/show_bug.cgi?id=76350

Reviewed by Adam Barth.

Source/WebCore:

The CachedResourceLoader only keeps a raw pointer to a ScriptElement.
If an async ScriptElement is removed from the document before it is
executed, it might be garbage collected before the script is loaded, so
it's never run.

By making the ScriptRunner keep an explicit reference to the
ScriptElement while it's loading (as is done for sync ScriptElements),
we can guarantee that the ScriptElement lives until it is executed.

No more flaky timeouts: http/tests/misc/async-script.html:

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::~ScriptRunner):
(WebCore::ScriptRunner::queueScriptForExecution):
(WebCore::ScriptRunner::notifyScriptReady):

  • dom/ScriptRunner.h:

(WebCore::ScriptRunner::hasPendingScripts):

LayoutTests:

  • http/tests/misc/async-script.html:
  • platform/qt/Skipped: unskip http/tests/misc/async-script.html
1:23 AM Changeset in webkit [105040] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

Reland chromium event dispatch test from ​https://bugs.webkit.org/show_bug.cgi?id=72988
​https://bugs.webkit.org/show_bug.cgi?id=73837

The original patch had a mistake that caused it to fail (not sure how I
missed that or why the bots didn't catch it).

Patch by Dave Michael <​dmichael@chromium.org> on 2012-01-16
Reviewed by Hajime Morita.

  • WebKit.gypi:
  • tests/DispatchEventTest.cpp: Added.

(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::DispatchEventTest::createMessageEvent):
(WebKit::TEST_F):

  • tests/data/event_target.html: Added.
1:16 AM Changeset in webkit [105039] by reni@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; added WebCore.exp.in changes lost in r105036.

  • WebCore.exp.in:
12:47 AM Changeset in webkit [105038] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

ScriptRunner should also keep references to pending async scripts
​https://bugs.webkit.org/show_bug.cgi?id=76350

  • platform/qt/Skipped: Skip http/tests/misc/async-script.html until fix.
12:42 AM Changeset in webkit [105037] by yuqiang.xian@intel.com
  • 6 edits in trunk/Source/JavaScriptCore

Build fix on 32bit if verbose debug is enabled in DFG
​https://bugs.webkit.org/show_bug.cgi?id=76351

Reviewed by Hajime Morita.

Mostly change "%lu" to "%zu" to print a "size_t" variable.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

Jan 15, 2012:

11:33 PM Changeset in webkit [105036] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Add DeviceOrientationEvent.absolute
​https://bugs.webkit.org/show_bug.cgi?id=51742

Patch by Xinchao He <​xinchao.he@intel.com> on 2012-01-15
Reviewed by Darin Fisher.

This patch add the DeviceOrientationEvent.absolute to follow the
latest w3c device orientation event spec.
​http://www.w3.org/TR/orientation-event/

Source/WebCore:

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • dom/DeviceOrientation.cpp:

(WebCore::DeviceOrientation::create):
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::absolute):
(WebCore::DeviceOrientation::canProvideAbsolute):

  • dom/DeviceOrientation.h:
  • dom/DeviceOrientationEvent.idl:

Source/WebKit/chromium:

  • public/WebDeviceOrientation.h:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):

  • src/WebDeviceOrientation.cpp:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
(WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):

8:03 PM Changeset in webkit [105035] by fpizlo@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
​https://bugs.webkit.org/show_bug.cgi?id=76355

Reviewed by Dan Bernstein.

Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers. This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions. I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has. Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code). Each of these except for JITCompiler can be reused for stub compilation.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGCCallHelpers.h: Added.

(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

4:57 PM Changeset in webkit [105034] by kling@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix wrong bug URL in ChangeLog.

3:18 PM Changeset in webkit [105033] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove external references to CSSPrimitiveValue::UnitTypes enum.
​https://bugs.webkit.org/show_bug.cgi?id=76229

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::isCacheable):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isUnitTypeLength):
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isIdent):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isString):
(WebCore::CSSPrimitiveValue::isURI):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

3:08 PM BuildBot edited by gulendekorasyon@gmail.com
(diff)
3:07 PM WikiStart edited by gulendekorasyon@gmail.com
(diff)
3:06 PM UsingGitWithWebKit edited by gulendekorasyon@gmail.com
(diff)
3:02 PM WikiStart edited by gulendekorasyon@gmail.com
(diff)
12:14 PM Changeset in webkit [105032] by commit-queue@webkit.org
  • 11 edits in trunk

Fix compilation errors on build-webkit --debug --no-video on mac.
​https://bugs.webkit.org/show_bug.cgi?id=75867

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-15
Reviewed by Philippe Normand.

Source/JavaScriptCore:

Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.

  • wtf/Platform.h:

Source/WebCore:

  • Some exported HTMLMediaElement symbols were guarded by FULLSCREEN_API feature instead of VIDEO.
  • Unused parameter warning in CanvasRenderingContext::wouldTaintOrigin().
  • RenderThemeMac::shouldShowPlaceholderWhenFocused() implementation wrongly guarded by VIDEO feature.
  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • rendering/RenderThemeMac.mm:

Source/WebKit/mac:

  • WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded by VIDEO feature instead of FULLSCREEN_API.
  • _isAnyMoviePlaying implementation depends on VIDEO.
  • WebCoreSupport/WebChromeClient.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _isAnyMoviePlaying]):

Tools:

Add --[no-]video-track to build-webkit, since video track feature
depends on video.

  • Scripts/build-webkit:
11:42 AM Changeset in webkit [105031] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParser: Fix failing assertion below BorderImageQuadParseContext.
<​http://webkit.org/b/76343> and <rdar://problem/10584969>

Reviewed by Antti Koivisto.

No longer asserts: fast/borders/inline-mask-overlay-image-outset-vertical-rl.html

  • css/CSSParser.cpp:

(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):

Clone CSSValues by copying the RefPtrs instead of going through
the CSSValuePool's create-from-double factory. This prevents an
assertion when the incoming value is CSSValueAuto.

11:01 AM WikiStart edited by robert@roberthogan.net
(diff)
9:17 AM Changeset in webkit [105030] by robert@webkit.org
  • 6 edits
    2 adds in trunk

<embed> width and height properties propagate to parent object node
​https://bugs.webkit.org/show_bug.cgi?id=17688

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html

WebKit seems to have inherited this behaviour from KHTML. When the width/height
of an <embed> element is set, it propagates the values up to any parent <object>
element. There doesn't seem to be any good reason for this and it is not consistent
with the behaviour of Firefox and Opera.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::attributeChanged): Removed

  • html/HTMLEmbedElement.h:

(WebCore::HTMLEmbedElement::attributeChanged): Removed

LayoutTests:

  • fast/dom/insertedIntoDocument-child-expected.txt:
  • fast/dom/insertedIntoDocument-sibling-expected.txt: These tests were added by ​http://trac.webkit.org/changeset/81611. The fact that an <embed> element inserted into the document no longer passes its height/width up to its parent object node seems to prevent the node getting removed by a simple garbage collection now so the <embed> added by the test is still there at the end, creating the trailing spaces. This is consistent with Opera's treatment of the test, FF is entirely different - it doesn't add the embed node in the first place. So given that the purpose of the test is to cause a crash (?), the change in result seems benign.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt: Added.
  • fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html: Added. This tests that the width/height for an embed element does not get propagated to the parent object.
6:20 AM WikiStart edited by gulendekorasyon@gmail.com
(diff)
5:48 AM Changeset in webkit [105029] by robert@webkit.org
  • 5 edits in trunk/Source/WebCore

compareBorders() is called too often during painting
​https://bugs.webkit.org/show_bug.cgi?id=73349

Reviewed by Julien Chaffraix.

Collapsed borders are re-calculated every time they are painted.
This is unnecessary, they only change with the layout or style so calculate and
cache them whenever the layout or style changes and use the cached values when
painting. The cache is stored in the table section so that the memory footprint
of a table is only increased when it has collapsing borders.

The gain in performance here consists of skipping collapsed border computation
during painting. The only path that incurs a small performance penalty is the
additional get/set on the cache when a collapsed border is computed. This penalty only applies
during style change, layout, or when the width of the table is calculated. The computed
border value is not stored in the cache when it has been calculated without its color
for borderHalfStart and co., so that code path is unaffected by this change.

No new tests, covered by existing collapsed border tests.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeDestroyed): remove entries from collapsed border cache
(WebCore::RenderTableCell::collapsedStartBorder):

Compute, and also cache if the full border including color was computed.

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder): ditto
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):

Inline the function since it is only called in paintCollapsedBorders and remove
includeColor as a parameter. Move the call to the table's style to the caller rather
than call it 4 times in a row. Use the cached border values directly.

(WebCore::RenderTableCell::cachedCollapsedRightBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedTopBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedBottomBorder): ditto
(WebCore::RenderTableCell::paintCollapsedBorders):

This function always uses the collapsed border cache now.

  • rendering/RenderTableCell.h: Make the collapsed border functions private.
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::removeCachedCollapsedBorders): The cache is deleted by the HashMap

since it is the only owner of the cached item.

(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

This will assert if there is no cached collapsed border for the side of the
cell requested by the caller.

  • rendering/RenderTableSection.h: HashMap wouldn't let me use CollapsedBorderSide in the key value for the cache so use int instead.

Jan 14, 2012:

7:14 PM Changeset in webkit [105028] by levin@chromium.org
  • 8 edits
    1 move in trunk/Source

HWndDC should be in platform/win instead of wtf.
​https://bugs.webkit.org/show_bug.cgi?id=76314

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

No new functionality, so no new tests.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.

I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

5:24 PM Changeset in webkit [105027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=76339

Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.

Patch by Adam Treat <​atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.

  • platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::initializeLoggingChannelsIfNecessary):

4:31 PM Changeset in webkit [105026] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298

Reviewed by Anders Carlsson.

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.

3:53 PM Changeset in webkit [105025] by robert@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Chromium results for test added by r105021

Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
12:46 PM Changeset in webkit [105024] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Change expected failures from IMAGE+TEXT to TEXT on Mac.

The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.

Unreviewed gardening.

  • platform/mac/test_expectations.txt:
12:31 PM Changeset in webkit [105023] by robert@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove reference result added in r105021.

This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.

Unreviewed.

  • css2.1/20110323/outline-color-applies-to-008-expected.html: Removed.
11:28 AM Changeset in webkit [105022] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
​https://bugs.webkit.org/show_bug.cgi?id=76313

Patch by James Robinson <​jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.

The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.

  • Scripts/run-chromium-webkit-unit-tests:
11:13 AM Changeset in webkit [105021] by robert@webkit.org
  • 5 edits
    30 adds in trunk

CSS 2.1 failure: outline-color-applies-to* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=71944

Reviewed by Julien Chaffraix.

Source/WebCore:

Paint the outline color for row, row-group, header-group and footer-group
elements.

Tests: css2.1/20110323/outline-color-applies-to-001.htm

css2.1/20110323/outline-color-applies-to-002.htm
css2.1/20110323/outline-color-applies-to-003.htm
css2.1/20110323/outline-color-applies-to-004.htm
css2.1/20110323/outline-color-applies-to-005.htm
css2.1/20110323/outline-color-applies-to-006.htm
css2.1/20110323/outline-color-applies-to-007.htm
css2.1/20110323/outline-color-applies-to-008.htm
css2.1/20110323/outline-color-applies-to-009.htm
css2.1/20110323/outline-color-applies-to-010.htm
(There is no outline-color-applies-to-011.htm in the test suite.)
css2.1/20110323/outline-color-applies-to-012.htm
css2.1/20110323/outline-color-applies-to-013.htm
css2.1/20110323/outline-color-applies-to-014.htm
css2.1/20110323/outline-color-applies-to-015.htm
fast/css/outline-color-self-painting-row.htm

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.

This is used by RenderTableSection::paintObject and RenderTableRow::paint

(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by

fast/css/outline-color-self-painting-row.htm.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.

LayoutTests:

  • css2.1/20110323/outline-color-applies-to-001-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-001.htm: Added.
  • css2.1/20110323/outline-color-applies-to-002-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-002.htm: Added.
  • css2.1/20110323/outline-color-applies-to-003-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-003.htm: Added.
  • css2.1/20110323/outline-color-applies-to-004-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-004.htm: Added.
  • css2.1/20110323/outline-color-applies-to-005-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-005.htm: Added.
  • css2.1/20110323/outline-color-applies-to-006-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-006.htm: Added.
  • css2.1/20110323/outline-color-applies-to-007-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-007.htm: Added.
  • css2.1/20110323/outline-color-applies-to-008-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-008.htm: Added.
  • css2.1/20110323/outline-color-applies-to-009-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-009.htm: Added.
  • css2.1/20110323/outline-color-applies-to-010-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-010.htm: Added.
  • css2.1/20110323/outline-color-applies-to-012-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-012.htm: Added.
  • css2.1/20110323/outline-color-applies-to-013-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-013.htm: Added.
  • css2.1/20110323/outline-color-applies-to-014-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-014.htm: Added.
  • css2.1/20110323/outline-color-applies-to-015-expected.html: Added.
  • css2.1/20110323/outline-color-applies-to-015.htm: Added.
  • fast/css/outline-color-self-painting-row-expected.html: Added.
  • fast/css/outline-color-self-painting-row.htm: Added.
11:11 AM Changeset in webkit [105020] by dslomov@google.com
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove WebKit::WebWorker class.
​https://bugs.webkit.org/show_bug.cgi?id=76327

Reviewed by Darin Fisher.

  • public/WebWorker.h: Removed.
  • src/WebWorkerClientImpl.cpp:
7:51 AM Changeset in webkit [105019] by Simon Fraser
  • 3 edits
    2 adds in trunk

Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
​https://bugs.webkit.org/show_bug.cgi?id=76329

Source/WebCore:

Reviewed by Dan Bernstein.

When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Reviewed by Dan Bernstein.

Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.

  • ManualTests/filters/opacity-above-filter.html: Added.
5:43 AM Changeset in webkit [105018] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r105017.
​http://trac.webkit.org/changeset/105017
​https://bugs.webkit.org/show_bug.cgi?id=76333

broke the build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-14

  • gtk/jhbuild.modules:
5:23 AM Changeset in webkit [105017] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include gtk+3 in the jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.

Jan 13, 2012:

8:41 PM Changeset in webkit [105016] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Skip test that started failing after r105015.

  • platform/qt/Skipped:
7:03 PM Changeset in webkit [105015] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
​https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
6:47 PM Changeset in webkit [105014] by efidler@rim.com
  • 2 edits in trunk

GCC compiler version is not detected properly for QNX qcc variant
​https://bugs.webkit.org/show_bug.cgi?id=76288

Reviewed by Rob Buis.

Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).

  • Source/cmake/WebKitHelpers.cmake:
5:13 PM Changeset in webkit [105013] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Build correction after r104919.

  • WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp from the build, since it is built as part of DOMAllInOne.cpp.
4:42 PM Changeset in webkit [105012] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

4:28 PM Changeset in webkit [105011] by scheib@chromium.org
  • 5 edits in trunk

Pointer Lock: Change isLocked() from operator to attribute isLocked
​https://bugs.webkit.org/show_bug.cgi?id=76311

Reviewed by Adam Barth.

Source/WebCore:

This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.

Test pointer-lock/pointer-lock-api.html updated to new spec.

  • page/PointerLock.idl:

LayoutTests:

  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
4:25 PM Changeset in webkit [105010] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.5

New tag.

4:13 PM Changeset in webkit [105009] by jochen@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
​https://bugs.webkit.org/show_bug.cgi?id=57600

Reviewed by Adam Barth.

  • http/tests/security/resources/cors-redirect.php: Added.
  • http/tests/security/resources/empty.html: Added.
  • http/tests/security/xhr-cors-redirect-expected.txt: Added.
  • http/tests/security/xhr-cors-redirect.html: Added.
4:08 PM Changeset in webkit [105008] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Delay updating the root compositing layer if the layer tree state is frozen
​https://bugs.webkit.org/show_bug.cgi?id=76316

Reviewed by Dan Bernstein.

When the layer tree is frozen, stash the root layer in m_pendingRootCompositingLayer and set it in flushLayers.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

4:01 PM Changeset in webkit [105007] by commit-queue@webkit.org
  • 5 edits in trunk

noteOn, noteGrainOn and noteOff idl should take doubles
​https://bugs.webkit.org/show_bug.cgi?id=76073

Patch by Raymond Toy <Raymond Toy> on 2012-01-13
Reviewed by Adam Barth.

Source/WebCore:

Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.

  • webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and

noteOff take doubles.

LayoutTests:

  • webaudio/audiobuffersource-playbackrate-expected.wav: Updated
  • webaudio/gain-expected.wav: Updated
3:58 PM Changeset in webkit [105006] by Beth Dakin
  • 10 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=71230
Clicking where the overlay scroll track would be should not scroll the page
-and corresponding-
<rdar://problem/9585424>

Reviewed by Alexey Proskuryakov.

These new functions indicate whether the scrollbar should participate in hit
testing. Non-overlay scrollbars always should, so they return true. Overlay
scrollbars consult the animator, which checks the current alpha.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::shouldScrollbarParticipateInHitTesting):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar:: shouldParticipateInHitTesting):

  • platform/Scrollbar.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac:: shouldScrollbarParticipateInHitTesting):

In these hit-testing functions, only hit-test when the scrollbar should
participate.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarAtPoint):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestOverflowControls):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):

3:56 PM Changeset in webkit [105005] by mitz@apple.com
  • 5 edits in trunk

REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
​https://bugs.webkit.org/show_bug.cgi?id=76254

Reviewed by Anders Carlsson.

Source/WebCore:

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.

LayoutTests:

  • svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.

Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.

  • svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
3:52 PM Changeset in webkit [105004] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

WebAudio: Optimize calculateNormalizationScale().
​https://bugs.webkit.org/show_bug.cgi?id=74372

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale): Replace implementation with optimized vector

math operation.

(WebCore::Reverb::Reverb):

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsvesq): Vector math operation for squared sum of elements.

  • platform/audio/VectorMath.h:
3:40 PM Changeset in webkit [105003] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a unused variable.
​https://bugs.webkit.org/show_bug.cgi?id=76307

Reviewed by James Robinson.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

3:39 PM Changeset in webkit [105002] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r104352.

3:35 PM Changeset in webkit [105001] by abarth@webkit.org
  • 2 edits in trunk/Tools

Remove --dry-run support from webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

This is the rest of the patch from Bug 76300. I landed it separtely
because main.py had some stray conflict markers that I needed to clean
up first.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester._run_tests):

3:32 PM Changeset in webkit [105000] by Nate Chapin
  • 4 edits in trunk

Source/WebCore: Revert most of the multipart changes in
​http://trac.webkit.org/changeset/104756.
​https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

http/tests/multipart/invalid-image-data.html
should stop asserting on chromium win dbg.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

LayoutTests: http/tests/multipart/invalid-image-data.html should no longer
be crashing on chromium win dbg.
​https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [104999] by abarth@webkit.org
  • 2 edits in trunk/Tools

test-webkitpy does not run
​https://bugs.webkit.org/show_bug.cgi?id=76318

Unreviewed.

Looks like some conflict markers got left in the file.

  • Scripts/webkitpy/test/main.py:

(Tester.run):

3:28 PM Changeset in webkit [104998] by abarth@webkit.org
  • 7 edits in trunk/Tools

Remove --dry-run support from webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

We don't use this functionality for anything, and it doesn't really
work. Someone in #webkit tried using it and and got sad/confused. We
should just remove it.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.init):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(_shared_test_commit_with_message):
(GitSVNTest.test_commit_text_parsing):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.commit_with_message):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.init):
(Bugzilla.quips):
(Bugzilla.authenticate):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

3:16 PM Changeset in webkit [104997] by Lucas Forschler
  • 14 edits in branches/safari-534.54-branch

Merged r104269.

3:13 PM Changeset in webkit [104996] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.54-branch

Merged r104239.

2:58 PM Changeset in webkit [104995] by levin@chromium.org
  • 5 edits in trunk

check-webkit-style: should encourage the use of Own* classes for Windows DC.
​https://bugs.webkit.org/show_bug.cgi?id=76227

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

  • wtf/win/HWndDCWin.h:

(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.

Tools:

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_leaky_patterns): The new check.
(process_line): Added a call to the new check.
(CppChecker): Added the new error type.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase):
(CppStyleTestBase.perform_leaky_pattern_check):
The check for only leaky pattern errors.
(LeakyPatternTest): Test cases.

2:52 PM Changeset in webkit [104994] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:42 PM Changeset in webkit [104993] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

WebAudio: Use float instead of double values for gain operations.
​https://bugs.webkit.org/show_bug.cgi?id=74345

Reviewed by Sam Weinig.

No new tests; optimization of existing code, so covered by existing test cases.

The following functions now take or operate on floats instead of doubles:
(WebCore::AudioBus::scale):
(WebCore::AudioBus::processWithGainFrom):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::sumWithGainFrom):

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::setGain):
(WebCore::AudioBus::gain):

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale):

  • platform/audio/AudioChannel.h:
  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

  • webaudio/AudioBufferSourceNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
2:42 PM Changeset in webkit [104992] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104119.

2:38 PM Changeset in webkit [104991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't use pending activity notification in IntentRequest
​https://bugs.webkit.org/show_bug.cgi?id=76302

Patch by Greg Billock <​gbillock@google.com> on 2012-01-13
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

2:34 PM Changeset in webkit [104990] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r104094.

2:29 PM Changeset in webkit [104989] by Lucas Forschler
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r104086.

2:20 PM Changeset in webkit [104988] by Lucas Forschler
  • 3 edits
    12 copies in branches/safari-534.54-branch

Merged r103981.

2:18 PM Changeset in webkit [104987] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

EQUALPOWER panner incorrectly computes gain
​https://bugs.webkit.org/show_bug.cgi?id=75767

Source/WebCore:

Patch by Raymond Toy <Raymond Toy> on 2012-01-13
Reviewed by Kenneth Russell.

Layout test added.

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan): Correct the formula.

LayoutTests:

Patch by Raymond Toy <​rtoy@chromium.org> on 2012-01-13
Reviewed by Kenneth Russell.

  • webaudio/panner-equalpower.html: Added.
  • webaudio/panner-equalpower-expected.txt: Added.
  • webaudio/resources/panner-model-testing.js: Added.
  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): New common utility function.

2:15 PM Changeset in webkit [104986] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Implement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
​https://bugs.webkit.org/show_bug.cgi?id=76308

Reviewed by Sam Weinig.

Keep track of whether the layer tree state is frozen and suspend/resume the layer flush scheduler accordingly.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::layerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

2:00 PM Changeset in webkit [104985] by ojan@chromium.org
  • 26 edits in trunk

Unreviewed, rolling out r104972.
​http://trac.webkit.org/changeset/104972
​https://bugs.webkit.org/show_bug.cgi?id=75782

Broke some tests

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
1:39 PM Changeset in webkit [104984] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Rollout 99999 (104249).

1:38 PM Changeset in webkit [104983] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable implicit animations when setting the root compositing layer
​https://bugs.webkit.org/show_bug.cgi?id=76304

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

1:31 PM Changeset in webkit [104982] by dpranke@chromium.org
  • 1 edit in trunk/Tools/ChangeLog

fix changelog

1:24 PM Changeset in webkit [104981] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source

Unreviewed build fix for Qt SnowLeopard build bot.

This is a workaround for the moment.

  • wtf/Platform.h:
1:23 PM Changeset in webkit [104980] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
​https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

1:23 PM Changeset in webkit [104979] by eae@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore

Windows build fixes for WebCore.

1:20 PM Changeset in webkit [104978] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
​https://bugs.webkit.org/show_bug.cgi?id=76299

Reviewed by Simon Fraser.

Override -[WebTileCacheLayer setNeedsDisplay] and call TileCache::setNeedsDisplay from there,
instead of ending up with a huge rectangle in TileCache::setNeedsDisplayInRect which causes our
tile computation logic to fail due to integer overflow when converting from CGFloats to ints.

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setNeedsDisplay]):

1:16 PM Changeset in webkit [104977] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: should support classes and individual test names as well as modules
​https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

% test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

% test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

% test-wekbitpy webkitpy.test.cat_unittest

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/cat_unittest.py:
  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

1:16 PM Changeset in webkit [104976] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Header file is missing header guard.

Reviewed by Dirk Pranke.

  • wtf/win/HWndDCWin.h: Added the guards.
12:59 PM Changeset in webkit [104975] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy: add basic code coverage support
​https://bugs.webkit.org/show_bug.cgi?id=76201

Reviewed by Adam Barth.

This test adds basic code coverage support to test-webkitpy; if
you pass the -c flag, we will generate a new coverage file. We
can start simply with this and add more features as necessary.

This patch requires coverage to be already installed on the
machine. I am not auto-installing this for now.

  • Scripts/webkitpy/test/main.py:

(Tester.parse_args):
(Tester.run_tests):

12:54 PM Changeset in webkit [104974] by dpranke@chromium.org
  • 2 edits in trunk/Tools

StatusBubbleTest.test_build_bubble is failing
​https://bugs.webkit.org/show_bug.cgi?id=76222

Reviewed by Adam Barth.

  • QueueStatusServer/handlers/statusbubble_unittest.py:

(StatusBubbleTest.test_build_bubble):

12:53 PM Changeset in webkit [104973] by Simon Fraser
  • 1 edit
    21 adds in trunk/LayoutTests

Add new baselines for various compositing tests which didn't have Mac results.

  • platform/mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/mac/compositing/animation/busy-indicator-expected.txt: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/mac/compositing/flat-with-transformed-child-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/mac/compositing/repaint/same-size-invalidation-expected.txt: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/mac/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
12:43 PM Changeset in webkit [104972] by ojan@chromium.org
  • 26 edits in trunk

Implement flex-align
​https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Not 100% sure about this, but I think the computed value of
flex-item-align needs to take the parent's flex-align into
account for computed auto values.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::flexAlign):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):

  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/flex-align-expected.txt:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/script-tests/css-properties.js:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:34 PM Changeset in webkit [104971] by jamesr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Update chromium image baselines for cross-fade-invalidation

  • platform/chromium-linux/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-invalidation-expected.png: Added.
12:31 PM Changeset in webkit [104970] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Eval in strict mode does not need dynamic checks
​https://bugs.webkit.org/show_bug.cgi?id=76286

Patch by Andy Wingo <​wingo@igalia.com> on 2012-01-13
Reviewed by Oliver Hunt.

  • runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):

Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.

12:13 PM Changeset in webkit [104969] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

Patch by Simon Fraser <Simon Fraser> on 2012-01-13

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:59 AM Changeset in webkit [104968] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix an obviously incorrect expected result image.

  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
11:55 AM Changeset in webkit [104967] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/Tools

nrwt should use multiple http shards
​https://bugs.webkit.org/show_bug.cgi?id=75958

Add --max-locked-shards option to the nrwt for manual set
the maximum number of the locked shards

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._max_locked_shards):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ShardingTests.get_shards):
(ShardingTests.test_multiple_locked_shards):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:45 AM Changeset in webkit [104966] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Rename GraphicsContext* argument in various RenderLayer methods
​https://bugs.webkit.org/show_bug.cgi?id=76283

Reviewed by James Robinson/Anders Carlsson.

Rename the GraphicsContext* parameter "p" in various RenderLayer
methods to "context". "p" was a historical name from when it was
called Painter.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):

11:42 AM Changeset in webkit [104965] by mihnea@adobe.com
  • 14 edits in trunk/Source/WebCore

[CSSRegions]Add back region style code removed in r104036
​https://bugs.webkit.org/show_bug.cgi?id=76064

Reviewed by David Hyatt.

No new tests. The region style tests are still skipped. A follow up patch will enable
both region style for background-color and region style tests.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::useInRegionStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleInRegion):

  • rendering/RenderObject.h:

(WebCore::RenderObject::canHaveRegionStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

11:42 AM Changeset in webkit [104964] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch

Merged r103728.

11:41 AM Changeset in webkit [104963] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; added project.pbxproj changes lost in r104954.
​https://bugs.webkit.org/show_bug.cgi?id=75906

  • WebCore.xcodeproj/project.pbxproj:
11:40 AM Changeset in webkit [104962] by Lucas Forschler
  • 7 edits
    6 copies in branches/safari-534.54-branch

Merge 103637.

11:26 AM Changeset in webkit [104961] by jocelyn.turcotte@nokia.com
  • 8 edits
    2 adds in trunk/Source

TextureMapper: Extract layer transform logic to a LayerTransform class.
​https://bugs.webkit.org/show_bug.cgi?id=76291

Reviewed by Noam Rosenthal.

Source/WebCore:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/LayerTransform.cpp: Added.

(WebCore::LayerTransform::LayerTransform):
(WebCore::LayerTransform::setPosition):
(WebCore::LayerTransform::setSize):
(WebCore::LayerTransform::setAnchorPoint):
(WebCore::LayerTransform::setFlattening):
(WebCore::LayerTransform::setLocalTransform):
(WebCore::LayerTransform::setChildrenTransform):
(WebCore::LayerTransform::combined):
(WebCore::LayerTransform::combinedForChildren):
(WebCore::LayerTransform::combineTransforms):
(WebCore::LayerTransform::combineTransformsForChildren):

  • platform/graphics/texmap/LayerTransform.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::compareGraphicsLayersZValue):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::TextureMapperNode):

Source/WebKit2:

Move the paint call before the visible rect collection to make sure that
transforms are computed. This will increase the delay for the visible rects
to get to the WebProcess until we move this calculation out of the UI Process.
This fixes an assert triggering in LayerTransform::combineTransforms.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):

11:24 AM Changeset in webkit [104960] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] SecurityPolicy whitelist interface should be exposed to EWebKit
​https://bugs.webkit.org/show_bug.cgi?id=76082

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2012-01-13
Reviewed by Andreas Kling.

  • CMakeListsEfl.txt: Added reference to ewk_security_policy.{cpp,h}.
  • ewk/EWebKit.h: Include ewk_security_policy.h.
  • ewk/ewk_security_policy.cpp: Added.

(ewk_security_policy_whitelist_origin_add): Implemented thin layer around SecurityPolicy::addOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_del): Implemented thin layer around SecurityPolicy::removeOriginAccessWhitelistEntry().
(ewk_security_policy_whitelist_origin_reset): Implemented thin layer around SecurityPolicy::resetOriginAccessWhitelists().

  • ewk/ewk_security_policy.h: Added.
11:19 AM Changeset in webkit [104959] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix for unused argument warning after r104954.
​https://bugs.webkit.org/show_bug.cgi?id=75906

Also fixed up somebody's bad merge in Source/WebCore/ChangeLog.

  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):

11:19 AM Changeset in webkit [104958] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build correction.

  • Shared/WebGraphicsContext.h: Use proper include path for RefPtrCairo.h.
11:15 AM Changeset in webkit [104957] by jamesr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Update expectations

  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:06 AM Changeset in webkit [104956] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update a few expectations

  • platform/chromium/test_expectations.txt:
11:05 AM Changeset in webkit [104955] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

prepare-ChangeLog: Look for a text editor in a few more variables.
​https://bugs.webkit.org/show_bug.cgi?id=76289

Reviewed by Ryosuke Niwa.

A text editor was looked for only in the CHANGE_LOG_EDITOR and
CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
to the OS X-specific open(1) command.

As there does not seem to be a common way of looking for a text editor
among the scripts in Tools/Scripts right now, just look at $VISUAL and
$EDITOR (set much more often than the other variables in Unix systems)
before falling back to open(1).

  • Scripts/prepare-ChangeLog:

(openChangeLogs):

11:02 AM Changeset in webkit [104954] by commit-queue@webkit.org
  • 24 edits
    5 copies
    1 add in trunk

Add WebGLContextGroup as step toward sharing WebGL resources
​https://bugs.webkit.org/show_bug.cgi?id=75906

The WebGL Working Group will soon add the ability to share
WebGL resources among WebGL contexts. This is the necessary
prep work. NO API changes.

Added WebGLSharedObject for objects that are shared vs
WebGLContextObject for objects that are not.

Patch by Gregg Tavares <​gman@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

No new tests. No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::WebGLBuffer):
(WebCore::WebGLBuffer::~WebGLBuffer):
(WebCore::WebGLBuffer::deleteObjectImpl):

  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLContextGroup.cpp: Added.

(WebCore::WebGLContextGroup::create):
(WebCore::WebGLContextGroup::WebGLContextGroup):
(WebCore::WebGLContextGroup::~WebGLContextGroup):
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::removeObject):
(WebCore::WebGLContextGroup::addObject):
(WebCore::WebGLContextGroup::detachAndRemoveAllObjects):
(WebCore::WebGLContextGroup::loseContextGroup):

  • html/canvas/WebGLContextGroup.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.
  • html/canvas/WebGLContextObject.cpp: Copied from Source/WebCore/html/canvas/WebGLShader.cpp.

(WebCore::WebGLContextObject::WebGLContextObject):
(WebCore::WebGLContextObject::~WebGLContextObject):
(WebCore::WebGLContextObject::detachContext):
(WebCore::WebGLContextObject::getAGraphicsContext3D):

  • html/canvas/WebGLContextObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLContextObject::context):
(WebCore::WebGLContextObject::validate):
(WebCore::WebGLContextObject::hasGroupOrContext):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::~WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLObject.cpp:

(WebCore::WebGLObject::WebGLObject):
(WebCore::WebGLObject::~WebGLObject):
(WebCore::WebGLObject::deleteObject):
(WebCore::WebGLObject::detach):
(WebCore::WebGLObject::onDetached):

  • html/canvas/WebGLObject.h:
  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::~WebGLProgram):
(WebCore::WebGLProgram::deleteObjectImpl):
(WebCore::WebGLProgram::cacheActiveAttribLocations):

  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderbuffer.cpp:

(WebCore::WebGLRenderbuffer::~WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
(WebCore::WebGLRenderbuffer::deleteObjectImpl):

  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::checkObjectToBeBound):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createBuffer):
(WebCore::WebGLRenderingContext::createFramebuffer):
(WebCore::WebGLRenderingContext::createTexture):
(WebCore::WebGLRenderingContext::createProgram):
(WebCore::WebGLRenderingContext::createRenderbuffer):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteObject):
(WebCore::WebGLRenderingContext::deleteRenderbuffer):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateWebGLObject):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::removeSharedObject):
(WebCore::WebGLRenderingContext::addSharedObject):
(WebCore::WebGLRenderingContext::removeContextObject):
(WebCore::WebGLRenderingContext::addContextObject):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::loseContextImpl):

  • html/canvas/WebGLRenderingContext.h:

(WebCore::WebGLRenderingContext::contextGroup):

  • html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::WebGLShader):
(WebCore::WebGLShader::~WebGLShader):
(WebCore::WebGLShader::deleteObjectImpl):

  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLSharedObject.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderbuffer.cpp.

(WebCore::WebGLSharedObject::WebGLSharedObject):
(WebCore::WebGLSharedObject::~WebGLSharedObject):
(WebCore::WebGLSharedObject::detachContextGroup):
(WebCore::WebGLSharedObject::getAGraphicsContext3D):

  • html/canvas/WebGLSharedObject.h: Copied from Source/WebCore/html/canvas/WebGLShader.h.

(WebCore::WebGLSharedObject::contextGroup):
(WebCore::WebGLSharedObject::isBuffer):
(WebCore::WebGLSharedObject::isFramebuffer):
(WebCore::WebGLSharedObject::isProgram):
(WebCore::WebGLSharedObject::isRenderbuffer):
(WebCore::WebGLSharedObject::isShader):
(WebCore::WebGLSharedObject::isTexture):
(WebCore::WebGLSharedObject::validate):
(WebCore::WebGLSharedObject::hasGroupOrContext):

  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::~WebGLTexture):
(WebCore::WebGLTexture::deleteObjectImpl):

  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):

  • html/canvas/WebGLVertexArrayObjectOES.h:
10:43 AM Changeset in webkit [104953] by Lucas Forschler
  • 5 edits
    6 copies in branches/safari-534.54-branch

Merged r103636.

10:40 AM Changeset in webkit [104952] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-534.54-branch

Merged r103594.

10:37 AM Changeset in webkit [104951] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r103587.

10:35 AM Changeset in webkit [104950] by Lucas Forschler
  • 6 edits
    3 copies in branches/safari-534.54-branch

Merged r103482.

10:26 AM Changeset in webkit [104949] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r103286.

10:05 AM Changeset in webkit [104948] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebCore

[soup] Initialize m_soupFlags in all ResourceResponse constructors.

Rubber-stamped by Gustavo Noronha Silva.

m_soupFlags was being initialized in two of the three ResourceResponse
constructors, causing some trouble in
FrameLoaderClient::dispatchDidReceiveResponse (ports which use
ResourceRequest::setSoupMessageFlags with the response's unitialized
flags).

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

9:58 AM Changeset in webkit [104947] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

CFURLRef to KURL conversion shouldn't turn raw paths into file URLs
​https://bugs.webkit.org/show_bug.cgi?id=76251

Reviewed by Dan Bernstein.

  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Removed the offending code.
9:51 AM Changeset in webkit [104946] by levin@chromium.org
  • 5 edits
    1 move in trunk/Source

HWndDC is a better name than HwndDC.
​https://bugs.webkit.org/show_bug.cgi?id=76281

Reviewed by Darin Adler.

Source/JavaScriptCore:

(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

9:43 AM Changeset in webkit [104945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Disconnecting the front-end does not disable profiling.
​https://bugs.webkit.org/show_bug.cgi?id=76213

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-01-13
Reviewed by Pavel Feldman.

Not testable.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::clearFrontend):

9:41 AM Changeset in webkit [104944] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark a flaky test as flaky

  • platform/chromium/test_expectations.txt:
9:41 AM Changeset in webkit [104943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix missing signal in qwebframe API test for Qt5
​https://bugs.webkit.org/show_bug.cgi?id=76195

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-01-13
Reviewed by Noam Rosenthal.

In Qt5 QObject has a new signal with this signature: "objectNameChanged(QString)".

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::enumerate_data):

9:04 AM Changeset in webkit [104942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
​https://bugs.webkit.org/show_bug.cgi?id=76269

Reviewed by Martin Robinson.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

8:35 AM Changeset in webkit [104941] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().
<​http://webkit.org/b/76271>

Reviewed by Darin Adler.

Use JSC::Weak::swap() to move JSDOMWrappers into the DOMWrapperWorld's wrapper map.
This avoids invoking the JSC::Weak copy constructor and associated HandleHeap churn.

  • bindings/js/JSDOMBinding.h:

(WebCore::cacheWrapper):

8:28 AM Changeset in webkit [104940] by vsevik@chromium.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
​https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:20 AM Changeset in webkit [104939] by kling@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Test that cloneNode() doesn't cause crashes when used directly after stylesheet mutation.
<​http://webkit.org/b/75987>

Reviewed by Antti Koivisto.

  • fast/css/cloneNode-after-deleteRule-crash-expected.txt: Added.
  • fast/css/cloneNode-after-deleteRule-crash.html: Added.
  • fast/css/resources/cloneNode-after-deleteRule-subdocument.html: Added.
8:03 AM Changeset in webkit [104938] by vsevik@chromium.org
  • 12 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r104935.
​http://trac.webkit.org/changeset/104935
​https://bugs.webkit.org/show_bug.cgi?id=76277

Breaks AppleWin compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-13

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Removed.
  • inspector/InspectorIndexedDBAgent.h: Removed.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Removed.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
7:49 AM Changeset in webkit [104937] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove extern "C" from ewk_private.h
​https://bugs.webkit.org/show_bug.cgi?id=76250

Reviewed by Andreas Kling.

ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application.
So, extern "C" keyword is unneeded in ewk_private.h.

  • ewk/ewk_private.h:
7:44 AM Changeset in webkit [104936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] Add OwnPtr specialization for Eina_Module.
​https://bugs.webkit.org/show_bug.cgi?id=76255

Patch by YoungTaeck Song <​youngtaeck.song@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Add an overload for deleteOwnedPtr(Eina_Module*) on EFL port.

  • wtf/OwnPtrCommon.h:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):

7:08 AM Changeset in webkit [104935] by vsevik@chromium.org
  • 12 edits
    3 adds in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.
​https://bugs.webkit.org/show_bug.cgi?id=76264

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorIndexedDBAgent.cpp: Added.

(WebCore::InspectorIndexedDBAgent::FrontendProvider::create):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::frontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorIndexedDBAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::~InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::setFrontend):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h: Added.

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js: Added.
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get securityOrigin):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
7:04 AM Changeset in webkit [104934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build when using TextureMapper with OpenGL/ES
​https://bugs.webkit.org/show_bug.cgi?id=76268

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-01-13
Reviewed by Tor Arne Vestbø.

  • WebCore.pri: When the texture mapper uses OpenGL/ES, then it also relies on the

availability of libEGL by using eglGetCurrentContext(). In that case we need to link against
libEGL.

6:58 AM Changeset in webkit [104933] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Don't artifically keep IDBDatabase objects alive if there are no references to it.
​https://bugs.webkit.org/show_bug.cgi?id=75859

Originally, this code was added to keep the IDBDatabase object alive
even if no reference from JavaScript to the object existed, because
running transactions could still send events for this database
connection. Meanwhile, transactions are marked as active DOM objects
during their lifetime, and they keep a RefPtr to the IDBDatabase
object, so this hack is no longer required.

Reviewed by Tony Gentilcore.

Test: storage/indexeddb/delete-closed-database-object.html

  • storage/IDBDatabase.cpp:
  • storage/IDBDatabase.h:

LayoutTests: Test that an IDBDatabase object is garbage collected once no further references to it exist.
​https://bugs.webkit.org/show_bug.cgi?id=75859

Reviewed by Tony Gentilcore.

  • storage/indexeddb/delete-closed-database-object-expected.txt: Added.
  • storage/indexeddb/delete-closed-database-object.html: Added.
6:41 AM Changeset in webkit [104932] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Do the node transform computation when painting.
​https://bugs.webkit.org/show_bug.cgi?id=74721

Reviewed by Noam Rosenthal.

The transform of the node tree was built during the syncCompositingState
step. This would cause an ASSERT with QWebView, trying to use a dirty transform
state since the rootTextureMapperNode in QWebFramePrivate::renderCompositedLayers
doesn't run the sync step after getting the world transform set.

This moves the transform computation from the sync to the paint step to
prevent making sure that the sync step has been run on all nodes before painting.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::computeTiles):
Remove an unused variable.
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:
6:39 AM Changeset in webkit [104931] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebCore

TextureMapper: Simplify transform manipulations.
​https://bugs.webkit.org/show_bug.cgi?id=74719

Reviewed by Noam Rosenthal.

  • Make sure that the replica node has a complete transform and use it directly instead of keeping a copy in the source.
  • Apply the origin and position translation only once, on the target and descendants transforms.
  • Use to2dTransform() on !preserves3D layers instead of doing the flattening manually.
  • Remove mentions of perspective as this is handled by WebCore through the children transform.
  • Apply the inverse target transform on the replica only where it is needed in paintReflection since it uses the full transform in paintSelf.
  • Merge the base and local transforms.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsSelf):
(WebCore::TextureMapperNode::computeAllTransforms):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::paintReflection):

  • platform/graphics/texmap/TextureMapperNode.h:
6:38 AM Changeset in webkit [104930] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

TextureMapper: Fix the fillsForward transform adjustment in syncAnimations.
​https://bugs.webkit.org/show_bug.cgi?id=76184

Reviewed by Noam Rosenthal.

Also make the intention clearer by using setTransform and setOpacity.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncAnimations):

6:32 AM Changeset in webkit [104929] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectation for svg/dom/SVGPathSegList-segment-modification.svg on LEOPARD DEBUG.

  • platform/chromium/test_expectations.txt:
6:25 AM Changeset in webkit [104928] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector scripts navigator style fixes.

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-container-tabbed-pane .tabbed-pane-header-tab):

6:20 AM Changeset in webkit [104927] by jochen@chromium.org
  • 9 edits
    5 adds in trunk

Source/WebCore: Once we prepared a script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
​https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

This bug was caught by the following IE Test Center test:

​http://samples.msdn.microsoft.com/ietestcenter/HTML5/show_async_test.htm?11_RemovingAsyncScript

Test: http/tests/misc/async-script-removed.html

http/tests/misc/async-script.html

  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:

LayoutTests: Once we've prepared script element for execution, execute it, even if the script element was meanwhile removed from the dom tree.
​https://bugs.webkit.org/show_bug.cgi?id=76083

Reviewed by Adam Barth.

  • http/tests/misc/async-script-expected.txt: Added.
  • http/tests/misc/async-script-removed-expected.txt: Added.
  • http/tests/misc/async-script-removed.html: Added.
  • http/tests/misc/async-script.html: Added.
  • http/tests/misc/resources/delayed-log.php: Added.
6:18 AM Changeset in webkit [104926] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

Large SVG text layout performance regression in r81168
​https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Antti Koivisto.

Finish SVGTextMetricsBuilder introduction, tested in my local svg-text-performance branch.
SVGTextMetricsBuilder has two public methods:
a) SVGTextMetricsBuilder::measureTextRenderer(RenderSVGInlineText*)

It will be used exclusively for non-initial, incremental layout changes. Once the inital
text layout ran, any mutation of eg. a child text node of a <tspan>, will only trigger
a rebuild of the layout attributes associated with the passed in renderer.

b) SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes(RenderSVGText*, RenderSVGInlineText* stopAtLeaf, SVGCharacterDataMap& allCharactersMap)

stopAtLeaf=0:
This carries out the initial layout phase. It measures all characters of the whole <text> subtree, and stores the SVGTextMetrics for each character
in the SVGTextLayoutAttributes, stored in the RenderSVGInlineText object. It requires a SVGCharacterDataMap allCharactersMap as input argument,
which contains a HashMap<unsigned, {float x, y, dx, dy, rotate}>, which maps each character position to a set of x/y/dx/dy/rotate values.
The SVGCharacterDataMap living in SVGTextLayoutAttributes will be filled, from the global "allCharactersMap", so that each RenderSVGInlineText only
stores the positioning information for its children, if any.

Note: SVGTextMetricsBuilder is not yet deployed, so this talks about the design, once everything is landed.

stopAtLeaf!=0:
This is never used for the initial layout phase. If the initial layout is done, and eg. a <tspan> is added to the <text> subtree, we no longer
need to rebuild the metrics map & layout attributes for the whole tree, but only for the desired <tspan>, and its previous/next sibling, if present
(which may be affected by the inclusion of another node inbetween them).

SVGTextMetricsBuilder is now finished, and will be used in the next patch chunk.
Doesn't affect any tests yet.

  • rendering/svg/SVGTextLayoutAttributes.h:

(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::SVGCharacterData::SVGCharacterData):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::MeasureTextData::MeasureTextData):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.h:
6:10 AM Changeset in webkit [104925] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: Fixing Win builders.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):

6:01 AM Changeset in webkit [104924] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[EFL] Add 'Copy Image Address' to context menu.
​https://bugs.webkit.org/show_bug.cgi?id=76153

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2012-01-13
Reviewed by Andreas Kling.

Source/WebCore:

Enables 'Copy Image Address' option to context menu in WebKit-EFL as it is enabled in GTK and QT ports.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopyImageUrlToClipboard):

Source/WebKit/efl:

Adds EWK_CONTEXT_MENU_ITEM_TAG_COPY_IMAGE_URL_TO_CLIPBOARD to Ewk_Context_Menu_Action to synchronize it with ContextMenuItem.h

  • ewk/ewk_contextmenu.h:
5:48 AM Changeset in webkit [104923] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: 32bit build fix.

  • inspector/DOMEditor.cpp:
  • inspector/DOMEditor.h:
5:41 AM Changeset in webkit [104922] by mario@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rollout r104905.
​https://bugs.webkit.org/show_bug.cgi?id=76267

This patch broke tests in the GTK 64bit Debug bot.

Source/WebCore:

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

Source/WebKit/gtk:

  • tests/testatk.c:

(textCaretMovedCallback):
(testWebkitAtkCaretOffsets):
(textSelectionChangedCallback):
(testWebkitAtkTextSelections):

5:29 AM Changeset in webkit [104921] by apavlov@chromium.org
  • 1 edit
    4 moves
    7 adds
    4 deletes in trunk/LayoutTests

Unreviewed, rebaseline Chromium and optimize Qt/GTK baselines after r104917 using garden-o-matic.

  • platform/chromium-mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Renamed from LayoutTests/platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt.
5:24 AM Changeset in webkit [104920] by pfeldman@chromium.org
  • 7 edits
    3 adds in trunk

Web Inspector: make HTML editing preserve node identity when node nesting level changes.
​https://bugs.webkit.org/show_bug.cgi?id=76183

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-2.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchHTMLElement):
(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::createDigest):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::markNodeAsUsed):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt: Added.
  • inspector/elements/set-outer-html-2.html: Added.
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html-test.js: Added.

(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step1):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step2):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite.step3):
(initialize_SetOuterHTMLTest.InspectorTest.setUpTestSuite):
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML.dumpOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest):

  • inspector/elements/set-outer-html.html:
5:04 AM Changeset in webkit [104919] by commit-queue@webkit.org
  • 17 edits
    1 copy
    3 adds in trunk

ShadowContentElement should be able to use query.
​https://bugs.webkit.org/show_bug.cgi?id=75302

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-01-13
Reviewed by Hajime Morita.

Source/WebCore:

This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.

Tests: fast/dom/shadow/shadow-contents-select-expected.html

fast/dom/shadow/shadow-contents-select.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):

Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.

(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::size):

  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::select):
(WebCore::ShadowContentElement::setSelect):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Added.

(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):

Returns true if Node is matched by the query.

  • dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.

LayoutTests:

Tests for ShadowContentElement query.

  • fast/dom/shadow/shadow-contents-select-expected.html: Added.
  • fast/dom/shadow/shadow-contents-select.html: Added.
4:39 AM Changeset in webkit [104918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-13

  • DEPS:
3:54 AM Changeset in webkit [104917] by reni@webkit.org
  • 74 edits in trunk/LayoutTests

Update Snow-Leopard SVG pixel test baseline after r104881.
Unreviewed gardening.

  • platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png:
  • platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png:
  • platform/mac-snowleopard/svg/custom/altglyph-expected.png:
  • platform/mac-snowleopard/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac-snowleopard/svg/custom/junk-data-expected.png:
  • platform/mac-snowleopard/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac-snowleopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/path-bad-data-expected.png:
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac-snowleopard/svg/dom/css-transforms-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac-snowleopard/svg/hixie/error/012-expected.png:
  • platform/mac-snowleopard/svg/in-html/circle-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac-snowleopard/svg/text/kerning-expected.png:
  • platform/mac-snowleopard/svg/text/multichar-glyph-expected.png:
  • platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
3:36 AM Changeset in webkit [104916] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
​https://bugs.webkit.org/show_bug.cgi?id=76252

_calculateFlags speed is about 10k edges per second.
It requires 150sec for the snapshot with 1.5m edges.
The root of problem is var node = list.shift();
shift() is not effective in term of memory and cpu.
In our case it can be replaced with pop().
Now the function works 40 times faster.

Drive by change: if statement was reformatted a bit for better readability.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateFlags):

3:25 AM Changeset in webkit [104915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add visible field into ewk_tiled_backing_store's data.
​https://bugs.webkit.org/show_bug.cgi?id=76165

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Nikolas Zimmermann.

Using of evas_object_visible_get() API can't gurantee the correctness of
evas_object's visible status if it's called inside of evas_object's
smart_show() method.
So, a visible flag for the ewk_tiled_backing_store is added.
In addition, as tiles are not visible, ewk_tiled_backing_store will push
its own tiles into the cache when it disapear.

  • ewk/ewk_tiled_backing_store.cpp:

(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):

3:02 AM Changeset in webkit [104914] by haraken@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed; chromium tests rebaselined after r104907.

  • platform/chromium-mac-leopard/fast/repaint/focus-layers-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/focus-layers-expected.png: Added.
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png: Removed.
  • platform/chromium-win/fast/repaint/focus-layers-expected.png:
2:52 AM Changeset in webkit [104913] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] JavaScriptOutlineDialog fails to open
​https://bugs.webkit.org/show_bug.cgi?id=76259

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
2:07 AM Changeset in webkit [104912] by vsevik@chromium.org
  • 24 edits in trunk/LayoutTests

Unreviewed tests rebaseline after r104803.

  • fast/profiler/throw-exception-from-eval-expected.txt:
  • platform/chromium-mac/http/tests/history/cross-origin-replace-history-object-child-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/xss-DENIED-javascript-execution-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-history-properties-expected.txt:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/mac-wk2/plugins/mouse-events-scaled-expected.txt:
  • platform/mac/fast/AppleScript/001-expected.txt:
  • platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt:
  • platform/qt-wk2/plugins/document-open-expected.txt:
  • platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
  • platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/iframe-inside-overflow-expected.txt:
  • platform/win/plugins/keyboard-events-expected.txt:
  • platform/win/plugins/mouse-events-expected.txt:
  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt:
  • platform/win/plugins/windowless-paint-rect-coordinates-expected.txt:
2:05 AM Changeset in webkit [104911] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed garedening. Skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
1:41 AM Changeset in webkit [104910] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
​https://bugs.webkit.org/show_bug.cgi?id=76247

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)

1:31 AM Changeset in webkit [104909] by Nikolas Zimmermann
  • 77 edits in trunk/LayoutTests

2012-01-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update Lion SVG pixel test baseline after r104881.
Also update SVGFETurbulenceElement-*-stitchTiles-*, filter-child-repaint.svg results, which pass again.

  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/custom/altglyph-expected.png:
  • platform/mac/svg/custom/external-paintserver-reference-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/linking-base-external-reference-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/mac/svg/dom/SVGPointList-basics-expected.png:
  • platform/mac/svg/dom/SVGStringList-basics-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • platform/mac/svg/dom/css-transforms-expected.png:
  • platform/mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/in-html/circle-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
1:23 AM Changeset in webkit [104908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Unused code cleanup on ewk_tiled_model.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=76031

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-13
Reviewed by Ryosuke Niwa.

Remove unused code from ewk_tiled_model.cpp.

  • ewk/ewk_tiled_model.cpp:
1:17 AM Changeset in webkit [104907] by haraken@chromium.org
  • 5 edits
    2 adds in trunk

text-decorations should not be propagated to floating, absolutely or fixed
positioned decendants
​https://bugs.webkit.org/show_bug.cgi?id=18611

Reviewed by Darin Adler.

Source/WebCore:

Previously text-decorations were propagated to all child elements,
but they should not be propagated to out-of-flow descendants,
i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
​http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

Test: fast/css/text-decoration-in-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The added test checks that text-decorations are not propagated to out-of-flow
descendants, i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
​http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

  • fast/css/text-decoration-in-descendants-expected.html: Added.
  • fast/css/text-decoration-in-descendants.html: Added.
  • platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
  • platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
1:14 AM Changeset in webkit [104906] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (r104668): Crash in HTMLFormElement destructor if the
document contains radio groups with the identical name.
​https://bugs.webkit.org/show_bug.cgi?id=76206

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/radio/radio-group-document-destruction.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement):
setForm(0) may register this to a document-level radio button group.
We need to unregister this from the group because
Document::checkedRadioButtons() is still accessible from other objects.

LayoutTests:

  • fast/forms/radio/radio-group-document-destruction-expected.txt: Added.
  • fast/forms/radio/radio-group-document-destruction.html: Added.
1:12 AM Changeset in webkit [104905] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
​https://bugs.webkit.org/show_bug.cgi?id=76069

Reviewed by Martin Robinson.

Source/WebCore:

Fix bug introduced with patch for Bug 72830.

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.

Source/WebKit/gtk:

Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.

  • tests/testatk.c:

(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.

1:10 AM Changeset in webkit [104904] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[Gtk] Removed duplicated unit test.

The unit test testWebkitAtkGetTextAtOffsetForms is exactly the
same test case than testWebkitAtkGetTextAtOffset, so it makes no
sense to have it duplicated.

Rubber-stamped by Martin Robinson.

  • tests/testatk.c:

(main): Removed testWebkitAtkGetTextAtOffsetForms.

1:05 AM Changeset in webkit [104903] by Alexandru Chiculita
  • 4 edits in trunk/Source/WebCore

Refactor RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=75983

Reviewed by Simon Fraser.

No new tests, just merging two duplicate methods.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

This method is used only in non-composited mode, so I've moved the check for composited mode much earlier.

(WebCore::RenderLayer::paintLayerContentsAndReflection):

Also used just in non-composited mode, it will draw the reflection and then just call paintLayerContents.

(WebCore::RenderLayer::paintLayerContents):

Old method, that is now used by both composited and non-composited mode. I've added 3 more flags used to render the
Graphics layers: Background, Foreground and Mask.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Removed all the code and delegated the work to RenderLayer::paintLayerContents.

12:47 AM Changeset in webkit [104902] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Mac][DRT] Should support --no-timeout
​https://bugs.webkit.org/show_bug.cgi?id=76242

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-01-13
Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
(setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
(shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.

12:46 AM Changeset in webkit [104901] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r104787 if JIT_VERBOSE_OSR is defined

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

Jan 12, 2012:

11:23 PM Changeset in webkit [104900] by morrita@google.com
  • 88 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Mark all exported symbols in the header file automatically.
​https://bugs.webkit.org/show_bug.cgi?id=72855

Reviewed by Darin Adler.

Added WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE based on JavaScriptCore.exp files.
The change is generated by a tool calledListExportables (​https://github.com/omo/ListExportables)

  • API/OpaqueJSString.h:
  • bytecode/CodeBlock.h:
  • bytecode/SamplingTool.h:
  • debugger/Debugger.h:
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.h:
  • heap/AllocationSpace.h:
  • heap/HandleHeap.h:
  • heap/Heap.h:
  • heap/MachineStackMarker.h:
  • heap/MarkStack.h:
  • heap/VTableSpectrum.h:
  • heap/WriteBarrierSupport.h:
  • parser/Nodes.h:
  • parser/ParserArena.h:
  • profiler/Profile.h:
  • runtime/ArgList.h:
  • runtime/CallData.h:
  • runtime/Completion.h:
  • runtime/ConstructData.h:
  • runtime/DateInstance.h:
  • runtime/Error.h:
  • runtime/ExceptionHelpers.h:
  • runtime/FunctionConstructor.h:
  • runtime/Identifier.h:
  • runtime/InitializeThreading.h:
  • runtime/InternalFunction.h:
  • runtime/JSArray.h:
  • runtime/JSByteArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalThis.h:
  • runtime/JSLock.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h:
  • runtime/Lookup.h:
  • runtime/MemoryStatistics.h:
  • runtime/ObjectPrototype.h:
  • runtime/Options.h:
  • runtime/PropertyDescriptor.h:
  • runtime/PropertyNameArray.h:
  • runtime/PropertySlot.h:
  • runtime/RegExp.h:
  • runtime/RegExpObject.h:
  • runtime/SamplingCounter.h:
  • runtime/SmallStrings.h:
  • runtime/StringObject.h:
  • runtime/Structure.h:
  • runtime/TimeoutChecker.h:
  • runtime/UString.h:
  • runtime/WriteBarrier.h:
  • wtf/ArrayBufferView.h:
  • wtf/ByteArray.h:
  • wtf/CryptographicallyRandomNumber.h:
  • wtf/CurrentTime.h:
  • wtf/DateMath.h:
  • wtf/DecimalNumber.h:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/MD5.h:
  • wtf/MainThread.h:
  • wtf/MetaAllocator.h:
  • wtf/MetaAllocatorHandle.h:
  • wtf/OSAllocator.h:
  • wtf/PageBlock.h:
  • wtf/RandomNumber.h:
  • wtf/RefCountedLeakCounter.h:
  • wtf/SHA1.h:
  • wtf/Threading.cpp:
  • wtf/Threading.h:
  • wtf/ThreadingPrimitives.h:
  • wtf/WTFThreadData.h:
  • wtf/dtoa.h:
  • wtf/text/AtomicString.h:
  • wtf/text/CString.h:
  • wtf/text/StringBuilder.h:
  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:
  • wtf/unicode/Collator.h:
  • wtf/unicode/UTF8.h:
  • yarr/Yarr.h:
  • yarr/YarrPattern.h:
10:44 PM Changeset in webkit [104899] by barraclough@apple.com
  • 24 edits in trunk/Source

../JavaScriptCore: [Chromium] JSExportMacros.h should be visible.
​https://bugs.webkit.org/show_bug.cgi?id=76147

Patch by MORITA Hajime <​morrita@google.com> on 2012-01-12
Reviewed by Tony Chang.

  • config.h:

../WebCore: Clean up putDirect (part 2)
​https://bugs.webkit.org/show_bug.cgi?id=76232

Reviewed by Sam Weinig.

Rename putWithAttributes to putDirectVirtual.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putDirectVirtual):

  • bindings/js/JSDOMWindowShell.h:
10:19 PM Changeset in webkit [104898] by mikelawther@chromium.org
  • 5 edits in trunk/LayoutTests

losslessly optimise file size of test resource pngs
​https://bugs.webkit.org/show_bug.cgi?id=76240

Reviewed by Darin Adler.

Filesizes approximately halved.

  • css3/calc/resources/colorsquare.png:
  • css3/calc/resources/diamond.png:
  • css3/calc/resources/mask.png:
  • css3/calc/resources/ring.png:
9:13 PM Changeset in webkit [104897] by morrita@google.com
  • 4 edits in trunk/Source

[Chromium] JSExportMacros.h should be visible.
​https://bugs.webkit.org/show_bug.cgi?id=76147

Reviewed by Tony Chang.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

No new tests. No behavior change.

  • config.h:
8:51 PM Changeset in webkit [104896] by commit-queue@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/Source/WebCore

Split GraphicsContext3DOpenGL into several files
​https://bugs.webkit.org/show_bug.cgi?id=75462

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-01-12
Reviewed by Kenneth Russell.

Split GraphicsContext3DOpenGL.cpp into three files, GraphicsContext3DOpenGLCommon.cpp,
GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp so that makes gles support possible
for WebGL etc. Most of common APIs between gl and gles are in GraphicsContext3DOpenGLCommon.cpp.
The other gl and gles specific APIs are placed apart in GraphicsContext3DOpenGL.cpp &
GraphicsContext3DOpenGLES.cpp

No new tests required.

  • GNUmakefile.list.am: Added GraphicsContext3DOpenGLCommon.cpp
  • Target.pri: Added GraphicsContext3DOpenGLCommon.cpp
  • WebCore.gypi: Added GraphicsContext3DOpenGLCommon.cpp
  • WebCore.xcodeproj/project.pbxproj: Added GraphicsContext3DOpenGLCommon.cpp
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Copied from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp.

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Added.

(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::texImage2D):

8:44 PM Changeset in webkit [104895] by levin@chromium.org
  • 5 edits
    1 move in trunk/Source

HwndDC is a better name than OwnGetDC.
​https://bugs.webkit.org/show_bug.cgi?id=76235

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

This is a better name for two reasons:

  1. "Own" implies "delete". In this case, the final call is a release (ReleaseDC).
  2. "Ref" would be a better name due to the release but the RefPtr (and OwnPtr) classes always take something to hold on to. In this case, the object (the DC) is created by the class once it is given a Window to ensure that the HDC was actually created using GetDC.

(WTF::HwndDC::HwndDC):
(WTF::HwndDC::~HwndDC):
(WTF::HwndDC::operator HDC):

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

8:35 PM Changeset in webkit [104894] by eae@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

Add mac-snowleopard pixel results for tests with scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=76223

Reviewed by Eric Seidel.

  • platform/mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/button-default-title-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol: Added.
  • platform/mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-lr: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
8:27 PM Changeset in webkit [104893] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add vsma in VectorMath to handle vector scale multiply and add and use it in AudioBus
​https://bugs.webkit.org/show_bug.cgi?id=75835

When summing a audio bus, the source is multiplied with the scale and
then summed into the destination bus. Add this function to fulfill it.

Patch by Wei James <​james.wei@intel.com> on 2012-01-12
Reviewed by Kenneth Russell.

  • platform/audio/AudioBus.cpp:
  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsma):

  • platform/audio/VectorMath.h:
8:06 PM Changeset in webkit [104892] by Lucas Forschler
  • 1 copy in tags/Safari-535.17

New Tag.

7:59 PM Changeset in webkit [104891] by dimich@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

[Chromium] More rebaselines after ​http://trac.webkit.org/changeset/104881.
Unreviewed.

  • platform/chromium-mac-leopard/fast/overflow/005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.txt: Removed.
7:56 PM Changeset in webkit [104890] by dslomov@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed: update expectation for fast/workers/worker-script-error.

  • platform/chromium/fast/workers/worker-script-error-expected.txt:
  • platform/chromium/test_expectations.txt:
6:42 PM Changeset in webkit [104889] by dimich@chromium.org
  • 1 edit
    11 moves
    100 adds
    13 deletes in trunk/LayoutTests

[Chromium] Rebaseline files affected by ​http://trac.webkit.org/changeset/104881.
They still render the old way in Chromium.
The garden-o-matic also collapsed some identical test results.
Unreviewed.

  • fast/block/float/008-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/008-expected.txt.
  • fast/block/float/019-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/019-expected.txt.
  • fast/block/float/033-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/033-expected.txt.
  • fast/block/float/035-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/035-expected.txt.
  • fast/block/positioning/negative-rel-position-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/negative-rel-position-expected.txt.
  • fast/flexbox/flex-hang-expected.txt: Renamed from LayoutTests/platform/gtk/fast/flexbox/flex-hang-expected.txt.
  • fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/gif-large-checkerboard-expected.txt.
  • fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-expected.txt.
  • fast/table/wide-colspan-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/wide-colspan-expected.txt.
  • fast/table/wide-column-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/wide-column-expected.txt.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/008-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/019-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/033-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/035-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/br-with-clear-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/nested-clearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/negative-rel-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/relative-overflow-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/vertical-rl/002-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/border-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt.
  • platform/chromium-mac-snowleopard/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/flexbox/flex-hang-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/overflow-scroll-auto-switch-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/li-br-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/005-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/023-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/wide-colspan-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/wide-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/softHyphen-expected.png: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/qt/fast/block/float/008-expected.txt: Removed.
  • platform/qt/fast/block/float/019-expected.txt: Removed.
  • platform/qt/fast/block/float/033-expected.txt: Removed.
  • platform/qt/fast/block/float/035-expected.txt: Removed.
  • platform/qt/fast/block/positioning/negative-rel-position-expected.txt: Removed.
  • platform/qt/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/qt/fast/table/height-percent-test-expected.txt: Removed.
  • platform/qt/fast/table/wide-colspan-expected.txt: Removed.
  • platform/qt/fast/table/wide-column-expected.txt: Removed.
6:09 PM Changeset in webkit [104888] by Simon Fraser
  • 962 edits in trunk/LayoutTests

2012-01-12 Simon Fraser <Simon Fraser>

Fix the MIME types for expected images.

5:56 PM Changeset in webkit [104887] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chomium] Resources loaded with 304 status code have receiving time of 15000 days in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=76176

Reviewed by Nate Chapin.

No new tests. Can't trigger this with inspector tests. Will add one when the Resource Timing API is in.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Use monotonic time.

5:40 PM Changeset in webkit [104886] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Clean up putDirect (part 1)
​https://bugs.webkit.org/show_bug.cgi?id=76232

Reviewed by Sam Weinig.

putDirect has ambiguous semantics, clean these up a bit.

putDirect generally behaves a bit like a fast defineOwnProperty, but one that
always creates the property, with no checking to validate the put it permitted.

It also encompasses two slightly different behaviors.
(1) a fast form of put for JSActivation, which doesn't have to handle searching

the prototype chain, getter/setter properties, or the magic proto value.
Break this out as a new method, 'putOwnDataProperty'.

(2) the version of putDirect on JSValue will also check for overwriting ReadOnly

values, in strict mode. This is, however, not so smart on a few level, since
it is only called from op_put_by_id with direct set, which is only used with
an object as the base, and is only used to put new properties onto objects.

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::put):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSObject.h:

(JSC::JSObject::putOwnDataProperty):

  • runtime/JSValue.h:
5:27 PM Changeset in webkit [104885] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

NSURL to KURL conversion shouldn't turn raw paths into file URLs
​https://bugs.webkit.org/show_bug.cgi?id=76234

Reviewed by Darin Adler.

  • platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Removed this code.
5:16 PM Changeset in webkit [104884] by dimich@chromium.org
  • 4 edits
    1 move in trunk/LayoutTests

[Chromium] Rebaseline for a test modified in ​http://trac.webkit.org/changeset/104851
Unreviewed.

  • platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/mac/animations/cross-fade-webkit-mask-box-image-expected.txt: Renamed from LayoutTests/animations/cross-fade-webkit-mask-box-image-expected.txt.
4:58 PM Changeset in webkit [104883] by leviw@chromium.org
  • 36 edits in branches/subpixellayout/LayoutTests

Updating more test expectations.

4:51 PM Changeset in webkit [104882] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added an expected result missing from r104786.

  • fast/css/parsing-font-variant-ligatures-expected.txt: Added.
4:44 PM Changeset in webkit [104881] by Simon Fraser
  • 620 edits in trunk

Mitigate scrollbar differences when running pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=67217

Tools:

Reviewed by Dan Bernstein.

Enable mock scrollbars by default for tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Rubber-stamped by Dan Bernstein.

Update pixel results for tests up to and including LayoutTests/fast after
enabling mock scrollbars (67217), and fixing color profile issues (75662).

  • animations/missing-values-first-keyframe-expected.png:
  • animations/suspend-transform-animation-expected.png:
  • compositing/geometry/ancestor-overflow-change-expected.png:
  • compositing/iframes/composited-iframe-scroll-expected.png:
  • compositing/iframes/iframe-content-flipping-expected.png:
  • compositing/images/direct-pdf-image-expected.png:
  • compositing/images/direct-svg-image-expected.png:
  • compositing/masks/layer-mask-placement-expected.png:
  • compositing/overflow/repaint-after-losing-scrollbars-expected.png:
  • compositing/reflections/remove-add-reflection-expected.png:
  • compositing/tiling/constrained-layer-size-expected.png:
  • css3/filters/add-filter-rendering-expected.png:
  • css3/filters/crash-filter-change-expected.png:
  • css3/filters/effect-blur-expected.png:
  • css3/filters/effect-blur-hw-expected.png:
  • css3/filters/effect-brightness-expected.png:
  • css3/filters/effect-combined-expected.png:
  • css3/filters/effect-combined-hw-expected.png:
  • css3/filters/effect-contrast-expected.png:
  • css3/filters/effect-custom-expected.png:
  • css3/filters/effect-drop-shadow-expected.png:
  • css3/filters/effect-drop-shadow-hw-expected.png:
  • css3/filters/effect-grayscale-expected.png:
  • css3/filters/effect-grayscale-hw-expected.png:
  • css3/filters/effect-hue-rotate-expected.png:
  • css3/filters/effect-hue-rotate-hw-expected.png:
  • css3/filters/effect-invert-expected.png:
  • css3/filters/effect-invert-hw-expected.png:
  • css3/filters/effect-opacity-expected.png:
  • css3/filters/effect-opacity-hw-expected.png:
  • css3/filters/effect-saturate-expected.png:
  • css3/filters/effect-saturate-hw-expected.png:
  • css3/filters/effect-sepia-expected.png:
  • css3/filters/effect-sepia-hw-expected.png:
  • css3/filters/filter-region-expected.png:
  • css3/filters/filter-with-transform-expected.png:
  • css3/filters/nested-filter-expected.png:
  • css3/filters/regions-expanding-expected.png:
  • css3/filters/simple-filter-rendering-expected.png:
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • fast/block/float/float-not-removed-from-next-sibling4-expected.png:
  • fast/css-generated-content/table-parts-before-and-after-expected.png:
  • fast/images/color-jpeg-with-color-profile-expected.png:
  • fast/multicol/flipped-blocks-border-after-expected.png:
  • fast/multicol/vertical-lr/rules-with-border-before-expected.png:
  • fast/multicol/vertical-rl/rule-style-expected.png:
  • fast/multicol/vertical-rl/rules-with-border-before-expected.png:
  • platform/mac/animations/missing-values-last-keyframe-expected.png:
  • platform/mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/mac/compositing/direct-image-compositing-expected.png:
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.png:
  • platform/mac/compositing/geometry/clipping-foreground-expected.png:
  • platform/mac/compositing/geometry/composited-html-size-expected.png:
  • platform/mac/compositing/geometry/fixed-in-composited-expected.png:
  • platform/mac/compositing/geometry/fixed-position-expected.png:
  • platform/mac/compositing/geometry/foreground-layer-expected.png:
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png:
  • platform/mac/compositing/geometry/repaint-foreground-layer-expected.png:
  • platform/mac/compositing/geometry/root-layer-update-expected.png:
  • platform/mac/compositing/geometry/tall-page-composited-expected.png:
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png:
  • platform/mac/compositing/images/content-image-change-expected.png:
  • platform/mac/compositing/images/direct-image-background-color-expected.png:
  • platform/mac/compositing/masks/masked-ancestor-expected.png:
  • platform/mac/compositing/masks/multiple-masks-expected.png:
  • platform/mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/mac/compositing/overflow/scrollbar-painting-expected.png:
  • platform/mac/compositing/plugins/composited-plugin-expected.png:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/compositing-change-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-opacity-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-size-change-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/mac/compositing/reflections/reflection-opacity-expected.png:
  • platform/mac/compositing/reflections/reflection-positioning-expected.png:
  • platform/mac/compositing/reflections/reflection-positioning2-expected.png:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/mac/compositing/self-painting-layers-expected.png:
  • platform/mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/mac/compositing/webgl/webgl-background-color-expected.png:
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.png:
  • platform/mac/css1/basic/comments-expected.png:
  • platform/mac/css1/basic/containment-expected.png:
  • platform/mac/css1/basic/id_as_selector-expected.png:
  • platform/mac/css1/basic/inheritance-expected.png:
  • platform/mac/css1/box_properties/border-expected.png:
  • platform/mac/css1/box_properties/border_bottom-expected.png:
  • platform/mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/mac/css1/box_properties/border_left-expected.png:
  • platform/mac/css1/box_properties/border_left_width-expected.png:
  • platform/mac/css1/box_properties/border_right_inline-expected.png:
  • platform/mac/css1/box_properties/border_right_width-expected.png:
  • platform/mac/css1/box_properties/border_style-expected.png:
  • platform/mac/css1/box_properties/border_top-expected.png:
  • platform/mac/css1/box_properties/border_top_width-expected.png:
  • platform/mac/css1/box_properties/border_width-expected.png:
  • platform/mac/css1/box_properties/clear-expected.png:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/box_properties/float_margin-expected.png:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac/css1/box_properties/height-expected.png:
  • platform/mac/css1/box_properties/margin-expected.png:
  • platform/mac/css1/box_properties/margin_bottom-expected.png:
  • platform/mac/css1/box_properties/margin_inline-expected.png:
  • platform/mac/css1/box_properties/margin_left-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.png:
  • platform/mac/css1/box_properties/margin_top-expected.png:
  • platform/mac/css1/box_properties/padding-expected.png:
  • platform/mac/css1/box_properties/padding_bottom-expected.png:
  • platform/mac/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/mac/css1/box_properties/padding_inline-expected.png:
  • platform/mac/css1/box_properties/padding_left-expected.png:
  • platform/mac/css1/box_properties/padding_right-expected.png:
  • platform/mac/css1/box_properties/padding_top-expected.png:
  • platform/mac/css1/box_properties/width-expected.png:
  • platform/mac/css1/cascade/cascade_order-expected.png:
  • platform/mac/css1/cascade/important-expected.png:
  • platform/mac/css1/classification/display-expected.png:
  • platform/mac/css1/classification/list_style_type-expected.png:
  • platform/mac/css1/classification/white_space-expected.png:
  • platform/mac/css1/color_and_background/background-expected.png:
  • platform/mac/css1/color_and_background/background_attachment-expected.png:
  • platform/mac/css1/color_and_background/background_image-expected.png:
  • platform/mac/css1/color_and_background/background_position-expected.png:
  • platform/mac/css1/color_and_background/background_repeat-expected.png:
  • platform/mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/mac/css1/font_properties/font-expected.png:
  • platform/mac/css1/font_properties/font_size-expected.png:
  • platform/mac/css1/font_properties/font_weight-expected.png:
  • platform/mac/css1/formatting_model/floating_elements-expected.png:
  • platform/mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/mac/css1/formatting_model/inline_elements-expected.png:
  • platform/mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/mac/css1/pseudo/anchor-expected.png:
  • platform/mac/css1/pseudo/firstletter-expected.png:
  • platform/mac/css1/pseudo/firstline-expected.png:
  • platform/mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/mac/css1/text_properties/letter_spacing-expected.png:
  • platform/mac/css1/text_properties/line_height-expected.png:
  • platform/mac/css1/text_properties/text_decoration-expected.png:
  • platform/mac/css1/text_properties/text_indent-expected.png:
  • platform/mac/css1/text_properties/text_transform-expected.png:
  • platform/mac/css1/text_properties/vertical_align-expected.png:
  • platform/mac/css1/text_properties/word_spacing-expected.png:
  • platform/mac/css1/units/color_units-expected.png:
  • platform/mac/css1/units/length_units-expected.png:
  • platform/mac/css1/units/urls-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-010-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-017-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-024-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-height-031-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-013-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-020-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-022-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-027-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-029-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-034-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-036-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-041-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-043-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-048-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-050-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-055-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-057-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-062-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-064-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-069-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-071-expected.png:
  • platform/mac/css2.1/20110323/absolute-replaced-width-076-expected.png:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-004-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-012-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-014-expected.png:
  • platform/mac/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/mac/css2.1/20110323/block-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/block-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-001-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-002-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-003-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-004-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-005-expected.png:
  • platform/mac/css2.1/20110323/float-replaced-width-011-expected.png:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/inline-block-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-height-003-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-width-001-expected.png:
  • platform/mac/css2.1/20110323/inline-replaced-width-006-expected.png:
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/mac/css2.1/20110323/width-replaced-element-001-expected.png:
  • platform/mac/css2.1/t051201-c23-first-line-00-b-expected.png:
  • platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/mac/css2.1/t1202-counters-08-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/mac/css2.1/t1508-c527-font-01-b-expected.png:
  • platform/mac/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/mac/css3/images/cross-fade-blending-expected.png:
  • platform/mac/css3/images/cross-fade-invalidation-expected.png:
  • platform/mac/css3/images/cross-fade-simple-expected.png:
  • platform/mac/css3/images/cross-fade-sizing-expected.png:
  • platform/mac/css3/images/cross-fade-tiled-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/mac/editing/inserting/insert-div-023-expected.png:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.png:
  • platform/mac/editing/selection/focus_editable_html-expected.png:
  • platform/mac/editing/selection/iframe-expected.png:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/mac/editing/selection/select-all-001-expected.png:
  • platform/mac/editing/selection/select-all-002-expected.png:
  • platform/mac/editing/selection/select-all-003-expected.png:
  • platform/mac/editing/selection/select-all-004-expected.png:
  • platform/mac/editing/selection/unrendered-001-expected.png:
  • platform/mac/editing/selection/unrendered-003-expected.png:
  • platform/mac/editing/selection/unrendered-004-expected.png:
  • platform/mac/editing/selection/unrendered-005-expected.png:
  • platform/mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/mac/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/block/basic/016-expected.png:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac/fast/block/basic/truncation-rtl-expected.png:
  • platform/mac/fast/block/float/008-expected.png:
  • platform/mac/fast/block/float/013-expected.png:
  • platform/mac/fast/block/float/019-expected.png:
  • platform/mac/fast/block/float/020-expected.png:
  • platform/mac/fast/block/float/021-expected.png:
  • platform/mac/fast/block/float/025-expected.png:
  • platform/mac/fast/block/float/026-expected.png:
  • platform/mac/fast/block/float/027-expected.png:
  • platform/mac/fast/block/float/028-expected.png:
  • platform/mac/fast/block/float/032-expected.png:
  • platform/mac/fast/block/float/033-expected.png:
  • platform/mac/fast/block/float/035-expected.png:
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/mac/fast/block/float/br-with-clear-2-expected.png:
  • platform/mac/fast/block/float/float-avoidance-expected.png:
  • platform/mac/fast/block/float/nested-clearance-expected.png:
  • platform/mac/fast/block/float/relative-painted-twice-expected.png:
  • platform/mac/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/104-expected.png:
  • platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/mac/fast/block/positioning/047-expected.png:
  • platform/mac/fast/block/positioning/051-expected.png:
  • platform/mac/fast/block/positioning/055-expected.png:
  • platform/mac/fast/block/positioning/auto/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/mac/fast/block/positioning/negative-rel-position-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/mac/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/001-expected.png:
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-expected.png:
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-expected.png:
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/mac/fast/borders/border-image-scaled-expected.png:
  • platform/mac/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/mac/fast/borders/rtl-border-01-expected.png:
  • platform/mac/fast/borders/rtl-border-02-expected.png:
  • platform/mac/fast/borders/rtl-border-03-expected.png:
  • platform/mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/mac/fast/box-sizing/box-sizing-expected.png:
  • platform/mac/fast/canvas/canvas-bg-expected.png:
  • platform/mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/mac/fast/canvas/canvas-text-baseline-expected.png:
  • platform/mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/mac/fast/canvas/shadow-offset-7-expected.png:
  • platform/mac/fast/css-generated-content/014-expected.png:
  • platform/mac/fast/css/005-expected.png:
  • platform/mac/fast/css/MarqueeLayoutTest-expected.png:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac/fast/css/border-height-expected.png:
  • platform/mac/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/mac/fast/css/continuationCrash-expected.png:
  • platform/mac/fast/css/empty-pseudo-class-expected.png:
  • platform/mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/hsl-color-expected.png:
  • platform/mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/line-height-overflow-expected.png:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/mac/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/mac/fast/css/nested-rounded-corners-expected.png:
  • platform/mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/percentage-non-integer-expected.png:
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png:
  • platform/mac/fast/css/shadow-multiple-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-transform-select-expected.png:
  • platform/mac/fast/css/transform-default-parameter-expected.png:
  • platform/mac/fast/css/word-space-extra-expected.png:
  • platform/mac/fast/dom/34176-expected.png:
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/mac/fast/dom/focus-contenteditable-expected.png:
  • platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/anchor-lock-expected.png:
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/pointer-events-2-expected.png:
  • platform/mac/fast/events/reveal-link-when-focused-expected.png:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/mac/fast/flexbox/016-expected.png:
  • platform/mac/fast/flexbox/flex-hang-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-hides-table-expected.png:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png:
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/mac/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/mac/fast/gradients/background-clipped-expected.png:
  • platform/mac/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/mac/fast/gradients/css3-radial-gradients-expected.png:
  • platform/mac/fast/gradients/generated-gradients-expected.png:
  • platform/mac/fast/gradients/simple-gradients-expected.png:
  • platform/mac/fast/html/details-position-expected.png:
  • platform/mac/fast/html/details-writing-mode-expected.png:
  • platform/mac/fast/images/gif-large-checkerboard-expected.png:
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png:
  • platform/mac/fast/images/pdf-as-background-expected.png:
  • platform/mac/fast/images/pdf-as-image-expected.png:
  • platform/mac/fast/images/pdf-as-image-landscape-expected.png:
  • platform/mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/mac/fast/inline/inline-continuation-borders-expected.png:
  • platform/mac/fast/inline/long-wrapped-line-expected.png:
  • platform/mac/fast/invalid/residual-style-expected.png:
  • platform/mac/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/mac/fast/lists/001-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/003-expected.png:
  • platform/mac/fast/lists/008-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/li-br-expected.png:
  • platform/mac/fast/lists/ol-start-parsing-expected.png:
  • platform/mac/fast/lists/olstart-expected.png:
  • platform/mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-02-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-03-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-04-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-05-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-06-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-07-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-09-expected.png:
  • platform/mac/fast/media/mq-width-absolute-01-expected.png:
  • platform/mac/fast/media/mq-width-absolute-02-expected.png:
  • platform/mac/fast/media/mq-width-absolute-03-expected.png:
  • platform/mac/fast/media/mq-width-absolute-04-expected.png:
  • platform/mac/fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/column-rules-expected.png:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/float-paginate-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-split-across-columns-expected.png:
  • platform/mac/fast/multicol/nested-columns-expected.png:
  • platform/mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.png:
  • platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.png:
  • platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.png:
  • platform/mac/fast/multicol/pagination-h-vertical-lr-expected.png:
  • platform/mac/fast/multicol/pagination-h-vertical-rl-expected.png:
  • platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.png:
  • platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.png:
  • platform/mac/fast/multicol/pagination-v-vertical-lr-expected.png:
  • platform/mac/fast/multicol/pagination-v-vertical-rl-expected.png:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/mac/fast/multicol/shadow-breaking-expected.png:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/mac/fast/multicol/table-vertical-align-expected.png:
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/mac/fast/overflow/002-expected.png:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/005-expected.png:
  • platform/mac/fast/overflow/006-expected.png:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/008-expected.png:
  • platform/mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/mac/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/mac/fast/overflow/overflow-auto-table-expected.png:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/mac/fast/overflow/overflow-stacking-expected.png:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/mac/fast/overflow/overflow-update-transform-expected.png:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/mac/fast/overflow/table-overflow-float-expected.png:
  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/mac/fast/parser/document-write-option-expected.png:
  • platform/mac/fast/reflections/reflection-direction-expected.png:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/mac/fast/repaint/text-shadow-expected.png:
  • platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/mac/fast/replaced/005-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/width100percent-button-expected.png:
  • platform/mac/fast/replaced/width100percent-image-expected.png:
  • platform/mac/fast/selectors/166-expected.png:
  • platform/mac/fast/table/023-expected.png:
  • platform/mac/fast/table/027-vertical-expected.png:
  • platform/mac/fast/table/034-expected.png:
  • platform/mac/fast/table/038-vertical-expected.png:
  • platform/mac/fast/table/040-expected.png:
  • platform/mac/fast/table/040-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/004-expected.png:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/mac/fast/table/edge-offsets-expected.png:
  • platform/mac/fast/table/empty-cells-expected.png:
  • platform/mac/fast/table/height-percent-test-expected.png:
  • platform/mac/fast/table/overflowHidden-expected.png:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/mac/fast/table/table-display-types-vertical-expected.png:
  • platform/mac/fast/table/wide-colspan-expected.png:
  • platform/mac/fast/table/wide-column-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/drawBidiText-expected.png:
  • platform/mac/fast/text/hyphenate-character-expected.png:
  • platform/mac/fast/text/hyphenate-limit-lines-expected.png:
  • platform/mac/fast/text/hyphenate-locale-expected.png:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/mac/fast/text/large-text-composed-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/softHyphen-expected.png:
  • platform/mac/fast/text/stroking-decorations-expected.png:
  • platform/mac/fast/text/stroking-expected.png:
  • platform/mac/fast/text/text-letter-spacing-expected.png:
  • platform/mac/fast/text/wbr-expected.png:
  • platform/mac/fast/text/whitespace/024-expected.png:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/fast/text/word-break-expected.png:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/mac/fast/writing-mode/fallback-orientation-expected.png:
  • platform/mac/fast/writing-mode/fieldsets-expected.png:
  • platform/mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
4:33 PM Writing Layout Tests for DumpRenderTree edited by scheib@chromium.org
(diff)
4:31 PM Changeset in webkit [104880] by Lucas Forschler
  • 3 edits in branches/safari-534.54-branch/Source/WebCore

Merged r103082.

4:30 PM Changeset in webkit [104879] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Create a GraphicsLayer for the overhang areas if threaded scrolling is enabled
​https://bugs.webkit.org/show_bug.cgi?id=76220

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

Remove PLATFORM(CHROMIUM) #ifdefs.

  • page/FrameView.h:

Ditto.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Ditto.

  • platform/ScrollableArea.h:

Ditto.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
Ditto.

(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
Make this return true if we have a scrolling coordinator.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Remove PLATFORM(CHROMIUM) #ifdefs. Fix a bug the overhang layer was being added above the clip layer.

(WebCore::RenderLayerCompositor::destroyRootLayer):
Remove PLATFORM(CHROMIUM) #ifdefs.

  • rendering/RenderLayerCompositor.h:

Ditto.

4:29 PM Changeset in webkit [104878] by dimich@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Baseline for test added in ​http://trac.webkit.org/changeset/104851
Unreviewed.

  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.txt: Added.
4:28 PM Changeset in webkit [104877] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Merged r102024.

4:27 PM Changeset in webkit [104876] by bashi@chromium.org
  • 4 edits
    1 move in trunk/Source/WebCore

Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
​https://bugs.webkit.org/show_bug.cgi?id=76155

Reviewed by Tony Chang.

No new tests. No behavior change.

  • PlatformBlackBerry.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/skia/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/SimpleFontDataSkia.cpp.

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

4:24 PM Changeset in webkit [104875] by Lucas Forschler
  • 2 edits
    2 copies in branches/safari-534.54-branch/Source/WebCore

Merge pre-reqs for 102024.

4:19 PM Changeset in webkit [104874] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

A Frame with frame flattening can be stuck in a state in which performPostLayoutTasks() is never executed
​https://bugs.webkit.org/show_bug.cgi?id=76154

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-01-12
Reviewed by Beth Dakin.

In a frame with inSubframeLayoutWithFrameFlattening == true, if
-m_hasPendingPostLayoutTasks == true
-FrameView::unscheduleRelayout() is executed
-->the timer m_postLayoutTasksTimer is stopped
-->no timer is scheduled due to m_hasPendingPostLayoutTasks == true && inSubframeLayoutWithFrameFlattening == true

This patch revert the handling of the postLayoutTasks to its state prior to r66552.

The timer itself is used as the only state to know if post layout tasks are scheduled.

For the case without frame flattening:
-Prior to this patch, when FrameView::unscheduleRelayout() was executed, the postLayoutTasksTimer was killed,
and the post layout tasks would be executed during the next layout().
-After this patch, the post layout tasks stay scheduled and are executed on the next event loop if layout()
was not invoked before.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::unscheduleRelayout):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:
3:59 PM Changeset in webkit [104873] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2012-01-12
Reviewed by Benjamin Poulain.

​https://bugs.webkit.org/show_bug.cgi?id=75991
Make the code in MemoryPressureHandler::respondToMemoryPressure shareable.

Move memory pressure handling code inside a new function (releaseMemory) so that
we could shared it between mac and iOS.

  • Configurations/WebCore.xcconfig: add MemoryPressureHandlerMac.mm into iOS build.
  • platform/MemoryPressureHandler.h:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::releaseMemory):

3:57 PM Changeset in webkit [104872] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor DOMImplementation.hasFeature logic into helper functions.
​https://bugs.webkit.org/show_bug.cgi?id=76212

Reviewed by Adam Barth.

This patch should not have any behavior change. The goal was
to move our feature detection towards a more modular architecture
(as that seems to be the current trend in webkit). In a future
patch we could easily move the SVG feature detection into the
SVG directory, for example. I've also added a list of all the
Event3 features (currently commented out) which makes it obvious
how many we're missing.

  • dom/DOMImplementation.cpp:

(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
(WebCore::isEvents2Feature):
(WebCore::isEvents3Feature):
(WebCore::DOMImplementation::hasFeature):

3:51 PM Changeset in webkit [104871] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=76141
defineSetter/defineGetter may fail to update Accessor attribute

Reviewed by Oliver Hunt.

  • runtime/JSObject.cpp:

(JSC::JSObject::defineGetter):
(JSC::JSObject::initializeGetterSetterProperty):
(JSC::JSObject::defineSetter):

  • runtime/Structure.cpp:

(JSC::Structure::attributeChangeTransition):

  • runtime/Structure.h:
3:48 PM Changeset in webkit [104870] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r95607.

3:46 PM Changeset in webkit [104869] by Lucas Forschler
  • 10 edits
    3 copies in branches/safari-534.54-branch

Merged r94338.

3:43 PM Changeset in webkit [104868] by Lucas Forschler
  • 14 edits
    1 add in branches/safari-534.54-branch

Merged r94317.

3:34 PM Changeset in webkit [104867] by levin@chromium.org
  • 5 edits
    1 add in trunk/Source

[chromium] Fix DC leak in WebScreenInfoFactory.
​https://bugs.webkit.org/show_bug.cgi?id=76203

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnGetDCWin.h
  • JavaScriptCore.gypi: Added OwnGetDCWin.h
  • JavaScriptCore/wtf/win/OwnGetDCWin.h: Made an owner class for GetDC which needs ReleaseDC as opposed to DeleteDC.

Source/WebKit/chromium:

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo): Use OwnGetDC to ensure its release.

3:18 PM Changeset in webkit [104866] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

NodeIterator loses track of the reference node when the reference node is removed from the document (IETC ni_removeReferenceNode)
​https://bugs.webkit.org/show_bug.cgi?id=76146

Reviewed by Eric Seidel.

Source/WebCore:

In the case where we're removing the reference node we can end up with
the wrong reference node. This patch makes sure we traverse outside of
the removed node's subtree.

This bug was caught by the following IE Test Center test:

​http://samples.msdn.microsoft.com/ietestcenter/domtraversal/showdomtraversaltest.htm?ni_removeReferenceNode

Our new behavior also match Firefox.

I experimented a bit with adding ASSERT_NOT_REACHED to various branches
in NodeIterator::updateForNodeRemoval, and it seems our test coverage
for this function is relatively poor. In the future, we should
consider adding more tests for this complicated function.

Test: fast/dom/node-iterator-reference-node-removed.html

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::updateForNodeRemoval):

LayoutTests:

Test based on ​http://samples.msdn.microsoft.com/ietestcenter/domtraversal/showdomtraversaltest.htm?ni_removeReferenceNode

  • fast/dom/node-iterator-reference-node-removed-expected.txt: Added.
  • fast/dom/node-iterator-reference-node-removed.html: Added.
3:12 PM Changeset in webkit [104865] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Throw exception if IDBCursor.continue() called with key equal to current
​https://bugs.webkit.org/show_bug.cgi?id=76100

Source/WebCore:

The fix for ​https://bugs.webkit.org/show_bug.cgi?id=74213 missed the "or equal" clause
in the spec.

Patch by Joshua Bell <​jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

Test: storage/indexeddb/cursor-continue.html

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):

LayoutTests:

The previously existing clauses that iterated a cursor over non-unique values
by specifing a key now fail per spec, so they are changed to simply call continue().

Patch by Joshua Bell <​jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
2:57 PM Changeset in webkit [104864] by jonlee@apple.com
  • 3 edits
    2 adds in trunk

Setting value on a select element to a non existing option value should clear selection
​https://bugs.webkit.org/show_bug.cgi?id=67233
<rdar://problem/10057159>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/select/setting-to-invalid-value.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setValue): Clear the selection in the cases where we cannot
find an option with the specified value. The spec states to clear the selectedness of all
options first. To avoid calling setSelectedIndex() multiple times, we clear the selected
option(s) only when don't find the appropriate option.

Also, correct the sentence style of a comment.

LayoutTests:

New tests check to see that setting the value of a select element clears the
selection, even if the value is invalid, null, or undefined.

  • fast/forms/select/setting-to-invalid-value-expected.txt: Added.
  • fast/forms/select/setting-to-invalid-value.html: Added.
2:54 PM Changeset in webkit [104863] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r104858.

NSDataReadingMappedIfSafe is not defined on <= 10.6. Use NSDataReadingMapped on that platform instead.

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

2:53 PM Changeset in webkit [104862] by Lucas Forschler
  • 28 edits
    3 copies in branches/safari-534.54-branch

Merged r91777.

2:39 PM Changeset in webkit [104861] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk/Source

[skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater
​https://bugs.webkit.org/show_bug.cgi?id=74352

Patch by Dana Jansens <​danakj@chromium.org> on 2012-01-12
Reviewed by Stephen White.

Source/WebCore:

New unit tests in PlatformContextSkiaTest.cpp

  • WebCore.gypi:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::drawOuterPath):
(WebCore::drawInnerPath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):

  • platform/graphics/skia/OpaqueRegionSkia.cpp: Added.

(WebCore::OpaqueRegionSkia::OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::~OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::asRect):
(WebCore::xfermodeIsOpaque):
(WebCore::xfermodePreservesOpaque):
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):

  • platform/graphics/skia/OpaqueRegionSkia.h: Added.
  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::clippedToImage):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::paintSkPaint):
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::setTrackOpaqueRegion):
(WebCore::PlatformContextSkia::opaqueRegion):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/PlatformContextSkiaTest.cpp: Added.

(WebCore::TEST):

2:18 PM Changeset in webkit [104860] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=76209
Support expanded scrollbars
-and corresponding-
<rdar://problem/10527734>

Reviewed by Sam Weinig.

All this really requires is leaving the proper amount of space for the
expanded width.

  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::supportsExpandedScrollbars):
(WebCore::ScrollbarThemeMac::scrollbarThickness):

2:15 PM Changeset in webkit [104859] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

WebAudio: Enable USE_CONCATENATED_IMPULSE_RESPONSES on Mac port.
​https://bugs.webkit.org/show_bug.cgi?id=74328

Reviewed by Eric Carlson.

No new tests; no net change in functionality.

  • WebCore.xcodeproj/project.pbxproj: Added SincResampler class, Composite.wav to the project.

Removed IRC_*.wav resources from the project.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::createBySampleRateConverting): Uncommented this function

  • platform/audio/AudioBus.h:
  • platform/audio/HRTFElevation.cpp:
2:13 PM Changeset in webkit [104858] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
​https://bugs.webkit.org/show_bug.cgi?id=74326

Reviewed by Darin Adler.

No new tests; no net change in functionality.

Use NSDataReadingMappedIfSafe when reading platform audio file data.

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

2:11 PM Changeset in webkit [104857] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

WebAudio: Use Logging instead of printf.
​https://bugs.webkit.org/show_bug.cgi?id=74322

Reviewed by Darin Adler.

No new tests; no net change in functionality.

Add a new WebCoreLogLevel for WebAudio, and use this new log level instead of
printf statements in webaudio classes.

  • platform/Logging.cpp:

(WebCore::getChannelFromName):

  • platform/Logging.h:
  • platform/mac/LoggingMac.mm:

(WebCore::InitializeLoggingChannelsIfNecessary):

  • platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::print):

  • webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):

2:08 PM Changeset in webkit [104856] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/Tools

Need a script to run tests in PerformanceTests
​https://bugs.webkit.org/show_bug.cgi?id=76132

Reviewed by Adam Barth.

Add run-perf-tests to run performance tests using parser/resources/runner.js.
Unfortunately, there isn't an easy way of telling which test uses which format
so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).

All test outputs are re-formatted to match Chromium perf-bot style.

  • Scripts/run-inspector-perf-tests.py:
  • Scripts/run-perf-tests: Added.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._print_status):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._should_ignore_line_in_parser_test_result):
(PerfTestsRunner._process_parser_test_result):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(create_runner):
(run_test):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_collect_tests):

1:39 PM Changeset in webkit [104855] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Make ScrollElasticityController members private
​https://bugs.webkit.org/show_bug.cgi?id=76208

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::endScrollGesture):
Call ScrollElasticityController::endScrollGesture.

  • platform/mac/ScrollElasticityController.h:

Make members private.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::endScrollGesture):
Call snapRubberBand.

(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
Call stopSnapRubberbandTimer.

1:34 PM Changeset in webkit [104854] by enne@google.com
  • 3 edits
    3 copies in branches/chromium/963

Merge 104782 - Repaint all graphics layers when their renderer offset changes
​https://bugs.webkit.org/show_bug.cgi?id=75730

Reviewed by Simon Fraser.

Source/WebCore:

In RenderLayerBacking, only the main graphics layer gets repainted
when the offset changes. If the offset on other graphics layers (e.g.
the foreground layer) changes, they should get repainted as well.

Test: compositing/geometry/foreground-offset-change.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • platform/graphics/GraphicsLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

  • compositing/geometry/foreground-offset-change-expected.png: Added.
  • compositing/geometry/foreground-offset-change-expected.txt: Added.
  • compositing/geometry/foreground-offset-change.html: Added.

TBR=​enne@google.com
Review URL: ​http://codereview.chromium.org/9187066

1:28 PM Changeset in webkit [104853] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move wheel event handling to ScrollElasticityController::handleWheelEvent
​https://bugs.webkit.org/show_bug.cgi?id=76205

Reviewed by Andreas Kling.

Move the code in ScrollAnimatorMac::smoothScrollWithEvent to ScrollElasticityController::handleWheelEvent and
change ScrollAnimatorMac::handleWheelEvent to just call ScrollElasticityController::handleWheelEvent.
This means that we'll not set m_haveScrolledSincePageLoad = true anymore (we used to set it in ScrollAnimatorMac::smoothScrollWithEvent),
but we already set it to true in ScrollAnimatorMac::handleWheelEvent so it already had no effect.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::elasticDeltaForReboundDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollElasticityController::handleWheelEvent):

1:26 PM Changeset in webkit [104852] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.54-branch

Merged r92005.

1:25 PM Changeset in webkit [104851] by Simon Fraser
  • 5 edits
    3 adds in trunk

Borders and box masks behave incorrectly with overlapping offsets
​https://bugs.webkit.org/show_bug.cgi?id=76137

Source/WebCore:

Reviewed by Dave Hyatt.

When border-image-slice sizes add up to more than the height or width
of the border-image, the middle sections should not be rendered, per spec.

Test: fast/borders/border-image-slice-constrained.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Testcase with border-image slices adding up to more than the height/width
of the border image.

Fixed cross-fade-webkit-mask-box-image.html to use slices that are half
of the image width.

  • animations/cross-fade-webkit-mask-box-image.html:
  • fast/borders/border-image-slice-constrained.html: Added.
  • platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png:
  • platform/mac/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/mac/fast/borders/border-image-slice-constrained-expected.txt: Added.
1:16 PM Changeset in webkit [104850] by Martin Robinson
  • 5 edits
    1 copy in trunk/Source/WebKit2

[GTK] [WebKit2] WebKitURIRequest and WebKitURIResponse should wrap the corresponding WebCore classes
​https://bugs.webkit.org/show_bug.cgi?id=74478

Reviewed by Gustavo Noronha Silva.

Have WebKitURIRequest wrap a ResourceRquesst and WebKitURIResponse wrap a ResourceResponse.
They are the WebCore types they are meant to represent and we will need to expose more
information from them in the future to make them useful. Later we can have ResourceResponse
generate a SoupMessage lazily if necessary.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkit_uri_request_class_init): Remove the set property vmethod.
(webkit_uri_request_new): The URI property is no longer settable.
(webkitURIRequestCreateForResourceRequest): Added this private constructor.
(webkit_uri_request_get_uri): Now we just get the URI directly from the ResourceRequest.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkit_uri_response_class_init): Remove the set property vmethod.
(webkit_uri_response_get_uri): Get the URI directly from the ResourceReponse.
(webkit_uri_response_get_status_code): Get the status code directly from the ResourceResponse.
(webkit_uri_response_get_content_length): Get the content length directly from the ResourceResponse.
(webkitURIResponseCreateForResourceResponse): Added this private constructor.

  • UIProcess/API/gtk/WebKitURIResponsePrivate.h: Removed unnecessary methods.
1:08 PM Changeset in webkit [104849] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make all calls to pinnedInDirection go through the ScrollElasticityController
​https://bugs.webkit.org/show_bug.cgi?id=76204

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

12:50 PM Changeset in webkit [104848] by senorblanco@chromium.org
  • 5 edits in trunk

[chromium] Re-enable Skia feColorMatrix filter implementation.
​https://bugs.webkit.org/show_bug.cgi?id=76186

Source/WebCore:

This code was landed in ​http://trac.webkit.org/changeset/104566 and
partially reverted in ​http://trac.webkit.org/changeset/104632 due
to problems with the Windows Shared builder. Those problems have
been fixed in r3006, since rolled into Chrome.

Reviewed by Kenneth Russell.

Covered by SVG feColorMatrix tests.

  • WebCore.gypi:
  • platform/graphics/filters/FEColorMatrix.h:

LayoutTests:

Remove suppressions for tests which now pass.

Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
12:43 PM Changeset in webkit [104847] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add allowsHorizontalStretching and allowsVerticalStretching to ScrollElasticityControllerClient
​https://bugs.webkit.org/show_bug.cgi?id=76202

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/ScrollElasticityController.h:
12:25 PM Changeset in webkit [104846] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move snapRubberBand to ScrollElasticityController
​https://bugs.webkit.org/show_bug.cgi?id=76200

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::endScrollGesture):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(systemUptime):
(WebCore::ScrollElasticityController::snapRubberBand):

12:21 PM Changeset in webkit [104845] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r104060): Setting user stylesheet may leave CSSStyleSelector with stale rule pointers
​https://bugs.webkit.org/show_bug.cgi?id=76191

Source/WebCore:

Reviewed by Andreas Kling.

Setting the user style sheet frees the existing user style sheet data structures. The code
in Document::updatePageGroupUserSheets then relies on styleSelectorChanged to clear the
style selector so it is not left with stale pointers. However under certain conditions
involving pending stylesheets it may bail out quickly without clearing.

Document::styleSelectorChanged has to take care that it never leaves the style selector stale
even when bailing out early.

Test: fast/css/user-stylesheet-crash.html

  • dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/user-stylesheet-crash-expected.txt: Added.
  • fast/css/user-stylesheet-crash.html: Added.
12:14 PM Changeset in webkit [104844] by nduca@chromium.org
  • 13 edits in trunk/Source

[chromium] Turn off FrameRateController timesource when it is not needed
​https://bugs.webkit.org/show_bug.cgi?id=76149

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(WebCore::CCDelayBasedTimeSource::active):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCFrameRateController.h:
  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
  • platform/graphics/chromium/cc/CCTimeSource.h:

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::timeout):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::active):

12:06 PM Changeset in webkit [104843] by dpranke@chromium.org
  • 15 edits in trunk/Tools

webkitpy: clean up port unit tests in preparation for making port_name mandatory
​https://bugs.webkit.org/show_bug.cgi?id=76123

Reviewed by Adam Barth.

This change updates the unit tests to be more consistent in how
ports are created, in preparation for making port_name a
mandatory parameter to the constructor and removing any version
interpretation from it.

There should be no functional changes in this patch, but some
tests that are no longer relevant have been removed or reworked.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_get_optiondefault):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest):
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest):
(ChromiumPortTest.test_all_test_configurations):
(ChromiumPortTest.TestMacPort.init):
(ChromiumPortTest.TestLinuxPort.init):
(ChromiumPortTest.TestWinPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest):

  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:

(EflPortTest):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest):
(MockDRTPortTest.make_port):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._port_flag_for_scripts):
(QtPort.init):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):
(QtPortTest.test_operating_system):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest):
(WinPortTest._assert_search_path):
(WinPortTest.test_baseline_search_path):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort.init):

12:04 PM Changeset in webkit [104842] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Move snapRubberBandTimerFired to ScrollElasticityController
​https://bugs.webkit.org/show_bug.cgi?id=76196

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::elasticDeltaForTimeDelta):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

11:55 AM Changeset in webkit [104841] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: clean up logging and provide a real --help message
​https://bugs.webkit.org/show_bug.cgi?id=76142

Reviewed by Adam Barth.

This test is mostly more refactoring - it calls objects in
unittest directly instead of routing through unittest.main() --
in order to gain more control over the logging and to provide a
correct --help message. This will also give us a better
foundation for adding more feautures down the road.

This patch adds different levels of logging controlled by the
'-s', '-q', and '-v' options (see --help for details), and
removes the --verbose-logging option.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/main.py:

(Tester):
(Tester.clean_packages):
(Tester.init):
(Tester.parse_args):
(Tester.configure):
(Tester._configure_logging):
(Tester.find_modules):
(Tester._exclude):
(Tester._modules_from_paths):
(Tester.run_tests):

11:39 AM Changeset in webkit [104840] by commit-queue@webkit.org
  • 5 edits in trunk

IndexedDB: Raise NON_TRANSIENT_ERR when invalid mode specified for transaction
​https://bugs.webkit.org/show_bug.cgi?id=76072

Source/WebCore:

Spec was updated to detail what should be thrown: ​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11406

Patch by Joshua Bell <​jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

Tests: storage/indexeddb/transaction-basics.html

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

LayoutTests:

Patch by Joshua Bell <​jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
11:19 AM Changeset in webkit [104839] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove the last non-ScrollElasticityController call from ScrollAnimatorMac::snapRubberBandTimerFired
​https://bugs.webkit.org/show_bug.cgi?id=76193

Reviewed by Andreas Kling.

Use ScrollElasticityControllerClient::immediateScrollBy for the final scroll before the rubber-band timer stops.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

11:15 AM Changeset in webkit [104838] by jer.noble@apple.com
  • 12 edits
    4 adds in trunk

Emit an error event when a request to enter full-screen is rejected.
​https://bugs.webkit.org/show_bug.cgi?id=62320

Reviewed by Eric Carlson.

Source/WebCore:

Tests: fullscreen/full-screen-request-rejected.html

fullscreen/full-screen-request-removed.html

When a request to enter full-screen is rejected, emit an event
(webkitfullscreenerror) in response. But emit the event during the next
trip through the run-loop, like the webkitfullscreenchange event, and so a new
timer and queue are necessary.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement): Emit the error event

if the request does not pass all our requirements.

  • dom/Document.h: Add new ivars.
  • dom/Document.idl: Add support for setting an onfullscreenerror attribute.
  • dom/Element.h: Ditto.
  • dom/Element.idl: Ditto.
  • dom/EventNames.h: Add the name for the error event.

LayoutTests:

  • fullscreen/full-screen-iframe-not-allowed-expected.txt:
  • fullscreen/full-screen-iframe-not-allowed.html:
  • fullscreen/full-screen-request-rejected-expected.txt: Added.
  • fullscreen/full-screen-request-rejected.html: Added.
  • fullscreen/full-screen-request-removed-expected: Added.
  • fullscreen/full-screen-request-removed.html: Added.
11:06 AM Changeset in webkit [104837] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=76133
ScrollAnimatorMac::mouseEnteredScrollbar() and mouseExitedScrollbar() should
only do stuff for legacy scrollbars
-and corresponding-
<rdar://problem/10603290>

Reviewed by Sam Weinig.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

10:38 AM Changeset in webkit [104836] by barraclough@apple.com
  • 10 edits in trunk

Allow accessor get/set property to be set to undefined
​https://bugs.webkit.org/show_bug.cgi?id=76148

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

AccessorDescriptor properties may have their get & set properties defined to reference a function
(Callable object) or be set to undefined. Valid PropertyDescriptors created by toPropertyDescriptor
(defined from JS code via Object.defineProperty, etc) have get and set properties that are in one of
three states (1) nonexistent, (2) set to undefined, or (3) a function (any Callable object).

On the PropertyDescriptor object these three states are represneted by JSValue(), jsUndefined(), and
any JSObject* (with a constraint that this must be callable).

Logically the get/set property of an accessor descriptor on an object might be in any of the three
states above, but in practice there is no way to distinguish between the first two states. As such
we stor the get/set values in property storage in a JSObject* field, with 0 indicating absent or
undefined. When unboxing to a PropertyDescriptor, map this back to a JS undefined value.

  • runtime/GetterSetter.h:

(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):

  • Allow the getter/setter to be cleared.
  • runtime/JSArray.cpp:

(JSC::JSArray::putDescriptor):

  • Changed to call getterObject/setterObject.

(JSC::JSArray::defineOwnNumericProperty):

  • Added ASSERT.
  • runtime/JSObject.cpp:

(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • Changed to call getterObject/setterObject.
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):

  • getter/setter values read from properties on object are never missing, they will now be set as undefined by 'setDescriptor'.

(JSC::toPropertyDescriptor):

  • Do not translate undefined->empty, this loses an important distinction between a get/set property being absent, or being explicitly set to undefined.
  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::getterObject):
(JSC::PropertyDescriptor::setterObject):

  • Accessors to convert the get/set property to an object pointer, converting undefined to 0.

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):

  • Translate a getter/setter internally represented at 0 to undefined, indicating that it is present.
  • runtime/PropertyDescriptor.h:
    • Declare getterObject/setterObject.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Update a couple of inaccurate tests (it is invalid for a property to have both a get: and value: field; AccessorDescritor properties do not have a writable property). Add more test cases.
10:20 AM Changeset in webkit [104835] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

When generating derived sources, use the same compiler that is used to compile WebCore.

Fixes <​http://webkit.org/b/76189>
[mac] When compiling WebCore with clang, llvm-gcc is used to generate derived sources

Reviewed by Mark Rowe.

  • DerivedSources.make: Changed to use the CC environment variable instead of hardcoded gcc.
  • WebCore.xcodeproj/project.pbxproj: Set the CC environment variable, if not already set,

according to TARGET_GCC_VERSION. CC is used by DerivedSources.make and some of the perl
scripts it invokes.

9:47 AM Changeset in webkit [104834] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed build fix after r104828.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::StylePainterMobile::findComboButton):

9:33 AM Changeset in webkit [104833] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r104829.
​http://trac.webkit.org/changeset/104829
​https://bugs.webkit.org/show_bug.cgi?id=76188

it broke qt-minimal (Requested by loislo1 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-12

  • inspector/CodeGeneratorInspector.py:

(CodeGenerator):
(CodeGenerator.generate_type_builder):
(CodeGenerator.generate_type_builder.AdHocTypeContext):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(CodeGenerator.register_use):
(RawTypesBinding):
(RawTypesBinding.get_code_generator):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(RawTypesBinding.reduce_to_raw_type):
(TypeData.init):

  • inspector/InspectorValues.h:
9:27 AM Changeset in webkit [104832] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] WebProcesses crashes when composited reflections/masks are present
​https://bugs.webkit.org/show_bug.cgi?id=75883

Reviewed by Kenneth Rohde Christiansen.

Make sure masks and replica layers can access layerTreeTileClient. Let masks
have the right contents/visible rect so that they can render content tiles.
Default the mask's size to be the layer's size.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):

9:06 AM Changeset in webkit [104831] by podivilov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: [JSC] @ sourceURL is not respected.
​https://bugs.webkit.org/show_bug.cgi?id=65532

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-url-comment.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findSourceURL):
(WebCore::ContentSearchUtils::findSourceMapURL):

  • inspector/ContentSearchUtils.h:

LayoutTests:

  • inspector/debugger/source-url-comment-expected.txt: Added.
  • inspector/debugger/source-url-comment.html: Added.
8:42 AM Changeset in webkit [104830] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial buildfix after r104828.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::StylePainterMobile::findComboButton):

8:40 AM Changeset in webkit [104829] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: generate array types.
​https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-01-12
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance.

  • inspector/CodeGeneratorInspector.py:

(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.init):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.init):
(TypeData.get_binding):

  • inspector/InspectorValues.h:
8:33 AM Changeset in webkit [104828] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Avoid string operations in mobile theme's caching mechanism
​https://bugs.webkit.org/show_bug.cgi?id=75010

The string operations constantly performed in the mobile theme
to fetch or put controls in the pixmap cache can be pretty expensive.
The new mechanism harnesses the QPixmapCache::Key API instead.

Reviewed by Kenneth Rohde Christiansen.

No new tests, internal refactoring.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::qHash):
(WebCore::StylePainterMobile::findCachedControl):
(WebCore::StylePainterMobile::insertIntoCache):
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::paintMenuList):

  • platform/qt/RenderThemeQtMobile.h:

(WebCore::KeyIdentifier::KeyIdentifier):
(WebCore::KeyIdentifier::operator==):

8:14 AM Changeset in webkit [104827] by vsevik@chromium.org
  • 23 edits
    4 deletes in trunk

Unreviewed, rolling out r104805.
​http://trac.webkit.org/changeset/104805
​https://bugs.webkit.org/show_bug.cgi?id=76180

Breaks apple win compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-12

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):

  • dom/SelectorQuery.h:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::create):
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::shouldInclude):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Removed.
  • dom/ShadowContentSelectorQuery.h: Removed.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsContentElement::shouldInclude):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
(WebCore::DetailsSummaryElement::shouldInclude):

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

  • testing/Internals.cpp:

(WebCore::Internals::createShadowContentElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/shadow-contents-select-expected.html: Removed.
  • fast/dom/shadow/shadow-contents-select.html: Removed.
7:28 AM Changeset in webkit [104826] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][WK2][Mac] Conflict of MacTypes.h defining a Fixed type after r104560.
​https://bugs.webkit.org/show_bug.cgi?id=76175

Defining ENABLE_CSS_FILTERS leads to ambiguous references
due to MacTypes.h being included.
Defining CF_OPEN_SOURCE works around this problem.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:
7:14 AM Changeset in webkit [104825] by Simon Hausmann
  • 8 edits
    2 moves in trunk

Make the new WTF module build on Qt
​https://bugs.webkit.org/show_bug.cgi?id=76163

Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pro: Build the new WTF instead of the old one.

Source/JavaScriptCore:

Source/WTF:

With this change the WTF sources are built _here_ but _from_ their old location using a VPATH.

  • WTF.pri: Renamed from Source/JavaScriptCore/wtf/wtf.pri.
  • WTF.pro: Renamed from Source/JavaScriptCore/wtf/wtf.pro.
  • config.h: Bring this file in sync with JavaScriptCore/config.h with regards to the inclusion

/ definition of the export macros.

Tools:

  • qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
6:57 AM Changeset in webkit [104824] by zherczeg@webkit.org
  • 8 edits in trunk

Fix turbulence bug when stitch tiles enabled and rendered in parallel
​https://bugs.webkit.org/show_bug.cgi?id=76042

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The width / height / wrap members are used by all threads
in the same time. The patch makes them local for all threads.

Fixes the layout fails in svg/dynamic-updates/SVGFETurbulence*

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D):
(WebCore::Noise::if):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):

  • platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData):

LayoutTests:

Update mac expected files.

  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
6:52 AM Changeset in webkit [104823] by kenneth@webkit.org
  • 9 edits in trunk/Source/WebKit2

[Qt] Set the input method hints on the QtQuick item ​https://bugs.webkit.org/show_bug.cgi?id=76169

Reviewed by Simon Hausmann.

Set the input method hints given the HTMLElement type and state.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(WebKit::EditorState::EditorState):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::updateTextInputState):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

6:44 AM Changeset in webkit [104822] by loislo@chromium.org
  • 3 edits
    1 add in trunk

Web Inspector: performance: restore 'log 300 messages into console' test.
​https://bugs.webkit.org/show_bug.cgi?id=76170

It was removed in order of transition from layout tests to perf tests.

Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/console-300-lines.html: Added.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):

6:39 AM Changeset in webkit [104821] by hans@chromium.org
  • 3 edits
    2 adds in trunk

Speech input: Send text to correct element even if focus has changed
​https://bugs.webkit.org/show_bug.cgi?id=76071

Reviewed by Steve Block.

Source/WebCore:

Make sure that the text from speech input ends up in the correct
element even if focus has changed since the user clicked on it.

Test: fast/speech/change-focus.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests:

Add test to make sure that the text from speech input ends up in the
correct element even if focus has moved away after the user clicked on it.

  • fast/speech/change-focus-expected.txt: Added.
  • fast/speech/change-focus.html: Added.
6:27 AM Changeset in webkit [104820] by vsevik@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, mac DumpRenderTree fix.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]):

6:08 AM Changeset in webkit [104819] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Add flaky test to GTK's test_expectations.txt.

  • platform/gtk/test_expectations.txt: Add flaky test.
5:52 AM Changeset in webkit [104818] by vsevik@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, updated chromium test expectations.

  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
  • platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt:
  • platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
5:48 AM Changeset in webkit [104817] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, fix http/tests/multipart/invalid-image-data.html expectation for XP.

  • platform/chromium/test_expectations.txt:
5:37 AM Changeset in webkit [104816] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:58 AM Changeset in webkit [104815] by vsevik@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, rebaseline wk2 and http/tests/security/cross-frame-access-put.html test expectations after r104803.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
4:41 AM Changeset in webkit [104814] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening after r104803.

Remove unnecessary "line 1" from expected files.

  • platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
4:27 AM Changeset in webkit [104813] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r104803.

  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt:
4:25 AM Changeset in webkit [104812] by vsevik@chromium.org
  • 2 edits in trunk/Tools

WebKitTestRunner should not print console message line number when it is equal to zero.
​https://bugs.webkit.org/show_bug.cgi?id=76167

Reviewed by Csaba Osztrogonác.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

4:24 AM Changeset in webkit [104811] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-01-12

  • DEPS:
4:19 AM Changeset in webkit [104810] by Csaba Osztrogonác
  • 48 edits in trunk/LayoutTests

Unreviewed gardening after r104803.

Remove unnecessary "line 0" from expected files.

  • fast/dom/exception-getting-event-handler-expected.txt:
  • fast/dom/javascript-url-exception-isolation-expected.txt:
  • fast/dom/nested-script-exceptions-expected.txt:
  • fast/events/window-onerror13-expected.txt:
  • fast/events/window-onerror16-expected.txt:
  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/uncaught-exception-line-number-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:
  • http/tests/history/cross-origin-replace-history-object-child-expected.txt:
  • http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt:
  • http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt:
  • http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
  • http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty-expected.txt:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt:
  • inspector/console/alert-toString-exception-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
  • platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • platform/qt/plugins/document-open-expected.txt:
  • platform/qt/plugins/plugin-initiate-popup-window-expected.txt:
  • plugins/keyboard-events-expected.txt:
  • plugins/mouse-events-expected.txt:
  • plugins/mouse-events-fixedpos-expected.txt:
  • plugins/nested-plugin-objects-expected.txt:
  • plugins/netscape-destroy-plugin-script-objects-expected.txt:
  • plugins/npp-set-window-called-during-destruction-expected.txt:
  • storage/sql-error-codes-expected.txt:
  • storage/statement-error-callback-expected.txt:
  • storage/transaction-callback-exception-crash-expected.txt:
4:06 AM Changeset in webkit [104809] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: performance tests: fix memory leak in first-open-resources test.
​https://bugs.webkit.org/show_bug.cgi?id=76049

first-open-resources doesn't reset resource panel properly after test run.

Reviewed by Yury Semikhatsky.

  • inspector/first-open-resources.html:
3:54 AM Changeset in webkit [104808] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: make source urls relative to source map url.
​https://bugs.webkit.org/show_bug.cgi?id=75968

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/resources/source-map.json:
3:52 AM Changeset in webkit [104807] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-01-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix WebKit build after r104803, by setting ScriptCallStack.h role to private.

  • WebCore.xcodeproj/project.pbxproj:
3:48 AM Changeset in webkit [104806] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Move macro checking to functions' definition in ewk_js.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=76037

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Moves macro checking to functions' definition instead of duplicate them in source depending on macro value.
It's known practice in WebKit and EFL port.
Duplicating functions in the same file whose return value is different may confuse user,
especially if macro isn't included in a patch.

  • ewk/ewk_js.cpp:

(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):

3:23 AM BuildingQt5OnHarmattan edited by vestbo@webkit.org
(diff)
3:22 AM BuildingQt5OnHarmattan edited by vestbo@webkit.org
Update instructions to match latest changes to Qt5 (diff)
3:15 AM Changeset in webkit [104805] by commit-queue@webkit.org
  • 23 edits
    1 copy
    3 adds in trunk

ShadowContentElement should be able to use query.
​https://bugs.webkit.org/show_bug.cgi?id=75302

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-01-12
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

This patch introduces a selector to query elements in ShadowContentElement.
This can be used instead of ShadowContentElement::shouldInclude in more sophisticated ways.

Tests: fast/dom/shadow/shadow-contents-select-expected.html

fast/dom/shadow/shadow-contents-select.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):

Extracted from SelectorQueryto share codes with ShadowContentSelectorQuery.

(WebCore::SelectorDataList::initialize):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::queryAll):
(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::canUseIdLookup):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::size):

  • dom/ShadowContentElement.cpp:

(WebCore::selectAttr):
(WebCore::ShadowContentElement::create):
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::select):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelectorQuery.cpp: Added.

(WebCore::ShadowContentSelectorQuery::ShadowContentSelectorQuery):
(WebCore::ShadowContentSelectorQuery::matches):

Returns true if Node is matched by the query.

  • dom/ShadowContentSelectorQuery.h: Copied from Source/WebCore/dom/ShadowContentElement.h.
  • dom/ShadowInclusionSelector.cpp:

(WebCore::ShadowInclusionSelector::select):

  • dom/ShadowInclusionSelector.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):
(WebCore::DetailsContentElement::DetailsContentElement): Re-implemented using query.
(WebCore::DetailsSummaryElement::DetailsSummaryElement): ditto.

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

  • testing/Internals.cpp:

(WebCore::Internals::createShadowContentElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Tests for ShadowContentElement query.

  • fast/dom/shadow/shadow-contents-select-expected.html: Added.
  • fast/dom/shadow/shadow-contents-select.html: Added.
3:10 AM Changeset in webkit [104804] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Update and show ewk_view with updated webpage.
​https://bugs.webkit.org/show_bug.cgi?id=76023

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Update ewk_view with BackingStore image which is rendered webpage
image by WebProcess, and show updated image's area when
PageClientImpl::setViewNeedsDisplay() is called.
The ewk_view_display() function is used to display updated area of
evas_object_image and the ewk_view_image_data_set() function is used
to set evas_object_image's data with rendered webpage.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setViewNeedsDisplay):

  • UIProcess/API/efl/ewk_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_add):
(ewk_view_display):
(ewk_view_image_data_set):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

2:56 AM Changeset in webkit [104803] by vsevik@chromium.org
  • 603 edits in trunk

Make default console messages line numbers consistent.
​https://bugs.webkit.org/show_bug.cgi?id=74075

Reviewed by Pavel Feldman.

Source/WebCore:

Added default values for Console::addMessage sourceURL, lineNumber and
callStack parameters, moved lineNumber after sourceURL.
Made virtual method ScriptExecutionContext::addMessage private
Added default values to ScriptExecutionContext::AddConsoleMessage sourceURL, lineNumber and
callStack parameters, moved lineNumber after sourceURL.
Reorder ScriptExecutionContext::logExceptionToConsole parameters, move lineNumber after sourceURL.
Reordered sourceURL and lineNumber parameters in inspector methods.
Made all calls to Console::addMessage() pass 0 as lineNumber by default (i.e. when line number is unknown / irrelevant).
Unset line numbers are not printed to console in QT now.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::addConsoleMessage):

  • dom/ScriptExecutionContext.h:
  • dom/UIEvent.cpp:

(WebCore::UIEvent::warnDeprecatedLayerXYUsage):

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::printWarningToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/ConsoleMessage.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::shouldAllowNavigation):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/Console.cpp:

(WebCore::Console::addMessage):
(WebCore::Console::groupEnd):

  • page/Console.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::printErrorMessage):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::logErrorMessage):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):

  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::postConsoleMessageTask):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/chromium:

Unset line numbers are not printed to console now.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::addMessageToConsole):

Source/WebKit/qt:

Unset line numbers are not printed to console now.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptConsoleMessage):

Tools:

Unset line numbers are not printed to console now.
Added Source/WebCore/inspector to efl DumpRenderTree include path.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didAddMessageToConsole):

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onConsoleMessage):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewConsoleMessage):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::javaScriptConsoleMessage):

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole):

  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(LayoutWebViewEventHandler::OnConsoleMessageEvent):

LayoutTests:

Removed unset line numbers in console messages from test expectations.

  • fast/canvas/svg-taint-expected.txt:
  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/events/init-events-expected.txt:
  • fast/events/mouse-relative-position-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/simulated-click-coords-expected.txt:
  • fast/forms/interactive-validation-prevented-expected.txt:
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt:
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt:
  • fast/xpath/nsresolver-bad-object-expected.txt:
  • http/tests/appcache/local-content-expected.txt:
  • http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
  • http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt:
  • http/tests/eventsource/eventsource-content-type-charset-expected.txt:
  • http/tests/history/cross-origin-replace-history-object-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/network-preflight-options-expected.txt:
  • http/tests/inspector/network/x-frame-options-deny-expected.txt:
  • http/tests/misc/bubble-drag-events-expected.txt:
  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/image-blocked-src-change-expected.txt:
  • http/tests/misc/image-blocked-src-no-change-expected.txt:
  • http/tests/misc/unloadable-script-expected.txt:
  • http/tests/plugins/cross-frame-object-access-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
  • http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
  • http/tests/security/canvas-remote-read-svg-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-delete-expected.txt:
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-history-get-expected.txt:
  • http/tests/security/cross-frame-access-history-put-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-put-expected.txt:
  • http/tests/security/cross-frame-access-name-getter-expected.txt:
  • http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
  • http/tests/security/cross-frame-access-object-prototype-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-selection-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/filesystem-iframe-from-remote-expected.txt:
  • http/tests/security/frame-loading-via-document-write-expected.txt:
  • http/tests/security/frameNavigation/not-opener-expected.txt:
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt:
  • http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
  • http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
  • http/tests/security/local-CSS-from-remote-expected.txt:
  • http/tests/security/local-JavaScript-from-remote-expected.txt:
  • http/tests/security/local-iFrame-from-remote-expected.txt:
  • http/tests/security/local-image-from-remote-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
  • http/tests/security/postMessage/target-origin-expected.txt:
  • http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
  • http/tests/security/sandboxed-iframe-modify-self-expected.txt:
  • http/tests/security/sandboxed-iframe-origin-add-expected.txt:
  • http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • http/tests/security/view-source-no-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-hash-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-host-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-hostname-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-pathname-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-protocol-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-reload-expected.txt:
  • http/tests/security/xss-DENIED-assign-location-search-expected.txt:
  • http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt:
  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-frame-name-expected.txt:
  • http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt:
  • http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt:
  • http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
  • http/tests/security/xss-DENIED-javascript-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
  • http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
  • http/tests/security/xss-DENIED-synchronous-form-expected.txt:
  • http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt:
  • http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt:
  • http/tests/security/xss-DENIED-window-open-parent-expected.txt:
  • http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
  • http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/dom-write-URL-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/iframe-injection-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt:
  • http/tests/security/xssAuditor/property-escape-expected.txt:
  • http/tests/security/xssAuditor/property-escape-long-expected.txt:
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-handshake-crash-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty-expected.txt:
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
  • http/tests/websocket/tests/hixie76/close-before-open-expected.txt:
  • http/tests/websocket/tests/hixie76/frame-length-overflow-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-error-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null-expected.txt:
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch-expected.txt:
  • http/tests/websocket/tests/hixie76/long-invalid-header-expected.txt:
  • http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query-expected.txt:
  • http/tests/websocket/tests/hixie76/websocket-event-target-expected.txt:
  • http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt:
  • http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
  • http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/close-expected.txt:
  • http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt:
  • http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt:
  • http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt:
  • http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/workers/close-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-sync-not-supported-expected.txt:
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
  • http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
  • http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt:
  • http/tests/xmlhttprequest/cross-origin-no-credential-prompt-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-sync-2-expected.txt:
  • http/tests/xmlhttprequest/cross-site-denied-response-sync-expected.txt:
  • http/tests/xmlhttprequest/get-dangerous-headers-expected.txt:
  • http/tests/xmlhttprequest/getResponseHeader-expected.txt:
  • http/tests/xmlhttprequest/onerror-event-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt:
  • http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt:
  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
  • http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
  • jquery/event-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-non-ascii-expected.txt:
  • platform/chromium-win/websocket/tests/url-parsing-expected.txt:
  • platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt:
  • platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt:
  • platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt:
  • platform/chromium/fast/events/onunload-expected.txt:
  • platform/chromium/fast/events/onunload-not-on-body-expected.txt:
  • platform/chromium/fast/events/onunload-window-property-expected.txt:
  • platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt:
  • platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt:
  • platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt:
  • platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
  • platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
  • platform/chromium/http/tests/security/window-named-proto-expected.txt:
  • platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
  • platform/chromium/media/csp-blocks-video-expected.txt:
  • platform/chromium/plugins/document-open-expected.txt:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
  • platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
  • plugins/document-open-expected.txt:
  • plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt:
  • plugins/geturlnotify-during-document-teardown-expected.txt:
  • plugins/netscape-plugin-map-data-to-src-expected.txt:
  • plugins/netscape-plugin-setwindow-size-2-expected.txt:
  • plugins/netscape-plugin-setwindow-size-expected.txt:
  • plugins/no-mime-with-valid-extension-expected.txt:
  • plugins/open-and-close-window-with-plugin-expected.txt:
  • plugins/pass-different-npp-struct-expected.txt:
  • plugins/window-open-expected.txt:
  • storage/open-database-creation-callback-expected.txt:
  • storage/open-database-set-empty-version-expected.txt:
2:22 AM Changeset in webkit [104802] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

Add RenderStyle::isPositioned() helper method
​https://bugs.webkit.org/show_bug.cgi?id=75959

Reviewed by Tony Chang.

No new tests since this is refactoring of existing code.

Replace (style()->position() == AbsolutePosition
style()->position() == FixedPosition)

with (style()->isPositioned()).
Replace (style()->position() != AbsolutePosition && style()->position() != FixedPosition)
with (!style()->isPositioned()).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::offsetFromContainer):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::isPositioned):

2:17 AM Changeset in webkit [104801] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
2:08 AM Changeset in webkit [104800] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Network is not available when SOUP is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=76112

Reviewed by Andreas Kling.

ecore_main_loop_glib_integrate should be called to use glib based library
such as SOUP.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

1:50 AM Changeset in webkit [104799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Modify some API's implementation to let it directly pass Eina_Rectangle into IntRect.
​https://bugs.webkit.org/show_bug.cgi?id=75695

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-01-12
Reviewed by Andreas Kling.

Dereference Eina_Rectangle pointers so the shorter IntRect constructor can be used.

  • ewk/ewk_view.cpp:

(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint):
(ewk_view_paint_contents):

1:46 AM Changeset in webkit [104798] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add PLATFORM(EFL) in SharedMemory.h, WebProcessStore.h, WebEditorClient.cpp
​https://bugs.webkit.org/show_bug.cgi?id=76115

Reviewed by Andreas Kling.

This patch added PLATFORM(EFL) guard in SharedMemory.h to use UNIX_DOMAIN_SOCKETS
and WebProcessStore.h to have font family preference
and WebEditorClient.cpp to use platform specific handleKeyboardEvent(),
handleInputMethodKeydown()

  • Platform/SharedMemory.h:
  • Shared/WebPreferencesStore.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
12:02 AM Changeset in webkit [104797] by pfeldman@chromium.org
  • 3 edits in branches/chromium/963

Merge 104714 - Web Inspector: "undefined" instead of error message in the SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=76060

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.get message):

LayoutTests:

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • inspector/debugger/source-frame-expected.txt:

TBR=​pfeldman@chromium.org
BUG=109861
Review URL: ​http://codereview.chromium.org/9193003

Note: See TracTimeline for information about the timeline view.