Timeline
Mar 5, 2012:
- 11:59 PM Changeset in webkit [109870] by
-
- 4 edits in trunk/Source/WebCore
WebAudio JSC-related fixes
https://bugs.webkit.org/show_bug.cgi?id=80299
Reviewed by Adam Barth.
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
Wrap the audio context in a DOM wrapper.
- webaudio/AudioContext.idl: No need to protect EventTarget by V8
guards, I think.
- webaudio/JavaScriptAudioNode.idl: Ditto.
- 11:40 PM Changeset in webkit [109869] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix pt 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:35 PM Changeset in webkit [109868] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new crashing tests,
because crashes aren't bugs but features. :)
- platform/qt-5.0-wk2/Skipped:
- 11:31 PM Changeset in webkit [109867] by
-
- 4 edits3 adds in trunk
Element not fully repainted after application and removal of transform
https://bugs.webkit.org/show_bug.cgi?id=61338
Source/WebCore:
Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-05
Reviewed by Simon Fraser.
RenderLayer is created and removed when a transform is applied and removed to element.
To render the element properly after removal of transform on it, preferred widths and dimensions of
the element and its containing block needs to be recalculated.
Test: fast/repaint/transform-rotate-and-remove.html
- rendering/RenderBoxModelObject.cpp:
(WebCore):
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
LayoutTests:
Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-05
Reviewed by Simon Fraser.
Test to remove the transform property of an element upon onload event.
- fast/repaint/transform-rotate-and-remove.html: Added.
- platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.png: Added.
- platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
- 11:23 PM Changeset in webkit [109866] by
-
- 56 edits in trunk
putByIndex should throw in strict mode
https://bugs.webkit.org/show_bug.cgi?id=80335
Reviewed by Filip Pizlo.
Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter.
Source/JavaScriptCore:
This is a largely mechanical change, simply adding an extra parameter to a number
of functions. Some call sites need perform additional exception checks, and
operationPutByValBeyondArrayBounds needs to know whether it is strict or not.
This patch doesn't fix a missing throw from some cases of shift/unshift (this is
an existing bug), I'll follow up with a third patch to handle that.
- API/JSObjectRef.cpp:
(JSObjectSetPropertyAtIndex):
- JSCTypedArrayStubs.h:
(JSC):
- dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jsc.cpp:
(GlobalObject::finishCreation):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::putByIndex):
- runtime/Arguments.h:
(Arguments):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
- runtime/ClassInfo.h:
(MethodTable):
- runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
- runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
- runtime/JSByteArray.cpp:
(JSC::JSByteArray::putByIndex):
- runtime/JSByteArray.h:
(JSByteArray):
- runtime/JSCell.cpp:
(JSC::JSCell::putByIndex):
- runtime/JSCell.h:
(JSCell):
- runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::putByIndex):
- runtime/JSNotAnObject.h:
(JSNotAnObject):
- runtime/JSONObject.cpp:
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
- runtime/JSObject.h:
(JSC::JSValue::putByIndex):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::fillArrayInstance):
- runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::putByIndex):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
Source/WebCore:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::setSlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::putByIndex):
- bridge/runtime_array.h:
(RuntimeArray):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::setProperty):
Source/WebKit2:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::setProperty):
LayoutTests:
- fast/js/Object-defineProperty-expected.txt:
- fast/js/mozilla/strict/15.4.4.12-expected.txt:
- fast/js/mozilla/strict/15.4.4.13-expected.txt:
- fast/js/mozilla/strict/15.4.4.8-expected.txt:
- fast/js/mozilla/strict/15.4.4.9-expected.txt:
- fast/js/mozilla/strict/15.5.5.2-expected.txt:
- fast/js/mozilla/strict/8.12.5-expected.txt:
- fast/js/preventExtensions-expected.txt:
- fast/js/primitive-property-access-edge-cases-expected.txt:
- Checking in passing test results.
- fast/js/script-tests/Object-defineProperty.js:
- Added test cases for putting to numeric properties where property is read-only, length is read-only, or property is accessor with missing set function.
- fast/js/script-tests/preventExtensions.js:
- Added test case, putting numeric property to non-extensible array.
- fast/js/script-tests/primitive-property-access-edge-cases.js:
- Enabled test cases for putting numeric properties to primitive strings.
- 11:02 PM Changeset in webkit [109865] by
-
- 2 edits in trunk/Source/JavaScriptCore
PredictNone is incorrectly treated as isDoublePrediction
https://bugs.webkit.org/show_bug.cgi?id=80365
Reviewed by Filip Pizlo.
Also it is incorrectly treated as isFixedIndexedStorageObjectPrediction.
- bytecode/PredictedType.h:
(JSC::isFixedIndexedStorageObjectPrediction):
(JSC::isDoublePrediction):
- 10:59 PM Changeset in webkit [109864] by
-
- 3 edits in trunk/Source/WebCore
InsertionPoint::attach should be consistent with Element.
https://bugs.webkit.org/show_bug.cgi?id=80373
Reviewed by Hajime Morita.
This patch is preparation for coming <shadow> patches.
InsertionPoint used to attach fallback elements before attaching distributed elements.
To be consistent with Element::attach behavior, attaching distributed elements first is
natural, because Element attaches a shadow tree first.
Also, this patch extracts a few methods form InsretionPoint::attach() and detach()
to keep code clean. They will become messy without this refactoring when adding
<shadow> patch.
No new tests. Should be covered by existing tests.
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
- 10:54 PM Changeset in webkit [109863] by
-
- 16 edits in trunk/Source/JavaScriptCore
The LLInt should work even when the JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=80340
<rdar://problem/10922235>
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::initialize):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- jit/JIT.h:
(JSC::JIT::compileCTINativeCall):
- jit/JITStubs.h:
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
- llint/LLIntEntrypoints.cpp:
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):
- llint/LLIntSlowPaths.h:
(LLInt):
- llint/LowLevelInterpreter.h:
- llint/LowLevelInterpreter32_64.asm:
- runtime/Executable.h:
(NativeExecutable):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/Options.cpp:
(Options):
(JSC::Options::parse):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- wtf/Platform.h:
- 10:31 PM Changeset in webkit [109862] by
-
- 6 edits2 deletes in trunk/Tools
Unreviewed, rolling out r109733.
http://trac.webkit.org/changeset/109733
https://bugs.webkit.org/show_bug.cgi?id=80378
It broke Qt5 build system (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05
- Tools.pro:
- qmake/config.tests/gccdepends/empty.cpp: Removed.
- qmake/config.tests/gccdepends/gccdepends.pro: Removed.
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- qmake/sync.profile:
- 10:28 PM WikiStart edited by
- Add a page about the EWS bots. (diff)
- 10:21 PM Changeset in webkit [109861] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix a number of GTK tests.
- GNUmakefile.list.am:
- 10:16 PM Changeset in webkit [109860] by
-
- 21 edits in trunk/Source
Unreviewed rollout of r109858 for restructuring.
- 10:11 PM Changeset in webkit [109859] by
-
- 2 edits in trunk/Source/JavaScriptCore
Checks for dead variables are not sufficient when fixing the expected
values in DFG OSR entry
https://bugs.webkit.org/show_bug.cgi?id=80371
Reviewed by Filip Pizlo.
A dead variable should be identified when there's no node referencing it.
But we currently failed to catch the case where there are some nodes
referencing a variable but those nodes are actually not referenced by
others so will be ignored in code generation. In such case we should
also consider that variable to be a dead variable in the block and fix
the expected values.
This is performance neutral on SunSpider, V8 and Kraken.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- 10:03 PM Changeset in webkit [109858] by
-
- 21 edits in trunk/Source
<http://webkit.org/b/78575> Web Inspector: Hide dock button when not allowed to dock
Source/WebCore:
There are times when an undocked inspector frontend is not allowed to
attach to the main window. We can remove the dock button in those cases.
Reviewed by Timothy Hatcher.
No new tests. This functionality is port specific right now.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
When the main frame is resized we let the inspector frontend client
update its docked availability.
- WebCore.exp.in:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didResizeMainFrameImpl):
(WebCore::InspectorInstrumentation::didResizeMainFrame):
- inspector/InspectorClient.h:
(WebCore::InspectorClient::updateDockingAvailability):
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::resume):
(WebCore::InspectorController::updateDockingAvailability):
When the main frame is resized call up to the InspectorClient to let
it update docking availability of the inspector frontend.
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):
On ports where the inspector frontend client is local, provide a
setDockingUnavailable InspectorFrontendAPI to update the docking state.
Automatically update availablity when the frontend completes loading.
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setDockingUnavailable):
- inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.setAttachedWindow):
(WebInspector.setDockingUnavailable):
(WebInspector.updateDockToggleButtonVisibility):
Update the dock button's visibility when its created, when the attached
state changes, when get a frontend API notification that we cannot attach.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::updateDockingAvailability):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::updateDockingAvailability):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::updateDockingAvailability):
- WebProcess/WebPage/WebInspector.h:
- 9:26 PM Changeset in webkit [109857] by
-
- 2 edits in tags/Safari-536.2.1/Source/WebCore
Merged r109847.
- 9:24 PM Changeset in webkit [109856] by
-
- 10 edits in tags/Safari-536.2.1/Source
Merged r109843.
- 9:23 PM Changeset in webkit [109855] by
-
- 7 edits in tags/Safari-536.2.1/Source
Merged r109812.
- 9:20 PM Changeset in webkit [109854] by
-
- 6 edits in tags/Safari-536.2.1/Source
Merged r109801.
- 9:19 PM Changeset in webkit [109853] by
-
- 12 edits in tags/Safari-536.2.1/Source/WebCore
Merged r109788.
- 9:15 PM Changeset in webkit [109852] by
-
- 6 edits4 copies in tags/Safari-536.2.1
Merged r109594.
- 9:13 PM Changeset in webkit [109851] by
-
- 7 edits4 adds in trunk
Compositing overlap testing can throw layers into compositing when they should not be.
https://bugs.webkit.org/show_bug.cgi?id=50192
Reviewed by Simon Fraser.
Source/WebCore:
The previous overlap map behavior was that a non-composited query
layer would become composited due to overlap if and only if the query
layer's absolute bounds overlapped the absolute bounds of some other
layer which:
- draws before the query layer
- is or has a compositing ancestor
This behavior, while correct, was too permissive in throwing layers
into compositing, causing many layers to get their own backing when
they could have just gone into their compositing ancestor's backing.
The correct logic is that non-composited query layer needs to be
composited due to overlap if and only if the query layer's absolute
bounds overlap the absolute bounds of some other layer which:
- draws before the query layer
- has a different compositing ancestor than the query layer
- is or has a compositing ancestor that is a descendent of the query layer's compositing ancestor
This patch changes the semantics of the overlap map to enable this
behavior.
Rather than having one global overlap map, there is now a stack of
overlap maps. New (empty) overlap maps are pushed onto the stack
whenever a layer becomes a compositing ancestor and popped after all
of the compositing requirements for that layer's children have been
computed.
The compositing ancestor and all of its non-composited children of a
compositing ancestor do not get considered for overlap until their
composited ancestor has been popped off the stack. If a compositing
ancestor has a compositing subtree, then any descendents of that
compositing ancestor that draw after that subtree will consider
everything in the compositing subtree for overlap.
Test: compositing/layer-creation/stacking-context-overlap.html
- platform/graphics/Region.cpp:
(WebCore::Region::intersects):
(WebCore):
- platform/graphics/Region.h:
(Region):
- rendering/RenderLayerCompositor.cpp:
(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::contains):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::isEmpty):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
LayoutTests:
- compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
- compositing/layer-creation/stacking-context-overlap.html: Added.
- compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
- compositing/layer-creation/stacking-context-overlap-nested.html: Added.
- platform/chromium/test_expectations.txt:
- 9:09 PM Changeset in webkit [109850] by
-
- 2 edits in tags/Safari-536.2.1/Source/WebCore
Merged r109486.
- 9:07 PM Changeset in webkit [109849] by
-
- 4 edits in tags/Safari-536.2.1/Source
Versioning.
- 9:04 PM Changeset in webkit [109848] by
-
- 2 edits in tags/Safari-536.2.1/Source/WebCore
Merged r109379.
- 8:57 PM Changeset in webkit [109847] by
-
- 2 edits in trunk/Source/WebCore
Address review comments from https://bugs.webkit.org/show_bug.cgi?id=80368
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplayInRect):
- 8:54 PM Changeset in webkit [109846] by
-
- 3 edits2 adds in trunk
[Forms] HTMLFieldSetForms.idl doesn't have type attribute.
https://bugs.webkit.org/show_bug.cgi?id=80109
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/fieldset/fieldset-type.html
- html/HTMLFieldSetElement.idl: Add attribute "type"
LayoutTests:
- fast/forms/fieldset/fieldset-type-expected.txt: Added.
- fast/forms/fieldset/fieldset-type.html: Added.
- 8:54 PM Changeset in webkit [109845] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix Qt build.
- 8:51 PM Changeset in webkit [109844] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScale):
- 8:33 PM Changeset in webkit [109843] by
-
- 10 edits in trunk/Source
pinch-to-zoom and double-tap flicker when using the new scrolling model
https://bugs.webkit.org/show_bug.cgi?id=80368
<rdar://problem/10866221>
Reviewed by Sam Weinig.
Source/WebCore:
In order to work better with zooming, make the tile cache undo the scale transformation
and handle the scaling manually. This avoids creating huge tile backing stores when zoomed in.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
Initialize m_scale to 1.
(WebCore::TileCache::setNeedsDisplayInRect):
Scale the given rect appropriately.
(WebCore::TileCache::drawLayer):
Apply a scale context transform.
(WebCore::TileCache::setScale):
No longer set the contents scale. Instead, update the scale and revalidate the tiles.
(WebCore::TileCache::revalidateTiles):
Return early if the bounds are empty. This avoids showing a single tile if that happens due to a race condition.
(WebCore::TileCache::getTileIndexRangeForRect):
Apply the scale to the bounds.
(WebCore::TileCache::createTileLayer):
Don't set the contents scale.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setScale.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
Make sure to give the tile cache layer sane composited bounds, even if the page has absolutely positioned
elements that are outside of the page.
Source/WebKit2:
Add a way for drawing areas to respond to callback based force repaint requests asynchronously.
This is currently needed for the tiled drawing area when there might be outstanding scroll updates
that are sent from the scrolling thread to the main thread and we need to ensure that they're processed
before sending a message back.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::forceRepaintAsync):
Add new member function.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
Try forceRepaintAsync first.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::forceRepaintAndSendMessage):
Force the repaint and send the message.
(WebKit::dispatchBackToMainThread):
Dispatch a call to forceRepaintAndSendMessage to the main thread.
(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
Dispatch a function on the scrolling thread. Its sole purpose is to dispatch a function back to the
main thread, ensuring that all previously dispatched functions have been executed.
- 8:32 PM Changeset in webkit [109842] by
-
- 1 copy in tags/Safari-536.2.1
New Tag.
- 8:24 PM Changeset in webkit [109841] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContext3D.h should include RefCounted.h explicitly
https://bugs.webkit.org/show_bug.cgi?id=80251
Reviewed by Rob Buis.
GraphicsContext3D.h was using RefCounted but including RefCounted.h indirectly
through GraphicsLayer.h through Animation.h. However Animation.h is included
by GraphicsLayer.h only when ACCELERATED_COMPOSITING is on. For some configurations
that don't use ACCELERATED_COMPOSITING but use GraphicsContext3D, like the
BlackBerry x86 configuration, the indirect inclusion will fail.
This patch is adding explicit inclusion of RefCounted.h to avoid that kind of
problem.
- platform/graphics/GraphicsContext3D.h:
- 8:20 PM Changeset in webkit [109840] by
-
- 6 edits4 adds in trunk
[WebSocket] Should raise SYNTAX_ERR when message contains unpaired surrogates
https://bugs.webkit.org/show_bug.cgi?id=80103
Reviewed by Kent Tamura.
Source/WebCore:
Add UTF8 validation checks for WebSocket message and close reason.
Tests: http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html
http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send): Raise SYNTAX_ERR if the message is invalid.
(WebCore::WebSocket::close):Raise SYNTAX_ERR if the reason is invalid.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send): Check whether message is a valid UTF8 string.
LayoutTests:
Added tests for unpaired surrogates check for WebSocket message and close reason.
Updated two expectations for close() tests because further error message is added.
- http/tests/websocket/tests/hybi/close-expected.txt: Updated.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Added.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Added.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Added.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Added.
- http/tests/websocket/tests/hybi/workers/close-expected.txt: Updated.
- 8:15 PM Changeset in webkit [109839] by
-
- 10 edits in trunk/Source
[chromium] Notify CCLayerImpl tree of context loss and restoration
https://bugs.webkit.org/show_bug.cgi?id=80339
Reviewed by James Robinson.
Source/WebCore:
Tested by manually killing GPU process while playing Flash video.
Video continues to play after compositor restores its context.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::didLoseAndRecreateGraphicsContext):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::sendContextLostAndRestoredNotification):
(WebCore):
(WebCore::CCLayerTreeHostImpl::sendContextLostAndRestoredNotificationRecursive):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::didLoseAndRecreateGraphicsContext):
(WebCore):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(CCPluginLayerImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::recreateContext):
Source/WebKit/chromium:
Unit test for notification of context loss and restoration.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit):
(ContextLostNotificationCheckLayer):
(WebKit::ContextLostNotificationCheckLayer::create):
(WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContext):
(WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContextCalled):
(WebKit::ContextLostNotificationCheckLayer::ContextLostNotificationCheckLayer):
(WebKit::TEST_F):
- 8:02 PM Changeset in webkit [109838] by
-
- 12 edits in trunk/Source
Change the argument orders to match OpenGL's in GraphicsContext3D functions
https://bugs.webkit.org/show_bug.cgi?id=80120
Patch by Changhun Kang <temoochin@company100.net> on 2012-03-05
Reviewed by Kenneth Russell.
No new tests because this patch just change the order of arguments.
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawTexturedQuad):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::bindProgramAndBuffers):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
Source/WebKit/chromium:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore):
- src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- 7:37 PM Changeset in webkit [109837] by
-
- 36 edits in trunk
Source/JavaScriptCore: Update JavaScriptCore files to use fully-qualified WTF include paths
https://bugs.webkit.org/show_bug.cgi?id=79960
Reviewed by Adam Barth.
This change does 5 small/related things:
- Updates JavaScriptCore.xcodeproj to install WTF headers into $BUILD/usr/local/include (WebCore, WebKit were already setup to look there, but JavaScriptCore.xcodeproj was not installing headers there.)
- Makes JavaScriptCore targets include $BUILD/usr/local/include in their header search path, as that's where the WTF headers will be installed.
- Similarly updates JavaScriptCore.vcproj/copy-files.cmd to copy WTF headers to PrivateHeaders/wtf/* in addition to the current behavior of flattening all headers to PrivateHeaders/*.h.
- Updates a bunch of JSC files to use #include <wtf/Foo.h> instead of #include "Foo.h" since soon the WTF headers will not be part of the JavaScriptCore Xcode project.
- Makes build-webkit build the WTF XCode project by default.
- API/tests/JSNode.c:
- API/tests/JSNodeList.c:
- Configurations/Base.xcconfig:
- assembler/MacroAssemblerCodeRef.h:
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGOperations.cpp:
- heap/GCAssertions.h:
- heap/HandleHeap.h:
- heap/HandleStack.h:
- heap/MarkedSpace.h:
- heap/PassWeak.h:
- heap/Strong.h:
- heap/Weak.h:
- jit/HostCallReturnValue.cpp:
- jit/JIT.cpp:
- jit/JITStubs.cpp:
- jit/ThunkGenerators.cpp:
- parser/Lexer.cpp:
- runtime/Completion.cpp:
- runtime/Executable.cpp:
- runtime/Identifier.h:
- runtime/InitializeThreading.cpp:
- runtime/JSDateMath.cpp:
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/JSStringBuilder.h:
- runtime/JSVariableObject.h:
- runtime/NumberPrototype.cpp:
- runtime/WriteBarrier.h:
- tools/CodeProfile.cpp:
- tools/TieredMMapArray.h:
- yarr/YarrJIT.cpp:
Tools: Update JavaScriptCore files to use fully-qualified WTF include path
https://bugs.webkit.org/show_bug.cgi?id=79960
Reviewed by Adam Barth.
Build WTF/WTF.xcodeproj by default on Mac.
- Scripts/build-webkit:
- 7:07 PM Changeset in webkit [109836] by
-
- 3 edits3 adds in trunk
Source/WebCore: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=80108
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.
Test: fast/forms/fieldset/fieldset-name.html
- html/HTMLFieldSetElement.idl: Add "name" attribute.
LayoutTests: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=81008
Test read/write attribute "name" of fieldset element.
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.
- fast/forms/fieldset/fieldset-name-expected.txt: Added.
- fast/forms/fieldset/fieldset-name.html: Added.
- 6:42 PM Changeset in webkit [109835] by
-
- 6 edits in trunk/Source/WebCore
Update usage of LayoutUnits in RenderBox
https://bugs.webkit.org/show_bug.cgi?id=80039
Reviewed by Julien Chaffraix.
Updating the usage of integers versus LayoutUnits in RenderBox to mirror the
subpixellayout branch. This reverts absoluteRects, intrinsicSize, and focusRingRects
methods to use integers, and flipForWritingMode functions to LayoutUnits.
No new tests. No change in behavior.
- platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedX): Convenience methods that only calculate
the needed values. This requires less computation than pixelSnappedIntRect(r).x().
(WebCore::FractionalLayoutRect::pixelSnappedY): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedWidth): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedHeight): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedMaxX): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedMaxY): Ditto.
(FractionalLayoutRect):
- platform/graphics/IntRect.h:
(IntRect):
(WebCore::IntRect::pixelSnappedX): Stub methods to allow us to use IntRects like we do
FractionalLayoutRects.
(WebCore::IntRect::pixelSnappedY): Ditto.
(WebCore::IntRect::pixelSnappedMaxX): Ditto.
(WebCore::IntRect::pixelSnappedMaxY): Ditto.
(WebCore::IntRect::pixelSnappedWidth): Ditto.
(WebCore::IntRect::pixelSnappedHeight): Ditto.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect): Convenience method for building a pixelSnappedIntRect from
a LayoutPoint and LayoutSize without constructing an intermediate LayoutRect.
(WebCore):
(WebCore::snapSizeToPixel): Stub method for snapping a LayoutUnit representing a size to
its pixel value using its location.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth): Changing to actually call snapSizeToPixel.
(WebCore::RenderBox::pixelSnappedClientHeight): Ditto.
(WebCore::RenderBox::absoluteRects): Switching to return IntRects that represent the actual
rendered location on screen.
(WebCore::RenderBox::addFocusRingRects): Ditto.
(WebCore::RenderBox::paintFillLayer): One-liner switching an IntSize() to LayoutSize() to
avoid unnecessary conversion.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Preparing for the conversion by
replacing 0 with zeroLayoutUnit.
(WebCore::RenderBox::positionLineBox): Preparing for conversion by replacing lroundf
with roundedLayoutUnit.
(WebCore::RenderBox::flipForWritingMode): Switching to use LayoutUnits.
- rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::pixelSnappedBorderBoxRect): Convenience method.
(WebCore::RenderBox::borderBoundingBox): Converting to a pixelSnappedIntRect.
(WebCore::RenderBox::intrinsicSize): Intrinsic sizes should always be integers.
- 6:40 PM Changeset in webkit [109834] by
-
- 22 edits in trunk/Source/JavaScriptCore
Add basic support for constant blinding to the JIT
https://bugs.webkit.org/show_bug.cgi?id=80354
Reviewed by Filip Pizlo.
This patch adds basic constant blinding support to the JIT, at the
MacroAssembler level. This means all JITs in JSC (Yarr, baseline, and DFG)
get constant blinding. Woo!
This patch only introduces blinding for Imm32, a later patch will do similar
for ImmPtr. In order to make misuse of Imm32 as a trusted type essentially
impossible, we make TrustedImm32 a private parent of Imm32 and add an explicit
accessor that's needed to access the actual value. This also means you cannot
accidentally pass an untrusted value to a function that does not perform
blinding.
To make everything work sensibly, this patch also corrects some code that was using
Imm32 when TrustedImm32 could be used, and refactors a few callers that use
untrusted immediates, so that they call slightly different varaints of the functions
that they used previously. This is largely necessary to deal with x86-32 not having
sufficient registers to handle the additional work required when we choose to blind
a constant.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Imm32::asTrustedImm32):
(Imm32):
(JSC::AbstractMacroAssembler::beginUninterruptedSequence):
(JSC::AbstractMacroAssembler::endUninterruptedSequence):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::inUninterruptedSequence):
(JSC::AbstractMacroAssembler::random):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::addressForPoke):
(MacroAssembler):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::convertInt32ToDouble):
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::BlindedImm32::BlindedImm32):
(BlindedImm32):
(JSC::MacroAssembler::keyForConstant):
(JSC::MacroAssembler::xorBlindConstant):
(JSC::MacroAssembler::additionBlindedConstant):
(JSC::MacroAssembler::andBlindedConstant):
(JSC::MacroAssembler::orBlindedConstant):
(JSC::MacroAssembler::loadXorBlindedConstant):
(JSC::MacroAssembler::add32):
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::and32):
(JSC::MacroAssembler::andPtr):
(JSC::MacroAssembler::move):
(JSC::MacroAssembler::or32):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::sub32):
(JSC::MacroAssembler::subPtr):
(JSC::MacroAssembler::xor32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
(JSC::MacroAssembler::branchSub32):
(JSC::MacroAssembler::trustedImm32ForShift):
(JSC::MacroAssembler::lshift32):
(JSC::MacroAssembler::rshift32):
(JSC::MacroAssembler::urshift32):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::scratchRegisterForBlinding):
(JSC::MacroAssemblerARMv7::shouldBlindForSpecificArch):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchSubPtr):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::scratchRegisterForBlinding):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):
(JSC::JIT::emitValueProfilingSite):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
- jit/JITStubCall.h:
(JITStubCall):
(JSC::JITStubCall::addArgument):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::backtrack):
- 6:30 PM Changeset in webkit [109833] by
-
- 13 edits3 copies in trunk/Source/WebCore
WorkerContext shouldn't need to know about SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=80352
Reviewed by Eric Seidel.
This patch removes the SQLDatabase functions from WorkerContext in
preparation for moving the SQLDatabase code into a module. These
functions don't interact with the rest of WorkerContext.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/DOMWindowSQLDatabase.cpp:
- storage/WorkerContextSQLDatabase.cpp: Added.
(WebCore):
(WebCore::WorkerContextSQLDatabase::openDatabase):
(WebCore::WorkerContextSQLDatabase::openDatabaseSync):
- storage/WorkerContextSQLDatabase.h: Added.
(WebCore):
(WorkerContextSQLDatabase):
(WebCore::WorkerContextSQLDatabase::WorkerContextSQLDatabase):
(WebCore::WorkerContextSQLDatabase::~WorkerContextSQLDatabase):
- storage/WorkerContextSQLDatabase.idl: Added.
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 6:11 PM Changeset in webkit [109832] by
-
- 9 edits in trunk/Source/WebCore
[WebSocket] Introduce ThreadableWebSocketChannel::SendResult
https://bugs.webkit.org/show_bug.cgi?id=80356
Reviewed by Kent Tamura.
Introduced ThreadableWebSocketChannel::SendResult type so that
WebSocketChannel can pass the validation result.
No new test. No changes in behavior.
- Modules/websockets/ThreadableWebSocketChannel.h: Added SendResult.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult): Ditto.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
(ThreadableWebSocketChannelClientWrapper):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool. Pass Cstring to enqueTextFrame instead of String.
(WebCore::WebSocketChannel::enqueueTextFrame): Ditto.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Ditto.
- Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
(QueuedFrame): Changed the type of stringData from String to CString.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::workerContextDidSend): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Peer::send): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send): Ditto.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel): ditto.
(Bridge): Ditto.
- 6:04 PM Changeset in webkit [109831] by
-
- 3 edits in trunk/Tools
There should be a way to disable optimizer in webkit-patch rebaseline-expectations
https://bugs.webkit.org/show_bug.cgi?id=69590
Reviewed by Ryosuke Niwa.
Adds a --no-optimize flag to webkit-patch rebaseline-expectations
to skip the 'optimize-expectations' step.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.init):
(RebaselineExpectations.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- 5:56 PM Changeset in webkit [109830] by
-
- 1 edit2 adds in trunk/LayoutTests
add tests for multiline flexbox and flex-pack
https://bugs.webkit.org/show_bug.cgi?id=80342
Reviewed by Ojan Vafai.
- css3/flexbox/multiline-pack-expected.txt: Added.
- css3/flexbox/multiline-pack.html: Added.
- 5:51 PM Changeset in webkit [109829] by
-
- 2 edits in trunk/Source/WebCore
[JSC] Cache the CSSPropertyID in JSCSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=80250
Reviewed by Benjamin Poulain.
V8CSSStyleDeclaration caches the calculated CSSPropertyID.
Similarly, we can implement the cache in JSCSSStyleDeclaration.
In my local Mac environment, this optimization improves the performance
of CSS property getters by 35%, and the performance of CSS property setters
by 8%.
CSS property getter: for (var i = 0; i < 1000000; i++) span.style.fontWeight;
CSS property setter: for (var i = 0; i < 1000000; i++) span.style.fontWeight = "bold";
Tests: fast/dom/CSSStyleDeclaration/* (No change in test results)
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):
- 5:41 PM Changeset in webkit [109828] by
-
- 4 edits2 adds in trunk/LayoutTests
Basic IndexedDB shared worker test
https://bugs.webkit.org/show_bug.cgi?id=80189
Reviewed by Tony Chang.
- fast/js/resources/js-test-pre.js:
(startWorker.worker.port.onmessage):
- platform/chromium/test_expectations.txt:
- storage/indexeddb/basics-shared-workers-expected.txt: Added.
- storage/indexeddb/basics-shared-workers.html: Added.
- storage/indexeddb/resources/shared.js:
(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
(done):
(unexpectedErrorCallback):
- 5:38 PM Changeset in webkit [109827] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=80089
Change class hierarchy of WebOptionElement to match with specification.
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.
- public/WebOptionElement.h: Replace to WebElement from WebFormControlElement
(WebKit::WebOptionElement::WebOptionElement):
(WebKit::WebOptionElement::operator=):
(WebKit::WebOptionElement::assign):
- src/WebOptionElement.cpp:
(WebKit::WebOptionElement::WebOptionElement):
- 5:35 PM Changeset in webkit [109826] by
-
- 2 edits in trunk/Source/WebKit2
Can't type on some websites (plug-ins steal key events).
<rdar://problem/10892291>
When the plugin is disabled, it is necessary to reset _pluginComplexTextInputIdentifier
in order to return the correct input context. Failure to do so results in the inputContext
method to return the plugin input context instead of the context of the browser view.
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:]):
(-[WKView _handlePluginComplexTextInputKeyDown:]):
- 5:33 PM Changeset in webkit [109825] by
-
- 6 edits1 add in trunk/Source
IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413
Source/WebCore:
Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.
Reviewed by Tony Chang.
Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'
- Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.
(WebCore::IDBLevelDBBackingStore::open):
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::destroy):
(WebCore):
- platform/leveldb/LevelDBDatabase.h:
(LevelDBDatabase):
Source/WebKit/chromium:
Reviewed by Tony Chang.
- WebKit.gypi:
- tests/LevelDBTest.cpp: Added.
(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):
- 5:18 PM Changeset in webkit [109824] by
-
- 11 edits in trunk
putByIndex should throw in strict mode
https://bugs.webkit.org/show_bug.cgi?id=80335
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We'll need to pass an additional parameter.
Part 1 - rename JSValue::put() for integer indices to JSValue::putByIndex()
to match the method in the MethodTable, make this take a parameter indicating
whether the put should throw. This fixes the cases where the base of the put
is a primitive.
- dfg/DFGOperations.cpp:
(DFG):
(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/JSObject.h:
(JSC::JSValue::putByIndex):
- runtime/JSValue.cpp:
(JSC):
- runtime/JSValue.h:
(JSValue):
LayoutTests:
- fast/js/primitive-property-access-edge-cases-expected.txt:
- fast/js/script-tests/primitive-property-access-edge-cases.js:
(checkNumericGet.Object.defineProperty):
(checkNumericSet.Object.defineProperty):
(checkNumericGetStrict.Object.defineProperty):
(checkNumericSetStrict.Object.defineProperty):
(checkNumericRead):
(checkNumericWrite):
(checkNumericReadStrict):
(checkNumericWriteStrict):
- Added test cases.
- 5:18 PM Changeset in webkit [109823] by
-
- 2 edits in trunk/Source/WebKit/chromium
Enable context menu on android
For android, long press is converted into a right mouse down event
So we will use that to invoke the context menu
https://bugs.webkit.org/show_bug.cgi?id=80332
Patch by Min Qin <qinmin@google.com> on 2012-03-05
Reviewed by Adam Barth.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::mouseDown):
- 5:03 PM Changeset in webkit [109822] by
-
- 4 edits in branches/subpixellayout/Source/WebCore
Fixing an improper overloaded method in RenderThemeMac, cleaning up RenderBlock.cpp, and adding a size_t flavor of operator* in FractionalLayoutUnit for RenderBlock.
- 5:01 PM Changeset in webkit [109821] by
-
- 4 edits in trunk
Perf-o-matic should memcache dashboard images
https://bugs.webkit.org/show_bug.cgi?id=80349
Reviewed by Eric Seidel.
Added DashboardImage.create and DashboardImage.get_image to encapsulate memcache.
Also replaced transaction in DashboardImage.set_cache by a single put since it duplicates
what put does by default.
Also removed redundant cache_* functions and merged them into handler code.
- Websites/webkit-perf.appspot.com/controller.py:
(ManifestUpdateHandler.post):
(CachedManifestHandler.get):
(DashboardUpdateHandler.post):
(CachedDashboardHandler.get):
(RunsUpdateHandler):
(RunsUpdateHandler.post):
(RunsChartHandler):
(RunsChartHandler.post):
(DashboardImageHandler.get):
- Websites/webkit-perf.appspot.com/models.py:
(PersistentCache.set_cache):
(DashboardImage):
(DashboardImage.create):
(DashboardImage.get_image):
- Websites/webkit-perf.appspot.com/models_unittest.py:
(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set_cache):
(PersistentCacheTests.test_get_cache):
(DashboardImageTests.setUp):
(DashboardImageTests):
(DashboardImageTests.test_create):
(DashboardImageTests.test_get):
- 5:00 PM Changeset in webkit [109820] by
-
- 7 edits2 adds in trunk
[Chromium] SVG Composite of Offset crashes
https://bugs.webkit.org/show_bug.cgi?id=77245
Reviewed by Stephen White.
The feComposite arithmetic mode filter could readily be made to
generate invalid pre-multiplied pixel values which would then go on to
pollute other filters and cause invalid final output pixels. This
patch checks for filters that require valid inputs, and checks that a
result is valid, and corrects the result if necessary. This matches
the behavior of FF and Opera while preventing crashes or other
undesirable behavior.
Source/WebCore:
Test: svg/filters/feComposite-arithmetic-invalid-rgba.svg
- platform/graphics/filters/FEComposite.h: Override the default validity checks and image cleanup methods.
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::correctFilterResultIfNeeded): Force valid pixels if this is an arithmetic filter
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply): Check for validity status and correct
(WebCore::FilterEffect::forceValidPremultipliedPixels): Make an image valid
(WebCore):
- platform/graphics/filters/FilterEffect.h: New virtual methods for image validity.
(FilterEffect):
(WebCore::FilterEffect::requiresValidPreMulultipliedPixels):
(WebCore::FilterEffect::forceValidPremultipliedPixels):
(WebCore::FilterEffect::correctFilterResultIfNeeded):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource): Check that the final filter result is valid
LayoutTests:
- svg/filters/feComposite-arithmetic-invalid-rgba-expected.svg: Added.
- svg/filters/feComposite-arithmetic-invalid-rgba.svg: Added.
- 4:54 PM Changeset in webkit [109819] by
-
- 2 edits in trunk/Source/WebKit2/UIProcess
Fix 32-bit builds.
- 4:51 PM Changeset in webkit [109818] by
-
- 10 edits2 adds in trunk
getComputedStyle gives incorrect information for 'height' property
https://bugs.webkit.org/show_bug.cgi?id=33593
Reviewed by David Hyatt.
Source/WebCore:
Make sure that the contentBoxRect doesn't take into account the
intrinsic padding when querying it. As stated by http://www.w3.org/TR/css3-box/#the-lsquo0
the height is the content area which doesn't include the intrinsic padding, the border, and
the padding.
Test: fast/css/getComputedStyle/getComputedStyle-height.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
- rendering/RenderBox.h:
(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
(WebCore::RenderTableCell::cellBaselinePosition):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline):
LayoutTests:
Make sure that the contentBoxRect doesn't take into account the
intrinsic padding.
- fast/css/getComputedStyle/getComputedStyle-height-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-height.html: Added.
- 4:47 PM Changeset in webkit [109817] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=80257
Lifecycle of InternalSettings should be simplified.
Reviewed by Ryosuke Niwa.
- Moved settings update code to separate restoreTo() method.
- Eliminated flags which indidate the changed field. Now these modifiable parameters are backed up at the initialization.
No new tests. Refactoring.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::create):
(WebCore::InternalSettings::InternalSettings):
(WebCore):
(WebCore::InternalSettings::restoreTo):
- testing/InternalSettings.h:
(InternalSettings):
- testing/Internals.cpp:
(WebCore::Internals::reset):
- 4:45 PM Changeset in webkit [109816] by
-
- 5 edits2 copies in trunk
[Chromium] Add new popup type: PagePopup
https://bugs.webkit.org/show_bug.cgi?id=80106
Reviewed by Darin Fisher.
Source/WebKit/chromium:
This is a preparation of implementing ChromeClient::openPagePopup and
closePagePopup.
- WebKit.gyp: Add WebPagePopup.h and WebPagePopupImpl.cpp.
- public/WebPagePopup.h:
(WebPagePopup): Add WebPagePopup interface.
- public/WebPopupType.h: Add WebPopupTypePage.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopup::create): Temprary implementation which just returns 0.
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createPopupMenu):
- 4:41 PM Changeset in webkit [109815] by
-
- 2 edits in trunk/Tools
Add myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
Also, add my IRC nick so it is easier to find and yell at me.
- 4:31 PM Changeset in webkit [109814] by
-
- 2 edits in trunk/Source/WebKit/blackberry
The minimum font size WebSetting should actually change the LOGICAL font size in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=80312
RIM PR: 139874
Reviewed by George Staikos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 4:20 PM Changeset in webkit [109813] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
The Bugzilla autocompleter doesn't support multiple Unicode characters per name
https://bugs.webkit.org/show_bug.cgi?id=80319
Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-03-05
Reviewed by Adam Barth.
The current regular expression for matching Unicode characters uses
the global modifier, which means that it will never enter its second
iteration of the match-loop. This patch fixes this by removing the
global modifier from the regex.
- committers-autocomplete.js:
(WebKitCommitters):
- 4:13 PM Changeset in webkit [109812] by
-
- 7 edits in trunk/Source
Be more aggressive about repainting page overlays
https://bugs.webkit.org/show_bug.cgi?id=80336
<rdar://problem/10965943>
Reviewed by Simon Fraser.
Source/WebCore:
Add a way to find out if a given GraphicsLayer is going to be repainted.
- WebCore.exp.in:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::needsDisplay):
(GraphicsLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
Source/WebKit2:
Whenever we're flushing layers and we have a page overlay, check if the main frame
has scrolled or if the main frame root content layer needs to be repainted and force the
overlay layer to be repainted if either of those conditions are true.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::shouldRepaintPageOverlayLayer):
(WebKit):
- 4:13 PM Changeset in webkit [109811] by
-
- 5 edits in trunk
Tools: Correctly compute the positions of GestureScroll* events on
Chromium.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::reset):
(EventSender::gestureEvent):
- DumpRenderTree/chromium/EventSender.h:
(EventSender):
LayoutTests: Correct a test to work the same on Gtk and non-Gtk chromium in
the presence of correctly synthesized GestureScroll* events.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.
- fast/events/touch/gesture/gesture-scroll.html:
- 4:11 PM Changeset in webkit [109810] by
-
- 3 edits in trunk/Tools
flakiness dashboard doesn't display baselines for virtual tests correctly
https://bugs.webkit.org/show_bug.cgi?id=80341
Reviewed by Ojan Vafai.
If the test is part of a virtual test suite, we need to look for
baselines in the underlying fallback path for the actual test
being run, as well as baselines for the virtual version.
This patch adds code to handle both branches and also pulls the
mapping of the test suites up into a constant.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testLookupVirtualTestSuite):
(testBaseTest):
- 3:50 PM Changeset in webkit [109809] by
-
- 2 edits2 adds in trunk/Source/WebCore
[BlackBerry] Upstream LayerRendererSurface.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80122
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-05
Reviewed by Rob Buis.
Initial upstream, no new tests.
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/LayerRendererSurface.cpp: Added.
(WebCore):
(WebCore::LayerRendererSurface::LayerRendererSurface):
(WebCore::LayerRendererSurface::~LayerRendererSurface):
(WebCore::LayerRendererSurface::setContentRect):
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::ensureTexture):
(WebCore::LayerRendererSurface::releaseTexture):
- platform/graphics/blackberry/LayerRendererSurface.h: Added.
(WebCore):
(LayerRendererSurface):
(WebCore::LayerRendererSurface::size):
(WebCore::LayerRendererSurface::contentRect):
(WebCore::LayerRendererSurface::clipRect):
(WebCore::LayerRendererSurface::setClipRect):
(WebCore::LayerRendererSurface::setDrawTransform):
(WebCore::LayerRendererSurface::drawTransform):
(WebCore::LayerRendererSurface::setReplicaDrawTransform):
(WebCore::LayerRendererSurface::replicaDrawTransform):
(WebCore::LayerRendererSurface::texture):
(WebCore::LayerRendererSurface::drawOpacity):
(WebCore::LayerRendererSurface::setDrawOpacity):
- 3:45 PM Changeset in webkit [109808] by
-
- 5 edits in trunk/WebKitLibraries
Fix the SnowLeoaprd build.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 3:31 PM Changeset in webkit [109807] by
-
- 5 edits2 adds in trunk
[CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
https://bugs.webkit.org/show_bug.cgi?id=79685
Reviewed by David Hyatt.
Asking for a named flow with an invalid flow name should return a null object.
Source/WebCore:
Test: fast/regions/webkit-named-flow-invalid-name.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFlowThread):
(WebCore):
- css/CSSParser.h:
- dom/Document.cpp:
(WebCore::validFlowName):
(WebCore):
(WebCore::Document::webkitGetFlowByName):
LayoutTests:
- fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
- fast/regions/webkit-named-flow-invalid-name.html: Added.
- 3:09 PM Changeset in webkit [109806] by
-
- 14 edits4 adds in trunk
unicode-bidi should support isolate override and override isolate
https://bugs.webkit.org/show_bug.cgi?id=73164
Reviewed by Eric Seidel.
Source/WebCore:
Updated CSS parser and CSS style selector to support the union of bidi-override and isolate in
unicode-bidi property. Added OverrideIsolate to EUnicodeBidi instead of turning Override and Isolate
into bit flags to avoid increasing the number of bits required to store the unicodeBidi flag.
Also fixed a bug in RenderBlock::constructTextRun to actually check whether an isolated run's direction
is overridden or not when constructing one.
Tests: fast/css/unicode-bidi-computed-value.html
fast/text/bidi-override-isolate.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderUnicodeBidiFlagsToCSSValue): Added; Create a CSSValueList when unicode-bidi has both
isolate and bidi-override specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Calls renderUnicodeBidiFlagsToCSSValue.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Support parsing combinations of -webkit-isolate and bidi-override;
Create a CSSValueList in such cases.
- css/CSSPrimitiveValueMappings.h:
(WebCore):
- css/CSSStyleApplyProperty.cpp:
(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue): Support combinations of -webkit-isolate and
bidi-override. Set the unicodeBidi flag to OverrideIsolate in such cases.
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(WebCore):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/text/UnicodeBidi.h: Added OverrideIsolate. We don't use bit flags to avoid increasing the
number of bits required to store flags especially because isolate and bidi-override are only values
that can be combined.
(WebCore::isIsolated):
(WebCore):
(WebCore::isOverride):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::statusWithDirection): Takes isOverride; we used to assume it's always false.
(WebCore::constructBidiRuns): Instantiate isolatedResolver with a proper value of isOverride.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::determineStartPosition):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::menuStyle):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::menuStyle):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
LayoutTests:
Added a test for retrieving computed value of unicode-bidi property
and also added a test to render "unicode-bidi: -webkit-isolate bidi-override".
- fast/css/unicode-bidi-computed-value-expected.txt: Added.
- fast/css/unicode-bidi-computed-value.html: Added.
- fast/text/bidi-override-isolate-expected.html: Added.
- fast/text/bidi-override-isolate.html: Added.
- 2:58 PM Changeset in webkit [109805] by
-
- 13 edits in trunk/Source/WebCore
Replace uses of x(), y() and width(), height() pairs with locationOffset and size()
https://bugs.webkit.org/show_bug.cgi?id=80196
Reviewed by Julien Chaffraix.
Replace IntSize(x(), y()) with locationOffset()
Replace IntSize(width(), height()) with size()
Replace IntRect(0, 0, width(), height()) with IntRect(IntPoint(), size())
Replace IntRect::move(x(), y()) with IntRect::move(locationOffset())
No new tests.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::baseTransform):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::localSelectionRect):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::buttonRect):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderView.cpp:
(WebCore::RenderView::viewRect):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
- 2:53 PM Changeset in webkit [109804] by
-
- 35 edits2 moves in trunk/Source
Add support for hosting layers in the window server in WebKit2
<rdar://problem/10400246>
https://bugs.webkit.org/show_bug.cgi?id=80310
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- wtf/Platform.h:
Add HAVE_LAYER_HOSTING_IN_WINDOW_SERVER.
Source/WebKit2:
This currently only works if you are using TiledCoreAnimation drawing model.
- Platform/mac/LayerHostingContext.h: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.h.
- Platform/mac/LayerHostingContext.mm: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.mm.
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::LayerHostingContext):
(WebKit::LayerHostingContext::createForWindowServer):
(WebKit::LayerHostingContext::~LayerHostingContext):
(WebKit::LayerHostingContext::setRootLayer):
(WebKit::LayerHostingContext::rootLayer):
(WebKit::LayerHostingContext::contextID):
(WebKit::LayerHostingContext::invalidate):
Renamed RemoteLayerClient to LayerHostingContext and add ability to use the window server
as the remote context.
- PluginProcess/PluginControllerProxy.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
Update for new names.
- Shared/LayerTreeContext.h:
Add LayerHostingMode enum.
- UIProcess/PageClient.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::layerHostingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
Add PageClient access points to get the current layer hosting mode,
and a hook to tell the underlying view that the layer hosting context
has changed.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateAcceleratedCompositingMode:WebKit::]):
Implement responding to a new layer hosting context as a simple
exit and re-entrance of compositing.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerHostingModeDidChange):
(WebKit::DrawingAreaProxy::updateAcceleratedCompositingMode):
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::updateAcceleratedCompositingMode):
Pipe layer hosting changes around.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::layerHostingMode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
Cache the current layer hosting mode so we don't overzealously
tell the WebProcess to reset its context. Re-check layer hosting
mode each time we are added/removed from a window.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
Update for new names.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setDeviceScaleFactor):
(WebKit::DrawingArea::setLayerHostingMode):
- WebProcess/WebPage/DrawingArea.messages.in:
Pipe layer hosting changes around.
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):
Update for new names.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Respond to a change in the layer hosting mode by invalidating our old context,
making a new one of the right type, and informing the UIProcess of our new context.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 2:33 PM Changeset in webkit [109803] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add missing method to PasteboardBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80326
Reviewed by Antonio Gomes.
Add missing method.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writeClipboard):
(WebCore):
- 2:10 PM Changeset in webkit [109802] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, attempted build fix for !ENABLE(JIT) after r109705.
- bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
- bytecode/ExecutionCounter.h:
- 2:01 PM Changeset in webkit [109801] by
-
- 6 edits in trunk/Source
Always update the scroll layer position on the main thread when we have an overlay
https://bugs.webkit.org/show_bug.cgi?id=80324
Reviewed by Sam Weinig.
Source/WebCore:
Add a way to ensure that scroll layer position updates happen on the main thread.
- WebCore.exp.in:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Source/WebKit2:
Call setForceMainThreadScrollLayerPositionUpdates when installing and uninstalling page overlays,
so we'll be able to synchronize painting between the tile cache and the page overlays.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
- 1:59 PM Changeset in webkit [109800] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Cleaning up RenderBlockLineLayout before attempting to land changes in trunk.
- 1:59 PM Changeset in webkit [109799] by
-
- 5 edits4 adds in trunk
Implement flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=79930
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/multiline-align.html
css3/flexbox/multiline.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): Don't apply column+stretch optimization to multiline.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator):
(WebCore::RenderFlexibleBox::FlexOrderIterator::currentChild): Expose the current child so we can pause
in the middle of iteration and resume later.
(RenderFlexibleBox::FlexOrderIterator):
(WebCore::RenderFlexibleBox::isMultiline):
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Loop per line.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Use the line space, not the whole container space.
(WebCore::RenderFlexibleBox::computeFlexOrder): Return true for each line.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the line offset. Also compute the line height as we go.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the line offset.
(WebCore::RenderFlexibleBox::alignChildren): Align based on the line height. For multiline + column, we have to relayout
since the width may change (same as the row case above). We'll have to do something smarter when we implement flex-line-pack.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
- css3/flexbox/multiline-align-expected.txt: Added.
- css3/flexbox/multiline-align.html: Added.
- css3/flexbox/multiline-expected.txt: Added.
- css3/flexbox/multiline.html: Added.
- 1:52 PM Changeset in webkit [109798] by
-
- 16 edits3 copies in trunk/Source/WebCore
Implement WebGL extension EXT_texture_filter_anisotropic
https://bugs.webkit.org/show_bug.cgi?id=79541
This exports the EXT_texture_filter_anisotropic extension with the WEBKIT_ prefix as defined at
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/extensions/proposals/EXT_texture_filter_anisotropic/index.html
Patch by Ben Vanik <benvanik@google.com> on 2012-03-05
Reviewed by Kenneth Russell.
Tested with the Khronos conformance test for the extension, available at https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/ext-texture-filter-anisotropic.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/EXTTextureFilterAnisotropic.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::~EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::getName):
(WebCore::EXTTextureFilterAnisotropic::create):
- html/canvas/EXTTextureFilterAnisotropic.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(EXTTextureFilterAnisotropic):
- html/canvas/EXTTextureFilterAnisotropic.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLObject.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::texParameter):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- platform/graphics/Extensions3D.h:
(Extensions3D):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):
- 1:49 PM Changeset in webkit [109797] by
-
- 2 edits in trunk/LayoutTests
[chromim] Mark http/tests/incremental/partial-jpeg.html as failing.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 1:47 PM Changeset in webkit [109796] by
-
- 1537 edits554 copies145 deletes in branches/subpixellayout
Merge trunk changes up until 109755 into subpixel branch.
- 1:45 PM Changeset in webkit [109795] by
-
- 3 edits1 move in trunk/Source/WebKit2
Change how the Web Inspector Develop menu actions work.
This removes the methods used by Safari's Develop menu. They can now be implemented in Safari.
Reviewed by John Sullivan.
- UIProcess/API/C/mac/WKInspectorPrivateMac.h: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectorRef]): Added.
- WebKit2.xcodeproj/project.pbxproj: Renamed WKInspectorPrivateMac.h to better reflect its private nature.
- 1:44 PM Changeset in webkit [109794] by
-
- 3 edits3 copies in branches/chromium/1025
Merge 109060 - RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/layer-creation/overlap-transformed-and-clipped.html
This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerPoint):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
- compositing/layer-creation/overlap-transformed-and-clipped.html: Added.
TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9599025
- 1:42 PM Changeset in webkit [109793] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, marking a test that is passing on linux as such.
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
is passing on the flakiness dashboard.
- platform/chromium/test_expectations.txt:
- 1:40 PM Changeset in webkit [109792] by
-
- 2 edits in trunk/LayoutTests
FileReader crashes when file is not readable
https://bugs.webkit.org/show_bug.cgi?id=79715
Unreviewed follow-up - skip the test as uses unimplemented beginDragWithFiles.
- platform/wk2/Skipped:
- 1:33 PM Changeset in webkit [109791] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r109760.
http://trac.webkit.org/changeset/109760
https://bugs.webkit.org/show_bug.cgi?id=80320
Caused many GTK+ tests to crash (Requested by mrobinson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05
.:
- configure.ac:
Source/WebCore:
- platform/network/ResourceHandleClient.h:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore):
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::run):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::ResourceHandle::defaultSession):
Tools:
- gtk/jhbuild.modules:
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Removed.
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Removed.
- 1:29 PM Changeset in webkit [109790] by
-
- 4 edits2 adds in trunk
Never dispatch mutation events in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79278
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/shadow/suppress-mutation-events-in-shadow.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Move allowEventDispatch() call later,
now that childrenChanged won't trigger mutation events in shadow dom.
(WebCore::dispatchChildInsertionEvents): Bail out if in shadow tree.
(WebCore::dispatchChildRemovalEvents): ditto.
- dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent): ditto.
LayoutTests:
- fast/dom/shadow/suppress-mutation-events-in-shadow-expected.txt: Added.
- fast/dom/shadow/suppress-mutation-events-in-shadow.html: Added.
- 1:16 PM Changeset in webkit [109789] by
-
- 2 edits in trunk/Source/WebCore
BlobResourceHandle should keep a reference to itself when calling client code.
https://bugs.webkit.org/show_bug.cgi?id=80318
Reviewed by Brady Eidson.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::doStart): (WebCore::BlobResourceHandle::getSizeForNext): (WebCore::BlobResourceHandle::readSync): (WebCore::BlobResourceHandle::readDataAsync): (WebCore::BlobResourceHandle::consumeData): (WebCore::BlobResourceHandle::failed): Added RefPtrs in functions that can result in calling client code, and use "this" object afterwards.
- 1:10 PM Changeset in webkit [109788] by
-
- 12 edits in trunk/Source/WebCore
Let RenderLayerCompositor set the tile cache visible rect
https://bugs.webkit.org/show_bug.cgi?id=80317
Reviewed by Simon Fraser.
We can't compute the visible rect from CALayers, because that breaks when we're updating
the scroll layer position on the main thread (since by the time visibleRectChanged() is called,
the CALayers won't yet have been updated).
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChanged):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::visibleRectChanged):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- platform/graphics/ca/PlatformCALayer.h:
(PlatformCALayer):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::visibleRectChanged):
- platform/graphics/ca/mac/TileCache.h:
(TileCache):
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::visibleRectChanged):
(WebCore::TileCache::revalidateTiles):
- platform/graphics/ca/mac/WebTileCacheLayer.h:
(WebCore):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer visibleRectChanged:]):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::visibleRectChanged):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
- 1:02 PM Changeset in webkit [109787] by
-
- 6 edits in trunk
[CMake][DRT] Add WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=79896
Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-05
Reviewed by Daniel Bates.
Add WebCoreTestSupport library for DRT in CMake.
We will use internals object by linking this library on DRT.
.:
- CMakeLists.txt:
Source/WebCore:
- CMakeLists.txt:
- UseJSC.cmake:
- UseV8.cmake:
- 1:00 PM Changeset in webkit [109786] by
-
- 5 edits in trunk/WebKitLibraries
Update WebKitSystemInterface for WKCAContext additions.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 12:44 PM Changeset in webkit [109785] by
-
- 40 edits14 deletes in trunk
Unreviewed, rolling out r109656.
http://trac.webkit.org/changeset/109656
https://bugs.webkit.org/show_bug.cgi?id=80316
This seems to have regressed Parser/html5-full-render by about
10% (Requested by anttik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSPrimitiveValue.idl:
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels):
(WebCore):
- dom/Document.h:
(Document):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
- platform/Length.h:
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::blend):
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
- rendering/RenderInline.cpp:
(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderText.h:
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
- rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
- rendering/style/RenderStyle.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 12:35 PM Changeset in webkit [109784] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for !ENABLE(JIT) after r109705.
- bytecode/ExecutionCounter.cpp:
- bytecode/ExecutionCounter.h:
- 12:28 PM Changeset in webkit [109783] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] UTF chars printed back from cookie through php shows as ???
https://bugs.webkit.org/show_bug.cgi?id=80307
Reviewed by Antonio Gomes.
PR: 130055
we need to check the cookies encoding first and encode the cookie header data
to pass to the request.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 12:15 PM Changeset in webkit [109782] by
-
- 2 edits in trunk/LayoutTests
Use a proper closing tag for shadow element layout test
https://bugs.webkit.org/show_bug.cgi?id=80305
Reviewed by Adam Barth.
- fast/dom/shadow/shadow-element.html:
- 12:05 PM Changeset in webkit [109781] by
-
- 8 edits in trunk/Source/WebCore
[chromium] Remove old cleanupResources() code
https://bugs.webkit.org/show_bug.cgi?id=80290
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.
cleanupResources() is only called by destructors, and adds no
value, any more, beyond the destructors themselves, but complicates
the code path.
Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::~CCRenderSurface):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
- 11:59 AM Changeset in webkit [109780] by
-
- 1 edit in branches/chromium/963/Source/WebCore/dom/StyledElement.cpp
getElementsByClassName result list no longer changes on class changes on m17 branch.
BUG=114068, 116789
Review URL: https://chromiumcodereview.appspot.com/9602021
- 11:54 AM Changeset in webkit [109779] by
-
- 3 edits5 adds in trunk
Partially loaded JPEGs should have alpha channel
https://bugs.webkit.org/show_bug.cgi?id=78239
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-05
Reviewed by Kenneth Russell.
Source/WebCore:
While a JPEG image is loading, the area outside the decoded region
should be fully transparent. Since currently all JPEG frames are marked
as opaque, a renderer respecting this flag will draw the partially
loaded image with garbage outside the valid image region.
Hence, a partially loaded JPEG image should be marked as having an alpha
channel while decoding is in progress. For performance reasons we mark
the image opaque after decoding has finished.
Graphics corruption caused by this bug was recently observed on
Chromium (http://code.google.com/p/chromium/issues/detail?id=113171). A
recent Skia change (r3036) changed SkBitmap::extractSubset() to produce
a bitmap with the same opaqueness flag as the parent. This meant that
the renderer was now seeing an opaque image from the JPEG decoder, and
drawing it appropriately resulted in garbage outside the decoded region.
Test: http/tests/incremental/partial-jpeg.html
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):
LayoutTests:
While a JPEG image is being loaded, the parts which have not been
decoded yet should show whatever is behind the image. This tests
verifies this by displaying a JPEG which never fully completes
loading. This is achieved by serving the JPEG from a PHP script that
strips the end of image marker (ff d9) from the data.
The test image is 32x32 pixels, so compresses to 4x4 JPEG MCU blocks.
The expected result is that the final row of MCU blocks (32x4 pixels)
never finishes loading due to the missing end of image marker and the
indicator div is shown through this area.
- http/tests/incremental/partial-jpeg-expected.png: Added.
- http/tests/incremental/partial-jpeg-expected.txt: Added.
- http/tests/incremental/partial-jpeg.html: Added.
- http/tests/incremental/resources/checkerboard.jpg: Added.
- http/tests/incremental/resources/partial-jpeg.php: Added.
- 11:50 AM Changeset in webkit [109778] by
-
- 8 edits in trunk
[chromium] Pass WebNavigationPolicy to WebViewClient::createView
https://bugs.webkit.org/show_bug.cgi?id=80057
Patch by Charlie Reis <creis@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.
Source/WebKit/chromium:
- public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::createView):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::createWindow):
(WebKit::ChromeClientImpl::getNavigationPolicy):
(WebKit):
(WebKit::ChromeClientImpl::show):
(WebKit::ChromeClientImpl::setNewWindowNavigationPolicy):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchCreatePage):
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 11:47 AM Changeset in webkit [109777] by
-
- 4 edits in trunk/Source
[chromium] Initialize CCOverdrawCounts struct to zero
https://bugs.webkit.org/show_bug.cgi?id=80204
Patch by James Robinson <jamesr@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.
Source/WebCore:
CCOverdrawCounts is stack allocated but not explicitly initialized, so the values are garbage. This adds a c'tor
to zero out the fields, which is the desired behavior. Bug was initially caught by valgrind, see
http://crbug.com/116475
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore::CCOverdrawCounts::CCOverdrawCounts):
Source/WebKit/chromium:
Update test to use c'tor instead of {} struct initialization.
- tests/CCQuadCullerTest.cpp:
(WebCore):
- 11:38 AM Changeset in webkit [109776] by
-
- 5 edits1 add in trunk/Source/WebCore
Add media control css for chromium on android
https://bugs.webkit.org/show_bug.cgi?id=79550
Patch by Min Qin <qinmin@google.com> on 2012-03-05
Reviewed by Adam Barth.
This should not change the any test results as it does not affect the any current bots. New test expectations will be added if we have a android bot on webkit.
- WebCore.gyp/WebCore.gyp:
- css/mediaControlsChromiumAndroid.css: Added.
(body:-webkit-full-page-media):
(audio):
(audio:-webkit-full-page-media, video:-webkit-full-page-media):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaFullscreenButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraMediaControlsStyleSheet):
(WebCore):
(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):
- rendering/RenderThemeChromiumAndroid.h:
- 11:26 AM Changeset in webkit [109775] by
-
- 2 edits in trunk/Source/WebCore
Fix crash in ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition
https://bugs.webkit.org/show_bug.cgi?id=80303
<rdar://problem/10953682>
Reviewed by Beth Dakin.
Add the same null checks that already exist in updateMainFrameScrollPosition.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- 11:15 AM Changeset in webkit [109774] by
-
- 3 edits in branches/chromium/1025/Source/WebCore/platform/graphics
Merge 109171 - [chromium] Inform v8 about extra memory used for PatternSkia clamp mode
https://bugs.webkit.org/show_bug.cgi?id=79846
Reviewed by James Robinson.
For large images, creating a non-repeating Pattern in Skia can
allocate a lot of memory. Inform v8 about this so that it can
potentially garbage collect any Pattern objects that aren't being used
and that are holding onto large image copies.
- platform/graphics/Pattern.cpp:
(WebCore::Pattern::Pattern):
- platform/graphics/Pattern.h:
(Pattern):
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9599019
- 11:00 AM Changeset in webkit [109773] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update: widen slowness of jquery/offset.html.
- platform/chromium/test_expectations.txt:
- 10:57 AM Changeset in webkit [109772] by
-
- 4 edits2 adds in trunk
Web Inspector: CSS inactive property check should account for vendor prefixes
https://bugs.webkit.org/show_bug.cgi?id=80225
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/vendor-prefixes.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredHexNumber):
(WebInspector.StylesSidebarPane.canonicalPropertyName):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
LayoutTests:
- inspector/styles/vendor-prefixes-expected.txt: Added.
- inspector/styles/vendor-prefixes.html: Added.
- 10:57 AM Changeset in webkit [109771] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
https://bugs.webkit.org/show_bug.cgi?id=80192
Reviewed by Kent Tamura.
- src/WebSocketImpl.h: use OVERRIDE macro.
(WebSocketImpl):
- 10:57 AM Changeset in webkit [109770] by
-
- 4 edits in trunk/Source
Versioning.
- 10:56 AM Changeset in webkit [109769] by
-
- 4 edits in trunk/Source/JavaScriptCore
Lexer: Specialize character predicates for LChar, UChar
https://bugs.webkit.org/show_bug.cgi?id=79677
Reviewed by Oliver Hunt.
This patch specializes isIdentStart, isIdentPart, isWhiteSpace,
and isLineTerminator to perform a more limited number of checks if
the lexer is being instantiated to work on LChar sequences. This
is about a 1.5% win on the --parse-only suite, here.
- parser/Lexer.cpp:
(JSC::isLatin1): New static helper, specialized for LChar and
UChar.
(JSC::typesOfLatin1Characters): Rename from
typesOfASCIICharacters, and expand to the range of the LChar
type. All uses of isASCII are changed to use isLatin1. Generated
using libunistring.
(JSC::isNonLatin1IdentStart):
(JSC::isIdentStart):
(JSC::isNonLatin1IdentPart):
(JSC::isIdentPart):
(JSC::Lexer::shiftLineTerminator):
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseIdentifierSlowCase):
(JSC::Lexer::parseStringSlowCase):
(JSC::Lexer::parseMultilineComment):
(JSC::Lexer::lex):
(JSC::Lexer::scanRegExp):
(JSC::Lexer::skipRegExp): Sprinkle static_cast<T>(_) around.
- parser/Lexer.h:
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
- KeywordLookupGenerator.py:
(Trie.printAsC): Declare specialized isIdentPart static functions.
- 10:51 AM WebKit Team edited by
- (diff)
- 10:50 AM Changeset in webkit [109768] by
-
- 2 edits in trunk/LayoutTests
Removed the svn:executable properties from a couple of expected test results
- 10:36 AM Changeset in webkit [109767] by
-
- 2 edits1 copy in trunk/LayoutTests
fast/text/international/spaces-combined-in-vertical-text.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80284
Reviewed by Alexey Proskuryakov.
The test was added in r104322 with results from the Chromium port, which are incorrect. This
is the subject of <https://bugs.webkit.org/show_bug.cgi?id=80293>.
- fast/text/international/spaces-combined-in-vertical-text-expected.txt:
- platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Copied from LayoutTests/fast/text/international/spaces-combined-in-vertical-text-expected.txt.
- 10:34 AM Changeset in webkit [109766] by
-
- 14 edits in trunk/Source
Add support for notification replaceId in Mac WebKit and WK2
https://bugs.webkit.org/show_bug.cgi?id=80206
<rdar://problem/10965574>
Reviewed by Sam Weinig.
Source/WebKit/mac:
- WebView/WebNotification.h: Add replaceID method.
- WebView/WebNotification.mm:
(-[WebNotification replaceID]):
Source/WebKit2:
- UIProcess/API/C/WKNotification.cpp: Add WK API.
(WKNotificationCopyReplaceID):
- UIProcess/API/C/WKNotification.h:
- UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
- UIProcess/Notifications/WebNotification.h: Add replaceID member.
(WebKit::WebNotification::create):
(WebKit::WebNotification::replaceID):
(WebNotification):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in: Add replaceID to the showNotification message.
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
- 10:28 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:26 AM Changeset in webkit [109765] by
-
- 8 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r109760
- 10:25 AM Changeset in webkit [109764] by
-
- 13 edits in releases/WebKitGTK/webkit-1.8/Source
Merging r109129
- 10:23 AM Changeset in webkit [109763] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 106476 - Source/WebCore: preventDefault() in a mousedown in a subframe should not
prevent the scrollbar from handling mouse movements if the
cursor leaves the subframe.
https://bugs.webkit.org/show_bug.cgi?id=73097
Reviewed by Darin Adler.
Test: fast/events/scroll-div-with-prevent-default-in-subframe.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=73097.
Test adapted from repro case provided by zacklloyd@google.com.
Reviewed by Darin Adler.
- fast/events/resources/subframe-with-scrollable-div.html: Added.
- fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added.
- fast/events/scroll-div-with-prevent-default-in-subframe.html: Added.
TBR=Nate Chapin
Review URL: https://chromiumcodereview.appspot.com/9600027
- 10:22 AM Changeset in webkit [109762] by
-
- 2 edits1 delete in trunk/LayoutTests
fast/regions/select-in-region-crash.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80289
Reviewed by Alexey Proskuryakov.
- fast/regions/select-in-region-crash-expected.txt: Updated.
- platform/chromium/fast/regions/select-in-region-crash-expected.txt: Removed.
- 10:17 AM Changeset in webkit [109761] by
-
- 13 edits in trunk/Source
Geolocation should use a ScriptExecutionContext as its context object
https://bugs.webkit.org/show_bug.cgi?id=80248
Reviewed by Kentaro Hara.
Source/WebCore:
This patch updates Geolocation to use some more modern WebCore
mechanisms. Previously, Geolocation used a Frame as a context object,
which required a bunch of manual integration with the PageCache as well
as custom signaling for Geolocation::reset(). After this patch,
Geolocation subclasses ActiveDOMObject, which does all this work
automatically.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::create):
(WebCore):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
- Modules/geolocation/Geolocation.h:
(WebCore):
(Geolocation):
- Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore):
(WebCore::NavigatorGeolocation::geolocation):
- Modules/geolocation/NavigatorGeolocation.h:
(NavigatorGeolocation):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(Document):
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
Source/WebKit/chromium:
Rather than indirecting through the Frame to get the SecurityOrigin, we
should get the SecurityOrigin directly from ScriptExecutionContext.
- src/WebGeolocationPermissionRequest.cpp:
(WebKit::WebGeolocationPermissionRequest::securityOrigin):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- We no longer special-case Geolocation.
- 10:15 AM Changeset in webkit [109760] by
-
- 8 edits2 adds in trunk
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238
Reviewed by Philippe Normand.
.:
- configure.ac: Bumped the libsoup dependency to 2.37.90.
Source/WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html
When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
(ResourceHandleClient):
(WebCore::ResourceHandleClient::isSynchronousClient): Added this virtual method.
Tools:
- gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
in the jhbuild file.
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
- 10:00 AM Changeset in webkit [109759] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109754
- 9:47 AM Changeset in webkit [109758] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merging r109722
- 9:47 AM Changeset in webkit [109757] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8
Merging r109270
- 9:44 AM Changeset in webkit [109756] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8
Merging r109719
- 9:15 AM Changeset in webkit [109755] by
-
- 10 edits2 deletes in trunk
Unreviewed, rolling out r109748.
http://trac.webkit.org/changeset/109748
https://bugs.webkit.org/show_bug.cgi?id=80296
Made some tests crash, will fix and recommit (Requested by
noamr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05
Source/WebKit2:
- Target.pri:
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::PageProxyNode):
(PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- UIProcess/qt/QtWebPageSGNode.cpp: Removed.
- UIProcess/qt/QtWebPageSGNode.h: Removed.
Tools:
- MiniBrowser/qt/main.cpp:
(main):
- 8:55 AM Changeset in webkit [109754] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] zlib link error with --enable-webkit2
https://bugs.webkit.org/show_bug.cgi?id=79877
Reviewed by Martin Robinson.
zlib should be linked properly.
- GNUmakefile.am: Link $(ZLIB_LIBS) with libwebkit2gtk instead of
linking it with WebKitWebProcess.
- 8:54 AM Changeset in webkit [109753] by
-
- 7 edits in trunk
[GTK] plugins/netscape-plugin-page-cache-works.html fails
https://bugs.webkit.org/show_bug.cgi?id=74409
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-05
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a method to override page-cache-for-plugins preference.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Add support for overriding the page-cache-for-plugins preference
through DumpRenderTreeSupport.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(booleanFromValue): A helper function to convert a string to boolean.
(LayoutTestController::overridePreference):
LayoutTests:
Unskip one new passing test and reclassify one failure.
- platform/gtk/Skipped:
- 8:52 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:40 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:38 AM Changeset in webkit [109752] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip a new flakey test, unskip a passing test.
- platform/qt/svg/custom/bug78807-expected.txt: Added. (https://bugs.webkit.org/show_bug.cgi?id=80156)
- 8:37 AM Changeset in webkit [109751] by
-
- 7 edits in trunk/Source/WebKit/blackberry
Make accelerated compositing work again with direct rendering.
https://bugs.webkit.org/show_bug.cgi?id=80181
RIM PR: 139110
Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson.
The significant amount of refactoring and optimization work
that has gone into accelerated compositing missed out on
some of the code paths that are being used in direct rendering.
Animations were relying on blitVisibleContents() only (which
is a no-op in direct rendering mode). There were early returns
which are suitable to determine whether screen contents need
to be updated at all; however, when we're already forcing a
re-render then those checks would cause the composition surface
not to appear at all, or avoid drawing new animation frames.
We went through dispatchMessage(), potentially causing
mismatches between rendered (but not yet posted) back content
and layers composited on top of it. As we're rendering onto
the sole target surface (the window) directly and posting
from the same thread, we have to wait for compositing on the
UI thread to finish before posting the window.
In turn, this patch combines both drawSubLayers() and
blendCompositingSurface() calls into one method, reducing
the number of messages to the UI thread within
renderDirectToWindow() to one.
blendCompositingMessage() in renderDirectToScreen() was called
with contents coordinates rather than viewport coordinates.
That caused some of the composited content to be cut off when
the scroll position wasn't (0, 0).
We called copyPreviousContentsToBackSurfaceOfWindow() twice for
one frame, in both renderDirectToWindow() and invalidateWindow().
Only one of those (the latter one) is necessary.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- Api/BackingStore.h:
(WebKit):
- Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
(BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(WebPagePrivate):
- WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
- WebKitSupport/WebPageCompositor.h:
(WebPageCompositor):
- 8:34 AM Changeset in webkit [109750] by
-
- 14 edits1 delete in trunk/Source/WebKit2
[WK2] WKPageGetContextMenuFromProposedContextMenuCallback should pass a HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=77208
Reviewed by Anders Carlsson.
A HitTestResultData is now passed to ShowContextMenu WebPageProxy
message instead of the ContextMenuState. ContextMenu client has
been updated to pass the HitTestResult to the
getContextMenuFromProposedMenu callback.
- GNUmakefile.am: Remove ContextMenuState.h.
- Shared/APIClientTraits.h:
- Shared/ContextMenuState.h: Removed.
- Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::Data::Data): Add constructor that takes
a WebCore::HitTestResult.
- UIProcess/API/C/WKPage.h: Add HitTestResult parameter to
getContextMenuFromProposedMenu callback and deprecate the old
version.
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
Pass a HitTestResult to getContextMenuFromProposedMenu or use the
deprecated one if client version is an old one.
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Save the
WebHitTestResult::Data to use it for handling context menu actions.
(WebKit::WebPageProxy::contextMenuItemSelected): Use the saved
WebHitTestResult::Data.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj: Remove ContextMenuState.h.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement): Use the new
WebHitTestResult::Data constructor that takes a WebCore::HitTestResult.
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Create a WebHitTestResult::Data
instead of a ContextMenuState and pass it to ShowContextMenu message.
- win/WebKit2.vcproj: ContextMenuState.h.
- 8:26 AM Changeset in webkit [109749] by
-
- 6 edits in trunk/Tools
[BlackBerry] Update Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=80287
Reviewed by Antonio Gomes.
Update so we are sure we can build our implementation of DRT.
- DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
- DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
- DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::addNotificationListener): add missing hook.
(AccessibilityController::removeNotificationListener): add missing hook.
- DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::isSelectedOptionActive): add missing hook.
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
(LayoutTestController::simulateDesktopNotificationClick): add missing hook.
- 7:52 AM Changeset in webkit [109748] by
-
- 10 edits2 adds in trunk
[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661
Source/WebKit2:
Made the appropriate fixes in the UI process code to make rendering thread-safe.
- Separated the scenegraph node code to QtWebPageSGNode. QtWebPageSGNode has direct access to LayerTreeHostProxy.
- Each function in LayerTreeHostProxy can be either called from the main thread (handling messages from the web process), or from the renderer thread (handling the GL context). The render-queue is locked with a mutex, and messages back to the web process are sent via callOnMainThread.
- LayerTreeHostProxy is now ThreadSafeRefCounted. That is done to make sure that the GL resources it creates are only freed when the QtWebPageSGNode is deleted, which can be before or after the owning DrawingAreaProxy is deleted. This ensures that the class is deleted only after its GL resources are freed, otherwise those resources may leak.
Based on a patch by Viatcheslav Ostapenko.
Reviewed by Kenneth Rohde Christiansen.
- Target.pri: Added new files.
- UIProcess/API/qt/qquickwebpage.cpp: Moved QtWebPageSGNode out.
(QQuickWebPage::updatePaintNode): Call QtWebPageSGNode
(QQuickWebPagePrivate::updateSize): Call QtWebPageSGNode
(QQuickWebPagePrivate::didDeleteSGWebPageNode): Override QtWebPageSGNode::Client
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy): Made LayerTreeHostProxy ref-counted.
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
- UIProcess/LayerTreeHostProxy.h:
(WebKit):
(WebKit::LayerTreeHostProxy::create):
(LayerTreeHostProxy):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(MainThreadGuardedInvoker):
A class that allows invoking functions in the main thread, while guarding a ref-
counted object.
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::detachDrawingArea):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::setShouldRenderNextFrame):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- UIProcess/qt/QtWebPageSGNode.cpp: Added.
- UIProcess/qt/QtWebPageSGNode.h: Added.
Tools:
Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
Reviewed by Kenneth Rohde Christiansen.
- MiniBrowser/qt/main.cpp:
(main):
- 7:37 AM Changeset in webkit [109747] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
https://bugs.webkit.org/show_bug.cgi?id=80274
Patch by George Staikos <gstaikos@rim.com> on 2012-03-05
Reviewed by Antonio Gomes.
A null range can be returned so we should not blindly deref it.
Reviewed Internally by Mike Fenton.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):
- 7:36 AM Changeset in webkit [109746] by
-
- 3 edits in trunk/Source/WebCore
Remove pointer to timer and use the timers directly in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80283
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
- 7:35 AM Changeset in webkit [109745] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Styles] Tabbing an empty new property in the middle of style moves the editor to the next section
https://bugs.webkit.org/show_bug.cgi?id=80264
Reviewed by Pavel Feldman.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection.alreadyNew):
(WebInspector.StylePropertyTreeElement.prototype):
- 7:30 AM Changeset in webkit [109744] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80278
Reviewed by Antonio Gomes.
Update LocalizedStringsBlackBerry.cpp to current HEAD.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inputElementAltText): fall back to "Submit".
(WebCore::imageTitle): choose the format "filename(widthxheight)" like Chrome does.
(WebCore::fileButtonNoFilesSelectedLabel): fall back to "No File Chosen" translation like Chrome does.
(WebCore):
- 7:24 AM Changeset in webkit [109743] by
-
- 3 edits1 add in trunk
Web Inspector: [chromium] introduce HeapSnapshot performance test.
https://bugs.webkit.org/show_bug.cgi?id=80280
Reviewed by Pavel Feldman.
PerformanceTests:
- inspector/detailed-heapshots-smoke-test.html: Added.
Source/WebCore:
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype._callLoadCallbacks):
- 7:14 AM Changeset in webkit [109742] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: cannot be launched when localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=80252
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Settings.js:
- 7:07 AM Changeset in webkit [109741] by
-
- 4 edits2 adds in trunk
Web Inspector: check for the number of parsed css properties.
https://bugs.webkit.org/show_bug.cgi?id=80268
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/styles/set-property-boundaries.html
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
LayoutTests:
- inspector/styles/set-property-boundaries-expected.txt: Added.
- inspector/styles/set-property-boundaries.html: Added.
- 7:00 AM Changeset in webkit [109740] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Tabbed pane should redraw tab elements when tab is closed.
https://bugs.webkit.org/show_bug.cgi?id=80273
Reviewed by Pavel Feldman.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
- 6:55 AM WebKitGTK/WebKit2Roadmap edited by
- 1.8 milestones done! (diff)
- 6:54 AM Changeset in webkit [109739] by
-
- 2 edits in trunk/Source/WebCore
Improve comments in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80279
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
- 6:26 AM Changeset in webkit [109738] by
-
- 3 edits in trunk/Source/WebCore
TiledBackingStore.{h,cpp} contains unclear variable names https://bugs.webkit.org/show_bug.cgi?id=80276
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
This patch renames some of the variables in TiledBackingStore.cpp to
enhance the clearity and for consistence.
The visibleContentsRect is renamed to visibleRect as it is not in
contents coordinates.
The panningTrajectoryVector and m_visibleRectTrajectoryVector are
renamed to just *[m_]trajectoryVector, as that is descriptive enough.
The previous prefix has also been removed, as it is being used as the
current one in the code. This avoids confusion.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
- 6:16 AM Changeset in webkit [109737] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build with Qt 5 and OpenGL ES 2.0
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapper.h: Since we don't do QT += opengl with Qt 5 anymore
here in WebCore, we cannot check for QT_OPENGL_LIB. But since this is Qt5, we know that the
GLES setting comes qconfig.h and we can rely on it.
- 6:00 AM Changeset in webkit [109736] by
-
- 2 edits in trunk/Source/WebCore
Whitespace clean-up of TiledBackingStore.cpp.
Rubber-stamped by Kenneth Rohde Christiansen.
Already covered by existing tests.
- platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
- 5:57 AM Changeset in webkit [109735] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header file.
Source/WebCore:
- GNUmakefile.list.am: Add missing header file.
- 5:29 AM Changeset in webkit [109734] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself to committer list.
- Scripts/webkitpy/common/config/committers.py:
- 5:28 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:00 AM Changeset in webkit [109733] by
-
- 6 edits3 adds in trunk/Tools
[Qt] Use config test to determine if the compiler supports -MD
We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.
Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.
Reviewed by Csaba Osztrogonác.
- 4:03 AM Changeset in webkit [109732] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has more than 2 CSS classes
https://bugs.webkit.org/show_bug.cgi?id=80258
Reviewed by Pavel Feldman.
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
- 3:55 AM Changeset in webkit [109731] by
-
- 3 edits in trunk/Source/JavaScriptCore
WTF: Micro-optimize cleanup of empty vectors and hash tables
https://bugs.webkit.org/show_bug.cgi?id=79903
Reviewed by Michael Saboff and Geoffrey Garen.
This patch speeds up cleanup of vectors and hash tables whose
backing store was never allocated. This is the case by default
for most vectors / hash tables that never had any entries added.
The result for me is that calling checkSyntax 1000 times on
concat-jquery-mootools-prototype.js goes from 6.234s to 6.068s, a
2.4% speedup.
- wtf/HashTable.h:
(WTF::HashTable::~HashTable):
(WTF::::clear): Don't deallocate the storage or frob member
variables if there is no backing storage.
- wtf/Vector.h:
(WTF::VectorBufferBase::deallocateBuffer): Likewise.
- 2:44 AM Changeset in webkit [109730] by
-
- 7 edits2 adds in trunk
Web Inspector: [Styles] [CRASH] Handle rule addition and inline style editing failure due to Content-Security-Policy in the page
https://bugs.webkit.org/show_bug.cgi?id=80024
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/add-new-rule-inline-style-csp.html
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- inspector/InspectorCSSAgent.h:
(InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::~InlineStyleOverrideScope):
(InspectorCSSAgent):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore):
- page/ContentSecurityPolicy.h:
(ContentSecurityPolicy):
LayoutTests:
- inspector/styles/add-new-rule-inline-style-csp-expected.txt: Added.
- inspector/styles/add-new-rule-inline-style-csp.html: Added.
- 2:26 AM Changeset in webkit [109729] by
-
- 5 edits in trunk/Source/WebCore
[Forms] The "optgroup" element should not be a form-associated element
https://bugs.webkit.org/show_bug.cgi?id=80234
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Kent Tamura.
This patch changes base class of HTMLOptGroup to HTMLElement from
HTMLFormControlElement to avoid the "optgroup" element in form-associate
elements collection.
This patch doesn't affect HTMLOptionElement::disabled's static_cast. However,
it doesn't good at coding style. This patch also fix it.
No new tests. No behavior changes.
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::create): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::childrenChanged): Replace base method call.
(WebCore::HTMLOptGroupElement::parseAttribute): Replace base method call.
(WebCore::HTMLOptGroupElement::attach): Replace base method call.
(WebCore::HTMLOptGroupElement::detach): Replace base method call.
- html/HTMLOptGroupElement.h:
(HTMLOptGroupElement): Change base class to HTMLElement.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::disabled): Replace static_cast<HTMLFormControlElement*> to static_cast<HTMLElement*> with checking isHTMLElement.
- html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
- 2:01 AM Changeset in webkit [109728] by
-
- 4 edits in trunk
Web Inspector: fix extensions-resource.html test.
https://bugs.webkit.org/show_bug.cgi?id=80183
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:49 AM Changeset in webkit [109727] by
-
- 2 edits1 delete in trunk/LayoutTests
[Chromium] Rebaseline search-field-cancel.html for r109503.
Fix an error of the previous rebaseline.
- platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
- platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
- 1:24 AM Changeset in webkit [109726] by
-
- 2 edits in trunk/Tools
Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249
Reviewed by Zoltan Herczeg.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
(BuildAndTestFactory.init):
- 1:05 AM Changeset in webkit [109725] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, skip a new failing test.
- platform/qt/Skipped:
- 12:48 AM Changeset in webkit [109724] by
-
- 17 edits in trunk
Add instrumentation for frame start/end on timeline.
Web Inspector: add timeline instrumentation for frame events
https://bugs.webkit.org/show_bug.cgi?id=80127
Reviewed by Pavel Feldman.
Source/WebCore:
- display frame boundaries when vertical overview mode is on
- aggregate by frame in vertical overview mode
- switched event filtering criteria from index to time in vertical overview mode
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didBeginFrameImpl):
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didBeginFrame):
(WebCore):
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrames):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype.getWindowTimes):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCategoryFilter.prototype.accept):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
- inspector/front-end/inspectorCommon.css:
- inspector/front-end/timelinePanel.css:
(#timeline-container):
(.timeline .resources-event-divider):
(.timeline.timeline-start-at-zero .resources-divider):
(.timeline .resources-event-divider.timeline-frame-divider):
Source/WebKit/chromium:
- expose an instrumentation method from WebWidget to mark frame update start
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentBeginFrame):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
LayoutTests:
- inspector/timeline/timeline-enum-stability-expected.txt:
- 12:44 AM Changeset in webkit [109723] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for !ENABLE(SHADOW_DOM).
- html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
- 12:42 AM Changeset in webkit [109722] by
-
- 2 edits in trunk/Tools
[GTK] Unit tests are noisy when run under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80241
Reviewed by Philippe Normand.
Force the 'memory' backend in GSettings so that each unit
test doesn't produce a warning when it's forced to fall back
to the 'memory' backend.
- Scripts/run-gtk-tests:
(TestRunner.run): Force the 'memory' backend.
- 12:37 AM Changeset in webkit [109721] by
-
- 14 edits2 adds in trunk
Internally used HTMLContentElement subclasses should have correct wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237
Reviewed by Kent Tamura.
Source/WebCore:
DetailsContentElement and DetailsSummaryElement used to use
<div> as their tag name. But this means they are wrapped by
wrapper objects for HTMLDivElement, which is wrong. This happened
to work though because HTMLDivElement has no extra state or API.
This change introduces "noConstructor" keyword for make_name.pl
sources. This keyword allows a tag name to specify its own
wrapper without making the tag name visible from the parser, or
HTMLElementFactory in precise.
Following this addition, this change also adds a new tag name
"webkitShadowContent" for DetailsContentElement and DetailsSummaryElement,
which has no constructor, and whose wrapper type is HTMLElement.
This change isn't visible from the page author and only matters for testing.
Test: fast/dom/shadow/content-element-user-agent-shadow.html
- dom/make_names.pl:
(defaultTagPropertyHash):
(buildConstructorMap):
(printConstructors):
(printFunctionInits):
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
- html/HTMLTagNames.in:
- html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
LayoutTests:
- fast/dom/shadow/content-element-user-agent-shadow-expected.txt: Added.
- fast/dom/shadow/content-element-user-agent-shadow.html: Added.
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- 12:35 AM Changeset in webkit [109720] by
-
- 4 edits in trunk
[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
https://bugs.webkit.org/show_bug.cgi?id=80235
Reviewed by Philippe Normand.
Source/WebKit/gtk:
Wait to inspect the WebView until the page has finished loading. Also
clean up some minor style errors.
- tests/testwebinspector.c:
(closeInspector): Small style fixes.
(showInspector): Ditto.
(loadFinished): Ditto.
(test_webkit_web_inspector_close_and_inspect): Wait to inspect until the page has loaded.
(test_webkit_web_inspector_destroy_inspected_web_view): Ditto.
(main): Small style fixes.
Tools:
- Scripts/run-gtk-tests:
(TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
inspector resources path determination is shared by all tests.
- 12:28 AM Changeset in webkit [109719] by
-
- 7 edits in trunk
[GTK] REGRESSION: r108278 broke some tests that expect focus
https://bugs.webkit.org/show_bug.cgi?id=79084
Reviewed by Philippe Normand.
Source/WebKit/gtk:
Grab focus before running the test. This ensures that if the
WebView lost focus, it has it before sending events.
- tests/testcopyandpaste.c:
(test_copy_and_paste): Grab focus.
Tools:
Grab focus when dumping test results and also when sending
events. During the course of testing, the WebView may lose
focus and this seems to snap it back when tests demand it.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump): Grab focus.
- DumpRenderTree/gtk/EventSender.cpp:
(dispatchEvent): Ditto.
LayoutTests:
- platform/gtk/Skipped: Unskip passing tests.
- 12:22 AM Changeset in webkit [109718] by
-
- 5 edits in trunk/Source/WebCore
Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
https://bugs.webkit.org/show_bug.cgi?id=80243
Reviewed by Hajime Morita.
Since the current code in HTMLContentElement::attach() will be used for coming <shadow>
elements, it is natural that InsertionPoint::attach() has such code.
No new tests, no change in behavior.
- html/shadow/HTMLContentElement.cpp:
- html/shadow/HTMLContentElement.h:
(HTMLContentElement):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore):
(WebCore::InsertionPoint::detach):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
- 12:18 AM WebKitGTK/1.8.x edited by
- (diff)
- 12:18 AM Changeset in webkit [109717] by
-
- 5 edits3 adds in trunk/LayoutTests
[Chromium] Rebaseline search-field-cancel.html for r109503.
- platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
- platform/chromium-mac-leopard/fast/repaint/search-field-cancel-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
- platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:13 AM Changeset in webkit [109716] by
-
- 12 edits in trunk/Source/WebCore
allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=80178
Reviewed by Eric Seidel.
These functions are only used by SQLDatabase, which means we can move
them to DatabaseContext, removing one more tendril of the SQLDatabase
code.
- dom/Document.cpp:
(WebCore):
- dom/Document.h:
(Document):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
- storage/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore):
(WebCore::DatabaseContext::databaseExceededQuota):
- storage/DatabaseContext.h:
(DatabaseContext):
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
- storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExceedQuota):
- storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WorkerContext):
- 12:08 AM Changeset in webkit [109715] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r109580
- 12:07 AM WebKitGTK/1.8.x edited by
- (diff)
- 12:07 AM Changeset in webkit [109714] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merging r109509
- 12:05 AM Changeset in webkit [109713] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merging r109396
- 12:03 AM Changeset in webkit [109712] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark two tests as flaky in GTK.
- platform/gtk/test_expectations.txt:
editing/selection/select-line-break-with-opposite-directionality.html
and fast/css/hover-update.html are flaky.
- 12:02 AM Changeset in webkit [109711] by
-
- 13 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging 109515
Mar 4, 2012:
- 11:58 PM Changeset in webkit [109710] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merging r108540
- 11:57 PM Changeset in webkit [109709] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r107551.
http://trac.webkit.org/changeset/107551
https://bugs.webkit.org/show_bug.cgi?id=80245
caused incorrect style sharing (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-04
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 11:56 PM WebKitGTK/1.8.x edited by
- (diff)
- 11:56 PM Changeset in webkit [109708] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r108760
- 11:50 PM Changeset in webkit [109707] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8/Source
Merging r108631
- 11:47 PM WebKitGTK/1.8.x edited by
- (diff)
- 10:57 PM Changeset in webkit [109706] by
-
- 2 edits in trunk/Source/WebCore
Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
https://bugs.webkit.org/show_bug.cgi?id=80236
Reviewed by Eric Seidel.
No new tests / unused code deletion only.
- css/CSSStyleSelector.cpp:
(WebCore):
- 10:52 PM Changeset in webkit [109705] by
-
- 21 edits4 adds in trunk/Source
JIT heuristics should be hyperbolic
https://bugs.webkit.org/show_bug.cgi?id=80055
<rdar://problem/10922260>
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Added tracking of the amount of executable memory typically used for a bytecode
instruction. Modified the execution counter scheme to use this, and the amount
of free memory, to determine how long to wait before invoking the JIT.
The result is that even if we bomb the VM with more code than can fit in our
executable memory pool, we still keep running and almost never run out of
executable memory - which ensures that if we have to JIT something critical, then
we'll likely have enough memory to do so. This also does not regress performance
on the three main benchmarks.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC):
(JSC::CodeBlock::usesOpcode):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecutionActiveThreshold):
(JSC::CodeBlock::offsetOfJITExecutionTotalCount):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
- bytecode/ExecutionCounter.cpp: Added.
(JSC):
(JSC::ExecutionCounter::ExecutionCounter):
(JSC::ExecutionCounter::checkIfThresholdCrossedAndSet):
(JSC::ExecutionCounter::setNewThreshold):
(JSC::ExecutionCounter::deferIndefinitely):
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter::applyMemoryUsageHeuristicsAndConvertToInt):
(JSC::ExecutionCounter::hasCrossedThreshold):
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::reset):
- bytecode/ExecutionCounter.h: Added.
(JSC):
(ExecutionCounter):
(JSC::ExecutionCounter::formattedTotalCount):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
- llint/LowLevelInterpreter32_64.asm:
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- wtf/SimpleStats.h: Added.
(WTF):
(SimpleStats):
(WTF::SimpleStats::SimpleStats):
(WTF::SimpleStats::add):
(WTF::SimpleStats::operator!):
(WTF::SimpleStats::count):
(WTF::SimpleStats::sum):
(WTF::SimpleStats::sumOfSquares):
(WTF::SimpleStats::mean):
(WTF::SimpleStats::variance):
(WTF::SimpleStats::standardDeviation):
Source/WebCore:
Reviewed by Oliver Hunt.
No new tests, since there's no new functionality.
- ForwardingHeaders/wtf/SimpleStats.h: Added.
- 10:30 PM Changeset in webkit [109704] by
-
- 5 edits in trunk
Source/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902
Reviewed by Hajime Morita.
firstRendererOfInsertionPoint should return the first renderer of its child, however
it returns next renderer of parent. The same thing happens lastRendererOfInsertionPoint.
Test: content-element-move.html has another test case.
- dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
LayoutTests: Refactoring: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902
Reviewed by Hajime Morita.
Added a new test case.
- fast/dom/shadow/content-element-move-expected.txt:
- fast/dom/shadow/content-element-move.html:
- 8:43 PM Changeset in webkit [109703] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for ENABLE(MATHML).
- mathml/MathMLElement.h:
(WebCore):
- 8:09 PM Changeset in webkit [109702] by
-
- 6 edits in trunk/Source/WebCore
WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
https://bugs.webkit.org/show_bug.cgi?id=80229
Reviewed by Kent Tamura.
The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.
No new tests. Just added a sanity check.
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):
- html/HTMLUnknownElement.h:
(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):
- mathml/MathMLElement.h:
(toMathMLElement):
- svg/SVGElement.h:
(WebCore::toSVGElement):
(WebCore):
- 8:02 PM Changeset in webkit [109701] by
-
- 2 edits in trunk/Tools
Unreviewed, Add myself to committer list.
https://bugs.webkit.org/show_bug.cgi?id=80232
- Scripts/webkitpy/common/config/committers.py:
- 7:44 PM Changeset in webkit [109700] by
-
- 6 edits3 copies in branches/chromium/1025
Merge 108574 - REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/css/font-face-insert-link.html
If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.
Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.
FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSFontSelector.h:
(CSSFontSelector):
- platform/graphics/Font.cpp:
(WebCore::Font::operator==):
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
- platform/graphics/FontFallbackList.h:
(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):
- platform/graphics/FontSelector.h:
(FontSelector):
LayoutTests:
- fast/css/font-face-insert-link-expected.txt: Added.
- fast/css/font-face-insert-link.html: Added.
- fast/css/resources/ahem.css: Added.
(@font-face):
TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9595009
- 7:38 PM Changeset in webkit [109699] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80226
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 7:29 PM Changeset in webkit [109698] by
-
- 3 edits4 adds in trunk/Source/WebKit
[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
https://bugs.webkit.org/show_bug.cgi?id=80107
Patch by Jonathan Dong <Jonathan Dong> on 2012-03-04
Reviewed by Antonio Gomes.
Initial upstream of CredentialManager.[h|cpp] and
CredentialTransformData.[h|cpp].
No new test.
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- WebCoreSupport/CredentialManager.cpp: Added.
(WebCore):
(WebCore::CredentialManager::CredentialManager):
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
- WebCoreSupport/CredentialManager.h: Added.
(WebKit):
(WebCore):
(CredentialManager):
- WebCoreSupport/CredentialTransformData.cpp: Added.
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
(WebCore::CredentialTransformData::url):
(WebCore::CredentialTransformData::credential):
(WebCore::CredentialTransformData::setCredential):
(WebCore::CredentialTransformData::findPasswordFormFields):
- WebCoreSupport/CredentialTransformData.h: Added.
(WebCore):
(CredentialTransformData):
(WebCore::CredentialTransformData::isValid):
(WebCore::CredentialTransformData::protectionSpace):
- 7:23 PM Changeset in webkit [109697] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=79650
Patch by Jonathan Dong <Jonathan Dong> on 2012-03-04
Reviewed by Antonio Gomes.
Opened Credential database in CedentialBackingStore::instance().
Added never_remember table and associated sql statment
members to store the never remember sites.
Removed CredentialStorage initialize codes because that
won't give users a chance to re-enter the new credential
information for an already stored site.
Changed login update and has statement to support
autofill feature of multiple credential forms in the
same page; Also added url as a parameter of hasLogin() function.
Added calling reset() after each statement calls step(),
to make it work correctly next time.
Also fixed a macro typo in HANDLE_SQL_EXEC_FAILURE.
No new tests.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::hasNeverRemember):
(WebCore::CredentialBackingStore::getNeverRemember):
(WebCore::CredentialBackingStore::removeNeverRemember):
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- 7:15 PM Changeset in webkit [109696] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.
This patch adds initialization and destruction codes using Evas_GL APIs to GC3DPrivate.
No new tests. No behavior change.
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- 7:01 PM Changeset in webkit [109695] by
-
- 10 edits in trunk
[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
https://bugs.webkit.org/show_bug.cgi?id=71507
Reviewed by Antonio Gomes.
.:
- Source/cmake/OptionsCommon.cmake: Provide two variables which
can be changed via CMake: LIB_SUFFIX, which is often used in CMake
projects to let the user choose whether a suffix should be added
to the library installation directory (such as 32 or 64), and
LIB_INSTALL_DIR, which takes LIB_SUFFIX into account to determine
whether to install libraries.
Source/JavaScriptCore:
- CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebCore:
No new tests, buildsystem change.
- CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebKit:
- CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebKit2:
- CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
- 6:43 PM Changeset in webkit [109694] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Implementation of missing functions in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.
The initial patch (Bug 62961) only contains implementations for simple functions
which call GL functions through Evas_GL_API.
This patch implements a little complicated functions such as getActiveAttrib(),
getShaderSource() and so on.
No new tests. No behavior change.
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
- 6:33 PM Changeset in webkit [109693] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- svg/DOMWindowSVG.idl: Removed.
- 6:32 PM Changeset in webkit [109692] by
-
- 2 edits in trunk/LayoutTests
[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748
- platform/chromium/test_expectations.txt: Removed flaky expectations.
- 6:24 PM Changeset in webkit [109691] by
-
- 7 edits1 delete in trunk/Source/WebCore
Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80144
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.
No tests. No change in behavior.
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/DOMWindowWebGL.idl: Removed.
- page/DOMWindow.idl:
- 6:01 PM Changeset in webkit [109690] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/files/xhr-response-blob-expected.txt:
- 5:59 PM Changeset in webkit [109689] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- rendering/RenderButton.cpp:
(WebCore::RenderButton::canHaveGeneratedChildren):
- 5:39 PM Changeset in webkit [109688] by
-
- 7 edits2 adds in trunk
REGRESSION(r108758): Assertion failure in WebCore::RenderMenuList::addChild
https://bugs.webkit.org/show_bug.cgi?id=80096
Reviewed by Dimitri Glazkov.
Source/WebCore:
After r108758 RenderBlock allowed <select> to have generated
contents. But it shouldn't. This change stops allowing it again by
replacing some canHaveChildren() invocations with
less permissive canHaveGeneratedChildren().
This change also pulls back original canHaveChildren() logic to
RenderButton to allow <button> to have generated contents.
Then RenderDeprecatedFlexibleBox::buttonText() is morphed to
more intention revealing canHaveGeneratedChildren().
Test: fast/forms/select-generated-content.html
- rendering/RenderBlock.cpp:
(WebCore):
(WebCore::canHaveGeneratedChildren):
(WebCore::RenderBlock::styleDidChange):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderButton.cpp:
- rendering/RenderButton.h:
(RenderButton):
- rendering/RenderDeprecatedFlexibleBox.h:
(WebCore::RenderDeprecatedFlexibleBox::canHaveGeneratedChildren):
- rendering/RenderMenuList.h:
LayoutTests:
- fast/forms/select-generated-content-expected.txt: Added.
- fast/forms/select-generated-content.html: Added.
- 5:34 PM Changeset in webkit [109687] by
-
- 2 edits in trunk/Source/WebKit/blackberry
2012-03-04 Antonio Gomes <agomes@rim.com>
Fixed positioned element not correctly positioned after orientation change,
when viewport metatag is used with "initial-scale=1" MKS_2992596
PR #138865
Reviewed by George Staikos.
Viewport size changes in two main scenarios:
- orientation changes;
- virtual keyboard pop up/hide.
When we are setting a new viewport size, we need to
update the FixedReportedSize of the mainframe. This size
is used to return innerWidth|Heigth as well as to calculate
the fixed position elements height relative to the RenderView [1].
[1] RenderBox::containingBlockLogicalHeightForPositioned.
When we are rotating, we need to delay setting the new FixedReportedSize
till we layout and are able to figure out the new contents size. At this
time we call setFixedReportedSize, but we do not reposition the fixed elemts
afterwards.
Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
setting the new size.
Source/WebKit/blackberry:
- Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Source/WebCore:
- manual-tests/blackberry/meta-viewport-fixed-position-preserved-on-rotation.html: Added.
- 5:09 PM Changeset in webkit [109686] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- 4:44 PM Changeset in webkit [109685] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- 4:30 PM Changeset in webkit [109684] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 4:23 PM Changeset in webkit [109683] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
- 1:35 PM Changeset in webkit [109682] by
-
- 1 edit2 adds in trunk/Source/WebCore
[BlackBerry] Upstream two helper files from platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=80125
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Added.
(WebCore):
(InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::~InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::isSolidColor):
(WebCore::InstrumentedPlatformCanvas::solidColor):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):
- platform/graphics/blackberry/LayerMessage.h: Added.
(WebCore):
(WebCore::isCompositingThread):
(WebCore::compositingThread):
(WebCore::isWebKitThread):
(WebCore::webKitThread):
(WebCore::dispatchCompositingMessage):
(WebCore::dispatchSyncCompositingMessage):
(WebCore::dispatchWebKitMessage):
- 12:46 PM Changeset in webkit [109681] by
-
- 6 edits in trunk/Tools
Newer versions of clang fail to compile WebKit.
Fix build.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionOfValue):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):
- DumpRenderTree/mac/EditingDelegate.mm:
(-[DOMRange dump]):
- DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSError _drt_descriptionSuitableForTestResult]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::descriptionOfValue):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::selectedTextRange):
- 12:43 PM Changeset in webkit [109680] by
-
- 1 edit4 adds in trunk/LayoutTests
table tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75898
Reviewed by Julien Chaffraix.
Tests CSS3 calc() (see http://webkit.org/b/16662) on some simple examples with tables.
- css3/calc/table-calcs-expected.txt: Added.
- css3/calc/table-calcs.html: Added.
- css3/calc/table-empty-cells-expected.html: Added.
- css3/calc/table-empty-cells.html: Added.
- 11:07 AM Changeset in webkit [109679] by
-
- 7 edits in trunk
Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790
Reviewed by Dirk Schulze.
Source/WebCore:
Restore SMIL animation behavior back to pre-r109342.
1) Always animate presentation attributes as CSS properties, regardless of the
attributeTypes value. Matches Opera/FF, and makes the attribute optional again
as specified in both SMIL & SVG.
Extend existing svg/animations/attributesTypes.html to verify this.
2) Switch setInstancesUpdatesBlocked calls to the right locations again, to
avoid chromium assertions (and/or extra work being done). Fixing that reveals another
problem: in the instance updating code path, we always called setTargetAttributeAnimatedCSSValue
even for XML animations.
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::shouldApplyAnimation): Restore old logic.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Fix typo, move setInstancesUpdatesBlocked calls.
LayoutTests:
Extended attributesTypes.html test case to check that presentation attributes are
always animated as CSS properties, regardless of their attributeTypes value.
- platform/chromium/test_expectations.txt: Remove animate-elem-32-t.svg suppression.
- svg/animations/attributeTypes-expected.txt: Updated expectations.
- svg/animations/resources/attributeTypes.svg: Fix comment.
- svg/animations/script-tests/attributeTypes.js: Extend test.
(sample1):
(sample2):
(sample3):
- 10:53 AM Changeset in webkit [109678] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix build when the classic interpreter is enabled
Reviewed by Gavin Barraclough.
Fixes the following build error when running the "Generate
Derived Sources" build phase script:
offlineasm: Parsing JavaScriptCore/llint/LowLevelInterpreter.asm and ../../JSCLLIntOffsetsExtractor and creating assembly file LLIntAssembly.h.
./JavaScriptCore/offlineasm/offsets.rb:145:in `offsetsAndConfigurationIndex': unhandled exception
from JavaScriptCore/offlineasm/asm.rb:131
Command /bin/sh failed with exit code 1
Gavin's fix in r109674 avoided the #error statement in
JITStubs.h when compiling LLIntOffsetsExtractor.cpp, but it
caused the "Generate Derived Sources" build phase script to fail
when JavaScriptCore/offlineasm/asm.rb was run. The solution is
to detect when the classic interpreter is being built and simply
exit early from asm.rb in that case.
- llint/LLIntOffsetsExtractor.cpp:
(JSC::LLIntOffsetsExtractor::dummy): Return NULL pointer if the
JIT is disabled. Note that offsets.rb doesn't care about the
return value here, but instead it cares about finding the magic
values in the binary. The magic values are no longer present
when the JIT is disabled.
- offlineasm/asm.rb: Catch MissingMagicValuesException and exit
early with a status message.
- offlineasm/offsets.rb:
(MissingMagicValuesException): Add new exception class.
(offsetsAndConfigurationIndex): Throw
MissingMagicValuesException when no magic values are found.
- 9:11 AM Changeset in webkit [109677] by
-
- 2 edits2 adds in trunk/Source/WebCore
[BlackBerry] upstream MediaPlayerPrivateBlackBerry.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=79729
Patch by Jonathan Dong <Jonathan Dong> on 2012-03-04
Reviewed by Rob Buis and Antonio Gomes.
Implementation of MediaPlayerPrivate for BlackBerry porting.
Initial upstream, No new tests.
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: Added.
(WebCore):
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::userAgent):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::setFullscreenWebPageClient):
(WebCore::MediaPlayerPrivate::getWindow):
(WebCore::MediaPlayerPrivate::getPeerWindow):
(WebCore::MediaPlayerPrivate::getWindowPosition):
(WebCore::MediaPlayerPrivate::mmrContextName):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::sourceWidth):
(WebCore::MediaPlayerPrivate::sourceHeight):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::onDurationChanged):
(WebCore::MediaPlayerPrivate::onTimeChanged):
(WebCore::MediaPlayerPrivate::onPauseStateChanged):
(WebCore::MediaPlayerPrivate::onRateChanged):
(WebCore::MediaPlayerPrivate::onVolumeChanged):
(WebCore::MediaPlayerPrivate::onRepaint):
(WebCore::MediaPlayerPrivate::onSizeChanged):
(WebCore::MediaPlayerPrivate::onPlayNotified):
(WebCore::MediaPlayerPrivate::onPauseNotified):
(WebCore::MediaPlayerPrivate::onBuffering):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::frameView):
(WebCore::MediaPlayerPrivate::platformWindow):
(WebCore::MediaPlayerPrivate::isFullscreen):
(WebCore::MediaPlayerPrivate::platformMedia):
(WebCore::MediaPlayerPrivate::platformLayer):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::bufferingTimerFired):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::allocateTextureId):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: Added.
(WebKit):
(WebCore):
(MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
- 7:57 AM Changeset in webkit [109676] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
- 7:42 AM Changeset in webkit [109675] by
-
- 2 edits in trunk/Source/JavaScriptCore
SPARC also needs aligned accesses.
Patch by Jurij Smakov <jurij@wooyd.org> on 2012-03-04
Rubber-stamped by Gustavo Noronha Silva.
- wtf/Platform.h:
- 7:26 AM BuildingGtk edited by
- Added gobject-introspection to jhbuild dependencies (diff)
- 1:04 AM Changeset in webkit [109674] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
- jit/JITStubs.h:
- Move ENABLE(JIT) to head of file.
Mar 3, 2012:
- 9:56 PM Changeset in webkit [109673] by
-
- 4 edits in trunk/Source/JavaScriptCore
Split JSArray's Put & DefineOwnProperty traps.
https://bugs.webkit.org/show_bug.cgi?id=80217
Reviewed by Filip Pizlo.
putByIndex() provides similar behavior to put(), but for indexed property names.
Many places in ArrayPrototype call putByIndex() where they really mean to call
DefineOwnProperty. This is only okay due to a bug – putByIndex should be
calling numeric accessors (& respecting numeric read only properties) on the
prototype chain, but isn't. Add a new putDirectIndex (matching JSObject's
putDirect* methods), to correctly provide a fast DefineOwnProperty interface.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
- runtime/JSArray.cpp:
(JSC):
(JSC::reject):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
- runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):
- 9:04 PM Changeset in webkit [109672] by
-
- 4 edits in trunk/Source/WebCore
Remove the unused function WebCore::protocolIsInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80218
Reviewed by Anders Carlsson.
- WebCore.order:
- platform/KURL.cpp:
- platform/KURL.h:
(WebCore):
- 7:49 PM Changeset in webkit [109671] by
-
- 6 edits in trunk/Source
Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600
Reviewed by Adam Barth.
Source/JavaScriptCore:
Add an API to know if a ParsedURL is valid.
- wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::isolatedCopy): This is needed by APIs moving URL objects between thread
and by KURL's detach() on write.
(WTF::ParsedURL::baseAsString):
(WTF::ParsedURL::segment):
Add a stronger constraint on accessors: the client of this API should never ask for the segments
on an invalid URL.
- wtf/url/api/ParsedURL.h:
(WTF):
(WTF::ParsedURL::ParsedURL):
(ParsedURL):
(WTF::ParsedURL::isValid):
Source/WebCore:
Add a simple, non-optimized, implementation for the main methods of KURL based
on ParsedURL.
- platform/KURLWTFURL.cpp:
(WebCore):
(WebCore::detach):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::hasPort):
(WebCore::KURL::port):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::baseAsString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):
- platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::copy):
(WebCore):
- 7:26 PM Changeset in webkit [109670] by
-
- 24 edits in trunk/Source
Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216
Reviewed by Anders Carlsson.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::hostForURL):
(WebCore::ResourceLoadScheduler::scheduleLoad):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
- loader/icon/IconController.cpp:
(WebCore::IconController::defaultURL):
- platform/KURL.h:
(KURL):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
(WebCore::findDefaultProtectionSpaceForURL):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
- src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForElement):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
- WebHistory.cpp:
(WebHistory::visitedURL):
- 7:08 PM Changeset in webkit [109669] by
-
- 9 edits in trunk
[Qt] Fix static_libs_as_shared build
https://bugs.webkit.org/show_bug.cgi?id=80214
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-03
Reviewed by Tor Arne Vestbø.
Source/WebKit/qt:
Add helper function to be called by WebProcess main
to potentially initialize the QStyle theme.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit):
(WebKit::initializeWebKit2Theme):
Source/WebKit2:
Replace (static) link time dependency to WK1 with entrypoint
in the separate WebProcess for activating the QStyle theme if
necessary.
- Target.pri:
- UIProcess/Launcher/ProcessLauncher.h:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- qt/MainQt.cpp:
(WebKit):
(main):
Tools:
- WebKitTestRunner/qt/main.cpp:
(main): Set the correct environment variable for choosing the theme in the
web process.
- 7:04 PM Changeset in webkit [109668] by
-
- 1 edit9 adds in trunk/Source/WebCore
[BlackBerry] Upstream LayerWebKitThread and its derived classes
https://bugs.webkit.org/show_bug.cgi?id=79871
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-03
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setCanvas):
(WebCore::CanvasLayerWebKitThread::setNeedsDisplay):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/CanvasLayerWebKitThread.h: Added.
(WebCore):
(CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::create):
- platform/graphics/blackberry/LayerData.h: Added.
(WebCore):
(LayerData):
(WebCore::LayerData::LayerData):
(WebCore::LayerData::~LayerData):
(WebCore::LayerData::anchorPoint):
(WebCore::LayerData::anchorPointZ):
(WebCore::LayerData::backgroundColor):
(WebCore::LayerData::borderColor):
(WebCore::LayerData::borderWidth):
(WebCore::LayerData::bounds):
(WebCore::LayerData::doubleSided):
(WebCore::LayerData::frame):
(WebCore::LayerData::masksToBounds):
(WebCore::LayerData::opacity):
(WebCore::LayerData::opaque):
(WebCore::LayerData::position):
(WebCore::LayerData::sublayerTransform):
(WebCore::LayerData::transform):
(WebCore::LayerData::preserves3D):
(WebCore::LayerData::getTextureID):
(WebCore::LayerData::setTextureID):
(WebCore::LayerData::needsTexture):
(WebCore::LayerData::layerProgramShader):
(WebCore::LayerData::isFixedPosition):
(WebCore::LayerData::hasFixedContainer):
(WebCore::LayerData::hasFixedAncestorInDOMTree):
(WebCore::LayerData::pluginView):
(WebCore::LayerData::holePunchRect):
(WebCore::LayerData::hasHolePunchRect):
(WebCore::LayerData::mediaPlayer):
(WebCore::LayerData::canvas):
(WebCore::LayerData::replicate):
(WebCore::LayerData::layerType):
(WebCore::LayerData::includeVisibility):
- platform/graphics/blackberry/LayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::LayerWebKitThread::create):
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::contentsVisible):
(WebCore::LayerWebKitThread::createFrontBufferLock):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setDrawable):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore::LayerWebKitThread::insertSublayer):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayer):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::indexOfSublayer):
(WebCore::LayerWebKitThread::setBounds):
(WebCore::LayerWebKitThread::setFrame):
(WebCore::LayerWebKitThread::rootLayer):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
- platform/graphics/blackberry/LayerWebKitThread.h: Added.
(WebCore):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setAnchorPoint):
(WebCore::LayerWebKitThread::setAnchorPointZ):
(WebCore::LayerWebKitThread::setBackgroundColor):
(WebCore::LayerWebKitThread::setBorderColor):
(WebCore::LayerWebKitThread::setBorderWidth):
(WebCore::LayerWebKitThread::setDoubleSided):
(WebCore::LayerWebKitThread::setMasksToBounds):
(WebCore::LayerWebKitThread::setMaskLayer):
(WebCore::LayerWebKitThread::maskLayer):
(WebCore::LayerWebKitThread::setReplicaLayer):
(WebCore::LayerWebKitThread::replicaLayer):
(WebCore::LayerWebKitThread::setNeedsDisplayOnBoundsChange):
(WebCore::LayerWebKitThread::setOpacity):
(WebCore::LayerWebKitThread::setOpaque):
(WebCore::LayerWebKitThread::setPosition):
(WebCore::LayerWebKitThread::getSublayers):
(WebCore::LayerWebKitThread::setSublayerTransform):
(WebCore::LayerWebKitThread::superlayer):
(WebCore::LayerWebKitThread::setTransform):
(WebCore::LayerWebKitThread::setPreserves3D):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setHasFixedContainer):
(WebCore::LayerWebKitThread::setHasFixedAncestorInDOMTree):
(WebCore::LayerWebKitThread::contents):
(WebCore::LayerWebKitThread::setOwner):
(WebCore::LayerWebKitThread::drawsContent):
(WebCore::LayerWebKitThread::layerCompositingThread):
(WebCore::LayerWebKitThread::setAbsoluteOffset):
(WebCore::LayerWebKitThread::contentsScale):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
(WebCore::LayerWebKitThread::setNeedsTexture):
(WebCore::LayerWebKitThread::setLayerProgramShader):
(WebCore::LayerWebKitThread::isDrawable):
(WebCore::LayerWebKitThread::boundsChanged):
(WebCore::LayerWebKitThread::setSuperlayer):
(WebCore::LayerWebKitThread::numSublayers):
- platform/graphics/blackberry/PluginLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::PluginLayerWebKitThread::PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::~PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::setPluginView):
(WebCore::PluginLayerWebKitThread::setHolePunchRect):
(WebCore::PluginLayerWebKitThread::setNeedsDisplay):
(WebCore::PluginLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/PluginLayerWebKitThread.h: Added.
(WebCore):
(PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::create):
- platform/graphics/blackberry/VideoLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::VideoLayerWebKitThread::VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::~VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::setMediaPlayer):
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::setNeedsDisplay):
(WebCore::VideoLayerWebKitThread::boundsChanged):
(WebCore::VideoLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/VideoLayerWebKitThread.h: Added.
(WebCore):
(VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::create):
- 5:06 PM Changeset in webkit [109667] by
-
- 24 edits in trunk
Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019
Reviewed by Adam Barth.
.:
Add ENABLE_SCRIPTED_SPEECH.
- configure.ac:
Source/JavaScriptCore:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
No functionality yet, so no new tests.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- Target.pri:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
Source/WebKit/chromium:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableScriptedSpeech):
(WebKit):
(WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):
Source/WebKit/mac:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Tools:
Add ENABLE_SCRIPTED_SPEECH.
- Scripts/build-webkit:
- qmake/mkspecs/features/features.prf:
WebKitLibraries:
Add ENABLE_SCRIPTED_SPEECH.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 2:48 PM Changeset in webkit [109666] by
-
- 13 edits1 copy1 add in trunk
DelayNode has a fixed one second max delay time
https://bugs.webkit.org/show_bug.cgi?id=78758
Source/WebCore:
Change DelayNode to accept an optional parameter to specify the
maximum delay allowed. If not specified, the default is 1 sec.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
Test: webaudio/delaynode-maxdelay.html
webaudio/delaynode-maxdelay-expected.txt
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelayNode): Allow maxDelayTime
parameter to specify max delay.
- webaudio/AudioContext.h: Allow maxDelayTime
parameter to specify max delay but default to 1.
(AudioContext):
- webaudio/AudioContext.idl: createDelayNode takes optional max
delay time parameter.
- webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
DefaultMaxDelayTime. Set m_maxDelayTime from processor
maxDelayTime.
- webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.
- webaudio/DelayNode.h:
(WebCore::DelayNode::create): Add maxDelayTime parameter.
(DelayNode): Add maxDelayTime parameter.
- webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
parameter.
- webaudio/DelayProcessor.h:
(DelayProcessor): Add maxDelayTime parameter.
(WebCore::DelayProcessor::maxDelayTime): New slot to hold
maxDelayTime.
LayoutTests:
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
- webaudio/resources/delay-testing.js: Added more informative
messages.
- webaudio/delaynode-expected.txt: Updated result for more
informative messages
- webaudio/delaynode-scheduling-expected.txt: Updated result for
more informative messages.
- webaudio/delaynode-maxdelay-expected.txt: Added
- webaudio/delaynode-maxdelay.html: Added
- 2:30 PM Changeset in webkit [109665] by
-
- 5 edits in trunk/Source/WebCore
Simplified discreteTimeConstantForSampleRate
https://bugs.webkit.org/show_bug.cgi?id=78051
Remove hardcoded constant and simplify computation of discrete
time constant.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
No new tests needed. Covered by existing AudioParam tests.
- platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
Simplify formula.
- platform/audio/AudioUtilities.h:
(AudioUtilities): Update function signature.
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
cast to float to avoid warnings.
- webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): cast to
float to avoid warnings.
- 11:26 AM Changeset in webkit [109664] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543
Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.
This is covered by existing API tests.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- 11:13 AM Changeset in webkit [109663] by
-
- 11 edits in trunk/Source
Fix build with newer versions of clang.
Source/WebCore:
- bindings/objc/DOM.mm:
(-[DOMNode description]):
Remove an unused parameter.
- bridge/objc/objc_instance.mm:
(ObjcInstance::getClass):
Use object_getClass instead of accessing isa directly.
- platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.
- platform/graphics/mac/WebLayer.mm:
(-[CALayer _descriptionWithPrefix:]):
Use %p for the CALayer pointer, and use %lu for the number of sublayers.
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Cast the NSAttachmentCharacte enum to unichar.
Source/WebKit/mac:
- Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
Use %ld and cast to long.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
- 10:55 AM Changeset in webkit [109662] by
-
- 1 edit2 adds in trunk/LayoutTests
Biquad getFrequencyResponse needs a layout test.
https://bugs.webkit.org/show_bug.cgi?id=79503
Add simple test for getFrequencyResponse.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
- webaudio/biquad-getFrequencyResponse-expected.txt: Added.
- webaudio/biquad-getFrequencyResponse.html: Added.
- 10:49 AM Changeset in webkit [109661] by
-
- 3 edits in trunk/Source/WebKit/chromium
Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
https://bugs.webkit.org/show_bug.cgi?id=80198
Reviewed by Adam Barth.
- src/AssociatedURLLoader.cpp:
- tests/AssociatedURLLoaderTest.cpp:
- 4:34 AM Changeset in webkit [109660] by
-
- 5 edits in trunk
Unreviewed, rolling out r109343.
http://trac.webkit.org/changeset/109343
https://bugs.webkit.org/show_bug.cgi?id=80212
Int32array can't handle values for native nodes because they
have int64 ids (Requested by loislo1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-03
Source/WebCore:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
- 1:16 AM Changeset in webkit [109659] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK tests_expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 1:12 AM Changeset in webkit [109658] by
-
- 4 edits in trunk/Source/WebCore
Free up a bit in RenderObject.
http://webkit.org/b/80208
Patch by Andreas Kling <awesomekling@apple.com> on 2012-03-03
Reviewed by Anders Carlsson.
Move m_hasMarkupTruncation to RenderBlock, stealing one bit from m_lineHeight.
This flag is only used by RenderBlock.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::hasMarkupTruncation):
(RenderBlock):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
- 1:09 AM Changeset in webkit [109657] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline after r109623.
- editing/selection/select-line-break-with-opposite-directionality-expected.txt:
- 12:35 AM Changeset in webkit [109656] by
-
- 40 edits15 adds in trunk
Implement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160
The specification related to this implementation is located at http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units and creation of primitive values.
Added new Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin for viewport-relative lengths
and included the support for fetching the value of these relative length units based on the current viewport size.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-03
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html
- css/CSSComputedStyleDeclaration.cpp: Modified to support viewport relative Length types.
(WebCore::getPositionOffsetValue): Ditto.
(WebCore::getBorderRadiusCornerValues): Ditto.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::lineHeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
- css/CSSGrammar.y: Added vw/vh/vmin support.
- css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
- css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue): Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyBorderRadius::applyValue): Ditto.
(WebCore::ApplyPropertyFontSize::applyValue): Ditto.
(WebCore::ApplyPropertyLineHeight::applyValue): Ditto.
(WebCore::ApplyPropertyVerticalAlign::applyValue): Ditto.
- css/CSSStyleSelector.cpp:
(WebCore::convertToLength): Added support for viewport relative units.
(WebCore::createGridTrackBreadth): Ditto.
(WebCore::CSSStyleSelector::mapFillSize): Ditto.
(WebCore::CSSStyleSelector::mapFillXPosition): Ditto.
(WebCore::CSSStyleSelector::mapFillYPosition): Ditto.
- dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
- dom/Document.h: Ditto.
(Document):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion): Modified to support viewport relative Length types.
- platform/Length.h: New LengthTypes such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin added.
(WebCore::Length::calcValue): Modified to support viewport relative Length types.
(WebCore::Length::calcMinValue): Ditto.
(WebCore::Length::calcFloatValue): Ditto.
(Length):
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight): Modified to support viewport relative Length types.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight): Ditto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset): Ditto.
(WebCore::RenderBox::paintBoxDecorations): Ditto.
(WebCore::RenderBox::clipRect): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegion): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Ditto.
(WebCore::RenderBox::computeInlineDirectionMargins): Ditto.
(WebCore::RenderBox::computeLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePercentageLogicalHeight): Ditto.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computeBlockDirectionMargins): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX): Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): Ditto.
(WebCore::RenderBoxModelObject::paddingTop): Ditto.
(WebCore::RenderBoxModelObject::paddingBottom): Ditto.
(WebCore::RenderBoxModelObject::paddingLeft): Ditto.
(WebCore::RenderBoxModelObject::paddingRight): Ditto.
(WebCore::RenderBoxModelObject::paddingBefore): Ditto.
(WebCore::RenderBoxModelObject::paddingAfter): Ditto.
(WebCore::RenderBoxModelObject::paddingStart): Ditto.
(WebCore::RenderBoxModelObject::paddingEnd): Ditto.
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect): Ditto.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::computeBorderImageSide): Ditto.
(WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Ditto.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Ditto.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Ditto.
- rendering/RenderInline.cpp:
(WebCore::computeMargin): Ditto.
(WebCore::RenderInline::lineHeight): Ditto.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::viewportSize): New function to fetch the current viewport size.
(RenderObject):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Modified to support viewport relative Length types.
- rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarWidth): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarHeight): Ditto.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Ditto.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth): Ditto.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing): Ditto.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Ditto.
- rendering/RenderText.h:
(WebCore::RenderText::marginLeft): Ditto.
(WebCore::RenderText::marginRight): Ditto.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Ditto.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Ditto.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox): Ditto.
- rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor): Ditto.
(WebCore::RenderStyle::getRoundedBorderFor): Ditto.
- rendering/style/RenderStyle.h: Ditto.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
LayoutTests:
- css3/viewport-relative-lengths: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
Mar 2, 2012:
- 11:43 PM Changeset in webkit [109655] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new crashing test.
- platform/qt-5.0-wk2/Skipped:
- 11:34 PM Changeset in webkit [109654] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, updated expected files.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- platform/qt/fast/dom/prototype-inheritance-2-expected.png:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- 9:48 PM Changeset in webkit [109653] by
-
- 4 edits4 adds in trunk
Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/execCommand/reset-values-after-navigation.html
- editing/Editor.cpp:
(WebCore::Editor::clear):
LayoutTests:
- editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
- editing/execCommand/reset-values-after-navigation-expected.txt: Added.
- editing/execCommand/reset-values-after-navigation.html: Added.
- editing/execCommand/resources/reset-default-values-helper-1.html: Added.
- editing/execCommand/resources/reset-default-values-helper-2.html: Added.
- 9:31 PM Changeset in webkit [109652] by
-
- 2 edits1 add in trunk/Source/WebCore
Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/8242128>
Reviewed by Anders Carlsson.
- plugins/npapi-sandbox.h: Added.
- WebCore.xcodeproj/project.pbxproj: Added as unused file.
- 7:28 PM Changeset in webkit [109651] by
-
- 1 edit2 adds in trunk/LayoutTests
:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734
Reviewed by Antonio Gomes.
- fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
- fast/css/pseudo-empty-dynamic-empty.html: Added.
- 7:18 PM Changeset in webkit [109650] by
-
- 16 edits in tags/Safari-536.2
Merged r109340.
- 7:18 PM Changeset in webkit [109649] by
-
- 2 edits in trunk/Tools
Fix commit queue, remove duplicate entry.
- Scripts/webkitpy/common/config/committers.py:
- 7:16 PM Changeset in webkit [109648] by
-
- 4 edits in tags/Safari-536.2/Source
Versioning.
- 7:13 PM Changeset in webkit [109647] by
-
- 1 copy in tags/Safari-536.2
New Tag.
- 6:41 PM Changeset in webkit [109646] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
- Api/WebPage.h:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 6:35 PM Changeset in webkit [109645] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:
- 5:52 PM Changeset in webkit [109644] by
-
- 3 edits in trunk/LayoutTests
ES5.1-15.3.5.4. prohibits Function.caller from Getting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011
We now support getting the caller from within an accessor.
Reviewed by Sam Weinig.
- fast/js/function-dot-arguments-and-caller.html:
- platform/qt/Skipped:
- 5:48 PM Changeset in webkit [109643] by
-
- 1 edit2 adds in trunk/LayoutTests
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Unreviewed rebaselining. Cr-Linux returns
application/javascript for .js files instead of text/javascript.
- platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Added.
- 5:47 PM Changeset in webkit [109642] by
-
- 7 edits in trunk/Source/WebCore
Revert borders to integers for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=80175
Reviewed by Eric Seidel.
Change border representation and calculation back to integers to ensure
that borders given the same width are rendered with the same actual width.
This will also avoid unnecessary type conversions when we switch over
to subpixel precision.
No new tests.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderTop):
(WebCore::RenderBoxModelObject::borderBottom):
(WebCore::RenderBoxModelObject::borderLeft):
(WebCore::RenderBoxModelObject::borderRight):
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
- rendering/RenderTable.h:
(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(RenderTable):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
- rendering/RenderTableCell.h:
(RenderTableCell):
- 5:32 PM Changeset in webkit [109641] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove an erroneous expected result that showed up in r109303.
- platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
- 5:24 PM Changeset in webkit [109640] by
-
- 2 edits in trunk/LayoutTests
Mark a few tests as flaky on Leopard debug.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 5:22 PM Changeset in webkit [109639] by
-
- 8 edits in branches/subpixellayout/Source
Change RenderBox::borderBoundingBox to return pixel snapped values and get rid of pixelSnapped version of same.
- 5:22 PM Changeset in webkit [109638] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Accelerated compositing: Checkerboard never goes away
https://bugs.webkit.org/show_bug.cgi?id=79020
RIM PR #134164
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-02
Reviewed by Adam Treat.
Checkerboard appears in accelerated compositing layers when there's no
texture for (part of) a layer. The layer renderer queues up some render
jobs and schedules a commit to make the WebKit thread process those
jobs. Render jobs performed during commit cause texture upload jobs to
be scheduled on the UI thread. Texture uploads are performed when next
drawing the layers.
Unfortunately, sometimes commit operation happens without a subsequent
call draw the layers.
In order to implement one-shot drawing sync, I added a call to
commitRootLayerIfNeeded() in BackingStore::renderContents(), and
I was lucky that most of the time, renderContents() is followed by
blit(Visible)Contents() which in turn draws the layers.
However, render is not always followed by a blit, for example when
rendering offscreen tiles in BackingStore::renderOnIdle(), and in
direct rendering mode.
Fixed by making sure that every call to commitRootLayerIfNeeded() that
returns true is followed by a call to drawLayersOnCommit(), unless a
blit was requested already.
Also tweak the logic for one-shot drawing sync to make the code in
drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
- Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
- 5:03 PM Changeset in webkit [109637] by
-
- 2 edits in trunk/LayoutTests
Another test fix after r109593. Remove the extra start body tag.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 4:59 PM Changeset in webkit [109636] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed rebaseline for Leopard.
- platform/chromium-mac-leopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- 4:57 PM Changeset in webkit [109635] by
-
- 4 edits5 adds in trunk
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Reviewed by Adam Barth.
Source/WebCore:
Most of the code was already there, this just fixes the FIXME
which was causing this feature not to work. Chromium already
had this #ifdef enabled, but other ports (at least Mac) do not.
Test: fast/files/xhr-response-blob.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
LayoutTests:
- fast/files/script-tests/xhr-response-blob.js: Added.
(xhr.onreadystatechange):
- fast/files/xhr-response-blob-expected.txt: Added.
- fast/files/xhr-response-blob.html: Added.
- platform/chromium/fast/files/xhr-response-blob-expected.txt: Added.
- 4:50 PM Changeset in webkit [109634] by
-
- 7 edits1 delete in trunk/Source/WebCore
Revert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80151
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- page/DOMWindow.idl:
- workers/DOMWindowWorker.idl: Removed.
- 4:39 PM Changeset in webkit [109633] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Move nsStringFromWebCoreString out of PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=80202
Reviewed by Sam Weinig.
nsStringFromWebCoreString() doesn't really belong in PageClientImpl.mm,
and it makes us include PageClientImpl.h in places where we shouldn't.
Move this function into StringUtilities.{h, mm}.
- Platform/mac/StringUtilities.h: Added.
- Platform/mac/StringUtilities.mm: Added.
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- UIProcess/mac/WebPageProxyMac.mm:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
- UIProcess/mac/WebPreferencesMac.mm:
- WebKit2.xcodeproj/project.pbxproj:
- 4:29 PM Changeset in webkit [109632] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations cleanup.
Marked a bunch of flakiness as happening only in DEBUG,
and removed a whole set of tests that are no longer flaky.
- platform/chromium/test_expectations.txt:
- 4:19 PM Changeset in webkit [109631] by
-
- 2 edits33 adds in trunk/LayoutTests
Unreviewed rebaseline of SVG feImage tests after r105612 and r106113.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:15 PM Changeset in webkit [109630] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80140
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
we should revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMWindowHTML.idl: Removed.
- page/DOMWindow.idl:
- 4:08 PM Changeset in webkit [109629] by
-
- 9 edits1 add1 delete in trunk/LayoutTests
Unreviewed, rebaseline some SVG tests after r105612.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium/test_expectations.txt:
- 3:59 PM Changeset in webkit [109628] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80148
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- xml/DOMWindowXML.idl: Removed.
- 3:57 PM Changeset in webkit [109627] by
-
- 3 edits in trunk/Source/JavaScriptCore
When getting the line number of a call into a call frame with no code block, it's
incorrect to rely on the returnPC
https://bugs.webkit.org/show_bug.cgi?id=80195
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- 3:49 PM Changeset in webkit [109626] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, widen flaky crash expectations for FileWriter test.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109625] by
-
- 2 edits1 move12 adds1 delete in trunk/LayoutTests
Unreviewed rebaselining, update a bunch of old results for Snow Leopard.
- platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
- platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109624] by
-
- 5 edits in branches/subpixellayout/Source/WebCore/rendering
Clean up paintInfo and absoluteBoundingBox calling code on branch.
- 3:34 PM Changeset in webkit [109623] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix. Don't add an event listener for interactive debugging
when the test is ran inside a DumpRenderTree / WebKitTestRunner.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 3:24 PM Changeset in webkit [109622] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix a ChangeLog typo.
- 3:23 PM Changeset in webkit [109621] by
-
- 2 edits in trunk/Source/WebKit2
Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197
Reviewed by Alexey Proskuryakov.
It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.
- WebKit2.xcodeproj/project.pbxproj:
- 3:10 PM Changeset in webkit [109620] by
-
- 4 edits in trunk
Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605
Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.
.:
PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.
- GNUmakefile.am:
Source/WebKit/gtk/po:
- GNUmakefile.am:
- 2:48 PM Changeset in webkit [109619] by
-
- 4 edits in trunk/Source/WebCore
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188
Reviewed by Ryosuke Niwa.
Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.
No new tests were added, functionality should be unchanged.
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
- dom/Element.h:
(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
- 2:44 PM Changeset in webkit [109618] by
-
- 2 edits in trunk/Source/JavaScriptCore
Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138
Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.
- tests/mozilla/ecma/TypeConversion/9.3.1-3.js:
- 2:41 PM Changeset in webkit [109617] by
-
- 7 edits6 copies3 moves4 adds34 deletes in trunk/LayoutTests
Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194
some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac/fast/clip/008-expected.png: Added.
- platform/chromium-mac/fast/clip/011-expected.png: Added.
- platform/chromium-mac/fast/clip/012-expected.png: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- 2:34 PM Changeset in webkit [109616] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Widen/correct a few chromium expectations.
- platform/chromium/test_expectations.txt:
- 2:25 PM Changeset in webkit [109615] by
-
- 2 edits in trunk/PerformanceTests
DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082
Reviewed by Eric Seidel.
Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.
- DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
- 2:16 PM Changeset in webkit [109614] by
-
- 2 edits in trunk/LayoutTests
Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.
Unreviewed gardening.
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
- 2:00 PM Changeset in webkit [109613] by
-
- 2 edits in trunk/Tools
Add the Chromium Lion canary bot to the flakiness dashboard.
- TestResultServer/static-dashboards/builders.js:
- 1:59 PM Changeset in webkit [109612] by
-
- 4 edits3 adds in trunk
Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.
Source/WebCore:
The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.
Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
LayoutTests:
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.
Test case to check un-clipped border logic
- platform/chromium/test_expectations.txt:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- 1:45 PM Changeset in webkit [109611] by
-
- 12 edits in trunk/Source/WebCore
[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947
Reviewed by Adam Barth.
This changes the generated bindings code to only generate the Document code for the Document wrappers.
No new tests. Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 1:40 PM Changeset in webkit [109610] by
-
- 3 edits2 adds in trunk
animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623
Source/WebCore:
In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.
Reviewed by Dean Jackson.
Test: animations/animation-shorthand-overriding.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
LayoutTests:
Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.
Reviewed by Dean Jackson.
- animations/animation-shorthand-overriding-expected.txt: Added.
- animations/animation-shorthand-overriding.html: Added.
- 1:37 PM Changeset in webkit [109609] by
-
- 6 edits1 move1 add1 delete in trunk/Source/WebCore
[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968
Reviewed by Gustavo Noronha Silva.
No new tests. This is covered by existing accelerated compositing and
WebGL tests.
Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.
- GNUmakefile.list.am: GLContext should be included for all X11 builds now.
There are no longer GTK+ specific versions of GraphicsContext3D.
- platform/graphics/GraphicsContext3D.h: Add a default argument for
resolveMultisamplingIfNecessary. This will resolve the entire texture.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is
now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
- platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
- platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.
- 1:33 PM Changeset in webkit [109608] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix spelling mistake in header guard
Reviewed by Noam Rosenthal.
- 1:32 PM Changeset in webkit [109607] by
-
- 2 edits in trunk
[Qt] Remove deleted file from api.pro
Reviewed by Noam Rosenthal.
- 1:13 PM Changeset in webkit [109606] by
-
- 3 edits in trunk/Tools
links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
(linkHTMLToOpenWindow):
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testLinkHTMLToOpenWindow): added.
- 1:08 PM Changeset in webkit [109605] by
-
- 5 edits3 adds2 deletes in trunk/Source
[GTK] [AC] Generalize WindowContextGL
https://bugs.webkit.org/show_bug.cgi?id=78969
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This should not change functionality.
- GNUmakefile.list.am: Added new files to source list.
- platform/graphics/cairo/GLContext.h: Added. An abstraction for all GL contexts.
- platform/graphics/glx/GLContextGLX.cpp: Added. This file is composed of very little
new code, as the logic for instantiating offscreen GL contexts is copied from
GraphicsContext3DPrivate. The code duplication will be removed in a followup patch.
(WebCore::GLContext::platformContext):
- platform/graphics/gtk/GLContextGtk.cpp: Added. This includes some helper factories
for creating and caching GL contexts for GTK+ widgets.
Source/WebKit/gtk:
Use GLContext instead of WindowContextGL. Remove a few unnecessary
namespace specifiers in the implementation of AcceleratedCompositingContext.
- WebCoreSupport/AcceleratedCompositingContext.h: Now we find the GLContext
of our widget, which is cached in WebCore. Remove m_initialized as it isn't needed.
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): No longer initialize
m_initialized.
(WebKit::AcceleratedCompositingContext::glContext): Added.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Use glContext() now.
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer): Ditto.
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Remove unnecessary namespace specifier.
(WebKit::AcceleratedCompositingContext::notifySyncRequired): Ditto.
(WebKit::AcceleratedCompositingContext::paintContents): Ditto.
(WebKit::AcceleratedCompositingContext::showDebugBorders): Ditto.
(WebKit::AcceleratedCompositingContext::showRepaintCounter): Ditto.
- 12:58 PM Changeset in webkit [109604] by
-
- 6 edits2 adds in trunk/LayoutTests
new baselines for Skia shadows
Unreviewed rebaselining.
- platform/chromium-win-vista/svg/css/group-with-shadow-expected.png:
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium-win/svg/css/group-with-shadow-expected.png:
- platform/chromium/test_expectations.txt:
- 12:54 PM Changeset in webkit [109603] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Suppress an inspector test timing out after r109561.
- platform/chromium/test_expectations.txt:
- 12:45 PM Changeset in webkit [109602] by
-
- 7 edits40 adds13 deletes in trunk/LayoutTests
Unreviewed Chromium rebaselining.
Those tests have consistent results with other platforms and with the expected
result so unmark and rebaseline them.
- platform/chromium-linux-x86/fast/box-shadow: Added.
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac/fast/clip/008-expected.png: Removed.
- platform/chromium-mac/fast/clip/011-expected.png: Removed.
- platform/chromium-mac/fast/clip/012-expected.png: Removed.
- platform/chromium-win-vista/fast/box-shadow: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win-xp/fast/box-shadow: Added.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
- 12:39 PM Changeset in webkit [109601] by
-
- 2 edits9 adds in trunk/LayoutTests
Rebaselining SVG foreignObject tests after r108494.
Unreviewed gardening.
- platform/chromium-linux/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-leopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:34 PM Changeset in webkit [109600] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove TRACE_EVENT from CCQuadCuller::cullOccludedQuads.
https://bugs.webkit.org/show_bug.cgi?id=80174
Reviewed by James Robinson.
Covered by existing chromium unit tests.
Firing TRACE_EVENT once per draw quad is overwhelming.
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- 12:30 PM Changeset in webkit [109599] by
-
- 3 edits2 adds in trunk
[V8] Make inline event attributes use evt for SVG and event otherwise
https://bugs.webkit.org/show_bug.cgi?id=80167
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/dom/inline-event-attributes-event-param-name.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
LayoutTests:
- fast/dom/inline-event-attributes-event-param-name-expected.txt: Added.
- fast/dom/inline-event-attributes-event-param-name.html: Added.
- 12:11 PM Changeset in webkit [109598] by
-
- 2 edits in trunk/Source/WebCore
Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943
Sync up the debug printing code in PageCache with the actual logic,
and clean up the debug printing at the same time.
Reviewed by Brady Eidson.
No new tests, as this is a refactor of debug only code.
- history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
- 12:07 PM Changeset in webkit [109597] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for svg/foreignObject/fO-parent-display-changes.svg.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 12:05 PM Changeset in webkit [109596] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, suppress some failures in shadow tests due to the skia roll.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [109595] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout test fast/events/overflow-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=52064
Reviewed by Simon Fraser.
Try to make the test less flaky.
- fast/events/overflow-events.html:
Ensure that the 'overflow' events arrive one at a time in order (there is no guarantee that they *do* dispatch
though). Also added a clearer message if we fail the test. That should help us if the test is still flaky.
- 11:58 AM Changeset in webkit [109594] by
-
- 6 edits4 adds in trunk
Source/WebCore: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
<rdar://problem/10432233>
Reviewed by Antti Koivisto.
Test: fast/dom/Window/navigated-window-properties.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore): Remove custom getters for window.location and window.history; they
were unnecessary and did the wrong thing when DOMWindow returned null values
for these.
- page/DOMWindow.idl: ditto
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException): Remove assert about null values and update comment,
since this is now an expected state for navigated inner windows.
LayoutTests: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
Reviewed by Antti Koivisto.
- fast/dom/Window/navigated-window-properties-expected.txt: Added.
- fast/dom/Window/navigated-window-properties.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
- 11:54 AM Changeset in webkit [109593] by
-
- 9 edits2 adds in trunk
REGRESSION(r74971): Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by inline text boxes created by BRs being placed at the end of the line
according to the block's direction regardless of its unicode bidi-level. e.g. if we have
<div dir="rtl"><span dir="ltr">hello<br>world</span></div>
the inline box generated by the br has the bidi-level of 2 like the rest of text in the span.
This inline text box gives an illusion of having text on the left of "hello" to hit testing
and editing code and causes all sorts of problems.
Fixed the bug by replacing calls to nextLeafChild and prevLeafChild by newly introduced
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak. These two functions will
return 0 when they hit the end of a line or inline text box that's a line break. In effect,
hit testing and editing code can ignore inline boxes generated by br's.
In the long term, we should move these two functions into RenderedPosition along with the rest
of code that converts a Position and an inline box, offset pair.
Test: editing/selection/select-line-break-with-opposite-directionality.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::prevLeafChild):
(WebCore::RenderedPosition::nextLeafChild):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):
- rendering/InlineBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
- rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): If we're on the left of a RTL line, we should stay at
upstream position since we're at the end of a line.
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi): Merge the two special cases into
the general loop as the comment suggests. Skip an inline text box for a line break at the left
edge when there are more line boxes on the line.
(WebCore::RenderText::positionForPoint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Ignore line boxes created for
line boxes when there are other boxes on the line.
LayoutTests:
Add a regression test for selecting multiline bidirectional text.
- editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- editing/selection/select-line-break-with-opposite-directionality.html: Added.
- 11:48 AM Changeset in webkit [109592] by
-
- 7 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=80161
PR: 141157
BlackBerryPlatformScreen.h API has been updated. Reflect those
changes in our usage.
Source/WebCore:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
Source/WebKit/blackberry:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileWidth):
(BlackBerry::WebKit::BackingStorePrivate::tileHeight):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::createCompositingSurface):
- 11:47 AM Changeset in webkit [109591] by
-
- 14 edits1 move7 adds2 deletes in trunk/LayoutTests
Chromium rebaselines after r109512.
Unreviewed gardening.
- platform/chromium-linux/fast/block/float/026-expected.png:
- platform/chromium-linux/fast/block/float/028-expected.png:
- platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-mac-leopard/fast/block/float/026-expected.png:
- platform/chromium-mac-leopard/fast/block/float/028-expected.png:
- platform/chromium-mac-leopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium/fast/events/offsetX-offsetY-expected.txt.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
- platform/chromium-mac/fast/block/float/026-expected.png: Removed.
- platform/chromium-mac/fast/block/float/028-expected.png: Removed.
- platform/chromium-win/fast/block/float/026-expected.png:
- platform/chromium-win/fast/block/float/026-expected.txt:
- platform/chromium-win/fast/block/float/028-expected.png:
- platform/chromium-win/fast/block/float/028-expected.txt:
- platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:44 AM Changeset in webkit [109590] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Allow plugins to set opaque() on their platform layer
https://bugs.webkit.org/show_bug.cgi?id=80171
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-02
Reviewed by James Robinson.
- public/WebPluginContainer.h:
(WebPluginContainer):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 11:41 AM Changeset in webkit [109589] by
-
- 2 edits in trunk/Source/WebCore
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Unreviewed build fix.
- rendering/RenderBlock.cpp:
(OverflowEventDispatcher): Removed the unused function.
- 11:28 AM Changeset in webkit [109588] by
-
- 111 edits3 adds29 deletes in trunk/LayoutTests
Unreviewed rebaselining of images affected by these changes:
https://bugs.webkit.org/show_bug.cgi?id=76556 ('Match style of platform error underline for misspellings')
https://bugs.webkit.org/show_bug.cgi?id=78117 ('[Skia Mac] Make misspelling underline dots unclipped')
- platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png:
[139 lines deleted]
- platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:24 AM Changeset in webkit [109587] by
-
- 6 edits2 adds in trunk
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/events/overflow-events-writing-mode.html
This moves the 'overflow' event dispatch from RenderLayer to an helper class
OverflowEventDispatcher. For now, the class lives in RenderBlock as it matches
the existing code but it may be moved later to its own class as FrameView could
benefit from it too or if we need to support 'overflow' events on RenderBoxes.
- rendering/RenderBlock.cpp:
(WebCore):
(OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::computeOverflowStatus):
RAII dispatcher class that stores the information before layout and compare
them after to dispatch the right information.
(WebCore::RenderBlock::layout): Added an instance of OverflowEventDispatcher.
- rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
Helper method to know if we have an horizontal / vertical layout overflow.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
Removed the scroll tracking logic as we don't need it anymore. This removes
3 booleans from RenderLayer.
LayoutTests:
- fast/events/overflow-events-writing-mode.html: Added.
- fast/events/overflow-events-writing-mode-expected.txt: Added.
Added a test for overflow events in a vertical writing mode.
- 11:05 AM Changeset in webkit [109586] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline a test on Leopard after expectation was removed in r109516.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
- 11:02 AM Changeset in webkit [109585] by
-
- 8 edits in trunk/Source/WebCore
Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169
Reviewed by Ryosuke Niwa.
Avoid manually peeking at attribute storage to get this information. This
simplify the callsites. The actual implementation of comparison was moved to
ElementAttributeData. The mapsEquivalent() function still exists for the sake
of DocumentType nodes.
- dom/Element.cpp:
(WebCore::Element::hasEquivalentAttributes):
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::isEquivalent):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
- editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Use Element::hasTagName() instead of matching
directly to make code a bit clearer.
- 10:03 AM Changeset in webkit [109584] by
-
- 7 edits in trunk/Source
[GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-02
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - no new functionality.
Add the ScrollAnimatorNone class to compilation and enable
the smooth scrolling feature by default at compilation time.
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit/gtk:
Add a new settings option to enable smooth scrolling.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 9:40 AM Changeset in webkit [109583] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=80160
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
Previously when executing window.devicePixelRatio these two pages returned 1 now
they report the devicePixelRatio returned by computeViewportAttributes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 8:55 AM Changeset in webkit [109582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r109581.
- platform/gtk/security/block-test-expected.txt:
- 8:45 AM Changeset in webkit [109581] by
-
- 4 edits1 add in trunk
[GTK] security/block-test.html baselines differ from mac
https://bugs.webkit.org/show_bug.cgi?id=78343
Reviewed by Martin Robinson.
Tools:
Improved the FrameLoader error heuristics to match mac behavior a
bit more.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Handle ftp urls the same as http urls.
(descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
LayoutTests:
GTK baselines updates for two security tests. They're closer to
the mac baselines now.
- platform/gtk/security/block-test-expected.txt: Added.
- platform/gtk/security/block-test-no-port-expected.txt:
- 8:40 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:38 AM Changeset in webkit [109580] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] media/media-can-play-flac-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=80124
Reviewed by Martin Robinson.
Handle audio/x-flac in the mimeTypeCache() function so that we
advertize both audio/flac and audio/x-flac.
No new tests, this is covered already by media/media-can-play-flac-audio.html.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 8:37 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:37 AM Changeset in webkit [109579] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109578
- 8:30 AM Changeset in webkit [109578] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled
https://bugs.webkit.org/show_bug.cgi?id=80150
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_zoom_level() instead of
WKPageGetPageZoomFactor() to get the current effective zoom level
depending on zoom-text-only setting.
- 8:21 AM Changeset in webkit [109577] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 7:36 AM Changeset in webkit [109576] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Fix typo in patch committed in r109575
Unreviewed typo fix.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Cache the position
in floating point coordinates.
- 7:27 AM Changeset in webkit [109575] by
-
- 5 edits in trunk/Tools
[Qt][WK2] Infinite loop on history navigation, when panning
https://bugs.webkit.org/show_bug.cgi?id=79119
Reviewed by Simon Hausmann.
Make the touch mocking more robust by creating touch events
directly and sending them synchronously to the browser window.
If the sent touch event was not accepted we propagate the
original mouse event to its target.
This way we make sure we only send either a touch or a mouse
event and do not end up in an infinite loop between our mocking
code and the Qt5 automatic mouse event synthesizing.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(touchRectForPosition):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
- MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
- 7:14 AM Changeset in webkit [109574] by
-
- 14 edits in trunk
Rename DOMURL to URL in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78214
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-03-02
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Interface name change.
- html/DOMURL.idl: Added InterfaceName attribute to DOMURL.
LayoutTests:
- fast/files/domurl-script-execution-context-crash-expected.txt:
- fast/files/domurl-script-execution-context-crash.html:
- fast/js/constructor-length.html:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 6:26 AM Changeset in webkit [109573] by
-
- 5 edits2 adds in trunk
Add :scope pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=79077
Source/WebCore:
Add :scope pseudo class name & pseudoId
Add selector check for the new pseudo-class
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/scope-pseudo.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
LayoutTests:
Test new :scope pseudo-class
Reviewed by Antti Koivisto.
- fast/css/style-scoped/scope-pseudo-expected.txt: Added.
- fast/css/style-scoped/scope-pseudo.html: Added.
- 6:25 AM Changeset in webkit [109572] by
-
- 11 edits in trunk/Source/WebKit/qt
[Qt] Documentation cleanup
https://bugs.webkit.org/show_bug.cgi?id=80131
Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-03-02
Reviewed by Simon Hausmann.
QDoc uses different commands to do bold, lists, and italics.
This change updates the documentation accordingly.
QTBUG-24578
- Api/qwebframe.cpp:
- Api/qwebhistory.cpp:
- Api/qwebinspector.cpp:
- Api/qwebpage.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- declarative/qdeclarativewebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit.qdoc:
- docs/qtwebkit.qdocconf:
- 6:16 AM Changeset in webkit [109571] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 6:07 AM Changeset in webkit [109570] by
-
- 18 edits in trunk/Source
Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963
Reviewed by Adam Barth.
Source/WebCore:
Instead of creating Element-less NamedNodeMaps, the parsing code now creates
AttributeVectors, that are used to fill Element via the parserSetAttributes()
method. This allows us to remove even more methods from the NamedNodeMap.
The AttributeVector class contains convenience methods that take the attribute's
QualifiedName as parameter. This class is also used inside ElementAttributeData.
- dom/Attr.h:
(Attr):
- dom/Element.cpp:
(WebCore::Element::getAttribute):
(WebCore::Element::parserSetAttributes): Now we have to create the attribute
storage, and fill it (by Vector::swap()) with the passed attributes. Also use an
early return to reduce indentation.
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
- dom/Element.h:
(Element):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
- dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
- dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::create):
(WebCore::AttributeVector::attributeItem):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute): Boolean parameter isn't necessary
since all the callers used 'false', indicating that duplicates were not allowed.
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/NamedNodeMap.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAttributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
Source/WebKit/chromium:
- src/WebNamedNodeMap.cpp:
(WebKit::WebNamedNodeMap::attributeItem):
- 5:53 AM Changeset in webkit [109569] by
-
- 2 edits in trunk/Tools
[Qt] Use 'all' as default target when debug_and_release is in effect
When debug_and_release is enabled, in combination with build_all,
qmake will generate an aggregate makefile that calls make on both
the debug and the release makefiles, but with the 'all' target.
In this case we can't use 'first' as the default target, as the
extra targets would then not be run, so we append extra targets
to 'all' instead.
Reviewed by Simon Hausmann.
- 5:48 AM Changeset in webkit [109568] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: assertion failure in JSMainThreadExecState::instrumentedCall
https://bugs.webkit.org/show_bug.cgi?id=80152
Extracted common code of JS call instrumentation into instrumentFunctionCall method
and call it directly where the instrumentation is needed instead of calling
JSMainThreadExecState::instrumentedCall which works on the main thread only.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- 5:46 AM Changeset in webkit [109567] by
-
- 2 edits in trunk/Tools
[Qt] Make sure activeBuildConfig() returns the right config
Using isActiveConfig fails, as that only checks if the given
argument is in CONFIG, not the order.
Reviewed by Simon Hausmann.
- 5:35 AM Changeset in webkit [109566] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/Skipped: Unskip non-existent files.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- 5:31 AM Changeset in webkit [109565] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80101
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLTextAreaElement.idl: Reorder attribute/method position.
- 5:30 AM Changeset in webkit [109564] by
-
- 3 edits in trunk/Source/WebCore
Build fix after r109538.
- CMakeLists.txt:
- Modules/websockets/WebSocketDeflater.cpp:
- 5:27 AM Changeset in webkit [109563] by
-
- 10 edits2 adds in trunk
Scoped stylesheets don't appear to work in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79549
Source/WebCore:
Make the scope stack in CSSStyleSelector use ContainerNode* instead of Element*.
Adapt using sites accordingly.
Push the ShadowRoot to the scope stack in the same way that elements are pushed.
Fix an issue with removedFromDocument() on destruction.
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/style-scoped-in-shadow.html
- css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::ruleSetForScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::setupScopeStack):
(WebCore::CSSStyleSelector::pushScope):
(WebCore):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::pushParentElement):
(WebCore::CSSStyleSelector::popParentElement):
(WebCore::CSSStyleSelector::pushParentShadowRoot):
(WebCore::CSSStyleSelector::popParentShadowRoot):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::pushScope):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::CSSStyleSelector::scopeStackIsConsistent):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
- css/SelectorChecker.h:
(SelectorCheckingContext):
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Test that <style scoped> works in shadow DOM as direct child of the ShadowRoot
Reviewed by Antti Koivisto.
- fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Added.
- fast/css/style-scoped/style-scoped-in-shadow.html: Added.
- 5:24 AM Changeset in webkit [109562] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLSelectElement.idl: Reorder attribute/method position.
- 5:22 AM Changeset in webkit [109561] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 5:15 AM Changeset in webkit [109560] by
-
- 3 edits in trunk
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
- 5:06 AM WebKitGTK/1.8.x edited by
- (diff)
- 4:59 AM Changeset in webkit [109559] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80099
Unreviewed build fix.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- 4:58 AM Changeset in webkit [109558] by
-
- 4 edits in trunk/Source
Fix build on AppleWebKit after 109548.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- mac/WebKit2.order:
- 4:47 AM Changeset in webkit [109557] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLOptionElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80095
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLOptionElement.idl: Reorder attribute/method position.
- 4:45 AM Changeset in webkit [109556] by
-
- 12 edits3 adds in trunk/Source/WebCore
WorkerContext shouldn't know about IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=80094
Reviewed by Kentaro Hara.
There are still a couple IndexedDB stragglers we should clean up in
WebCore proper. This patch moves some IndexedDB logic from
WorkerContext into the indexeddb module.
In the process of writing this patch, I noticed that some IndexedDB
files were missing from various build systems, so I added them. I
suspect that means IndexedDB is only enabled by default on Chromium.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/indexeddb/WorkerContextIndexedDatabase.cpp: Added.
(WebCore):
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::~WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
(WebCore::WorkerContextIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/WorkerContextIndexedDatabase.h: Added.
(WebCore):
(WorkerContextIndexedDatabase):
- Modules/indexeddb/WorkerContextIndexedDatabase.idl: Added.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 4:45 AM Changeset in webkit [109555] by
-
- 5 edits in trunk
[Qt] Fix tests run with WTR not using QStyle theme
https://bugs.webkit.org/show_bug.cgi?id=80147
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
Use an environment variable (set by WTR) to select the QStyle theme.
This is a temporary kludge until we rebase the layout tests to use the
QStyle independent "mobile" theme. This also temporarily breaks the
force_static_libs_as_shared build.
- Target.pri:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
Tools:
- WebKitTestRunner/qt/main.cpp:
(main): Set environment variable for web process to use QStyle theme.
- 4:29 AM Changeset in webkit [109554] by
-
- 4 edits1 delete in trunk
Tools: Unreviewed, remove debug print call.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult):
LayoutTests: Unreviewed, unskip security/block-test.html and remove its GTK
baseline, the platform-agnostic baseline match.
- platform/gtk/Skipped:
- platform/gtk/security/block-test-expected.txt: Removed.
- 4:23 AM Changeset in webkit [109553] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 4:16 AM Changeset in webkit [109552] by
-
- 8 edits in trunk
[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=80141
Reviewed by Tor Arne Vestbø.
.:
- Source/api.pri: Use QT += opengl for the WebKit1 bits, such as the QGLWidget
usage in PageClientQt.cpp. Previously this dependency came implicitly through WebCore.pri.
Source/WebCore:
- Target.pri: Don't add widgets to QT.
- WebCore.pri: Use QT += opengl only with Qt 4, because it has an implicit QtWidgets
dependency. With Qt 5 all necessary OpenGL API is part of QtGui (with a QOpenGL* prefix).
Source/WebKit2:
- Shared/qt/WebEventFactoryQt.cpp: Removed unnecessary include.
- Target.pri: Require widgets for WK2 for the moment, until bug #79458
is fixed.
- 3:57 AM Changeset in webkit [109551] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFormElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80093
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes
- html/HTMLFormElement.idl: Reorder attribute/method position.
- 3:54 AM Changeset in webkit [109550] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80091
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLButtonElement.idl: Reorder attribute/method position.
- 3:43 AM Changeset in webkit [109549] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Build system cleanup
Rubber-stamped by Antti Koivisto.
- tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now
that the symbols are properly exported with export macros from the DLL.
- 3:40 AM Changeset in webkit [109548] by
-
- 15 edits in trunk/Source
Suspend/Resume API for pausing timers and animations.
https://bugs.webkit.org/show_bug.cgi?id=76063
Source/WebCore:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- dom/ActiveDOMObject.h:
New ReasonForSuspension: PageWillBePaused.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend): Handle new ReasonForSuspension.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setDocument):
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Frame.h:
(WebCore::Frame::activeDOMObjectsAndAnimationsSuspended):
Frame now maintains a state of suspending animation and ActiveDOMObjects,
which is inherited to all child-frames.
- page/Page.cpp:
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
- page/Page.h:
Functions for suspending and resuming active DOM objects and animations in all frames.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
WillRenderImage now checks for suspension. This causes animated images to pause
together with all other types of animations.
Source/WebKit2:
Based on the initial work of Zalan Bujtas <zalan.bujtas@nokia.com>,
Adds suspend and resume API for WebKit2 and uses it in Qt to
suspend animations and DOM timers during panning and zoom.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:33 AM Changeset in webkit [109547] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFieldSetElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80092
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLFieldSetElement.idl: Reorder attribute/method position.
- 3:28 AM Changeset in webkit [109546] by
-
- 3 edits in trunk/Source/WebCore
possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676
Rubber-stamped by Simon Hausmann.
Remove the speculative fix (the problem was elsewhere, http://trac.webkit.org/changeset/104845).
Also remove the debugging code added for this bug.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(Document):
- 3:16 AM Changeset in webkit [109545] by
-
- 11 edits in trunk
Web Inspector: Implement suggestions in Watch Expressions
https://bugs.webkit.org/show_bug.cgi?id=79912
Source/WebCore:
Drive-by: make subproperties in ObjectPropertySections editable
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completionsForTextPrompt):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.renderPromptAsBlock):
(WebInspector.ObjectPropertyTreeElement.prototype.elementAndValueToEdit):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing.blurListener):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted):
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
(WebInspector.ObjectPropertyPrompt):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.renderPromptAsBlock):
(WebInspector.WatchExpressionTreeElement.prototype.elementAndValueToEdit):
(WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
- inspector/front-end/inspector.css:
(.watch-expressions > li.editing-sub-part .text-prompt):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/console-cd-completions.html:
- inspector/debugger/debugger-completions-on-call-frame.html:
- 2:55 AM Changeset in webkit [109544] by
-
- 4 edits in trunk
[EFL] Build warning : comparison between signed and unsigned integer expressions.
https://bugs.webkit.org/show_bug.cgi?id=79860
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.
Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.
- Source/WebCore/bindings/js/JSDocumentCustom.cpp:
- Source/WebCore/platform/ContextMenu.cpp:
- Source/WebKit/efl/ewk/ewk_view_single.cpp:
- 2:46 AM Changeset in webkit [109543] by
-
- 3 edits3 adds in trunk
REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/css/pending-stylesheet-repaint.html
If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.
- dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
LayoutTests:
- fast/css/pending-stylesheet-repaint-expected.png: Added.
- fast/css/pending-stylesheet-repaint-expected.txt: Added.
- fast/css/pending-stylesheet-repaint.html: Added.
- 2:43 AM Changeset in webkit [109542] by
-
- 11 edits1 copy3 moves in trunk
[Qt] Move QStyle theming code out of WebCore into WebKit1
https://bugs.webkit.org/show_bug.cgi?id=80128
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/api.pri: Adjust to moving source files.
Source/WebCore:
Moved QStyle dependant code into WebKit1, where it's okay to depend on
QtWidgets/QStyle. Added factory hooks into RenderThemeQt to allow changing
the default "mobile" style to QStyle on start-up.
- Target.pri:
- platform/qt/RenderThemeQt.cpp:
(WebCore):
(WebCore::RenderThemeQt::setCustomTheme):
(WebCore::RenderThemeQt::customScrollbarTheme):
(WebCore::createTheme):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
- platform/qt/RenderThemeQt.h:
(WebCore):
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
- platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
Source/WebKit/qt:
Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
Install the QStyle factory functions in initWebCoreQt.cpp.
- Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
- WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):
- WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.
(WebCore):
(ScrollbarThemeQStyle):
- 2:40 AM Changeset in webkit [109541] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColumnRuleStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80085
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:39 AM Changeset in webkit [109540] by
-
- 16 edits in trunk/Source/WebCore
Web Inspector: enable Timeline panel for workers
https://bugs.webkit.org/show_bug.cgi?id=80130
Enabled Timeline panel for worker inspector. Refactored
JS function calls instrumentation to work for both
worker contexts and documents.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore):
(WebCore::JSMainThreadExecState::instrumentedCall):
- bindings/js/ScriptState.cpp:
(WebCore::scriptExecutionContextFromScriptState):
(WebCore):
- bindings/js/ScriptState.h:
(WebCore):
- bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::scriptExecutionContext):
(WebCore):
(WebCore::scriptExecutionContextFromScriptState):
- bindings/v8/ScriptState.h:
(WebCore):
(ScriptState):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
- 2:37 AM Changeset in webkit [109539] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK tests expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 2:24 AM Changeset in webkit [109538] by
-
- 18 edits1 copy12 adds in trunk
Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522
Source/JavaScriptCore:
Added USE(ZLIB) flag.
Reviewed by Kent Tamura.
- wtf/Platform.h:
Source/WebCore:
Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.
Reviewed by Kent Tamura.
Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html
- CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.gyp/WebCore.gyp: Added zlib dependency.
- WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect): Set m_extensions.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
- websockets/WebSocketChannel.h:
- websockets/WebSocketDeflateFramer.cpp: Added.
(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):
- websockets/WebSocketDeflateFramer.h: Added.
(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):
LayoutTests:
Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
- http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(_retrieve_frame):
(web_socket_transfer_data):
- platform/efl/Skipped: Skips tests rely on zlib
- platform/qt/Skipped: Ditto.
- 2:21 AM Changeset in webkit [109537] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:59 AM Changeset in webkit [109536] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691
Reviewed by Pavel Feldman.
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode.prototype.createCell):
(WebInspector.IDBDataGridNode.prototype._formatValue):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get subtype):
- inspector/front-end/indexedDBViews.css:
(.indexed-db-data-view .data-grid .data-container td):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column div.primitive-value):
(.indexed-db-data-view .data-grid .data-container td .section .header .title):
- 1:57 AM Changeset in webkit [109535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark
fast/frames/flattening/frameset-flattening-advanced.html as flaky in GTK.
- platform/gtk/test_expectations.txt:
- 1:50 AM Changeset in webkit [109534] by
-
- 2 edits in trunk/Tools
Updated EventSender to send complete gesture events.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-02
Reviewed by Adam Barth.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::gestureEvent): set additional parameters in sent events.
- 1:35 AM Changeset in webkit [109533] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build.
- GNUmakefile.am: allow WebKitWebProcess to link with zlib properly.
- 1:32 AM Changeset in webkit [109532] by
-
- 7 edits in trunk
[Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79765
Patch by Wei James <james.wei@intel.com> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
- webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- webaudio/AudioContext.h:
(WebCore):
(AudioContext):
(WebCore::AudioContext::maxNumberOfChannels):
- webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:30 AM Changeset in webkit [109531] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:22 AM Changeset in webkit [109530] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 1:20 AM Changeset in webkit [109529] by
-
- 8 edits2 adds in trunk
Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command
Test: editing/execCommand/default-paragraph-separator.html
- editing/Editor.cpp:
(WebCore::Editor::Editor):
- editing/Editor.h:
(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):
- editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):
- editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::create):
(WebCore):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
Added create(Document*) method that defaults to pTag as the QualifiedName.
LayoutTests:
- editing/execCommand/default-paragraph-separator-expected.txt: Added.
- editing/execCommand/default-paragraph-separator.html: Added.
- 1:12 AM Changeset in webkit [109528] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064
Reviewed by James Robinson.
Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- 1:05 AM Changeset in webkit [109527] by
-
- 3 edits in trunk/Source/WebCore
Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059
Reviewed by Brady Eidson.
- WebCore.exp.in: Only export IconDatabase symbols when the feature is
enabled.
- loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.
- 12:55 AM Changeset in webkit [109526] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().
Rubber-stamped internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::learnText):
- 12:50 AM Changeset in webkit [109525] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 12:33 AM Changeset in webkit [109524] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
https://bugs.webkit.org/show_bug.cgi?id=79646
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-02
Reviewed by Andreas Kling.
INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
with Ewk_Context_Menu_Action.
To avoid similar case in the feature I added checks between WebCore and
WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_contextmenu.h:
- 12:22 AM WebKitGTK/1.8.x edited by
- Added r109509 as proposed merge (diff)
- 12:15 AM Changeset in webkit [109523] by
-
- 1 edit2 adds in trunk/LayoutTests
reflection computed style test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75902
Reviewed by Ojan Vafai.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/reflection-computed-style-expected.txt: Added.
- css3/calc/reflection-computed-style.html: Added.
- 12:15 AM Changeset in webkit [109522] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- 12:11 AM Changeset in webkit [109521] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Send didCommitAndDrawFrame after swap
https://bugs.webkit.org/show_bug.cgi?id=80052
Patch by John Bauman <jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.
Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- 12:06 AM Changeset in webkit [109520] by
-
- 8 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/Skipped: Skip 2 new failing tests and unskip a new
media test that should pass on GTK.
- platform/gtk/editing/inserting/5994480-2-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/fast/multicol/span/clone-summary-expected.txt:
- 12:04 AM Changeset in webkit [109519] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098
Reviewed by Anders Carlsson.
If DFGCodeBlocks traces a CodeBlock that might also be traced via its owner Executable,
then you might have the visitAggregate() method called concurrently by multiple threads.
This is benign on 64-bit -- visitAggregate() and everything it calls turns out to be
racy and slightly imprecise but not unsound. But on 32-bit, visitAggregate() may crash
due to word tearing in ValueProfile bucket updates inside of computeUpdatedPrediction().
It would seem that the fix is just to have DFGCodeBlocks not trace CodeBlocks that are
not jettisoned. But CodeBlocks may be jettisoned later during the GC, so it must trace
any CodeBlock that it knows to be live by virtue of it being reachable from the stack.
Hence the real fix is to make sure that concurrent calls into CodeBlock::visitAggregate()
don't lead to two threads racing over each other as they clobber state. This patch
achieves this with a simple CAS loop: whichever thread wins the CAS race (which is
trivially linearizable) will get to trace the CodeBlock; all other threads give up and
go home.
Unfortunately there will be no new tests. It's possible to reproduce this maybe 1/10
times by running V8-v6's raytrace repeatedly, using the V8 harness hacked to rerun it
even when it's gotten sufficient counts. But that takes a while - sometimes up to a
minute to get a crash. I have no other reliable repro case.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(DFGData):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::clearMarks):
- 12:01 AM Changeset in webkit [109518] by
-
- 7 edits8 adds in trunk
AudioParam needs tests for the parameter automation routines.
https://bugs.webkit.org/show_bug.cgi?id=77666
Patch by Raymond Toy <Raymond Toy> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
Tests: webaudio/audioparam-linearRampToValueAtTime.html
webaudio/audioparam-setTargetValueAtTime.html
webaudio/audioparam-setValueAtTime.html
webaudio/audioparam-setValueCurveAtTime.html
- webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Round the
curveIndex to fix timing issue in setValueCurveAtTime.
LayoutTests:
- webaudio/audioparam-exponentialRampToValueAtTime.html:
- webaudio/audioparam-linearRampToValueAtTime-expected.txt: Added.
- webaudio/audioparam-linearRampToValueAtTime.html: Added.
- webaudio/audioparam-setTargetValueAtTime-expected.txt: Added.
- webaudio/audioparam-setTargetValueAtTime.html: Added.
- webaudio/audioparam-setValueAtTime-expected.txt: Added.
- webaudio/audioparam-setValueAtTime.html: Added.
- webaudio/audioparam-setValueCurveAtTime-expected.txt: Added.
- webaudio/audioparam-setValueCurveAtTime.html: Added.
- webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(createLinearRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction.return.var):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/audio-testing.js: Moved isValidNumber from
biquad-testing.js to here.
- webaudio/resources/biquad-testing.js: Moved isValidNumber from
here to audio-testing.js.
Mar 1, 2012:
- 11:33 PM Changeset in webkit [109517] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Simplify the code to adjust font sizes depending on screen DPI
https://bugs.webkit.org/show_bug.cgi?id=80032
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(screenDPI): Helper function to get the DPI of a given
GdkScreen. Added also fallback code when gdk_screen_resolution
returns -1.
(webViewGetDPI): Use screenDPI() from WebCore.
(webViewConvertFontSizeToPixels): This is the existing
pixelsFromSize(), renamed and moved to be used also in
webkit_web_view_screen_changed().
(webkit_web_view_screen_changed): Use
webViewConvertFontSizeToPixels() instead of duplicating the code.
(webkit_web_view_settings_notify): Use
webViewConvertFontSizeToPixels() instead of pixelsFromSize().
- 10:50 PM Changeset in webkit [109516] by
-
- 2 edits in trunk/LayoutTests
Moar tightening of expectations (mac this time).
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 10:50 PM Changeset in webkit [109515] by
-
- 11 edits in trunk/Source/WebCore
Fix code generators to correctly guard header declarations that have a [Conditional] attribute.
https://bugs.webkit.org/show_bug.cgi?id=79375
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-01
Reviewed by Kentaro Hara.
In most cases code generators weren't checking the Conditional attribute
when generating code in headers for function/attribute/constants, they
were just guarding against the Conditional for the whole interface.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- 10:47 PM Changeset in webkit [109514] by
-
- 8 edits5 adds in trunk
[chromium] Make opaque paint tracker aware of SkCanvas layers
https://bugs.webkit.org/show_bug.cgi?id=79145
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-01
Reviewed by Stephen White.
Source/WebCore:
The current opaque paint tracker ignored SkCanvas layers entirely. But
SkCanvas layers can be used to apply things like alpha. So we make it
know about layers, and apply any clipping and SkPaint objects for layers
when tracking a paint.
Image clipping is done via a layer, so we can now also remove the
special-case code around image clipping in PlatformContextSkia and
OpaqueRegionSkia.
Unit test: PlatformContextSkiaTest.contextTransparencyLayerTest
Test: compositing/culling/clear-fixed-iframe.html
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
LayoutTests:
- compositing/culling/clear-fixed-iframe-expected.png: Added.
- compositing/culling/clear-fixed-iframe-expected.txt: Added.
- compositing/culling/clear-fixed-iframe.html: Added.
- compositing/culling/resources/clear-fixed-iframe-content.html: Added.
- 10:43 PM Changeset in webkit [109513] by
-
- 3 edits2 adds in trunk/Source/WebCore
Add HTML-capable popup API to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=79078
Reviewed by Dimitri Glazkov.
This API will be used to implement a calendar picker of <input type=date>.
The code is enclosed with ENABLE_PAGE_POPUP, and doesn't change any
behavior for now.
- page/ChromeClient.h: Added declarations of openPagePopup() and closePagePopup().
- loader/EmptyClients.h:
(EmptyChromeClient): Add empty implementations of new ChromeClient functions.
- page/PagePopup.h: Added.
(PagePopup): Define an empty interface
- page/PagePopupClient.h: Added.
(PagePopupClient): Define an interface to provide various information to HTMLPopup.
- 10:33 PM Changeset in webkit [109512] by
-
- 9 edits2 adds in trunk
Render overflow controls of an RTL element to its left-side.
https://bugs.webkit.org/show_bug.cgi?id=54623
This change adds a new flag WTF_USE_RTL_SCROLLBAR and render the
vertical scrollbars and resizers of RTL elements to their left side if
this new flag is enabled.
Patch by Hironori Bono <hbono@chromium.org> on 2012-03-01
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: platform/chromium/fast/events/rtl-scrollbar.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects): Move child elements right.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): ditto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::overflowClipRect): Move the content rectangle right.
- rendering/RenderLayer.cpp:
(WebCore::cornerStart): Added a function that calculates the X position of a resizer.
(WebCore):
(WebCore::cornerRect): Use cornerStart to move a resizer.
(WebCore::RenderLayer::verticalScrollbarStart): Added a function that calculates
the X position of a vertical scrollbar.
(WebCore::RenderLayer::horizontalScrollbarStart): Added a function that calculates
the X position of a horizontal scrollbar.
(WebCore::RenderLayer::scrollbarOffset): Render a vertical scrollbar to the left side
and move a horizontal scrollbar right by the width of the vertical scrollbar.
(WebCore::RenderLayer::invalidateScrollbarRect): ditto.
(WebCore::RenderLayer::positionOverflowControls): ditto.
(WebCore::RenderLayer::hitTestOverflowControls): ditto.
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/style/RenderStyle.h: Added shouldPlaceBlockDirectionScrollbarOnLogicalLeft,
which returns if we need to move a left scrollbar to its right side.
Source/WebKit/chromium:
- features.gypi: Set WTF_USE_RTL_SCROLLBAR to 1 on Chromium.
LayoutTests:
- platform/chromium/fast/events/rtl-scrollbar-expected.txt: Added.
- platform/chromium/fast/events/rtl-scrollbar.html: Added.
- 10:28 PM Changeset in webkit [109511] by
-
- 2 edits in trunk/Source/JavaScriptCore
The JIT should not crash the entire process just because there is not enough executable
memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-01
Reviewed by Csaba Osztrogonác.
Fix for ARM, SH4.
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
- 10:28 PM Changeset in webkit [109510] by
-
- 2 edits in trunk/LayoutTests
Tighten various expectations to be more accurate.
Unreviewed, expectations change.
(This means fewer "unexpected pass" results).
- platform/chromium/test_expectations.txt:
- 10:26 PM Changeset in webkit [109509] by
-
- 2 edits in trunk/Tools
WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=80033
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.
GCC 4.7 no longer includes unistd.h from most of the standard C++
header files, so we need to explicitly include it for getcwd().
- WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
not only on Mac, but on all Unix platforms.
- 10:13 PM Changeset in webkit [109508] by
-
- 3 edits in trunk/Websites/webkit.org
Add a link to the EFL wiki page
https://bugs.webkit.org/show_bug.cgi?id=79439
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-01
Reviewed by Adam Barth.
- building/tools.html:
- css/main.css: Cross-browser border-radius.
- 10:11 PM Changeset in webkit [109507] by
-
- 2 edits in trunk/LayoutTests
fast/forms/textfield-overflow.html is no longer failing.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 10:10 PM Changeset in webkit [109506] by
-
- 10 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Implement features for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=79820
Patch by Andy Chen <andchen@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.
- Make it be able to search text around the whole page instead of single frame.
- Make it be able to start new search from active selection and last active match.
No new tests as this patch doesn't change behavior.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
- Api/WebPage_p.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
(WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::incrementFrame):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- WebKitSupport/InPageSearchManager.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::frameUnloaded):
- WebKitSupport/InputHandler.h:
- 9:56 PM Changeset in webkit [109505] by
-
- 1 edit9 moves1 add in trunk/LayoutTests
Fix paths to mac baselines for virtual/gpu/canvas/philip tests.
Unreveiwed, baselines update.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.gradient.radial.cone.cylinder-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.basic-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.basic-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.transformed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.transformed-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve1-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve2-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.shadow.enable.blur-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.text.draw.fontface.notinpage-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.setTransform.skewed-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.transform.skewed-expected.txt.
- 9:45 PM Changeset in webkit [109504] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 9:43 PM Changeset in webkit [109503] by
-
- 4 edits3 adds in trunk
REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
https://bugs.webkit.org/show_bug.cgi?id=79445
Reviewed by Dimitri Glazkov.
Source/WebCore:
If the inner text height of a search field is smaller than the
content box height of the <input>, the height of the container
element should be same as the content box height.
When the element style is changed, the RenderStyle height of the
container element is cleared, but the renderer height of the
container element remains. We had a bug that layout() didn't set
the RenderStyle height in a case that the renderer height was the
desired height. It shrunk the renderer height as the result of
layout for children.
Tests: fast/forms/search/search-shaking-text.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Always set the RenderStyle height explicitly.
LayoutTests:
- fast/forms/search/search-shaking-text-expected.html: Added.
- fast/forms/search/search-shaking-text.html: Added.
- platform/chromium/test_expectations.txt: This change might need a rebaseline of fast/repaint/search-field-cancel.html
- 9:40 PM Changeset in webkit [109502] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rebaselined run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- 9:37 PM Changeset in webkit [109501] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/js/mozilla/strict/13.1-expected.txt: Removed.
- 9:35 PM Changeset in webkit [109500] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/js/mozilla/strict/12.14.1-expected.txt: Removed.
- 9:26 PM Changeset in webkit [109499] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/frames/transparent-scrollbar-expected.png: Added.
- platform/chromium-win/fast/frames/transparent-scrollbar-expected.png: Added.
- 9:25 PM Changeset in webkit [109498] by
-
- 2 edits in trunk/Tools
Actually look at the args in driver_input :(.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
- 8:54 PM Changeset in webkit [109497] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/10942540> REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build
https://bugs.webkit.org/show_bug.cgi?id=80034
Reviewed by Benjamin Poulain.
Safari Webpage Preview Fetcher can’t access the WebCore framework when launched from a WebKit
nightly build. After r108956, this causes it to crash.
- platform/mac/LocalizedStringsMac.cpp:
(WebCore::localizedString): Added a null-check for the value returned from
CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebCore")).
- 8:49 PM Changeset in webkit [109496] by
-
- 2 edits in trunk/Tools
Fix typo in flag used to run gpu virtual suites.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
- 8:31 PM Changeset in webkit [109495] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r109317.
http://trac.webkit.org/changeset/109317
Let's try watchlists again now that we're using a pure git
working copy
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.run):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 8:26 PM Changeset in webkit [109494] by
-
- 5 edits3 adds in trunk
[BlackBerry]Array of Cookies in HTTP request header are not in order.
https://bugs.webkit.org/show_bug.cgi?id=79870
Std::sort and HashMap are not stable. So cookies with the same creating
time sometimes are sent disorder.
Change std::sort with std::stable-sort.
We don't need using HashMap to save so few cookies for one domain.
It is a wast of time to create HashMap, too.
So change it with vector.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-01
Reviewed by George Staikos.
Test: http/tests/cookies/resources/setArraycookies.php
- platform/blackberry/CookieManager.cpp:
(WebCore::cookieSorter):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookieAtIndex):
(WebCore::CookieMap::removeCookie):
(WebCore):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::updateOldestCookie):
(WebCore::CookieMap::deleteAllCookiesAndDomains):
- platform/blackberry/CookieMap.h:
(WebCore::CookieMap::count):
(CookieMap):
- 8:23 PM Changeset in webkit [109493] by
-
- 15 edits84 moves in trunk/Source/WebCore
Move WebCore/storage/IDB* files into WebCore/Modules/indexeddb
https://bugs.webkit.org/show_bug.cgi?id=80071
Reviewed by Kentaro Hara.
Now that we've removed all the ENABLE(INDEXED_DATABASE) ifdefs from
WebCore proper, we can move IndexedDB into its own module.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBAny.cpp: Copied from Source/WebCore/storage/IDBAny.cpp.
- Modules/indexeddb/IDBAny.h: Copied from Source/WebCore/storage/IDBAny.h.
- Modules/indexeddb/IDBAny.idl: Copied from Source/WebCore/storage/IDBAny.idl.
- Modules/indexeddb/IDBBackingStore.h: Copied from Source/WebCore/storage/IDBBackingStore.h.
- Modules/indexeddb/IDBCallbacks.h: Copied from Source/WebCore/storage/IDBCallbacks.h.
- Modules/indexeddb/IDBCursor.cpp: Copied from Source/WebCore/storage/IDBCursor.cpp.
- Modules/indexeddb/IDBCursor.h: Copied from Source/WebCore/storage/IDBCursor.h.
- Modules/indexeddb/IDBCursor.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
- Modules/indexeddb/IDBCursorBackendImpl.cpp: Copied from Source/WebCore/storage/IDBCursorBackendImpl.cpp.
- Modules/indexeddb/IDBCursorBackendImpl.h: Copied from Source/WebCore/storage/IDBCursorBackendImpl.h.
- Modules/indexeddb/IDBCursorBackendInterface.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
- Modules/indexeddb/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursorWithValue.cpp.
- Modules/indexeddb/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorWithValue.h.
- Modules/indexeddb/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursorWithValue.idl.
- Modules/indexeddb/IDBDatabase.cpp: Copied from Source/WebCore/storage/IDBDatabase.cpp.
- Modules/indexeddb/IDBDatabase.h: Copied from Source/WebCore/storage/IDBDatabase.h.
- Modules/indexeddb/IDBDatabase.idl: Copied from Source/WebCore/storage/IDBDatabase.idl.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.cpp.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.h.
- Modules/indexeddb/IDBDatabaseBackendInterface.h: Copied from Source/WebCore/storage/IDBDatabaseBackendInterface.h.
- Modules/indexeddb/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.cpp.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.h.
- Modules/indexeddb/IDBDatabaseError.h: Copied from Source/WebCore/storage/IDBDatabaseError.h.
- Modules/indexeddb/IDBDatabaseError.idl: Copied from Source/WebCore/storage/IDBDatabaseError.idl.
- Modules/indexeddb/IDBDatabaseException.cpp: Copied from Source/WebCore/storage/IDBDatabaseException.cpp.
- Modules/indexeddb/IDBDatabaseException.h: Copied from Source/WebCore/storage/IDBDatabaseException.h.
- Modules/indexeddb/IDBDatabaseException.idl: Copied from Source/WebCore/storage/IDBDatabaseException.idl.
- Modules/indexeddb/IDBEventDispatcher.cpp: Copied from Source/WebCore/storage/IDBEventDispatcher.cpp.
- Modules/indexeddb/IDBEventDispatcher.h: Copied from Source/WebCore/storage/IDBEventDispatcher.h.
- Modules/indexeddb/IDBFactory.cpp: Copied from Source/WebCore/storage/IDBFactory.cpp.
- Modules/indexeddb/IDBFactory.h: Copied from Source/WebCore/storage/IDBFactory.h.
- Modules/indexeddb/IDBFactory.idl: Copied from Source/WebCore/storage/IDBFactory.idl.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.cpp.
- Modules/indexeddb/IDBFactoryBackendImpl.h: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.h.
- Modules/indexeddb/IDBFactoryBackendInterface.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.cpp.
- Modules/indexeddb/IDBFactoryBackendInterface.h: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.h.
- Modules/indexeddb/IDBIndex.cpp: Copied from Source/WebCore/storage/IDBIndex.cpp.
- Modules/indexeddb/IDBIndex.h: Copied from Source/WebCore/storage/IDBIndex.h.
- Modules/indexeddb/IDBIndex.idl: Copied from Source/WebCore/storage/IDBIndex.idl.
- Modules/indexeddb/IDBIndexBackendImpl.cpp: Copied from Source/WebCore/storage/IDBIndexBackendImpl.cpp.
- Modules/indexeddb/IDBIndexBackendImpl.h: Copied from Source/WebCore/storage/IDBIndexBackendImpl.h.
- Modules/indexeddb/IDBIndexBackendInterface.h: Copied from Source/WebCore/storage/IDBIndexBackendInterface.h.
- Modules/indexeddb/IDBKey.cpp: Copied from Source/WebCore/storage/IDBKey.cpp.
- Modules/indexeddb/IDBKey.h: Copied from Source/WebCore/storage/IDBKey.h.
- Modules/indexeddb/IDBKey.idl: Copied from Source/WebCore/storage/IDBKey.idl.
- Modules/indexeddb/IDBKeyPath.cpp: Copied from Source/WebCore/storage/IDBKeyPath.cpp.
- Modules/indexeddb/IDBKeyPath.h: Copied from Source/WebCore/storage/IDBKeyPath.h.
- Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.cpp.
- Modules/indexeddb/IDBKeyPathBackendImpl.h: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.h.
- Modules/indexeddb/IDBKeyRange.cpp: Copied from Source/WebCore/storage/IDBKeyRange.cpp.
- Modules/indexeddb/IDBKeyRange.h: Copied from Source/WebCore/storage/IDBKeyRange.h.
- Modules/indexeddb/IDBKeyRange.idl: Copied from Source/WebCore/storage/IDBKeyRange.idl.
- Modules/indexeddb/IDBLevelDBBackingStore.cpp: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.cpp.
- Modules/indexeddb/IDBLevelDBBackingStore.h: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.h.
- Modules/indexeddb/IDBLevelDBCoding.cpp: Copied from Source/WebCore/storage/IDBLevelDBCoding.cpp.
- Modules/indexeddb/IDBLevelDBCoding.h: Copied from Source/WebCore/storage/IDBLevelDBCoding.h.
- Modules/indexeddb/IDBObjectStore.cpp: Copied from Source/WebCore/storage/IDBObjectStore.cpp.
- Modules/indexeddb/IDBObjectStore.h: Copied from Source/WebCore/storage/IDBObjectStore.h.
- Modules/indexeddb/IDBObjectStore.idl: Copied from Source/WebCore/storage/IDBObjectStore.idl.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp.
- Modules/indexeddb/IDBObjectStoreBackendImpl.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.h.
- Modules/indexeddb/IDBObjectStoreBackendInterface.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendInterface.h.
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.cpp.
- Modules/indexeddb/IDBPendingTransactionMonitor.h: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.h.
- Modules/indexeddb/IDBRequest.cpp: Copied from Source/WebCore/storage/IDBRequest.cpp.
- Modules/indexeddb/IDBRequest.h: Copied from Source/WebCore/storage/IDBRequest.h.
- Modules/indexeddb/IDBRequest.idl: Copied from Source/WebCore/storage/IDBRequest.idl.
- Modules/indexeddb/IDBTracing.h: Copied from Source/WebCore/storage/IDBTracing.h.
- Modules/indexeddb/IDBTransaction.cpp: Copied from Source/WebCore/storage/IDBTransaction.cpp.
- Modules/indexeddb/IDBTransaction.h: Copied from Source/WebCore/storage/IDBTransaction.h.
- Modules/indexeddb/IDBTransaction.idl: Copied from Source/WebCore/storage/IDBTransaction.idl.
- Modules/indexeddb/IDBTransactionBackendImpl.cpp: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.cpp.
- Modules/indexeddb/IDBTransactionBackendImpl.h: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.h.
- Modules/indexeddb/IDBTransactionBackendInterface.h: Copied from Source/WebCore/storage/IDBTransactionBackendInterface.h.
- Modules/indexeddb/IDBTransactionCallbacks.h: Copied from Source/WebCore/storage/IDBTransactionCallbacks.h.
- Modules/indexeddb/IDBTransactionCoordinator.cpp: Copied from Source/WebCore/storage/IDBTransactionCoordinator.cpp.
- Modules/indexeddb/IDBTransactionCoordinator.h: Copied from Source/WebCore/storage/IDBTransactionCoordinator.h.
- Modules/indexeddb/IDBVersionChangeEvent.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
- Modules/indexeddb/IDBVersionChangeEvent.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
- Modules/indexeddb/IDBVersionChangeEvent.idl: Copied from Source/WebCore/storage/IDBVersionChangeEvent.idl.
- Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebCore/storage/IDBVersionChangeRequest.cpp.
- Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/storage/IDBVersionChangeRequest.h.
- Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/storage/IDBVersionChangeRequest.idl.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/IDBAny.cpp: Removed.
- storage/IDBAny.h: Removed.
- storage/IDBAny.idl: Removed.
- storage/IDBBackingStore.h: Removed.
- storage/IDBCallbacks.h: Removed.
- storage/IDBCursor.cpp: Removed.
- storage/IDBCursor.h: Removed.
- storage/IDBCursor.idl: Removed.
- storage/IDBCursorBackendImpl.cpp: Removed.
- storage/IDBCursorBackendImpl.h: Removed.
- storage/IDBCursorBackendInterface.h: Removed.
- storage/IDBCursorWithValue.cpp: Removed.
- storage/IDBCursorWithValue.h: Removed.
- storage/IDBCursorWithValue.idl: Removed.
- storage/IDBDatabase.cpp: Removed.
- storage/IDBDatabase.h: Removed.
- storage/IDBDatabase.idl: Removed.
- storage/IDBDatabaseBackendImpl.cpp: Removed.
- storage/IDBDatabaseBackendImpl.h: Removed.
- storage/IDBDatabaseBackendInterface.h: Removed.
- storage/IDBDatabaseCallbacks.h: Removed.
- storage/IDBDatabaseCallbacksImpl.cpp: Removed.
- storage/IDBDatabaseCallbacksImpl.h: Removed.
- storage/IDBDatabaseError.h: Removed.
- storage/IDBDatabaseError.idl: Removed.
- storage/IDBDatabaseException.cpp: Removed.
- storage/IDBDatabaseException.h: Removed.
- storage/IDBDatabaseException.idl: Removed.
- storage/IDBEventDispatcher.cpp: Removed.
- storage/IDBEventDispatcher.h: Removed.
- storage/IDBFactory.cpp: Removed.
- storage/IDBFactory.h: Removed.
- storage/IDBFactory.idl: Removed.
- storage/IDBFactoryBackendImpl.cpp: Removed.
- storage/IDBFactoryBackendImpl.h: Removed.
- storage/IDBFactoryBackendInterface.cpp: Removed.
- storage/IDBFactoryBackendInterface.h: Removed.
- storage/IDBIndex.cpp: Removed.
- storage/IDBIndex.h: Removed.
- storage/IDBIndex.idl: Removed.
- storage/IDBIndexBackendImpl.cpp: Removed.
- storage/IDBIndexBackendImpl.h: Removed.
- storage/IDBIndexBackendInterface.h: Removed.
- storage/IDBKey.cpp: Removed.
- storage/IDBKey.h: Removed.
- storage/IDBKey.idl: Removed.
- storage/IDBKeyPath.cpp: Removed.
- storage/IDBKeyPath.h: Removed.
- storage/IDBKeyPathBackendImpl.cpp: Removed.
- storage/IDBKeyPathBackendImpl.h: Removed.
- storage/IDBKeyRange.cpp: Removed.
- storage/IDBKeyRange.h: Removed.
- storage/IDBKeyRange.idl: Removed.
- storage/IDBLevelDBBackingStore.cpp: Removed.
- storage/IDBLevelDBBackingStore.h: Removed.
- storage/IDBLevelDBCoding.cpp: Removed.
- storage/IDBLevelDBCoding.h: Removed.
- storage/IDBObjectStore.cpp: Removed.
- storage/IDBObjectStore.h: Removed.
- storage/IDBObjectStore.idl: Removed.
- storage/IDBObjectStoreBackendImpl.cpp: Removed.
- storage/IDBObjectStoreBackendImpl.h: Removed.
- storage/IDBObjectStoreBackendInterface.h: Removed.
- storage/IDBPendingTransactionMonitor.cpp: Removed.
- storage/IDBPendingTransactionMonitor.h: Removed.
- storage/IDBRequest.cpp: Removed.
- storage/IDBRequest.h: Removed.
- storage/IDBRequest.idl: Removed.
- storage/IDBTracing.h: Removed.
- storage/IDBTransaction.cpp: Removed.
- storage/IDBTransaction.h: Removed.
- storage/IDBTransaction.idl: Removed.
- storage/IDBTransactionBackendImpl.cpp: Removed.
- storage/IDBTransactionBackendImpl.h: Removed.
- storage/IDBTransactionBackendInterface.h: Removed.
- storage/IDBTransactionCallbacks.h: Removed.
- storage/IDBTransactionCoordinator.cpp: Removed.
- storage/IDBTransactionCoordinator.h: Removed.
- storage/IDBVersionChangeEvent.cpp: Removed.
- storage/IDBVersionChangeEvent.h: Removed.
- storage/IDBVersionChangeEvent.idl: Removed.
- storage/IDBVersionChangeRequest.cpp: Removed.
- storage/IDBVersionChangeRequest.h: Removed.
- storage/IDBVersionChangeRequest.idl: Removed.
- 7:45 PM Changeset in webkit [109492] by
-
- 2 edits in trunk/LayoutTests
Remove tests that now pass.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 7:37 PM Changeset in webkit [109491] by
-
- 2 edits in trunk/Tools
webkitpy: test_run_test_pause_before_testing is failing after r109482
https://bugs.webkit.org/show_bug.cgi?id=80084
Unreviewed, build fix.
Fixes the test string compare to ignore the time spent running
the tests.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):
- 7:28 PM Changeset in webkit [109490] by
-
- 4 edits in trunk/Tools
nrwt: virtual tests aren't being run
https://bugs.webkit.org/show_bug.cgi?id=80083
Reviewed by Eric Seidel.
If we tried to run all of the tests by default (and
didn't specify any paths), the virtual tests weren't
picked up.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._virtual_tests):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_tests):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
- 7:28 PM Changeset in webkit [109489] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/function-name-arity-expected.txt:
- fast/js/mozilla/strict/script-tests/function-name-arity.js:
- This tests a non-existent, non-spec-defined property.
- 7:18 PM Changeset in webkit [109488] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitBorderFit in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79998
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 7:17 PM Changeset in webkit [109487] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/12.14.1-expected.txt:
- fast/js/mozilla/strict/script-tests/12.14.1.js:
- This test uses destructuring, this didn't make it into ES5.
- 7:11 PM Changeset in webkit [109486] by
-
- 2 edits in trunk/Source/WebCore
Crash when doing repeated double-tap-to-zoom gesture on apple startpage
https://bugs.webkit.org/show_bug.cgi?id=80081
<rdar://problem/10966391>
Reviewed by Sam Weinig.
Setting the contents scale on the tile cache layer was creating a WebTileCacheLayer presentation layer copy with a null _tileCache.
Implement -[WebTileCacheLayer actionForKey:] and have it always return nil so we'll avoid implicit animations, and thus creating presentation layers.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer initWithLayer:]):
Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer.
(-[WebTileCacheLayer actionForKey:]):
Implement this and always return nil.
- 7:10 PM Changeset in webkit [109485] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/13.1-expected.txt:
- fast/js/mozilla/strict/script-tests/13.1.js:
- This test uses destructuring, this didn't make it into ES5.
- 7:08 PM Changeset in webkit [109484] by
-
- 3 edits in trunk/LayoutTests
Fix typo in test, causing test to fail.
Rubber stamped by Sam Weinig.
- fast/js/number-parsing-crash-expected.txt:
- fast/js/script-tests/number-parsing-crash.js:
- 6:39 PM Changeset in webkit [109483] by
-
- 6 edits3 adds in trunk
Custom scrollbars do not support transparency
https://bugs.webkit.org/show_bug.cgi?id=50547
Source/WebCore:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-01
Reviewed by James Robinson.
RenderScrollbar, which is used even for outermost frame when
-webkit-scrollbar is specified, assumes that its background is
painted by the enclosing container. But there is no such container
for outermost frame. This causes visual glitches when the
scrollbar has transparency.
This change clears background region for custom
outermostscrollbars to erase such glitches.
Test: fast/frames/transparent-scrollbar.html
- page/FrameView.cpp:
(WebCore::FrameView::paintScrollbar): The background is cleared here.
(WebCore):
- page/FrameView.h:
(FrameView):
- platform/ScrollView.cpp:
(WebCore::ScrollView::paintScrollbar): Added to hook in FrameView
(WebCore):
(WebCore::ScrollView::paintScrollbars):
- platform/ScrollView.h:
(ScrollView):
LayoutTests:
Reviewed by James Robinson.
- fast/frames/transparent-scrollbar.html: Added.
- fast/frames/transparent-scrollbar-expected.txt: Added.
- platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Added.
- 6:35 PM Changeset in webkit [109482] by
-
- 2 edits in trunk/Tools
run-perf-tests should report the test runtime
https://bugs.webkit.org/show_bug.cgi?id=80078
Reviewed by Hajime Morita.
Record and output the aggreated test run time.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
- 6:32 PM Changeset in webkit [109481] by
-
- 2 edits in trunk/Source/JavaScriptCore
Revert my change. Broke builds.
Source/JavaScriptCore/wtf/Atomics.h:188: error: redefinition of 'bool WTF::weakCompareAndSwap(volatile uintptr_t*, uintptr_t, uintptr_t)'
Source/JavaScriptCore/wtf/Atomics.h:122: error: 'bool WTF::weakCompareAndSwap(volatile unsigned int*, unsigned int, unsigned i
- wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
- 6:29 PM Changeset in webkit [109480] by
-
- 5 edits4 adds in trunk
REGRESSION(r106388): Form state is restored to a wrong document.
https://bugs.webkit.org/show_bug.cgi?id=79206
Reviewed by Brady Eidson.
Source/WebCore:
In some cases, the URL of the current HistoryItem and the document
URL are mismatched.
A form state should be restored only if the document was loaded
with a HistoryItem and the document is not loaded as a
redirection.
Test: fast/loader/form-state-restore-with-locked-back-forward-list.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Clear m_requestedHistoryItem.
(WebCore::FrameLoader::loadItem):
Save the requested HistoryItem for didLoadWithLodItem().
- loader/FrameLoader.h:
(WebCore::FrameLoader::requestedHistoryItem):
Added. Accessor for m_requestedHistoryItem.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
Restore a form state only if the current document was loaded with
FrameLoader::loadItem() and not redirection.
LayoutTests:
- fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt: Added.
- fast/loader/form-state-restore-with-locked-back-forward-list.html: Added.
- fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html: Added.
- fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html: Added.
- 6:23 PM Changeset in webkit [109479] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107726
BUG=114068
Review URL: https://chromiumcodereview.appspot.com/9570062
- 6:13 PM Changeset in webkit [109478] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gcc build fix.
Rubber-stamped by Filip Pizlo.
- wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
- 6:04 PM Changeset in webkit [109477] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107726
BUG=114068
Review URL: https://chromiumcodereview.appspot.com/9569051
- 6:00 PM Changeset in webkit [109476] by
-
- 2 edits in trunk/Source/WebCore
SSE optimization for vsvesq and vmaxmgv
https://bugs.webkit.org/show_bug.cgi?id=77950
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.
Achieved the performance of 3.7x on vsvesq and 4.1x on vmaxmgv.
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):
- 5:57 PM Changeset in webkit [109475] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web Notification crashes the browser.
https://bugs.webkit.org/show_bug.cgi?id=79897
Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-03-01
Reviewed by Antonio Gomes.
The reason of the crash is that it still uses the iterator
after been removed from the container, which invalidates the
iterator.
We should stop processing after we have found the element
and removed from the container through the iterator.
This patch only fixes the crash issue, but not any notification
functionality issue, which is tracked seperatly.
Test case: http://sandbox.gtaero.net/chrome/notifications.php
- WebCoreSupport/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::onPermission):
(WebKit::NotificationPresenterImpl::notificationClicked):
- 5:57 PM Changeset in webkit [109474] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9570058
- 5:51 PM Changeset in webkit [109473] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9570057
- 5:44 PM Changeset in webkit [109472] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyBoxSizing in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80001
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 5:26 PM Changeset in webkit [109471] by
-
- 1 edit8 copies in branches/chromium/1025
Merge 109299
BUG=116474
Review URL: https://chromiumcodereview.appspot.com/9569050
- 5:23 PM Changeset in webkit [109470] by
-
- 1 edit8 copies in branches/chromium/963
Merge 109299
BUG=116474
Review URL: https://chromiumcodereview.appspot.com/9568049
- 5:14 PM Changeset in webkit [109469] by
-
- 16 edits in trunk/Source
[chromium] LayerChromium::contentChanged is redundant with setNeedsDisplay
https://bugs.webkit.org/show_bug.cgi?id=79708
Reviewed by Adrienne Walker.
Some layer types need special handling when they receive damage. WebGL layers need to know if their texture is
updated for clear-on-swap behavior and both WebGL and canvas 2d layers have rate limiting mechanisms tied to
receiving invalidations. This mechanism was implemented by LayerChromium::contentChanged(), but this is
redundant with setNeedsDisplay().
Covered by existing tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsDisplay):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
- 5:06 PM Changeset in webkit [109468] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark a JS strict mode test as failing in V8,
and link it to a semi-related V8 bug.
- platform/chromium/test_expectations.txt:
- 5:03 PM Changeset in webkit [109467] by
-
- 9 edits4 copies in branches/chromium/1025
Merge 109362
BUG=113755
Review URL: https://chromiumcodereview.appspot.com/9567036
- 4:47 PM Changeset in webkit [109466] by
-
- 9 edits in trunk/Source
[chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
https://bugs.webkit.org/show_bug.cgi?id=79723
Reviewed by Adrienne Walker.
Source/WebCore:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateNames):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setDebugName):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::dumpLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::setDebugName):
(WebCore::CCLayerImpl::debugName):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::name):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 4:42 PM Changeset in webkit [109465] by
-
- 9 edits4 copies in branches/chromium/963
Merge 109362
BUG=113755
Review URL: https://chromiumcodereview.appspot.com/9569046
- 4:33 PM Changeset in webkit [109464] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark two media tests as flaky.
- platform/chromium/test_expectations.txt:
- 4:25 PM Changeset in webkit [109463] by
-
- 7 edits2 adds in trunk/Source/WebCore
Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
https://bugs.webkit.org/show_bug.cgi?id=80061
Reviewed by Dimitri Glazkov.
This patch removes the last ENABLED(INDEXED_DATABASE) ifdef from
WebCore proper by moving the backend factory out of PageGroup and into
a supplement for PageGroup. After this patch, we're ready to move the
IDB code into Modules.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- WebCore.gypi:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::assertIDBFactory):
- page/PageGroup.cpp:
(WebCore):
- page/PageGroup.h:
(PageGroup):
- 4:25 PM Changeset in webkit [109462] by
-
- 2 edits in trunk/Tools
[chromium] Use webkit_support to create session storage namespaces in DRT.
https://bugs.webkit.org/show_bug.cgi?id=79933
Reviewed by Tony Chang.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createSessionStorageNamespace):
- 4:12 PM Changeset in webkit [109461] by
-
- 7 edits in trunk
ES5.1-15.3.5.4. prohibits Function.caller from Getting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011
Reviewed by Oliver Hunt.
Also, fix getting the caller from within a bound function, for within a getter,
or setter (make our implementation match other browsers).
Source/JavaScriptCore:
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- Allow this to get the caller of host functions.
(JSC::Interpreter::retrieveCallerFromVMCode):
- This should use getCallerInfo, and should skip over function bindings.
- runtime/JSFunction.cpp:
(JSC::JSFunction::callerGetter):
- This should never return a strict-mode function.
LayoutTests:
- fast/js/caller-property-expected.txt:
- fast/js/script-tests/caller-property.js:
- Add test cases covering permutations of caller/callee being strict/non-strict, And for callee being a getter/setter/bound.
- fast/js/stack-trace-expected.txt:
- Allow stack tracing over host functions.
- 4:11 PM Changeset in webkit [109460] by
-
- 3 edits in branches/chromium/1025/Source/WebCore
Merge 109406
BUG=116405
Review URL: https://chromiumcodereview.appspot.com/9564040
- 4:05 PM Changeset in webkit [109459] by
-
- 4 edits in trunk/Source
Remove deprecated FFmpeg build directories.
https://bugs.webkit.org/show_bug.cgi?id=79282
We've switched the layout of the FFmpeg repo in Chrome and these paths
are no longer needed or valid.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-03-01
Reviewed by Dirk Pranke.
Source/WebCore:
No new tests. It either compiles or not.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- DEPS:
- 3:59 PM Changeset in webkit [109458] by
-
- 5 edits in trunk
Enable IPP for Biquad filter
https://bugs.webkit.org/show_bug.cgi?id=77509
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.
Source/WebCore:
Use IIR filter in IPP and improve ~27% performance in linux.
Changes are covered by current tests.
- platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
(WebCore::Biquad::~Biquad):
(WebCore):
(WebCore::Biquad::process):
(WebCore::Biquad::reset):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setNormalizedCoefficients):
(WebCore::Biquad::setZeroPolePairs):
- platform/audio/Biquad.h:
(Biquad):
LayoutTests:
Adjust a code format issue.
- webaudio/resources/biquad-testing.js:
(filterData):
- 3:52 PM Changeset in webkit [109457] by
-
- 3 edits in branches/chromium/963/Source/WebCore
Merge 109406
BUG=116405
Review URL: https://chromiumcodereview.appspot.com/9569043
- 3:46 PM Changeset in webkit [109456] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109245
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9566040
- 3:45 PM Changeset in webkit [109455] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Rebaseline fast/flexbox/010.html on Leopard after removing its suppression.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/flexbox/010-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/flexbox/010-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/flexbox/010-expected.png.
- 3:45 PM Changeset in webkit [109454] by
-
- 5 edits2 copies in branches/chromium/1025
Merge 108548
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9564039
- 3:43 PM Changeset in webkit [109453] by
-
- 10 edits2 moves8 adds5 deletes in trunk/LayoutTests
Rebaselining some old Chromium tests and removing test_expectations.
Unreviewed gardening.
- fast/writing-mode/block-level-images-expected.txt: Renamed from LayoutTests/platform/gtk/fast/writing-mode/block-level-images-expected.txt.
- platform/chromium-linux/fast/backgrounds/background-leakage-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/chromium-linux/fast/multicol/float-multicol-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
- platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/multicol/float-multicol-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/float-multicol-expected.png.
- platform/chromium-mac-snowleopard/fast/writing-mode/block-level-images-expected.png: Added.
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/background-leakage-expected.png: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-expected.txt: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
- platform/chromium-win/fast/multicol/float-multicol-expected.png:
- platform/chromium-win/fast/multicol/float-multicol-expected.txt:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/writing-mode/block-level-images-expected.txt: Removed.
- platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed.
- 3:41 PM Changeset in webkit [109452] by
-
- 19 edits in branches/subpixellayout/Source/WebCore
Revert remaining border methods to ints for subpixel branch.
- 3:36 PM Changeset in webkit [109451] by
-
- 42 edits1 add in trunk/Source/WebCore
Decouple scrollbar painting from Scrollbar object
https://bugs.webkit.org/show_bug.cgi?id=78028
Patch by Peter Kotwicz <pkotwicz@google.com> on 2012-03-01
Reviewed by James Robinson.
Added interface ScrollbarThemeClient which Scrollbar inherits from.
This allows painting via ScrollbarTheme with a proxy to a Scrollbar
object.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::scrollbarOverlayStyle):
(WebCore):
(WebCore::Scrollbar::getTickmarks):
(WebCore::Scrollbar::isScrollableAreaActive):
(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::setFrameRect):
- platform/Scrollbar.h:
(Scrollbar):
(WebCore::Scrollbar::x):
(WebCore::Scrollbar::y):
(WebCore::Scrollbar::width):
(WebCore::Scrollbar::height):
(WebCore::Scrollbar::size):
(WebCore::Scrollbar::location):
(WebCore::Scrollbar::parent):
(WebCore::Scrollbar::root):
(WebCore::Scrollbar::frameRect):
(WebCore::Scrollbar::invalidate):
(WebCore::Scrollbar::convertFromContainingWindow):
(WebCore::Scrollbar::isCustomScrollbar):
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::currentPos):
(WebCore::Scrollbar::visibleSize):
(WebCore::Scrollbar::totalSize):
(WebCore::Scrollbar::maximum):
(WebCore::Scrollbar::controlSize):
(WebCore::Scrollbar::lineStep):
(WebCore::Scrollbar::pageStep):
(WebCore::Scrollbar::pressedPart):
(WebCore::Scrollbar::hoveredPart):
(WebCore::Scrollbar::styleChanged):
(WebCore::Scrollbar::enabled):
- platform/ScrollbarTheme.h:
(WebCore):
(WebCore::ScrollbarTheme::updateEnabledState):
(WebCore::ScrollbarTheme::paint):
(WebCore::ScrollbarTheme::hitTest):
(WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):
(WebCore::ScrollbarTheme::invalidateParts):
(WebCore::ScrollbarTheme::invalidatePart):
(WebCore::ScrollbarTheme::shouldCenterOnThumb):
(WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackPosition):
(WebCore::ScrollbarTheme::trackLength):
(WebCore::ScrollbarTheme::registerScrollbar):
(WebCore::ScrollbarTheme::unregisterScrollbar):
- platform/ScrollbarThemeClient.h: Added.
(WebCore):
(ScrollbarThemeClient):
(WebCore::ScrollbarThemeClient::~ScrollbarThemeClient):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
(WebCore::ScrollbarThemeComposite::minimumThumbLength):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
- platform/ScrollbarThemeComposite.h:
(ScrollbarThemeComposite):
(WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
(WebCore::ScrollbarThemeComposite::paintTrackBackground):
(WebCore::ScrollbarThemeComposite::paintTrackPiece):
(WebCore::ScrollbarThemeComposite::paintButton):
(WebCore::ScrollbarThemeComposite::paintThumb):
(WebCore::ScrollbarThemeComposite::paintTickmarks):
(WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::hasThumb):
(WebCore::ScrollbarThemeChromium::backButtonRect):
(WebCore::ScrollbarThemeChromium::forwardButtonRect):
(WebCore::ScrollbarThemeChromium::trackRect):
(WebCore::ScrollbarThemeChromium::paintTrackBackground):
(WebCore::ScrollbarThemeChromium::paintTickmarks):
- platform/chromium/ScrollbarThemeChromium.h:
(WebCore::ScrollbarThemeChromium::hasButtons):
(ScrollbarThemeChromium):
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumLinux.h:
(ScrollbarThemeChromiumLinux):
- platform/chromium/ScrollbarThemeChromiumMac.h:
(ScrollbarThemeChromiumMac):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintGivenTickmarks):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
(WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
(WebCore::ScrollbarThemeChromiumWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
- platform/chromium/ScrollbarThemeChromiumWin.h:
(ScrollbarThemeChromiumWin):
- platform/efl/ScrollbarThemeEfl.cpp:
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):
- platform/efl/ScrollbarThemeEfl.h:
(ScrollbarThemeEfl):
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore):
(WebCore::ScrollbarThemeGtk::registerScrollbar):
(WebCore::ScrollbarThemeGtk::unregisterScrollbar):
(WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
(WebCore::ScrollbarThemeGtk::hasThumb):
(WebCore::ScrollbarThemeGtk::backButtonRect):
(WebCore::ScrollbarThemeGtk::forwardButtonRect):
(WebCore::ScrollbarThemeGtk::trackRect):
(WebCore::ScrollbarThemeGtk::thumbRect):
(WebCore::ScrollbarThemeGtk::paint):
(WebCore::ScrollbarThemeGtk::shouldCenterOnThumb):
(WebCore::ScrollbarThemeGtk::buttonSize):
(WebCore::ScrollbarThemeGtk::minimumThumbLength):
- platform/gtk/ScrollbarThemeGtk.h:
(WebCore::ScrollbarThemeGtk::hasButtons):
(ScrollbarThemeGtk):
- platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::getWidgetForScrollbar):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
- platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
- platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
- platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::trackRect):
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
- platform/mock/ScrollbarThemeMock.h:
(WebCore::ScrollbarThemeMock::hasButtons):
(WebCore::ScrollbarThemeMock::hasThumb):
(WebCore::ScrollbarThemeMock::backButtonRect):
(WebCore::ScrollbarThemeMock::forwardButtonRect):
(ScrollbarThemeMock):
- platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::hitTest):
(WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQt::invalidatePart):
(WebCore::ScrollbarThemeQt::thumbPosition):
(WebCore::ScrollbarThemeQt::thumbLength):
(WebCore::ScrollbarThemeQt::trackPosition):
(WebCore::ScrollbarThemeQt::trackLength):
- platform/qt/ScrollbarThemeQt.h:
(ScrollbarThemeQt):
- platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::hasButtons):
(WebCore::ScrollbarThemeSafari::hasThumb):
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::ScrollbarThemeSafari::trackRect):
(WebCore::ScrollbarThemeSafari::minimumThumbLength):
(WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
- platform/win/ScrollbarThemeSafari.h:
(ScrollbarThemeSafari):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::hasThumb):
(WebCore::ScrollbarThemeWin::backButtonRect):
(WebCore::ScrollbarThemeWin::forwardButtonRect):
(WebCore::ScrollbarThemeWin::trackRect):
(WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeWin::paintTrackBackground):
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::paintGripper):
(WebCore::ScrollbarThemeWin::paintThumb):
- platform/win/ScrollbarThemeWin.h:
(WebCore::ScrollbarThemeWin::hasButtons):
(ScrollbarThemeWin):
- platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::hasThumb):
(WebCore::ScrollbarThemeWx::minimumThumbLength):
(WebCore::ScrollbarThemeWx::buttonSize):
(WebCore::ScrollbarThemeWx::splitTrack):
(WebCore::ScrollbarThemeWx::backButtonRect):
(WebCore::ScrollbarThemeWx::forwardButtonRect):
(WebCore::ScrollbarThemeWx::trackRect):
(WebCore::ScrollbarThemeWx::paint):
- platform/wx/ScrollbarThemeWx.h:
(ScrollbarThemeWx):
(WebCore::ScrollbarThemeWx::hasButtons):
- rendering/RenderScrollbar.h:
(WebCore::toRenderScrollbar):
- rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
(WebCore::RenderScrollbarTheme::hasButtons):
(WebCore::RenderScrollbarTheme::hasThumb):
(WebCore::RenderScrollbarTheme::minimumThumbLength):
(WebCore::RenderScrollbarTheme::backButtonRect):
(WebCore::RenderScrollbarTheme::forwardButtonRect):
(WebCore::RenderScrollbarTheme::trackRect):
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
(WebCore::RenderScrollbarTheme::paintScrollbarBackground):
(WebCore::RenderScrollbarTheme::paintTrackBackground):
(WebCore::RenderScrollbarTheme::paintTrackPiece):
(WebCore::RenderScrollbarTheme::paintButton):
(WebCore::RenderScrollbarTheme::paintThumb):
- rendering/RenderScrollbarTheme.h:
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):
(RenderScrollbarTheme):
- 3:33 PM Changeset in webkit [109450] by
-
- 3 edits in trunk/Source/WebCore
Implement CSSPropertyImageRendering in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79855
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:31 PM Changeset in webkit [109449] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109245
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9570047
- 3:29 PM Changeset in webkit [109448] by
-
- 5 edits2 copies in branches/chromium/963
Merge 108548
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9562039
- 3:28 PM Changeset in webkit [109447] by
-
- 2 edits in trunk/LayoutTests
chromium: start running virtual gpu tests
https://bugs.webkit.org/show_bug.cgi?id=80050
Unreviewed, expectations change.
This patch un-SKIPs the platform/chromium/virtual/gpu tests
and copies their expectations from the GPU and generic
expectations for fast/canvas and canvas/philip. I
will re-sort the expectations in subsequent patches so
that the virtual expectations are next to the action ones,
for easier maintenance.
- platform/chromium/test_expectations.txt:
- 3:23 PM Changeset in webkit [109446] by
-
- 2 edits in trunk/LayoutTests
Mark fast/workers/stress-js-execution.html as flakily crashy on cr-win.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:21 PM Changeset in webkit [109445] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS to 124511
Unreviewed, DEPS change.
- DEPS:
- 3:20 PM Changeset in webkit [109444] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109369
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9565031
- 3:17 PM Changeset in webkit [109443] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109369
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9570045
- 3:17 PM Changeset in webkit [109442] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Partial texture updates not happening with accelerated painting path
https://bugs.webkit.org/show_bug.cgi?id=80040
Reviewed by James Robinson.
The order of y-flip and clip-rect was opposite of what it should be.
The clip rect was not properly transformed to account for y-flip and hence clipping everything.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- 3:16 PM Changeset in webkit [109441] by
-
- 2 edits in trunk/LayoutTests
Remove outdated (mostly mac) test suppressions.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:12 PM Changeset in webkit [109440] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109142
BUG=113801
Review URL: https://chromiumcodereview.appspot.com/9570043
- 3:10 PM Changeset in webkit [109439] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109142
BUG=113801
Review URL: https://chromiumcodereview.appspot.com/9566037
- 2:58 PM Changeset in webkit [109438] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Cleaning up some InlineFlowBox cruft and using static casts instead of explicit wrapping.
- 2:57 PM Changeset in webkit [109437] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 109140
BUG=115028
Review URL: https://chromiumcodereview.appspot.com/9570040
- 2:56 PM Changeset in webkit [109436] by
-
- 1 edit3 copies in branches/chromium/963
Merge 109140
BUG=115028
Review URL: https://chromiumcodereview.appspot.com/9570038
- 2:50 PM Changeset in webkit [109435] by
-
- 2 edits in trunk/Source/WebCore
FileReader read speed is way too low
https://bugs.webkit.org/show_bug.cgi?id=77272
Reviewed by Oliver Hunt.
This brings performance to reasonable range, but certainly doesn't exhaust improvement opportunities.
- platform/network/BlobResourceHandle.cpp: Use a more appropriate block size. Performing cross-thread messaging for every 1024 bytes is slow.
- 2:48 PM Changeset in webkit [109434] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109124
BUG=116027
Review URL: https://chromiumcodereview.appspot.com/9578001
- 2:48 PM Changeset in webkit [109433] by
-
- 2 edits in trunk/LayoutTests
Mark svg/W3C-SVG-1.1/animate-elem-32-t.svg as debug/crash after r109342.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [109432] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109124
BUG=116027
Review URL: https://chromiumcodereview.appspot.com/9573003
- 2:42 PM Changeset in webkit [109431] by
-
- 2 edits in trunk/Source/WebCore
ScrollView::setFrameRect() calls contentsResized() even when the frame size is unchanged
https://bugs.webkit.org/show_bug.cgi?id=80047
Reviewed by Anders Carlsson.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect): Added a check that the new frame size differs from the
old one before calling contentsResized().
- 2:41 PM Changeset in webkit [109430] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.
Add local static Qualified name for autocorrect attribute.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
- 2:41 PM Changeset in webkit [109429] by
-
- 5 edits in trunk/Tools
nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
https://bugs.webkit.org/show_bug.cgi?id=80048
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_isfile):
(Port.test_isdir):
(Port):
(Port.test_exists):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_test_exists):
(PortTest):
(PortTest.test_test_isfile):
(PortTest.test_test_isdir):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_virtual):
- 2:41 PM Changeset in webkit [109428] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109011
BUG=114144
Review URL: https://chromiumcodereview.appspot.com/9565029
- 2:39 PM Changeset in webkit [109427] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109011
BUG=114144
Review URL: https://chromiumcodereview.appspot.com/9566033
- 2:30 PM Changeset in webkit [109426] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108875
BUG=113800
Review URL: https://chromiumcodereview.appspot.com/9569037
- 2:28 PM Changeset in webkit [109425] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108875
BUG=113800
Review URL: https://chromiumcodereview.appspot.com/9569036
- 2:24 PM Changeset in webkit [109424] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=79714
Patch by James Robinson <jamesr@chromium.org> on 2012-03-01
Reviewed by Adrienne Walker.
When the page scale changes on a composited layer we need to invalidate all of the contents on the layer in
order to repaint them at the new scale. The sequence of calls we get make this a bit tricky, since we first
receive a page scale changed notification and then receive the new layer bounds. The solution is to defer the
invalidation until we have the new layer bounds, which landed in r99774.
This moves that logic from LayerChromium into GraphicsLayerChromium since IMO this is pretty particular to the
way WebCore is passing us invalidations and not something fundamental to the compositor.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- 2:14 PM Changeset in webkit [109423] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108847
BUG=115681
Review URL: https://chromiumcodereview.appspot.com/9569034
- 2:13 PM Changeset in webkit [109422] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108847
BUG=115681
Review URL: https://chromiumcodereview.appspot.com/9567024
- 2:07 PM Changeset in webkit [109421] by
-
- 1 edit7 copies in branches/chromium/1025
Merge 108543
BUG=113497
Review URL: https://chromiumcodereview.appspot.com/9564028
- 2:07 PM Changeset in webkit [109420] by
-
- 2 edits in trunk/LayoutTests
Remove lots of bogus flaky test suppressions, mark some others
as always failing and some others for rebaselining.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 2:04 PM Changeset in webkit [109419] by
-
- 1 edit7 copies in branches/chromium/963
Merge 108543
BUG=113497
Review URL: https://chromiumcodereview.appspot.com/9562030
- 1:55 PM Changeset in webkit [109418] by
-
- 6 edits in trunk
Perf-o-matic: generate dashboard images for 30, 90, and 365 days
https://bugs.webkit.org/show_bug.cgi?id=80016
Reviewed by Eric Seidel.
Add the ability to generate graphs for 30, 90, and 365 day graphs but only occasionally
according to the heuristics in DashboardImage.needs_update.
Also fix a bug in Runs.chart_params that y-axis grid was set to an incorrect value.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsChartHandler.post):
- Websites/webkit-perf.appspot.com/json_generators.py:
(Runs.chart_params):
- Websites/webkit-perf.appspot.com/json_generators_unittest.py:
(RunsTest.test_chart_params_with_value):
- Websites/webkit-perf.appspot.com/models.py:
(DashboardImage):
(DashboardImage.needs_update):
- Websites/webkit-perf.appspot.com/models_unittest.py:
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_model_from_numeric_id.execute):
(HelperTests):
(HelperTests.test_model_from_numeric_id):
(BranchTests.test_create_if_possible):
(PlatformTests.test_create_if_possible):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(_create_some_builder):
(_create_build):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestModelTests.test_merge):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):
(ReportLogTests._create_log_with_payload):
(ReportLogTests.test_builder):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):
(DashboardImageTests):
(DashboardImageTests.test_needs_update):
- 1:53 PM Changeset in webkit [109417] by
-
- 3 edits2 adds in trunk
:empty still applies to elements made non-empty via page dynamics.
https://bugs.webkit.org/show_bug.cgi?id=79734
Check for :empty style change should be made even if the RenderStyle for the element is NULL
as changes to the element's children can trigger a change in :empty state of the parent element.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-01
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/selectors/empty-element-made-non-empty.html
- dom/Element.cpp:
(WebCore::checkForSiblingStyleChanges):
LayoutTests:
- fast/selectors/empty-element-made-non-empty-expected.txt: Added.
- fast/selectors/empty-element-made-non-empty.html: Added.
- 1:52 PM Changeset in webkit [109416] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108194
BUG=114924
Review URL: https://chromiumcodereview.appspot.com/9562027
- 1:51 PM Changeset in webkit [109415] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Make the interaction with the Flickable work on the N9
https://bugs.webkit.org/show_bug.cgi?id=80029
Reviewed by Simon Hausmann.
Because the WebView item accepts all touch events it receives and sends
them to the web process before propagating them to the gesture recognizers,
which is correct behaviour, we can not rely on the touch->mouse conversion
of Qt5 when controlling Flickable. Hence we need to convert the received
touch events to mouse events in the QtFlickProvider.
- UIProcess/qt/QtFlickProvider.cpp:
(QtFlickProvider::handleTouchFlickEvent):
Do the touch to mouse event conversion for the Flickable.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
A touch begin event should cancel the previous pan gesture
and stop the ongoing flick animation.
- 1:50 PM Changeset in webkit [109414] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108194
BUG=114924
Review URL: https://chromiumcodereview.appspot.com/9568037
- 1:46 PM Changeset in webkit [109413] by
-
- 2 edits6 copies in branches/chromium/1025
Merge 108606
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9568036
- 1:43 PM Changeset in webkit [109412] by
-
- 4 edits in tags/Safari-536.1/Source
Versioning.
- 1:42 PM Changeset in webkit [109411] by
-
- 14 edits in trunk/Source
[chromium] Move context lost control code from CCSingleThreadProxy to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=79964
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::didLoseContext):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseContext):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore):
(WebCore::CCSingleThreadProxy::loseContext):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore):
(WebCore::CCThreadProxy::loseContext):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::loseCompositorContext):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createContext):
(WTF::MockLayerTreeHostClient::didRecreateContext):
- tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::createContext):
(WebCore::FakeCCLayerTreeHostClient::didRecreateContext):
- 1:39 PM Changeset in webkit [109410] by
-
- 1 copy in tags/Safari-536.1
New Tag.
- 1:35 PM Changeset in webkit [109409] by
-
- 4 edits in trunk/Source
Versioning.
- 1:33 PM Changeset in webkit [109408] by
-
- 4 edits12 copies in branches/chromium/1025
Merge 108127
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9562026
- 1:31 PM Changeset in webkit [109407] by
-
- 2 edits6 copies in branches/chromium/963
Merge 108606
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9566030
- 1:27 PM Changeset in webkit [109406] by
-
- 4 edits in trunk/Source/WebCore
Prevent layout root to remain set on renderers getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=79953
Reviewed by Eric Seidel.
Implement Julien Chaffraix's idea.
- page/FrameView.h:
(WebCore::FrameView::clearLayoutRoot): helper to clear layout root.
- rendering/RenderObject.cpp:
(WebCore::clearLayoutRootIfNeeded): if we know we are going
away and we are the view's layout root, then we need to reset the layout
root to prevent being used.
(WebCore):
(WebCore::RenderObject::willBeDestroyed): call clearLayoutRootIfNeeded at end.
- 1:26 PM Changeset in webkit [109405] by
-
- 3 edits in trunk/Source/WebKit2
Assertion failure in pageContainsAnyHorizontalScrollbars() (scrollableArea->isOnActivePage()) when leaving pages with embedded PDFs
https://bugs.webkit.org/show_bug.cgi?id=80044
<rdar://problem/10919940>
Reviewed by Brady Eidson.
Remove the code that would add and remove wheel event handlers since that's not what we want to track.
Instead, dynamically add and remove the view as its scrollbars come and go.
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::updateScrollbars):
(WebKit::BuiltInPDFView::initialize):
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):
- 1:16 PM Changeset in webkit [109404] by
-
- 4 edits12 copies in branches/chromium/963
Merge 108127
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9568032
- 12:56 PM Changeset in webkit [109403] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 108109
BUG=113707
Review URL: https://chromiumcodereview.appspot.com/9562024
- 12:55 PM Changeset in webkit [109402] by
-
- 12 edits in trunk
[DRT] Remove all PlainTextController usages in existing tests by adding internal API
https://bugs.webkit.org/show_bug.cgi?id=78570
Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-01
Reviewed by Hajime Morita.
This patch will remove all PlainTextController usages
in existing DRT tests by adding internal API to WebCore/testing/Internals
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Changed editing/text-iterator/script-tests/basic-iteration.js to use internals.rangeAsText
- testing/Internals.cpp:
(WebCore::Internals::rangeAsText):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- editing/text-iterator/basic-iteration-expected.txt:
- editing/text-iterator/script-tests/basic-iteration.js:
- 12:54 PM Changeset in webkit [109401] by
-
- 1 edit3 copies in branches/chromium/963
Merge 108109
BUG=113707
Review URL: https://chromiumcodereview.appspot.com/9565026
- 12:50 PM Changeset in webkit [109400] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107987
BUG=113799
Review URL: https://chromiumcodereview.appspot.com/9562023
- 12:49 PM Changeset in webkit [109399] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107987
BUG=113799
Review URL: https://chromiumcodereview.appspot.com/9569026
- 12:45 PM Changeset in webkit [109398] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107627
BUG=113690
Review URL: https://chromiumcodereview.appspot.com/9570026
- 12:44 PM WebKitGTK/1.8.x edited by
- Added 109396 as proposed merge (diff)
- 12:43 PM Changeset in webkit [109397] by
-
- 2 edits in trunk/LayoutTests
Rebaseline to remove quotes around font name after r109382.
Unreviewed gardening.
- editing/inserting/5994480-2-expected.txt:
- 12:37 PM Changeset in webkit [109396] by
-
- 2 edits in trunk/Tools
[GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
https://bugs.webkit.org/show_bug.cgi?id=80031
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.
Only build the libTestRunnerInjectedBundle.la convenience library when
ENABLE_WEBKIT2 is defined.
- WebKitTestRunner/GNUmakefile.am:
- 12:36 PM Changeset in webkit [109395] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107627
BUG=113690
Review URL: https://chromiumcodereview.appspot.com/9566026
- 12:35 PM Changeset in webkit [109394] by
-
- 2 edits in trunk/LayoutTests
Remove expectations for no-longer-flaky tests on Snow Leopard.
https://bugs.webkit.org/show_bug.cgi?id=54322
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 12:32 PM Changeset in webkit [109393] by
-
- 2 edits in trunk/Tools
Unreviewed, second attempt to fix GTK NRWT after r109242.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- 12:29 PM Changeset in webkit [109392] by
-
- 5 edits in trunk/Source/WebCore
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
https://bugs.webkit.org/show_bug.cgi?id=80013
Reviewed by Kentaro Hara.
Before this patch, DOMWindow still knew about IDB because of the
database factory. This patch moves the factory to
DOMWindowIndexedDatabase.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::from):
(WebCore):
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
- page/DOMWindow.h:
(DOMWindow):
- 12:29 PM Changeset in webkit [109391] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 109345
BUG=116093
Review URL: https://chromiumcodereview.appspot.com/9562022
- 12:28 PM Changeset in webkit [109390] by
-
- 1 edit3 copies in branches/chromium/963
Merge 109345
BUG=116093
Review URL: https://chromiumcodereview.appspot.com/9568029
- 12:20 PM Changeset in webkit [109389] by
-
- 5 edits in branches/subpixellayout/Source/WebCore/rendering
Cleaning up RenderBox. Removing unneeded integer flipForWritingMode functions.
- 12:15 PM Changeset in webkit [109388] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108372
BUG=114219
Review URL: https://chromiumcodereview.appspot.com/9569024
- 12:13 PM Changeset in webkit [109387] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108372
BUG=114219
Review URL: https://chromiumcodereview.appspot.com/9567020
- 12:04 PM Changeset in webkit [109386] by
-
- 3 edits in trunk/Source/WebCore
Glitchy scrolling on pages where the scroll layer needs to be updated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=80038
<rdar://problem/10933831>
Reviewed by Simon Fraser.
When we need to update the scroll layer position on the main thread, we need to cache the
scroll position we sent to the main thread and assume that that's the correct scroll position.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollPosition):
- 12:01 PM Changeset in webkit [109385] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108417
BUG=114054
Review URL: https://chromiumcodereview.appspot.com/9566023
- 12:00 PM Changeset in webkit [109384] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108417
BUG=114054
Review URL: https://chromiumcodereview.appspot.com/9568027
- 11:58 AM Changeset in webkit [109383] by
-
- 17 edits in trunk
Unreviewed, rolling out r109367.
http://trac.webkit.org/changeset/109367
https://bugs.webkit.org/show_bug.cgi?id=75568
Some tests started to fail in a non obvious way.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
- rendering/RenderBox.h:
(RenderBox):
(WebCore):
- rendering/RenderBoxModelObject.cpp:
(WebCore):
(WebCore::RenderBoxModelObject::styleDidChange):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
(RenderBoxModelObject):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
LayoutTests:
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
- 11:47 AM Changeset in webkit [109382] by
-
- 3 edits2 adds in trunk
REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=79448
Reviewed by Ryosuke Niwa.
Source/WebCore:
Don't produce single quotes around face attribute of font elements.
Test: editing/style/font-face-unquote.html
- editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles): Remove single quotes from m_applyFontFace.
LayoutTests:
Add a test that makes sure WebKit doesn't produce single quotes around
face attribute of font element.
- editing/style/font-face-unquote-expected.txt: Added.
- editing/style/font-face-unquote.html: Added.
- 11:40 AM Changeset in webkit [109381] by
-
- 2 edits2 copies in branches/chromium/1025
Merge 107613
BUG=113258
Review URL: https://chromiumcodereview.appspot.com/9562018
- 11:38 AM Changeset in webkit [109380] by
-
- 2 edits2 copies in branches/chromium/963
Merge 107613
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9568025
- 11:36 AM Changeset in webkit [109379] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Kevin Decker.
Part of https://bugs.webkit.org/show_bug.cgi?id=79705
Here's some of that tweaking promised in the comment. Adjusting
gMaximumUnpaintedAreaRatio down a bit.
- page/Page.cpp:
(WebCore):
- 11:33 AM Changeset in webkit [109378] by
-
- 13 edits in trunk/Source/WebCore
Add roundToInt method for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=79283
Reviewed by Eric Seidel.
Adding a roundToInt method that rounds a LayoutUnit to the nearest integer. This
only has an effect once we switch to sub-pixel positioning. Points and offsets
are rounded for painting and hit testing.
No new tests. No change in behavior.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::computeLineGridPaginationOrigin):
- rendering/LayoutTypes.h:
(WebCore::roundToInt): Stub until we switch to sub-pixel LayoutUnits.
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageLogicalTopForOffset):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Correcting to use the
pixel snapped methods on FloatingObjects and removing the fixme.
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalWidthForFloat): Ditto.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Using
pixelSnappedLogicalLeft/RightOffsetForLine convenience methods for line layout. When
we switch to sub-pixel positioning, we still pixel snap blocks before painting them,
but text is rendered using floats. We need to ensure the text is laid out using the
actual pixel width of the containing block to avoid bleeding out of the block.
- rendering/RenderBoxModelObject.h: Moving the fixme to pixelSnappedWidth/Height and
adding the necessary rounding for Left/Top.
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight): Rounding the height for scrollHeight. Scrolling
always uses rounded values.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToParentTransform): Similar to the line box tree, since
SVG renders using floats, we need to start with pixel snapped values from the render
tree or we'll end up with the contents not properly aligned to the rest of the page.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):
- 11:26 AM Changeset in webkit [109377] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107729
BUG=113562
Review URL: https://chromiumcodereview.appspot.com/9570024
- 11:24 AM Changeset in webkit [109376] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107729
BUG=113562
Review URL: https://chromiumcodereview.appspot.com/9568024
- 11:22 AM Changeset in webkit [109375] by
-
- 2 edits in trunk/LayoutTests
Mark use-same-database-in-page-and-workers.html as a TEXT failure.
Requested by dslomov on #webkit.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 11:18 AM Changeset in webkit [109374] by
-
- 2 edits in branches/chromium/1025
Merge 108311
BUG=114911
Review URL: https://chromiumcodereview.appspot.com/9566019
- 11:14 AM Changeset in webkit [109373] by
-
- 2 edits in branches/chromium/963
Merge 108311
BUG=114911
Review URL: https://chromiumcodereview.appspot.com/9568022
- 11:12 AM Changeset in webkit [109372] by
-
- 8 edits2 adds in trunk
2012-03-01 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596
Reviewed by Vsevolod Vlasov.
Test: inspector/console/console-big-array.html
- inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray): (WebInspector.ConsoleMessageImpl.prototype._printArray):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): (WebInspector.ArrayGroupingTreeElement): (WebInspector.ArrayGroupingTreeElement.populateAsArray): (WebInspector.ArrayGroupingTreeElement._populate.appendElement): (WebInspector.ArrayGroupingTreeElement._populate): (WebInspector.ArrayGroupingTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.release): (WebInspector.RemoteObject.prototype.arrayLength): (WebInspector.LocalJSONObject.prototype.isError): (WebInspector.LocalJSONObject.prototype.arrayLength):
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype._mouseDown):
- inspector/front-end/inspector.css: (.console-formatted-object, .console-formatted-node, .console-formatted-array): (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-array .section):
2012-03-01 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596
Reviewed by Vsevolod Vlasov.
- inspector/console/console-big-array-expected.txt: Added.
- inspector/console/console-big-array.html: Added.
- 11:05 AM Changeset in webkit [109371] by
-
- 1 edit2 deletes in branches/chromium/963
Revert 109368 - Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9564016
TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/9565017
- 11:01 AM Changeset in webkit [109370] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r109336.
http://trac.webkit.org/changeset/109336
https://bugs.webkit.org/show_bug.cgi?id=80013
It's causing some crashes
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
(WebCore::DOMWindow::setIDBFactory):
- page/DOMWindow.h:
(DOMWindow):
(WebCore::DOMWindow::idbFactory):
- 10:57 AM Changeset in webkit [109369] by
-
- 3 edits2 adds in trunk
Move m_frame protector from FrameLoader::changeLocation to FrameLoader::urlSelected
https://bugs.webkit.org/show_bug.cgi?id=79882
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/frames/url-selected-crash.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
LayoutTests:
- fast/frames/url-selected-crash-expected.txt: Added.
- fast/frames/url-selected-crash.html: Added.
- 10:56 AM Changeset in webkit [109368] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9564016
- 10:46 AM Changeset in webkit [109367] by
-
- 17 edits in trunk
Lazily allocate overflow: hidden layers if we have overflowing content
https://bugs.webkit.org/show_bug.cgi?id=75568
Reviewed by David Hyatt.
Source/WebCore:
Change covered by the existing tests and the tons of rebaselines.
This change makes us lazily allocate our RenderLayer for overflow: hidden layers only.
Apart from saving some memory, it will also speed up the rendering as we don't need to
go through the layer's machinery when painting and hit testing.
On http://dglazkov.github.com/performance-tests/biggrid.html benchmark, this puts the
overflow: hidden case in par with the overflow: visible case when scrolling that is a
very-smooth scrolling vs a jerky one currently (mostly due to the painting speedup).
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
Changed this method to update our size cache if needed.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
Added layer() check to the previous call sites.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::ensureLayer):
Added this function to create and add a new layer.
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore):
(WebCore::RenderBoxModelObject::styleDidChange):
Patched those method to handle updating / removing
cached size entries.
(WebCore::cachedSizeForOverflowClipMap):
(WebCore::RenderBoxModelObject::cachedSizeForOverflowClip):
(WebCore::RenderBoxModelObject::updateCachedSizeForOverflowClip):
(WebCore::RenderBoxModelObject::clearCachedSizeForOverflowClip):
This logic stores the size information for later repainting.
It is in practice replicating what RenderLayer is doing.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
Updated to call requiresLayerForOverflowClip.
(WebCore::RenderBoxModelObject::requiresLayerForOverflowClip):
Added this method to check if we can lazily allocate the layer.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Removed some checks as they are part of updateScrollInfoAfterLayout.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scrolledContentOffset):
Added a layer() check.
- rendering/RenderTableRow.h:
(RenderTableRow):
Added a comment about why we need a layout for table rows.
LayoutTests:
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png:
This test really doesn't seem to test much on all platforms. The new expected result is as
good as the original from a correctness perspective. It just means we now do repaint the whole
iframe when scrolling.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
Disable gazillions tests that need a small rebaseline after losing some layers. The expectations are
updated to match each platform as best as I could but expect some breakage...
- 10:45 AM Changeset in webkit [109366] by
-
- 4 edits2 copies in branches/chromium/1025
Merge 108009
BUG=112542
Review URL: https://chromiumcodereview.appspot.com/9567016
- 10:43 AM Changeset in webkit [109365] by
-
- 4 edits2 copies in branches/chromium/963
Merge 108009
BUG=112542
Review URL: https://chromiumcodereview.appspot.com/9567015
- 10:26 AM Changeset in webkit [109364] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107749
BUG=111748
Review URL: https://chromiumcodereview.appspot.com/9568019
- 10:24 AM Changeset in webkit [109363] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107749
BUG=111748
Review URL: https://chromiumcodereview.appspot.com/9564014
- 10:19 AM Changeset in webkit [109362] by
-
- 10 edits4 adds in trunk
Protect functions using two container node function, each of which can fire mutation events.
https://bugs.webkit.org/show_bug.cgi?id=78397
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/document-set-title-mutation-crash.html
fast/dom/option-text-mutation-crash.html
- dom/Node.cpp:
(WebCore::Node::setTextContent):
- dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- editing/markup.cpp:
(WebCore::trimFragment):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::insertRow):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
LayoutTests:
- fast/dom/document-set-title-mutation-crash-expected.txt: Added.
- fast/dom/document-set-title-mutation-crash.html: Added.
- fast/dom/option-text-mutation-crash-expected.txt: Added.
- fast/dom/option-text-mutation-crash.html: Added.
- 10:07 AM Changeset in webkit [109361] by
-
- 5 edits2 copies in branches/chromium/1025
Merge 108134
BUG=108037
Review URL: https://chromiumcodereview.appspot.com/9569016
- 10:06 AM Changeset in webkit [109360] by
-
- 6 edits in trunk/Source/WebCore
Some trivial file stream cleanup
https://bugs.webkit.org/show_bug.cgi?id=79955
Reviewed by Sam Weinig.
No change in functionality.
- fileapi/FileStreamProxy.cpp: Tweaked comment, and added copyright for earlier changes.
- fileapi/FileStreamProxy.h: Added a FIXME telling that this should be in platform.
- platform/AsyncFileStream.h: Tweaked includes and added a FIXME about this to stop being a subclass.
- platform/FileStreamClient.h: Removed obvious comments, and added ones explaing in-band error signals.
- platform/network/BlobResourceHandle.cpp: Removed an include outside of platform, and an unused constant.
- 10:05 AM Changeset in webkit [109359] by
-
- 9 edits2 adds in trunk
Appending ShadowRoot into an element should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=79620
Reviewed by Dimitri Glazkov.
Source/WebCore:
We should treat ShadowRoot as a document fragment.
Test: fast/dom/shadow/shadow-root-append.html
- dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
LayoutTests:
- fast/dom/shadow/shadow-root-append-expected.txt: Added.
- fast/dom/shadow/shadow-root-append.html: Added.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 10:05 AM Changeset in webkit [109358] by
-
- 5 edits2 copies in branches/chromium/963
Merge 108134
BUG=108037
Review URL: https://chromiumcodereview.appspot.com/9568017
- 9:53 AM Changeset in webkit [109357] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108415
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9570019
- 9:52 AM Changeset in webkit [109356] by
-
- 2 edits4 copies in branches/chromium/1025
Merge 108152
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9567012
- 9:50 AM Changeset in webkit [109355] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108415
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9567011
- 9:49 AM Changeset in webkit [109354] by
-
- 2 edits4 copies in branches/chromium/963
Merge 108152
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9565015
- 9:42 AM Changeset in webkit [109353] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107733
BUG=104266
Review URL: https://chromiumcodereview.appspot.com/9565014
- 9:41 AM Changeset in webkit [109352] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107733
BUG=104266
Review URL: https://chromiumcodereview.appspot.com/9565013
- 9:30 AM Changeset in webkit [109351] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: use live location to update console message bubbles.
https://bugs.webkit.org/show_bug.cgi?id=80023
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript.updateLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptForURLAndLocation):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
- 9:15 AM Changeset in webkit [109350] by
-
- 2 edits in trunk/Source/WebKit/chromium
REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
https://bugs.webkit.org/show_bug.cgi?id=77452
Reviewed by Hajime Morita.
WebViewImpl::enableAutoResizeMode loops infinitely.
This patch fixes the following line:
enableAutoResizeMode(enable, minSize, maxSize);
to
enableAutoResizeMode(minSize, maxSize);
to avoid the infinite loop. I guess this is the change originally intended.
Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode):
- 8:34 AM Changeset in webkit [109349] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information
https://bugs.webkit.org/show_bug.cgi?id=80022
Reviewed by Pavel Feldman.
Added tooltips with meta information for IndexedDB databases, object stores and indexes.
Added keyPath: prefix to key columns in IndexedDB data grid.
- English.lproj/localizedStrings.js:
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._keyPathHeader):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype._updateTooltip):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
(WebInspector.IDBIndexTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement.prototype._updateTooltip):
- 8:16 AM Changeset in webkit [109348] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: hide color picker on Esc and Enter.
https://bugs.webkit.org/show_bug.cgi?id=79915
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):
(WebInspector.Spectrum.prototype._onKeyDown):
- 8:13 AM Changeset in webkit [109347] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fixed incorrect size pixmap creation for a new transparency layer.
https://bugs.webkit.org/show_bug.cgi?id=79658
If QPainter does not have clipping, beginPlatformTransparencyLayer can create
wrong size pixmap, so it causes incorrect rendering.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-03-01
Reviewed by Simon Hausmann.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
- 7:18 AM Changeset in webkit [109346] by
-
- 3 edits1 delete in trunk/Source/WebCore
[Qt] Remove dead style option code.
https://bugs.webkit.org/show_bug.cgi?id=80017
Reviewed by Kenneth Rohde Christiansen.
QtStyleOptionWebComboBox provides functionality (bool multiple()) that
is not called from anywhere (and the base class does not have it as a
virtual function).
- Target.pri:
- platform/qt/QtStyleOptionWebComboBox.h: Removed.
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::paintMenuListButton):
- 7:04 AM Changeset in webkit [109345] by
-
- 3 edits3 adds in trunk
Crash in WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget
https://bugs.webkit.org/show_bug.cgi?id=79831
Patch by Stephen Chenney <schenney@chromium.org> on 2012-03-01
Reviewed by Eric Seidel.
Out-of-order operations in the SVGSMILElement::removedFromDocument
method caused its target to be removed and then re-added due to a
later call. This led to the target being set on the animation while
the target element itself was unaware. At deletion time, this caused a
crash (or assert in debug builds). Thanks to Abhishek Arya for help
with the layout test.
Source/WebCore:
Test: svg/animations/smil-element-target-crash-main.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::removedFromDocument):
LayoutTests:
- svg/animations/resources/smil-element-target-crash.svg: Added.
- svg/animations/smil-element-target-crash-main-expected.txt: Added.
- svg/animations/smil-element-target-crash-main.html: Added.
- 6:46 AM Changeset in webkit [109344] by
-
- 2 edits in trunk/LayoutTests
2012-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline another SVG test on SnowLeopard, now new-run-webkit-tests --tolerance 0 -p svg also passes w/o failures on SL.
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- 6:15 AM Changeset in webkit [109343] by
-
- 5 edits in trunk
Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Tests:
heap-shapshot.html
heap-shapshot-loader.html
- inspector/front-end/HeapSnapshot.js:
(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
- 6:00 AM Changeset in webkit [109342] by
-
- 22 edits4 adds in trunk
Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790
Reviewed by Zoltan Herczeg.
Source/WebCore:
Next step towards enabling animVal support for XML attribute animations.
When SVG CSS properties are animated using SMIL, we currently mutate
the target elements style, and have to keep a baseValue around as String
to be able to recover from the DOM mutations at the end, if fill!="freeze".
The approach required by SMIL is to keep around an override style declaration
set and apply it right after the inline style declarations. Implement that
finally, to avoid mutating styles directly.
Test: svg/animations/attributeTypes.html
- css/CSSStyleSelector.cpp: Model "SMIL animation style" applying just like "inline style" declarations.
(WebCore::CSSStyleSelector::addElementStyleProperties): Refactored common code from matchAllRules().
(WebCore::CSSStyleSelector::matchAllRules): Apply "SMIL animation style" after "inline style" declarations, as specified in SMIL2.
- css/CSSStyleSelector.h: Add new addElementStyleProperties() helper.
- svg/SVGAnimateElement.cpp: Keep track of animation state, if it's about to end, clear "SMIL animation style" upon next applyResultToTarget() call.
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::applyResultsToTarget): Reset the CSS property we're animating int the "SMIL animation style", after animation ends.
(Instead of resetting target->style() properties to the old baseValue, as we used to do).
(WebCore::SVGAnimateElement::endedActiveInterval): Set m_aboutToStopAnimation to true, so next call to applyResultsToTarget() knows the animation ends.
- svg/SVGAnimateElement.h: Store bool m_aboutToSTopAnimation;
- svg/SVGAnimationElement.cpp:
(WebCore::setTargetAttributeAnimatedCSSValue):
(WebCore::setTargetAttributeAnimatedXMLValue):
Refactored both of these methods from setTargetAttributeAnimatedValue().
Changed the CSS part, to apply property changes to the "SMIL animation style" instead of the regular StylePropertySet.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Refactored code, use shouldApplyAnimation() to determine whether this animation should run.
(WebCore::SVGAnimationElement::resetAnimationState): New helper calling setTargetAttributeAnimatedValue with a null-string for CSS attributes, when the animation ends.
This is used to detect that the CSS property should be removed from the "SMIL animation style".
(WebCore::SVGAnimationElement::shouldApplyAnimation): Refactored from existing code, and make it more obvious how attributeType influences the animation, all according to SVG 1.1/SMIL2.
- svg/SVGAnimationElement.h:
- svg/SVGElement.cpp: Manage the "SMIL animation style", in SVGElementRareData, if needed. Only gets created if SMIL animations on CSS properties run.
(WebCore::SVGElement::~SVGElement): Destroy SMIL animation style, upon destruction.
(WebCore::SVGElement::animatedSMILStyleProperties): Returns the StylePropertySet for the "SMIL animation style", if it's available.
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties): Enforces creating the StylePropertySet for the "SMIL animation style".
- svg/SVGElement.h: Expose new methods.
- svg/SVGElementRareData.h: Stores the "SMIL animation style", actual managment is done by SVGElement, if needed.
(WebCore::SVGElementRareData::animatedSMILStyleProperties): Retrieve it.
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties): Create it.
(WebCore::SVGElementRareData::destroyAnimatedSMILStyleProperties): Destroy it.
- svg/animation/SVGSMILElement.h: Make endedActiveInterval() virtual again, its needed by SVGAnimateElement now.
LayoutTests:
SVG CSS property animations aren't leaked into the DOM anymore, update the tests.
- svg/animations/animate-color-transparent-expected.txt:
- svg/animations/animate-currentColor-expected.txt:
- svg/animations/animate-dynamic-update-attributeName-expected.txt:
- svg/animations/animate-inherit-css-property-expected.txt:
- svg/animations/attributeTypes-expected.txt: Added.
- svg/animations/attributeTypes.html: Added.
- svg/animations/resources/attributeTypes.svg: Added.
- svg/animations/script-tests/animate-color-transparent.js:
(expectTransparent):
(expectOtherColor):
- svg/animations/script-tests/animate-currentColor.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(sample1):
(sample3):
- svg/animations/script-tests/animate-inherit-css-property.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/attributeTypes.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:
(sample1):
(sample2):
(sample3):
- svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
- 5:58 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:56 AM Changeset in webkit [109341] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109230
- 5:44 AM Changeset in webkit [109340] by
-
- 16 edits in trunk
Unreviewed, rolling out r109255.
http://trac.webkit.org/changeset/109255
https://bugs.webkit.org/show_bug.cgi?id=79932
Breaks rounded rects with dashed strokes in SVG
Source/WebCore:
- WebCore.exp.in:
- platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
- platform/graphics/Path.h:
(Path):
- platform/graphics/cg/PathCG.cpp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:03 AM Changeset in webkit [109339] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109229
- 4:51 AM Changeset in webkit [109338] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [GTK] [libsoup] SoupSession should use system CA
https://bugs.webkit.org/show_bug.cgi?id=79657
Reviewed by Martin Robinson.
SoupSession sould use system CA list to validate SSL
certificates. Do not use strict certificate validation though as
we want clients to decide whether or not accept/decline invalid
certificates (API to be added later).
No new tests required as current behaviour does not change at all
as we continue to accept invalid certificates by default.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 4:40 AM Changeset in webkit [109337] by
-
- 2 edits in trunk/Tools
Unreviewed, GTK NRWT build fix attempt after r109242.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- 4:39 AM Changeset in webkit [109336] by
-
- 5 edits in trunk/Source/WebCore
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
https://bugs.webkit.org/show_bug.cgi?id=80013
Reviewed by Kentaro Hara.
Before this patch, DOMWindow still knew about IDB because of the
database factory. This patch moves the factory to
DOMWindowIndexedDatabase.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::from):
(WebCore):
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
- page/DOMWindow.h:
(DOMWindow):
- 4:37 AM Changeset in webkit [109335] by
-
- 2 edits in trunk/Tools
REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
https://bugs.webkit.org/show_bug.cgi?id=80008
Reviewed by Adam Barth.
In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
to "preprocess-idls.pl". This patch renames it.
Test: Confirm that run-bindings-tests runs.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
- 4:28 AM Changeset in webkit [109334] by
-
- 7 edits in trunk/LayoutTests
2012-03-01 Florin Malita <fmalita@google.com>
Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490
Reviewed by Nikolas Zimmermann.
Update tests to avoid the use of window.resize{To,By}.
- fast/repaint/percent-minheight-resize-expected.html:
- fast/repaint/percent-minheight-resize.html:
- svg/custom/svg-percent-scale-expected.html:
- svg/custom/svg-percent-scale-vonly-expected.html:
- svg/custom/svg-percent-scale-vonly.html:
- svg/custom/svg-percent-scale.html:
- 4:21 AM Changeset in webkit [109333] by
-
- 2 edits in trunk/Source/WebCore
SVG <use> element allows invalid contents
https://bugs.webkit.org/show_bug.cgi?id=77764
Reviewed by Zoltan Herczeg.
Unbreak the world after r109299 - dozens of SVGUseElement tests fail in trunk because:
- text nodes weren't allowed in SVG shadow subtrees
- tagName matching ignores any prefixes, thus svg:circle fails to identify as SVGCircleElement
- svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
- 3:43 AM Changeset in webkit [109332] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109228
- 3:43 AM Changeset in webkit [109331] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitHyphens in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80004
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:36 AM Changeset in webkit [109330] by
-
- 11 edits3 adds in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109222
- 3:17 AM Changeset in webkit [109329] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build.
- UIProcess/API/gtk/WebKitDefines.h:
- UIProcess/API/gtk/WebKitWebView.h:
- 2:29 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:28 AM Changeset in webkit [109328] by
-
- 6 edits in trunk
Web Inspector: abstract out the common pattern of creating auto-updated locations.
https://bugs.webkit.org/show_bug.cgi?id=79906
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.createLiveLocation):
(WebInspector.RawSourceCode.LiveLocation):
(WebInspector.RawSourceCode.LiveLocation.prototype.init):
(WebInspector.RawSourceCode.LiveLocation.prototype.dispose):
(WebInspector.RawSourceCode.LiveLocation.prototype._update):
LayoutTests:
- inspector/debugger/linkifier.html:
- 1:53 AM Changeset in webkit [109327] by
-
- 3 edits in trunk/Source/WebCore
Make the tiling code slightly smarter
https://bugs.webkit.org/show_bug.cgi?id=80015
Reviewed by Simon Hausmann.
Avoid doing the same tranformations all over in each call to
tileRectForCoordinate.
Do not resize tiles and then drop them because they are not out of
the keep rect; instead drop before resizing.
Rename dropTilesOutsideRect to setKeepRect as it now stored the keep
rect. This is used to avoid unneeded iteration of all tiles for
invalidates outside the keep rect.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
(WebCore):
(WebCore::TiledBackingStore::commitScaleChange):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::setSupportsAlpha):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
- 1:32 AM Changeset in webkit [109326] by
-
- 6 edits in trunk
[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
Tools:
Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
sending to the item requires the QObject::event re-implementation to dispatch to the correct
event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
the event handlers directly, and with the removal of our own dispatching we need to go through
that code path.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):
- 1:31 AM Changeset in webkit [109325] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG local CSE for a node can be terminated earlier
https://bugs.webkit.org/show_bug.cgi?id=80014
Reviewed by Filip Pizlo.
When one of the node's childredn is met in the process of back traversing
the nodes, we don't need to traverse the remaining nodes.
This is performance neutral on SunSpider, V8 and Kraken.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
- 1:18 AM Changeset in webkit [109324] by
-
- 14 edits in trunk/Source
Use the new createSnapshotFileAndReadMetadata API for FileEntry.file()
https://bugs.webkit.org/show_bug.cgi?id=79928
Reviewed by David Levin.
Source/WebCore:
No new tests: no functionality changes.
fast/filesystem/ tests should use the new code (they should pass once
the corresponding chromium change is rolled in).
- fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile): Updated to use the new API.
- fileapi/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile): Updated to use the new API.
- fileapi/FileSystemCallbacks.cpp:
- fileapi/FileSystemCallbacks.h:
(FileSystemCallbacksBase):
- platform/AsyncFileSystem.h:
(AsyncFileSystem):
- platform/AsyncFileSystemCallbacks.h: Added default implementation (which just calls ASSERT_NOTREACHED()) so that subclasses can focus only on the callback methods that they're interested in.
Source/WebKit/chromium:
In the new flow we first create an internal Blob URL for the
snapshot file and call the new createSnapshotFileAndReadMetadata()
WebKit API with the Blob URL.
The implementor of createSnapshotFileAndReadMetadata() (i.e. chromium)
registers the created snapshot file with the given internal Blob URL.
In the callback chain we call File::createWithName() to create a
new File using the returned platform path, and then call
unregisterBlobURL() to clean up the internal Blob URL.
- src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
(WebCore::AsyncFileSystemChromium::createSnapshotFileCallback): Added.
- src/AsyncFileSystemChromium.h:
- src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
- src/WorkerAsyncFileSystemChromium.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postCreateSnapshotFileToMainThread): Added.
(WebKit::WorkerFileSystemCallbacksBridge::createSnapshotFileOnMainThread): Added.
- src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):
- 12:22 AM Changeset in webkit [109323] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add UISourceCode.isEditable property.
https://bugs.webkit.org/show_bug.cgi?id=79909
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
- 12:05 AM Changeset in webkit [109322] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r109277.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-03-01
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
