Timeline
Mar 27, 2012:
- 11:43 PM Changeset in webkit [112367] by
-
- 2 edits in trunk/Tools
kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388
Disable kill-old-processes on the Qt bots not to kill each others.
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Factory.init):
- 11:40 PM Changeset in webkit [112366] by
-
- 5 edits1 move4 adds1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening after r112301.
- platform/qt-4.8/fast/dom/Window/window-properties-expected.png:
- platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.png: Added.
- platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.png: Removed.
- 11:12 PM Changeset in webkit [112365] by
-
- 2 edits1 add in trunk/LayoutTests
Not reviewed: rebaselined chromium expectations.
- platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png:
- platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt: Added.
- 11:08 PM Changeset in webkit [112364] by
-
- 13 edits1 copy in trunk/Source
[chromium] Transfer wheel fling via WebCompositorInputHandlerClient
https://bugs.webkit.org/show_bug.cgi?id=81740
Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
Source/WebCore:
Adds the ability to construct an in-progress PlatformGestureAnimation.
- platform/ActivePlatformGestureAnimation.cpp:
(WebCore::ActivePlatformGestureAnimation::create):
(WebCore):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
- platform/ActivePlatformGestureAnimation.h:
(ActivePlatformGestureAnimation):
- platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
- platform/TouchpadFlingPlatformGestureCurve.h:
(TouchpadFlingPlatformGestureCurve):
Source/WebKit/chromium:
Adds a path for transfering an active wheel fling animation out to the embedder from the compositor and back in
to a WebViewImpl via the embedder. This is used when we start a wheel fling animation on the compositor thread
but then hit a condition that we can't handle from the compositor, such as registered wheel event listeners or a
scrollable area we can't handle.
New tests added to WebCompositorInputHandlerTest for the transfering logic.
- public/WebActiveWheelFlingParameters.h: Copied from Source/WebKit/chromium/public/WebCompositorInputHandlerClient.h.
(WebKit):
(WebActiveWheelFlingParameters):
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
- public/WebCompositorInputHandlerClient.h:
(WebKit):
(WebCompositorInputHandlerClient):
(WebKit::WebCompositorInputHandlerClient::transferActiveWheelFlingAnimation):
- public/WebView.h:
(WebKit):
(WebView):
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
- src/WebCompositorInputHandlerImpl.h:
(WebCore):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::MockWebCompositorInputHandlerClient::MockWebCompositorInputHandlerClient):
(MockWebCompositorInputHandlerClient):
(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebKit::WebCompositorInputHandlerImplTest::~WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):
(WebKit):
- 9:27 PM Changeset in webkit [112363] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Send wheel events to main thread even if we think nothing is scrollable
https://bugs.webkit.org/show_bug.cgi?id=82408
Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
- 9:19 PM Changeset in webkit [112362] by
-
- 3 edits in trunk
Perf-o-matic build fix.
- Websites/webkit-perf.appspot.com/controller.py:
(RunsChartHandler.post):
- Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):
- 8:47 PM Changeset in webkit [112361] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
https://bugs.webkit.org/show_bug.cgi?id=82292
Change to check and avoid text selection across frames.
Internal reviewed by Mike Fenton
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
support selection across frames, so check if the *framePoint* is in
the *frame*.
(BlackBerry::WebKit::SelectionHandler::setSelection):
function returns a null VisablePosition, it stands for a invalid position
or a position in the different frames, therefor we don't execute setting
handle's position.
- 8:15 PM Changeset in webkit [112360] by
-
- 14 edits in trunk/Source
[chromium] Route monotonic clock up from compositor
https://bugs.webkit.org/show_bug.cgi?id=82154
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateAnimations):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
Source/WebKit/chromium:
- public/WebWidget.h:
(WebKit::WebWidget::animate):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::updateAnimations):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
- 8:05 PM Changeset in webkit [112359] by
-
- 3 edits in trunk/Tools
Handle DRT crash caused by Android OOM.
https://bugs.webkit.org/show_bug.cgi?id=82310
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-27
Reviewed by Tony Chang.
When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
is stopped silently and regarded as crashed. Re-run the test for
such crash.
Add some debug log to NRWT.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.get_last_stacktrace):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver._get_drt_return_value):
- 7:56 PM Changeset in webkit [112358] by
-
- 1 edit2 adds in trunk/Source/WebCore
[BlackBerry] Upstream LayerAnimation.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80123
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.
Initial upstream, no new tests.
- platform/graphics/blackberry/LayerAnimation.cpp: Added.
(WebCore):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::timingFunctionForAnimationValue):
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
(WebCore::LayerAnimation::blendTransform):
(WebCore::LayerAnimation::blendOpacity):
(WebCore::LayerAnimation::validateTransformLists):
- platform/graphics/blackberry/LayerAnimation.h: Added.
(WebCore):
(LayerAnimation):
(WebCore::LayerAnimation::create):
(WebCore::LayerAnimation::clone):
(WebCore::LayerAnimation::~LayerAnimation):
(WebCore::LayerAnimation::name):
(WebCore::LayerAnimation::setStartTime):
(WebCore::LayerAnimation::idFromAnimation):
(WebCore::LayerAnimation::isEqualToAnimation):
(WebCore::LayerAnimation::id):
(WebCore::LayerAnimation::property):
(WebCore::LayerAnimation::boxSize):
(WebCore::LayerAnimation::timeOffset):
(WebCore::LayerAnimation::startTime):
(WebCore::LayerAnimation::valueCount):
(WebCore::LayerAnimation::timingFunction):
(WebCore::LayerAnimation::duration):
(WebCore::LayerAnimation::iterationCount):
(WebCore::LayerAnimation::direction):
(WebCore::LayerAnimation::valueAt):
(WebCore::LayerAnimation::LayerAnimation):
- 7:42 PM Changeset in webkit [112357] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Uninitialized access in SimpleFontDataSkia::platformInit
https://bugs.webkit.org/show_bug.cgi?id=82411
Reviewed by Kent Tamura.
SimpleFontDataSkia::platformInit() could call widthForGlyph(), which
accesses m_zeroWidthSpaceGlyph. This causes a valgrind memcheck error
because m_zeroWidthSpaceGlyph isn't initialized at this point.
Initialize m_zeroWidthSpaceGlyph with zero so that widthForGlyph() can
return appropriate value(The value zero here means "unknown glyph").
No new tests. I manually confirmed this change fixes the valgrind
memcheck error.
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):
- 7:29 PM Changeset in webkit [112356] by
-
- 2 edits in trunk/Source/WebKit/chromium
webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
https://bugs.webkit.org/show_bug.cgi?id=82382
Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
Use UnsignedWithZeroKeyHashTraits trait for the HashSet<WebGLId> m_usedTextures in
CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet<T>
where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.
- tests/CCLayerTreeHostTest.cpp:
(CompositorFakeWebGraphicsContext3DWithTextureTracking):
- 7:08 PM Changeset in webkit [112355] by
-
- 2 edits in trunk/Tools
Fix expected results for some unittest failures.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- 7:06 PM Changeset in webkit [112354] by
-
- 4 edits in trunk/Tools
[chromium] Fix --enabled-threaded-compositing flag in DRT
https://bugs.webkit.org/show_bug.cgi?id=82405
Reviewed by James Robinson.
--enable-threaded-compositing wasn't working because there was no way
to set the value before it was used in the TestShell constructor.
To avoid adding yet another boolean parameter to TestShell's
constructor, add an explicit initialize function that can operate on
any boolean settings that are set post-constructor.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setTestShellMode):
- 7:02 PM Changeset in webkit [112353] by
-
- 9 edits1 add in trunk/Source
[EFL][WK2] Add RunLoopEfl and WorkQueueEfl
https://bugs.webkit.org/show_bug.cgi?id=62777
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-27
Reviewed by Hajime Morita.
Source/WebCore:
Add initial version RunLoopEfl for WebKit2 Efl.
- platform/RunLoop.h:
(TimerBase):
(RunLoop):
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore):
(WebCore::RunLoop::run):
(WebCore::RunLoop::stop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::TimerBase):
(WebCore::RunLoop::TimerBase::~TimerBase):
(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):
(WebCore::RunLoop::TimerBase::isActive):
Source/WebKit2:
Add initial version WorkQueueEfl for WebKit2 Efl.
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open):
- Platform/PlatformProcessIdentifier.h:
(WebKit):
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/efl/WorkQueueEfl.cpp: Added.
(TimerWorkItem):
(TimerWorkItem::TimerWorkItem):
(TimerWorkItem::~TimerWorkItem):
(TimerWorkItem::function):
(TimerWorkItem::queue):
(TimerWorkItem::timerID):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::performWork):
(WorkQueue::performFdWork):
(WorkQueue::sendMessageToThread):
(WorkQueue::workQueueThread):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::timerFired):
(WorkQueue::dispatchAfterDelay):
- PlatformEfl.cmake:
- 6:58 PM Changeset in webkit [112352] by
-
- 2 edits in trunk/LayoutTests
More flaky tests!
Unreviewed, expectations changes.
- platform/chromium/test_expectations.txt:
- 6:56 PM Changeset in webkit [112351] by
-
- 2 edits in trunk/Source/WebKit/chromium
webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
https://bugs.webkit.org/show_bug.cgi?id=82381
Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
test uses and the test isn't designed to cover the theming code, only code inside the compositor.
- tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):
- 6:16 PM Changeset in webkit [112350] by
-
- 2 edits in trunk/LayoutTests
Restore a couple of leopard/snowleopard expectations I overzealously deleted.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 6:10 PM Changeset in webkit [112349] by
-
- 2 edits in trunk/LayoutTests
Remove move tests passing on win and linux.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 6:01 PM Changeset in webkit [112348] by
-
- 2 edits in trunk/LayoutTests
Remove more tests passing on lion
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 5:58 PM Changeset in webkit [112347] by
-
- 3 edits in trunk/Source/WebCore
Reinforce Geolocation to prevent accidental leak of the user position
https://bugs.webkit.org/show_bug.cgi?id=82396
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-27
Reviewed by Adam Barth.
It is very important not to provide the position of the user to a page
unless the user authorize it.
The code used to make it easy to cause such problems, because any part
of the Geolocation object could invoke the success callback directly.
This patch add encapsulation for all the attributes of GeoNotifier,
and add extra guards for the two callbacks.
In the case of the success callback, we do one extra check before sending
the value to the bindings.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::runSuccessCallback):
(WebCore::Geolocation::GeoNotifier::runErrorCallback):
(WebCore):
(WebCore::Geolocation::GeoNotifier::stopTimer):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::sendError):
(WebCore::Geolocation::sendPosition):
(WebCore::Geolocation::stopTimer):
(WebCore::Geolocation::extractNotifiersWithCachedPosition):
(WebCore::Geolocation::startUpdating):
- Modules/geolocation/Geolocation.h:
(WebCore::Geolocation::isAllowed):
(Geolocation):
(GeoNotifier):
(WebCore::Geolocation::GeoNotifier::options):
(WebCore::Geolocation::GeoNotifier::useCachedPosition):
- 5:52 PM Changeset in webkit [112346] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r112339.
http://trac.webkit.org/changeset/112339
https://bugs.webkit.org/show_bug.cgi?id=82354
webkit_unit_tests crashing on chromium mac bots
- src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
- tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::TearDown):
(WebKit):
(WebKit::TEST_F):
- 5:49 PM Changeset in webkit [112345] by
-
- 5 edits in branches/safari-534.56-branch/Source
Versioning.
- 5:47 PM Changeset in webkit [112344] by
-
- 2 edits in trunk/LayoutTests
Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 5:37 PM Changeset in webkit [112343] by
-
- 11 edits in trunk/Source
[Coverity] Address some uninitialized constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82376
Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-03-27
Reviewed by James Robinson.
Source/WebCore:
New tests are not required since I did not modify any code behavior.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
- platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):
Source/WebKit/chromium:
New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.
- src/WebCompositorInputHandlerImpl.cpp:
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
- 5:28 PM Changeset in webkit [112342] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS to r129300.
Unreviewed, deps change.
- DEPS:
- 5:27 PM Changeset in webkit [112341] by
-
- 2 edits in trunk/Source/WebCore
Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397
Reviewed by Benjamin Poulain.
Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.
No new tests, no functionality change intended.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 5:21 PM Changeset in webkit [112340] by
-
- 2 edits in trunk/Source/WebCore
Fix race condition when initializing the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=82398
<rdar://problem/11002166>
Reviewed by Sam Weinig.
Lock m_initializeRunLoopConditionMutex when assigning m_threadIdentifier since we're
asserting that it's not null in the scrolling thread.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):
- 5:19 PM Changeset in webkit [112339] by
-
- 3 edits in trunk/Source/WebKit/chromium
AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354
AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.
Reviewed by Adam Barth.
- src/AssociatedURLLoader.cpp:
(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):
- tests/AssociatedURLLoaderTest.cpp:
(WebKit::TEST_F):
- 5:16 PM Changeset in webkit [112338] by
-
- 23 edits in trunk/Source/WebKit2
Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
https://bugs.webkit.org/show_bug.cgi?id=82387
<rdar://problem/11031942>
Reviewed by Sam Weinig.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::initialize):
Remove m_pluginCreationParameters; it was used by the old NPRuntime short-circuit code.
Make platformInitialize take creation parameters.
- PluginProcess/PluginControllerProxy.messages.in:
Add SetLayerHostingMode message.
- PluginProcess/gtk/PluginControllerProxyGtk.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformInitialize):
Call updateLayerHostingContext.
(WebKit::PluginControllerProxy::setLayerHostingMode):
Call updateLayerHostingContext and send back the new context ID.
(WebKit::PluginControllerProxy::updateLayerHostingContext):
Create a new LayerHostingContext given the layer hosting mode.
- PluginProcess/qt/PluginControllerProxyQt.cpp:
(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::setLayerHostingMode):
Add stub.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::makeRenderLayer):
Add helper function for creating a new render layer.
(WebKit::PluginProxy::pluginLayer):
Call makeRenderLayer.
(WebKit::PluginProxy::setLayerHostingMode):
Send a message to the plug-in process.
(WebKit::PluginProxy::setLayerHostingContextID):
Update the context ID and make a new render layer.
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::setLayerHostingMode):
Add stub.
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h:
Add the layer hosting mode as a parameter. Add a new setLayerHostingMode pure virtual member function.
- WebProcess/Plugins/PluginProxy.messages.in:
Add a SetLayerHostingContextID message.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
Call down to the plug-in.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Set the layer hosting mode of the page.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_layerHostingMode to false.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
Add m_layerHostingMode and a getter.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Call WebPage::setLayerHostingMode.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setLayerHostingMode):
Tell all plug-ins that the layer hosting mode changed.
- 5:12 PM Changeset in webkit [112337] by
-
- 2 edits in trunk/Tools
new-run-webkit-tests: suppress debug output from run-safari on results file
https://bugs.webkit.org/show_bug.cgi?id=82400
Reviewed by Ryosuke Niwa.
Send the run-safari output to /dev/null rather than the console.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
- 5:12 PM Changeset in webkit [112336] by
-
- 3 edits in trunk/Source/WebCore
Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
https://bugs.webkit.org/show_bug.cgi?id=82393
Reviewed by Eric Seidel.
No new tests / adding assetions only.
- css/LengthFunctions.cpp:
(WebCore::valueForLength):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
- 5:05 PM Changeset in webkit [112335] by
-
- 676 edits45 copies8 deletes in branches/subpixellayout
Merge trunk changes up until 112329 into subpixel branch.
- 5:02 PM Changeset in webkit [112334] by
-
- 2 edits in trunk/LayoutTests
Remove more passing tests, tighten overly broad expectations.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 4:56 PM Changeset in webkit [112333] by
-
- 5 edits in trunk
use the correct size when computing flex-pack space
https://bugs.webkit.org/show_bug.cgi?id=82378
Reviewed by Ojan Vafai.
Source/WebCore:
Fix 2 bugs:
- We weren't properly updating available space before computing packing space. If a min/max is not hit, we still need to adjust the available free space.
- For flex-pack:end, we need to put the overflow in the start edge.
New test cases in css3/flexbox/flex-pack.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::initialPackingOffset):
LayoutTests:
- css3/flexbox/flex-pack-expected.txt:
- css3/flexbox/flex-pack.html:
- 4:49 PM Changeset in webkit [112332] by
-
- 4 edits in trunk/Source
[chromium] Unknown transforms should be treated as non-axis aligned on main thread
https://bugs.webkit.org/show_bug.cgi?id=82370
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
Source/WebCore:
On main thread, animating transforms have "unknown" values as they are changing
out of sync on the impl thread. So treat them as non-axis-aligned since they
may be, when deciding to create a render surface.
In addition, since surfaces are cheap on main thread, create one for all layers
with animating transforms and a drawing descendant, as this allows paint culling
within the layer's subtree (the animated transform won't affect drawTransforms
inside the subtree).
Also renamed the layerIsInAnimatingSubtreeFor* to animatingTransformTo*.
The old name made me pause and think what it meant and I'm the one who
created it. Hopefully this is more clear.
Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::transformToParentIsKnown):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
- 4:39 PM Changeset in webkit [112331] by
-
- 1 copy in tags/Safari-534.56.3
New tag.
- 4:25 PM Changeset in webkit [112330] by
-
- 1 delete in branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp
Update SVGImageBufferTools on branch to match trunk.
- 4:21 PM Changeset in webkit [112329] by
-
- 3 edits in trunk/Source/WebCore
Re-land r112277; reverting it doesn't seem to have fixed anything.
Unreviewed, build fix.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
- xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):
- 4:21 PM April 2012 Meeting edited by
- (diff)
- 4:12 PM Changeset in webkit [112328] by
-
- 3884 edits6304 copies880 deletes in branches/subpixellayout
Merge trunk changes up until 112277 into subpixel branch.
- 4:07 PM WebKitIDL edited by
- (diff)
- 3:46 PM Changeset in webkit [112327] by
-
- 12 edits in trunk/Source
[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
https://bugs.webkit.org/show_bug.cgi?id=81689
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
Source/WebCore:
The return value from this function is a region of opaque pixels in the
layer's content space that intersect with its visible rect. Rather than
adding a comment to this effect, renaming the method to make it clear.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::opaqueVisibleContents):
- tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestContentLayerChromium::opaqueVisibleContents):
(WebCore::TestContentLayerImpl::opaqueVisibleContents):
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 3:29 PM Changeset in webkit [112326] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] A unit test to verify clipping is honored when moving occlusion to parent surface
https://bugs.webkit.org/show_bug.cgi?id=81783
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
- tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
- 3:24 PM Changeset in webkit [112325] by
-
- 10 edits in trunk/Source
Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163
Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Anders Carlsson.
Source/WebCore:
Whenever a ScrollableArea is added or removed from a FrameView's ScrollableAreaSet, we have to recalculate the
nonFastScrollableRegion. This can happen for certain types of plugins that are scrollable.
This also reverts 112142 which was a not quite right way to handle these plugins.
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- plugins/PluginViewBase.h:
Source/WebKit/chromium:
Since ScrollbarGroups are ScrollableAreas, they need to be able to report their bounds for the
ScrollingCoordinator's calculateNonFastScrollableRegion. This also changes ScrollbarGroups to only be registered
as ScrollableAreas on the FrameView's set when they actually have Scrollbars.
- src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setFrameRect):
(WebKit):
(WebKit::ScrollbarGroup::scrollableAreaBoundingBox):
- src/ScrollbarGroup.h:
(ScrollbarGroup):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit):
(WebKit::WebPluginContainerImpl::scrollbarGroup):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 3:21 PM Changeset in webkit [112324] by
-
- 2 edits in trunk/LayoutTests
Remove a bunch of lines that are no longer failing.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 3:13 PM Changeset in webkit [112323] by
-
- 3 edits2 adds in trunk
Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
https://bugs.webkit.org/show_bug.cgi?id=82377
Reviewed by Ryosuke Niwa.
Source/WebCore:
This fixes a regression from r111925.
Test: fast/dom/insertBefore-refChild-crash.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore): Move the 'next' RefPtr above the call to
collectChildrenAndRemoveFromOldParent and rename refChildPreviousSibling
to 'prev' (matching appendChild and replaceChild).
LayoutTests:
- fast/dom/insertBefore-refChild-crash-expected.txt: Added.
- fast/dom/insertBefore-refChild-crash.html: Added.
- 3:07 PM Changeset in webkit [112322] by
-
- 2 edits in trunk/Tools
Improve error reporting in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=82379
Reviewed by Jessie Berlin.
When the script dies, have it print out the reason for dying.
- Scripts/run-javascriptcore-tests:
- 3:01 PM Changeset in webkit [112321] by
-
- 5 edits in trunk
cssText should not generate literal 'initial' in shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=82364
Reviewed by Antti Koivisto.
Source/WebCore:
Fixed the bug by treating initial value as if the value is not set.
While this is incorrect for properties that inherits by default,
it's strictly better than generating unparsable value as we do today.
The proper fix is for CSSInitialValue::cssText to fetch the respective
default value from what's currently in CSSStyleSelector code but that requires
a considerable amount of refactoring and work.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
LayoutTests:
- fast/css/cssText-shorthand-expected.txt: Rebaselined.
- fast/css/cssText-shorthand.html:
- 2:54 PM Changeset in webkit [112320] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG OSR exit should not generate an exit for variables of inlinees if the
inlinees are not in scope
https://bugs.webkit.org/show_bug.cgi?id=82312
Reviewed by Oliver Hunt.
- bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForInlineCallFrame):
(JSC):
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::computeNumVariablesForCodeOrigin):
(DFG):
(JSC::DFG::OSRExit::OSRExit):
- 2:39 PM Changeset in webkit [112319] by
-
- 2 edits in trunk/Tools
Add Dave Barton to the Contributors list so I can more easily CC him on bugs
https://bugs.webkit.org/show_bug.cgi?id=82373
Reviewed by Ryosuke Niwa.
Dave's committer-status in in-progress, so until then
list him as a Contributor so at least I can more easily CC him on bugs.
- Scripts/webkitpy/common/config/committers.py:
- 2:38 PM Changeset in webkit [112318] by
-
- 14 edits in trunk/Source/WebCore
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256
Reviewed by Adam Barth.
This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).
Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.
Relanding r112207 with setJSWrapperForDOMSVGElementInstance defined
out-of-line to avoid SVG header dependencies.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.
Not inline to avoid header dependency on SVGElementInstance.h.
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.
- 2:34 PM Changeset in webkit [112317] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Make use of common animation unit test methods
https://bugs.webkit.org/show_bug.cgi?id=82357
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.
- tests/CCAnimationTestCommon.cpp:
(WebKitTests::addAnimatedTransformToController):
(WebKitTests):
- tests/CCAnimationTestCommon.h:
(WebKitTests):
- tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
- 2:34 PM Changeset in webkit [112316] by
-
- 3 edits in trunk/Source/WebCore
Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82344
Reviewed by Eric Seidel.
Correcting the signature of RenderFlexibleBox::layoutBlock to use a LayoutUnit
for the page height, and avoiding assigning the renderer's size to an IntSize.
No new tests. No change in behavior.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- 2:29 PM Changeset in webkit [112315] by
-
- 1 edit in trunk/Source/WebCore/platform/mac/SoftLinking.h
Fix a missing block call that was found post review.
- 2:29 PM Changeset in webkit [112314] by
-
- 2 edits in trunk/LayoutTests
Change media/track/track-delete-during-startup bug #
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 2:15 PM Changeset in webkit [112313] by
-
- 2 edits in trunk/Source/JavaScriptCore
Stop compiling Interpreter.cpp with -fno-var-tracking
https://bugs.webkit.org/show_bug.cgi?id=82299
Reviewed by Anders Carlsson.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:01 PM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 1:44 PM Changeset in webkit [112312] by
-
- 7 edits in trunk/Source
Make WebKit properly load a staged framework when soft linking.
https://webkit.org/b/82371
rdar://problem/11125989
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/mac/SoftLinking.h: Replaced SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL with
SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL and made it use the StagedFrameworks path
if the first dlopen failed.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
load the WebInspector framework.
- WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.
- 1:33 PM Changeset in webkit [112311] by
-
- 2 edits in trunk/LayoutTests
Mark media/track/track-delete-during-startup as crashing in debug.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 1:33 PM Changeset in webkit [112310] by
-
- 10 edits1 add in trunk/Source/WebCore
Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056
Reviewed by Antti Koivisto.
Introduce a new CSSParserMode enum to differ between strict / quirks and SVG presentation
attribute parsing modes.
The followup patch will make use of the enum in all other classes.
After that it will be easier possible to reuse the CSS parser in SVG as much as possible and
introduce SVG specific functionality.
No new tests. No change on functionality yet. This is just a refactoring to use the enumeration.
- GNUmakefile.list.am: Added new file CSSParserMode.h with the new enum, which can be used by any caller of CSSParser, CSSStyleSheet and others.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSGrammar.y: Make use of the new enumeration.
- css/CSSParser.cpp: Replaced boolean by enumeration. No change of functionality at this point of time.
(WebCore::CSSParser::inStrictMode): Helper function.
(WebCore):
(WebCore::CSSParser::inQuirksMode): Helper function.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::checkForOrphanedUnits):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
- css/CSSParser.h:
(CSSParser):
- css/CSSParserMode.h: Added. New enumeration CSSParserMode.
- css/SVGCSSParser.cpp: Use new SVGAttributeMode CSS parsing mode.
(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGStrokeDasharray):
- 1:33 PM Changeset in webkit [112309] by
-
- 3 edits in trunk/Tools
[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252
Reviewed by Gustavo Noronha Silva.
Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 1:30 PM Changeset in webkit [112308] by
-
- 5 edits in trunk/Source/WebCore
2012-03-27 Nate Chapin <Nate Chapin>
Don't manually set an identifier for main resource
loads in FrameLoader. ResourceLoader::willSendRequest()
will set an identifier for the request if one isn't found,
so this code appears to be unnecessary duplication.
https://bugs.webkit.org/show_bug.cgi?id=82248
Reviewed by Adam Barth.
No new tests, no functionality change intended.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Mark navigation start
here, since it's conceptually part of starting the main resource load.
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Remove duplicate identifier
logic, and move navigation timing call to startLoadingMainResource, since
it fits better logically there.
- loader/ResourceLoader.h: No callers of setIdentifier() remain, so delete it.
- 1:20 PM Changeset in webkit [112307] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, expectations change.
Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit
- platform/chromium/test_expectations.txt:
- 1:18 PM Changeset in webkit [112306] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r112277.
http://trac.webkit.org/changeset/112277
https://bugs.webkit.org/show_bug.cgi?id=81985
possibly causing crashes?
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
- xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):
- 1:08 PM Changeset in webkit [112305] by
-
- 4 edits in trunk/Source/WebCore
<http://webkit.org/b/82362> Web Inspector: Provide private -[DOMNode inspect]
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-27
Reviewed by Timothy Hatcher.
No new tests, this is only an ObjC SPI.
- bindings/objc/DOM.mm:
- bindings/objc/DOMPrivate.h:
(-[DOMNode inspect]):
Call through to InspectorController inspect for the node.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::inspect):
Whenever we inspect an element, clear the node search.
The frontend already takes this approach.
- 1:06 PM Changeset in webkit [112304] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
https://bugs.webkit.org/show_bug.cgi?id=81706
Patch by Joe Mason <jmason@rim.com> on 2012-03-27
Reviewed by Rob Buis.
LayerCompositingThread has a destructor that does a synchronous
dispatch to the compositing thread and then does the actual cleanup
from a helper function. This is confusing.It should be the
opposite: the helper function dispatches to the compositing thread,
which calls delete.
No new tests since the existing animation tests will exercise this
code.
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WTF):
(WTF::::deref):
- 12:36 PM Changeset in webkit [112303] by
-
- 4 edits in trunk
Show image diffs for gpu_tests on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81848
Patch by Dave Tu <dtu@chromium.org> on 2012-03-27
Reviewed by Ojan Vafai.
Add a new results layout for gpu_tests that pulls the image diffs in
addition to the text output. Also add new gpu_tests builders.
- Tools/TestResultServer/static-dashboards/builders.js: Update
gpu_tests builders.
- Tools/TestResultServer/static-dashboards/dashboard_base.js: Add a
function to check for GPU test type.
- Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:
Add new GPU results layout.
- 12:32 PM Changeset in webkit [112302] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Stop using NSMapTable in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=82358
Reviewed by Darin Adler.
- platform/network/mac/FormDataStreamMac.mm: Use WTF::HashMap, as we always do. All accesses are protected with a mutex anyway.
- 12:19 PM Changeset in webkit [112301] by
-
- 44 edits14 adds in trunk
Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-27
Reviewed by Antti Koivisto.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units.
New Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin are added for these length units
and included the support for fetching the value of these relative units based on the current viewport size.
The specification related to this implementation is http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
Source/WebCore:
Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp: Modified to support viewport relative Length types.
(getAttributeSetForAccessibilityObject):
- css/CSSComputedStyleDeclaration.cpp: Ditto.
(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSGrammar.y: Added vw/vh/vmin support.
- css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
- css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength): Ditto.
- css/CSSStyleApplyProperty.cpp: Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
- css/CSSStyleSelector.cpp: Added support for viewport relative units.
- css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.
(WebCore::miminumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
- css/LengthFunctions.h: Added new RenderView argument.
(WebCore):
- dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
- dom/Document.h: Ditto.
(Document):
- html/HTMLAreaElement.cpp: Modified to support viewport relative Length types.
(WebCore::HTMLAreaElement::getRegion):
- platform/Length.h:
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
- rendering/RenderBR.cpp: Modified to support viewport relative Length types.
(WebCore::RenderBR::lineHeight):
- rendering/RenderBlock.cpp: Ditto.
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::lineHeight):
- rendering/RenderBox.cpp: Ditto.
(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBoxModelObject.cpp: Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderFlexibleBox.cpp: Ditto.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
- rendering/RenderInline.cpp: Ditto.
(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):
- rendering/RenderMenuList.cpp: Ditto.
(WebCore::RenderMenuList::updateOptionsWidth):
- rendering/RenderObject.cpp: Ditto.
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderReplaced.cpp: Ditto.
(WebCore::RenderReplaced::paint):
- rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
- rendering/RenderTable.cpp: Ditto.
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
- rendering/RenderTableCell.cpp: Ditto.
(WebCore::RenderTableCell::logicalHeightForRowSizing):
- rendering/RenderTableSection.cpp: Ditto.
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderText.h: Ditto.
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
- rendering/RenderThemeMac.mm: Ditto.
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
- rendering/RenderView.h:
(WebCore::RenderView::viewportSize):
- rendering/RenderWidget.cpp: Ditto.
(WebCore::RenderWidget::paint):
- rendering/RootInlineBox.cpp: Ditto.
(WebCore::RootInlineBox::verticalPositionForBox):
- rendering/style/RenderStyle.cpp: Ditto.
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
- rendering/style/RenderStyle.h: Ditto.
- rendering/svg/RenderSVGRoot.cpp: Ditto.
(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 12:19 PM Changeset in webkit [112300] by
-
- 60 edits2 moves21 adds in trunk/Source/ThirdParty/ANGLE
Update ANGLE in WebKit https://bugs.webkit.org/show_bug.cgi?id=81717
Reviewed by Kenneth Russell.
Update angleproject to r1009. Synced the source directory
between the angle repository and WebKit. Ran the OS X Lion
version of Bison over the glslang.l input which generates
a slightly different output than angle provided.
Converted tabs to spaces in preprocessor/new files.
- include/EGL/eglext.h:
- include/GLES2/gl2ext.h:
- include/GLSLANG/ShaderLang.h:
- src/common/RefCountObject.cpp: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.cpp.
(RefCountObject::RefCountObject):
(RefCountObject::~RefCountObject):
(RefCountObject::addRef):
(RefCountObject::release):
(RefCountObjectBindingPointer::set):
- src/common/RefCountObject.h: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.h.
(RefCountObject):
(RefCountObject::id):
(RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::~RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::get):
(RefCountObjectBindingPointer::id):
(RefCountObjectBindingPointer::operator ! ):
(BindingPointer):
(BindingPointer::set):
(BindingPointer::get):
(BindingPointer::operator -> ):
- src/common/debug.cpp:
(gl::output):
- src/common/version.h:
- src/compiler/BaseTypes.h:
- src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::~TCompiler):
(TCompiler::mapLongVariableNames):
- src/compiler/ConstantUnion.h:
(ConstantUnion::ConstantUnion):
(ConstantUnion::operator==):
(ConstantUnion::operator>):
(ConstantUnion::operator<):
- src/compiler/Intermediate.cpp:
(TIntermConstantUnion::fold):
- src/compiler/MapLongVariableNames.cpp:
(LongNameMap::LongNameMap):
(LongNameMap::~LongNameMap):
(LongNameMap::GetInstance):
(LongNameMap::Release):
(LongNameMap::Find):
(LongNameMap::Insert):
(LongNameMap::Size):
(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapGlobalLongName):
- src/compiler/MapLongVariableNames.h:
(LongNameMap):
(MapLongVariableNames):
- src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorateUniform):
- src/compiler/OutputHLSL.h:
(OutputHLSL):
- src/compiler/PoolAlloc.cpp:
(TAllocation::checkGuardBlock):
- src/compiler/ShHandle.h:
(TCompiler):
- src/compiler/SymbolTable.cpp:
- src/compiler/SymbolTable.h:
(TSymbolTable):
(TSymbolTable::getOuterLevel):
- src/compiler/VariableInfo.cpp:
(getVariableDataType):
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(yy_buffer_state):
(yyguts_t):
(input):
(yyensure_buffer_stack):
(yy_scan_bytes):
(yyget_leng):
- src/compiler/glslang_tab.cpp:
- src/compiler/osinclude.h:
- src/compiler/preprocessor/cpp.c:
- src/compiler/preprocessor/memory.c:
- src/compiler/preprocessor/new/Context.cpp: Added.
(isMacroNameReserved):
(pp):
(pp::Context::Context):
(pp::Context::~Context):
(pp::Context::init):
(pp::Context::process):
(pp::Context::defineMacro):
(pp::Context::undefineMacro):
(pp::Context::isMacroDefined):
(pp::Context::reset):
(pp::Context::defineBuiltInMacro):
- src/compiler/preprocessor/new/Context.h: Added.
(pp):
(Context):
(pp::Context::lexer):
(pp::Context::output):
- src/compiler/preprocessor/new/Input.cpp: Added.
(pp):
(pp::Input::Input):
(pp::Input::eof):
(pp::Input::read):
(pp::Input::getChar):
(pp::Input::peekChar):
(pp::Input::switchToNextString):
(pp::Input::isStringEmpty):
(pp::Input::stringLength):
- src/compiler/preprocessor/new/Input.h: Added.
(pp):
(Input):
(pp::Input::error):
(pp::Input::stringIndex):
- src/compiler/preprocessor/new/Macro.cpp: Added.
(pp):
(pp::Macro::Macro):
(pp::Macro::~Macro):
- src/compiler/preprocessor/new/Macro.h: Added.
(pp):
(Macro):
(pp::Macro::type):
(pp::Macro::identifier):
(pp::Macro::parameters):
(pp::Macro::replacements):
- src/compiler/preprocessor/new/Preprocessor.cpp: Added.
(pp):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::process):
(pp::Preprocessor::reset):
- src/compiler/preprocessor/new/Preprocessor.h: Added.
(pp):
(Preprocessor):
(pp::Preprocessor::begin):
(pp::Preprocessor::end):
- src/compiler/preprocessor/new/Token.cpp: Added.
(pp):
(pp::Token::encodeLocation):
(pp::Token::decodeLocation):
(pp::Token::Token):
(pp::Token::~Token):
(pp::operator<<):
- src/compiler/preprocessor/new/Token.h: Added.
(pp):
(Token):
(pp::Token::location):
(pp::Token::type):
(pp::Token::value):
- src/compiler/preprocessor/new/generate_parser.sh: Added.
- src/compiler/preprocessor/new/pp.l: Added.
- src/compiler/preprocessor/new/pp.y: Added.
- src/compiler/preprocessor/new/pp_lex.cpp: Added.
(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_push_state):
(yy_pop_state):
(yy_top_state):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(extractMacroName):
(pp):
(pp::Context::readInput):
(pp::Context::initLexer):
(pp::Context::destroyLexer):
- src/compiler/preprocessor/new/pp_tab.cpp: Added.
(YYLTYPE):
(yysyntax_error):
(yyerror):
(pushConditionalBlock):
(popConditionalBlock):
(pp::Context::parse):
- src/compiler/preprocessor/new/pp_tab.h: Added.
(YYLTYPE):
- src/compiler/preprocessor/new/stl_utils.h: Added.
(pp):
(Delete):
(pp::Delete::operator()):
(DeleteSecond):
(pp::DeleteSecond::operator()):
- src/compiler/preprocessor/new/token_type.h: Added.
- src/compiler/preprocessor/scanner.c:
(yylex_CPP):
- src/compiler/preprocessor/symbols.c:
- src/compiler/preprocessor/tokens.c:
- src/libEGL/Config.cpp:
(egl::ConfigSet::getConfigs):
- src/libEGL/Display.cpp:
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::restoreLostDevice):
(egl::Display::sync):
(egl):
(egl::Display::allocateEventQuery):
(egl::Display::freeEventQuery):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getEventQuerySupport):
(egl::Display::initExtensionString):
(egl::Display::shareHandleSupported):
(egl::Display::getOcclusionQuerySupport):
(egl::Display::getInstancingSupport):
- src/libEGL/Display.h:
(Display):
(egl::Display::isD3d9ExDevice):
- src/libEGL/Surface.cpp:
(egl::Surface::resetSwapChain):
- src/libEGL/libEGL.cpp:
- src/libEGL/libEGL.vcproj:
- src/libGLESv2/Blit.cpp:
(gl::Blit::setCommonBlitState):
- src/libGLESv2/Buffer.h:
(Buffer):
- src/libGLESv2/Context.cpp:
(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::getActiveQuery):
(gl):
(gl::Context::createFence):
(gl::Context::createQuery):
(gl::Context::deleteQuery):
(gl::Context::beginQuery):
(gl::Context::endQuery):
(gl::Context::getQuery):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawLineLoop):
(gl::Context::supportsOcclusionQueries):
(gl::Context::supportsInstancing):
(gl::Context::setVertexAttribDivisor):
(gl::Context::initExtensionString):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):
- src/libGLESv2/Context.h:
(gl):
(gl::VertexAttribute::VertexAttribute):
(State):
(VertexDeclarationCache):
(Context):
- src/libGLESv2/Fence.cpp:
(gl::Fence::Fence):
(gl::Fence::~Fence):
(gl::Fence::setFence):
- src/libGLESv2/Fence.h:
(egl):
(Fence):
- src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::detachTexture):
(gl::Framebuffer::completeness):
- src/libGLESv2/Framebuffer.h:
- src/libGLESv2/IndexDataManager.cpp:
(gl::IndexDataManager::IndexDataManager):
(gl::IndexDataManager::~IndexDataManager):
(gl::computeRange):
(gl::IndexDataManager::prepareIndexData):
(gl::IndexDataManager::getCountingIndices):
(gl):
- src/libGLESv2/IndexDataManager.h:
(IndexDataManager):
- src/libGLESv2/Program.cpp:
(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::Program::setUniform4fv):
(gl::Program::setUniform1iv):
(gl::Program::setUniform2iv):
(gl::Program::setUniform3iv):
(gl::Program::setUniform4iv):
(gl::Program::packVaryings):
(gl::Program::linkVaryings):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::getInfoLog):
- src/libGLESv2/Program.h:
(Program):
- src/libGLESv2/Query.cpp: Added.
(gl):
(gl::Query::Query):
(gl::Query::~Query):
(gl::Query::begin):
(gl::Query::end):
(gl::Query::getResult):
(gl::Query::isResultAvailable):
(gl::Query::getType):
(gl::Query::testQuery):
- src/libGLESv2/Query.h: Added.
(gl):
(Query):
- src/libGLESv2/Renderbuffer.cpp:
(gl):
(gl::RenderbufferInterface::addProxyRef):
(gl::RenderbufferInterface::releaseProxy):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::addProxyRef):
(gl::RenderbufferTexture::releaseProxy):
(gl::Renderbuffer::addRef):
(gl::Renderbuffer::release):
- src/libGLESv2/Renderbuffer.h:
(gl):
(RenderbufferInterface):
(RenderbufferTexture):
(Renderbuffer):
- src/libGLESv2/Shader.cpp:
(gl::Shader::Shader):
(gl::Shader::getInfoLog):
(gl::Shader::getSourceImpl):
(gl):
(gl::Shader::initializeCompiler):
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
(gl::Shader::compileToHLSL):
(gl::VertexShader::uncompile):
(gl::VertexShader::compile):
(gl::VertexShader::parseAttributes):
(gl::FragmentShader::compile):
- src/libGLESv2/Shader.h:
(Shader):
(VertexShader):
- src/libGLESv2/Texture.cpp:
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl):
(gl::Texture2D::addProxyRef):
(gl::Texture2D::releaseProxy):
(gl::Texture2D::getRenderbuffer):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::addProxyRef):
(gl::TextureCubeMap::releaseProxy):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::getRenderbuffer):
- src/libGLESv2/Texture.h:
(Texture):
(Texture2D):
(TextureCubeMap):
- src/libGLESv2/VertexDataManager.cpp:
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexDataManager::spaceRequired):
(gl):
- src/libGLESv2/VertexDataManager.h:
(TranslatedAttribute):
(VertexDataManager):
- src/libGLESv2/libGLESv2.cpp:
- src/libGLESv2/libGLESv2.def:
- src/libGLESv2/libGLESv2.vcproj:
- src/libGLESv2/utilities.cpp:
(gl::IsInternalTextureTarget):
- src/libGLESv2/utilities.h:
(gl):
- 12:16 PM Changeset in webkit [112299] by
-
- 14 edits6 deletes in trunk/Source/WebCore
Remove deprecated LowPass2FilterNode and HighPass2FilterNode
https://bugs.webkit.org/show_bug.cgi?id=82296
Patch by Gao Chun <chun.gao@intel.com> on 2012-03-27
Reviewed by Chris Rogers.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioContext.h:
(WebCore):
(AudioContext):
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadProcessor.cpp:
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/HighPass2FilterNode.cpp: Removed.
- Modules/webaudio/HighPass2FilterNode.h: Removed.
- Modules/webaudio/HighPass2FilterNode.idl: Removed.
- Modules/webaudio/LowPass2FilterNode.cpp: Removed.
- Modules/webaudio/LowPass2FilterNode.h: Removed.
- Modules/webaudio/LowPass2FilterNode.idl: Removed.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- 12:15 PM Changeset in webkit [112298] by
-
- 2 edits2 adds in trunk/Tools
test-webkitpy: prepare for better test run output
https://bugs.webkit.org/show_bug.cgi?id=82290
Reviewed by Adam Barth.
This code basically re-implements the output of the TextTestRunner default
runner code from unittest, although the implementation is quite
different, in preparation for changing the test output to be
metered and possibly running in parallel.
The output is almost identical to before, except that instead of
logging "test_regular (webkitpy.main.RunnerTest) passed" we log
"webkitpy.main.RunnerTest.test_regular passed". It has always
annoyed me that they invert the names to be harder to read and
so that you can't copy & paste back to the input for
test-webkitpy.
This patch is provided to add a skeleton for unit tests and for
comparison to an upcoming patch that will actually add new
functionality.
- Scripts/webkitpy/test/main.py:
(Tester.init):
(Tester._configure_logging):
(Tester._run_tests):
- Scripts/webkitpy/test/runner.py: Added.
(TestRunner):
(TestRunner.init):
(TestRunner.test_name):
(TestRunner.all_test_names):
(TestRunner.run):
(TestRunner.write_result):
(TestRunner.write_summary):
- Scripts/webkitpy/test/runner_unittest.py: Added.
(FakeModuleSuite):
(FakeModuleSuite.init):
(FakeModuleSuite.str):
(FakeModuleSuite.run):
(FakeTopSuite):
(FakeTopSuite.init):
(FakeLoader):
(FakeLoader.init):
(FakeLoader.top_suite):
(FakeLoader.loadTestsFromName):
(RunnerTest):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
- 12:08 PM Changeset in webkit [112297] by
-
- 1 copy in releases/WebKitGTK/webkit-1.7.92
Tagging the WebKitGTK+ 1.7.92 release
- 12:07 PM Changeset in webkit [112296] by
-
- 1 delete in releases/WebKitGTK/webkit-1.8.0/webkit-1.8
Removing improperly tagged WebKitGTK+ release
- 11:59 AM Changeset in webkit [112295] by
-
- 1 copy in releases/WebKitGTK/webkit-1.7.91
Tagging the WebKitGTK+ 1.7.91 release
- 11:58 AM Changeset in webkit [112294] by
-
- 2 edits in trunk/Tools
[GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway
- 11:56 AM Changeset in webkit [112293] by
-
- 1 copy in releases/WebKitGTK/webkit-1.8.0/webkit-1.8
Tagging the 1.8.0 release
- 11:54 AM Changeset in webkit [112292] by
-
- 1 copy in releases/WebKitGTK/webkit-1.8.0
Tagging the 1.8.0 release
- 11:49 AM Changeset in webkit [112291] by
-
- 3 edits2 copies in tags/Safari-536.4.1/Source
Merge 111898.
- 11:45 AM Changeset in webkit [112290] by
-
- 4 edits in tags/Safari-536.4.1/Source
Versioning.
- 11:42 AM Changeset in webkit [112289] by
-
- 2 edits in trunk/Source/WebKit2
Don't update the layer hosting state unless the WKView is added to a window
https://bugs.webkit.org/show_bug.cgi?id=82359
Reviewed by Sam Weinig.
This avoids thrashing the layer hosting state when switching tabs.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- 11:41 AM Changeset in webkit [112288] by
-
- 1 copy in tags/Safari-536.4.1
New Tag.
- 11:39 AM Changeset in webkit [112287] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
https://bugs.webkit.org/show_bug.cgi?id=82350
Switch timer in WebPageCompositor to use AnimationFrameRateController.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-27
Reviewed by Rob Buis.
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 11:18 AM Changeset in webkit [112286] by
-
- 16 edits3 adds in trunk/Source
[chromium] Add TextureCopier for copying texture contents
https://bugs.webkit.org/show_bug.cgi?id=80870
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-27
Reviewed by Stephen White.
Source/WebCore:
This patch introduces a TextureCopier class whose job is to copy the
contents from one GL texture to another using the most efficient means
for the current GPU. This version uses render-to-texture to do the copy,
but a path based on EXT_framebuffer_blit can be added later.
The class is intended to replace the use of image path operations such
as glCopyTex{Sub}Image2D for duplicating texture contents. The reason is
that such functions may not be very well optimized in some -- mainly
mobile -- GPU drivers.
With this patch the new copier is used just for Canvas2D layer
presentation, but another potential use is for WebGL layer presentation.
Test: webkit_unit_tests: TextureCopierTest
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(WebCore::LayerRendererChromium::textureCopier):
(LayerRendererChromium):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTexIdentity::getShaderString):
(WebCore):
(WebCore::FragmentShaderRGBATexCopy::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(VertexShaderPosTexIdentity):
(WebCore::VertexShaderPosTexIdentity::init):
(WebCore):
(FragmentShaderRGBATexCopy):
- platform/graphics/chromium/TextureCopier.cpp: Added.
(WebCore):
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
- platform/graphics/chromium/TextureCopier.h: Added.
(WebCore):
(TextureCopier):
(WebCore::TextureCopier::~TextureCopier):
(AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::create):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::CCTextureUpdater):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(WebCore):
(CCTextureUpdater):
(WebCore::CCTextureUpdater::copier):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Source/WebKit/chromium:
Add new test for TextureCopier.
- WebKit.gypi:
- tests/Canvas2DLayerChromiumTest.cpp:
- tests/TextureCopierTest.cpp: Added.
- tests/TiledLayerChromiumTest.cpp:
(FakeTextureCopier):
(WTF::FakeTextureCopier::copyTexture):
(WTF):
(WTF::TEST):
- 11:06 AM Changeset in webkit [112285] by
-
- 2 edits in trunk/Source/JavaScriptCore
Compiler warning when JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=82352
Reviewed by Filip Pizlo.
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
- 11:03 AM Changeset in webkit [112284] by
-
- 3 edits in trunk/Source/WebCore
Correct SVG paint functions that are still using IntPoints
https://bugs.webkit.org/show_bug.cgi?id=82343
Reviewed by Eric Seidel.
Two small corrections to SVG paint functions that should use LayoutPoint instead
of IntPoint.
No new tests. No change in behavior.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
- 11:00 AM Changeset in webkit [112283] by
-
- 2 edits in trunk/Source/WebCore
Frame flattening: childframe in FrameView::layout() needs protector.
https://bugs.webkit.org/show_bug.cgi?id=82345
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-27
Reviewed by Kenneth Rohde Christiansen.
RefPtr<FrameView> protector(this) is supposed to protect the current frameview in
FrameView::layout() from being destroyed by recalcStyle().
However, when frame flattening is on and a child frame is re-starting layout from
the topmost parent, the protection is missing and parent's recalcStyle()
can destroy the child frame.
Moving the protector before the layout re-starting is initiated makes the child frame
safe.
No new tests. Unable to create a test case, where this scenario is reproducible.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 10:47 AM Changeset in webkit [112282] by
-
- 3 edits in trunk/Tools
[Qt] Make debug build work on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=82331
Use --no-keep-memory option of ld not to cache the symbol tables of input files in
memory to avoid memory exhaustion during the linking phase for x86-debug builds.
Reviewed by Tor Arne Vestbø.
- qmake/mkspecs/features/unix/default_post.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 10:46 AM Changeset in webkit [112281] by
-
- 8 edits in trunk/Source/WebCore
Construct CSSCharsetRule on CSSOM API access only
https://bugs.webkit.org/show_bug.cgi?id=82332
Reviewed by Andreas Kling.
Charset is just a string. There is usually no need to construct CSSCharsetRule at all.
- Make CSS parser to return encoding string instead of CSSCharsetRule object. This string is used for constructing CSSCharsetRule if it is needed (and nothing else, @charset has no effect after string decoding).
- Remove internal interface for adding and removing rules. It has no clients.
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::ensureCharsetRule):
(WebCore):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::parserSetEncodingFromCharsetRule):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
- css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::ruleVector):
(WebCore::CSSStyleSheet::hasCharsetRule):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
- 10:44 AM Changeset in webkit [112280] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip fast/events/dropzone-005.html on mac-wk1.
It has been failing since its introduction and is skipped for every
port but chromium.
- platform/mac/Skipped:
- 10:41 AM April 2012 Meeting edited by
- (diff)
- 10:38 AM Changeset in webkit [112279] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8
Update the NEWS and version for the impending 1.8.0 release.
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: Update the version.
Source/WebKit/gtk:
- NEWS: Update the news.
- 10:06 AM LayoutUnit edited by
- (diff)
- 10:02 AM Changeset in webkit [112278] by
-
- 6 edits in trunk/Source
Source/WebCore: [chromium] Fix filter context creation to be more conservative.
https://bugs.webkit.org/show_bug.cgi?id=82349
Reviewed by James Robinson.
Covered by webkit_unit_tests, and css3/filters layout tests.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Only request a filter context if the filter lists is non-empty.
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
Add a bool param, so tests can cancel a request for filter contexts.
Source/WebKit/chromium: [chromium] Fix filter context usage in webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=82349
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
Cancel request for filter context after test run.
(WTF::TEST_F):
- tests/CCOcclusionTrackerTest.cpp:
Re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
(WebCore::CCOcclusionTrackerTest::TearDown):
Cancel request for filter context after test run.
- 9:12 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 8:58 AM Changeset in webkit [112277] by
-
- 3 edits in trunk/Source/WebCore
<svg:use> elements in the parser can create elements not marked as created by the parser
https://bugs.webkit.org/show_bug.cgi?id=81985
Reviewed by Adam Barth.
The SVGUseElement was creating its shadow tree immediately upon
demand. This resulted in nodes being created that were not marked as
"createdByParser", even during parsing. As it happens, there is
already code in there to track "createdByParser" in the SVGUseElement,
it was just being ignored all the time. This may even have been
inefficient. Now we delay creating the shadow dom tree until children
are finished, which is the standard time to handle the createdByParser
flag.
I also verified that other SVG classes that derived from core DOM
classes that use the createdByParser flag do correctly pass this flag
on.
No new tests as this is covered by existing tests and does not have new behavior.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):
- xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):
- 8:56 AM Changeset in webkit [112276] by
-
- 7 edits in branches/subpixellayout/Source/WebCore
Shrinking our patch by moving PaintRect::infiniteRect to LayoutRect::infiniteRect, and cleaning up SubframeLoader.
- 8:44 AM Changeset in webkit [112275] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Disable DisallowCType.h usage
https://bugs.webkit.org/show_bug.cgi?id=82211
Patch by Ming Xie <mxie@rim.com> on 2012-03-27
Reviewed by Rob Buis.
Build fix: QNX port does use ctype.h, so we should not
include <wtf/DisallowCType.h> in WebCore/config.h
No new tests - Build Fix
- config.h:
- 8:41 AM Changeset in webkit [112274] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
https://bugs.webkit.org/show_bug.cgi?id=82314
Reviewed by Vsevolod Vlasov.
- http/tests/inspector/compiler-script-mapping.html:
- platform/gtk/Skipped:
- 8:22 AM Changeset in webkit [112273] by
-
- 2 edits1 copy1 move1 add in trunk/Source/WebKit2
Implement WebFrameNetworkingContext for soup in WebKit2
[SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=82081
Reviewed by Martin Robinson.
- GNUmakefile.am: Add new files to compilation
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit::WebFrameNetworkingContext::soupSession): Return the
default SoupSession.
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create): Create a new
WebFrameNetworkingContext().
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
- 8:17 AM Changeset in webkit [112272] by
-
- 2 edits in trunk/Source/WebCore
Change default position attribute of media control panel to relative for Android.
https://bugs.webkit.org/show_bug.cgi?id=82303
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-27
Reviewed by Eric Carlson.
Follow up https://bugs.webkit.org/show_bug.cgi?id=79746 .
- css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
- 8:15 AM Changeset in webkit [112271] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Speed up snapshot parsing.
https://bugs.webkit.org/show_bug.cgi?id=82325
Replacing the iterators with raw nodes/edges access speeds up
some phases phasses up to 10 times, taking down the whole init
time to less than 6 sec.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
- 8:03 AM Changeset in webkit [112270] by
-
- 4 edits2 adds in trunk/Tools
Add png checking to check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=75824
Reviewed by NOBODY Tony Chang.
- Scripts/webkitpy/style/checker.py:
(_all_categories):
(FileType):
(CheckerDispatcher._should_skip_file_path):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):
- Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherDispatchTest.test_none_paths):
- Scripts/webkitpy/style/checkers/png.py: Added.
(PNGChecker):
(PNGChecker.init):
(PNGChecker.check):
(PNGChecker._config_file_path):
- Scripts/webkitpy/style/checkers/png_unittest.py: Added.
(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(MockSCMDetector.propget):
(PNGCheckerTest):
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_init.mock_handle_style_error):
(PNGCheckerTest.test_check):
(PNGCheckerTest.test_check.mock_handle_style_error):
- Scripts/webkitpy/style/patchreader.py:
(PatchReader.check):
- 8:01 AM Changeset in webkit [112269] by
-
- 2 edits in trunk/Source/WebCore
Assertion failure in acid2.
Rubber-stamped by Andreas Kling.
Remove assert added in http://trac.webkit.org/changeset/112258. It seems insertedInto/removedFromDocument
don't always pair.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
- 7:55 AM Changeset in webkit [112268] by
-
- 4 edits in trunk
Web Inspector: simplify heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82338
Source/WebCore:
Simplify constructors of WebInspector.HeapSnapshotArraySlice and
WebInspector.HeapSnapshotEdgesProvider.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice):
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/profiler/heap-snapshot.html:
- 7:51 AM Changeset in webkit [112267] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Tabbed pane should set focus on its contents on tab click.
https://bugs.webkit.org/show_bug.cgi?id=82323
Reviewed by Pavel Feldman.
Otherwise selected tab does not have focus.
Also added tabIndex on tabElements to prevent pasting on closing middle click.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.focus):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
- 7:43 AM Changeset in webkit [112266] by
-
- 7 edits in trunk
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Breakpoint-added and breakpoint-removed events are always related to specific UISourceCode.
See bug 82224 for more details.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._addBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._removeBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
- inspector/front-end/UISourceCode.js:
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- 7:42 AM Changeset in webkit [112265] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=82289
Reviewed by Kenneth Rohde Christiansen.
As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
- UIProcess/WebPageProxy.cpp:
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
- 7:32 AM Changeset in webkit [112264] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry]Cleanup WTF string in platform/network/blackberry
https://bugs.webkit.org/show_bug.cgi?id=82005
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.
No new tests. Just replace WTF::String with String.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):
- 7:30 AM Changeset in webkit [112263] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Enable "number" parameters in the web inspector protocol methods
https://bugs.webkit.org/show_bug.cgi?id=82334
The generated protocol dispatcher does not understand protocol method parameters of type "number"
(mapped to "double" in the native code.)
Reviewed by Vsevolod Vlasov.
- inspector/CodeGeneratorInspector.py:
(RawTypes.Number.get_getter_name):
(RawTypes.Number.get_c_initializer):
(RawTypes.Number.get_js_bind_type):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Number.get_validate_method_params):
- 7:23 AM Changeset in webkit [112262] by
-
- 6 edits in trunk
Web Inspector: Fix missing objects in the dominators view.
https://bugs.webkit.org/show_bug.cgi?id=82194
Due to the nature of dominators tree it is not possible to hide internal
objects there because they may happen to contain user objects that can't
be hidden.
Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
function.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
LayoutTests:
- inspector/profiler/heap-snapshot-expected.txt:
- inspector/profiler/heap-snapshot.html:
- 6:37 AM Changeset in webkit [112261] by
-
- 2 edits in trunk/Tools
Unreviewed. Skip GTK+ unit tests that fail in the bots
- Scripts/run-gtk-tests:
(TestRunner): Add failing tests to the skipped list.
- 6:22 AM Changeset in webkit [112260] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp
Plugins are always positioned at integer boundaries, so the size can be rounded. Correcting unnecessary pixel snapping in SubframeLoader.
- 5:45 AM Changeset in webkit [112259] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix Kling's name.
- 5:40 AM Changeset in webkit [112258] by
-
- 9 edits in trunk/Source/WebCore
Remove Document::mappedElementSheet()
https://bugs.webkit.org/show_bug.cgi?id=82242
Reviewed by Anreas Kling and Nikolas Zimmermann.
The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
the confusing extra stylesheet.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- Add font face rules from registered SVGFontFaceElements.
- Simplify the constructor signature. Stylesheets are part of the document.
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore):
(WebCore::Document::updateBaseURL):
- dom/Document.h:
(WebCore):
(WebCore::Document::documentUserSheets):
(Document):
- Remove mappedElementSheet
- Adapt to the CSSStyleSelector constructor signature changes.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::svgFontFaceElements):
(WebCore):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):
- svg/SVGDocumentExtensions.h:
(WebCore):
(SVGDocumentExtensions):
- Add map for SVGFontFaceElements
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore):
- svg/SVGFontFaceElement.h:
(SVGFontFaceElement):
(WebCore::SVGFontFaceElement::fontFaceRule):
- Switch to updating svgFontFaceElements map.
- Use elementSheet as the parent sheet (nothing is ever added to the elementSheet, it is used for resolving relative URLs only).
- 5:32 AM Changeset in webkit [112257] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
https://bugs.webkit.org/show_bug.cgi?id=82322
Reviewed by Pavel Feldman.
This patch removes tabIndex attribute from the element after editing if it was not present before.
Otherwise tabIndex becomes set unexpectedly after exiting edit mode.
- inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
- 5:22 AM Changeset in webkit [112256] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Tree outline should not start search on key press if it is being edited.
https://bugs.webkit.org/show_bug.cgi?id=82327
Reviewed by Pavel Feldman.
This is needed for snippet renaming support.
- inspector/front-end/treeoutline.js:
(TreeOutline):
(TreeOutline.prototype._treeKeyPress):
- 5:13 AM Changeset in webkit [112255] by
-
- 3 edits in trunk/Source/WebCore
Revert RenderApplet::intrinsicSize to integers
https://bugs.webkit.org/show_bug.cgi?id=82206
Reviewed by Eric Seidel.
Intrinsic sizes originate either outside of WebCore, or from their initial values,
which are always integers. Reverting RenderApplet::intrinsicSize to integers, the
last spot improperly using LayoutUnits
No new tests. No change in behavior.
- rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
- rendering/RenderApplet.h:
(RenderApplet):
- 5:00 AM Changeset in webkit [112254] by
-
- 7 edits in trunk
Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82261
Reviewed by Ryosuke Niwa.
Source/WebCore:
Use longhands declaration from CSSPropertyLonghand in CSSComputedStyleDeclaration to avoid
code duplication.
No new tests : refactoring only, we shouldn't have any behavior difference.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
- css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
- css/CSSPropertyLonghand.cpp:
(WebCore::outlineLonghand):
Re-order to match the spec default order and also remove outline-offset as it is not part
of the shorthand (http://www.w3.org/TR/css3-ui/#outline). Luckily this was cover by a layout test.
LayoutTests:
Update expectation as it was relying on inaccurate order. All other outline related tests
are expecting the same order (e.g. fast/getComputedStyle/getComputedStyle-outline-shorthand) as well
as Opera.
- fast/css/cssText-shorthand-expected.txt:
- fast/css/cssText-shorthand.html:
- 4:57 AM Changeset in webkit [112253] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a perf test which updates the value of an already declared CSS property.
https://bugs.webkit.org/show_bug.cgi?id=82321
Reviewed by Andreas Kling.
This benchmark update CSS existing properties of the style from JS.
- CSS/CSSPropertyUpdateValue.html: Added.
- 4:53 AM Changeset in webkit [112252] by
-
- 2 edits in trunk/Source/WebKit/blackberry
A page containing multiparts with "multipart/x-mixed-replace" should not be cached.
https://bugs.webkit.org/show_bug.cgi?id=82291
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.
If we have a multiPart reponse with multipart/x-mixed-replace,
the current page should not be cached. I use isMultipartPayload()
API which was supposed to be set in NetworkJob to decide to
cache page or not.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::canCachePage):
- 4:40 AM Changeset in webkit [112251] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Editable TextViewer should show cursor when it is focused.
https://bugs.webkit.org/show_bug.cgi?id=82320
Reviewed by Pavel Feldman.
TextViewer now focuses editable inner container unless read-only flag is set.
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.focus):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleElementFocus):
(WebInspector.TextEditorMainPanel.prototype.focus):
- 4:08 AM Changeset in webkit [112250] by
-
- 2 edits in trunk/Tools
Unreviewed. Unskip all GTK+ unit test.
Currently, skipped tests contains the list of unit tests that have
failed in one or more bots. In this moment it's not possible to
skip just the test cases that fail, so the complete unit test is
skipped when a single test case fails. For that reason, we don't
know which test cases are actually failing for every skipped
test. We are planning to land a patch to allow skipping individual
test cases, but first we need to know which test cases are
currently failing in the bots to skip them. So, this patch simply
unskips all unit tests in order to watch the bots and get the list
of test cases failing. Failing tests will be skipped again as soon
as we have the new list of failing test cases.
- Scripts/run-gtk-tests:
(TestRunner): Reset the list of skipped tests.
- 4:03 AM Changeset in webkit [112249] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Unreviewed. Removing change markers from ChangeLog.
- 3:52 AM Changeset in webkit [112248] by
-
- 2 edits in trunk/Source/WebCore
Convert RenderSelectionInfo::rect to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82213
Reviewed by Eric Seidel.
RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to
renderers should be stored in LayoutUnits.
No new tests. No change in behavior.
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::rect):
(RenderSelectionInfo):
- 3:47 AM Changeset in webkit [112247] by
-
- 9 edits in trunk
Enable animVal support for SVGAnimatedRect
https://bugs.webkit.org/show_bug.cgi?id=82317
Reviewed by Zoltan Herczeg.
Source/WebCore:
Enable animVal support for SVGAnimatedRect. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedRectAnimator.
Extended existing tests to cover this.
- svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedRectAnimator::animValWillChange):
(WebCore::SVGAnimatedRectAnimator::animValDidChange):
- svg/SVGAnimatedRect.h:
(SVGAnimatedRectAnimator):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
LayoutTests:
Extend SVGAnimatedRect tests to cover animVal support.
- svg/animations/script-tests/svgrect-animation-1.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/svgrect-animation-2.js:
(sample1):
(sample2):
(sample3):
- svg/animations/svgrect-animation-1-expected.txt:
- svg/animations/svgrect-animation-2-expected.txt:
- 3:44 AM Changeset in webkit [112246] by
-
- 7 edits in trunk/LayoutTests
2012-03-27 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Use shouldBe() instead of shouldBeCloseEnough() when testing the baseVal in the SVGAngle tests.
It doesn't get animated, and thus isn't timing dependant. All other tests are correct.
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample1): (sample2): (sample3):
- 3:43 AM Changeset in webkit [112245] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r112201.
http://trac.webkit.org/changeset/112201
https://bugs.webkit.org/show_bug.cgi?id=82302
Breaks chromium's WebPageSerializerTest.HTMLNodes test
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-27
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::error):
(WebCore):
- loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
- loader/cache/CachedFont.cpp:
(WebCore):
(WebCore::CachedFont::error):
- loader/cache/CachedFont.h:
(CachedFont):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::error):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::error):
(WebCore):
- loader/cache/CachedScript.h:
(CachedScript):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::error):
(WebCore):
- loader/cache/CachedXSLStyleSheet.h:
(CachedXSLStyleSheet):
- 3:40 AM Changeset in webkit [112244] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip accidentally unskipped tests again.
- platform/qt/Skipped:
- 3:35 AM Changeset in webkit [112243] by
-
- 3 edits in trunk/Source/WebCore
LayoutRepainter: Remove unused constructor parameter and update to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82185
Reviewed by Eric Seidel.
Removing an optional parameter for old bounds in LayoutRepainter's constructor that
is no longer used. The old bounds are instead always gleaned from the renderer's
clippedOverflowRectForRepaint.
The renderer's bounds and outline rect also are stored in LayoutUnits to properly
detect sub-pixel changes during layout. Eventually, we'll pixel snap these values
when telling the embedder to invalidate. Adding a comment to that effect.
No new tests. No change in behavior.
- rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
- rendering/LayoutRepainter.h:
(LayoutRepainter):
- 3:29 AM Changeset in webkit [112242] by
-
- 1 edit1 delete in trunk/LayoutTests
Not reviewed: chromium baselines updated.
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.
- 3:23 AM Changeset in webkit [112241] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r112229.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/qt/fast/table/quote-text-around-iframe-expected.png:
- platform/qt/fast/table/quote-text-around-iframe-expected.txt:
- 3:22 AM Changeset in webkit [112240] by
-
- 5 edits3 adds in trunk
Enable animVal support for SVGAnimatedString
https://bugs.webkit.org/show_bug.cgi?id=82316
Reviewed by Zoltan Herczeg.
Source/WebCore:
Enable animVal support for SVGAnimatedString. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedStringAnimator.
Test: svg/animations/svgstring-animation-1.html
- svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedStringAnimator::animValWillChange):
(WebCore::SVGAnimatedStringAnimator::animValDidChange):
- svg/SVGAnimatedString.h:
(SVGAnimatedStringAnimator):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
LayoutTests:
Add new test covering animVal+SVGAnimatedString.
- svg/animations/script-tests/svgstring-animation-1.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/svgstring-animation-1-expected.txt: Added.
- svg/animations/svgstring-animation-1.html: Added.
- 3:18 AM Changeset in webkit [112239] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r112229.
- platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
- 3:08 AM Changeset in webkit [112238] by
-
- 3 edits in trunk/Source/WebCore
Update usage of LayoutUnits in RenderListMarker
https://bugs.webkit.org/show_bug.cgi?id=81921
Reviewed by Eric Seidel.
Implementing proper pixel snapping in list marker painting, and correcting usage of integers
for local coordinates/margins that should be sub-pixel.
No new tests. No change in behavior.
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect): Changed to LayoutUnits since this represents
a rect in local coordinates.
(WebCore::RenderListMarker::paint): Doing proper pixel snapping, and using integers for
results from text measurement.
(WebCore::RenderListMarker::computePreferredLogicalWidths): Using integers for results
from text measurement.
(WebCore::RenderListMarker::updateMargins): Fixing to be LayoutUnits.
- rendering/RenderListMarker.h:
(RenderListMarker):
- 3:06 AM Changeset in webkit [112237] by
-
- 7 edits in trunk/Source/WebCore
Revert linesBoundingBox to integers
https://bugs.webkit.org/show_bug.cgi?id=82182
Reviewed by Eric Seidel.
LayoutRects are intended to be pixel snapped to determine the ultimate screen
coordinates, but the Inline Box tree is laid out using floats, and pixel snapping
the resulting box from linesBoundingBox would produce a potentially incorrect
rectangle. Keeping this using enclosingIntRect retains the previous accuracy and
prevents misuse.
No new tests. No change in behavior.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::linesBoundingBox):
- rendering/svg/RenderSVGInlineText.h:
(RenderSVGInlineText):
- 2:59 AM April 2012 Meeting edited by
- (diff)
- 2:55 AM Changeset in webkit [112236] by
-
- 10 edits in trunk
Web Inspector: store UIBreakpoints on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82214
Source/WebCore:
This change will allow us to make breakpoint-added and breakpoint-removed events a part of UISourceCode interface.
See bug 82224 for more details.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.debuggerReset):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.breakpoints):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
- inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.UISourceCode.prototype.breakpoints):
- inspector/front-end/inspector.html:
LayoutTests:
Reviewed by Vsevolod Vlasov.
- inspector/debugger/breakpoint-manager.html:
- 2:48 AM Changeset in webkit [112235] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Fix crash with fling with tracing enabled
https://bugs.webkit.org/show_bug.cgi?id=82306
The TRACE_EVENT_START instrumentation was deferencing a PassOwnPtr
after it had been passed into another OwnPtr. This caused frequent
crashes when tracing was enabled.
Reviewed by Adam Barth.
- platform/ActivePlatformGestureAnimation.cpp:
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
- platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
- 2:42 AM Changeset in webkit [112234] by
-
- 10 edits in trunk/Source
[SOUP] Implement missing methods in CookieJarSoup
https://bugs.webkit.org/show_bug.cgi?id=82082
Reviewed by Martin Robinson.
Source/WebCore:
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::defaultCookieJar): Return a global GRefPtr to store the
default cookie jar.
(WebCore::soupCookieJar): Return the current cookie jar or create
a new one.
(WebCore::setSoupCookieJar): Set the current cookie jar.
(WebCore::setCookies): Fix coding style.
(WebCore::cookiesForDocument): Helper function to get the list of
cookies as a string.
(WebCore::cookies): Use cookiesForDocument().
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::getRawCookies): Get the list of cookies for the given
document and url.
(WebCore::deleteCookie): Delete the given cookie.
(WebCore::getHostnamesWithCookies): Use GOwnPtr.
(WebCore::deleteCookiesForHostname): Use GOwnPtr and
soup_cookie_domain_matches() instead of comparing the domain
directly with the given hostname.
(WebCore::deleteAllCookies): Use GOwnPtr.
- platform/network/soup/CookieJarSoup.h:
- platform/network/soup/GOwnPtrSoup.cpp:
(WTF::SoupCookie): Add GOwnPtr template for SoupCookie.
- platform/network/soup/GOwnPtrSoup.h:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized): Use soupCookieJar() instead
of defaultCookieJar().
Source/WebKit/efl:
- ewk/ewk_cookies.cpp:
(ewk_cookies_clear): Use soupCookieJar() instead of
defaultCookieJar().
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.
Source/WebKit2:
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Use
soupCookieJar() instead of defaultCookieJar().
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Ditto.
- 2:34 AM Changeset in webkit [112233] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskipped 5 passing tests.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-03-27
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 2:32 AM Changeset in webkit [112232] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a failing test.
- platform/qt-5.0-wk2/Skipped:
- 2:29 AM Changeset in webkit [112231] by
-
- 7 edits in trunk
Enable animVal support for SVGAnimatedBoolean
https://bugs.webkit.org/show_bug.cgi?id=82311
Reviewed by Antti Koivisto.
Source/WebCore:
Enable animVal support for SVGAnimatedBoolean. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedBooleanAnimator.
Extended existing tests to cover this.
- svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedBooleanAnimator::animValWillChange):
(WebCore::SVGAnimatedBooleanAnimator::animValDidChange):
- svg/SVGAnimatedBoolean.h:
(SVGAnimatedBooleanAnimator):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
LayoutTests:
Extend SVGAnimatedBoolean tests to cover animVal support.
- svg/animations/script-tests/svgboolean-animation-1.js:
(sample1):
(sample2):
(sample3):
- svg/animations/svgboolean-animation-1-expected.txt:
- 2:27 AM Changeset in webkit [112230] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip an inspector test failing on 64-bit Debug GTK bot.
- platform/gtk/Skipped:
- 2:24 AM Changeset in webkit [112229] by
-
- 16 edits5 adds in trunk
<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
https://bugs.webkit.org/show_bug.cgi?id=81631
Reviewed by Antti Koivisto.
Source/WebCore:
Final cleanup of RenderReplaced after the intrinsic size negotiation patch series from some weeks/months ago.
Stop tracking whether a RenderReplaced has an intrinsic size or not with an extra-bool, instead assume each
RenderReplaced derived class has an intrinsic size. If not, the class should override
computeIntrinsicRatioInformation() for any custom logic - currently only done by RenderImage.
Remove all logic depending on m_hasIntrinsicSize from computeReplacedLogicalWidth/Height, which was used
to support different sizing models depending on if the replaced element is a RenderImage or a RenderPart.
Unify all of this in computeIntrinsicRatioInformation right in RenderReplaced. This allows to remove
a hack from RenderImage::computeReplacedLogicalWidth(), which forced the synchroniziation of the intrinsicSize()
before calling the base classes RenderReplaced::computeReplacedLogicalWidth().
Now RenderImage just overrides the layout() method, calls RenderReplaced::layout() and then sets the container
size of the image resources to [contentWidth(), contentHeight()] - reflecting the actual result of the layout.
Furthermore this now allows us to unify CachedImage::imageSizeForRenderer() again for both SVG and non-SVG images.
Propagating the right container size to the image resource fixes the actual bug, that the SVGImage got pixellated.
Adding new tests covering percentage width or height set on an <img> embedding an external SVG, no more pixelation.
Tests: svg/as-image/img-relative-height-expected.html
svg/as-image/img-relative-height.html
svg/as-image/img-relative-width-expected.html
svg/as-image/img-relative-width.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::layout):
(WebCore::RenderImage::computeIntrinsicRatioInformation):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
(WebCore::rendererHasAspectRatio):
(WebCore):
(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::intrinsicSize):
(RenderReplaced):
(WebCore::RenderReplaced::setIntrinsicSize):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
- svg/graphics/SVGImage.h:
(WebCore::SVGImage::usesContainerSize):
LayoutTests:
Add new tests covering setting only one of width/height to a percentage when embedding SVGs into <img>s.
- platform/chromium/test_expectations.txt: Update expectations.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Update changed result - slight rounding difference.
- platform/mac/fast/table/quote-text-around-iframe-expected.png: Update changed result, now the default intrinsic size respects scaling.
- platform/mac/fast/table/quote-text-around-iframe-expected.txt: Ditto.
- svg/as-image/img-relative-height-expected.html: Added.
- svg/as-image/img-relative-height.html: Added.
- svg/as-image/img-relative-width-expected.html: Added.
- svg/as-image/img-relative-width.html: Added.
- svg/as-image/resources/island.svg: Added.
- svg/as-image/svg-non-integer-scaled-image-expected.png:
- svg/as-image/svg-non-integer-scaled-image-expected.txt:
- 1:58 AM Changeset in webkit [112228] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip two new xmlhttprequest failures on GTK.
- platform/gtk/Skipped:
- 1:56 AM Changeset in webkit [112227] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Add method webkit_web_resource_get_data() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79667
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebResource.cpp:
(webkitWebResourceCreate): Add isMainResource parameter indication
whether the resource is the main one of the frame.
(resourceDataCallback): C API callback called when resource data
is available.
(webkit_web_resource_get_data): Asynchronously get the raw data of
the resource.
(webkit_web_resource_get_data_finish): Finish asynchronous
operation started by webkit_web_resource_get_data().
- UIProcess/API/gtk/WebKitWebResource.h:
- UIProcess/API/gtk/WebKitWebResourcePrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted): Pass isMainResource parameter
to webkitWebResourceCreate().
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceGetData):
(serverCallback):
(beforeAll):
- 1:56 AM Changeset in webkit [112226] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a new asserting test.
- platform/qt/Skipped:
- 1:34 AM Changeset in webkit [112225] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: HeapSnapshot: speed-up distanceToWindow calculation.
https://bugs.webkit.org/show_bug.cgi?id=82305
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._bfs):
- 1:30 AM Changeset in webkit [112224] by
-
- 28 edits2 copies3 adds in trunk
SVGAnimatedType should support SVGAnimatedIntegerOptionalInteger animation
https://bugs.webkit.org/show_bug.cgi?id=67563
Reviewed by Dirk Schulze.
Source/WebCore:
Add SVGAnimatedIntegerOptionalInteger type handling animation of pair<int, int> objects
as used for the SVG properties 'filterRes' and 'order'. They're currently animated as
SVGAnimatedNumberOptionalNumber - but that won't work for animVal support. Fix that
and enable animVal support for SVGAnimatedInteger(OptionalInteger).
Use 'int' as datatype for SVGAnimatedInteger instead of 'long' for consistency, and
move SVGAnimatedEnumeration from 'int' to 'unsigned short', to make them distinguishable.
Test: svg/animations/svginteger-animation-2.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimatedEnumeration.h:
(WebCore):
- svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerAnimator::animValDidChange):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedInteger.h:
(WebCore):
(SVGAnimatedIntegerAnimator):
- svg/SVGAnimatedIntegerOptionalInteger.cpp: Added.
(WebCore):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::SVGAnimatedIntegerOptionalIntegerAnimator):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::constructFromString):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateDistance):
- svg/SVGAnimatedIntegerOptionalInteger.h: Copied from Source/WebCore/svg/SVGAnimatedInteger.h.
(WebCore):
(SVGAnimatedIntegerOptionalIntegerAnimator):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::~SVGAnimatedIntegerOptionalIntegerAnimator):
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createIntegerOptionalInteger):
(WebCore):
(WebCore::SVGAnimatedType::integerOptionalInteger):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
- svg/SVGAnimatedType.h:
(SVGAnimatedType):
- svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
- svg/SVGFilterElement.h:
(SVGFilterElement):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getPathSegAtLength):
- svg/SVGPathElement.h:
(SVGPathElement):
- svg/SVGPathParserFactory.cpp:
(WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
- svg/SVGPathParserFactory.h:
(SVGPathParserFactory):
- svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::pathSegmentIndex):
- svg/SVGPathTraversalStateBuilder.h:
(SVGPathTraversalStateBuilder):
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):
- svg/properties/SVGPropertyInfo.h:
- svg/properties/SVGPropertyTraits.h:
LayoutTests:
Extend SVGAnimatedInteger tests to cover animVal support.
- svg/animations/script-tests/svginteger-animation-1.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/svginteger-animation-2.js: Copied from LayoutTests/svg/animations/script-tests/svginteger-animation-1.js.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/svginteger-animation-1-expected.txt:
- svg/animations/svginteger-animation-2-expected.txt: Added.
- svg/animations/svginteger-animation-2.html: Added.
- 1:22 AM Changeset in webkit [112223] by
-
- 17 edits in trunk
Enable animVal support for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=82144
Reviewed by Rob Buis.
Source/WebCore:
Enable animVal support for SVGAnimatedAngle. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedAngleAnimator.
Extended existing tests to cover this.
- svg/SVGAnimatedAngle.cpp:
(WebCore::sharedSVGAngle):
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateDistance):
- svg/SVGAnimatedAngle.h:
(SVGAnimatedAngleAnimator):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
LayoutTests:
Update tests after enabling animVal support for SVGAnimatedAngle.
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample2):
(sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample2):
(sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample2):
(sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample2):
(sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample2):
(sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample2):
(sample3):
- svg/animations/svgangle-animation-deg-to-grad-expected.txt:
- svg/animations/svgangle-animation-deg-to-rad-expected.txt:
- svg/animations/svgangle-animation-grad-to-deg-expected.txt:
- svg/animations/svgangle-animation-grad-to-rad-expected.txt:
- svg/animations/svgangle-animation-rad-to-deg-expected.txt:
- svg/animations/svgangle-animation-rad-to-grad-expected.txt:
- 1:18 AM Changeset in webkit [112222] by
-
- 6 edits in trunk
Web Inspector: remove remains of path finder in heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82304
Removed remainders of heap path finder as this code is not used anymore.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/HeapSnapshot.js:
- inspector/front-end/HeapSnapshotProxy.js:
LayoutTests:
- inspector/profiler/heap-snapshot-expected.txt:
- inspector/profiler/heap-snapshot.html:
- 12:59 AM Changeset in webkit [112221] by
-
- 13 edits6 adds in trunk/Source/WebKit2
[GTK] Add resources API to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=79477
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitResourceLoadClient.cpp: Added.
(didInitiateLoadForResource): Call
webkitWebViewResourceLoadStarted() so that view will create the
resource and emit WebKitWebView::resource-load-started.
(didSendRequestForResource): Call webkitWebResourceSentRequest()
with the given request and response.
(didReceiveResponseForResource): Call
webkitWebResourceSetResponse() with the given response.
(didReceiveContentLengthForResource): Call
webkitWebResourceNotifyProgress().
(didFinishLoadForResource): Call webkitWebResourceFinished().
(didFailLoadForResource): Create a GError for the given WKError
and call webkitWebResourceFailed().
(attachResourceLoadClientToView): Add callbacks for the
WKPageResourceLoadClient.
- UIProcess/API/gtk/WebKitResourceLoadClient.h: Added.
- UIProcess/API/gtk/WebKitWebResource.cpp: Added.
(webkitWebResourceGetProperty):
(webkit_web_resource_init):
(webkit_web_resource_class_init):
(webkitWebResourceUpdateURI): Update the active URI every time a
new request is sent to the server.
(webkitWebResourceCreate): Create a WebResource for the given
frame.
(webkitWebResourceSentRequest): Update uri and emit
WebKitWebResource::sent-request.
(webkitWebResourceSetResponse): Set the response property.
(webkitWebResourceNotifyProgress): Emit
WebKitWebResource::received-data.
(webkitWebResourceFinished): Emit WebKitWebResource::finished.
(webkitWebResourceFailed): Emit WebKitWebResource::failed and then
WebKitWebResource::finished.
(webkit_web_resource_get_uri): Return the currentr active URI.
(webkit_web_resource_get_response): Return the response received
from the server.
- UIProcess/API/gtk/WebKitWebResource.h: Added.
- UIProcess/API/gtk/WebKitWebResourcePrivate.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach the resource load client to the
view.
(webkit_web_view_class_init): Add
WebKitWebView::resource-load-started signal.
(webkitWebViewLoadChanged): Clear loading resources map when a new
load starts and loaded resources map when the new load has been
committed.
(webkitWebViewResourceLoadStarted): Create a resource for the
given identifier, add it to the loading resources map and emit
WebKitWebView::resource-load-started signal.
(webkitWebViewGetLoadingWebResource): Return the resource that is
being loaded corresponding to the given identifier.
(webkitWebViewRemoveLoadingWebResource): Remove the resouurce
corresponfing to the given identifier from the loading resources
map.
(webkitWebViewResourceLoadFinished): Move the resource from the
loading resources map to the loaded resources map.
(webkit_web_view_get_main_resource): Return the main resource.
(webkit_web_view_get_subresources): Return the list of
subresources.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitWebResource.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_web_resource_get_type.
- UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for resources.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile): Use getWebKit1TestResoucesDir() from Test.
(testDownloadLocalFileError): Ditto.
(serverCallback): Ditto.
- UIProcess/API/gtk/tests/TestMain.h:
(Test::getWebKit1TestResoucesDir): Moed from TestDownloads so that
it can be used by other tests.
(Test): Add information about leaked objects.
- UIProcess/API/gtk/tests/TestResources.cpp: Added.
(testWebViewResources):
(testWebResourceLoading):
(testWebResourceResponse):
(testWebResourceActiveURI):
(addCacheHTTPHeadersToResponse):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h: Include WebKitWebResource.h
- UIProcess/API/gtk/webkit2marshal.list:
- 12:57 AM Changeset in webkit [112220] by
-
- 2 edits in trunk/Source/WebCore
Reverted r112214, since it was not the right fix for the build.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
- 12:54 AM Changeset in webkit [112219] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline.
- platform/gtk/editing/inserting/before-after-input-element-expected.txt:
- platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:
- 12:48 AM Changeset in webkit [112218] by
-
- 5 edits in trunk/Source/WebCore
[V8][Performance] Optimize createTextNode(), createElement(), cloneNode(), etc
https://bugs.webkit.org/show_bug.cgi?id=82201
Reviewed by Adam Barth.
This patch improves performance of createTextNode() by 13%, createElement() by 14%,
and cloneNode() by 16%. Similar performance improvement will be observed in
DOM methods that create a new object every time.
Performance test: https://bugs.webkit.org/attachment.cgi?id=133799
The performance test results are as follows. Since the performance of V8's GC is
really unstable, the average of measured times makes no sense in Chromium.
Instead, let us focus on the median. I believe that this performance
improvement has impact on Dromaeo, but we cannot observe the improvement
due to the unsteadiness of V8's GC, as shown below.
Chromium/V8/Linux (without the patch):
createTextNode : median=277ms (mean=460.88ms, min=270ms, max=3381ms)
createElement : median=379ms (mean=637.52ms, min=372ms, max=3022ms)
cloneNode : median=369ms (mean=581.72ms, min=363ms, max=3050ms)
Dromaeo/dom-modify/createElement: 439.17runs/s +-31.60% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 287.71runs/s +-28.39% (<--- pretty noisy)
Dromaeo/dom-modify/cloneNode: 174.62runs/s +-25.68% (<--- pretty noisy)
Chromium/V8/Linux (with the patch):
createTextNode : median=240ms (mean=411.12ms, min=237ms, max=2965ms)
createElement : median=325ms (mean=585.30ms, min=317ms, max=2984ms)
cloneNode : median=310ms (mean=522.48ms, min=302ms, max=2988ms)
Dromaeo/dom-modify/createElement: 507.15runs/s +-36.00% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 251.01runs/s +-6.57%
Dromaeo/dom-modify/cloneNode: 177.85runs/s +-28.74% (<--- pretty noisy)
Chromium/V8/Mac (without the patch):
createTextNode : median=317ms (mean=439.08ms, min=303ms, max=3126ms)
createElement : median=403ms (mean=695.70ms, min=398ms, max=5615ms)
cloneNode : median=384ms (mean=577.96ms, min=372ms, max=5313ms)
Dromaeo/dom-modify/createElement: 493.89runs/s +-28.32% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 279.66runs/s +-1.91%
Dromaeo/dom-modify/cloneNode: 173.06runs/s +-24.41% (<--- pretty noisy)
Chromium/V8/Mac (with the patch):
createTextNode : median=277ms (mean=460.88ms, min=270ms, max=3381ms)
createElement : median=379ms (mean=637.52ms, min=372ms, max=3022ms)
cloneNode : median=369ms (mean=581.72ms, min=363ms, max=3050ms)
Dromaeo/dom-modify/createElement: 510.47runs/s +-28.13% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 215.80runs/s +-20.99% (<--- pretty noisy)
Dromaeo/dom-modify/cloneNode: 174.41runs/s +-24.85% (<--- pretty noisy)
Safari/JavaScriptCore/Mac:
createTextNode : median=142ms (mean=141.04ms, min=110ms, max=168ms)
createElement : median=234ms (mean=245.74ms, min=219ms, max=305ms)
cloneNode : median=210ms (mean=213.36ms, min=204ms, max=284ms)
Dromaeo/dom-modify/createElement: 822.49runs/s +-1.69%
Dromaeo/dom-modify/createTextNode: 735.57runs/s +-0.91%
Dromaeo/dom-modify/cloneNode: 135.20runs/s +-4.13%
This patch makes the following two optimizations:
[1] If the currently running context is equal to the context that we are about to enter,
we do not call context->Enter().
[2] We do not create a Local handle of the context until we really need to enter the context.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::persistentContext):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Updated run-bindings-tests results.
- 12:38 AM Changeset in webkit [112217] by
-
- 6 edits3 adds2 deletes in trunk
cross-origin XMLHttpRequest doesn't work with redirect
https://bugs.webkit.org/show_bug.cgi?id=57600
Reviewed by Adam Barth.
Source/WebCore:
Changes DocumentThreadableLoader to follow the CORS redirect steps when
asynchronously loading a cross origin request with access control. Synchronous
loads should not be affected. Also adds methods to ResourceRequestBase to
clear special request headers that aren't allowed when using access control.
Follows the CORS spec as described in the Latest Editor Draft at:
http://www.w3.org/TR/cors/
Test: http/tests/xmlhttprequest/access-control-and-redirects-async.html
- loader/DocumentThreadableLoader.cpp:
- loader/DocumentThreadableLoader.h:
- platform/network/ResourceRequestBase.cpp:
- platform/network/ResourceRequestBase.h:
LayoutTests:
Adds tests to verify that an asynchronous XHR load that receives a redirect
response follows the CORS redirect steps.
Follows the CORS spec as described in the Latest Editor Draft at:
http://www.w3.org/TR/cors/
- http/tests/security/resources/cors-redirect.php: Removed.
- http/tests/security/xhr-cors-redirect.html: Removed.
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-and-redirects-async.html: Added.
- http/tests/xmlhttprequest/resources/redirect-cors.php: Added.
- 12:35 AM Changeset in webkit [112216] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, GTK gardening after r112112.
- platform/gtk/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
- 12:21 AM Changeset in webkit [112215] by
-
- 8 edits in trunk/Source/WebCore
ImageLoader::m_firedLoadEvent is a confusing name
https://bugs.webkit.org/show_bug.cgi?id=82283
Reviewed by Kentaro Hara.
This patch renames m_firedLoadEvent (and friends) to
m_hasPendingLoadEvent (and negates the value). That name more
accurately reflects the semantics of this piece of state. For example,
we now initialize m_hasPendingLoadEvent to false, which makes sense as
there is no pending load event, whereas before we initialized
m_firedLoadEvent to true, which made less sense since we hadn't yet
actually fired the load event.
- bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attach):
- html/HTMLImageElement.h:
(HTMLImageElement):
(WebCore::HTMLImageElement::hasPendingLoadEvent):
(WebCore::HTMLImageElement::hasPendingActivity):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::attach):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
- loader/ImageLoader.h:
(WebCore::ImageLoader::hasPendingBeforeLoadEvent):
(WebCore::ImageLoader::hasPendingLoadEvent):
(ImageLoader):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::haveLoadedRequiredResources):
- 12:17 AM Changeset in webkit [112214] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix 32-bit builds.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
- 12:05 AM Changeset in webkit [112213] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Not reviewed: fixing Emil's rebaselined of of textfield-overflow for chromium.
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
- platform/chromium-mac/fast/forms/textfield-overflow-expected.txt: Removed.
Mar 26, 2012:
- 11:56 PM Changeset in webkit [112212] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 11:39 PM Changeset in webkit [112211] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 11:36 PM Changeset in webkit [112210] by
-
- 36 edits in trunk/LayoutTests
[EFL] More gardening, update some fast/replaced expectations.
- platform/efl/fast/replaced/001-expected.png:
- platform/efl/fast/replaced/002-expected.png:
- platform/efl/fast/replaced/003-expected.png:
- platform/efl/fast/replaced/004-expected.png:
- platform/efl/fast/replaced/005-expected.png:
- platform/efl/fast/replaced/007-expected.png:
- platform/efl/fast/replaced/absolute-image-sizing-expected.png:
- platform/efl/fast/replaced/absolute-position-percentage-height-expected.png:
- platform/efl/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/efl/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/efl/fast/replaced/applet-disabled-positioned-expected.png:
- platform/efl/fast/replaced/applet-rendering-java-disabled-expected.png:
- platform/efl/fast/replaced/border-radius-clip-expected.png:
- platform/efl/fast/replaced/image-resize-width-expected.png:
- platform/efl/fast/replaced/image-sizing-expected.png:
- platform/efl/fast/replaced/image-solid-color-with-alpha-expected.png:
- platform/efl/fast/replaced/inline-box-wrapper-handover-expected.png:
- platform/efl/fast/replaced/max-width-percent-expected.png:
- platform/efl/fast/replaced/object-align-hspace-vspace-expected.png:
- platform/efl/fast/replaced/outline-replaced-elements-expected.png:
- platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
- platform/efl/fast/replaced/replaced-breaking-expected.png:
- platform/efl/fast/replaced/replaced-breaking-expected.txt:
- platform/efl/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/efl/fast/replaced/selection-rect-in-table-cell-expected.png:
- platform/efl/fast/replaced/selection-rect-transform-expected.png:
- platform/efl/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/efl/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/efl/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/efl/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/efl/fast/replaced/width100percent-button-expected.png:
- platform/efl/fast/replaced/width100percent-image-expected.png:
- platform/efl/fast/replaced/width100percent-textarea-expected.png:
- platform/efl/fast/replaced/width100percent-textfield-expected.png:
- 11:23 PM Changeset in webkit [112209] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium test expectations lint.
- platform/chromium/test_expectations.txt:
- 11:06 PM Changeset in webkit [112208] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: marking fast/events/platform-wheelevent-* as flaky on
Chromium Snow Leopard.
- platform/chromium/test_expectations.txt:
- 10:32 PM Changeset in webkit [112207] by
-
- 14 edits in trunk/Source/WebCore
Unreviewed, rolling out r112199.
http://trac.webkit.org/changeset/112199
https://bugs.webkit.org/show_bug.cgi?id=82295
Breaks Chromium Win compilation (Requested by pfeldman on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-26
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore):
- bindings/v8/V8DOMWrapper.h:
(WebCore):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
- 10:09 PM Changeset in webkit [112206] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
https://bugs.webkit.org/show_bug.cgi?id=82285
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):
- 9:41 PM Changeset in webkit [112205] by
-
- 4 edits2 deletes in trunk/Source/WebKit/chromium
[chromium] Remove WebMediaElement from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=82277
Reviewed by James Robinson.
This was added in r63859 but is no longer used by anyone.
- WebKit.gyp:
- public/WebMediaElement.h: Removed.
- src/WebMediaElement.cpp: Removed.
- 9:25 PM Changeset in webkit [112204] by
-
- 1 edit2 moves in trunk/LayoutTests
Fix flaky test fast/eventsource/eventsource-url-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=82257
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-26
Reviewed by Ryosuke Niwa.
The test used http://localhost, chosen as a semi-random url, but since
it doesn't return a text/event-stream mime-type sometimes a console
warning would appear. Moved the test to the http folder and changed it
to use a resource with the correct mime-type.
- http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
- http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.
- 8:58 PM Changeset in webkit [112203] by
-
- 3 edits in trunk/Source/WebCore
Build system prep work for upstreaming iOS changes
<http://webkit.org/b/82267>
Reviewed by Mark Rowe.
- DerivedSources.make: Move 'bison' into a variable and use
xcrun to find it on Mac OS X.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor): Add local @args variable. On iOS, the
compiler needs additional "-isysroot $(SDKROOT)" arguments when
invoked, so it's easier to add them to an array, especially if
$SDKROOT contains a space in the path. Remove now-redundant
$gccLocation variable.
- 8:50 PM Changeset in webkit [112202] by
-
- 124 edits119 copies3 adds in trunk/LayoutTests
Extract logic of indexeddb html layout tests into js files that can
be run from either a worker or a window.
The two changed -expected.txt files are just for line numbers in JS
error messages.
Skipped were:
- transaction-abort-with-js-recursion.html
- transaction-abort-with-js-recursion-cross-frame.html
- noblobs.html
- structured-clone.html
- tutorial.html
The first four simulate mouse events and the last isn't really a test.
structured-clone.html will be refactored for worker compatibility in a
future patch.
https://bugs.webkit.org/show_bug.cgi?id=81440
Reviewed by Tony Chang.
- storage/indexeddb/constants.html:
- storage/indexeddb/create-and-remove-object-store.html:
- storage/indexeddb/create-object-store-options.html:
... every html file in storage/indexeddb except the ones listed above
- storage/indexeddb/exception-in-event-aborts-expected.txt:
line number in javascript error message changed
- storage/indexeddb/version-change-abort-expected.txt:
line number in javascript error message changed
- 8:50 PM Changeset in webkit [112201] by
-
- 11 edits in trunk/Source/WebCore
Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161
Reviewed by Alexey Proskuryakov.
No new tests, refactor only.
- loader/cache/CachedCSSStyleSheet.cpp:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedResource.h: Make checkNotify()
virtual, so the right checkNotify() gets called in error().
- loader/cache/CachedScript.cpp:
- loader/cache/CachedScript.h:
- loader/cache/CachedXSLStyleSheet.cpp:
- loader/cache/CachedXSLStyleSheet.h:
- 8:16 PM Changeset in webkit [112200] by
-
- 7 edits2 adds in trunk
Assert failure from capitalized RenderTextFragment
https://bugs.webkit.org/show_bug.cgi?id=82096
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-26
Reviewed by Ryosuke Niwa.
Source/WebCore:
The cause of this bug was the call to RenderTextFragment::setTextInternal
resulting from a style change from RenderObject::addChild. The idea here
is to better separate the code path for transforming existing text from
the code path for replacing the underlying text of a node. For
RenderTextFragment this has to be clear because only in the latter case
does the first-letter get reset.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Added call to transformText
- rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange): Added call to transformText
(WebCore::RenderText::transformText): Added
- rendering/RenderText.h:
(WebCore::RenderText::setText): Changed to virtual so RenderTextFragment can override
(WebCore::RenderText::transformText): Added
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange): Removed references to
m_allowFragmentReset which was the previous approach to separating the
code paths
(WebCore::RenderTextFragment::setTextInternal): Deleted
(WebCore::RenderTextFragment::setText): Added with most of logic that was
previously in setTextInternal
(WebCore::RenderTextFragment::transformText): Added
- rendering/RenderTextFragment.h:
(WebCore::RenderTextFragment::setText): Added
(WebCore::RenderTextFragment::transformText): Added
(WebCore::RenderTextFragment::setTextInternal): Deleted
LayoutTests:
Test that exercises failure condition in bug 82096.
- fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Added
- fast/css/first-letter-capitalized-edit-select-crash.html: Added
- 7:58 PM Changeset in webkit [112199] by
-
- 14 edits in trunk/Source/WebCore
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256
Reviewed by Adam Barth.
This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).
Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
- bindings/v8/V8DOMWrapper.h:
(WebCore): Forward decls.
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.
- 7:45 PM Changeset in webkit [112198] by
-
- 21 edits in trunk/Source
Fix typo in method name - WebCore::miminumValueForLength should be WebCore::minimumValueForLength
https://bugs.webkit.org/show_bug.cgi?id=82254
Reviewed by Benjamin Poulain.
Source/WebCore:
No new tests because no functional changes.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/LengthFunctions.cpp:
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
- css/LengthFunctions.h:
(WebCore):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderInline.cpp:
(WebCore::computeMargin):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
- rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderText.h:
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
- rendering/style/RenderStyle.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
- 7:42 PM Changeset in webkit [112197] by
-
- 3 edits2 adds in trunk
Triggers assertion if dragging from outside of <meter> in a shadow tree to inside of it.
https://bugs.webkit.org/show_bug.cgi?id=82177
Reviewed by Dimitri Glazkov.
Source/WebCore:
VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries has moved the start position or
the end position to the invalid position, i.e. position after (before) the non-existing node.
This patch fixes the problem, and adds assertion that the selection does not cross shadow boundaries.
Test: fast/dom/shadow/drag-to-meter-in-shadow-crash.html
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
LayoutTests:
- fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt: Added.
- fast/dom/shadow/drag-to-meter-in-shadow-crash.html: Added.
- 7:41 PM Changeset in webkit [112196] by
-
- 11 edits in trunk
Enable layout testing of the scroll animator.
https://bugs.webkit.org/show_bug.cgi?id=81858
Add a call to the InternalSettings that layout tests can use to
turn on scroll animation. Enable animation updates for the
Chromium platform DRT when scroll animation has been turned on in
a test. This should be a no-op for all current layout tests.
Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-26
Reviewed by James Robinson.
Source/WebCore:
No new tests. Layout test results should be unchanged.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore):
(WebCore::InternalSettings::scrollAnimatorEnabled):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::scrollAnimatorEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::serviceAnimation):
(WebViewHost::scheduleAnimation):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 7:29 PM Changeset in webkit [112195] by
-
- 10 edits1 copy7 adds in trunk
[Qt][WK2] Support multi-file upload
https://bugs.webkit.org/show_bug.cgi?id=81589
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.
Source/WebKit2:
Added 'allowMutipleFiles' property to filePicker context property to indicate whether to allow
multiple file selections.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::chooseFiles):
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml: Added.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml:
- UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Added.
- UIProcess/API/qt/tests/qmltests/common/singlefileupload.html:
- UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Added.
(updateTitle):
- UIProcess/qt/QtDialogRunner.cpp:
(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::allowMultipleFiles):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):
- UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
Tools:
Modified filePicker to support multi-file upload.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/icons/checkbox_checked.png: Added.
- MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
- MiniBrowser/qt/js/MultiSelect.js: Added.
(values):
(isSelected):
(removeValue):
- MiniBrowser/qt/qml/CheckBox.qml: Added.
- MiniBrowser/qt/qml/FilePicker.qml:
- 7:17 PM Changeset in webkit [112194] by
-
- 2 edits in trunk/Source/WebCore
Fix minor spell error in DocumentLoader.h
https://bugs.webkit.org/show_bug.cgi?id=82141
Reviewed by Nate Chapin.
Just fix spell error, no new tests.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setClientRedirectSourceForHistory):
- 7:13 PM Changeset in webkit [112193] by
-
- 4 edits in trunk/Source/WebCore
[Skia] Remove use of deprecated Skia constant and struct field names
https://bugs.webkit.org/show_bug.cgi?id=81034
Patch by Brian Salomon <bsalomon@google.com> on 2012-03-26
Reviewed by James Robinson.
No behavior change, so no tests. The modified code is executed by many existing tests.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::createAcceleratedCanvas):
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
- 7:03 PM Changeset in webkit [112192] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unaligned userspace access for SH4 platforms
https://bugs.webkit.org/show_bug.cgi?id=79104
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-26
Reviewed by Gavin Barraclough.
- assembler/AbstractMacroAssembler.h:
(Jump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::extraInstrForBranch):
(SH4Assembler):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
- jit/JIT.h:
(JIT):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
- 7:01 PM Changeset in webkit [112191] by
-
- 21 edits in trunk/Source
[chromium] Add isInputThrottled/didBecomeReadyForAdditionalInput to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=82265
Source/Platform:
Reviewed by James Robinson.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::didCommit):
Source/WebCore:
In threaded compositing mode, the WebWidget is self-scheduled,
receiving damage and processing it without forwarding that damage
up to the embedding WebWidgetClient. In Chromium's case, the
client uses the presence of damage to perform input flow
control. This patch exposes the need for input flow control to the
embedder, while keeping the actual logic about what exactly
warrants input flow control inside the implementation.
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::commitRequested):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitRequested):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitRequested):
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
In threaded compositing mode, the WebWidget is self-scheduled,
receiving damage and processing it without forwarding that damage
up to the embedding WebWidgetClient. In Chromium's case, the
client uses the presence of damage to perform input flow
control. This patch exposes the need for input flow control to the
embedder, while keeping the actual logic about what exactly
warrants input flow control inside the implementation.
Reviewed by James Robinson.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::isInputThrottled):
- public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::didBecomeReadyForAdditionalInput):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::commitRequested):
(WebKit):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isInputThrottled):
(WebKit):
(WebKit::WebViewImpl::didCommit):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::didCommit):
(MockLayerTreeHostClient):
- tests/FakeCCLayerTreeHostClient.h:
(FakeCCLayerTreeHostClient):
- 6:59 PM Changeset in webkit [112190] by
-
- 7 edits in trunk
When <img crossorigin> fails the CORS check, we should fire the error event
https://bugs.webkit.org/show_bug.cgi?id=81998
Reviewed by Nate Chapin.
Source/WebCore:
The spec says we're supposed to fire the error event when the CORS
check fails, but we haven't been. This patch is larger than it might
otherwise be because we're firing the event asynchronously, but that
seems like the right thing to do.
Tests: http/tests/security/img-with-failed-cors-check-fails-to-load.html
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- loader/ImageLoader.cpp:
(WebCore::errorEventSender):
(WebCore):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvents):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
Check that we're firing the error event in this case.
- http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
- http/tests/security/img-with-failed-cors-check-fails-to-load.html:
- 6:56 PM Changeset in webkit [112189] by
-
- 4 edits in trunk/Tools
Retry crashing tests serially at the end of NRWT on Apple Mac
https://bugs.webkit.org/show_bug.cgi?id=82233
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_retry_crashes):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.should_retry_crashes):
- 6:32 PM Changeset in webkit [112188] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r112177.
- fast/dom/css-dom-read-2-expected.txt:
- 6:31 PM Changeset in webkit [112187] by
-
- 10 edits in trunk/Source/WebCore
Make filters and the threaded compositor play well together.
https://bugs.webkit.org/show_bug.cgi?id=78139
Use a dedicated GraphicsContext3D instance for all filters calls in
the threaded case. Clone all FilterOperations for thread safety
in the threaded case.
Reviewed by James Robinson.
Covered by tests in LayoutTests/css3/filters.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Set a global flag if we've seen content with filters, so we know
we need to create the filter context.
(WebCore::LayerChromium::pushPropertiesTo):
Clone all filter operations if we're in the threaded case.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::needsFilterContext):
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
(CCLayerTreeHost):
Add flag and accessors for needsFilterContext.
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::applyFilters):
Pick up the appropriate context from SharedGraphicsContext3D,
depending if we're in the threaded case or not.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::recreateContext):
For the threaded compositor re-create the filter context
alongside the main compositor context on lost context, if requested.
(WebCore::CCThreadProxy::beginFrame):
Create the filter context in beginFrame, if it was resquested and is
NULL. This handles the first-use case.
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::clone):
Assert if trying to clone the custom filter operation (it has
non-threadsafe members).
- platform/graphics/filters/FilterOperation.h:
(WebCore::DefaultFilterOperation::clone):
(WebCore::PassthroughFilterOperation::clone):
(WebCore::ReferenceFilterOperation::clone):
(WebCore::BasicColorMatrixFilterOperation::clone):
(WebCore::BasicComponentTransferFilterOperation::clone):
(WebCore::GammaFilterOperation::clone):
(WebCore::BlurFilterOperation::clone):
(WebCore::DropShadowFilterOperation::clone):
Add clone methods for all FilterOperations.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
(WebCore::SharedGraphicsContext3DImpl::getContext):
(WebCore::SharedGraphicsContext3DImpl::createContext):
(WebCore::SharedGraphicsContext3D::get):
(WebCore::getOrCreateContextForImplThread):
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):
Split out context creation, lost context recovery, and retrieval
into separate functions, so the impl thread can use only the parts
it wants on the threads it wants (create and have on main, get on impl).
Add asserts to ensure that's how they're called.
- platform/graphics/gpu/SharedGraphicsContext3D.h:
(SharedGraphicsContext3D):
Reuse the SharedGraphicsContext infrastructure to create a new
context singleton for filter use in the threaded compositor.
- 6:21 PM Changeset in webkit [112186] by
-
- 1 edit in trunk/Source/WTF/ChangeLog
Set eol-style: native on WTF.sln per Ryan Sleevi's request.
- WTF.vcproj/WTF.sln: Added property svn:eol-style.
- 6:12 PM Changeset in webkit [112185] by
-
- 2 edits in trunk/Source/WTF
Chromium build fix; add BitVector.h/cpp to gypi.
- WTF.gypi:
- 6:09 PM Changeset in webkit [112184] by
-
- 22 edits4 adds in trunk
FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020
Reviewed by Eric Seidel.
Source/WebCore:
The vast majority of security checks in the browser should use a
ScriptExecutionContext (aka a Document) to designate "who" is
attempting to perform a given action. Unfortunately,
shouldAllowNavigation was using a Frame to designate "who" is
attempting the navigation.
In cases when the executing script is "inactive" (i.e., belongs to a
document that is not currently displayed in a Frame), using the Frame
can cause us to grant the script the privileges of the document that's
currently displayed in the Frame rather than the one that contains the
script.
This patch moves shouldAllowNavigation from FrameLoader to Document
(and renames it to canNavigate), effectively change the context object
from a Frame to a Document.
Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html
- bindings/generic/BindingSecurity.h:
(BindingSecurity):
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore):
- bindings/v8/V8Utilities.h:
(WebCore):
- Deletes unused code.
- dom/Document.cpp:
(WebCore::canAccessAncestor):
(WebCore):
(WebCore::Document::canNavigate):
- canNavigate is copied from FrameLoader::shouldAllowNavigation. I've added a null-check bailout if the document is inactive.
- dom/Document.h:
(Document):
- loader/FormState.cpp:
(WebCore::FormState::FormState):
(WebCore::FormState::create):
- loader/FormState.h:
(WebCore):
(FormState):
(WebCore::FormState::sourceDocument):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- Changes the context object from Frame to Document.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore):
(WebCore::FrameLoader::findFrameForNavigation):
- FrameLoader::findFrameForNavigation still incorrectly uses Frame as the context object, but that's a bug for another patch.
(WebCore::createWindow):
- loader/FrameLoader.h:
(FrameLoader):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::open):
- page/History.cpp:
(WebCore::History::go):
Source/WebKit/mac:
Update call site to new function name.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSubmitForm):
Source/WebKit/win:
Update call site to new function name.
- WebFrame.cpp:
(WebFrame::dispatchWillSubmitForm):
Source/WebKit2:
Update call site to new function name.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
LayoutTests:
Test that a script from an inactive document doesn't inherit the
navigation privileges of the document that currently occupies the
frame.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
- http/tests/security/frameNavigation/resources/fail.html: Added.
- http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
- http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.
- 6:02 PM Changeset in webkit [112183] by
-
- 1 edit in trunk/ChangeLog
Trigger a build on Chromium Linux boxes to see if clean builds succeed or not.
- 5:16 PM Changeset in webkit [112182] by
-
- 5 edits in trunk/Source
[chromium] Simplify and fix CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=82114
Source/WebCore:
A significant cleanup, simplification and improvement of the CCLayerSorter code.
Simplified the LayerShape structure to use WebCore's FloatQuad for all overlap tests.
By treating every layer as two triangles, the old overlap code did a lot of redundant work
including testing two of the vertices of the layer and its diagonal twice. The new overlap
tests check:
- The four corners of each of the two layers against the other layer.
- The four edges of each layer against the edges of the other layer.
Unlike the old code, the new code has no early-outs in the overlap tests as those where causing
us to miss legitimate overlaps.
A new technique for breaking dependency cycles introduced by intersecting layers is implemented.
Instead of arbitrarily breaking cycles by choosing the node in the graph with the smallest number of
incoming edges (i.e. layers that need to be drawn before it) we chose the one with the smallest sum
of graph edge weights (defined as the max depth difference between two layers). Layers that intersect
have their respective graph edge weight set to zero, making them more likely to be picked for breaking
the cycles (it's not a perfect solution but it seems to perform much better than the previous one).
In addition to being overly complex and doing reduntant work, the old code was missing a
perspective divide when computing the coordinates of the layer's corners in the projected plane
which was the source of a lot of mis-sorted results.
In all, these improvements, fix a lot of outstanding issues with layer sorting, on pages such as:
http://www.keithclark.co.uk/labs/3dcss/demo/
http://2012.beercamp.com
https://developer.mozilla.org/fr/demos/detail/the-box/launch
Tests: CCLayerSorter unit tests.
Reviewed by Kenneth Russell.
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore):
(WebCore::perpProduct):
(WebCore::edgeEdgeTest):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::LayerShape::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::sort):
- platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::CCLayerSorter):
(CCLayerSorter):
(LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):
(GraphNode):
(WebCore::CCLayerSorter::GraphEdge::GraphEdge):
(GraphEdge):
Source/WebKit/chromium:
Adjustments to the CCLayerSorter unit tests to account for API changes in the
CCLayerSorter class.
Reviewed by Kenneth Russell.
- tests/CCLayerSorterTest.cpp:
(WebCore):
(WebCore::TEST):
- 5:12 PM Changeset in webkit [112181] by
-
- 2 edits in trunk/Tools
NRWT should retry failures serially
https://bugs.webkit.org/show_bug.cgi?id=82241
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests): Add another parameter to specify the number of workers to use.
(Manager.run): Run the failures serially.
- 5:12 PM Changeset in webkit [112180] by
-
- 2 edits in trunk/Source/WTF
Touch BitVector as a speculative fix for Chromium Linux.
- wtf/BitVector.h:
(BitVector):
- 5:10 PM Changeset in webkit [112179] by
-
- 37 edits1 copy7 moves50 adds15 deletes in trunk/LayoutTests
More Chromium rebaselines for assorted failing tests. Almost all of the differences
are text rendering or antialiasing. Some of them are imperceptibly different shades
of a color for tests that aren't testing that (e.g the test tests clipping).
- 5:09 PM Changeset in webkit [112178] by
-
- 7 edits in trunk/Source/WebCore
[Chromium] Using WebViewPlugins with --force-compositing-mode causes an ASSERT to fail
https://bugs.webkit.org/show_bug.cgi?id=81954
Reviewed by James Robinson.
A static variable s_inPaintContents is set when painting, and it ensures
that we don't delete GraphicsLayers or create GraphicsLayers while painting.
However, because this variable is static, it does not permit the existence
of multiple WebViews in different stages (one laying out and one painting).
This manifests itself if one attempts to use the --force-compositing-mode
in Chromium and attempts to navigate to a page with a missing or old plugin
or a browser plugin (which uses a WebViewPlugin as a placeholder until it's
done loading).
The solution to simplify debugging is to make this flag per-Page.
We can access Page from RenderLayerBacking which is a GraphicsLayerClient.
We add a new method GraphicsLayerClient::verifyNotPainting with a default
(do nothing) implementation and override it in RenderLayerBacking to
test the flag set in Page.
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(Page):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
- platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::verifyNotPainting):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
(WebCore):
(WebCore::RenderLayerBacking::verifyNotPainting):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- 4:59 PM Changeset in webkit [112177] by
-
- 17 edits2 adds in trunk
cssText should use shorthand notations
https://bugs.webkit.org/show_bug.cgi?id=81737
Reviewed by Enrica Casucci.
Source/JavaScriptCore:
Export symbols of BitVector on Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Source/WebCore:
Use shorthand properties to serialize style properties for cssText.
The overall algorithm is to look for any property that has a shorthand, and then check if
the shorthand value could be obtained (the condition is quite complicated for border properties).
If it could, then append that value to the string builder, and set the corresponding entries in
shorthandPropertyAppeared and shorthandPropertyUsed. If not, only turn on the bit in
shorthandPropertyAppeared on to avoid calling getPropertyValue again for longhand properties
that use the same shorthand property when we cannot use the shorthand.
Test: fast/css/cssText-shorthand.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
Source/WTF:
- wtf/BitVector.h:
(BitVector):
(WTF::BitVector::ensureSizeAndSet): Added.
LayoutTests:
Rebaseline existing tests and add a regression test for unprefixed CSS properties with
the exception of -webkit-border-horizontal/vertical-spacing (the shorthand version of
these properties (border-spacing) is unprefixed.
- editing/pasteboard/paste-and-sanitize-expected.txt: Uses border instead of longhand
properties as desired.
- editing/pasteboard/paste-and-sanitize.html:
- editing/style/non-inheritable-styles-expected.txt: Ditto.
- fast/css/background-position-serialize-expected.txt: No longer emits "background-*:
initial" as desired.
- fast/css/cssText-shorthand-expected.txt: Added.
- fast/css/cssText-shorthand.html: Added.
- fast/css/remove-shorthand-expected.txt:
- fast/css/remove-shorthand.html: Modified to do elaborative comparison of the lists of
properties before and after removing a shorthand since now removing a shorthand property
may end up adding new longhand property.
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html: Uses shorthand properties instead of longhand equivalents.
- inspector/styles/styles-update-from-js-expected.txt: Ditto.
- printing/page-rule-css-text-expected.txt: Ditto.
- 4:53 PM Changeset in webkit [112176] by
-
- 3 edits in trunk/Tools
Allow expectations on directories in virtual test suites
https://bugs.webkit.org/show_bug.cgi?id=82250
Reviewed by Dirk Pranke.
lookup_virtual_test_base was only returning valid results for files
and not directories. Fix by falling back to the virtual test suite
mapping if possible.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.lookup_virtual_test_base):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.skipped_tests):
(TestPort.virtual_test_suites):
- 4:42 PM Changeset in webkit [112175] by
-
- 2 edits in trunk/Source/WebKit2
Never remove root compositing layers in the web process
https://bugs.webkit.org/show_bug.cgi?id=82255
<rdar://problem/11058521>
Reviewed by Sam Weinig.
Since we never leave accelerated compositing mode when using tiled drawing, we should
never remove root compositing layers in the web process.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 4:39 PM Changeset in webkit [112174] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Add Android keycodes
https://bugs.webkit.org/show_bug.cgi?id=81950
Add the missing Android keycodes listed in the bug.
Patch by Bolin Hsu <bhsu@google.com> on 2012-03-26
Reviewed by Adam Barth.
- platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- platform/chromium/KeyboardCodes.h:
- 4:39 PM Changeset in webkit [112173] by
-
- 1 edit in trunk/Tools/ChangeLog
Fix duplicated ChangeLog entry from r112171.
Unreviewed, build fix.
- 4:37 PM Changeset in webkit [112172] by
-
- 2 edits in trunk/Source/WebCore
Switch ColumnInfo::addForcedBreak to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82210
Reviewed by Eric Seidel.
Forced breaks are added by local offsets, which should be in LayoutUnits.
No new tests. No change in behavior.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::addForcedBreak):
- 4:36 PM Changeset in webkit [112171] by
-
- 12 edits in trunk/Tools
test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253
Reviewed by Adam Barth.
Per suggestion from abarth, this change splits all the
filesystem-crawling, test-finding code in test-webkitpy out into
a separate module and switches to using a FileSystem object.
This makes things much more testable, so we also add tests :).
We also add a realpath() method to the Filesystem object, since
test-webkitpy needs that in order to be able to resolve symlinks
properly to determine whether a file is under a particular tree
or not.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.realpath):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.realpath):
- Scripts/webkitpy/test/main.py:
(Tester.init):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):
- Scripts/webkitpy/test/test_finder.py: Added.
(TestDirectoryTree):
(TestDirectoryTree.init):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.find_modules.file_filter):
(TestDirectoryTree.to_module):
(TestDirectoryTree.clean):
(TestFinder):
(TestFinder.init):
(TestFinder.add_tree):
(TestFinder.additional_paths):
(TestFinder.clean_trees):
(TestFinder.is_module):
(TestFinder.to_module):
(TestFinder.find_names):
(TestFinder._exclude):
- Scripts/webkitpy/test/test_finder_unittest.py: Added.
(TestFinderTest):
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.test_additional_system_paths):
(TestFinderTest.test_is_module):
(TestFinderTest.test_to_module):
(TestFinderTest.test_clean):
(TestFinderTest.test_find_names):
- 4:35 PM Changeset in webkit [112170] by
-
- 5 edits in trunk/Source/WebCore
Update LayoutUnit usage in ContainerNode, Element, and ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=82219
Reviewed by Eric Seidel.
No new tests. No change in behavior.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getLowerRightCorner): linesBoundingBox returns the enclosing IntRect
of the contained lines. Inline's aren't bounded in LayoutUnits nor pixel snapped.
- dom/Element.cpp:
(WebCore::Element::boundsInRootViewSpace): Coordinates in root view space are akin to absolute
coordinates, which are always expressed in integers.
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(WebCore::defaultMinimumSizeForResizing): Using numeric_limits<LayoutUnit>::max instead of
INT_MAX to avoid overflowing when LayoutUnits are sub-pixel.
- 4:33 PM Changeset in webkit [112169] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test_expectations update for chromium.
- platform/chromium/test_expectations.txt:
- 4:31 PM Changeset in webkit [112168] by
-
- 4 edits2 adds in trunk/Tools
test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253
Reviewed by Adam Barth.
Per suggestion from abarth, this change splits all the
filesystem-crawling, test-finding code in test-webkitpy out into
a separate module and switches to using a FileSystem object.
This makes things much more testable, so we also add tests :).
We also add a realpath() method to the Filesystem object, since
test-webkitpy needs that in order to be able to resolve symlinks
properly to determine whether a file is under a particular tree
or not.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.realpath):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.realpath):
- Scripts/webkitpy/test/main.py:
(Tester.init):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):
- Scripts/webkitpy/test/test_finder.py: Added.
(TestDirectoryTree):
(TestDirectoryTree.init):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.find_modules.file_filter):
(TestDirectoryTree.to_module):
(TestDirectoryTree.clean):
(TestFinder):
(TestFinder.init):
(TestFinder.add_tree):
(TestFinder.additional_paths):
(TestFinder.clean_trees):
(TestFinder.is_module):
(TestFinder.to_module):
(TestFinder.find_names):
(TestFinder._exclude):
- Scripts/webkitpy/test/test_finder_unittest.py: Added.
(TestFinderTest):
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.test_additional_system_paths):
(TestFinderTest.test_is_module):
(TestFinderTest.test_to_module):
(TestFinderTest.test_clean):
(TestFinderTest.test_find_names):
- 4:05 PM Changeset in webkit [112167] by
-
- 5 edits in trunk/Source/WebCore
Update binding test output for V8 after r112163.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- 4:01 PM Changeset in webkit [112166] by
-
- 9 edits in trunk/Source/WebCore
Update localSelectionRect to return a LayoutRect
https://bugs.webkit.org/show_bug.cgi?id=82183
Reviewed by Eric Seidel.
localSelectionRect returns a rectangle in the coordinate space of its renderer,
and therefor should remain LayoutUnits until being promoted to absolute
coordinates or painted. Also fixing an incorrect conversion of startPos and
endPos in selectionRectForRepaint.
No new tests. No change in behavior.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect): Continuing to use enclosingIntRect
for the value being returned from the font engine since these floating point
values should not be pixel snapped.
- rendering/InlineTextBox.h:
(InlineTextBox):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::localSelectionRect):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint): Fixing an incorrect conversion of
start/endPos to LayoutUnits. These values represent a range of selected characters,
not layout values!
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::localSelectionRect):
- rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):
- 3:59 PM Changeset in webkit [112165] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Crash in Canvas2DLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=82243
Patch by Justin Novosad <junov@chromium.org> on 2012-03-26
Reviewed by James Robinson.
Adding null pointer check to prevent crash and texture object
validity check to prevent potential graphics glitch
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
- 3:58 PM Changeset in webkit [112164] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should assert that argument value recoveries can only be
AlreadyInRegisterFile or Constant
https://bugs.webkit.org/show_bug.cgi?id=82249
Reviewed by Michael Saboff.
Made the assertions that the DFG makes for argument value recoveries match
what Arguments expects.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isConstant):
(ValueRecovery):
(JSC::ValueRecovery::isAlreadyInRegisterFile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:57 PM Changeset in webkit [112163] by
-
- 11 edits in trunk/Source/WebCore
Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238
Reviewed by Adam Barth.
The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).
In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().
No new tests, no change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.
- bindings/v8/V8Proxy.h:
(WebCore::toV8): Remove explicit ref.
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.
- bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback): ditto.
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback): ditto.
- 3:51 PM Changeset in webkit [112162] by
-
- 5 edits in trunk/Source/WebCore
Remove obsolete FormDataStreamMac code
https://bugs.webkit.org/show_bug.cgi?id=82244
Reviewed by Brady Eidson.
- platform/network/ResourceHandle.h: Removed ResourceHandle::didSendBodyDataDelegateExists().
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm: Removed code that was needed to call ResourceLoaderClient::didSendData() before Foundation added support for it.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): We no longer need to associate streams with ResourceHandles!
- 3:49 PM Changeset in webkit [112161] by
-
- 4 edits3 adds in trunk
V8RecursionScope should not hold a raw pointer to ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=82222
Reviewed by Eric Seidel.
Source/WebCore:
Instead of holding onto ScriptExecutionContext, cache the boolean value we
care about (context->isDocument()). This avoids problems if the
context goes away as a result of the script we just ran.
Test: fast/frames/subframe-load-js-url-crash.html
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext): Check the cached
bool instead of calling into the context.
- bindings/v8/V8RecursionScope.h:
(WebCore::V8RecursionScope::V8RecursionScope): Call isDocument from
the constructor and cache the result.
(WebCore::V8RecursionScope::~V8RecursionScope): No longer need to pass
anything to didLeaveScriptContext since it's now a member.
(V8RecursionScope): Make didLeaveScriptContext a member function and
remove its argument. Add member bool to hold the value of isDocument.
LayoutTests:
- fast/frames/resources/subframe-load-js-url-crash-iframe.html: Added.
- fast/frames/subframe-load-js-url-crash-expected.txt: Added.
- fast/frames/subframe-load-js-url-crash.html: Added.
- 3:47 PM Changeset in webkit [112160] by
-
- 43 edits4 copies55 adds in trunk/LayoutTests
[EFL] Unreviewed gardening i fast/frames, fast/html and
fast/lists.
- platform/efl/Skipped:
- platform/efl/fast/frames/001-expected.png:
- platform/efl/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
- platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.png:
- platform/efl/fast/frames/frame-navigation-expected.png:
- platform/efl/fast/frames/frame-scrolling-attribute-expected.png:
- platform/efl/fast/frames/frameset-style-recalc-expected.png:
- platform/efl/fast/frames/iframe-scrolling-attribute-expected.png:
- platform/efl/fast/frames/iframe-with-frameborder-expected.png:
- platform/efl/fast/frames/onlyCommentInIFrame-expected.png:
- platform/efl/fast/frames/viewsource-attribute-expected.png:
- platform/efl/fast/frames/viewsource-on-image-file-expected.png:
- platform/efl/fast/html/details-add-child-1-expected.png: Added.
- platform/efl/fast/html/details-add-child-2-expected.png: Added.
- platform/efl/fast/html/details-add-details-child-1-expected.png: Added.
- platform/efl/fast/html/details-add-details-child-2-expected.png: Added.
- platform/efl/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
- platform/efl/fast/html/details-add-summary-1-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
- platform/efl/fast/html/details-add-summary-10-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-10-expected.png: Added.
- platform/efl/fast/html/details-add-summary-2-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-2-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
- platform/efl/fast/html/details-add-summary-3-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-3-expected.png: Added.
- platform/efl/fast/html/details-add-summary-4-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-4-expected.png: Added.
- platform/efl/fast/html/details-add-summary-5-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-5-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
- platform/efl/fast/html/details-add-summary-6-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-6-expected.png: Added.
- platform/efl/fast/html/details-add-summary-7-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-7-expected.png: Added.
- platform/efl/fast/html/details-add-summary-8-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-8-expected.png: Added.
- platform/efl/fast/html/details-add-summary-9-and-click-expected.png: Added.
- platform/efl/fast/html/details-add-summary-9-expected.png: Added.
- platform/efl/fast/html/details-add-summary-child-1-expected.png: Added.
- platform/efl/fast/html/details-add-summary-child-2-expected.png: Added.
- platform/efl/fast/html/details-nested-1-expected.png: Added.
- platform/efl/fast/html/details-nested-2-expected.png: Added.
- platform/efl/fast/html/details-no-summary1-expected.png: Added.
- platform/efl/fast/html/details-no-summary2-expected.png: Added.
- platform/efl/fast/html/details-no-summary3-expected.png: Added.
- platform/efl/fast/html/details-no-summary4-expected.png: Added.
- platform/efl/fast/html/details-open-javascript-expected.png: Added.
- platform/efl/fast/html/details-open1-expected.png: Added.
- platform/efl/fast/html/details-open2-expected.png: Added.
- platform/efl/fast/html/details-open3-expected.png: Added.
- platform/efl/fast/html/details-open4-expected.png: Added.
- platform/efl/fast/html/details-open5-expected.png: Added.
- platform/efl/fast/html/details-open6-expected.png: Added.
- platform/efl/fast/html/details-position-expected.png: Added.
- platform/efl/fast/html/details-remove-child-1-expected.png: Added.
- platform/efl/fast/html/details-remove-child-2-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-1-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-1-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-2-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-2-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-3-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-3-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-4-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-4-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-5-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-5-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-6-and-click-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-6-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-child-1-expected.png: Added.
- platform/efl/fast/html/details-remove-summary-child-2-expected.png: Added.
- platform/efl/fast/html/details-replace-summary-child-expected.png: Added.
- platform/efl/fast/html/details-replace-text-expected.png: Added.
- platform/efl/fast/html/details-writing-mode-expected.png: Added.
- platform/efl/fast/html/link-rel-stylesheet-expected.png:
- platform/efl/fast/html/listing-expected.png:
- platform/efl/fast/html/marquee-scroll-expected.png:
- platform/efl/fast/html/marquee-scrollamount-expected.png:
- platform/efl/fast/lists/001-expected.png:
- platform/efl/fast/lists/001-vertical-expected.png:
- platform/efl/fast/lists/002-expected.png:
- platform/efl/fast/lists/002-vertical-expected.png:
- platform/efl/fast/lists/003-expected.png:
- platform/efl/fast/lists/003-vertical-expected.png:
- platform/efl/fast/lists/005-expected.png:
- platform/efl/fast/lists/005-vertical-expected.png:
- platform/efl/fast/lists/007-expected.png:
- platform/efl/fast/lists/007-vertical-expected.png:
- platform/efl/fast/lists/008-expected.png:
- platform/efl/fast/lists/008-vertical-expected.png:
- platform/efl/fast/lists/anonymous-items-expected.png:
- platform/efl/fast/lists/big-list-marker-expected.png:
- platform/efl/fast/lists/dynamic-marker-crash-expected.png:
- platform/efl/fast/lists/li-br-expected.png:
- platform/efl/fast/lists/li-style-alpha-huge-value-crash-expected.png:
- platform/efl/fast/lists/marker-before-empty-inline-expected.png:
- platform/efl/fast/lists/marker-image-error-expected.png:
- platform/efl/fast/lists/markers-in-selection-expected.png:
- platform/efl/fast/lists/ol-display-types-expected.png:
- platform/efl/fast/lists/ol-start-parsing-expected.png:
- platform/efl/fast/lists/olstart-expected.png:
- platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/efl/fast/lists/scrolled-marker-paint-expected.png:
- 3:43 PM Changeset in webkit [112159] by
-
- 2 edits in trunk/Source/WebCore
[chromium] assertion being hit in CCLayerTreeHost::updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=82239
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-26
Reviewed by Adrienne Walker.
The assert is incorrect and should check the animation state on
the surface, not the owning layer.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateCompositorResources):
- 3:41 PM Changeset in webkit [112158] by
-
- 3 edits in trunk/Source/WebCore
Correct LayoutUnit usage in RenderFieldSet and RenderMenuItem
https://bugs.webkit.org/show_bug.cgi?id=82179
Reviewed by Julien Chaffraix.
Correcting small misuses of ints vs LayoutUnits in RenderFieldSet and RenderMenuItem. Also
adding zeroLayoutUnit where necessary to fix the sub-pixel build. See below for details.
No new tests. No change in behavior.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Clip rects need to be pixel snapped to mirror
the actual coordinates we paint.
(WebCore::RenderFieldset::paintMask): Using zeroLayoutUnit for ternary operation to fix the
sub-pixel build.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup): Correctly using an IntRect for absoluteBoundingBoxRect.
(WebCore::RenderMenuList::clientPaddingLeft): Correcting mismatched return type with header.
(WebCore::RenderMenuList::clientPaddingRight): Ditto.
- 3:39 PM Changeset in webkit [112157] by
-
- 63 edits2 copies10 moves63 adds11 deletes in trunk/LayoutTests
Chromium rebaselines for test failing due to text rendering or antialiasing differences.
Changes to non-chromium results were from "webkit-patch optimize-baselines".
- 3:39 PM Changeset in webkit [112156] by
-
- 3 edits in trunk/Source/WebCore
Tried to fix an unused parameter warning after r112154.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Changed to not pass relayoutChildren to
layoutFlexItems.
(WebCore::RenderFlexibleBox::layoutFlexItems): Removed the unused relayoutChildren parameter.
- rendering/RenderFlexibleBox.h:
- 3:32 PM Changeset in webkit [112155] by
-
- 2 edits in trunk/Source/WebCore
SyntheticStyleCalc on an element should not force recalculation on its children
https://bugs.webkit.org/show_bug.cgi?id=79389
Patch by Rob Arnold <robarnold@fb.com> on 2012-03-26
Reviewed by Simon Fraser.
No new tests. Existing tests cover correctness, not sure how to test for performance.
- dom/Element.cpp:
(WebCore::Element::recalcStyle):
- 3:26 PM Changeset in webkit [112154] by
-
- 6 edits in trunk
apply cross axis constraints before aligning children in flexbox
https://bugs.webkit.org/show_bug.cgi?id=82240
Reviewed by Ojan Vafai.
Source/WebCore:
We weren't applying max-height constraints before aligning children.
This would cause center, end, stretch alignment to be wrong if we hit
a max-height on a flexbox.
This patch also moves the repositioning logic to happen after
computeLogicalHeight, which will be useful for flex-line-pack.
New test case in css3/flexbox/flex-align.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/flex-align-expected.txt:
- css3/flexbox/flex-align.html:
- 3:14 PM Changeset in webkit [112153] by
-
- 2 edits in trunk/Tools
[jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209
Reviewed by Martin Robinson.
Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 3:04 PM Changeset in webkit [112152] by
-
- 2 edits in trunk/Source/JavaScriptCore
Tried to fix the Windows build.
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::putRange):
- 2:59 PM Changeset in webkit [112151] by
-
- 2 edits in trunk/LayoutTests
The css3/selectors3/xml tests are flaky on Leopard as well.
- platform/chromium/test_expectations.txt:
- 2:58 PM Changeset in webkit [112150] by
-
- 3 edits in trunk/Tools
add a Tree abstraction to test-webkitpy to better encapsulate things
https://bugs.webkit.org/show_bug.cgi?id=82158
Reviewed by Adam Barth.
There are no functional changes in this patch, but adding a
basic abstraction for the trees we are looking in for python
tests will allow me to add some features later on more easily
(like ignoring certain directories like webkitpy/thirdparty),
and it makes things slightly less hard-coded.
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/main.py:
(Tester.init):
(Tester):
(Tester.add_tree):
(Tester._parse_args):
(Tester._configure):
(Tester.run):
(Tester._find_modules):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):
(TestDirectoryTree):
(TestDirectoryTree.init):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.clean):
- 2:56 PM Changeset in webkit [112149] by
-
- 5 edits in trunk/Tools
garden-o-matic should special case reftests
https://bugs.webkit.org/show_bug.cgi?id=81812
Reviewed by Adam Barth.
On the examine page, don't show a rebaseline button for reftests.
We still show it on the failure summary page because tests are grouped
together. Long-term, we should make sure webkit-patch rebaseline-test
never tries to rebaseline reftests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 2:43 PM Changeset in webkit [112148] by
-
- 2 edits in trunk/Source/WebCore
Find in page overlay and bouncy are not always positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=82247
<rdar://problem/10866139>
Reviewed by Sam Weinig.
In WebCore, a lot of code depends on scroll position updates to happen synchronously, so
update the frame view scroll position before asking the scrolling thread to scroll.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
- 2:40 PM Changeset in webkit [112147] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed - speculative Windows build fix.
- yarr/YarrCanonicalizeUCS2.h:
(JSC::Yarr::getCanonicalPair):
- 2:30 PM Changeset in webkit [112146] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed builds with assertions disabled.
- yarr/YarrCanonicalizeUCS2.h:
(JSC::Yarr::areCanonicallyEquivalent):
- 2:06 PM Changeset in webkit [112145] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed - errk! - accidentally the whole pbxproj.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:34 PM Changeset in webkit [112144] by
-
- 4 edits in trunk/Source/WebCore
Simplify setting loading state in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=82099
Reviewed by Adam Barth.
The logic for deciding what to return for DocumentLoader::isLoading()
is crazy. It's indirectly based on the ResourceLoaders that have
registered themselves with the DocumentLoader, but we can make that
relationship more direct.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete): Renamed from updateLoading, since it's not actually
updating anything anymore. It now calls DOMWindow::finishedLoading() if loading is in fact done.
(WebCore::DocumentLoader::startLoadingMainResource): The only reason this had a return value was to call
updateLoading() if loading failed. Just call checkLoadComplete() directly (this allows it to
be private, whereas updateLoading() was public).
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoading): Rather than holding a separate bool, return based on the presence
of non-multipart ResourceLoaders directly.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::isLoading): Depend on DocumentLoader::isLoading() for the activeDocumentLoader(),
rather than indirectly the other way around.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Remove several assertions that should now be
absolutely identical to the remaining !pdl->isLoading().
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
- 1:13 PM Changeset in webkit [112143] by
-
- 11 edits6 adds in trunk
Greek sigma is handled wrong in case independent regexp.
https://bugs.webkit.org/show_bug.cgi?id=82063
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The bug here is that we assume that any given codepoint has at most one additional value it
should match under a case insensitive match, and that the pair of codepoints that match (if
a codepoint does not only match itself) can be determined by calling toUpper/toLower on the
given codepoint). Life is not that simple.
Instead, pre-calculate a set of tables mapping from a UCS2 codepoint to the set of characters
it may match, under the ES5.1 case-insensitive matching rules. Since unicode is fairly regular
we can pack this table quite nicely, and get it down to 364 entries. This means we can use a
simple binary search to find an entry in typically eight compares.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- yarr/yarr.pri:
- Added new files to build systems.
- yarr/YarrCanonicalizeUCS2.cpp: Added.
- New - autogenerated, UCS2 canonicalized comparison tables.
- yarr/YarrCanonicalizeUCS2.h: Added.
(JSC::Yarr::rangeInfoFor):
- Look up the canonicalization info for a UCS2 character.
(JSC::Yarr::getCanonicalPair):
- For a UCS2 character with a single equivalent value, look it up.
(JSC::Yarr::isCanonicallyUnique):
- Returns true if no other UCS2 code points are canonically equal.
(JSC::Yarr::areCanonicallyEquivalent):
- Compare two values, under canonicalization rules.
- yarr/YarrCanonicalizeUCS2.js: Added.
- script used to generate YarrCanonicalizeUCS2.cpp.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::tryConsumeBackReference):
- Use isCanonicallyUnique, rather than Unicode toUpper/toLower.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
- Use isCanonicallyUnique, rather than Unicode toUpper/toLower.
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::putChar):
- Updated to determine canonical equivalents correctly.
(JSC::Yarr::CharacterClassConstructor::putUnicodeIgnoreCase):
- Added, used to put a non-ascii, non-unique character in a case-insensitive match.
(JSC::Yarr::CharacterClassConstructor::putRange):
- Updated to determine canonical equivalents correctly.
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
- Changed to call putUnicodeIgnoreCase, instead of putChar, avoid a double lookup of rangeInfo.
LayoutTests:
- fast/regex/script-tests/unicodeCaseInsensitive.js: Added.
(shouldBeTrue.ucs2CodePoint):
- fast/regex/unicodeCaseInsensitive-expected.txt: Added.
- fast/regex/unicodeCaseInsensitive.html: Added.
- Added test cases for case-insensitive matches of non-ascii characters.
- 12:43 PM Changeset in webkit [112142] by
-
- 6 edits in trunk/Source
Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163
Reviewed by Anders Carlsson.
Source/WebCore:
Plugins may be scrollable, so we have to add them in the non-fast scrollable region. Tested manually.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::nonFastScrollableRegion):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scrollable):
(PluginViewBase):
Source/WebKit/chromium:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollable):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 12:41 PM Changeset in webkit [112141] by
-
- 5 edits4 adds in trunk/Source
[GTK] Build fix for Accelerated Compositing with Clutter
https://bugs.webkit.org/show_bug.cgi?id=81785
Reviewed by Martin Robinson.
Source/WebCore:
AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This includes an initial implementation of GraphicsContext3D
and fixes the build error.
- GNUmakefile.list.am:
- platform/graphics/clutter/DrawingBufferClutter.cpp: Added.
(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/clutter/GraphicsContext3DClutter.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::platformLayer):
- platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::platformContext):
(WebCore::GraphicsContext3DPrivate::paintToGraphicsLayerActor):
- platform/graphics/clutter/GraphicsContext3DPrivate.h: Added.
(WebCore):
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
Source/WebKit/gtk:
AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This fixes the build error.
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
(WebKit):
- 12:41 PM Changeset in webkit [112140] by
-
- 12 edits in trunk/Tools
clean up NRWT logging/metering, be less verbose
https://bugs.webkit.org/show_bug.cgi?id=73846
Reviewed by Ojan Vafai.
Re-land r112014 with a build fix for Python 2.6 compatibility.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.run):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker._set_up_logging):
(Worker):
(Worker._set_up_host_and_port):
(Worker.run):
(Worker.cleanup):
- Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.implements):
(MeteredStream._erasure):
(MeteredStream._ensure_newline):
(MeteredStream.init):
(MeteredStream.del):
(MeteredStream.cleanup):
(MeteredStream.write_throttled_update):
(MeteredStream.write_update):
(MeteredStream.write):
(MeteredStream.writeln):
(MeteredStream._erase_last_partial_line):
(_LogHandler):
(_LogHandler.init):
(_LogHandler.emit):
- Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest):
(RegularTest.setUp):
(RegularTest.tearDown):
(RegularTest.time_fn):
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest._log_after_update):
(RegularTest.test_log_after_update):
(TtyTest):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
- Scripts/webkitpy/layout_tests/views/printing.py:
(parse_print_options):
(Printer.init):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.test_print_progress):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):
- 12:31 PM Changeset in webkit [112139] by
-
- 2 edits in trunk/Tools
[jhbuild] Revert $MAKE environment hack introduced in r101929.
https://bugs.webkit.org/show_bug.cgi?id=82234
Reviewed by Martin Robinson.
The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 12:28 PM Changeset in webkit [112138] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Expose InspectorTypeBuilder.h to other components
https://bugs.webkit.org/show_bug.cgi?id=82226
Patch by Peter Rybin <prybin@chromium.org> on 2012-03-26
Reviewed by Vsevolod Vlasov.
This is a provisional commit that simplifies passing ealy warning system
for the main patch https://bugs.webkit.org/show_bug.cgi?id=81558
- WebCore.xcodeproj/project.pbxproj: config file is changed in Xcode UI.
- 12:19 PM Changeset in webkit [112137] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test_expectations update for chromium.
- platform/chromium/test_expectations.txt:
- 11:56 AM Changeset in webkit [112136] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
Unreviewed rebaseline for fast/forms/textfield-overflow.
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png: Added.
- platform/chromium-mac/fast/forms/textfield-overflow-expected.txt: Added.
- 11:54 AM Changeset in webkit [112135] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test_expectations update for chromium.
- platform/chromium/test_expectations.txt:
- 11:51 AM Changeset in webkit [112134] by
-
- 4 edits2 adds in trunk
An <area> element remains focusable even though its associated <img> is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=71788
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-26
Reviewed by Andy Estes.
Source/WebCore:
HTMLAreaElement::isFocusable() needs to consider the display and
visibility state.
Test: fast/events/tab-test-not-visible-imagemap.html
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isFocusable):
- html/HTMLAreaElement.h: Make imageElement() const.
(HTMLAreaElement):
LayoutTests:
Test sequential focus navigation.
- fast/events/tab-test-not-visible-imagemap-expected.txt: Added.
- fast/events/tab-test-not-visible-imagemap.html: Added.
- 11:44 AM Changeset in webkit [112133] by
-
- 2 edits in trunk/LayoutTests
Trim the set of flaky css3/selectors3/xml tests on SnowLeopard to
the set that are actually flaky on the bots.
- platform/chromium/test_expectations.txt:
- 11:39 AM Changeset in webkit [112132] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933
This is a build-fix after r112116.
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-26
Reviewed by Tor Arne Vestbø.
- UIProcess/API/qt/qwebpreferences_p_p.h:
- 11:26 AM Changeset in webkit [112131] by
-
- 3 edits in trunk/LayoutTests
Fix Qt after r112113 and r112112.
Unreviewed.
- platform/qt/Skipped:
Skipped a new test that is failing.
- platform/qt/fast/forms/textfield-overflow-expected.txt:
Updated the baseline as it matches other ports.
- 11:12 AM Changeset in webkit [112130] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in IDL
https://bugs.webkit.org/show_bug.cgi?id=82215
Reviewed by Adam Barth.
No new tests, just a typo fix.
- notifications/WorkerContextNotifications.idl:
- 11:11 AM Changeset in webkit [112129] by
-
- 1 edit6 adds in trunk/LayoutTests
Not reviewed: chromium baselines for c543-txt-decor-000.
- platform/chromium-linux/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
- 10:55 AM Changeset in webkit [112128] by
-
- 1 edit1 delete in trunk/LayoutTests
Removed Mac WebKit2-specific expected results for this test, which were added in r90097.
- platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
- 10:52 AM Changeset in webkit [112127] by
-
- 5 edits in trunk/Source
[chromium] Change handleGestureFling() to use CCInputHandlerClient::Wheel.
https://bugs.webkit.org/show_bug.cgi?id=82133
Reviewed by James Robinson.
Source/WebCore:
Covered by existing unit tests.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBegin):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
- 10:48 AM Changeset in webkit [112126] by
-
- 3 edits2 adds in trunk
CSS3 calc: mixed percent/absolute for box-reflect
https://bugs.webkit.org/show_bug.cgi?id=82161
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: css3/calc/box-reflect-expected.html
css3/calc/box-reflect.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
- css3/calc/box-reflect-expected.html: Added.
- css3/calc/box-reflect.html: Added.
- 10:45 AM Changeset in webkit [112125] by
-
- 3 edits2 adds in trunk
CSS3 calc: mixed percent/absolute support for vertical-align
https://bugs.webkit.org/show_bug.cgi?id=82152
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: css3/calc/vertical-align-expected.html
css3/calc/vertical-align.html
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyVerticalAlign::applyValue):
LayoutTests:
- css3/calc/vertical-align-expected.html: Added.
- css3/calc/vertical-align.html: Added.
- 10:43 AM Changeset in webkit [112124] by
-
- 9 edits1 move in trunk/Source/WebCore
[BlackBerry] Accelerated compositing updates
https://bugs.webkit.org/show_bug.cgi?id=82058
Patch by Filip Spacek <fspacek@rim.com> on 2012-03-26
Reviewed by Rob Buis.
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):
- platform/graphics/blackberry/InstrumentedPlatformCanvas.h:
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::needsTexture):
(LayerData):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::setDrawable):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::loadBufferingImageData):
- platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Renamed from Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h.
(WebCore):
(ImageBufferData):
- 10:38 AM Changeset in webkit [112123] by
-
- 2 edits in trunk/Source/JavaScriptCore
[wx] Unreviewed build fix. Add the build outputs dir to the list of build dirs, so we make sure it finds the API headers on all platforms.
- 10:38 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:37 AM Changeset in webkit [112122] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Merging r112111
- 10:36 AM Changeset in webkit [112121] by
-
- 6 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Merging r112004
- 10:29 AM Changeset in webkit [112120] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Merging r111915
- 10:25 AM Changeset in webkit [112119] by
-
- 7 edits2 adds in trunk
Source/WebCore: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464
Reviewed by Nikolas Zimmermann.
The text positioning elements data structure in RenderSVGText must be
updated when either the children of the corresponding element are
modified, or the length of the text inside the elements changes.
Previously, the call to clear the text positioning elements (to force
recomputation) was guarded by a flag. If code tried to invalidate when
the flag was not set, then something set the flag, the elements would
be invalid at use time.
This patch modifies the method that invalidates the positining
attributes so that the action always happens. It also renames the
method to more accurately reflect its function.
Test: svg/custom/delete-modified-text-in-defs-crash.svg
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::setTextInternal): Rename textDOMChanged to invalidateTextPositioningElements
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::invalidateTextPositioningElements): Rename
textDOMChanged to invalidateTextPositioningElements and remove the check against the needsPosition... flag.
- rendering/svg/RenderSVGText.h:
(RenderSVGText): Rename textDOMChanged to invalidateTextPositioningElements
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements
LayoutTests: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464
Reviewed by Nikolas Zimmermann.
- svg/custom/delete-modified-text-in-defs-crash-expected.txt: Added.
- svg/custom/delete-modified-text-in-defs-crash.svg: Added.
- 10:22 AM Changeset in webkit [112118] by
-
- 27 edits in releases/WebKitGTK/webkit-1.8/Source
Merging rr111914
- 10:16 AM Changeset in webkit [112117] by
-
- 3 edits in branches/subpixellayout/Source/WebCore
Correcting a usage of linesBoundingBox as a LayoutRect, removing a rename from RenderTheme to minimize patch size, and using new convenience functions in SubframeLoader to simplify logic.
- 10:04 AM Changeset in webkit [112116] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933
This would result in an attempt to create FontPlatformData
with the -webkit- prefixed family name.
Logic adapted from QWebSettings.
Patch by Pierre Rossi <pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::initFontDefaults):
- UIProcess/API/qt/qwebpreferences_p_p.h:
- 9:55 AM Changeset in webkit [112115] by
-
- 8 edits2 adds in trunk/LayoutTests
Rebaseline zoom-foreignObject.svg CR results
https://bugs.webkit.org/show_bug.cgi?id=82205
Unreviewed Chromium rebaseline.
Patch by Florin Malita <fmalita@google.com> on 2012-03-26
- platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-mac-leopard/svg/zoom/text/zoom-foreignObject-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/chromium/test_expectations.txt:
- 9:52 AM Changeset in webkit [112114] by
-
- 4 edits in trunk
REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute
https://bugs.webkit.org/show_bug.cgi?id=81802
Reviewed by Dan Bernstein.
Source/WebCore:
Covered by fast/forms/placeholder-set-attribute.html which should be less flaky.
Unfortunately no new test case as this bug requires a very specific set of conditions that I couldn't reproduce deterministically.
This is a regression from r110072: RenderTextControlSingleLine would rely on the placeholder's RenderLayer to properly repaint during
the first layout as the placeholder has overflow: hidden set. r110072 removed the layer in this case and thus we miss a repaint.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
For our first layout, we need to make sure our placeholder is painted. layoutBlockChild has a very similar logic to force repaint
on a first layout. We don't hit this logic as the placeholder is explicitly skipped in RenderTextControl::layoutSpecialExcludedChild.
LayoutTests:
- platform/mac/Skipped: Unskip the test on Mac. The other platforms are either
skipping it for other reasons or did not have a specific entry for the flakiness.
- 9:46 AM Changeset in webkit [112113] by
-
- 13 edits in trunk
REGRESSION(r110072): fast/forms/textfield-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=80531
Reviewed by Ojan Vafai.
Source/WebCore:
Tested by fast/forms/textfield-overflow.html (re-enabled after this change).
The existing code would happily query layout information before calling layout (FTW!).
The solution is to properly layout our object, then modify some dimensions as needed while
marking ourself as needing layout and then layouting again.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Implemented a proper 2 pass layout algorithm. Removed the |relayoutChildren| logic as:
- layoutBlock handles automatically logical height changes.
- we were not modifying the logical width between layouts so we don't need to force a
child relayout in this case.
LayoutTests:
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
This is a progression. The <input> now takes the full cell's space instead of
being shrunk.
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
Re-enable fast/forms/textfield-overflow.html as it should be passing.
Also disabled colspanMinWidth-vertical.html on platforms without a rebaseline.
- platform/chromium/test_expectations.txt:
Ditto and marked fast/repaint/search-field-cancel.html as failing image only.
- 9:43 AM Changeset in webkit [112112] by
-
- 1 edit5 adds15 deletes in trunk/LayoutTests
Supersede t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html
https://bugs.webkit.org/show_bug.cgi?id=82120
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-26
Reviewed by Pavel Feldman.
Test css2.1/t1504-c543-txt-decor-00-d-g.html is outdated and had
some issues, hence removed and superseding it with c543-txt-decor-000.html. Also,
copied two support png files from css2.1/support to css2.1/20110323/support.
- css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
- css2.1/20110323/c543-txt-decor-000.html: Added.
- css2.1/20110323/support/square-purple.png: Added.
- css2.1/20110323/support/square-teal.png: Added.
- css2.1/t1504-c543-txt-decor-00-d-g.html: Removed.
- platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
- platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
- platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
- platform/mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
- platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
- platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
- 9:24 AM Changeset in webkit [112111] by
-
- 3 edits in trunk/Source/WebKit/gtk
WebKitWebView signals with GError parameters cause crashes when using GObject Introspection
https://bugs.webkit.org/show_bug.cgi?id=81977
Patch by Gary Kramlich <grim@reaperworld.com> on 2012-03-26
Reviewed by Martin Robinson.
Added marshalers for BOOLEAN:OBJECT,STRING,BOXED and VOID:OBJECT,OBJECT,BOXED
and changed the signal signatures for WebKitWebView::load-fail and
WebKitWebView::resource-load-failed to use the new marshalers since
GError has been a GBoxed type since Gtk 2.26. This fixes these signals
for the gobject-introspection bindings.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- webkitmarshal.list:
- 9:24 AM Changeset in webkit [112110] by
-
- 1 edit2 adds in trunk/Source/WebCore
[BlackBerry] Upstream LayerCompositingThread.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79873
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-26
Reviewed by Rob Buis.
Initial upstream, no new tests.
- platform/graphics/blackberry/LayerCompositingThread.cpp: Added.
(WebCore):
(WebCore::LayerCompositingThread::create):
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore::LayerCompositingThread::setLayerRenderer):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):
(WebCore::LayerCompositingThread::setPluginView):
(WebCore::LayerCompositingThread::setMediaPlayer):
(WebCore::LayerCompositingThread::clearAnimations):
(WebCore::LayerCompositingThread::removeSublayer):
(WebCore::LayerCompositingThread::indexOfSublayer):
(WebCore::LayerCompositingThread::rootLayer):
(WebCore::LayerCompositingThread::removeFromSuperlayer):
(WebCore::LayerCompositingThread::setSublayers):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::setNeedsCommit):
(WebCore::LayerCompositingThread::scheduleCommit):
(WebCore::LayerCompositingThread::updateAnimations):
(WebCore::LayerCompositingThread::hasVisibleHolePunchRect):
(WebCore::LayerCompositingThread::createLayerRendererSurface):
- platform/graphics/blackberry/LayerCompositingThread.h: Added.
(Graphics):
(WebCore):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::bindContentsTexture):
(WebCore::LayerCompositingThread::getSublayers):
(WebCore::LayerCompositingThread::setSuperlayer):
(WebCore::LayerCompositingThread::superlayer):
(WebCore::LayerCompositingThread::drawTransform):
(WebCore::LayerCompositingThread::setDrawOpacity):
(WebCore::LayerCompositingThread::drawOpacity):
(WebCore::LayerCompositingThread::layerRendererSurface):
(WebCore::LayerCompositingThread::clearLayerRendererSurface):
(WebCore::LayerCompositingThread::setMaskLayer):
(WebCore::LayerCompositingThread::maskLayer):
(WebCore::LayerCompositingThread::setReplicaLayer):
(WebCore::LayerCompositingThread::replicaLayer):
(WebCore::LayerCompositingThread::getDrawRect):
(WebCore::LayerCompositingThread::getTransformedBounds):
(WebCore::LayerCompositingThread::hasMissingTextures):
(WebCore::LayerCompositingThread::isDirty):
(WebCore::LayerCompositingThread::isVisible):
(WebCore::LayerCompositingThread::setOpacity):
(WebCore::LayerCompositingThread::setTransform):
(WebCore::LayerCompositingThread::hasRunningAnimations):
(WebCore::LayerCompositingThread::numSublayers):
- 9:19 AM Changeset in webkit [112109] by
-
- 3 edits in trunk/Source/WebCore
Add a notification function for detaching to TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82142
Reviewed by Dimitri Glazkov.
Add willDetach() functio to TextFieldDecorator. This will be
needed if a decorator opens a popup UI on handleClick(), and the
popup UI should be closed when the attaching text field is
detached.
No new tests because of no behavior changes in any platforms.
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::hostInput):
Added. A utilify function to get an HTMLInputElement*.
(WebCore::TextFieldDecorationElement::updateImage): Use hostInput().
(WebCore::TextFieldDecorationElement::customStyleForRenderer): ditto.
(WebCore::TextFieldDecorationElement::detach): Added. Calls TextFieldDecorator::willDetach().
(WebCore::TextFieldDecorationElement::defaultEventHandler): Use hostInput().
- html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorator):
(TextFieldDecorationElement):
- 9:16 AM Changeset in webkit [112108] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the 32-bit build after r112021.
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
- 9:11 AM Changeset in webkit [112107] by
-
- 2 edits13 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, add Qt specific expected results for new passsing tests.
- platform/qt/Skipped: Skip a new failing test.
- platform/qt/editing/selection/selection-button-text-expected.png: Added.
- platform/qt/editing/selection/selection-button-text-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
- platform/qt/svg/custom/use-extern-href-expected.png: Added.
- platform/qt/svg/custom/use-extern-href-expected.txt: Added.
- platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
- platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
- 8:51 AM Changeset in webkit [112106] by
-
- 7 edits2 adds in trunk
[BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=82157
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake: Turn on ENABLE_FILE_SYSTEM for blackberry.
Source/WebCore:
AsyncFileSystemBlackBerry is responsible for asynchronous operating
on file system for the blackberry porting. It's just skeleton code
containing no implementation yet.
No new tests because of skeleton code.
- PlatformBlackBerry.cmake: Add AsyncFileSystemBlackBerry.cpp if ENABLE_FILE_SYSTEM is on.
- platform/AsyncFileSystem.cpp:
(WebCore):
- platform/blackberry/AsyncFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::toURL):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
- platform/blackberry/AsyncFileSystemBlackBerry.h: Added.
(WebCore):
(AsyncFileSystemBlackBerry):
Tools:
- Scripts/build-webkit:
Make ENABLE_FILE_SYSTEM default on for blackberry.
- 8:50 AM Changeset in webkit [112105] by
-
- 3 edits in trunk/Source/WebKit2
[Qt WK2] Disable/enable mouse events when displaying dialogs only for desktop view
https://bugs.webkit.org/show_bug.cgi?id=80542
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::enableMouseEvents):
(QQuickWebViewLegacyPrivate::disableMouseEvents):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewLegacyPrivate):
- 8:37 AM Changeset in webkit [112104] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] CredentialBackingStore implement encryptString() and decryptString()
https://bugs.webkit.org/show_bug.cgi?id=82204
Patch by Jonathan Dong <Jonathan Dong> on 2012-03-26
Reviewed by Rob Buis.
Implemented encryptedString() and decryptedString() in class CredentialBackingStore
by calling BlackBerry::Platform::Encryptor::encryptString() and
BlackBerry::Platform::Encryptor::encryptString() respectively.
No new tests.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):
- 8:36 AM Changeset in webkit [112103] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Skip failing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 8:30 AM Changeset in webkit [112102] by
-
- 6 edits in trunk
Web Inspector: 'use strict' exceptions stop in inspector code
https://bugs.webkit.org/show_bug.cgi?id=82199
Reviewed by Yury Semikhatsky.
Source/WebCore:
Accessing callee from within InjectedScript made inspector stop on handled exceptions.
I replaced it with Object.prototype.toString.call(obj) === "[object Arguments]".
- inspector/InjectedScriptSource.js:
LayoutTests:
- inspector/console/console-format-collections-expected.txt:
- inspector/console/console-format-collections.html:
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- 8:26 AM Changeset in webkit [112101] by
-
- 3 edits in trunk/Tools
[jhbuild] Explicitly disable DTrace when building glib.
https://bugs.webkit.org/show_bug.cgi?id=82145
Reviewed by Gustavo Noronha Silva.
DTrace support is not really needed by WebKit, so disabling it
helps avoid some build errors on more exotic platforms (such as
FreeBSD).
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
- 8:23 AM April 2012 Meeting edited by
- (diff)
- 8:22 AM April 2012 Meeting edited by
- (diff)
- 8:21 AM Changeset in webkit [112100] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for WinCE after r112039.
- interpreter/Register.h:
(Register): Removed inline keyword from decleration since
there is an ALWAYS_INLINE at the definition anyway.
- 8:16 AM Changeset in webkit [112099] by
-
- 3 edits2 adds in trunk
[CSS Regions] In region styling (@-webkit-region) the position for CSS rules is incorrectly computed
https://bugs.webkit.org/show_bug.cgi?id=81901
Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-26
Reviewed by Antti Koivisto.
Source/WebCore:
Right now CSS rules position does not take into account rules that are inside a @-webkit-region
declaration, leading to buggy behavior where rules that appear later in the document are superseded
by rules that appear earlier in the document (opposite as how things should be). The fix updates
the "global" rules counter once the rules in a @-webkit-region declaration have been added.
Tests: fast/regions/region-style-rule-position-expected.html
fast/regions/region-style-rule-position.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
Ref tests for bug #81901. Testing that CSS rules position is properly computed when having multiple
@-webkit-region declarations.
- fast/regions/region-style-rule-position-expected.html: Added.
- fast/regions/region-style-rule-position.html: Added.
- 8:14 AM Changeset in webkit [112098] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Remove tests, because the original change was rolled out.
- platform/qt-5.0-wk2/Skipped:
- 8:11 AM Changeset in webkit [112097] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/rendering
Removing dead code in RenderReplaced, and correcting use of LayoutUnits for integers from HTMLFrameBase.
- 7:54 AM Changeset in webkit [112096] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Make sure that purged directly composited images are re-created before a layer's sync.
https://bugs.webkit.org/show_bug.cgi?id=81771
Reviewed by Noam Rosenthal.
This fixes a regression in tst_qquickwebview introduced by r111567.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::updateContentBuffers):
- 7:49 AM Changeset in webkit [112095] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Disable focus ring in the mobile theme.
https://bugs.webkit.org/show_bug.cgi?id=81934
For mobile devices intended to be used only through
touch, the focus rings makes little sense and feels
awkward.
Patch by Pierre Rossi <pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.
No new tests. This is merely a cosmetic touch.
- platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::platformFocusRingColor):
- 7:47 AM Changeset in webkit [112094] by
-
- 2 edits in trunk/LayoutTests
[Qt] Running these two tests gives different results on 32 and
64 bit systems so they have been skipped until they're fixed.
Patch by János Badics <János Badics> on 2012-03-26
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 7:40 AM Changeset in webkit [112093] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][Qt] Fix compilation without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=79458
Reviewed by Tor Arne Vestbø.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent): Replace use of QApplication::wheelScrollLines()
with the constant that is actually used and usually not changed anyway.
- Target.pri: Remove widgets from Qt variable.
- UIProcess/qt/QtWebPageEventHandler.cpp: Remove unecessary include.
- WebProcess.pro: Use widgets for the process (for the time being).
- WebProcess/qt/WebProcessMainQt.cpp: Delegate QApplication creation to the caller.
(WebKit::WebProcessMainQt):
- qt/MainQt.cpp: Create QApplication here.
(WebKit):
(main):
- 7:38 AM Changeset in webkit [112092] by
-
- 8 edits in trunk/Source/WebCore
[BlackBerry] Clean up networking code and remove WML support.
https://bugs.webkit.org/show_bug.cgi?id=82170
Reviewed by Rob Buis.
This just removes the WML support of BlackBerry porting, which is already
removed from WebCore. No new tests needed.
- platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore):
- platform/network/blackberry/DeferredData.cpp:
(WebCore::DeferredData::DeferredData):
(WebCore::DeferredData::processDeferredData):
- platform/network/blackberry/DeferredData.h:
(DeferredData):
(WebCore::DeferredData::hasDeferredData):
- platform/network/blackberry/NetworkJob.cpp:
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(ResourceResponse):
- platform/network/blackberry/ResourceResponseBlackBerry.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
- 7:36 AM Changeset in webkit [112091] by
-
- 8 edits2 adds in trunk
Add invalid bounding box concept to SVG containers
https://bugs.webkit.org/show_bug.cgi?id=81104
Patch by Philip Rogers <pdr@google.com> on 2012-03-26
Reviewed by Nikolas Zimmermann.
Source/WebCore:
An empty <g> element needs to use an invalid bounding box because
an empty bounding box isn't the default state. This change
introduces the concept of an invalid object bounding box for
both RenderSVGContainer and RenderSVGRoot. Code that
does not explicitly check that the bounding box is valid
should be unaffected by this change. We use this new invalid
flag in computeContainerBoundingBoxes so that we do not
include invalid bounding boxes.
This change also contains a small fix in
RenderSVGContainer::toRenderSVGContainer which depended on
RenderSVGViewportContainer not inheriting from RenderSVGContainer,
which it now does.
Test: svg/custom/getBBox-empty-container.html
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::updateCachedBoundaries):
- rendering/svg/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::isObjectBoundingBoxValid):
(RenderSVGContainer):
(WebCore::toRenderSVGContainer):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::updateCachedBoundaries):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore):
(WebCore::updateObjectBoundingBox):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
- rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):
LayoutTests:
- svg/custom/getBBox-empty-container-expected.txt: Added.
- svg/custom/getBBox-empty-container.html: Added.
- 7:32 AM Changeset in webkit [112090] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Speed up the retainers build phase.
https://bugs.webkit.org/show_bug.cgi?id=81763
Replacing the edge iterator in retainers building phase
makes it run 10 times faster (400 ms vs. 4 sec).
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-26
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildRetainers):
- 7:20 AM Changeset in webkit [112089] by
-
- 2 edits in trunk/Source/WebKit2
Be more careful with git gui usage
Unreviewed typo fix.
- UIProcess/qt/QtViewportInteractionEngine.cpp: Remove additional line committed by accident.
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- 7:16 AM Changeset in webkit [112088] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Allow the viewport meta tag to be disabled for testing purposes
https://bugs.webkit.org/show_bug.cgi?id=81940
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-03-26
Reviewed by Adam Barth.
- public/WebSettings.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setViewportEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::viewportEnabled):
- 7:04 AM Changeset in webkit [112087] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Migrate InspectorCSSAgent to strict protocol types
https://bugs.webkit.org/show_bug.cgi?id=81923
Reviewed by Pavel Feldman.
No new tests, as this is a refactoring.
- inspector/CodeGeneratorInspector.py:
- inspector/InspectorCSSAgent.cpp:
(SelectorProfile):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorStyleSheet.cpp:
(WebCore::buildSourceRangeObject):
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::asProtocolValue):
(InspectorStyle):
(InspectorStyleSheet):
- 6:59 AM Changeset in webkit [112086] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: [chromium] rebaselining plugins/embed-attributes-style.
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- 6:50 AM Changeset in webkit [112085] by
-
- 3 edits in trunk/LayoutTests
Not reviewed: [chromium] rebaselining compositing/plugins/composited-plugin.
- platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png:
- platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png:
- 6:23 AM Changeset in webkit [112084] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Taps are sometimes not highlighted.
https://bugs.webkit.org/show_bug.cgi?id=82188
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.
Highlight any focusable parent element, or if none is found at least
the element returned by bestClickableNodeForTouchPoint.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
- 6:15 AM WebKitGTK/Releasing edited by
- Add link to Gentoo's make patchset (original patch doesn't apply that … (diff)
- 6:07 AM Changeset in webkit [112083] by
-
- 3 edits3 adds in trunk
Web Inspector: [REGRESSION] Workarounds for security checks when retrieving stylesheet rule lists are broken
https://bugs.webkit.org/show_bug.cgi?id=82191
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: http/tests/inspector/modify-cross-domain-rule.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
LayoutTests:
- http/tests/inspector/modify-cross-domain-rule-expected.txt: Added.
- http/tests/inspector/modify-cross-domain-rule.html: Added.
- http/tests/inspector/styles/modify-cross-domain-rule.css: Added.
(#inspected):
- 6:05 AM Changeset in webkit [112082] by
-
- 6 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files.
Source/WebCore:
- GNUmakefile.list.am: Add missing files.
Source/WTF:
- GNUmakefile.list.am: Add config.h to the source file list.
- 5:58 AM Changeset in webkit [112081] by
-
- 10 edits in branches/subpixellayout/Source/WebCore
Reverting RenderTheme painting to integers to avoid making platform code understand LayoutUnits.
- 5:42 AM Changeset in webkit [112080] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Cookies mismatch when login to gmail.
https://bugs.webkit.org/show_bug.cgi?id=82165
Redirection's response can add or update cookies. The cookies of ResourceRequest is dirty
in this case. We shouldn't copy the dirty cookie header from ResourceRequest to PlatformRequest
for redirection loading.
This issue didn't happen before because we used m_cookieData not the cookie header.
Now we use the cookie header to avoid storing double cookie's data, and m_cookieData is removed.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-26
Reviewed by George Staikos.
No new tests. It is a refactoring issue.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- 5:32 AM Changeset in webkit [112079] by
-
- 4 edits253 adds in trunk/LayoutTests
[Qt] Unskip passing tests from the 'new tests without expected results' section.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-03-26
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/compositing/overflow/ancestor-overflow-expected.png: Added.
- platform/qt/compositing/overflow/ancestor-overflow-expected.txt: Added.
- platform/qt/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
- platform/qt/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
- platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
- platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
- platform/qt/fast/backgrounds/border-radius-split-background-expected.png: Added.
- platform/qt/fast/backgrounds/border-radius-split-background-expected.txt: Added.
- platform/qt/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
- platform/qt/fast/backgrounds/border-radius-split-background-image-expected.txt: Added.
- platform/qt/fast/backgrounds/mask-box-image-expected.png: Added.
- platform/qt/fast/backgrounds/mask-box-image-expected.txt: Added.
- platform/qt/fast/block/float/fit_line_below_floats-expected.png: Added.
- platform/qt/fast/block/float/fit_line_below_floats-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
- platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
- platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
- platform/qt/fast/block/float/overhanging-tall-block-expected.png: Added.
- platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/qt/fast/block/lineboxcontain/none-expected.png: Added.
- platform/qt/fast/block/lineboxcontain/none-expected.txt: Added.
- platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
- platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
- platform/qt/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/qt/fast/borders/border-image-slice-constrained-expected.txt: Added.
- platform/qt/fast/borders/border-styles-split-expected.png: Added.
- platform/qt/fast/borders/border-styles-split-expected.txt: Added.
- platform/qt/fast/borders/mixed-border-styles-radius2-expected.png: Added.
- platform/qt/fast/borders/mixed-border-styles-radius2-expected.txt: Added.
- platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
- platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
- platform/qt/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/qt/fast/box-shadow/inset-box-shadows-expected.txt: Added.
- platform/qt/fast/box-shadow/scaled-box-shadow-expected.png: Added.
- platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
- platform/qt/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/qt/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/qt/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
- platform/qt/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
- platform/qt/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
- platform/qt/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
- platform/qt/fast/css/font-face-weight-matching-expected.png: Added.
- platform/qt/fast/css/font-face-weight-matching-expected.txt: Added.
- platform/qt/fast/css/non-empty-span-expected.png: Added.
- platform/qt/fast/css/non-empty-span-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
- platform/qt/fast/css/transformed-mask-expected.png: Added.
- platform/qt/fast/css/transformed-mask-expected.txt: Added.
- platform/qt/fast/dom/52776-expected.png: Added.
- platform/qt/fast/dom/52776-expected.txt: Added.
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
- platform/qt/fast/forms/listbox-bidi-align-expected.png: Added.
- platform/qt/fast/forms/listbox-bidi-align-expected.txt: Added.
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/range/input-appearance-range-expected.png: Added.
- platform/qt/fast/forms/range/input-appearance-range-expected.txt: Added.
- platform/qt/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/qt/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- platform/qt/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/qt/fast/forms/textfield-focus-ring-expected.txt: Added.
- platform/qt/fast/line-grid/line-align-left-edges-expected.png: Added.
- platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Added.
- platform/qt/fast/line-grid/line-align-right-edges-expected.png: Added.
- platform/qt/fast/line-grid/line-align-right-edges-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-contains-value-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-floating-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-floating-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-inside-columns-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-into-floats-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-into-floats-expected.txt: Added.
- platform/qt/fast/line-grid/line-grid-positioned-expected.png: Added.
- platform/qt/fast/line-grid/line-grid-positioned-expected.txt: Added.
- platform/qt/fast/multicol/positioned-split-expected.png: Added.
- platform/qt/fast/multicol/positioned-split-expected.txt: Added.
- platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
- platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
- platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
- platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
- platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/qt/fast/repaint/transform-rotate-and-remove-expected.png: Added.
- platform/qt/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
- platform/qt/fast/text/hyphenate-limit-before-after-expected.png: Added.
- platform/qt/fast/text/hyphenate-limit-before-after-expected.txt: Added.
- platform/qt/fast/text/unicode-variation-selector-expected.png: Added.
- platform/qt/fast/text/unicode-variation-selector-expected.txt: Added.
- platform/qt/fast/writing-mode/fallback-orientation-expected.png: Added.
- platform/qt/fast/writing-mode/fallback-orientation-expected.txt: Added.
- platform/qt/http/tests/misc/slow-loading-mask-expected.png: Added.
- platform/qt/http/tests/misc/slow-loading-mask-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
- platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
- platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
- platform/qt/svg/custom/mask-colorspace-expected.png: Added.
- platform/qt/svg/custom/mask-colorspace-expected.txt: Added.
- platform/qt/svg/custom/object-no-size-attributes-expected.png: Added.
- platform/qt/svg/custom/object-no-size-attributes-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-explicit-height-expected.png: Added.
- platform/qt/svg/custom/object-sizing-explicit-height-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-explicit-width-expected.png: Added.
- platform/qt/svg/custom/object-sizing-explicit-width-expected.txt: Added.
- platform/qt/svg/custom/path-moveto-only-rendering-expected.png: Added.
- platform/qt/svg/custom/path-moveto-only-rendering-expected.txt: Added.
- platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
- platform/qt/svg/custom/relative-sized-image-expected.png: Added.
- platform/qt/svg/custom/relative-sized-image-expected.txt: Added.
- platform/qt/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
- platform/qt/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
- platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
- platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-segmented-expected.png: Added.
- platform/qt/svg/custom/svg-fonts-segmented-expected.txt: Added.
- platform/qt/svg/custom/use-disappears-after-style-update-expected.png: Added.
- platform/qt/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/qt/svg/filters/feColorMatrix-offset-expected.png: Added.
- platform/qt/svg/filters/feColorMatrix-offset-expected.txt: Added.
- platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
- platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
- platform/qt/svg/filters/feImage-change-target-id-expected.png: Added.
- platform/qt/svg/filters/feImage-change-target-id-expected.txt: Added.
- platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
- platform/qt/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-position-expected.png: Added.
- platform/qt/svg/filters/feImage-position-expected.txt: Added.
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- platform/qt/svg/filters/feImage-remove-target-expected.png: Added.
- platform/qt/svg/filters/feImage-remove-target-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-expected.png: Added.
- platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-style-change-expected.png: Added.
- platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.
- platform/qt/svg/filters/filter-placement-issue-expected.png: Added.
- platform/qt/svg/filters/filter-placement-issue-expected.txt: Added.
- platform/qt/svg/filters/filter-refresh-expected.png: Added.
- platform/qt/svg/filters/filter-refresh-expected.txt: Added.
- platform/qt/svg/filters/filterRes1-expected.png: Added.
- platform/qt/svg/filters/filterRes1-expected.txt: Added.
- platform/qt/svg/filters/filterRes3-expected.png: Added.
- platform/qt/svg/filters/filterRes3-expected.txt: Added.
- platform/qt/svg/filters/parent-children-with-same-filter-expected.png: Added.
- platform/qt/svg/filters/parent-children-with-same-filter-expected.txt: Added.
- platform/qt/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/qt/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
- platform/qt/svg/foreignObject/fO-parent-display-none-expected.png: Added.
- platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
- platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
- platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/qt/svg/repaint/filter-repaint-expected.png: Added.
- platform/qt/svg/repaint/filter-repaint-expected.txt: Added.
- platform/qt/svg/text/append-text-node-to-tspan-expected.png: Added.
- platform/qt/svg/text/append-text-node-to-tspan-expected.txt: Added.
- platform/qt/svg/text/modify-text-node-in-tspan-expected.png: Added.
- platform/qt/svg/text/modify-text-node-in-tspan-expected.txt: Added.
- platform/qt/svg/text/remove-text-node-from-tspan-expected.png: Added.
- platform/qt/svg/text/remove-text-node-from-tspan-expected.txt: Added.
- platform/qt/svg/text/remove-tspan-from-text-expected.png: Added.
- platform/qt/svg/text/remove-tspan-from-text-expected.txt: Added.
- platform/qt/svg/wicd/sizing-flakiness-expected.png: Added.
- platform/qt/svg/wicd/sizing-flakiness-expected.txt: Added.
- 5:11 AM Changeset in webkit [112078] by
-
- 4 edits in trunk/Source/WebCore
Increase code sharing between StylePropertySet and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=81960
Reviewed by Antti Koivisto.
Use longhands declaration from CSSPropertyLonghand in StylePropertySet in order
to avoid code duplication.
No new tests : refactoring only, we shouldn't have any behavior difference.
- css/CSSPropertyLonghand.cpp:
(WebCore::backgroundLonghand):
Re-order the array to match the spec default order.
(WebCore::webkitMaskLonghand):
Re-order to match the original order.
(WebCore::webkitTransformOriginLonghand):
A LayoutTest shows that a property was missing.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::asText):
- css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
- 4:56 AM Changeset in webkit [112077] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Assert in GestureTapHighlighter.
https://bugs.webkit.org/show_bug.cgi?id=82187
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.
Adjust the boundaries of the center-rect before performing the intersection test,
since adjusting the boundary may cause a new intersection.
- page/GestureTapHighlighter.cpp:
- 4:52 AM Changeset in webkit [112076] by
-
- 29 edits in trunk/Source/WebCore
Split MediaList into internal and CSSOM types
https://bugs.webkit.org/show_bug.cgi?id=82149
Reviewed by Andread Kling.
MediaList is a CSSOM type and should not be used internally.
- Use new type MediaQuerySet internally to represent a collection of media queries.
- Create MediaList wrapper on-demand for CSSOM purposes only.
This moves us forward in separating CSSOM from the internal stylesheet implementation.
MediaQuerySet really belongs to a file of its own but that is not part of this patch.
- css/CSSGrammar.y:
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::create):
(WebCore):
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):
- css/CSSImportRule.h:
(WebCore):
(CSSImportRule):
(WebCore::CSSImportRule::mediaQueries):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::cssText):
- css/CSSMediaRule.h:
(WebCore::CSSMediaRule::create):
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::mediaQueries):
(CSSMediaRule):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseMediaQuery):
(WebCore::CSSParser::createMediaQuerySet):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::updateLastMediaLine):
- css/CSSParser.h:
(WebCore):
(CSSParser):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSheet.cpp:
(WebCore):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::setMediaQueries):
- css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::mediaQueries):
- css/MediaList.cpp:
(WebCore):
(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::MediaQuerySet::~MediaQuerySet):
(WebCore::parseMediaDescriptor):
(WebCore::MediaQuerySet::parse):
(WebCore::MediaQuerySet::add):
(WebCore::MediaQuerySet::remove):
(WebCore::MediaQuerySet::addMediaQuery):
(WebCore::MediaQuerySet::mediaText):
(WebCore::MediaQuerySet::ensureMediaList):
- Use OwnPtr<> for MediaQuery ownership.
- Move the appropriate functions to MediaQuerySet.
- Clean up a bit to make this more readable and better aligned to WebKit style.
(WebCore::MediaList::MediaList):
(WebCore::MediaList::~MediaList):
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::item):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
- css/MediaList.h:
(WebCore):
(WebCore::MediaQuerySet::create):
(WebCore::MediaQuerySet::createAllowingDescriptionSyntax):
(MediaQuerySet):
(WebCore::MediaQuerySet::queryVector):
(WebCore::MediaQuerySet::lastLine):
(WebCore::MediaQuerySet::setLastLine):
(MediaList):
(WebCore::MediaList::ref):
(WebCore::MediaList::deref):
(WebCore::MediaList::length):
(WebCore::MediaList::mediaText):
(WebCore::MediaList::queries):
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryEvaluator.h:
(WebCore):
(MediaQueryEvaluator):
- css/MediaQueryList.cpp:
(WebCore::MediaQueryList::create):
(WebCore::MediaQueryList::MediaQueryList):
- css/MediaQueryList.h:
(WebCore):
(MediaQueryList):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::evaluate):
(WebCore::MediaQueryMatcher::matchMedia):
- css/MediaQueryMatcher.h:
(WebCore):
(MediaQueryMatcher):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- css/StyleSheet.cpp:
(WebCore::StyleSheet::~StyleSheet):
Move the media query ownership to CSSStyleSheet where it belongs.
(WebCore):
- css/StyleSheet.h:
(WebCore::StyleSheet::media):
(StyleSheet):
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::linkMediaAttributeIsScreen):
- inspector/InspectorStyleSheet.cpp:
(WebCore::buildMediaObject):
- 4:17 AM Changeset in webkit [112075] by
-
- 2 edits in trunk/Source/WebCore
[Qt]WK2] TextureMapperShaderManager should query the program map before creating new shader program instances.
https://bugs.webkit.org/show_bug.cgi?id=82178
If TextureMapperShaderManager already has a reference to an instance of the
requested shader program type, this instance should be reused instead of
creating a new one.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderManager::getShaderProgram):
- 4:00 AM Changeset in webkit [112074] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Removing an unused paramter in LayoutRepainter.
- 3:51 AM Changeset in webkit [112073] by
-
- 4 edits in trunk
Unreviewed, rolling out r111993.
http://trac.webkit.org/changeset/111993
https://bugs.webkit.org/show_bug.cgi?id=82184
It broke layout and API tests and made WTR crash (Requested by
Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-26
Source/WebKit2:
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 3:18 AM Changeset in webkit [112072] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Web Inspector: dedicated worker inspector is empty
https://bugs.webkit.org/show_bug.cgi?id=82181
"beforeunload" event for worker inspector front-end is ingnored if the
window url is "about:blank" as it is just unload of the default content
before the front-end page load.
Reviewed by Pavel Feldman.
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
- 3:15 AM Changeset in webkit [112071] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: split nodes and containment edges into two different arrays
https://bugs.webkit.org/show_bug.cgi?id=81930
Extract heap profile nodes and edges into two separate arrays. This
way we will have a continuous array of the heap graph nodes and can
aviod additional mapping between node index and its position in the
heap snapshot.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildContinuousNodeArray):
(WebInspector.HeapSnapshot.prototype._createOnlyNodesArray):
(WebInspector.HeapSnapshot.prototype._restoreNodeTypes):
(WebInspector.HeapSnapshot.prototype._createRetainmentEdgesArray):
(WebInspector.HeapSnapshot.prototype._createContainmentEdgesArray):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
- 2:55 AM Changeset in webkit [112070] by
-
- 5 edits in trunk
Web Inspector: move resource loading logic from SourceMapParser to CompilerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=81897
Reviewed by Vsevolod Vlasov.
Source/WebCore:
SourceMapParser should only deal with payload parsing.
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.SourceMapPayload):
(WebInspector.SourceMapParser):
(WebInspector.SourceMapParser.prototype.sourceContent):
(WebInspector.SourceMapParser.prototype.findEntry):
(WebInspector.SourceMapParser.prototype.findEntryReversed):
- inspector/front-end/ContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- 2:36 AM Changeset in webkit [112069] by
-
- 1 edit4 moves2 adds23 deletes in trunk/LayoutTests
Reverting r112060, css3/selector3 expectations for chromium.
- 2:28 AM Changeset in webkit [112068] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Adding missing pixel snapping in RenderFieldSet and changing a toInt() call to an abstraction-friendly floorToInt().
- 2:27 AM Changeset in webkit [112067] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: marking more flaky chromium css3/selector3 tests.
- platform/chromium/test_expectations.txt:
- 2:07 AM Changeset in webkit [112066] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
https://bugs.webkit.org/show_bug.cgi?id=82175
We were using aString.indexOf("Window") but it is not effective from performance point of view.
I'm replaced it with RegExp.
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
- 2:04 AM Changeset in webkit [112065] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: marking flaky chromium css3/selector3 tests.
- platform/chromium/test_expectations.txt:
- 1:56 AM Changeset in webkit [112064] by
-
- 6 edits in trunk
Web Inspector: breakpoints should be disabled while live editing JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=81947
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change disables (removes from the backend) the breakpoints while editing script.
Undoing or committing the change restores the breakpoints. Main logic is implemented within
JavaScriptSourceFrame, but it required minor tweaking of the text editor: more correct
undo/redo wrapper and better detection of the noop opterations.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.before):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.after):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
LayoutTests:
- inspector/editor/highlighter-basics-expected.txt:
- 1:55 AM Changeset in webkit [112063] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening, remove non-existing tests from Skipped lists.
- platform/qt/Skipped:
- platform/wk2/Skipped:
- 1:38 AM Changeset in webkit [112062] by
-
- 1 edit7 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new fast/hidpi tests.
- platform/gtk/fast/hidpi/image-set-as-background-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-background-repeat-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-simple-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
- 1:35 AM Changeset in webkit [112061] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp
Second round of RenderListMarker cleanup. Properly measuring text with integers.
- 1:27 AM Changeset in webkit [112060] by
-
- 1 edit314 adds in trunk/LayoutTests
Not reviewed: chromium expectations for css3/selectors3 re-added for snow -leopard.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-10-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-11-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-118-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-119-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-120-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-122-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-144-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-148-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14d-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14e-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-150-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-151-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-152-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-153-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-154-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155d-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-157-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-158-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-159-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-16-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-160-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-17-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170d-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-171-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-176-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-178-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-180a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-181-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-182-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-183-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184d-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184e-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184f-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-2-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-20-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-30-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-31-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-32-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-33-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-34-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-35-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-36-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-37-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-38-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-4-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42a-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44d-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-47-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-48-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-5-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-50-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-51-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-52-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-53-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-54-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-55-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-56-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-59-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-6-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-60-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-61-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-62-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-63-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-65-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-67-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-79-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-8-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-80-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-83-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-86-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-89-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-9-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-91-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-92-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-93-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1b-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d2-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d2-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d3-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d3-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d4-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d4-expected.txt: Added.
- 1:02 AM Changeset in webkit [112059] by
-
- 13 edits in trunk/Source
[chromium] Route willBeginFrame from compositor to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=82171
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(WebCore::CCLayerTreeHost::willBeginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrame):
Source/WebKit/chromium:
- public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::willBeginCompositorFrame):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willBeginFrame):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::willBeginFrame):
(MockLayerTreeHostClient):
- tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::willBeginFrame):
- 12:34 AM Changeset in webkit [112058] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, skip plugins/netscape-dom-access-and-reload.html
failing on GTK and Qt.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 12:27 AM Changeset in webkit [112057] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r112022.
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
- 12:20 AM Changeset in webkit [112056] by
-
- 2 edits293 deletes in trunk/LayoutTests
Not reviewed: [chromium] preparing to generate proper snow leopard css3/selectors3/xml tests.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-10-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-11-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-118-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-119-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-120-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-122-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-144-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-148-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14d-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14e-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-150-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-151-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-152-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-153-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-154-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155d-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-157-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-158-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-159-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-16-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-160-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170d-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-171-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-176-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-178-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-180a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-181-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-182-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-183-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184d-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184e-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184f-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-20-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-30-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-31-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-32-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-33-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-34-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-35-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-36-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-37-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-38-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-4-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44d-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45c-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-47-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-48-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-5-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-50-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-51-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-52-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-53-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-54-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-55-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-56-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-59-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-6-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-60-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-62-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-63-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-65-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-67-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-79-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-8-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-80-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-83-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-86-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-89-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-9-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-93-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99b-expected.png: Removed.
- platform/chromium/test_expectations.txt:
Mar 25, 2012:
- 11:44 PM Changeset in webkit [112055] by
-
- 27 edits4 adds in trunk
[Shadow DOM] Add Reified DOM Tree traversal internal APIs.
https://bugs.webkit.org/show_bug.cgi?id=79197
Reviewed by Dimitri Glazkov.
Add internal APIs which can be used to traverse Reified DOM tree, which is
a result of node distribution algorithm explained in Shadow DOM spec.
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html
Every public functions defined in ReifiedTreeTraversal are static
functions and are named in a similar way to ones defined in WebCore::Node class.
The only difference is that ReifiedTreeTraversal APIs consider shadow
hosts and also traverse nodes is Shadow DOM subtrees, crossing shadow's upper and lower boundary
transparently.
There is no actual client which uses these APIs. Follow-up patches for FocusNavigation
and EventDispatcher will use the APIs so that they can traverse node in reified tree order.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/shadow/reified-tree-traversal.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ReifiedTreeTraversal.cpp: Added.
(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ReifiedTreeTraversal::firstChild):
(WebCore::ReifiedTreeTraversal::lastChild):
(WebCore::ReifiedTreeTraversal::lastChildWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traverseChild):
(WebCore::ReifiedTreeTraversal::traverseLightChildren):
(WebCore::ReifiedTreeTraversal::traverseNode):
(WebCore::ReifiedTreeTraversal::nextSibling):
(WebCore::ReifiedTreeTraversal::previousSibling):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::traverseSiblingInCurrentTree):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ReifiedTreeTraversal::escapeFallbackContentElement):
(WebCore::ReifiedTreeTraversal::traverseNodeEscapingFallbackContents):
(WebCore::ReifiedTreeTraversal::parentNode):
(WebCore::ReifiedTreeTraversal::parentNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::parentNodeOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::parentNodeInCurrentTree):
(WebCore::ReifiedTreeTraversal::parentNodeBackToYoungerShadowRootOrHost):
(WebCore::ReifiedTreeTraversal::adjustedParentNode):
(WebCore::ReifiedTreeTraversal::traverseNextNode):
(WebCore::ReifiedTreeTraversal::traverseNextNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traversePreviousNode):
(WebCore::ReifiedTreeTraversal::traversePreviousNodeWithoutCrossingUpperBoundary):
- dom/ReifiedTreeTraversal.h: Added.
(WebCore):
(ReifiedTreeTraversal):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::selectionFor):
(WebCore):
- dom/ShadowTree.h:
(WebCore):
(ShadowTree):
- html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::findFor):
- html/shadow/HTMLContentSelector.h:
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
- html/shadow/InsertionPoint.h:
(WebCore::isInsertionPoint):
(WebCore::toInsertionPoint):
(WebCore):
- testing/Internals.cpp:
(WebCore::Internals::nextSiblingInReifiedTree):
(WebCore):
(WebCore::Internals::firstChildInReifiedTree):
(WebCore::Internals::lastChildInReifiedTree):
(WebCore::Internals::traverseNextNodeInReifiedTree):
(WebCore::Internals::traversePreviousNodeInReifiedTree):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/reified-tree-traversal-expected.txt: Added.
- fast/dom/shadow/reified-tree-traversal.html: Added.
- platform/efl/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 11:20 PM Changeset in webkit [112054] by
-
- 2 edits in trunk/LayoutTests
[Qt] unexpected result in fast/js/large-expressions.html
https://bugs.webkit.org/show_bug.cgi?id=76379
- platform/qt/Skipped: Skip it until proper fix.
- 11:17 PM Changeset in webkit [112053] by
-
- 3 edits2 adds in trunk
Web Inspector: Indenting fully selected line should not indent the line next to it
https://bugs.webkit.org/show_bug.cgi?id=81758
Source/WebCore:
In the editor, you can select a whole line by moving caret at 0 column
position and pressing Shift + Arrow Down/Up. After that, pressing Tab
indents 2 lines: fully selected one and the line next to it. The patch
changes this behaviour to indent only fully selected line since that is
what pretty-match all the other code editors do.
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.
Test: inspector/editor/indentation.html
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._indentLines):
Do not insert indent at the begging of the last line if a selection
ends on its 0 column.
(WebInspector.TextEditorMainPanel.prototype._unindentLines):
Do not remove indent at the begging of the last line if a selection
ends on its 0 column.
LayoutTests:
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.
- inspector/editor/indentation-expected.txt: Added.
- inspector/editor/indentation.html: Added.
- 11:12 PM Changeset in webkit [112052] by
-
- 1 edit1 move in trunk/LayoutTests
[Qt] Unreviewed morning gardening after r112023.
- platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Removed unnecessary Qt specific txt.
- platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt: Updated.
- 11:11 PM Changeset in webkit [112051] by
-
- 4 edits2 adds in trunk
Crash in ContainerNode::resumePostAttachCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=82159
Reviewed by Hajime Morita.
Source/WebCore:
Test: plugins/object-onfocus-mutation-crash.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::resumePostAttachCallbacks): dispatching post attach
callbacks when our attach depth is 1 can fire mutation events such as onfocus
which can blow away |this|. Need to protect it with a RefPtr.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::attach): add calls to suspend attach callbacks
until the function completes.
LayoutTests:
- plugins/object-onfocus-mutation-crash-expected.txt: Added.
- plugins/object-onfocus-mutation-crash.html: Added.
- 11:04 PM Changeset in webkit [112050] by
-
- 4 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening after r112022.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.png: Added.
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
- 11:02 PM Changeset in webkit [112049] by
-
- 6 edits in trunk/Source
[chromium] Layers with animating transforms should prepaint even if they are not visible yet
https://bugs.webkit.org/show_bug.cgi?id=82117
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-25
Reviewed by Adrienne Walker.
Source/WebCore:
For animating transforms, instead of early-outing when the layer's
visible rect is empty, let it prepaint regardless.
For now, we just only paint the outermost tiles, and only for small
layers, with at most 9 tiles.
This changes the behaviour of ContentLayerChromium's
idlePaintContentsIfDirty() so I've guarded the behaviour of the two
prepainting functions that it calls to ensure the old behaviour holds
without animations, and the new behaviour works with them.
Unit test: TiledLayerChromiumTest.idlePaintZeroSizedLayer
TiledLayerChromiumTest.idlePaintZeroSizedAnimatingLayer
TiledLayerChromiumTest.idlePaintNonVisibleLayers
TiledLayerChromiumTest.idlePaintNonVisibleAnimatingLayers
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::numPaintedTiles):
(TiledLayerChromium):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::tileSize):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):
(WTF::idlePaintRepeat):
(WTF::testHaveOuterTiles):
- 10:47 PM Changeset in webkit [112048] by
-
- 7 edits1 add in trunk
[wx] Unreviewed build fix. Move WTF to its own static lib build.
- 10:37 PM Changeset in webkit [112047] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new failing tests, decrease test coverage.
- platform/qt-5.0-wk2/Skipped: Skip new failing tests - https://bugs.webkit.org/show_bug.cgi?id=82167
- platform/qt/Skipped: Skip a new failing test because ENABLE(MUTATION_OBSERVERS) is disabled.
- 9:46 PM Changeset in webkit [112046] by
-
- 213 edits6 copies2 adds in trunk/LayoutTests
[EFL] More gardening. Update baselines and expectations in
fast/table and fast/text after the recent jhbuild and font
updates.
- platform/efl/fast/table/002-expected.png:
- platform/efl/fast/table/003-expected.png:
- platform/efl/fast/table/003-expected.txt:
- platform/efl/fast/table/004-expected.png:
- platform/efl/fast/table/005-expected.png:
- platform/efl/fast/table/007-expected.png:
- platform/efl/fast/table/009-expected.png:
- platform/efl/fast/table/012-expected.png:
- platform/efl/fast/table/016-expected.png:
- platform/efl/fast/table/017-expected.png:
- platform/efl/fast/table/018-expected.png:
- platform/efl/fast/table/020-expected.png:
- platform/efl/fast/table/023-expected.png:
- platform/efl/fast/table/025-expected.png:
- platform/efl/fast/table/028-expected.png:
- platform/efl/fast/table/028-vertical-expected.png:
- platform/efl/fast/table/030-expected.png:
- platform/efl/fast/table/035-expected.png:
- platform/efl/fast/table/035-vertical-expected.png:
- platform/efl/fast/table/036-expected.png:
- platform/efl/fast/table/038-expected.png:
- platform/efl/fast/table/038-vertical-expected.png:
- platform/efl/fast/table/039-expected.png:
- platform/efl/fast/table/041-expected.png:
- platform/efl/fast/table/100-percent-cell-width-expected.png:
- platform/efl/fast/table/add-before-anonymous-child-expected.png:
- platform/efl/fast/table/append-cells-expected.png:
- platform/efl/fast/table/append-cells2-expected.png:
- platform/efl/fast/table/auto-with-percent-height-expected.png:
- platform/efl/fast/table/auto-with-percent-height-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/001-expected.png:
- platform/efl/fast/table/border-collapsing/001-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/002-expected.png:
- platform/efl/fast/table/border-collapsing/002-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/003-expected.png:
- platform/efl/fast/table/border-collapsing/003-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
- platform/efl/fast/table/cell-absolute-child-expected.png:
- platform/efl/fast/table/cell-pref-width-invalidation-expected.txt:
- platform/efl/fast/table/cell-width-auto-expected.png:
- platform/efl/fast/table/cellindex-expected.png:
- platform/efl/fast/table/colgroup-preceded-by-caption-expected.png:
- platform/efl/fast/table/colgroup-spanning-groups-rules-expected.png:
- platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
- platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/efl/fast/table/dynamic-cellpadding-expected.png:
- platform/efl/fast/table/dynamic-descendant-percentage-height-expected.png:
- platform/efl/fast/table/early-table-layout-expected.png:
- platform/efl/fast/table/edge-offsets-expected.png:
- platform/efl/fast/table/fixed-nested-expected.png:
- platform/efl/fast/table/fixed-table-non-cell-in-row-expected.png:
- platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png:
- platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png:
- platform/efl/fast/table/fixed-table-with-percent-width-inside-div-expected.png:
- platform/efl/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png:
- platform/efl/fast/table/fixed-table-with-small-percent-width-expected.png:
- platform/efl/fast/table/floating-th-expected.png:
- platform/efl/fast/table/form-with-table-style-expected.png:
- platform/efl/fast/table/generated-caption-expected.png:
- platform/efl/fast/table/giantRowspan2-expected.png:
- platform/efl/fast/table/height-percent-test-expected.png:
- platform/efl/fast/table/insert-before-anonymous-ancestors-expected.png:
- platform/efl/fast/table/insert-cell-before-form-expected.png:
- platform/efl/fast/table/insert-row-before-form-expected.png:
- platform/efl/fast/table/invisible-cell-background-expected.png:
- platform/efl/fast/table/large-width-expected.png:
- platform/efl/fast/table/max-width-integer-overflow-expected.txt:
- platform/efl/fast/table/nobr-expected.png:
- platform/efl/fast/table/overflowHidden-expected.png:
- platform/efl/fast/table/overflowHidden-expected.txt:
- platform/efl/fast/table/percent-heights-expected.png:
- platform/efl/fast/table/relative-position-containment-expected.png:
- platform/efl/fast/table/remove-td-display-none-expected.png:
- platform/efl/fast/table/row-height-recalc-expected.png:
- platform/efl/fast/table/rowindex-expected.png:
- platform/efl/fast/table/rowspan-paint-order-vertical-expected.png:
- platform/efl/fast/table/rtl-cell-display-none-assert-expected.png:
- platform/efl/fast/table/rules-attr-dynchange1-expected.png:
- platform/efl/fast/table/rules-attr-dynchange2-expected.png:
- platform/efl/fast/table/spanOverlapRepaint-expected.png:
- platform/efl/fast/table/table-after-child-in-table-expected.png:
- platform/efl/fast/table/table-and-parts-outline-expected.png:
- platform/efl/fast/table/table-before-child-in-table-expected.png:
- platform/efl/fast/table/table-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
- platform/efl/fast/table/table-cell-after-child-in-block-expected.png:
- platform/efl/fast/table/table-cell-before-child-in-block-expected.png:
- platform/efl/fast/table/table-cell-before-child-in-table-expected.png:
- platform/efl/fast/table/table-display-types-expected.png:
- platform/efl/fast/table/table-display-types-strict-expected.png:
- platform/efl/fast/table/table-display-types-vertical-expected.png:
- platform/efl/fast/table/table-hspace-align-center-expected.png:
- platform/efl/fast/table/table-row-after-child-in-block-expected.png:
- platform/efl/fast/table/table-row-before-child-in-block-expected.png:
- platform/efl/fast/table/table-row-before-child-in-table-expected.png:
- platform/efl/fast/table/table-row-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
- platform/efl/fast/table/table-row-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
- platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
- platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png: Copied from LayoutTests/platform/efl/fast/table/height-percent-test-expected.png.
- platform/efl/fast/table/table-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
- platform/efl/fast/table/text-field-baseline-expected.png:
- platform/efl/fast/table/text-field-baseline-expected.txt:
- platform/efl/fast/table/unbreakable-images-quirk-expected.png:
- platform/efl/fast/table/unused-percent-heights-expected.png:
- platform/efl/fast/table/vertical-align-baseline-expected.png:
- platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
- platform/efl/fast/text/atsui-multiple-renderers-expected.png:
- platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
- platform/efl/fast/text/atsui-partial-selection-expected.png:
- platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
- platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
- platform/efl/fast/text/atsui-spacing-features-expected.png:
- platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/efl/fast/text/backslash-to-yen-sign-expected.png:
- platform/efl/fast/text/basic/001-expected.png:
- platform/efl/fast/text/basic/002-expected.png:
- platform/efl/fast/text/basic/003-expected.png:
- platform/efl/fast/text/basic/004-expected.png:
- platform/efl/fast/text/basic/006-expected.png:
- platform/efl/fast/text/basic/007-expected.png:
- platform/efl/fast/text/basic/008-expected.png:
- platform/efl/fast/text/basic/012-expected.png:
- platform/efl/fast/text/basic/014-expected.png:
- platform/efl/fast/text/basic/015-expected.png:
- platform/efl/fast/text/basic/generic-family-changes-expected.png:
- platform/efl/fast/text/basic/generic-family-reset-expected.png:
- platform/efl/fast/text/break-word-expected.png:
- platform/efl/fast/text/capitalize-empty-generated-string-expected.png:
- platform/efl/fast/text/capitalize-preserve-nbsp-expected.png:
- platform/efl/fast/text/cg-vs-atsui-expected.png:
- platform/efl/fast/text/decorations-transformed-expected.png:
- platform/efl/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
- platform/efl/fast/text/emphasis-avoid-ruby-expected.png:
- platform/efl/fast/text/emphasis-overlap-expected.png:
- platform/efl/fast/text/fake-italic-expected.png:
- platform/efl/fast/text/hyphenate-character-expected.png:
- platform/efl/fast/text/hyphenate-limit-before-after-expected.png:
- platform/efl/fast/text/hyphenate-limit-lines-expected.png:
- platform/efl/fast/text/justified-selection-at-edge-expected.png:
- platform/efl/fast/text/justified-selection-expected.png:
- platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
- platform/efl/fast/text/justify-padding-distribution-expected.png: Added.
- platform/efl/fast/text/line-breaks-after-white-space-expected.png:
- platform/efl/fast/text/line-breaks-expected.png:
- platform/efl/fast/text/monospace-width-cache-expected.png:
- platform/efl/fast/text/reset-emptyRun-expected.png:
- platform/efl/fast/text/selection-hard-linebreak-expected.png:
- platform/efl/fast/text/shadow-translucent-fill-expected.png:
- platform/efl/fast/text/should-use-atsui-expected.png:
- platform/efl/fast/text/soft-hyphen-4-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png.
- platform/efl/fast/text/softHyphen-expected.png:
- platform/efl/fast/text/text-letter-spacing-expected.png:
- platform/efl/fast/text/textIteratorNilRenderer-expected.png:
- platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
- platform/efl/fast/text/wbr-expected.png:
- platform/efl/fast/text/wbr-in-pre-crash-expected.png:
- platform/efl/fast/text/whitespace/002-expected.png:
- platform/efl/fast/text/whitespace/002-expected.txt:
- platform/efl/fast/text/whitespace/003-expected.png:
- platform/efl/fast/text/whitespace/003-expected.txt:
- platform/efl/fast/text/whitespace/004-expected.png:
- platform/efl/fast/text/whitespace/004-expected.txt:
- platform/efl/fast/text/whitespace/005-expected.png:
- platform/efl/fast/text/whitespace/005-expected.txt:
- platform/efl/fast/text/whitespace/006-expected.png:
- platform/efl/fast/text/whitespace/006-expected.txt:
- platform/efl/fast/text/whitespace/007-expected.png:
- platform/efl/fast/text/whitespace/007-expected.txt:
- platform/efl/fast/text/whitespace/008-expected.png:
- platform/efl/fast/text/whitespace/008-expected.txt:
- platform/efl/fast/text/whitespace/009-expected.png:
- platform/efl/fast/text/whitespace/009-expected.txt:
- platform/efl/fast/text/whitespace/010-expected.png:
- platform/efl/fast/text/whitespace/010-expected.txt:
- platform/efl/fast/text/whitespace/011-expected.png:
- platform/efl/fast/text/whitespace/011-expected.txt:
- platform/efl/fast/text/whitespace/012-expected.png:
- platform/efl/fast/text/whitespace/012-expected.txt:
- platform/efl/fast/text/whitespace/013-expected.png:
- platform/efl/fast/text/whitespace/013-expected.txt:
- platform/efl/fast/text/whitespace/014-expected.png:
- platform/efl/fast/text/whitespace/014-expected.txt:
- platform/efl/fast/text/whitespace/015-expected.png:
- platform/efl/fast/text/whitespace/015-expected.txt:
- platform/efl/fast/text/whitespace/016-expected.png:
- platform/efl/fast/text/whitespace/016-expected.txt:
- platform/efl/fast/text/whitespace/018-expected.png:
- platform/efl/fast/text/whitespace/018-expected.txt:
- platform/efl/fast/text/whitespace/020-expected.png:
- platform/efl/fast/text/whitespace/020-expected.txt:
- platform/efl/fast/text/whitespace/021-expected.png:
- platform/efl/fast/text/whitespace/021-expected.txt:
- platform/efl/fast/text/whitespace/022-expected.png:
- platform/efl/fast/text/whitespace/025-expected.png:
- platform/efl/fast/text/whitespace/025-expected.txt:
- platform/efl/fast/text/whitespace/027-expected.png:
- platform/efl/fast/text/whitespace/027-expected.txt:
- platform/efl/fast/text/whitespace/030-expected.png:
- platform/efl/fast/text/whitespace/030-expected.txt:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/efl/fast/text/whitespace/pre-break-word-expected.png:
- platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- platform/efl/fast/text/whitespace/tab-character-basics-expected.png:
- platform/efl/fast/text/wide-zero-width-space-expected.png:
- platform/efl/fast/text/word-break-expected.png:
- platform/efl/fast/text/word-break-run-rounding-expected.png:
- platform/efl/fast/text/word-break-soft-hyphen-expected.png:
- platform/efl/fast/text/word-space-expected.png:
- 9:08 PM Changeset in webkit [112045] by
-
- 2 edits2 adds in trunk/LayoutTests
[EFL] Unreviewed gardening, add some baselines and skip a few
tests in fast/events.
- platform/efl/Skipped:
- platform/efl/fast/events/resize-events-expected.png: Added.
- platform/efl/fast/events/resize-events-expected.txt: Added.
- 7:33 PM Changeset in webkit [112044] by
-
- 14 edits1 add in trunk/LayoutTests
[EFL] Unreviewed gardening, update baselines in editing/, media/
and scrollbars/.
- platform/efl/editing/unsupported-content/table-type-after-expected.png:
- platform/efl/editing/unsupported-content/table-type-before-expected.png:
- platform/efl/media/controls-layout-direction-expected.png: Added.
- platform/efl/media/media-controls-clone-expected.png:
- platform/efl/media/media-controls-clone-expected.txt:
- platform/efl/media/video-empty-source-expected.png:
- platform/efl/media/video-empty-source-expected.txt:
- platform/efl/media/video-zoom-controls-expected.png:
- platform/efl/media/video-zoom-controls-expected.txt:
- platform/efl/scrollbars/basic-scrollbar-expected.png:
- platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
- platform/efl/scrollbars/disabled-scrollbar-expected.png:
- platform/efl/scrollbars/scrollbar-buttons-expected.png:
- platform/efl/scrollbars/scrollbar-orientation-expected.png:
- 7:17 PM Changeset in webkit [112043] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Update baseline in animations/ after
the recent jhbuild/fonts updates.
- platform/efl/animations/state-at-end-event-expected.png:
- 7:09 PM Changeset in webkit [112042] by
-
- 7 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Update some fonts/ baselines after the
recent jhbuild/fonts updates.
- platform/efl/fonts/cursive-expected.png:
- platform/efl/fonts/default-expected.png:
- platform/efl/fonts/fantasy-expected.png:
- platform/efl/fonts/monospace-expected.png:
- platform/efl/fonts/sans-serif-expected.png:
- platform/efl/fonts/serif-expected.png:
- 5:57 PM Changeset in webkit [112041] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Update some tables/layering/ baselines.
- platform/efl/tables/layering/paint-test-layering-1-expected.png:
- platform/efl/tables/layering/paint-test-layering-2-expected.png:
- 4:50 PM Changeset in webkit [112040] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
DFG int-to-double conversion should be revealed to CSE
https://bugs.webkit.org/show_bug.cgi?id=82135
Reviewed by Oliver Hunt.
This introduces the notion of an Int32ToDouble node, which is injected
into the graph anytime we know that we have a double use of a node that
was predicted integer. The Int32ToDouble simplifies double speculation
on integers by skipping the path that would unbox doubles, if we know
that the value is already proven to be an integer. It allows integer to
double conversions to be subjected to common subexpression elimination
(CSE) by allowing the CSE phase to see where these conversions are
occurring. Finally, it allows us to see when a constant is being used
as both a double and an integer. This is a bit odd, since it means that
sometimes a double use of a constant will not refer directly to the
constant. This should not cause problems, for now, but it may require
some canonizalization in the future if we want to support strength
reductions of double operations based on constants.
To allow injection of nodes into the graph, this change introduces the
DFG::InsertionSet, which is a way of lazily inserting elements into a
list. This allows the FixupPhase to remain O(N) despite performing
multiple injections in a single basic block. Without the InsertionSet,
each injection would require performing an insertion into a vector,
which is O(N), leading to O(N2) performance overall. With the
InsertionSet, each injection simply records what insertion would have
been performed, and all insertions are performed at once (via
InsertionSet::execute) after processing of a basic block is completed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/PredictedType.h:
(JSC::isActionableIntMutableArrayPrediction):
(JSC):
(JSC::isActionableFloatMutableArrayPrediction):
(JSC::isActionableTypedMutableArrayPrediction):
(JSC::isActionableMutableArrayPrediction):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.h:
(JSC::DFG::useKindToString):
(DFG):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGInsertionSet.h: Added.
(DFG):
(Insertion):
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::index):
(JSC::DFG::Insertion::element):
(InsertionSet):
(JSC::DFG::InsertionSet::InsertionSet):
(JSC::DFG::InsertionSet::append):
(JSC::DFG::InsertionSet::execute):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:35 PM Changeset in webkit [112039] by
-
- 8 edits1 move in trunk/Source/JavaScriptCore
DFGOperands should be moved out of the DFG and into bytecode
https://bugs.webkit.org/show_bug.cgi?id=82151
Reviewed by Dan Bernstein.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Operands.h: Copied from Source/JavaScriptCore/dfg/DFGOperands.h.
- dfg/DFGBasicBlock.h:
- dfg/DFGNode.h:
- dfg/DFGOSREntry.h:
- dfg/DFGOSRExit.h:
- dfg/DFGOperands.h: Removed.
- dfg/DFGVariableAccessData.h:
- 2:47 PM Changeset in webkit [112038] by
-
- 3 edits in trunk/LayoutTests
Don't use CSSRuleList for child rule ownership
https://bugs.webkit.org/show_bug.cgi?id=82127
Reviewed by Andreas Kling.
Update for the new CSSStyleSheet.cssRules uniqueness behavior.
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
- 1:58 PM Changeset in webkit [112037] by
-
- 19 edits in trunk/Source/WebCore
Don't use CSSRuleList for child rule ownership
https://bugs.webkit.org/show_bug.cgi?id=82127
Reviewed by Andreas Kling.
CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule use CSSRuleList for storing children.
They should use a simple rule vector instead. CSSRuleList is a CSSOM type that should be
instantiated on-demand for API purposes only.
- Use Vector<RefPtr<CSSRule>> for storing the rule children of CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule.
- Add direct accessors, use internally instead of CSSRuleList.
- Make CSSRuleList an abstract base. Add concrete subclasses for dealing with the underlying storage.
- Instantiate CSSRuleLists on-demand.
- Make CSSStyleSheet.cssRules always return the same object instance. This matches Firefox and the rest of our CSSOM implementation. Tested by fast/dom/gc-9.html.
The patch decouples internals from the external API. It simplifies the child rule ownership and reduces
indirection. Memory use of css rules with children is reduced (by a ptr, refcount and heap allocation overhead).
- css/CSSGrammar.y:
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::cssRules):
- css/CSSMediaRule.h:
(WebCore::CSSMediaRule::create):
(CSSMediaRule):
(WebCore::CSSMediaRule::ruleCount):
(WebCore::CSSMediaRule::ruleAt):
- css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createRuleList):
(WebCore::CSSParser::createRegionRule):
- css/CSSParser.h:
(WebCore):
- css/CSSRuleList.cpp:
(WebCore):
(WebCore::StaticCSSRuleList::StaticCSSRuleList):
(WebCore::StaticCSSRuleList::~StaticCSSRuleList):
(WebCore::StaticCSSRuleList::deref):
(WebCore::StaticCSSRuleList::item):
- css/CSSRuleList.h:
(CSSRuleList):
Turn CSSRuleList into abstract interface.
(StaticCSSRuleList):
(WebCore::StaticCSSRuleList::create):
(WebCore::StaticCSSRuleList::ref):
(WebCore::StaticCSSRuleList::rules):
(WebCore::StaticCSSRuleList::styleSheet):
(WebCore::StaticCSSRuleList::length):
Concrete implementation for fixed list of rules.
(WebCore):
(LiveCSSRuleList):
(WebCore::LiveCSSRuleList::LiveCSSRuleList):
(WebCore::LiveCSSRuleList::ref):
(WebCore::LiveCSSRuleList::deref):
(WebCore::LiveCSSRuleList::length):
(WebCore::LiveCSSRuleList::item):
(WebCore::LiveCSSRuleList::styleSheet):
Concrete implemenation for live list backed by the underlying container rule.
LiveCSSRuleList is owned by the underlying rule. Refcount is forwarded.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- css/CSSStyleSheet.cpp:
The same scheme for CSSStyleSheet.cssRule as with container rules.
(StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::ref):
(WebCore::StyleSheetCSSRuleList::deref):
(WebCore::StyleSheetCSSRuleList::length):
(WebCore::StyleSheetCSSRuleList::item):
(WebCore::StyleSheetCSSRuleList::styleSheet):
(WebCore):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):
- css/CSSStyleSheet.h:
(CSSStyleSheet):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::cssRules):
- css/WebKitCSSKeyframesRule.h:
(WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::ruleCount):
(WebCore::WebKitCSSKeyframesRule::ruleAt):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):
- css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::cssRules):
- css/WebKitCSSRegionRule.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
- 1:00 PM Changeset in webkit [112036] by
-
- 7 edits in trunk/Source/WebCore
Remove duplicated GenerateConditionalString() from code generators
https://bugs.webkit.org/show_bug.cgi?id=82148
Reviewed by Adam Barth.
Previously GenerateConditionalString()s were defined in each code generator,
and they were doing the same thing. This patch puts GenerateConditionalString()
in CodeGenerator.pm and removes duplicated GenerateConditionalString()s.
No tests. No change in the generated code.
- bindings/scripts/CodeGenerator.pm:
(GenerateConditionalString):
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateProperties):
(GenerateFunction):
(WriteData):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateBatchedAttributeData):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
- 12:51 PM Changeset in webkit [112035] by
-
- 9 edits6 moves in trunk/Source/WebCore
Move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*, and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*
https://bugs.webkit.org/show_bug.cgi?id=82146
Reviewed by Adam Barth.
Now SQLDatabase is renamed to WebDatabase (See Modules/webdatabase/).
We should move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*,
and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*.
We'll rename the SQL_DATABASE flag to the WEB_DATABASE flag in a follow-up patch.
No tests. No change in behavior.
- Modules/webdatabase/DOMWindowWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.cpp.
(WebCore):
(WebCore::DOMWindowWebDatabase::openDatabase):
- Modules/webdatabase/DOMWindowWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.h.
(WebCore):
(DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::~DOMWindowWebDatabase):
- Modules/webdatabase/DOMWindowWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.idl.
- Modules/webdatabase/WorkerContextWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.cpp.
(WebCore):
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
- Modules/webdatabase/WorkerContextWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.h.
(WebCore):
(WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::~WorkerContextWebDatabase):
- Modules/webdatabase/WorkerContextWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.idl.
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 12:47 PM Changeset in webkit [112034] by
-
- 2 edits in trunk/Source/WebKit/wx
[wx] Unreviewed build fix. Add header needed for Unix builds.
- 12:19 PM Changeset in webkit [112033] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix for QtWebKit on Mac OS X.
- UIProcess/API/qt/tests/bytearraytestdata.cpp:
(ByteArrayTestData::~ByteArrayTestData):
- UIProcess/API/qt/tests/bytearraytestdata.h:
- 12:14 PM Changeset in webkit [112032] by
-
- 4 edits2 moves4 deletes in trunk/LayoutTests
Not reviewed: fixing Chromium Win7 baselines for editing/selection tests.
- platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Removed.
- platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Removed.
- platform/chromium-win-vista/editing/selection/3690703-expected.png: Removed.
- platform/chromium-win-vista/editing/selection/3690719-expected.png: Removed.
- platform/chromium-win/editing/selection/3690703-2-expected.png:
- platform/chromium-win/editing/selection/3690703-expected.png:
- platform/chromium-win/editing/selection/3690719-expected.png:
- platform/chromium-win/editing/selection/selection-button-text-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.png.
- platform/chromium-win/editing/selection/selection-button-text-expected.txt: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt.
- 12:07 PM Changeset in webkit [112031] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed. Rebaseline chromium foreignObject results, after Nikolas's rebaselines.
- platform/chromium-win/svg/zoom/page/zoom-foreign-content-expected.png: Added.
- 10:41 AM Changeset in webkit [112030] by
-
- 5 edits3 adds in trunk
Avoid race condition when iterating over pending resources
https://bugs.webkit.org/show_bug.cgi?id=82115
Patch by Philip Rogers <pdr@google.com> on 2012-03-25
Reviewed by Nikolas Zimmermann.
Source/WebCore:
We can hit a race condition in SVGStyledElement::buildPendingResourcesIfNeeded
where pending elements can become non-pending while we iterate over them.
This patch cleans up buildPendingResourcesIfNeeded and re-works how pending
resources are removed. Because pending resources can be modified while
iterating over them, we introduce m_pendingResourcesForRemoval that
holds pending resources that are marked for removal. Instead of iterating
over this list we simply remove each pending resource from
m_pendingResourcesForRemoval; if a pending resource is modified or removed
during the processing of another pending resource this list is updated before
the next element can be accessed.
This change also removes removePendingResourceForElement which is no longer
referenced.
Test: http/tests/svg/change-id-with-pending-resources.html
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
- svg/SVGDocumentExtensions.h:
(SVGDocumentExtensions):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
LayoutTests:
- http/tests/svg/change-id-with-pending-resources-expected.txt: Added.
- http/tests/svg/change-id-with-pending-resources.html: Added.
- http/tests/svg/resources/svg-use-defs-rect.svg: Added.
- 10:18 AM Changeset in webkit [112029] by
-
- 4 edits in trunk/Source
Versioning.
- 10:06 AM Changeset in webkit [112028] by
-
- 1 copy in tags/Safari-536.4
New Tag.
- 5:39 AM Changeset in webkit [112027] by
-
- 7 edits in trunk/LayoutTests
2012-03-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline foreignObject results, after Florins changes.
Eventually the zoom-foreign-content-expected.png needs to be moved to platform/mac/, let's see.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
- platform/mac/test_expectations.txt:
- svg/zoom/page/zoom-foreign-content-expected.png:
- 5:16 AM Changeset in webkit [112026] by
-
- 4 edits in trunk/Source
[BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=82104
RIM PR: 145963
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-25
Reviewed by Rob Buis.
Source/WebCore:
The embedder may use vertex buffers, which affected the interpretation
our vertex array pointers from memory pointers to offsets into a vertex
buffer. The resulting geometry often resulted in no visible layers on
screen.
Fixed by getting rid of any bound buffer when we enter
LayerRenderer::drawLayers().
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawLayers):
Source/WebKit/blackberry:
The root layer may be set before we have a layer renderer, because the
latter is not created until we get an OpenGL context from the embedder.
Fixed by setting the root layer on the layer renderer when it's created
instead of assuming a certain order of events.
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
- 3:41 AM Changeset in webkit [112025] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed: new chromium baseline for r112022.
- platform/chromium-mac/svg/zoom/page/zoom-foreign-content-expected.png: Added.
Mar 24, 2012:
- 10:03 PM Changeset in webkit [112024] by
-
- 9 edits in trunk/Source
[chromium] Instrument gesture animations with async traces
https://bugs.webkit.org/show_bug.cgi?id=82076
Reviewed by Adrienne Walker.
Source/WebCore:
- platform/ActivePlatformGestureAnimation.cpp:
(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
- platform/PlatformGestureCurve.h:
(PlatformGestureCurve):
- platform/TouchpadFlingPlatformGestureCurve.h:
(WebCore::TouchpadFlingPlatformGestureCurve::debugName):
- platform/WheelFlingPlatformGestureCurve.h:
(WebCore::WheelFlingPlatformGestureCurve::debugName):
- platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):
- platform/graphics/chromium/cc/CCGestureCurve.h:
(CCGestureCurve):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebCore::PlatformGestureToCCGestureAdapter::debugName):
(PlatformGestureToCCGestureAdapter):
- 9:24 PM Changeset in webkit [112023] by
-
- 6 edits in trunk
XML error document creation should not fire mutation events
https://bugs.webkit.org/show_bug.cgi?id=80765
Reviewed by Adam Barth.
Source/WebCore:
Broke two tests that expected the old behavior, which have now been updated.
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
LayoutTests:
Fixed tests that relied on old behavior.
- fast/css/stylesheet-candidate-nodes-crash-expected.txt:
- fast/css/stylesheet-candidate-nodes-crash.xhtml:
- fast/dom/xml-parser-error-message-crash-expected.txt:
- 9:08 PM Changeset in webkit [112022] by
-
- 11 edits3 adds in trunk
ForeignObject content is zoomed two times
https://bugs.webkit.org/show_bug.cgi?id=76282
Patch by Florin Malita <fmalita@google.com> on 2012-03-24
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/zoom/page/zoom-foreign-content.svg
Reset the effective zoom property for FO-nested content to avoid
having the zoom factor applied multiple times (zooming is handled by
the top level SVG root element).
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
LayoutTests:
- platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:
Rebaseline cr-linux expectations.
- platform/chromium/test_expectations.txt:
- platform/mac/test_expectations.txt:
Updated zoom-foreignObject.svg expectations, pending rebaseline.
- svg/zoom/page/zoom-foreign-content-expected.png: Added.
- svg/zoom/page/zoom-foreign-content-expected.txt: Added.
- svg/zoom/page/zoom-foreign-content.svg: Added.
- svg/zoom/page/zoom-foreignObject.svg:
- svg/zoom/text/zoom-foreignObject.svg:
Updated test to cover SVG FO text.
- 9:03 PM Changeset in webkit [112021] by
-
- 11 edits2 adds in trunk
AX: Support solution to handle invalid ax text marker
https://bugs.webkit.org/show_bug.cgi?id=82023
Reviewed by Oliver Hunt.
Source/WebCore:
This provides methods to better use text markers so that assistive technologies
can know when they are valid, and can convert them to and from absolute positions.
Test: platform/mac/accessibility/textmarker-routines.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(indexForTextMarkerCallback):
(isTextMarkerValidCallback):
(textMarkerForIndexCallback):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::isTextMarkerValid):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::isTextMarkerValid):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
LayoutTests:
- platform/mac/accessibility/textmarker-routines-expected.txt: Added.
- platform/mac/accessibility/textmarker-routines.html: Added.
- 8:59 PM Changeset in webkit [112020] by
-
- 2 edits in trunk/Source/WebCore
Quick fix for rendering controls regression.
https://bugs.webkit.org/show_bug.cgi?id=82125
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-24
Reviewed by Eric Carlson.
Only temporary fix. Tests to cover the problem should be added
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeOpaque): The display:none
property should be toggled only by the media element now.
(WebCore::MediaControlPanelElement::makeTransparent): The timer
that toggles the dispalay:none shouldn't be used now.
- 8:50 PM Changeset in webkit [112019] by
-
- 12 edits in trunk/Tools
Unreviewed, rolling out r112014.
http://trac.webkit.org/changeset/112014
https://bugs.webkit.org/show_bug.cgi?id=82138
Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-24
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.run):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):
- Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.is):
(MeteredStream.init):
(MeteredStream.write):
(MeteredStream.update):
(MeteredStream._overwrite):
(MeteredStream._reset):
- Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(TestMeteredStream):
(TestMeteredStream.test_regular):
- Scripts/webkitpy/layout_tests/views/printing.py:
(_configure_logging):
(_restore_logging):
(Printer.init):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):
(Printer):
(Printer._update):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.get_printer):
(Testprinter.test_print_progress):
(Testprinter.test_print_progress.mock_time):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):
- 7:29 PM Changeset in webkit [112018] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG 64-bit Branch implementation should not be creating a JSValueOperand that
it isn't going to use
https://bugs.webkit.org/show_bug.cgi?id=82136
Reviewed by Geoff Garen.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
- 6:41 PM Changeset in webkit [112017] by
-
- 7 edits in trunk
[wx] Unreviewed. Fix the build after WTF move.
- 6:32 PM Changeset in webkit [112016] by
-
- 2 edits in trunk/Source/WebCore
[wx] Unreviewed. Add header needed for compilation.
- 5:46 PM Changeset in webkit [112015] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG double voting may be overzealous in the case of variables that end up
being used as integers
https://bugs.webkit.org/show_bug.cgi?id=82008
Reviewed by Oliver Hunt.
Cleaned up propagation, making the intent more explicit in most places.
Back-propagate NodeUsedAsInt for cases where a node was used in a context
that is known to strongly prefer integers.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
- 2:22 PM Changeset in webkit [112014] by
-
- 12 edits in trunk/Tools
clean up NRWT logging/metering, be less verbose
https://bugs.webkit.org/show_bug.cgi?id=73846
Reviewed by Ojan Vafai.
This patch totally rewrites the metered_stream module and
changes the way it and the printing module now interact with the
logging subsystem.
The printing module becomes a dumb layout_tests-specific wrapper around
the metered stream. All of the intelligence of how and when to
actually write (or erase) lines and how things interact with
logging moves into the metered stream.
As of now, anything written to the metered stream *bypasses the
logging system*. If a logger is passed to the meter constructor,
the metered stream will also attach a log handler so that all
messages fed to the logger will also be written to the metered
stream. This detangles the logic that used to exist where
sometimes the meter would write to the logger and sometimes the
logger would write to the meter.
All of this makes the logic generic and reusable for
test-webkitpy (coming in another patch). It also helps clarify
what the mysterious "configure_logging" parameter to the printer
constructor used to do (that parameter itself is gone now, and
by default the printer and metered_stream will not ever touch
the logging system; this makes a bunch of tests less fragile).
All of the above should produce no user-visible changes.
However, to also fix the bug in question, we change the message
format in --verbose mode to %H:%M:%S.%frac %pid %message,
eliminating the date, file:lineno, and level parameters. I am
making this change at the same time because it would be
difficult to write things consistently between the logs and the
metered stream if we were still logging the file:lineno.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Remove the configure_logging parameter
- Scripts/webkitpy/layout_tests/controllers/worker.py: Use metered stream to configure the logging (we don't need a printer) and be careful about when and how we manipulate the log level and handlers on the root logger.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Pass in the root logger so that log messages are formatted properly, and set the log level outside of any routines called by unit tests so as to not interfere.
- Scripts/webkitpy/layout_tests/views/manager_worker_broker.py: remove a duplicate log message.
- Scripts/webkitpy/layout_tests/views/metered_stream.py: complete rewrite :).
- Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: complete rewrite :).
- Scripts/webkitpy/layout_tests/views/printing.py: move the logging configuration into metered_stream, and also move the "when should I log progress messages" into metered stream.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py: remove tests that are no longer necessary.
- Scripts/webkitpy/performance_tests/perftestsrunner.py: remove the configure_logging parameter.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: update the test; since the printer no longer writes to the log, we need to check what is written to the regular_output instead. (test_run_test_pause_before_testing):
- 1:15 PM Changeset in webkit [112013] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG::Node::shouldNotSpeculateInteger() should be eliminated
https://bugs.webkit.org/show_bug.cgi?id=82123
Reviewed by Geoff Garen.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGNode.h:
(Node):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
- 1:03 PM Changeset in webkit [112012] by
-
- 4 edits2 adds in trunk
Crash in ApplyStyleCommand::applyInlineStyleToNodeRange.
https://bugs.webkit.org/show_bug.cgi?id=81959
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/execCommand/apply-style-command-crash.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): RefPtr the weak
node iterator |node|.
- editing/ApplyStyleCommand.h:
(ApplyStyleCommand): convert |startNode| and |pastEndNode| into PassRefPtr.
LayoutTests:
- editing/execCommand/apply-style-command-crash-expected.txt: Added.
- editing/execCommand/apply-style-command-crash.html: Added.
- 12:13 PM Changeset in webkit [112011] by
-
- 2 edits in trunk/Source/JavaScriptCore
Increase getByIdSlowCase ConstantSpace/InstructionSpace for CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/show_bug.cgi?id=81521
Increase sequenceGetByIdSlowCaseConstantSpace and sequenceGetByIdSlowCaseInstructionSpace
for CPU(ARM_TRADITIONAL) to fit actual need.
Patch by Yong Li <yoli@rim.com> on 2012-03-24
Reviewed by Oliver Hunt.
- jit/JIT.h:
(JIT):
- 10:08 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:06 AM Changeset in webkit [112010] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging 112002
- 10:05 AM Changeset in webkit [112009] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging 112001
- 10:05 AM Changeset in webkit [112008] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Reverting r90755 (Merging 112000)
- 10:04 AM Changeset in webkit [112007] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging 111999
- 10:02 AM Changeset in webkit [112006] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging 111998
- 10:02 AM Changeset in webkit [112005] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging 111997.
- 10:01 AM Changeset in webkit [112004] by
-
- 6 edits in trunk/Source/WebKit/gtk
[GTK] Replace occurrences of "uri" in the documentation with "URI"
https://bugs.webkit.org/show_bug.cgi?id=82025
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
In documentation "uri" should really be written as "URI" so
we should fix all existing strings.
- webkit/webkitdownload.cpp: Replace "uri" with "URI."
- webkit/webkitnetworkrequest.cpp: Ditto.
- webkit/webkitnetworkresponse.cpp: Ditto.
- webkit/webkitwebhistoryitem.cpp: Ditto.
- webkit/webkitwebresource.cpp: Ditto.
(webkit_web_resource_class_init):
- 10:00 AM Changeset in webkit [112003] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po
Merging r111996.
- 9:51 AM Changeset in webkit [112002] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=77834
Patch by Christian Kirbach <Christian.Kirbach@googlemail.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- de.po:
- 9:46 AM Changeset in webkit [112001] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Updated Norwegian bokmål translation for webkitgtk
https://bugs.webkit.org/show_bug.cgi?id=73891
Patch by Kjartan Maraas <kmaraas@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- nb.po:
- 9:37 AM Changeset in webkit [112000] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Unreviewed, rolling out r90755.
http://trac.webkit.org/changeset/90755
https://bugs.webkit.org/show_bug.cgi?id=44410
This is actually less up-to-date then the one we committed
before
- id.po:
- 9:32 AM Changeset in webkit [111999] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
[l10n] [mr] WebKitGTK+ Marathi Translations
https://bugs.webkit.org/show_bug.cgi?id=82014
Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- mr.po: Added.
- 9:26 AM Changeset in webkit [111998] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Updated en_GB translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=82093
Patch by Chris Leonard <cjl@laptop.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- en_GB.po:
- 9:21 AM Changeset in webkit [111997] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Add Galician translations for webkitgtk
https://bugs.webkit.org/show_bug.cgi?id=67591
Patch by Fran Dieguez <frandieguez@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- gl.po:
- 9:11 AM Changeset in webkit [111996] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Slovenian translation update
https://bugs.webkit.org/show_bug.cgi?id=68504
Patch by Matej Urbančič <mateju@svn.gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.
- sl.po:
- 9:08 AM Changeset in webkit [111995] by
-
- 2 edits in trunk/Tools
Add myself and Martin Robinson to: * GStreamerGraphics * GtkWebKit2PublicAPI * SoupNetwork and to the newly created WebKitGTKTranslations.
Rubber-stamped by Martin Robinson.
- Scripts/webkitpy/common/config/watchlist:
- 8:36 AM Changeset in webkit [111994] by
-
- 2 edits in trunk/LayoutTests
2012-03-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: restoring chromium's expectations for effect-custom-parameters-expected.png.
- platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
- 8:23 AM Changeset in webkit [111993] by
-
- 4 edits in trunk
[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-03-24
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 6:34 AM Changeset in webkit [111992] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix since we use "-Werror=unused-but-set-variable".
The variable 'it' was set at TextureMapperShaderManager.h:110 but never used.
- platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderManager::getShaderProgram):
- 4:51 AM Changeset in webkit [111991] by
-
- 13 edits3 adds in trunk/LayoutTests
Updated chromium baselines wrt button selection changes in r111946.
Not reviewed.
- platform/chromium-linux/editing/selection/3690703-2-expected.png:
- platform/chromium-linux/editing/selection/3690703-expected.png:
- platform/chromium-linux/editing/selection/3690719-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Added.
- platform/chromium-win-vista/editing/selection/3690703-expected.png: Added.
- platform/chromium-win-vista/editing/selection/3690719-expected.png: Added.
- 3:45 AM Changeset in webkit [111990] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: updating chromium test expectations.
- platform/chromium/test_expectations.txt:
- 2:07 AM Changeset in webkit [111989] by
-
- 1 edit4 copies in trunk/LayoutTests
Added Mac expected results for these two tests. The results were accidentally removed in
r111545, even though these tests were not converted into reftests.
- platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png.
- platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt.
- platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png.
- platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt.
- 1:54 AM Changeset in webkit [111988] by
-
- 1 edit2 adds in trunk/LayoutTests
Added Mac expected results for this test that was added in r111139.
- platform/mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
- platform/mac/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
- 1:49 AM Changeset in webkit [111987] by
-
- 1 edit2 adds in trunk/LayoutTests
Added Mac expected results for this test that was added in r111946.
- platform/mac/editing/selection/selection-button-text-expected.png: Added.
- platform/mac/editing/selection/selection-button-text-expected.txt: Added.
- 1:37 AM Changeset in webkit [111986] by
-
- 3 edits in trunk/Source/WebCore
[Qt][WK2] Make TextureMapperShaderManager::getShaderProgram() not be a template.
https://bugs.webkit.org/show_bug.cgi?id=82049
Change the getShaderProgram() function to not be a template.
This is a workaround for a compiler bug that leads to an assert
when compiling in debug mode on mac.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::beginClip):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(TextureMapperShaderManager):
- 1:36 AM Changeset in webkit [111985] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 1:10 AM Changeset in webkit [111984] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 12:01 AM Changeset in webkit [111983] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
Mar 23, 2012:
- 11:51 PM Changeset in webkit [111982] by
-
- 4 edits in trunk/Source
[chromium] Incorrect replica originTransform used in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=82118
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test added to CCDamageTrackerTest.cpp
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 11:44 PM Changeset in webkit [111981] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 11:27 PM Changeset in webkit [111980] by
-
- 1 edit9 adds in trunk/LayoutTests
Not reviewed: adding chromium baselines.
- platform/chromium-linux/editing/selection/selection-button-text-expected.png: Added.
- platform/chromium-linux/editing/selection/selection-button-text-expected.txt: Added.
- platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png: Added.
- platform/chromium-mac/editing/selection/selection-button-text-expected.png: Added.
- platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Added.
- platform/chromium-win-vista/editing/selection/selection-button-text-expected.png: Added.
- platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt: Added.
- 11:22 PM Changeset in webkit [111979] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromium expectations updated.
- platform/chromium/test_expectations.txt:
- 10:54 PM Changeset in webkit [111978] by
-
- 6 edits in trunk/Source
[chromium] When prepainting fails, tiles dirty rects may be cleared
https://bugs.webkit.org/show_bug.cgi?id=82107
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.
Source/WebCore:
When prepainting, if a tile is unable to be reserved due to memory
limits, we bail out of prepareToUpdateTiles. But we would have
cleared the dirty rect of any previous tiles. This leaves them
in a bad state where their textures are reserved, but their textureIds
are set to 0, and they are not marked dirty. This means that they will
not be updated and displayed if they become visible, since it is
assumed that valid textures with zero textureId must have a dirty
region.
We fix this by not clearing the dirty rects until we know we are
going to update the layer.
Unit test: TiledLayerChromiumTest.pushTilesAfterIdlePaintFailed
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::hasTextureIdForTileAt):
(WebCore):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(FakeCCTiledLayerImpl):
(WTF::FakeCCTiledLayerImpl::hasTextureIdForTileAt):
(WTF::TEST):
(WTF):
- 10:21 PM Changeset in webkit [111977] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
<rdar://problem/11094830> WebProcess appears to get stuck in its GC handler (81963).
Remove the call to garbage collect in low memory signal handler. Did some testing with hitting the low memory handler
during Membuster and we would get back at most 100k - 200k. That isn't enough to help the system, and in
that state the GC collection can take a substantial amount of time.
Reviewed by Geoff Garen.
Performance Change, no change in behavior.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- 9:07 PM WebKitGTK/1.8.x edited by
- (diff)
- 9:04 PM Changeset in webkit [111976] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp
Fix a bad merge.
- 8:30 PM Changeset in webkit [111975] by
-
- 2 edits in trunk/LayoutTests
Updated the Mac expected results for this test after CSS shaders were disabled in r111893.
WebKitCSSFilterValue.CSS_FILTER_CUSTOM is no longer defined.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- 8:23 PM Changeset in webkit [111974] by
-
- 9 edits2 adds in trunk/Source/JavaScriptCore
DFG Fixup should be able to short-circuit trivial ValueToInt32's
https://bugs.webkit.org/show_bug.cgi?id=82030
Reviewed by Michael Saboff.
Takes the fixup() method of the prediction propagation phase and makes it
into its own phase. Adds the ability to short-circuit trivial ValueToInt32
nodes, and mark pure ValueToInt32's as such.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCommon.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp: Added.
(DFG):
(FixupPhase):
(JSC::DFG::FixupPhase::FixupPhase):
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::performFixup):
- dfg/DFGFixupPhase.h: Added.
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(PredictionPropagationPhase):
- 8:11 PM Changeset in webkit [111973] by
-
- 3 edits in trunk/Source/JavaScriptCore
tryReallocate could break the zero-ed memory invariant of CopiedBlocks
https://bugs.webkit.org/show_bug.cgi?id=82087
Reviewed by Filip Pizlo.
Removing this optimization turned out to be ~1% regression on kraken, so I simply
undid the modification to the current block if we fail.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryReallocate): Undid the reset in the CopiedAllocator if we fail
to reallocate from the current block.
- 7:27 PM Changeset in webkit [111972] by
-
- 1 edit5 moves4 adds37 deletes in trunk/LayoutTests
Fix more Chromium 10.6/10.5 tests that broke with r111917. There's a bug
with garden-o-matic when rebaselining all the Chromium Mac ports.
Other ports seem fine.
- 7:23 PM Changeset in webkit [111971] by
-
- 4 edits in trunk/Source
[chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
https://bugs.webkit.org/show_bug.cgi?id=82106
Reviewed by Adrienne Walker.
Source/WebCore:
Existing unit tests updated.
With gesture scroll events now being handled as mouse wheel events, we should not start a gesture scroll when
wheel handlers are present.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBegin):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
- 7:22 PM Changeset in webkit [111970] by
-
- 3 edits1 add1 delete in releases/WebKitGTK/webkit-1.8
Merging r111882
- 7:20 PM Changeset in webkit [111969] by
-
- 12 edits3 adds in trunk/Source/WebCore
Move Notifications APIs from WorkerContext.idl to WorkerContextNotifications.idl
https://bugs.webkit.org/show_bug.cgi?id=79635
Reviewed by Kentaro Hara.
This patch moves the NotificationCenter from WorkerContext to
WorkerContextNotificiations, reducing clutter in WorkerContext. After
this patch, Notifications are almost entirely contained in the
notifications directory.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 7:15 PM Changeset in webkit [111968] by
-
- 3 edits in trunk/Source/WebCore
[chromium] RootLayer was not being checked for null causing segfaults very rarely.
https://bugs.webkit.org/show_bug.cgi?id=82111
Patch by Michal Mocny <mmocny@google.com> on 2012-03-23
Reviewed by Adrienne Walker.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
- 7:13 PM Changeset in webkit [111967] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r111400
- 7:12 PM Changeset in webkit [111966] by
-
- 46 edits2 adds25 deletes in releases/WebKitGTK/webkit-1.8
Merging r111361
- 6:39 PM Changeset in webkit [111965] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110938
- 6:38 PM Changeset in webkit [111964] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110925
- 6:28 PM Changeset in webkit [111963] by
-
- 4 edits in trunk/Source
[chromium] Fix race bug that clobbers CCLayerImpl updateRect
https://bugs.webkit.org/show_bug.cgi?id=82109
Reviewed by Dirk Pranke.
Source/WebCore:
If the main thread commits twice before the impl thread actually
draws, then the updateRect of the first frame gets lost forever,
and not propagated to the damage tracker.
The solution is to accumulate the updateRect. The CCLayerImpl
updateRect is already being correctly cleared at the appropriate
time after drawing.
Unit test added to LayerChromiumTest.cpp.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 6:25 PM Changeset in webkit [111962] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r110888
- 6:13 PM Changeset in webkit [111961] by
-
- 2 edits11 moves3 adds66 deletes in trunk
Fix Chromium 10.6/10.5 tests that broke with r111917. There's a bug
with garden-o-matic when rebaselining all the Chromium Mac ports.
Other ports seem fine.
- 6:13 PM Changeset in webkit [111960] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110598
- 6:12 PM Changeset in webkit [111959] by
-
- 7 edits2 adds in trunk/Source/WebKit/blackberry
[BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API
https://bugs.webkit.org/show_bug.cgi?id=81121
RIM PR: 136687
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-23
Reviewed by Rob Buis.
The idea is for the API client to use a WebPageCompositor object to
render the WebPage when there's no screen window available.
The WebPageCompositorPrivate becomes reference counted in order to be
kept alive either because it's used for accelerated compositing layers
or used for the WebPageCompositor API. It can still work standalone.
Clean up some code - no need to keep track of a separate boolean
WebPagePrivate::m_isAcceleratedCompositingActive when the state of
m_compositor can tell you.
Also remove duplicated code from WebPagePrivate - go directly to the
compositor object instead, if you need to draw the AC layers.
Reviewed internally by Robin Cao and the hasBlitJobs/blitOnIdle change
by Filip Spacek.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::hasBlitJobs):
(BlackBerry::WebKit::BackingStore::blitOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- Api/WebPage.h:
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositorDestroyed):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::client):
(BlackBerry::WebKit::WebPageCompositor::prepareFrame):
(BlackBerry::WebKit::WebPageCompositor::render):
(BlackBerry::WebKit::WebPageCompositor::cleanup):
(BlackBerry::WebKit::WebPageCompositor::contextLost):
- Api/WebPageCompositor.h: Added.
- Api/WebPageCompositorClient.h: Added.
- Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::create):
(BlackBerry::WebKit::WebPageCompositorPrivate::context):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameTimestamp):
(BlackBerry::WebKit::WebPageCompositorPrivate::page):
(BlackBerry::WebKit::WebPageCompositorPrivate::client):
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::client):
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(BlackBerry::WebKit::WebPagePrivate::compositor):
- 6:11 PM Changeset in webkit [111958] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110401
- 6:10 PM Changeset in webkit [111957] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8
Merging r110331
- 6:08 PM Changeset in webkit [111956] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110243
- 6:07 PM Changeset in webkit [111955] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110178.diff
- 6:06 PM Changeset in webkit [111954] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r110065
- 6:04 PM Changeset in webkit [111953] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merging r110063
- 6:03 PM Changeset in webkit [111952] by
-
- 6 edits4 adds in releases/WebKitGTK/webkit-1.8
Merging r109594
- 6:00 PM BuildingGtk edited by
- (diff)
- 5:58 PM Changeset in webkit [111951] by
-
- 9 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r109593
- 5:58 PM Changeset in webkit [111950] by
-
- 6 edits in trunk
[MutationObservers] attributeFilter should be case sensitive at all times
https://bugs.webkit.org/show_bug.cgi?id=81822
Reviewed by Ryosuke Niwa.
Source/WebCore:
This removes the behavior in MutationObserverRegistration which treats
attributeFilter as case insensitive for HTML elements in HTML documents.
Relevant tests have been updated.
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
- dom/MutationObserverRegistration.h:
(MutationObserverRegistration):
LayoutTests:
- fast/mutation/observe-attributes-expected.txt:
- fast/mutation/observe-attributes.html:
- 5:55 PM Changeset in webkit [111949] by
-
- 8 edits1 add in trunk/Source/WebCore
Move WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=79663
Reviewed by Adam Barth.
For WebKit modularization, this patch moves WebSocket APIs from WorkerContext.idl
to WorkerContextWebSocket.idl.
Tests: http/tests/websocket/tests/hybi/workers/* (No change in test results)
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/websockets/WorkerContextWebSocket.idl: Added.
- WebCore.gypi:
- WebCore.xcodeproj/project.xcodeproj:
- workers/WorkerContext.idl:
- 5:55 PM Changeset in webkit [111948] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r109543
- 5:54 PM Changeset in webkit [111947] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-1.8
Merging r109503
- 5:54 PM Changeset in webkit [111946] by
-
- 4 edits3 adds in trunk
REGRESSION: can select text of an input button
https://bugs.webkit.org/show_bug.cgi?id=13624
Patch by Parag Radke <parag@motorola.com> on 2012-03-23
Reviewed by Ryosuke Niwa.
Source/WebCore:
Text in a button should never have a selection background of its own painted
but if the button is inside an editable area, then the whole button should
have it's selection background painted.
Test: editing/selection/selection-button-text.html
- rendering/RenderButton.h:
Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the button renderer is editable, false other wise.
- rendering/RenderTextFragment.h:
Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the text fragment renderer is editable, false other wise.
LayoutTests:
Added a pixel test case to test the selection background for button label text.
- editing/selection/selection-button-text.html: Added.
- platform/gtk/editing/selection/selection-button-text-expected.png: Added.
- platform/gtk/editing/selection/selection-button-text-expected.txt: Added.
- 5:53 PM Changeset in webkit [111945] by
-
- 4 edits in trunk/Tools
nrwt: don't wait for safari to exit before exiting after showing the results file
https://bugs.webkit.org/show_bug.cgi?id=81845
Reviewed by Ryosuke Niwa.
Prior to this change, if you ran new-run-webkit-tests and
displayed the HTML results file at the end, we would block
waiting for the user to quit the browser. There doesn't seem to
be a need for that, and the Chromium ports don't do this.
Also, update the mac tests to capture the output and be quiet :).
- Scripts/webkitpy/common/system/executive_mock.py: Make popen() testable, implement should_log for it.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py: Silence some of the tests via outputcapture.
- 5:52 PM Changeset in webkit [111944] by
-
- 5 edits4 adds in releases/WebKitGTK/webkit-1.8
Merging r109480
- 5:51 PM Changeset in webkit [111943] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
Merging r109034
- 5:44 PM Changeset in webkit [111942] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8
Merging r109021
- 5:34 PM Changeset in webkit [111941] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary ASSERT from LoadableTextTrack::trackElementIndex
https://bugs.webkit.org/show_bug.cgi?id=82095
Reviewed by Dan Bernstein.
No new tests, removed a bogus ASSERT that was sometimes triggered by tests.
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::trackElementIndex): Remove ASSERT.
- 5:32 PM Changeset in webkit [111940] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r108878
- 5:30 PM Changeset in webkit [111939] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r108668
- 5:29 PM Changeset in webkit [111938] by
-
- 2 edits in trunk/Source/WebCore
Layout Test media/video-source-load.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82094
Reviewed by Alexey Proskuryakov.
No new tests, tested by media/video-source-load.html.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::sourceWasAdded): Set m_nextChildNodeToConsider when called
with networkState == NETWORK_EMPTY because the resource selection algorithm has
not started yet.
- 5:25 PM Changeset in webkit [111937] by
-
- 8 edits3 adds in releases/WebKitGTK/webkit-1.8
Merging r108574
- 5:24 PM Changeset in webkit [111936] by
-
- 6 edits14 adds in releases/WebKitGTK/webkit-1.8
Merging r108494
- 5:23 PM Changeset in webkit [111935] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r108490
- 5:22 PM Changeset in webkit [111934] by
-
- 1 edit1 copy in trunk/LayoutTests
Added Mac WebKit2 expected results for this test. The fact that it is failing is tracked by
<http://webkit.org/b/82020>.
- platform/mac-wk2/plugins/netscape-dom-access-and-reload-expected.txt: Added.
- 5:09 PM Changeset in webkit [111933] by
-
- 3 edits in branches/chromium/1025/Source/WebCore/dom
Merge r110925 into 1025 branch.
- 5:01 PM Changeset in webkit [111932] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merging r108417
- 4:55 PM Changeset in webkit [111931] by
-
- 8 edits in trunk/Source
[Mac] No need for platform-specific ENABLE_BLOB values
https://bugs.webkit.org/show_bug.cgi?id=82102
Reviewed by David Kilzer.
- Configurations/FeatureDefines.xcconfig:
- 4:41 PM Changeset in webkit [111930] by
-
- 5 edits2 adds in trunk/Source/WebCore
Add TextFieldDecorator and TextFieldDecorationElement
https://bugs.webkit.org/show_bug.cgi?id=80580
Reviewed by Dimitri Glazkov.
These classes will be used to add a decoration icon to a text field
<input> from outside of WebCore. We have a plan to use them in Chromium
port. So this patch doesn't add TextFieldDecorationElement.{cpp,h} to
non-Chromium build files.
How it works:
When a shadow subtree for a text field is created, we ask ChromeClient
to decorate it. ChromeClient appends a TextFieldDecorationElement to the
existing shadow subtree or another shadow tree. A TextFieldDecorator is
associated to a TextFieldDecorationElement, and it provides decoration
icon images and a click handler.
No new tests. This patch won't make any behavior change for now.
- WebCore.gypi: Add TextFieldDecorationElement.cpp and TextFieldDecorationElement.h
- dom/Element.h:
(WebCore::Element::isTextFieldDecoration):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
Calls ChromeClient::willAddTextFieldDecorationsTo() and addTextFieldDecorationsTo().
- html/shadow/TextFieldDecorationElement.cpp: Added.
(WebCore::TextFieldDecorator::~TextFieldDecorator):
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::create):
(WebCore::TextFieldDecorationElement::isTextFieldDecoration):
(WebCore::TextFieldDecorationElement::updateImage):
(WebCore::TextFieldDecorationElement::customStyleForRenderer):
Sets the size to a square of the font-size.
(WebCore::TextFieldDecorationElement::createRenderer):
Always creates a RenderImage.
(WebCore::TextFieldDecorationElement::attach):
Sets an image for appropriate state.
(WebCore::TextFieldDecorationElement::isMouseFocusable):
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Delegate a click event to the corresponding function of TextFieldDecorator.
- html/shadow/TextFieldDecorationElement.h: Added.
(TextFieldDecorator): Added.
(TextFieldDecorationElement): Added.
(WebCore::toTextFieldDecorationElement): Added.
- page/ChromeClient.h:
(WebCore::ChromeClient::willAddTextFieldDecorationsTo): Add an empty implementation.
(WebCore::ChromeClient::addTextFieldDecorationsTo): ditto.
- 4:31 PM Changeset in webkit [111929] by
-
- 4 edits in trunk/Tools
[GTK] libgcrypt and p11-kit should not be in jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82073
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(jhbuildConfigurationChanged): new function that isolates the
jhbuild configuration change checking from the autogen logic.
(mustReRunAutogen): code for the new function lived here.
(buildAutotoolsProject): now calls jhbuildConfigurationChanged
itself, and cleans up the jhbuild root if configuration has
changed; it also forces autogen to be run in that case, to
make sure the new libraries are used.
- gtk/jhbuild.modules: removed libgcrypt and p11-kit.
- jhbuild/jhbuild-wrapper:
(ensure_jhbuild): this might be run inside a jhbuild environment,
in which case aclocal fails when trying to use the now deleted
aclocal directory in the jhbuild prefix, so work around that.
- 4:08 PM Changeset in webkit [111928] by
-
- 1 edit in branches/chromium/1025/Source/WebKit/chromium/features.gypi
Revert 111620 - Revert 103349 - enable USE_SKIA_TEXT by default, replacing GDI for all text drawing
https://bugs.webkit.org/show_bug.cgi?id=74928
Reviewed by Stephen White.
- features.gypi:
TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/9832001
TBR=kareng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9837068
- 4:00 PM Changeset in webkit [111927] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r108851.
http://trac.webkit.org/changeset/108851
https://bugs.webkit.org/show_bug.cgi?id=82098
"Revert the addition of unnecessary, deprecated functions in
WKPreferences.h" (Requested by estes on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-23
- UIProcess/API/C/WKPreferences.cpp:
- UIProcess/API/C/WKPreferences.h:
- 3:54 PM Changeset in webkit [111926] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test_expectations update for chromium.
- platform/chromium/test_expectations.txt:
- 3:51 PM Changeset in webkit [111925] by
-
- 5 edits2 adds in trunk
Match DOM4 spec with respect to DocumentFragment insertion
https://bugs.webkit.org/show_bug.cgi?id=82089
Reviewed by Ryosuke Niwa.
Source/WebCore:
DOM4 specifies the behavior of appendChild, insertBefore, and replaceChild
in terms of "mutation algorithms":
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#mutation-algorithms
This change updates WebKit to match, in particular with regard to DocumentFragments.
Previously, ContainerNode would remove nodes one at a time, then add them to the new parent.
When combined with MutationObservers, this results in overly-verbose mutation records.
Now we create as few records as possible, matching the spec as well as Gecko's implementation
of MutationObservers.
Note that we still need to check validity each time through the loop,
since inserting a node may dispatch events. In a future change, I hope
to move these events so that they fire only after all nodes are inserted,
but that's too much to tackle all in one.
Tests: fast/mutation/document-fragment-insertion.html
- dom/ContainerNode.cpp:
(WebCore::collectChildrenAndRemoveFromOldParent): New helper method
combining collectTargetNodes() with the removal of the collected nodes from
their old parent, if any.
(WebCore::ContainerNode::insertBefore): Use new helper method instead
of removing nodes one at a time from the fragment.
(WebCore::ContainerNode::replaceChild): ditto. Also removed some redundant asserts
and moved the "do nothing" check out of the loop.
(WebCore::ContainerNode::appendChild): Use new helper method.
LayoutTests:
- fast/dom/Node/fragment-mutation-expected.txt:
- fast/dom/Node/fragment-mutation.html: Removed tests that no longer make sense
since the DocumentFragment has no children by the time DOMSubtreeModified is called.
- fast/mutation/document-fragment-insertion-expected.txt: Added.
- fast/mutation/document-fragment-insertion.html: Added.
- 3:44 PM Changeset in webkit [111924] by
-
- 1 edit in branches/chromium/1025/Source/WebKit/chromium/features.gypi
Revert 111450 - disabling Mutation Observers on Chromium branch 1025
TBR=rafaelw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9845042
- 3:43 PM Changeset in webkit [111923] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of css3 filter test for chromium linux.
- platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
- 3:41 PM Changeset in webkit [111922] by
-
- 4 edits1 add in trunk
[skia] Switch to Skia's implementation of the feMorphology filter.
https://bugs.webkit.org/show_bug.cgi?id=82085
Reviewed by Dirk Schulze.
Covered by existing tests in svg/filters/.
- WebCore.gypi:
- platform/graphics/filters/FEMorphology.h:
(FEMorphology):
- platform/graphics/filters/skia/FEMorphologySkia.cpp: Added.
(WebCore):
(WebCore::FEMorphology::platformApplySkia):
- 3:37 PM Changeset in webkit [111921] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Putting the y in 'already'
- 3:35 PM Changeset in webkit [111920] by
-
- 5 edits in trunk/Source/WebCore
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=82027
Reviewed by Kentaro Hara.
Rather than watching for willDetachPage, NotificationCenter can just
override ActiveDOMObject::stop directly to be notified when it needs to
stop.
Switching NotificationCenter over to using ActiveDOMObject callbacks
frees DOMWindowNotification to implement reconnectFrame. However, this
is only really a victory in princple because NotificationCenter always
returns false for canSuspend(), which means we'll never actually use
the reconnectFrame functionality. However, this patch does move us
closer to the time when NotificationCenter can implement
ActiveDOMObject::suspend/resume to play nice with the PageCache.
- notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrame):
(WebCore::DOMWindowNotifications::reconnectFrame):
- notifications/DOMWindowNotifications.h:
(DOMWindowNotifications):
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::stop):
- notifications/NotificationCenter.h:
(NotificationCenter):
- 3:25 PM Changeset in webkit [111919] by
-
- 9 edits2 adds in trunk
[chromium] Support file drag out using DataTransferItemList::add(File)
https://bugs.webkit.org/show_bug.cgi?id=81261
Reviewed by Tony Chang.
Source/WebCore:
Original patch by Varun Jain <varunjain@chromium.org>.
I've updated the original patch to remove 'downloadurl' handling since it's not tested, nor
is it necessary for File objects, since File objects correspond to a native filesystem path.
Test: fast/events/drag-dataTransferItemList-file-handling.html
- platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::add):
Source/WebKit/chromium:
Original patch by Varun Jain <varunjain@chromium.org>.
I've updated the original patch to add some asserts for conditions we shouldn't encounter as
well as removing some redundant null checks.
- src/WebDragData.cpp:
(WebKit::WebDragData::items):
LayoutTests:
- fast/events/drag-dataTransferItemList-file-handling-expected.txt: Added.
- fast/events/drag-dataTransferItemList-file-handling.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 3:22 PM Changeset in webkit [111918] by
-
- 2 edits in trunk/LayoutTests
Added all tests that crashed more than once on the Lion WebKit2 bots between r111867
and r111906 to the Mac WebKit2 skip list (that weren’t alread on the list).
Rubber-stamped by Geoff Garen.
- platform/mac-wk2/Skipped:
- 3:19 PM Changeset in webkit [111917] by
-
- 2 edits in trunk/Tools
garden-o-matic scrolls to the top of the page when you click an accordion item
https://bugs.webkit.org/show_bug.cgi?id=82088
Reviewed by Adam Barth.
Check the scroll position and make sure that the clicked accordion item is visible.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 3:17 PM Changeset in webkit [111916] by
-
- 2 edits in trunk/LayoutTests
Mark fast/dom/nodesFromRect-basic.html as passing; it seems to have been fixed by r110594.
Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 3:14 PM WebKitGTK/1.8.x edited by
- (diff)
- 3:14 PM Changeset in webkit [111915] by
-
- 4 edits in trunk/Source/WebKit/gtk
[Gtk] Webkit fails to build with --disable-geolocation
https://bugs.webkit.org/show_bug.cgi?id=81451
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-23
Reviewed by Benjamin Poulain.
Wrap uses of WebCore::Geolocation in WebKitGeolocationPolicyDecision
and WebKitWebView in ifdefs, removing compilation errors when compiling
with geolocation support disabled. Affected public API methods are then
stubs, throwing a warning that feature was not enabled at compile-time.
- webkit/webkitgeolocationpolicydecision.cpp:
(_WebKitGeolocationPolicyDecisionPrivate):
(webkit_geolocation_policy_decision_new):
(webkit_geolocation_policy_allow):
(webkit_geolocation_policy_deny):
- webkit/webkitgeolocationpolicydecisionprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- 3:10 PM Changeset in webkit [111914] by
-
- 27 edits in trunk/Source
[GObject bindings] Supplemental interfaces are not disabled with the "Conditional" attribute
https://bugs.webkit.org/show_bug.cgi?id=80030
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-23
Reviewed by Martin Robinson.
Source/WebCore:
Changes in CodeGeneratorGObject.pm:
- group implementation of private helpers and guard them inside
an ifdef if a root conditional attribute is present.
- always define the type of a GObject binding, even if the root
conditional feature is not enabled
- the methods are generated as well, but are simply stubs if the
feature is not enabled, throwing a warning upon interaction.
- if the method itself is guarded by a conditional attribute,
the stub implementation gains one more level of depth, throwing
a warning if the method's conditional feature is not enabled
but the root conditional feature is.
- small style fixes in random places.
Also changed are GObject baselines for binding tests.
No new tests - no new testable functionality.
- bindings/gobject/GNUmakefile.am:
- bindings/scripts/CodeGeneratorGObject.pm:
(HumanReadableConditional):
(GenerateConditionalWarn):
(GenerateProperty):
(GenerateProperties):
(GenerateFunction):
(GenerateFunctions):
(GenerateCFile):
(GenerateEventTargetIface):
(Generate):
(WriteData):
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_foo):
- bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_exciting_function):
(webkit_dom_test_active_dom_object_post_message):
(webkit_dom_test_active_dom_object_get_exciting_attr):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_another_function):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(WebKit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_item):
(webkit_dom_test_event_target_dispatch_event):
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_supplemental_method4):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(WebKit):
(WebKit::kit):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_constructed):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_int_method):
(webkit_dom_test_obj_int_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_idb_key):
(webkit_dom_test_obj_options_object):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_class_method):
(webkit_dom_test_obj_class_method_with_optional):
(webkit_dom_test_obj_overloaded_method1):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert3):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_mutable_point_function):
(webkit_dom_test_obj_immutable_point_function):
(webkit_dom_test_obj_orange):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_read_only_int_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_short_attr):
(webkit_dom_test_obj_set_short_attr):
(webkit_dom_test_obj_get_unsigned_short_attr):
(webkit_dom_test_obj_set_unsigned_short_attr):
(webkit_dom_test_obj_get_int_attr):
(webkit_dom_test_obj_set_int_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):
(webkit_dom_test_obj_set_xml_obj_attr):
(webkit_dom_test_obj_get_create):
(webkit_dom_test_obj_set_create):
(webkit_dom_test_obj_get_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_get_reflected_integral_attr):
(webkit_dom_test_obj_set_reflected_integral_attr):
(webkit_dom_test_obj_get_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_set_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_get_reflected_boolean_attr):
(webkit_dom_test_obj_set_reflected_boolean_attr):
(webkit_dom_test_obj_get_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_get_reflected_custom_integral_attr):
(webkit_dom_test_obj_set_reflected_custom_integral_attr):
(webkit_dom_test_obj_get_reflected_custom_boolean_attr):
(webkit_dom_test_obj_set_reflected_custom_boolean_attr):
(webkit_dom_test_obj_get_reflected_custom_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_get_string_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_content_document):
(webkit_dom_test_obj_get_mutable_point):
(webkit_dom_test_obj_set_mutable_point):
(webkit_dom_test_obj_get_immutable_point):
(webkit_dom_test_obj_set_immutable_point):
(webkit_dom_test_obj_get_strict_float):
(webkit_dom_test_obj_set_strict_float):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
(webkit_dom_test_serialized_script_value_interface_get_value):
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
Source/WebKit/gtk:
Add a private macro that can be used when necessary to throw a warning
about a future not enabled at compile-time.
- webkit/webkitglobalsprivate.h:
- 3:09 PM Changeset in webkit [111913] by
-
- 6 edits in trunk/Source
[chromium] Record painted pixel counts for measuring effectiveness of per-tile painting
https://bugs.webkit.org/show_bug.cgi?id=82057
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.
Source/WebCore:
Adds painted pixel metrics to CCOverdrawMetrics class, and calls in
to report painted areas when updating tiles in the TiledLayerChromium
class.
Unit test: TiledLayerChromiumTest.opaqueContentsRegion
TiledLayerChromiumTest.pixelsPaintedMetrics
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didPaint):
(WebCore):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
- platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsPainted):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):
- 3:05 PM Changeset in webkit [111912] by
-
- 3 edits2 adds in trunk
Crash in RenderBlock::splitBlocks.
https://bugs.webkit.org/show_bug.cgi?id=81926
Reviewed by Julien Chaffraix.
Source/WebCore:
We are updating the :after content before calling splitFlow. The :after content
gets blown away since it will go to the continuation. beforeChild was earlier
set to the first child. Being the last anonymous block, its children gets pulled
up in collapseAnonymousBoxChild and it gets destroyed. So, we need to update
beforeChild value.
Test: fast/multicol/span/update-after-content-before-child-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
LayoutTests:
- fast/multicol/span/update-after-content-before-child-crash.html: Added.
- 3:03 PM Changeset in webkit [111911] by
-
- 2 edits in trunk/Source/WebKit2
[WinCairo] Unreviewed build fix.
- win/WebKit2CFLite.def: Add missing export symbols so that other
tools can link properly.
- 2:47 PM Changeset in webkit [111910] by
-
- 6 edits42 adds in trunk/LayoutTests
Integrate IETC CSS : textshadow tests
https://bugs.webkit.org/show_bug.cgi?id=81936
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-23
Reviewed by Adam Barth.
- ietestcenter/TestSupport/FeatureDetection.js: Added.
- ietestcenter/css3/support/TahomaNarrow.ttf: Added.
- ietestcenter/css3/support/TahomaNormal.ttf: Added.
- ietestcenter/css3/support/TahomaT.ttf: Added.
- ietestcenter/css3/support/ahem.ttf: Added.
- ietestcenter/css3/support/black_color.png: Added.
- ietestcenter/css3/support/black_red.png: Added.
- ietestcenter/css3/support/blue_color.png: Added.
- ietestcenter/css3/support/cat.png: Added.
- ietestcenter/css3/support/flexbox_100r_50g_100r_50g_100g.png: Added.
- ietestcenter/css3/support/flexbox_100x100_green.png: Added.
- ietestcenter/css3/support/flexbox_100x100_red.png: Added.
- ietestcenter/css3/support/flexbox_100x100g_red.png: Added.
- ietestcenter/css3/support/flexbox_200x100_red.png: Added.
- ietestcenter/css3/support/flexbox_200x100g_red.png: Added.
- ietestcenter/css3/support/flexbox_300x100_red.png: Added.
- ietestcenter/css3/support/flexbox_300x150_100red.png: Added.
- ietestcenter/css3/support/flexbox_300x200_red.png: Added.
- ietestcenter/css3/support/flexbox_300x50_100_80_baseline_red.png: Added.
- ietestcenter/css3/support/flexbox_300x50_100_80_red.png: Added.
- ietestcenter/css3/support/green_color.png: Added.
- ietestcenter/css3/support/red_color.png: Added.
- ietestcenter/css3/support/red_space_pb.png: Added.
- ietestcenter/css3/support/scope-003.css: Added.
- ietestcenter/css3/support/space_border_box.png: Added.
- ietestcenter/css3/support/syntax-018.css: Added.
- ietestcenter/css3/support/syntax-019.css: Added.
- ietestcenter/css3/support/white_color.png: Added.
- ietestcenter/css3/text/textshadow-001.htm: Added.
- ietestcenter/css3/text/textshadow-002.htm: Added.
- ietestcenter/css3/text/textshadow-003.htm: Added.
- ietestcenter/css3/text/textshadow-004.htm: Added.
- ietestcenter/css3/text/textshadow-005.htm: Added.
- ietestcenter/css3/text/textshadow-006.htm: Added.
- ietestcenter/css3/text/textshadow-007.htm: Added.
- ietestcenter/css3/text/textshadow-008.htm: Added.
- ietestcenter/css3/text/textshadow-009.htm: Added.
- ietestcenter/css3/text/textshadow-010.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 2:45 PM Changeset in webkit [111909] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Improved composited debug borders
https://bugs.webkit.org/show_bug.cgi?id=82071
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.
Fix the problem with missing debug borders. Since we append quads
to the list front to back now, we draw the quads in the list from
back to front of the list. Which means if the debug quad is added
after the layer it is drawing around, the layer can draw over top
of its debug quad. Reverse the ordering when appending to fix it.
Make the border red around tiles that are checkerboarded. Missing
tiles in non-root layers are drawn clear, so this makes them more
visible.
Put a blue border around each render surface, and a purple border
on their replicas.
No new tests.
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore):
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::hasReplica):
(WebCore):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore):
(WebCore::CCTiledLayerImpl::appendQuads):
- 2:40 PM Changeset in webkit [111908] by
-
- 4 edits in trunk/Source/WebCore
Move code that calls setAcceleratesDrawing() on GraphicsLayers into RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=82092
Reviewed by Dean Jackson.
A RenderLayerBacking manages several GraphicsLayers, but RenderLayerCompositor
was only calling setAcceleratesDrawing() on the one it knows about. Fix by moving
this setting code down into RenderLayerBacking.
RenderLayerCompositor now caches the setAcceleratesDrawing setting, as it does
for other compositing-related settings, so that RenderLayerBacking doesn't have
to grovel for Settings every time.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateBacking):
- rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::acceleratedDrawingEnabled):
(RenderLayerCompositor):
- 2:38 PM Changeset in webkit [111907] by
-
- 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
Reverting unintential change to JavaScriptCore xcode project file
checked in with change set r111906.
- 2:27 PM Changeset in webkit [111906] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG::compileValueToInt32 Sometime Generates GPR to FPR reg back to GPR
https://bugs.webkit.org/show_bug.cgi?id=81805
Reviewed by Filip Pizlo.
Added SpeculativeJIT::checkGeneratedType() to determine the current format
of an operand. Used that information in SpeculativeJIT::compileValueToInt32
to generate code that will use integer and JSValue types in integer
format directly without a conversion to double.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedType):
(DFG):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- dfg/DFGSpeculativeJIT.h:
(DFG):
(SpeculativeJIT):
- 2:24 PM HackingGtk edited by
- (diff)
- 2:19 PM Changeset in webkit [111905] by
-
- 2 edits in trunk/LayoutTests
Added all tests that crashed more than once on the Lion WebKit2 bots between r111885
and r111892 to the Mac WebKit2 skip list (that weren’t alread on the list).
Rubber-stamped by Geoff Garen.
- platform/mac-wk2/Skipped:
- 2:16 PM Changeset in webkit [111904] by
-
- 2 edits in trunk/Source/WTF
[chromium] Unreviewed, move a comment closer to where it matters and
make it more specific.
- WTF.gyp/WTF.gyp:
- 2:10 PM Changeset in webkit [111903] by
-
- 2 edits1 move1 delete in trunk/LayoutTests
[chromium] Unreviewed, rebaseline platform/chromium/compositing/3d-corners.html
https://bugs.webkit.org/show_bug.cgi?id=69124
Somebody checked in an incorrect windows expectation missing a
newline. Fixing.
- platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/3d-corners-expected.png.
- platform/chromium-win/platform/chromium/compositing/3d-corners-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:09 PM Changeset in webkit [111902] by
-
- 4 edits in trunk/Tools
LayoutTestHelper could get torn down earlier (mostly to reset color profile)
https://bugs.webkit.org/show_bug.cgi?id=80567
Reviewed by Ryosuke Niwa.
Move clean_up_run to occur right after we finish testing and
before we start processing the results. Also makes set_up_run()
and clean_up_run() private since there's no real need for
callers to be aware of them.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
(Manager.run):
(Manager._clean_up_run):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- 2:02 PM Changeset in webkit [111901] by
-
- 7 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=82083
Rubber-stamped by Simon Fraser.
This patch is just a name change. getExistingScrollAnimator() (which was
added earlier today) is now existingScrollAnimator().
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTapDown):
- page/FrameView.cpp:
(WebCore::FrameView::setAnimatorsAreActive):
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::willStartLiveResize):
(WebCore::ScrollableArea::willEndLiveResize):
(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):
(WebCore::ScrollableArea::contentsResized):
(WebCore::ScrollableArea::serviceScrollAnimations):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::existingScrollAnimator):
- 2:00 PM Changeset in webkit [111900] by
-
- 2 edits1 delete in trunk/LayoutTests
Revert r111891. Instead, add editing/inserting/insert-bg-font.html to the list of failing tests.
Again, the failure is tracked by the bug https://bugs.webkit.org/show_bug.cgi?id=82079.
- platform/mac-lion/Skipped:
- platform/mac-lion/editing: Removed.
- platform/mac-lion/editing/inserting: Removed.
- platform/mac-lion/editing/inserting/insert-bg-font-expected.txt: Removed.
- 1:56 PM Changeset in webkit [111899] by
-
- 4 edits2 adds in trunk
Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=81359
Reviewed by Eric Seidel.
Source/WebCore:
Similar to r110323, adds the canUpdateSelectionOnRootLineBoxes
check to more places.
Test: editing/selection/clear-selection-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
LayoutTests:
- editing/selection/clear-selection-crash-expected.txt: Added.
- editing/selection/clear-selection-crash.html: Added.
- 1:47 PM Changeset in webkit [111898] by
-
- 3 edits2 adds in trunk/Source
Update Apple Windows build files for WTF move
https://bugs.webkit.org/show_bug.cgi?id=82069
Reviewed by Jessie Berlin.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Removed WTF and WTFGenerated.
../WTF:
- WTF.vcproj/WTF.make: Added.
- WTF.vcproj/WTF.sln: Added.
- 1:45 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:43 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:40 PM Changeset in webkit [111897] by
-
- 2 edits57 moves1863 adds57 deletes in trunk/LayoutTests
Initial triage pass of css3/selectors3/xml for the Chromium ports.
The difference from the Apple Mac results are all text rendering or
cases where the Chromium result is clearly correct and the Apple Mac
result is clearly incorrect.
All changes done to the non-chromium ports were done automatically
by "webkit-patch optimize-baselines".
- 1:40 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:37 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:36 PM Changeset in webkit [111896] by
-
- 7 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=82083
Too many ScrollAnimators are allocated on pages with frames
Reviewed by Geoffrey Garen.
This patch adds a new getter to ScrollableArea called
getExistingScrollAnimator() unlike scrollAnimator() this new function will
just return null if there is not already a ScrollAnimator. Callers should use
this new function when they have business with ScrollAnimator that does not
need to do anything when there are no scrollbars.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTapDown):
- page/FrameView.cpp:
(WebCore::FrameView::setAnimatorsAreActive):
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::willStartLiveResize):
(WebCore::ScrollableArea::willEndLiveResize):
(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
(WebCore::ScrollableArea::contentsResized):
(WebCore::ScrollableArea::serviceScrollAnimations):
- platform/ScrollableArea.h:
(ScrollableArea):
(WebCore::ScrollableArea::getExistingScrollAnimator):
- 1:26 PM Changeset in webkit [111895] by
-
- 7 edits2 adds in trunk
Deal with DOM modifications when evaluating source elements.
https://bugs.webkit.org/show_bug.cgi?id=81163
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: media/video-beforeload-remove-source.html
- dom/ContainerNode.cpp: Make NodeVector and collectNodes public, renamed as getChildNodes.
(WebCore::ContainerNode::takeAllChildrenFrom): collectNodes -> getChildNodes.
(WebCore::ContainerNode::willRemove): collectNodes -> getChildNodes.
(WebCore::ContainerNode::willRemoveChildren): collectNodes -> getChildNodes.
(WebCore::ContainerNode::insertedIntoDocument): collectNodes -> getChildNodes.
(WebCore::ContainerNode::removedFromDocument): collectNodes -> getChildNodes.
- dom/ContainerNode.h:
(WebCore::getChildNodes):
- editing/ReplaceSelectionCommand.cpp: Remove unused NodeVector declaration.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): m_nextChildNodeToConsider and m_currentSourceNode
are now RefPtrs.
(WebCore::HTMLMediaElement::loadTimerFired): Protect HTMLMediaElement from being deleted during
a DOM modification during an event callback.
(WebCore::HTMLMediaElement::load): Ditto.
(WebCore::HTMLMediaElement::selectMediaResource): Set m_nextChildNodeToConsider to the first
child node, it will be the first node considered.
(WebCore::HTMLMediaElement::havePotentialSourceChild): m_nextChildNodeToConsider and m_currentSourceNode
are now RefPtrs.
(WebCore::HTMLMediaElement::selectNextSourceChild): Collect all child nodes in a vector before
looking for <source> nodes because 'beforeload' event handlers can mutate the DOM. Don't
use a <source> that is no longer a child node after 'beforeload'. Use 0 to represent the end
of the child node list because m_nextChildNodeToConsider is now a RefPtr so using the previous
sentinel, "this", would cause a retain cycle.
(WebCore::HTMLMediaElement::sourceWasAdded): m_nextChildNodeToConsider and m_currentSourceNode
are now RefPtrs.
(WebCore::HTMLMediaElement::sourceWillBeRemoved): Ditto.
(WebCore::HTMLMediaElement::getPluginProxyParams): Protect HTMLMediaElement from being deleted during
a DOM modification during an event callback.
- html/HTMLMediaElement.h:
LayoutTests:
- media/video-beforeload-remove-source-expected.txt: Added.
- media/video-beforeload-remove-source.html: Added.
- 1:24 PM Changeset in webkit [111894] by
-
- 2 edits in trunk/LayoutTests
Added all tests that crashed more than once on the Lion WebKit2 bots between r111865
and r111885 to the Mac WebKit2 skip list (that weren’t alread on the list).
Rubber-stamped by Geoff Garen.
- platform/mac-wk2/Skipped:
- 1:18 PM Changeset in webkit [111893] by
-
- 14 edits in trunk
Disable CSS_SHADERS in Apple builds https://bugs.webkit.org/show_bug.cgi?id=81996
Source/JavaScriptCore:
Reviewed by Simon Fraser.
Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Simon Fraser.
Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Reviewed by Simon Fraser.
Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Reviewed by Simon Fraser.
Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Reviewed by Simon Fraser.
Put ENABLE_CSS_SHADERS into Platform.h, but disable for
Apple builds.
- wtf/Platform.h:
Tools:
Reviewed by Simon Fraser.
- Scripts/build-webkit:
LayoutTests:
Add css3/filters/custom to the skipped list.
Reviewed by Simon Fraser.
- platform/mac/Skipped:
- 1:07 PM Changeset in webkit [111892] by
-
- 3 edits in trunk/LayoutTests
Updated Mac expected results for these tests by reverting r111339, now that bug 81826 was
fixed in r111882.
- platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
- 1:03 PM Changeset in webkit [111891] by
-
- 1 edit1 copy4 adds in trunk/LayoutTests
Add a failing expectation for the bug 82079.
- platform/editing: Added.
- platform/editing/inserting: Added.
- platform/mac-lion/editing: Added.
- platform/mac-lion/editing/inserting: Added.
- platform/mac-lion/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/editing/inserting/insert-bg-font-expected.txt.
- 1:00 PM Changeset in webkit [111890] by
-
- 13 edits2 adds in trunk
Relanding(r111754): HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
https://bugs.webkit.org/show_bug.cgi?id=80428
.:
Patch by Dave Michael <dmichael@chromium.org> on 2012-03-23
Source/WebCore:
Patch by Dave Michael <dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.
Make HTMLPluginElement release its m_NPObject in detach() to break a
reference-counting cycle that happens on reload or navigation. With this
change, HTMLPlugInElement::removedFromDocument is unnecessary, so it
was removed. Note that Releasing m_NPObject does not result in a call to
the plugin; it simply releases a reference count on the wrapper object
for this HTMLPlugInElement. (The plugin's NPP_Deallocate is invoked
when the render tree is destroyed, when PluginView calls
PluginPackage::unload.) Thus, it is safe to release m_NPObject in
detach, because it can not result in layout or style changes.
Also added numberOfLiveNodes() and numberOfLiveDocuments() to
window.internals to enable testing.
Test: plugins/netscape-dom-access-and-reload.html
- WebCore.exp.in:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::detach):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::numberOfLiveNodes):
(WebCore::Internals::numberOfLiveDocuments):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
Patch by Dave Michael <dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.
- win/WebKit2.def: Export a symbol for InspectorCounters::counterValue
- win/WebKit2CFLite.def: Export a symbol for InspectorCounters::counterValue
LayoutTests:
Patch by Dave Michael <dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.
Due to unfortunate copy/paste laziness, the new test was using the same
window.sessionStorage as plugins/reloadplugins-and-pages.html, so that
if the tests were run in the same session, reloadplugins-and-pages.html
would *not* reload as it was supposed to, causing a text mismatch. This
patch uses a more appropriate and unique name so that these two tests
won't affect each other.
- plugins/netscape-dom-access-and-reload-expected.txt: Added.
- plugins/netscape-dom-access-and-reload.html: Added.
- 12:57 PM Changeset in webkit [111889] by
-
- 13 edits3 adds in trunk/Source/JavaScriptCore
RexExp constructor last match properties should not rely on previous ovector
https://bugs.webkit.org/show_bug.cgi?id=82077
Reviewed by Oliver Hunt.
This change simplifies matching, and will enable subpattern results to be fully lazily generated in the future.
This patch changes the scheme used to lazily generate the last match properties of the RegExp object.
Instead of relying on the results in the ovector, we can instead lazily generate the subpatters using
a RegExpMatchesArray. To do so we just need to store the input, the regexp matched, and the match
location (the MatchResult). When the match is accessed or the input is set, we reify results. We use
a special value of setting the saved result to MatchResult::failed() to indicated that we're in a
reified state. This means that next time a match is performed, the store of the result will
automatically blow away the reified value.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files.
- runtime/RegExp.cpp:
(JSC::RegExpFunctionalTestCollector::outputOneTest):
- changed 'subPattern' -> 'subpattern' (there was a mix in JSC, 'subpattern' was more common).
- runtime/RegExpCachedResult.cpp: Added.
(JSC::RegExpCachedResult::visitChildren):
(JSC::RegExpCachedResult::lastResult):
(JSC::RegExpCachedResult::setInput):
- New methods, mark GC objects, lazily create the matches array, and record a user provided input (via assignment to RegExp.inupt).
- runtime/RegExpCachedResult.h: Added.
(RegExpCachedResult):
- Added new class.
(JSC::RegExpCachedResult::RegExpCachedResult):
(JSC::RegExpCachedResult::record):
(JSC::RegExpCachedResult::input):
- Initialize the object, record the result of a RegExp match, access the stored input property.
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
- Initialize m_result/m_multiline properties.
(JSC::RegExpConstructor::visitChildren):
- Make sure the cached results (or lazy source for them) are marked.
(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):
- Moved from RegExpConstructor, moved to RegExpCachedResult, and using new caching scheme.
(JSC::regExpConstructorInput):
(JSC::setRegExpConstructorInput):
- Changed to use RegExpCachedResult.
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
(RegExpConstructor):
(JSC::RegExpConstructor::setMultiline):
(JSC::RegExpConstructor::multiline):
- Move multiline property onto the constructor object; it is not affected by the last match.
(JSC::RegExpConstructor::setInput):
(JSC::RegExpConstructor::input):
- These defer to RegExpCachedResult.
(JSC::RegExpConstructor::performMatch):
- runtime/RegExpMatchesArray.cpp: Added.
(JSC::RegExpMatchesArray::visitChildren):
- Eeeep! added missing visitChildren!
(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::reifyAllProperties):
(JSC::RegExpMatchesArray::reifyMatchProperty):
- Moved from RegExpConstructor.cpp.
(JSC::RegExpMatchesArray::leftContext):
(JSC::RegExpMatchesArray::rightContext):
- Since the match start/
- runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):
- Declare new methods & structure flags.
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- performMatch now requires the JSString input, to cache.
- runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- performMatch now requires the JSString input, to cache.
- 12:49 PM WebKitGTK/1.8.x edited by
- (diff)
- 12:37 PM Changeset in webkit [111888] by
-
- 6 edits2 adds in trunk
CSSParser doesn't set border-*-width/style/color to initial by border shorthand property
https://bugs.webkit.org/show_bug.cgi?id=82040
Reviewed by Antti Koivisto.
Source/WebCore:
The border shorthand property sets values for border-width, border-style, and border-color shorthand properties.
While CSSParser::parseValue can process these shorthand properties properly and set the longhand properties
such as border-top-width, border-right-width, ... border-left-color, CSSParser::addProperty can't and the
initialization in parseShorthand fails for the border property.
Fixed the bug by explicitly initializing longhand properties.
Changing the behavior here is unlikely to break the Web since our behavior already differs from that of Firefox
and Internet Explorer. Both of those browsers return the actual initial values such as "medium" and "currentColor".
This discrepancy is tracked by https://bugs.webkit.org/show_bug.cgi?id=82078.
Test: fast/css/border-shorthand-initialize-longhands.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Uses borderAbridgedLonghand.
(WebCore::CSSParser::parseShorthand): Uses longhand properties for initialization if one is available.
This allows us to initialize multiple properties (e.g. border-*-color) for a single property missing in the set.
- css/CSSPropertyLonghand.cpp:
(WebCore::borderAbridgedLonghand): Added. The longhand here (border-width, border-style, border-color) is
"abridged" in the sense that they're still shorthands.
- css/CSSPropertyLonghand.h:
(WebCore::CSSPropertyLonghand::CSSPropertyLonghand):
(CSSPropertyLonghand): Added the version that takes longhand instances for initialization purposes.
(WebCore::CSSPropertyLonghand::longhandsForInitialization):
LayoutTests:
Added a comprehensive regression test.
- fast/css/border-shorthand-initialize-longhands-expected.txt: Added.
- fast/css/border-shorthand-initialize-longhands.html: Added.
- inspector/styles/styles-new-API-expected.txt: Correctly lists border's longhand properties.
- 12:30 PM Changeset in webkit [111887] by
-
- 10 edits in trunk
[chromium] rename newwtf target back to wtf
https://bugs.webkit.org/show_bug.cgi?id=82064
Reviewed by Adam Barth.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
Source/Platform:
- Platform.gyp/Platform.gyp:
Source/WebCore:
No new tests, only renaming a build target.
- WebCore.gyp/WebCore.gyp:
Source/WTF:
- WTF.gyp/WTF.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 12:24 PM Changeset in webkit [111886] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Turn off painting of scrollbars on compositor thread for unsupported platforms
https://bugs.webkit.org/show_bug.cgi?id=82066
Reviewed by James Robinson.
With threaded compositing, OSX will crash and Windows will have black
scrollbars. Fix that by reverting to the previosu behavior of updating
scrollbars on the main thread instead.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollbarLayerDidChange):
- 12:19 PM WebKitGTK/1.8.x edited by
- (diff)
- 11:40 AM Changeset in webkit [111885] by
-
- 2 edits57 moves1749 adds57 deletes in trunk/LayoutTests
Initial triage pass of css3/selectors3/xhtml for the Chromium ports.
The difference from the Apple Mac results are all text rendering or
cases where the Chromium results is clearly correct and the Apple Mac
result is clearly incorrect.
All changes done to the non-chromium ports were done automatically
by "webkit-patch optimize-baselines".
- 11:34 AM Changeset in webkit [111884] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers https://bugs.webkit.org/show_bug.cgi?id=81351
Rubber-stamped by Jessie Berlin.
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
the issue is still noticeable, but it does not automatically make the debug bots red.
- 11:30 AM Changeset in webkit [111883] by
-
- 3 edits1 move in trunk
CSS3 calc: image sizing works with mixed percentage/absolute
https://bugs.webkit.org/show_bug.cgi?id=82017
Reviewed by Ojan Vafai.
Source/WebCore:
Test: css3/calc/img-size-expected.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
LayoutTests:
Test is now expected to match.
- css3/calc/img-size-expected.html: Renamed from LayoutTests/css3/calc/img-size-expected-mismatch.html.
- 11:27 AM Changeset in webkit [111882] by
-
- 9 edits1 move in trunk
REGRESSION(107971): Google Voice contact list is broken in WebKit due to badly allocating the extra height
https://bugs.webkit.org/show_bug.cgi?id=81826
Reviewed by Tony Chang.
Source/WebCore:
Covered by tables/mozilla/bugs/bug27038-{1|2}.html.
This partly reverts r107971: the extra logical height distribution change was not needed
to fix the bug (it is needed by the test though). We revert to giving all the extra height
to the first tbody and not the first section.
This is broken but unfortunately some websites are relying on that. Getting a real
distribution algorithm is covered by bug 81824. However this is super tricky to get
right and I did not want to add more compatibility risks until I have something solid.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::distributeExtraLogicalHeight):
LayoutTests:
- fast/table/double-height-table-no-tbody.html-disabled: Renamed from LayoutTests/fast/table/double-height-table-no-tbody.html.
Disabled this test as it relies on our algorithm not to discriminate between first sections.
- platform/chromium/test_expectations.txt:
- platform/qt/Skipped:
Mark those 2 tests as needing a new baseline again.
- platform/efl/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/test_expectations.txt:
- platform/win/Skipped:
Those platforms did not rebaseline those 2 tests so they should automatically pass them.
- 11:23 AM Changeset in webkit [111881] by
-
- 5 edits20 adds in trunk/LayoutTests
Unreviewed rebasline, add expectations for new test introducted in r111872.
- platform/chromium-mac-leopard/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-mac-leopard/fast/canvas/setWidthResetAfterForcedRender-expected.png:
- platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/setWidthResetAfterForcedRender-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-mac/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win-vista/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win-vista/platform/chromium/virtual: Added.
- platform/chromium-win-vista/platform/chromium/virtual/gpu: Added.
- platform/chromium-win-vista/platform/chromium/virtual/gpu/fast: Added.
- platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas: Added.
- platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win-xp/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/virtual: Added.
- platform/chromium-win-xp/platform/chromium/virtual/gpu: Added.
- platform/chromium-win-xp/platform/chromium/virtual/gpu/fast: Added.
- platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas: Added.
- platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- 11:14 AM Changeset in webkit [111880] by
-
- 3 edits in trunk/Source/WebCore
Optimize for IPP in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80255
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-23
Reviewed by Chris Rogers.
Increase ~2X performance by conv() in IPP.
- platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
- platform/audio/DirectConvolver.h:
(DirectConvolver):
- 11:12 AM Changeset in webkit [111879] by
-
- 2 edits in trunk/LayoutTests
Added more appcache tests to the Mac WebKit2 skip list due to intermittent failures.
<http://webkit.org/b/82061> tracks this issue.
- platform/mac-wk2/Skipped:
- 11:08 AM Changeset in webkit [111878] by
-
- 5 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline after r111876 and r111731.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/fast/ruby/ruby-text-before-child-split-expected.txt: Added.
- 10:19 AM Changeset in webkit [111877] by
-
- 9 edits in trunk/Source/JavaScriptCore
Simplify memory usage tracking in CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=80705
Reviewed by Filip Pizlo.
- heap/CopiedAllocator.h:
(CopiedAllocator): Rename currentUtilization to currentSize.
(JSC::CopiedAllocator::currentCapacity):
- heap/CopiedBlock.h:
(CopiedBlock):
(JSC::CopiedBlock::payload): Move the implementation of payload() out of the class
declaration.
(JSC):
(JSC::CopiedBlock::size): Add new function to calculate the block's size.
(JSC::CopiedBlock::capacity): Ditto for capacity.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::CopiedSpace): Remove old bogus memory stats fields and add a new
field for the water mark.
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase): When we fail to allocate from the current
block, we need to update our current water mark with the size of the block.
(JSC::CopiedSpace::tryAllocateOversize): When we allocate a new oversize block, we
need to update our current water mark with the size of the used portion of the block.
(JSC::CopiedSpace::tryReallocate): We don't need to update the water mark when
reallocating because it will either get accounted for when we fill up the block later
in the case of being able to reallocate in the current block or it will get picked up
immediately because we'll have to get a new block.
(JSC::CopiedSpace::tryReallocateOversize): We do, however, need to update in when
realloc-ing an oversize block because we deallocate the old block and allocate a brand
new one.
(JSC::CopiedSpace::doneFillingBlock): Update the water mark as blocks are returned to
the CopiedSpace by the SlotVisitors.
(JSC::CopiedSpace::doneCopying): Add in any pinned blocks to the water mark.
(JSC::CopiedSpace::getFreshBlock): We use the Heap's new function to tell us whether or
not we should collect now instead of doing the calculation ourself.
(JSC::CopiedSpace::destroy):
(JSC):
(JSC::CopiedSpace::size): Manually calculate the size of the CopiedSpace, similar to how
MarkedSpace does.
(JSC::CopiedSpace::capacity): Ditto for capacity.
- heap/CopiedSpace.h:
(JSC::CopiedSpace::waterMark):
(CopiedSpace):
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying): Reset water mark to 0 when we start copying during a
collection.
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::allocateFromBlock):
- heap/Heap.cpp:
(JSC::Heap::size): Incorporate size of CopiedSpace into the total size of the Heap.
(JSC::Heap::capacity): Ditto for capacity.
(JSC::Heap::collect):
- heap/Heap.h:
(Heap):
(JSC::Heap::shouldCollect): New function for other sub-parts of the Heap to use to
determine whether they should initiate a collection or continue to allocate new blocks.
(JSC):
(JSC::Heap::waterMark): Now is the sum of the water marks of the two sub-parts of the
Heap (MarkedSpace and CopiedSpace).
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Changed to use the Heap's new shouldCollect() function.
- 10:16 AM Changeset in webkit [111876] by
-
- 7 edits1 copy4 adds in trunk/Source/WebCore
MediaStream API (JSEP): Introducing PeerConnection00 and IceCallback
https://bugs.webkit.org/show_bug.cgi?id=81657
Reviewed by Adam Barth.
Last major WebCore patch for the JSEP PeerConnection, together with the associated
IceCallback (they both depend on each other and IceCallback has very few lines of real code).
My next patch after this one will do a major overhaul of the existing layout tests
and add a few new ones.
- GNUmakefile.list.am:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/IceCallback.h: Added.
(WebCore):
(IceCallback):
(WebCore::IceCallback::~IceCallback):
- Modules/mediastream/IceCallback.idl: Added.
- Modules/mediastream/PeerConnection00.cpp: Added.
(WebCore):
(WebCore::PeerConnection00::create):
(WebCore::PeerConnection00::PeerConnection00):
(WebCore::PeerConnection00::~PeerConnection00):
(WebCore::PeerConnection00::hasLocalAudioTrack):
(WebCore::PeerConnection00::hasLocalVideoTrack):
(WebCore::PeerConnection00::parseMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::setLocalDescription):
(WebCore::PeerConnection00::setRemoteDescription):
(WebCore::PeerConnection00::localDescription):
(WebCore::PeerConnection00::remoteDescription):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::processIceMessage):
(WebCore::PeerConnection00::readyState):
(WebCore::PeerConnection00::iceState):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::removeStream):
(WebCore::PeerConnection00::localStreams):
(WebCore::PeerConnection00::remoteStreams):
(WebCore::PeerConnection00::close):
(WebCore::PeerConnection00::didGenerateIceCandidate):
(WebCore::PeerConnection00::didChangeReadyState):
(WebCore::PeerConnection00::didChangeIceState):
(WebCore::PeerConnection00::didAddRemoteStream):
(WebCore::PeerConnection00::didRemoveRemoteStream):
(WebCore::PeerConnection00::interfaceName):
(WebCore::PeerConnection00::scriptExecutionContext):
(WebCore::PeerConnection00::stop):
(WebCore::PeerConnection00::eventTargetData):
(WebCore::PeerConnection00::ensureEventTargetData):
(WebCore::PeerConnection00::changeReadyState):
(WebCore::PeerConnection00::changeIceState):
- Modules/mediastream/PeerConnection00.h: Added.
(WebCore):
(PeerConnection00):
(WebCore::PeerConnection00::refEventTarget):
(WebCore::PeerConnection00::derefEventTarget):
- Modules/mediastream/PeerConnection00.idl: Added.
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):
- bindings/js/JSPeerConnection00Custom.cpp: Added.
(WebCore):
(WebCore::JSPeerConnection00Constructor::constructJSPeerConnection00):
- dom/EventTargetFactory.in:
- 10:13 AM Changeset in webkit [111875] by
-
- 4 edits in trunk/Source
[chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6
https://bugs.webkit.org/show_bug.cgi?id=82062
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
Source/WebKit/chromium:
Override the paint function so that it becomes a no-op. Painting
scrollbars on the impl thread is not yet supported on platforms other
than Linux or ChromeOS.
- tests/CCLayerTreeHostImplTest.cpp:
(ScrollbarLayerFakePaint):
(WebKitTests::ScrollbarLayerFakePaint::create):
(WebKitTests::ScrollbarLayerFakePaint::paint):
(WebKitTests::ScrollbarLayerFakePaint::ScrollbarLayerFakePaint):
(WebKitTests):
(WebKitTests::TEST_F):
- 10:10 AM Changeset in webkit [111874] by
-
- 7 edits in trunk/Source
[chromium] MediaStream API (JSEP): Extending WebMediaStreamCenter
https://bugs.webkit.org/show_bug.cgi?id=81924
Reviewed by Adam Barth.
Source/WebCore:
Nothing to test, just moving methods.
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSDP):
(WebCore):
Source/WebKit/chromium:
Adding the two constructSDP methods.
- bridge/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSDP):
(WebCore):
- bridge/MediaStreamCenterInternal.cpp:
(WebCore::MediaStreamCenterInternal::constructSDP):
(WebCore):
- bridge/MediaStreamCenterInternal.h:
(WebCore):
(MediaStreamCenterInternal):
- public/platform/WebMediaStreamCenter.h:
(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::constructSDP):
- 10:07 AM Changeset in webkit [111873] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Restored part of a change log entry that I deleted by accident in r111870
- 9:58 AM Changeset in webkit [111872] by
-
- 6 edits4 adds in trunk
Reuse buffer allocation if canvas size does not change
https://bugs.webkit.org/show_bug.cgi?id=80871
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-23
Reviewed by Stephen White.
Source/WebCore:
If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.
Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.
Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.
Test: fast/canvas/canvas-resize-after-paint-without-layout.html +
existing layout tests for canvas resetting.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer): Save the initial
graphics context state so we can restore it without creating a new
context.
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().
LayoutTests:
Add layout test to check canvas resizing without changing its layout size.
We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).
In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.
Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.
- fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
- fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
- platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.
- 9:54 AM Changeset in webkit [111871] by
-
- 2 edits in trunk/Source/WebCore
Fix some code generation warnings on GTK+.
Reviewed by Gustavo Noronha Silva.
No new tests. This just fixes warnings.
- GNUmakefile.am: Remove nonexistent directories from the list IDL directories.
- 9:50 AM Changeset in webkit [111870] by
-
- 2 edits in trunk/LayoutTests
Added all tests that failed more than once on the Lion WebKit2 Release bot between r111814
and r111865 to the Mac WebKit2 skip list (that weren’t alread on the list).
Rubber-stamped by Geoff Garen.
- platform/mac-wk2/Skipped:
- 9:40 AM Changeset in webkit [111869] by
-
- 2 edits in trunk/LayoutTests
Added all tests that failed more than once on the Lion WebKit2 Debug bot between r111808 and
r111849 to the Mac WebKit2 skip list (that weren’t alread on the list).
Rubber-stamped by Geoff Garen.
- platform/mac-wk2/Skipped:
- 9:35 AM Changeset in webkit [111868] by
-
- 2 edits in trunk/LayoutTests
Added all appcache tests to the Mac WebKit2 skip list due to intermittent failures. Filed
<http://webkit.org/b/82061> to track this issue.
- platform/mac-wk2/Skipped:
- 9:32 AM Changeset in webkit [111867] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r111751.
http://trac.webkit.org/changeset/111751
https://bugs.webkit.org/show_bug.cgi?id=82060
caused 15% page cycler regression for chromium-linux
(Requested by eae on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-23
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 9:14 AM Changeset in webkit [111866] by
-
- 2 edits in trunk/Tools
Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
the Lion Intel WebKit2 Debug bots.
https://bugs.webkit.org/show_bug.cgi?id=81012.
Rubber-stamped by Dan Bernstein.
Add a step to kill the pasteboard server while we investigate what is causing these
assertion failures (to get the bots green).
- BuildSlaveSupport/kill-old-processes:
- 9:04 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:46 AM Changeset in webkit [111865] by
-
- 12 edits in trunk/Source/WebCore
Support [ImplementedAs] for attributes
https://bugs.webkit.org/show_bug.cgi?id=81605
Reviewed by Adam Barth.
[ImplementedAs] just supports methods. [ImplementedAs] should support
attributes too.
Explained here: https://trac.webkit.org/wiki/WebKitIDL#ImplementedAs
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGenerator.pm: Modified to support [ImplementedAs] for attributes.
(AttributeNameForGetterAndSetter):
- bindings/scripts/test/TestObj.idl: Added a test case.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::strawberry):
(WebDOMTestObj::setStrawberry):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjStrawberry):
(WebCore::setJSTestObjStrawberry):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj strawberry]):
(-[DOMTestObj setStrawberry:]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::strawberryAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::strawberryAttrSetter):
(WebCore):
- 8:43 AM Changeset in webkit [111864] by
-
- 9 edits in trunk/Tools
[check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
https://bugs.webkit.org/show_bug.cgi?id=81986
Reviewed by David Levin.
Track whether or not errors are filtered in error handlers. If an
alphabetical sorting error is reported for a header and filtered, try
reporting it for the other potential source of the error. This ensures
that the style bot can still find new sorting errors in both potential
situations:
#include <foo.h> <-- 1. edited line
#include <baz.h> <-- 2. edited line
- Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line): Potentially report the error for both lines,
if the first error is filtered.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
test that allows only reporting errors for certain lines. This verifies that
when one line of an ordering error is filtered, the error is reported on the
other line.
(ErrorCollector.init):
(ErrorCollector.call):
(CppStyleTestBase.perform_lint):
(CppStyleTestBase.perform_language_rules_check):
(CppStyleTestBase.assert_language_rules_check):
(OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
Added a new test that verifies that when one line of the two lines of an ordering
error occur, the error is reported on the other line.
- Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
(MockErrorHandler.call): Report True because the error is handled.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(ErrorCollector.call): Ditto.
- Scripts/webkitpy/style/checkers/watchlist_unittest.py:
(MockErrorHandler.call): Ditto.
- Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(TestErrorHandler.call): Ditto.
- Scripts/webkitpy/style/checkers/xml_unittest.py:
(MockErrorHandler.call): Ditto.
- Scripts/webkitpy/style/error_handlers.py:
(DefaultStyleErrorHandler.call): Report True if the error is handled
and False if it is filtered.
- 8:04 AM Changeset in webkit [111863] by
-
- 2 edits in trunk/Tools
Build fix for WinCE after r111778.
- WinCELauncher/CMakeLists.txt:
- 7:53 AM Changeset in webkit [111862] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove unused variables from unittest.
https://bugs.webkit.org/show_bug.cgi?id=82054
Patch by Jonathan Backer <backer@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
- 7:43 AM Changeset in webkit [111861] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Try to skip the test before the crashing one.
- platform/qt-5.0-wk2/Skipped:
- 7:40 AM Changeset in webkit [111860] by
-
- 3 edits in trunk/LayoutTests
Unskipped some tests that don't fail on Qt5.
3 of them still fail on Qt5-wk2 so these tests will be skipped
Patch by János Badics <János Badics> on 2012-03-23
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- 7:25 AM Changeset in webkit [111859] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r111855.
http://trac.webkit.org/changeset/111855
https://bugs.webkit.org/show_bug.cgi?id=82053
It broke 30+ tests (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-23
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
- 7:04 AM Changeset in webkit [111858] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/Skipped: Skip one more crashing test.
- 7:00 AM Changeset in webkit [111857] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip crashing tests to paint the bot green.
- 6:27 AM Changeset in webkit [111856] by
-
- 8 edits in trunk/Source/WebCore
The JSC code generator doesn't generate correct code for Constructors
https://bugs.webkit.org/show_bug.cgi?id=82046
Reviewed by Kentaro Hara.
The main bulk of generated code for constructors uses the name jsConstructor
for the created object, and then calls GenerateParametersCheck which generates
code that uses the name castedThis.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObjConstructor::constructJSTestObj):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
- 6:27 AM Changeset in webkit [111855] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.
This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).
- UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
- 6:10 AM Changeset in webkit [111854] by
-
- 11 edits in branches/subpixellayout/Source/WebCore/rendering
Correct localSelectionRect to be a LayourRect since it's in local coordinates.
- 6:01 AM Changeset in webkit [111853] by
-
- 13 edits in trunk/Source/WebCore
The JSC code generator can't handle boolean arguments for Callbacks
https://bugs.webkit.org/show_bug.cgi?id=82045
Reviewed by Kentaro Hara.
CodeGeneratorJS.pm only handles DOMStrings and objects as arguments
for a Callback, so I added support for boolean values as well.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::callbackWithBoolean):
- bindings/scripts/test/CPP/WebDOMTestCallback.h:
(WebDOMTestCallback):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_callback_with_boolean):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
- bindings/scripts/test/JS/JSTestCallback.h:
(JSTestCallback):
- bindings/scripts/test/ObjC/DOMTestCallback.h:
- bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithBoolean:]):
- bindings/scripts/test/TestCallback.idl:
- bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
- bindings/scripts/test/V8/V8TestCallback.h:
(V8TestCallback):
- 5:41 AM Changeset in webkit [111852] by
-
- 3 edits2 adds in trunk
Touch adjustment forgets some subtarget quads.
https://bugs.webkit.org/show_bug.cgi?id=82044
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Do not uncritically skip all nodes that are ancestors to other test results.
Instead return the inner-most element if multiple nodes have the same distance.
Test: touchadjustment/block-testing.html
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
LayoutTests:
- touchadjustment/block-testing-expected.txt: Added.
- touchadjustment/block-testing.html: Added.
- 5:23 AM Changeset in webkit [111851] by
-
- 3 edits4 adds in trunk
TouchAdjustment does not correct for frame position
https://bugs.webkit.org/show_bug.cgi?id=82043
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Convert geometry to window coordinates before calculating distance.
Test: touchadjustment/iframe.html
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::distanceSquaredToTargetCenterLine):
LayoutTests:
Add test that will fail if frame position is not adjusted for.
- touchadjustment/iframe-expected.txt: Added.
- touchadjustment/iframe.html: Added.
- touchadjustment/resources/inner-frame.html: Added.
- 5:17 AM Changeset in webkit [111850] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Disable the flickable when pinching.
Reviewed by Kenneth Rohde Christiansen.
Set the interactivity of the internal flickable to false
when pinching so that it does not react to mouse events
which might break pinch zoom.
This is a temporal workaround and needed until the event
propagation in QtQuick is fixed.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
- 5:07 AM Changeset in webkit [111849] by
-
- 2 edits in trunk/Source/WebCore
Fixed minor WebInspector display issue
Clicking on disabled sections in Styles Sidebar Pane creates new elements.
https://bugs.webkit.org/show_bug.cgi?id=81925
Patch by Vlad Voicu <vladv@rosedu.org> on 2012-03-23
Reviewed by Timothy Hatcher
No new tests should be required.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):
- 5:02 AM Changeset in webkit [111848] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rebaselined run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod5Callback):
(WebCore::TestObjInternal::overloadedMethodCallback):
- 4:14 AM Changeset in webkit [111847] by
-
- 6 edits1 add in trunk/Source/WebKit/gtk
[GTK] Add a way to expose well known names for items in the default context menu
https://bugs.webkit.org/show_bug.cgi?id=67660
Reviewed by Martin Robinson.
Add WebKitContextMenuAction enum containing all possible context
menu item actions.
- GNUmakefile.am: Add new files to compilation.
- WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::inputMethodsMenuItem): Use WebCore context menu classes
to create the context menu and its items to make sure all items
have a GtkAction associated.
(WebKit::insertControlCharacter):
(WebKit::unicodeMenuItem): Ditto.
- tests/testcontextmenu.c: Added.
(testInfoNew):
(testInfoDestroy):
(contextMenuFixtureSetup):
(contextMenuFixtureTeardown):
(checkAction):
(checkActionWithSubmenu):
(checkSeparator):
(contextMenuCallback):
(pushEvent):
(loadStatusCallback):
(mapEventCallback):
(testContextMenu):
(contextMenuCustomItemCallback):
(testContextMenuCustomItem):
(main):
- webkit/webkitglobals.cpp:
(webkit_context_menu_item_get_action): Return the
WebKitContextMenuAction for the given context menu item.
- webkit/webkitglobals.h:
- 3:19 AM Changeset in webkit [111846] by
-
- 2 edits in trunk/Tools
Unreviewed buildfix for the Chromium Android builder.
Disable the ImageDiff target for now. Android needs to build this for
host rather than for target (as other configurations do), but since the
WTF move the dependency chain got significantly more complicated.
I'll work out a proper fix in the following bug, but since several
things are broken due to this, this buildfix should be landed first.
https://bugs.webkit.org/show_bug.cgi?id=82039
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 3:16 AM WebKitGTK/1.8.x edited by
- (diff)
- 2:52 AM Changeset in webkit [111845] by
-
- 2 edits in trunk/Source/WebCore
cssText should use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=82028
Reviewed by Hajime Morita.
Make StylePropertySet::asText more efficient by deploying StringBuilder;
avoids heap churn by String::operator+ and String::operator+=.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
- 2:40 AM Changeset in webkit [111844] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed. Rename a variable name in API documentation.
Rename keyboard_mode to triggered_with_keyboard in
WebKitWebView::context-menu signal documentation as suggested by
Martin and Gustavo. I forgot to make this change before landing
previous patch.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 2:29 AM Changeset in webkit [111843] by
-
- 6 edits in trunk/Source/WebKit/gtk
[GTK] Add a signal to allow applications to handle its own context menu
https://bugs.webkit.org/show_bug.cgi?id=49904
Reviewed by Gustavo Noronha Silva.
- tests/testhittestresult.c:
(load_status_cb): Test x, y properties of WebKitHitTestResult.
- webkit/webkithittestresult.cpp:
(webkit_hit_test_result_get_property):
(webkit_hit_test_result_set_property):
(webkit_hit_test_result_class_init): Add x and y construct only
properties to keep the coordinates of the event relative to view's
widget.
(WebKit::kit):
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init): Mark enable-default-context-menu
property as deprecated.
- webkit/webkitwebview.cpp:
(prepareMouseEventForFrame):
(defaultContextMenuEnabled): Helper function to check whether
default context menu setting is enabled or not.
(webkit_web_view_forward_context_menu_event): Emit the new
context-menu signal.
(webkit_web_view_popup_menu_handler):
(webkit_web_view_button_press_event):
(webkit_web_view_class_init): Add new context-menu signal and mark
populate-popup as deprecated.
- webkitmarshal.list:
- 2:26 AM Changeset in webkit [111842] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a failing test.
- platform/qt-4.8/Skipped:
- 2:25 AM April 2012 Meeting edited by
- (diff)
- 2:21 AM Changeset in webkit [111841] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium DEPS roll r127913:r128426.
- DEPS:
- 2:10 AM Changeset in webkit [111840] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove the failing expectation added in r111831 for the test added in r111754
since r111754 was rolled out in r111839.
- platform/mac-wk2/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
- 2:04 AM Changeset in webkit [111839] by
-
- 13 edits2 deletes in trunk
REGRESSION(r111754): plugins/reloadplugins-and-pages.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=82035
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Rollout r111754 since it caused a test to fail and the test added by the patch
is failing on Mac WebKit 2.
- WebCore.exp.in:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::detach):
(WebCore):
(WebCore::HTMLPlugInElement::removedFromDocument):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- testing/Internals.cpp:
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- plugins/netscape-dom-access-and-reload-expected.txt: Removed.
- plugins/netscape-dom-access-and-reload.html: Removed.
- 1:35 AM Changeset in webkit [111838] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed. Fix GTK+ build after r111707.
- WebCoreSupport/UserMediaClientGtk.h:
- 1:27 AM Changeset in webkit [111837] by
-
- 3 edits in trunk/LayoutTests
GTK rebaselines.
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- 1:04 AM Changeset in webkit [111836] by
-
- 6 edits in trunk/Source/WebCore
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=82026
Reviewed by Kentaro Hara.
This patch removes DOMWindow::resetNotifications, which was unneeded
special-case logic for clearing the notifications center. The previous
patch that tried to accomplish the same thing did not override
willDetachPage, which is why it caused crashes.
There's actually a cleaner way to handle these cases, which will let us
implement reconnectFrame, but that will need to wait for the next
patch.
- notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore):
(WebCore::DOMWindowNotifications::disconnectFrame):
(WebCore::DOMWindowNotifications::willDetachPage):
(WebCore::DOMWindowNotifications::reset):
- notifications/DOMWindowNotifications.h:
(DOMWindowNotifications):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
- page/DOMWindow.h:
(DOMWindow):
- page/Frame.cpp:
(WebCore::Frame::willDetachPage):
- 12:25 AM Changeset in webkit [111835] by
-
- 9 edits in trunk
[EFL][DRT] Implement LayoutTestController's methods related with editing.
https://bugs.webkit.org/show_bug.cgi?id=80136
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-23
Reviewed by Ryosuke Niwa.
Source/WebKit/efl:
Implements DumpRenderTreeSupportEfl's and EditorClientEfl's methods related with editing.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled): New function.
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled): New function.
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::setSmartInsertDeleteEnabled): New function.
(WebCore):
(WebCore::EditorClientEfl::smartInsertDeleteEnabled): Add implementation.
(WebCore::EditorClientEfl::setSelectTrailingWhitespaceEnabled): New function.
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled): Add implementation.
(WebCore::EditorClientEfl::EditorClientEfl):
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
Tools:
Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
setSelectTrailingWhitespaceEnabled.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setSmartInsertDeleteEnabled):
(LayoutTestController::setSelectTrailingWhitespaceEnabled):
LayoutTests:
Enables tests connected with setSelectTrailingWhitespaceEnabled and setSmartInsertDeleteEnabled.
Tests related with spelling can not be enabled in this patch because WebKit-Efl doesn't
support spell checking (missing TextCheckerClient implementation).
- platform/efl/Skipped:
- 12:14 AM Changeset in webkit [111834] by
-
- 3 edits in trunk/Source
BitVector::resizeOutOfLine doesn't memset when converting an inline buffer
https://bugs.webkit.org/show_bug.cgi?id=82012
Reviewed by Filip Pizlo.
Initialize out-of-line buffers while extending an inline buffer. Also export symbols to be used in WebCore.
- wtf/BitVector.cpp:
(WTF::BitVector::resizeOutOfLine):
- wtf/BitVector.h:
(BitVector):
(OutOfLineBits):
