Timeline



Apr 5, 2012:

10:23 PM Changeset in webkit [113415] by adele@apple.com
  • 4 edits in trunk/Source/WebCore

<rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129
REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken

Patch by Dan Bernstein, Reviewed by Beth Dakin.

This code assumed that the current CTM wouldn't have extraneous operations built into it,
but this bug is evidence that that assumption was wrong. We should just get the base CTM instead
and apply the device scale factor to it.

No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):

  • platform/graphics/GraphicsContext.h: (GraphicsContext):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
10:16 PM Changeset in webkit [113414] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

Leak in WebSocketChannel with workers/worker-reload.html
https://bugs.webkit.org/show_bug.cgi?id=83345

Reviewed by David Levin.

A speculative fix of memory leaks caused by worker-reload.html.

No new tests, as this change imposes no functional change.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
Receive the peer as PassOwnPtr<> so the destructor of the task object can
delete the peer even if the task didn't run before main thread's cleanup period.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):

9:57 PM Changeset in webkit [113413] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
https://bugs.webkit.org/show_bug.cgi?id=83141

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-05
Reviewed by Adam Barth.

No new tests required.

  • dom/DOMCoreException.cpp:

(CoreException):
(WebCore):
(WebCore::DOMCoreException::initializeDescription):

9:49 PM Changeset in webkit [113412] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline a couple tests for GTK+.

  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
9:26 PM Changeset in webkit [113411] by rakuco@webkit.org
  • 12 edits in trunk/LayoutTests

[EFL] Gardening; update expctations in fast/css-generated-content.

Mostly adapt to the size changes after the jhbuild and font
commits.

  • platform/efl/fast/css-generated-content/003-expected.txt:
  • platform/efl/fast/css-generated-content/009-expected.png:
  • platform/efl/fast/css-generated-content/009-expected.txt:
  • platform/efl/fast/css-generated-content/013-expected.png:
  • platform/efl/fast/css-generated-content/013-expected.txt:
  • platform/efl/fast/css-generated-content/014-expected.png:
  • platform/efl/fast/css-generated-content/014-expected.txt:
  • platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
  • platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
  • platform/efl/fast/css-generated-content/inline-display-types-expected.png:
  • platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
9:26 PM Changeset in webkit [113410] by rakuco@webkit.org
  • 7 edits in trunk/LayoutTests

[EFL] Gardening after r110072.

  • platform/efl/fast/clip/008-expected.png:
  • platform/efl/fast/clip/008-expected.txt:
  • platform/efl/fast/clip/011-expected.png:
  • platform/efl/fast/clip/011-expected.txt:
  • platform/efl/fast/clip/012-expected.png:
  • platform/efl/fast/clip/012-expected.txt:
9:26 PM Changeset in webkit [113409] by rakuco@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Gardening after r112112.

  • platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
9:08 PM Changeset in webkit [113408] by rakuco@webkit.org
  • 55 edits
    1 copy
    1 add in trunk/LayoutTests

[EFL] Gardening. Update baselines and expectations in fast/backgrounds, fast/block, fast/box-shadow and fast/box-sizing.

  • platform/efl/fast/backgrounds/001-expected.png:
  • platform/efl/fast/backgrounds/001-expected.txt:
  • platform/efl/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
  • platform/efl/fast/backgrounds/background-clip-text-expected.png:
  • platform/efl/fast/backgrounds/background-clip-text-expected.txt:
  • platform/efl/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/efl/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/efl/fast/backgrounds/background-leakage-expected.png:
  • platform/efl/fast/backgrounds/background-leakage-expected.txt:
  • platform/efl/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
  • platform/efl/fast/backgrounds/background-origin-root-element-expected.png:
  • platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/efl/fast/backgrounds/background-position-parsing-expected.png:
  • platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/efl/fast/backgrounds/opacity-on-document-element-expected.png:
  • platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
  • platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/efl/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/efl/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/efl/fast/backgrounds/size/zero-expected.png:
  • platform/efl/fast/backgrounds/size/zero-expected.txt:
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/efl/fast/backgrounds/svg-as-mask-expected.png: Added.
  • platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Copied from LayoutTests/platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt.
  • platform/efl/fast/block/float/015-expected.png:
  • platform/efl/fast/block/float/015-expected.txt:
  • platform/efl/fast/box-shadow/basic-shadows-expected.png:
  • platform/efl/fast/box-shadow/basic-shadows-expected.txt:
  • platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/efl/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/efl/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/efl/fast/box-shadow/inset-expected.png:
  • platform/efl/fast/box-shadow/no-blur-multiple-offsets-expected.png:
  • platform/efl/fast/box-shadow/transform-fringing-expected.png:
  • platform/efl/fast/box-sizing/box-sizing-expected.png:
  • platform/efl/fast/box-sizing/box-sizing-expected.txt:
8:04 PM Changeset in webkit [113407] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove intrinsic padding from contentBoxRect(), etc.
https://bugs.webkit.org/show_bug.cgi?id=83092

Patch by David Barton <Dave Barton> on 2012-04-05
Reviewed by Julien Chaffraix.

"Intrinsic padding" does not count as CSS padding, but is treated as padding by basic
layout and rendering code, e.g. RenderBlock::layout(). A lot of code relies on the
equation border-box = content-box + padding + border (+ scrollbars). To keep this valid,
change 5 functions in RenderBox.h to not include intrinsic padding in the content box,
thus reverting to their behavior before the patch for bug 33593. Instead, have
sizingBox(renderer) in CSSComputedStyleDeclaration.cpp explicitly put the intrinsic
padding in computed CSS content-box values [for javascript getComputedStyle()], so the
above equation still also holds for CSS computed values. This seems more consistent with
how the padding...() functions behave since the patch for bug 23487, and will work
better for MathML. For instance, a block's contentLogicalWidth() will be the
availableLogicalWidth() for use by child elements.

No new tests. The only real observable changes are illustrated in the bug 83092 attached
test case and discussion. These are minor and hard to automate.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):

  • rendering/RenderBox.h:

(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):

  • Change these 5 functions to omit intrinsic padding from the content box.
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::cellBaselinePosition):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline):

7:51 PM Changeset in webkit [113406] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
https://bugs.webkit.org/show_bug.cgi?id=83252

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-05
Reviewed by George Staikos.

Test: http/tests/misc/resources/referrer-main-resource.php

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):

7:48 PM Changeset in webkit [113405] by hbono@chromium.org
  • 5 edits
    2 adds in trunk

[Chromium] moving a cursor on a misspelled word should not remove a misspelled underline
https://bugs.webkit.org/show_bug.cgi?id=83214

Reviewed by Ryosuke Niwa.

When Chrome enables asynchronous spellchecking, it adds Spelling markers in the
background. For this case, moving a cursor should not remove these markers
because it requires Chrome to spellcheck text again. This change prevents
removing Spelling markers added by spellcheckers asynchronously.

Source/WebCore:

Test: platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): use marker descriptions instead of spellchecking text when Chrome enables asynchronous spellchecking.

LayoutTests:

  • platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt: Added.
  • platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Added.
7:27 PM Changeset in webkit [113404] by staikos@webkit.org
  • 6 edits
    2 adds in trunk

.: Compile the vibration module for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit: Add the vibration client for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry: Add a vibration client for BlackBerry and enable it.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): enable the client

  • WebCoreSupport/VibrationClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::vibrate):
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):

  • WebCoreSupport/VibrationClientBlackBerry.h: Added.

(WebCore):
(VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):

6:29 PM Changeset in webkit [113403] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

Removed abs(LayoutUnit) on branch as it confused the chromium linux and gtk builds.

6:25 PM Changeset in webkit [113402] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip a test that should now be passing after r113004

  • platform/gtk/Skipped: Unskip a test that should now be passing.
6:22 PM Changeset in webkit [113401] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip some tests on GTK+ that should now be passing.

  • platform/gtk/Skipped:
6:18 PM Changeset in webkit [113400] by commit-queue@webkit.org
  • 8 edits in trunk

CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

Changed the CSS Parser to accept a conventional comma separated argument list for the
polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
polygon(10px,20px 30px,40px). Now commas separate points: polygon(10px 20px, 30px 40px).
This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
Additional relevant information about CSS argument list syntax can be found
here: http://dev.w3.org/csswg/css3-values/#component-whitespace.

Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.

The existing tests have been updated.

  • css/CSSParser.cpp:

(WebCore::isComma)
(WebCore::CSSParser::parseFillPosition)
(WebCore::CSSParser::parseFillRepeat)
(WebCore::CSSParser::parseFillProperty)
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
(WebCore::CSSParser::parseAnimationTimingFunction)
(WebCore::CSSParser::parseAnimationProperty)
(WebCore::CSSParser::parseExclusionShapePolygon)
(WebCore::CSSParser::parseDeprecatedGradient)
(WebCore::CSSParser::parseRadialGradient)
(WebCore::CSSParser::parseGradientColorStops)
(WebCore::CSSParser::parseImageSet)
(WebCore::filterInfoForName)
(WebCore::CSSParser::parseCustomFilter)
(WebCore::CSSParser::parseFontFeatureSettings)

  • css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapePolygon::cssText):

LayoutTests:

Updated the tests to match the polygon syntax defined by the draft exclusions
spec - http://dev.w3.org/csswg/css3-exclusions.

  • fast/exclusions/parsing-wrap-shape-inside-expected.txt:
  • fast/exclusions/parsing-wrap-shape-outside-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
6:14 PM Changeset in webkit [113399] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

This should fix things properly; FileUploader() was setting the
socket default timeout value, and apparently that doesn't work
properly with urllib. Also, the class had a bad try/finally
block that was causing the exceptions to be swallowed :(.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):

  • Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTimeout.str):
(NetworkTransaction.run):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

6:06 PM Changeset in webkit [113398] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when switching to a tab with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=83339
<rdar://problem/11183338>

Reviewed by Oliver Hunt.

Add an additional check so we don't try to call into plug-ins that haven't yet been initialized.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):

5:56 PM Changeset in webkit [113397] by fischman@chromium.org
  • 3 edits
    2 moves in trunk/LayoutTests

http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
https://bugs.webkit.org/show_bug.cgi?id=83296

Reviewed by Eric Carlson.

  • media/media-can-load-when-hidden-expected.txt: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt.
  • media/media-can-load-when-hidden.html: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden.html.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
5:12 PM Changeset in webkit [113396] by benjamin@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Speed up the conversion from JSValue to String for bulk operations
https://bugs.webkit.org/show_bug.cgi?id=83243

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

When making operations on primitive types, we loose some time converting
values to JSString in order to extract the string.

This patch speeds up some basic Array operations by avoiding the creation
of intermediary JSString when possible.

For the cases where we need to convert a lot of JSValue in a tight loop,
an inline conversion is used.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncSort):

  • runtime/CommonIdentifiers.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::sort):

  • runtime/JSString.h:

(JSC::JSValue::toUString):
(JSC):
(JSC::inlineJSValueNotStringtoUString):
(JSC::JSValue::toUStringInline):

  • runtime/JSValue.cpp:

(JSC::JSValue::toUStringSlowCase):
(JSC):

  • runtime/JSValue.h:

(JSValue):

4:54 PM Changeset in webkit [113395] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Support string.length in keyPaths
https://bugs.webkit.org/show_bug.cgi?id=83221

Source/WebCore:

Special case in the IDB spec - keyPaths can reference the |length| property
of string values. Other instrinsic properties (|length| of Array, etc) are
handled automagically. Relevant section of the updated spec is:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct

Reviewed by Kentaro Hara.

Test: storage/indexeddb/keypath-intrinsic-properties.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore):

LayoutTests:

Reviewed by Kentaro Hara.

  • storage/indexeddb/keypath-intrinsic-properties-expected.txt: Added.
  • storage/indexeddb/keypath-intrinsic-properties.html: Added.
  • storage/indexeddb/resources/keypath-intrinsic-properties.js: Added.

(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStringLengths.request.onsuccess):
(testKeyPaths.checkStringLengths):
(testKeyPaths.checkArrayLengths.request.onsuccess):
(testKeyPaths.checkArrayLengths):
(testKeyPaths):

4:40 PM Changeset in webkit [113394] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove some tests that are passing consistently.

  • platform/chromium/test_expectations.txt:
4:28 PM Changeset in webkit [113393] by arv@chromium.org
  • 3 edits
    4 copies in branches/chromium/1084

Merge 113086 - [v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Reviewed by Ojan Vafai.

Source/WebCore:

This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).

This also clears the strings once the code has been parsed and the function created.

Tests: fast/dom/inline-event-attributes-moved.html

fast/dom/inline-event-attributes-release.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

  • fast/dom/inline-event-attributes-moved-expected.txt: Added.
  • fast/dom/inline-event-attributes-moved.html: Added.
  • fast/dom/inline-event-attributes-release-expected.txt: Added.
  • fast/dom/inline-event-attributes-release.html: Added.

TBR=arv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10007027

4:20 PM Changeset in webkit [113392] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
fast/js/cross-global-object-inline-global-var.html is flakey on win debug and
fast/forms/select-style.html is consistently passing.

  • platform/chromium/test_expectations.txt:
4:08 PM Changeset in webkit [113391] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use QuickSort when sorting primitive values by string representation
https://bugs.webkit.org/show_bug.cgi?id=83312

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Gavin Barraclough.

When the value we are sorting are all primitive values, we do not need to
ensure a stable sort as two values with equal string representation are
indistinguishable from JavaScript.

This gives about 16% performance increase when sorting primitive values.

  • runtime/JSArray.cpp:

(JSC::JSArray::sort):

4:00 PM Changeset in webkit [113390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
https://bugs.webkit.org/show_bug.cgi?id=83314

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 143771
One new virtual method was added to the SkCanvas, to draw a nine piece
image. Override it and mark output as not being a solid color anymore.

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h:

(WebCore::InstrumentedPlatformCanvas::drawBitmapNine):
(InstrumentedPlatformCanvas):

3:57 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
3:51 PM Changeset in webkit [113389] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496

Reviewed by Gavin Barraclough.

Don't attempt to use the DFG when SSE2 is not available.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::canCompileOpcodes):

3:42 PM Changeset in webkit [113388] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
https://bugs.webkit.org/show_bug.cgi?id=76105

Unreviewed build fix for Windows. windowIsVisible() is PLATFORM(MAC) only.
This means a Page might start requestAnimationFrame-based animations
even when it isn't visible. This should only happen when a Page is
opened in the background though. The regular hide and show should still
pause animations.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::resumePainting):

3:33 PM Changeset in webkit [113387] by oliver@apple.com
  • 79 edits in trunk/Source/WebCore

Make WebCore use jsCast rather than static_cast for casting JSC objects
https://bugs.webkit.org/show_bug.cgi?id=83320

Reviewed by Stephanie Lewis.

Mechanically replace static_cast with jsCast where ever we can.

  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::JSStringOwner::finalize):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::currentWorld):

  • bindings/js/JSArrayBufferCustom.cpp:

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/JSDOMBinding.h:

(WebCore::deprecatedGlobalObjectForPrototype):
(WebCore::getDOMPrototype):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):

  • bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::nameGetter):

  • bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::nameGetter):

  • bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::nameGetter):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::nameGetter):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::toJSDOMWindow):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):
(WebCore::toDOMWindow):

  • bindings/js/JSDOMWindowCustom.h:

(WebCore::asJSDOMWindow):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::JSDataViewConstructor::constructJSDataView):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventTarget.cpp:

(WebCore):
(WebCore::toEventTarget):

  • bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

  • bindings/js/JSFloat64ArrayCustom.cpp:

(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::remove):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::constructImage):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

  • bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

  • bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeOwner::finalize):

  • bindings/js/JSNodeCustom.h:

(WebCore::toJS):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::toNodeFilter):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectPropertyGetter):
(WebCore::callPlugin):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSTextTrackListCustom.cpp:

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSTrackCustom.cpp:

(WebCore::toTrack):

  • bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

  • bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

  • bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

  • bindings/js/JSUint8ClampedArrayCustom.cpp:

(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):

  • bindings/js/JSWebKitPointCustom.cpp:

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::toJSDedicatedWorkerContext):
(WebCore::toJSSharedWorkerContext):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForInspector):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::updateStyleIfNeededForBindings):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidPause):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):

  • bindings/js/ScriptState.cpp:

(WebCore::domWindowFromScriptState):
(WebCore::scriptExecutionContextFromScriptState):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::fillTransferMap):
(WebCore::CloneSerializer::dumpArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
(GenerateCallWith):
(NativeToJSValue):
(GenerateConstructorDefinition):

  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeConstructor):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

3:21 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
3:18 PM Changeset in webkit [113386] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk

[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html

The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.

Source/WebKit/gtk:

Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.

LayoutTests:

Added a pixel test for this issue.

  • platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.
3:07 PM Changeset in webkit [113385] by commit-queue@webkit.org
  • 19 edits in trunk

Unreviewed, rolling out r113299.
http://trac.webkit.org/changeset/113299
https://bugs.webkit.org/show_bug.cgi?id=83297

The patch broke 11 tests on Lion. (Requested by jonlee on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

  • platform/mac-lion/Skipped:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/mac/svg/custom/viewbox-syntax-expected.png:
  • platform/mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
3:01 PM Changeset in webkit [113384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Correct misleading trace event names in Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=83310

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

2:51 PM Changeset in webkit [113383] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

Cleanyp RenderInputSpeech on branch.

2:32 PM Changeset in webkit [113382] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, fast/js/keywords-and-reserved_words.html is
passing again after r113352.

  • platform/chromium/test_expectations.txt:
2:29 PM Changeset in webkit [113381] by dino@apple.com
  • 9 edits in trunk

[mac] requestAnimationFrame sometimes stuck when page loads in a background tab https://bugs.webkit.org/show_bug.cgi?id=76105

Reviewed by Simon Fraser.

Source/WebCore:

Fix three issues with requestAnimationFrame:

  • It's possible for the call to rAF to come to the document before there is a page associated. Added a guard for this.
  • A page may try to suspend the scripted animations before the ScriptedAnimationController exists, in which case we need to suspend it immediately after it is created. Do this by keeping track of the state in Page. Otherwise rAF would be busy looping on hidden pages until they are brought to the front and hidden again.
  • A page created in the background (from WebKit1) does not get informed it is not visible. This can mean that resume() is called more times than suspend() and we get into a state where the number of suspensions becomes -1, and thus fails truthiness tests. Clamp it to values >= 0.

No new tests, since this is not automatically testable. The most reliable test
is to open a page with rAF in a background tab within Safari.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::resume):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

  • page/Page.h:

(WebCore::Page::scriptedAnimationsSuspended):
(Page):

Source/WebKit2:

When we are resuming painting only start the scripted animations
if we're a visible window. This can happen when tabs are opened
in the background.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::resumePainting):

LayoutTests:

Add fast/animation/request-animation-frame-during-modal.html
to the skipped list. This patch will ensure that non-visible windows
do not get a requestAnimationFrame callback, so the test will timeout.
See https://bugs.webkit.org/show_bug.cgi?id=83239 to re-enable.

  • platform/mac/Skipped:
2:18 PM Changeset in webkit [113380] by tony@chromium.org
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, moving linux result from 32-bit directory to 64 and 32 bit directory.

  • platform/chromium-linux/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png.
2:15 PM Changeset in webkit [113379] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9359029> and https://bugs.webkit.org/show_bug.cgi?id=83311 Crashes in WebProcess at WebCore::HistoryController::recursiveSetProvisionalItem when restoring previous session

Reviewed by Sam Weinig.

It's possible to hit a race condition between the UIProcess and the WebProcess where the UIProcess records for a
page have been cleared out but the WebProcess is still trying to perform a history navigation within that page.

In this situation HistoryController code that expects there to always be a current history item in the back/forward
controller is wrong.

No new tests. (The race conditions involved have proven making a test impractical)

  • loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveSetProvisionalItem): Don't ASSERT the fromItem. We now know there might not be one.
(WebCore::HistoryController::recursiveGoToItem): Ditto
(WebCore::HistoryController::itemsAreClones): Always return false if either item is null, as a null item and a non-null

item cannot possible be clones of each other.

2:11 PM Changeset in webkit [113378] by adamk@chromium.org
  • 6 edits
    4 adds in trunk

Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/clear-transient-without-delivery-expected.txt: Added.
  • fast/mutation/clear-transient-without-delivery.html: Added.
  • fast/mutation/transient-gc-crash-expected.txt: Added.
  • fast/mutation/transient-gc-crash.html: Added.
2:04 PM Changeset in webkit [113377] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, update expectation for
media/nodesFromRect-shadowContent.html since it moved in r113371.

  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [113376] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Added takeRecords to WebKitMutationObserver properties list, to fix mac.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
1:52 PM Changeset in webkit [113375] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix lint errors in GTK+ test_expectations.txt file.

  • platform/gtk/test_expectations.txt:

http/tests/security/cross-origin-xsl-redirect-BLOCKED.html had 2 entries
and css3/flexbox/inline-flexbox.html doesn't exist anymore.

1:45 PM Changeset in webkit [113374] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Rebaseline binding tests after r113272.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

1:44 PM Changeset in webkit [113373] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Drawing an accelerated canvas onto itself is slow.
https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::create):

1:35 PM Changeset in webkit [113372] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Record the number of tiles paint-culled instead of the incorrect number of pixels
https://bugs.webkit.org/show_bug.cgi?id=82423

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

Source/WebCore:

We currently attempt to record the number of pixels we save from uploading,
however the number is wrong in two ways.
1) An early-out if everything is culled results in nothing being reported.
2) With threaded-compositor, the number of pixels uploaded in one tile can be
changed by culling in another tile, making the number far too difficult to
compute to be worthwhile. If a tile was going to be partial-updated, but is
culled, now a new tile gets to be partial-updated instead, which affects the
numbers.

This patch breaks up CCOverdrawMetrics to make the methods/variables less
overloaded and more clear. This way they don't have to mirror each other
so closely on paint/draw sides.

Then we record the number of tiles for which we prevented upload via paint
culling. This will still over-report (a dirty culled tile stays dirty and
will be culled again each commit), but it seems more reasonable as it
clearly does not try to mimic a performance metric in the way that a pixel
count does, but still gives a rough estimation of the amount of paint
culling going on in a page.

Covered by existing tests, modified where needed.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCullTileForUpload):
(WebCore):
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsCulledForDrawing):
(WebCore::CCOverdrawMetrics::pixelsUploadedOpaque):
(WebCore::CCOverdrawMetrics::pixelsUploadedTranslucent):
(WebCore::CCOverdrawMetrics::tilesCulledForUpload):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::append):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

1:34 PM Changeset in webkit [113371] by tonikitoo@webkit.org
  • 2 moves in trunk/LayoutTests/media

2012-04-05 Antonio Gomes <agomes@rim.com>

Move nodesFromRect-shadowContent test from fast/dom to media, where the
helper .js files are able to work properly.
https://bugs.webkit.org/show_bug.cgi?id=80847 (PART III)

Reviewed by Eric Carlson.

  • media/nodesFromRect-shadowContent-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent-expected.txt.
  • media/nodesFromRect-shadowContent.html: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent.html.
1:32 PM Changeset in webkit [113370] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, update baselines for tests with 'let' after r113352.

  • platform/chromium/fast/js/reserved-words-as-property-expected.txt:
  • platform/chromium/fast/js/reserved-words-strict-expected.txt:
1:31 PM Changeset in webkit [113369] by enrica@apple.com
  • 10 edits
    2 adds in trunk/Source/WebCore

Provide a separate editing command to cleanup of redundant markup.
https://bugs.webkit.org/show_bug.cgi?id=83240

Reviewed by Ryosuke Niwa.

This patch moves the logic originally performed by the private
method removeRedundantMarkup inside ReplaceSelectionCommand into
a separate command. This way the markup cleanup can be exposed as
a separate command, independent from ReplaceSelectionCommand.

No new tests. No change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added new file to project files.

  • editing/EditorAllInOne.cpp: Added SimplifyMarkupCommand.
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Now uses SimplifyMarkupCommand.

  • editing/ReplaceSelectionCommand.h:

(ReplaceSelectionCommand): Removed removeRedundantMarkup.

  • editing/SimplifyMarkupCommand.cpp: Added.

(WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand):
(WebCore::SimplifyMarkupCommand::doApply):

  • editing/SimplifyMarkupCommand.h: Added.

(WebCore::SimplifyMarkupCommand::create):

1:28 PM Changeset in webkit [113368] by schenney@chromium.org
  • 18 edits
    1 add
    4 deletes in trunk/LayoutTests

Rebaseline text results
https://bugs.webkit.org/show_bug.cgi?id=74928

Unreviewed text expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

  • platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/textPathBoundsBug-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page: Removed.
  • platform/chromium-win/fast/repaint/reflection-redraw-expected.png:
  • platform/chromium-win/printing/width-overflow-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-win/svg/carto.net/textbox-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • svg/as-background-image/svg-as-background-4-expected.txt: Added.
1:26 PM Changeset in webkit [113367] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Remove unused ValueToString function on branch.

1:24 PM Changeset in webkit [113366] by schenney@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] Layout test failure svg/clip-path/clip-path-tspan-and-stroke.xhtml
https://bugs.webkit.org/show_bug.cgi?id=83308

Unreviewed Chromium test expectations update.

Also removing some expectations that are no longer needed.

  • platform/chromium-linux-x86/svg/clip-path: Added.
  • platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [113365] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 32-bit build.

1:14 PM Changeset in webkit [113364] by shawnsingh@chromium.org
  • 7 edits
    2 adds in trunk/Source

[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

WebCore TransformationMatrix mapRect / mapQuad / projectQuad do
not properly handle the case where a surface is oriented partially
behind the camera, with a perspective projection. In this case,
projected points may appear to be valid in cartesian coordinates,
but they are indeed not valid, and this problem can only be
detected in homogeneous coordinates after applying the transform,
before the divide-by-w step.

The correct solution is to clip geometry where w < 0. This patch
makes this change local to chromium only, to fix rendering bugs
that arise from this problem. The primary fix is to correct
calculateVisibleLayerRect(), but other ancillary locations are
also fixed, in particular, the antialiasing code path is simply
skipped when this case arises.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCMathUtil.cpp: Added.

(WebCore):
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::computeClippedPointForEdge):
(WebCore::expandBoundsToIncludePoint):
(WebCore::computeEnclosingRectOfClippedQuad):
(WebCore::computeEnclosingRect):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):

  • platform/graphics/chromium/cc/CCMathUtil.h: Added.

(WebCore):
(CCMathUtil):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

1:09 PM Changeset in webkit [113363] by oliver@apple.com
  • 28 edits in trunk/Source/JavaScriptCore

Replace static_cast with jsCast when casting JSCell subclasses in JSC
https://bugs.webkit.org/show_bug.cgi?id=83307

Reviewed by Gavin Barraclough.

Replace all usage of static_cast<JSCell subtype*> with jsCast<> in JavaScriptCore.
This results in assertions when unsafe casts are performed, but simply leaves
a static_cast<> in release builds.

  • API/APICast.h:

(toJS):

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::finishCreation):
(JSC::::construct):
(JSC::::call):

  • API/JSObjectRef.cpp:

(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

  • API/JSValueRef.cpp:

(JSValueIsObjectOfClass):

  • API/JSWeakObjectMapRefPrivate.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::finishCreation):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.h:

(JSC::isHostFunction):

  • runtime/JSActivation.h:

(JSC::asActivation):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • runtime/JSArray.h:

(JSC::asArray):

  • runtime/JSBoundFunction.cpp:

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):

  • runtime/JSByteArray.h:

(JSC::asByteArray):

  • runtime/JSCell.cpp:

(JSC::JSCell::toObject):

  • runtime/JSCell.h:

(JSC::jsCast):

  • runtime/JSGlobalObject.h:

(JSC::asGlobalObject):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/JSObject.cpp:

(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::toThisObject):
(JSC::JSObject::unwrappedObject):

  • runtime/JSObject.h:

(JSC::asObject):

  • runtime/JSPropertyNameIterator.h:

(JSC::Register::propertyNameIterator):

  • runtime/JSString.h:

(JSC::asString):
(JSC::JSValue::toString):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstr):

1:03 PM Changeset in webkit [113362] by schenney@chromium.org
  • 6 edits
    1 add
    3 deletes in trunk/LayoutTests

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Unreviewed Chromium test expectations update.

Somehow this test slipped thorugh the crack of rebaselining.

  • platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
  • platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/chromium-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
  • platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/chromium/test_expectations.txt:
1:01 PM Changeset in webkit [113361] by Patrick Gansterer
  • 18 edits in trunk

[Qt] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83270

Reviewed by Eric Seidel.

Modify the #include declerations so that the
wtf types are included using the full path.

Source/WebCore:

  • platform/graphics/TiledBackingStoreBackend.h:

Source/WebKit/qt:

  • Api/qwebpage.cpp:
  • WebCoreSupport/ContextMenuClientQt.h:
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InspectorServerQt.cpp:

Source/WebKit2:

  • Shared/qt/QtNetworkReplyData.cpp:
  • UIProcess/WebLayerTreeRenderer.cpp:
  • UIProcess/qt/LayerBackingStore.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.h:
  • UIProcess/qt/QtWebPageSGNode.h:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

Tools:

  • WebKitTestRunner/qt/TestInvocationQt.cpp:
12:49 PM Changeset in webkit [113360] by schenney@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Unreviewed Chromium expectations update.

Somehow this file was not correctly rebaselined when the original change was made.

  • platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Removed.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Modified property svn:mime-type.
  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [113359] by eae@chromium.org
  • 729 edits
    124 copies
    10 deletes in branches/subpixellayout

Merge trunk changes up until 113337 into subpixel branch.

12:38 PM Changeset in webkit [113358] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-04-05 Antonio Gomes <agomes@rim.com>

Unreviewed bit left over from rebasing the origin patch before landing it.

Complementary to r113329.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::operator=):
12:32 PM Changeset in webkit [113357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Cleanup test, redundant code in CCSchedulerTest.NoBeginFrameWhenDrawFails
https://bugs.webkit.org/show_bug.cgi?id=83300

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

12:32 PM Changeset in webkit [113356] by rniwa@webkit.org
  • 4 edits in trunk

perf-o-matic should include unit in runs JSON responses
https://bugs.webkit.org/show_bug.cgi?id=83294

Reviewed by Tony Chang.

This is a follow up to r112829. Report the unit in /api/test/runs so that the frontend can show it.
Fixed a bug in Test.update_or_insert that it didn't store the unit when it first created the Test object.

Also increment perf-o-matic's version to 18.

  • Websites/webkit-perf.appspot.com/app.yaml: Incremented the version.
  • Websites/webkit-perf.appspot.com/models.py:

(Test.update_or_insert.execute): Store unit when creating a test.
(Runs.to_json): Include unit.

  • Websites/webkit-perf.appspot.com/models_unittest.py: Added tests.

(TestModelTests.test_update_or_insert_with_unit):
(RunsTest.test_to_json_without_results):
(RunsTest.test_to_json_with_results):
(RunsTest.test_to_json_with_unit):

12:30 PM Changeset in webkit [113355] by benjamin@webkit.org
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

Make something faster than JSStringBuilder for joining an array of JSValue
https://bugs.webkit.org/show_bug.cgi?id=83180

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

This patch add the class JSStringJoiner optimized for join() operations.

This class makes stricter constraints than JSStringBuilder in order avoid
memory allocations.

In the best case, the class allocate memory only twice:
-Allocate an array to keep a list of UString to join.
-Allocate the final string.

We also avoid the conversion from 8bits strings to 16bits strings since
they are costly and unlikly to help for subsequent calls.

(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

  • runtime/JSStringJoiner.cpp: Added.

(JSC):
(JSC::appendStringToData):
(JSC::joinStrings):
(JSC::JSStringJoiner::build):

  • runtime/JSStringJoiner.h: Added.

(JSC):
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

12:25 PM Changeset in webkit [113354] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, widen the suppression for
http/tests/multipart/policy-ignore-crash.php-- it is flakey on win debug too.

  • platform/chromium/test_expectations.txt:
12:23 PM Changeset in webkit [113353] by schenney@chromium.org
  • 4 edits
    2 adds
    3 deletes in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test expectations rationalization.

Apparently the efl port results match Chromium.

  • platform/chromium-win-vista/svg/as-background-image: Removed.
  • platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • svg/as-background-image/svg-as-background-1-expected.txt: Added.
  • svg/as-background-image/svg-as-background-3-expected.txt: Added.
12:09 PM Changeset in webkit [113352] by barraclough@apple.com
  • 9 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=77293
[Un]Reserve 'let'

Rubber stamped by Oliver Hunt.

Revert r106198.
This does break the web - e.g. https://bvi.bnc.ca/index/bnc/indexen.html
If we're going to reserve let, we're going to have to do so in a more
circumspect fashion.

Source/JavaScriptCore:

  • parser/Keywords.table:

LayoutTests:

  • fast/js/keywords-and-reserved_words-expected.txt:
  • fast/js/reserved-words-as-property-expected.txt:
  • fast/js/reserved-words-strict-expected.txt:
  • fast/js/script-tests/keywords-and-reserved_words.js:
  • fast/js/script-tests/reserved-words-as-property.js:
  • fast/js/script-tests/reserved-words-strict.js:
12:08 PM Changeset in webkit [113351] by arv@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

HTMLSelectElement does not have a getter for namedItem. This fixes the invalid test
https://bugs.webkit.org/show_bug.cgi?id=83289

Reviewed by Ryosuke Niwa.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-select-element

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
12:07 PM Changeset in webkit [113350] by zmo@google.com
  • 7 edits in trunk/Source

Unreviewed, rolling out r113241.
http://trac.webkit.org/changeset/113241
https://bugs.webkit.org/show_bug.cgi?id=83293

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):

12:05 PM Changeset in webkit [113349] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Fixed incorrect expectations for fonts/cursive.html.

  • platform/chromium/test_expectations.txt: Fixed.
12:04 PM Changeset in webkit [113348] by jpu@apple.com
  • 1 edit in trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp

Fixing build failure on SnowLeopard caused by changeset 113340.

12:00 PM Changeset in webkit [113347] by shawnsingh@chromium.org
  • 7 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r113341.
http://trac.webkit.org/changeset/113341
https://bugs.webkit.org/show_bug.cgi?id=83299

bots caught some build errors (Requested by shawnsingh on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
  • platform/graphics/chromium/cc/CCMathUtil.h: Removed.
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
11:57 AM Changeset in webkit [113346] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Race condition in CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=83179

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-05
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::willAnimateLayers):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::willAnimateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):

11:49 AM Changeset in webkit [113345] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Chromium] With the skia port, setting LCD text filtering is causing
texture cache invalidations of gpu canvas backing store
https://bugs.webkit.org/show_bug.cgi?id=74183

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Stephen White.

Source/WebCore:

Replacing unnecessary usage of SkCanvas::LayerIter with calls to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore):
(WebCore::TransparencyAwareFontPainter::initializeForGDI):

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore):
(WebCore::adjustTextRenderMode):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore):
(WebCore::adjustTextRenderMode):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore):
(WebCore::disableTextLCD):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):

Source/WebKit/chromium:

Replacing unnecessary usage of SkCanvas::LayerIter with call to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::drawText):

11:47 AM Changeset in webkit [113344] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Properly align members in WebInputEvent and subclasses to make Valgrind happy.
https://bugs.webkit.org/show_bug.cgi?id=81570

Patch by Lei Zhang <thestig@chromium.org> on 2012-04-05
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:

(WebKit):
(WebKit::WebInputEvent::WebInputEvent):
(WebKeyboardEvent):
(WebKit::WebTouchEvent::WebTouchEvent):

11:32 AM Changeset in webkit [113343] by commit-queue@webkit.org
  • 7 edits in trunk

media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

Source/WebCore:

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

Move all the checking for the WebVTT file identifier from TextTrackLoader
to WebVTTParser, notifying the parser clients of parsing failures through
a new method. Remove the WebVTTParser::fileIdentifierMaximumLength method
and make WebVTTParser::hasRequiredFileIdentifier private. The latter now
operates on a vector holding the identifier data to which data is added
until there's enough of it to possibly hold the optional BOM character
and the required WEBVTT character sequence.

No new tests. Fixes an existing test.

  • html/track/WebVTTParser.cpp: Fix a typo throughout the file:

fileIdentiferLength -> fileIdentifierLength
(WebCore):
(WebCore::WebVTTParser::parseBytes): Only continue with searcing for
the WEBVTT identifier if there's enough data to possibly contain the
identifier. Report that the file failed to parse if the identifier
was then not found.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Refactor to operate
on the vector containing identifier data and merge with the
hasLongWebVTTIdentifier function.

  • html/track/WebVTTParser.h:

(WebVTTParserClient): Add a new method.
(WebVTTParser):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::processNewCueData): Parser is now created
immediately regardless of the mime type the response holds.
(WebCore::TextTrackLoader::fileFailedToParse): Log the error, set the
state to failed, start the cue load timer and cancel the load if the file
was not parsed successfully.
(WebCore):

  • loader/TextTrackLoader.h:

(TextTrackLoader):

LayoutTests:

Remove the test from test expectations file as it should now pass.

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

  • platform/chromium/test_expectations.txt:
11:28 AM Changeset in webkit [113342] by darin@chromium.org
  • 12 edits in branches/chromium/1084

Merge 113282 - Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Patch by Greg Billock <gbillock@google.com> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity):

  • Modules/intents/NavigatorIntents.h:

(NavigatorIntents):

  • Modules/intents/NavigatorIntents.idl:

LayoutTests:

  • webintents/resources/web-intents-reload-orig.html:
  • webintents/resources/web-intents-testing.js:

(startIntentWithCallbacks):

  • webintents/web-intents-api-expected.txt:
  • webintents/web-intents-api.html:
  • webintents/web-intents-invoke.html:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9949021

11:24 AM Changeset in webkit [113341] by shawnsingh@chromium.org
  • 7 edits
    2 adds in trunk/Source

[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

WebCore TransformationMatrix mapRect / mapQuad / projectQuad do
not properly handle the case where a surface is oriented partially
behind the camera, with a perspective projection. In this case,
projected points may appear to be valid in cartesian coordinates,
but they are indeed not valid, and this problem can only be
detected in homogeneous coordinates after applying the transform,
before the divide-by-w step.

The correct solution is to clip geometry where w < 0. This patch
makes this change local to chromium only, to fix rendering bugs
that arise from this problem. The primary fix is to correct
calculateVisibleLayerRect(), but other ancillary locations are
also fixed, in particular, the antialiasing code path is simply
skipped when this case arises.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCMathUtil.cpp: Added.

(WebCore):
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::computeClippedPointForEdge):
(WebCore::expandBoundsToIncludePoint):
(WebCore::computeEnclosingRectOfClippedQuad):
(WebCore::computeEnclosingRect):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):

  • platform/graphics/chromium/cc/CCMathUtil.h: Added.

(WebCore):
(CCMathUtil):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

11:16 AM Changeset in webkit [113340] by jpu@apple.com
  • 31 edits
    5 adds in trunk/Source

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
See WebCore/ChangeLog for details.

  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/mac/PageClientImpl.h: (PageClientImpl):
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::recordAutocorrectionResponse):
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/PageClient.h: (PageClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::recordAutocorrectionResponse):
  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Added. (WebKit): (WebKit::WebAlternativeTextClient::WebAlternativeTextClient): (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient): (WebKit::WebAlternativeTextClient::showCorrectionAlternative): (WebKit::WebAlternativeTextClient::dismissAlternative): (WebKit::WebAlternativeTextClient::dismissAlternativeSoon): (WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Added. (WebKit): (WebAlternativeTextClient):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
See WebCore/ChangeLog for details.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm:
  • WebCoreSupport/WebAlternativeTextClient.h: Added. (WebAlternativeTextClient):
  • WebCoreSupport/WebAlternativeTextClient.mm: Added. (WebAlternativeTextClient::WebAlternativeTextClient): (WebAlternativeTextClient::~WebAlternativeTextClient): (WebAlternativeTextClient::showCorrectionAlternative): (WebAlternativeTextClient::dismissAlternative): (WebAlternativeTextClient::dismissAlternativeSoon): (WebAlternativeTextClient::recordAutocorrectionResponse):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::~WebEditorClient):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

See WebCore/ChangeLog for details.

  • WebKit.xcodeproj/project.pbxproj:

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

No new tests, since there's no change of functionality.

The existing correction panel related functions in EditorClient are currently used only by OS X.
We'd like to move them into separate AlternativeTextClient class to avoid using #ifdef's. This
new client class will also hold dictation alternative related interface that we will add soon for
bug 82503.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/AlternativeTextController.cpp: Changes in this file are all for calling functions in AlternativeTextClient instead of those in EditoClient. (WebCore::AlternativeTextController::show): (WebCore::AlternativeTextController::dismiss): (WebCore::AlternativeTextController::dismissSoon): (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection): (WebCore::AlternativeTextController::timerFired): (WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled): (WebCore::AlternativeTextController::alternativeTextClient): (WebCore): (WebCore::AlternativeTextController::editorClient): (WebCore::AlternativeTextController::textChecker): (WebCore::AlternativeTextController::recordAutocorrectionResponseReversed): (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
  • editing/AlternativeTextController.h: (WebCore): (AlternativeTextController):
  • editing/TextCheckingHelper.h: (WebCore):
  • loader/EmptyClients.h: (EmptyEditorClient):
  • page/AlternativeTextClient.h: Added. (WebCore): (AlternativeTextClient): (WebCore::AlternativeTextClient::~AlternativeTextClient):
  • page/EditorClient.h: (EditorClient):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
  • page/Page.h: (WebCore): (PageClients): (Page): (WebCore::Page::alternativeTextClient):
11:15 AM Changeset in webkit [113339] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-05
Reviewed by Tony Chang.

Refactored the test to use os.path.join() to specify the
core_pattern value of the empty crash log mock.

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):
(GtkPortTest.assertLinesEqual):
(GtkPortTest.test_get_crash_log):
(_mock_gdb_output):

11:01 AM Changeset in webkit [113338] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Marked storage/indexeddb/basics-workers.html as flaky across all platforms in DEBUG

  • platform/chromium/test_expectations.txt: Marked.
10:54 AM Changeset in webkit [113337] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix fullscreen video button for android
https://bugs.webkit.org/show_bug.cgi?id=83087

Patch by Min Qin <qinmin@google.com> on 2012-04-05
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=70437 changed css keyword for fullscreen video button.
It is changed from media-fullscreen-button to media-enter-fullscreen-button.
However, it does not change the value in mediaControlChromiumAndroid.css.
No behavior change.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-fullscreen-button):

10:46 AM Changeset in webkit [113336] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CSS file revisions are not restored upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=83292

Reviewed by Yury Semikhatsky.

Populating suggestions before the panel creation now.

  • inspector/front-end/inspector.js:

(WebInspector._doLoadedDoneWithCapabilities.get if):

10:44 AM Changeset in webkit [113335] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Add assertions to check for mutation of RenderLayer z-order lists during enumeration
https://bugs.webkit.org/show_bug.cgi?id=83242

Reviewed by James Robinson.

Add debug-only code that detects whether RenderLayer's z-order and
normal flow lists are being cleared or otherwise mutated while we're
enumerating over them.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::calculateLayerBounds):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateZOrderListsSlowCase):
(WebCore::RenderLayer::updateNormalFlowList):

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::layerListMutationAllowed):
(WebCore::RenderLayer::setLayerListMutationAllowed):
(WebCore):
(LayerListMutationDetector):
(WebCore::LayerListMutationDetector::LayerListMutationDetector):
(WebCore::LayerListMutationDetector::~LayerListMutationDetector):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::layerHas3DContent):

10:38 AM April 2012 Meeting edited by rniwa@webkit.org
(diff)
10:27 AM Changeset in webkit [113334] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r113254.
http://trac.webkit.org/changeset/113254
https://bugs.webkit.org/show_bug.cgi?id=83291

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

10:18 AM Changeset in webkit [113333] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolling out http://trac.webkit.org/changeset/113262.
Original code was fine.

Rubber-stamped by Oliver Hunt.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

10:11 AM Changeset in webkit [113332] by zmo@google.com
  • 4 edits in trunk/Source

Unreviewed, rolling out r113307.
http://trac.webkit.org/changeset/113307
https://bugs.webkit.org/show_bug.cgi?id=83288

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

9:56 AM Changeset in webkit [113331] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening.
fast/events/click-focus-anchor.html is flakey in debug
fast/filesystem/file-writer-abort-continue.html is hitting an assert.

  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
9:50 AM Changeset in webkit [113330] by Csaba Osztrogonác
  • 19 edits in trunk

[Qt] Fix includes after QtDeclarative -> QtQML renaming
https://bugs.webkit.org/show_bug.cgi?id=82195

Relanding r112651, because Qt5 is updated everywhere.

Source/WebKit/qt:

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/qquicknetworkrequest_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebiconimageprovider_p.h:
  • UIProcess/API/qt/qwebnavigationhistory.cpp:
  • UIProcess/API/qt/qwebnavigationhistory_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
  • UIProcess/qt/QtDialogRunner.cpp:

(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/main.cpp:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

  • qmake/mkspecs/features/unix/default_post.prf:
9:46 AM Changeset in webkit [113329] by tonikitoo@webkit.org
  • 19 edits
    2 adds in trunk

Extend HitTestResult to support not "discarding" shadow content in favor of its DOM ancestor
https://bugs.webkit.org/show_bug.cgi?id=80847

Reviewed by David Hyatt.
Patch by Antonio Gomes <agomes@rim.com>

.:

Exporting Internals::nodesFromRect symbols for the Gtk build.

  • Source/autotools/symbols.filter:

Source/WebCore:

In order to improve touch precision on shadow tree content, patch
extends the rect-hittest'ing system to allow shadow content
to be stored as the rect-hittest result node list.

Primary use cases are for this extension is making it easier to
improve the clickability of default controls of <video> and <audio>
elements.

For the callee site, the use is simple: if shadow content in the rect-hittest
result is desired, just add an extra 'AllowShadowContent' parameter at the creation
of the HitTestResult object.

Test: fast/dom/nodesFromRect-shadowContent.html

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/HitTestResult.h:

(HitTestResult):
(WebCore::HitTestResult::shadowContentFilterPolicy):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Adds a test that rect-hittest's a element known to have a shadow
tree (<video> with built-in controls), and check if its return type
contains its clickable shadow nodes.

  • fast/dom/nodesFromRect-shadowContent-expected.txt: Added.
  • fast/dom/nodesFromRect-shadowContent.html: Added.
  • fast/dom/resources/nodesFromRect.js:

(check):
(checkShadowContent):

Conflicts:

Source/WebCore/page/FrameView.cpp

9:41 AM Changeset in webkit [113328] by commit-queue@webkit.org
  • 10 edits in trunk

Rename CSS Exclusions "rect" value to "rectangle"
https://bugs.webkit.org/show_bug.cgi?id=82367

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Changed the CSS exclusion shape called "rect" to "rectangle" to match
the current draft spec - http://dev.w3.org/csswg/css3-exclusions.

Source/WebCore:

The meeting minutes where the decision to rename the exclusion "rect" function
to "rectangle" are: http://lists.w3.org/Archives/Public/www-style/2012Feb/0325.html

No new tests were created; just updated the existing ones.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRectangle):
(WebCore::CSSParser::parseWrapShape):

  • css/CSSParser.h:
  • css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapeRectangle::cssText):

  • css/CSSWrapShapes.h:

(WebCore::CSSWrapShapeRectangle::create):
(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeRectangle::CSSWrapShapeRectangle):

LayoutTests:

  • fast/exclusions/parsing-wrap-shape-inside-expected.txt:
  • fast/exclusions/parsing-wrap-shape-outside-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
9:39 AM Changeset in webkit [113327] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Marked fast/filesystem/file-writer-abort-continue.html as flaky crash
https://bugs.webkit.org/show_bug.cgi?id=83286

  • platform/chromium/test_expectations.txt: Marked.
9:10 AM Changeset in webkit [113326] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Disable paintingGoesToWindow() for the root layer when forced compositing mode is active
https://bugs.webkit.org/show_bug.cgi?id=83127

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by Rob Buis.

RIM PR: 136381
The BlackBerry port will use accelerated compositing code path to
render the root layer in some situations.

The plan is to do this by activating the "force compositing mode"
setting, but that in itself doesn't get us all the way, since painting
will still go to window for the root layer.

Fixed by adding a special clause in
RenderLayerBacking::paintingGoesToWindow() for PLATFORM(BLACKBERRY).

No new tests, this is currently not testable with the BlackBerry WebKit
testing infrastructure.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):
(WebCore::RenderLayerCompositor::inForcedCompositingMode): Added.

8:57 AM Changeset in webkit [113325] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Force compositing mode when backing store is not active
https://bugs.webkit.org/show_bug.cgi?id=83131

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 136381
Normally, the BlackBerry WebKit port resorts to direct rendering when
the backing store is not active. However, direct rendering is broken
with the OpenGL code path. This prevented multiple web pages from being
displayed at once with the new WebPageCompositor API.

Fixed by using accelerated compositing layer to render the root layer
instead of backing store. This will give us a tiled layer backing the
root layer, which for some use cases is even better than direct
rendering.

Reviewed internally by Filip Spacek.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::setNeedsOneShotDrawingSynchronization):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::rootLayer):
(WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setDrawsRootLayer):

  • Api/WebPage_p.h:

(WebPagePrivate):

8:51 AM Changeset in webkit [113324] by rakuco@webkit.org
  • 2 edits
    19 adds in trunk/LayoutTests

[EFL][DRT] Gardening 30 missing expectations
https://bugs.webkit.org/show_bug.cgi?id=83266

Unreviewed EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

  • platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-display-none-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
  • platform/efl/test_expectations.txt:
8:51 AM Changeset in webkit [113323] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315

Reviewed by Dimitri Glazkov.

The existing fix for this issue was failing to check if the frameView object
was currently _in_ layout, in addition to whether it needs layout. Calling the
redraw method while in layout leads to a debug assertion and potential infinite
layout loops. Now we check whether we need layout or are in layout. We also add
a check when the repaint timer fires to ensure we do not call redraw during layout
at that point.

This patch was tested with tens of thousands of runs on layout test cases that
previously crashed at a rate of about 1 in 25. Now we see no crashes and no test
failures.

No new tests, as this exists to fix flaky existing tests.

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

8:35 AM Changeset in webkit [113322] by schenney@chromium.org
  • 13 edits
    8 adds
    5 deletes in trunk/LayoutTests

Rebaseline after 73643
https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed update of test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

  • platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/clip-path/clipper-placement-issue-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/chromium-win/svg/clip-path/clipper-placement-issue-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
  • platform/chromium-win/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
  • platform/chromium/test_expectations.txt:
8:32 AM Changeset in webkit [113321] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] WK1/WK2 layout test results are diverging
https://bugs.webkit.org/show_bug.cgi?id=82720

The resolving of default font families was altered in Qt5.
This directly affects the font picked by DRT for layout
tests. Since we want to keep the Qt4 and Qt5 results in line,
we can trick DRT in picking the same font as before for now.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2012-04-05
Reviewed by Csaba Osztrogonác.

  • DumpRenderTree/qt/QtInitializeTestFonts.cpp:

(WebKit::initializeTestFonts):

7:44 AM Changeset in webkit [113320] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Hide datalist element
https://bugs.webkit.org/show_bug.cgi?id=82874

Source/WebCore:

The datalist element should be hidden when ENABLE_DATALIST is on.

Reviewed by Kent Tamura.

Tests: fast/forms/datalist/datalist-fallback-content-expected.html

fast/forms/datalist/datalist-fallback-content.html

  • css/html.css:

(datalist): Added display:none.

LayoutTests:

Reviewed by Kent Tamura.

  • fast/forms/datalist/datalist-fallback-content-expected.html: Added.
  • fast/forms/datalist/datalist-fallback-content.html: Added. Tests that fallback content is hidden.
6:49 AM Changeset in webkit [113319] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebCore

Adjust max bisection search iterations for TouchpadFlingGestureCurve.
https://bugs.webkit.org/show_bug.cgi?id=83166

Reviewed by James Robinson.

Covered by existing tests.

  • platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore):

6:25 AM Changeset in webkit [113318] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch FileSystem, Profiler and Worker domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83069

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-05
Reviewed by Yury Semikhatsky.

Domains are switched to 'strict' mode. However, hardly any changes were needed in C++ code because
only basic types are currently used in Inspector.json.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

5:49 AM Changeset in webkit [113317] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

DOM measurement APIs should operate on pixel snapped values.
https://bugs.webkit.org/show_bug.cgi?id=83138

Reviewed by Julien Chaffraix.

DOM measurement APIs return unscaled integers. In an effort to return the best possible values (and
most consistent with current behavior) when we use sub-pixel values for Layout, we want to adjust
the actual on-screen position and size values for scaling, not the sub-pixel values.

No new tests. No change in behavior.

  • dom/Element.cpp:

(WebCore::adjustForLocalZoom): Needs to return an integer, since this is what the DOM API calls for.
(WebCore::Element::offsetWidth): Using pixel snapped values for all the following functions.
(WebCore::Element::offsetHeight):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):

5:32 AM Changeset in webkit [113316] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] clean up WDTFC::saveAs after migration to save()
https://bugs.webkit.org/show_bug.cgi?id=83271

Reviewed by Yury Semikhatsky.

  • public/WebDevToolsFrontendClient.h:
5:22 AM Changeset in webkit [113315] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add ability to copy resource URL from web inspector's resources page.
https://bugs.webkit.org/show_bug.cgi?id=83175

Reviewed by Yury Semikhatsky.

Added requested context menu item.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

5:19 AM Changeset in webkit [113314] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: display frame duration instead of time ruler in Timeline panel's frame mode
https://bugs.webkit.org/show_bug.cgi?id=83184

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController): Maintain reference to TimelinePresentationModel
(WebInspector.TimelineFrameController.prototype._flushFrame): Report frames to TimelinePresentationModel (only real ones)

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.removeDividers): remove time marks/labels from upper time ruler

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._updateEventDividers): Updated call site of createEventDivider

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype._updateFrames): Frame bars rendering logic.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords): Do not keep frames in the panel any more.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh): Moved updateDividers() call here...
(WebInspector.TimelinePanel.prototype._refreshRecords): ... from here.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.createEventDivider): Use type & title, not entire record.
(WebInspector.TimelinePresentationModel.prototype.frames): Maintain frames in the TimelinePresentationModel.
(WebInspector.TimelinePresentationModel.prototype.reset): ditto.
(WebInspector.TimelinePresentationModel.prototype.addFrame): ditto.
(WebInspector.TimelinePresentationModel.Record): Fix title for timestamp events (drive by).

  • inspector/front-end/timelinePanel.css:

(.timeline-frame-strip):

4:56 AM Changeset in webkit [113313] by Patrick Gansterer
  • 5 edits in trunk/Source

[WinCE] Remove unnecessary function decleration
https://bugs.webkit.org/show_bug.cgi?id=83155

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

  • runtime/JSDateMath.cpp:

Source/WTF:

  • wtf/DateMath.cpp:
  • wtf/Platform.h:
4:50 AM Changeset in webkit [113312] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

IsCommentNode flags is a waste.
https://bugs.webkit.org/show_bug.cgi?id=83251

Reviewed by Ryosuke Niwa.

Effectively nobody uses it. To save a precious NodeFlags bit, this
change removes NodeFlags::IsCommentFlag and its companion mehtod
Node::isCommentNode().

No new tests. No behaviour change.

  • dom/CharacterData.h:

(WebCore::CharacterData::CharacterData):

  • dom/Comment.cpp:

(WebCore::Comment::Comment):

  • dom/Node.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::getTagName):
This was the only client of Node::isCommentNode(). Replaced it with nodeType() call.

4:45 AM Changeset in webkit [113311] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt][WK2] Skip tests that still failing after implementing layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=83263
[Qt] Moving already skipped test to right place and skip new SHADOW_DOM test.
https://bugs.webkit.org/show_bug.cgi?id=82607

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
3:58 AM Changeset in webkit [113310] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Remove layer-related passing tests from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83262

Unreviewed gardening

Fixing test expectations file - some of these cases already pass.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

  • platform/efl/test_expectations.txt:
3:52 AM Changeset in webkit [113309] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

[BlackBerry] Clear local storage won't take effect until browser exit and relaunch
https://bugs.webkit.org/show_bug.cgi?id=83253

Patch by Jonathan Dong <Jonathan Dong> on 2012-04-05
Reviewed by Rob Buis.

.:

RIM PR: #146871
Added a manual test case to test the behavior when press
button "Clear Local Storage" from browser settings.
It has to be a manual test as it requires user interaction.

  • ManualTests/blackberry/clear-localstorage.html: Added.

Source/WebKit/blackberry:

RIM PR: #146871
Cleared the local storage namespace of a WebPage's PageGroup
when WebPage::clearLocalStorage() get called.
Also deleted unused global function clearLocalStorage().

  • Api/BlackBerryGlobal.cpp:
  • Api/BlackBerryGlobal.h:

(WebKit):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::clearLocalStorage):

3:41 AM Changeset in webkit [113308] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/text/international/font-fallback-to-common-script.html has flaky image results on all Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=81544

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-05
Reviewed by Kent Tamura.

Skip embed-bidi-style-in-isolate-crash.html, which seems to cause the
subsequent layout test to fail (bug https://bugs.webkit.org/show_bug.cgi?id=83260).

  • platform/chromium/test_expectations.txt:
3:14 AM Changeset in webkit [113307] by hans@chromium.org
  • 4 edits in trunk/Source

webkit_unit_tests build fix.
https://bugs.webkit.org/show_bug.cgi?id=83261

Unreviewed, webkit_unit_tests buildfix.

The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
stopped working after r113254.

Disable it for now.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(WTF::TEST_F):

3:10 AM Changeset in webkit [113306] by tkent@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

[Chromium] Remove a wrong expectation file for hebrew-vowels.html.
https://bugs.webkit.org/show_bug.cgi?id=81544

  • platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.txt: Removed.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.txt: Removed.
2:30 AM WebKitEFLLayoutTest edited by dominik.rottsches@intel.com
changing deprecated flags, removing process count (done automatically) (diff)
2:25 AM Changeset in webkit [113305] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
https://bugs.webkit.org/show_bug.cgi?id=83137

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-05
Reviewed by Kentaro Hara.

fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
function object like this, "this[testsList[testCounter++]]();". I'm not familiar
with JavaScript and V8, but in my understanding, it looks a bit strange.
'this' in the statement means runNextTest function object which doesn't have
testList array object. (It's a global scope variable.) This test might be able to
pass on V8 JS engine, but not on JSC at least my try.
'testsList' is changed from a function name array to a function array.

  • fast/filesystem/script-tests/flags-passing.js:

(runNextTest):

2:13 AM Changeset in webkit [113304] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update after r113292.

  • platform/gtk/test_expectations.txt:
2:08 AM Changeset in webkit [113303] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r113279

  • platform/qt/Skipped: Skip a new failing test because ENABLE(MUTATION_OBSERVERS) is disabled.
1:58 AM Changeset in webkit [113302] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=82607
Skip V8 specific test that currently not supported on Qt bots

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05

  • platform/qt/Skipped: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html
1:53 AM Changeset in webkit [113301] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Only shut down V8 if we actually initialized it
https://bugs.webkit.org/show_bug.cgi?id=83159

Reviewed by Pavel Feldman.

  • src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

1:47 AM Changeset in webkit [113300] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] keycode translation is wrong for function keys
https://bugs.webkit.org/show_bug.cgi?id=82738

Source/WebCore:

This patch fixes keycode translation for function keys.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

Test: fast/events/keydown-function-keys.html

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createWindowsKeyMap):

LayoutTests:

Unskip fast/events/keydown-function-keys.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

  • platform/efl/Skipped:
1:19 AM FeatureFlags edited by tkent@chromium.org
Add CALENDAR_PICKER (diff)
1:18 AM Changeset in webkit [113299] by Nikolas Zimmermann
  • 19 edits in trunk

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Source/WebCore:

Work-around entity expansion bug that affects several SVG tests on Lion.

Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-W3CDTD SVG 1.1 BasicEN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>

<svg xmlns="http://www.w3.org/2000/svg">&Smile;</svg>

The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:

  • When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses) or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
  • When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started. This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
  • When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started, clear the recorded detph(), and stop executing the workaround.

It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):
(WebCore::XMLDocumentParser::isParsingEntityDeclaration):
(WebCore::XMLDocumentParser::setIsParsingEntityDeclaration):
(WebCore::XMLDocumentParser::depthTriggeringEntityExpansion):
(WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::hackAroundLibXMLEntityParsingBug):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::entityDeclarationHandler):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

Unskip several test on Lion, now that the libxml2 bug doesn't affect us anymore.

  • platform/mac-lion/Skipped:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/mac/svg/custom/viewbox-syntax-expected.png:
  • platform/mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
12:30 AM Changeset in webkit [113298] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

Add JavaScript and CSS code for the calendar picker implementation
https://bugs.webkit.org/show_bug.cgi?id=83011

Reviewed by Hajime Morita.

.:

  • ManualTests/forms/calendar-picker.html: Added.

Source/WebCore:

Add calendarPicker.js and calendarPicker.css, and add a build rule to
generate a C++ file. This change doesn't make any behavior change
because the code is wrapped by ENABLE(CALENDAR_PICKER).

Tests: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.css: Added.
  • Resources/calendarPicker.js: Added.
  • WebCore.gyp/WebCore.gyp: Generate CalendarPicker.{cpp,h} from calendarPicker.{css,js}.
12:29 AM Changeset in webkit [113297] by kinuko@chromium.org
  • 16 edits
    10 adds in trunk

Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
https://bugs.webkit.org/show_bug.cgi?id=82592

Reviewed by David Levin.

Source/WebCore:

For now the method is prefixed thus it is to be exposed as 'webkitGetAsEntry'.

The API is proposed and discussed in the following whatwg thread:
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html

Add DataTransferItemFilesystem under Modules/filesystem and implemented the bridging part for chromium.

Test: editing/pasteboard/data-transfer-items-drag-drop-entry.html

  • Modules/filesystem/DataTransferItemFileSystem.h: Added.

(DataTransferItemFileSystem):

  • Modules/filesystem/DataTransferItemFileSystem.idl: Added for DataTransferItem.getAsEntry which is only exposed if filesystem is enabled.
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Added for chromium implementation.
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.h: Added.
  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Added.
  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Added.
  • WebCore.gypi:
  • platform/chromium/ChromiumDataObject.cpp:
  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::filesystemId): Added.
(WebCore::ChromiumDataObject::setFilesystemId): Added.

  • platform/chromium/ClipboardChromium.cpp:

Source/WebKit/chromium:

  • src/WebDragData.cpp:

(WebKit::WebDragData::filesystemId): Added implementation.
(WebKit::WebDragData::setFilesystemId): Added implementation.

Tools:

Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::beginDragWithFiles):

LayoutTests:

  • editing/pasteboard/data-transfer-items-drag-drop-entry-expected.txt: Added.
  • editing/pasteboard/data-transfer-items-drag-drop-entry.html: Added.
  • editing/pasteboard/resources/test_directory/test.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:21 AM Changeset in webkit [113296] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113279.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:

Apr 4, 2012:

11:40 PM Changeset in webkit [113295] by Patrick Gansterer
  • 10 edits in trunk/Source

Add WTF::getCurrentLocalTime()
https://bugs.webkit.org/show_bug.cgi?id=83164

Reviewed by Alexey Proskuryakov.

Replace the calls to WTF::getLocalTime() with time(0) with the new function.
This allows us to use Win32 API on windows to get the same result in a next step.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/DateConstructor.cpp:

(JSC::callDate):

Source/WebCore:

  • html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WTF:

Also remove the inline keyword from WTF::getLocalTime(), since there is no need for
it and it will make the later Win32 API changes easier.

  • WTF.gyp/WTF.gyp:
  • wtf/CurrentTime.cpp:

(WTF::getLocalTime):
(WTF::getCurrentLocalTime):

  • wtf/CurrentTime.h:
10:29 PM Changeset in webkit [113294] by hayato@chromium.org
  • 22 edits
    4 deletes in trunk

Remove ReifiedTreeTraversal.
https://bugs.webkit.org/show_bug.cgi?id=83110

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

We can now remove ReifiedTreeTraversal. All clients have switched to use ComposedShadowTreeWalker.

No new tests. No change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ReifiedTreeTraversal.cpp: Removed.
  • dom/ReifiedTreeTraversal.h: Removed.
  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/reified-tree-traversal-expected.txt: Removed.
  • fast/dom/shadow/reified-tree-traversal.html: Removed.
  • platform/efl/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
10:29 PM Changeset in webkit [113293] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Another unreviewed attempt at getting the EFL build bot to a
healthy state by forcing a rebuild.

  • ewk/ewk_cookies.h:
10:17 PM Changeset in webkit [113292] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83173

Reviewed by David Levin.

Try to deflake the test by

  • decreasing the number of reloads in the test, and
  • changing the URL of WebSocket to silence random console messages.
  • http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:

Reloading 100 times seemed too much, as Chromium debug bots frequently time out.

  • http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:

Use a real URL to avoid random console messages.

10:15 PM Changeset in webkit [113291] by dslomov@google.com
  • 2 edits in trunk/Source/WebCore

WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
https://bugs.webkit.org/show_bug.cgi?id=83202

On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
The tasks in their turn delete themselves from the map whenever task gets executed.
However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.

Reviewed by David Levin.

Covered by existing tests.

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
(WorkerEventQueue::EventDispatcherTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):

10:13 PM Changeset in webkit [113290] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed; touch a file to check if the EFL build bot is back to
normal.

  • ewk/ewk_cookies.h:
9:30 PM Changeset in webkit [113289] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

RenderLayer scrollbars' updates should be split between layout induced and style change induced
https://bugs.webkit.org/show_bug.cgi?id=83213

Reviewed by Simon Fraser.

Refactoring only, no change in behavior.

This patches splits up the 2 reasons for modifying the scrollbars:

  • style updates, handled in updateScrollbarsAfterStyleChange.
  • layout time, handled in updateScrollbarsAfterLayout.
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize):
Removed now unneeded const-casts.

(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
Updated to use hasHorizontalScrollbar / hasVerticalScrollbar.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Made those functions |const|.

(WebCore::RenderLayer::computeScrollDimensions):
Removed the unneeded booleans and move the do-we-have-overflow-logic
into hasHorizontalOverflow and hasVerticalOverflow.

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
Added those new helper functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Updated the latter to call the former.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
(WebCore::RenderLayer::styleChanged):
Ditto.

(WebCore::overflowCanHaveAScrollbar):
Add this helper function for updateScrollbarsAfterStyleChange.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasHorizontalScrollbar):
(WebCore::RenderLayer::hasVerticalScrollbar):
Added those 2 new helper functions.

9:28 PM Changeset in webkit [113288] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

[mac] WKTR should always keep its windows offscreen
https://bugs.webkit.org/show_bug.cgi?id=83244
<rdar://problem/11188764>

Reviewed by Simon Fraser.

We don't want to allow windows onto the main display; intercept attempts to
change WebKitTestRunnerWindow's frame origin and prevent it from happening.

Also keep around and respond with a new "fake" origin, in case someone is
expecting it to change (I couldn't find any tests that expected this, however).

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:display:animate:]):
(-[WebKitTestRunnerWindow setFrame:display:]):
(-[WebKitTestRunnerWindow frame]):

9:22 PM Changeset in webkit [113287] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.

No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

9:18 PM Changeset in webkit [113286] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

XSSAuditor doesn't catch injected srcdoc attributes
https://bugs.webkit.org/show_bug.cgi?id=83238

Reviewed by Daniel Bates.

Source/WebCore:

<iframe srcdoc> is an XSS injection vector because the srcdoc inherits
the security origin of the parent page. This patch updates the XSS
auditor to check whether the attribute is injected using the same
hueristics we use for inline event handlers.

Test: http/tests/security/xssAuditor/iframe-srcdoc.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/iframe-srcdoc-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-srcdoc.html: Added.
9:06 PM Changeset in webkit [113285] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add local: protocol support in KURL for blackberry
https://bugs.webkit.org/show_bug.cgi?id=82695

Reviewed by Rob Buis.

BlackBerry porting is using local: protocol just as file: protocol
with the exception that it sandboxes the path to the application private space.

  • platform/KURL.cpp:

(WebCore::KURL::parse):
(WebCore::portAllowed):

8:44 PM Changeset in webkit [113284] by Simon Fraser
  • 3 edits
    2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Fix an issue when removing elements with reflections from the document.

Test: compositing/reflections/remove-reflection.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::willBeDestroyed):

LayoutTests: REGRESSION(112939): compositing/reflections/backface-hidden-reflection.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Test that removes reflected elements.

  • compositing/reflections/remove-reflection-expected.txt: Added.
  • compositing/reflections/remove-reflection.html: Added.
8:43 PM Changeset in webkit [113283] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need using namespace std for system calls in MIMESniffing.cpp
https://bugs.webkit.org/show_bug.cgi?id=82706

Reviewed by Antonio Gomes.

No new tests, just fix the compile error for BlackBerry porting.

  • platform/network/MIMESniffing.cpp:
8:36 PM Changeset in webkit [113282] by commit-queue@webkit.org
  • 12 edits in trunk

Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Patch by Greg Billock <gbillock@google.com> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity):

  • Modules/intents/NavigatorIntents.h:

(NavigatorIntents):

  • Modules/intents/NavigatorIntents.idl:

LayoutTests:

  • webintents/resources/web-intents-reload-orig.html:
  • webintents/resources/web-intents-testing.js:

(startIntentWithCallbacks):

  • webintents/web-intents-api-expected.txt:
  • webintents/web-intents-api.html:
  • webintents/web-intents-invoke.html:
8:08 PM Changeset in webkit [113281] by alexis.menard@openbossa.org
  • 11 edits in trunk/Source/WebCore

[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83224

Reviewed by Tony Chang.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • page/animation/AnimationBase.h:

(WebCore::AnimationBase::affectsProperty):
(WebCore::AnimationBase::isAnimatingProperty):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):

  • page/animation/CompositeAnimation.h:

(CompositeAnimation):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::affectsProperty):

  • page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::transitionProperty):
(WebCore::ImplicitAnimation::animatingProperty):
(ImplicitAnimation):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::affectsProperty):

  • page/animation/KeyframeAnimation.h:

(KeyframeAnimation):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::transitionPaused):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

7:50 PM Changeset in webkit [113280] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar Picker: Add localization functions
https://bugs.webkit.org/show_bug.cgi?id=83235

Reviewed by Adam Barth.

Implement calendarTodayText() and calendarClearText(), which are
introduced in http://trac.webkit.org/changeset/113166

  • public/platform/WebLocalizedString.h:

Add CalendarClear and CalendarToday.

  • src/LocalizedStrings.cpp:

(WebCore::calendarTodayText): Added.
(WebCore::calendarClearText): Added.

7:50 PM Changeset in webkit [113279] by rafaelw@chromium.org
  • 5 edits
    2 adds in trunk

[MutationObservers] implement takeRecords()
https://bugs.webkit.org/show_bug.cgi?id=83218

Reviewed by Ojan Vafai.

Source/WebCore:

This patch implements MutationObserver.takeRecords per the DOM4 spec.
takeRecords retrieves and clears any pending mutation records for
the observer.

Test: fast/mutation/takeRecords.html

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::takeRecords):
(WebCore):
(WebCore::WebKitMutationObserver::deliver):

  • dom/WebKitMutationObserver.h:
  • dom/WebKitMutationObserver.idl:

LayoutTests:

  • fast/mutation/takeRecords-expected.txt: Added.
  • fast/mutation/takeRecords.html: Added.
7:42 PM Changeset in webkit [113278] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
7:35 PM Changeset in webkit [113277] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix typo introduced in r113271.

Unreviewed, build fix.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data.callback):
(FileUploader):

7:28 PM Changeset in webkit [113276] by shinyak@chromium.org
  • 12 edits
    2 adds in trunk

Shadow DOM is exposed in JS.
https://bugs.webkit.org/show_bug.cgi?id=82607

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

DOMSelection didn't consider nested shadow trees. This patch makes DOMSelection
take nested shadow trees into account.

To test that the element is not in a shadow tree, Internals has a treeScopeRootNode method
which returns the root node of the belonging tree scope.

Test: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html

  • WebCore.exp.in:
  • page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor):
(WebCore):

  • testing/Internals.cpp:

(WebCore::Internals::treeScopeRootNode):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt: Added.
  • fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html: Added.
7:07 PM Changeset in webkit [113275] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
https://bugs.webkit.org/show_bug.cgi?id=82593

Reviewed by Dimitri Glazkov.

Prior to r113125, if we traverse a ShadowRoot which does not have any children,
it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
Adds a test case for that to catch a future regression.

  • fast/dom/shadow/focus-navigation-expected.html:
  • fast/dom/shadow/focus-navigation.html:
6:57 PM Changeset in webkit [113274] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Chromium, DRT] Bounds check indices on gamepadController
https://bugs.webkit.org/show_bug.cgi?id=83192

Invalid test data would cause bad array accesses. Add simple checks to
ignore such invalid data.

Patch by Scott Graham <scottmg@google.com> on 2012-04-04
Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/GamepadController.cpp:

(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

6:42 PM Changeset in webkit [113273] by macpherson@chromium.org
  • 9 edits in trunk/Source/WebCore

Replace further usage of int with CSSPropertyID.
https://bugs.webkit.org/show_bug.cgi?id=83119

Reviewed by Simon Fraser.

No new tests / no functionality changed.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):

  • css/CSSParser.h:

(CSSParser):
(WebCore::ShorthandScope::~ShorthandScope):

  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/makeprop.pl:
  • dom/StyledElement.h:

(StyledElement):

  • editing/EditingStyle.h:

(EditingStyle):

  • html/HTMLElement.h:

(HTMLElement):

6:38 PM Changeset in webkit [113272] by adamk@chromium.org
  • 11 edits in trunk/Source/WebCore

Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

Relanding r112163 without modification, as it still seems valid.
Will watch Chrome Canaries closely for any memory issues.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

  • bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

6:17 PM Changeset in webkit [113271] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

More debugging info and a possible fix - stop messing with the
default network timeout, and don't swallow URLErrors.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data):

  • Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTransaction.run):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

5:56 PM Changeset in webkit [113270] by oliver@apple.com
  • 5 edits in trunk

Parser fails to revert some state after parsing expression and object literals.
https://bugs.webkit.org/show_bug.cgi?id=83236

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Reset left hand side counter after parsing the literals.

  • parser/Parser.cpp:

(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):

LayoutTests:

Add more parser test cases.

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:
5:48 PM Changeset in webkit [113269] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG InstanceOf should not uselessly speculate cell
https://bugs.webkit.org/show_bug.cgi?id=83234

Reviewed by Oliver Hunt.

If InstanceOf is the only user of its child then don't speculate cell, since
the not-cell case is super easy to handle.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOf):

5:14 PM Changeset in webkit [113268] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

WaveTable::waveDataForFundamentalFrequency() should properly interpret negative frequency
https://bugs.webkit.org/show_bug.cgi?id=83228

Reviewed by Kenneth Russell.

  • Modules/webaudio/WaveTable.cpp:

(WebCore::WaveTable::waveDataForFundamentalFrequency):

5:05 PM Changeset in webkit [113267] by adamk@chromium.org
  • 5 edits
    2 adds in trunk

Delay post-insertion notifications until new DOM tree is complete
https://bugs.webkit.org/show_bug.cgi?id=82631

Reviewed by Ojan Vafai.

Source/WebCore:

When inserting a DocumentFragment, WebKit previously would update both
internal WebCore state and mutation event listeners after each node
was inserted. This is inconsistent not only with DOM4, but also
with (at least) Firefox and IE. Given the many bugs over the years in
WebKit due to this behavior, it seems better to delay notification
until the fragment is completely inserted.

The changes to the three core mutation methods below are similar:
the only logic remaining in the loop is checking that insertion is
possible and taking care of that insertion. The entire loop is then
wrapped in forbidEventDispatch/allowEventDispatch, effectively
asserting that none of the code inside will have side effects.

The one bit of logic added to the loop is resizing the targets
vector down to the set of nodes actually inserted as part of the
loop. This makes it possible to simply pass the vector on to
notifyChildrenInserted without having to also pass along a count of
actually-inserted nodes.

As for the code that used to live inside the loop that could have
side-effects, or depended on those side-effects, it has been moved
out, either above (the check that the refChild is still valid in
insertBefore) or after (the calls to notifyChildrenInserted).

Finally, it was necessary to retrofit ChildListMutationScope to take a
vector of added nodes instead of a single node at a time, due to the
assertions in isAddedNodeInOrder (now renamed to be plural). Note that
there is now a single call to ChildListMutationScope::childrenAdded,
inside notifyChildrenInserted.

Test: fast/events/domnodeinserted-entire-fragment.html

  • dom/ChildListMutationScope.cpp:

(ChildListMutationScope::MutationAccumulator): Renamed method to be plural.
(WebCore::ChildListMutationScope::MutationAccumulator::areAddedNodesInOrder): Handle a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulator::childrenAdded): Handle adding a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childrenAdded): Renamed to be plural, pass NodeVector through.

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::childrenAdded): ditto.
(MutationAccumulationRouter):

  • dom/ContainerNode.cpp:

(WebCore): Renamed updateTreeAfterInsertion to notifyChildrenInserted.
(WebCore::ContainerNode::insertBefore): See main ChangeLog explanation.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.
(WebCore::dispatchChildInsertionEvents): Remove MutationObserver handling.
(WebCore::notifyChildrenInserted): Handle a NodeVector of all inserted children,
and take on responsiblity for MutationObserver handling as well as dispatchSubtreeModifiedEvent.

LayoutTests:

  • fast/events/domnodeinserted-entire-fragment-expected.txt: Added.
  • fast/events/domnodeinserted-entire-fragment.html: Added.
5:03 PM Changeset in webkit [113266] by crogers@google.com
  • 5 edits in trunk

RealtimeAnalyserNode should support smaller analysis sizes
https://bugs.webkit.org/show_bug.cgi?id=83215

Source/WebCore:

Reviewed by Kenneth Russell.

RealtimeAnalyserNode analysis size currently goes no lower than 128.
It is useful to support lower power-of-two sizes.
Decrease this limit to 32.

Updated webaudio/realtimeanalyser-fft-sizing-expected.txt

  • Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore):

LayoutTests:

Reviewed by Kenneth Russell.

  • webaudio/realtimeanalyser-fft-sizing-expected.txt:
  • webaudio/realtimeanalyser-fft-sizing.html:
5:00 PM Changeset in webkit [113265] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Unify and modernize fast/css/{outline,background}-currentcolor.html
https://bugs.webkit.org/show_bug.cgi?id=75523

Patch by David Barr <davidbarr@chromium.org> on 2012-04-04
Reviewed by Daniel Bates.

Use js-test-pre utility functions instead of hardcoded testing logic
to simplify the test code and make the test more closely conform to
the visual appearance of other PASS/FAIL tests.

  • fast/css/background-currentcolor-expected.txt:
  • fast/css/background-currentcolor.html:
  • fast/css/outline-currentcolor-expected.txt:
  • fast/css/outline-currentcolor.html:
4:57 PM Changeset in webkit [113264] by tony@chromium.org
  • 3 edits
    2 adds in trunk

CSS transitions should work on the flex property
https://bugs.webkit.org/show_bug.cgi?id=75915

Reviewed by Dean Jackson.

Source/WebCore:

Test: transitions/flex-transitions.html

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperGetter::equals): Fix indention.
(PropertyWrapperFlex): Add a wrapper for -webkit-flex which has 3 values (two floats and
a length), but is not a shorthand.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
(WebCore):
(WebCore::AnimationBase::ensurePropertyMap):

LayoutTests:

  • transitions/flex-transitions-expected.txt: Added.
  • transitions/flex-transitions.html: Added.
4:54 PM Changeset in webkit [113263] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor bypass through HTTP Parameter Pollution.
https://bugs.webkit.org/show_bug.cgi?id=81283

Reviewed by Adam Barth.

Source/WebCore:

Deal with concatenation of multiple parameters via comma-splicing that
is common to some webservers. We can no longer trust that all of the
attributes of a reflected script tag, nor the reflected script itself,
came from the same single URL parameter. The fix is to take commas into
account when trucating the snippet used for matching.

Test: http/tests/security/xssAuditor/script-tag-with-comma.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

  • http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-comma.html: Added.
4:50 PM Changeset in webkit [113262] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed minor error: "& 3" should be "& 2".

Rubber-stamped by Oliver Hunt.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

4:28 PM Changeset in webkit [113261] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Text input doesn't work for some Flash forms
https://bugs.webkit.org/show_bug.cgi?id=83232
<rdar://problem/11186162>

Reviewed by Alexey Proskuryakov.

If a plug-in is instantiated when the WKView is not focused, text input wouldn't work. The reason for this
is that WebPage::windowIsFocused() would only return true if the window and the WKView are both focused. Rename
this member function to windowAndWebPageAreFocused, add a new windowIsFocused member function that does the right thing
and change WebPage::focusedWebPage to use windowAndWebPageAreFocused.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowIsFocused):
(WebKit):
(WebKit::WebPage::windowAndWebPageAreFocused):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::focusedWebPage):

4:23 PM Changeset in webkit [113260] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Paginated webviews render nothing in their gutters
https://bugs.webkit.org/show_bug.cgi?id=83231

Reviewed by Adele Peterson.

When the RenderView has columns, nothing draws in the gutters.

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents): Paint the background color behind everything when
paginated.

4:17 PM Changeset in webkit [113259] by Dimitri Glazkov
  • 1 edit
    59 adds in trunk/LayoutTests

[Chromium] Update expectations for Leopard.

  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds: Added.
  • platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Added.
4:10 PM Changeset in webkit [113258] by tony@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

inline script for flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=83220

Reviewed by Ojan Vafai.

Inline the .js test files into the .html files. These tests don't need
to be in a separate file.

  • css3/flexbox/css-properties.html:
  • css3/flexbox/display-flexbox-set-get.html:
  • css3/flexbox/resources/display-flexbox-set-get.js: Removed.
  • css3/flexbox/script-tests/TEMPLATE.html: Removed.
  • css3/flexbox/script-tests/css-properties.js: Removed.
4:06 PM Changeset in webkit [113257] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:
4:01 PM Changeset in webkit [113256] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

3:55 PM Changeset in webkit [113255] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Call histogramEnumeration directly
https://bugs.webkit.org/show_bug.cgi?id=83106

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Part of a refactoring project to remove the PlatformSupport
abstraction from some functions. See bug 82948.

Source/WebCore:

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):

  • platform/chromium/HistogramSupportChromium.cpp:

(WebCore::HistogramSupport::histogramEnumeration):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

  • src/PlatformSupport.cpp:

(WebCore):

3:53 PM Changeset in webkit [113254] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2012-04-04 Zhenyao Mo <zmo@google.com>

Unreviewed, GPU bots build fix.

Commited on behalf of sievers@chromium.org.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::canDraw):
3:42 PM Changeset in webkit [113253] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Constant Blinding for add/sub immediate crashes in ArmV7 when dest is SP
https://bugs.webkit.org/show_bug.cgi?id=83191

Reviewed by Oliver Hunt.

Make are that blinded constant pairs are similarly aligned to the
original immediate values so that instructions that expect that
alignment work correctly. One example is ARMv7 add/sub imm to SP.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::add): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub_S): Added ASSERT that immediate is word aligned.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

3:41 PM Changeset in webkit [113252] by inferno@chromium.org
  • 17 edits in trunk

Add helpers to create anonymous table parts.
https://bugs.webkit.org/show_bug.cgi?id=83116

Reviewed by Julien Chaffraix.

Source/WebCore:

The patch introduces helpers to create anonymous table parts by
introducing a new static function createAnonymousWithParentRenderer.
The function builds a new anonymous wrapper of the same type as the class,
inheriting style properties from parent and sets a display based on
argument/default values. Also we streamline the RenderBlock functions
to match this naming convention.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousBlockWithSameTypeAs):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRendererAndDisplay):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::createAnonymousColumnsBlock):
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::addChild):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
(WebCore::RenderTable::createAnonymousWithParentRendererAndDisplay):
(WebCore):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRendererAndDisplay):
(WebCore):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):
(WebCore::RenderTableRow::createAnonymousWithParentRendererAndDisplay):
(WebCore):

  • rendering/RenderTableRow.h:

(RenderTableRow):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::createAnonymousWithParentRendererAndDisplay):
(WebCore):

  • rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Rebaselining tests because we now correctly inherit the bidi override.

  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
3:36 PM Changeset in webkit [113251] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html

  • platform/chromium/test_expectations.txt: Tweaked some more.
3:30 PM Changeset in webkit [113250] by arv@chromium.org
  • 14 edits
    6 adds in trunk

[V8] Add a per context data store and use that for caching boiler plates as well as constructor functions
https://bugs.webkit.org/show_bug.cgi?id=83093

Reviewed by Adam Barth.

Source/WebCore:

This introduces a V8BindingPerContextData class. After creating a new v8::Context we also create a new
per context data instance. This instance maintains the boiler plate and constructor caches. V8DOMWrapper
now delegates the caching to this new class. Previously the caching was only done in V8DOMWindowShell which
made workers and isolated worlds behave slightly different.

Tests: fast/dom/constructor-proto.html

fast/workers/constructor-proto.html

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorGetter): Renamed getConstructor to constructorForType.

  • bindings/v8/V8BindingPerContextData.cpp: Added.

(WebCore):
(WebCore::V8BindingPerContextData::dispose): This clears the persistent handles stored in the maps.
(WebCore::V8BindingPerContextData::init): This installs the hidden prototype which is used as the
Prototype? for the constructor functions (for HotMail compat).
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase): Instantiates a new object and
stores it in the boilerplate map, and returns a clone.
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): Creates the function for the constructor
and stores it in the constructor map.

  • bindings/v8/V8BindingPerContextData.h: Added.

(WebCore):
(V8BindingPerContextData):
(WebCore::V8BindingPerContextData::create):
(WebCore::V8BindingPerContextData::~V8BindingPerContextData):
(WebCore::V8BindingPerContextData::createWrapperFromCache): Checks the cache and clones the wrapper in
the cache. If no boiler plate exists one is created and cached.
(WebCore::V8BindingPerContextData::constructorForType): If the constructor already exists the cached
constructor function is returned, otherwise a new constructor function is created and cached.
(WebCore::V8BindingPerContextData::V8BindingPerContextData):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles): Clear the per context data when disposing the handles.
(WebCore::V8DOMWindowShell::initContextIfNeeded): Create and initialize the per context data.
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::perContextData):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::constructorForType): Static method to get the constructor. The per context data
is determined based on the type of the parameters.
(WebCore):
(WebCore::V8DOMWrapper::perContextData):
(WebCore::V8DOMWrapper::instantiateV8Object): Use the per context data to unify the code paths.

  • bindings/v8/V8DOMWrapper.h:

(WebCore):
(V8DOMWrapper):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext): Create and initialize the per context data.
(WebCore::V8IsolatedContext::destroy): Clear the per context data.

  • bindings/v8/V8IsolatedContext.h:

(WebCore):
(WebCore::V8IsolatedContext::perContextData):
(V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrievePerContextData):
(WebCore):

  • bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose): Clear the per context data
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Create and initialize the per context data.

  • bindings/v8/WorkerContextExecutionProxy.h:

(WebCore):
(WebCore::WorkerContextExecutionProxy::perContextData):
(WorkerContextExecutionProxy):

LayoutTests:

  • fast/dom/constructor-proto-expected.txt: Added.
  • fast/dom/constructor-proto.html: Added.
  • fast/workers/constructor-proto-expected.txt: Added.
  • fast/workers/constructor-proto.html: Added.
3:28 PM Changeset in webkit [113249] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expected test output for a test already marked FAIL.
Replace dummy output with real expected output to unblock Chromium-side test.

  • storage/indexeddb/dont-commit-on-blocked-expected.txt:
3:23 PM Changeset in webkit [113248] by shawnsingh@chromium.org
  • 7 edits in trunk/Source

[chromium] Move recursive renderSurface clearing to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=82091

Reviewed by James Robinson.

Source/WebCore:

No new tests needed, minor refactoring covered by existing tests.

This patch is just a minor cleanup, moving clearRenderSurfacesOnCCLayerImplRecursive()
from LayerRendererChromium to CCLayerTreeHostImpl. It makes more sense to place the code
there, so that LayerRendererChromium is more like a blind utility for drawing things
while CCLayerTreeHostImpl actually manages the state of the resources.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::sendDidLoseContextRecursive):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::rootLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):

3:23 PM Changeset in webkit [113247] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for accessibility/aria-checkbox-sends-notification.html.

  • platform/chromium/test_expectations.txt: Tweaked expectations.
3:19 PM Changeset in webkit [113246] by eae@chromium.org
  • 1038 edits
    503 copies
    31 deletes in branches/subpixellayout

Merge trunk changes up until 113241 into subpixel branch.

3:13 PM Changeset in webkit [113245] by crogers@google.com
  • 9 edits in trunk/Source

Web Audio should use MutexTryLocker class
https://bugs.webkit.org/show_bug.cgi?id=83194

Reviewed by Kenneth Russell.

Source/WebCore:

Switch existing Web Audio code from directly calling tryLock() on a Mutex to use a MutexTryLocker.
No new tests since it is a low-level threading primitive and is difficult to test.
Existing Web Audio tests continue to test the process() methods affected.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRange):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::process):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::process):

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::process):

  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::process):

Source/WTF:

Add MutexTryLocker class which can be used as a stack-based object wrapping a Mutex.
It will automatically unlock the Mutex in its destructor if the tryLock() succeeded.

  • wtf/ThreadingPrimitives.h:

(MutexTryLocker):
(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):
Check if the tryLock() on the Mutex succeeded.
(WTF):

3:06 PM Changeset in webkit [113244] by rakuco@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS] Make makevalues.pl and makeprop.pl ignore '#'s.
https://bugs.webkit.org/show_bug.cgi?id=83212

Reviewed by Tony Chang.

This patch is a side-effect of my intentions to make the
CMake-based ports work with GCC 4.7 without changing the
parameters currently passed to the preprocessor. "-P" is always
being passed to the preprocessor, but this breaks
dom/make_names.pl due to GCC not outputting empty lines with "-P"
anymore; if I switch to never passing "-P" (my aim), the CSS
scripts currently break because of the additional lines output by
the preprocessor. InFilesParser.pm and make-css-file-array.pl
already skip lines which start with '#', for example.

No new tests, tools plumbing.

  • css/makeprop.pl:
  • css/makevalues.pl:
2:48 PM Changeset in webkit [113243] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Disable fancy upsampling and dithering for decoding jpeg on android
https://bugs.webkit.org/show_bug.cgi?id=83196

Patch by Min Qin <qinmin@google.com> on 2012-04-04
Reviewed by Kenneth Russell.

Dithering and fancy upsampling are currently disabled for chrome on android.
This gives us about 20% performance improvement.
Since the screen of mobile devices is small, impact on image quality is limited.
This change does not introduce any changes on other platforms.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(ditherMode):
(doFancyUpsampling):
(WebCore::JPEGImageReader::decode):

2:40 PM WebKit Team edited by Antti Koivisto
(diff)
2:36 PM Changeset in webkit [113242] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fonts/cursive.html as flaky on LION.

  • platform/chromium/test_expectations.txt: Marked as flaky.
2:33 PM WebKit Team edited by kling@webkit.org
(diff)
2:27 PM Changeset in webkit [113241] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Always skip draw and readback if there is nothing
to draw.
https://bugs.webkit.org/show_bug.cgi?id=82680

This avoids corruption from pushing frames that have no valid
content drawn into them.
Also in addition to checking for non-existing root layers, check
for root layers with no content bounds. It's possible to see those
with kForceCompositing mode for empty documents.

Patch by Daniel Sievers <sievers@chromium.org> on 2012-04-04
Reviewed by James Robinson.

Added CCLayerTreeHostTestEmptyContentsShouldNotDraw.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF):
(CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::beginTest):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::afterTest):
(WTF::TEST_F):

2:14 PM Changeset in webkit [113240] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should short-circuit Branch(LogicalNot(...))
https://bugs.webkit.org/show_bug.cgi?id=83181

Reviewed by Geoff Garen.

Slight (sub 1%) speed-up on V8.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

2:12 PM Changeset in webkit [113239] by Beth Dakin
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=83207
platform/mac/fast/forms/input-list-button-size.html fails on the Mac bots after
r11317

This test is expected to fail now that datalist is disabled.

  • platform/mac/Skipped:
2:11 PM Changeset in webkit [113238] by jer.noble@apple.com
  • 15 edits in trunk/Source

Full Screen mode should cancel before navigation.
https://bugs.webkit.org/show_bug.cgi?id=81295

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; protect against speculative crasher when a bad client calls the below
functions at inopportune times.

Check that the document is not either detached or in the page cache, and if so, bail out
early:

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

Source/WebKit/mac:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController isFullScreen]): Added.

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if

present and in full screen mode.

Source/WebKit2:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

Close the full screen window controller, if present and in full screen mode:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add boilerplate to support passing through isFullScreen() and close() methods from the WebPageProxy
to the WKFullScreenWindowController:

  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController isFullScreen]): Added simple accessor.

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::close): Pass through to the WKFullScreenWindowController.
(WebKit::WebFullScreenManagerProxy::isFullScreen): Ditto.

2:06 PM Changeset in webkit [113237] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=82669

  • platform/chromium/test_expectations.txt: Tweaked expectations.
2:06 PM Changeset in webkit [113236] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix getFilterOutsets parameter types in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=83041

Reviewed by Julien Chaffraix.

The getFilterOutsets method was changed to take integers in r112475, update
RenderLayer to use the right data type for the outset arguments.

No new tests, no change in functionality.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::calculateLayerBounds):

1:51 PM Changeset in webkit [113235] by commit-queue@webkit.org
  • 14 edits in trunk

WKTR needs to implement layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=69554

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Simon Fraser.

Source/WebKit2:

This patch implements the setPageVisibilityState through InjectedBundle
so WKTR supports the Page Visibility API and can set the visibility state
directly to Page.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit):
(WebKit::InjectedBundle::setPageVisibilityState):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

This patch implements the layoutTestController.setPageVisibility
so WKTR supports the Page Visibility API implementation by using InjectedBundle
to set the visibility state directly to Page.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR):
(WTR::LayoutTestController::resetPageVisibility):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

  • platform/wk2/Skipped: Unskipping compositing/video-page-visibility.html
1:47 PM Changeset in webkit [113234] by arv@chromium.org
  • 5 edits in trunk/Source/WebCore

Rebaseline binding tests.

Unreviewed.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

1:43 PM Changeset in webkit [113233] by dslomov@google.com
  • 5 edits in trunk

Source/WebCore: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
The implementation of structured cloning algorithm (http://www.w3.org/TR/html5/common-dom-interfaces.html#internal-structured-cloning-algorithm)
in SerializedScriptValue.cpp assigns numerical identifiers to encontered objects as it traverses
the cloned object during serialization.
When the cloning encounters an already seen object, it transfers the assigned numerical id
instead of cloning the object again. Deserialization process then repeats the process in
the mirror fashion, i.e. on deserializing the object it assigns deserialized object a numeric id and if it
deserializes the id it substitutes the perviously deserialized objects. It is critical that serialization and deserialization
assigns numeric ids in the same order.

The bug (discovered by Yong Li) is that when serializing ArrayBufferView, the ids were assigned first to
the ArrayBufferView and then to underlying ArrayBuffer; however on deserialization the ids were assigned another way round.

This patch fixes that by assigning the id first to ArrayBuffer and then to ArrayBufferView, and adds corresponding test cases.

Reviewed by Kenneth Russell.

New test cases added to fast/canvas/web-gl/array-message-passing.html.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(CloneSerializer):
(WebCore::CloneSerializer::recordObject):
(WebCore::CloneSerializer::startObjectInternal):
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
Adds tests that cover more than one view of the same ArrayBuffer being cloned.

Reviewed by Kenneth Russell.

  • fast/canvas/webgl/array-message-passing-expected.txt:
  • fast/canvas/webgl/script-tests/array-message-passing.js:

(typedArrayCompare):
(dataViewCompare):
(dataViewCompare2):
(dataViewCompare3):

1:31 PM Changeset in webkit [113232] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] When setting animation started events, should check the root layer
https://bugs.webkit.org/show_bug.cgi?id=83060

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-04
Reviewed by Adrienne Walker.

No new tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::animateLayers):
(WebCore::CCLayerTreeHost::animateLayersRecursive):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

1:27 PM Changeset in webkit [113231] by abarth@webkit.org
  • 3 edits in trunk

[Chromium] TestWebKitAPI links in WebCore twice
https://bugs.webkit.org/show_bug.cgi?id=83177

Reviewed by Dimitri Glazkov.

This is causing link errors in the Windows component build. This patch
moves the dependencies a bit lower down in the dependency diagram in
the hopes of removing the duplicate symbols.

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1:10 PM Changeset in webkit [113230] by adamk@chromium.org
  • 9 edits in trunk

Web Inspector: break on DOM node insertion only once per operation, not once per inserted node
https://bugs.webkit.org/show_bug.cgi?id=82967

Reviewed by Ojan Vafai.

Source/WebCore:

This change affects the case where a DocumentFragment is inserted,
rather than a single node. This is most common when using innerHTML:
the effect of the change is that inserting, e.g., '<input><input>',
the SubtreeModified breakpoint will be hit once, rather than twice
(once for each input element). Given that the particular node being
inserted wasn't exposed as part of the breakpoint, this seems strictly
better.

Now that the call to willInsertDOMNode is outside the loop, there's
not an obvious node to pass in as the new child. Luckily, InspectorDOMDebuggerAgent
already ignored that argument, so it's simply been removed from the signature.

This changes paves the way to do only tree-modification work, and no
external notifications, inside the loops in appendChild/insertBefore/replaceChild.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore): Hoisted call to willInsertDOMNode out of loop.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): Removed first argument (now takes only the parent).

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): Removed second argument.

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willInsertDOMNode): Removed second argument.

LayoutTests:

Added test for setting inner HTML and ensuring that only a single
breakpoint is hit.

  • inspector/debugger/dom-breakpoints.html:
  • platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:
1:06 PM Changeset in webkit [113229] by jpfau@apple.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

Test: fast/html/pending-stylesheet-crash.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::removedFromDocument):

LayoutTests: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

  • fast/html/pending-stylesheet-crash-expected.txt: Added.
  • fast/html/pending-stylesheet-crash.html: Added.
12:50 PM Changeset in webkit [113228] by jonlee@apple.com
  • 21 edits
    4 adds in trunk/LayoutTests

Unskip Mac filter pixel tests which changed because of color space adjustment
https://bugs.webkit.org/show_bug.cgi?id=80630

Unreviewed.

  • platform/mac/test_expectations.txt: Unskip tests now that patch for b80571 landed.
  • platform/wk2/Skipped: Unskip same tests.

These were rebaselined with color correction. Between WK1 and WK2, however, they still fail
the pixel hash, and completely fail if tolerance is set to 0. https://bugs.webkit.org/show_bug.cgi?id=83187

  • css3/filters/add-filter-rendering-expected.png:
  • css3/filters/crash-filter-change-expected.png:
  • css3/filters/effect-blur-expected.png:
  • css3/filters/effect-brightness-expected.png:
  • css3/filters/effect-combined-expected.png:
  • css3/filters/effect-contrast-expected.png:
  • css3/filters/effect-drop-shadow-expected.png:
  • css3/filters/effect-grayscale-expected.png:
  • css3/filters/effect-hue-rotate-expected.png:
  • css3/filters/effect-invert-expected.png:
  • css3/filters/effect-opacity-expected.png:
  • css3/filters/effect-saturate-expected.png:
  • css3/filters/effect-sepia-expected.png:
  • css3/filters/filter-repaint-expected.png:
  • css3/filters/filter-with-transform-expected.png:
  • css3/filters/nested-filter-expected.png:
  • css3/filters/regions-expanding-expected.png:
  • css3/filters/simple-filter-rendering-expected.png:

These tests fail between WK1 and WK2 because of a difference in the blur. https://bugs.webkit.org/show_bug.cgi?id=83188

  • platform/mac-wk2/css3/filters/effect-blur-expected.png: Added.
  • platform/mac-wk2/css3/filters/effect-combined-expected.png: Added.
  • platform/mac-wk2/css3/filters/effect-opacity-expected.png: Added.
  • platform/mac-wk2/css3/filters/regions-expanding-expected.png: Added.
12:46 PM Changeset in webkit [113227] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Call histogramCustomCounts directly
https://bugs.webkit.org/show_bug.cgi?id=83112

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/painting/PaintAggregator.cpp:
12:35 PM Changeset in webkit [113226] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark fast/writing-mode/relative-positioning-percentages.html as crashing on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=83185

  • platform/chromium/test_expectations.txt: Marked as crashing.
12:33 PM Changeset in webkit [113225] by alexis.menard@openbossa.org
  • 19 edits in trunk/Source

Source/WebCore: Animation related classes should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

Split the concept of animate none and animate all into a separate function rather than using the property member
with some magic value set on it. Make also sure that we use CSSPropertyID all over the place rather than integers.
We still have some place where convert from int to CSSPropertyID (mostly due to the fact that we need to make Hash*
related classes to handle CSSPropertyID). While refactoring I also removed some dead code.

No new tests : not behaviour changes intented.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • page/animation/AnimationBase.cpp:

(WebCore):
(WebCore::PropertyWrapperBase::PropertyWrapperBase):
(WebCore::PropertyWrapperBase::property):
(PropertyWrapperBase):
(WebCore::PropertyWrapperGetter::PropertyWrapperGetter):
(WebCore::PropertyWrapper::PropertyWrapper):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::wrapperForProperty):
(WebCore::AnimationBase::propertiesEqual):
The code removed here could never be reached. propertiesEqual is used only in CompositeAnimation::updateTransitions and through
ImplicitAnimation::isTargetPropertyEqual which is also called in CompositeAnimation. Both calls are protected by an ASSERT in
CompositeAnimation:116 where we make sure the property id we're dealing with is a valid property id, therefore prop can't be equal to
the old value cAnimateAll or even the new mode concept introduced in that patch can't be AnimateAll.
(WebCore::AnimationBase::getPropertyAtIndex):
(WebCore::AnimationBase::blendProperties):
(WebCore::AnimationBase::animationOfPropertyIsAccelerated):
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):

  • page/animation/AnimationBase.h:

(AnimationBase):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):

  • page/animation/CompositeAnimation.h:

(CompositeAnimation):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
The check removed is useless as ImplicitAnimation constructor ensure via an ASSERT that the animatingProperty value is a correct and valid
property id. Even the old code was ensuring the value of animatingProperty was different from cAnimateAll at construction time. As stated also
in CompositeAnimation::updateTransitions and cover by the same ASSERT explained earlier, ImplicitAnimation are constructed for valid property ids.
(WebCore::ImplicitAnimation::isTargetPropertyEqual):
(WebCore::ImplicitAnimation::blendPropertyValueInStyle):

  • page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):
(ImplicitAnimation):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::timeToNextService):

  • platform/animation/Animation.cpp:

(WebCore::Animation::Animation):
(WebCore::Animation::operator=):
(WebCore::Animation::animationsMatch):

  • platform/animation/Animation.h:

(WebCore::Animation::property):
(WebCore::Animation::animationMode):
(WebCore::Animation::setProperty):
(WebCore::Animation::setAnimationMode):
(Animation):
(WebCore::Animation::initialAnimationProperty):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startTransition):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::transitionForProperty):

  • rendering/style/RenderStyle.h:

Source/WebKit2: Animation related classes should use CSSPropertyId rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

The property of the Animation is a CSSPropertyID. It's ok to cast it here as an int for IPC transmission.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:11 PM Changeset in webkit [113224] by rakuco@webkit.org
  • 9 edits in trunk

[EFL][DRT] Catch the "resource,request,willsend" signal
https://bugs.webkit.org/show_bug.cgi?id=82192

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-04
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

EFL's FrameLoaderClient now emits the "resource,request,willsend"
signal on the view for all resources about to be loaded, not just the
main frame. Also adds a boolean flag to Ewk_Frame_Resource_Request to
distinguish the request for the main frame from those for
sub-resources.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

  • ewk/ewk_frame.h:
  • ewk/ewk_view.h:

Tools:

EFL's DumpRenderTree now catches the "resource,request,willsend"
signal in order to implement the "Blocked access to external URL"
behavior and avoid potential network-related timeouts in the tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip related test cases now that EFL's DumpRenderTree
catches the "resource,request,willsend" signal and implements the
"Blocked access to external URL" behavior.

  • platform/efl/Skipped:
12:10 PM Changeset in webkit [113223] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix usage of LayoutUnits and snapping for scrolling in RenderBox
https://bugs.webkit.org/show_bug.cgi?id=83073

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and snapping/rounding logic in RenderBox.

No new tests, no change in functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change scrollWidth to properly pixel snap values.

(WebCore::RenderBox::scrollHeight):
Change scrollHeight to properly pixel snap values.

(WebCore::RenderBox::scrolledContentOffset):
Change to return IntSize to match function definition.

(WebCore::RenderBox::cachedSizeForOverflowClip):
Changed cachedSizeForOverflowClip to LayoutSize as the overflow and clip
rects all have subpixel precision.

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
Removed FIXME comment as the implementation

(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
Added static_cast for border values.

(WebCore::RenderBox::hasVisualOverflow):
Changed to compare two pixel snapped values as we don't want to indicate
overflow in cases where the the size is rounded down resulting in no
visual overflow.

12:04 PM Changeset in webkit [113222] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

Fix types for location, size and rect calculations for render objects
https://bugs.webkit.org/show_bug.cgi?id=83089

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding for a couple of different render
object classes.

No new tests, no change in functionality.

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::getPath):
Change getPath to take a LayoutPoint as the transform has subpixel
precision already.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):
Change logicalHeight to LayoutUnit as it is computed from subpixel
values.

  • rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
Change button rect computation to LayoutRect and pixel snap just before
painting to preserve precision.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
Change range calculations to LayoutUnits to preserve precision.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Change width calculations to LayoutUnits to preserve precision.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layoutCaption):
Change table captions to LayoutUnits as the values are computed from
subpixel componenets.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor):
Snap border rect as RoundedRects use ints for crisp rendering.

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):
Change adjustRectForShadow to take a LayoutRect as it already uses
LayoutUnits.

11:54 AM Changeset in webkit [113221] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Convert RootInlineBox to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=83054

Reviewed by Eric Seidel.

Convert RootInlineBox over to LayoutUnits, this mostly involves updating
the alignment and adjustment code to be subpixel aware.

No new tests, no change in functionality.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Change beforeAnnotationsAdjustment to LayoutUnit.

(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
Change method to return LayoutUnit as it is computed from values with
subpixel precision.

(WebCore::RootInlineBox::lineSnapAdjustment):
Round values before computing remainder.

(WebCore::RootInlineBox::ascentAndDescentForBox):
Change ascent and decent calculation to use LayoutUnits as they are
computed from values with subpixel precision.

(WebCore::RootInlineBox::verticalPositionForBox):
Change verticalPosition to LayoutUnit.

  • rendering/RootInlineBox.h:

(RootInlineBox):

11:42 AM Changeset in webkit [113220] by Joseph Pecoraro
  • 6 edits in trunk

<http://webkit.org/b/83108> Web Inspector: JSC Crash inspecting node with object event listener

Reviewed by Geoff Garen.

Source/WebCore:

  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):
Use jsDynamicCast to bail when the JSObject is not a JSFunction.

LayoutTests:

  • inspector/elements/event-listener-sidebar.html:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:

Add an EventListener that uses an object listener instead of a function.

11:18 AM Changeset in webkit [113219] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Call suddenTerminationChanged directly
https://bugs.webkit.org/show_bug.cgi?id=83114

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/SuddenTerminationChromium.cpp:

(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

11:14 AM Changeset in webkit [113218] by abarth@webkit.org
  • 8 edits in trunk/Source

figure out how to export webcore symbols from webkit.dll properly
https://bugs.webkit.org/show_bug.cgi?id=83105

Reviewed by Dimitri Glazkov.

Source/Platform:

Unwind our ugly, ugly hack to make the Windows component build work.

  • chromium/public/WebMediaStreamSourcesRequest.h:

(WebMediaStreamSourcesRequest):

Source/WebCore:

  • WebCore.gypi:
    • Separate the platform support files into a new GYP variable so that they can be build as part of webkit.dll rather than in webcore_platform.lib. Building them as part of webkit.dll ensure that the symbols marked for export will actually be in webkit.dll (and hence exported), even if nothing else in webkit.dll references the obj file that contains the symbol.
  • platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
    • Unwind our ugly, ugly hack to make the Windows component build work.

Source/WebKit/chromium:

  • WebKit.gyp:
    • We now compile the platform support files as part of webkit.dll to make sure the lib contains the obj files and therefore exports the necessary symbols. In principle, we could use a defs file to achieve the same thing, but those files are a pain to maintain.
  • src/WebKit.cpp:

(WebKit::shutdown):

  • Unwind our ugly, ugly hack to make the Windows component build work.
11:12 AM Changeset in webkit [113217] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Call sandboxEnabled directly
https://bugs.webkit.org/show_bug.cgi?id=83113

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

11:07 AM Changeset in webkit [113216] by Patrick Gansterer
  • 2 edits in trunk/Tools

[EFL][DRT] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83168

Reviewed by Eric Seidel.

Modify the #include declarations so that the
wtf types are included using the full path.

  • DumpRenderTree/efl/DumpRenderTree.cpp:
11:07 AM Changeset in webkit [113215] by kareng@chromium.org
  • 1 edit
    2 copies in branches/chromium/1084

Merge 113139 - Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

TBR=macpherson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981010

10:50 AM Changeset in webkit [113214] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=83183

  • platform/chromium/test_expectations.txt: Registered flakes.
10:43 AM Changeset in webkit [113213] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch IndexedDB, DOMStorage, ApplicationCache domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83039

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-04
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of array specialization is added. Inspector.json is fixed to comform
with actual behavior of InspectorDOMStorageAgent.

Output parameter initialization is assured.

  • inspector/CodeGeneratorInspector.py:
  • inspector/Inspector.json:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):

  • inspector/InspectorApplicationCacheAgent.h:

(InspectorApplicationCacheAgent):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):

  • inspector/InspectorDOMStorageAgent.h:

(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::bind):

10:38 AM Changeset in webkit [113212] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Add another kind of flaky to fast/replaced/border-radius-clip.html

  • platform/chromium/test_expectations.txt: Flakes registered.
10:31 AM Changeset in webkit [113211] by fischman@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test media/video-beforeload-remove-source.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=82260

Reviewed by Eric Carlson.

Moved the beforeload listener to <head> to ensure it is registered before the
load actually happens. Before this change, the test failed (timed out) 2/1000 runs,
after the change it had no failures in 5000 runs.

  • media/video-beforeload-remove-source.html:
  • platform/chromium/test_expectations.txt:
10:29 AM Changeset in webkit [113210] by Philippe Normand
  • 2 edits in trunk/Tools

gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(test_get_crash_log): Skip the test on non-linux platforms.

10:17 AM Changeset in webkit [113209] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r113141): All tests assert on 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=83139

Reviewed by Sam Weinig.

  • heap/PassWeak.h:

(JSC::::get): 32-bit JSValue treats JSValue(nullptr).asCell() as an error,
so work around that here. (Long-term, we should make 32-bit and 64-bit
agree on the right behavior.)

10:13 AM Changeset in webkit [113208] by tony@chromium.org
  • 17 edits
    5 deletes in trunk

Remove flex function css parsing
https://bugs.webkit.org/show_bug.cgi?id=83083

Reviewed by Ojan Vafai.

Source/WebCore:

The flexbox spec switched from using a flex() function on the width
and height to a css property. Now that the -webkit-flex: has been
implemented, we can remove the flex() function code.

No new tests. Removing an old test that used to test the flex() function.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSFlexValue.cpp: Removed.
  • css/CSSFlexValue.h: Removed.
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSParser.h:

(WebCore):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Remove test of -webkit-flex() function.

  • css3/flexbox/flex-parsing-expected.txt: Removed.
  • css3/flexbox/flex-parsing.html: Removed.
  • css3/flexbox/script-tests/flex-parsing.js: Removed.
10:09 AM Changeset in webkit [113207] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
10:06 AM Changeset in webkit [113206] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for fast/canvas/canvas-overloads-strokeText.html

  • platform/chromium/test_expectations.txt: Tweaked.
10:03 AM Changeset in webkit [113205] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Marked http/tests/websocket/tests/hybi/workers/worker-reload.html as flaky fail.
https://bugs.webkit.org/show_bug.cgi?id=83173

  • platform/chromium/test_expectations.txt: Added expectations.
10:03 AM Changeset in webkit [113204] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[Coverity] Address some uninit constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82424

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-04-04
Reviewed by Stephen White.

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

Source/WebCore:

  • Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::Gamepad):

  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • html/canvas/WebGLContextObject.h:

(WebGLContextObject):

  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

Source/WebKit/chromium:

  • src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):

  • src/LocalFileSystemChromium.cpp:

(WebCore):

Source/WTF:

  • wtf/ArrayBufferView.cpp:

(WTF::ArrayBufferView::ArrayBufferView):

9:59 AM Changeset in webkit [113203] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
https://bugs.webkit.org/show_bug.cgi?id=83085

Reviewed by Antonio Gomes.

PR 121109

This way when we add something to the enum and forget to add to the switch we'll get a compile error.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

9:38 AM Changeset in webkit [113202] by loislo@chromium.org
  • 1 edit
    3 moves in trunk/PerformanceTests

Web Inspector: Unreviewed. temporary disable broken inspector tests.

  • inspector/first-open-scripts.html.broken: Renamed from PerformanceTests/inspector/first-open-scripts.html.
  • inspector/network-append-30-requests.html.broken: Renamed from PerformanceTests/inspector/network-append-30-requests.html.
  • inspector/show-panel.html.broken: Renamed from PerformanceTests/inspector/show-panel.html.
9:31 AM Changeset in webkit [113201] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, temporary dirty hack to make Win Debug work again.

  • All.gyp: Temporarily removed TestWebKitAPI target.
9:16 AM Changeset in webkit [113200] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

  • platform/gtk/test_expectations.txt:
9:10 AM Changeset in webkit [113199] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: expose savedURL, setToolbarColors and toggleSearchingForNode in InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=83170

Reviewed by Yury Semikhatsky.

Chromium port is calling these from the embedder layer and they all are perfect candidates
for the InspectorFrontendAPI. Adding them there.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):
(InspectorFrontendAPI.savedURL):
(InspectorFrontendAPI.setToolbarColors):

9:03 AM Changeset in webkit [113198] by rakuco@webkit.org
  • 7 edits in trunk

[EFL] DRT support for computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=82190

Source/WebKit/efl:

Add missing implementation computedStyleIncludingVisitedInfo to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::computedStyleIncludingVisitedInfo):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
LayoutTestController so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip tests connected with computedStyleIncludingVisitedInfo().

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
9:01 AM Changeset in webkit [113197] by bbudge@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebKit/chromium/src/AssociatedURLLoader.cpp

Merge 112485 - AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981003

8:54 AM Changeset in webkit [113196] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

A couple more cleanups to LayoutUnits in RenderInputSpeech::paintInputFieldSpeechButton.

8:52 AM Changeset in webkit [113195] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Entire page highlighted on panning.
https://bugs.webkit.org/show_bug.cgi?id=83158

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

8:49 AM Changeset in webkit [113194] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: linearise aggregate's retaining size calculation.
https://bugs.webkit.org/show_bug.cgi?id=83125

This version is twice as fast as the original and it is non-recursive.

Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._getDominatedIndex): was moved closer to it's usage
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize): it was _buildAggregates' inner function forDominatedNodes.
it was:
a) extracted from _buildAggregates;
b) made non-recursive;
c) many getters were inlined;
d) subarray of dominating nodes were inlined too.
(WebInspector.HeapSnapshot.prototype._buildAggregates): many getters were inlined.
(WebInspector.HeapSnapshot.prototype.aggregates):

8:42 AM Changeset in webkit [113193] by commit-queue@webkit.org
  • 5 edits in trunk

Source/WebCore: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Do not return non-clickable nodes as a best clickable node.

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):

LayoutTests: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

  • touchadjustment/touch-inlines-expected.txt:
  • touchadjustment/touch-inlines.html:
8:40 AM Changeset in webkit [113192] by pfeldman@chromium.org
  • 22 edits in trunk

Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save.
https://bugs.webkit.org/show_bug.cgi?id=83162

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change adds Save item into the context menus for inspector. It also makes
saveAs parameter optional in the InspectorFrontendHost.save so that we could
skip the dialog for the paths that were already saved. Embedder tells the front-end
what urls were successfully saved so that front-end could issue subsequent save commands
for those files.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSave):
(WebCore::InspectorFrontendClientLocal::save):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSave):
(WebCore::InspectorFrontendHost::save):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canSave):

  • inspector/front-end/JavaScriptSourceFrame.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

  • inspector/front-end/ResourceView.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.save):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.saveToFile):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canSave):
(WebKit::InspectorFrontendClientImpl::save):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

8:35 AM Changeset in webkit [113191] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

Cleaning up LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton. This method is only called from RenderTheme, so it arrives with an IntRect. We have to be careful to do proper pixel snapping within this method.

8:23 AM Changeset in webkit [113190] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: time dividers are incorrectly rendered on empty timeline grid
https://bugs.webkit.org/show_bug.cgi?id=83165

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkBaseCalculator.prototype.setDisplayWindow):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

8:15 AM Changeset in webkit [113189] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] ASSERT in SocketStreamHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=83123

Reviewed by Martin Robinson.

Do not try to reuse a GOwnPtr as calling outPtr() causes an
assertion if the pointer is already valid. Also do not try to
close the IOStream if it was not created.

This patch fixes
http/tests/websocket/tests/hybi/workers/worker-reload.html but I
am leaving it skipped until webkit.org/b/83124 is fixed.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::connectedCallback):

8:05 AM Changeset in webkit [113188] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to try to paint ARM and Mac bots green.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
7:26 AM Changeset in webkit [113187] by alexis.menard@openbossa.org
  • 7 edits in trunk/Source/WebCore

Re-add variable names in CSS related headers to help understanding the meaning of them.
https://bugs.webkit.org/show_bug.cgi?id=83151

Reviewed by Andreas Kling.

r112952, r113031, r113042 removed variable names in some places but at the end it
was better before as it helps understanding what the variables represent. This patch
address this issue and add back the names where it makes sense.

No new tests : cosmetic changes, no behavior change here.

  • css/CSSParser.h:

(CSSParser):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/StyledElement.h:

(StyledElement):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/Editor.h:

(Editor):

  • html/HTMLElement.h:

(HTMLElement):

7:11 AM Changeset in webkit [113186] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Unreviewed; update my email address once again in the committers
and watch list.

  • Scripts/webkitpy/common/config/committers.py: Prefer my

webkit.org email over my FreeBSD.org one.

  • Scripts/webkitpy/common/config/watchlist: Ditto.
7:06 AM Changeset in webkit [113185] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Layout Test fast/canvas/canvas-toDataURL-webp.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=81735

Test expectations update. Fixed in http://crrev.com/129144.

  • platform/chromium/test_expectations.txt:
6:52 AM Changeset in webkit [113184] by Nikolas Zimmermann
  • 33 edits in trunk

Implement animatedPathSegList support for SVGPathElement
https://bugs.webkit.org/show_bug.cgi?id=83140

Reviewed by Zoltan Herczeg.

Source/WebCore:

Add the last missing piece of animVal support: animations of the SVGPathElement's 'd' attribute
should be reflected in the 'animatedPathSegList' not the 'pathSegList'.

The SVGAnimatedPathAnimator is special as it doesn't operate on the SVGPathSegList types
directly, but on the SVGPathByteStreams for performance reasons. The SVGPathSegLists
are refcounted and exposed to JS, thus require lots of memory, compared to a simple
byte stream, which SVGPathByteStream is. Only build an 'animatedPathSegList' while
animating if its actually observed by the bindings, as this operation is heavy.

This marks the finish of the animVal patch series: no more string round trips during
animation. Previously paths were animated as byte streams, then converted to a String
passed to pathElement->setAttribute("d", "newString"), parsed again to a byte stream, etc.

A follow-up patch will remove the last crufts of direct setAttribute() animation.

Extend all existing animated SVGPathElement tests to cover animatedPathSegList.

  • svg/SVGAnimatedColor.h:

(WebCore::SVGAnimatedColorAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedColorAnimator::animValWillChange):
(WebCore::SVGAnimatedColorAnimator::animValDidChange):
(SVGAnimatedColorAnimator):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedPathAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::animValWillChange):
(WebCore::SVGAnimatedPathAnimator::animValDidChange):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPath.h:

(SVGAnimatedPathAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::animatedPathSegList):
(WebCore::SVGPathElement::pathSegListChanged):

  • svg/SVGPathElement.h:

(WebCore):
(SVGPathElement):
(WebCore::SVGPathElement::isAnimValObserved):

  • svg/SVGPathParserFactory.cpp:

(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
(WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):

  • svg/SVGPathParserFactory.h:

(SVGPathParserFactory):

  • svg/SVGPathSegWithContext.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animatedPathByteStream):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::SVGListProperty):
(WebCore::SVGListProperty::~SVGListProperty):
(SVGListProperty):

LayoutTests:

Update all tests animating the SVGPathElement's 'd' attribute to verify 'animatedPathSegList' now gets animated, not 'pathSegList'.

  • svg/animations/animate-path-animation-Cc-Ss-expected.txt:
  • svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
  • svg/animations/animate-path-animation-Qq-Tt-expected.txt:
  • svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
  • svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
  • svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt:
  • svg/animations/animate-path-to-animation-expected.txt:
  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-path-to-animation.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgpath-animation-1.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgtransform-animation-1.js:
  • svg/animations/svgpath-animation-1-expected.txt:
6:35 AM Changeset in webkit [113183] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] QtWebKit2 should support Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=81164

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Implementing the last bits needed for getting the expected
behavior for Page Visibility API, according to its spec.
The only missing part in Qt was a way to check whether
the view was exposed or not.

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewVisible):

Tools:

Enabling Page Visiblity API for Qt WebKit2.

  • qmake/mkspecs/features/features.prf:
6:20 AM Changeset in webkit [113182] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

  • platform/gtk/test_expectations.txt:
6:10 AM Changeset in webkit [113181] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=81154

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Use WebPageProxy::viewStateDidChange to correctly define the page's
visibilityState and then set it to the WebProcess. The WebKit2's based
ports just need to implement the related PageClient functions in order
to get this API enabled and working properly.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::viewStateDidChange):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::setVisibilityState):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
6:04 AM Changeset in webkit [113180] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Cleaning jp RenderView changes. Reverting the print rect to an IntRect, and cleaning up a FIXME with hardcoded offsets.

5:47 AM Changeset in webkit [113179] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Best zoomable area does not balance intersection with target area.
https://bugs.webkit.org/show_bug.cgi?id=83148

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Change the two step sort to simply picking the best quotient of touch intersection with target area.

Test: touchadjustment/zoom-fatfinger.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::distanceSquaredToTargetCenterLine):
(TouchAdjustment):
(WebCore::TouchAdjustment::zoomableIntersectionQuotient):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):
(WebCore::findBestZoomableArea):

LayoutTests:

  • touchadjustment/zoom-fatfinger-expected.txt: Added.
  • touchadjustment/zoom-fatfinger.html: Added.
5:43 AM Changeset in webkit [113178] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
https://bugs.webkit.org/show_bug.cgi?id=83020

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-04
Reviewed by Hajime Morita.

Source/WebKit/efl:

Implementing handling of media content type and media documents
in the respective FrameLoaderClientEfl callbacks.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::committedLoad): Cancel loading for media documents.
(WebCore::FrameLoaderClientEfl::canShowMIMEType): Let media content types through.
(WebCore):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError): Returning appropriate error type.
(WebCore::FrameLoaderClientEfl::shouldFallBack): Falling back as well for media handled by media player.

LayoutTests:

  • platform/efl/Skipped: Unskipping those MediaDocument related cases which now pass.
5:41 AM Changeset in webkit [113177] by caseq@chromium.org
  • 8 edits in trunk

Web Inspector: make padding and client window width part of timeline calculator's state
https://bugs.webkit.org/show_bug.cgi?id=83122

Reviewed by Pavel Feldman.

Source/WebCore:

  • preserve window width and padding within TimelineCalculator
  • rely on calculator to add expansion arrow padding
  • add TimelineCalculator::computePosition() for computing single position (not entire bar dimensions)
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkBaseCalculator.prototype.computePosition):
(WebInspector.NetworkBaseCalculator.prototype.formatTime):
(WebInspector.NetworkBaseCalculator.prototype.setDisplayWindow):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDividers):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewCalculator.prototype.computePosition):
(WebInspector.TimelineOverviewCalculator.prototype.setDisplayWindow):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

LayoutTests:

  • re-enable 4 injspector tests skipped after previous landing attempt.
  • platform/gtk/Skipped:
5:34 AM Changeset in webkit [113176] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

WebSpeechRecognizer.h: add missing forward declaration
https://bugs.webkit.org/show_bug.cgi?id=83150

Reviewed by Tony Gentilcore.

Add missing forward declaration of WebSpeechRecognitionParams.

  • public/WebSpeechRecognizer.h:

(WebKit):

5:32 AM Changeset in webkit [113175] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Further improvements of the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=83149

Reviewed by Zoltan Herczeg.

Ignore single tap while finger is still pressed.
Some renaming to make the states more clear.
A pan further than the maxPanDistance can now invalidate
double-taps as well.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

  • UIProcess/qt/QtTapGestureRecognizer.h:
5:31 AM Changeset in webkit [113174] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[FileSystem] Forward declare File in FileCallback.h
https://bugs.webkit.org/show_bug.cgi?id=83128

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • Modules/filesystem/FileCallback.h: forward declare File class to make

#include of "File.h" redundant.
(WebCore):

5:24 AM Changeset in webkit [113173] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
https://bugs.webkit.org/show_bug.cgi?id=82438

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.

The purpose of ewk_settings_icon_database_icon_object_add is to get icon
for the given URL. This function doesn't add anything to database.
Documentation and API name are adjusted.

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_object_get):

  • ewk/ewk_settings.h:
5:21 AM Changeset in webkit [113172] by abecsi@webkit.org
  • 20 edits
    2 deletes in trunk

[Qt][WK2] Make the WebView a subclass of Flickable
https://bugs.webkit.org/show_bug.cgi?id=83033

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Add needed dependency to quick-private for projects that include the WebView header.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:

Source/WebKit2:

Hitherto, the experiment of a QML WebView with an internal Flickable
instance showed that the approach of hiding the Flickable raises more
problems than it solves.

One set of problems arose because the internal Flickable was a separate
item which received and reacted on automatically synthesized mouse events
send by the canvas, this interfered with the gesture recognizers of the
WebView.

Other issues were related to orientation and the integration of the
WebView item with other QML items and components (like scroll indicators)
which require a larger set of the Flickable API or the Flickable object
itself (e.g. ScrollDecorator).

These disadvantages of an internal Flickable instance outweigh the
benefits of controlling the exposed API, therefore the experiment had
the conclusion that there is no way around the public inheritance from
QQuickFlickable.

This patch removes the QtFlickProvider class, inherits QQuickWebView
from QQuickFlickable and adjusts the viewport interaction engine and
the gesture recognizers to use the Flickable API of the WebView to
keep the same behaviour as before.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::useDefaultContentItemSize):
(QQuickWebViewExperimental::setUseDefaultContentItemSize):
(QQuickWebView::QQuickWebView):
(QQuickWebView::inputMethodQuery):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):
(QQuickWebView::event):
(QQuickWebView::contentPos):
(QQuickWebView::setContentPos):
(QQuickWebView::handlePress):
(QQuickWebView::handleMove):
(QQuickWebView::handleRelease):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/qt/QtFlickProvider.cpp: Removed.
  • UIProcess/qt/QtFlickProvider.h: Removed.
  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::flickableMoveStarted):
(WebKit::QtViewportInteractionEngine::flickableMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::doneWithTouchEvent):

Tools:

Remove workaround in MiniBrowser and the ScrollIndicator
now that the WebView is a Flickable.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ScrollIndicator.qml:
  • WebKitTestRunner/Target.pri:
5:19 AM Changeset in webkit [113171] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

REGRESSION(r113144): It made run-webkit-tests always fail
https://bugs.webkit.org/show_bug.cgi?id=83142

Unreviewed trivial fix after r113144.

  • Scripts/run-webkit-tests:
5:01 AM Changeset in webkit [113170] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Unable to zoom to some areas.
https://bugs.webkit.org/show_bug.cgi?id=83144

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Remember to convert touch-area to touch-point radius.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

4:52 AM Changeset in webkit [113169] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r113156.
http://trac.webkit.org/changeset/113156
https://bugs.webkit.org/show_bug.cgi?id=83146

Breaks inspector layout tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-04

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDividers):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._reset):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timelinePaddingLeft):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

4:37 AM Changeset in webkit [113168] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=83057
New test flakey on Qt Linux Release introduced in r113086

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-04

  • platform/qt/Skipped: fast/dom/inline-event-attributes-release.html
4:19 AM Changeset in webkit [113167] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: front-end should accept raw web socket address for the remote connection.
https://bugs.webkit.org/show_bug.cgi?id=83134

Reviewed by Yury Semikhatsky.

Migrated from the /devtools/page web socket schema to the generic one where remote target address
can be specified as index.html?ws=localhost:9222/page1. Left the old host/page way for backwards
compatibility.

  • inspector/front-end/inspector.js:
4:06 AM Changeset in webkit [113166] by tkent@chromium.org
  • 3 edits
    2 adds in trunk/Source/WebCore

Add localization functions for the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=83129

Reviewed by Hajime Morita.

No behavior changes yet.

  • WebCore.gypi: Add LocalizedCalendar.h and LocalizedCalendarICU.cpp.
  • platform/LocalizedStrings.h: Add calendarTodayText() and calendarClearText().
  • platform/text/LocalizedCalendar.h:

Added. This provides monthLabels(), weekDayShortLabels(), and firstDayOfWeek().

  • platform/text/LocalizedCalendarICU.cpp: Added. ICU implementations of the above functions.

(WebCore::ScopedDateFormat): A wrapper for UDateFormat*.
(WebCore::ScopedDateFormat::ScopedDateFormat):
(WebCore::ScopedDateFormat::~ScopedDateFormat):
(WebCore::ScopedDateFormat::get):
(createFallbackMonthLabels): Creates fallback month labels in English.
(createLabelVector):
A helper for createMonthLabels() and createWeekDayShortLabels().
(createMonthLabels):
Creates month labels using createLabelVector() or createFallbackMonthLabels().
(WebCore::monthLabels):
(createFallbackWeekDayShortLabels): Creates fallback week labels in English.
(createWeekDayShortLabels):
Creates month labels using createLabelVector() or createFallbackWeekDayShortLabels().
(WebCore::weekDayShortLabels):
(getFirstDayOfWeek):
(WebCore::firstDayOfWeek):

4:00 AM Changeset in webkit [113165] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Improve the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=83135

Reviewed by Simon Hausmann.

Clean up the code and make sure that the first single tap
event, as part of a double tap gesture, is ignored.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

  • UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

3:56 AM Changeset in webkit [113164] by hans@chromium.org
  • 11 edits
    7 copies
    4 adds in trunk/Source

Speech JavaScript API: Plumbing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=81667

Reviewed by Darin Fisher.

Source/WebCore:

SpeechGrammar::src() is called with a ScriptExecutionContext, because
the attribute setter needs it. Provide a src() method that doesn't
take a ScriptExecutionContext that can be used internally.

Rename SpeechRecognition::audioStartCallback(), etc. to use event style
names, i.e. didStartAudio(), etc.

Remove SpeechRecognitionClient::notifyVisibilityHidden(). The embedder
can keep track of the visibility.

Remove SpeechRecognitionClient::unregisterSpeechRecognition,
it is not needed.

No new tests, just minor tweaks.

  • Modules/speech/SpeechGrammar.h:

(WebCore::SpeechGrammar::src):

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didStartAudio):
(WebCore::SpeechRecognition::didStartSound):
(WebCore::SpeechRecognition::didStartSpeech):
(WebCore::SpeechRecognition::didEndSpeech):
(WebCore::SpeechRecognition::didEndSound):
(WebCore):
(WebCore::SpeechRecognition::didEndAudio):
(WebCore::SpeechRecognition::didReceiveResult):
(WebCore::SpeechRecognition::didReceiveNoMatch):
(WebCore::SpeechRecognition::didDeleteResult):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didStart):
(WebCore::SpeechRecognition::didEnd):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.h:

Source/WebKit/chromium:

Add plumbing for speech recognition.

The implementer is expected to implement the WebSpeechRecognizer interface.
The start(), stop(), and abort() functions of that interface take a
WebSpeechRecognitionHandle argument, which identifies the object which has
requested the action, and a pointer to a WebSpeechRecognitionClient interface,
through which it should send back notifications on progress, errors, etc.

SpeechRecognitionClientProxy passes data between the WebCore and WebKit layers,
implementing the WebCore::SpeechRecognitionClient and WebKit::WebSpeechRecognizerClient
interfaces.

  • WebKit.gyp:
  • public/WebSpeechGrammar.h:

(WebCore):
(WebKit):
(WebSpeechGrammar):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::~WebSpeechGrammar):

  • public/WebSpeechRecognitionHandle.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::~WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::operator==):
(WebKit::operator!=):
(WebKit::operator<):

  • public/WebSpeechRecognitionParams.h:

(WebKit):
(WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::grammars):
(WebKit::WebSpeechRecognitionParams::language):
(WebKit::WebSpeechRecognitionParams::continuous):

  • public/WebSpeechRecognitionResult.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::~WebSpeechRecognitionResult):

  • public/WebSpeechRecognizer.h:

(WebKit):
(WebSpeechRecognizer):
(WebKit::WebSpeechRecognizer::start):
(WebKit::WebSpeechRecognizer::stop):
(WebKit::WebSpeechRecognizer::abort):
(WebKit::WebSpeechRecognizer::~WebSpeechRecognizer):

  • public/WebSpeechRecognizerClient.h: Added.

(WebKit):
(WebSpeechRecognizerClient):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::speechRecognizer):

  • src/SpeechRecognitionClientProxy.cpp: Added.

(WebKit):
(WebKit::SpeechRecognitionClientProxy::~SpeechRecognitionClientProxy):
(WebKit::SpeechRecognitionClientProxy::create):
(WebKit::SpeechRecognitionClientProxy::start):
(WebKit::SpeechRecognitionClientProxy::stop):
(WebKit::SpeechRecognitionClientProxy::abort):
(WebKit::SpeechRecognitionClientProxy::didStartAudio):
(WebKit::SpeechRecognitionClientProxy::didStartSound):
(WebKit::SpeechRecognitionClientProxy::didStartSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSound):
(WebKit::SpeechRecognitionClientProxy::didEndAudio):
(WebKit::SpeechRecognitionClientProxy::didReceiveResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveNoMatch):
(WebKit::SpeechRecognitionClientProxy::didDeleteResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveError):
(WebKit::SpeechRecognitionClientProxy::didStart):
(WebKit::SpeechRecognitionClientProxy::didEnd):
(WebKit::SpeechRecognitionClientProxy::SpeechRecognitionClientProxy):

  • src/SpeechRecognitionClientProxy.h: Added.

(WebKit):
(SpeechRecognitionClientProxy):

  • src/WebSpeechGrammar.cpp: Added.

(WebKit):
(WebKit::WebSpeechGrammar::reset):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::operator=):
(WebKit::WebSpeechGrammar::src):
(WebKit::WebSpeechGrammar::weight):

  • src/WebSpeechRecognitionHandle.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionHandle::reset):
(WebKit::WebSpeechRecognitionHandle::assign):
(WebKit::WebSpeechRecognitionHandle::equals):
(WebKit::WebSpeechRecognitionHandle::lessThan):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::WebSpeechRecognitionHandle::operator PassRefPtr<SpeechRecognition>):

  • src/WebSpeechRecognitionParams.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):

  • src/WebSpeechRecognitionResult.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionResult::assign):
(WebKit::WebSpeechRecognitionResult::reset):
(WebKit::WebSpeechRecognitionResult::operator PassRefPtr<WebCore::SpeechRecognitionResult>):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

3:47 AM Changeset in webkit [113163] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

  • platform/gtk/test_expectations.txt:
3:37 AM Changeset in webkit [113162] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch baseline values to LayoutUnits in RenderTableSection.
https://bugs.webkit.org/show_bug.cgi?id=83017

Reviewed by Julien Chaffraix.

We initially intend to keep table layout on integers post switching the render tree to primarily
use sub-pixel precision. Baseline positions switch to sub-pixel units, and in table layout code are
combined with padding (also sub-pixel), which means we ideally won't truncate their values until
after they're added together. Converting baseline values in RenderTableSection to LayoutUnits.

No new tests. No change in behavior.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTableSection.h:

(RowStruct):

3:29 AM Changeset in webkit [113161] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Scrolling doesn't work in WebKit2 since r110185
https://bugs.webkit.org/show_bug.cgi?id=81779

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-04
Reviewed by James Robinson.

Bring back functionality of the ScrollAnimatorNone for ports that
use a fallback timer for animation frames.

No new tests - only restoring previous functionality.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::startNextTimer):
(WebCore::ScrollAnimatorNone::animationTimerActive):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

3:27 AM Changeset in webkit [113160] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
3:26 AM Changeset in webkit [113159] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Coalesce extra pixel snapping in getRoundedBorderFor into a local variable, remove LayoutUnit flavors of adjustForAsboluteZoom, and use pixel snapped values throughout Element's DOM accessors.

3:13 AM Changeset in webkit [113158] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new _crashing_ test and unskip a non-existing test.

  • platform/qt/Skipped:
  • platform/qt/fast/forms/label/labelable-elements-expected.txt: Added after r113148 and r113137.
2:36 AM Changeset in webkit [113157] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and Database domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=82958

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-02
Reviewed by Yury Semikhatsky.

Client code is switched to typed API (all InspectorObject and InspectorArray types are replaced with
generated types from TypeBuilder according to Inspector.json).

Missing array of InspectorValues specialization is added.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::inspectImpl):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspect):

  • inspector/InspectorAgent.h:

(InspectorAgent):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

  • inspector/InspectorDatabaseResource.cpp:

(WebCore::InspectorDatabaseResource::bind):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

2:27 AM Changeset in webkit [113156] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: make padding and client window width part of timeline calculator's state
https://bugs.webkit.org/show_bug.cgi?id=83122

Reviewed by Pavel Feldman.

  • preserve window width and padding within TimelineCalculator
  • rely on calculator to add expansion arrow padding
  • add TimelineCalculator::computePosition() for computing single position (not entire bar dimensions)
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewCalculator.prototype.computePosition):
(WebInspector.TimelineOverviewCalculator.prototype.setDisplayWindow):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

2:18 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add ShowModalDialog (diff)
2:15 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add console message (diff)
2:13 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add Cookies (diff)
2:12 AM Changeset in webkit [113155] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, GTK baseline for test added in r112816.

  • platform/gtk/fast/text/international/text-spliced-font-expected.txt: Added.
2:10 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
2:09 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add target version coloumn (diff)
2:05 AM Changeset in webkit [113154] by pfeldman@chromium.org
  • 21 edits in branches/chromium/1084/Source/WebCore/inspector/front-end

Merge 112992 - Web Inspector: "Pause on start" doesn't change checked state in workers panel
https://bugs.webkit.org/show_bug.cgi?id=82908

Reviewed by Yury Semikhatsky.

This change partially reverts logic that was introduced with r111551:
preventDefault was called beside each stopPropagation. As a result, default checkbox handler was not working.
Event.prototype.consume now receives preventDefault parameter that controls whether default action
should be prevented.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype._onKeyDown):

  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._enterKeyPressed):
(WebInspector.ConsoleGroup.prototype._titleClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):

  • inspector/front-end/Dialog.js:

(WebInspector.Dialog.prototype._onKeyDown):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/Object.js:

(WebInspector.Event.prototype.consume):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onKeyDown):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._discardMenu):

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.draggable.consume):
(WebInspector.Spectrum.prototype._onKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.muteEventListener):
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._handleKeyDown):

  • inspector/front-end/UIUtils.js:

(WebInspector.startEditing):

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.prototype.selectOnMouseDown):

  • inspector/front-end/utilities.js:

(Event.prototype.consume):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9968120

2:01 AM Changeset in webkit [113153] by commit-queue@webkit.org
  • 11 edits
    11 deletes in trunk/Source

Unreviewed, rolling out r113149.
http://trac.webkit.org/changeset/113149
https://bugs.webkit.org/show_bug.cgi?id=83126

for breaking Chromium builders (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-04

Source/WebCore:

  • Modules/speech/SpeechGrammar.h:
  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::audioStartCallback):
(WebCore::SpeechRecognition::soundStartCallback):
(WebCore::SpeechRecognition::speechStartCallback):
(WebCore::SpeechRecognition::speechEndCallback):
(WebCore::SpeechRecognition::audioEndCallback):
(WebCore::SpeechRecognition::resultCallback):
(WebCore::SpeechRecognition::noMatchCallback):
(WebCore::SpeechRecognition::resultDeletedCallback):
(WebCore::SpeechRecognition::errorCallback):
(WebCore::SpeechRecognition::startCallback):
(WebCore::SpeechRecognition::endCallback):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.h:

(WebCore::SpeechRecognitionController::visibilityHidden):
(WebCore::SpeechRecognitionController::unregisterSpeechRecognition):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebSpeechGrammar.h: Removed.
  • public/WebSpeechRecognitionHandle.h: Removed.
  • public/WebSpeechRecognitionParams.h: Removed.
  • public/WebSpeechRecognitionResult.h: Removed.
  • public/WebSpeechRecognizer.h: Removed.
  • public/WebSpeechRecognizerClient.h: Removed.
  • public/WebViewClient.h:

(WebKit):

  • src/SpeechRecognitionClientProxy.cpp: Removed.
  • src/SpeechRecognitionClientProxy.h: Removed.
  • src/WebSpeechGrammar.cpp: Removed.
  • src/WebSpeechRecognitionHandle.cpp: Removed.
  • src/WebSpeechRecognitionResult.cpp: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

1:56 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update (diff)
1:52 AM Changeset in webkit [113152] by pfeldman@chromium.org
  • 1 edit
    15 adds in trunk/LayoutTests

Not reviewed: expectations updated for chromium.

  • platform/chromium-linux/fast/forms/datalist/input-list-expected.png: Added.
  • platform/chromium-linux/fast/forms/datalist/input-selectedoption-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/datalist/input-selectedoption-expected.png: Added.
  • platform/chromium-mac/fast/forms/datalist/input-list-expected.png: Added.
  • platform/chromium-mac/fast/forms/datalist/input-list-expected.txt: Added.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.png: Added.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.txt: Added.
  • platform/chromium-win/fast/forms/datalist/input-list-expected.png: Added.
  • platform/chromium-win/fast/forms/datalist/input-list-expected.txt: Added.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.png: Added.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.txt: Added.
1:47 AM Changeset in webkit [113151] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: event marks are missing in the timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83043

Reviewed by Pavel Feldman.

  • invoke overview event dividers update as part of overview update, not lower pane update;
  • store raw records for event dividers within overview;
  • moved createEventDividers to a class method of TimelinePresentationModel for reuse.
  • ditto for forAllRecords
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype._updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype._onRecordAdded):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.HeapGraph.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
(WebInspector.TimelinePresentationModel.forAllRecords):
(WebInspector.TimelinePresentationModel.createEventDivider):

1:39 AM Changeset in webkit [113150] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, update platform test expectations for worker-reload.html.

  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
1:34 AM Changeset in webkit [113149] by hans@chromium.org
  • 11 edits
    7 copies
    4 adds in trunk/Source

Speech JavaScript API: Plumbing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=81667

Reviewed by Darin Fisher.

Source/WebCore:

SpeechGrammar::src() is called with a ScriptExecutionContext, because
the attribute setter needs it. Provide a src() method that doesn't
take a ScriptExecutionContext that can be used internally.

Rename SpeechRecognition::audioStartCallback(), etc. to use event style
names, i.e. didStartAudio(), etc.

Remove SpeechRecognitionClient::notifyVisibilityHidden(). The embedder
can keep track of the visibility.

Remove SpeechRecognitionClient::unregisterSpeechRecognition,
it is not needed.

No new tests, just minor tweaks.

  • Modules/speech/SpeechGrammar.h:

(WebCore::SpeechGrammar::src):

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didStartAudio):
(WebCore::SpeechRecognition::didStartSound):
(WebCore::SpeechRecognition::didStartSpeech):
(WebCore::SpeechRecognition::didEndSpeech):
(WebCore::SpeechRecognition::didEndSound):
(WebCore):
(WebCore::SpeechRecognition::didEndAudio):
(WebCore::SpeechRecognition::didReceiveResult):
(WebCore::SpeechRecognition::didReceiveNoMatch):
(WebCore::SpeechRecognition::didDeleteResult):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didStart):
(WebCore::SpeechRecognition::didEnd):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.h:

Source/WebKit/chromium:

Add plumbing for speech recognition.

The implementer is expected to implement the WebSpeechRecognizer interface.
The start(), stop(), and abort() functions of that interface take a
WebSpeechRecognitionHandle argument, which identifies the object which has
requested the action, and a pointer to a WebSpeechRecognitionClient interface,
through which it should send back notifications on progress, errors, etc.

SpeechRecognitionClientProxy passes data between the WebCore and WebKit layers,
implementing the WebCore::SpeechRecognitionClient and WebKit::WebSpeechRecognizerClient
interfaces.

  • WebKit.gyp:
  • public/WebSpeechGrammar.h:

(WebCore):
(WebKit):
(WebSpeechGrammar):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::~WebSpeechGrammar):

  • public/WebSpeechRecognitionHandle.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::~WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::operator==):
(WebKit::operator!=):
(WebKit::operator<):

  • public/WebSpeechRecognitionParams.h:

(WebKit):
(WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::grammars):
(WebKit::WebSpeechRecognitionParams::language):
(WebKit::WebSpeechRecognitionParams::continuous):

  • public/WebSpeechRecognitionResult.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::~WebSpeechRecognitionResult):

  • public/WebSpeechRecognizer.h:

(WebKit):
(WebSpeechRecognizer):
(WebKit::WebSpeechRecognizer::start):
(WebKit::WebSpeechRecognizer::stop):
(WebKit::WebSpeechRecognizer::abort):
(WebKit::WebSpeechRecognizer::~WebSpeechRecognizer):

  • public/WebSpeechRecognizerClient.h: Added.

(WebKit):
(WebSpeechRecognizerClient):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::speechRecognizer):

  • src/SpeechRecognitionClientProxy.cpp: Added.

(WebKit):
(WebKit::SpeechRecognitionClientProxy::~SpeechRecognitionClientProxy):
(WebKit::SpeechRecognitionClientProxy::create):
(WebKit::SpeechRecognitionClientProxy::start):
(WebKit::SpeechRecognitionClientProxy::stop):
(WebKit::SpeechRecognitionClientProxy::abort):
(WebKit::SpeechRecognitionClientProxy::didStartAudio):
(WebKit::SpeechRecognitionClientProxy::didStartSound):
(WebKit::SpeechRecognitionClientProxy::didStartSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSound):
(WebKit::SpeechRecognitionClientProxy::didEndAudio):
(WebKit::SpeechRecognitionClientProxy::didReceiveResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveNoMatch):
(WebKit::SpeechRecognitionClientProxy::didDeleteResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveError):
(WebKit::SpeechRecognitionClientProxy::didStart):
(WebKit::SpeechRecognitionClientProxy::didEnd):
(WebKit::SpeechRecognitionClientProxy::SpeechRecognitionClientProxy):

  • src/SpeechRecognitionClientProxy.h: Added.

(WebKit):
(SpeechRecognitionClientProxy):

  • src/WebSpeechGrammar.cpp: Added.

(WebKit):
(WebKit::WebSpeechGrammar::reset):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::operator=):
(WebKit::WebSpeechGrammar::src):
(WebKit::WebSpeechGrammar::weight):

  • src/WebSpeechRecognitionHandle.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionHandle::reset):
(WebKit::WebSpeechRecognitionHandle::assign):
(WebKit::WebSpeechRecognitionHandle::equals):
(WebKit::WebSpeechRecognitionHandle::lessThan):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::WebSpeechRecognitionHandle::operator PassRefPtr<SpeechRecognition>):

  • src/WebSpeechRecognitionParams.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):

  • src/WebSpeechRecognitionResult.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionResult::assign):
(WebKit::WebSpeechRecognitionResult::reset):
(WebKit::WebSpeechRecognitionResult::operator PassRefPtr<WebCore::SpeechRecognitionResult>):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

1:03 AM Changeset in webkit [113148] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline after r113137 and skip some more flaky
inspector tests on GTK.

  • fast/forms/label/labelable-elements-expected.txt:
  • platform/gtk/test_expectations.txt:
12:37 AM WebKit Team edited by sergio@webkit.org
(diff)
12:30 AM Changeset in webkit [113147] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=82342

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.

Fixes build break in WebKit-Gtk, and WebKit-EFL ports when CONTEXT_MENUS macro is disabled.

Source/WebCore:

  • page/ContextMenuClient.h:
  • page/ContextMenuController.h:
  • page/Page.cpp:

(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):

  • platform/ContextMenu.cpp:
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.cpp:
  • platform/ContextMenuItem.h:
  • platform/efl/ContextMenuEfl.cpp:
  • platform/efl/ContextMenuItemEfl.cpp:
  • platform/gtk/ContextMenuGtk.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp:

Source/WebKit/gtk:

  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.h:
  • webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

  • webkit/webkitwebview.cpp:

(webkit_web_view_button_press_event):
(webkit_web_view_class_init):
(webkit_web_view_init):

12:17 AM Changeset in webkit [113146] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed some WebKit2 crashes seen on the buildbot after my last patch.

Reviewed by Beth Dakin.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize): Don't try to get our value
out of the map, since Weak<T> returns NULL during finalization. Instead,
use the handle we've been passed for finalization.

12:11 AM Changeset in webkit [113145] by abarth@webkit.org
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

The baseline for this test is V8-specific. This patch moves the
baseline to the chromium directory and places the JSC result in the
cross-platform directory.

  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Replaced.
  • platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Copied from LayoutTests/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt.

Apr 3, 2012:

11:24 PM Changeset in webkit [113144] by rniwa@webkit.org
  • 2 edits in trunk/Tools

I really hope this is the last build fix. Apparently exec doesn't quite arguments with
double quotations on Windows. Use system instead.

Hopefully, this won't break anything.

  • Scripts/run-webkit-tests:
10:54 PM Changeset in webkit [113143] by abarth@webkit.org
  • 11 edits
    28 adds in trunk

Implement <iframe srcdoc>
https://bugs.webkit.org/show_bug.cgi?id=82991

Reviewed by Sam Weinig.

Source/WebCore:

This patch implements the <iframe srcdoc> feature. This feature allows
authors to easily supply the contents of an iframe without needing to
round-trip to the server. Using srcdoc is more convenient than using
data URLs because we set a bunch of properties of the child document
sensibly. For example, the child inherits the base URL of the parent
and the child uses standards mode by default.

This feature is specified in
<http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-srcdoc>.
Although the feature has been in the spec for a while, I'm not aware of
any other implementations in major browsers. The srcdoc feature works
especially well with the sandbox and seamless attributes. We already
implement sandbox and will likely implement seamless soon.

The srcdoc feature was announced on the webkit-dev mailing list on March 30:
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020161.html

This patch approaches the implementation using SubstituteData, which is
a mechanism previously used for error messages and the like. Using
SubstituteData has the advantage of not needing to modify the loading
or history pipelines at all, making the integration of srcdoc with the
rest of WebCore quite smooth.

This patch encodes the contents of the srcdoc attribute to and from
UTF-8 when round-tripping the contents through the loader. In a future
patch, I plan to experiment with whether using UTF-16 (or perhaps
another encoding) can improve performance. There might also be a way to
avoid the memcpy entirely, but these optimizations are best left to
followup patches as this patch focuses on the observable behavior of
the feature.

Tests: fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html

fast/frames/srcdoc/setting-src-does-nothing.html
fast/frames/srcdoc/setting-srcdoc-reloads-document.html
fast/frames/srcdoc/srcdoc-beats-src-dom.html
fast/frames/srcdoc/srcdoc-beats-src.html
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html
fast/frames/srcdoc/srcdoc-can-navigate.html
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html
fast/frames/srcdoc/srcdoc-loads-content.html
fast/frames/srcdoc/srcdoc-urls.html
http/tests/security/srcdoc-can-access-parent.html
http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html
http/tests/security/srcdoc-inherits-referrer-for-forms.html
http/tests/security/srcdoc-inherits-referrer.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):

  • srcdoc documents need to inherit their security contexts from their parents. We pick this initialization point to inherit the base URL and to set the "srcdoc Document" bit so that everything gets initialized atomically and from precisely the same owner frame.
  • dom/Document.h:

(Document):
(WebCore::Document::isSrcdocDocument):

  • This bit of state is present in the HTML5 spec and is referred to by a number of different requirements in the spec.
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):

  • These functions implement the requirement that the srcdoc attribute takes precedence over the src attribute and triggers a load of a document with the URL about:srcdoc.
  • html/HTMLIFrameElement.idl:
    • Expose the srcdoc property as a reflection of the DOM attribute.
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::defaultForInitial):

  • This tweak allows srcdoc documents to use standards mode by default, saving authors from having to include a doctype in each srcdoc document.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL):

  • This function transfers the contents of the srcdoc attribute into the loading pipeline. If the client supplies other SubstituteData, that takes precendence over our "default" SubstituteData.

(WebCore::FrameLoader::outgoingReferrer):

  • This function implements the requirement from the HTML5 spec that srcdoc documents inherit their referrer from their parent document. A recursive implementation might have been more aesthetic but the iterative implementation seemed like a better choice.

(WebCore::FrameLoader::shouldTreatURLAsSrcdocDocument):

  • An about:srcdoc URL only has special meaning when loaded in an iframe with a srcdoc attribute. Otherwise, it's just a normal "about" URL, meaning a blank page.

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):

  • Update these call sites to call defaultSubstituteDataForURL and outgoingReferrer consistently.
  • loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

Add a number of tests for <iframe srcdoc>. These tests cover all the
requirements I could find in the HTML5 specification by grepping for
the term "srcdoc".

  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Added.
  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Added.
  • fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Added.
  • fast/frames/srcdoc/setting-src-does-nothing.html: Added.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Added.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-dom.html: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-beats-src.html: Added.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Added.
  • fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-can-navigate.html: Added.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Added.
  • fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-loads-content.html: Added.
  • fast/frames/srcdoc/srcdoc-urls-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-urls.html: Added.
  • http/tests/security/srcdoc-can-access-parent-expected.txt: Added.
  • http/tests/security/srcdoc-can-access-parent.html: Added.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Added.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Added.
  • http/tests/security/srcdoc-inherits-referrer-expected.txt: Added.
  • http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Added.
  • http/tests/security/srcdoc-inherits-referrer-for-forms.html: Added.
  • http/tests/security/srcdoc-inherits-referrer.html: Added.
10:37 PM Changeset in webkit [113142] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Updated JSC expected test results to reflect recent bug fixes <disapproving look>.

Reviewed by Sam Weinig.

  • tests/mozilla/expected.html:
10:28 PM Changeset in webkit [113141] by ggaren@apple.com
  • 35 edits
    7 adds in trunk/Source

First step toward incremental Weak<T> finalization
https://bugs.webkit.org/show_bug.cgi?id=82670

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch implements a Weak<T> heap that is compatible with incremental
finalization, while making as few behavior changes as possible. The behavior
changes it makes are:

(*) Weak<T>'s raw JSValue no longer reverts to JSValue() automatically --
instead, a separate flag indicates that the JSValue is no longer valid.
(This is required so that the JSValue can be preserved for later finalization.)
Objects dealing with WeakImpls directly must change to check the flag.

(*) Weak<T> is no longer a subclass of Handle<T>.

(*) DOM GC performance is different -- 9% faster in the geometric mean,
but 15% slower in one specific case:

gc-dom1.html: 6% faster
gc-dom2.html: 23% faster
gc-dom3.html: 17% faster
gc-dom4.html: 15% *slower*

The key features of this new heap are:

(*) Each block knows its own state, independent of any other blocks.

(*) Each block caches its own sweep result.

(*) The heap visits dead Weak<T>s at the end of GC. (It doesn't
mark them yet, since that would be a behavior change.)

  • API/JSCallbackObject.cpp:

(JSC::JSCallbackObjectData::finalize):

  • API/JSCallbackObjectFunctions.h:

(JSC::::init): Updated to use the new WeakHeap API.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri: Paid the build system tax since I added some new files.
  • heap/Handle.h: Made WeakBlock a friend and exposed slot() as public,

so we can keep passing a Handle<T> to finalizers, to avoid more surface
area change in this patch. A follow-up patch should change the type we
pass to finalizers.

  • heap/HandleHeap.cpp:

(JSC):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):

  • heap/HandleHeap.h:

(JSC):
(HandleHeap):
(Node):
(JSC::HandleHeap::Node::Node): Removed all code related to Weak<T>, since
we have a separate WeakHeap now.

  • heap/Heap.cpp:

(JSC::Heap::Heap): Removed m_extraCost because extra cost is accounted
for through our watermark now. Removed m_waterMark because it was unused.

(JSC::Heap::destroy): Updated for addition of WeakHeap.

(JSC::Heap::reportExtraMemoryCostSlowCase): Changed from using its own
variable to participating in the watermark strategy. I wanted to standardize
WeakHeap and all other Heap clients on this strategy, to make sure it's
accurate.

(JSC::Heap::markRoots): Updated for addition of WeakHeap. Added WeakHeap
dead visit pass, as explained above.

(JSC::Heap::collect):
(JSC::Heap::resetAllocators): Updated for addition of WeakHeap.

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize): Updated for new Weak<T> API.

  • heap/Heap.h:

(JSC::Heap::weakHeap):
(Heap):
(JSC::Heap::addToWaterMark): Added a way to participate in the watermarking
strategy, since this is the best way for WeakHeap to report its memory
cost. (I plan to update this in a follow-up patch to make it more accurate,
but for now it is not less accurate than it used to be.)

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::addToWaterMark):
(JSC::MarkedSpace::didConsumeFreeList): Removed m_nurseryWaterMark because
it was unused, and I didn't want to update WeakHeap to keep an usused
variable working. Added API for above.

  • heap/PassWeak.h:

(JSC):
(WeakImplAccessor):
(PassWeak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::::PassWeak):
(JSC::::~PassWeak):
(JSC::UnspecifiedBoolType):
(JSC::::leakImpl):
(JSC::adoptWeak):

  • heap/Strong.h:

(JSC::Strong::operator!):
(Strong):
(JSC::Strong::operator UnspecifiedBoolType*):
(JSC::Strong::get):

  • heap/Weak.h:

(Weak):
(JSC::::Weak):
(JSC):
(JSC::::isHashTableDeletedValue):
(JSC::::~Weak):
(JSC::::swap):
(JSC::=):
(JSC::::operator):
(JSC::UnspecifiedBoolType):
(JSC::::release):
(JSC::::clear):
(JSC::::hashTableDeletedValue): Lots of code changes here, but they boil
down to two things:

(*) Allocate WeakImpls from the WeakHeap instead of Handles from the HandleHeap.

(*) Explicitly check WeakImpl::state() for non-liveness before returning
a value (explained above).

These files implement the new Weak<T> heap behavior described above:

  • heap/WeakBlock.cpp: Added.
  • heap/WeakBlock.h: Added.
  • heap/WeakHandleOwner.cpp: Added.
  • heap/WeakHandleOwner.h: Added.
  • heap/WeakHeap.cpp: Added.
  • heap/WeakHeap.h: Added.
  • heap/WeakImpl.h: Added.

One interesting difference from the old heap is that we don't allow
clients to overwrite a WeakImpl after allocating it, and we don't recycle
WeakImpls prior to garbage collection. This is required for lazy finalization,
but it will also help us esablish a useful invariant in the future: allocating
a WeakImpl will be a binding contract to run a finalizer at some point in the
future, even if the WeakImpl is later deallocated.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub): Check the Weak<T> for ! instead of
its JSValue, since that's our API contract now, and the JSValue might
be stale.

  • runtime/JSCell.h:

(JSC::jsCast): Allow casting NULL pointers because it's useful and harmless.

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::add): I can't remember why I did this.

  • runtime/StructureTransitionTable.h:
  • runtime/WeakGCMap.h: I had to update these classes because they allocate

and deallocate weak pointers manually. They should probably stop doing that.

Source/WebCore:

Updated WebCore for Weak<T> API changes.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::JSStringOwner::finalize): We're not allowed to get() a dead Weak<T>
anymore, so use the debug-only was() helper function instead.

  • bindings/js/JSDOMBinding.h:

(WebCore::uncacheWrapper): Ditto.

  • bindings/js/JSNodeCustom.h:

(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper): We're not allowed to get() a dead
Weak<T>, so I had to push down these ASSERTs into ScriptWrappable.

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode): Updated for non-Handle-ness
of Weak<T>.

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper): Use was(), as above.

Source/WebKit2:

Updated for API change.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize):

10:18 PM Changeset in webkit [113140] by tony@chromium.org
  • 2 edits in trunk

remove WebKit files from .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=82966

Reviewed by Adam Barth.

  • .gitattributes: These entries were never updated from the move to

Source/WebKit so they're probably not needed.

10:05 PM Changeset in webkit [113139] by macpherson@chromium.org
  • 2 edits
    2 adds in trunk

Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

10:00 PM Changeset in webkit [113138] by yutak@chromium.org
  • 15 edits
    4 adds in trunk

Crash in WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=82873

Reviewed by David Levin.

Source/WebCore:

WorkerThreadableWebSocketChannel::Bridge should properly handle the cases where inter-thread
callback is not called due to the termination of the worker run loop. Specifically, the bridge
should not send its "this" pointer to the main thread, because the bridge object may be freed
in the worker thread before the main thread starts to process.

Test: http/tests/websocket/tests/hybi/workers/worker-reload.html

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::peer):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCreateWebSocketChannel):
Renamed from setUseHixie76Protocol, as this funtion now also sets m_peer.
Sets m_syncMethodDone to true, because this function is called in the end of
synchronous wait of Bridge::initialize().
(WebCore::ThreadableWebSocketChannelClientWrapper::clearPeer):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add WorkerThreadableWebSocketChannel::Peer which is initialized after the creation of
WebSocketChannel in the main thread.
(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
Don't do synchronous wait in the constructor, as a member function may be called
during the wait before the constructor finishes. The meat of the constructor has
moved to initialize() function.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::~Bridge):
(WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::create):
(WebCore::WorkerContextDidInitializeTask::~WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
Don't pass "this" object to the main thread. Receive the pointer to the peer object
via ThreadableWebSocketChannelClientWrapper which is ThreadSafeRefCounted<>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
m_peer may be NULL, and we should not do anything in that case.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel):
(Bridge):

  • workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):

  • workers/WorkerLoaderProxy.h:

(WorkerLoaderProxy::postTaskForModeToWorkerContext):
Return bool to indicate whether postTask was successful or not. This is necessary
to avoid memory leaks of Peer object in Bridge::initialize() function.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

  • workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

Source/WebKit/chromium:

Change the function signature of WorkerLoaderProxy::postTaskForModeToWorkerContext().

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):

  • src/WebSharedWorkerImpl.h:

(WebSharedWorkerImpl):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):

  • src/WebWorkerClientImpl.h:

(WebWorkerClientImpl):

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/worker-reload.js: Added.
  • http/tests/websocket/tests/hybi/workers/worker-reload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-reload.html: Added.
9:43 PM Changeset in webkit [113137] by keishi@webkit.org
  • 21 edits
    8 moves
    1 add in trunk

Disable ENABLE_DATALIST for now
https://bugs.webkit.org/show_bug.cgi?id=82871

Reviewed by Kent Tamura.

.:

We should disable ENABLE_DATALIST because

  • We need platform-dependent implementation, and non-BlackBerry platforms don't have it.
  • We need to hide the content of <datalist>, but it is shown for now.
  • Source/cmake/OptionsEfl.cmake: Disabled ENABLE_DATALIST.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Tools:

  • Scripts/build-webkit: Disabled ENABLE_DATALIST.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Disabled ENABLE_DATALIST.

LayoutTests:

Moved datalist tests into directory fast/forms/datalist and added it to Skipped files.

  • fast/forms/datalist/datalist-expected.txt: Moved from LayoutTests/fast/forms/datalist-expected.txt.
  • fast/forms/datalist/datalist-nonoption-child-expected.txt: Moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt.
  • fast/forms/datalist/datalist-nonoption-child.html: Moved from LayoutTests/fast/forms/datalist-nonoption-child.html.
  • fast/forms/datalist/datalist.html: Moved from LayoutTests/fast/forms/datalist.html.
  • fast/forms/datalist/input-list-expected.txt: Moved from LayoutTests/fast/forms/input-list-expected.txt.
  • fast/forms/datalist/input-list.html: Moved from LayoutTests/fast/forms/input-list.html.
  • fast/forms/datalist/input-selectedoption-expected.txt: Moved from LayoutTests/fast/forms/input-selectedoption-expected.txt.
  • fast/forms/datalist/input-selectedoption.html: Moved from LayoutTests/fast/forms/input-selectedoption.html.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:25 PM Changeset in webkit [113136] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

jsr/sret should be removed
https://bugs.webkit.org/show_bug.cgi?id=82986
<rdar://problem/11017015>

Reviewed by Sam Weinig and Geoff Garen.

Replaces jsr/sret with finally block inlining.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC):

  • bytecompiler/BytecodeGenerator.h:

(FinallyContext):
(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC):

  • jit/JITOpcodes32_64.cpp:

(JSC):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
9:21 PM Changeset in webkit [113135] by yael.aharon@nokia.com
  • 6 edits in trunk/Source

[Qt][WK2] Assert on startup after r113090
https://bugs.webkit.org/show_bug.cgi?id=83111

Reviewed by Noam Rosenthal.

Source/WebCore:

Add willBeDestroyed to to GraphicsLayerTextureMapper.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

Source/WebKit2:

Add willBeDestroyed to to WebGraphicsLayer.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

8:52 PM Changeset in webkit [113134] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Sigh... this isn't going well. I can't even reproduce this issue locally.
Another speculative fix.

  • Scripts/run-webkit-tests:
8:35 PM Changeset in webkit [113133] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Allow the old WebKit2 drawing model to host layers in the window server
<rdar://problem/11170525>
https://bugs.webkit.org/show_bug.cgi?id=83101

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostingMode):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):
(WebKit::LayerTreeHost::setLayerHostingMode):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

(LayerTreeHostCAMac):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Pipe layer hosting mode to the old drawing area.

8:15 PM Changeset in webkit [113132] by bashi@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

7:56 PM Changeset in webkit [113131] by jamesr@google.com
  • 5 edits in branches/chromium/1084/Source

Merge 113095 - [chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061

Reviewed by James Robinson.

Source/WebCore:

Revised existing unit tests.

Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding
to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude
scaling present in previous implementation, and gives better feel to fling animation.

  • platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):

  • platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp:

TBR=wjmaclean@chromium.org
BUG=121824
Review URL: https://chromiumcodereview.appspot.com/9969140

7:53 PM Changeset in webkit [113130] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Update another baseline for a failing chromium SL svg test (and mark it flaky).

Unreviewed, expectations change.

  • platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [113129] by dpranke@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Update baselines for failing svg tests ...

Reviewed by NOBODY (OOPS!).

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
7:19 PM Changeset in webkit [113128] by rniwa@webkit.org
  • 2 edits in trunk/Tools

I don't know why I'm so sloppy today. Another build fix.

  • Scripts/run-webkit-tests:
7:18 PM Changeset in webkit [113127] by hbono@chromium.org
  • 13 edits
    2 adds in trunk

Prevent spellchecking text pasted to an element having spellchecking disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Reviewed by Hajime Morita.

This change prevent calling SpellChecker::requestCheckingFor when pasting text
to an element whose spellcheck attribute is false or a password input.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-disabled.html

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Disabled spellchecking on password inputs.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable): Return false when spellchecking is disabled.

LayoutTests:

  • editing/spelling/spellcheck-paste-disabled-expected.txt: Added.
  • editing/spelling/spellcheck-paste-disabled.html: Added.
  • platform/efl/Skipped: Skipped due to the lack of requestCheckingOfString().
  • platform/gtk/Skipped: ditto.
  • platform/mac-leopard/Skipped: ditto.
  • platform/mac-lion/Skipped: ditto.
  • platform/mac-wk2/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win-wk2/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
7:12 PM Changeset in webkit [113126] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make it possible to install the JavaScriptCore test tools.

Part of <rdar://problem/11158607>.

Reviewed by Filip Pizlo.

  • JavaScriptCore.xcodeproj/project.pbxproj: Introduce an aggregate target named

Test Tools that builds testapi, minidom and testRegExp. Switch All from depending on
those targets individually to depending on the new aggregate target.

7:11 PM Changeset in webkit [113125] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Make FocusController use a ComposedShadowTreeWalker, instead of ReifiedTreeTraversal APIs.
https://bugs.webkit.org/show_bug.cgi?id=82694

Reviewed by Dimitri Glazkov.

Rewrite a focus controller so that it uses ComposedShadowTreeWalker
since that is a preferred way to traverse composed shadow tree.
I'll get rid of ReifiedTreeTraversal in follow-up patches, which is now deprecated.

No new tests. No change in functionality.

  • page/FocusController.cpp:

(WebCore::walkerFrom):
(WebCore):
(WebCore::walkerFromNext):
(WebCore::walkerFromPrevious):
(WebCore::nextNode):
(WebCore::previousNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

6:49 PM Changeset in webkit [113124] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Hopefully the last build fix for Chromium Windows.

Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.

  • Scripts/run-webkit-tests:
6:44 PM Changeset in webkit [113123] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Crash in ~GraphicsContext3D() when init failed
https://bugs.webkit.org/show_bug.cgi?id=82992

Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-03
Reviewed by Luiz Agostini.

WebKit crashes in ~GraphicsContext3D() while freeing the variables which are
not even allocated because of the init failure in GraphicsContext3D() for Qt.
In addition, Added a safety check in makeContextCurrent() before accessing
GraphicsContext3DPrivate object.

No new tests because the change is about adding null check
before accessing the variables.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):

6:40 PM Changeset in webkit [113122] by dpranke@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Lots of timeouts causing Mac10.6 to exit early.
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).

Add logic to the apple mac and chromium mac code to not use
too many workers; it looks like the xserves (and possibly mac
pros) count hyperthreaded cores when they really shouldn't and
we end up using too many workers at a time; this leads to tests
thrashing and timing out.

This change is a temporary fix to make the bots happy while I
look into more profiling and other fixes.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(ChromiumMacPort.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.default_child_processes):

6:38 PM Changeset in webkit [113121] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Offlineasm ARM backend has a very convoluted way of saying it wants to emit a
three-operand multiply instruction
https://bugs.webkit.org/show_bug.cgi?id=83100

Reviewed by Darin Adler.

Changed the "muli"/"mulp" case to call emitArmV7() since that helper method was
already smart enough to do the Right Thing for multiply.

  • offlineasm/armv7.rb:
6:30 PM Changeset in webkit [113120] by Michael Nordman
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[chromium] Unreviewed gardening: skip LayoutTest/storage/domstorage/quota.html

6:28 PM Changeset in webkit [113119] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Add audit token to PHCheckInWithPluginHost
https://bugs.webkit.org/show_bug.cgi?id=83102

Reviewed by Sam Weinig.

  • Plugins/Hosted/WebKitPluginHost.defs:
6:26 PM Changeset in webkit [113118] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test media/video-source-error.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=80068

Unreviewed; test is no longer showing up on flakiness dashboard.

  • platform/chromium/test_expectations.txt:
6:06 PM Changeset in webkit [113117] by Simon Fraser
  • 2 edits in trunk/Tools

WebKitTestRunner's EventSender is leaky
https://bugs.webkit.org/show_bug.cgi?id=83099

Reviewed by Beth Dakin.

Fix leaks of WKNumbers by using the adoptWK idiom, and make
all the code consistent.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

6:03 PM Changeset in webkit [113116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Include Image.h in TextFieldDecoratorImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=83066

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-03
Reviewed by James Robinson.

  • src/TextFieldDecoratorImpl.cpp:
6:02 PM Changeset in webkit [113115] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

5:57 PM Changeset in webkit [113114] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes should kill apache2 and httpd
https://bugs.webkit.org/show_bug.cgi?id=83065

Reviewed by Tony Chang.

Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.

  • BuildSlaveSupport/kill-old-processes:
5:50 PM Changeset in webkit [113113] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Offlineasm ARM backend uses the wrong mnemonic for multiply
https://bugs.webkit.org/show_bug.cgi?id=83098
<rdar://problem/11168744>

Reviewed by Gavin Barraclough.

Use "mul" instead of "muls" since we're passing three operands, not two.

  • offlineasm/armv7.rb:
5:29 PM Changeset in webkit [113112] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Linux crashes during boot
https://bugs.webkit.org/show_bug.cgi?id=83096

Reviewed by Filip Pizlo.

The bug here is that we add empty JSValues to the sparse map, and then set them

  • but a GC may occur before doing so (due to a call to reportExtraMemory cost).

We may want to consider making it safe to mark empty JSValues, but the simple &
contained fix to this specific bug is to just initialize these values to
something other than JSValue().

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):

  • Initialize sparse map entries.
5:28 PM Changeset in webkit [113111] by rafaelw@chromium.org
  • 28 edits
    2 copies
    1 add in trunk/Source

Use V8 completion callback API to assert that V8RecursionScope is on the stack whenever invoking script
https://bugs.webkit.org/show_bug.cgi?id=79131

Reviewed by Adam Barth.

Source/WebCore:

End-of-microtask work (cancelling outstanding IDB transactions,
delivering DOM mutations) depend on V8RecursionScope being on the
stack whenever a call is made into script. V8 provides a completion
callback API that could be used to hook these "end-of-microtask"
events, but it turns out that WebKit calls into script for various
reasons besides running script from the page. For example, constructing
wrapper objects from function templates counts as "running script",
yet it's not appropriate to run this callback every time a JS wrapper
is constructed.

Instead, this patch makes use of the V8 completion callback mechanism
only in debug mode, to assert that either a V8RecursionScope (when
calling author script) or a V8RecursionScope::MicrotaskSuppression
(when calling non-author script) is on the stack when V8 thinks it's
finished executing script. This requires dropping MicrotaskSuppression
objects in a bunch of places, most notably the Inspector.
Note that in release mode, this class does nothing and thus should be
optimized away.

No new tests. Existing tests have appropriate coverage.

  • Target.pri:
  • WebCore.gypi:
  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::setAllowSleep):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):
(WebCore):
(WebCore::ScriptController::collectGarbage):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::callDebuggerMethod):
(WebCore):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::currentCallFrame):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::internalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::incrementInternalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementInternalScriptRecursionLevel):

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::recursionLevel):
(V8RecursionScope):
(WebCore::V8RecursionScope::properlyUsed):
(MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::~MicrotaskSuppression):

  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::WrapInShadowObject):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:
  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebFrame.h:

(v8):
(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebKit.cpp:

(WebKit):
(WebKit::assertV8RecursionScope):
(WebKit::initialize):
(WebKit::shutdown):

5:04 PM Changeset in webkit [113110] by annacc@chromium.org
  • 3 edits
    2 adds in trunk

Makes sure m_showingByDefault is set to false when TextTrack.mode is set from JS.
https://bugs.webkit.org/show_bug.cgi?id=79791

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-mode.html

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode): setMode should always setShowingByDefault to false.

LayoutTests:

  • media/track/track-mode-expected.txt: Added.
  • media/track/track-mode.html: Added.
4:38 PM Changeset in webkit [113109] by jpu@apple.com
  • 35 edits
    2 moves in trunk/Source

Manual submission for bug 82942.

4:37 PM Changeset in webkit [113108] by mrowe@apple.com
  • 5 edits in branches/safari-534.56-branch/Source

Versioning.

4:35 PM Changeset in webkit [113107] by mrowe@apple.com
  • 1 copy in tags/Safari-534.56.5

New tag.

4:32 PM Changeset in webkit [113106] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore/rendering

RenderBox cleanup on branch.

4:26 PM Changeset in webkit [113105] by abarth@webkit.org
  • 6 edits in trunk/Source

Unreviewed. This patch adds an ugly, ugly hack to bandaid over the
Windows component build. See comments in the code for details.

Source/Platform:

  • chromium/public/WebMediaStreamSourcesRequest.h:

(WebMediaStreamSourcesRequest):

Source/WebCore:

  • platform/chromium/support/WebMediaStreamSourcesRequest.cpp:

(WebKit::WebMediaStreamSourcesRequest::dummy):
(WebKit):

Source/WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::shutdown):

4:25 PM Changeset in webkit [113104] by tony@chromium.org
  • 2 edits in trunk/Tools

run the same test steps on test only bots as on build-and-test bots
https://bugs.webkit.org/show_bug.cgi?id=83090

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

4:04 PM Changeset in webkit [113103] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r113087.
http://trac.webkit.org/changeset/113087
https://bugs.webkit.org/show_bug.cgi?id=83068

Breaks Windows builds in other unpredictable ways.

  • WebKit.gyp: Removed the hack.
4:04 PM Changeset in webkit [113102] by fischman@chromium.org
  • 2 edits in trunk/Tools

Add a Media watchlist.
https://bugs.webkit.org/show_bug.cgi?id=83071

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/watchlist:
3:58 PM Changeset in webkit [113101] by Simon Fraser
  • 2 edits in trunk/Tools

Fix large leak in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83084

Reviewed by Beth Dakin.

Fix a leak of the bimap backing store created when doing pixel and
ref tests. This leak was causing serious thrash on the test bots.

We don't need to allocate memory for CGBitmapContextCreate(); if we
pass NULL, it will allocate and manage its own backing store.

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):

3:54 PM Changeset in webkit [113100] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Remove #if !USE(TILED_BACKING_STORE) from WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=83070

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Andreas Kling.

It is preventing m_frameHasCustomRepresentation to be set properly and not in sync with
WebFrameLoaderClient::transitionToCommittedFromCachedFrame()

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

3:51 PM Changeset in webkit [113099] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/css-set-selector-text-crash.html

Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

LayoutTests:

  • fast/css/css-set-selector-text-crash-expected.txt: Added.
  • fast/css/css-set-selector-text-crash.html: Added.
3:39 PM Changeset in webkit [113098] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

presentationAttributeCacheMaximumSize is set too low
https://bugs.webkit.org/show_bug.cgi?id=82816

Reviewed by Antti Koivisto.

Performance change, no side effects anticipated.

Prior to r106740, the presentation attribute style cache used to grow unbounded. As part of r110316,
a different version of the cache was introduced with a maximum size of 128. This size gave a 75% hit rate.

However this is bad as the previous cache had a 85% hit rate and each miss propagate down to the matched
properties cache as we use pointer comparisons.

This change bumps the size to 4096. This size was chosen to bring us back to the previous hit rate while
being a power of 2 (it is the HashMap maximum size). The steep increase is due to the combinational compexity
of the new cache model: we need to match all our attributes' name, value and tag name to get a hit vs
one attribute name, value and a category in the previous cache. To avoid blowing up the memory, we introduced
a timer to clear the cache if the hit rate is too low.

The measured hit rate is actually better now - in the 90% range on most page cyclers. This ups the matched
properties hit rate by 1 percent point on presentation attributes.

This is not a true apple-to-apple comparison as the cache model was changed.

  • dom/StyledElement.cpp:

(PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::didHitPresentationAttributeCache):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):
(WebCore):
(WebCore::presentationAttributeCacheCleaner):
(WebCore::StyledElement::updateAttributeStyle):
Added the logic to clean the presentation attribute cache if we drop below 100 hits per minutes.

3:34 PM Changeset in webkit [113097] by tony@chromium.org
  • 38 edits in trunk

Implement new flex property and deprecate flex function
https://bugs.webkit.org/show_bug.cgi?id=82128

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests. Tests were updated to use the new syntax and they should
all pass.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredFlexLengthForChild): Grab the
preferred size and if it's auto, fall back to width or height.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Update tests to use the -webkit-flex: propery instead of the function.
In most cases this was just a simple find & replace, but in a few cases
we had to clear the flex value.

  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-max.html:
  • css3/flexbox/flex-align-percent-height.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-flow-border.html:
  • css3/flexbox/flex-flow-margins-auto-size-expected.txt: This test had expected failures that needed to be updated.
  • css3/flexbox/flex-flow-margins-auto-size.html:
  • css3/flexbox/flex-flow-margins.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-flow-padding.html:
  • css3/flexbox/flex-flow.html:
  • css3/flexbox/flex-no-flex.html:
  • css3/flexbox/flex-order.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/repaint-rtl-column.html:
  • css3/flexbox/repaint.html:
  • css3/flexbox/writing-modes.html:
3:26 PM Changeset in webkit [113096] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Search result page scrolls up before the correct page opens from google search
https://bugs.webkit.org/show_bug.cgi?id=81280
<rdar://problem/10973263>

Reviewed by Sam Weinig.

Make the requested scroll position part of the ScrollingTreeState so any changes being made
are in sync with other important changes such as the scroll layer or contents size.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Use coordinatesScrollingForFrameView instead of checking if the frame is the main frame.

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
Call ScrollingTreeState::setRequestedScrollPosition.

(WebCore::ScrollingCoordinator::setScrollLayer):
Reset the requested scroll position.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setRequestedScrollPosition):
Keep track of the scroll position.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Update the scroll position if it's changed.

3:26 PM UsingGitWithWebKit edited by dpranke@chromium.org
(diff)
3:02 PM Changeset in webkit [113095] by wjmaclean@chromium.org
  • 5 edits in trunk/Source

[chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061

Reviewed by James Robinson.

Source/WebCore:

Revised existing unit tests.

Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding
to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude
scaling present in previous implementation, and gives better feel to fling animation.

  • platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):

  • platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp:
3:01 PM Changeset in webkit [113094] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.

  • BuildSlaveSupport/built-product-archive:

(unzipArchive):

2:52 PM Changeset in webkit [113093] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/media/video-cancel-load.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=82508

Unreviewed, removing no-longer-needed expectation.

  • platform/chromium/test_expectations.txt:
2:48 PM Changeset in webkit [113092] by zmo@google.com
  • 30 edits
    5 adds in trunk

Implement WebGLShaderPrecisionFormat
https://bugs.webkit.org/show_bug.cgi?id=75925

Reviewed by Kenneth Russell.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h: Add getShaderPrecisionFormat().

(WebGraphicsContext3D):

Source/WebCore:

Test: fast/canvas/webgl/shader-precision-format.html

  • CMakeLists.txt: Add new source files webglshaderprecisionformat.h/idl
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: Add getShaderPrecisionFormat.

(WebCore):
(WebCore::WebGLRenderingContext::getShaderPrecisionFormat):

  • html/canvas/WebGLRenderingContext.h: Ditto.

(WebCore):
(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl: Ditto.
  • html/canvas/WebGLShaderPrecisionFormat.h: Added.

(WebCore):
(WebGLShaderPrecisionFormat):
(WebCore::WebGLShaderPrecisionFormat::create):
(WebCore::WebGLShaderPrecisionFormat::rangeMin):
(WebCore::WebGLShaderPrecisionFormat::rangeMax):
(WebCore::WebGLShaderPrecisionFormat::precision):
(WebCore::WebGLShaderPrecisionFormat::WebGLShaderPrecisionFormat):

  • html/canvas/WebGLShaderPrecisionFormat.idl: Added.
  • page/DOMWindow.idl: Expose new type WebGLShaderPrecisionFormat for instanceof.
  • platform/graphics/GraphicsContext3D.h: Add getShaderPrecisionFormat().
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp: Add getShaderPrecisionFormat().

(WebCore):

  • src/GraphicsContext3DPrivate.h: Ditto.

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h: Ditto.

(FakeWebGraphicsContext3D):

LayoutTests:

  • fast/canvas/webgl/instanceof-test-expected.txt: Add new WebGLShaderPrecisionFormat failure.
  • fast/canvas/webgl/instanceof-test.html:
  • fast/canvas/webgl/shader-precision-format-expected.txt: Added.
  • fast/canvas/webgl/shader-precision-format.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js: Add new type WebGLShaderPrecisionFormat.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.

(constructorNamesForWindow):

  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/js/script-tests/global-constructors.js: Ditto.
2:35 PM Changeset in webkit [113091] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Source/WebCore: Frame flattening: Do not restart layout from parent frame, when the parent is clean.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

When frame flattening is on, child frames try to mark the ancestors dirty
to be able to restart layout from the main frame. Child frames mark the
anchestors in FrameView::scheduleRelayout(). Marking fails when scheduling is disabled,
for example when the iframe's <head> has blocking resource and the <body> has not
been injected into the document.
When marking ancestor fails, child frame layout needs to continue normally.
It is expected to have layouts, when scheduling is enabled.

Test: http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::doLayoutWithFrameFlattening):

  • page/FrameView.h:

(FrameView):

LayoutTests: Add test case for 3 level nested iframes with frame flattening on.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

  • http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource-expected.txt: Added.
  • http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html: Added.
  • http/tests/misc/resources/3rd-level-iframe-with-blocking-resource.php: Added.
  • http/tests/misc/resources/nested-iframe-loading-another-iframe.html: Added.
  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [113090] by Simon Fraser
  • 13 edits in trunk/Source/WebCore

Avoid virtual method calls in the GraphicsLayer destructor
https://bugs.webkit.org/show_bug.cgi?id=83067

Reviewed by James Robinson.

Code cleanup to avoid calling virtual methods in the GraphicsLayer
destructor. Factor teardown code into a willBeDestroyed() method
that is called from the most dervied class. willBeDestroyed()
calls have to be chained. Fix the various ports' GraphicsLayer
implementations.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore):
(WebCore::GraphicsLayer::willBeDestroyed):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore):
(WebCore::GraphicsLayerCA::willBeDestroyed):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore):
(WebCore::GraphicsLayerChromium::willBeDestroyed):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):

  • platform/graphics/efl/GraphicsLayerEfl.cpp:

(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQt::~GraphicsLayerQt):
(WebCore):
(WebCore::GraphicsLayerQt::willBeDestroyed):

  • platform/graphics/qt/GraphicsLayerQt.h:

(GraphicsLayerQt):

2:29 PM Changeset in webkit [113089] by commit-queue@webkit.org
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

[skia] Switch to Skia's implementation of the feMorphology filter.
https://bugs.webkit.org/show_bug.cgi?id=82085

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-04-03

  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [113088] by dcheng@chromium.org
  • 5 edits
    2 adds in trunk

Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.
http://trac.webkit.org/changeset/105396 introduced this issue when fixing some other aspects
of DnD handling.

Test: fast/events/drop-handler-should-not-stop-navigate.html

  • page/DragController.cpp:

(WebCore::DragController::performDrag):
(WebCore::DragController::concludeEditDrag): Remove the assert. By definition, we want to

allow default actions to run now if they weren't explicitly canceled.

LayoutTests:

  • fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
  • fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
  • fast/events/drop-handler-should-not-stop-navigate.html: Added.
  • http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler

to prevent bubbled events from causing navigation.

2:17 PM Changeset in webkit [113087] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

disable incremental linking for debug of webkit
https://bugs.webkit.org/show_bug.cgi?id=83068

Reviewed by Adam Barth.

Now that we need to export symbols from webkit.dll that are
defined in webcore_platform, we have to enable ULDI in order for
incremental linking to work (which is used in debug mode).

  • WebKit.gyp:
1:59 PM Changeset in webkit [113086] by arv@chromium.org
  • 4 edits
    4 adds in trunk

[v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Reviewed by Ojan Vafai.

Source/WebCore:

This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).

This also clears the strings once the code has been parsed and the function created.

Tests: fast/dom/inline-event-attributes-moved.html

fast/dom/inline-event-attributes-release.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

  • fast/dom/inline-event-attributes-moved-expected.txt: Added.
  • fast/dom/inline-event-attributes-moved.html: Added.
  • fast/dom/inline-event-attributes-release-expected.txt: Added.
  • fast/dom/inline-event-attributes-release.html: Added.
1:56 PM Changeset in webkit [113085] by commit-queue@webkit.org
  • 11 edits
    1 copy
    3 adds
    9 deletes in trunk/LayoutTests

More rebaselines after WK79568
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-03

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [113084] by ojan@chromium.org
  • 3 edits in trunk/Tools

Give more human friendly error message when builders fail to load or have stale data.
https://bugs.webkit.org/show_bug.cgi?id=83058

Reviewed by Eric Seidel.

  • TestResultServer/static-dashboards/dashboard_base.js:

(addError):
(addBuilderLoadErrors):
(handleLocationChange):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1:50 PM Changeset in webkit [113083] by tomz@codeaurora.org
  • 2 edits
    350 adds in trunk/LayoutTests

Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734

Unreviewed test expectation updates

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03

  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 PM Changeset in webkit [113082] by msaboff@apple.com
  • 4 edits in trunk

Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Source/WebCore:

Initialize m_script to empty string. Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):

LayoutTests:

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

  • platform/mac/Skipped:
1:36 PM Changeset in webkit [113081] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Enable sparkline FPS counter in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82959

Patch by James Robinson <jamesr@chromium.org> on 2012-04-03
Reviewed by Adrienne Walker.

This enables rendering the FPS counter sparkline when in threaded compositing mode. We don't currently have a
way to draw text from the thread (since we can't interact with WebCore::Font objects from a non-main thread),
but having a sparkline is still useful for judging framerate stability.

There are no tests for the HUD since it's a developer-facing feature and not user-facing.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

1:34 PM Changeset in webkit [113080] by kareng@chromium.org
  • 14 edits
    6 deletes in branches/chromium/1084

Revert 111028 - Support W3C Full Screen API proposal
https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html

fullscreen/full-screen-enabled.html
fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately. As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being

added to the event and error queue by swapping out empty queues before starting.

(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.

  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

  • fullscreen/full-screen-element-stack-expected.txt: Added.
  • fullscreen/full-screen-element-stack.html: Added.
  • fullscreen/full-screen-enabled-expected.txt: Added.
  • fullscreen/full-screen-enabled.html: Added.
  • fullscreen/full-screen-request-rejected.html:
  • fullscreen/full-screen-request-removed.html:
  • fullscreen/full-screen-restrictions-expected.txt: Added.
  • fullscreen/full-screen-restrictions.html: Added.
  • fullscreen/full-screen-test.js:

TBR=jer.noble@apple.com
Review URL: https://chromiumcodereview.appspot.com/9950115

1:32 PM Changeset in webkit [113079] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.

  • BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):

1:16 PM Changeset in webkit [113078] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect comment in CCDamageTrackerTest
https://bugs.webkit.org/show_bug.cgi?id=82118

Reviewed by Adrienne Walker.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

1:15 PM Changeset in webkit [113077] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Yet another build fix after r113067. Don't trigger Chromium testers right away
since they're now triggered by builders.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:14 PM Changeset in webkit [113076] by robert@webkit.org
  • 3 edits
    28 adds in trunk

CSS 2.1 failure: at-import-009.htm fails
https://bugs.webkit.org/show_bug.cgi?id=82921

Source/WebCore:

Reviewed by Antti Koivisto.

This fixes at-import-009.htm only, the other tests already passed.

Tests: css2.1/20110323/at-import-001.htm

css2.1/20110323/at-import-002.htm
css2.1/20110323/at-import-003.htm
css2.1/20110323/at-import-004.htm
css2.1/20110323/at-import-005.htm
css2.1/20110323/at-import-006.htm
css2.1/20110323/at-import-007.htm
css2.1/20110323/at-import-009.htm
css2.1/20110323/at-import-010.htm
css2.1/20110323/at-import-011.htm

  • css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations

LayoutTests:

Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
as it relies on a print media type to work.

Reviewed by Antti Koivisto.

  • css2.1/20110323/at-import-001-expected.html: Added.
  • css2.1/20110323/at-import-001.htm: Added.
  • css2.1/20110323/at-import-002-expected.html: Added.
  • css2.1/20110323/at-import-002.htm: Added.
  • css2.1/20110323/at-import-003-expected.html: Added.
  • css2.1/20110323/at-import-003.htm: Added.
  • css2.1/20110323/at-import-004-expected.html: Added.
  • css2.1/20110323/at-import-004.htm: Added.
  • css2.1/20110323/at-import-005-expected.html: Added.
  • css2.1/20110323/at-import-005.htm: Added.
  • css2.1/20110323/at-import-006-expected.html: Added.
  • css2.1/20110323/at-import-006.htm: Added.
  • css2.1/20110323/at-import-007-expected.html: Added.
  • css2.1/20110323/at-import-007.htm: Added.
  • css2.1/20110323/at-import-009-expected.html: Added.
  • css2.1/20110323/at-import-009.htm: Added.
  • css2.1/20110323/at-import-010-expected.html: Added.
  • css2.1/20110323/at-import-010.htm: Added.
  • css2.1/20110323/at-import-011-expected.html: Added.
  • css2.1/20110323/at-import-011.htm: Added.
  • css2.1/20110323/support/at-import-001.css: Added.
  • css2.1/20110323/support/at-import-002.css: Added.
  • css2.1/20110323/support/at-import-004.css: Added.
  • css2.1/20110323/support/at-import-005.css: Added.
  • css2.1/20110323/support/at-import-006.css: Added.
  • css2.1/20110323/support/at-import-007.css: Added.
  • css2.1/20110323/support/import-green.css: Added.
  • css2.1/20110323/support/import-red.css: Added.
1:14 PM Changeset in webkit [113075] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Convert RootInlineBox to LayoutUnits on branch.

1:05 PM Changeset in webkit [113074] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix after r113067 for Mac port.
It turned out that archiving the entire build directory doesn't work.

  • BuildSlaveSupport/built-product-archive:

(createZipManually):
(createZip):
(archiveBuiltProduct):

1:02 PM Changeset in webkit [113073] by commit-queue@webkit.org
  • 10 edits in trunk

[BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
https://bugs.webkit.org/show_bug.cgi?id=82643

Source/WebKit/blackberry:

Enhance BlackBerry::WebKit::WebPage::findNextString()

This patch adds support for toggling case sensitivity,
search wrapping, and whether or not to highlight all matches
in addition to the next found match.

I refactored and renamed the new setActiveMatchAndMarker() method
to move the active match from one range to another. This was
required because in the case of a non wrapped search we do not
want to adjust the m_activeMatch if another match is not found.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::findNextString):

  • Api/WebPage.h:
  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

  • WebKitSupport/InPageSearchManager.h:

(InPageSearchManager):

Tools:

Update LayoutTestController to accomodate the new find API.
It now provides caseSensitive functionality to DRT.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::findString):

LayoutTests:

Update findString-markers to also test caseSensitive.
All findString tests used to be case insensitive before.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

  • platform/blackberry/editing/text-iterator/findString-markers-expected.txt:
  • platform/blackberry/editing/text-iterator/findString-markers.html:
12:31 PM Changeset in webkit [113072] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
because download-built-product creates the build directory as needed.

This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

12:26 PM Changeset in webkit [113071] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r113067. Don't delete the build directory.

  • BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):

12:24 PM Changeset in webkit [113070] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] remove dead function declarations in RenderSurfacechromium
https://bugs.webkit.org/show_bug.cgi?id=82086

Reviewed by James Robinson.

No tests needed, no change in behavior.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

12:21 PM Changeset in webkit [113069] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update fast/regions expectations to match what's happening on
the chromium bots.

  • platform/chromium/test_expectations.txt:
12:08 PM Changeset in webkit [113068] by ojan@chromium.org
  • 6 edits in trunk/Tools

Load all builder lists from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=82998

Reviewed by Adam Barth.

Also, remove an unnecessary list of test types. Now we don't hard-code
builder names anywhere and we only have a single hard-coded list of
test types.

  • TestResultServer/static-dashboards/builders.js:

(BuilderMaster.prototype.logPath):
(BuilderMaster.prototype.builderJsonPath):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(isChromiumDepsFyiGpuTestRunner):
(isChromiumTipOfTreeGpuTestRunner):
(isChromiumDepsGTestRunner):
(isChromiumDepsCrosGTestRunner):
(isChromiumTipOfTreeGTestRunner):
(onBuilderListLoad):
(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseCrossDashboardParameters):
(currentBuilderGroupCategory):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForTestsWithExpectationsButNoFailures):
(testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
(testGenerateChromiumDepsGTestBuildersFromBuilderList):
(testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
(testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):

  • TestResultServer/static-dashboards/timeline_explorer.html:
11:58 AM Changeset in webkit [113067] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/Tools

Chromium testers should extract builds instead of building on their own
https://bugs.webkit.org/show_bug.cgi?id=82996

Reviewed by Tony Chang.

Make Chromium builders triggger Chromium testers and make testers download and extract builds
from the buildbot master instead of building binaries on their own.

Add download-built-product to wrap curl used in the download-built-product step since Windows
does not provide "curl" natively.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make

Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadBuiltProduct): Call download-built-product instead of curl.

  • BuildSlaveSupport/built-product-archive:

(createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
(archiveBuiltProduct): Zip the configuration build directory on Mac port.
(unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
(extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.

  • BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
11:54 AM Changeset in webkit [113066] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473

Reviewed by Philippe Normand.

Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.

  • gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first

check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

11:26 AM Changeset in webkit [113065] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Another attempt to fix the Windows build. This uses WebSecurityOrigin
has a value type but doesn't include the header.

  • public/WebUserMediaRequest.h:

(WebKit):

11:09 AM Changeset in webkit [113064] by abarth@webkit.org
  • 2 edits in trunk/Source/Platform

Attempt to fix the Windows component build by including these headers
rather than forward declaring these objects.

  • chromium/public/WebMediaStreamSourcesRequest.h:

(WebKit):

11:08 AM Changeset in webkit [113063] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Revert unneeded changes in RenderView and RenderDeprecatedFlexibleBox on branch.

10:57 AM Changeset in webkit [113062] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Not reviewed. Follow up to inspector's r113032: change provisional method signature a bit.

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::save):

10:50 AM Changeset in webkit [113061] by bbudge@chromium.org
  • 4 edits in branches/chromium/1084

Merge 112997 - REGRESSION (r112217): H&R Block tax site won't load
https://bugs.webkit.org/show_bug.cgi?id=82964

Source/WebCore:

Modifies the redirect checking code to first check if the security origin can
request the redirect URL before invoking the CORS check.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-and-redirects-async.html

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:

LayoutTests:

Add a test case for a same origin request with a custom header that receives a
same origin redirect, and therefore should pass the redirect check.

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-and-redirects-async.html:

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956108

10:43 AM Changeset in webkit [113060] by bbudge@chromium.org
  • 2 edits in branches/chromium/1084/Source/WebKit/chromium/src

Merge 112991 - WebViewImpl doesn't notify the page that the user has canceled fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=82760

Reviewed by Darin Fisher.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::willExitFullScreen):
(WebKit::WebViewImpl::exitFullScreenForElement):

  • src/WebViewImpl.h:

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9969112

10:42 AM Changeset in webkit [113059] by jpu@apple.com
  • 11 edits in trunk/Source/WebCore

Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=82946

Reviewed by Enrica Casucci.

On OS X, we draw similar underline on dictated text that has alternative text. We rename
this function, so that we can reuse it for dictation underline.

No new tests, since there's no change of functionality.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • rendering/InlineTextBox.cpp:

(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):

10:39 AM Changeset in webkit [113058] by fischman@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test media/video-src-source.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82227

De-race the test by registering the listener before the event can fire.
Reviewed by Eric Carlson.

  • media/video-src-source.html:
  • platform/chromium/test_expectations.txt:
10:34 AM Changeset in webkit [113057] by fischman@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] media/video-delay-load-event.html is flaky on all platforms
https://bugs.webkit.org/show_bug.cgi?id=64003

Explicitly request a .load() on the <video> element before expecting changes to its <source>
to be reflected, per the note in section 4.8.8 of the spec saying:

Dynamically modifying a source element [...] when the element is already
inserted [...] will have no effect. To change what is playing [...] call
the load() method on the media element [...]

Reviewed by Eric Carlson.

  • media/video-delay-load-event.html:
  • platform/chromium/test_expectations.txt:
10:33 AM Changeset in webkit [113056] by jer.noble@apple.com
  • 12 edits in trunk/Source

ESC key in full screen does not result in webkitFullScreenChange event.
https://bugs.webkit.org/show_bug.cgi?id=82755
<rdar://problem/11093513>

Reviewed by Eric Carlson.

Source/WebCore:

  • WebCore.exp.in: Export the WebCore::Document::webkitCancelFullScreen() symbol.

Source/WebKit/mac:

Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController requestExitFullScreen]):

Source/WebKit2:

Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.

Because the WebProcess may be stalled or hung, add a watchdog timer which will force an exit of full
screen if the WebProcess does not respond in a timely manner (defaults to 1s).

Add a new method, requestExitFullScreen, which calls through to the WebProcess and Document:

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):

  • UIProcess/WebFullScreenManagerProxy.h:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::requestExitFullScreen):

  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/FullScreen/WebFullScreenManager.messages.in:

Request that the document exits full screen when the ESC key is pressed:

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController cancelOperation:]):
(-[WKFullScreenWindowController exitFullScreen]):

10:31 AM Changeset in webkit [113055] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 flaky crash inspector tests on GTK.

  • platform/gtk/Skipped:
10:21 AM Changeset in webkit [113054] by tomz@codeaurora.org
  • 6 edits in trunk/LayoutTests

Expectations update after 82734
https://bugs.webkit.org/show_bug.cgi?id=82734

Unreviewed expectations update.

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
10:14 AM Changeset in webkit [113053] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=82050

Source/WebKit/efl:

Add a setting setInteractiveFormValidationEnabled to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Enable interactive form validation and unskip tests from the
skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip interactive form validation tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
10:07 AM Changeset in webkit [113052] by mnaganov@chromium.org
  • 1 edit
    19 deletes in branches/chromium/1025

Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when starting typing.
https://bugs.webkit.org/show_bug.cgi?id=65027

Reviewed by Ryosuke Niwa.

Tests: editing/input/caret-at-the-edge-of-contenteditable.html

editing/input/caret-at-the-edge-of-input.html
editing/input/reveal-caret-of-multiline-contenteditable.html
editing/input/reveal-caret-of-multiline-input.html
editing/input/reveal-contenteditable-on-input-vertically.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/input/reveal-edit-on-input-vertically.html
editing/input/reveal-edit-on-paste-vertically.html

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
  • editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-contenteditable.html: Added.
  • editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • editing/input/caret-at-the-edge-of-input-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-input.html: Added.
  • editing/input/resources/reveal-utilities.js: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable.html: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-input.html: Added.
  • editing/input/reveal-contenteditable-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-input-vertically.html: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically.html: Added.
  • editing/input/reveal-edit-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-input-vertically.html: Added.
  • editing/input/reveal-edit-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-paste-vertically.html: Added.
  • platform/chromium/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/gtk/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/qt/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/win/test_expectations.txt: Mark new tests as FAIL to grab results from bots.

TBR=mnaganov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9965112

10:06 AM Changeset in webkit [113051] by eae@chromium.org
  • 969 edits
    251 copies
    49 deletes in branches/subpixellayout

Merge trunk changes up until 113044 into subpixel branch.

10:00 AM Changeset in webkit [113050] by mnaganov@chromium.org
  • 1 edit
    13 deletes in branches/chromium/1084

Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when starting typing.
https://bugs.webkit.org/show_bug.cgi?id=65027

Reviewed by Ryosuke Niwa.

Tests: editing/input/caret-at-the-edge-of-contenteditable.html

editing/input/caret-at-the-edge-of-input.html
editing/input/reveal-caret-of-multiline-contenteditable.html
editing/input/reveal-caret-of-multiline-input.html
editing/input/reveal-contenteditable-on-input-vertically.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/input/reveal-edit-on-input-vertically.html
editing/input/reveal-edit-on-paste-vertically.html

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
  • editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-contenteditable.html: Added.
  • editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • editing/input/caret-at-the-edge-of-input-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-input.html: Added.
  • editing/input/resources/reveal-utilities.js: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable.html: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-input.html: Added.
  • editing/input/reveal-contenteditable-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-input-vertically.html: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically.html: Added.
  • editing/input/reveal-edit-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-input-vertically.html: Added.
  • editing/input/reveal-edit-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-paste-vertically.html: Added.
  • platform/chromium/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/gtk/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/qt/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/win/test_expectations.txt: Mark new tests as FAIL to grab results from bots.

TBR=mnaganov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9969106

9:52 AM Changeset in webkit [113049] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
https://bugs.webkit.org/show_bug.cgi?id=83000

Reviewed by Andreas Kling.

Source/WebCore:

Fixed the crash by exiting early in StylePropertySet::borderSpacingValue when
the vertical value is set.

Test: fast/css/border-spacing-without-vertical-value.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::borderSpacingValue):

LayoutTests:

Add a regression for obtaining the value of border-spacing without specifying
-webkit-horizontal-vertical.

  • fast/css/border-spacing-without-vertical-value-expected.txt: Added.
  • fast/css/border-spacing-without-vertical-value.html: Added.
9:49 AM Changeset in webkit [113048] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add click count and modifiers to the factory method of mouse event.
https://bugs.webkit.org/show_bug.cgi?id=82502

Modify WebInputEventFactory::mouseEvent() to take click count
and modifiers from input parameters. Sample use cases of these
are double click, triple click, Ctrl+click, etc.

Patch by Bolin Hsu <bhsu@google.com> on 2012-04-03
Reviewed by Eric Seidel.

  • public/android/WebInputEventFactory.h:
  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::mouseEvent):

9:45 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update QtWebKit buildbots (diff)
9:41 AM Changeset in webkit [113047] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

LayoutTests/.gitattributes cleanup
https://bugs.webkit.org/show_bug.cgi?id=82975

Reviewed by Hajime Morita.

  • .gitattributes: Set svn:mime-type for .gif files and remove files

that no longer exist.

9:23 AM Changeset in webkit [113046] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed ASSERT fix on Chromium bots (in debug).

It appears that http://trac.webkit.org/changeset/113031 caused ASSERT in CSSParser::parseFillProperty.
I added the ASSERT to fix the compilation about values not handled in the switch. I supposed the callers
were only property ids handled in the switch case. It wasn't the case, so I'm restoring the old behavior
while keeping the code to compile (it still need a deeper investigation but let fix the bots quickly).

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillProperty):

9:11 AM Changeset in webkit [113045] by leviw@chromium.org
  • 9 edits in branches/subpixellayout/Source/WebCore/rendering

Removing unnecessary explicit toInt calls in AutoTableLayout, removing unnecssary flooring for Captions in RenderTable and correcting some incorrect int usage for Baselines, removing unnecessary usage of LayoutUnits for shadow blur and spread (which are integers), and correcting a context translate at FractionalLayoutUnit bounds in RenderBoxModelObject. Also changing cachedSizeForOverflowClip to return LayoutUnits, as its actual data type was, and as it was always used.

9:02 AM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
9:00 AM Changeset in webkit [113044] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, another test-webkitpy fix-up after r113037.

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock

crash dump depending on current environment.

8:55 AM Changeset in webkit [113043] by schenney@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

Expectations update after 65072
https://bugs.webkit.org/show_bug.cgi?id=65072

Unreviewed Chromium expectations update.

  • platform/chromium-linux/svg/text/ems-display-none-expected.png: Added.
  • platform/chromium-linux/svg/text/exs-display-none-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Added.
  • platform/chromium-mac/svg/text/ems-display-none-expected.png: Added.
  • platform/chromium-mac/svg/text/exs-display-none-expected.png: Added.
  • platform/chromium-win/svg/text/ems-display-none-expected.png: Added.
  • platform/chromium-win/svg/text/ems-display-none-expected.txt: Added.
  • platform/chromium-win/svg/text/exs-display-none-expected.png: Added.
  • platform/chromium-win/svg/text/exs-display-none-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:47 AM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
8:46 AM Changeset in webkit [113042] by alexis.menard@openbossa.org
  • 7 edits in trunk/Source/WebCore

[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83032

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(CSSPropertyInfo):
(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(CSSPropertyInfo):
(WebCore::cssPropertyInfo):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):
(WebCore::counterToCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive):
Remove the parameter's name from the h file as it doesn't follow the style and also because the
name was simply wrong we don't expect a propId here but an indentifier. Make it clear in the
cpp file too.

  • css/CSSParser.h:

(CSSParser):

  • page/animation/AnimationBase.cpp:

(WebCore::addPropertyWrapper):

8:45 AM Changeset in webkit [113041] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT(!(outputBytes.size() % sizeof(UChar))) in PluginProcessProxyQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=83034

Reviewed by Zoltan Herczeg.

Don't allow the plugin to pollute the standard output.
Reinvent StdOutDevNullRedirector which was removed in
r112889 for this purpose.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::NetscapePluginModule::scanPlugin):

8:37 AM Changeset in webkit [113040] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, test-webkitpy build fix after r113037.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._get_crash_log):

8:33 AM Changeset in webkit [113039] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: remove unused references to TimelineCalculator
https://bugs.webkit.org/show_bug.cgi?id=83025

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineRecordListRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

8:33 AM Changeset in webkit [113038] by tomz@codeaurora.org
  • 2 edits
    59 adds in trunk/LayoutTests

Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03
Reviewed by Adam Barth.

Adding 57 pixel tests for IETC backgrounds and borders. Modified chromium
tests expectations, will pull the MISSING FAIL lines when we get good
expected results from the bots. Also renaming 'ahem.ttf' to 'Ahem.ttf' to deal with
case-insensitive filesystem issue.

  • ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-size-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background_color_padding_box.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-clip-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-style-003.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-style-004.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-style-005.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/box-shadow-001.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/box-shadow-002.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/box-shadow-003.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/box-shadow-004.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/color-behind-images.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm: Added.
  • ietestcenter/css3/bordersbackgrounds/order-of-images.htm: Added.
  • ietestcenter/css3/support/Ahem.ttf: Renamed from LayoutTests/ietestcenter/css3/support/ahem.ttf.
  • ietestcenter/css3/support/orange_color.png: Added.
  • platform/chromium/test_expectations.txt:
8:23 AM Changeset in webkit [113037] by Philippe Normand
  • 6 edits
    5 deletes in trunk/Tools

[GTK] crash log reports support
https://bugs.webkit.org/show_bug.cgi?id=81659

Reviewed by Martin Robinson.

Removed the daemontools crashmon/xvfb scripts and implemented the crash
log reporting in the NRWT Gtk port. To get proper crash logs one
needs to set the core pattern like this:
echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
environment variable.

  • BuildSlaveSupport/gtk/README:
  • BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
  • BuildSlaveSupport/gtk/crashmon/log/run: Removed.
  • BuildSlaveSupport/gtk/crashmon/run: Removed.
  • BuildSlaveSupport/gtk/daemontools-buildbot.conf:
  • BuildSlaveSupport/gtk/xvfb/log/run: Removed.
  • BuildSlaveSupport/gtk/xvfb/run: Removed.
  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver.stop):
(GtkPort.show_results_html_file):
(GtkPort):
(GtkPort._get_gdb_output):
(GtkPort._get_crash_log):
(GtkPort._get_crash_log.match_filename):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):
(test_show_results_html_file):
(assertLinesEqual):
(_mock_gdb_output):
(test_get_crash_log):

8:22 AM Changeset in webkit [113036] by schenney@chromium.org
  • 5 edits
    4 deletes in trunk/LayoutTests

More unreviewed mac rebaselines
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-03

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
8:16 AM Changeset in webkit [113035] by Philippe Normand
  • 4 edits in trunk/LayoutTests

[GTK] svg/zoom/page/zoom-svg-through-object-with-auto-size.html is flaky on 32-bits Release
https://bugs.webkit.org/show_bug.cgi?id=68523

Unreviewed, unskip tests passing locally, they aren't flaky
anymore, from the test runs I performed locally.

  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/gtk/test_expectations.txt:
8:03 AM Changeset in webkit [113034] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Call incrementStatsCounter directly
https://bugs.webkit.org/show_bug.cgi?id=83023

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.

Source/WebCore:

  • bindings/v8/V8Proxy.h:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::WebFrameImpl):

7:48 AM Changeset in webkit [113033] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying
https://bugs.webkit.org/show_bug.cgi?id=83013

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-03
Reviewed by Stephen White.

Source/WebCore:

We need to flush the GPU command queue after copying the canvas back
buffer into the front buffer. Otherwise the copy might be delayed to a
point where new contents have already been drawn into the back buffer,
leading to flickering.

Added test to Canvas2DLayerChromiumTest.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp: Make sure context is flushed after copying.
7:29 AM Changeset in webkit [113032] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add provisional save method into the frontend client.
https://bugs.webkit.org/show_bug.cgi?id=83022

Reviewed by Yury Semikhatsky.

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::save):

7:18 AM Changeset in webkit [113031] by alexis.menard@openbossa.org
  • 36 edits in trunk/Source

[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82977

Reviewed by Andreas Kling.

Source/WebCore:

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. Almost everything has been changed with the exception of the Animation related
classes which can be done in a following patch.

No new tests : There should be no behavior change in this patch.

  • WebCore.exp.in:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssText):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
(WebCore::CSSComputedStyleDeclaration::item):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::isColorPropertyID):
(WebCore::parseColorValue):
(WebCore::isSimpleLengthPropertyID):
(WebCore::parseSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSize):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):

  • css/CSSParser.h:

(CSSParser):
(WebCore::ShorthandScope::ShorthandScope):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):
(CSSProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:

(WebCore):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • editing/EditingStyle.cpp:

(HTMLElementEquivalent):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::setProperty):

  • editing/EditingStyle.h:

(WebCore::EditingStyle::create):
(EditingStyle):

  • editing/Editor.cpp:

(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):

  • editing/Editor.h:

(Editor):

  • editing/EditorCommand.cpp:

(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeToggleStyle):
(WebCore::executeApplyParagraphStyle):
(WebCore::stateStyle):

  • editing/markup.cpp:

(WebCore):
(WebCore::propertyMissingOrEqualToNone):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLElement.h:

(HTMLElement):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties):

  • svg/SVGFontFaceElement.cpp:

(WebCore::cssPropertyIdForSVGAttributeName):
(WebCore::SVGFontFaceElement::parseAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::mapAttributeToCSSProperty):
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::svgAttributeChanged):
(WebCore::SVGStyledElement::getPresentationAttribute):

  • svg/SVGStyledElement.h:

(WebCore):
(SVGStyledElement):

Source/WebKit/qt:

Update the code to use CSSPropertyID rather than an integer.

  • Api/qwebelement.cpp:

(QWebElement::setStyleProperty):

6:55 AM Changeset in webkit [113030] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

Revert RenderTheme paint and layout functions to ints
https://bugs.webkit.org/show_bug.cgi?id=82196

Reviewed by Julien Chaffraix.

When dealing with object that are rendered outside of WebCore, we do all necessary pixel snapping
before passing coordinates to the external code. RenderTheme encompasses a set of objects whose
rendering is influenced by the platform. This change reverts the interface between this platform
code and WebCore to be integers.

Some platforms, such as Mac, use sub-pixel units for layout and rendering, but it's still not
desirable to pass sub-pixel values to these API's, because ultimately we'll render these objects
at whole-pixel values to avoid anti-aliasing.

Marking touched overridden virtual functions as OVERRIDE. There are many more to update.

No new tests. No change in behavior.

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::pixelSnappedLocation): Convenience function.
(WebCore::FractionalLayoutRect::pixelSnappedSize): Ditto.
(FractionalLayoutRect):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::pixelSnappedLocation): Temporary mirrors to the functions of the same name on
FractionalLayoutRect.
(WebCore::IntRect::pixelSnappedSize): Ditto.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Adding a local pixel snapped paint rect to avoid
repeated pixel snapping.

  • rendering/RenderBox.h:

(WebCore::RenderBox::absoluteContentBox): Reverting to integers since this represents on-screen
coordinates
(WebCore::RenderBox::pixelSnappedSize): Convenience method.

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): This static function is only called
from RenderTheme platform code. Changing it to operate on pixel snapped values since we don't want
to pipe LayoutUnits through that code.

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::computeLogicalWidth): Changing to feed pixel snapped values into the platform
code to properly determine the resulting meter size.
(WebCore::RenderMeter::computeLogicalHeight): Ditto.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):

  • rendering/RenderTheme.h:

(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

6:39 AM Changeset in webkit [113029] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

chromium: fast/dom/error-to-string-stack-overflow.html is failing after v8 roll to 3.10.0.2
https://bugs.webkit.org/show_bug.cgi?id=82993

Adjust test expectation to include the line number of the exception.

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.

  • platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
6:24 AM Changeset in webkit [113028] by jocelyn.turcotte@nokia.com
  • 12 edits in trunk

Enable and connect the WebInspectorServer with WebKit2 pages.
https://bugs.webkit.org/show_bug.cgi?id=73094

Reviewed by Simon Hausmann.

Source/WebKit2:

Pages are registered/unregistered as they are created/destroyed, if they have
developer extras enabled. The server is run on the UI process and communicates
with the web process through IPC for each message between the inspector
controller and the remote frontend.

Includes the server spawning logic for the Qt port, the server is
started through an environment variable specifying the interface and
port to bind the server to, by default on 127.0.0.1.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit):
(WebKit::WebInspectorProxy::enableRemoteInspection):
(WebKit::WebInspectorProxy::remoteFrontendConnected):
(WebKit::WebInspectorProxy::remoteFrontendDisconnected):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::sendMessageToRemoteFrontend):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):

  • UIProcess/qt/QtWebContext.cpp:

(WebKit::initInspectorServer):
(WebKit):
(WebKit::globalInitialization):
(WebKit::QtWebContext::create):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::sendMessageToFrontend):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit):
(WebKit::WebInspector::sendMessageToRemoteFrontend):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):
(WebKit::WebInspector::hasRemoteFrontendConnected):

  • WebProcess/WebPage/WebInspector.messages.in:

Tools:

Enable developer extras on pages in MiniBrowser for Qt.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
6:24 AM Changeset in webkit [113027] by jocelyn.turcotte@nokia.com
  • 2 edits
    6 adds in trunk/Source/WebKit2

WebInspectorServer for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=73855

Reviewed by Simon Hausmann.

The server uses WebSocket for communication with the remote client and
normal HTTP requests are handled to optionally send the frontend on the
wire. Those decision are handled per platform and Qt currently maps:

  • "/" to a static listing page.
  • "/pagelist.json" to the page list for the listing page or tools.
  • anything else, for example "/inspector.js" to the file with the same name in the dynamic libraries built resources. Invalid files should return a 404.
  • Target.pri:
  • UIProcess/InspectorServer/WebInspectorServer.cpp: Added.

(WebKit):
(WebKit::pageIdFromRequestPath):
(WebKit::WebInspectorServer::server):
(WebKit::WebInspectorServer::WebInspectorServer):
(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):
(WebKit::WebInspectorServer::unregisterPage):
(WebKit::WebInspectorServer::sendMessageOverConnection):
(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebInspectorServer::didEstablishWebSocketConnection):
(WebKit::WebInspectorServer::didReceiveWebSocketMessage):
(WebKit::WebInspectorServer::didCloseWebSocketConnection):
(WebKit::WebInspectorServer::closeConnection):

  • UIProcess/InspectorServer/WebInspectorServer.h: Added.

(WebKit):
(WebInspectorServer):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Added.

(WebKit):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):

  • WebKit2.qrc: Added.
  • qt/Resources/inspectorPageIndex.html: Added.
6:24 AM Changeset in webkit [113026] by jocelyn.turcotte@nokia.com
  • 8 edits
    9 adds in trunk/Source

Add a Generic WebSocket Server.
https://bugs.webkit.org/show_bug.cgi?id=73093

Reviewed by Simon Hausmann.

Source/WebCore:

Allow SocketStreamHandle for the Qt port to take an existing QTcpSocket in its constructor.

  • platform/network/qt/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(SocketStreamHandle):

  • platform/network/qt/SocketStreamHandlePrivate.h:

(SocketStreamHandlePrivate):

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore):
(WebCore::SocketStreamHandlePrivate::initConnections):
(WebCore::SocketStreamHandlePrivate::close):
(WebCore::SocketStreamHandle::SocketStreamHandle):

Source/WebKit2:

The Inspector Server will be a WebSocket Server that also responds to
non-WebSocket-Upgrade HTTP Requests. This is a generic WebSocket server
that passes on what it doesn't know on to its client for extended
functionality. This code is wrapped in a new ENABLE(INSPECTOR_SERVER) flag.

There are no tests yet for a built-in WebSocket server.
This will be covered by API level tests in a later patch.

  • Target.pri:

WebSocketServer is a simple server. Calling listen, or close,
multiple times is safe. Subclassing is expected.

  • UIProcess/InspectorServer/WebSocketServer.cpp: Added.

(WebKit):
(WebKit::WebSocketServer::WebSocketServer):
(WebKit::WebSocketServer::~WebSocketServer):
(WebKit::WebSocketServer::listen):
(WebKit::WebSocketServer::close):
(WebKit::WebSocketServer::didAcceptConnection):
(WebKit::WebSocketServer::didCloseWebSocketServerConnection):

  • UIProcess/InspectorServer/WebSocketServer.h: Added.

(WebKit):
(WebCore):
(WebSocketServer):

  • UIProcess/InspectorServer/WebSocketServerClient.h: Added.

(WebCore):
(WebKit):
(WebSocketServerClient):
(WebKit::WebSocketServerClient::~WebSocketServerClient):
(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):
(WebKit::WebSocketServerClient::didReceiveWebSocketMessage):
(WebKit::WebSocketServerClient::didCloseWebSocketConnection):

Each WebSocketConnection:

  • Passes unknown HTTP Requests to the server's client.
  • Handles WebSocket Upgrade Requests.
    • First ask the client if it is okay.
    • Later notify the client about a success.
  • Once upgraded the connection parses and passes WebSocket frames to the client.
  • UIProcess/InspectorServer/WebSocketServerConnection.cpp: Added.

(WebKit):
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::~WebSocketServerConnection):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::shutdownAfterSendOrNow): meant to shutdown after an HTTP response. Ensure all platforms work as expected.
(WebKit::WebSocketServerConnection::sendWebSocketMessage): send a text message (WebSocket message) over the connection.
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData): send raw data (HTTP message) over the connection.
(WebKit::WebSocketServerConnection::didCloseSocketStream): handle socket closing scenarios.
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData): parse the incoming data in HTTP / WebSocket modes.
(WebKit::WebSocketServerConnection::didFailSocketStream): log errors.
(WebKit::WebSocketServerConnection::readHTTPMessage): when starting, a web socket connection reads an HTTP message.
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):
(WebKit::WebSocketServerConnection::readWebSocketFrames): parse our buffer for as many frames as possible.
(WebKit::WebSocketServerConnection::readWebSocketFrame): parse an individual frame.

  • UIProcess/InspectorServer/WebSocketServerConnection.h: Added.

(WebCore):
(WebKit):
(WebSocketServerConnection):
(WebKit::WebSocketServerConnection::identifier):
(WebKit::WebSocketServerConnection::setIdentifier):

Qt specific implementation.

  • UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Added.

(WebKit):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):
(WebKit::QtTcpServerHandler::QtTcpServerHandler):
(WebKit::QtTcpServerHandler::handleNewConnection):
(WebKit::QtTcpServerHandler::listen):
(WebKit::QtTcpServerHandler::close):

  • UIProcess/InspectorServer/qt/WebSocketServerQt.h: Added.

(WebKit):
(QtTcpServerHandler):

  • WebKit2.pri:
  • config.h: Add ENABLE(INSPECTOR_SERVER) for WebKit2.
6:23 AM Changeset in webkit [113025] by jocelyn.turcotte@nokia.com
  • 12 edits
    1 add in trunk/Source/WebCore

Expose reusable WebSocket code for WebSocketServer.
https://bugs.webkit.org/show_bug.cgi?id=73852

Reviewed by Kent Tamura.

Keep the majority the web socket handshake HTTP request and response logic
inside WebSocketHandshake and expose it through WebSocketFrame to make it
available for the web socket server implementation.

This also re-add the masking code that was removed in r111829 since it is
needed for the server implementation.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore):
(WebCore::WebSocketChannel::processFrame): now using WebSocketChannel::parseFrame. Extracted the !frame.masked check.
(WebCore::WebSocketChannel::sendFrame):

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):

  • Modules/websockets/WebSocketFrame.cpp: Added.

(WebCore):
(WebCore::WebSocketFrame::needsExtendedLengthField):
(WebCore::WebSocketFrame::parseFrame): moved from WebSocketChannel::parseFrame.
(WebCore::appendMaskedFramePayload):
(WebCore::WebSocketFrame::makeFrameData): moved from makeFrameData in WebSocketChannel.cpp.
(WebCore::WebSocketFrame::WebSocketFrame): moved from the header.

  • Modules/websockets/WebSocketFrame.h:

(WebSocketFrame):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::getExpectedWebSocketAccept): expose this object-static function.

  • Modules/websockets/WebSocketHandshake.h:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
6:23 AM Changeset in webkit [113024] by jocelyn.turcotte@nokia.com
  • 14 edits
    1 copy
    1 add in trunk/Source/WebCore

Add Generic HTTP Request Class. Generalized HTTP Parsing.
https://bugs.webkit.org/show_bug.cgi?id=73092

Reviewed by Simon Hausmann.

A WebSocket server will need to read HTTP Requests before upgrading
to WebSocket framing. This patch creates a cross-platform HTTPRequest
class. Since some of this was already done in WebSocket code:

  • the header parsing code was extracted and put into HTTPParsers.cpp
  • WebSocketHandshakeRequest subclasses HTTPRequest
  • WebSocket code was refactored for these changes

Refactoring is covered by existing http/tests/websocket tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):

Extract the HTTP Header parsing out of WebSocketHandshake and
put it into HTTP Parsers. Now make use of the generic parsing.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore):
(WebCore::trimInputSample):
(WebCore::WebSocketHandshake::clientHandshakeRequest): switch to RefCounted HandshakeRequest.
(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders): use generic HTTPParsers parsing.

  • Modules/websockets/WebSocketHandshake.h: switch to RefCounted HandshakeRequest.

WebSocketHandshakeRequest is a specialization of an HTTPRequest.
Much of its original code was abstracted into HTTPRequest, and
this is now a subclass with WebSocket key information.

  • Modules/websockets/WebSocketHandshakeRequest.cpp:

(WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): initialize now calls super.

  • Modules/websockets/WebSocketHandshakeRequest.h:

(WebCore::WebSocketHandshakeRequest::create): switch to being ref counted like HTTPRequest.
(WebSocketHandshakeRequest):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add generic HTTP Request parsing functions to HTTPParsers.cpp.
Use out parameters to get values after parsing.

  • platform/network/HTTPParsers.cpp:

(WebCore):
(WebCore::trimInputSample): taken from WebSocket parsing.
(WebCore::parseHTTPRequestLine): new code, parse a request line.
(WebCore::parseHTTPHeaders): taken from previous WebSocket parsing. Algorithm unchanged.
(WebCore::parseHTTPRequestBody): new code, just copy the date into the provided buffer.

  • platform/network/HTTPParsers.h:

(WebCore):

This adds a general HTTPRequest class. Accessors for the
request method, url, httpVersion, headers, and data. You can
create an HTTPRequest using the constructor, or parse one
from a data buffer, such as one read from a socket.

  • platform/network/HTTPRequest.cpp: Added.

(WebCore):
(WebCore::HTTPRequest::parseHTTPRequestFromBuffer): create an HTTPRequest by parsing data in a buffer.
(WebCore::HTTPRequest::parseRequestLine): helper to initialize members while parsing.
(WebCore::HTTPRequest::parseHeaders): helper to initialize members while parsing.
(WebCore::HTTPRequest::parseRequestBody): helper to initialize members while parsing.
(WebCore::HTTPRequest::HTTPRequest):
(WebCore::HTTPRequest::~HTTPRequest):

  • platform/network/HTTPRequest.h: Added.

(WebCore):
(HTTPRequest):
(WebCore::HTTPRequest::create): create an empty request, or specify details.
(WebCore::HTTPRequest::requestMethod):
(WebCore::HTTPRequest::setRequestMethod):
(WebCore::HTTPRequest::url):
(WebCore::HTTPRequest::setURL):
(WebCore::HTTPRequest::body):
(WebCore::HTTPRequest::headerFields):
(WebCore::HTTPRequest::addHeaderField):

6:22 AM Changeset in webkit [113023] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Add a missing inspector front-end image to resources.

Reviewed by Simon Hausmann.

  • inspector/front-end/WebKit.qrc:
6:22 AM Changeset in webkit [113022] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] Add developerExtrasEnabled to QWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=83018

Reviewed by Kenneth Rohde Christiansen.

This is required to allow inspecting pages.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::developerExtrasEnabled):
(QWebPreferences::setDeveloperExtrasEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
6:13 AM Changeset in webkit [113021] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] All plugin tests are failing on buildbot
https://bugs.webkit.org/show_bug.cgi?id=83024

Unreviewed gardening. Skip plugin tests until fix.

  • platform/qt-5.0-wk2/Skipped:
6:06 AM Changeset in webkit [113020] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Gtk fails media/video-source-error.html (due to trailing whitespace?)
https://bugs.webkit.org/show_bug.cgi?id=30198

Patch by Simon Pena <Simon Pena> on 2012-04-03
Reviewed by Philippe Normand.

Unskip offending test, since it is now passing without errors.

  • platform/gtk/Skipped: Unskip media/video-source-error.html
5:59 AM Changeset in webkit [113019] by commit-queue@webkit.org
  • 10 edits
    6 copies
    2 adds in trunk

Soup HTTP backend does not send Content-Length in certain cases
https://bugs.webkit.org/show_bug.cgi?id=82036

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-03
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Telling soup explicitly when to send content-length header
in POST & PUT cases in order to align with e.g. Chromium and FF.

No new tests, already covered by *methods*.html in
http/tests/xmlhttprequest/.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::startHTTPRequest): Special handling for POST & PUT.

LayoutTests:

Rebaselining and unskipping relevant tests for EFL.
Rebaselining POST and PUT cases for GTK.

  • platform/efl/Skipped:
  • platform/efl/http/tests/xmlhttprequest/methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt.
  • platform/efl/http/tests/xmlhttprequest/methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/methods-expected.txt.
  • platform/efl/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt.
  • platform/efl/http/tests/xmlhttprequest/workers/methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt.
  • platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt.
  • platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/methods-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt:
5:56 AM Changeset in webkit [113018] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] LayoutTestController needs implementation of setDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=82890

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-03
Reviewed by Philippe Normand.

Source/WebKit/efl:

Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setDefersLoading):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController implements setDefersLoading().

  • platform/efl/Skipped:
5:16 AM Changeset in webkit [113017] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppress compositing/reflections/nested-reflection-transformed2.html on Win Debug.

  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [113016] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Simplify CSSStyleSelector constructor through the use of a helper function
https://bugs.webkit.org/show_bug.cgi?id=82940

Reviewed by Andreas Kling.

No behavior change, thus no tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

5:11 AM Changeset in webkit [113015] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] LayoutTestController needs implementation of goBack
https://bugs.webkit.org/show_bug.cgi?id=81914

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-03
Reviewed by Philippe Normand.

Tools:

Implement goBack() in EFL's LayoutTestController by calling
ewk_frame_back().

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::goBack):

LayoutTests:

Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController supports goBack().

  • platform/efl/Skipped:
5:08 AM Changeset in webkit [113014] by kbalazs@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt][WK2] Failing http/tests/plugins tests after reenabled plugins
https://bugs.webkit.org/show_bug.cgi?id=82895

Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
5:07 AM Changeset in webkit [113013] by yurys@chromium.org
  • 15 edits in trunk/Source/WebCore

Web Inspector: Database::Database::id field in the protocol should have type integer not string
https://bugs.webkit.org/show_bug.cgi?id=83003

Reviewed by Pavel Feldman.

Changed DOM storage and database identifier type from int to String. This
is aligned with other domains and gives us more flexibility.

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::databaseId):
(WebCore::JSInjectedScriptHost::storageId):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):

  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):

  • inspector/InspectorDOMStorageAgent.h:

(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::bind):

  • inspector/InspectorDOMStorageResource.h:

(WebCore::InspectorDOMStorageResource::id):
(InspectorDOMStorageResource):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

  • inspector/InspectorDatabaseResource.cpp:

(WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
(WebCore::InspectorDatabaseResource::bind):

  • inspector/InspectorDatabaseResource.h:

(WebCore::InspectorDatabaseResource::id):
(InspectorDatabaseResource):

5:06 AM Changeset in webkit [113012] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap highlight attempted hidden several times
https://bugs.webkit.org/show_bug.cgi?id=82903

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-03
Reviewed by Kenneth Rohde Christiansen.

Do not reset GestureRecognizer if already reset, and do not
disable tap-highlight on touch-end if already reset.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::reset):

5:05 AM Changeset in webkit [113011] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=82589

Source/WebKit/efl:

Add missing implementation for pageSizeAndMarginsInPixels to EFL's
DumpRenderTreeSupport.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-03
Reviewed by Philippe Normand.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
in order to unskip printing/page-format-data.html

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-03
Reviewed by Philippe Normand.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pageSizeAndMarginsInPixels):

5:01 AM Changeset in webkit [113010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap highlight still showing when tap gesture has timed out
https://bugs.webkit.org/show_bug.cgi?id=82902

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-03
Reviewed by Kenneth Rohde Christiansen.

Disable highlight of potential tap, when tap-and-hold state
replaces potential tap state.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

4:26 AM Changeset in webkit [113009] by Nikolas Zimmermann
  • 15 edits in trunk/Source/WebCore

2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>

Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Rubber-stamped by Zoltan Herczeg.

Make highestEnumValue() return an unsigned to avoid casting in SVGAnimatedEnumerationPropertyTearOff.
Fixes the last chromium build failure on the debug carnary bots.

  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGUnitTypes.h:
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: (WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
3:36 AM Changeset in webkit [113008] by Nikolas Zimmermann
  • 10 edits in trunk

Animate animatedPoints instead of points for SVGPoly*Elements
https://bugs.webkit.org/show_bug.cgi?id=82844

Reviewed by Dirk Schulze.

Source/WebCore:

When the points attribute of a SVGPoly*Element is animated, we should animate
the 'animatedPoints' SVG DOM property, not the 'points' property, which corresponds
to the "baseVal". Fix that, now only the 'd' attribute for SVGPathElement is incorrect,
everything else is moved to the new animVal concept!

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPointListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPointListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPointListAnimator::animValWillChange):
(WebCore::SVGAnimatedPointListAnimator::animValDidChange):

  • svg/SVGAnimatedPointList.h:

(SVGAnimatedPointListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::SVGPolyElement::points):
(WebCore::SVGPolyElement::animatedPoints):

LayoutTests:

Update SVGPointList animation tests, verifying that animatedPoints is animated, and not points.

  • svg/animations/script-tests/svgpointlist-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgpointlist-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svgpointlist-animation-1-expected.txt:
  • svg/animations/svgpointlist-animation-2-expected.txt:
3:27 AM Changeset in webkit [113007] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] media/video-volume.html fails on 32-bits debug
https://bugs.webkit.org/show_bug.cgi?id=50389

Unreviewed, unskip the test, it's passing locally. We'll keep an
eye on the bots.

  • platform/gtk/Skipped:
3:26 AM Changeset in webkit [113006] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Next chromium build fix, this time for real :-)

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: (WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal): Cast highestEnumValue to unsigned.
3:19 AM Changeset in webkit [113005] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix chromium build.

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Unsigned is always >= 0 - only check if its 0 here. (WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
2:57 AM Changeset in webkit [113004] by apavlov@chromium.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r112954 and r112969.
http://trac.webkit.org/changeset/112954
http://trac.webkit.org/changeset/112969
https://bugs.webkit.org/show_bug.cgi?id=79172

Hits "ASSERTION FAILED: !m_isHandlingDrag" in DnD-related
tests on Debug bots

Source/WebCore:

  • page/DragController.cpp:

(WebCore::DragController::performDrag):

LayoutTests:

  • fast/events/drag-dataTransferItemList.html:
  • fast/events/drop-handler-should-not-stop-navigate-expected.txt: Removed.
  • fast/events/drop-handler-should-not-stop-navigate.html: Removed.
  • http/tests/security/clipboard/clipboard-file-access.html:
2:39 AM Changeset in webkit [113003] by Nikolas Zimmermann
  • 47 edits
    49 adds in trunk

2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>

Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.

  • platform/gtk/Skipped: Unskip svgenum tests.
  • svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
  • svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
  • svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
  • svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
  • svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
  • svg/animations/animate-marker-orient-to-angle.html: Added.
  • svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-marker-orient-to-angle.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample1): (sample2): (sample3):
  • svg/animations/script-tests/svgenum-animation-1.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svgenum-animation-10.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svgenum-animation-11.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
  • svg/animations/script-tests/svgenum-animation-12.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgenum-animation-13.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/svgenum-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgenum-animation-3.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svgenum-animation-4.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (sample6): (executeTest):
  • svg/animations/script-tests/svgenum-animation-5.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svgenum-animation-6.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/svgenum-animation-7.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svgenum-animation-8.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
  • svg/animations/script-tests/svgenum-animation-9.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/svgangle-animation-deg-to-grad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-rad-expected.txt:
  • svg/animations/svgangle-animation-grad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-grad-to-rad-expected.txt:
  • svg/animations/svgangle-animation-rad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-rad-to-grad-expected.txt:
  • svg/animations/svgenum-animation-1-expected.txt: Added.
  • svg/animations/svgenum-animation-1.html: Added.
  • svg/animations/svgenum-animation-10-expected.txt: Added.
  • svg/animations/svgenum-animation-10.html: Added.
  • svg/animations/svgenum-animation-11-expected.txt: Added.
  • svg/animations/svgenum-animation-11.html: Added.
  • svg/animations/svgenum-animation-12-expected.txt: Added.
  • svg/animations/svgenum-animation-12.html: Added.
  • svg/animations/svgenum-animation-13-expected.txt: Added.
  • svg/animations/svgenum-animation-13.html: Added.
  • svg/animations/svgenum-animation-2-expected.txt: Added.
  • svg/animations/svgenum-animation-2.html: Added.
  • svg/animations/svgenum-animation-3-expected.txt: Added.
  • svg/animations/svgenum-animation-3.html: Added.
  • svg/animations/svgenum-animation-4-expected.txt: Added.
  • svg/animations/svgenum-animation-4.html: Added.
  • svg/animations/svgenum-animation-5-expected.txt: Added.
  • svg/animations/svgenum-animation-5.html: Added.
  • svg/animations/svgenum-animation-6-expected.txt: Added.
  • svg/animations/svgenum-animation-6.html: Added.
  • svg/animations/svgenum-animation-7-expected.txt: Added.
  • svg/animations/svgenum-animation-7.html: Added.
  • svg/animations/svgenum-animation-8-expected.txt: Added.
  • svg/animations/svgenum-animation-8.html: Added.
  • svg/animations/svgenum-animation-9-expected.txt: Added.
  • svg/animations/svgenum-animation-9.html: Added.

2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>

Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.

One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.

This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.

Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>

at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 90

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO

someMarkerElement.orientAngle.animVal.value = 0

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.

Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.

Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html

svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determineAnimatedPropertyType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::propertyTypesAreConsistent): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimatedAngle.cpp: (WebCore::SVGAnimatedAngleAnimator::constructFromString): (WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation): (WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal): (WebCore::SVGAnimatedAngleAnimator::animValWillChange): (WebCore::SVGAnimatedAngleAnimator::animValDidChange): (WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
  • svg/SVGAnimatedAngle.h: (WebCore):
  • svg/SVGAnimatedBoolean.cpp: (WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation): (WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedEnumeration.cpp: Added. (WebCore): (WebCore::enumerationValueForTargetAttribute): (WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator): (WebCore::SVGAnimatedEnumerationAnimator::constructFromString): (WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation): (WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal): (WebCore::SVGAnimatedEnumerationAnimator::animValWillChange): (WebCore::SVGAnimatedEnumerationAnimator::animValDidChange): (WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):
  • svg/SVGAnimatedEnumeration.h: (SVGAnimatedEnumerationAnimator): (WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator): (WebCore):
  • svg/SVGAnimatedInteger.cpp: (WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation): (WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedIntegerOptionalInteger.cpp: (WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation): (WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal): (WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange): (WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation): (WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedLengthList.cpp: (WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation): (WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation): (WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation): (WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedNumberOptionalNumber.cpp: (WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
  • svg/SVGAnimatedPreserveAspectRatio.cpp: (WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedRect.cpp: (WebCore::SVGAnimatedRectAnimator::startAnimValAnimation): (WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedString.cpp: (WebCore::SVGAnimatedStringAnimator::startAnimValAnimation): (WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedTransformList.cpp: (WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation): (WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation): (WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
  • svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createAngleAndEnumeration): (WebCore::SVGAnimatedType::createEnumeration): (WebCore): (WebCore::SVGAnimatedType::angleAndEnumeration): (WebCore::SVGAnimatedType::enumeration): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): (WebCore::SVGAnimatedType::supportsAnimVal):
  • svg/SVGAnimatedType.h: (SVGAnimatedType):
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName): (SVGAnimatedTypeAnimator): (WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue): (WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue): (WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType): (WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType): (WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType): (WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues): (WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues): (WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes): (WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes): (WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes): (WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType): (WebCore::SVGAnimatedTypeAnimator::executeAction):
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGMarkerElement.cpp: (WebCore):
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (SVGAnimatedListPropertyTearOff):
  • svg/properties/SVGAnimatedPropertyTearOff.h: (SVGAnimatedPropertyTearOff):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (SVGAnimatedStaticPropertyTearOff):
2:24 AM Changeset in webkit [113002] by commit-queue@webkit.org
  • 10 edits
    29 deletes in trunk

Unreviewed, rolling out r112987 and r112993.
http://trac.webkit.org/changeset/112987
http://trac.webkit.org/changeset/112993
https://bugs.webkit.org/show_bug.cgi?id=83010

hits ASSERTs in Debug builds (Requested by philn-tp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-03

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):

  • dom/Document.h:

(Document):

  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):

  • html/HTMLIFrameElement.idl:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::defaultForInitial):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::outgoingReferrer):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Removed.
  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Removed.
  • fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Removed.
  • fast/frames/srcdoc/setting-src-does-nothing.html: Removed.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Removed.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Removed.
  • fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-beats-src-dom.html: Removed.
  • fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-beats-src.html: Removed.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Removed.
  • fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-can-navigate.html: Removed.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Removed.
  • fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-loads-content.html: Removed.
  • fast/frames/srcdoc/srcdoc-urls-expected.txt: Removed.
  • fast/frames/srcdoc/srcdoc-urls.html: Removed.
  • http/tests/security/srcdoc-can-access-parent-expected.txt: Removed.
  • http/tests/security/srcdoc-can-access-parent.html: Removed.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Removed.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Removed.
  • http/tests/security/srcdoc-inherits-referrer-expected.txt: Removed.
  • http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Removed.
  • http/tests/security/srcdoc-inherits-referrer-for-forms.html: Removed.
  • http/tests/security/srcdoc-inherits-referrer.html: Removed.
  • platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Removed.
2:20 AM Changeset in webkit [113001] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] DRT missing didRunInsecureContent notification
https://bugs.webkit.org/show_bug.cgi?id=59367

Patch by Simon Pena <Simon Pena> on 2012-04-03
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a new signal "insecure-content-run" to the WebFrame to notify
when insecure HTTP content (such as CSS, an iframe or a script) is
run from a secure HTTPS WebFrame. Implement didRunInsecureContent
in gtk's FrameLoaderClient by means of emitting that signal.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: Implement

didRunInsecureContent by emitting WebFrame's
"insecure-content-run" signal
(WebKit::FrameLoaderClient::didRunInsecureContent):

  • webkit/webkitwebframe.cpp: Add "insecure-content-run" signal

(webkit_web_frame_class_init):

Tools:

Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
the main WebFrame or any other WebFrame created later. Added
"didRunInsecureContent" notification in the callback in order to
get the LayoutTests passing.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: Connect

to WebFrame's "insecure-content-run" signal and add
didRunInsecureContent notification in the callback to get the
LayoutTests passing.
(didRunInsecureContent):
(createWebView):

LayoutTests:

Unskip tests as new API is added to detect when a secure HTTPS page
loads content (such as CSS, images, iframes or a script) from
a non-secure HTTP origin.

  • platform/gtk/Skipped: Unskip insecure-css-in-main-frame,

insecure-css-in-iframe, insecure-image-in-main-frame,
insecure-script-in-iframe, insecure-plugin-in-iframe,
redirect-http-to-https-script-in-iframe and
redirect-https-to-http-script-in-iframe since they pass after the
new API has been added.

2:16 AM Changeset in webkit [113000] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r112954.

Patch by János Badics <János Badics> on 2012-04-03

  • platform/qt/Skipped: Skip fast/events/drop-handler-should-not-stop-navigate.html because of missing drag and drop support.
2:08 AM Changeset in webkit [112999] by bashi@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Fallback fonts should be used while a web font is being loaded
https://bugs.webkit.org/show_bug.cgi?id=76684

Reviewed by Ojan Vafai.

Add the test which should have been submitted with r112489.

  • http/tests/webfont/fallback-font-while-loading-expected.txt: Added.
  • http/tests/webfont/fallback-font-while-loading.html: Added.
  • http/tests/webfont/slow-ahem-loading.cgi: Added.
1:53 AM Changeset in webkit [112998] by apavlov@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, disable inspector/styles/override-screen-size.html on platforms other than Chromium.
Related bug: https://bugs.webkit.org/show_bug.cgi?id=82886

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
1:45 AM Changeset in webkit [112997] by bbudge@chromium.org
  • 6 edits in trunk

REGRESSION (r112217): H&R Block tax site won't load
https://bugs.webkit.org/show_bug.cgi?id=82964

Source/WebCore:

Modifies the redirect checking code to first check if the security origin can
request the redirect URL before invoking the CORS check.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-and-redirects-async.html

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:

LayoutTests:

Add a test case for a same origin request with a custom header that receives a
same origin redirect, and therefore should pass the redirect check.

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-and-redirects-async.html:
1:36 AM Changeset in webkit [112996] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r112994.
http://trac.webkit.org/changeset/112994
https://bugs.webkit.org/show_bug.cgi?id=83008

This patch has to wait until v8 roll. (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-03

  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore):

  • bindings/v8/ScriptHeapSnapshot.h:

(WebCore):
(ScriptHeapSnapshot):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createSnapshotHeader):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.firstSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.secondSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.get maxNodeId):

1:32 AM Changeset in webkit [112995] by rakuco@FreeBSD.org
  • 2 edits in trunk/Tools

rebaseline-server: Make it possible to not launch a browser with the server.
https://bugs.webkit.org/show_bug.cgi?id=82999

Reviewed by Adam Barth.

Add the `--no-show-results' option, which lets one decide not to
launch a web browser when running the rebaseline server. This is
especially useful if the default browser is not the wanted one, or
if the rebaseline server page is already open.

  • Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:

(AbstractLocalServerCommand.init):
(AbstractLocalServerCommand.execute):

1:28 AM Changeset in webkit [112994] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: use maxJSObjectId that is provided by back-end.
https://bugs.webkit.org/show_bug.cgi?id=82451

Summary view can filter objects in snapshot. It uses maxJSObjectId for this.
There was no such field in the profile header at the
moment but I've landed a patch in downstream.

Reviewed by Yury Semikhatsky.

  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
(WebCore):

  • bindings/v8/ScriptHeapSnapshot.h:

(WebCore):
(ScriptHeapSnapshot):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createSnapshotHeader):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:
12:57 AM Changeset in webkit [112993] by Philippe Normand
  • 2 edits
    1 copy in trunk/LayoutTests

Unreviewed, baseline update for new test.

  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:
  • platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Copied from LayoutTests/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt.
12:31 AM Changeset in webkit [112992] by pfeldman@chromium.org
  • 22 edits in trunk/Source/WebCore

Web Inspector: "Pause on start" doesn't change checked state in workers panel
https://bugs.webkit.org/show_bug.cgi?id=82908

Reviewed by Yury Semikhatsky.

This change partially reverts logic that was introduced with r111551:
preventDefault was called beside each stopPropagation. As a result, default checkbox handler was not working.
Event.prototype.consume now receives preventDefault parameter that controls whether default action
should be prevented.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype._onKeyDown):

  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._enterKeyPressed):
(WebInspector.ConsoleGroup.prototype._titleClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):

  • inspector/front-end/Dialog.js:

(WebInspector.Dialog.prototype._onKeyDown):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype._statusBarDragging):

  • inspector/front-end/Object.js:

(WebInspector.Event.prototype.consume):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onKeyDown):

  • inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._discardMenu):

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.draggable.consume):
(WebInspector.Spectrum.prototype._onKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.muteEventListener):
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElement.prototype):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._handleKeyDown):

  • inspector/front-end/UIUtils.js:

(WebInspector.startEditing):

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.prototype.selectOnMouseDown):

  • inspector/front-end/utilities.js:

(Event.prototype.consume):

12:21 AM Changeset in webkit [112991] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

WebViewImpl doesn't notify the page that the user has canceled fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=82760

Reviewed by Darin Fisher.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::willExitFullScreen):
(WebKit::WebViewImpl::exitFullScreenForElement):

  • src/WebViewImpl.h:
12:18 AM Changeset in webkit [112990] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening

  • platform/gtk/Skipped: Skip 2 crashers and failing new test.
  • platform/gtk/test_expectations.txt: Mark

inspector/timeline/timeline-network-resource.html flaky.

12:15 AM Changeset in webkit [112989] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: search field on Google.com does not have the AXSearchField subrole
https://bugs.webkit.org/show_bug.cgi?id=82819

Reviewed by Darin Adler.

Source/WebCore:

Detect search fields when possible for accessibility.

Test: platform/mac/accessibility/search-subrole.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSearchField):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isSearchField):
(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper subrole]):

LayoutTests:

  • platform/mac/accessibility/search-subrole-expected.txt: Added.
  • platform/mac/accessibility/search-subrole.html: Added.
12:14 AM Changeset in webkit [112988] by tkent@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

Introduce another file-to-array script
https://bugs.webkit.org/show_bug.cgi?id=83001

Reviewed by Kentaro Hara.

make-file-arrays.py is a script to convert a binary file to a C++
char array. The differences from css/make-css-file-arrays.pl and
inspector/xxd.pl are:

  • No whitespace stripping for CSS files
  • We can make conditional arrays.

e.g. An array enclosed with #if ENABLE(...) - #endif.

This script will be used to implement a calendar picker for <input
type=date>.

  • make-file-arrays.py: Added.

Apr 2, 2012:

11:52 PM Changeset in webkit [112987] by abarth@webkit.org
  • 10 edits
    29 adds in trunk

Implement <iframe srcdoc>
https://bugs.webkit.org/show_bug.cgi?id=82991

Reviewed by Sam Weinig.

Source/WebCore:

This patch implements the <iframe srcdoc> feature. This feature allows
authors to easily supply the contents of an iframe without needing to
round-trip to the server. Using srcdoc is more convenient than using
data URLs because we set a bunch of properties of the child document
sensibly. For example, the child inherits the base URL of the parent
and the child uses standards mode by default.

This feature is specified in
<http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-srcdoc>.
Although the feature has been in the spec for a while, I'm not aware of
any other implementations in major browsers. The srcdoc feature works
especially well with the sandbox and seamless attributes. We already
implement sandbox and will likely implement seamless soon.

The srcdoc feature was announced on the webkit-dev mailing list on March 30:
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020161.html

This patch approaches the implementation using SubstituteData, which is
a mechanism previously used for error messages and the like. Using
SubstituteData has the advantage of not needing to modify the loading
or history pipelines at all, making the integration of srcdoc with the
rest of WebCore quite smooth.

This patch encodes the contents of the srcdoc attribute to and from
UTF-8 when round-tripping the contents through the loader. In a future
patch, I plan to experiment with whether using UTF-16 (or perhaps
another encoding) can improve performance. There might also be a way to
avoid the memcpy entirely, but these optimizations are best left to
followup patches as this patch focuses on the observable behavior of
the feature.

Tests: fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html

fast/frames/srcdoc/setting-src-does-nothing.html
fast/frames/srcdoc/setting-srcdoc-reloads-document.html
fast/frames/srcdoc/srcdoc-beats-src-dom.html
fast/frames/srcdoc/srcdoc-beats-src.html
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html
fast/frames/srcdoc/srcdoc-can-navigate.html
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html
fast/frames/srcdoc/srcdoc-loads-content.html
fast/frames/srcdoc/srcdoc-urls.html
http/tests/security/srcdoc-can-access-parent.html
http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html
http/tests/security/srcdoc-inherits-referrer-for-forms.html
http/tests/security/srcdoc-inherits-referrer.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):

  • srcdoc documents need to inherit their security contexts from their parents. We pick this initialization point to inherit the base URL and to set the "srcdoc Document" bit so that everything gets initialized atomically and from precisely the same owner frame.
  • dom/Document.h:

(Document):
(WebCore::Document::isSrcdocDocument):

  • This bit of state is present in the HTML5 spec and is referred to by a number of different requirements in the spec.
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):

  • These functions implement the requirement that the srcdoc attribute takes precedence over the src attribute and triggers a load of a document with the URL about:srcdoc.
  • html/HTMLIFrameElement.idl:
    • Expose the srcdoc property as a reflection of the DOM attribute.
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::defaultForInitial):

  • This tweak allows srcdoc documents to use standards mode by default, saving authors from having to include a doctype in each srcdoc document.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL):

  • This function transfers the contents of the srcdoc attribute into the loading pipeline. If the client supplies other SubstituteData, that takes precendence over our "default" SubstituteData.

(WebCore::FrameLoader::outgoingReferrer):

  • This function implements the requirement from the HTML5 spec that srcdoc documents inherit their referrer from their parent document. A recursive implementation might have been more aesthetic but the iterative implementation seemed like a better choice.

(WebCore::FrameLoader::shouldTreatURLAsSrcdocDocument):

  • An about:srcdoc URL only has special meaning when loaded in an iframe with a srcdoc attribute. Otherwise, it's just a normal "about" URL, meaning a blank page.

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):

  • Update these call sites to call defaultSubstituteDataForURL and outgoingReferrer consistently.
  • loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

Add a number of tests for <iframe srcdoc>. These tests cover all the
requirements I could find in the HTML5 specification by grepping for
the term "srcdoc".

  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Added.
  • fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Added.
  • fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Added.
  • fast/frames/srcdoc/setting-src-does-nothing.html: Added.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Added.
  • fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-dom.html: Added.
  • fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-beats-src.html: Added.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Added.
  • fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-can-navigate.html: Added.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Added.
  • fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-loads-content.html: Added.
  • fast/frames/srcdoc/srcdoc-urls-expected.txt: Added.
  • fast/frames/srcdoc/srcdoc-urls.html: Added.
  • http/tests/security/srcdoc-can-access-parent-expected.txt: Added.
  • http/tests/security/srcdoc-can-access-parent.html: Added.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Added.
  • http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Added.
  • http/tests/security/srcdoc-inherits-referrer-expected.txt: Added.
  • http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Added.
  • http/tests/security/srcdoc-inherits-referrer-for-forms.html: Added.
  • http/tests/security/srcdoc-inherits-referrer.html: Added.
10:10 PM Changeset in webkit [112986] by commit-queue@webkit.org
  • 5 edits in trunk

EFL's LayoutTestController disableImageLoading implementation.
https://bugs.webkit.org/show_bug.cgi?id=82848

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::disableImageLoading):

LayoutTests:

  • platform/efl/Skipped:
10:05 PM Changeset in webkit [112985] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] LayoutTestController needs implementation of isPageBoxVisible
https://bugs.webkit.org/show_bug.cgi?id=82591

Source/WebKit/efl:

Add missing implementation for isPageBoxVisible to EFL's
DumpRenderTreeSupport.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::isPageBoxVisible):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
in order to unskip printing/page-format-data.html

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::isPageBoxVisible):

LayoutTests:

Unskip printing/page-format-data.html

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

  • platform/efl/Skipped:
9:24 PM Changeset in webkit [112984] by tkent@chromium.org
  • 7 edits
    3 adds in trunk/Source/WebKit/chromium

[Chromium] Add WebKit API for WebCore::TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82143

Reviewed by Dimitri Glazkov.

Expose WebCore::TextFieldDecorator as
WebKit::WebTextFieldDecoratorClient. This change add capability to add
decoration buttons to text field <input> elements.

  • WebKit.gyp: Add new files.
  • public/WebTextFieldDecoratorClient.h: Added.
  • public/WebView.h:

(WebKit): Add addTextFieldDecoratorClient().

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::willAddTextFieldDecorationsTo):
Calls willAddDecorationTo() of TextFieldDecorator objects owned by WebViewImpl.
(WebKit::ChromeClientImpl::addTextFieldDecorationsTo):
Apply TextFieldDecorationElement::decorate() for the specified input element.

  • src/ChromeClientImpl.h:

(ChromeClientImpl): Add new function declarations.

  • src/TextFieldDecoratorImpl.cpp:

Added. This is a bridge of WebCore::TextFieldDecorator and
WebKit::WebTextFieldDecoratorClient. This owns CachedImage objects
specfied by WebTextFieldDecoratorClient.
(WebKit::TextFieldDecoratorImpl::TextFieldDecoratorImpl):
(WebKit::TextFieldDecoratorImpl::create):
(WebKit::TextFieldDecoratorImpl::~TextFieldDecoratorImpl):
(WebKit::TextFieldDecoratorImpl::willAddDecorationTo):
(WebKit::TextFieldDecoratorImpl::imageForNormalState):
(WebKit::TextFieldDecoratorImpl::imageForDisabledState):
(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::handleClick):
(WebKit::TextFieldDecoratorImpl::willDetach):

  • src/TextFieldDecoratorImpl.h: Added.

(TextFieldDecoratorImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::addTextFieldDecoratorClient):
Add implementation of WebView::addTextFieldDecoratorClient().

  • src/WebViewImpl.h:

WebViewImpl owns a vector of TextFieldDecoratorImpl.
(WebViewImpl):
(WebKit::WebViewImpl::textFieldDecorators):

9:14 PM Changeset in webkit [112983] by rakuco@freebsd.org
  • 17 edits in trunk/LayoutTests

[EFL] Gardening; update expectations in fast/dom.

Mostly size changes after the recent jhbuild and font commits.

  • platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/efl/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/efl/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/efl/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/efl/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/efl/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/efl/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.png:
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.txt:
  • platform/efl/fast/dom/dom-parse-serialize-expected.png:
  • platform/efl/fast/dom/dom-parse-serialize-expected.txt:
9:01 PM Changeset in webkit [112982] by rakuco@freebsd.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening; update text expectation for test in fast/layers.

  • platform/efl/fast/layers/video-layer-expected.png:
  • platform/efl/fast/layers/video-layer-expected.txt:
8:52 PM Changeset in webkit [112981] by Simon Fraser
  • 6 edits in trunk/Tools

run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
https://bugs.webkit.org/show_bug.cgi?id=82962

Reviewed by Dirk Pranke.

Ensure that _build_path() returns an absolute path.

Eric Seidel also had to deploy MockConfig in a bunch of places
in order to correct previous testing errors where we were
pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
was a real path. The real Config object calls run_command("webkit-build-directory")
to read the WebKit build directory from the webkitdirs.pm perl code.
MockConfig abstracts this away and always returns "/mock-build" during
testing. This change is much larger than one would think necessary
because of needing to deploy this MockConfig class.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_path):

8:31 PM Changeset in webkit [112980] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[chromium] Remove SkCanvas::LayerIter use from OpaqueRegionSkia
https://bugs.webkit.org/show_bug.cgi?id=82564

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-02
Reviewed by Stephen White.

Source/WebCore:

Per-tile-painting uses an SkPictureRecord in place of an SkCanvas
as the painting target for the GraphicsContext. This class only does
a simple recording and does not create layers in the canvas during
record, only playback. This is preventing us from correctly tracking
opaque regions under per-tile-painting.

We currently use the SkCanvas LayerIter to look at the layers in the
canvas backing the GraphicsContext, and check the SkPaints, clips,
and transforms to see how they impact the current draw once it reaches
the final device.

The clips and transforms can be retreived without using the LayerIter
through the "getTotal*" methods. A cumulative SkPaint is not available
so we store this ourselves.

PlatformContextSkia becomes aware of when saveLayer() is being called
on the underlying canvas, and passes this information to the
OpaqueRegionSkia class. Since we no longer watch layers in the canvas,
we must explicitly handle image clipping for the opaque tracker, as
it is implemented in the PlatformContextSkia, not via constructs in
the SkCanvas/SkPaint. We save the opaque area of the image mask for
the canvas layer in the stack along with the SkPaint for the layer.

Unit test: PlatformContextSkiaTest.PreserveOpaqueOnlyMattersForFirstLayer

  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:

(WebCore::FEGaussianBlur::platformApplySkia):

  • platform/graphics/filters/skia/FEMorphologySkia.cpp:

(WebCore::FEMorphology::platformApplySkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::setImageMask):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::CanvasLayerState::CanvasLayerState):
(CanvasLayerState):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::saveLayer):
(WebCore):
(WebCore::PlatformContextSkia::restoreLayer):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore):
(WebCore::TEST):

8:21 PM Changeset in webkit [112979] by morrita@google.com
  • 2 edits in branches/chromium/1025/Source/WebCore/html

Disable content element.

BUG=114667
TBR=Dimitri Glazkov
Review URL: https://chromiumcodereview.appspot.com/9959089

8:00 PM Changeset in webkit [112978] by shinyak@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove TreeScope::isShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=82879

Reviewed by Dimitri Glazkov.

This patch removes TreeScope::isShadowRoot(). To make code fast, TreeScope::isShadowRoot
is implemented in ShadowRoot.h. So when using TreeScope::isShadowRoot(), ShadowRoot.h is
always required. In some case, this might bring unnecessary dependency.

Since TreeScope::rootNode() is inlined, the overall performance won't change.

No new tests, simple refactoring.

  • dom/ShadowRoot.h:
  • dom/TreeScope.h:
  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::doesSelectFromHostChildren):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::assignedFrom):
(WebCore::InsertionPoint::isShadowBoundary):

7:44 PM Changeset in webkit [112977] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix usage of LayoutUnits and pixel snapping in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=82498

Reviewed by Julien Chaffraix.

Fix usage of subpixel types and snapping/rounding in RenderLayer in
preparation for turning on subpixel layout.

No new tests, no change in functionality.

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntSize):
Add no-op implementation of pixelSnappedIntSize, will be replaced with a
real implementation once we make the switch.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
Snap RenderBox size when updating the size of the layer.

(WebCore::RenderLayer::resize):
Round position when setting the inline style during resize operation.

(WebCore::RenderLayer::scrollCornerRect):
Remove unnecessary pixelSnappedIntRect call.

(WebCore::RenderLayer::positionOverflowControls):
Remove unnecessary pixelSnappedIntRect call.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Fix implementation of scrollWidth and Height to pixel snap the values.

(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
Remove unnecessary pixelSnappedIntRect calls.

(WebCore::RenderLayer::paintLayerContents):
Pixel snap values just before painting (instead of earlier on).

(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestContents):
Change to use subpixel types.

7:39 PM Changeset in webkit [112976] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Mark compositing/reflections/backface-hidden-reflection.html as crashing

Unreviewed, expectations and baselines update.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-linux-x86/svg/custom/text-ctm-expected.png: Removed
  • platform/chromium-linux/svg/custom/text-ctm-expected.png: Added.
7:16 PM Changeset in webkit [112975] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set viewport size back, when WebProcess is relaunched.
https://bugs.webkit.org/show_bug.cgi?id=82936

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-02
Reviewed by Andreas Kling.

Fixed layout requires viewport size set properly on the WebProcess side.
Make sure it is set, when WebProcess is relaunched.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):

7:12 PM Changeset in webkit [112974] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
6:41 PM Changeset in webkit [112973] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

<select> shouldn't intrude as a run-in.
https://bugs.webkit.org/show_bug.cgi?id=82829

Reviewed by Tony Chang.

Source/WebCore:

Matches Opera's behavior which also does not allow <select>
to intrude as a run-in into the neighbouring block.
IE and Firefox doesn't support run-ins, so can't compare behavior
with them.

Test: fast/runin/select-runin.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

  • fast/runin/select-runin-expected.txt: Added.
  • fast/runin/select-runin.html: Added.
6:39 PM Changeset in webkit [112972] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix snafu in r112971. We were never calling parseParameter for builder.

  • TestResultServer/static-dashboards/dashboard_base.js:
6:25 PM Changeset in webkit [112971] by ojan@chromium.org
  • 8 edits in trunk/Tools

Generate the lists of all layout test builders from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=82924

Reviewed by Mihai Parparita.

In order to make this work, cleaned up a lot of existing technical debt.
-Got rid of expectations builder. This concept is outdated and just dead code.
-Split hash parameter parsing into two functions. One for dashboard_base
(crossDashboardParameters) and one for the specific dashboard html file
(dashboardSpecificParameters). In the old world, parseParameters needed to
be called twice and depended on it's own output the first time through.
Now we only need to parse crossDashboardParameters first and crossDashboardParameters
doesn't depend on the output of crossDashboardParameters.
-Lots of variable/method renames due to the above.
-g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
for that dashboard.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/builders.js:

(BuilderGroup):
(BuilderGroup.prototype.setup):
(jsonRequest.xhr.onload):
(jsonRequest.xhr.onerror):
(isWebkitTestRunner):
(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(generateBuildersFromBuilderList):
(onLayoutTestBuilderListLoad):
(onErrorLoadingBuilderList):
(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(handleValidHashParameterWrapper):
(queryHashAsMap):
(parseParameter):
(parseCrossDashboardParameters):
(parseDashboardSpecificParameters):
(parseParameters):
(diffStates):
(defaultValue):
(isLayoutTestResults):
(isGPUTestResults):
(currentBuilderGroupCategory):
(currentBuilderGroup):
(initBuilders):
Now that we've split parameter parseing, these methods no longer need
to take an optional state. They can always just use the global cross-dashboard state.

(pathToBuilderResultsFile):
(appendJSONScriptElementFor):
(appendJSONScriptElements):
(handleResourceLoadError):
(haveJsonFilesLoaded):
(combinedDashboardState):
(setQueryParameter):
(permaLinkURLHash):
(toggleQueryParameter):
(queryParameterValue):
(selectHTML):
(htmlForTestTypeSwitcher):
(g_handleBuildersListLoaded):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testSubstringList):
(testHtmlForTestTypeSwitcherGroup):
(testLookupVirtualTestSuite):
(testBaseTest):
(generateBuildersFromBuilderListHelper):
(testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
(testGenerateChromiumWebkitDepsBuildersFromBuilderList):
(assertObjectsDeepEqual):
(testQueryHashAsMap):
(testDiffStates):

  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
6:18 PM UsingGitWithWebKit edited by srikumar.b@gmail.com
git-svn package also need to be installed to use git with svn (diff)
6:16 PM Changeset in webkit [112970] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Call decrementStatsCounter directly
https://bugs.webkit.org/show_bug.cgi?id=82950

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-02
Reviewed by Adam Barth.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::~WebFrameImpl):

5:25 PM Changeset in webkit [112969] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

fast/events/drop-handler-should-not-stop-navigate.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=82984

Reviewed by Enrica Casucci.

  • fast/events/drop-handler-should-not-stop-navigate.html:
  • platform/mac/Skipped:
5:24 PM Changeset in webkit [112968] by tony@chromium.org
  • 28 edits
    2 adds in trunk

add css parsing of -webkit-flex
https://bugs.webkit.org/show_bug.cgi?id=82927

Reviewed by Ojan Vafai.

Source/WebCore:

This is the new syntax for CSS3 flexbox:
http://dev.w3.org/csswg/css3-flexbox/#flexibility

Not hooked up to anything in the render tree yet so the old syntax is
still valid.

Test: css3/flexbox/flex-property-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSParser.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

LayoutTests:

  • css3/flexbox/flex-property-parsing-expected.txt: Added.
  • css3/flexbox/flex-property-parsing.html: Added.
  • css3/flexbox/script-tests/css-properties.js:
  • css3/flexbox/script-tests/flex-parsing.js:
  • css3/flexbox/script-tests/flex-property-parsing.js: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
5:22 PM Changeset in webkit [112967] by crogers@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

Rebaseline oscillator results
https://bugs.webkit.org/show_bug.cgi?id=82987

Unreviewed rebaseline.

  • platform/chromium-linux-x86/webaudio/oscillator-custom-expected.wav: Added.
  • platform/chromium-linux-x86/webaudio/oscillator-sawtooth-expected.wav: Added.
  • platform/chromium-linux-x86/webaudio/oscillator-sine-expected.wav: Added.
  • platform/chromium-linux-x86/webaudio/oscillator-square-expected.wav: Added.
  • platform/chromium-linux-x86/webaudio/oscillator-triangle-expected.wav: Added.
  • platform/chromium-linux/webaudio/oscillator-custom-expected.wav: Added.
  • platform/chromium-linux/webaudio/oscillator-sawtooth-expected.wav: Added.
  • platform/chromium-linux/webaudio/oscillator-sine-expected.wav: Added.
  • platform/chromium-linux/webaudio/oscillator-square-expected.wav: Added.
  • platform/chromium-linux/webaudio/oscillator-triangle-expected.wav: Added.
  • platform/chromium-win/webaudio/oscillator-custom-expected.wav: Added.
  • platform/chromium-win/webaudio/oscillator-sawtooth-expected.wav: Added.
  • platform/chromium-win/webaudio/oscillator-sine-expected.wav: Added.
  • platform/chromium-win/webaudio/oscillator-square-expected.wav: Added.
  • platform/chromium-win/webaudio/oscillator-triangle-expected.wav: Added.
5:11 PM Changeset in webkit [112966] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Incorrect liveness information when inlining
https://bugs.webkit.org/show_bug.cgi?id=82985

Reviewed by Filip Pizlo.

Don't remap register numbers that have already been remapped.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

5:07 PM Changeset in webkit [112965] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

One more flakey canvas test

  • platform/mac/Skipped:
5:02 PM Changeset in webkit [112964] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/drop-handler-should-not-stop-navigate.html fails on Lion
after http://trac.webkit.org/changeset/112954

  • platform/mac/Skipped:
4:54 PM Changeset in webkit [112963] by tony@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style errors when removing .png files
https://bugs.webkit.org/show_bug.cgi?id=82933

Reviewed by David Levin.

  • Scripts/webkitpy/style/patchreader.py:

(PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).

  • Scripts/webkitpy/style/patchreader_unittest.py:

(test_check_patch_with_png_deletion):

4:53 PM Changeset in webkit [112962] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping a bunch of flakey tests on Lion.

  • platform/mac/Skipped:
4:41 PM Changeset in webkit [112961] by crogers@google.com
  • 2 edits in trunk/LayoutTests

Fix layout test failure with window-properties-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=82969

Unreviewed build fix.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:

Fix expectations caused by addition of Oscillator and WaveTable:
http://trac.webkit.org/changeset/112938

4:24 PM Changeset in webkit [112960] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Skip new test webarchive/css-page-rule-crash.html for WK2.
WK2 tests can't dump as WebArchives yet.

No review.

  • platform/wk2/Skipped:
4:15 PM Changeset in webkit [112959] by mrowe@apple.com
  • 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merge r112801.

4:04 PM Changeset in webkit [112958] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r112948.
http://trac.webkit.org/changeset/112948
https://bugs.webkit.org/show_bug.cgi?id=82961

Someone else already checked in a similar change (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._start):

4:01 PM Changeset in webkit [112957] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adapt WebPagePrivate::webContext to the API change of r109570
https://bugs.webkit.org/show_bug.cgi?id=82945

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-02
Reviewed by Rob Buis.

RIM PR: 147163
Adapt WebPagePrivate::webContext to the API change of the security
cherry-pick of r109570 and r112023.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

3:56 PM Changeset in webkit [112956] by tomz@codeaurora.org
  • 1 edit
    1 delete in trunk/LayoutTests

Removing ahem.ttf that was checked in with wrong-case name.

Reviewed by Adam Barth.

This file is not referenced yet. The correctly named one will be added with
the next ietestcenter css test import.

  • ietestcenter/css3/support/ahem.ttf: Removed.
3:35 PM Changeset in webkit [112955] by abarth@webkit.org
  • 3 edits in trunk/Tools

garden-o-matic isn't able to rebaseline audio failures
https://bugs.webkit.org/show_bug.cgi?id=82957

Reviewed by Chris Rogers.

This patch just adds "wav" to the list of test suffixes and updates the
unit tests to show that we're rebaselining audio tests results now too.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_updates_expectations_file):

3:33 PM Changeset in webkit [112954] by dcheng@chromium.org
  • 5 edits
    2 adds in trunk

Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.

Test: fast/events/drop-handler-should-not-stop-navigate.html

  • page/DragController.cpp:

(WebCore::DragController::performDrag):

LayoutTests:

  • fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
  • fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
  • fast/events/drop-handler-should-not-stop-navigate.html: Added.
  • http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler

to prevent bubbled events from causing navigation.

3:31 PM Changeset in webkit [112953] by schenney@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Flaky SVG tests on MacOS 10.6
https://bugs.webkit.org/show_bug.cgi?id=82954

Unreviewed Chromium test_expectations update

Removign one empty expectations file that somehow made it in
previously. And marking several tests as flaky on Snow Leopard.

  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:30 PM Changeset in webkit [112952] by alexis.menard@openbossa.org
  • 14 edits in trunk/Source

We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82941

Reviewed by Andreas Kling.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. It will also feel more correct after this patch that CSSProperty::id()
return a value of the enum rather than an integer. As this modification is quite big this
is the first part only so it will be easier to review.

Source/WebCore:

No new tests : There should be no behavior change in this patch.

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):

  • css/CSSParser.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::cssText):

  • css/CSSProperty.h:

(WebCore::CSSProperty::id):
(WebCore::CSSProperty::shorthandID):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::asText):

  • css/StylePropertySet.h:

(StylePropertySet):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::removePropertiesInStyle):
(WebCore::setTextDecorationProperty):
(WebCore::diffTextDecorations):

  • editing/Editor.cpp:

(WebCore::Editor::selectionStartCSSPropertyValue):

  • editing/Editor.h:

(Editor):

  • editing/EditorCommand.cpp:

(WebCore::valueStyle):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty): Adapt to the API change and also remove an unecessary name->id
conversion.

3:19 PM Changeset in webkit [112951] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should let you listen to audio failures
https://bugs.webkit.org/show_bug.cgi?id=82953

Reviewed by Chris Rogers.

Now that we've actually got an audio failure on the bots, we can clean
up the last stray bugs. This patch doesn't have any tests because I'm
lame.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

3:11 PM Changeset in webkit [112950] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Call NPP_SetValue with WKNVCALayerRenderServerPort when a WKView is moved from a buffered to an unbuffered window, or vice versa
https://bugs.webkit.org/show_bug.cgi?id=82951
<rdar://problem/10589308>

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setLayerHostingMode):
Call Plugin::setLayerHostingMode).

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:

Move WKNVCALayerRenderServerPort to the header file.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_layerHostingMode.

(WebKit::NetscapePlugin::initialize):
Set m_layerHostingMode from the parameters struct.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::compositingRenderServerPort):
Return MACH_PORT_NULL when hosted in the window server.

(WebKit::NetscapePlugin::platformPostInitialize):
Move the code that gets the layer out into a separate function, updatePluginLayer.

(WebKit::NetscapePlugin::setLayerHostingMode):
Let the plug-in know that the layer hosting mode changed and update the plug-in layer if
setting the new compositing port was successful.

3:08 PM Changeset in webkit [112949] by Nate Chapin
  • 6 edits in trunk/Source/WebCore

Simplify main resource load start/end in FrameLoader
and DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=82935

  1. Have FrameLoader call prepareForLoadStart() on itself directly, rather

than through DocumentLoader.

  1. Remove DocumentLoader::m_primaryLoadComplete, since this is basically equivalent

to m_mainResourceLoader.

  1. Rename setPrimaryLoadComplete() to clearMainResourceLoader(), and only call it at

the end of the main resource load.

  1. Move clearing DocumentLoader::m_mainResourceError into startLoadingMainResource(),

which leaves DocumentLoader::prepareForLoadStart() empty.

Reviewed by Adam Barth.

No new tests, refactor only.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • loader/FrameLoader.h: prepareForLoadStart() is now called directly,

so make it private.

3:05 PM Changeset in webkit [112948] by Stephanie Lewis
  • 2 edits in trunk/Tools

2012-04-02 Stephanie Lewis <Stephanie Lewis>

run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
https://bugs.webkit.org/show_bug.cgi?id=82552

Reviewed by Dirk Pranke.

Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

  • Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver._start):
2:53 PM Changeset in webkit [112947] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Activation tear-off neglects to copy the callee and scope chain, leading to crashes if we
try to create an arguments object from the activation
https://bugs.webkit.org/show_bug.cgi?id=82947
<rdar://problem/11058598>

Reviewed by Gavin Barraclough.

We now copy the entire call frame header just to be sure. This is mostly perf-netural,
except for a 3.7% slow-down in V8/earley.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

  • runtime/JSActivation.h:

(JSC::JSActivation::tearOff):

2:44 PM Changeset in webkit [112946] by schenney@chromium.org
  • 34 edits
    13 adds
    8 deletes in trunk/LayoutTests

[Chromium] Expectations updated needed after 75091
https://bugs.webkit.org/show_bug.cgi?id=81217

Unreviewed Chromium test_expectations update.

Leaving tests as flaky because some builders seem to be flaky,
although it's not clear why.

  • platform/chromium-linux-x86/svg/carto.net: Added.
  • platform/chromium-linux-x86/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/text-ctm-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/003-expected.png: Added.
  • platform/chromium-linux/svg/carto.net/tabgroup-expected.png:
  • platform/chromium-linux/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/window-expected.png:
  • platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/use-detach-expected.png:
  • platform/chromium-linux/svg/hixie/perf/003-expected.png:
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Removed.
  • platform/chromium-mac/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/window-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-detach-expected.png: Added.
  • platform/chromium-mac/svg/hixie/perf/003-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-xp/svg/carto.net: Removed.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.png:
  • platform/chromium-win/svg/carto.net/tabgroup-expected.txt:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/text-ctm-expected.png:
  • platform/chromium-win/svg/custom/text-ctm-expected.txt:
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-detach-expected.txt:
  • platform/chromium-win/svg/hixie/perf/003-expected.png:
  • platform/chromium-win/svg/hixie/perf/003-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
2:34 PM Changeset in webkit [112945] by commit-queue@webkit.org
  • 10 edits
    4 deletes in trunk/LayoutTests

Rebaseline more tests from 79568
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations udpate.

Patch by Philip Rogers <pdr@google.com> on 2012-04-02

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/chromium/test_expectations.txt:
2:33 PM Changeset in webkit [112944] by dpranke@chromium.org
  • 3 edits in trunk/Tools

NRWT is not printing out the builder it's uploading JSON files for
https://bugs.webkit.org/show_bug.cgi?id=82834

Reviewed by Ojan Vafai.

Handle log messages of the form log.info("%s", arg) properly ...
I didn't even know you could do that :).

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(_LogHandler.emit):

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(RegularTest.test_log_args):
(VerboseTest.test_log_args):

2:23 PM Changeset in webkit [112943] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

[mac] LayoutTestHelper crashes if there is no main display
https://bugs.webkit.org/show_bug.cgi?id=82944
<rdar://problem/11162954>

Reviewed by Simon Fraser.

If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
a null dictionary, so we shouldn't go ahead and try to read from it.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):

2:19 PM Changeset in webkit [112942] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg
https://bugs.webkit.org/show_bug.cgi?id=81002
<rdar://problem/11168969>

Reviewed by Simon Fraser.

Don't spend time rebuilding SVG text layout attributes if the document is being torn down, as
they won't be used, and can cause assertion failures in the font cache.

No new tests, as it fixes an intermittent assertion failure during document destruction.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):

2:16 PM Changeset in webkit [112941] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

svg/W3C-SVG-1.1/animate-elem-80-t.svg is flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=82911

Unreviewed test_expectations update.

Fixing Mac 10.7 buildbot redness by marking animate-elem-80-t.svg as flaky.

  • platform/chromium/test_expectations.txt:
2:15 PM Changeset in webkit [112940] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
https://bugs.webkit.org/show_bug.cgi?id=80519

Source/WebCore:

Stop asserting in platformCachePolicyForRequest() as now it is expected
that the ResourceRequest might not have the right TargetType setup at
this time for main loads.

Patch by Lianghui Chen <liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.

No new tests as no change in behaviour.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::platformCachePolicyForRequest):

Source/WebKit/blackberry:

Set the right TargetType for main loads if they are not already set in
dispatchWillSendRequest().

Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
and dispatchDecidePolicyForNavigationAction() as they are called before
dispatchWillSendRequest() is called. Patch to change ResourceRequest
TargetType earlier has been rejected as in WebKit bug
https://bugs.webkit.org/show_bug.cgi?id=80713

Patch by Lianghui Chen <liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

2:10 PM Changeset in webkit [112939] by Simon Fraser
  • 4 edits in trunk

Fix issue with reflections and composited layers
https://bugs.webkit.org/show_bug.cgi?id=82636

Source/WebCore:

Reviewed by Alexey Proskuryakov

When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
we need to clean up the replica layer pointers.

No new tests; tested by existing compositing and repaint tests.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::setReplicatedByLayer):

LayoutTests:

Reviewed by Alexey Proskuryakov

Unskip some compositing tests that should pass now.

  • platform/mac-wk2/Skipped:
2:07 PM Changeset in webkit [112938] by crogers@google.com
  • 10 edits
    17 adds in trunk

Source/WebCore: Add Oscillator/WaveTable implementation and tests
https://bugs.webkit.org/show_bug.cgi?id=82414

Oscillator represents an audio source generating a periodic waveform. It can be set to
a few commonly used waveforms. Additionally, it can be set to an arbitrary periodic
waveform through the use of a WaveTable object.

Reviewed by Kenneth Russell.

Tests: webaudio/oscillator-custom.html

webaudio/oscillator-sawtooth.html
webaudio/oscillator-sine.html
webaudio/oscillator-square.html
webaudio/oscillator-triangle.html

  • DerivedSources.make:
  • GNUmakefile.list.am:

Add Oscillator and WaveTable to build files.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createOscillator):
(WebCore):
(WebCore::AudioContext::createWaveTable):

  • Modules/webaudio/AudioContext.h:

Add create methods for Oscillator and WaveTable.
(WebCore):
(AudioContext):

  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/Oscillator.cpp: Added.

(WebCore):
(WebCore::Oscillator::create):
(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::~Oscillator):
(WebCore::Oscillator::setType):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):
(WebCore::Oscillator::reset):
(WebCore::Oscillator::setWaveTable):

  • Modules/webaudio/Oscillator.h: Added.

(WebCore):
(Oscillator):
(WebCore::Oscillator::type):
(WebCore::Oscillator::frequency):
(WebCore::Oscillator::detune):
Implement Oscillator as AudioSourceNode.

  • Modules/webaudio/Oscillator.idl: Added.
  • Modules/webaudio/WaveTable.cpp: Added.

(WebCore):
(WebCore::WaveTable::create):
(WebCore::WaveTable::createSine):
(WebCore::WaveTable::createSquare):
(WebCore::WaveTable::createSawtooth):
(WebCore::WaveTable::createTriangle):
(WebCore::WaveTable::WaveTable):
(WebCore::WaveTable::waveDataForFundamentalFrequency):
(WebCore::WaveTable::maxNumberOfPartials):
(WebCore::WaveTable::numberOfPartialsForRange):
(WebCore::WaveTable::createBandLimitedTables):
(WebCore::WaveTable::generateBasicWaveform):

  • Modules/webaudio/WaveTable.h: Added.

(WebCore):
(WaveTable):
(WebCore::WaveTable::rateScale):
(WebCore::WaveTable::waveTableSize):
(WebCore::WaveTable::sampleRate):
(WebCore::WaveTable::numberOfRanges):
Implement WaveTable which is constructed given a set of Fourier coefficients.

  • Modules/webaudio/WaveTable.idl: Added.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

Add Oscillator and WaveTable files to build files.

LayoutTests: Add Oscillator/WaveTable implementation and tests
https://bugs.webkit.org/show_bug.cgi?id=82414

Reviewed by Kenneth Russell.

  • webaudio/oscillator-custom-expected.wav: Added.
  • webaudio/oscillator-custom.html: Added.
  • webaudio/oscillator-sawtooth-expected.wav: Added.
  • webaudio/oscillator-sawtooth.html: Added.
  • webaudio/oscillator-sine-expected.wav: Added.
  • webaudio/oscillator-sine.html: Added.
  • webaudio/oscillator-square-expected.wav: Added.
  • webaudio/oscillator-square.html: Added.
  • webaudio/oscillator-triangle-expected.wav: Added.
  • webaudio/oscillator-triangle.html: Added.
  • webaudio/resources/oscillator-testing.js: Added.

(generateExponentialOscillatorSweep):

2:05 PM Changeset in webkit [112937] by scherkus@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2012-04-02 David Dorwin <ddorwin@chromium.org>

Add layout test expectations for Chromium to exhibit support WebM types
https://bugs.webkit.org/show_bug.cgi?id=82925

Unreviewed.

  • platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [112936] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82899

Reviewed by Darin Adler.

Removing remaining LayoutUnit misuse and compiler errors that exist in RenderReplaced
and RenderFlexibleBox once LayoutUnit becomes sub-pixel.

No new tests. No change in behavior.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Switching
a raw zero in a ternary operation to zeroLayoutUnit.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Ditto for std::max.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint): Adding missing pixel snapping before painting.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Like above, switching
a raw zero to zeroLayoutUnit.
(WebCore::RenderReplaced::computePreferredLogicalWidths): Ditto.

1:58 PM Changeset in webkit [112935] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash due to floating object lists not properly being cleared
https://bugs.webkit.org/show_bug.cgi?id=74056

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-02
Reviewed by David Hyatt.

Source/WebCore:

Add a check to clearFloats() that determines when intruding floats
are being cleared and not re-added. In this condition, ensure
children with floats are also getting layout because they might
need to have the same intruding floats cleared from their floating
object lists also.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

LayoutTests:

This test creates a condition where an intruding float is changed so
that it no longer intrudes. The child of a sibling was not getting
properly updated during the next layout.

  • fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt: Added
  • fast/block/float/intruding-float-not-removed-from-descendant-crash.html: Added
1:53 PM Changeset in webkit [112934] by schenney@chromium.org
  • 2 edits
    4 adds
    3 deletes in trunk/LayoutTests

[chromium] Layout Test svg/text/text-rescale.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79454

Unreviewed Chromium test_expectations update.

Some the of results for svg/text/text-rescale.svg and svg/text/text-viewbox-rescale.svg
are just in need of rebaselining, while others are flakey. Clarifying
the situation in test_expectations.

  • platform/chromium-linux/svg/text/text-rescale-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Removed.
  • platform/chromium-mac/svg/text/text-rescale-expected.png: Added.
  • platform/chromium-win/svg/text/text-rescale-expected.png: Added.
  • platform/chromium-win/svg/text/text-rescale-expected.txt: Added.
  • platform/chromium-win/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/text-viewbox-rescale-expected.txt: Removed.
1:46 PM Changeset in webkit [112933] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Align IDL to Typed Array Specification
https://bugs.webkit.org/show_bug.cgi?id=82919

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-04-02
Reviewed by Darin Adler.

No tests. No change in behavior.

  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
1:45 PM Changeset in webkit [112932] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping ASSERTING inspector/debugging tests.

  • platform/mac/Skipped:
1:38 PM Changeset in webkit [112931] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping 2 Unicode tests that are crashing intermittently.

  • platform/mac-wk2/Skipped:
1:34 PM Changeset in webkit [112930] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674

Rubber-stamped by Darin Adler.

Updated r112910: <http://trac.webkit.org/changeset/112910> to address
post checkin concerns raised in original bug.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

1:34 PM Changeset in webkit [112929] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG
https://bugs.webkit.org/show_bug.cgi?id=79455

Unreviewed Chromium test_expectations clean-up.

Closing another bug that is an instance of WK82232.

  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [112928] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/Source/JavaScriptCore

Remove Source/JavaScriptCore/wtf and its empty subdirectories

Rubber-stamped by Eric Seidel.

Following the move of WTF from Source/JavaScriptCore/wtf to Source/WTF
(https://bugs.webkit.org/show_bug.cgi?id=75673), remove directory
Source/JavaScriptCore/wtf and its empty subdirectories.

  • wtf: Removed.
  • wtf/android: Removed.
  • wtf/blackberry: Removed.
  • wtf/chromium: Removed.
  • wtf/dtoa: Removed.
  • wtf/efl: Removed.
  • wtf/gobject: Removed.
  • wtf/gtk: Removed.
  • wtf/mac: Removed.
  • wtf/qt: Removed.
  • wtf/qt/compat: Removed.
  • wtf/tests: Removed.
  • wtf/text: Removed.
  • wtf/threads: Removed.
  • wtf/threads/win: Removed.
  • wtf/unicode: Removed.
  • wtf/unicode/glib: Removed.
  • wtf/unicode/icu: Removed.
  • wtf/unicode/qt4: Removed.
  • wtf/unicode/wince: Removed.
  • wtf/url: Removed.
  • wtf/url/api: Removed.
  • wtf/url/src: Removed.
  • wtf/win: Removed.
  • wtf/wince: Removed.
  • wtf/wx: Removed.
1:25 PM Changeset in webkit [112927] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping flakey test on Mac.

  • platform/mac/Skipped:
1:21 PM Changeset in webkit [112926] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=80976

Unreviewed Chromium test_expectations clean-up

The tests reported in this bug are either no longer crashing or
crashing due to the same problem as Bug 82232. So they are being
consolidated in the test_expectations file.

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [112925] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping inspector/profiler/cpu-profiler-profiling.html
since it produces intermittent crashes.

  • platform/mac/Skipped:
1:14 PM Changeset in webkit [112924] by darin@chromium.org
  • 3 edits
    6 adds in trunk

HistoryItem not updated properly when a form submission begins before a
previous form submission has finished.
https://bugs.webkit.org/show_bug.cgi?id=76686

Reviewed by Nate Chapin.

Source/WebCore:

Test: LayoutTests/fast/loader/form-submission-before-load-{get,post}.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadPostRequest):

LayoutTests:

  • fast/loader/form-submission-before-load-get-expected.txt: Added.
  • fast/loader/form-submission-before-load-get.html: Added.
  • fast/loader/form-submission-before-load-post-expected.txt: Added.
  • fast/loader/form-submission-before-load-post.html: Added.
  • fast/loader/resources/form-submission-before-load-page2.html: Added.
  • fast/loader/resources/form-submission-before-load-page3.html: Added.
12:50 PM Changeset in webkit [112923] by Antti Koivisto
  • 35 edits in trunk/Source/WebCore

Split remaining CSSRules into internal and CSSOM types
https://bugs.webkit.org/show_bug.cgi?id=82728

Reviewed by Andreas Kling.

This will complete the move to internal types for CSS rules. The only remaining unsplit type is
the CSSStyleSheet itself.

By separating internal types from the CSSOM we save memory immediately and enable future performance
optimizations as we are no longer tied to the structure of the API.

CSSOM type Internal type

CSSStyleRule StyleRule -> StyleRuleBase
CSSPageRule StyleRulePage -> StyleRuleBase
CSSFontFaceRule StyleRuleFontFace -> StyleRuleBase
CSSMediaRule StyleRuleMedia -> StyleRuleBlock -> StyleRuleBase
CSSImportRule StyleRuleImport -> StyleRuleBase
CSSCharsetRule String (owned by CSSStyleSheet)
CSSUnknownRule Never instantiated
WebKitCSSRegionRule StyleRuleRegion -> StyleRuleBlock -> StyleRuleBase
WebKitKeyframesRule StyleRuleKeyframes -> StyleRuleBase
WebKitKeyframeRule StyleKeyframe (owned by StyleRuleKeyframes)

StyleRuleBase is refcounted.

The CSSOM objects contain the public API functions and their implementations (almost) nothing else. Unlike the
CSSOM types they don't have parent pointers, saving memory.

The CSSOM tree is constructed on demand only. The CSSOM wrapper instances are constructed and owned by
the parent wrapper in the tree. Wrappers ref the corresponding internal type. The trees are kept in sync
when mutating.

All rules shrink by a pointer (from the parent pointer removal). The immediate memory savings from this patch are
larger as some earlier patches temporarily increased the memory use to allow incremental refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:

(WebCore):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::cssText):
(WebCore):

  • css/CSSFontFaceRule.h:

(WebCore):
(WebCore::CSSFontFaceRule::create):
(CSSFontFaceRule):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontSelector.h:

(WebCore):

  • css/CSSGrammar.y:
  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):

  • css/CSSImportRule.h:

(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::clearParentStyleSheet):
(WebCore::StyleRuleImport::href):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
(ImportedStyleSheetClient):
(CSSImportRule):
(WebCore::CSSImportRule::create):
(WebCore::CSSImportRule::href):
(WebCore::CSSImportRule::styleSheet):
(WebCore):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::media):
(WebCore):
(WebCore::CSSMediaRule::length):
(WebCore::CSSMediaRule::item):
(WebCore::CSSMediaRule::cssRules):

  • css/CSSMediaRule.h:

(WebCore):
(WebCore::CSSMediaRule::create):
(CSSMediaRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):

  • css/CSSPageRule.h:

(WebCore):
(WebCore::CSSPageRule::create):
(CSSPageRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::createMarginAtRule):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSPropertySourceData.h:

(WebCore):

  • css/CSSStyleRule.cpp:

(WebCore):
(WebCore::selectorTextCache):
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleRule.h:

(WebCore):
(WebCore::CSSStyleRule::create):
(CSSStyleRule):

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore::RuleSet::pageRules):
(WebCore::CSSStyleSelector::addKeyframeStyle):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::createChildRuleCSSOMWrapper):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
(WebCore::CSSStyleSheet::ensureCSSOMWrapper):
(WebCore):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::parentStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::childRules):
(WebCore::CSSStyleSheet::importRules):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::hasCharsetRule):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::setProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::~StyleRulePage):
(WebCore::StyleRulePage::setProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::~StyleRuleFontFace):
(WebCore::StyleRuleFontFace::setProperties):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleBlock::wrapperInsertRule):
(WebCore::StyleRuleBlock::wrapperRemoveRule):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):

  • css/StyleRule.h:

(WebCore):
(WebCore::StyleRuleBase::type):
(StyleRuleBase):
(WebCore::StyleRuleBase::isCharsetRule):
(WebCore::StyleRuleBase::isFontFaceRule):
(WebCore::StyleRuleBase::isKeyframesRule):
(WebCore::StyleRuleBase::isMediaRule):
(WebCore::StyleRuleBase::isPageRule):
(WebCore::StyleRuleBase::isStyleRule):
(WebCore::StyleRuleBase::isRegionRule):
(WebCore::StyleRuleBase::isImportRule):
(WebCore::StyleRuleBase::sourceLine):
(WebCore::StyleRuleBase::deref):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRuleBase::~StyleRuleBase):
(StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRule::wrapperAdoptSelectorList):
(StyleRuleFontFace):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRuleFontFace::properties):
(StyleRulePage):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::selector):
(WebCore::StyleRulePage::properties):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRulePage::wrapperAdoptSelectorList):
(StyleRuleBlock):
(WebCore::StyleRuleBlock::childRules):
(StyleRuleMedia):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleMedia::mediaQueries):
(StyleRuleRegion):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleRegion::selectorList):

  • css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore):

  • css/StyleSheet.h:

(WebCore):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::parentStyleSheet):
(StyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore):
(WebCore::StyleRuleKeyframes::~StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):

  • css/WebKitCSSKeyframesRule.h:

(WebCore):
(StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::create):
(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::name):
(WebCore::StyleRuleKeyframes::setName):
(WebCore::WebKitCSSKeyframesRule::create):
(WebCore::WebKitCSSKeyframesRule::name):
(WebKitCSSKeyframesRule):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::length):
(WebCore):
(WebCore::WebKitCSSRegionRule::item):
(WebCore::WebKitCSSRegionRule::cssRules):

  • css/WebKitCSSRegionRule.h:

(WebCore):
(WebCore::WebKitCSSRegionRule::create):
(WebKitCSSRegionRule):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ensureSourceData):

  • inspector/InspectorStyleSheet.h:

(WebCore):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):

  • svg/SVGFontFaceElement.h:

(WebCore):
(WebCore::SVGFontFaceElement::fontFaceRule):
(SVGFontFaceElement):

12:48 PM Changeset in webkit [112922] by commit-queue@webkit.org
  • 20 edits
    9 deletes in trunk/LayoutTests

Rebaseline svg/W3C-SVG-1.1/animate-elem-XX-t.svg
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-02

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [112921] by jesus@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ResourceError::isCancellation() is always returning false
https://bugs.webkit.org/show_bug.cgi?id=82917

Reviewed by Noam Rosenthal.

We were missing the encoding of a boolean in ArgumentCoder<ResourceError>
and, therefore, we were getting always "false" for ResourceError::isCancellation()
for errors being sent through the IPC.

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:41 PM Changeset in webkit [112920] by scherkus@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2012-04-02 Andrew Scherkus <scherkus@chromium.org>

Add a layout test for videos that change resolutions during decoding.
https://bugs.webkit.org/show_bug.cgi?id=82686

Chromium has been bitten by these types of clips in the past hence the introduction
of a layout test. Test clips is only in VP8 as not all codecs support resolution
changes.

Reviewed by Eric Carlson.

  • platform/chromium/media/resources/frame_size_change.webm: Added.
  • platform/chromium/media/video-frame-size-change-expected.txt: Added.
  • platform/chromium/media/video-frame-size-change.html: Added.
12:37 PM Changeset in webkit [112919] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Scroll position is lost after hide/show element
https://bugs.webkit.org/show_bug.cgi?id=72852

Source/WebCore:

Maintain the scroll position of an overflowing element in the ElementRareData when the scrollable
RenderLayer is destroyed, which can be used to restore the scroll position if the same element gets
back a RenderLayer.

WebKit behaviour will be the same as Firefox and IE. It differs from Opera as it does not reset the
scroll position when an element is moved to another location in the same document. However Opera resets
the scroll position for elements moved to another document, which matches other browsers.

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.

Test: fast/overflow/scroll-div-hide-show.html

  • dom/Element.cpp:

(WebCore::Element::removedFromDocument):
Reset the saved scroll offset if the node is moved to another location in the same document or another one.

(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):

  • dom/Element.h:

Add helper functions to access the layer scroll offset from the element's rare data.

  • dom/ElementRareData.h:

(ElementRareData):
Add the scroll offset book-keeping.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Restore the scroll offset.
(WebCore::RenderLayer::~RenderLayer):
Store the scroll offset if document is not being destroyed.

LayoutTests:

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.

  • fast/overflow/scroll-div-hide-show-expected.txt: Added.
  • fast/overflow/scroll-div-hide-show.html: Added.
12:33 PM Changeset in webkit [112918] by schenney@chromium.org
  • 30 edits
    11 adds
    3 deletes in trunk/LayoutTests

[Chromium] Update expectations for SVG Lion results
https://bugs.webkit.org/show_bug.cgi?id=82926

Unreviewed Chromium SVG Lion expectations update.

  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/massive-coordinates-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/batik/text/textPosition-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:10 PM Changeset in webkit [112917] by eae@chromium.org
  • 1075 edits
    228 copies
    38 deletes in branches/subpixellayout

Merge trunk changes up until 112900 into subpixel branch.

12:06 PM Changeset in webkit [112916] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping inspector/styles/override-screen-size.html on Mac.

  • platform/mac/Skipped:
11:53 AM Changeset in webkit [112915] by commit-queue@webkit.org
  • 3 edits
    2 adds
    1 delete in trunk/LayoutTests

Updating test expectations
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-02

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/chromium/test_expectations.txt:
11:47 AM Changeset in webkit [112914] by alexis.menard@openbossa.org
  • 13 edits
    2 moves in trunk/Source/WebCore

Rename CSSPropertyLonghand files to StylePropertyShorthand.
https://bugs.webkit.org/show_bug.cgi?id=82905

Reviewed by Antti Koivisto.

r112880 renamed CSSPropertyLonghand class to StylePropertyShorthand, so the
files need to reflect this new name now.

No new tests : Just a renaming, No behaviour change intended.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSProperty.cpp:
  • css/StylePropertySet.cpp:
  • css/StylePropertyShorthand.cpp: Renamed from Source/WebCore/css/CSSPropertyLonghand.cpp.

(WebCore):
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h: Renamed from Source/WebCore/css/CSSPropertyLonghand.h.

(WebCore):
(StylePropertyShorthand):
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(WebCore::StylePropertyShorthand::length):

  • page/animation/AnimationBase.cpp:
11:23 AM Changeset in webkit [112913] by beidson@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/11020155> and https://bugs.webkit.org/show_bug.cgi?id=82910
REGRESSION (98963 and 109091): Crash when creating a WebArchive of a page with @page style rules

Reviewed by Antti Koivisto.

Source/WebCore:

Test: webarchive/css-page-rule-crash.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Page rules do not (currently) have subresource urls to get,

and are not CSSStyleRules.

LayoutTests:

  • webarchive/css-page-rule-crash-expected.webarchive: Added.
  • webarchive/css-page-rule-crash.html: Added.
11:21 AM Changeset in webkit [112912] by schenney@chromium.org
  • 2 edits
    2 adds
    3 deletes in trunk/LayoutTests

Expectations update for svg/css/stars-with-shadow.html
https://bugs.webkit.org/show_bug.cgi?id=82916

Unreviewed expectations change.

This rationalizes expectations for several platforms.

  • platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.
  • svg/css/stars-with-shadow-expected.txt: Replaced.
11:15 AM Changeset in webkit [112911] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r112851.
http://trac.webkit.org/changeset/112851
https://bugs.webkit.org/show_bug.cgi?id=82915

Broke 3 Mac accessibility tests (Requested by enrica on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

  • accessibility/AXObjectCache.cpp:
  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

LayoutTests:

  • accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
  • accessibility/anchor-link-selection-and-focus.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
11:13 AM Changeset in webkit [112910] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674

Reviewed by Geoffrey Garen.

Changed the MemoryPressureHandler hold off timer to start timing after
respondToMemoryPressure runs. The delay time is now 20 times longer than the
time it took for respondToMemoryPressure to run with a minimum of 5 seconds.
This throttles the response to low memory events in the extreme case where
we are spending most of our time paging / swapping.
This is a Mac only change.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

11:08 AM Changeset in webkit [112909] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/rendering/RenderFullScreen.cpp

Merge 112596
BUG=118853
Review URL: https://chromiumcodereview.appspot.com/9950061

11:06 AM Changeset in webkit [112908] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r112163.
http://trac.webkit.org/changeset/112163
https://bugs.webkit.org/show_bug.cgi?id=82914

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8Proxy.h:

(WebCore::toV8):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

10:57 AM Changeset in webkit [112907] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1025

Merge 112051
BUG=120037
Review URL: https://chromiumcodereview.appspot.com/9963064

10:56 AM Changeset in webkit [112906] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Unreviewed, rolling out r112318.
http://trac.webkit.org/changeset/112318
https://bugs.webkit.org/show_bug.cgi?id=82912

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

10:52 AM Changeset in webkit [112905] by cevans@google.com
  • 4 edits in branches/chromium/1025/Source/WebCore

Merge 112623
BUG=119281
Review URL: https://chromiumcodereview.appspot.com/9968049

10:52 AM Changeset in webkit [112904] by schenney@chromium.org
  • 20 edits
    3 adds
    3 deletes in trunk/LayoutTests

<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
https://bugs.webkit.org/show_bug.cgi?id=81631

Unreviewed Chromium expectations update.

  • platform/chromium-linux-x86/tables: Removed.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
  • platform/chromium-win-vista/tables: Removed.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/writing-mode/block-level-images-expected.txt: Removed.
10:46 AM Changeset in webkit [112903] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip failing inspector test on GTK.

  • platform/gtk/Skipped: Skip inspector/styles/override-screen-size.html
10:38 AM Changeset in webkit [112902] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1025

Merge 112200
BUG=118784
Review URL: https://chromiumcodereview.appspot.com/9968048

10:32 AM Changeset in webkit [112901] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Missing NULL check for vendor string from glGetString()
https://bugs.webkit.org/show_bug.cgi?id=82859

Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-02
Reviewed by Kentaro Hara.

glGetString() possible to return NULL value.
Refer to http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml
for more information. The missing null check crashes webkit when
vendor name is not set (null) by glGetString().

No new tests because this is missing NULL check for
for openGL API response.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes):

10:16 AM Changeset in webkit [112900] by fischman@chromium.org
  • 2 edits in trunk/Source/WebCore

Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
https://bugs.webkit.org/show_bug.cgi?id=82906

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleLoad):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):

10:13 AM Changeset in webkit [112899] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CPU time bar missing on top-level events in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82909

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.addRecord):

10:10 AM Changeset in webkit [112898] by eric.carlson@apple.com
  • 43 edits in trunk

Renaming parameters for positioning a track cue
https://bugs.webkit.org/show_bug.cgi?id=78706

Source/WebCore:

Change WebVTT settings identifiers for spec change: D: -> vertical:, L: -> line:,
T: -> position:, S: -> size:, A: -> align:

Reviewed by Sam Weinig.

No new tests, existing tests updated for spec changes.

  • html/track/TextTrackCue.cpp:

(WebCore::verticalGrowingLeftKeyword): Drive-by change to improve readability.
(WebCore::TextTrackCue::settingName): New, parse the settings keyword.
(WebCore::TextTrackCue::parseSettings): Update to match the current spec.

  • html/track/TextTrackCue.h:
  • html/track/WebVTTParser.h:

(WebCore::WebVTTParser::isValidSettingDelimiter): New.

LayoutTests:

Reviewed by Sam Weinig.

  • media/track/captions-webvtt/missed-cues.vtt:
  • media/track/captions-webvtt/sorted-dispatch.vtt:
  • media/track/captions-webvtt/tc005-default-styles.vtt:
  • media/track/captions-webvtt/tc014-alignment-bad.vtt:
  • media/track/captions-webvtt/tc014-alignment-ltr.vtt:
  • media/track/captions-webvtt/tc014-alignment.vtt:
  • media/track/captions-webvtt/tc015-positioning-bad.vtt:
  • media/track/captions-webvtt/tc015-positioning-ltr.vtt:
  • media/track/captions-webvtt/tc015-positioning.vtt:
  • media/track/captions-webvtt/tc016-align-positioning-bad.vtt:
  • media/track/captions-webvtt/tc016-align-positioning.vtt:
  • media/track/captions-webvtt/tc017-line-position-bad.vtt:
  • media/track/captions-webvtt/tc017-line-position.vtt:
  • media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt:
  • media/track/captions-webvtt/tc018-align-text-line-position.vtt:
  • media/track/captions-webvtt/tc019-cue-size-bad.vtt:
  • media/track/captions-webvtt/tc019-cue-size.vtt:
  • media/track/captions-webvtt/tc020-cue-size-align-bad.vtt:
  • media/track/captions-webvtt/tc020-cue-size-align.vtt:
  • media/track/captions-webvtt/tc021-valign-bad.vtt:
  • media/track/captions-webvtt/tc021-valign-ltr.vtt:
  • media/track/captions-webvtt/tc021-valign.vtt:
  • media/track/captions-webvtt/tc022-entities-wrong.vtt:
  • media/track/captions-webvtt/tc022-entities.vtt:
  • media/track/captions-webvtt/tc023-markup-bad.vtt:
  • media/track/captions-webvtt/tc023-markup.vtt:
  • media/track/captions-webvtt/tc024-timestamp-bad.vtt:
  • media/track/captions-webvtt/tc024-timestamp.vtt:
  • media/track/captions-webvtt/tc025-class-bad.vtt:
  • media/track/captions-webvtt/tc025-class.vtt:
  • media/track/captions-webvtt/tc026-voice-bad.vtt:
  • media/track/captions-webvtt/tc026-voice.vtt:
  • media/track/captions-webvtt/tc027-empty-cue.vtt:
  • media/track/captions-webvtt/tc028-unsupported-markup.vtt:

Update settings for spec change.

  • media/track/captions-webvtt/tc013-settings-bad-separation.vtt:
  • media/track/captions-webvtt/tc013-settings.vtt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:

Update test and results to skip illegal settings delimiters.

9:42 AM Changeset in webkit [112897] by cevans@google.com
  • 17 edits
    4 copies in branches/chromium/1025

Merge 112184
BUG=117583
Review URL: https://chromiumcodereview.appspot.com/9963061

9:39 AM Changeset in webkit [112896] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, CCLayerTreeHost runMultiThread is flaky.
Related bug: https://bugs.webkit.org/show_bug.cgi?id=80811

Disabled CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

9:23 AM Changeset in webkit [112895] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark http/tests/xmlhttprequest/upload-progress-events.html as crashy on Linux Debug

  • platform/chromium/test_expectations.txt:
9:22 AM Changeset in webkit [112894] by weinig@apple.com
  • 12 edits in trunk/Source

Add setting to disable Java for local files even if it is otherwise enabled
https://bugs.webkit.org/show_bug.cgi?id=82685

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Export setting setter.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::canEmbedJava):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):

  • page/Navigator.cpp:

(WebCore::Navigator::javaEnabled):
Check for both isJavaEnabled and isJavaEnabledForLocalFiles.

  • page/Settings.cpp:

(WebCore::Settings::setJavaEnabledForLocalFiles):

  • page/Settings.h:

(WebCore::Settings::isJavaEnabledForLocalFiles):
Add new setting.

Source/WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabledForLocalFiles):
(WKPreferencesGetJavaEnabledForLocalFiles):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add pref as SPI and forward to WebCore.

9:13 AM Changeset in webkit [112893] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Some SVG tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=82232

Unreviewed Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
9:07 AM Changeset in webkit [112892] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: Device metrics emulation should turn off when zero width and height are passed in
https://bugs.webkit.org/show_bug.cgi?id=82907

Currently this also requires the fontScaleFactor of 1 to be passed in, too. However, it results in
downsizing the FrameView to (0x0) on navigation with the open Inspector when the emulation is disabled.

Reviewed by Yury Semikhatsky.

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):

8:56 AM Changeset in webkit [112891] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp

Fixing baseline position data types in RenderTableSection.

8:41 AM Changeset in webkit [112890] by schenney@chromium.org
  • 9 edits in trunk/LayoutTests

LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469

Unreviewed Chromium test_expectations update.

These tests are skipped on Mac and the Mac baselines are hence wrong.
Comments on Bug 82469 indicate that our results are correct.

  • platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/chromium/test_expectations.txt:
8:35 AM Changeset in webkit [112889] by kbalazs@webkit.org
  • 21 edits
    2 copies
    3 adds in trunk

[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

  • Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

  • GNUmakefile.am:
  • PluginProcess.pro: Added.
  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

  • PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

  • Shared/Plugins/Netscape/NetscapePluginModule.h:

(WebKit):
(NetscapePluginModule):

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

  • Shared/ProcessExecutablePath.h: Added.

(WebKit):

  • Shared/gtk/ProcessExecutablePathGtk.cpp: Added.

(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):

  • Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.

(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

  • Target.pri:
  • UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

  • UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):

  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

  • qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.

(WebKit):
(main):

Tools:

  • qmake/mkspecs/features/features.prf: Reenable plugins

and turn on plugin process.

8:27 AM Changeset in webkit [112888] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/test_expectations.txt:
8:17 AM Changeset in webkit [112887] by kbalazs@webkit.org
  • 21 edits
    5 deletes in trunk

Unreviewed, rolling out r112868, r112879, and r112881.
http://trac.webkit.org/changeset/112868
http://trac.webkit.org/changeset/112879
http://trac.webkit.org/changeset/112881
https://bugs.webkit.org/show_bug.cgi?id=82901

"Build fail on bots." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

.:

  • Source/QtWebKit.pro:

Source/WebKit2:

  • GNUmakefile.am:
  • PluginProcess.pro: Removed.
  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

  • PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::PluginProcessMain):

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:

(NetscapePluginModule):

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::initializeGTK):
(WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad):
(WebKit::NetscapePluginModule::setMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/ProcessExecutablePath.h: Removed.
  • Shared/gtk/ProcessExecutablePathGtk.cpp: Removed.
  • Shared/qt/ProcessExecutablePathQt.cpp: Removed.
  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):

  • Target.pri:
  • UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit):
(WebKit::findWebKitProcess):
(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(PluginProcessProxy):

  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • qt/PluginMainQt.cpp: Removed.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • qmake/mkspecs/features/features.prf:
8:06 AM Changeset in webkit [112886] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112882.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
7:48 AM Changeset in webkit [112885] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip inspector/profiler/heap-snapshot-inspect-dom-wrapper.html in
debug mode as it crashes.

  • platform/chromium/test_expectations.txt:
7:45 AM Changeset in webkit [112884] by apavlov@chromium.org
  • 12 edits
    1 add in trunk/Source/WebCore

Web Inspector: Implement frontend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82891

This change implements the backend-based device metrics emulation capability discovery,
UI (enablement checkbox + input controls), and a persistence setting
for the user-specified device metrics (screen width/height and an auxiliary font scale factor).

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
(WebInspector.SettingsScreen.prototype.set _applyDeviceMetricsUserInput):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride.set if):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.createInput):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/UserAgentSupport.js: Added.

(WebInspector.UserAgentSupport.DeviceMetrics):
(WebInspector.UserAgentSupport.DeviceMetrics.parseSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.parseUserInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isWidthValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isHeightValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isFontScaleFactorValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.toSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.widthToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.heightToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.fontScaleFactorToInput):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css:

(.help-table > tr > th):
(.help-table > tr > td):
(#resolution-override-section):

  • inspector/front-end/inspector.css:

(.hidden):
(.error-input):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

7:32 AM Changeset in webkit [112883] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Switching an explicit wrapping in RenderTable.h to use a static_cast to mirror trunk. Removing an unnecessary pixelSnappedIntRect in RenderReplaced.

7:29 AM Changeset in webkit [112882] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] Enable shadow-dom in build-webkit.

Rubber-stamped by Gustavo Noronha Silva.

  • Scripts/build-webkit: Enable shadow-dom build, this is need to

have a working build currently.

7:28 AM Changeset in webkit [112881] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

One more try to fix Qt build after r112868.

It's a misery why I don't have these build failures
locally.

  • PluginProcess.pro:
7:19 AM Changeset in webkit [112880] by alexis.menard@openbossa.org
  • 13 edits in trunk/Source/WebCore

Rename CSSPropertyLonghand class to StylePropertyShorthand.
https://bugs.webkit.org/show_bug.cgi?id=82624

Reviewed by Antti Koivisto.

Rename CSSPropertyLonghand to StylePropertyShorthand as what CSSPropertyLonghand
is representing is not a longhand but the list of longhands for a given shorthand.
Also in the same time switch all shorthand declarations to use CSSPropertyID enum
rather than a int so it is clear on what kind of data we are dealing with.

In a following patch I will rename CSSPropertyLonghand file.

No new tests : This is a refactoring, no behaviour change intended

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

  • css/CSSPropertyLonghand.cpp:

(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):

  • css/CSSPropertyLonghand.h:

(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(StylePropertyShorthand):
(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • editing/EditingStyle.cpp:

(WebCore):
(WebCore::removePropertiesInStyle):

  • page/animation/AnimationBase.cpp:

(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::addShorthandProperties):

  • page/animation/CompositeAnimation.cpp:
7:15 AM Changeset in webkit [112879] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix Qt build after r112868.

  • PluginProcess.pro: Add WTF into includepath.
7:12 AM Changeset in webkit [112878] by leviw@chromium.org
  • 11 edits in branches/subpixellayout/Source/WebCore

Reverting remaining RenderTheme methods to operate on integers. Reverting absoluteContentBox to an IntRect. This has the affect of no longer requiring us to round in RenderWidget, which is for the best.

7:02 AM Changeset in webkit [112877] by apavlov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, baseline for fast/dom/shadow/form-in-shadow.html

  • platform/chromium/fast/dom/shadow/form-in-shadow-expected.txt: Added.
6:58 AM Changeset in webkit [112876] by kling@webkit.org
  • 2 edits in trunk/Tools

Adding Zalan Bujtas to committers list.

  • Scripts/webkitpy/common/config/committers.py:
6:55 AM Changeset in webkit [112875] by podivilov@chromium.org
  • 12 edits in trunk

Web Inspector: refactor UI breakpoint listeners.
https://bugs.webkit.org/show_bug.cgi?id=82481

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are currently dispatched on UISourceCode.
That allows us to move handlers that manage SourceFrame's breakpoint decorations from ScriptsPanel to SourceFrame.
SourceFrame's "Loaded" event is removed as it was only used by ScriptsPanel to restore SourceFrame's breakpoints.

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointRemoved):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextViewerContentLoaded):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):

  • inspector/debugger/live-edit.html:
  • inspector/debugger/set-breakpoint.html:
  • inspector/debugger/source-frame.html:
6:44 AM Changeset in webkit [112874] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Web Inspector: Implement support for InspectorClient::overrideDeviceMetrics() in platforms other than Chromium
https://bugs.webkit.org/show_bug.cgi?id=82886

Patch by János Badics <János Badics> on 2012-04-02

  • platform/qt/Skipped: Skip inspector/styles/override-screen-size.html.
6:42 AM Changeset in webkit [112873] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling chromium DEPS.

  • DEPS:
6:41 AM Changeset in webkit [112872] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Qt: Doc: Fix typo which marks document to be printed in console font.
https://bugs.webkit.org/show_bug.cgi?id=82893

Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-04-02
Reviewed by Simon Hausmann.

The qtwebkit-bridge.qdoc file contained a typo where a \c {} was
missing its closing curly bracket, this marked the rest of the page as
text to be printed using the code/console font.

  • docs/qtwebkit-bridge.qdoc:
6:37 AM Changeset in webkit [112871] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Call resize on frameview in WebPage::resizeToContentsIfNeeded only when the size changes.
https://bugs.webkit.org/show_bug.cgi?id=82892

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-02
Reviewed by Kenneth Rohde Christiansen.

Check against the expanded size before calling resize on frameview.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):
(WebKit::WebPage::resizeToContentsIfNeeded):

6:36 AM Changeset in webkit [112870] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Take into account policy checks in ClipboardBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82651

Reviewed by George Staikos.

Add policy checks in the methods we implemented.

Covered by existing tests.

  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(WebCore::ClipboardBlackBerry::create):

6:12 AM Changeset in webkit [112869] by yurys@chromium.org
  • 3 edits in trunk

2012-04-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html as
slow.

  • platform/chromium/test_expectations.txt:
6:08 AM Changeset in webkit [112868] by kbalazs@webkit.org
  • 21 edits
    2 copies
    3 adds in trunk

[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

  • Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

  • GNUmakefile.am:
  • PluginProcess.pro: Added.
  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

  • PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

  • Shared/Plugins/Netscape/NetscapePluginModule.h:

(WebKit):
(NetscapePluginModule):

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

  • Shared/ProcessExecutablePath.h: Added.

(WebKit):

  • Shared/gtk/ProcessExecutablePathGtk.cpp: Added.

(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):

  • Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.

(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

  • Target.pri:
  • UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

  • UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):

  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

  • qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.

(WebKit):
(main):

Tools:

  • qmake/mkspecs/features/features.prf: Reenable plugins

and turn on plugin process.

6:06 AM Changeset in webkit [112867] by Philippe Normand
  • 5 edits in trunk/Source/WebKit2

[GTK][WK2] Initial FullScreen support
https://bugs.webkit.org/show_bug.cgi?id=75553

Reviewed by Martin Robinson.

Full screen display support in WebKitWebViewBase. Two functions
have been added to handle this. They're called by the
WebFullScreenManagerProxy when full screen display needs to be
managed for an HTML element.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate):
(webkitWebViewBaseCreateWebPage):
(onFullscreenGtkKeyPressEvent):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

6:01 AM Changeset in webkit [112866] by yurys@chromium.org
  • 2 edits in trunk

2012-04-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark newly added test as slow.

  • platform/chromium/test_expectations.txt:
5:49 AM Changeset in webkit [112865] by caseq@chromium.org
  • 9 edits
    1 add in trunk/Source/WebCore

Web Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameController
https://bugs.webkit.org/show_bug.cgi?id=82735

Reviewed by Pavel Feldman.

  • factor out frame aggregation logic from TimelineVerticalOverview into TimelineFrameController;
  • if we don't have frames, pretend each top-level event is a frame (this preserves behavior of vertical overview);
  • factor out time-by-category stats aggregation into class methods of TimelineModel for reuse accross timeline modules;
  • do not filter top-level events by type in vertical overview mode;
  • WebCore.gypi: Added TimelineFrameController.js
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • inspector/compile-front-end.py: ditto.
  • inspector/front-end/TimelineFrameController.js: Added.

(WebInspector.TimelineFrameController):
(WebInspector.TimelineFrameController.prototype._onRecordAdded):
(WebInspector.TimelineFrameController.prototype._onRecordsCleared):
(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): create a "frame" based on a single top-level record.
(WebInspector.TimelineFrameController.prototype.dispose): Remove listeners that we added in constructor.
(WebInspector.TimelineFrame):

  • inspector/front-end/TimelineModel.js: Added utilities for aggregating times by categories.

(WebInspector.TimelineModel.aggregateTimeByCategories):
(WebInspector.TimelineModel.aggregateTimeForRecord):

  • inspector/front-end/TimelineOverviewPane.js: Use frame information supplied by TimelineFrameController.

(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype.reset): Clear stored frames upon reset()
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

  • inspector/front-end/TimelinePanel.js: Create/dispose TimelineFrameController when switching to/from vertical overview mode.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats): Factored out statistics aggregation to utilities method in the model.

  • inspector/front-end/WebKit.qrc: Added TimelineFrameController.js
  • inspector/front-end/inspector.html: ditto.
5:20 AM Changeset in webkit [112864] by apavlov@chromium.org
  • 10 edits in trunk

Web Inspector: Implement backend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82827

Source/WebCore:

This change implements the inspector backend for the device metrics override feature,
as well as the respective InspectorClient capability detection.
When a navigation occurs in the override mode, the page auto-zooming ("fit width")
is initiated upon the first layout after the DOMContentLoaded event.

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canOverrideDeviceMetrics):
(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):
(InspectorClient):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLayoutImpl):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateViewMetrics):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getDouble):
(WebCore):

  • inspector/InspectorState.h:

(InspectorState):
(WebCore::InspectorState::setDouble):

LayoutTests:

Follow the Web Inspector Protocol change.

Reviewed by Pavel Feldman.

  • inspector/styles/override-screen-size.html:
5:16 AM Changeset in webkit [112863] by commit-queue@webkit.org
  • 44 edits
    49 deletes in trunk

Unreviewed, rolling out r112813 and r112837.
http://trac.webkit.org/changeset/112813
http://trac.webkit.org/changeset/112837
https://bugs.webkit.org/show_bug.cgi?id=82885

It made two tests crash on WK2 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedAngle.h:

(WebCore):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedEnumeration.cpp: Removed.
  • svg/SVGAnimatedEnumeration.h:

(WebCore):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
(WebCore):
(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedType.h:

(SVGAnimatedType):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):

  • svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

  • svg/SVGMarkerElement.cpp:

(WebCore):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

LayoutTests:

  • svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Removed.
  • svg/animations/animate-marker-orient-from-angle-to-angle.html: Removed.
  • svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Removed.
  • svg/animations/animate-marker-orient-from-angle-to-auto.html: Removed.
  • svg/animations/animate-marker-orient-to-angle-expected.txt: Removed.
  • svg/animations/animate-marker-orient-to-angle.html: Removed.
  • svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Removed.
  • svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Removed.
  • svg/animations/script-tests/animate-marker-orient-to-angle.js: Removed.
  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgenum-animation-1.js: Removed.
  • svg/animations/script-tests/svgenum-animation-10.js: Removed.
  • svg/animations/script-tests/svgenum-animation-11.js: Removed.
  • svg/animations/script-tests/svgenum-animation-12.js: Removed.
  • svg/animations/script-tests/svgenum-animation-13.js: Removed.
  • svg/animations/script-tests/svgenum-animation-2.js: Removed.
  • svg/animations/script-tests/svgenum-animation-3.js: Removed.
  • svg/animations/script-tests/svgenum-animation-4.js: Removed.
  • svg/animations/script-tests/svgenum-animation-5.js: Removed.
  • svg/animations/script-tests/svgenum-animation-6.js: Removed.
  • svg/animations/script-tests/svgenum-animation-7.js: Removed.
  • svg/animations/script-tests/svgenum-animation-8.js: Removed.
  • svg/animations/script-tests/svgenum-animation-9.js: Removed.
  • svg/animations/svgangle-animation-deg-to-grad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-rad-expected.txt:
  • svg/animations/svgangle-animation-grad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-grad-to-rad-expected.txt:
  • svg/animations/svgangle-animation-rad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-rad-to-grad-expected.txt:
  • svg/animations/svgenum-animation-1-expected.txt: Removed.
  • svg/animations/svgenum-animation-1.html: Removed.
  • svg/animations/svgenum-animation-10-expected.txt: Removed.
  • svg/animations/svgenum-animation-10.html: Removed.
  • svg/animations/svgenum-animation-11-expected.txt: Removed.
  • svg/animations/svgenum-animation-11.html: Removed.
  • svg/animations/svgenum-animation-12-expected.txt: Removed.
  • svg/animations/svgenum-animation-12.html: Removed.
  • svg/animations/svgenum-animation-13-expected.txt: Removed.
  • svg/animations/svgenum-animation-13.html: Removed.
  • svg/animations/svgenum-animation-2-expected.txt: Removed.
  • svg/animations/svgenum-animation-2.html: Removed.
  • svg/animations/svgenum-animation-3-expected.txt: Removed.
  • svg/animations/svgenum-animation-3.html: Removed.
  • svg/animations/svgenum-animation-4-expected.txt: Removed.
  • svg/animations/svgenum-animation-4.html: Removed.
  • svg/animations/svgenum-animation-5-expected.txt: Removed.
  • svg/animations/svgenum-animation-5.html: Removed.
  • svg/animations/svgenum-animation-6-expected.txt: Removed.
  • svg/animations/svgenum-animation-6.html: Removed.
  • svg/animations/svgenum-animation-7-expected.txt: Removed.
  • svg/animations/svgenum-animation-7.html: Removed.
  • svg/animations/svgenum-animation-8-expected.txt: Removed.
  • svg/animations/svgenum-animation-8.html: Removed.
  • svg/animations/svgenum-animation-9-expected.txt: Removed.
  • svg/animations/svgenum-animation-9.html: Removed.
5:13 AM Changeset in webkit [112862] by Csaba Osztrogonác
  • 21 edits in trunk

Unreviewed, rolling out r112651.
http://trac.webkit.org/changeset/112651
https://bugs.webkit.org/show_bug.cgi?id=82887

It doesn't work with older Qt