Timeline



May 15, 2012:

11:45 PM Changeset in webkit [117224] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in Document::nodeChildrenWillBeRemoved.
​https://bugs.webkit.org/show_bug.cgi?id=85247

Reviewed by Hajime Morita.

Source/WebCore:

Reverse ordering of commands to ref ptr the children set
first before calling nodeChildrenWillBeRemoved, since it
can fire mutation events.

Test: fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

LayoutTests:

  • fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml: Added.
11:44 PM Changeset in webkit [117223] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enhance an API of BackingStore::drawContents
​https://bugs.webkit.org/show_bug.cgi?id=86447

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-05-15
Reviewed by George Staikos.

Enhance the current APIs by adding parameters of id and destination
contentSize, because chrome browser may want different contents from
the same webview at different times.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

11:24 PM Changeset in webkit [117222] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit2

Fix Qt5/Mac build after r117212 by adding missing NETSCAPE_PLUGIN_API guards
​https://bugs.webkit.org/show_bug.cgi?id=86577

Reviewed by Andy Estes.

  • Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::getPluginInfo):

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
10:39 PM Changeset in webkit [117221] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 would fail to build on Windows if Netscape plug-ins were disabled.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::getPluginInfo): Return false if ENABLE_NETSCAPE_PLUGIN_API is false.

10:36 PM Changeset in webkit [117220] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Worker] Web Worker lacks test for posting structured data message.
​https://bugs.webkit.org/show_bug.cgi?id=86556

Patch by Li Yin <​li.yin@intel.com> on 2012-05-15
Reviewed by David Levin.

From ​http://www.w3.org/TR/2012/CR-workers-20120501/#communicating-with-a-dedicated-worker
Structured data can be sent over the communication channel.

  • fast/workers/resources/worker-structure-message.js: Added.

(self.onmessage):

  • fast/workers/worker-structure-message-expected.txt: Added.
  • fast/workers/worker-structure-message.html: Added.
10:13 PM Changeset in webkit [117219] by noel.gordon@gmail.com
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

Merge 116636 - [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
​https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

On some JPEG images, vertical and horizontal lines artifacts might appear in image
regions with very high frequency color variation when using DCT_IFAST decodes. Use
DCT_IFAST on small screen devices only (Chromium Android).

No new tests. Covered by existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(dctMethod): Permit DCT_IFAST decoding for Chromium Android only.

LayoutTests: [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
​https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Add IMAGE expectations.

TBR=​noel.gordon@gmail.com
Review URL: ​https://chromiumcodereview.appspot.com/10388157

10:06 PM Changeset in webkit [117218] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] Fix eventSender key providing
​https://bugs.webkit.org/show_bug.cgi?id=84710

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-05-15
Reviewed by Andreas Kling.

Currently eventSender doesn't provide key event correctly.
For example, 'Right' will be visible when 'right arrow' key event is fired.
Given circumstance, nothing has to be shown.
Therefore, this patch fixed incorrectly provided key event.

Tools:

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

LayoutTests:

  • platform/efl/Skipped:
10:02 PM Changeset in webkit [117217] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectation update after r117206

  • platform/chromium/test_expectations.txt:
9:49 PM Changeset in webkit [117216] by igor.o@sisa.samsung.com
  • 4 edits
    2 adds in trunk

regression(111639): Issue with simultaneous CSS animations
​https://bugs.webkit.org/show_bug.cgi?id=85929

Source/WebCore:

Currently, previousTimeToNextService is just saving the previous CompositeAnimation::timeToNextService
for AnimationControllerPrivate::updateAnimationTimerForRenderer, however CompositeAnimation::timeToNextService
is also called and used by updateAnimationTimer. Make sure we save the existing timeToNextService from
both places, updateAnimationTimerForRenderer and updateAnimationTimer.

Reviewed by Dean Jackson.

Test: animations/fill-mode-forwards.html

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

LayoutTests:

Reviewed by Dean Jackson.

  • animations/fill-mode-forwards-expected.txt: Added.
  • animations/fill-mode-forwards.html: Added.
9:31 PM Changeset in webkit [117215] by mitz@apple.com
  • 2 edits in trunk/Tools

Fixed a typo.

  • Scripts/copy-webkitlibraries-to-product-directory:
9:07 PM Changeset in webkit [117214] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] CCTimer::isActive() is incorrect inside tick callback
​https://bugs.webkit.org/show_bug.cgi?id=86513

Source/WebCore:

This patch implements CCTimer::isActive() by clearing the task pointer
when the timer fires.

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.

No new tests. Existing tests updated accordingly.

  • platform/graphics/chromium/cc/CCTimer.cpp:

(WebCore::CCTimerTask::performTask):

  • rendering/RenderLayerBacking.cpp:

Source/WebKit/chromium:

Update test cases to verify CCTimer::isActive() values.

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.

  • tests/CCTimerTest.cpp:

(WebKitTests::TEST_F):

9:00 PM Changeset in webkit [117213] by commit-queue@webkit.org
  • 12 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r117204.
​http://trac.webkit.org/changeset/117204
​https://bugs.webkit.org/show_bug.cgi?id=86559

causing win compilation failures (Requested by pilgrim_google_
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-15

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):

  • chromium/public/WebMessagePortChannel.h: Removed.
  • chromium/public/WebMessagePortChannelClient.h: Removed.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebMessagePortChannel.h:

(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createMessagePortChannel):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

  • src/PlatformMessagePortChannel.h:
  • src/SharedWorkerRepository.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebWorkerClientImpl.cpp:
8:55 PM Changeset in webkit [117212] by aestes@apple.com
  • 35 edits in trunk/Source/WebKit2

Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
​https://bugs.webkit.org/show_bug.cgi?id=86496

Reviewed by Sam Weinig.

Ensure that WebKit2 can compile with ENABLE_NETSCAPE_PLUGIN_API disabled.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
  • WebProcess/Plugins/PluginController.h:

(PluginController):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::didFinishLoading):
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::scriptObject):
(WebKit):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

8:49 PM Changeset in webkit [117211] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertyDescriptor):

8:07 PM Changeset in webkit [117210] by shinyak@chromium.org
  • 17 edits in trunk/Source

Rename Node::shadowTreeRootNode() to Node::shadowRoot()
​https://bugs.webkit.org/show_bug.cgi?id=86449

Reviewed by Darin Adler.

Source/WebCore:

Since Node::shadowTreeRootNode() returns always a ShadowRoot now, shadowRoot() is
mure suitable than shadowTreeRootNode().

This patch changes the method name.

No new tests, no change in behavior.

  • WebCore.order:
  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable):
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowRoot):

  • dom/Node.h:

(Node):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/Range.cpp:

(WebCore::Range::shadowRoot):

  • dom/Range.h:

(Range):

  • editing/Editor.cpp:

(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::countMatchesForText):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

  • editing/htmlediting.cpp:

(WebCore::indexForVisiblePosition):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::matches):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::detach):

  • page/EventHandler.cpp:

(WebCore::instanceAssociatedWithShadowTreeElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingElement):
(WebCore::collectInstancesForSVGElement):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):

8:03 PM Changeset in webkit [117209] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove some unused gyp lines
​https://bugs.webkit.org/show_bug.cgi?id=86545

Reviewed by Dirk Pranke.

mac_framework_dirs adds directories to search for frameworks
(similar to -I for includes), it doesn't add any frameworks.
Having something that ends in .framewok in mac_framework_dirs
doesn't make sense.

No intended functionality change.

  • WebCore.gyp/WebCore.gyp:
7:55 PM Changeset in webkit [117208] by alexis.menard@openbossa.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt.

These tests were unskipped but their expectations were not up-to-date.

  • platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt:
  • platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
7:54 PM Changeset in webkit [117207] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] build a static list of mime-types
​https://bugs.webkit.org/show_bug.cgi?id=86331

Reviewed by Martin Robinson.

Don't bother parsing the gstreamer typefind factories and doing
ugly hacks around this. Instead build a static list and let our
::supportsType() method return MediaPlayer::MayBeSupported or
MediaPlayer::IsSupported for them. Playback will still fail if a
demuxer or decoder is missing for one of these mime-types but we
will handle that case more properly soon by fixing bug 34085 and
bug 34318.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
7:49 PM Changeset in webkit [117206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

MHTML files should be loadable from all schemes considered local,
not just file:

​https://bugs.webkit.org/show_bug.cgi?id=86540

Patch by Greg Spencer <​gspencer@chromium.org> on 2012-05-15
Reviewed by Adam Barth.

Current tests should assure that loading is still allowed locally.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterContentPolicy):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::create):

7:34 PM Changeset in webkit [117205] by commit-queue@webkit.org
  • 10 edits
    10 adds in trunk

[EFL] Enable Fullscreen API
​https://bugs.webkit.org/show_bug.cgi?id=85870

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

.:

Enable FULLSCREEN_API on the Efl port.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::supportsFullScreenForElement):
Add check routine if the full screen is enabled by page setting.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
Add full screen setting to be true.

Tools:

Enable full screen api feature on the EFL port.
There are two failed test cases under LayoutTests/fullscreen.
They are going to be fixed with other patch.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/Skipped: Remove fullscreen/video-controls-override.html.
  • platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/efl/fullscreen/full-screen-placeholder-expected.txt: Added.
  • platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/efl/fullscreen/full-screen-render-inline-expected.txt: Added.
  • platform/efl/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/efl/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/efl/fullscreen/full-screen-zIndex-expected.png: Added.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
  • platform/efl/test_expectations.txt: Remove fullscreen and media/video-play-require-user-gesture.html
    • Add full-screen-keyboard-disabled.html and video-controls-drag.html to the efl's test_expectation.txt
7:30 PM Changeset in webkit [117204] by pilgrim@chromium.org
  • 12 edits
    2 copies in trunk/Source

[Chromium] Move createMessagePortChannel to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=85764

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createMessagePortChannel):

  • chromium/public/WebMessagePortChannel.h: Added.

(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):

  • chromium/public/WebMessagePortChannelClient.h: Added.

(WebKit):
(WebMessagePortChannelClient):
(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebMessagePortChannel.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

  • src/PlatformMessagePortChannel.h:
  • src/SharedWorkerRepository.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebWorkerClientImpl.cpp:
7:00 PM Changeset in webkit [117203] by fsamuel@chromium.org
  • 6 edits in trunk/Source

[Chromium] Reset ScriptInstance in HTMLPlugInElement on WebPluginContainerImpl::setPlugin
​https://bugs.webkit.org/show_bug.cgi?id=86535

Source/WebCore:

Reviewed by Darin Fisher.

When we swap out WebPluginImpls for the Browser Plugin, the HTMLPlugInElement continues
to use a now invalid ScriptInstance, so we reset the ScriptInstance on WebPluginContainerImpl::setPlugin

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::resetInstance):
(WebCore):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setPlugin):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

6:46 PM Changeset in webkit [117202] by pilgrim@chromium.org
  • 10 edits
    2 copies in trunk/Source

[Chromium] Move blobRegistry to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=85765

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::blobRegistry):

  • chromium/public/WebBlobData.h: Added.

(WebKit):
(WebBlobData):
(WebKit::WebBlobData::~WebBlobData):
(WebKit::WebBlobData::WebBlobData):
(WebKit::WebBlobData::isNull):

  • chromium/public/WebBlobRegistry.h: Added.

(WebKit):
(WebBlobRegistry):
(WebKit::WebBlobRegistry::~WebBlobRegistry):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebBlobData.h:
  • public/platform/WebBlobRegistry.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::cookieJar):

  • src/BlobRegistryProxy.cpp:

(WebCore::BlobRegistryProxy::BlobRegistryProxy):

  • src/WebBlobData.cpp:
6:44 PM Changeset in webkit [117201] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Block freeing thread should not free blocks when we are actively requesting them
​https://bugs.webkit.org/show_bug.cgi?id=86519

Reviewed by Geoff Garen.

  • heap/BlockAllocator.h:

(JSC::BlockAllocator::allocate): Reordering the setting of the flag so its done
while we hold the lock to ensure proper locking.

6:42 PM Changeset in webkit [117200] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Overloaded printBegin() function to support auto fit to page functionality.
​https://bugs.webkit.org/show_bug.cgi?id=84312

Patch by Kausalya Madhusudhanan <​kmadhusu@chromium.org> on 2012-05-15
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebKit):
(WebFrame):

  • public/WebPlugin.h:

(WebKit):
(WebPlugin):
(WebKit::WebPlugin::printBegin):

  • public/WebPrintParams.h: Added.

(WebKit):
(WebPrintParams):
(WebKit::WebPrintParams::WebPrintParams):

  • src/WebFrameImpl.cpp:

(WebKit::ChromePluginPrintContext::ChromePluginPrintContext):
(WebKit::ChromePluginPrintContext::computePageRects):
(ChromePluginPrintContext):
(WebKit):
(WebKit::WebFrameImpl::printBegin):

  • src/WebFrameImpl.h:

(WebKit):
(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

  • src/WebPluginContainerImpl.h:

(WebKit):
(WebPluginContainerImpl):

6:28 PM WebKit Team edited by yosin@chromium.org
Add yosin to Committers list (diff)
6:24 PM Changeset in webkit [117199] by shawnsingh@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add unit testing to WebTransformationMatrix
​https://bugs.webkit.org/show_bug.cgi?id=86421

Reviewed by Adrienne Walker.

  • WebKit.gypi:
  • tests/WebTransformationMatrixTest.cpp: Added.

(WebKit):
(WebKit::printTransform):
(WebKit::initializeTestMatrix):
(WebKit::initializeTestMatrix2):
(WebKit::TEST):

6:16 PM WebInspector edited by contact@freemobileactu.com
(diff)
5:56 PM Changeset in webkit [117198] by fpizlo@apple.com
  • 9 edits in trunk/Source

shrinkToFit() is often not called for Vectors in CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=86436

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The vectors in CodeBlock are often appended to during various stages of
compilation, but we neglect to shrink them after compilation finishes. This
patch takes the most brutal possible approach: shrink all the vectors after
the bytecompile phase, and then shrink them again after the appropriate
JITing phase. The two shrinks are necessary because the JIT may append more
stuff, but may also generate code that directly references things in other
vectors; hence some can only be shrunk before JIT and some after. Also,
we may allow a CodeBlock to sit around for a long time - possibly forever -
before invoking the JIT, hence it makes sense to have two shrinks.

This is performance neutral on the major benchmarks we track.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::appendWeakReferenceTransition):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

Source/WTF:

Reviewed by NOBODY (OOPS!).

Gave SegmentedVector a shrinkToFit() method. This only shrinks the segment
lookup table, which is likely to not be hugely profitable, but it is better
than nothing.

  • wtf/SegmentedVector.h:

(SegmentedVector):
(WTF::SegmentedVector::shrinkToFit):

5:56 PM Changeset in webkit [117197] by robert@webkit.org
  • 5 edits
    292 deletes in trunk

Heap-use-after-free in WebCore::RenderBlock::layoutRunsAndFloats
​https://bugs.webkit.org/show_bug.cgi?id=86206

Reviewed by Abhishek Arya.

Source/WebCore:

Revert ​https://trac.webkit.org/changeset/116438/. It caused three different regressions on
ClusterFuzz.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h:

(RenderBlock):

LayoutTests:

Revert ​https://trac.webkit.org/changeset/116438/ and subsequent pixel results. It caused three different regressions on
ClusterFuzz.

  • css2.1/20110323/first-letter-000.htm: Removed.
  • css2.1/20110323/first-letter-001.htm: Removed.
  • css2.1/20110323/first-letter-dynamic-001.htm: Removed.
  • css2.1/20110323/first-letter-dynamic-002.htm: Removed.
  • css2.1/20110323/first-letter-dynamic-003a.htm: Removed.
  • css2.1/20110323/first-letter-dynamic-003b.htm: Removed.
  • css2.1/20110323/first-letter-inherit-001.htm: Removed.
  • css2.1/20110323/first-letter-nested-001.htm: Removed.
  • css2.1/20110323/first-letter-nested-002.htm: Removed.
  • css2.1/20110323/first-letter-nested-003.htm: Removed.
  • css2.1/20110323/first-letter-nested-004.htm: Removed.
  • css2.1/20110323/first-letter-nested-005.htm: Removed.
  • css2.1/20110323/first-letter-nested-006.htm: Removed.
  • css2.1/20110323/first-letter-nested-007.htm: Removed.
  • css2.1/20110323/first-letter-quote-001.htm: Removed.
  • css2.1/20110323/first-letter-quote-002.htm: Removed.
  • css2.1/20110323/first-letter-quote-003.htm: Removed.
  • css2.1/20110323/first-letter-quote-004.htm: Removed.
  • css2.1/20110323/first-letter-quote-005.htm: Removed.
  • css2.1/20110323/first-letter-quote-006.htm: Removed.
  • fast/css/first-letter-capitalized-edit-select-crash-expected.txt:
  • fast/css/first-letter-nested-positioned.htm: Removed.
  • fast/css/first-letter-quotes-no-content-before-after.html: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/efl/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/gtk/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/gtk/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/mac/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-000-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-000-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
  • platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
  • platform/qt/fast/css/first-letter-nested-positioned-expected.png: Removed.
  • platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Removed.
  • platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
  • platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
5:37 PM Changeset in webkit [117196] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86549
Page Scale + Tiled Drawing: Twitter sign in page content disappears
after typing into name and enabling password field
-and corresponding-
<rdar://problem/11415352>

Reviewed by Oliver Hunt.

The enormous rect we used to use would overflow in CA and do nothing
when there was any scale > 1 on the context. Instead, just call
setNeedsDisplay on each tile.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):

5:34 PM Changeset in webkit [117195] by kling@webkit.org
  • 257 edits in trunk/Source/WebCore

Pass Attribute by const reference as much as possible.
<​http://webkit.org/b/86487>

Reviewed by Darin Adler.

Switch to passing around "const Attribute&" instead of "Attribute*" wherever possible.
This helps enforce the constness and non-nullity of these arguments at compile time.

Also renamed 'attr' to 'attribute' in the touched code. Attr and Attribute are two
different classes, so having "Attribute attr" just looks wrong.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/v8/ScriptEventListener.h:
  • dom/Attr.cpp:

(WebCore::Attr::setPrefix):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
(WebCore::Attr::style):
(WebCore::Attr::elementAttribute):

  • dom/Attr.h:
  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):

  • dom/Element.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::setAttributes):
(WebCore::ElementAttributeData::replaceAttribute):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLAnchorElement.h:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseAttribute):

  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::parseAttribute):

  • html/HTMLAreaElement.h:
  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::parseAttribute):

  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::parseAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::parseAttribute):

  • html/HTMLCanvasElement.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::parseAttribute):

  • html/HTMLDetailsElement.h:
  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectStyleForAttribute):

  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::dirAttributeChanged):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::parseAttribute):

  • html/HTMLFrameElement.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::parseMaxLengthAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::parseAttribute):

  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):

  • html/HTMLLIElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):

  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseAttribute):

  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectStyleForAttribute):

  • html/HTMLMarqueeElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::parseAttribute):

  • html/HTMLMetaElement.h:
  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::parseAttribute):

  • html/HTMLMeterElement.h:
  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):

  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::parseAttribute):

  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::parseAttribute):

  • html/HTMLOptionElement.h:
  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::parseAttribute):

  • html/HTMLOutputElement.h:
  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectStyleForAttribute):

  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::collectStyleForAttribute):

  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::collectStyleForAttribute):

  • html/HTMLPreElement.h:
  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::parseAttribute):

  • html/HTMLProgressElement.h:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute):

  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::parseMultipleAttribute):

  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):

  • html/HTMLStyleElement.h:
  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):

  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::parseAttribute):

  • html/HTMLTextFormControlElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):

  • html/HTMLTrackElement.h:
  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::collectStyleForAttribute):

  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):

  • html/HTMLVideoElement.h:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentElement.h:
  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectStyleForAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::parseAttribute):

  • svg/SVGAElement.h:
  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::parseAttribute):

  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::parseAttribute):

  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::parseAttribute):

  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::parseAttribute):

  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::parseAttribute):

  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::parseAttribute):

  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::reportAttributeParsingError):
(WebCore::SVGElement::parseAttribute):
(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:
  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::parseAttribute):

  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp:

(WebCore::SVGExternalResourcesRequired::parseAttribute):

  • svg/SVGExternalResourcesRequired.h:

(SVGExternalResourcesRequired):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::parseAttribute):

  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::parseAttribute):

  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::parseAttribute):

  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::parseAttribute):

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::parseAttribute):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::parseAttribute):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::parseAttribute):

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::parseAttribute):

  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::parseAttribute):

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseAttribute):

  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::parseAttribute):

  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::parseAttribute):

  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::parseAttribute):

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::parseAttribute):

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::parseAttribute):

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::parseAttribute):

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::parseAttribute):

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::parseAttribute):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(SVGFilterPrimitiveStandardAttributes):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseAttribute):

  • svg/SVGFitToViewBox.h:

(SVGFitToViewBox):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):

  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::parseAttribute):

  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::parseAttribute):

  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::parseAttribute):

  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::parseAttribute):

  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::parseAttribute):

  • svg/SVGGlyphRefElement.h:
  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::parseAttribute):

  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):

  • svg/SVGImageElement.h:
  • svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::sourceURI):

  • svg/SVGLangSpace.cpp:

(WebCore::SVGLangSpace::parseAttribute):

  • svg/SVGLangSpace.h:

(SVGLangSpace):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::parseAttribute):

  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::parseAttribute):

  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::parseAttribute):

  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::parseAttribute):

  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::parseAttribute):

  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::parseAttribute):

  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::parseAttribute):

  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::parseAttribute):

  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::parseAttribute):

  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute):

  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::parseAttribute):

  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::parseAttribute):

  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::parseAttribute):

  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):

  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::parseAttribute):

  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::parseAttribute):

  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::parseAttribute):

  • svg/SVGTRefElement.h:
  • svg/SVGTests.cpp:

(WebCore::SVGTests::parseAttribute):

  • svg/SVGTests.h:

(SVGTests):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):

  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::parseAttribute):

  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::parseAttribute):

  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::parseAttribute):

  • svg/SVGTextPositioningElement.h:
  • svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::parseAttribute):

  • svg/SVGURIReference.h:

(SVGURIReference):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::parseAttribute):

  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::parseAttribute):

  • svg/SVGViewElement.h:
  • svg/SVGZoomAndPan.cpp:

(WebCore::SVGZoomAndPan::parseAttribute):

  • svg/SVGZoomAndPan.h:

(SVGZoomAndPan):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseAttribute):

  • svg/animation/SVGSMILElement.h:
5:32 PM Changeset in webkit [117194] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/test_expectations.txt

Stable gardening - getting a test expectation baseline

5:21 PM Changeset in webkit [117193] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make error information available even if all we have is line number information.
​https://bugs.webkit.org/show_bug.cgi?id=86547

Reviewed by Filip Pizlo.

We don't need expression information to generate useful line, file, and stack information,
so only require that we have line number info available.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

  • runtime/Executable.h:

(JSC):

5:01 PM Changeset in webkit [117192] by Lucas Forschler
  • 1 edit in branches/safari-536-branch/Source/JavaScriptCore/ChangeLog

Merged r116785.

5:00 PM Changeset in webkit [117191] by kbr@google.com
  • 6 edits in trunk/Source/WebCore

Assertion failure running Mozilla's WebGL performance regression tests
​https://bugs.webkit.org/show_bug.cgi?id=85942

Reviewed by Stephen White.

Fixed incorrect assumptions about source formats and buffer sizes
when uploading to floating-point textures. Added code paths
supporting the necessary conversions.

Tests have been added to the WebGL conformance suite which cover
these new code paths; they verify uploads of HTMLCanvasElement,
HTMLImageElement, HTMLVideoElement, and ImageData to
floating-point textures. However, because floating-point texture
support is optional, and generally only supported on bots which
run with real GPUs and not in virtual machines, it isn't feasible
to incorporate these tests as layout tests.

Ran the new WebGL conformance tests in Chromium on Linux; all
pass.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::extractImageData):
Properly compute size of destination buffer.

(WebCore):
Add pack/unpack routines for converting RGBA8/BGRA8 to floating point.

(WebCore::doFloatingPointPacking):
Support RGBA8 and BGRA8 source formats.

(WebCore::isFloatingPointSource):
Factored out logic for assertions.

(WebCore::GraphicsContext3D::packPixels):
Generalized assertions and logic.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.

4:58 PM Changeset in webkit [117190] by jamesr@google.com
  • 13 edits in trunk

[chromium] Chromium port never sets USE(CG) so code behind it is dead
​https://bugs.webkit.org/show_bug.cgi?id=86537

Reviewed by Adrienne Walker.

Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.

Source/WebCore:

  • platform/chromium/DragImageRef.h:

(WebCore):

  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::paintStepper):

  • platform/graphics/chromium/PlatformImage.cpp:

(WebCore::PlatformImage::updateFromImage):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3D::grContext):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • src/PlatformSupport.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::paintRect):

4:57 PM Changeset in webkit [117189] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r117169.

  • platform/efl/test_expectations.txt: Unskip test that now passes.
4:54 PM Changeset in webkit [117188] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r117160.

  • platform/efl/test_expectations.txt: Skip test that depends on blob

support.

4:52 PM Changeset in webkit [117187] by commit-queue@webkit.org
  • 5 edits in trunk

Skia does not respect a specified InterpolationQuality
​https://bugs.webkit.org/show_bug.cgi?id=86249

Patch by Keyar Hood <​keyar@chromium.org> on 2012-05-15
Reviewed by Stephen White.

Source/WebCore:

The added functionality is not exposed to higher layers of webkit.
Tests will be added that will exercise these changes when bug 82804 is
fixed.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
Code to have the useLowQualityScale cause the InterpolationQuality be
be set to low for Chromium but remain as none for other platforms.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::limitResamplingMode): Added
(WebCore):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
We now limit the resampling choice based on what InterpolationQuality
is set as. InterpolationNone restricts resampling to RESAMPLE_NONE,
InterpolationLow and InterpolationMedium restricts resampling to
RESAMPLE_LINEAR. InterpolationHigh and InterpolationDefault do not
change the resampling.

Furthermore, the choice on how to set the filter bitmap flag in
paintSkBitmap was made to be consistent with that in
Image::drawPattern.

LayoutTests:

Now expecting the following to tests to have an IMAGE failure:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg

  • platform/chromium/test_expectations.txt:
4:51 PM Changeset in webkit [117186] by jamesr@google.com
  • 5 edits in trunk

[chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
​https://bugs.webkit.org/show_bug.cgi?id=86536

Reviewed by Adam Barth.

Source/Platform:

The Chromium port always using Skia, so WEBKIT_USING_CG has been dead code for many moons.

  • chromium/public/WebCommon.h:

Tools:

Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::paintPagesWithBoundaries):

4:48 PM Changeset in webkit [117185] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

ImageDocuments erroneously trigger beforeload events for the main resource
​https://bugs.webkit.org/show_bug.cgi?id=86543
<rdar://problem/11309013>

Reviewed by Brady Eidson.

No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

4:41 PM Changeset in webkit [117184] by jamesr@google.com
  • 3 edits in trunk/Tools

[chromium] Unreviewed build fix.

Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
component build, at least on linux. This restores Tools/DumpRenderTree to its pre-r117166 state.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::initialize):

4:38 PM Changeset in webkit [117183] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Block freeing thread should not free blocks when we are actively requesting them
​https://bugs.webkit.org/show_bug.cgi?id=86519

Reviewed by Geoffrey Garen.

The block freeing thread shoots us in the foot if it decides to run while we're actively
requesting blocks and returning them. This situation can arise when there is a lot of copying
collection going on in steady state. We allocate a large swath of pages to copy into, then we
return all the newly free old pages to the BlockAllocator. In this state, if the block freeing
thread wakes up in between collections (which is more likely than it waking up during a
collection) and frees half of these pages, they will be needed almost immediately during the
next collection, causing a storm of VM allocations which we know are going to be very slow.

What we'd like is for when things have quieted down the block freeing thread can then return
memory to the OS. Usually this will be when a page has fully loaded and has a low allocation
rate. In this situation, our opportunistic collections will only be running at least every few
seconds, thus the extra time spent doing VM allocations won't matter nearly as much as, say,
while a page is loading.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator): Initialize our new field.
(JSC::BlockAllocator::blockFreeingThreadMain): We check if we've seen any block requests recently.
If so, reset our flag and go back to sleep. We also don't bother with locking here. If we miss out
on an update, we'll see it when we wake up again.

  • heap/BlockAllocator.h: Add new field to track whether or not we've received recent block requests.

(BlockAllocator):
(JSC::BlockAllocator::allocate): If we receive a request for a block, set our field that tracks
that to true. We don't bother locking since we assume that writing to a bool is atomic.

4:36 PM Changeset in webkit [117182] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] ScrollElasticityController.mm doesn't compile with the 10.6 SDK on mac
​https://bugs.webkit.org/show_bug.cgi?id=86544

Reviewed by Anders Carlsson.

This is a build fix for now until we can figure out what a
better way to approach this is.

  • platform/mac/ScrollElasticityController.mm:

(WebCore):

4:31 PM Changeset in webkit [117181] by Nate Chapin
  • 4 edits in trunk/Source/WebCore

MainResourceLoader::load() always returns true, so make it return
void and delete the related dead code.
​https://bugs.webkit.org/show_bug.cgi?id=86413

Reviewed by Alexey Proskuryakov.

No new tests, cleanup only.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::load):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

4:31 PM Changeset in webkit [117180] by Lucas Forschler
  • 32 edits
    1 delete in branches/safari-536-branch

Rollout 116009.

4:23 PM Changeset in webkit [117179] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Rollout 116013.

4:21 PM Changeset in webkit [117178] by Lucas Forschler
  • 6 edits in branches/safari-536-branch/LayoutTests

Rollout 116070.

4:21 PM Changeset in webkit [117177] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Set the new PlatformWheelEvent member variables to sane defaults
​https://bugs.webkit.org/show_bug.cgi?id=86542

Reviewed by Andreas Kling.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

4:20 PM Changeset in webkit [117176] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/LayoutTests

Rollout 116143.

4:16 PM Changeset in webkit [117175] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Skip the mediastream tests

because the GTK+ implementation is incomplete.

4:12 PM Changeset in webkit [117174] by Lucas Forschler
  • 32 edits
    7 copies in branches/safari-536-branch

roll 116009 back in, removed out of order.

4:05 PM Changeset in webkit [117173] by Lucas Forschler
  • 32 edits
    1 delete in branches/safari-536-branch

Rollout 116009.

3:59 PM Changeset in webkit [117172] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt]3 fast/borders tests assert intermittently
​https://bugs.webkit.org/show_bug.cgi?id=67994

Reviewed by Darin Adler.

These tests are now passing even with --iteration 1000.

  • platform/qt/Skipped:
3:51 PM Changeset in webkit [117171] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Ensure animations get ticked at least once when added.
​https://bugs.webkit.org/show_bug.cgi?id=86013

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-15
Reviewed by James Robinson.

Source/WebCore:

Tested in

CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didAddAnimation):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(CCSingleThreadProxyAnimationTimer):
(WebCore::CCSingleThreadProxyAnimationTimer::create):
(WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer):
(WebCore):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):

3:34 PM Changeset in webkit [117170] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Fix unsafe viewport tag dispatch
​https://bugs.webkit.org/show_bug.cgi?id=80554

Patch by Alexandre Elias <​aelias@google.com> on 2012-05-15
Reviewed by Adam Barth.

In some uncommon situations (such as window.open() new tab on
Android), dispatchViewportPropertiesDidChange may early-return without
setting the page scale because the window size is not yet
available from the embedder. At that point, the previous behavior was
to call it again in layoutUpdated(), but this is unsafe since it
leaves a pending needsLayout.

I moved the dispatch call into WebViewImpl::didChangeContentsSize and
WebViewImpl::resize() instead -- these represent more explicitly the
situations where the inputs to the viewport tag calculation change. I
removed the other dispatch call from setFrameRect as it's now
redundant.

Covered by FixedLayoutInitializeAtMinimumPageScale test introduced
in ​http://webk.it/82949 (an assertion will fire there without
this fix).

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::didChangeContentsSize):

3:33 PM Changeset in webkit [117169] by arv@chromium.org
  • 6 edits in trunk/LayoutTests

Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)
​https://bugs.webkit.org/show_bug.cgi?id=86442

Reviewed by Darin Adler.

This fixes the test to not print the invalid value (which includes file paths) for the JSC fail case.

  • fast/dom/DOMException/stack-trace-expected.txt:
  • fast/dom/DOMException/stack-trace.html:
  • platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
3:14 PM WebKit Team edited by zhajiang@rim.com
Add Jacky Jiang in the committer list. (diff)
3:05 PM Changeset in webkit [117168] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

add unit test for NRWT's --additional-expectations option
​https://bugs.webkit.org/show_bug.cgi?id=86501

Patch by Elliot Poger <​epoger@google.com> on 2012-05-15
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_additional_expectations):

2:48 PM Changeset in webkit [117167] by Lucas Forschler
  • 8 edits in branches/safari-536-branch/Source

Merge fix for radar 11401642.

2:48 PM Changeset in webkit [117166] by jamesr@google.com
  • 8 edits in trunk

[chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
​https://bugs.webkit.org/show_bug.cgi?id=86524

Reviewed by Adam Barth.

Source/Platform:

Moves createOffscreenGraphicsContext3D(), previously on WebKitPlatformSupport, to WebKit::Platform.

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::createOffscreenGraphicsContext3D):

Source/WebKit/chromium:

Moves createOffscreenGraphicsContext3D() out (to WebKit::Platform) and updates GraphicsContext3DChromium to use
the new location. Also removes a few unnecessary includes from GraphicsContext3DChromium.cpp.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

Tools:

Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::initialize):

2:43 PM Changeset in webkit [117165] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

r117147 causes a null-deref crash in DOMImplementation::createDocument()
​https://bugs.webkit.org/show_bug.cgi?id=86532

Reviewed by James Robinson.

No new tests, but fixes many crashing tests.

Protect against the possibility of being passed a NULL frame in
DOMImplementation::createDocument().

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

2:39 PM Changeset in webkit [117164] by Lucas Forschler
  • 6 edits in branches/safari-536-branch/Source

Merge fix for radar 10887709.

2:38 PM Changeset in webkit [117163] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=86527
http/tests/media/video-query-url.html fails on Lion bots

Add it to the skipped list until Eric can explore.

  • platform/mac-lion/Skipped:
2:33 PM Changeset in webkit [117162] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Use posZOrderList() / negZOrderList() everywhere to avoid querying dirtied lists
​https://bugs.webkit.org/show_bug.cgi?id=86416

Reviewed by Simon Fraser.

Covered by existing tests that are not ASSERTing after this change.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::update3DTransformedDescendantStatus):
Added a call to updateZOrderLists() to the previous sites as nothing guarantees
that we have recomputed our z-order lists.

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::needsContentsCompositingLayer):
Converted those functions to use the safe getters.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasNegativeZOrderList):
Newly added funtion to return if we have a negative z-order list.

2:29 PM Changeset in webkit [117161] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash due shadow tree parent confusion in SVG.
​https://bugs.webkit.org/show_bug.cgi?id=84248

Reviewed by Nikolas Zimmermann.

Test: svg/foreignObject/viewport-foreignobject-crash.html

When we try to make a decision on whether we need an outer
SVGRoot container, we detect if we are in shadow tree or not.
We also need to make sure that our parentOrHostElement is also
an svg element.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement):

LayoutTests: Crash due shadow tree parent confusion in SVG.
​https://bugs.webkit.org/show_bug.cgi?id=84248

Reviewed by Nikolas Zimmermann.

  • svg/foreignObject/viewport-foreignobject-crash-expected.html: Added.
  • svg/foreignObject/viewport-foreignobject-crash.html: Added.
2:27 PM Changeset in webkit [117160] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[File API] URL methods handling null arguments
​https://bugs.webkit.org/show_bug.cgi?id=69693

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-05-15
Reviewed by Adam Barth.

Source/WebCore:

Per the latest editor's draft of the File API:
​http://dev.w3.org/2006/webapi/FileAPI/#dfn-createObjectURL

Use null instead of undefined as return value when a
null blob is given to URL.createObjectURL.

Test: fast/files/url-null.html

  • html/DOMURL.idl:

LayoutTests:

URL.createObjectURL must return null instead of undefined
when a null blob is given as argument. Updated old test that
used undefined explicitly. New test by Mark Pilgrim (rebaselined
after fix).

  • fast/files/url-null-expected.txt: Added.
  • fast/files/url-null.html: Added.
  • http/tests/fileapi/create-blob-url-from-data-url.html:
2:21 PM Changeset in webkit [117159] by Lucas Forschler
  • 5 edits in branches/safari-536-branch/Source/WebKit2

Merged r116993.

2:21 PM Changeset in webkit [117158] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix [Qt].

Protect the definition of DOMImplementationSupportsTypeClient class with
VIDEO disabled.

  • dom/DOMImplementation.cpp:
2:19 PM Changeset in webkit [117157] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-536-branch

Merged r116960.

2:16 PM Changeset in webkit [117156] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536-branch

Merged r116925.

2:14 PM Changeset in webkit [117155] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r116831.

2:12 PM Changeset in webkit [117154] by Lucas Forschler
  • 6 edits in branches/safari-536-branch/Source/WebCore

Merged r116830.

2:10 PM Changeset in webkit [117153] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r116824.

2:08 PM Changeset in webkit [117152] by Lucas Forschler
  • 7 edits
    3 copies in branches/safari-536-branch

Merged r116821.

2:06 PM Changeset in webkit [117151] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source/WebKit/mac

Merged r116820.

2:04 PM Changeset in webkit [117150] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116809.

2:02 PM Changeset in webkit [117149] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r116799.

1:55 PM Changeset in webkit [117148] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable the Fullscreen API
​https://bugs.webkit.org/show_bug.cgi?id=86129

Patch by Max Feil <​mfeil@rim.com> on 2012-05-15
Reviewed by Antonio Gomes.

This patch enables the new document-based Fullscreen API.
The ENABLE(FULLSCREEN_API) is already enabled in the
BlackBerry WebKit build. My patch turns fullscreen on
in the page settings by default and implements the missing
ChromeClientBlackBerry::{supports,enter,exit}FullScreenForElement()
member functions. I am also plumbing through the existing
"fullScreenVideoCapable" that QNXStageWebView has always been
sending to allow the presence of a native fullscreen video player
to be checked.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::fullScreenVideoCapable):
(BlackBerry::WebKit::WebSettings::setFullScreenVideoCapable):

  • Api/WebSettings.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

1:54 PM Changeset in webkit [117147] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

Site-specific hack: Disclaim WebM as a supported type on Mac for YouTube.
​https://bugs.webkit.org/show_bug.cgi?id=86409

Reviewed by Darin Adler.

No new tests; site specific hack.

Add a Mac-only site-specific hack which disclaims both video/webm and video/x-flv
as supported types when the media element's document has a host of youtube.com.

Add a new, pure-virtual prototype class for use by MediaPlayer::supportsType:

  • platform/graphics/MediaPlayer.h:

(MediaPlayerSupportsTypeClient):
(WebCore::MediaPlayerSupportsTypeClient::~MediaPlayerSupportsTypeClient):
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerDocumentHost):

Use these new client calls to determine whether to apply the site-specific
hack:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType):

Add this prototype class as a superclass of HTMLMediaElement. Pass in the
HTMLMediaElement's this pointer when calling MediaPlayer::supportsType():

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::HTMLMediaElement::mediaPlayerDocumentHost):

  • html/HTMLMediaElement.h:

As is HTMLMediaElement, a MediaPlayerSupportsTypeClient class is needed. Add a
new class DOMImplementationSupportsTypeClient, an instance of which will be
passed to MediaPlayer::supportsType():

  • dom/DOMImplementation.cpp:

(DOMImplementationSupportsTypeClient):
(WebCore::DOMImplementationSupportsTypeClient::DOMImplementationSupportsTypeClient):
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::DOMImplementation::mediaPlayerDocumentHost):

  • dom/DOMImplementation.h:
1:49 PM Changeset in webkit [117146] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536-branch

Merged r116832.

1:47 PM Changeset in webkit [117145] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source

Merged r116720.

1:46 PM Changeset in webkit [117144] by Lucas Forschler
  • 20 edits in branches/safari-536-branch/Source

Merged r116720.

1:44 PM Changeset in webkit [117143] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r116711.

1:41 PM Changeset in webkit [117142] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r116697.

1:26 PM Changeset in webkit [117141] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes
​https://bugs.webkit.org/show_bug.cgi?id=80209

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-05-15
Reviewed by Kenneth Rohde Christiansen.

This patch adds a method isOpen to WebIconDatabase to
be able to check whether the database has already been opened.
This helps preventing problems when reusing a WebContext
to create another view, as e.g. WebKitTestRunner does it in the
Qt port.

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setDatabasePath):
(WebKit::WebIconDatabase::isOpen): Added.
(WebKit):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):

1:22 PM Changeset in webkit [117140] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r116794.

1:20 PM Changeset in webkit [117139] by Lucas Forschler
  • 25 edits in branches/safari-536-branch

Merged r116716.

1:18 PM Changeset in webkit [117138] by Lucas Forschler
  • 16 edits in branches/safari-536-branch

Merged r116695.

1:15 PM Changeset in webkit [117137] by Lucas Forschler
  • 22 edits in branches/safari-536-branch/Source

Merged r116687.

1:14 PM Changeset in webkit [117136] by epoger@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

modify my own line

1:12 PM Changeset in webkit [117135] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-536-branch

Merged r116685.

1:10 PM Changeset in webkit [117134] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116813.

1:09 PM Changeset in webkit [117133] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116593.

1:07 PM Changeset in webkit [117132] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r116579.

1:05 PM Changeset in webkit [117131] by Lucas Forschler
  • 10 edits in branches/safari-536-branch/Source/WebCore

Merged r116570.

1:03 PM Changeset in webkit [117130] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116565.

1:02 PM Changeset in webkit [117129] by andersca@apple.com
  • 15 edits in trunk/Source

Use unaccelerated scrolling deltas when rubber-banding
​https://bugs.webkit.org/show_bug.cgi?id=86503
<rdar://problem/11378742>

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):
(WebCore::PlatformWheelEvent::scrollCount):
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaX):
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaY):
Add scroll count and unaccelerated scrolling deltas.

  • platform/mac/ScrollElasticityController.mm:

(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
Call the new WKSI functions.

(WebCore::ScrollElasticityController::handleWheelEvent):
Use the unaccelerated scrolling deltas when needed.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add new WKSI functions.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Init new WKSI functions.

Source/WebKit2:

  • Shared/WebEvent.h:

(WebWheelEvent):
(WebKit::WebWheelEvent::scrollCount):
(WebKit::WebWheelEvent::unacceleratedScrollingDelta):
Add scroll count and unaccelerated scrolling delta.

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
Initialize scroll count and unaccelerated scrolling deltas.

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
Initialize scroll count and unaccelerated scrolling deltas.

(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Encode and decode scroll count and unaccelerated scrolling deltas.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):
Initialize the scroll count and unaccelerated scrolling deltas from the underlying NSEvent.

  • UIProcess/WebPageProxy.cpp:

(WebKit::coalesce):
Coalesce unaccelerated scrolling deltas as well.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Init new WKSI functions.

12:58 PM Changeset in webkit [117128] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Compute the best target node on a GestureTap event
​https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-15
Reviewed by Adam Barth.

Source/WebCore:

Using the tests in the touchadjustment/ directory.

  • WebCore.gypi:

Include TouchAdjustment.* files.

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::zoomableIntersectionQuotient):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
No longer using the INFINITY constant due to problems with compiling
on chromium win.

Source/WebKit/chromium:

  • features.gypi:

Enable the touch adjustment code by default.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

  • platform/chromium/test_expectations.txt:

The flaky tests in touchadjustment/ have been addressed in WK86218.

12:58 PM Changeset in webkit [117127] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116484.

12:56 PM Changeset in webkit [117126] by crogers@google.com
  • 9 edits
    2 adds in trunk/Source/WebCore

Add AudioSummingJunction class to handle fan-in (abstracted from AudioNodeInput)
​https://bugs.webkit.org/show_bug.cgi?id=86396

Reviewed by Kenneth Russell.

No new tests. Existing layout tests already extensively test summing.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Add AudioSummingJunction files to makefiles.

  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::handlePreRenderTasks):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::markSummingJunctionDirty):
(WebCore::AudioContext::removeMarkedSummingJunction):
(WebCore::AudioContext::handleDirtyAudioSummingJunctions):
Simple munge from AudioNodeInput -> AudioSummingJunction

  • Modules/webaudio/AudioNodeInput.cpp:
  • Modules/webaudio/AudioNodeInput.h:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::didUpdate):
Remove logic from AudioNodeInput which now is being moved to AudioSummingJunction.

  • Modules/webaudio/AudioSummingJunction.cpp: Added.
  • Modules/webaudio/AudioSummingJunction.h: Added.

(WebCore::AudioSummingJunction::AudioSummingJunction):
(WebCore::AudioSummingJunction::~AudioSummingJunction):
(WebCore::AudioSummingJunction::changedOutputs):
(WebCore::AudioSummingJunction::updateRenderingState):
(WebCore::AudioSummingJunction::context):
(WebCore::AudioSummingJunction::numberOfRenderingConnections):
(WebCore::AudioSummingJunction::renderingOutput):
(WebCore::AudioSummingJunction::isConnected):
(WebCore::AudioSummingJunction::numberOfConnections):
Add AudioSummingJunction which is an abstraction to manage/track the connections from AudioNodeOutputs
representing the fan-in points for unity gain summing junctions.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

Add AudioSummingJunction files to makefiles.

12:55 PM Changeset in webkit [117125] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebKit2

Unreviewed, rolling out r117095.
​http://trac.webkit.org/changeset/117095
​https://bugs.webkit.org/show_bug.cgi?id=86511

broke Qt Mac build (Requested by estes on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-15

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
12:52 PM Changeset in webkit [117124] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash when dropping a reference to a non-existing file
​https://bugs.webkit.org/show_bug.cgi?id=86505
<rdar://problem/11402084>

Reviewed by Darin Adler.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): Check that extension handle actually has a non-null extension. Extensions for non-existent files can not exist, so they are passed as null ones.
12:51 PM Changeset in webkit [117123] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fixing the flaky 'script-src-redirect.html' test.
​https://bugs.webkit.org/show_bug.cgi?id=86433

Patch by Mike West <​mkwst@chromium.org> on 2012-05-15
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/resources/source-list-parsing-base.js:

(test):

  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
12:50 PM Changeset in webkit [117122] by Lucas Forschler
  • 9 edits in branches/safari-536-branch/Source/WebKit2

Merged r116478.

12:48 PM Changeset in webkit [117121] by Lucas Forschler
  • 16 edits
    7 copies in branches/safari-536-branch

Merged r116473.

12:46 PM Changeset in webkit [117120] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merged r116469.

12:45 PM Changeset in webkit [117119] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merged r116466.

12:43 PM Changeset in webkit [117118] by Lucas Forschler
  • 5 edits
    8 copies in branches/safari-536-branch

Merged r116458.

12:41 PM Changeset in webkit [117117] by Lucas Forschler
  • 7 edits in branches/safari-536-branch/Source

Merged r116449.

12:25 PM Changeset in webkit [117116] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Ruby annotation is incorrectly identified as a paragraph boundary
​https://bugs.webkit.org/show_bug.cgi?id=86507

Reviewed by Darin Adler.

Source/WebCore:

Test: editing/selection/paragraph-with-ruby.html

  • editing/htmlediting.cpp:

(WebCore::isBlock): Changed to return false for ruby text.

LayoutTests:

  • editing/selection/paragraph-with-ruby-expected.txt: Added.
  • editing/selection/paragraph-with-ruby.html: Added.
12:23 PM Changeset in webkit [117115] by aestes@apple.com
  • 13 edits in trunk/Source

Add WTF_USE_SECURITY_FRAMEWORK and use it in place of the less specific PLATFORM(MAC)
​https://bugs.webkit.org/show_bug.cgi?id=86508

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):
(CoreIPC):

  • Shared/cf/ArgumentCodersCF.h:

(CoreIPC):

  • Shared/mac/KeychainAttribute.cpp:
  • Shared/mac/KeychainAttribute.h:
  • Shared/mac/SecKeychainItemRequestData.cpp:
  • Shared/mac/SecKeychainItemRequestData.h:
  • Shared/mac/SecKeychainItemResponseData.cpp:
  • Shared/mac/SecKeychainItemResponseData.h:
  • UIProcess/WebProcessProxy.h:

(WebKit):
(WebProcessProxy):

  • WebProcess/mac/WebProcessMac.mm:

Source/WTF:

  • wtf/Platform.h:
12:22 PM Changeset in webkit [117114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Un-used GStreamer linker options
​https://bugs.webkit.org/show_bug.cgi?id=86407

Patch by Philippe Normand <​pnormand@igalia.com> on 2012-05-15
Reviewed by Martin Robinson.

  • GNUmakefile.am: Remove no-longer used webcore_libadd variable.
12:21 PM WebKit Team edited by epoger@google.com
added epoger (diff)
12:20 PM Changeset in webkit [117113] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86506
REGRESSION (tiled drawing): No scrollbar while page is loading
-and corresponding
<rdar://problem/11444589>

Reviewed by Anders Carlsson.

We have always had a mechanism in place to suppress painting overlay
scrollbars while the page is loading. However, that mechaism is
overriden if the page has been scrolled. It should be, anyway. It was
not being overriden when the scrolling was handled as a wheel event by
the scrolling tree. This patch takes advantage of the fact that
ScrollingTree::handleWheelEvent() already calls back to the main
thread for handleWheelEventPhase() and just patches
handleWheelEventPhase to mark m_haveScrolledSincePageLoad as true.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEventPhase):

12:05 PM Changeset in webkit [117112] by jberlin@webkit.org
  • 7 edits
    2 deletes in trunk

WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
going into the PageCache.
​https://bugs.webkit.org/show_bug.cgi?id=85891

Reviewed by Brady Eidson.

Source/WebCore:

Do not claim that it is possible to cache a page when the page cache has a capacity of 0.

Covered by the modified DOMWindowExtensionNoCache WK2 API test.

  • history/PageCache.cpp:

(WebCore::PageCache::canCache):
Check m_capacity.

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
canCache is no longer static on PageCache.

Tools:

Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
better than using pages with unload handlers because we may find a way to make pages with
unload handlers cacheable in the future.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:

(TestWebKitAPI::TEST):
Set the cache model to kWKCacheModelDocumentViewer.

  • TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
12:03 PM Changeset in webkit [117111] by caryclark@google.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add self as committer-but-not-reviewer

11:54 AM Changeset in webkit [117110] by jamesr@google.com
  • 4 edits
    3 moves in trunk/Source

Unreviewed, rolling out r116811.
​http://trac.webkit.org/changeset/116811
​https://bugs.webkit.org/show_bug.cgi?id=86257

Introduced layering violation

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/Extensions3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp.

(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • src/GraphicsContext3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DChromium.cpp.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • src/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.h.

(WebKit):
(WebCore):
(GraphicsContext3DPrivate):

11:53 AM Changeset in webkit [117109] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Font copy constructor unnecessarily recalculates transcoding
​https://bugs.webkit.org/show_bug.cgi?id=86490

Reviewed by Dan Bernstein.

  • platform/graphics/Font.cpp:

(WebCore::Font::Font): Copy m_needsTranscoding instead of recomputing it.

11:51 AM Changeset in webkit [117108] by kling@webkit.org
  • 5 edits in trunk/Source

Deep copy PluginModuleInfo before passing across thread boundary.
<​http://webkit.org/b/86491>
<rdar://problem/11451178>

Reviewed by Anders Carlsson.

Source/WebCore:

  • plugins/PluginData.h:

(MimeClassInfo):
(WebCore::MimeClassInfo::isolatedCopy):
(PluginInfo):
(WebCore::PluginInfo::isolatedCopy):

Source/WebKit2:

Since the vector of PluginModuleInfo objects returned by PluginInfoStore::plugins()
can end up being passed to another thread, we should clone it to make sure it's
safe to do so.

No new tests, speculative use-after-free fix.

  • Shared/Plugins/PluginModuleInfo.h:

(PluginModuleInfo):
(WebKit::PluginModuleInfo::isolatedCopy):

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::plugins):

11:47 AM Changeset in webkit [117107] by commit-queue@webkit.org
  • 15 edits
    2 copies
    1 add in trunk/Source

Unreviewed, rolling out r116712.
​http://trac.webkit.org/changeset/116712
​https://bugs.webkit.org/show_bug.cgi?id=86484

This patch is causing crashes in Chromium Canary builds
(Requested by pilgrim_google on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-15

Source/WebCore:

  • storage/StorageArea.h:

(StorageArea):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebStorageArea.h:

(WebKit):

  • public/WebStorageEventDispatcher.h:

(WebStorageEventDispatcher):
(WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):

  • public/WebStorageNamespace.h:

(WebStorageNamespace):
(WebKit::WebStorageNamespace::close):

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::dispatchStorageEvent):

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::setItem):
(WebCore::StorageAreaProxy::removeItem):
(WebCore::StorageAreaProxy::clear):
(WebCore):
(WebCore::StorageAreaProxy::storageEvent):
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::findPageWithSessionStorageNamespace):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):

  • src/StorageAreaProxy.h:

(WebCore):
(StorageAreaProxy):

  • src/StorageEventDispatcherImpl.cpp: Added.

(WebCore):
(WebCore::StorageEventDispatcherImpl::StorageEventDispatcherImpl):
(WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):

  • src/StorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.

(WebCore):
(StorageEventDispatcherImpl):

  • src/WebStorageEventDispatcherImpl.cpp:

(WebKit):
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent):
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent):
(WebKit::WebStorageEventDispatcher::create):
(WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
(WebKit::WebStorageEventDispatcherImpl::dispatchStorageEvent):

  • src/WebStorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.

(WebKit):
(WebStorageEventDispatcherImpl):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

11:43 AM Changeset in webkit [117106] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Optimize save/restore with no drawing operations between them (shows up on some canvas benchmarks)
​https://bugs.webkit.org/show_bug.cgi?id=86448

Reviewed by Simon Fraser.

Since canvas programmers sometimes end up doing extra save/restore pairs with no actual drawing
in between, optimize that case by not realizing saves until we have to. This is doubly important
because saves are costly.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Initialize m_unrealizedSaveCount.
(WebCore::CanvasRenderingContext2D::isAccelerated): Improve performance by calling the
drawingContext function only once.
(WebCore::CanvasRenderingContext2D::reset): Set m_unrealizedSaveCount to 0.
(WebCore::CanvasRenderingContext2D::realizeSavesLoop): Added. Replaces the save function as the
function that actually pushes context onto the state stack.
(WebCore::CanvasRenderingContext2D::restore): Added code to do an early return if we can do the
restore just by decrementing the unrealized save count.
(WebCore::CanvasRenderingContext2D::setStrokeStyle): Added calls to realizeSaves and replaced
calls to state with calls to modifiableState.
(WebCore::CanvasRenderingContext2D::setFillStyle): Ditto.
(WebCore::CanvasRenderingContext2D::setLineWidth): Ditto. Also added an early out for cases where
the line width is not changing.
(WebCore::CanvasRenderingContext2D::setLineCap): Ditto.
(WebCore::CanvasRenderingContext2D::setLineJoin): Ditto.
(WebCore::CanvasRenderingContext2D::setMiterLimit): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowOffsetX): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowOffsetY): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowBlur): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowColor): Ditto.
(WebCore::CanvasRenderingContext2D::setWebkitLineDash): Ditto.
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset): Ditto.
(WebCore::CanvasRenderingContext2D::setGlobalAlpha): Ditto.
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): Ditto.
(WebCore::CanvasRenderingContext2D::scale): Ditto.
(WebCore::CanvasRenderingContext2D::rotate): Ditto.
(WebCore::CanvasRenderingContext2D::translate): Ditto.
(WebCore::CanvasRenderingContext2D::transform): Ditto.
(WebCore::CanvasRenderingContext2D::setTransform): Ditto.
(WebCore::CanvasRenderingContext2D::setStrokeColor): Ditto.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
(WebCore::CanvasRenderingContext2D::clip): Ditto.
(WebCore::CanvasRenderingContext2D::clearRect): Changed implementation so it does not save
the graphics context in the common case where shadows, global alpha, and global compositing
operators do not interfer with the function's operation. This allowed us to get rid of the
setAllAttributesToDefault function, which was used nowhere else.
(WebCore::CanvasRenderingContext2D::setShadow): Added a new common bottleneck and made all
the setShadow functions call it.
(WebCore::CanvasRenderingContext2D::clearShadow): Changed to call the new setShadow.
(WebCore::CanvasRenderingContext2D::setFont): Renamed tempDecl to the more friendly
parsedStyle. Changed code structure so the CSS parser is deleted right after parsing is
done. Used string concatenation instead of more expensive string append. Added calls to
realizeSaves and modifiableState.
(WebCore::CanvasRenderingContext2D::setTextAlign): Added calls to realizeSaves and replaced
calls to state with calls to modifiableState. Also added an early out for cases where the
alignment is not changing.
(WebCore::CanvasRenderingContext2D::setTextBaseline): Ditto.

  • html/canvas/CanvasRenderingContext2D.h: Made save an inline function that bumps

m_unrealizedSaveCount. Removed setAllAttributesToDefault. Added OVERRIDE for all the
virtual function overrides, and made them all private. Moved m_path down with the other data
members. Renamed the non-const state function to modifiableState. Added a realizeSaves
function and the realizeSavesLoop for the unusual case where there is work to do.
Added m_unrealizedSaveCount.

11:31 AM Changeset in webkit [117105] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r116427.

11:24 AM Changeset in webkit [117104] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source/WebCore

Merged r116419.

11:16 AM Changeset in webkit [117103] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536-branch

Merged r116395.

11:15 AM Changeset in webkit [117102] by tommyw@google.com
  • 3 edits
    2 adds in trunk

MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8
​https://bugs.webkit.org/show_bug.cgi?id=86459

Reviewed by Adam Barth.

Source/WebCore:

LocalMediaStream inherits from MediaStream, but only MediaStream have the
EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue.

Test: fast/mediastream/LocalMediaStream-onended.html

  • Modules/mediastream/LocalMediaStream.idl:

LayoutTests:

  • fast/mediastream/LocalMediaStream-onended-expected.txt: Added.
  • fast/mediastream/LocalMediaStream-onended.html: Added.
11:14 AM Changeset in webkit [117101] by Lucas Forschler
  • 11 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116372.

11:10 AM Changeset in webkit [117100] by Lucas Forschler
  • 6 edits in branches/safari-536-branch/Source/WebCore

Merged r116368.

11:08 AM Changeset in webkit [117099] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r116363.

11:07 AM Changeset in webkit [117098] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Remove unused code for tap target fuzzing
​https://bugs.webkit.org/show_bug.cgi?id=86252

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-15
Reviewed by Adam Barth.

Source/WebCore:

No tests required since this is a cleanup of unused code.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):

  • page/EventHandler.h:

(EventHandler):
The touch adjustment code will be used to determine the best target
for a GestureTap event instead of passing in a pre-targeted node.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
A rectangular touch region is defined by the touch center and the
delta values only, so gammaX and gammaY are not needed.

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
A rectangular touch region is defined by the touch center and the
delta values only, so gammaX and gammaY are not needed.

11:07 AM Changeset in webkit [117097] by Lucas Forschler
  • 7 edits in branches/safari-536-branch

Merged r116361.

11:05 AM Changeset in webkit [117096] by Lucas Forschler
  • 8 edits in branches/safari-536-branch/Source

Merged r116367.

11:04 AM Changeset in webkit [117095] by aestes@apple.com
  • 30 edits in trunk/Source/WebKit2

Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
​https://bugs.webkit.org/show_bug.cgi?id=86496

Reviewed by Dan Bernstein.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::individualPluginPaths):
(WebKit::PluginInfoStore::getPluginInfo):

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
11:00 AM Changeset in webkit [117094] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

[Qt] WebKit with Qt5 hangs on Mac
​https://bugs.webkit.org/show_bug.cgi?id=79785

Reviewed by Tor Arne Vestbø.

Delay the initialization of our QNetworkConfigurationManager used in
NetworkStateNotifierPrivate. On Mac it was causing a race condition because it
spawns a thread that triggers a static initializer in Qt, while in the main
thread NetworkStateNotifier is being static initialized. On Mac the lock for
static initializers is shared between all of them, causing a deadlock.

The issue was also reported in ​http://openradar.appspot.com/11217150.

  • platform/network/qt/NetworkStateNotifierPrivate.h:

(NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::effectivelyOnline):

  • platform/network/qt/NetworkStateNotifierQt.cpp:

(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::setNetworkAccessAllowed):
(WebCore::NetworkStateNotifierPrivate::setOnlineState):
(WebCore::NetworkStateNotifierPrivate::initialize):
(WebCore):
(WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

10:56 AM Changeset in webkit [117093] by Lucas Forschler
  • 13 edits in branches/safari-536-branch

Merged r116356.

10:47 AM Changeset in webkit [117092] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merged r116226.

10:41 AM Changeset in webkit [117091] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Factor HitTestPoint out of HitTestResult.
​https://bugs.webkit.org/show_bug.cgi?id=85965

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-15
Reviewed by Simon Fraser.

In preparation for handling transformations on area-based hit-testing,
we need to factor test-point and test-area out of HitTestResult so that
it can be transformed independently.

To maintain the current API as closely as possible HitTestResult now
inherit from HitTestPoint, representing the original untransformed
hitTestPoint.

No change in functionality. No new tests.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::~HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestPoint::rectForPoint):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):

  • rendering/HitTestResult.h:

(HitTestPoint):
(WebCore::HitTestPoint::point):
(WebCore::HitTestPoint::roundedPoint):
(WebCore::HitTestPoint::setPoint):
(WebCore::HitTestPoint::isRectBasedTest):
(WebCore::HitTestPoint::topPadding):
(WebCore::HitTestPoint::rightPadding):
(WebCore::HitTestPoint::bottomPadding):
(WebCore::HitTestPoint::leftPadding):
(HitTestResult):
(WebCore::HitTestResult::hitTestPoint):
(WebCore::HitTestPoint::rectForPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):

10:34 AM Changeset in webkit [117090] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Skip a webarchive test I added that fails on WK2.

  • platform/wk2/Skipped:
10:26 AM Changeset in webkit [117089] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [117088] by fmalita@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png.

Patch by Florin Malita <​fmalita@chromium.org> on 2012-05-15

  • platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:11 AM Changeset in webkit [117087] by danakj@chromium.org
  • 7 edits in branches/chromium/1132/Source

Merge 116587 - [chromium] Don't draw when canDraw() is false
​https://bugs.webkit.org/show_bug.cgi?id=85829

Reviewed by Adrienne Walker.

Source/WebCore:

This is based on the work of Daniel Sievers in bug
​https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.

drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.

A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.

Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):

TBR=​danakj@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10377150

9:59 AM Changeset in webkit [117086] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebCore

Refactor SVG parts of Node::addEventListener/removeEventListener
​https://bugs.webkit.org/show_bug.cgi?id=86426

Reviewed by Nikolas Zimmermann.

Move SVG parts of Node::addEventListener/removeEventListener into svg/. Now we do not
have to check in Node::addEventListener/removeEventListener if we are dealing with an SVG
element. Make tryAddEventListener/tryRemoveEventListener protected methods on Node to be able to use
it in SVGElement.

No new tests, since no change in behavior, just refactoring.

  • dom/Node.cpp:

(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):

  • svg/SVGElement.cpp:

(WebCore::collectInstancesForSVGElement):
(WebCore):
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):

  • svg/SVGElement.h:

(SVGElement):

9:38 AM Changeset in webkit [117085] by aestes@apple.com
  • 9 edits in trunk/Source/WebKit2

Guard some AppKit-specific code in WebKit2 with USE(APPKIT)
​https://bugs.webkit.org/show_bug.cgi?id=86444

Reviewed by Sam Weinig.

  • Shared/NativeWebKeyboardEvent.h:

(NativeWebKeyboardEvent):
(WebKit::NativeWebKeyboardEvent::nativeEvent):

  • Shared/NativeWebMouseEvent.h:

(NativeWebMouseEvent):
(WebKit::NativeWebMouseEvent::nativeEvent):

  • Shared/NativeWebWheelEvent.h:

(NativeWebWheelEvent):
(WebKit::NativeWebWheelEvent::nativeEvent):

  • Shared/mac/ArgumentCodersMac.h:

(CoreIPC):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):

  • Shared/mac/WebEventFactory.mm:
  • WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

9:34 AM Changeset in webkit [117084] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

RuleSet::addToRuleSet wastes a bit of Vector capacity.
<​http://webkit.org/b/86434>

Reviewed by Antti Koivisto.

Have makeRuleSet call shrinkToFit() on the vectors before returning them.
This avoids wasting space for the rulesets constructed in collectFeatures().

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):

9:22 AM Changeset in webkit [117083] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[CG] CGImageCreateWithImageInRect is too slow, but for now we still need to use it
​https://bugs.webkit.org/show_bug.cgi?id=86340

Reviewed by Geoffrey Garen.

This patch adds a subimage cache to defray the cost of CGImageCreateWithImageInRect.
Later, we will restructure the code so it doesn't use that function, but at the
moment there are CG issues blocking that change.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(SubimageCacheEntry): Added. An entry in the cache.
(SubimageCacheEntryTraits): Added. Traits for the cache.
(SubimageCacheHash): Added. Hash function for the cache.
(SubimageCacheTimer): Added. Timer that clears the cache after a second
of inactivity.
(SubimageCacheWithTimer): Added. Cache and its timer.
(WebCore::subimageCache): Added. Function returning the single global timer.
(WebCore::SubimageCacheTimer::restart): Added. Start the timer.
(WebCore::SubimageCacheTimer::fired): Added. Clear the cache when the timer fires.
(SubimageRequest): Added. A key to look up in the cache.
(SubimageCacheAdder): Added. Translator to add to the cache.
(WebCore::subimage): Added. Puts an entry in the cache.
(WebCore::GraphicsContext::drawNativeImage): Changed to call the subimage function.

9:18 AM Changeset in webkit [117082] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Move http/tests/cookies/third-party-cookie-relaxing.html from Skipped
list to test_expectations.txt. This test is expected to fail on EFL
port and won't be fixed.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
9:16 AM Changeset in webkit [117081] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove duplicated entries because of disabled SUBPIXEL_LAYOUT.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
9:13 AM Changeset in webkit [117080] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: AdvancedSearchController is not stopped then view is hidden.
​https://bugs.webkit.org/show_bug.cgi?id=86466

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-05-15
Reviewed by Vsevolod Vlasov.

AdvancedSearchController overrides "wasHidden" method instead of "willHide".

UI event-flow, not tested.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype.willHide): Renamed function.

9:05 AM Changeset in webkit [117079] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=86485

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-15

  • platform/efl/test_expectations.txt:
8:52 AM Changeset in webkit [117078] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] adding a functionality for web inspector to inspect current selected element
​https://bugs.webkit.org/show_bug.cgi?id=86394

Patch by Hanna Ma <​Hanma@rim.com> on 2012-05-15
Reviewed by Rob Buis.

Add a way to trigger the remote web inspector on selected element.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::inspectCurrentContextElement):
(WebKit):

  • Api/WebPage.h:
8:48 AM Changeset in webkit [117077] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Wk2] Unskip passing svg/dynamic-updates tests after r95878.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
8:45 AM Changeset in webkit [117076] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
​https://bugs.webkit.org/show_bug.cgi?id=36954

Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)

  • platform/qt/Skipped: Try to unskip really. :)
8:43 AM Changeset in webkit [117075] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/repaint/scroll-in-clipped-layer.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=80387

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2012-05-15
Reviewed by Csaba Osztrogonác.

Unskip tests for bug 80387. They do not crash now.

  • platform/qt-5.0-wk2/Skipped:
8:40 AM Changeset in webkit [117074] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip test which require USE(ZLIB). It has been enabled for EFL port
since r110896).

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15

  • platform/efl/Skipped:
8:38 AM Changeset in webkit [117073] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
​https://bugs.webkit.org/show_bug.cgi?id=86473

Unreviewed gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-15

  • platform/efl/Skipped:
8:36 AM Changeset in webkit [117072] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
​https://bugs.webkit.org/show_bug.cgi?id=36954

Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)

  • platform/qt/css1/box_properties/acid_test-expected.png: Added.
  • platform/qt/css1/box_properties/acid_test-expected.txt:
8:34 AM Changeset in webkit [117071] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html times out
​https://bugs.webkit.org/show_bug.cgi?id=84016

Reviewed by Simon Hausmann.

Source/WebCore:

Calling didFail abort the connection and doesn't activate the HEADERS_RECEIVED state.
Since the goal of HEAD is to test then the request should be marked as finished
also in cases of HTTP errors.
This matches other ports behavior.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::shouldIgnoreHttpError):

LayoutTests:

  • platform/qt/Skipped:
8:32 AM EFLWebKitBuildBots edited by rakuco@webkit.org
Add myself to the People table (diff)
8:15 AM Changeset in webkit [117070] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] fast/loader/create-frame-in-DOMContentLoaded.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=83578

Source/WebKit2:

Retrieve and save page ID only for a valid page in WebFrameNetworkingContext.
The page will be null if the frame was detached from the page.

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):

LayoutTests:

Unskip passing test.

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

  • platform/qt-5.0-wk2/Skipped:
8:07 AM Changeset in webkit [117069] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Qt][WK2] Fix scrolling in touch mode
​https://bugs.webkit.org/show_bug.cgi?id=75006

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

On changes to fixedVisibleContentRect update scroll-animators position, and
recalculate page-step sizes in scrollbars.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollTo):

Forward scrolling-request to the host window.

(WebCore::ScrollView::updateScrollbars):

Allow ScrollViews to have invisible scrollbars when scrolling is delegated.

  • platform/ScrollView.h:

(ScrollView):

Source/WebKit2:

Only handle mouse-wheel events in WebCore to avoid double scrolling, and
scale pixels scrolled by wheel events according to viewport transformation.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:
  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleWheelEvent):

7:57 AM Changeset in webkit [117068] by kareng@chromium.org
  • 13 edits
    3 copies in branches/chromium/1137/Source

Revert 116712 - Source/WebCore: [chromium] DomStorage events handling needs TLC (2)
​https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the StorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.

Reviewed by Adam Barth.

No new tests. Existing tests cover this.

  • storage/StorageArea.h: Alter the interface so the mutators no longer return previous values
  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): removed an unneeded PLATFORM(CHROMIUM) guard
(WebCore::StorageAreaImpl::setItem): no longer return the old value
(WebCore::StorageAreaImpl::removeItem): no longer return the old value
(WebCore::StorageAreaImpl::clear): no longer return whether something was cleared

  • storage/StorageAreaImpl.h: match StorageArea's virtual interface

Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (2)
​https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the WebStorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.

Also clean up from the last patch, remove support for the DEPRECATED event
dispatching API.

Reviewed by Adam Barth.

  • WebKit.gyp: delete three files indicated below
  • public/WebStorageArea.h:

(WebKit::WebStorageArea::setItem): no longer returns the old value
(WebKit::WebStorageArea::removeItem): no longer returns the old value
(WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared

  • public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
  • public/WebStorageNamespace.h: removed the DEPRECATED close() method
  • public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
  • src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method

(WebCore::StorageAreaProxy::setItem): no return value
(WebCore::StorageAreaProxy::removeItem): no return value
(WebCore::StorageAreaProxy::clear): no return value
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
(WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed

  • src/StorageAreaProxy.h:

(WebCore):
(StorageAreaProxy):

  • src/StorageEventDispatcherImpl.cpp: Deleted the file.
  • src/StorageEventDispatcherImpl.h: Deleted the file.
  • src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.

(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup

  • src/WebStorageEventDispatcherImpl.h: Deleted the file.
  • src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,

(WebKit::WebViewImpl::defaultPageGroup):

  • src/WebViewImpl.h:

TBR=Michael Nordman
Review URL: ​https://chromiumcodereview.appspot.com/10377148

7:51 AM Changeset in webkit [117067] by kareng@chromium.org
  • 1 add in branches/chromium/1137/codereview.settings

adding for easy drover

7:49 AM Changeset in webkit [117066] by kareng@chromium.org
  • 1 copy in branches/chromium/1137

branching for 1137 canary to fix top crasher

7:37 AM Changeset in webkit [117065] by vsevik@chromium.org
  • 9 edits
    6 adds
    3 deletes in trunk

Web Inspector: Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapping delegate calls to ScriptSnippetModel and provide public interface on ScriptSnippetModel in terms of uiSourceCodes
​https://bugs.webkit.org/show_bug.cgi?id=86477

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted SnippetStorage to be reused for other snippet types.
Made SnippetScriptMapping delegate all calls to ScriptSnippetModel and injected it in DebuggerPresentationModel.
ScriptSnippetModel now provides public interface for ScriptsPanel in terms of uiSourceCodes.

Tests: inspector/debugger/script-snippet-model.html

inspector/snippet-storage.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):

  • inspector/front-end/ScriptSnippetModel.js: Added.

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype.get scriptMapping):
(WebInspector.ScriptSnippetModel.prototype.createScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._rawLocationToUILocation):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation.get if):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._sourceURLForSnippet):
(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._snippetForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping):
(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.SnippetScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetScriptMapping.prototype.snippetIdForSourceURL):
(WebInspector.SnippetScriptMapping.prototype.addScript):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesAdded):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesRemoved):
(WebInspector.SnippetScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):

  • inspector/front-end/SnippetStorage.js: Added.

(WebInspector.SnippetStorage):
(WebInspector.SnippetStorage.prototype.get namePrefix):
(WebInspector.SnippetStorage.prototype._saveSettings):
(WebInspector.SnippetStorage.prototype.set snippets):
(WebInspector.SnippetStorage.prototype.snippetForId):
(WebInspector.SnippetStorage.prototype.deleteSnippet):
(WebInspector.SnippetStorage.prototype._snippetAdded):
(WebInspector.SnippetStorage.prototype.reset.set this):
(WebInspector.Snippet):
(WebInspector.Snippet.fromObject):
(WebInspector.Snippet.prototype.get id):
(WebInspector.Snippet.prototype.get name):
(WebInspector.Snippet.prototype.set name):
(WebInspector.Snippet.prototype.get content):
(WebInspector.Snippet.prototype.set content):
(WebInspector.Snippet.prototype.serializeToObject):

  • inspector/front-end/SnippetsModel.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/script-snippet-model-expected.txt: Added.
  • inspector/debugger/script-snippet-model.html: Added.
  • inspector/debugger/snippets-model-expected.txt: Removed.
  • inspector/debugger/snippets-model.html: Removed.
  • inspector/snippet-storage-expected.txt: Added.
  • inspector/snippet-storage.html: Added.
7:15 AM Changeset in webkit [117064] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add show/hide debugger sidebar button.
​https://bugs.webkit.org/show_bug.cgi?id=86478

Reviewed by Vsevolod Vlasov.

As with the navigator, but with no overlay. See the screenshot.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):
(WebInspector.ScriptsPanel.prototype._installDebuggerSidebarController.clickHandler):
(WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(button.status-bar-item.scripts-debugger-show-hide-button):
(.status-bar-item.scripts-debugger-show-hide-button > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden > .glyph):

7:11 AM Changeset in webkit [117063] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=83133

Unreviewed gardening, unskip the now passing test.

  • platform/qt/Skipped:
6:57 AM Changeset in webkit [117062] by commit-queue@webkit.org
  • 2 edits
    1 add
    12 deletes in trunk/LayoutTests

Making layout testcase: fast/table/empty-section-crash.html result platform independent
​https://bugs.webkit.org/show_bug.cgi?id=86352

After modifying the current handling of collapsed borders for
table (​https://bugs.webkit.org/show_bug.cgi?id=67877), the expected output for this testcase
changes. Hence, instead of generating new png images and dumprendertext platform specific
output files, have made the output platform independant by making it dumpAsText() only.
Shall be adding a reftest for this along with ​https://bugs.webkit.org/show_bug.cgi?id=67877.

Patch by Arpita Bahuguna <​arpitabahuguna@gmail.com> on 2012-05-15
Reviewed by Antti Koivisto.

  • fast/table/empty-section-crash-expected.txt: Added.

Added new expected file.

  • fast/table/empty-section-crash.html:

Modified testcase to make it dumpAsText().

  • platform/chromium-linux/fast/table/empty-section-crash-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-section-crash-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-section-crash-expected.txt: Removed.
  • platform/efl/fast/table/empty-section-crash-expected.png: Removed.
  • platform/efl/fast/table/empty-section-crash-expected.txt: Removed.
  • platform/gtk/fast/table/empty-section-crash-expected.png: Removed.
  • platform/gtk/fast/table/empty-section-crash-expected.txt: Removed.
  • platform/mac/fast/table/empty-section-crash-expected.png: Removed.
  • platform/mac/fast/table/empty-section-crash-expected.txt: Removed.
  • platform/qt/fast/table/empty-section-crash-expected.png: Removed.
  • platform/qt/fast/table/empty-section-crash-expected.txt: Removed.

Removed the platform specific expected output files for empty-section-crash.html

6:55 AM Changeset in webkit [117061] by kenneth@webkit.org
  • 13 edits
    2 moves
    1 add in trunk

[Qt] Add infra for testing double-tap to zoom functionality etc
​https://bugs.webkit.org/show_bug.cgi?id=86474

Reviewed by Simon Hausmann.

Source/WebKit/qt:

The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

Rename the WebViewportInfo class to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

Modify the API to work better for testing and make sure the
signals are emitted the right places. Also add a method for
simulating a double tap.

Work around issue with animations not running when the item
doesn't have focus.

Create an example test for double-tap to zoom, showing how we can
now create UI tests using QML.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::setContentsSize):
(QQuickWebPage::setContentsScale):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::test):
(QQuickWebView::mouseDoubleClickEvent):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebkittest.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp.

(QWebKitTest::QWebKitTest):
(QWebKitTest::~QWebKitTest):
(QWebKitTest::touchDoubleTap):
(QWebKitTest::contentsSize):
(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

  • UIProcess/API/qt/qwebkittest_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Added.
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

Tools:

The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ViewportInfoItem.qml:
6:41 AM Changeset in webkit [117060] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Tests added in r117012 (plugins/npruntime/delete-plugin-within-*) failing on Mac bots
​https://bugs.webkit.org/show_bug.cgi?id=86480

Not reviewed.

Skipping.

  • platform/mac/Skipped:
6:23 AM Changeset in webkit [117059] by Nikolas Zimmermann
  • 2 edits
    1 add in trunk/LayoutTests

2012-05-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png on Lion.

  • platform/mac/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/mac/test_expectations.txt:
6:18 AM Changeset in webkit [117058] by zherczeg@webkit.org
  • 4 edits in trunk/Source

NEONizing forceValidPreMultipliedPixels
​https://bugs.webkit.org/show_bug.cgi?id=86468

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Optimize forceValidPreMultipliedPixels with ARM-NEON intrinsics.

Existing tests cover this feature.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::forceValidPreMultipliedPixels):

Source/WTF:

Allow to disable all intrinsics with a single macro.

  • wtf/Platform.h:
6:08 AM Changeset in webkit [117057] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove unnecessary setTimeout in HeapSnapshotGridNodes.js
​https://bugs.webkit.org/show_bug.cgi?id=86464

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved): Posting
a message to worker is already asynchronous, no need to postpone the call via setTimeout.
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):

5:56 AM Changeset in webkit [117056] by fmalita@chromium.org
  • 5 edits
    3 adds in trunk

Mask deformations when masked content is rotated
​https://bugs.webkit.org/show_bug.cgi?id=76527

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/mask-clip-target-transform.svg

RenderSVGResource::markForLayoutAndParentResourceInvalidation() needs to also
invalidate parent mask and clip resources, not just filters.

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

LayoutTests:

  • platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • svg/repaint/mask-clip-target-transform-expected.txt: Added.
  • svg/repaint/mask-clip-target-transform.svg: Added.
5:50 AM Changeset in webkit [117055] by pfeldman@chromium.org
  • 9 edits
    1 delete in trunk/Source/WebCore

Web Inspector: merge show navigator with pin navigator buttons.
​https://bugs.webkit.org/show_bug.cgi?id=86469

Reviewed by Vsevolod Vlasov.

See screenshots attached to the bug.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Images/navigatorPinButton.png: Removed.
  • inspector/front-end/Images/navigatorShowHideButton.png:
  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):

  • inspector/front-end/navigatorView.css:

(.navigator-tabbed-pane .tabbed-pane-header-contents):

  • inspector/front-end/scriptsPanel.css:

(.status-bar-item.scripts-navigator-show-hide-button > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay > .glyph):
(button.status-bar-item.scripts-navigator-show-hide-button):
(button.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay):

5:47 AM Changeset in webkit [117054] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r117052.
​http://trac.webkit.org/changeset/117052
​https://bugs.webkit.org/show_bug.cgi?id=86470

Unskipping compositing tests made 500+ other tests fail
(sideeffect bug) (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-15

  • platform/qt-4.8/Skipped:
4:58 AM Changeset in webkit [117053] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Introduce ENABLE_CSS_VARIABLES compile flag.
​https://bugs.webkit.org/show_bug.cgi?id=86338

Reviewed by Hajime Morita.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.

(WebKitPortTest.test_skipped_directories_for_symbols):

4:33 AM Changeset in webkit [117052] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Wk1] Unskip now passig tests.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.

  • platform/qt-4.8/Skipped:
4:18 AM Changeset in webkit [117051] by yurys@chromium.org
  • 13 edits
    2 adds in trunk

Web Inspector: implement "Reveal in Dominators view" context menu action
​https://bugs.webkit.org/show_bug.cgi?id=86455

Reviewed by Pavel Feldman.

Source/WebCore:

Implemented "Reveal in Dominators view" context menu action for objects
in the console.

Test: inspector/profiler/heap-snapshot-reveal-in-dominators-view.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetDominators):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.expandNextDominator):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.childForPosition):
(WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didGetNodePosition):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didPopulateChildren):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.dominatorIdsForNode):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):

LayoutTests:

Test that an object can be revealed in the heap snapshot dominators view
by its heap snapshot object id.

  • inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Added.
  • inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Added.
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
4:10 AM Changeset in webkit [117050] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception when switching to heap profiler comparison view
​https://bugs.webkit.org/show_bug.cgi?id=86224

Reviewed by Pavel Feldman.

Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.TimerQueue):
(WebInspector.TimerQueue.prototype.addTask):
(WebInspector.TimerQueue.prototype._onTimeout):
(WebInspector.TimerQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

4:01 AM EFLWebKitBuildBots created by dominik.rottsches@intel.com
buildbot schedule
3:39 AM EFLWebKit edited by dominik.rottsches@intel.com
(diff)
3:16 AM Changeset in webkit [117049] by vestbo@webkit.org
  • 2 edits in trunk/Tools

Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout

​https://bugs.webkit.org/show_bug.cgi?id=85809

webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
output to stdout, but StreamWriter will by default always encode the object that's
passed to write(). This blows up when the object is a raw string, already encoded
as utf8, and does not match the default behavior of sys.stdout.

To solve this in one place, instead of every single call-site that might write
raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
passing them on to StreamWriter.write(). This has the benefit of also making the
stacktrace easy to read in the case where this assumption does not hold.

The source of this particular bug was that Executive.run_and_throw_if_fail() will
tee the output of the subprocess, and in the case of running prepare-ChangeLog this
might produce non-ascii output, which gets written directly to sys.stdout as raw
utf8-encoded strings.

Reviewed by Dirk Pranke.

  • Scripts/webkit-patch:
3:09 AM Changeset in webkit [117048] by zherczeg@webkit.org
  • 10 edits in trunk/Source/WebCore

The ARM NEON optimized filters does not compile on THUMB2
​https://bugs.webkit.org/show_bug.cgi?id=86457

Reviewed by Csaba Osztrogonác.

We should disable the compilation on Thumb2 until we fix the code.

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformArithmeticSoftware):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApply):

  • platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp:
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
  • platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:
  • platform/graphics/filters/arm/FEGaussianBlurNEON.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp:
  • platform/graphics/filters/arm/FELightingNEON.h:
3:04 AM Changeset in webkit [117047] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking plugins/npruntime/delete-plugin-within-getProperty.html
as crashing for GTK.

  • platform/gtk/test_expectations.txt:
2:49 AM Changeset in webkit [117046] by commit-queue@webkit.org
  • 26 edits
    4 copies
    7 moves
    2 adds in trunk

Source/WebKit: [EFL] Split ewk_private.h file to multiple private files.
​https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

  • PlatformEfl.cmake: Removed ewk_logging.h file from EWebKit_HEADERS.

Source/WebKit/efl: [EFL] Split ewk_private.h file to multiple private files.
​https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

Split ewk_private file to multiple private files.
Delete ewk_logging.h and ewk_tiled_private.h files and removed tiled_backing_store logging domain.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/EditorClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • ewk/ewk_auth.cpp:
  • ewk/ewk_auth_soup.cpp:

(detach):

  • ewk/ewk_auth_soup_private.h: Renamed from Source/WebKit/efl/ewk/ewk_auth_soup.h.
  • ewk/ewk_contextmenu_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

(WebCore):

  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame_private.h: Added.

(WebCore):
(EWKPrivate):

  • ewk/ewk_history.cpp:
  • ewk/ewk_history_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

(WebCore):
(EWKPrivate):

  • ewk/ewk_js.cpp:
  • ewk/ewk_js_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

(_Ewk_JS_Object):

  • ewk/ewk_main.cpp:
  • ewk/ewk_network.cpp:
  • ewk/ewk_private.h:

(WebCore):

  • ewk/ewk_security_origin_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

(WebCore):

  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(ewk_tiled_backing_store_add):

  • ewk/ewk_tiled_backing_store_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.h.

(_Ewk_Tile_Stats):
(_Ewk_Tile):

  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_matrix_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.h.
  • ewk/ewk_tiled_model.cpp:

(tile_account):

  • ewk/ewk_tiled_model_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.h.
  • ewk/ewk_util.cpp:
  • ewk/ewk_util_private.h: Renamed from Source/WebKit/efl/ewk/ewk_util.h.
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):

  • ewk/ewk_view_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

(WebCore):
(EWKPrivate):

  • ewk/ewk_view_single.cpp:
  • ewk/ewk_view_tiled.cpp:
  • ewk/ewk_window_features.cpp:
  • ewk/ewk_window_features_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

Tools: [EFL][DRT] Split ewk_private.h file to multiple private files.
​https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <​t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2:39 AM Changeset in webkit [117045] by commit-queue@webkit.org
  • 8 edits in trunk

[Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
​https://bugs.webkit.org/show_bug.cgi?id=83576

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebView::allowAnyHTTPSCertificateForLocalHost): Added.
(QQuickWebView::setAllowAnyHTTPSCertificateForLocalHost): Added.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate): Added bool m_allowAnyHTTPSCertificateForLocalHost.

Tools:

Set the PlatformWebView for the Qt port to accept all SSL certificates.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

Unskipped http/tests/navgiation/https-in-page-cache.html

  • platform/qt-5.0-wk2/Skipped:
2:13 AM Changeset in webkit [117044] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Kill unnecessary RuntimeEnabledFeatures.h inclusion
​https://bugs.webkit.org/show_bug.cgi?id=86451

Reviewed by Kentaro Hara.

No new tests. No behavior change.

  • dom/Element.cpp:
  • dom/ElementShadow.cpp:
  • dom/TreeScope.cpp:
1:59 AM Changeset in webkit [117043] by hans@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

Speech JavaScript API: Introduce error code enum in Chromium plumbing
​https://bugs.webkit.org/show_bug.cgi?id=86353

Reviewed by Adam Barth.

Introduce an enum for receiving error codes from the embedder.
This enum matches the enum in SpeechRecognitionError.

  • public/WebSpeechRecognizerClient.h:
  • src/AssertMatchingEnums.cpp:
  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveError):

  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

1:51 AM Changeset in webkit [117042] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening after r116986, r117012 and r117016.

  • platform/gtk/test_expectations.txt:
1:24 AM Changeset in webkit [117041] by shinyak@chromium.org
  • 16 edits
    2 adds in trunk

document.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
​https://bugs.webkit.org/show_bug.cgi?id=86341

Reviewed by Ryosuke Niwa.

.:

Exports necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

When document.execCommand('Indent') is executed in the direct child of ShadowRoot,
the scope variable of TextIterator becomes ShadowRoot. However, an element is assumed for it,
so a crash happended.

This patch enables TextIterator to have ShadowRoot as a scope variable.

Test: editing/shadow/execcommand-indent-in-shadow.html

  • WebCore.exp.in:
  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::rangeFromLocationAndLength):

  • editing/TextIterator.h:

(TextIterator):

  • editing/htmlediting.cpp:

(WebCore::indexForVisiblePosition):
(WebCore::visiblePositionForIndex):

  • editing/htmlediting.h:

(WebCore):

Source/WebKit/chromium:

  • src/WebRange.cpp:

(WebKit::WebRange::fromDocumentRange):

Source/WebKit2:

Exports necessary symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • editing/shadow/execcommand-indent-in-shadow-expected.txt: Added.
  • editing/shadow/execcommand-indent-in-shadow.html: Added.
1:15 AM Changeset in webkit [117040] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] 6 SVG tests assert after r107207
​https://bugs.webkit.org/show_bug.cgi?id=78332

Reviewed by Csaba Osztrogonác.

Unskip these tests because they don't assert now.

  • platform/qt/Skipped:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
12:59 AM Changeset in webkit [117039] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more crashing/asserting test.

  • platform/qt/Skipped:
12:42 AM Changeset in webkit [117038] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update test expectations.

Unreviewed EFL gardening, add 2 failing tests to
test_expectations.txt and remove 1 test that no longer exists.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15

  • platform/efl/test_expectations.txt:
12:13 AM Changeset in webkit [117037] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2012-05-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Renegerate three pixel test results on Lion, so that the svg/ pixel tests pass with tolerance 0 again.

  • platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
12:11 AM Changeset in webkit [117036] by shinyak@chromium.org
  • 15 edits in trunk/Source

Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
​https://bugs.webkit.org/show_bug.cgi?id=86428

Reviewed by Hajime Morita.

Source/WebCore:

Since Node::shadowTreeRootNode() returns only ShadowRoot or 0 now, its return type should be ShadowRoot.
This patch changes the return type and adds include directive to build.

No new tests, no change in behavior.

  • dom/Node.cpp:

(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowTreeRootNode):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/Range.cpp:

(WebCore::Range::shadowTreeRootNode):

  • dom/Range.h:

(Range):

  • editing/Editor.cpp:
  • editing/TextIterator.cpp:
  • editing/htmlediting.cpp:
  • html/shadow/ContentSelectorQuery.cpp:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::detach):

  • page/EventHandler.cpp:

Source/WebKit/chromium:

Adds include directive to build.

  • src/WebFrameImpl.cpp:
12:04 AM Changeset in webkit [117035] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Content Security Policy console error messages should include the violated directive.
​https://bugs.webkit.org/show_bug.cgi?id=86323

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15
Reviewed by Adam Barth.

Update global expectations for 1 Content Security Policy test after r117006.

  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:

May 14, 2012:

11:36 PM Changeset in webkit [117034] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Make StyleResolver::applyMatchedProperties and ::applyProperties use enum template parameter instead of bool.
​https://bugs.webkit.org/show_bug.cgi?id=86424

Reviewed by Dimitri Glazkov.

This patch changes from using a boolean template parameter for StyleResolver::applyMatchedProperties and
StyleResolver::applyProperties functions. The motivation for this change is that it paves the way for
CSS Variables to make the value tri-state, which is a requirement because variable definitions must occur
before high priority CSS properties such that they can be referenced by the latter. This change affects
only the type signatures of those functions, and not their behavior.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:
11:30 PM Changeset in webkit [117033] by morrita@google.com
  • 9 edits in trunk/Source/WebCore

[Refactoring] Get rid of ContentDistribution::Item
​https://bugs.webkit.org/show_bug.cgi?id=86350

This change replaces the linked list on ContentDistribution with a Vector.
We no longer link item class ContentDistribution::Item.
This simplification also allows ContentDistribution to go.
ContentDistribution is now just a typedef of Vector<RefPtr<Node> >.

Reviewed by Dimitri Glazkov.

No new tests. Covered by existing tests.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):

  • dom/ElementShadow.cpp:
  • dom/ElementShadow.h:

(ElementShadow):

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findInsertionPointFor):

  • html/shadow/ContentDistributor.h:

(WebCore):
(ContentDistributor):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::nextTo):
(WebCore):
(WebCore::InsertionPoint::previousTo):

  • html/shadow/InsertionPoint.h: Added a set of delegate method to m_distribution.

(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::indexOf):
(WebCore::InsertionPoint::size):
(WebCore::InsertionPoint::at):
(WebCore::InsertionPoint::first):
(WebCore::InsertionPoint::last):
(InsertionPoint):

11:12 PM Changeset in webkit [117032] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants
​https://bugs.webkit.org/show_bug.cgi?id=86429
<rdar://problem/11445132>

Reviewed by Simon Fraser.

Change repaintRectIncludingDescendants to not include repaint rects for composited child layers,
and rename the function to make it more clear that that's what it does now.

No new tests, scrolling performance optimization.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):

  • rendering/RenderLayer.h:

(RenderLayer):

10:55 PM Changeset in webkit [117031] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening to paint the Qt bots green.

  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Updated after r117006.
  • platform/qt/Skipped: Skip new failing/crashing tests.
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Updated after r117006.
10:21 PM FeatureFlags edited by tkent@chromium.org
Add CSS_VARIABLES (diff)
10:08 PM Changeset in webkit [117030] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
9:42 PM Changeset in webkit [117029] by gavinp@chromium.org
  • 36 edits
    10 copies
    2 adds
    2 deletes in trunk

Add Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
​https://bugs.webkit.org/show_bug.cgi?id=85005

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebPrerender.h:

(WebKit::WebPrerender::referrer):
(WebCore):
(WebPrerender):

  • chromium/public/WebPrerenderingSupport.h:

(WebKit):
(WebPrerenderingSupport):

  • chromium/public/WebURLRequest.h:
  • chromium/src/WebPrerenderingSupport.cpp: Added.

(WebKit):
(WebKit::WebPrerenderingSupport::initialize):
(WebKit::WebPrerenderingSupport::shutdown):
(WebKit::WebPrerenderingSupport::current):

Source/WebCore:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

No new tests, as this interface requires a full platform to work, and doesn't affect layout. Test
it with your platform when implemented for it.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::prerenderer):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::removedFrom):

  • html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):

  • html/LinkRelAttribute.h:

(LinkRelAttribute):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):

  • loader/LinkLoader.h:

(WebCore):
(LinkLoader):

  • loader/Prerenderer.cpp: Added.

(WebCore):
(WebCore::Prerenderer::create):
(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::~Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::stop):
(WebCore::Prerenderer::suspend):
(WebCore::Prerenderer::resume):
(WebCore::Prerenderer::document):
(WebCore::Prerenderer::client):

  • loader/Prerenderer.h: Copied from Source/Platform/chromium/public/WebPrerender.h.

(WebCore):
(Prerenderer):

  • loader/PrerendererClient.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.

(WebCore):
(WebCore::PrerendererClient::supplementName):
(WebCore::PrerendererClient::from):
(WebCore::providePrerendererClientTo):

  • loader/PrerendererClient.h: Copied from Source/WebCore/html/LinkRelAttribute.h.

(WebCore):
(PrerendererClient):
(WebCore::PrerendererClient::~PrerendererClient):
(WebCore::PrerendererClient::PrerendererClient):

  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::ignoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • platform/PrerenderHandle.h: Copied from Source/Platform/chromium/public/WebPrerender.h.

(WebCore):
(PrerenderHandle):

  • platform/chromium/Prerender.cpp: Added.

(WebCore):
(WebCore::Prerender::Prerender):
(WebCore::Prerender::~Prerender):
(WebCore::Prerender::setState):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::suspend):
(WebCore::Prerender::resume):

  • platform/chromium/Prerender.h: Copied from Source/Platform/chromium/public/WebPrerender.h.

(WebCore):
(Prerender):
(ExtraData):
(WebCore::Prerender::ExtraData::~ExtraData):
(WebCore::Prerender::url):
(WebCore::Prerender::referrer):
(WebCore::Prerender::referrerPolicy):
(WebCore::Prerender::setExtraData):
(WebCore::Prerender::extraData):

  • platform/chromium/PrerenderHandle.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.

(WebCore):
(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::prerender):
(WebCore::PrerenderHandle::add):
(WebCore::PrerenderHandle::cancel):
(WebCore::PrerenderHandle::abandon):
(WebCore::PrerenderHandle::suspend):
(WebCore::PrerenderHandle::resume):
(WebCore::PrerenderHandle::url):
(WebCore::PrerenderHandle::referrer):
(WebCore::PrerenderHandle::referrerPolicy):

  • platform/chromium/support/WebPrerender.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.

(WebKit::WebPrerender::WebPrerender):
(WebKit):
(WebKit::WebPrerender::~WebPrerender):
(WebKit::WebPrerender::url):
(WebKit::WebPrerender::referrer):
(WebKit::WebPrerender::referrerPolicy):
(WebKit::WebPrerender::setExtraData):
(WebKit::WebPrerender::extraData):

  • platform/network/blackberry/ResourceRequest.h:
  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::platformTargetTypeForRequest):

  • platform/network/chromium/ResourceRequest.h:

Source/WebKit/chromium:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

  • WebKit.gyp:
  • public/WebView.h:
  • src/PrerendererClientImpl.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.

(WebKit):
(WebKit::PrerendererClientImpl::PrerendererClientImpl):
(WebKit::PrerendererClientImpl::willAddPrerender):

  • src/PrerendererClientImpl.h: Copied from Source/WebCore/html/LinkRelAttribute.h.

(WebCore):
(WebKit):
(PrerendererClientImpl):

  • src/WebKit.cpp:

(WebKit::shutdown):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPrerendererClient):
(WebKit):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

These tests are being removed, and expectations updated, because the old phantom-load
prerendering interface was susceptible to layout testing, and the new interface requires
a full platform to test, so it can't really be a layout test.

  • fast/dom/HTMLLinkElement/prerender-expected.txt: Removed.
  • fast/dom/HTMLLinkElement/prerender.html: Removed.
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
9:39 PM Changeset in webkit [117028] by macpherson@chromium.org
  • 16 edits in trunk

Introduce ENABLE_CSS_VARIABLES compile flag.
​https://bugs.webkit.org/show_bug.cgi?id=86338

Reviewed by Dimitri Glazkov.

Add a configuration option for CSS Variables support, disabling it by default.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. This patch only introduces an unused build flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._missing_symbol_to_skipped_tests):

  • qmake/mkspecs/features/features.pri:
9:36 PM Changeset in webkit [117027] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

Add WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other Darwin platforms
​https://bugs.webkit.org/show_bug.cgi?id=86432

Reviewed by Maciej Stachowiak.

  • wtf/Platform.h:
9:36 PM Changeset in webkit [117026] by eric@webkit.org
  • 5 edits in trunk

Styles are not recalculated when the seamless attribute is dynamically added/removed
​https://bugs.webkit.org/show_bug.cgi?id=86315

Reviewed by Andreas Kling.

Source/WebCore:

Covered by fast/frames/seamless/seamless-css-cascade.html.

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::isPresentationAttribute):

  • Make seamless a presentational attribute, which means style on the <iframe> will be forced to recalculate when it changes. This is correct, but not observable until the layout changes are landed (as then the iframe should correctly revert to not being sized to fit its content if seamless is removed).

(WebCore::HTMLIFrameElement::parseAttribute):

  • When the seamless attribute is added or remove, force the content document to recalc its style resolver, which will refresh the list of inherited stylesheets from the parent. This doesn't need to happen synchronously. When the layout changes land the content document will actually cause that recalc to redirect to the parent document in the seamless case anyway, but it's more correct to ask the content document directly.

LayoutTests:

Add a subtest to cover this case.

  • fast/frames/seamless/seamless-css-cascade-expected.txt:
  • fast/frames/seamless/seamless-css-cascade.html:
8:43 PM Changeset in webkit [117025] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Cannot login to iCloud
​https://bugs.webkit.org/show_bug.cgi?id=86321

Reviewed by Filip Pizlo.

This is a bug introduced by bug#85853, we shouldn't allow assignment to
the prototype property of functions to be cached, since we need to clear
the cached inheritorID.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):

8:42 PM Changeset in webkit [117024] by tkent@chromium.org
  • 4 edits
    1 move
    3 deletes in trunk/LayoutTests

[Chromium] Update text expectations.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Removed.
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
8:26 PM Changeset in webkit [117023] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] remove skia/third_party/glu from DEPS
​https://bugs.webkit.org/show_bug.cgi?id=86431

Chromium rev 136872 removed skia/third_party/glu, but nobody updated it in WebKit. This
patch fixes that.

Unreviewed, remove bad Chromium repo.

  • DEPS:
6:10 PM Changeset in webkit [117022] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
​https://bugs.webkit.org/show_bug.cgi?id=86415

Patch by Alexandre Elias <​aelias@google.com> on 2012-05-14
Reviewed by Adam Barth.

The new enum values added in this file have been added in recent
versions of the NDK, so this file will fail to compile with duplicate
enum error when we roll NDK to r7c or higher. A workaround is
to move our enum values to the WebCore namespace. When the NDK
upgrade is complete, we can delete them.

No new tests. (No-op change.)

  • platform/chromium/KeyCodeConversionAndroid.cpp:

(WebCore):

6:06 PM Changeset in webkit [117021] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86420
ScrollbarPainter should support expansionTransitionProgress

Reviewed by Sam Weinig.

expansionTransitionProgress works the same as
uiStateTransitionProgress. This code just echoes that code, but for
expansion instead of uiState.

  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollAnimatorMac.mm:

(supportsExpansionTransitionProgress):
(-[WebScrollbarPartAnimation setCurrentProgress:]):
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate invalidate]):

5:22 PM Changeset in webkit [117020] by dpranke@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.

LayoutTests: fast/loader/javascript-url-in-embed.html is failing after r115646
​https://bugs.webkit.org/show_bug.cgi?id=86414

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
5:11 PM Changeset in webkit [117019] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix RunLoopCF.cpp's copyright string.

  • platform/cf/RunLoopCF.cpp:
5:05 PM Changeset in webkit [117018] by aestes@apple.com
  • 3 edits
    1 copy in trunk/Source/WebCore

Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
​https://bugs.webkit.org/show_bug.cgi?id=86411

Reviewed by Anders Carlsson.

Most of RunLoopMac.mm was written in terms of CF API. Move these bits
to a new file called RunLoopCF.cpp, leaving only the bits dealing with
NSApplication.

  • WebCore.xcodeproj/project.pbxproj: Xcode decided to give

VisitedLinks.* new UUIDs. I'll allow it.

  • platform/cf/RunLoopCF.cpp: Copied from Source/WebCore/platform/mac/RunLoopMac.mm.
  • platform/mac/RunLoopMac.mm:
4:55 PM Changeset in webkit [117017] by fpizlo@apple.com
  • 16 edits
    2 adds in branches/dfgopt/Source/JavaScriptCore

DFG should optimize inlined uses of arguments.length and arguments[i]
​https://bugs.webkit.org/show_bug.cgi?id=86327

Reviewed by Gavin Barraclough.

Turns inlined uses of arguments.length into a constant.

Turns inlined uses of arguments[constant] into a direct reference to the
argument.

Big win on micro-benchmarks. Not yet a win on V8 because the hot uses of
arguments.length and arguments[i] are aliased. I'll leave the aliasing
optimizations to a later patch.

(FrequentExitSite):
(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::QueryableExitProfile::hasExitSite):
(QueryableExitProfile):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp: Added.

(DFG):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::performArgumentsSimplification):

  • dfg/DFGArgumentsSimplificationPhase.h: Added.

(DFG):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::executableFor):
(DFG):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::executableFor):
(Graph):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(Node):
(JSC::DFG::Node::unlinkedLocal):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:54 PM Changeset in webkit [117016] by arv@chromium.org
  • 3 edits
    3 adds in trunk

[V8] Add "stack" property to DOMException
​https://bugs.webkit.org/show_bug.cgi?id=85057

Reviewed by Kentaro Hara.

When we create a DOM exception we define a V8 accessor for the stack property. This
accessor uses a new Error object to get the underlying stack string.

Source/WebCore:

Test: fast/dom/DOMException/stack-trace.html

  • bindings/v8/V8Proxy.cpp:

(WebCore::DOMExceptionStackGetter):
(WebCore):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8Proxy::setDOMException):

LayoutTests:

  • fast/dom/DOMException/stack-trace-expected.txt: Added.
  • fast/dom/DOMException/stack-trace.html: Added.
  • platform/chromium/fast/dom/DOMException/stack-trace-expected.txt: Added.
4:47 PM Changeset in webkit [117015] by msaboff@apple.com
  • 21 edits in trunk/Source

Enh: Add the Ability to Disable / Enable JavaScript GC Timer
​https://bugs.webkit.org/show_bug.cgi?id=86382

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add flag to GCActivityCallback to enable / disable activity timer.
Add api via Heap to set the flag's value.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Windows export
  • heap/Heap.cpp:

(JSC::Heap::setGarbageCollectionTimerEnabled):

  • heap/Heap.h:
  • runtime/GCActivityCallback.h:

(JSC::GCActivityCallback::isEnabled):
(JSC::GCActivityCallback::setEnabled):
(JSC::GCActivityCallback::GCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):

Source/WebCore:

Plumbing to set / clear JS GC activity timer enable flag.

  • WebCore.exp.in:
  • bindings/js/GCController.cpp:

(WebCore::GCController::setJavaScriptGarbageCollectorTimerEnabled):

  • bindings/js/GCController.h:

Source/WebKit/mac:

Plumbing to set / clear JS GC activity timer enable flag.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):

Source/WebKit2:

Plumbing to set / clear JS GC activity timer enable flag.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetJavaScriptGarbageCollectorTimerEnabled):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setJavaScriptGarbageCollectorTimerEnabled):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setJavaScriptGarbageCollectorTimerEnabled):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
4:47 PM Changeset in webkit [117014] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fast/replaced/width100percent-searchfield is still failing on chromium leopard/snowleopard
​https://bugs.webkit.org/show_bug.cgi?id=86412

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
4:45 PM Changeset in webkit [117013] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Increase Debug Logging in MarkStack::validate()
​https://bugs.webkit.org/show_bug.cgi?id=86408

Rubber-stamped by Filip Pizlo.

Added some descriptive debug messages for the conditions and
values when a cell validation fails.

  • heap/MarkStack.cpp:

(JSC::MarkStack::validate):

4:37 PM Changeset in webkit [117012] by Nate Chapin
  • 6 edits
    10 adds in trunk

Source/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
​https://bugs.webkit.org/show_bug.cgi?id=86131

Reviewed by Adam Barth.

Tests: plugins/npruntime/delete-plugin-within-getProperty.html

plugins/npruntime/delete-plugin-within-hasProperty-return-false.html
plugins/npruntime/delete-plugin-within-hasProperty-return-true.html
plugins/npruntime/delete-plugin-within-invoke.html
plugins/npruntime/delete-plugin-within-setProperty.html

  • bindings/v8/NPV8Object.cpp:

(_NPN_EvaluateHelper):

  • bindings/v8/V8NPObject.cpp: Check NPN_IsAlive in a bunch of places we're not currently.

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):

Tools: Add end-of-life test cases for ​https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(callDeletePlugin):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

  • plugins/npruntime/delete-plugin-within-getProperty-expected.txt: Added.
  • plugins/npruntime/delete-plugin-within-getProperty.html: Added.
  • plugins/npruntime/delete-plugin-within-hasProperty-return-false-expected.txt: Added.
  • plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: Added.
  • plugins/npruntime/delete-plugin-within-hasProperty-return-true-expected.txt: Added.
  • plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: Added.
  • plugins/npruntime/delete-plugin-within-invoke-expected.txt: Added.
  • plugins/npruntime/delete-plugin-within-invoke.html: Added.
  • plugins/npruntime/delete-plugin-within-setProperty-expected.txt: Added.
  • plugins/npruntime/delete-plugin-within-setProperty.html: Added.
4:19 PM Changeset in webkit [117011] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

  • platform/win/DragImageCairoWin.cpp: Add missing include for

new NativeImageCairo.h type.

4:19 PM Changeset in webkit [117010] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Re-enable "drt mode" on chromium-mac-leopard
​https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (change?).

This change is another attempt to gather data on
the flakiness and timeouts we're seeing on Mac SL
now that we have another bot.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):

4:11 PM Changeset in webkit [117009] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.

​https://bugs.webkit.org/show_bug.cgi?id=60121

Unreviewed, baselines change.

  • platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [117008] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

<​http://webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds

Reviewed by Simon Fraser.

  • WTF.xcodeproj/project.pbxproj: Ensure that the debug configuration uses the

same settings as the debug variant would.

3:36 PM Changeset in webkit [117007] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Crash in WebCore::RenderObject::repaint
​https://bugs.webkit.org/show_bug.cgi?id=86162

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-05-14
Reviewed by Abhishek Arya.

Source/WebCore:

As RenderScrollbarPart has no parent renderer, we crash in
WebCore::RenderBoxModelObject::paddingLeft when paddingLeft has
percent value, e.g. 5%. However if we set the scrollbar's parent
renderer to a renderer owning the scrollbar by using setParent method,
RenderScrollbarPart::styleWillChange will invoke parent renderer's
repaint. This causes crash in WebCore::RenderObject::repaint if the
owning renderer is already destroyed.
To fix the first crash without the second crash, modify
RenderObject::containingBlock() to check isRenderScrollbarPart or not,
if parent() is 0.
If so, use scrollbar's owningRenderer from RenderScrollbarPart.

Test: scrollbars/scrollbar-percent-padding-crash.html

scrollbars/scrollbar-scrollbarparts-repaint-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):
Modifying containingBlock. If parent() is 0 and isRenderScrollbarPart()
is true, use RenderScrollbarPart's m_scrollbar->owningRenderer()
instead of parent().

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderScrollbarPart):
(RenderObject):
Adding a new method, isRenderScrollbarPart.

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
(WebCore):
Adding a new method, scrollbarOwningRenderer to obtain m_scrollar's
owningRenderer.

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):
Removing "friend class RenderScrollbar".
(WebCore::RenderScrollbarPart::isRenderScrollbarPart):
(WebCore::toRenderScrollbarPart):
(WebCore):
Implementing isRenderScrollbarPart and toRenderScrollbarPart.

LayoutTests:

  • scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt: Added.
  • scrollbars/scrollbar-scrollbarparts-repaint-crash.html: Added.
  • scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
  • scrollbars/scrollbar-percent-padding-crash.html: Added.
2:53 PM Changeset in webkit [117006] by commit-queue@webkit.org
  • 47 edits
    9 adds
    2 deletes in trunk

Content Security Policy console errors include violated directive.
​https://bugs.webkit.org/show_bug.cgi?id=86323

Source/WebCore:

Patch by Mike West <​mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

Console errors generated when resources, inline script/style, or eval
are blocked by Content Security Policy directives should include the
text of the directive that's been violated. This gives developers more
of the information they need to resolve the issue.

Test: http/tests/security/contentSecurityPolicy/*

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):

LayoutTests:

Sharded http/tests/security/contentSecurityPolicy/source-list-parsing.html
into four tests, and reworked it to have a well-defined order.

Patch by Mike West <​mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
  • http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Removed
  • http/tests/security/contentSecurityPolicy/source-list-parsing.html: Removed
  • http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-01.html: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-02.html: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-03.html: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-04-expected.txt: Added
  • http/tests/security/contentSecurityPolicy/source-list-parsing-04.html: Added
  • http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
2:50 PM Changeset in webkit [117005] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in FrameView::windowClipRectForFrameOwner after r116371
​https://bugs.webkit.org/show_bug.cgi?id=86035

Reviewed by David Hyatt.

Added a NULL-check for |parentView| as nothing guarantees it to be
non-NULL. Unfortunately no test as this is a crasher I couldn't
reproduce on my machine and the user logs were not helpful.

  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):

2:47 PM Changeset in webkit [117004] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86403
ASSERTION FAILED: m_verticalScrollbarPainterDelegate on recent builds
-and corresponding-
<rdar://problem/11448841>

Reviewed by Simon Fraser.

​http://trac.webkit.org/changeset/116476 accidentally started calling
these functions for custom scrollbars. This change replaces that
guard.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::destroyScrollbar):

2:28 PM Changeset in webkit [117003] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r116981.
​http://trac.webkit.org/changeset/116981
​https://bugs.webkit.org/show_bug.cgi?id=86402

Caused compositing and mathml tests to fail. (Requested by
rakuco on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-14

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

2:25 PM Changeset in webkit [117002] by dpranke@chromium.org
  • 3 edits in trunk/Tools

Fix regressions in garden-o-matic after r116988.

Unreviewed, build fix.

I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2:19 PM Changeset in webkit [117001] by rniwa@webkit.org
  • 8 edits in trunk/PerformanceTests

Convert CSS and Parser tests to runs/s tests
​https://bugs.webkit.org/show_bug.cgi?id=86399

Reviewed by Ojan Vafai.

Use runPerSecond instead of run to measure results in function calls per second (run/s) instead of time (ms).
This allows us to continue measuring performance reliably even when WebKit's performance improves and results
become too small for Date.now()'s precision (around 15 ms).

It should also reduce perf. bots cycle time for slower tests because we limit the number of function calls by time.

  • CSS/CSSPropertySetterGetter.html:
  • CSS/CSSPropertyUpdateValue.html:
  • Parser/css-parser-yui.html:
  • Parser/simple-url.html:
  • Parser/tiny-innerHTML.html:
  • Parser/url-parser.html:
  • Parser/xml-parser.html:
2:17 PM Changeset in webkit [117000] by enne@google.com
  • 5 edits in branches/chromium/1132/Source

Merge 116554 - [chromium] Add impl-thread support for fill-mode and direction css animation properties
​https://bugs.webkit.org/show_bug.cgi?id=77662

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.

Source/WebCore:

Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.

Tested in:

CCActiveAnimationTest.TrimTimeAlternating
CCLayerAnimationControllerTest.createReversedAnimation
CCLayerAnimationControllerTest.createAlternatingAnimation
CCLayerAnimationControllerTest.createReversedAlternatingAnimation

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

Source/WebKit/chromium:

  • tests/CCActiveAnimationTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10384167

2:12 PM Changeset in webkit [116999] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove redundant pixel snapping in calculateCompositedBounds()
​https://bugs.webkit.org/show_bug.cgi?id=86400

Reviewed by Sam Weinig.

RenderLayer::calculateLayerBounds() returns a pixel-snapped rect,
so we don't need to pixel-snap it again.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

2:12 PM Changeset in webkit [116998] by enne@google.com
  • 6 edits
    4 copies in branches/chromium/1132

Merge 116786 - [chromium] Ensure that animations continue to run when transform-style is changed
​https://bugs.webkit.org/show_bug.cgi?id=83283

Source/WebCore:

Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

Test: animations/change-transform-style-during-animation.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):

Source/WebKit/chromium:

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/GraphicsLayerChromiumTest.cpp: Added.

(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

LayoutTests:

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • animations/change-transform-style-during-animation-expected.png: Added.
  • animations/change-transform-style-during-animation-expected.txt: Added.
  • animations/change-transform-style-during-animation.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10310152

2:10 PM Changeset in webkit [116997] by schenney@chromium.org
  • 8 edits
    1 add
    2 deletes in trunk/LayoutTests

[chromium] Layout Test svg/carto.net/window.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=84810

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/carto.net/window-expected.txt: Removed.
  • platform/gtk/svg/carto.net/window-expected.txt: Removed.
  • svg/carto.net/window-expected.txt: Added.
2:04 PM Changeset in webkit [116996] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
​https://bugs.webkit.org/show_bug.cgi?id=86270

Reviewed by Eric Seidel.

  • public/android/WebInputEventFactory.h:
  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):
(WebKit::WebInputEventFactory::mouseEvent):
(WebKit):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

1:58 PM Changeset in webkit [116995] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid logging related to setting shadow-related properties on a transform-only layer
​https://bugs.webkit.org/show_bug.cgi?id=86398

Reviewed by Dan Bernstein.

When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::ensureStructuralLayer):

1:52 PM Changeset in webkit [116994] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r116983.
​http://trac.webkit.org/changeset/116983
​https://bugs.webkit.org/show_bug.cgi?id=86397

Does not compile on chromium-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

  • WebCore.gypi:
  • page/TouchAdjustment.cpp:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [116993] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
​https://bugs.webkit.org/show_bug.cgi?id=86395
<rdar://problem/11447652>

Reviewed by John Sullivan.

Add the plug-in identifier and version string to the didFail client callback.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
Pass a null plug-in identifier and version here since we don't have the plug-in information here.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

1:48 PM Changeset in webkit [116992] by schenney@chromium.org
  • 7 edits in trunk/LayoutTests

[SVG] Nothing should be stroked when the stroke-width is 0
​https://bugs.webkit.org/show_bug.cgi?id=83568

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png:
  • platform/chromium-mac/svg/custom/js-update-style-expected.png:
  • platform/chromium-mac/svg/custom/path-zero-strokewidth-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/custom/js-update-style-expected.png:
  • platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png:
  • platform/chromium/test_expectations.txt:
1:39 PM Changeset in webkit [116991] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Added more detail to marked test failure for chromium.

  • platform/chromium/test_expectations.txt:
1:20 PM Changeset in webkit [116990] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Fix typo in expectations file causing lint to fail.

Unreviewed, build fix.

  • platform/chromium/test_expectations.txt:
1:16 PM Changeset in webkit [116989] by mitz@apple.com
  • 1 edit
    1 add in trunk/PerformanceTests

Add a line layout performance test
​https://bugs.webkit.org/show_bug.cgi?id=86216

Reviewed by Ryosuke Niwa.

  • Layout/line-layout.html: Added.
1:11 PM Changeset in webkit [116988] by dpranke@chromium.org
  • 6 edits in trunk/Tools

garden-o-matic should specify which types of baselines to rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=86242

Reviewed by Adam Barth.

This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:

(.):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.init):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):

1:09 PM Changeset in webkit [116987] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar.com/iphone
​https://bugs.webkit.org/show_bug.cgi?id=86391

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-05-14
Reviewed by Adam Treat.

PR 156992
Request layout first if needed before painting contents.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):

1:04 PM Changeset in webkit [116986] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Pagination splits lines that could fit on a single page if it were not for their top leading
​https://bugs.webkit.org/show_bug.cgi?id=86388

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/split-in-top-margin.html

When a line’s visible content fits on a page, but adding the top leading makes it taller than
a page, instead of giving up and splitting the line in an arbitrary position, add a strut
to push it downwards so that the split occurs in the top leading, and the visible content is
fully contained on a single page.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustLinePositionForPagination):

LayoutTests:

  • fast/multicol/split-in-top-margin-expected.html: Added.
  • fast/multicol/split-in-top-margin.html: Added.
12:52 PM Changeset in webkit [116985] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
the specific test (storage/indexeddb/noblobs.html) was fixed in r116337.

  • platform/chromium/test_expectations.txt:
12:28 PM Changeset in webkit [116984] by tony@chromium.org
  • 2 edits in trunk/PerformanceTests

Don't append log lines while perf tests are running.
​https://bugs.webkit.org/show_bug.cgi?id=86028

Reviewed by Ryosuke Niwa.

In some tests, the extra DOM nodes can cause the test timing to change.
Avoid adding DOM nodes until the test is over. When running in a browser,
we append nodes as we run so the user can have some feedback.

  • resources/runner.js:

(PerfTestRunner.log): Store the log lines in an array until the test is finished.

12:24 PM Changeset in webkit [116983] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Compute the best target node on a GestureTap event
​https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-14
Reviewed by Adam Barth.

Source/WebCore:

Using tests in the touchadjustment/ directory.

  • WebCore.gypi:

Include TouchAdjustment.* files.

  • page/TouchAdjustment.cpp:

Included math.h because of an 'Undeclared identifier: INFINITY' when
this patch was landed before.

Source/WebKit/chromium:

  • features.gypi:

Enable the touch adjustment code by default.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

  • platform/chromium/test_expectations.txt:

The flaky tests in touchadjustment/ have been addressed in WK86218.

12:19 PM Changeset in webkit [116982] by piman@chromium.org
  • 4 edits
    1 copy in branches/chromium/1132/Source

Merge 116722 - Sync with impl thread when removing references to external textures
​https://bugs.webkit.org/show_bug.cgi?id=86054

We want to ensure the client side is safe to release textures, so we
sync with the impl thread when:

  • we change the texture (and we had one)
  • the layer is removed from the tree (and we had a texture)
  • the layer is destroyed (and we had a texture)

Reviewed by James Robinson.

Test: TextureLayerChromiumTest.

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setLayerTreeHost):
(WebCore):

  • platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromium):

TBR=​piman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10384160

12:14 PM Changeset in webkit [116981] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][DRT] Fix WebCore library path
​https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-05-14
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

12:12 PM Changeset in webkit [116980] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark one test as failed on chromium.

  • platform/chromium/test_expectations.txt:
12:10 PM Changeset in webkit [116979] by enne@google.com
  • 8 edits in trunk/Source

[chromium] Add compositor debug asserts for blocked main thread
​https://bugs.webkit.org/show_bug.cgi?id=86384

Reviewed by James Robinson.

Source/WebCore:

Where we depend for thread-safety that the main thread is blocked,
assert that this is actually the case.

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore):
(WebCore::CCProxy::isMainThreadBlocked):
(WebCore::CCProxy::setMainThreadBlocked):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):
(WebCore):
(DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::~DebugScopedSetMainThreadBlocked):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::stop):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):

Source/WebKit/chromium:

For tests that are just on the impl tree, pretend that the main thread
is always blocked.

  • tests/CCLayerTreeHostImplTest.cpp:

(CCLayerTreeHostImplTest):

12:06 PM Changeset in webkit [116978] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Patch by Swapna P <​spottabathini@innominds.com> on 2012-05-14
Reviewed by Eric Seidel.

Bug: Cannot resize frames because frameborder=0
​https://bugs.webkit.org/show_bug.cgi?id=23750

Source/WebCore:

Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.

Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::startResizing):
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):

LayoutTests:

Added test case to test whether the frame can be resized when frameborder=0.

  • fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
  • fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.
12:03 PM Changeset in webkit [116977] by jchaffraix@webkit.org
  • 6 edits
    2 adds
    4 deletes in trunk/LayoutTests

More gardening after r115846.

The rebaselining was partially done. Removed the expected TEXT failures from our Mac bots
and rebaselined more platforms.

  • platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [116976] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix. Don't adjust calls per iteration in the second run.

  • resources/runner.js:

(PerfTestRunner._perSecondRunner):

11:57 AM Changeset in webkit [116975] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
​https://bugs.webkit.org/show_bug.cgi?id=86319

Patch by David Barton <Dave Barton> on 2012-05-14
Reviewed by Darin Adler.

Source/WebCore:

Most of RenderMathMLSquareRoot.cpp is duplicated in RenderMathMLRoot.cpp and can be
eliminated. We also define RenderMathMLRoot::computePreferredLogicalWidths().

Test: mathml/presentation/mroot-pref-width.html

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::addChild):

  • rendering/mathml/RenderMathMLSquareRoot.h:

LayoutTests:

  • mathml/presentation/mroot-pref-width.html: Added.
  • platform/mac/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Added.
11:54 AM Changeset in webkit [116974] by morrita@google.com
  • 16 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
​https://bugs.webkit.org/show_bug.cgi?id=86064

Reviewed by Dimitri Glazkov.

This change renames classes around shadow content distribution.

  • Renamed HTMLContentSelector to ContentDistributor
  • Renamed HTMLContentSelectionList to ContentDistribution
  • Renamed HTMLContentSelection to ContentDistribution::Item
  • Inlined HTMLContentSelectionSet into ContentDistributor

Associated rename and inlining are also happening for method names.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::distributionItemFor):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsRedistributing):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsRedistributing):

  • dom/ElementShadow.h:

(WebCore):
(ElementShadow):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::clearNeedsRedistributing):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(WebCore):

  • html/shadow/ContentDistributor.cpp: Renamed from Source/WebCore/html/shadow/HTMLContentSelector.cpp.

(WebCore):
(WebCore::ContentDistribution::ContentDistribution):
(WebCore::ContentDistribution::~ContentDistribution):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findFor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::willDistribute):
(WebCore::ContentDistributor::didDistribute):
(WebCore::ContentDistributor::preparePoolFor):

  • html/shadow/ContentDistributor.h: Added.

(WebCore):
(ContentDistribution):
(Item):
(WebCore::ContentDistribution::Item::insertionPoint):
(WebCore::ContentDistribution::Item::node):
(WebCore::ContentDistribution::Item::next):
(WebCore::ContentDistribution::Item::previous):
(WebCore::ContentDistribution::Item::create):
(WebCore::ContentDistribution::Item::Item):
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::firstNode):
(WebCore::ContentDistribution::lastNode):
(WebCore::ContentDistribution::isEmpty):
(ContentDistributor):
(Translator):
(WebCore::ContentDistributor::Translator::hash):
(WebCore::ContentDistributor::Translator::equal):
(WebCore::ContentDistributor::Hash::hash):
(WebCore::ContentDistributor::Hash::equal):
(Hash):
(WebCore::ContentDistributor::inDistribution):
(WebCore::ContentDistributor::poolIsReady):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentSelector.h: Removed.
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::distribution):
(WebCore::InsertionPoint::hasDistribution):

11:26 AM Changeset in webkit [116973] by commit-queue@webkit.org
  • 4 edits in trunk

[Chromium] ImageDiff should be build for host on Android
​https://bugs.webkit.org/show_bug.cgi?id=82039

Patch by Wei James <​james.wei@intel.com> on 2012-05-14
Reviewed by Adam Barth.

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:18 AM Changeset in webkit [116972] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fixup: Two of the touch-adjustment tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-14
Reviewed by Darin Adler.

One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.

  • touchadjustment/touch-inlines.html:
11:17 AM Changeset in webkit [116971] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r116796): Assertion failure in API tests
<​http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):

11:14 AM Changeset in webkit [116970] by kling@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r116969.
​http://trac.webkit.org/changeset/116969
​https://bugs.webkit.org/show_bug.cgi?id=86386

i accidentally the icondatabase (Requested by kling on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):

  • loader/icon/IconDatabase.h:

(IconDatabase):

Source/WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):

11:04 AM Changeset in webkit [116969] by kling@webkit.org
  • 4 edits in trunk/Source

REGRESSION(r116796): Assertion failure in API tests
<​http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):

11:02 AM Changeset in webkit [116968] by jchaffraix@webkit.org
  • 1 edit
    4 copies in branches/chromium/1132

Merge 116693 - Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
​https://bugs.webkit.org/show_bug.cgi?id=85912

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/images/link-body-content-imageDimensionChanged-crash.html

fast/images/script-counter-imageDimensionChanged-crash.html

The bug comes from CSS generated images that could end up calling imageDimensionsChanged during attachment. As the
rest of the code (e.g. computedCSSPadding*) would assumes that we are already inserted in the tree, we would crash.

The solution is to bail out in this case as newly inserted RenderObject will trigger layout later on and properly
handle what we would be doing as part of imageDimensionChanged (the only exception being updating our intrinsic
size which should be done as part of imageDimensionsChanged).

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):

LayoutTests:

  • fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
  • fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
  • fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
  • fast/images/script-counter-imageDimensionChanged-crash.html: Added.

TBR=​jchaffraix@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10383163

10:54 AM Changeset in webkit [116967] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed trivial buildfix after r116958.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
10:48 AM Changeset in webkit [116966] by Joone Hur
  • 2 edits in trunk/Tools

Unreviewed. Updating email for committers.py script.

Patch by Joone Hur <Joone Hur> on 2012-05-14

  • Scripts/webkitpy/common/config/committers.py:
10:46 AM Changeset in webkit [116965] by jchaffraix@webkit.org
  • 16 edits
    15 adds
    39 deletes in trunk/LayoutTests

Unreviewed rebaseline after r115846.

Those are layers additions & baselines churns due to sharing or splitting
between ports.

  • fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • fast/repaint/lines-with-layout-delta-expected.txt: Added.
  • fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • fast/repaint/subtree-root-clip-2-expected.png: Added.
  • fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Added.
  • platform/chromium-linux-x86/fast/layers: Removed.
  • platform/chromium-linux-x86/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/chromium-mac/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Removed.
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/chromium-win-vista/fast/layers: Removed.
  • platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-win-xp/fast/layers: Removed.
  • platform/chromium-win-xp/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium/fast/layers: Removed.
  • platform/chromium/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/chromium/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
  • platform/chromium/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/chromium/fast/repaint/subtree-root-clip-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
  • platform/efl/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
  • platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
  • platform/efl/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
  • platform/efl/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
  • platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Removed.
  • platform/efl/fast/repaint/subtree-root-clip-expected.png: Removed.
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
  • platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
10:45 AM Changeset in webkit [116964] by rakuco@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Remove ewk_view_core_page_get().
​https://bugs.webkit.org/show_bug.cgi?id=86326

Reviewed by Antonio Gomes.

Right now, we have both ewk_view_core_page_get() and
EWKPrivate::corePage() doing the same thing, but the latter is
better encapsulated.

Remove the former then.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::syncLayersNow): Add
missing ewk_private.h and use EWKPrivate::corePage().

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow): Use
EWKPrivate::corePage().

  • ewk/ewk_private.h: Remove ewk_view_core_page_get() declaration.
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(EWKPrivate::corePage): Fix coding style while here.

10:32 AM Changeset in webkit [116963] by danakj@chromium.org
  • 8 edits in branches/chromium/1132/Source

Merge 116472 - [chromium] Reflections with masks should not occlude
​https://bugs.webkit.org/show_bug.cgi?id=85927

Reviewed by James Robinson.

Source/WebCore:

When a surface does not have a mask, we make both it and its reflection
occlude the things below them. However, if the reflection has a mask
applied to it, then we should not consider it as occluding.

Adds replicaHasMask() to the render surface classes so we can test if
the mask is present.

Unit Tests: CCOcclusionTrackerTestReplicaWithMask

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::RenderSurfaceChromium::replicaHasMask):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToTargetRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::CCRenderSurface::replicaHasMask):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setMask):
(CCOcclusionTrackerTestReplicaWithMask):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests):

TBR=​danakj@chromium.org

10:30 AM Changeset in webkit [116962] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for wxMSW build.

10:27 AM Changeset in webkit [116961] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.

10:17 AM Changeset in webkit [116960] by eric.carlson@apple.com
  • 4 edits
    3 adds in trunk

<video> won't load when URL ends with .php
​https://bugs.webkit.org/show_bug.cgi?id=86308

Source/WebCore:

Reviewed by NOBODY (OOPS!).

Test: http/tests/media/video-query-url.html

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::MediaPlayer): Initialize m_typeInferredFromExtension.
(WebCore::MediaPlayer::load): Set m_typeInferredFromExtension appropriately.
(WebCore::MediaPlayer::loadWithNextMediaEngine): If we don't find a media engine registered

for a MIME type, and the type was inferred from the extension, give the first registered
media engine a chance anwyay just as we do when there is no MIME type at all.

  • platform/graphics/MediaPlayer.h: Add m_typeInferredFromExtension.

LayoutTests:

Reviewed by Darin Adler.

  • http/tests/media/resources/load-video.php: Added.
  • http/tests/media/video-query-url-expected.txt: Added.
  • http/tests/media/video-query-url.html: Added.
10:12 AM Changeset in webkit [116959] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.
​https://bugs.webkit.org/show_bug.cgi?id=86371

When the user selects an object in HeapSnapshot we are updating $0 variable in console API.
But if the snapshot was loaded from file then we can't map object id for the selected obect
from the snapshot to the live objects in the inspected page.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

9:44 AM Changeset in webkit [116958] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Simplify OTHER_FILES for QML tests project files

Reviewed by Jocelyn Turcotte.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
  • UIProcess/API/qt/tests/qmltests/WebView.pro:
9:34 AM Changeset in webkit [116957] by caseq@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: [Extensions API] allow extensions to evaluate in the context of their content scripts
​https://bugs.webkit.org/show_bug.cgi?id=86361

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/extensions/extensions-eval-content-script.html

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): Added evaluateOptions optional parameter.
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument): A helper to extract callback function from last argument.

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane.prototype.setExpression): Added evaluateOptions optional parameter.

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onSetSidebarContent): Use ExtensionServer.evaluate() wrapper.
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): Ditto.
(WebInspector.ExtensionServer.prototype._normalizePath):
(WebInspector.ExtensionServer.prototype.evaluate): A wrapper for PageAgent.evaluate() that handles evaluateOptions.

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin): Expose interface to locate context id by frame and content script security origin.
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext): Maintain contexts sorted by name.
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts): ditto (skip sorting when returning contexts)
(WebInspector.FrameEvaluationContext.prototype.contextBySecurityOrigin):

  • inspector/front-end/inspector.js: Hold/expose javaScriptContextManager.

LayoutTests:

  • inspector/extensions/extensions-eval-content-script-expected.txt: Added.
  • inspector/extensions/extensions-eval-content-script.html: Added.
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
9:10 AM Changeset in webkit [116956] by Carlos Garcia Campos
  • 8 edits in trunk

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

  • GNUmakefile.am: Explicitly link WebProcess to

libjavascriptcoregtk to make sure it uses the non installed
library.

  • GNUmakefile.list.am: Add missing header file.

Tools:

  • GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
  • gtk/run-api-tests:

(TestRunner._lookup_atspi2_binary): Handle the case when
pkg_config_file_variable() return None.

9:06 AM Changeset in webkit [116955] by mihnea@adobe.com
  • 2 edits
    1 add
    11 deletes in trunk/LayoutTests

[CSSRegions]Convert render-region-custom-style-mark to ref test
​https://bugs.webkit.org/show_bug.cgi?id=86289

Reviewed by Andreas Kling.

This test verifies that:

  • If an element is displayed in a region with a region styling rule, that rule is applied.
  • If an element is collected into a named flow and we add a region (with a region style rule) to display the named flow,

that region styling rule is applied.

  • If an element is displayed in a region with a region styling rule, and the region element is changed into a non-region,

the region styling rule is not applied.

  • fast/regions/render-region-custom-style-mark-expected.html: Added.
  • fast/regions/render-region-custom-style-mark.html:
  • platform/chromium-linux/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
  • platform/chromium-mac/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
  • platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
  • platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
8:53 AM Changeset in webkit [116954] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: preserve tab index while widening / shrinking tabbed pane area.
​https://bugs.webkit.org/show_bug.cgi?id=86359

Reviewed by Vsevolod Vlasov.

After the drag'n'drop reorder, we should preserve tab index while widening /
shrinking the tabbed pane area.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._innerCloseTab):
(WebInspector.TabbedPane.prototype._showTabElement):
(WebInspector.TabbedPane.prototype._hideTabElement):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.TabbedPane.prototype._insertBefore):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabDragging):

8:48 AM Changeset in webkit [116953] by schenney@chromium.org
  • 8 edits in trunk/LayoutTests

[Chromium] Update expectations after fix for 84846
​https://bugs.webkit.org/show_bug.cgi?id=86374

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/chromium/test_expectations.txt:
8:44 AM Changeset in webkit [116952] by vsevik@chromium.org
  • 11 edits in trunk

Web Inspector: Request / response headers should be stored in name-value pairs array, not a map on front-end.
​https://bugs.webkit.org/show_bug.cgi?id=86357

Reviewed by Pavel Feldman.

Source/WebCore:

Storing headers as name-value pairs array information more accurate and allows
to treat Set-Cookie headers (which become not parseable when joined by comma) correctly.

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):

  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._headersMapToHeadersArray):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype._headerValue):

  • inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

LayoutTests:

  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt:
  • http/tests/inspector/resource-har-headers.html:
8:35 AM Changeset in webkit [116951] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Source/JavaScriptCore: DFG JIT didn't work with ARM EABI.
​https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <​yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add a 32-bit dummy argument for some callOperation()
methods to make it work for ARM EABI.

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

Source/WTF: DFG JIT is not ARM EABI compatible
​https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <​yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add COMPILER_SUPPORTS(EABI) when ARM_EABI
or EABI is defined.

  • wtf/Compiler.h:
8:33 AM Changeset in webkit [116950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leaks in WebKitWebSettings
​https://bugs.webkit.org/show_bug.cgi?id=86365

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fix memory leaks in WebKitWebSettings by adopting allocations
using adoptWK.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_init):
(webkit_settings_set_serif_font_family):

8:28 AM Changeset in webkit [116949] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
​https://bugs.webkit.org/show_bug.cgi?id=86060

Patch by Sriram Neelakandan <​sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.

Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests

No new tests - covered by existing bindings tests

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(webkit_dom_test_active_dom_object_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(webkit_dom_test_event_constructor_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(webkit_dom_test_exception_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):

8:23 AM Changeset in webkit [116948] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Wrong documentation for Web Database
​https://bugs.webkit.org/show_bug.cgi?id=86362

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fixed docs for webkit_set_default_web_database_quota().

  • webkit/webkitwebdatabase.cpp:
8:17 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
8:15 AM Changeset in webkit [116947] by Csaba Osztrogonác
  • 4 edits
    3 deletes in trunk/Tools

Unreviewed, rolling out r116935.
​http://trac.webkit.org/changeset/116935
​https://bugs.webkit.org/show_bug.cgi?id=86373

Something is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-14

  • Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):
(PNGChecker):
(PNGChecker._config_file_path):

  • Scripts/webkitpy/tool/commands/download.py:

(Land):

  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
7:49 AM Changeset in webkit [116946] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] css properties copied into clipboard contain extra line breaks before color values
​https://bugs.webkit.org/show_bug.cgi?id=86372

Reviewed by Vsevolod Vlasov.

The "display: block" property found in the ".swatch-inner" CSS class was causing the issue
(an additional \n was rendered in the plain text value).

  • inspector/front-end/inspector.css:

(.swatch-inner):

7:05 AM Changeset in webkit [116945] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive-before-unload-crash.html can be unskipped
​https://bugs.webkit.org/show_bug.cgi?id=86368

Unreviewed EFL gardening.

Remove fast/loader/null-request-after-willSendRequest.html and
fast/loader/recursive-before-unload-crash.html from skip list now that
EFL port has proper support for LayoutTestController's
dumpFrameLoadCallbacks.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-14

  • platform/efl/Skipped:
7:01 AM Changeset in webkit [116944] by commit-queue@webkit.org
  • 7 edits in trunk

[Qt] Doesn't build with ENABLE_INSPECTOR=0
​https://bugs.webkit.org/show_bug.cgi?id=85056

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-14
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

  • Target.pri:
  • UIProcess/qt/QtWebContext.cpp:

(WebKit::initInspectorServer):

Tools:

  • WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/features.pri:
6:58 AM Changeset in webkit [116943] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, unskip now passing tests.

  • platform/qt-5.0-wk2/Skipped:
6:39 AM Changeset in webkit [116942] by commit-queue@webkit.org
  • 17 edits
    16 adds in trunk/LayoutTests

[EFL][DRT] Unskipping a set of remaining media failures
​https://bugs.webkit.org/show_bug.cgi?id=86104

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-05-14

  • platform/efl/Skipped:
  • platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
  • platform/efl/media/audio-controls-rendering-expected.png:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.png:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.png: Added.
  • platform/efl/media/media-document-audio-repaint-expected.txt: Added.
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.png:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/test_expectations.txt:
6:36 AM Changeset in webkit [116941] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; unskip tests fixed in r116929.

  • platform/efl/test_expectations.txt:
6:25 AM Changeset in webkit [116940] by pfeldman@chromium.org
  • 5 edits in trunk

[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
​https://bugs.webkit.org/show_bug.cgi?id=86336

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.location):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints.html:
  • platform/qt/Skipped:
6:10 AM Changeset in webkit [116939] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r116932.
​http://trac.webkit.org/changeset/116932
​https://bugs.webkit.org/show_bug.cgi?id=86364

It still fails on 32 bit platforms (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-14

  • platform/qt/Skipped:
6:07 AM Changeset in webkit [116938] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

TiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
​https://bugs.webkit.org/show_bug.cgi?id=85488

Reviewed by Kenneth Rohde Christiansen.

Right now an invalidate can cause problems for tiles on the boundary of the keep
rect. Intersecting the dirty rect causes only part of the tile to be updated,
and the glitch becomes visible if the user scrolls this tile back into the viewport.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::invalidate):

5:45 AM Changeset in webkit [116937] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] fast/viewport testcases are skipped
​https://bugs.webkit.org/show_bug.cgi?id=86360

Unreviewed, unskipping now passing fast/viewport tests after
bug ​https://bugs.webkit.org/show_bug.cgi?id=70609 got fixed.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-14

  • platform/efl/Skipped:
5:38 AM Changeset in webkit [116936] by vestbo@webkit.org
  • 10 edits in trunk

[Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted

​https://bugs.webkit.org/show_bug.cgi?id=86222

The WebView QML api for dialogs is based on delegates for each dialog, which
are implemented as components. Since there's no explicit API to show the dialog,
the natural place to allow the dialog to choose how to display itself is in
Component.onCompleted.

The issue was that we were using QQmlComponent::create() when instantiating the
component, at which point the component did not have a parent or it's attached
WebView property set. That meant that we had to do some ugly workaround in our
test, using a 1ms timer, to get a callback once the parent was there.

We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
pair, which allows us to set the relevant properties before triggering the
Component.onCompleted callback. We were already doing this for the context
menus (except for setting the parent, which we did afterwards).

Reviewed by Simon Hausmann.

5:31 AM Changeset in webkit [116935] by Csaba Osztrogonác
  • 4 edits
    3 adds in trunk/Tools

webkit-patch land should automatically add svn:mime-type for .png files
​https://bugs.webkit.org/show_bug.cgi?id=75825
I refactored the png.py to avoid code duplication.

Patch by Balazs Ankes <​bank@inf.u-szeged.hu> on 2012-05-14
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/checksvnconfigfile.py: Added.

(check):
(_config_file_path):
(errorstr_autoprop):
(errorstr_png):

  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/tool/commands/download.py:

(Land):

  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.

(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.init):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):

  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.

(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):

5:17 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
5:08 AM Changeset in webkit [116934] by ddkilzer@apple.com
  • 5 edits in trunk/Tools

webkit-patch apply-attachment is very slow for big patches
​https://bugs.webkit.org/show_bug.cgi?id=74929

Add "excludefield=attachmentdata" to the URL everywhere
"ctype=xml" is used to exclude this field from the XML.

Reviewed by Adam Barth.

  • Scripts/prepare-ChangeLog:

(fetchBugDescriptionFromURL):

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/config/urls_unittest.py:

(URLsTest.test_parse_bug_id):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.bug_url_for_bug_id):

4:42 AM Changeset in webkit [116933] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Esc should revert the colorpicker-modifed color to the original
​https://bugs.webkit.org/show_bug.cgi?id=86349

Reviewed by Vsevolod Vlasov.

A boolean parameter has been added to the Spectrum's hide() method to denote the picker cancellation,
which gets passed into the "Hidden" event listeners. StylesSidebarPane is made to remember the original property value
when the picker is opened, and restore it if the color picker is cancelled.

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
(WebInspector.Spectrum.prototype._onKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

4:08 AM Changeset in webkit [116932] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

  • platform/qt/Skipped:
4:03 AM Changeset in webkit [116931] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] TextureMapperGL::drawTexture marked OVERRIDE but does not override any member function.
​https://bugs.webkit.org/show_bug.cgi?id=86347

This bug was introduced by r116834.
TextureMapperGL implements two drawTexture functions.
The first one takes a BitmapTexture as an argument and does override TextureMapper::drawTexture().
The second one takes a texture id as an argument and does not override any member function.

  • platform/graphics/texmap/TextureMapperGL.h:
2:46 AM Changeset in webkit [116930] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: implement tabs reordering via drag'n'drop.
​https://bugs.webkit.org/show_bug.cgi?id=86294

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabMouseMove):
(WebInspector.TabbedPaneTab.prototype._tabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):

2:12 AM Acronyms edited by yosin@chromium.org
Add WIP (diff)
1:56 AM Changeset in webkit [116929] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests after r116926.

  • platform/qt/Skipped:
1:13 AM Changeset in webkit [116928] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, removing test expectations for two tests that were
fixed in r116926.

  • platform/gtk/test_expectations.txt:
12:49 AM Changeset in webkit [116927] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

Should have Node::inDetach() for assertion purposes.
​https://bugs.webkit.org/show_bug.cgi?id=86157

Reviewed by Darin Adler.

Implemented Node::inDetach() and added an assertio in Document::setFocusedNode().
This is a follow up of r116644 which removes inDetach() checking.

No new tests. Just adding an asssertion.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::inDetach):
(WebCore::Node::detach):

  • dom/Node.h:

(Node):

12:26 AM Changeset in webkit [116926] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Introduce PropertyName class
​https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Darin Adler.

This patch introduced a couple of small bugs.

  • runtime/PropertyName.h:

(JSC::toUInt32FromCharacters):

  • Returning wrong value for "" - should not convert to 0.

(JSC::PropertyName::PropertyName):

  • Remove the ASSERT, it was a little too aspirational.

May 13, 2012:

11:47 PM Changeset in webkit [116925] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG performs incorrect constant folding on double-to-uint32 conversion in
Uint32Array PutByVal
​https://bugs.webkit.org/show_bug.cgi?id=86330

Source/JavaScriptCore:

Reviewed by Darin Adler.

static_cast<int>(d) is wrong, since JS semantics require us to use toInt32(d).
In particular, C++ casts on typical hardware (like x86 and similar) will
return 0x80000000 for double values that are out of range of the int32 domain
(i.e. less than -231 or greater than or equal to 231). But JS semantics call
for wrap-around; for example the double value 4294967297 ought to become the
int32 value 1, not 0x80000000.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

LayoutTests:

Rubber stamped by Darin Adler.

  • fast/js/dfg-uint32array-overflow-constant-expected.txt: Added.
  • fast/js/dfg-uint32array-overflow-constant.html: Added.
  • fast/js/script-tests/dfg-uint32array-overflow-constant.js: Added.

(foo):

11:44 PM Changeset in webkit [116924] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove platform/image-decoders/xbm from WebCore.gyp
​https://bugs.webkit.org/show_bug.cgi?id=86333

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • WebCore.gyp/WebCore.gyp: Remove reference to platform/image-decoders/xbm

since that directory was removed from the repository long ago.

11:42 PM Changeset in webkit [116923] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new asserting and failing test to paint the bots green.

  • platform/qt/Skipped:
11:27 PM Changeset in webkit [116922] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed test fix: these calc() tests are dumpAsText().

  • css3/calc/transition-crash.html:
  • css3/calc/transition-crash2.html:
11:23 PM Changeset in webkit [116921] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several dom tests are failing after r116828
​https://bugs.webkit.org/show_bug.cgi?id=86334

Unreviewed EFL gardening.

Move fast/dom/CSSStyleDeclaration/empty-string-property.html and
fast/dom/collection-null-like-arguments.html to test_expectations.txt.
Those tests are failing due to a regression introduced in r116828.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-13

  • platform/efl/test_expectations.txt:
10:58 PM Changeset in webkit [116920] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for plenty of sputnik tests that
were specific for debug builds. These tests are now consistently
passing on all the builders but that was only noticed when migration to
using test_expectations.txt was complete, meaning their test expectations
were out of date and moreover erroneous.

  • platform/gtk/test_expectations.txt:
10:34 PM Changeset in webkit [116919] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[CG] Unneeded CFRetain/Release of CGImageRef in BitmapImage::draw
​https://bugs.webkit.org/show_bug.cgi?id=86332

Reviewed by Dan Bernstein.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw): Don't use RetainPtr since the result of
the function is used before anything could call CFRelease on it.

10:32 PM Changeset in webkit [116918] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, remove test expectations for another test which
consistently passess on all the Gtk builders.

  • platform/gtk/test_expectations.txt:
10:26 PM Changeset in webkit [116917] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Listeners map uses raw pointers, but should use OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=86298

Reviewed by Dan Bernstein.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::~PageScriptDebugServer): Removed call
to deleteAllValues since the destructor now takes care of this
(WebCore::PageScriptDebugServer::addListener): Changed idiom of the add
function call here to use adoptPtr.
(WebCore::PageScriptDebugServer::removeListener): Added a now-needed
call to get and removed a now-uneeeded call to delete.

  • bindings/js/PageScriptDebugServer.h: Changed the key type of

PageListenersMap to OwnPtr.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::~ScriptDebugServer): Removed code to delete
the values in m_pageListenersMap. This map was never used and so I have
removed it.

  • bindings/js/ScriptDebugServer.h: Removed the type PageListenersMap

and the unused data member, m_pageListenersMap.

10:23 PM Changeset in webkit [116916] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

performance tests should be able to measure runs/sec rather than time
​https://bugs.webkit.org/show_bug.cgi?id=86021

Reviewed by Ojan Vafai.

PerformanceTests:

Add PerfTestRunner.runPerSecond. It uses _runLoop but replaces _runner by _perSecondRunner
to compute runs/s of runFunction.

When _perSecondRunner is called for the first time, i.e. _completedRuns is 0 (notice this is -1
in regular run/_runner), it slowly increases the number of function calls to runFunction between
time measurements in order to discount the time used by new Date() calls themselves until the
total time spent reaches 100 milliseconds.

By default, runPerSecond runs the test for at least 750 milliseconds in each run, and executes
21 runs, yielding the total run time of roughly 18 seconds. This is significantly faster than
most of existing performance tests. Also see ​http://ejohn.org/blog/accuracy-of-javascript-time/.

Finally, refactored the existing methods of PerfTestRunner to allow "runs/s" unit and share code.

  • Layout/flexbox-column-nowrap.html:
  • Layout/flexbox-column-wrap.html:
  • Layout/flexbox-row-nowrap.html:
  • Layout/flexbox-row-wrap.html:
  • resources/runner.js:

(PerfTestRunner.computeStatistics): Takes unit.
(PerfTestRunner.logStatistics): Ditto.
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):
(PerfTestRunner.runPerSecond): Added.
(PerfTestRunner._perSecondRunner): Added. Called by _runLoop.
(PerfTestRunner._perSecondRunnerIterator): Added.

Tools:

Allow " runs/s" or " ms" to appear after numerical values in tests.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

LayoutTests:

Add tests for PerfTestRunner.runPerSecond.

  • fast/harness/perftests/runs-per-second-iterations-expected.txt: Added.
  • fast/harness/perftests/runs-per-second-iterations.html: Added.
  • fast/harness/perftests/runs-per-second-log-expected.txt: Added.
  • fast/harness/perftests/runs-per-second-log.html: Added.
9:22 PM Changeset in webkit [116915] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[Forms] Move ValidityState methods implementation to another place
​https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-05-13
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added. set custom error message.

  • html/FormAssociatedElement.h:

(FormAssociatedElement): Added new instance value m_customValidationMessage.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessage): Removed. Note: HTMLInputElement, HTMLSelectElement, and HTMLTextAreaElement implement this method.
(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing): Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.

  • html/HTMLInputElement.h:

(HTMLInputElement): Make tooLong method private.

  • html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Added entries for newly added methods.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.

  • html/InputType.cpp:

(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep): Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer): Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added. Moved from HTMLInputElement.

  • html/InputType.h:

(InputType): Added entries for newly added methods and update methods signature.

  • html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.

(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState): Remove custom validation message related things.

8:30 PM Changeset in webkit [116914] by mikelawther@chromium.org
  • 5 edits
    4 adds in trunk

Heap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>, WTF::IntHash<unsigned int>, WTF::HashTrait
​https://bugs.webkit.org/show_bug.cgi?id=85195

Source/WebCore:

This bug was caused by Length not understanding that calc expressions shouldn't be
blended - a Length with a calc expression handle was created without incrementing
the ref count of the expression. Length no longer attempts to blend calc expressions,
​http://webkit.org/b/86160 has been filed to track expression blending. Fixing this fixed
the crash.

Once this was fixed, the RenderStyle diff checker thought the style was changing,
as Length didn't know how to compare calc expressions, resulting in an infinite
loop of style recalcs. Expressions can now compare themselves.

Reviewed by Darin Adler.

Tests: css3/calc/transition-crash.html

css3/calc/transition-crash2.html

  • platform/CalculationValue.h:

(WebCore::CalcExpressionNode::CalcExpressionNode):
(CalcExpressionNode):
(WebCore::CalcExpressionNode::type):
(CalculationValue):
(WebCore::CalculationValue::operator==):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::operator==):
(CalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::operator==):
(CalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::operator==):
(CalcExpressionBinaryOperation):

  • platform/Length.cpp:

(WebCore::Length::isCalculatedEqual):
(WebCore):

  • platform/Length.h:

(WebCore::Length::operator==):
(Length):
(WebCore::Length::blend):

LayoutTests:

Reviewed by Darin Adler.

  • css3/calc/transition-crash-expected.txt: Added.
  • css3/calc/transition-crash.html: Added.
  • css3/calc/transition-crash2-expected.txt: Added.
  • css3/calc/transition-crash2.html: Added.
8:23 PM Changeset in webkit [116913] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark

media/video-controls-toggling.html as failing and move 2 other
media failures to the correct section.

7:17 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
7:16 PM Changeset in webkit [116912] by fpizlo@apple.com
  • 22 edits in branches/dfgopt/Source/JavaScriptCore

DFG should be able to optimize foo.apply(bar, arguments)
​https://bugs.webkit.org/show_bug.cgi?id=86306

Reviewed by Gavin Barraclough.

Enables compilation of op_jneq_ptr and some forms of op_call_varargs.

Also includes a bunch of bug fixes that were made necessary by the increased
pressure on the CFG simplifier.

This is a 1-2% win on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::canCompileWithDFGInternal):
(JSC::EvalCodeBlock::canCompileWithDFGInternal):
(JSC::FunctionCodeBlock::canCompileWithDFGInternal):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::canCompileWithDFG):
(JSC::CodeBlock::canCompileWithDFGState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getLocalLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
(DFG):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:

(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

7:10 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
6:48 PM Changeset in webkit [116911] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag another 2 media failures.
6:40 PM Changeset in webkit [116910] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag failing media test.
4:48 PM Changeset in webkit [116909] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Roll out local changes accidentally landed in r116905.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
4:47 PM Changeset in webkit [116908] by rwlbuis@webkit.org
  • 10 edits in trunk/Source/WebCore

Use emptyString instead of String("")
​https://bugs.webkit.org/show_bug.cgi?id=86305

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and faster.

No new tests. No change in behavior.

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer):

  • platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::setProxyInfo):

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeLocalizedDateFormatText):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):

  • svg/SVGStringList.cpp:

(WebCore::SVGStringList::reset):

4:42 PM Changeset in webkit [116907] by Darin Adler
  • 13 edits in trunk/Source/WebCore

Image::initPlatformData is always an empty function so we can remove it
​https://bugs.webkit.org/show_bug.cgi?id=86297

Reviewed by Dan Bernstein.

  • platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/chromium/ImageChromiumMac.mm: Removed empty

initPlatformData function.

  • platform/graphics/efl/ImageEfl.cpp: Ditto.
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/mac/ImageMac.mm:
  • platform/graphics/openvg/ImageOpenVG.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
  • platform/graphics/win/ImageWin.cpp: Ditto.
  • platform/graphics/wx/ImageWx.cpp: Ditto.

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

4:39 PM Changeset in webkit [116906] by Darin Adler
  • 2 edits in trunk/Source/WebCore

RenderView::selectionBounds and RenderView::setSelection use maps with raw pointers that should be OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=86300

Reviewed by Eric Seidel.

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds): Changed SelectionMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
(WebCore::RenderView::setSelection): Changed SelectedBlockMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.

4:36 PM Changeset in webkit [116905] by Darin Adler
  • 5 edits in trunk/Source/WebCore

FractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
​https://bugs.webkit.org/show_bug.cgi?id=86301

Reviewed by Andreas Kling.

  • platform/FractionalLayoutUnit.h: Removed uses of inline for functions

defined inside a class definition. The C++ language defines that all such
functions are treated as if specified with inline, and explicitly stating
inline in addition does not add anything or change behavior.

4:25 PM Changeset in webkit [116904] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Dangling node to ID maps vector uses raw pointers, but should use OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=86299

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::releaseDanglingNodes): Removed now-unneeded call
to deleteAllValues since the clear function now takes care of that.
(WebCore::InspectorDOMAgent::pushNodePathToFrontend): Added code that uses
adoptPtr and release as neeed to deal with a Vector<OwnPtr>.

  • inspector/InspectorDOMAgent.h: Changed m_danglingNodeToIdMaps to be

Vector<OwnPtr> instead of a vector of raw pointers.

2:45 PM Changeset in webkit [116903] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, fix test skipped in the previous commit.

  • platform/efl/test_expectations.txt:
2:43 PM Changeset in webkit [116902] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip tests after r116900.

The patch only updated the chromium and mac expectations...

  • platform/efl/test_expectations.txt:
2:09 PM Changeset in webkit [116901] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip test added in r116858.

  • platform/efl/test_expectations.txt:
12:11 PM Changeset in webkit [116900] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

Volume slider needs to be displayed below the mute button
​https://bugs.webkit.org/show_bug.cgi?id=85990

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.

Source/WebCore:

Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.

Test: media/media-volume-slider-rendered-below.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.

  • css/mediaControlsQuickTime.css:

Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create):

LayoutTests:

Updated tests expectation and marked failing tests accordingly.

  • media/media-volume-slider-rendered-below.html: Added.
  • media/media-volume-slider-rendered-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Updated.
  • platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
  • platform/mac/media/controls-after-reload-expected.txt: Same.
  • platform/mac/media/controls-strict-expected.txt: Same.
  • platform/mac/media/video-controls-rendering-expected.txt: Same.
  • platform/mac/media/video-display-toggle-expected.txt: Same.
  • platform/mac/media/video-playing-and-pause-expected.txt: Same.
  • platform/mac/test_expectations.txt: Updated.
10:00 AM Changeset in webkit [116899] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
​https://bugs.webkit.org/show_bug.cgi?id=86303

Qt and GTK, in WebKit1, use TextureMapper to store AC animations using
TextureMapperAnimations::add(keyframeName, TextureMapperAnimation). And when a
CSS animation animates several CSS properties, TextureMapperAnimations::add is
called more than once with the same keyframeName value. However, currently,
TextureMapperAnimations can not store more than one animated property in the keyframe
because it is using HashMap<String, TextureMapperAnimation>, and WebKit HashMap
does not support add the same key twice.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
(WebCore::TextureMapperAnimations::hasRunningAnimations):
(WebCore::TextureMapperAnimations::add):
(WebCore):
(WebCore::TextureMapperAnimations::pause):
(WebCore::TextureMapperAnimations::apply):

  • platform/graphics/texmap/TextureMapperAnimation.h:

(TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
so we can support an keyframe with multiple animations.

6:46 AM Changeset in webkit [116898] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113995 - Unreviewed, GTK test_expectations post-Skipped-migration update #2.

  • platform/gtk/test_expectations.txt:
6:46 AM Changeset in webkit [116897] by kov@webkit.org
  • 14 edits
    2 adds in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113986 - Unreviewed, GTK test_expectations post-Skipped-migration update.

  • platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/003-expected.txt:
  • platform/gtk/svg/hixie/perf/004-expected.txt:
  • platform/gtk/svg/hixie/perf/005-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/text-deco-01-b-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/gtk/test_expectations.txt:
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:

Conflicts:

LayoutTests/platform/gtk/svg/hixie/perf/001-expected.txt
LayoutTests/platform/gtk/svg/hixie/perf/002-expected.txt
LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt

6:46 AM Changeset in webkit [116896] by kov@webkit.org
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 110563 - Crash in WebCore::GraphicsContext::paintingDisabled
​https://bugs.webkit.org/show_bug.cgi?id=80669

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.

So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.

Tests: svg/custom/circular-clip-path-references-crash-expected.svg

svg/custom/circular-clip-path-references-crash.svg

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clipToImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:

(SVGImageBufferTools):

LayoutTests:

  • svg/custom/circular-clip-path-references-crash-expected.svg: Added.
  • svg/custom/circular-clip-path-references-crash.svg: Added.
6:45 AM Changeset in webkit [116895] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 110332 - Crash due to inserting letter into div with first-letter
​https://bugs.webkit.org/show_bug.cgi?id=78534

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)

  • rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment)

LayoutTests:

Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.

  • editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
  • editing/inserting/insert-character-in-first-letter-crash.html: Added

Conflicts:

Source/WebCore/rendering/RenderTextFragment.cpp

6:45 AM Changeset in webkit [116894] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115978 - Unreviewed, fix another call to join(), similar to the ones landed
in r115975.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged):

6:45 AM Changeset in webkit [116893] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115975 - [GTK] join() is wrongly used in webkitdirs.pm since r115532
​https://bugs.webkit.org/show_bug.cgi?id=85501

Patch by Philippe Normand <​pnormand@igalia.com> on 2012-05-03
Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath):
(buildAutotoolsProject):

6:45 AM Changeset in webkit [116892] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112408 - [GTK] generate-gtk-doc doesn't cope with custom build directory
​https://bugs.webkit.org/show_bug.cgi?id=82448

Reviewed by Martin Robinson.

Pass the product directory in generate-gtkdoc arguments from
build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/common.py:

(get_build_path):

6:44 AM Changeset in webkit [116891] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115904 - Unreviewed. Fix mistake I committed when applying review comments.

  • jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'

appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.

6:44 AM Changeset in webkit [116890] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115659 - [GTK] Add glib as a dependency to build glib-networking
​https://bugs.webkit.org/show_bug.cgi?id=85181

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules:
6:44 AM Changeset in webkit [116889] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 115532 - [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
​https://bugs.webkit.org/show_bug.cgi?id=76161

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(getJhbuildPath): New method to obtain the jhbuild base directory,
using the product base directory
(jhbuildConfigurationChanged): Use the new method
(buildAutotoolsProject): Ditto.

  • efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
  • gtk/jhbuildrc: Ditto.
  • jhbuild/jhbuild-wrapper: Ditto.
6:44 AM Changeset in webkit [116888] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112372 - [GTK] jhbuild wrongly tricked into clean-up
​https://bugs.webkit.org/show_bug.cgi?id=82216

Reviewed by Gustavo Noronha Silva.

Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
build tree. Also when checking if the jhbuild configuration
changed use absolute md5sum paths.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(jhbuildConfigurationChanged):
(buildAutotoolsProject):

6:43 AM Changeset in webkit [116887] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 114653 - [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
​https://bugs.webkit.org/show_bug.cgi?id=82484

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.

Tools:

Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

LayoutTests:

Unskipping tests that were previously failing due to a bug in libsoup.

  • platform/gtk/test_expectations.txt:

Conflicts:

LayoutTests/platform/gtk/test_expectations.txt
Tools/efl/jhbuild.modules

6:43 AM Changeset in webkit [116886] by kov@webkit.org
  • 2 edits
    1 delete in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113981 - [GTK] Migrate Skipped tests to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=83768

Reviewed by Martin Robinson.

This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.

  • platform/gtk/Skipped: Removed.
  • platform/gtk/test_expectations.txt:

Conflicts:

LayoutTests/platform/gtk/Skipped
LayoutTests/platform/gtk/test_expectations.txt

6:43 AM Changeset in webkit [116885] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114332 - [GTK] Use configure instead of autogen.sh for gtk+
​https://bugs.webkit.org/show_bug.cgi?id=84112

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;

we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball

6:43 AM Changeset in webkit [116884] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114312 - [GTK] Add pango to jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=84086

Unreviewed build fix.

  • gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our

jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.

6:42 AM Changeset in webkit [116883] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 114308 - [GTK] fonts jhbuild module needs an empty clean target
​https://bugs.webkit.org/show_bug.cgi?id=84085

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which

includes a phony clean target that should make warnings and errors go
away.

6:42 AM Changeset in webkit [116882] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merge 114297 - [GTK] Bump dependency on GTK+ 3.x to match reality
​https://bugs.webkit.org/show_bug.cgi?id=84060

Rubber-stamped by Martin Robinson.

.:

  • configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we

already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.

Tools:

  • gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf

to their GNOME 3.4 versions.

  • gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch

is applied upstream.

Conflicts:

Tools/gtk/jhbuild.modules

6:42 AM Changeset in webkit [116881] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 113066 - [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=82473

Reviewed by Philippe Normand.

Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.

  • gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first

check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

6:42 AM Changeset in webkit [116880] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112309 - [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
​https://bugs.webkit.org/show_bug.cgi?id=82252

Reviewed by Gustavo Noronha Silva.

Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
6:41 AM Changeset in webkit [116879] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112294 - [GTK] Build gnutls without p11-kit support
​https://bugs.webkit.org/show_bug.cgi?id=82212

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: pass --without-p11-kit to gnutls'

configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway

6:41 AM Changeset in webkit [116878] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112153 - [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
​https://bugs.webkit.org/show_bug.cgi?id=82209

Reviewed by Martin Robinson.

Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:41 AM Changeset in webkit [116877] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112139 - [jhbuild] Revert $MAKE environment hack introduced in r101929.
​https://bugs.webkit.org/show_bug.cgi?id=82234

Reviewed by Martin Robinson.

The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:41 AM Changeset in webkit [116876] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112101 - [jhbuild] Explicitly disable DTrace when building glib.
​https://bugs.webkit.org/show_bug.cgi?id=82145

Reviewed by Gustavo Noronha Silva.

DTrace support is not really needed by WebKit, so disabling it
helps avoid some build errors on more exotic platforms (such as
FreeBSD).

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
6:40 AM Changeset in webkit [116875] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111929 - [GTK] libgcrypt and p11-kit should not be in jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=82073

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged): new function that isolates the
jhbuild configuration change checking from the autogen logic.
(mustReRunAutogen): code for the new function lived here.
(buildAutotoolsProject): now calls jhbuildConfigurationChanged
itself, and cleans up the jhbuild root if configuration has
changed; it also forces autogen to be run in that case, to
make sure the new libraries are used.

  • gtk/jhbuild.modules: removed libgcrypt and p11-kit.
  • jhbuild/jhbuild-wrapper:

(ensure_jhbuild): this might be run inside a jhbuild environment,
in which case aclocal fails when trying to use the now deleted
aclocal directory in the jhbuild prefix, so work around that.

6:40 AM Changeset in webkit [116874] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111668 - [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
​https://bugs.webkit.org/show_bug.cgi?id=81888

Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild:

(runJhbuild): Helper function to run jhbuild with a given command.
Instead of running jhbuild directly, use the jhbuild-wrapper, so
that we don't need to run it first to check whether jhbuild is
installed or not.

  • efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
  • gtk/run-with-jhbuild: Ditto.
  • jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,

not only run.

6:40 AM Changeset in webkit [116873] by kov@webkit.org
  • 2 edits
    6 adds in releases/WebKitGTK/webkit-1.8/Tools

Merge 111115 - [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
​https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitefl-libs: Added.
  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • efl/common.py: Added.

(script_path):
(top_level_path):
(number_of_cpus):

  • efl/jhbuild.modules: Added.
  • efl/jhbuildrc: Added.
  • efl/run-with-jhbuild: Added.
6:40 AM Changeset in webkit [116872] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 111175 - jhbuild: Call jhbuild's autogen.sh via bash.
​https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

6:39 AM Changeset in webkit [116871] by kov@webkit.org
  • 3 edits
    2 copies
    1 add in releases/WebKitGTK/webkit-1.8/Tools

Merge 110846 - Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
​https://bugs.webkit.org/show_bug.cgi?id=79673

Preparatory work for bringing jhbuild enabled build to EFL port.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
  • Scripts/update-webkitgtk-libs:
  • gtk/run-with-jhbuild:
  • jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.

(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):

6:39 AM Changeset in webkit [116870] by kov@webkit.org
  • 2 edits
    3 adds in releases/WebKitGTK/webkit-1.8/Tools

Merge 111749 - [GTK] Add make to the jhbuild moduleset
​https://bugs.webkit.org/show_bug.cgi?id=81769

Reviewed by Martin Robinson.

Mostly based on a patch by Carlos Garcia Campos <​cgarcia@igalia.com>.
Add GNU make with custom patches to fix several issues:

  • make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to fix the argument list limit of GNU make when running make distcheck.
  • make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski and Jeremy Devenport to fix parallel build issues present in GNU make 3.82
  • gtk/jhbuild.modules: Added make with patches.
  • gtk/patches/make-3.82-arg-list-length.patch: Added.
  • gtk/patches/make-3.82-parallel-build.patch: Added.
6:39 AM Changeset in webkit [116869] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112672 - [GTK] Disable introspection build in the at-spi2-core module.
​https://bugs.webkit.org/show_bug.cgi?id=82729

Patch by Vineet Chaudhary <Vineet> on 2012-03-30
Reviewed by Philippe Normand.

This change is a follow-up of bug 82395 which initially disabled for other modules of the set.

  • gtk/jhbuild.modules: Disable introspection.
6:39 AM Changeset in webkit [116868] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merge 112392 - [GTK] Disable introspection for jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=82395

Reviewed by Philippe Normand.

  • efl/jhbuild.modules: add --disable-introspection to all modules

that support it

  • gtk/jhbuild.modules: ditto.

Conflicts:

Tools/efl/jhbuild.modules

6:38 AM Changeset in webkit [116867] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog

Merge 111607 - Unreviewed, GTK gardening after r111601.

  • platform/gtk/svg/custom/delete-text-crash-expected.txt: Removed.
6:38 AM Changeset in webkit [116866] by kov@webkit.org
  • 5 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 110593 - Fix the use of stale text fragments
​https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <​pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

LayoutTests:

  • svg/custom/delete-text-crash-expected.png: Added.
  • svg/custom/delete-text-crash-expected.txt: Added.
  • svg/custom/delete-text-crash.html: Added.

May 12, 2012:

11:07 PM Changeset in webkit [116865] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r116812.
​http://trac.webkit.org/changeset/116812
​https://bugs.webkit.org/show_bug.cgi?id=86313

Appears to be causing a top crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-12

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):

  • chromium/public/WebStorageArea.h: Removed.
  • chromium/public/WebStorageNamespace.h: Removed.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebStorageArea.h:

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • public/WebStorageNamespace.h:

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createLocalStorageNamespace):

  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

9:22 PM Changeset in webkit [116864] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in HTMLSelectElement::setOption
​https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Reviewed by Eric Seidel.

  • fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/option-add-crash.html: Added.
8:51 PM Changeset in webkit [116863] by kevino@webkit.org
  • 5 edits in trunk/Source

[wx] Restore paste implementation and fix a couple typos.
​https://bugs.webkit.org/show_bug.cgi?id=86311

6:40 PM Changeset in webkit [116862] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

[wx] Fix backing bitmap creation under wxMSW.
​https://bugs.webkit.org/show_bug.cgi?id=86304

Reviewed by Kevin Ollivier.

12:23 PM Changeset in webkit [116861] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8

Merging 111925.

12:14 PM Changeset in webkit [116860] by pdr@google.com
  • 3 edits
    2 adds in trunk

Cleanup before changing attributeName in SVG <animate>
​https://bugs.webkit.org/show_bug.cgi?id=86100

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Changing attributeName caused a crash because references were not removed from the old target.
This change simply cleans up before changing attributeName in SVG animation elements.

Test: svg/animations/dynamic-modify-attributename-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::svgAttributeChanged):

LayoutTests:

  • svg/animations/dynamic-modify-attributename-crash-expected.txt: Added.
  • svg/animations/dynamic-modify-attributename-crash.svg: Added.
11:08 AM Changeset in webkit [116859] by timothy_horton@apple.com
  • 4 edits in trunk/Tools

run-safari and co. should support --guard-malloc command line argument
​https://bugs.webkit.org/show_bug.cgi?id=86287

Reviewed by Dan Bernstein.

Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.

Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
tends to be harmless.

Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

(appendToEnvironmentVariableList):
(setUpGuardMallocIfNeeded):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

10:09 AM Changeset in webkit [116858] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[BlackBerry] Allow the platform media player to determine the media element's paused/playing status
​https://bugs.webkit.org/show_bug.cgi?id=86235

Patch by Max Feil <​mfeil@rim.com> on 2012-05-12
Reviewed by George Staikos.

Source/WebCore:

The platform media player needs to know when the HTMLMediaElement
is not paused. This is to address problems when switching
source element, which causes the destruction of the old
MediaPlayerPrivate object and construction of a new one. The
new one must resume playing ASAP if the old one was playing.

Test: media/media-continues-playing-after-replace-source.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::isElementPaused):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

This test replaces the source element of a playing media object
and makes sure the new source element begins playing.

  • media/media-continues-playing-after-replace-source-expected.txt: Added.
  • media/media-continues-playing-after-replace-source.html: Added.
9:35 AM Changeset in webkit [116857] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: heap profiler should allow revealing an element which is logged to the console
​https://bugs.webkit.org/show_bug.cgi?id=86204

Reviewed by Pavel Feldman.

JS objects in the console have context menu item that allows to reveal them in a heap snapshot view.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu.prototype.isEmpty):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype._detach):
(WebInspector.DataGridNode.prototype.wasDetached):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodeWasDetached):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._clearCurrentHighlight):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetClassName):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.wasDetached):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId.didPopulateChildren):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.nodeClassName):
(WebInspector.HeapSnapshotProviderProxy.prototype.nodePosition):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.ContextMenuProvider):
(WebInspector.ObjectPropertiesSection.ContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ObjectPropertiesSection.addContextMenuProvider):
(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.showObject):
(WebInspector.RevealInHeapSnapshotContextMenuProvider):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):

  • inspector/front-end/profilesPanel.css:

(.highlighted-row):
(@-webkit-keyframes row_highlight):
(to):

7:29 AM Changeset in webkit [116856] by zandobersek@gmail.com
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed, GTK gardening. Also add baselines for new tests after
r116001, r116373 and r116438.

  • platform/gtk/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/gtk/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/gtk/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/gtk/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
  • platform/gtk/fast/css/first-line-text-decoration-expected.txt: Added.
  • platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
  • platform/gtk/media/media-can-play-webm-expected.txt: Added.
  • platform/gtk/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
  • platform/gtk/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
6:54 AM Changeset in webkit [116855] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: move recording button state control out of addProfileHeader.
​https://bugs.webkit.org/show_bug.cgi?id=86293

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot.done):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

6:39 AM Changeset in webkit [116854] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Turn HelpScreen to be View.
​https://bugs.webkit.org/show_bug.cgi?id=85711

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-05-12
Reviewed by Yury Semikhatsky.

Motivation: for further UI changes, HelpSceen needs to be View.
It is planned to combine Settings Screen and Shortcuts Screen in one
tabbed screen.
Bonus: "helpScreen.css" will be lazy-loaded.
Additional changes: move settingsScreen logic out of inspector.js

UI change, no test required.

  • WebCore.gypi: Change "helpScreen.css" file group.
  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Turned to View subclass.
(WebInspector.HelpScreen.prototype.showModal): Remove "onHide" param
(WebInspector.HelpScreen.prototype.hide): Ditto.
(WebInspector.HelpScreen.prototype._onKeyDown): Adopt View members.
(WebInspector.HelpScreen.prototype._onBlur): Ditto.

  • inspector/front-end/SettingsScreen.js: Adopt new workflow.

(WebInspector.SettingsScreen): Put onHide function to member
(WebInspector.SettingsScreen.prototype.willHide): Invoke onHide
(WebInspector.SettingsController): Mediator pattern - this class
takes care of status bar button - settings screen relationship.
(WebInspector.SettingsController.prototype.get statusBarItem):
Getter fot representative element.
(WebInspector.SettingsController.prototype._buttonClicked):
Classifies user action.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Cleanup after settings screen is hidden.
(WebInspector.SettingsController.prototype._showSettingsScreen):
Presents settings screen.
(WebInspector.SettingsController.prototype._hideSettingsScreen):
Hides settings screen.

  • inspector/front-end/ShortcutsScreen.js: Adopt new workflow.

(WebInspector.ShortcutsScreen.prototype.wasShown): Lazy initialization.

  • inspector/front-end/WorkerManager.js: Adopt new workflow.

(WebInspector.WorkerManager.prototype._disconnectedFromWorker): Ditto.
(WebInspector.WorkerTerminatedScreen.prototype.willHide): Ditto.

  • inspector/front-end/helpScreen.css: Fix spacing.

(.help-window-outer): Ditto.
(body.compact .help-window-outer): Ditto.
(body.compact .help-window-main): Ditto.
(body.compact .help-window-caption): Ditto.
(.help-content): Ditto.
(body.compact .help-content): Ditto.
(.help-content select): Ditto.

  • inspector/front-end/inspector.html: Ditto.
  • inspector/front-end/inspector.js: Ditto.

(WebInspector._createGlobalStatusBarItems): Create SettingsController.
(WebInspector.documentKeyDown): Adopt new workflow.

6:09 AM Changeset in webkit [116853] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add tab context menu
​https://bugs.webkit.org/show_bug.cgi?id=86292

Reviewed by Yury Semikhatsky.

This tab context menu will have "Close", "Close Others" and "Close All".

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeOtherTabs):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):

5:52 AM Changeset in webkit [116852] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: make call frame selector pane focusable, allow Up / Down to select current call frame.
​https://bugs.webkit.org/show_bug.cgi?id=86291

Reviewed by Yury Semikhatsky.

This change makes sidebar section focusable, introduces key listeners for Up and Down.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
(WebInspector.CallStackSidebarPane.prototype._treeKeyDown):

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar img):

5:36 AM Changeset in webkit [116851] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: unreviewed one line fix.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

5:02 AM Changeset in webkit [116850] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Load context menu item has to be shown for all Profiles panel.
​https://bugs.webkit.org/show_bug.cgi?id=86290

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):

4:56 AM Changeset in webkit [116849] by tkent@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

[Chromium] Update test expectations

  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Removed.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium/test_expectations.txt:
4:09 AM Changeset in webkit [116848] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: shrink SourceFrame editing API to two methods (was 4).
​https://bugs.webkit.org/show_bug.cgi?id=86288

Reviewed by Yury Semikhatsky.

Used specific workflow in two SourceFrame implementations.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.commitEditing.callbackWrapper):
(WebInspector.EditableResourceSourceFrame.prototype.commitEditing):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):

3:17 AM Changeset in webkit [116847] by yurys@chromium.org
  • 15 edits
    2 adds in trunk

Web Inspector: allow showing arbitrary range of nodes in heap snapshot view
​https://bugs.webkit.org/show_bug.cgi?id=86230

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/profiler/heap-snapshot-summary-show-ranges.html

It was only possible to expand heap snapshot node children sequentially starting
from the first child and then pressing either "Show next X items" or "Show all X items".
This change makes it possible to show any range of children.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAll):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
(WebInspector.HeapSnapshotEdgesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotNodesProvider.prototype.serializeItem):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.serializeNextChunk):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertRetrievedChild):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.insertShowMoreButton):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeItemsRange.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProviderProxy.prototype.serializeItemsRange):

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showNextChunk):
(WebInspector.ShowMoreDataGridNode.prototype._showAll):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.setStartPosition):
(WebInspector.ShowMoreDataGridNode.prototype.setEndPosition):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/profiler/heap-snapshot-comparison-show-all.html:
  • inspector/profiler/heap-snapshot-containment-show-all.html:
  • inspector/profiler/heap-snapshot-dominators-show-all.html:
  • inspector/profiler/heap-snapshot-summary-show-all.html:
  • inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-show-ranges.html: Added. Test that

showing overlapping and disjoint ranges of node children will leave the node
in a valid state.

  • platform/mac/Skipped: Skip the test on platforms that don't support heap profiling.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
3:02 AM Changeset in webkit [116846] by pfeldman@chromium.org
  • 16 edits in trunk

Web Inspector: remove UISourceCode.id since it is no longer used.
​https://bugs.webkit.org/show_bug.cgi?id=86286

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We are now using breakpointStorageId property for breakpoint persistence.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._uiLocationAdded.get if):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved.get if):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
1:51 AM Changeset in webkit [116845] by tkent@chromium.org
  • 36 edits
    4 copies
    5 moves
    1 add
    23 deletes in trunk/LayoutTests

[Chromium] Test expectation update.

  • fast/block/float/avoiding-float-centered-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/avoiding-float-centered-expected.txt.
  • fast/clip/008-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/008-expected.txt.
  • fast/clip/011-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/011-expected.txt.
  • fast/clip/012-expected.txt: Renamed from LayoutTests/platform/efl/fast/clip/012-expected.txt.
  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium-linux-x86/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt.
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/4806874-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/4895428-3-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/4975120-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/drag-select-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/expanding-selections-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/block-font-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-mac/fast/block/lineboxcontain/font-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Removed.
  • platform/gtk/fast/clip/008-expected.txt: Removed.
  • platform/gtk/fast/clip/011-expected.txt: Removed.
  • platform/gtk/fast/clip/012-expected.txt: Removed.
1:44 AM Changeset in webkit [116844] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Also remove expectations for some

tests that were recently removed.

1:33 AM Changeset in webkit [116843] by pfeldman@chromium.org
  • 13 edits
    2 adds in trunk

Web Inspector: merge MainScriptMapping into DebuggerPresentationModel; move other classes into their own files.
​https://bugs.webkit.org/show_bug.cgi?id=86285

Reviewed by Yury Semikhatsky.

Source/WebCore:

The only purpose of the debugger presentation model now is to manage mappings. Merging main script mapping back into it.
Other classes defined in that class are moved out into their own files.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/DebuggerResourceBinding.js: Added.

(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/PresentationConsoleMessageHelper.js: Added.

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._addConsoleMessageToScript):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):
(WebInspector.PresentationConsoleMessage.prototype._updateLocation):
(WebInspector.PresentationConsoleMessage.prototype.get lineNumber):
(WebInspector.PresentationConsoleMessage.prototype.dispose):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping-expected.txt:
  • http/tests/inspector/compiler-script-mapping.html:
1:31 AM Changeset in webkit [116842] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Cleanup ContentSecurityPolicy naming conventions.
​https://bugs.webkit.org/show_bug.cgi?id=86282

Patch by Mike West <​mkwst@chromium.org> on 2012-05-12
Reviewed by Adam Barth.

Two tiny changes:

  1. reportURI and reportURL are both used within the CSP implementation. We should standardize on reportURI to match the spec.
  1. Renames ContentSecurityPolicy::allowConnectFromSource to ContentSecurityPolicy::allowConnectToSource for clarity.

No new tests, as there's no user-visible change.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::allowConnectToSource):

  • page/ContentSecurityPolicy.h:
  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

12:43 AM Changeset in webkit [116841] by tkent@chromium.org
  • 198 edits
    40 moves
    5 adds
    177 deletes in trunk/LayoutTests

[Chromium] Rebaseline for some tests.

  • css3/selectors3/html/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-23-expected.txt.
  • css3/selectors3/html/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-24-expected.txt.
  • css3/selectors3/html/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-68-expected.txt.
  • css3/selectors3/html/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-69-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • css3/selectors3/xhtml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
  • css3/selectors3/xml/css3-modsel-23-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-23-expected.txt.
  • css3/selectors3/xml/css3-modsel-24-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • css3/selectors3/xml/css3-modsel-68-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • css3/selectors3/xml/css3-modsel-69-expected.txt: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-69-expected.txt.
  • fast/block/float/033-expected.txt:
  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/float-not-removed-from-next-sibling3-expected.txt.
  • fast/block/float/in-margin-expected.png: Renamed from LayoutTests/platform/efl/fast/block/float/in-margin-expected.png.
  • fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt.
  • fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/shrink-to-avoid-float-complexity-expected.txt.
  • fast/block/lineboxcontain/parsing-invalid-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/lineboxcontain/parsing-invalid-expected.txt.
  • fast/clip/017-expected.png: Renamed from LayoutTests/platform/efl/fast/clip/017-expected.png.
  • fast/css/invalidation-errors-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-2-expected.txt.
  • fast/css/invalidation-errors-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/invalidation-errors-expected.txt.
  • fast/css/nested-layers-with-hover-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/nested-layers-with-hover-expected.txt.
  • fast/dynamic/subtree-boundary-percent-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-boundary-percent-height-expected.png.
  • fast/dynamic/subtree-no-common-root-static-y-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-no-common-root-static-y-expected.png.
  • fast/dynamic/subtree-table-cell-height-expected.png: Renamed from LayoutTests/platform/efl/fast/dynamic/subtree-table-cell-height-expected.png.
  • fast/inline/continuation-outlines-expected.txt: Renamed from LayoutTests/platform/efl/fast/inline/continuation-outlines-expected.txt.
  • fast/layers/self-painting-outline-expected.png: Renamed from LayoutTests/platform/efl/fast/layers/self-painting-outline-expected.png.
  • fast/multicol/layers-split-across-columns-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/layers-split-across-columns-expected.txt.
  • fast/overflow/004-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/004-expected.txt.
  • fast/overflow/clip-rects-fixed-ancestor-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt.
  • fast/overflow/line-clamp-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/line-clamp-expected.txt.
  • fast/overflow/overflow-focus-ring-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/overflow-focus-ring-expected.txt.
  • fast/repaint/layer-outline-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-expected.txt.
  • fast/repaint/layer-outline-horizontal-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/layer-outline-horizontal-expected.txt.
  • fast/repaint/opacity-change-on-overflow-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.txt.
  • fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
  • fast/table/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/029-expected.txt.
  • fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/overflowHidden-expected.txt.
  • platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-linux-x86/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-linux/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac-leopard/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.txt: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.txt: Removed.
  • platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Removed.
  • platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Removed.
  • platform/chromium-mac/fast/css/line-height-expected.txt: Removed.
  • platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/isindex-001-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/encoding-test-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/fieldset-align-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-align-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-baseline-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-spaces-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-table-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/input-width-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-styled-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/004-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/line-clamp-expected.txt: Removed.
  • platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/layer-outline-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.txt: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.txt: Removed.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.txt: Removed.
  • platform/chromium-mac/fast/table/003-expected.txt: Removed.
  • platform/chromium-mac/fast/table/029-expected.txt: Removed.
  • platform/chromium-mac/fast/table/colspanMinWidth-expected.txt: Removed.
  • platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.txt: Removed.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.txt: Removed.
  • platform/chromium-mac/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.txt: Removed.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/45621-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug154780-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Removed.
  • platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win-xp/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/chromium-win/fast/overflow/004-expected.txt:
  • platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/chromium-win/fast/overflow/line-clamp-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/003-expected.txt:
  • platform/chromium-win/fast/table/029-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/selection-painted-separately-expected.txt:
  • platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/fast/block/float/033-expected.txt: Removed.
  • platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/chromium/fast/block/float/in-margin-expected.txt: Removed.
  • platform/chromium/fast/clip/017-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/chromium/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/chromium/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/block/float/033-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: Removed.
  • platform/gtk/fast/block/float/033-expected.txt: Removed.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/gtk/fast/block/float/in-margin-expected.png: Removed.
  • platform/gtk/fast/block/float/in-margin-expected.txt: Removed.
  • platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/gtk/fast/clip/017-expected.png: Removed.
  • platform/gtk/fast/clip/017-expected.txt: Removed.
  • platform/gtk/fast/css/invalidation-errors-2-expected.txt: Removed.
  • platform/gtk/fast/css/invalidation-errors-expected.txt: Removed.
  • platform/gtk/fast/css/nested-layers-with-hover-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/gtk/fast/inline/continuation-outlines-expected.txt: Removed.
  • platform/gtk/fast/layers/self-painting-outline-expected.png: Removed.
  • platform/gtk/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Removed.
  • platform/gtk/fast/overflow/004-expected.txt: Removed.
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Removed.
  • platform/gtk/fast/overflow/line-clamp-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-focus-ring-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-outline-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt: Removed.
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • platform/gtk/fast/table/029-expected.txt: Removed.
  • platform/gtk/fast/table/overflowHidden-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug154780-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Removed.
  • platform/mac/fast/block/float/033-expected.txt: Removed.
  • platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Removed.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/mac/fast/block/float/in-margin-expected.txt: Removed.
  • platform/mac/fast/clip/017-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
  • platform/qt/fast/block/float/in-margin-expected.txt: Removed.
  • platform/qt/fast/clip/017-expected.txt: Removed.
  • platform/qt/fast/css/resize-single-axis-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
  • platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
  • platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
  • tables/mozilla/bugs/bug154780-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug154780-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug45621-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.txt.

May 11, 2012:

11:45 PM Changeset in webkit [116840] by pilgrim@chromium.org
  • 11 edits
    3 adds in trunk/Source

[Chromium] Call isLinkVisited directly
​https://bugs.webkit.org/show_bug.cgi?id=85412

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):

  • platform/VisitedLinks.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

  • platform/VisitedLinks.h: Added.

(WebCore):
(VisitedLinks):

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/VisitedLinksChromium.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

10:43 PM Changeset in webkit [116839] by noel.gordon@gmail.com
  • 429 edits
    2 copies
    60 moves
    74 adds
    71 deletes in trunk/LayoutTests

Optimise and update test expectations after r116636

Unreviewed test expectations update.

  • fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
  • fast/block/float/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/014-expected.txt.
  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
  • fast/repaint/backgroundSizeRepaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/backgroundSizeRepaint-expected.txt.
  • fast/repaint/clipped-relative-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clipped-relative-expected.txt.
  • fast/repaint/selected-replaced-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/selected-replaced-expected.txt.
  • fast/replaced/absolute-image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/absolute-image-sizing-expected.txt.
  • fast/replaced/image-onload-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-onload-expected.txt.
  • fast/replaced/image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-sizing-expected.txt.
  • fast/replaced/width100percent-image-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/width100percent-image-expected.txt.
  • fast/writing-mode/background-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-horizontal-bt-expected.txt.
  • fast/writing-mode/background-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-lr-expected.txt.
  • fast/writing-mode/background-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-rl-expected.txt.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/float/014-expected.png:
  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-onload-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.png:
  • platform/chromium-mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/image-css3-content-data-expected.png:
  • platform/chromium-mac/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
  • platform/chromium-mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-mac/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-onload-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-tag-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/img-layer-grow-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-win-xp/fast/replaced/image-tag-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/float/014-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/image-css3-content-data-expected.png:
  • platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png:
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/repaint/clipped-relative-expected.png:
  • platform/chromium-win/fast/repaint/selected-replaced-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-onload-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-tag-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/gtk/fast/block/float/014-expected.txt: Removed.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/gtk/fast/repaint/backgroundSizeRepaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/clipped-relative-expected.txt: Removed.
  • platform/gtk/fast/repaint/selected-replaced-expected.txt: Removed.
  • platform/gtk/fast/replaced/absolute-image-sizing-expected.txt: Removed.
  • platform/gtk/fast/replaced/image-onload-expected.txt: Removed.
  • platform/gtk/fast/replaced/image-sizing-expected.txt: Removed.
  • platform/gtk/fast/replaced/width100percent-image-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug10565-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug11026-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1296-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1430-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug15544-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug17138-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2981-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4093-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4284-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug56563-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug5797-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug625-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/bloomberg-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/misc-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/row_span-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt: Removed.
  • platform/gtk/tables/mozilla/other/cell_widths-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/qt/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Copied from LayoutTests/fast/images/gray-scale-jpeg-with-color-profile-expected.txt.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/tables/mozilla/bugs/bug29314-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • tables/mozilla/bugs/bug10565-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10565-expected.txt.
  • tables/mozilla/bugs/bug11026-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11026-expected.txt.
  • tables/mozilla/bugs/bug12908-1-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt.
  • tables/mozilla/bugs/bug1296-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1296-expected.txt.
  • tables/mozilla/bugs/bug1430-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1430-expected.txt.
  • tables/mozilla/bugs/bug15544-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug15544-expected.txt.
  • tables/mozilla/bugs/bug17138-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug17138-expected.txt.
  • tables/mozilla/bugs/bug29314-expected.txt:
  • tables/mozilla/bugs/bug2981-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt.
  • tables/mozilla/bugs/bug4093-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4093-expected.txt.
  • tables/mozilla/bugs/bug4284-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4284-expected.txt.
  • tables/mozilla/bugs/bug4427-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug4427-expected.txt.
  • tables/mozilla/bugs/bug56563-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56563-expected.txt.
  • tables/mozilla/bugs/bug5797-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug5797-expected.txt.
  • tables/mozilla/bugs/bug625-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug625-expected.txt.
  • tables/mozilla/bugs/bug6404-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug6404-expected.txt.
  • tables/mozilla/bugs/bug82946-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt.
  • tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/bloomberg-expected.txt.
  • tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt.
  • tables/mozilla/core/misc-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/misc-expected.txt.
  • tables/mozilla/core/row_span-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/core/row_span-expected.txt.
  • tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tbody_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt.
  • tables/mozilla/marvin/tbody_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt.
  • tables/mozilla/marvin/td_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt.
  • tables/mozilla/marvin/td_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt.
  • tables/mozilla/marvin/td_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt.
  • tables/mozilla/marvin/td_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt.
  • tables/mozilla/marvin/tfoot_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt.
  • tables/mozilla/marvin/th_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt.
  • tables/mozilla/marvin/th_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt.
  • tables/mozilla/marvin/th_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt.
  • tables/mozilla/marvin/th_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt.
  • tables/mozilla/marvin/thead_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt.
  • tables/mozilla/marvin/thead_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt.
  • tables/mozilla/marvin/thead_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt.
  • tables/mozilla/marvin/thead_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt.
  • tables/mozilla/marvin/tr_valign_baseline-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt.
  • tables/mozilla/marvin/tr_valign_bottom-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt.
  • tables/mozilla/marvin/tr_valign_middle-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt.
  • tables/mozilla/marvin/tr_valign_top-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt.
  • tables/mozilla/other/cell_widths-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/other/cell_widths-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug6933-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt.
9:14 PM Changeset in webkit [116838] by fpizlo@apple.com
  • 19 edits in branches/dfgopt/Source/JavaScriptCore

DFG should be able to inline functions that use arguments reflectively
​https://bugs.webkit.org/show_bug.cgi?id=86132

Reviewed by Oliver Hunt.

This turns on inlining of functions that use arguments reflectively, but it
does not do any of the obvious optimizations that this exposes. I'll save that
for another patch - the important thing for now is that this contains all of
the plumbing necessary to make this kind of inlining sound even in bizarro
cases like an inline callee escaping the arguments object to parts of the
inline caller where the arguments are otherwise dead. Or even more fun cases
like where you've inlined to an inline stack that is three-deep, and the
function on top of the inline stack reflectively accesses the arguments of a
function that is in the middle of the inline stack. Any subsequent
optimizations that we do for the obvious cases of arguments usage in inline
functions will have to take care not to break the baseline functionality that
this patch plumbs together.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:
  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::someCodeBlockForPossiblyInlinedCode):

  • interpreter/CallFrame.h:

(ExecState):
(JSC::ExecState::someCodeBlockForPossiblyInlinedCode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArgumentsFromVMCode):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):
(JSC):
(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/Arguments.h:

(Arguments):
(JSC::Arguments::create):
(JSC::Arguments::finishCreation):
(JSC):

8:15 PM Changeset in webkit [116837] by ojan@chromium.org
  • 4 edits in trunk/Tools

Add previous/next buttons the garden-o-matics perf panel
​https://bugs.webkit.org/show_bug.cgi?id=86280

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
8:04 PM Changeset in webkit [116836] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Port gtest WebViewTest.ActiveState from test_shell_tests to webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=86271

Reviewed by James Robinson.

The original test is in src/webkit/glue/webview_unittest.cc.

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit):

7:20 PM Changeset in webkit [116835] by shawnsingh@chromium.org
  • 9 edits in trunk/Source

[chromium] Plumb --show-paint-rects to accelerated compositor
​https://bugs.webkit.org/show_bug.cgi?id=86255

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setShowPaintRects):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::showFPSCounter):
(WebKit::WebSettingsImpl::showPlatformLayerTree):
(WebKit::WebSettingsImpl::showPaintRects):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::settingsImpl):
(WebKit::WebViewImpl::settings):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
7:11 PM Changeset in webkit [116834] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[TextureMapper] Tiles are not created for large textures
​https://bugs.webkit.org/show_bug.cgi?id=86245

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This will not produce any observable behavior changes,
unless run on a machine with a small texture size limit.

The maxTextureSize() method on TextureMapperGL was missing a "const"
keyword, meaning that it was not properly overriding the version in
the abstract base class (TextureMapper). This patch adds the const
modifier and cleans up the list of override methods in the two
TextureMapper sublcasses, adding the OVERRIDE macro for compilers that
support it and removing a couple unused methods.

  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::create):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

7:04 PM Changeset in webkit [116833] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Prevent deadlock on CCVideoLayerImpl destruction
​https://bugs.webkit.org/show_bug.cgi?id=86258

Reviewed by James Robinson.

~CCVideoLayerImpl had a common deadlock issue where if it got
destroyed before WebMediaPlayerClientImpl, it would take a lock,
call WebMediaPlayerClientImpl::setVideoFrameProviderClient(0),
which in turn would call CCVideoLayerImpl::stopUsingProvider(),
which would try to take the same lock and would deadlock.

CCVideoLayerImpl is only created and destroyed during tree
synchronization in a commit or during synchronous compositor thread
destruction. In either case, the main thread is blocked, and so no
lock needs to be taken at all.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::stopUsingProvider):

7:01 PM Changeset in webkit [116832] by jpfau@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r114170): Scroll areas in nested frames improperly placed when tiled drawing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=86239

Reviewed by Anders Carlsson.

.:

  • ManualTests/resources/frame-textarea.html: Added.
  • ManualTests/scrollable-positioned-frame.html: Added.
  • ManualTests/scrollable-positioned-nested-frame.html: Added.

Source/WebCore:

Fixes a regression introduced in r114170 by recursively adding positions of parent frames to placement of nested frame scroll areas.

Manual tests: ManualTests/scrollable-positioned-frame.html

ManualTests/scrollable-positioned-nested-frame.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

6:19 PM Changeset in webkit [116831] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86278
Composited layers should only run the overlay scrollbars painting pass
if necessary

Reviewed by Dan Bernstein.

It's not enough that the rootLayer has dirty scrollbars; we also have
to actually be doing the overlay scrollbars painting pass to skip the
early return.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

5:56 PM Changeset in webkit [116830] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Comcast website displays bottom of page when loaded
​https://bugs.webkit.org/show_bug.cgi?id=86277
<rdar://problem/11426887>

Reviewed by Beth Dakin.

There were two bugs here. The first bug was that FrameView::setScrollPosition didn't end up calling into the scrolling coordinator
to update the scroll position. The second bug was that ScrollingTreeNodeMac::setScrollPosition didn't constrain the scroll position
to the edge of the page.

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):
Call requestScrollPositionUpdate.

  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTree.h:

Remove setMainFrameScrollPosition, it is not called by anyone.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:
  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Clamp to the page size and call setScrollPositionWithoutContentEdgeConstraints.

(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
Update the scroll layer position and call back to the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call setScrollPosition.

(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Call setScrollPositionWithoutContentEdgeConstraints.

5:42 PM Changeset in webkit [116829] by commit-queue@webkit.org
  • 1 edit
    7 adds
    35 deletes in trunk/LayoutTests

Convert some MathML layout tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=86250

Patch by David Barton <Dave Barton> on 2012-05-11
Reviewed by Ryosuke Niwa.

  • mathml/presentation/msub-base-changed-expected.html: Added.
  • mathml/presentation/msub-sub-changed-expected.html: Added.
  • mathml/presentation/msubsup-base-changed-expected.html: Added.
  • mathml/presentation/msubsup-sub-changed-expected.html: Added.
  • mathml/presentation/msubsup-sup-changed-expected.html: Added.
  • mathml/presentation/msup-base-changed-expected.html: Added.
  • mathml/presentation/msup-sup-changed-expected.html: Added.
  • platform/efl/mathml/presentation/msub-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msub-sub-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msup-base-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/efl/mathml/presentation/msup-sup-changed-expected.png: Removed.
  • platform/efl/mathml/presentation/msup-sup-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msub-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msub-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msub-sub-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msub-sub-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msup-base-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msup-base-changed-expected.txt: Removed.
  • platform/mac/mathml/presentation/msup-sup-changed-expected.png: Removed.
  • platform/mac/mathml/presentation/msup-sup-changed-expected.txt: Removed.
5:39 PM Changeset in webkit [116828] by barraclough@apple.com
  • 186 edits
    1 add in trunk/Source

Introduce PropertyName class
​https://bugs.webkit.org/show_bug.cgi?id=86241

Reviewed by Geoff Garen.

Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
This change paves the way to allow for properties keyed by values that are not Identifiers.

This change is largely a mechanical find & replace.
It also changes JSFunction's constructor to take a UString& instead of an Identifier&
(since in some cases we can no longer guarantee that we'lll have an Identifier), and
unifies Identifier's methods to obtain array indices onto PropertyName.

The new PropertyName class retains the ability to support .impl() and .ustring(), but
in a future patch we may need to rework this, since not all PropertyNames should be
equal based on their string representation.

Source/JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::finishCreation):

  • API/JSCallbackFunction.h:

(JSCallbackFunction):
(JSC::JSCallbackFunction::create):

  • API/JSCallbackObject.h:

(JSCallbackObject):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • JSCTypedArrayStubs.h:

(JSC):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putDirectVirtual):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:

(DebuggerActivation):

  • jsc.cpp:

(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):

  • runtime/Arguments.h:

(Arguments):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::finishCreation):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:

(ArrayConstructor):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
(JSC::putProperty):

  • runtime/ArrayPrototype.h:

(ArrayPrototype):

  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::finishCreation):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:

(BooleanPrototype):

  • runtime/ClassInfo.h:

(MethodTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::finishCreation):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:

(DateConstructor):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):

  • runtime/DatePrototype.h:

(DatePrototype):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:

(ErrorPrototype):

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):
(FunctionPrototype):

  • runtime/Identifier.cpp:

(JSC):

  • runtime/Identifier.h:

(Identifier):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

  • runtime/InternalFunction.h:

(InternalFunction):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putDirectVirtual):
(JSC::JSActivation::deleteProperty):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h:

(JSActivation):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSArray):
(JSC):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h:

(JSBoundFunction):

  • runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlot):
(JSC::JSCell::put):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::putDirectVirtual):
(JSC::JSCell::defineOwnProperty):
(JSC::JSCell::getOwnPropertyDescriptor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::getCalculatedDisplayName):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
(JSC::JSGlobalObject::symbolTableHasProperty):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):

  • runtime/JSNotAnObject.h:

(JSNotAnObject):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):

  • runtime/JSONObject.h:

(JSONObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::hasProperty):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::callDefaultValueFunction):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::get):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSValue::get):
(JSC::JSValue::put):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSStaticScopeObject.h:

(JSStaticScopeObject):

  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSString):
(JSC::JSString::getStringPropertySlot):

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/JSValue.h:

(JSC):
(JSValue):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::putDirectVirtual):

  • runtime/JSVariableObject.h:

(JSVariableObject):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashTable::entry):
(JSC):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueSlot):
(JSC::getStaticValueDescriptor):
(JSC::lookupPut):

  • runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):

  • runtime/MathObject.h:

(MathObject):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

  • runtime/NumberConstructor.cpp:

(JSC):
(JSC::NumberConstructor::finishCreation):
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
(JSC::NumberConstructor::put):
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

  • runtime/NumberConstructor.h:

(NumberConstructor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:

(NumberPrototype):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

  • runtime/ObjectConstructor.h:

(ObjectConstructor):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

  • runtime/PropertySlot.h:

(PropertySlot):
(JSC::PropertySlot::getValue):

  • runtime/RegExpConstructor.cpp:

(JSC):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::RegExpConstructor::put):

  • runtime/RegExpConstructor.h:

(RegExpConstructor):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::defineOwnProperty):

  • runtime/RegExpObject.cpp:

(JSC):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::deleteProperty):
(JSC::RegExpObject::defineOwnProperty):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):
(JSC::RegExpObject::put):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:

(RegExpPrototype):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deleteProperty):

  • runtime/StrictEvalActivation.h:

(StrictEvalActivation):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::finishCreation):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:

(StringConstructor):

  • runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::put):
(JSC::StringObject::defineOwnProperty):
(JSC::StringObject::deleteProperty):

  • runtime/StringObject.h:

(StringObject):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):

  • runtime/StringPrototype.h:

(StringPrototype):

  • runtime/Structure.cpp:

(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::get):

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):
(WebCore::objectToStringFunctionGetter):

  • bindings/js/JSDOMBinding.h:

(WebCore):
(WebCore::propertyNameToString):
(WebCore::propertyNameToAtomicString):

  • bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::canGetItemsForName):
(WebCore::JSDOMMimeTypeArray::nameGetter):

  • bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::canGetItemsForName):
(WebCore::JSDOMPluginArray::nameGetter):

  • bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::canGetItemsForName):
(WebCore::JSDOMPlugin::nameGetter):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putDirectVirtual):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLAppletElement::putDelegate):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLEmbedElement::putDelegate):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
(WebCore::JSHTMLObjectElement::putDelegate):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::putDelegate):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
(WebCore::runtimeObjectCustomPut):

  • bindings/js/JSPluginElementFunctions.h:

(WebCore):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/c/c_class.h:

(CClass):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::finishCreation):
(JSC::Bindings::CInstance::getMethod):

  • bridge/c/c_instance.h:

(CInstance):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/jsc/JavaClassJSC.h:

(JavaClass):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::create):
(JavaRuntimeMethod::finishCreation):

  • bridge/jni/jsc/JavaInstanceJSC.h:

(JavaInstance):

  • bridge/jsc/BridgeJSC.h:

(Class):
(JSC::Bindings::Class::fallbackObject):
(JSC::Bindings::Instance::setValueOfUndefinedField):
(Instance):
(JSC::Bindings::Instance::getOwnPropertySlot):
(JSC::Bindings::Instance::getOwnPropertyDescriptor):
(JSC::Bindings::Instance::put):

  • bridge/objc/objc_class.h:

(ObjcClass):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
(JSC::Bindings::ObjcClass::fallbackObject):

  • bridge/objc/objc_instance.h:

(ObjcInstance):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::finishCreation):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):
(JSC::Bindings::ObjcFallbackObjectImp::propertyName):
(ObjcFallbackObjectImp):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
(JSC::Bindings::ObjcFallbackObjectImp::put):
(JSC::Bindings::callObjCFallbackObject):
(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::deleteProperty):

  • bridge/runtime_array.h:

(RuntimeArray):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::finishCreation):
(JSC::RuntimeMethod::lengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::create):
(RuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::deleteProperty):

  • bridge/runtime_object.h:

(RuntimeObject):

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.h:

(ProxyInstance):

  • Plugins/Hosted/ProxyInstance.mm:

(ProxyClass):
(WebKit::ProxyClass::methodsNamed):
(WebKit::ProxyClass::fieldNamed):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::finishCreation):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::finishCreation):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):
(JSNPMethod):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(JSNPObject):

5:28 PM Changeset in webkit [116827] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

use after free in WebCore::RenderObject::document
​https://bugs.webkit.org/show_bug.cgi?id=84891

Patch by David Barton <Dave Barton> on 2012-05-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderMathMLFenced::addChild() to use the beforeChild parameter. When beforeChild
is 0, insert child renderers before the closing fence, which might not be the same as
this->lastChild(), e.g. possibly due to anonymous blocks or generated content.

Tests: mathml/presentation/mfenced-add-child1-expected.html

mathml/presentation/mfenced-add-child1.html
mathml/presentation/mfenced-add-child2-expected.html
mathml/presentation/mfenced-add-child2.html

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:

(RenderMathMLFenced):

LayoutTests:

  • mathml/presentation/mfenced-add-child1-expected.html: Added.
  • mathml/presentation/mfenced-add-child1.html: Added.
  • mathml/presentation/mfenced-add-child2-expected.html: Added.
  • mathml/presentation/mfenced-add-child2.html: Added.
5:17 PM Changeset in webkit [116826] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

5:14 PM Changeset in webkit [116825] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Do a DEPS roll per build failure caused by r116810.

See ​http://webkitmemes.tumblr.com/post/21734202168/the-solution-to-any-chromium-problem for the rationale.

  • DEPS:
5:09 PM Changeset in webkit [116824] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Can't scroll on webpage after following links from Blogger
​https://bugs.webkit.org/show_bug.cgi?id=86274
<rdar://problem/11431352>

Reviewed by Beth Dakin.

When committing a new scroll layer, make sure to reset the scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):

4:57 PM Changeset in webkit [116823] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

[TextureMapper] Support drawing debug borders
​https://bugs.webkit.org/show_bug.cgi?id=86237

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-05-11
Reviewed by Noam Rosenthal.

No new tests. This is the implementation of an interactive debugging
feature.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayer::create): Moved this to the top of the file to
reduce contention for the coveted last spot in the file. This also
follows the pattern used in many WebCore files of having the factories
at the top.
(WebCore::GraphicsLayerTextureMapper::setDebugBorder): Added this
plumbing.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added

plumbing.

  • platform/graphics/texmap/TextureMapper.h: Ditto.
  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
Initialize the new member.
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper): When
debug borders are enabled call the new drawBorder method on the TM.
(WebCore::TextureMapperTiledBackingStore::setDebugBorder): Added this
plumbing.

  • platform/graphics/texmap/TextureMapperBackingStore.h: Added plumbing

and members to store debug border states. This is necessary because of
the when painting there is no handle on the GraphicsLayers.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRect): Factored out the common bits of
drawTexture and drawBorder into this helper.
(WebCore::TextureMapperGL::drawBorder): Added this method, which works
very similarly to drawTexture, but uses a different shader program and
must also set the line width and color.
(WebCore::TextureMapperGL::drawTexture): Factored out the bits that
are shared with drawRect.

  • platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL): Added the new method declarations.

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::TextureMapperImageBuffer::drawBorder): Added an empty
implementation. Later we can add an implementation for the ImageBuffer
TM.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): When updating the
backing store send the debug border information through.
(WebCore::TextureMapperLayer::syncCompositingStateSelf): When updating
the layer state, also update the debug indicators. This is required to
initialize the debug border values for the layer.
(WebCore::TextureMapperLayer::setDebugBorder): Added this plumbing.

  • platform/graphics/texmap/TextureMapperLayer.h: Ditto.
  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Added a

solid color shader that doesn't care about texture coordinates or
opacity values.
(WebCore::TextureMapperShaderManager::solidColorProgram): Added. This
is a shorter getter for the solid color program that doesn't require
casting from the caller.
(WebCore::TextureMapperShaderManager::getShaderProgram): Added support
for the solid color program.
(WebCore::TextureMapperShaderProgramSolidColor::create): Added.
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::vertexShaderSource):
Ditto.
(WebCore::TextureMapperShaderProgramSolidColor::fragmentShaderSource):
Ditto.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramSolidColor): Added.
(WebCore::TextureMapperShaderProgramSolidColor::colorVariable): Added.

4:50 PM Changeset in webkit [116822] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rolling out r116659.

Causes ASSERT failures on bots.

Rubber stamped by Geoff Garen.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC):
(JSC::SlotVisitor::copyAndAppend):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):
(MarkStack):

  • runtime/JSString.h:

(JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit):
(JSC::JSRopeString::finishCreation):

4:40 PM Changeset in webkit [116821] by timothy@apple.com
  • 7 edits
    3 adds in trunk

Instrument timer function calls so they show up in the Web Inspector Timeline.

​https://webkit.org/b/86173

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-timer.html

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext): Wrap the call with JSMainThreadExecState::instrumentFunctionCall
and InspectorInstrumentation::didCallFunction.

LayoutTests:

  • inspector/timeline/timeline-injected-script-eval-expected.txt: Updated for the blocked scriptName and scriptLine.
  • inspector/timeline/timeline-script-tag-1-expected.txt: Updated for the blocked lineNumber.
  • inspector/timeline/timeline-script-tag-2-expected.txt: Ditto.
  • inspector/timeline/timeline-test.js: Block scriptName, scriptLine, lineNumber and timerId.
  • inspector/timeline/timeline-timer-expected.txt: Added.
  • inspector/timeline/timeline-timer.html: Added.
  • platform/chromium/inspector/timeline/timeline-timer-expected.txt: Added.
4:20 PM Changeset in webkit [116820] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit/mac

<rdar://problem/11361907> and ​https://bugs.webkit.org/show_bug.cgi?id=86265
REGRESSION(r104885): Images missing from printed YummySoup! recipes

We thought clients were passing paths as URLs.
It turns out it was more likely they were passing file: URLs with the file: scheme removed.
And that jives perfectly with the behavior change caused by r104885.

Reviewed by Alexey Proskuryakov.

Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
to create the new URL simply by appending "file:":

  • Misc/WebNSURLExtras.h:
  • Misc/WebNSURLExtras.mm:

(-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the

existing URL string.

(-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
(-[WebFrame loadHTMLString:baseURL:]):
(-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):

4:08 PM Changeset in webkit [116819] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin
​https://bugs.webkit.org/show_bug.cgi?id=86240

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-11
Reviewed by Martin Robinson.

Free the output received from the g_spawn_sync().

  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

4:07 PM Changeset in webkit [116818] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Appease thread verifier when dealing with the JSC API's shared VM
​https://bugs.webkit.org/show_bug.cgi?id=86268

Reviewed by Geoffrey Garen.

If we're the shared VM, just disable the verifier. This makes debug builds
livable against non-webkit clients.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

4:03 PM Changeset in webkit [116817] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Let libwebkit.dylib link in Debug/components build
​https://bugs.webkit.org/show_bug.cgi?id=86244

Reviewed by James Robinson.

In static builds, this was not needed because the targets depending on
'webkit' already link in QuartzCore. In Release components builds, it wasn't
needed because they are built with -dead_strip, which stripped the referencing
code.

  • WebCore.gyp/WebCore.gyp:
3:58 PM Changeset in webkit [116816] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a Chromium test expectation now that the regression is fixed in r116814.

  • platform/chromium/test_expectations.txt:
3:55 PM Changeset in webkit [116815] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r116802.
​http://trac.webkit.org/changeset/116802
​https://bugs.webkit.org/show_bug.cgi?id=86260

This patch causes compiling error to chromium builds
(Requested by jianli_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [116814] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression fix after r116798.

We need to return true for the html element in the design mode
in which case parentNode() is editable and is not a body element.

  • dom/Node.cpp:

(WebCore::Node::isRootEditableElement):

3:37 PM Changeset in webkit [116813] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT memory allocator is not returning memory to the OS on Darwin
​https://bugs.webkit.org/show_bug.cgi?id=86047

Reviewed by Geoff Garen.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

3:30 PM Changeset in webkit [116812] by pilgrim@chromium.org
  • 10 edits
    2 copies in trunk/Source

[Chromium] Move createLocalStorageNamespace to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=85766

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):

  • chromium/public/WebStorageArea.h: Added.

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • chromium/public/WebStorageNamespace.h: Added.

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebStorageArea.h:
  • public/WebStorageNamespace.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::blobRegistry):

  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::localStorageNamespace):

3:19 PM Changeset in webkit [116811] by jamesr@google.com
  • 4 edits
    3 moves in trunk/Source

[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
​https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Adam Barth.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium on top of
the Platform interface WebGraphicsContext3D. This moves the implementation support code from WebKit/chromium/src
to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore interfaces and
allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

  • WebCore.gypi:
  • platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.

(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.

(WebKit):
(WebCore):
(GraphicsContext3DPrivate):

Source/WebKit/chromium:

  • WebKit.gyp:
3:18 PM Changeset in webkit [116810] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Expose WebPluginContainer of WebPlugin to embedder
​https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

  • public/WebPlugin.h:

(WebPlugin):
(WebKit::WebPlugin::container):

3:17 PM Changeset in webkit [116809] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Clarified JSGlobalData (JavaScript VM) lifetime
​https://bugs.webkit.org/show_bug.cgi?id=85142

Reviewed by Alexey Proskuryakov.

(Follow-up fix.)

  • API/JSContextRef.cpp:

(JSGlobalContextCreate): Restored some code I removed because I misread an #ifdef.
(We don't need to test BUILDING_ON_LEOPARD, but we still need the linked-on
test, because apps might have been linked on older OS's.)

2:53 PM Changeset in webkit [116808] by tomz@codeaurora.org
  • 6 edits
    35 adds in trunk/LayoutTests

Integrate IETC CSS : xml namespace tests
​https://bugs.webkit.org/show_bug.cgi?id=86144

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-05-11
Reviewed by Adam Barth.

Integrating 17 IETC xml namespace tests, along with associated
reference tests.

  • ietestcenter/css3/namespaces/declaring-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/declaring-001.xml: Added.
  • ietestcenter/css3/namespaces/prefix-007-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-007.xml: Added.
  • ietestcenter/css3/namespaces/prefix-008-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-008.xml: Added.
  • ietestcenter/css3/namespaces/prefix-009-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-009.xml: Added.
  • ietestcenter/css3/namespaces/prefix-010-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-010.xml: Added.
  • ietestcenter/css3/namespaces/prefix-011-expected.xml: Added.
  • ietestcenter/css3/namespaces/prefix-011.xml: Added.
  • ietestcenter/css3/namespaces/qualifiedNames-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/qualifiedNames-001.xml: Added.
  • ietestcenter/css3/namespaces/scope-003-expected.xml: Added.
  • ietestcenter/css3/namespaces/scope-003.xml: Added.
  • ietestcenter/css3/namespaces/syntax-016-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-016.xml: Added.
  • ietestcenter/css3/namespaces/syntax-017-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-017.xml: Added.
  • ietestcenter/css3/namespaces/syntax-018-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-018.xml: Added.
  • ietestcenter/css3/namespaces/syntax-019-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-019.xml: Added.
  • ietestcenter/css3/namespaces/syntax-020-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-020.xml: Added.
  • ietestcenter/css3/namespaces/syntax-021-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-021.xml: Added.
  • ietestcenter/css3/namespaces/syntax-022-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-022.xml: Added.
  • ietestcenter/css3/namespaces/syntax-023-expected.xml: Added.
  • ietestcenter/css3/namespaces/syntax-023.xml: Added.
  • ietestcenter/css3/namespaces/terminology-001-expected.xml: Added.
  • ietestcenter/css3/namespaces/terminology-001.xml: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
2:49 PM Changeset in webkit [116807] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark 1 crashed test for chromium mac.

  • platform/chromium/test_expectations.txt:
2:40 PM Changeset in webkit [116806] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ImageSkia.cpp does not conform to style guidelines
​https://bugs.webkit.org/show_bug.cgi?id=86219

Patch by Keyar Hood <​keyar@chromium.org> on 2012-05-11
Reviewed by Stephen White.

No tests as this is purely style changees.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::TransformDimensions):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

2:36 PM Changeset in webkit [116805] by jianli@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline one test for chromium mac.

  • platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png: Added.
2:28 PM Changeset in webkit [116804] by Philippe Normand
  • 53 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after fonts update in r116778.

  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/gtk/fast/dynamic/text-combine-expected.txt:
  • platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/gtk/fast/ruby/nested-ruby-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt:
  • platform/gtk/fast/text/emphasis-vertical-expected.txt:
  • platform/gtk/fast/text/international/001-expected.txt:
  • platform/gtk/fast/text/international/002-expected.txt:
  • platform/gtk/fast/text/international/003-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
  • platform/gtk/fast/text/international/text-spliced-font-expected.txt:
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt:
  • platform/gtk/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-simple-expected.txt:
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt:
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/dom/altGlyph-dom-expected.txt:
  • platform/gtk/svg/text/text-fonts-01-t-expected.txt:
2:24 PM Changeset in webkit [116803] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix after ​http://trac.webkit.org/changeset/116799.

  • rendering/RenderLayerBacking.cpp:
2:16 PM Changeset in webkit [116802] by commit-queue@webkit.org
  • 7 edits in trunk

[chromium] Compute the best target node on a GestureTap event
​https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

Will be using the tests in the touchadjustment/ directory.

  • WebCore.gypi:

Include TouchAdjustment.* files.

Source/WebKit/chromium:

  • features.gypi:

Enable the touch adjustment code by default.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.

2:12 PM Changeset in webkit [116801] by commit-queue@webkit.org
  • 8 edits
    4 deletes in trunk

Unreviewed, rolling out r116498.
​http://trac.webkit.org/changeset/116498
​https://bugs.webkit.org/show_bug.cgi?id=86251

Causes crashes in major sites and security issues (Requested
by schenney on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::recursiveUpdateLayoutAttributes):
(WebCore::RenderSVGText::layoutAttributesChanged):
(WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
(WebCore::RenderSVGText::invalidateTextPositioningElements):
(WebCore::recursiveUpdateScaledFont):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
(WebCore):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):
(WebCore::RenderSVGText::layoutAttributes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

  • svg/text/add-tspan-position-bug-expected.html: Removed.
  • svg/text/add-tspan-position-bug.html: Removed.
  • svg/text/modify-tspan-position-bug-expected.html: Removed.
  • svg/text/modify-tspan-position-bug.html: Removed.
1:24 PM Changeset in webkit [116800] by kevino@webkit.org
  • 4 edits in trunk

[wx] Unreviewed build fixes for recent trunk changes and 32-bit ld *nix builds.

1:16 PM Changeset in webkit [116799] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

FrameView->m_lastPaintTime is not updated in the tiled drawing case
​https://bugs.webkit.org/show_bug.cgi?id=86246
<rdar://problem/11248475>

Reviewed by Simon Fraser.

Update FrameView's m_lastPaintTime from RenderLayerBacking::paintContents
if the RenderLayerBacking is backing a tiled drawing layer.

In the future we might want to consider updating m_lastPaintTime when any
compositing layer is painted into, but this change gets us on par with the
non-tiled-drawing case as it stands now.

No new tests.

  • page/FrameView.h:

(WebCore::FrameView::setLastPaintTime):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

1:09 PM Changeset in webkit [116798] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Add helper function for node()->rootEditableElement() == node()
​https://bugs.webkit.org/show_bug.cgi?id=86217

Patch by Shezan Baig <​shezbaig.wk@gmail.com> on 2012-05-11
Reviewed by Ryosuke Niwa.

Added Node::isRootEditableElement and updated existing code that did
(node->rootEditableElement() == node) to use isRootEditableElement
instead.

No new tests. No change in behavior.

  • dom/Node.cpp:

(WebCore::Node::isRootEditableElement):
(WebCore):

  • dom/Node.h:

(Node):
Added new helper function.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • page/FocusController.cpp:

(WebCore::FocusController::setFocusedNode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hasLineIfEmpty):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::addOverflowFromInlineChildren):
Updates to existing code to use the new helper function.

1:07 PM Changeset in webkit [116797] by shawnsingh@chromium.org
  • 5 edits
    2 adds in trunk/Source

[chromium] Create WebTransformationMatrix interface for chromium platform
​https://bugs.webkit.org/show_bug.cgi?id=86049

Reviewed by James Robinson.

Source/Platform:

  • Platform.gyp/Platform.gyp:
  • Platform.gypi:
  • chromium/public/WebTransformationMatrix.h: Added.

(WebCore):
(WebKit):
(WebTransformationMatrix):

Source/WebCore:

This patch creates a WebTransformationMatrix interface. It will
remain unused at the moment, until (a) unit tests are created
and (b) when we are ready to make a brief transition of all other
chromium code to use it.

  • WebCore.gypi:
  • platform/chromium/support/WebTransformationMatrix.cpp: Added.

(WebKit):
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::operator*):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

12:49 PM Changeset in webkit [116796] by kling@webkit.org
  • 15 edits
    1 move in trunk/Source/WebKit2

WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread.
<​http://webkit.org/b/86143>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

To avoid spins beneath PluginInfoStore::getPluginInfo(), do this work on a secondary
thread in the UIProcess.

  • Shared/APIObject.h:

Made APIObject a ThreadSafeRefCounted. In the context of this patch, this is to
be able to dispatch bound Functions on WebContext.

  • WebProcess/mac/KeychainItemShimMethods.mm:

(WebKit::responseMap):

  • WebProcess/mac/SecItemShimMethods.mm:

(WebKit::responseMap):

  • WebKit2.xcodeproj/project.pbxproj:
  • Shared/BlockingResponseMap.h:

(BlockingResponseMap):
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

Renamed from Source/WebKit2/WebProcess/mac/KeychainShimResponseMap.h.
Generalize this somewhat since it's useful in more than just the keychain scenario.
This can/should be generalized further, but that's a topic for another patch.

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):

Slap a mutex on the PluginInfoStore since it can now be called from both the
main thread (via WKFrameCanShowMIMEType) and the GetPlugin work queue.

  • UIProcess/WebContext.messages.in:
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):
(WebKit::WebContext::getPlugins):
(WebKit::WebContext::didReceiveMessageOnConnectionWorkQueue):

Make GetPlugins a DispatchOnConnectionQueue message and execute it on a new
plug-in work queue. This effectively makes the GetPlugin call asynchronous.
On Mac, the built-in PDF reader is still registered on the main thread as that
ends up calling into localizedString().

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didGetPlugins):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add a DidGetPlugins message to WebProcess. This is passed directly to the handler
in WebPlatformStrategies.cpp.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::responseMap):
(WebKit::handleDidGetPlugins):
(WebKit::generateRequestID):
(WebKit::WebPlatformStrategies::populatePluginCache):

Use a BlockingResponseMap to block the WebProcess main thread until the UIProcess
responds with DidGetPlugins.

12:45 PM Changeset in webkit [116795] by Alexandru Chiculita
  • 8 edits
    5 adds in trunk

[CSS Shaders] Make CSS Shaders render to texture framebuffers
​https://bugs.webkit.org/show_bug.cgi?id=85113

Reviewed by Dean Jackson.

Source/WebCore:

Added the required members to store the framebuffer, the texture and the depth buffer. Also removed the m_drawingBuffer
because context->readPixels doesn't require one anymore.

ReadPixels is not flipping the result, so I've also removed the flipping projection matrix that was specific only to Chromium.

Added a test to check that colors are not switched and the resulting image is not mirrored.

Test: css3/filters/custom/effect-color-check.html

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::~FECustomFilter):
(WebCore):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

LayoutTests:

Added a test to check that colors are not switched and the resulting image is not mirrored.

  • css3/filters/custom/effect-color-check-expected.png: Added.
  • css3/filters/custom/effect-color-check-expected.txt: Added.
  • css3/filters/custom/effect-color-check.html: Added.
  • css3/filters/resources/color-fill.fs: Added.
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:40 PM Changeset in webkit [116794] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled string
​https://bugs.webkit.org/show_bug.cgi?id=86170

Reviewed by Andreas Kling.

The string we are passing to the TextRun constructor needs to stay alive for longer so revert back to the old
behavior where we store it as a member variable.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):

12:21 PM Changeset in webkit [116793] by commit-queue@webkit.org
  • 29 edits in trunk/LayoutTests

[EFL] Tests needs rebaselining after r116776
​https://bugs.webkit.org/show_bug.cgi?id=86227

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-11

  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/efl/fast/dynamic/text-combine-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.png:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/efl/fast/ruby/nested-ruby-expected.png:
  • platform/efl/fast/ruby/nested-ruby-expected.txt:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/efl/fast/text/backslash-to-yen-sign-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/efl/fast/text/emphasis-combined-text-expected.png:
  • platform/efl/fast/text/emphasis-combined-text-expected.txt:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/efl/fast/text/justify-ideograph-simple-expected.png:
  • platform/efl/fast/text/justify-ideograph-simple-expected.txt:
  • platform/efl/fast/text/justify-ideograph-vertical-expected.png:
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.png:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
11:56 AM Changeset in webkit [116792] by Simon Fraser
  • 6 edits
    2 adds in trunk

Source/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame
​https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

A DisplayRefreshMonitor would keep its CVDisplayLink alive for as long
as it had clients, and the client is the ScriptedAnimationController, which
lives on the document. So a single requestAnimationFrame call would kick
off a CVDisplayLink which lived until the document was destroyed.

Fix by having the DisplayRefreshMonitor kill itself if the CVDisplayLink
fires for 10 times with no scheduled callbacks (to avoid creation/deletion
thrash on pages that call requestAnimationFrames with short setTimeouts,
as some do).

Use a HashMap in DisplayRefreshMonitorManager for the set of DisplayRefreshMonitor,
with the displayID as the key (using UnsignedWithZeroKeyHashTraits<uint64_t> since
we want to allow for 0 to be a valid displayID).

Use a HashSet in DisplayRefreshMonitor for the client set, so that we don't have to
worry about adding clients twice.

Also fix a possible crash when the only client of a DisplayRefreshMonitor
was removed from inside the callback by making DisplayRefreshMonitor ref-counted,
with a protector.

Test: fast/animation/request-animation-frame-detach-element2.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize m_unscheduledFireCount
(WebCore::DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread): Renamed
from refreshDisplayOnMainThread, since it doesn't just refresh the display.
(WebCore::DisplayRefreshMonitor::addClient): No longer inline.
(WebCore::DisplayRefreshMonitor::removeClient): No longer inline.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Keep track of m_unscheduledFireCount,
which we used to kill this monitor if it has been idle for a while.
Use a RefPtr<DisplayRefreshMonitor> to prevent deletion while running the callback.
Copy the clients to a vector to protect against mutating the set while enumerating it.
Notify the DisplayRefreshMonitorManager when we're done, so that it can decide
to delete inactive monitors.

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient): find or allocate
a DisplayRefreshMonitor for a given client.
(WebCore::DisplayRefreshMonitorManager::registerClient): Simplified by use of HashMap.
(WebCore::DisplayRefreshMonitorManager::unregisterClient): Ditto.
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation): Ditto. Uses
ensureMonitorForClient() since an earlier inactive monitor may have been removed.
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh): Remove inactive
monitors.

  • platform/graphics/DisplayRefreshMonitor.h: Make DisplayRefreshMonitor

ref-counted, to make it easier to avoid deletion while it's on the stack.
(WebCore::DisplayRefreshMonitor::create):
(DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::shouldBeTerminated):
(DisplayRefreshMonitorManager):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Attempt to

keep things building.
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
to give the manager a chance to kill this monitor.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayLinkFired): Don't bail early
if not scheduled; we want to call handleDisplayRefreshedNotificationOnMainThread(),

LayoutTests: CVDisplayLink keeps running after a single requestAnimationFrame
​https://bugs.webkit.org/show_bug.cgi?id=86174

Reviewed by Sam Weinig.

Test removing a frame inside its requestAnimationFrame callback.

  • fast/animation/request-animation-frame-detach-element2-expected.txt: Added.
  • fast/animation/request-animation-frame-detach-element2.html: Added.
11:50 AM Changeset in webkit [116791] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentationModel into ResourceBinding
​https://bugs.webkit.org/show_bug.cgi?id=86234

Reviewed by Vsevolod Vlasov.

Simple move refactoring.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.canEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):

11:48 AM Changeset in webkit [116790] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove RenderLayer::m_scrollOverflow
​https://bugs.webkit.org/show_bug.cgi?id=86226

Reviewed by Simon Fraser.

No expected change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeScrollDimensions):
Added 2 local variables to compute the left / top scrollable overflows.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset):
Returned m_scrollOffset directly as this is what the old code was doing by adding
m_scrollOrigin then adding m_scrollOverflow (which was set to -m_scrollOrigin in
computeScrollDimensions).

(RenderLayer::m_scrollOffset): Improved the comment about what m_scrollOffset is.

11:31 AM Changeset in webkit [116789] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel.
​https://bugs.webkit.org/show_bug.cgi?id=86229

Reviewed by Vsevolod Vlasov.

This change also starts tracking messages along with the live location changes.

Tested with script-formatter-console.html.

  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
(WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
(WebInspector.PresentationConsoleMessage):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

11:21 AM Changeset in webkit [116788] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Simplify FloatingObject by removing unnecessary convenience methods.
​https://bugs.webkit.org/show_bug.cgi?id=86163

Reviewed by Eric Seidel.

Simplify the pixel snapping in FloatingObject by getting rid of a bunch
of convenience methods.

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):

  • rendering/RenderBlock.h:

(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

11:10 AM Changeset in webkit [116787] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline should fetch stale expectations :)
​https://bugs.webkit.org/show_bug.cgi?id=86231

Unreviewed, build fix.

This change reverts r115492 and goes back to fetching individual
baselines from the layout tests directory, rather than fetching
entire zip files. The performance hit over networks for people
far away from the bots has turned out to be severe, so we need a
better solution to this.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(RebaselineTest._file_name_for_expected_result):
(RebaselineTest._rebaseline_test):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

11:04 AM Changeset in webkit [116786] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

[chromium] Ensure that animations continue to run when transform-style is changed
​https://bugs.webkit.org/show_bug.cgi?id=83283

Source/WebCore:

Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

Test: animations/change-transform-style-during-animation.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):

Source/WebKit/chromium:

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/GraphicsLayerChromiumTest.cpp: Added.

(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

LayoutTests:

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.

  • animations/change-transform-style-during-animation-expected.png: Added.
  • animations/change-transform-style-during-animation-expected.txt: Added.
  • animations/change-transform-style-during-animation.html: Added.
10:57 AM Changeset in webkit [116785] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
​https://bugs.webkit.org/show_bug.cgi?id=86232

Reviewed by Gavin Barraclough.

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.

10:28 AM Changeset in webkit [116784] by tomz@codeaurora.org
  • 23 edits in trunk/LayoutTests

[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=85596

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-05-11
Reviewed by Csaba Osztrogonác.

Reference tests originally assumed "background: green" was identical
to the green used in the pngs used by the feature tests. On local builds
of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac
and QT bots however, it became clear this was an invalid assumption. I've
re-written the reference tests to use the original pngs as appropriate.
I have reproduced the failures on a Mac & Qt32 and verified that the newly
re-written reference tests behave properly now.

  • ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
  • ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
10:09 AM Changeset in webkit [116783] by tommyw@google.com
  • 3 edits
    1 add in trunk

MediaStream API: Fix a reference counting issue in UserMediaRequest
​https://bugs.webkit.org/show_bug.cgi?id=86210

Reviewed by Abhishek Arya.

.:

  • ManualTests/user-media-request-crash.html: Added.

Source/WebCore:

When contextDestroyed() is called on UserMediaRequest it does a callback to the
page client. If the receiving code clears their stored copy the UserMediaRequest
object is destroyed in the middle of the call.

Currently only testable manually against chrome, preferably with asan turned on.
I have added a manual test that verifies the fix, but I have started work
to make DumpRenderTree able to test this and many other things. The first patch is here:
​https://bugs.webkit.org/show_bug.cgi?id=86215

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::contextDestroyed):

10:05 AM Changeset in webkit [116782] by commit-queue@webkit.org
  • 9 edits in trunk/Source

split MediaPlayer::enterFullscreen into 2 seperate functions
​https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin <​qinmin@google.com> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

In WebCore, we splitted bool enterFullscreen() into two seperate calls:
void enterFullscreen() and bool canEnterFullscreen()
This is the change in the chromium part that we needed to support the WebCore change
No behavior change, just refactoring.

  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):

9:51 AM Changeset in webkit [116781] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
​https://bugs.webkit.org/show_bug.cgi?id=86212

Unreviewed EFL gardening.

Test expectations update, moving related bugs from Skipped list to test_expectations.txt.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2012-05-11

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt: adding new bug regarding to missing contextClick implementation.
9:46 AM Changeset in webkit [116780] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: move breakpoint manager from debuggerPresentationModel to WebInspector.
​https://bugs.webkit.org/show_bug.cgi?id=86220

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now that breakpoint manager does not depend on the source mapping instance from the
debugger presentation model, it can be moved out.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/scripts-panel.html:
9:41 AM Changeset in webkit [116779] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
​https://bugs.webkit.org/show_bug.cgi?id=85893

Patch by David Reveman <​reveman@chromium.org> on 2012-05-11
Reviewed by Adrienne Walker.

Source/WebCore:

Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

9:41 AM Changeset in webkit [116778] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
​https://bugs.webkit.org/show_bug.cgi?id=86198

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
Mincho / Gothic fonts to display Japanese and Chinese characters.

  • gtk/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that GTK's
DumpRenderTree is able to display Chinese characters.

  • platform/gtk/svg/batik/text/verticalText-expected.png:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
9:33 AM Changeset in webkit [116777] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Two of the touch-adjustment tests are flaky.
​https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Move the touch points and text so the tests are more stable.

  • touchadjustment/event-triggered-widgets-expected.txt:
  • touchadjustment/event-triggered-widgets.html:
  • touchadjustment/touch-inlines.html:
9:28 AM Changeset in webkit [116776] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][DRT] SVG Batik test fails to display Chinese characters
​https://bugs.webkit.org/show_bug.cgi?id=84461

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Martin Robinson.

Tools:

Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
new Kochi Mincho / Gothic fonts to display Japanese and Chinese
characters.

  • DumpRenderTree/efl/CMakeLists.txt:
  • efl/jhbuild.modules:

LayoutTests:

Rebaseline svg/batik/text/verticalText.svg now that EFL's
DumpRenderTree is able to display Chinese characters.

  • platform/efl/svg/batik/text/verticalText-expected.png:
  • platform/efl/svg/batik/text/verticalText-expected.txt:
9:13 AM Changeset in webkit [116775] by pfeldman@chromium.org
  • 26 edits
    1 delete in trunk

Web Inspector: pass source mapping into UISourceCode's constructor; move formatting outside mapping.
​https://bugs.webkit.org/show_bug.cgi?id=86099

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This changes moves formatting out of the source mapping machinery.
As a result, it removes most of the DebuggerPresentation's mapping-related code as well
as most of the raw source code's code.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Breakpoint):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.setStatus):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.fireContentAvailable):
(WebInspector.JavaScriptSource.prototype.setFormatted.if):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
(WebInspector.JavaScriptSource.prototype.togglingFormatter):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.overrideLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.FormatterSourceMapping):
(WebInspector.FormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.FormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.IdentityFormatterSourceMapping):
(WebInspector.IdentityFormatterSourceMapping.prototype.originalToFormatted):
(WebInspector.IdentityFormatterSourceMapping.prototype.formattedToOriginal):
(WebInspector.FormatterSourceMappingImpl):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._handleUISourceCodeAdded):
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.mimeType):
(WebInspector.UISourceCode.prototype.content):
(WebInspector.UISourceCode.prototype.fireContentAvailable):
(WebInspector.UISourceCode.prototype.contentLoaded):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/pause-in-inline-script.html:
  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/resources/test-navigation.html: Removed.
  • inspector/debugger/script-formatter-breakpoints-expected.txt:
  • inspector/debugger/script-formatter-breakpoints.html:
  • inspector/debugger/script-formatter-console.html:
  • inspector/debugger/selected-call-frame-after-formatting-source.html:
8:51 AM Changeset in webkit [116774] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][DRT] Input Attribute Placeholder RefTests failing
​https://bugs.webkit.org/show_bug.cgi?id=85603

Unreviewed, build fix for EFL.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-05-11

  • platform/efl/RenderThemeEfl.cpp:
8:51 AM Changeset in webkit [116773] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org

Try to make spacing of fine print items in lower left nicer looking.

  • css/main.css:

(#notice, #trademark, #terms): Changed top margin to 10px.
(#notice): Put 30px margin here.

8:48 AM Changeset in webkit [116772] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org

CSS tweak needed for the trademark terms of use.

  • css/main.css:

(#notice, #trademark, #terms): Added #trademark.

8:46 AM Changeset in webkit [116771] by commit-queue@webkit.org
  • 9 edits in trunk

Web Inspector: Remove support of combined nodes and edges serialization schema.
​https://bugs.webkit.org/show_bug.cgi?id=86209

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-05-11
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get _nodes):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest._postprocessHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
8:40 AM Changeset in webkit [116770] by Darin Adler
  • 3 edits in trunk/Websites/webkit.org

Add a link to WebKit trademark terms of use, other small website changes
​https://bugs.webkit.org/show_bug.cgi?id=86112

Reviewed by Dan Bernstein.

  • contact.html: Use RIGHT SINGLE QUOTATION MARK instead of APOSTROPHE as appropriate.

Fixed awkward use of the phrase "per itself" and the use of "intent" where "intend"
was intended.

  • nav.inc: Added mention of the WebKit trademark and a link to the trademark terms

of use on the macosforge.org terms of use page.

8:23 AM Changeset in webkit [116769] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK 64-bit Debug bot fix attempt.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._get_gdb_output): Ignore unicode decoding errors when
processing gdb output.

8:05 AM Changeset in webkit [116768] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: add Profiler.getHeapObjectId command
​https://bugs.webkit.org/show_bug.cgi?id=86211

Reviewed by Pavel Feldman.

Added Profiler.getHeapObjectId command to the protocol which allows to convert remote
object id to heap snapshot object id.

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):

  • bindings/js/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::findObjectById):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getHeapObjectId):
(WebCore):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

7:11 AM Changeset in webkit [116767] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Qt support for new layout types.
​https://bugs.webkit.org/show_bug.cgi?id=85607

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Adds similar Qt support to FractionalLayout classes as Qt has for
FloatSomething and IntSomething classes. This means Qt code can stay
unchanged from after the redefinition of Layout classes.

No new functionality. No new tests.

  • Target.pri:
  • platform/FractionalLayoutUnit.h:

(WebCore::operator<<):
(WebCore::operator>>):

  • platform/graphics/FractionalLayoutPoint.h:

(FractionalLayoutPoint):

  • platform/graphics/FractionalLayoutRect.h:

(FractionalLayoutRect):

  • platform/graphics/FractionalLayoutSize.h:

(FractionalLayoutSize):

  • platform/graphics/qt/FractionalLayoutPointQt.cpp: Added.

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::operator QPointF):

  • platform/graphics/qt/FractionalLayoutRectQt.cpp: Added.

(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::operator QRectF):

  • platform/graphics/qt/FractionalLayoutSizeQt.cpp: Added.

(WebCore::FractionalLayoutSize::FractionalLayoutSize):
(WebCore::FractionalLayoutSize::operator QSizeF):

7:04 AM Changeset in webkit [116766] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Internals::touchPositionAdjustedToBestClickableNode adjust twice for scroll-offset
​https://bugs.webkit.org/show_bug.cgi?id=86205

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-11
Reviewed by Simon Hausmann.

Source/WebCore:

Remove the redundant conversion from document to window coords.

Test: touchadjustment/scroll-offset.html

  • testing/Internals.cpp:

(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):

LayoutTests:

Add test of touchPositionAdjustedToBestClickableNode with scroll-offset.

  • touchadjustment/scroll-offset-expected.txt: Added.
  • touchadjustment/scroll-offset.html: Added.
6:55 AM Changeset in webkit [116765] by tkent@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

[Chromium] Updat test expectations.

  • platform/chromium-mac-leopard/fast/block/float/032-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
6:53 AM Changeset in webkit [116764] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: load heap snapshot implementation.
​https://bugs.webkit.org/show_bug.cgi?id=86097

The idea is to have a hidden file selector control.
When the user select a context menu item or click a button
we redirect this user-action to file selector.
As result we see the standard file selector dialog.
When the user selects a file we load it's chunks and push the chunks to the worker.
The loaded snapshot can be completely unrelated to the current page.
Thats why we have to skip range selection options in Summary tab.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile): now it accepts a custom title.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._updateFilterOptions): we have to skip the profiles loaded from file because there is no guaranty t
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.HeapSnapshotProfileType.prototype.createProfile): cosmetic changes.
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype._setupWorker): a common part was extracted from load method and reused in loadFromFile.
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate): cosmetic changes.
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.canLoadFromFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.HeapProfileHeader.prototype.loadFromFile): chunk based file loader.
(WebInspector.HeapProfileHeader.prototype.loadFromFile.loadNextChunk):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.createTemporaryProfile): now it accepts a custom title.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createTemporaryProfile): now it accepts a custom title.
(WebInspector.ProfileHeader.prototype.canSaveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.saveToFile): cosmetic rename for better consistency with 'load' part.
(WebInspector.ProfileHeader.prototype.canLoadFromFile): default implementation for 'load' part.
(WebInspector.ProfileHeader.prototype.loadFromFile): default implementation for 'load' part.
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

6:49 AM Changeset in webkit [116763] by commit-queue@webkit.org
  • 16 edits in trunk

Web Intents code only supports V8
​https://bugs.webkit.org/show_bug.cgi?id=85954

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-11
Reviewed by Adam Barth.

.:

Add ENABLE_WEB_INTENTS flag to CMake.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Add necessary abstraction for js Dictionary and ScriptValue so that
the Web Intents code in WebCore compiles with JSC, not just V8.

This required changes in the JSC bindings generator to pass
callback arguments of type SerializedScriptValue as raw pointers
instead of RefPtr. This matches the change made to the V8 bindings
generator in r104531.

  • CMakeLists.txt:
  • Modules/intents/Intent.cpp:
  • Modules/intents/Intent.h:
  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::Dictionary):
(WebCore):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):

  • bindings/js/Dictionary.h:

(Dictionary):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
(WebCore):

  • bindings/js/JSDictionary.h:

(WebCore):
(WebCore::JSDictionary::initializerObject):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore):

  • bindings/js/ScriptValue.h:

(ScriptValue):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(GetNativeTypeForCallbacks):

6:42 AM Changeset in webkit [116762] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Can't type spaces in "Override User Agent" field
​https://bugs.webkit.org/show_bug.cgi?id=86202

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.isClosingKey):
(WebInspector.HelpScreen.prototype._onKeyDown):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.isClosingKey):

6:39 AM Changeset in webkit [116761] by commit-queue@webkit.org
  • 151 edits in trunk

[EFL][DRT] Input Attribute Placeholder RefTests failing
​https://bugs.webkit.org/show_bug.cgi?id=85603

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-05-11
Reviewed by Hajime Morita.

Source/WebCore:

Refrain from overriding style coloring by theme coloring.
RenderThemeEfl was always overriding colors and whitespace
handling leading to failures in reftests that verify placeholder styling
which expect the user agent stylesheet to be applied correctly
without any color overrides. Also, leave whitespace handling untouched.

No new tests, covered by existing tests. See also
the LayoutTests/ChangeLog in this commit for the required
rebaselining.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyEdjeColors):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

Source/WebKit/efl:

Removing color classes which we don't need anymore after
RenderThemeEfl.cpp is less aggressively overriding styling.

  • DefaultTheme/default.edc:

LayoutTests:

Rebaselining after we're allowing color styling of menulists,
search and text fields and textareas and after removing
whitespace handling override.

  • platform/efl/Skipped:
  • platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/efl/fast/block/float/float-avoidance-expected.txt:
  • platform/efl/fast/block/margin-collapse/103-expected.txt:
  • platform/efl/fast/css/continuationCrash-expected.txt:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/efl/fast/dom/isindex-001-expected.txt:
  • platform/efl/fast/dom/isindex-002-expected.txt:
  • platform/efl/fast/dynamic/008-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/forms/003-expected.txt:
  • platform/efl/fast/forms/004-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/efl/fast/forms/basic-buttons-expected.txt:
  • platform/efl/fast/forms/basic-inputs-expected.txt:
  • platform/efl/fast/forms/blankbuttons-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/button-positioned-expected.txt:
  • platform/efl/fast/forms/button-sizes-expected.txt:
  • platform/efl/fast/forms/button-style-color-expected.txt:
  • platform/efl/fast/forms/button-table-styles-expected.txt:
  • platform/efl/fast/forms/button-text-transform-expected.txt:
  • platform/efl/fast/forms/control-clip-overflow-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/disabled-select-change-index-expected.txt:
  • platform/efl/fast/forms/encoding-test-expected.txt:
  • platform/efl/fast/forms/fieldset-align-expected.txt:
  • platform/efl/fast/forms/file/file-input-direction-expected.txt:
  • platform/efl/fast/forms/file/file-input-disabled-expected.txt:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-align-expected.txt:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-appearance-visibility-expected.txt:
  • platform/efl/fast/forms/input-appearance-width-expected.txt:
  • platform/efl/fast/forms/input-button-sizes-expected.txt:
  • platform/efl/fast/forms/input-disabled-color-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-field-text-truncated-expected.txt:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/efl/fast/forms/input-readonly-empty-expected.txt:
  • platform/efl/fast/forms/input-spaces-expected.txt:
  • platform/efl/fast/forms/input-table-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/input-text-word-wrap-expected.txt:
  • platform/efl/fast/forms/input-type-text-min-width-expected.txt:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/input-width-expected.txt:
  • platform/efl/fast/forms/menulist-deselect-update-expected.txt:
  • platform/efl/fast/forms/menulist-narrow-width-expected.txt:
  • platform/efl/fast/forms/menulist-no-overflow-expected.txt:
  • platform/efl/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/menulist-separator-painting-expected.txt:
  • platform/efl/fast/forms/menulist-style-color-expected.txt:
  • platform/efl/fast/forms/menulist-width-change-expected.txt:
  • platform/efl/fast/forms/minWidthPercent-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/efl/fast/forms/option-script-expected.txt:
  • platform/efl/fast/forms/option-strip-whitespace-expected.txt:
  • platform/efl/fast/forms/option-text-clip-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/forms/select-align-expected.txt:
  • platform/efl/fast/forms/select-background-none-expected.txt:
  • platform/efl/fast/forms/select-baseline-expected.txt:
  • platform/efl/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/efl/fast/forms/select-initial-position-expected.txt:
  • platform/efl/fast/forms/select-selected-expected.txt:
  • platform/efl/fast/forms/select-size-expected.txt:
  • platform/efl/fast/forms/select-style-expected.txt:
  • platform/efl/fast/forms/select-visual-hebrew-expected.txt:
  • platform/efl/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/efl/fast/forms/selectlist-minsize-expected.txt:
  • platform/efl/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/forms/text-style-color-expected.txt:
  • platform/efl/fast/forms/textAreaLineHeight-expected.txt:
  • platform/efl/fast/forms/textarea-align-expected.txt:
  • platform/efl/fast/forms/textarea-scroll-height-expected.txt:
  • platform/efl/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/efl/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/efl/fast/forms/textarea-width-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/html/details-no-summary4-expected.txt:
  • platform/efl/fast/html/details-open-javascript-expected.txt:
  • platform/efl/fast/html/details-open2-expected.txt:
  • platform/efl/fast/html/details-open4-expected.txt:
  • platform/efl/fast/html/details-replace-summary-child-expected.txt:
  • platform/efl/fast/html/details-replace-text-expected.txt:
  • platform/efl/fast/html/keygen-expected.txt:
  • platform/efl/fast/invalid/014-expected.txt:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/efl/fast/overflow/overflow-x-y-expected.txt:
  • platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/parser/document-write-option-expected.txt:
  • platform/efl/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/efl/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/efl/fast/replaced/three-selects-break-expected.txt:
  • platform/efl/fast/replaced/width100percent-button-expected.txt:
  • platform/efl/fast/replaced/width100percent-menulist-expected.txt:
  • platform/efl/fast/replaced/width100percent-textarea-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/efl/test_expectations.txt:
  • platform/efl/transforms/2d/zoom-menulist-expected.txt:
6:34 AM Changeset in webkit [116760] by kov@webkit.org
  • 8 edits in trunk

REGRESSION(r116205): [GTK]: build no longer supports thin archives
​https://bugs.webkit.org/show_bug.cgi?id=86207

Source/WebCore:

  • GNUmakefile.am: go back to not linking libWebCoreModules into

libWebCore; when linking 2 convenience libraries libtools tries to
extract the object files from one of them to add to the other, breaking
thin archive builds

Source/WebKit/gtk:

  • GNUmakefile.am: link libWebCoreModules into the webkitgtk shared

library.

Source/WebKit2:

  • GNUmakefile.am: link libWebCoreModules to the webkit2gtk shared

library; tell the linker to ignore internal unresolved symbols for
PluginProcess and avoid linking libWebCoreModules.

Tools:

  • GNUmakefile.am: link libWebCoreModules to DRT.
6:33 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
Qt5 r26+ configure -sysroot bug workaround (diff)
6:32 AM Changeset in webkit [116759] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Assertion failure in ietestcenter/css3/valuesandunits/units-000.htm
​https://bugs.webkit.org/show_bug.cgi?id=86208

Not reviewed.

  • platform/mac/Skipped:
6:25 AM Changeset in webkit [116758] by commit-queue@webkit.org
  • 3 edits in trunk

[BlackBerry] Update DumpRenderTree.cpp to also run ref-tests if there're any
​https://bugs.webkit.org/show_bug.cgi?id=86055

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-05-11
Reviewed by Rob Buis.

Ref-tests are tests with suffix "-expected", "-expected-mismatch" and a valid
extension(".html", ".htm", etc.).
Currently torch-launcher only run tests parsed by NRWT, with ref-tests
excluded. As a result, if a test have ref-tests (which were not run), our
DumpRenderTree Perl script will think there's a crash and exit with code 1.
So NRWT will report the result as CRASH.
We need to update DumpRenderTree.cpp to try to find ref-tests and run them.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::getRefTests):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::runTests):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

6:04 AM Changeset in webkit [116757] by keishi@webkit.org
  • 7 edits in trunk

Sanitization algorithm for input type=email should strip whitespaces
​https://bugs.webkit.org/show_bug.cgi?id=86177

Reviewed by Kent Tamura.

Source/WebCore:

No new tests. Covered by: fast/forms/ValidityState-typeMismatch-email.html

The spec says that the value sanitization algorithm should

Strip line breaks from the value, then strip leading and trailing whitespace from the value.

  • html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue):

LayoutTests:

  • fast/forms/ValidityState-typeMismatch-email-expected.txt:
  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:
  • fast/forms/resources/ValidityState-typeMismatch-email.js:
5:56 AM Changeset in webkit [116756] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

Unreviewed, rolling out r116752.
​http://trac.webkit.org/changeset/116752
​https://bugs.webkit.org/show_bug.cgi?id=86201

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

  • html/FormAssociatedElement.cpp:
  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::setCustomValidity):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue):
(WebCore::HTMLInputElement::typeMismatch):
(WebCore::HTMLInputElement::valueMissing):
(WebCore::HTMLInputElement::patternMismatch):
(WebCore::HTMLInputElement::rangeUnderflow):
(WebCore::HTMLInputElement::rangeOverflow):
(WebCore::HTMLInputElement::minimum):
(WebCore::HTMLInputElement::maximum):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::minimumString):
(WebCore::HTMLInputElement::maximumString):
(WebCore):
(WebCore::HTMLInputElement::stepBaseString):
(WebCore::HTMLInputElement::stepString):
(WebCore::HTMLInputElement::typeMismatchText):
(WebCore::HTMLInputElement::valueMissingText):
(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLObjectElement.h:

(WebCore::HTMLObjectElement::setCustomValidity):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::valueMissing):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing):
(HTMLTextAreaElement):

  • html/InputType.cpp:

(WebCore::InputType::alignValueForStep):
(WebCore::InputType::stepUpFromRenderer):

  • html/InputType.h:

(InputType):

  • html/ValidityState.cpp:

(WebCore::ValidityState::validationMessage):
(WebCore):
(WebCore::ValidityState::setCustomErrorMessage):
(WebCore::ValidityState::valueMissing):
(WebCore::ValidityState::typeMismatch):
(WebCore::ValidityState::patternMismatch):
(WebCore::ValidityState::tooLong):
(WebCore::ValidityState::rangeUnderflow):
(WebCore::ValidityState::rangeOverflow):
(WebCore::ValidityState::stepMismatch):
(WebCore::ValidityState::customError):
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState):

5:47 AM Changeset in webkit [116755] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Search box doesn't allow CSS selectors anymore
​https://bugs.webkit.org/show_bug.cgi?id=86196

Reviewed by Pavel Feldman.

Source/WebCore:

Refactoring in ​http://trac.webkit.org/changeset/99983 inadvertently removed the selector matching during
node search in the InspectorDOMAgent. This change re-introduces the Document::querySelectorAll() evaluation
for the user query.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
5:45 AM Changeset in webkit [116754] by inferno@chromium.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r116527.
​http://trac.webkit.org/changeset/116527
​https://bugs.webkit.org/show_bug.cgi?id=86199

Causing crashes on ClusterFuzz (Requested by inferno-sec on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarPart):

  • rendering/RenderScrollbarPart.h:

LayoutTests:

  • scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed.
  • scrollbars/scrollbar-percent-padding-crash.html: Removed.
5:41 AM Changeset in webkit [116753] by tkent@chromium.org
  • 2 edits
    1 move
    2 deletes in trunk/LayoutTests

[Chromium] Update wrong expectations.

  • platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
5:39 AM Changeset in webkit [116752] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[Forms] Move ValidityState methods implementation to another place
​https://bugs.webkit.org/show_bug.cgi?id=86058

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-05-11
Reviewed by Kent Tamura.

This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.

Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.

No new tests. This patch doesn't change behavior.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added. set custom error message.

  • html/FormAssociatedElement.h:

(FormAssociatedElement): Added new instance value m_customValidationMessage.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing): Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.

  • html/HTMLInputElement.h:

(HTMLInputElement): Make tooLong method private.

  • html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Added entries for newly added methods.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.

  • html/InputType.cpp:

(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep): Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer): Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added. Moved from HTMLInputElement.

  • html/InputType.h:

(InputType): Added entries for newly added methods and update methods signature.

  • html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.

(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):

  • html/ValidityState.h:

(ValidityState): Remove custom validation message related things.

5:14 AM Changeset in webkit [116751] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix a build error without SVG, introduced by tab-size support.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

5:06 AM Changeset in webkit [116750] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening failure cases on EFL build bot
​https://bugs.webkit.org/show_bug.cgi?id=86192

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-11

  • platform/efl/test_expectations.txt:
4:52 AM Changeset in webkit [116749] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure cases on editing/style and editing/pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=86184

Unreviewed EFL gardening.

Test expectations update.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2012-05-11

  • platform/efl/test_expectations.txt: adding tests regarding to missing beginDragWithFiles

execCommand('copy') and execCommand('paste') implementation.

4:43 AM Changeset in webkit [116748] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] fast/css/getComputedStyle/computed-style-without-renderer.html fails on EFL
​https://bugs.webkit.org/show_bug.cgi?id=86190

Unreviewed, EFL rebaseline after r116723.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-11

  • platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:23 AM Changeset in webkit [116747] by tkent@chromium.org
  • 32 edits
    1 copy
    4 moves
    7 adds
    12 deletes in trunk/LayoutTests

[Chromium] Rebaseline for some tests, and optimization.

  • fast/block/float/032-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/032-expected.txt.
  • fast/forms/input-appearance-bkcolor-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-appearance-bkcolor-expected.txt.
  • fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/platform/efl/fast/images/color-jpeg-with-color-profile-expected.png.
  • platform/chromium-linux-x86/fast/forms/date/date-appearance-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/032-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/text-style-color-expected.txt: Removed.
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/032-expected.txt: Removed.
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
  • platform/gtk/fast/images/color-jpeg-with-color-profile-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt: Removed.
  • tables/mozilla/bugs/bug99948-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug99948-expected.txt.
4:11 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:10 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
3:36 AM Changeset in webkit [116746] by shinyak@chromium.org
  • 10 edits in trunk/Source/WebCore

[Refactoring] Move Selection from DOMWindow to TreeScope.
​https://bugs.webkit.org/show_bug.cgi?id=82699

Reviewed by Ryosuke Niwa.

Since ShadowRoot will also manage its own version of DOMSelection, we would like to
share the code among Document and DOMSelection. This patch moves DOMSelection from DOMWindow to TreeScope
so that ShadowRoot can also use it.

No new tests, should covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::updateFocusAppearanceTimerFired):

  • dom/Document.h:

(Document):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::getSelection):
(WebCore):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::clearTreeScope):
(WebCore):

  • page/DOMSelection.h:

(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):

  • page/DOMWindow.h:

(DOMWindow):

3:26 AM Changeset in webkit [116745] by morrita@google.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix attempt.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

2:55 AM Changeset in webkit [116744] by yurys@chromium.org
  • 23 edits in trunk/Source/WebCore

Web Inspector: console should allow JS execution in the context of an isolated world
​https://bugs.webkit.org/show_bug.cgi?id=85612

Reviewed by Pavel Feldman.

Added an option to select not only a frame but also isolated world in which
to perform evaluation of the code typed into the console.

Each execution context can be identified using it injected script id. We call it
execution context id in the protocol. Runtime agent is extended with an event that
is sent when new ExecutionContext is created. The event tracking can be enabled/disabled
using setReportExecutionContextCreation command.

  • bindings/js/ScriptController.cpp:

(WebCore):
(WebCore::isolatedWorldToSecurityOriginMap):

  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/js/ScriptState.cpp:

(WebCore::isolatedWorldScriptState):
(WebCore):

  • bindings/js/ScriptState.h:

(WebCore):

  • bindings/v8/ScriptController.cpp:

(WebCore):
(WebCore::ScriptController::isolatedWorldToSecurityOriginMap):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptState.cpp:

(WebCore::isolatedWorldScriptState):
(WebCore):

  • bindings/v8/ScriptState.h:

(WebCore):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::setSecurityOrigin):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setIsolatedWorldSecurityOrigin):
(WebCore::V8Proxy::isolatedWorldContext):
(WebCore):
(WebCore::V8Proxy::isolatedWorldToSecurityOriginMap):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateIsolatedContextImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateIsolatedContext):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::pageRuntimeAgent):
(WebCore::InstrumentingAgents::setPageRuntimeAgent):
(InstrumentingAgents):

  • inspector/PageRuntimeAgent.cpp:

(PageRuntimeAgentState):
(WebCore):
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore::PageRuntimeAgent::setReportExecutionContextCreation):
(WebCore::PageRuntimeAgent::didCreateExecutionContext):
(WebCore::PageRuntimeAgent::getScriptStateForEval):

  • inspector/PageRuntimeAgent.h:

(WebCore):
(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::setReportExecutionContextCreation):
(WebCore::WorkerRuntimeAgent::getScriptStateForEval):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype._currentEvaluationContextId):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedWorldId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane.prototype.setExpression):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype._didLoadCachedResources):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.isolatedContextCreated):
(WebInspector.ExecutionContext):
(WebInspector.ExecutionContext.comparator):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext):
(WebInspector.FrameEvaluationContext.prototype._ensureMainWorldContextAdded):
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts):

2:35 AM Changeset in webkit [116743] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
​https://bugs.webkit.org/show_bug.cgi?id=86188

Reviewed by Yury Semikhatsky.

Source/WebCore:

We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
within _treeElementFromEvent(), which returns 0 for inline elements.

  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node):

LayoutTests:

  • inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.
2:28 AM Changeset in webkit [116742] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Inline Node::traverseNextNode
​https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.

In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.

Performance bots will tell if this was worthwhile.

  • dom/ContainerNode.h:

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

  • dom/Node.cpp:

(WebCore::Node::traverseNextAncestorSibling):

  • dom/Node.h:

(Node):

  • bindings/v8/RetainedDOMInfo.cpp:
2:05 AM Changeset in webkit [116741] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/test_expectations.txt:
1:42 AM Changeset in webkit [116740] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
​https://bugs.webkit.org/show_bug.cgi?id=85708

Reviewed by Pavel Feldman.

Instead of calling emitCommitLoadIfNeeded after all agents are restored
required actions are performed directly in the restore() methods.

  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:

(WebCore::InspectorAgent::didCommitLoadFired):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::restore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::restore):

1:29 AM Changeset in webkit [116739] by caseq@chromium.org
  • 11 edits in trunk

Web Inspector: [Extensions API] add audit formatters for remote objects and DOM elements
​https://bugs.webkit.org/show_bug.cgi?id=86108

Reviewed by Pavel Feldman.

Source/WebCore:

  • added two new formatters to AuditResults object of webInspector.audits API;
  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.resourceLink):
(WebInspector.AuditFormatters.object.onEvaluate):
(WebInspector.AuditFormatters.object): format as a remote object property list;
(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node.onEvaluate):
(WebInspector.AuditFormatters.node): format as a DOM elements sub-tree;
(WebInspector.AuditFormatters.Utilities.evaluate): common expression evaluation logic for both new formatters;

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.AuditResultImpl):

  • inspector/front-end/auditsPanel.css:

(.audit-result-tree ol.outline-disclosure):
(.audit-result-tree .section .header):
(.audit-result-tree .section .header::before):

LayoutTests:

  • rebaselined tests to account for two new AuditResults method and their results;
  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-audits-tests.js:

(initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):

  • inspector/extensions/extensions-audits.html:
1:14 AM Changeset in webkit [116738] by Carlos Garcia Campos
  • 9 edits
    2 adds in trunk/Source/WebKit2

[SOUP] Allow sending URI request data in chunks
​https://bugs.webkit.org/show_bug.cgi?id=85880

Reviewed by Martin Robinson.

The API to handle custom URI schemes will receive an input stream
to read from. Current code requires to buffer the whole stream
before sending it to the WebProcess. This patch allows to send the
data in chunks while it's read from the stream.

  • GNUmakefile.list.am: Add new files to compilation
  • UIProcess/API/C/soup/WKSoupRequestManager.cpp:

(WKSoupRequestManagerRegisterURIScheme): Use toWTFString() to
convert from WKString to WTFString.
(WKSoupRequestManagerDidHandleURIRequest): Use didHandleURIRequest
as it has been renamed.
(WKSoupRequestManagerDidReceiveURIRequestData): New method to send
more data for the uri request to the web process.

  • UIProcess/API/C/soup/WKSoupRequestManager.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
HandleURIRequest has been renamed to DidHandleURIRequest.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Send DidReceiveURIRequestData message to the web process.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest): Use
didHandleURIRequest as it has been renamed.

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/soup/WebKitSoupRequestInputStream.cpp: Added.

(AsyncReadData::AsyncReadData): Helper struct to store information
about pending async read operations.
(_WebKitSoupRequestInputStreamPrivate):
(webkitSoupRequestInputStreamReadAsyncResultComplete): Read the
data from the memory input stream and complete the async read
operation.
(webkitSoupRequestInputStreamReadAsync): Read the data from the
memory input stream and complete the async read operation if
there's data to read, or save the async result to be completed
when more data is added to the stream.
(webkitSoupRequestInputStreamReadFinish): Finish an async read
started with webkitSoupRequestInputStreamReadAsync.
(webkitSoupRequestInputStreamFinalize):
(webkit_soup_request_input_stream_init):
(webkit_soup_request_input_stream_class_init):
(webkitSoupRequestInputStreamNew): Create a new input stream with
a fixed size or 0 if content length is not known.
(webkitSoupRequestInputStreamAddData): Add more data to the
stream and complete any pending async read.
(webkitSoupRequestInputStreamFinished): Whether all data expected
by the stream has been received.

  • WebProcess/soup/WebKitSoupRequestInputStream.h: Added.
  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::didHandleURIRequest): Create a
WebKitSoupRequestInputStream if we haven't received all the
request data in the HandleURIRequest message. Otherwise just
create a memory input stream with all the data.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): Add the data
received to the WebKitSoupRequestInputStream associated to the
given request identifier.

  • WebProcess/soup/WebSoupRequestManager.h:
  • WebProcess/soup/WebSoupRequestManager.messages.in: Add

contentLength parameter to DidHandleURIRequest message and add
DidReceiveURIRequestData message.

12:53 AM Changeset in webkit [116737] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
12:33 AM Changeset in webkit [116736] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r116727.
​http://trac.webkit.org/changeset/116727
​https://bugs.webkit.org/show_bug.cgi?id=86181

Build error on Chromium-Android (Requested by tkent on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::enterFullscreen):
(WebCore):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::exitFullscreen):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enterFullScreenForElement):

12:16 AM Changeset in webkit [116735] by morrita@google.com
  • 4 edits in trunk/LayoutTests

Unreviewed expectation update.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
12:11 AM Changeset in webkit [116734] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed gardening.

  • fast/css/getComputedStyle/computed-style-expected.txt: Updated after r116723.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r116723.
  • platform/qt/Skipped: Skip new crashing and failing tests.
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r116723.
12:00 AM Changeset in webkit [116733] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r116731.
​http://trac.webkit.org/changeset/116731
​https://bugs.webkit.org/show_bug.cgi?id=86178

Build failure on Chromium-mac (Requested by tkent on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-11

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore):
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

Note: See TracTimeline for information about the timeline view.